{"action":"created","comment":{"url":"https://api.github.com/repos/SuperTux/supertux/pulls/comments/200418544","pull_request_review_id":134731859,"id":200418544,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDQxODU0NA==","diff_hunk":"@@ -330,7 +330,8 @@ ScreenManager::handle_screen_switch()\n \n       // move actions to a new vector since setup() might modify it\n       auto actions = std::move(m_actions);\n-\n+      bool quitactiontriggered = false;","path":"src/supertux/screen_manager.cpp","position":5,"original_position":5,"commit_id":"0192c6c20f31e84c468b7413db469c0ecb1acfc9","original_commit_id":"0192c6c20f31e84c468b7413db469c0ecb1acfc9","user":{"login":"christ2go","id":8479239,"node_id":"MDQ6VXNlcjg0NzkyMzk=","avatar_url":"https://avatars0.githubusercontent.com/u/8479239?v=4","gravatar_id":"","url":"https://api.github.com/users/christ2go","html_url":"https://github.com/christ2go","followers_url":"https://api.github.com/users/christ2go/followers","following_url":"https://api.github.com/users/christ2go/following{/other_user}","gists_url":"https://api.github.com/users/christ2go/gists{/gist_id}","starred_url":"https://api.github.com/users/christ2go/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christ2go/subscriptions","organizations_url":"https://api.github.com/users/christ2go/orgs","repos_url":"https://api.github.com/users/christ2go/repos","events_url":"https://api.github.com/users/christ2go/events{/privacy}","received_events_url":"https://api.github.com/users/christ2go/received_events","type":"User","site_admin":false},"body":"Can you use a variable name which is better to read? (Maybe camel-case or use _). ","created_at":"2018-07-05T16:43:17Z","updated_at":"2018-07-05T16:45:09Z","html_url":"https://github.com/SuperTux/supertux/pull/861#discussion_r200418544","pull_request_url":"https://api.github.com/repos/SuperTux/supertux/pulls/861","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/SuperTux/supertux/pulls/comments/200418544"},"html":{"href":"https://github.com/SuperTux/supertux/pull/861#discussion_r200418544"},"pull_request":{"href":"https://api.github.com/repos/SuperTux/supertux/pulls/861"}}},"pull_request":{"url":"https://api.github.com/repos/SuperTux/supertux/pulls/861","id":198827173,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4ODI3MTcz","html_url":"https://github.com/SuperTux/supertux/pull/861","diff_url":"https://github.com/SuperTux/supertux/pull/861.diff","patch_url":"https://github.com/SuperTux/supertux/pull/861.patch","issue_url":"https://api.github.com/repos/SuperTux/supertux/issues/861","number":861,"state":"open","locked":false,"title":"Fixed buffer overflow on game termination","user":{"login":"InsightGit","id":13735132,"node_id":"MDQ6VXNlcjEzNzM1MTMy","avatar_url":"https://avatars0.githubusercontent.com/u/13735132?v=4","gravatar_id":"","url":"https://api.github.com/users/InsightGit","html_url":"https://github.com/InsightGit","followers_url":"https://api.github.com/users/InsightGit/followers","following_url":"https://api.github.com/users/InsightGit/following{/other_user}","gists_url":"https://api.github.com/users/InsightGit/gists{/gist_id}","starred_url":"https://api.github.com/users/InsightGit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/InsightGit/subscriptions","organizations_url":"https://api.github.com/users/InsightGit/orgs","repos_url":"https://api.github.com/users/InsightGit/repos","events_url":"https://api.github.com/users/InsightGit/events{/privacy}","received_events_url":"https://api.github.com/users/InsightGit/received_events","type":"User","site_admin":false},"body":"This pull request fixes a buffer overflow that occurred on game termination, as reported by Issue #671. This overflow was caused from the QUIT_ACTION clearing the entirety of the m_screen_stack stack. However, the code that dealt with the last screen in that screen stack was still being executed after that QUIT_ACTION code was executed, causing a buffer overflow from trying to get the back of an empty vector.\r\n\r\nCloses #671 ","created_at":"2018-07-03T01:26:09Z","updated_at":"2018-07-05T16:45:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"529358fa4e46ff224fc462ebbb8ca75173342f9d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SuperTux/supertux/pulls/861/commits","review_comments_url":"https://api.github.com/repos/SuperTux/supertux/pulls/861/comments","review_comment_url":"https://api.github.com/repos/SuperTux/supertux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SuperTux/supertux/issues/861/comments","statuses_url":"https://api.github.com/repos/SuperTux/supertux/statuses/0192c6c20f31e84c468b7413db469c0ecb1acfc9","head":{"label":"InsightGit:bufferoverflowclose","ref":"bufferoverflowclose","sha":"0192c6c20f31e84c468b7413db469c0ecb1acfc9","user":{"login":"InsightGit","id":13735132,"node_id":"MDQ6VXNlcjEzNzM1MTMy","avatar_url":"https://avatars0.githubusercontent.com/u/13735132?v=4","gravatar_id":"","url":"https://api.github.com/users/InsightGit","html_url":"https://github.com/InsightGit","followers_url":"https://api.github.com/users/InsightGit/followers","following_url":"https://api.github.com/users/InsightGit/following{/other_user}","gists_url":"https://api.github.com/users/InsightGit/gists{/gist_id}","starred_url":"https://api.github.com/users/InsightGit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/InsightGit/subscriptions","organizations_url":"https://api.github.com/users/InsightGit/orgs","repos_url":"https://api.github.com/users/InsightGit/repos","events_url":"https://api.github.com/users/InsightGit/events{/privacy}","received_events_url":"https://api.github.com/users/InsightGit/received_events","type":"User","site_admin":false},"repo":{"id":138775348,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg3NzUzNDg=","name":"supertux","full_name":"InsightGit/supertux","owner":{"login":"InsightGit","id":13735132,"node_id":"MDQ6VXNlcjEzNzM1MTMy","avatar_url":"https://avatars0.githubusercontent.com/u/13735132?v=4","gravatar_id":"","url":"https://api.github.com/users/InsightGit","html_url":"https://github.com/InsightGit","followers_url":"https://api.github.com/users/InsightGit/followers","following_url":"https://api.github.com/users/InsightGit/following{/other_user}","gists_url":"https://api.github.com/users/InsightGit/gists{/gist_id}","starred_url":"https://api.github.com/users/InsightGit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/InsightGit/subscriptions","organizations_url":"https://api.github.com/users/InsightGit/orgs","repos_url":"https://api.github.com/users/InsightGit/repos","events_url":"https://api.github.com/users/InsightGit/events{/privacy}","received_events_url":"https://api.github.com/users/InsightGit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/InsightGit/supertux","description":"SuperTux source code","fork":true,"url":"https://api.github.com/repos/InsightGit/supertux","forks_url":"https://api.github.com/repos/InsightGit/supertux/forks","keys_url":"https://api.github.com/repos/InsightGit/supertux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/InsightGit/supertux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/InsightGit/supertux/teams","hooks_url":"https://api.github.com/repos/InsightGit/supertux/hooks","issue_events_url":"https://api.github.com/repos/InsightGit/supertux/issues/events{/number}","events_url":"https://api.github.com/repos/InsightGit/supertux/events","assignees_url":"https://api.github.com/repos/InsightGit/supertux/assignees{/user}","branches_url":"https://api.github.com/repos/InsightGit/supertux/branches{/branch}","tags_url":"https://api.github.com/repos/InsightGit/supertux/tags","blobs_url":"https://api.github.com/repos/InsightGit/supertux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/InsightGit/supertux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/InsightGit/supertux/git/refs{/sha}","trees_url":"https://api.github.com/repos/InsightGit/supertux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/InsightGit/supertux/statuses/{sha}","languages_url":"https://api.github.com/repos/InsightGit/supertux/languages","stargazers_url":"https://api.github.com/repos/InsightGit/supertux/stargazers","contributors_url":"https://api.github.com/repos/InsightGit/supertux/contributors","subscribers_url":"https://api.github.com/repos/InsightGit/supertux/subscribers","subscription_url":"https://api.github.com/repos/InsightGit/supertux/subscription","commits_url":"https://api.github.com/repos/InsightGit/supertux/commits{/sha}","git_commits_url":"https://api.github.com/repos/InsightGit/supertux/git/commits{/sha}","comments_url":"https://api.github.com/repos/InsightGit/supertux/comments{/number}","issue_comment_url":"https://api.github.com/repos/InsightGit/supertux/issues/comments{/number}","contents_url":"https://api.github.com/repos/InsightGit/supertux/contents/{+path}","compare_url":"https://api.github.com/repos/InsightGit/supertux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/InsightGit/supertux/merges","archive_url":"https://api.github.com/repos/InsightGit/supertux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/InsightGit/supertux/downloads","issues_url":"https://api.github.com/repos/InsightGit/supertux/issues{/number}","pulls_url":"https://api.github.com/repos/InsightGit/supertux/pulls{/number}","milestones_url":"https://api.github.com/repos/InsightGit/supertux/milestones{/number}","notifications_url":"https://api.github.com/repos/InsightGit/supertux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/InsightGit/supertux/labels{/name}","releases_url":"https://api.github.com/repos/InsightGit/supertux/releases{/id}","deployments_url":"https://api.github.com/repos/InsightGit/supertux/deployments","created_at":"2018-06-26T18:06:41Z","updated_at":"2018-06-27T02:35:39Z","pushed_at":"2018-07-03T00:59:20Z","git_url":"git://github.com/InsightGit/supertux.git","ssh_url":"git@github.com:InsightGit/supertux.git","clone_url":"https://github.com/InsightGit/supertux.git","svn_url":"https://github.com/InsightGit/supertux","homepage":"https://supertux.org","size":354785,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SuperTux:master","ref":"master","sha":"2e3757db981adb089b2e576edf50e54db14c8d8d","user":{"login":"SuperTux","id":6020189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMjAxODk=","avatar_url":"https://avatars2.githubusercontent.com/u/6020189?v=4","gravatar_id":"","url":"https://api.github.com/users/SuperTux","html_url":"https://github.com/SuperTux","followers_url":"https://api.github.com/users/SuperTux/followers","following_url":"https://api.github.com/users/SuperTux/following{/other_user}","gists_url":"https://api.github.com/users/SuperTux/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperTux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperTux/subscriptions","organizations_url":"https://api.github.com/users/SuperTux/orgs","repos_url":"https://api.github.com/users/SuperTux/repos","events_url":"https://api.github.com/users/SuperTux/events{/privacy}","received_events_url":"https://api.github.com/users/SuperTux/received_events","type":"Organization","site_admin":false},"repo":{"id":14650917,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY1MDkxNw==","name":"supertux","full_name":"SuperTux/supertux","owner":{"login":"SuperTux","id":6020189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMjAxODk=","avatar_url":"https://avatars2.githubusercontent.com/u/6020189?v=4","gravatar_id":"","url":"https://api.github.com/users/SuperTux","html_url":"https://github.com/SuperTux","followers_url":"https://api.github.com/users/SuperTux/followers","following_url":"https://api.github.com/users/SuperTux/following{/other_user}","gists_url":"https://api.github.com/users/SuperTux/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperTux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperTux/subscriptions","organizations_url":"https://api.github.com/users/SuperTux/orgs","repos_url":"https://api.github.com/users/SuperTux/repos","events_url":"https://api.github.com/users/SuperTux/events{/privacy}","received_events_url":"https://api.github.com/users/SuperTux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SuperTux/supertux","description":"SuperTux source code","fork":false,"url":"https://api.github.com/repos/SuperTux/supertux","forks_url":"https://api.github.com/repos/SuperTux/supertux/forks","keys_url":"https://api.github.com/repos/SuperTux/supertux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SuperTux/supertux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SuperTux/supertux/teams","hooks_url":"https://api.github.com/repos/SuperTux/supertux/hooks","issue_events_url":"https://api.github.com/repos/SuperTux/supertux/issues/events{/number}","events_url":"https://api.github.com/repos/SuperTux/supertux/events","assignees_url":"https://api.github.com/repos/SuperTux/supertux/assignees{/user}","branches_url":"https://api.github.com/repos/SuperTux/supertux/branches{/branch}","tags_url":"https://api.github.com/repos/SuperTux/supertux/tags","blobs_url":"https://api.github.com/repos/SuperTux/supertux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SuperTux/supertux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SuperTux/supertux/git/refs{/sha}","trees_url":"https://api.github.com/repos/SuperTux/supertux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SuperTux/supertux/statuses/{sha}","languages_url":"https://api.github.com/repos/SuperTux/supertux/languages","stargazers_url":"https://api.github.com/repos/SuperTux/supertux/stargazers","contributors_url":"https://api.github.com/repos/SuperTux/supertux/contributors","subscribers_url":"https://api.github.com/repos/SuperTux/supertux/subscribers","subscription_url":"https://api.github.com/repos/SuperTux/supertux/subscription","commits_url":"https://api.github.com/repos/SuperTux/supertux/commits{/sha}","git_commits_url":"https://api.github.com/repos/SuperTux/supertux/git/commits{/sha}","comments_url":"https://api.github.com/repos/SuperTux/supertux/comments{/number}","issue_comment_url":"https://api.github.com/repos/SuperTux/supertux/issues/comments{/number}","contents_url":"https://api.github.com/repos/SuperTux/supertux/contents/{+path}","compare_url":"https://api.github.com/repos/SuperTux/supertux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SuperTux/supertux/merges","archive_url":"https://api.github.com/repos/SuperTux/supertux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SuperTux/supertux/downloads","issues_url":"https://api.github.com/repos/SuperTux/supertux/issues{/number}","pulls_url":"https://api.github.com/repos/SuperTux/supertux/pulls{/number}","milestones_url":"https://api.github.com/repos/SuperTux/supertux/milestones{/number}","notifications_url":"https://api.github.com/repos/SuperTux/supertux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SuperTux/supertux/labels{/name}","releases_url":"https://api.github.com/repos/SuperTux/supertux/releases{/id}","deployments_url":"https://api.github.com/repos/SuperTux/supertux/deployments","created_at":"2013-11-23T21:40:12Z","updated_at":"2018-07-04T21:56:55Z","pushed_at":"2018-07-04T21:56:47Z","git_url":"git://github.com/SuperTux/supertux.git","ssh_url":"git@github.com:SuperTux/supertux.git","clone_url":"https://github.com/SuperTux/supertux.git","svn_url":"https://github.com/SuperTux/supertux","homepage":"https://supertux.org","size":354842,"stargazers_count":646,"watchers_count":646,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":154,"mirror_url":null,"archived":false,"open_issues_count":179,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":154,"open_issues":179,"watchers":646,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SuperTux/supertux/pulls/861"},"html":{"href":"https://github.com/SuperTux/supertux/pull/861"},"issue":{"href":"https://api.github.com/repos/SuperTux/supertux/issues/861"},"comments":{"href":"https://api.github.com/repos/SuperTux/supertux/issues/861/comments"},"review_comments":{"href":"https://api.github.com/repos/SuperTux/supertux/pulls/861/comments"},"review_comment":{"href":"https://api.github.com/repos/SuperTux/supertux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SuperTux/supertux/pulls/861/commits"},"statuses":{"href":"https://api.github.com/repos/SuperTux/supertux/statuses/0192c6c20f31e84c468b7413db469c0ecb1acfc9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"christ2go"}}