{"action":"created","comment":{"url":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/comments/231315579","pull_request_review_id":172261412,"id":231315579,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTMxNTU3OQ==","diff_hunk":"@@ -606,14 +567,14 @@ export class ExtensionView extends VDomRenderer<ListModel> {\n \n       content.push(\n         <CollapsibleSection\n-          header={model.query ? 'Search Results' : 'Discover'}\n           key=\"search-section\"\n-          startCollapsed={true}\n-          onCollapse={(collapsed: boolean) => {\n-            if (!collapsed && model.query === null) {\n-              model.query = '';\n-            }\n-          }}\n+          isOpen={false}\n+          header={model.query ? 'Search Results' : 'Discover'}\n+          // onCollapse={(collapsed: boolean) => {","path":"packages/extensionmanager/src/widget.tsx","position":408,"original_position":408,"commit_id":"6f1be0a45606bbb54044f71ba87336bb0d35a081","original_commit_id":"6f1be0a45606bbb54044f71ba87336bb0d35a081","user":{"login":"saulshanabrook","id":1186124,"node_id":"MDQ6VXNlcjExODYxMjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1186124?v=4","gravatar_id":"","url":"https://api.github.com/users/saulshanabrook","html_url":"https://github.com/saulshanabrook","followers_url":"https://api.github.com/users/saulshanabrook/followers","following_url":"https://api.github.com/users/saulshanabrook/following{/other_user}","gists_url":"https://api.github.com/users/saulshanabrook/gists{/gist_id}","starred_url":"https://api.github.com/users/saulshanabrook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saulshanabrook/subscriptions","organizations_url":"https://api.github.com/users/saulshanabrook/orgs","repos_url":"https://api.github.com/users/saulshanabrook/repos","events_url":"https://api.github.com/users/saulshanabrook/events{/privacy}","received_events_url":"https://api.github.com/users/saulshanabrook/received_events","type":"User","site_admin":false},"body":"Looks like this should be deleted.\n\nNot exactly sure what this original logic was for. Seems like it is setting the query to `''` if it was `null`?\n\nDid you move this logic somewhere else?","created_at":"2018-11-06T22:20:25Z","updated_at":"2018-11-06T22:20:25Z","html_url":"https://github.com/jupyterlab/jupyterlab/pull/5538#discussion_r231315579","pull_request_url":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/5538","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/comments/231315579"},"html":{"href":"https://github.com/jupyterlab/jupyterlab/pull/5538#discussion_r231315579"},"pull_request":{"href":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/5538"}}},"pull_request":{"url":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/5538","id":226189923,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MTg5OTIz","html_url":"https://github.com/jupyterlab/jupyterlab/pull/5538","diff_url":"https://github.com/jupyterlab/jupyterlab/pull/5538.diff","patch_url":"https://github.com/jupyterlab/jupyterlab/pull/5538.patch","issue_url":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/5538","number":5538,"state":"open","locked":false,"title":"[WIP] Add @jupyterlab/ui-components package","user":{"login":"gnestor","id":512354,"node_id":"MDQ6VXNlcjUxMjM1NA==","avatar_url":"https://avatars3.githubusercontent.com/u/512354?v=4","gravatar_id":"","url":"https://api.github.com/users/gnestor","html_url":"https://github.com/gnestor","followers_url":"https://api.github.com/users/gnestor/followers","following_url":"https://api.github.com/users/gnestor/following{/other_user}","gists_url":"https://api.github.com/users/gnestor/gists{/gist_id}","starred_url":"https://api.github.com/users/gnestor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnestor/subscriptions","organizations_url":"https://api.github.com/users/gnestor/orgs","repos_url":"https://api.github.com/users/gnestor/repos","events_url":"https://api.github.com/users/gnestor/events{/privacy}","received_events_url":"https://api.github.com/users/gnestor/received_events","type":"User","site_admin":false},"body":"This work is a first shot at https://github.com/jupyterlab/jupyterlab/issues/5170 and continuation of https://github.com/jupyterlab/jupyterlab/pull/4234\r\n\r\nThis package will provide React components that other lab extensions can consume to easily create UIs within lab. \r\n\r\nInitially, this PR:\r\n\r\n* Imports [blueprint](https://github.com/palantir/blueprint) components and exports them with a CSS class name applied \r\n* Imports the blueprint CSS and a custom CSS file that will allow us to define styles for individual components (e.g. `jp-Button`). We don't have to define styles from scratch since the blueprint CSS is applied, we just need to override styles in our own classes.\r\n\r\nTo contribute to this PR:\r\n\r\n* Add my remote/fork: `git remote add gnestor https://github.com/gnestor/jupyterlab.git`\r\n* Fetch my remote: `git fetch gnestor`\r\n* Checkout this branch: `git checkout gnestor/ui-components`\r\n* Install dependencies: `jlpm`\r\n* Watch the source: `jlpm watch`\r\n* Launch lab in dev and watch mode: `jupyter lab --dev --watch`","created_at":"2018-10-26T18:39:07Z","updated_at":"2018-11-06T22:20:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7d747940fcab131f343510b2aca880bda1692f4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/5538/commits","review_comments_url":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/5538/comments","review_comment_url":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/5538/comments","statuses_url":"https://api.github.com/repos/jupyterlab/jupyterlab/statuses/6f1be0a45606bbb54044f71ba87336bb0d35a081","head":{"label":"gnestor:ui-components","ref":"ui-components","sha":"6f1be0a45606bbb54044f71ba87336bb0d35a081","user":{"login":"gnestor","id":512354,"node_id":"MDQ6VXNlcjUxMjM1NA==","avatar_url":"https://avatars3.githubusercontent.com/u/512354?v=4","gravatar_id":"","url":"https://api.github.com/users/gnestor","html_url":"https://github.com/gnestor","followers_url":"https://api.github.com/users/gnestor/followers","following_url":"https://api.github.com/users/gnestor/following{/other_user}","gists_url":"https://api.github.com/users/gnestor/gists{/gist_id}","starred_url":"https://api.github.com/users/gnestor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnestor/subscriptions","organizations_url":"https://api.github.com/users/gnestor/orgs","repos_url":"https://api.github.com/users/gnestor/repos","events_url":"https://api.github.com/users/gnestor/events{/privacy}","received_events_url":"https://api.github.com/users/gnestor/received_events","type":"User","site_admin":false},"repo":{"id":60647367,"node_id":"MDEwOlJlcG9zaXRvcnk2MDY0NzM2Nw==","name":"jupyterlab","full_name":"gnestor/jupyterlab","private":false,"owner":{"login":"gnestor","id":512354,"node_id":"MDQ6VXNlcjUxMjM1NA==","avatar_url":"https://avatars3.githubusercontent.com/u/512354?v=4","gravatar_id":"","url":"https://api.github.com/users/gnestor","html_url":"https://github.com/gnestor","followers_url":"https://api.github.com/users/gnestor/followers","following_url":"https://api.github.com/users/gnestor/following{/other_user}","gists_url":"https://api.github.com/users/gnestor/gists{/gist_id}","starred_url":"https://api.github.com/users/gnestor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnestor/subscriptions","organizations_url":"https://api.github.com/users/gnestor/orgs","repos_url":"https://api.github.com/users/gnestor/repos","events_url":"https://api.github.com/users/gnestor/events{/privacy}","received_events_url":"https://api.github.com/users/gnestor/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gnestor/jupyterlab","description":"JupyterLab computational environment","fork":true,"url":"https://api.github.com/repos/gnestor/jupyterlab","forks_url":"https://api.github.com/repos/gnestor/jupyterlab/forks","keys_url":"https://api.github.com/repos/gnestor/jupyterlab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gnestor/jupyterlab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gnestor/jupyterlab/teams","hooks_url":"https://api.github.com/repos/gnestor/jupyterlab/hooks","issue_events_url":"https://api.github.com/repos/gnestor/jupyterlab/issues/events{/number}","events_url":"https://api.github.com/repos/gnestor/jupyterlab/events","assignees_url":"https://api.github.com/repos/gnestor/jupyterlab/assignees{/user}","branches_url":"https://api.github.com/repos/gnestor/jupyterlab/branches{/branch}","tags_url":"https://api.github.com/repos/gnestor/jupyterlab/tags","blobs_url":"https://api.github.com/repos/gnestor/jupyterlab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gnestor/jupyterlab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gnestor/jupyterlab/git/refs{/sha}","trees_url":"https://api.github.com/repos/gnestor/jupyterlab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gnestor/jupyterlab/statuses/{sha}","languages_url":"https://api.github.com/repos/gnestor/jupyterlab/languages","stargazers_url":"https://api.github.com/repos/gnestor/jupyterlab/stargazers","contributors_url":"https://api.github.com/repos/gnestor/jupyterlab/contributors","subscribers_url":"https://api.github.com/repos/gnestor/jupyterlab/subscribers","subscription_url":"https://api.github.com/repos/gnestor/jupyterlab/subscription","commits_url":"https://api.github.com/repos/gnestor/jupyterlab/commits{/sha}","git_commits_url":"https://api.github.com/repos/gnestor/jupyterlab/git/commits{/sha}","comments_url":"https://api.github.com/repos/gnestor/jupyterlab/comments{/number}","issue_comment_url":"https://api.github.com/repos/gnestor/jupyterlab/issues/comments{/number}","contents_url":"https://api.github.com/repos/gnestor/jupyterlab/contents/{+path}","compare_url":"https://api.github.com/repos/gnestor/jupyterlab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gnestor/jupyterlab/merges","archive_url":"https://api.github.com/repos/gnestor/jupyterlab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gnestor/jupyterlab/downloads","issues_url":"https://api.github.com/repos/gnestor/jupyterlab/issues{/number}","pulls_url":"https://api.github.com/repos/gnestor/jupyterlab/pulls{/number}","milestones_url":"https://api.github.com/repos/gnestor/jupyterlab/milestones{/number}","notifications_url":"https://api.github.com/repos/gnestor/jupyterlab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gnestor/jupyterlab/labels{/name}","releases_url":"https://api.github.com/repos/gnestor/jupyterlab/releases{/id}","deployments_url":"https://api.github.com/repos/gnestor/jupyterlab/deployments","created_at":"2016-06-07T21:22:39Z","updated_at":"2018-04-27T19:37:39Z","pushed_at":"2018-11-05T06:56:47Z","git_url":"git://github.com/gnestor/jupyterlab.git","ssh_url":"git@github.com:gnestor/jupyterlab.git","clone_url":"https://github.com/gnestor/jupyterlab.git","svn_url":"https://github.com/gnestor/jupyterlab","homepage":null,"size":60462,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jupyterlab:master","ref":"master","sha":"0fad4075eafebfaa7bdd82c74b4536c7478e87f7","user":{"login":"jupyterlab","id":22800682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODAwNjgy","avatar_url":"https://avatars1.githubusercontent.com/u/22800682?v=4","gravatar_id":"","url":"https://api.github.com/users/jupyterlab","html_url":"https://github.com/jupyterlab","followers_url":"https://api.github.com/users/jupyterlab/followers","following_url":"https://api.github.com/users/jupyterlab/following{/other_user}","gists_url":"https://api.github.com/users/jupyterlab/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyterlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyterlab/subscriptions","organizations_url":"https://api.github.com/users/jupyterlab/orgs","repos_url":"https://api.github.com/users/jupyterlab/repos","events_url":"https://api.github.com/users/jupyterlab/events{/privacy}","received_events_url":"https://api.github.com/users/jupyterlab/received_events","type":"Organization","site_admin":false},"repo":{"id":60374819,"node_id":"MDEwOlJlcG9zaXRvcnk2MDM3NDgxOQ==","name":"jupyterlab","full_name":"jupyterlab/jupyterlab","private":false,"owner":{"login":"jupyterlab","id":22800682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODAwNjgy","avatar_url":"https://avatars1.githubusercontent.com/u/22800682?v=4","gravatar_id":"","url":"https://api.github.com/users/jupyterlab","html_url":"https://github.com/jupyterlab","followers_url":"https://api.github.com/users/jupyterlab/followers","following_url":"https://api.github.com/users/jupyterlab/following{/other_user}","gists_url":"https://api.github.com/users/jupyterlab/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyterlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyterlab/subscriptions","organizations_url":"https://api.github.com/users/jupyterlab/orgs","repos_url":"https://api.github.com/users/jupyterlab/repos","events_url":"https://api.github.com/users/jupyterlab/events{/privacy}","received_events_url":"https://api.github.com/users/jupyterlab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jupyterlab/jupyterlab","description":"JupyterLab computational environment.","fork":false,"url":"https://api.github.com/repos/jupyterlab/jupyterlab","forks_url":"https://api.github.com/repos/jupyterlab/jupyterlab/forks","keys_url":"https://api.github.com/repos/jupyterlab/jupyterlab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jupyterlab/jupyterlab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jupyterlab/jupyterlab/teams","hooks_url":"https://api.github.com/repos/jupyterlab/jupyterlab/hooks","issue_events_url":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/events{/number}","events_url":"https://api.github.com/repos/jupyterlab/jupyterlab/events","assignees_url":"https://api.github.com/repos/jupyterlab/jupyterlab/assignees{/user}","branches_url":"https://api.github.com/repos/jupyterlab/jupyterlab/branches{/branch}","tags_url":"https://api.github.com/repos/jupyterlab/jupyterlab/tags","blobs_url":"https://api.github.com/repos/jupyterlab/jupyterlab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jupyterlab/jupyterlab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jupyterlab/jupyterlab/git/refs{/sha}","trees_url":"https://api.github.com/repos/jupyterlab/jupyterlab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jupyterlab/jupyterlab/statuses/{sha}","languages_url":"https://api.github.com/repos/jupyterlab/jupyterlab/languages","stargazers_url":"https://api.github.com/repos/jupyterlab/jupyterlab/stargazers","contributors_url":"https://api.github.com/repos/jupyterlab/jupyterlab/contributors","subscribers_url":"https://api.github.com/repos/jupyterlab/jupyterlab/subscribers","subscription_url":"https://api.github.com/repos/jupyterlab/jupyterlab/subscription","commits_url":"https://api.github.com/repos/jupyterlab/jupyterlab/commits{/sha}","git_commits_url":"https://api.github.com/repos/jupyterlab/jupyterlab/git/commits{/sha}","comments_url":"https://api.github.com/repos/jupyterlab/jupyterlab/comments{/number}","issue_comment_url":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/comments{/number}","contents_url":"https://api.github.com/repos/jupyterlab/jupyterlab/contents/{+path}","compare_url":"https://api.github.com/repos/jupyterlab/jupyterlab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jupyterlab/jupyterlab/merges","archive_url":"https://api.github.com/repos/jupyterlab/jupyterlab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jupyterlab/jupyterlab/downloads","issues_url":"https://api.github.com/repos/jupyterlab/jupyterlab/issues{/number}","pulls_url":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls{/number}","milestones_url":"https://api.github.com/repos/jupyterlab/jupyterlab/milestones{/number}","notifications_url":"https://api.github.com/repos/jupyterlab/jupyterlab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jupyterlab/jupyterlab/labels{/name}","releases_url":"https://api.github.com/repos/jupyterlab/jupyterlab/releases{/id}","deployments_url":"https://api.github.com/repos/jupyterlab/jupyterlab/deployments","created_at":"2016-06-03T20:09:17Z","updated_at":"2018-11-06T16:45:40Z","pushed_at":"2018-11-06T21:24:27Z","git_url":"git://github.com/jupyterlab/jupyterlab.git","ssh_url":"git@github.com:jupyterlab/jupyterlab.git","clone_url":"https://github.com/jupyterlab/jupyterlab.git","svn_url":"https://github.com/jupyterlab/jupyterlab","homepage":"https://jupyterlab.readthedocs.io/en/stable/","size":63562,"stargazers_count":6646,"watchers_count":6646,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":883,"mirror_url":null,"archived":false,"open_issues_count":855,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":883,"open_issues":855,"watchers":6646,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/5538"},"html":{"href":"https://github.com/jupyterlab/jupyterlab/pull/5538"},"issue":{"href":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/5538"},"comments":{"href":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/5538/comments"},"review_comments":{"href":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/5538/comments"},"review_comment":{"href":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/5538/commits"},"statuses":{"href":"https://api.github.com/repos/jupyterlab/jupyterlab/statuses/6f1be0a45606bbb54044f71ba87336bb0d35a081"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"saulshanabrook"}}