{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/30244","repository_url":"https://api.github.com/repos/dotnet/roslyn","labels_url":"https://api.github.com/repos/dotnet/roslyn/issues/30244/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/30244/comments","events_url":"https://api.github.com/repos/dotnet/roslyn/issues/30244/events","html_url":"https://github.com/dotnet/roslyn/pull/30244","id":365416396,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MzQwODkw","number":30244,"title":"Attempted fix for correctly reporting error CS1069 when using implicit namespaces","user":{"login":"jechter","id":439505,"node_id":"MDQ6VXNlcjQzOTUwNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/439505?v=4","gravatar_id":"","url":"https://api.github.com/users/jechter","html_url":"https://github.com/jechter","followers_url":"https://api.github.com/users/jechter/followers","following_url":"https://api.github.com/users/jechter/following{/other_user}","gists_url":"https://api.github.com/users/jechter/gists{/gist_id}","starred_url":"https://api.github.com/users/jechter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jechter/subscriptions","organizations_url":"https://api.github.com/users/jechter/orgs","repos_url":"https://api.github.com/users/jechter/repos","events_url":"https://api.github.com/users/jechter/events{/privacy}","received_events_url":"https://api.github.com/users/jechter/received_events","type":"User","site_admin":false},"labels":[{"id":166673288,"node_id":"MDU6TGFiZWwxNjY2NzMyODg=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Area-Compilers","name":"Area-Compilers","color":"5319e7","default":false},{"id":288147422,"node_id":"MDU6TGFiZWwyODgxNDc0MjI=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Community","name":"Community","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":{"login":"cston","id":10732005,"node_id":"MDQ6VXNlcjEwNzMyMDA1","avatar_url":"https://avatars2.githubusercontent.com/u/10732005?v=4","gravatar_id":"","url":"https://api.github.com/users/cston","html_url":"https://github.com/cston","followers_url":"https://api.github.com/users/cston/followers","following_url":"https://api.github.com/users/cston/following{/other_user}","gists_url":"https://api.github.com/users/cston/gists{/gist_id}","starred_url":"https://api.github.com/users/cston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cston/subscriptions","organizations_url":"https://api.github.com/users/cston/orgs","repos_url":"https://api.github.com/users/cston/repos","events_url":"https://api.github.com/users/cston/events{/privacy}","received_events_url":"https://api.github.com/users/cston/received_events","type":"User","site_admin":false},"assignees":[{"login":"cston","id":10732005,"node_id":"MDQ6VXNlcjEwNzMyMDA1","avatar_url":"https://avatars2.githubusercontent.com/u/10732005?v=4","gravatar_id":"","url":"https://api.github.com/users/cston","html_url":"https://github.com/cston","followers_url":"https://api.github.com/users/cston/followers","following_url":"https://api.github.com/users/cston/following{/other_user}","gists_url":"https://api.github.com/users/cston/gists{/gist_id}","starred_url":"https://api.github.com/users/cston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cston/subscriptions","organizations_url":"https://api.github.com/users/cston/orgs","repos_url":"https://api.github.com/users/cston/repos","events_url":"https://api.github.com/users/cston/events{/privacy}","received_events_url":"https://api.github.com/users/cston/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/roslyn/milestones/18","html_url":"https://github.com/dotnet/roslyn/milestone/18","labels_url":"https://api.github.com/repos/dotnet/roslyn/milestones/18/labels","id":1675130,"node_id":"MDk6TWlsZXN0b25lMTY3NTEzMA==","number":18,"title":"16.0","description":"The version *after* the next major version.","creator":{"login":"gafter","id":3804346,"node_id":"MDQ6VXNlcjM4MDQzNDY=","avatar_url":"https://avatars3.githubusercontent.com/u/3804346?v=4","gravatar_id":"","url":"https://api.github.com/users/gafter","html_url":"https://github.com/gafter","followers_url":"https://api.github.com/users/gafter/followers","following_url":"https://api.github.com/users/gafter/following{/other_user}","gists_url":"https://api.github.com/users/gafter/gists{/gist_id}","starred_url":"https://api.github.com/users/gafter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gafter/subscriptions","organizations_url":"https://api.github.com/users/gafter/orgs","repos_url":"https://api.github.com/users/gafter/repos","events_url":"https://api.github.com/users/gafter/events{/privacy}","received_events_url":"https://api.github.com/users/gafter/received_events","type":"User","site_admin":false},"open_issues":1375,"closed_issues":746,"state":"open","created_at":"2016-03-31T00:06:25Z","updated_at":"2018-10-15T08:03:38Z","due_on":null,"closed_at":null},"comments":13,"created_at":"2018-10-01T11:21:22Z","updated_at":"2018-10-15T08:49:33Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/30244","html_url":"https://github.com/dotnet/roslyn/pull/30244","diff_url":"https://github.com/dotnet/roslyn/pull/30244.diff","patch_url":"https://github.com/dotnet/roslyn/pull/30244.patch"},"body":"This is an attempted fix for https://github.com/dotnet/roslyn/issues/29747 \r\n\r\nAs explained in that issue, this misreported error is causing major usability problems for a new feature we introduced in Unity, which let's users disable modules of our engine (which are implemented as assemblies with type forwarders).\r\n\r\nI looked at the Roslyn code, and came up with the patch below to make it return the correct error code. Now, obviously, I don't have a clue about the Roslyn code base, and this is probably a bad, hackish way of fixing it. Basically, what it does is to make Imports.LookupSymbolInUsings also check any referenced assemblies for TypeForwarders of that name, and merge them to results with an ERR_DottedTypeNameNotFoundInNSFwd error. Then, in Binder.ResultSymbol, it will skip the call to ReportUseSiteDiagnostics if there is an existing error attached to the symbol, so we don't get duplicate errors.\r\n\r\nDoes this seem like a sane approach to fix the problem? Any suggestions for improving my fix?"},"comment":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/comments/429760243","html_url":"https://github.com/dotnet/roslyn/pull/30244#issuecomment-429760243","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/30244","id":429760243,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTc2MDI0Mw==","user":{"login":"jechter","id":439505,"node_id":"MDQ6VXNlcjQzOTUwNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/439505?v=4","gravatar_id":"","url":"https://api.github.com/users/jechter","html_url":"https://github.com/jechter","followers_url":"https://api.github.com/users/jechter/followers","following_url":"https://api.github.com/users/jechter/following{/other_user}","gists_url":"https://api.github.com/users/jechter/gists{/gist_id}","starred_url":"https://api.github.com/users/jechter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jechter/subscriptions","organizations_url":"https://api.github.com/users/jechter/orgs","repos_url":"https://api.github.com/users/jechter/repos","events_url":"https://api.github.com/users/jechter/events{/privacy}","received_events_url":"https://api.github.com/users/jechter/received_events","type":"User","site_admin":false},"created_at":"2018-10-15T08:49:33Z","updated_at":"2018-10-15T08:49:33Z","author_association":"NONE","body":"I added the requested generic tests."}}
{"actor":{"display_login":"jechter"}}