{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/218560565","pull_request_review_id":156526780,"id":218560565,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODU2MDU2NQ==","diff_hunk":"@@ -63,7 +63,7 @@ void L1RCTChannelMaskTester::analyze(const edm::Event& iEvent,\n             edm::eventsetup::EventSetupRecordKey::TypeTag::findType(\n                     \"L1RCTNoisyChannelMaskRcd\"));\n \n-    if (evSetup.find(recordKey) == nullptr) {\n+    if (evSetup.find(recordKey) == std::nullopt) {\n         //record not found","path":"L1TriggerConfig/RCTConfigProducers/src/L1RCTChannelMaskTester.cc","position":6,"original_position":6,"commit_id":"53ea6581609c21df4b8a52f0fd20492af4ce1e37","original_commit_id":"53ea6581609c21df4b8a52f0fd20492af4ce1e37","user":{"login":"knoepfel","id":7603566,"node_id":"MDQ6VXNlcjc2MDM1NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/7603566?v=4","gravatar_id":"","url":"https://api.github.com/users/knoepfel","html_url":"https://github.com/knoepfel","followers_url":"https://api.github.com/users/knoepfel/followers","following_url":"https://api.github.com/users/knoepfel/following{/other_user}","gists_url":"https://api.github.com/users/knoepfel/gists{/gist_id}","starred_url":"https://api.github.com/users/knoepfel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knoepfel/subscriptions","organizations_url":"https://api.github.com/users/knoepfel/orgs","repos_url":"https://api.github.com/users/knoepfel/repos","events_url":"https://api.github.com/users/knoepfel/events{/privacy}","received_events_url":"https://api.github.com/users/knoepfel/received_events","type":"User","site_admin":false},"body":"Missed this one, too--should be `tryToGet`.","created_at":"2018-09-18T19:17:03Z","updated_at":"2018-09-18T19:17:03Z","html_url":"https://github.com/cms-sw/cmssw/pull/24586#discussion_r218560565","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/24586","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/218560565"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/24586#discussion_r218560565"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/24586"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/24586","id":216383452,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MzgzNDUy","html_url":"https://github.com/cms-sw/cmssw/pull/24586","diff_url":"https://github.com/cms-sw/cmssw/pull/24586.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/24586.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/24586","number":24586,"state":"open","locked":false,"title":"Migrate from boost::optional to std::optional in EventSetup system","user":{"login":"knoepfel","id":7603566,"node_id":"MDQ6VXNlcjc2MDM1NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/7603566?v=4","gravatar_id":"","url":"https://api.github.com/users/knoepfel","html_url":"https://github.com/knoepfel","followers_url":"https://api.github.com/users/knoepfel/followers","following_url":"https://api.github.com/users/knoepfel/following{/other_user}","gists_url":"https://api.github.com/users/knoepfel/gists{/gist_id}","starred_url":"https://api.github.com/users/knoepfel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knoepfel/subscriptions","organizations_url":"https://api.github.com/users/knoepfel/orgs","repos_url":"https://api.github.com/users/knoepfel/repos","events_url":"https://api.github.com/users/knoepfel/events{/privacy}","received_events_url":"https://api.github.com/users/knoepfel/received_events","type":"User","site_admin":false},"body":"This PR *does* include some whitespace changes which are due to using C++17's nested namespace declarations.","created_at":"2018-09-18T17:20:25Z","updated_at":"2018-09-18T19:17:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"807aef6dbca8578f2fe3c066d7048fcfa24f1954","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":52881179,"node_id":"MDU6TGFiZWw1Mjg4MTE3OQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/analysis-pending","name":"analysis-pending","color":"fbca04","default":false},{"id":673935047,"node_id":"MDU6TGFiZWw2NzM5MzUwNDc=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"2cbe4e","default":false},{"id":88653795,"node_id":"MDU6TGFiZWw4ODY1Mzc5NQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":52822606,"node_id":"MDU6TGFiZWw1MjgyMjYwNg==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/core-pending","name":"core-pending","color":"fbca04","default":false},{"id":52820549,"node_id":"MDU6TGFiZWw1MjgyMDU0OQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/dqm-pending","name":"dqm-pending","color":"fbca04","default":false},{"id":52820587,"node_id":"MDU6TGFiZWw1MjgyMDU4Nw==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/l1-pending","name":"l1-pending","color":"fbca04","default":false},{"id":56953091,"node_id":"MDU6TGFiZWw1Njk1MzA5MQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"node_id":"MDU6TGFiZWw1MzE2Nzc3MA==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"ff8000","default":false},{"id":170521617,"node_id":"MDU6TGFiZWwxNzA1MjE2MTc=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-started","name":"tests-started","color":"ff8000","default":false}],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/77","html_url":"https://github.com/cms-sw/cmssw/milestone/77","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/77/labels","id":3502981,"node_id":"MDk6TWlsZXN0b25lMzUwMjk4MQ==","number":77,"title":"CMSSW_10_3_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"node_id":"MDQ6VXNlcjQxMTUxMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":60,"closed_issues":564,"state":"open","created_at":"2018-07-17T14:14:12Z","updated_at":"2018-09-18T17:21:34Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/24586/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/24586/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/24586/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/53ea6581609c21df4b8a52f0fd20492af4ce1e37","head":{"label":"knoepfel:boost-to-std-optional","ref":"boost-to-std-optional","sha":"53ea6581609c21df4b8a52f0fd20492af4ce1e37","user":{"login":"knoepfel","id":7603566,"node_id":"MDQ6VXNlcjc2MDM1NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/7603566?v=4","gravatar_id":"","url":"https://api.github.com/users/knoepfel","html_url":"https://github.com/knoepfel","followers_url":"https://api.github.com/users/knoepfel/followers","following_url":"https://api.github.com/users/knoepfel/following{/other_user}","gists_url":"https://api.github.com/users/knoepfel/gists{/gist_id}","starred_url":"https://api.github.com/users/knoepfel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knoepfel/subscriptions","organizations_url":"https://api.github.com/users/knoepfel/orgs","repos_url":"https://api.github.com/users/knoepfel/repos","events_url":"https://api.github.com/users/knoepfel/events{/privacy}","received_events_url":"https://api.github.com/users/knoepfel/received_events","type":"User","site_admin":false},"repo":{"id":70836120,"node_id":"MDEwOlJlcG9zaXRvcnk3MDgzNjEyMA==","name":"cmssw","full_name":"knoepfel/cmssw","private":false,"owner":{"login":"knoepfel","id":7603566,"node_id":"MDQ6VXNlcjc2MDM1NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/7603566?v=4","gravatar_id":"","url":"https://api.github.com/users/knoepfel","html_url":"https://github.com/knoepfel","followers_url":"https://api.github.com/users/knoepfel/followers","following_url":"https://api.github.com/users/knoepfel/following{/other_user}","gists_url":"https://api.github.com/users/knoepfel/gists{/gist_id}","starred_url":"https://api.github.com/users/knoepfel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knoepfel/subscriptions","organizations_url":"https://api.github.com/users/knoepfel/orgs","repos_url":"https://api.github.com/users/knoepfel/repos","events_url":"https://api.github.com/users/knoepfel/events{/privacy}","received_events_url":"https://api.github.com/users/knoepfel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/knoepfel/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/knoepfel/cmssw","forks_url":"https://api.github.com/repos/knoepfel/cmssw/forks","keys_url":"https://api.github.com/repos/knoepfel/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knoepfel/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knoepfel/cmssw/teams","hooks_url":"https://api.github.com/repos/knoepfel/cmssw/hooks","issue_events_url":"https://api.github.com/repos/knoepfel/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/knoepfel/cmssw/events","assignees_url":"https://api.github.com/repos/knoepfel/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/knoepfel/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/knoepfel/cmssw/tags","blobs_url":"https://api.github.com/repos/knoepfel/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knoepfel/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knoepfel/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/knoepfel/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knoepfel/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/knoepfel/cmssw/languages","stargazers_url":"https://api.github.com/repos/knoepfel/cmssw/stargazers","contributors_url":"https://api.github.com/repos/knoepfel/cmssw/contributors","subscribers_url":"https://api.github.com/repos/knoepfel/cmssw/subscribers","subscription_url":"https://api.github.com/repos/knoepfel/cmssw/subscription","commits_url":"https://api.github.com/repos/knoepfel/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/knoepfel/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/knoepfel/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/knoepfel/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/knoepfel/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/knoepfel/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knoepfel/cmssw/merges","archive_url":"https://api.github.com/repos/knoepfel/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knoepfel/cmssw/downloads","issues_url":"https://api.github.com/repos/knoepfel/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/knoepfel/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/knoepfel/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/knoepfel/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knoepfel/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/knoepfel/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/knoepfel/cmssw/deployments","created_at":"2016-10-13T18:29:11Z","updated_at":"2016-10-13T18:32:25Z","pushed_at":"2018-09-18T17:18:41Z","git_url":"git://github.com/knoepfel/cmssw.git","ssh_url":"git@github.com:knoepfel/cmssw.git","clone_url":"https://github.com/knoepfel/cmssw.git","svn_url":"https://github.com/knoepfel/cmssw","homepage":"http://cms-sw.github.io/","size":1027161,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cms-sw:master","ref":"master","sha":"04963397facc38ce9efc0870e8c89f767673d402","user":{"login":"cms-sw","id":3863500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjM1MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk2OTU1MQ==","name":"cmssw","full_name":"cms-sw/cmssw","private":false,"owner":{"login":"cms-sw","id":3863500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjM1MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2018-09-18T12:49:35Z","pushed_at":"2018-09-18T17:20:26Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1035712,"stargazers_count":576,"watchers_count":576,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2688,"mirror_url":null,"archived":false,"open_issues_count":471,"license":null,"forks":2688,"open_issues":471,"watchers":576,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/24586"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/24586"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/24586"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/24586/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/24586/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/24586/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/53ea6581609c21df4b8a52f0fd20492af4ce1e37"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"knoepfel"}}