{"action":"created","comment":{"url":"https://api.github.com/repos/verdaccio/verdaccio/pulls/comments/203845663","pull_request_review_id":138818243,"id":203845663,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzg0NTY2Mw==","diff_hunk":"@@ -0,0 +1,7 @@\n+{","path":".prettierrc","position":1,"original_position":1,"commit_id":"17aba34ca4873d560ae60aa4a040d14f8c853a6e","original_commit_id":"17aba34ca4873d560ae60aa4a040d14f8c853a6e","user":{"login":"sergiohgz","id":14012309,"node_id":"MDQ6VXNlcjE0MDEyMzA5","avatar_url":"https://avatars3.githubusercontent.com/u/14012309?v=4","gravatar_id":"","url":"https://api.github.com/users/sergiohgz","html_url":"https://github.com/sergiohgz","followers_url":"https://api.github.com/users/sergiohgz/followers","following_url":"https://api.github.com/users/sergiohgz/following{/other_user}","gists_url":"https://api.github.com/users/sergiohgz/gists{/gist_id}","starred_url":"https://api.github.com/users/sergiohgz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergiohgz/subscriptions","organizations_url":"https://api.github.com/users/sergiohgz/orgs","repos_url":"https://api.github.com/users/sergiohgz/repos","events_url":"https://api.github.com/users/sergiohgz/events{/privacy}","received_events_url":"https://api.github.com/users/sergiohgz/received_events","type":"User","site_admin":false},"body":"I don't like this. If we have Eslint rules separated from Prettier, we can reach a loop of Prettier fixing a file and Eslint telling that is incorrect.\r\n\r\nAs the [eslint-plugin-prettier README](https://github.com/prettier/eslint-plugin-prettier#options) said, we can use `eslint --fix` to run Prettier through Eslint: \r\n\r\n> The rule is autofixable -- if you run eslint with the --fix flag, your code will be formatted according to prettier style.","created_at":"2018-07-19T19:33:09Z","updated_at":"2018-07-19T19:37:01Z","html_url":"https://github.com/verdaccio/verdaccio/pull/821#discussion_r203845663","pull_request_url":"https://api.github.com/repos/verdaccio/verdaccio/pulls/821","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/verdaccio/verdaccio/pulls/comments/203845663"},"html":{"href":"https://github.com/verdaccio/verdaccio/pull/821#discussion_r203845663"},"pull_request":{"href":"https://api.github.com/repos/verdaccio/verdaccio/pulls/821"}}},"pull_request":{"url":"https://api.github.com/repos/verdaccio/verdaccio/pulls/821","id":201754867,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNzU0ODY3","html_url":"https://github.com/verdaccio/verdaccio/pull/821","diff_url":"https://github.com/verdaccio/verdaccio/pull/821.diff","patch_url":"https://github.com/verdaccio/verdaccio/pull/821.patch","issue_url":"https://api.github.com/repos/verdaccio/verdaccio/issues/821","number":821,"state":"open","locked":false,"title":"Added prettier","user":{"login":"priscilawebdev","id":29228205,"node_id":"MDQ6VXNlcjI5MjI4MjA1","avatar_url":"https://avatars1.githubusercontent.com/u/29228205?v=4","gravatar_id":"","url":"https://api.github.com/users/priscilawebdev","html_url":"https://github.com/priscilawebdev","followers_url":"https://api.github.com/users/priscilawebdev/followers","following_url":"https://api.github.com/users/priscilawebdev/following{/other_user}","gists_url":"https://api.github.com/users/priscilawebdev/gists{/gist_id}","starred_url":"https://api.github.com/users/priscilawebdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/priscilawebdev/subscriptions","organizations_url":"https://api.github.com/users/priscilawebdev/orgs","repos_url":"https://api.github.com/users/priscilawebdev/repos","events_url":"https://api.github.com/users/priscilawebdev/events{/privacy}","received_events_url":"https://api.github.com/users/priscilawebdev/received_events","type":"User","site_admin":false},"body":"**Description:**\r\nAdded Prettier\r\n\r\n**Scripts**\r\nI added the previous scripts created by @ayusharma + 01  more script,  which checks the conflicts caused by the same rule defined in .prettierrc and .eslintrc\r\n\r\n**Pre-Commit**\r\nI added **pretty-quick --staged**, which runs ESlint together with Prettier on your **staged files**.\r\n\r\n**VS Code users**\r\nIn order to  format the code onSave using **eslint** and **prettierl**, I installed the **ESLINT plugin** and added the following configuration:\r\n```\r\n`   \"files.autoSave\": \"onFocusChange\",`\r\n  `  \"editor.formatOnSave\": true,`\r\n   ` \"[javascript]\": {\r\n        \"editor.formatOnSave\": false\r\n    },`\r\n `  \"eslint.autoFixOnSave\": true,`\r\n  `  \"eslint.workingDirectories\": [\r\n        \".\",\r\n        \"./src/webui\"\r\n    ],`\r\n   ` \"javascript.validate.enable\": false`\r\n```","created_at":"2018-07-16T20:43:11Z","updated_at":"2018-07-19T19:37:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1515aa22e18c0097d773feffb4a61f743d9eb549","assignee":{"login":"juanpicado","id":558752,"node_id":"MDQ6VXNlcjU1ODc1Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/558752?v=4","gravatar_id":"","url":"https://api.github.com/users/juanpicado","html_url":"https://github.com/juanpicado","followers_url":"https://api.github.com/users/juanpicado/followers","following_url":"https://api.github.com/users/juanpicado/following{/other_user}","gists_url":"https://api.github.com/users/juanpicado/gists{/gist_id}","starred_url":"https://api.github.com/users/juanpicado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanpicado/subscriptions","organizations_url":"https://api.github.com/users/juanpicado/orgs","repos_url":"https://api.github.com/users/juanpicado/repos","events_url":"https://api.github.com/users/juanpicado/events{/privacy}","received_events_url":"https://api.github.com/users/juanpicado/received_events","type":"User","site_admin":false},"assignees":[{"login":"juanpicado","id":558752,"node_id":"MDQ6VXNlcjU1ODc1Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/558752?v=4","gravatar_id":"","url":"https://api.github.com/users/juanpicado","html_url":"https://github.com/juanpicado","followers_url":"https://api.github.com/users/juanpicado/followers","following_url":"https://api.github.com/users/juanpicado/following{/other_user}","gists_url":"https://api.github.com/users/juanpicado/gists{/gist_id}","starred_url":"https://api.github.com/users/juanpicado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanpicado/subscriptions","organizations_url":"https://api.github.com/users/juanpicado/orgs","repos_url":"https://api.github.com/users/juanpicado/repos","events_url":"https://api.github.com/users/juanpicado/events{/privacy}","received_events_url":"https://api.github.com/users/juanpicado/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":916230137,"node_id":"MDU6TGFiZWw5MTYyMzAxMzc=","url":"https://api.github.com/repos/verdaccio/verdaccio/labels/WIP","name":"WIP","color":"71ef02","default":false},{"id":598171219,"node_id":"MDU6TGFiZWw1OTgxNzEyMTk=","url":"https://api.github.com/repos/verdaccio/verdaccio/labels/need%20verification","name":"need verification","color":"0052cc","default":false}],"milestone":{"url":"https://api.github.com/repos/verdaccio/verdaccio/milestones/2","html_url":"https://github.com/verdaccio/verdaccio/milestone/2","labels_url":"https://api.github.com/repos/verdaccio/verdaccio/milestones/2/labels","id":2373702,"node_id":"MDk6TWlsZXN0b25lMjM3MzcwMg==","number":2,"title":"Future","description":"","creator":{"login":"juanpicado","id":558752,"node_id":"MDQ6VXNlcjU1ODc1Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/558752?v=4","gravatar_id":"","url":"https://api.github.com/users/juanpicado","html_url":"https://github.com/juanpicado","followers_url":"https://api.github.com/users/juanpicado/followers","following_url":"https://api.github.com/users/juanpicado/following{/other_user}","gists_url":"https://api.github.com/users/juanpicado/gists{/gist_id}","starred_url":"https://api.github.com/users/juanpicado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanpicado/subscriptions","organizations_url":"https://api.github.com/users/juanpicado/orgs","repos_url":"https://api.github.com/users/juanpicado/repos","events_url":"https://api.github.com/users/juanpicado/events{/privacy}","received_events_url":"https://api.github.com/users/juanpicado/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":10,"state":"open","created_at":"2017-03-09T06:19:34Z","updated_at":"2018-07-17T19:11:41Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/verdaccio/verdaccio/pulls/821/commits","review_comments_url":"https://api.github.com/repos/verdaccio/verdaccio/pulls/821/comments","review_comment_url":"https://api.github.com/repos/verdaccio/verdaccio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/verdaccio/verdaccio/issues/821/comments","statuses_url":"https://api.github.com/repos/verdaccio/verdaccio/statuses/17aba34ca4873d560ae60aa4a040d14f8c853a6e","head":{"label":"priscilawebdev:task-379","ref":"task-379","sha":"17aba34ca4873d560ae60aa4a040d14f8c853a6e","user":{"login":"priscilawebdev","id":29228205,"node_id":"MDQ6VXNlcjI5MjI4MjA1","avatar_url":"https://avatars1.githubusercontent.com/u/29228205?v=4","gravatar_id":"","url":"https://api.github.com/users/priscilawebdev","html_url":"https://github.com/priscilawebdev","followers_url":"https://api.github.com/users/priscilawebdev/followers","following_url":"https://api.github.com/users/priscilawebdev/following{/other_user}","gists_url":"https://api.github.com/users/priscilawebdev/gists{/gist_id}","starred_url":"https://api.github.com/users/priscilawebdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/priscilawebdev/subscriptions","organizations_url":"https://api.github.com/users/priscilawebdev/orgs","repos_url":"https://api.github.com/users/priscilawebdev/repos","events_url":"https://api.github.com/users/priscilawebdev/events{/privacy}","received_events_url":"https://api.github.com/users/priscilawebdev/received_events","type":"User","site_admin":false},"repo":{"id":141187868,"node_id":"MDEwOlJlcG9zaXRvcnkxNDExODc4Njg=","name":"verdaccio","full_name":"priscilawebdev/verdaccio","owner":{"login":"priscilawebdev","id":29228205,"node_id":"MDQ6VXNlcjI5MjI4MjA1","avatar_url":"https://avatars1.githubusercontent.com/u/29228205?v=4","gravatar_id":"","url":"https://api.github.com/users/priscilawebdev","html_url":"https://github.com/priscilawebdev","followers_url":"https://api.github.com/users/priscilawebdev/followers","following_url":"https://api.github.com/users/priscilawebdev/following{/other_user}","gists_url":"https://api.github.com/users/priscilawebdev/gists{/gist_id}","starred_url":"https://api.github.com/users/priscilawebdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/priscilawebdev/subscriptions","organizations_url":"https://api.github.com/users/priscilawebdev/orgs","repos_url":"https://api.github.com/users/priscilawebdev/repos","events_url":"https://api.github.com/users/priscilawebdev/events{/privacy}","received_events_url":"https://api.github.com/users/priscilawebdev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/priscilawebdev/verdaccio","description":"📦🔐A lightweight private npm proxy registry","fork":true,"url":"https://api.github.com/repos/priscilawebdev/verdaccio","forks_url":"https://api.github.com/repos/priscilawebdev/verdaccio/forks","keys_url":"https://api.github.com/repos/priscilawebdev/verdaccio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/priscilawebdev/verdaccio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/priscilawebdev/verdaccio/teams","hooks_url":"https://api.github.com/repos/priscilawebdev/verdaccio/hooks","issue_events_url":"https://api.github.com/repos/priscilawebdev/verdaccio/issues/events{/number}","events_url":"https://api.github.com/repos/priscilawebdev/verdaccio/events","assignees_url":"https://api.github.com/repos/priscilawebdev/verdaccio/assignees{/user}","branches_url":"https://api.github.com/repos/priscilawebdev/verdaccio/branches{/branch}","tags_url":"https://api.github.com/repos/priscilawebdev/verdaccio/tags","blobs_url":"https://api.github.com/repos/priscilawebdev/verdaccio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/priscilawebdev/verdaccio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/priscilawebdev/verdaccio/git/refs{/sha}","trees_url":"https://api.github.com/repos/priscilawebdev/verdaccio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/priscilawebdev/verdaccio/statuses/{sha}","languages_url":"https://api.github.com/repos/priscilawebdev/verdaccio/languages","stargazers_url":"https://api.github.com/repos/priscilawebdev/verdaccio/stargazers","contributors_url":"https://api.github.com/repos/priscilawebdev/verdaccio/contributors","subscribers_url":"https://api.github.com/repos/priscilawebdev/verdaccio/subscribers","subscription_url":"https://api.github.com/repos/priscilawebdev/verdaccio/subscription","commits_url":"https://api.github.com/repos/priscilawebdev/verdaccio/commits{/sha}","git_commits_url":"https://api.github.com/repos/priscilawebdev/verdaccio/git/commits{/sha}","comments_url":"https://api.github.com/repos/priscilawebdev/verdaccio/comments{/number}","issue_comment_url":"https://api.github.com/repos/priscilawebdev/verdaccio/issues/comments{/number}","contents_url":"https://api.github.com/repos/priscilawebdev/verdaccio/contents/{+path}","compare_url":"https://api.github.com/repos/priscilawebdev/verdaccio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/priscilawebdev/verdaccio/merges","archive_url":"https://api.github.com/repos/priscilawebdev/verdaccio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/priscilawebdev/verdaccio/downloads","issues_url":"https://api.github.com/repos/priscilawebdev/verdaccio/issues{/number}","pulls_url":"https://api.github.com/repos/priscilawebdev/verdaccio/pulls{/number}","milestones_url":"https://api.github.com/repos/priscilawebdev/verdaccio/milestones{/number}","notifications_url":"https://api.github.com/repos/priscilawebdev/verdaccio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/priscilawebdev/verdaccio/labels{/name}","releases_url":"https://api.github.com/repos/priscilawebdev/verdaccio/releases{/id}","deployments_url":"https://api.github.com/repos/priscilawebdev/verdaccio/deployments","created_at":"2018-07-16T19:59:53Z","updated_at":"2018-07-16T19:59:57Z","pushed_at":"2018-07-18T19:30:36Z","git_url":"git://github.com/priscilawebdev/verdaccio.git","ssh_url":"git@github.com:priscilawebdev/verdaccio.git","clone_url":"https://github.com/priscilawebdev/verdaccio.git","svn_url":"https://github.com/priscilawebdev/verdaccio","homepage":"https://www.verdaccio.org/","size":23427,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"verdaccio:master","ref":"master","sha":"11dcf798cc7dca594547f74f0a05473e7ee74f58","user":{"login":"verdaccio","id":18487506,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDg3NTA2","avatar_url":"https://avatars2.githubusercontent.com/u/18487506?v=4","gravatar_id":"","url":"https://api.github.com/users/verdaccio","html_url":"https://github.com/verdaccio","followers_url":"https://api.github.com/users/verdaccio/followers","following_url":"https://api.github.com/users/verdaccio/following{/other_user}","gists_url":"https://api.github.com/users/verdaccio/gists{/gist_id}","starred_url":"https://api.github.com/users/verdaccio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/verdaccio/subscriptions","organizations_url":"https://api.github.com/users/verdaccio/orgs","repos_url":"https://api.github.com/users/verdaccio/repos","events_url":"https://api.github.com/users/verdaccio/events{/privacy}","received_events_url":"https://api.github.com/users/verdaccio/received_events","type":"Organization","site_admin":false},"repo":{"id":56333861,"node_id":"MDEwOlJlcG9zaXRvcnk1NjMzMzg2MQ==","name":"verdaccio","full_name":"verdaccio/verdaccio","owner":{"login":"verdaccio","id":18487506,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDg3NTA2","avatar_url":"https://avatars2.githubusercontent.com/u/18487506?v=4","gravatar_id":"","url":"https://api.github.com/users/verdaccio","html_url":"https://github.com/verdaccio","followers_url":"https://api.github.com/users/verdaccio/followers","following_url":"https://api.github.com/users/verdaccio/following{/other_user}","gists_url":"https://api.github.com/users/verdaccio/gists{/gist_id}","starred_url":"https://api.github.com/users/verdaccio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/verdaccio/subscriptions","organizations_url":"https://api.github.com/users/verdaccio/orgs","repos_url":"https://api.github.com/users/verdaccio/repos","events_url":"https://api.github.com/users/verdaccio/events{/privacy}","received_events_url":"https://api.github.com/users/verdaccio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/verdaccio/verdaccio","description":"📦🔐A lightweight private npm proxy registry","fork":false,"url":"https://api.github.com/repos/verdaccio/verdaccio","forks_url":"https://api.github.com/repos/verdaccio/verdaccio/forks","keys_url":"https://api.github.com/repos/verdaccio/verdaccio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/verdaccio/verdaccio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/verdaccio/verdaccio/teams","hooks_url":"https://api.github.com/repos/verdaccio/verdaccio/hooks","issue_events_url":"https://api.github.com/repos/verdaccio/verdaccio/issues/events{/number}","events_url":"https://api.github.com/repos/verdaccio/verdaccio/events","assignees_url":"https://api.github.com/repos/verdaccio/verdaccio/assignees{/user}","branches_url":"https://api.github.com/repos/verdaccio/verdaccio/branches{/branch}","tags_url":"https://api.github.com/repos/verdaccio/verdaccio/tags","blobs_url":"https://api.github.com/repos/verdaccio/verdaccio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/verdaccio/verdaccio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/verdaccio/verdaccio/git/refs{/sha}","trees_url":"https://api.github.com/repos/verdaccio/verdaccio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/verdaccio/verdaccio/statuses/{sha}","languages_url":"https://api.github.com/repos/verdaccio/verdaccio/languages","stargazers_url":"https://api.github.com/repos/verdaccio/verdaccio/stargazers","contributors_url":"https://api.github.com/repos/verdaccio/verdaccio/contributors","subscribers_url":"https://api.github.com/repos/verdaccio/verdaccio/subscribers","subscription_url":"https://api.github.com/repos/verdaccio/verdaccio/subscription","commits_url":"https://api.github.com/repos/verdaccio/verdaccio/commits{/sha}","git_commits_url":"https://api.github.com/repos/verdaccio/verdaccio/git/commits{/sha}","comments_url":"https://api.github.com/repos/verdaccio/verdaccio/comments{/number}","issue_comment_url":"https://api.github.com/repos/verdaccio/verdaccio/issues/comments{/number}","contents_url":"https://api.github.com/repos/verdaccio/verdaccio/contents/{+path}","compare_url":"https://api.github.com/repos/verdaccio/verdaccio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/verdaccio/verdaccio/merges","archive_url":"https://api.github.com/repos/verdaccio/verdaccio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/verdaccio/verdaccio/downloads","issues_url":"https://api.github.com/repos/verdaccio/verdaccio/issues{/number}","pulls_url":"https://api.github.com/repos/verdaccio/verdaccio/pulls{/number}","milestones_url":"https://api.github.com/repos/verdaccio/verdaccio/milestones{/number}","notifications_url":"https://api.github.com/repos/verdaccio/verdaccio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/verdaccio/verdaccio/labels{/name}","releases_url":"https://api.github.com/repos/verdaccio/verdaccio/releases{/id}","deployments_url":"https://api.github.com/repos/verdaccio/verdaccio/deployments","created_at":"2016-04-15T16:21:12Z","updated_at":"2018-07-19T16:57:58Z","pushed_at":"2018-07-19T11:02:40Z","git_url":"git://github.com/verdaccio/verdaccio.git","ssh_url":"git@github.com:verdaccio/verdaccio.git","clone_url":"https://github.com/verdaccio/verdaccio.git","svn_url":"https://github.com/verdaccio/verdaccio","homepage":"https://www.verdaccio.org/","size":23468,"stargazers_count":3639,"watchers_count":3639,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":431,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":431,"open_issues":64,"watchers":3639,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/verdaccio/verdaccio/pulls/821"},"html":{"href":"https://github.com/verdaccio/verdaccio/pull/821"},"issue":{"href":"https://api.github.com/repos/verdaccio/verdaccio/issues/821"},"comments":{"href":"https://api.github.com/repos/verdaccio/verdaccio/issues/821/comments"},"review_comments":{"href":"https://api.github.com/repos/verdaccio/verdaccio/pulls/821/comments"},"review_comment":{"href":"https://api.github.com/repos/verdaccio/verdaccio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/verdaccio/verdaccio/pulls/821/commits"},"statuses":{"href":"https://api.github.com/repos/verdaccio/verdaccio/statuses/17aba34ca4873d560ae60aa4a040d14f8c853a6e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sergiohgz"}}