{"action":"created","issue":{"url":"https://api.github.com/repos/moby/moby/issues/37172","repository_url":"https://api.github.com/repos/moby/moby","labels_url":"https://api.github.com/repos/moby/moby/issues/37172/labels{/name}","comments_url":"https://api.github.com/repos/moby/moby/issues/37172/comments","events_url":"https://api.github.com/repos/moby/moby/issues/37172/events","html_url":"https://github.com/moby/moby/pull/37172","id":327615010,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxMzY0MDY4","number":37172,"title":"Fix race condition between exec start and resize.","user":{"login":"zq-david-wang","id":6317291,"node_id":"MDQ6VXNlcjYzMTcyOTE=","avatar_url":"https://avatars0.githubusercontent.com/u/6317291?v=4","gravatar_id":"","url":"https://api.github.com/users/zq-david-wang","html_url":"https://github.com/zq-david-wang","followers_url":"https://api.github.com/users/zq-david-wang/followers","following_url":"https://api.github.com/users/zq-david-wang/following{/other_user}","gists_url":"https://api.github.com/users/zq-david-wang/gists{/gist_id}","starred_url":"https://api.github.com/users/zq-david-wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zq-david-wang/subscriptions","organizations_url":"https://api.github.com/users/zq-david-wang/orgs","repos_url":"https://api.github.com/users/zq-david-wang/repos","events_url":"https://api.github.com/users/zq-david-wang/events{/privacy}","received_events_url":"https://api.github.com/users/zq-david-wang/received_events","type":"User","site_admin":false},"labels":[{"id":175375407,"node_id":"MDU6TGFiZWwxNzUzNzU0MDc=","url":"https://api.github.com/repos/moby/moby/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-05-30T07:56:46Z","updated_at":"2018-06-01T00:33:56Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/moby/moby/pulls/37172","html_url":"https://github.com/moby/moby/pull/37172","diff_url":"https://github.com/moby/moby/pull/37172.diff","patch_url":"https://github.com/moby/moby/pull/37172.patch"},"body":"Signed-off-by: David Wang <00107082@163.com>\r\n\r\n<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\nhttps://github.com/moby/moby/blob/master/CONTRIBUTING.md\r\n\r\n** Make sure all your commits include a signature generated with `git commit -s` **\r\n\r\nFor additional information on our contributing process, read our contributing\r\nguide https://docs.docker.com/opensource/code/\r\n\r\nIf this is a bug fix, make sure your description includes \"fixes #xxxx\", or\r\n\"closes #xxxx\"\r\n\r\nPlease provide the following information:\r\n-->\r\n\r\n**- What I did**\r\nFix a race condition between exec start and resize\r\n**- How I did it**\r\nAdd lock when calling resize\r\n**- How to verify it**\r\nrun `docker exec -it $(docker run -d centos sleep 3600) bash`, and then type a long line to see that the line actually wrapped around to next line\r\n**- Description for the changelog**\r\n<!--\r\nWrite a short (one line) summary that describes the changes in this\r\npull request for inclusion in the changelog:\r\n-->\r\nfixes #31223 #35407\r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/moby/moby/issues/comments/393723888","html_url":"https://github.com/moby/moby/pull/37172#issuecomment-393723888","issue_url":"https://api.github.com/repos/moby/moby/issues/37172","id":393723888,"node_id":"MDEyOklzc3VlQ29tbWVudDM5MzcyMzg4OA==","user":{"login":"zq-david-wang","id":6317291,"node_id":"MDQ6VXNlcjYzMTcyOTE=","avatar_url":"https://avatars0.githubusercontent.com/u/6317291?v=4","gravatar_id":"","url":"https://api.github.com/users/zq-david-wang","html_url":"https://github.com/zq-david-wang","followers_url":"https://api.github.com/users/zq-david-wang/followers","following_url":"https://api.github.com/users/zq-david-wang/following{/other_user}","gists_url":"https://api.github.com/users/zq-david-wang/gists{/gist_id}","starred_url":"https://api.github.com/users/zq-david-wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zq-david-wang/subscriptions","organizations_url":"https://api.github.com/users/zq-david-wang/orgs","repos_url":"https://api.github.com/users/zq-david-wang/repos","events_url":"https://api.github.com/users/zq-david-wang/events{/privacy}","received_events_url":"https://api.github.com/users/zq-david-wang/received_events","type":"User","site_admin":false},"created_at":"2018-06-01T00:33:56Z","updated_at":"2018-06-01T00:33:56Z","author_association":"NONE","body":"Jenkins jobs still report failure.\r\nhttps://jenkins.dockerproject.org/job/Docker-PRs-experimental/40864/console\r\n03:43:08 FAIL: docker_cli_swarm_test.go:1372: DockerSwarmSuite.TestSwarmClusterRotateUnlockKey\r\n\r\nhttps://jenkins.dockerproject.org/job/Docker-PRs/49618/console\r\n02:51:39 === RUN   TestCreateServiceSecretFileMode\r\n02:52:12 --- FAIL: TestCreateServiceSecretFileMode (32.34s)\r\n02:52:12 \tdaemon.go:285: [da6a109addeb3] waiting for daemon to start\r\n02:52:12 \tdaemon.go:317: [da6a109addeb3] daemon started\r\n02:52:12 \tcreate_test.go:190: timeout hit after 30s: task count at 1 waiting for 0\r\n02:52:12 \tdaemon.go:275: [da6a109addeb3] exiting daemon\r\n\r\nIt is hard for me to relate those failures to 'docker exec', and those two failure jobs reported SUCCESS during previous round of test, while tow failure jobs reports SUCCESS now....... strange thing."}}
{"actor":{"display_login":"zq-david-wang"}}