{"action":"created","comment":{"url":"https://api.github.com/repos/thomasbean-prezi/pongservice/pulls/comments/170215774","pull_request_review_id":98868839,"id":170215774,"diff_hunk":"@@ -3,8 +3,8 @@\n \n def get_invalid_matches():\n     matches = Match.objects.all()\n-    invalid_matches = [match for match in matches if is_match_invalid(match)]\n-    return invalid_matches\n+    invalid_match_ids = [match.id for match in matches if is_match_invalid(match)]\n+    return invalid_match_ids","path":"main/helpers.py","position":7,"original_position":7,"commit_id":"389281744071eb94c3b46eda850e9097533c201b","original_commit_id":"389281744071eb94c3b46eda850e9097533c201b","user":{"login":"akoskaaa","id":4692150,"avatar_url":"https://avatars3.githubusercontent.com/u/4692150?v=4","gravatar_id":"","url":"https://api.github.com/users/akoskaaa","html_url":"https://github.com/akoskaaa","followers_url":"https://api.github.com/users/akoskaaa/followers","following_url":"https://api.github.com/users/akoskaaa/following{/other_user}","gists_url":"https://api.github.com/users/akoskaaa/gists{/gist_id}","starred_url":"https://api.github.com/users/akoskaaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akoskaaa/subscriptions","organizations_url":"https://api.github.com/users/akoskaaa/orgs","repos_url":"https://api.github.com/users/akoskaaa/repos","events_url":"https://api.github.com/users/akoskaaa/events{/privacy}","received_events_url":"https://api.github.com/users/akoskaaa/received_events","type":"User","site_admin":false},"body":"This was an interesting change. I'd expect this function to return matches and not match ids. I'd recommend returning matches, or renaming the function `get_invalid_match_ids`.\r\n\r\nThe first one is a bit more versatile.","created_at":"2018-02-23T10:25:13Z","updated_at":"2018-02-23T10:25:14Z","html_url":"https://github.com/thomasbean-prezi/pongservice/pull/3#discussion_r170215774","pull_request_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/pulls/3","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/thomasbean-prezi/pongservice/pulls/comments/170215774"},"html":{"href":"https://github.com/thomasbean-prezi/pongservice/pull/3#discussion_r170215774"},"pull_request":{"href":"https://api.github.com/repos/thomasbean-prezi/pongservice/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/thomasbean-prezi/pongservice/pulls/3","id":170977813,"html_url":"https://github.com/thomasbean-prezi/pongservice/pull/3","diff_url":"https://github.com/thomasbean-prezi/pongservice/pull/3.diff","patch_url":"https://github.com/thomasbean-prezi/pongservice/pull/3.patch","issue_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/issues/3","number":3,"state":"open","locked":false,"title":"[BIO-860] Management commands to remove invalid matches","user":{"login":"thomasbean-prezi","id":31205324,"avatar_url":"https://avatars3.githubusercontent.com/u/31205324?v=4","gravatar_id":"","url":"https://api.github.com/users/thomasbean-prezi","html_url":"https://github.com/thomasbean-prezi","followers_url":"https://api.github.com/users/thomasbean-prezi/followers","following_url":"https://api.github.com/users/thomasbean-prezi/following{/other_user}","gists_url":"https://api.github.com/users/thomasbean-prezi/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasbean-prezi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasbean-prezi/subscriptions","organizations_url":"https://api.github.com/users/thomasbean-prezi/orgs","repos_url":"https://api.github.com/users/thomasbean-prezi/repos","events_url":"https://api.github.com/users/thomasbean-prezi/events{/privacy}","received_events_url":"https://api.github.com/users/thomasbean-prezi/received_events","type":"User","site_admin":false},"body":"### What does it do \r\nI reorganized git so the management commands and scripts called to run the commands are included in this PR and not the PR involved with writing the logic to remove invalid matches\r\n\r\n### Comments\r\n","created_at":"2018-02-23T10:15:25Z","updated_at":"2018-02-23T10:25:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9634cf053009691fb5742f6d99d91e5852cd3c57","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/pulls/3/commits","review_comments_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/pulls/3/comments","review_comment_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/issues/3/comments","statuses_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/statuses/389281744071eb94c3b46eda850e9097533c201b","head":{"label":"thomasbean-prezi:management-commands-remove-invalid-matches","ref":"management-commands-remove-invalid-matches","sha":"389281744071eb94c3b46eda850e9097533c201b","user":{"login":"thomasbean-prezi","id":31205324,"avatar_url":"https://avatars3.githubusercontent.com/u/31205324?v=4","gravatar_id":"","url":"https://api.github.com/users/thomasbean-prezi","html_url":"https://github.com/thomasbean-prezi","followers_url":"https://api.github.com/users/thomasbean-prezi/followers","following_url":"https://api.github.com/users/thomasbean-prezi/following{/other_user}","gists_url":"https://api.github.com/users/thomasbean-prezi/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasbean-prezi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasbean-prezi/subscriptions","organizations_url":"https://api.github.com/users/thomasbean-prezi/orgs","repos_url":"https://api.github.com/users/thomasbean-prezi/repos","events_url":"https://api.github.com/users/thomasbean-prezi/events{/privacy}","received_events_url":"https://api.github.com/users/thomasbean-prezi/received_events","type":"User","site_admin":false},"repo":{"id":121387177,"name":"pongservice","full_name":"thomasbean-prezi/pongservice","owner":{"login":"thomasbean-prezi","id":31205324,"avatar_url":"https://avatars3.githubusercontent.com/u/31205324?v=4","gravatar_id":"","url":"https://api.github.com/users/thomasbean-prezi","html_url":"https://github.com/thomasbean-prezi","followers_url":"https://api.github.com/users/thomasbean-prezi/followers","following_url":"https://api.github.com/users/thomasbean-prezi/following{/other_user}","gists_url":"https://api.github.com/users/thomasbean-prezi/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasbean-prezi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasbean-prezi/subscriptions","organizations_url":"https://api.github.com/users/thomasbean-prezi/orgs","repos_url":"https://api.github.com/users/thomasbean-prezi/repos","events_url":"https://api.github.com/users/thomasbean-prezi/events{/privacy}","received_events_url":"https://api.github.com/users/thomasbean-prezi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thomasbean-prezi/pongservice","description":"this is my pet project. a ping pong logger in django","fork":false,"url":"https://api.github.com/repos/thomasbean-prezi/pongservice","forks_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/forks","keys_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/teams","hooks_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/hooks","issue_events_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/issues/events{/number}","events_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/events","assignees_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/assignees{/user}","branches_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/branches{/branch}","tags_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/tags","blobs_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/git/refs{/sha}","trees_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/statuses/{sha}","languages_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/languages","stargazers_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/stargazers","contributors_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/contributors","subscribers_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/subscribers","subscription_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/subscription","commits_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/commits{/sha}","git_commits_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/git/commits{/sha}","comments_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/comments{/number}","issue_comment_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/issues/comments{/number}","contents_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/contents/{+path}","compare_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/merges","archive_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/downloads","issues_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/issues{/number}","pulls_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/pulls{/number}","milestones_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/milestones{/number}","notifications_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/labels{/name}","releases_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/releases{/id}","deployments_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/deployments","created_at":"2018-02-13T13:43:41Z","updated_at":"2018-02-15T13:07:41Z","pushed_at":"2018-02-23T10:15:25Z","git_url":"git://github.com/thomasbean-prezi/pongservice.git","ssh_url":"git@github.com:thomasbean-prezi/pongservice.git","clone_url":"https://github.com/thomasbean-prezi/pongservice.git","svn_url":"https://github.com/thomasbean-prezi/pongservice","homepage":null,"size":147,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"thomasbean-prezi:remove-invalid-matches","ref":"remove-invalid-matches","sha":"ddbc77e2fe1348aa9dd002a6fc50e5fdb771d16a","user":{"login":"thomasbean-prezi","id":31205324,"avatar_url":"https://avatars3.githubusercontent.com/u/31205324?v=4","gravatar_id":"","url":"https://api.github.com/users/thomasbean-prezi","html_url":"https://github.com/thomasbean-prezi","followers_url":"https://api.github.com/users/thomasbean-prezi/followers","following_url":"https://api.github.com/users/thomasbean-prezi/following{/other_user}","gists_url":"https://api.github.com/users/thomasbean-prezi/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasbean-prezi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasbean-prezi/subscriptions","organizations_url":"https://api.github.com/users/thomasbean-prezi/orgs","repos_url":"https://api.github.com/users/thomasbean-prezi/repos","events_url":"https://api.github.com/users/thomasbean-prezi/events{/privacy}","received_events_url":"https://api.github.com/users/thomasbean-prezi/received_events","type":"User","site_admin":false},"repo":{"id":121387177,"name":"pongservice","full_name":"thomasbean-prezi/pongservice","owner":{"login":"thomasbean-prezi","id":31205324,"avatar_url":"https://avatars3.githubusercontent.com/u/31205324?v=4","gravatar_id":"","url":"https://api.github.com/users/thomasbean-prezi","html_url":"https://github.com/thomasbean-prezi","followers_url":"https://api.github.com/users/thomasbean-prezi/followers","following_url":"https://api.github.com/users/thomasbean-prezi/following{/other_user}","gists_url":"https://api.github.com/users/thomasbean-prezi/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasbean-prezi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasbean-prezi/subscriptions","organizations_url":"https://api.github.com/users/thomasbean-prezi/orgs","repos_url":"https://api.github.com/users/thomasbean-prezi/repos","events_url":"https://api.github.com/users/thomasbean-prezi/events{/privacy}","received_events_url":"https://api.github.com/users/thomasbean-prezi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thomasbean-prezi/pongservice","description":"this is my pet project. a ping pong logger in django","fork":false,"url":"https://api.github.com/repos/thomasbean-prezi/pongservice","forks_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/forks","keys_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/teams","hooks_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/hooks","issue_events_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/issues/events{/number}","events_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/events","assignees_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/assignees{/user}","branches_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/branches{/branch}","tags_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/tags","blobs_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/git/refs{/sha}","trees_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/statuses/{sha}","languages_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/languages","stargazers_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/stargazers","contributors_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/contributors","subscribers_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/subscribers","subscription_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/subscription","commits_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/commits{/sha}","git_commits_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/git/commits{/sha}","comments_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/comments{/number}","issue_comment_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/issues/comments{/number}","contents_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/contents/{+path}","compare_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/merges","archive_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/downloads","issues_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/issues{/number}","pulls_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/pulls{/number}","milestones_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/milestones{/number}","notifications_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/labels{/name}","releases_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/releases{/id}","deployments_url":"https://api.github.com/repos/thomasbean-prezi/pongservice/deployments","created_at":"2018-02-13T13:43:41Z","updated_at":"2018-02-15T13:07:41Z","pushed_at":"2018-02-23T10:15:25Z","git_url":"git://github.com/thomasbean-prezi/pongservice.git","ssh_url":"git@github.com:thomasbean-prezi/pongservice.git","clone_url":"https://github.com/thomasbean-prezi/pongservice.git","svn_url":"https://github.com/thomasbean-prezi/pongservice","homepage":null,"size":147,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thomasbean-prezi/pongservice/pulls/3"},"html":{"href":"https://github.com/thomasbean-prezi/pongservice/pull/3"},"issue":{"href":"https://api.github.com/repos/thomasbean-prezi/pongservice/issues/3"},"comments":{"href":"https://api.github.com/repos/thomasbean-prezi/pongservice/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/thomasbean-prezi/pongservice/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/thomasbean-prezi/pongservice/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thomasbean-prezi/pongservice/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/thomasbean-prezi/pongservice/statuses/389281744071eb94c3b46eda850e9097533c201b"}},"author_association":"OWNER"}}
{"actor":{"display_login":"akoskaaa"}}