{"action":"created","comment":{"url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/comments/188210047","pull_request_review_id":120138018,"id":188210047,"diff_hunk":"@@ -305,14 +305,53 @@ function getValidFieldsTypes($module, $field){\n }\n \n \n-function getModuleField($module, $fieldname, $aow_field, $view='EditView',$value = '', $alt_type = '', $currency_id = '', $params= array()){\n-    global $current_language, $app_strings, $app_list_strings, $current_user, $beanFiles, $beanList;\n+function getModuleField(\n+    $module,\n+    $fieldname,\n+    $aow_field,\n+    $view='EditView',\n+    $value = '',\n+    $alt_type = '',\n+    $currency_id = '',\n+    $params= array()\n+){\n+    global $current_language;\n+    global $app_strings;\n+    global $app_list_strings;\n+    global $current_user;\n+    global $beanFiles;\n+    global $beanList;\n \n     // use the mod_strings for this module\n     $mod_strings = return_module_language($current_language,$module);\n \n+    // if aor condition\n+    if(strstr($aow_field, 'aor_conditions_value') !== false) {\n+        // get aor condition row\n+        $aor_row = str_replace('aor_conditions_value', '', $aow_field);\n+        $aor_row = str_replace('[', '', $aor_row);\n+        $aor_row = str_replace(']', '', $aor_row);\n+        // set the filename for this control\n+        $file = create_cache_directory('modules/AOW_WorkFlow/')\n+            . $module\n+            . $view\n+            . $alt_type\n+            . $fieldname\n+            . $aor_row\n+            . '.tpl';\n+    } else {\n+        //  its probably result of the report\n+        // set the filename for this control\n+        $file = create_cache_directory('modules/AOW_WorkFlow/')\n+            . $module\n+            . $view\n+            . $alt_type\n+            . $fieldname\n+            . '.tpl';\n+    }\n+\n     // set the filename for this control\n-    $file = create_cache_directory('modules/AOW_WorkFlow/') . $module . $view . $alt_type . $fieldname . '.tpl';\n+    $file = create_cache_directory('modules/AOW_WorkFlow/') . $module . $view . $alt_type . $fieldname . $aor_row . '.tpl';","path":"modules/AOW_WorkFlow/aow_utils.php","position":53,"original_position":53,"commit_id":"3856060163320278b1937026c7cbd930ff342108","original_commit_id":"3856060163320278b1937026c7cbd930ff342108","user":{"login":"samus-aran","id":4041275,"avatar_url":"https://avatars2.githubusercontent.com/u/4041275?v=4","gravatar_id":"","url":"https://api.github.com/users/samus-aran","html_url":"https://github.com/samus-aran","followers_url":"https://api.github.com/users/samus-aran/followers","following_url":"https://api.github.com/users/samus-aran/following{/other_user}","gists_url":"https://api.github.com/users/samus-aran/gists{/gist_id}","starred_url":"https://api.github.com/users/samus-aran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samus-aran/subscriptions","organizations_url":"https://api.github.com/users/samus-aran/orgs","repos_url":"https://api.github.com/users/samus-aran/repos","events_url":"https://api.github.com/users/samus-aran/events{/privacy}","received_events_url":"https://api.github.com/users/samus-aran/received_events","type":"User","site_admin":false},"body":"A new tpl for each row?","created_at":"2018-05-15T08:51:32Z","updated_at":"2018-05-15T08:55:00Z","html_url":"https://github.com/salesagility/SuiteCRM/pull/5874#discussion_r188210047","pull_request_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5874","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/comments/188210047"},"html":{"href":"https://github.com/salesagility/SuiteCRM/pull/5874#discussion_r188210047"},"pull_request":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5874"}}},"pull_request":{"url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5874","id":188054997,"html_url":"https://github.com/salesagility/SuiteCRM/pull/5874","diff_url":"https://github.com/salesagility/SuiteCRM/pull/5874.diff","patch_url":"https://github.com/salesagility/SuiteCRM/pull/5874.patch","issue_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/5874","number":5874,"state":"open","locked":false,"title":"Fixed #5663 - AOR_Reports Date issues","user":{"login":"daniel-samson","id":12231216,"avatar_url":"https://avatars0.githubusercontent.com/u/12231216?v=4","gravatar_id":"","url":"https://api.github.com/users/daniel-samson","html_url":"https://github.com/daniel-samson","followers_url":"https://api.github.com/users/daniel-samson/followers","following_url":"https://api.github.com/users/daniel-samson/following{/other_user}","gists_url":"https://api.github.com/users/daniel-samson/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-samson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-samson/subscriptions","organizations_url":"https://api.github.com/users/daniel-samson/orgs","repos_url":"https://api.github.com/users/daniel-samson/repos","events_url":"https://api.github.com/users/daniel-samson/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-samson/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\n<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->\r\n<!--- Please link to the issue here unless your commit contains the issue number -->\r\nFixes issues with #5799 pr.\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n\r\n## How To Test This\r\n<!--- Please describe in detail how to test your changes. -->\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n### Final checklist\r\n<!--- Go over all the following points and check all the boxes that apply. --->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --->\r\n- [x] My code follows the code style of this project found [here](https://docs.suitecrm.com/community/contributing-code/coding-standards/).\r\n- [ ] My change requires a change to the documentation.\r\n- [x] I have read the [**How to Contribute**](https://docs.suitecrm.com/community/contributing-code/) guidelines.\r\n\r\n<!--- Your pull request will be tested via Travis CI to automatically indicate that your changes do not prevent compilation. --->\r\n\r\n<!--- If it reports back that there are problems, you can log into the Travis system and check the log report for your pull request to see what the problem was. --->","created_at":"2018-05-15T08:48:08Z","updated_at":"2018-05-15T08:55:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23a96f6dc02e7bc8d22fe2afaf94389c9c710f27","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5874/commits","review_comments_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5874/comments","review_comment_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/comments{/number}","comments_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/5874/comments","statuses_url":"https://api.github.com/repos/salesagility/SuiteCRM/statuses/3856060163320278b1937026c7cbd930ff342108","head":{"label":"daniel-samson:fix_5663","ref":"fix_5663","sha":"3856060163320278b1937026c7cbd930ff342108","user":{"login":"daniel-samson","id":12231216,"avatar_url":"https://avatars0.githubusercontent.com/u/12231216?v=4","gravatar_id":"","url":"https://api.github.com/users/daniel-samson","html_url":"https://github.com/daniel-samson","followers_url":"https://api.github.com/users/daniel-samson/followers","following_url":"https://api.github.com/users/daniel-samson/following{/other_user}","gists_url":"https://api.github.com/users/daniel-samson/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-samson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-samson/subscriptions","organizations_url":"https://api.github.com/users/daniel-samson/orgs","repos_url":"https://api.github.com/users/daniel-samson/repos","events_url":"https://api.github.com/users/daniel-samson/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-samson/received_events","type":"User","site_admin":false},"repo":{"id":46138130,"name":"SuiteCRM","full_name":"daniel-samson/SuiteCRM","owner":{"login":"daniel-samson","id":12231216,"avatar_url":"https://avatars0.githubusercontent.com/u/12231216?v=4","gravatar_id":"","url":"https://api.github.com/users/daniel-samson","html_url":"https://github.com/daniel-samson","followers_url":"https://api.github.com/users/daniel-samson/followers","following_url":"https://api.github.com/users/daniel-samson/following{/other_user}","gists_url":"https://api.github.com/users/daniel-samson/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-samson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-samson/subscriptions","organizations_url":"https://api.github.com/users/daniel-samson/orgs","repos_url":"https://api.github.com/users/daniel-samson/repos","events_url":"https://api.github.com/users/daniel-samson/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-samson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/daniel-samson/SuiteCRM","description":"SuiteCRM - Open source CRM for the world","fork":true,"url":"https://api.github.com/repos/daniel-samson/SuiteCRM","forks_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/forks","keys_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/teams","hooks_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/hooks","issue_events_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/issues/events{/number}","events_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/events","assignees_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/assignees{/user}","branches_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/branches{/branch}","tags_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/tags","blobs_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/git/refs{/sha}","trees_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/statuses/{sha}","languages_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/languages","stargazers_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/stargazers","contributors_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/contributors","subscribers_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/subscribers","subscription_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/subscription","commits_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/commits{/sha}","git_commits_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/git/commits{/sha}","comments_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/comments{/number}","issue_comment_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/issues/comments{/number}","contents_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/contents/{+path}","compare_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/merges","archive_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/downloads","issues_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/issues{/number}","pulls_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/pulls{/number}","milestones_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/milestones{/number}","notifications_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/labels{/name}","releases_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/releases{/id}","deployments_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/deployments","created_at":"2015-11-13T17:53:25Z","updated_at":"2018-05-01T11:27:17Z","pushed_at":"2018-05-15T08:46:00Z","git_url":"git://github.com/daniel-samson/SuiteCRM.git","ssh_url":"git@github.com:daniel-samson/SuiteCRM.git","clone_url":"https://github.com/daniel-samson/SuiteCRM.git","svn_url":"https://github.com/daniel-samson/SuiteCRM","homepage":"http://www.suitecrm.com","size":91258,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"salesagility:hotfix","ref":"hotfix","sha":"04561fe820c0cd23b145d4b269af27e4539ded6f","user":{"login":"salesagility","id":1450870,"avatar_url":"https://avatars1.githubusercontent.com/u/1450870?v=4","gravatar_id":"","url":"https://api.github.com/users/salesagility","html_url":"https://github.com/salesagility","followers_url":"https://api.github.com/users/salesagility/followers","following_url":"https://api.github.com/users/salesagility/following{/other_user}","gists_url":"https://api.github.com/users/salesagility/gists{/gist_id}","starred_url":"https://api.github.com/users/salesagility/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salesagility/subscriptions","organizations_url":"https://api.github.com/users/salesagility/orgs","repos_url":"https://api.github.com/users/salesagility/repos","events_url":"https://api.github.com/users/salesagility/events{/privacy}","received_events_url":"https://api.github.com/users/salesagility/received_events","type":"Organization","site_admin":false},"repo":{"id":13044600,"name":"SuiteCRM","full_name":"salesagility/SuiteCRM","owner":{"login":"salesagility","id":1450870,"avatar_url":"https://avatars1.githubusercontent.com/u/1450870?v=4","gravatar_id":"","url":"https://api.github.com/users/salesagility","html_url":"https://github.com/salesagility","followers_url":"https://api.github.com/users/salesagility/followers","following_url":"https://api.github.com/users/salesagility/following{/other_user}","gists_url":"https://api.github.com/users/salesagility/gists{/gist_id}","starred_url":"https://api.github.com/users/salesagility/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salesagility/subscriptions","organizations_url":"https://api.github.com/users/salesagility/orgs","repos_url":"https://api.github.com/users/salesagility/repos","events_url":"https://api.github.com/users/salesagility/events{/privacy}","received_events_url":"https://api.github.com/users/salesagility/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/salesagility/SuiteCRM","description":"SuiteCRM - Open source CRM for the world","fork":false,"url":"https://api.github.com/repos/salesagility/SuiteCRM","forks_url":"https://api.github.com/repos/salesagility/SuiteCRM/forks","keys_url":"https://api.github.com/repos/salesagility/SuiteCRM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/salesagility/SuiteCRM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/salesagility/SuiteCRM/teams","hooks_url":"https://api.github.com/repos/salesagility/SuiteCRM/hooks","issue_events_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/events{/number}","events_url":"https://api.github.com/repos/salesagility/SuiteCRM/events","assignees_url":"https://api.github.com/repos/salesagility/SuiteCRM/assignees{/user}","branches_url":"https://api.github.com/repos/salesagility/SuiteCRM/branches{/branch}","tags_url":"https://api.github.com/repos/salesagility/SuiteCRM/tags","blobs_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/refs{/sha}","trees_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/salesagility/SuiteCRM/statuses/{sha}","languages_url":"https://api.github.com/repos/salesagility/SuiteCRM/languages","stargazers_url":"https://api.github.com/repos/salesagility/SuiteCRM/stargazers","contributors_url":"https://api.github.com/repos/salesagility/SuiteCRM/contributors","subscribers_url":"https://api.github.com/repos/salesagility/SuiteCRM/subscribers","subscription_url":"https://api.github.com/repos/salesagility/SuiteCRM/subscription","commits_url":"https://api.github.com/repos/salesagility/SuiteCRM/commits{/sha}","git_commits_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/commits{/sha}","comments_url":"https://api.github.com/repos/salesagility/SuiteCRM/comments{/number}","issue_comment_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/comments{/number}","contents_url":"https://api.github.com/repos/salesagility/SuiteCRM/contents/{+path}","compare_url":"https://api.github.com/repos/salesagility/SuiteCRM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/salesagility/SuiteCRM/merges","archive_url":"https://api.github.com/repos/salesagility/SuiteCRM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/salesagility/SuiteCRM/downloads","issues_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues{/number}","pulls_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls{/number}","milestones_url":"https://api.github.com/repos/salesagility/SuiteCRM/milestones{/number}","notifications_url":"https://api.github.com/repos/salesagility/SuiteCRM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/salesagility/SuiteCRM/labels{/name}","releases_url":"https://api.github.com/repos/salesagility/SuiteCRM/releases{/id}","deployments_url":"https://api.github.com/repos/salesagility/SuiteCRM/deployments","created_at":"2013-09-23T19:10:08Z","updated_at":"2018-05-15T02:02:48Z","pushed_at":"2018-05-15T08:48:09Z","git_url":"git://github.com/salesagility/SuiteCRM.git","ssh_url":"git@github.com:salesagility/SuiteCRM.git","clone_url":"https://github.com/salesagility/SuiteCRM.git","svn_url":"https://github.com/salesagility/SuiteCRM","homepage":"http://www.suitecrm.com","size":91931,"stargazers_count":1002,"watchers_count":1002,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":789,"mirror_url":null,"archived":false,"open_issues_count":945,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":789,"open_issues":945,"watchers":1002,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5874"},"html":{"href":"https://github.com/salesagility/SuiteCRM/pull/5874"},"issue":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/issues/5874"},"comments":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/issues/5874/comments"},"review_comments":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5874/comments"},"review_comment":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5874/commits"},"statuses":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/statuses/3856060163320278b1937026c7cbd930ff342108"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"samus-aran"}}