{"action":"created","issue":{"url":"https://api.github.com/repos/gluster/gluster-prometheus/issues/15","repository_url":"https://api.github.com/repos/gluster/gluster-prometheus","labels_url":"https://api.github.com/repos/gluster/gluster-prometheus/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/gluster/gluster-prometheus/issues/15/comments","events_url":"https://api.github.com/repos/gluster/gluster-prometheus/issues/15/events","html_url":"https://github.com/gluster/gluster-prometheus/pull/15","id":355875045,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMzAwODgy","number":15,"title":"Added metrics for brick disks","user":{"login":"shtripat","id":6771252,"node_id":"MDQ6VXNlcjY3NzEyNTI=","avatar_url":"https://avatars0.githubusercontent.com/u/6771252?v=4","gravatar_id":"","url":"https://api.github.com/users/shtripat","html_url":"https://github.com/shtripat","followers_url":"https://api.github.com/users/shtripat/followers","following_url":"https://api.github.com/users/shtripat/following{/other_user}","gists_url":"https://api.github.com/users/shtripat/gists{/gist_id}","starred_url":"https://api.github.com/users/shtripat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shtripat/subscriptions","organizations_url":"https://api.github.com/users/shtripat/orgs","repos_url":"https://api.github.com/users/shtripat/repos","events_url":"https://api.github.com/users/shtripat/events{/privacy}","received_events_url":"https://api.github.com/users/shtripat/received_events","type":"User","site_admin":false},"labels":[{"id":1063624438,"node_id":"MDU6TGFiZWwxMDYzNjI0NDM4","url":"https://api.github.com/repos/gluster/gluster-prometheus/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"shtripat","id":6771252,"node_id":"MDQ6VXNlcjY3NzEyNTI=","avatar_url":"https://avatars0.githubusercontent.com/u/6771252?v=4","gravatar_id":"","url":"https://api.github.com/users/shtripat","html_url":"https://github.com/shtripat","followers_url":"https://api.github.com/users/shtripat/followers","following_url":"https://api.github.com/users/shtripat/following{/other_user}","gists_url":"https://api.github.com/users/shtripat/gists{/gist_id}","starred_url":"https://api.github.com/users/shtripat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shtripat/subscriptions","organizations_url":"https://api.github.com/users/shtripat/orgs","repos_url":"https://api.github.com/users/shtripat/repos","events_url":"https://api.github.com/users/shtripat/events{/privacy}","received_events_url":"https://api.github.com/users/shtripat/received_events","type":"User","site_admin":false},"assignees":[{"login":"shtripat","id":6771252,"node_id":"MDQ6VXNlcjY3NzEyNTI=","avatar_url":"https://avatars0.githubusercontent.com/u/6771252?v=4","gravatar_id":"","url":"https://api.github.com/users/shtripat","html_url":"https://github.com/shtripat","followers_url":"https://api.github.com/users/shtripat/followers","following_url":"https://api.github.com/users/shtripat/following{/other_user}","gists_url":"https://api.github.com/users/shtripat/gists{/gist_id}","starred_url":"https://api.github.com/users/shtripat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shtripat/subscriptions","organizations_url":"https://api.github.com/users/shtripat/orgs","repos_url":"https://api.github.com/users/shtripat/repos","events_url":"https://api.github.com/users/shtripat/events{/privacy}","received_events_url":"https://api.github.com/users/shtripat/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2018-08-31T07:47:29Z","updated_at":"2018-10-11T05:15:31Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/gluster/gluster-prometheus/pulls/15","html_url":"https://github.com/gluster/gluster-prometheus/pull/15","diff_url":"https://github.com/gluster/gluster-prometheus/pull/15.diff","patch_url":"https://github.com/gluster/gluster-prometheus/pull/15.patch"},"body":"The metrics exposed are\r\n- gluster_disk_read_ios\r\n- gluster_disk_read_merges\r\n- gluster_disk_read_sectors\r\n- gluster_disk_read_ticks\r\n- gluster_disk_write_ios\r\n- gluster_disk_write_merges\r\n- gluster_disk_write_sectors\r\n- gluster_disk_write_ticks\r\n- gluster_disk_inflight\r\n- gluster_disk_total_ticks\r\n- gluster_disk_time_inqueue\r\n\r\nThis expects a --brickinfo parameter for the collector and the format of the same is as below\r\n\r\n{\r\n  \"vol1\": [list_of_bricks_returned_from_gd2_bricks_get_api],\r\n  \"vol2\": [list_of_bricks_returned_from_gd2_bricks_get_api],\r\n  .....\r\n}\r\n\r\nSample metrics from prometheus looks as below\r\n\r\ngluster_disk_inflight{brick_path=\"/root/gluster_bricks/vol1_b2\",device=\"/dev/mapper/centos_....-root\",disk=\"vda\",host=\"....\",id=\"7933f8ac-ea2f-42ad-af15-ce1944bc55c5\",instance=\"....:8080\",job=\"prometheus\",subvolume=\"testvol-replicate-0\",volume=\"testvol\"}\t0\r\ngluster_disk_inflight{brick_path=\"/root/gluster_bricks/vol1_b5\",device=\"/dev/mapper/centos_....-root\",disk=\"vda\",host=\"....\",id=\"ef40df91-579e-415b-af74-6f6292fbe3f2\",instance=\"....:8080\",job=\"prometheus\",subvolume=\"testvol-replicate-1\",volume=\"testvol\"}\t0\r\ngluster_disk_inflight{brick_path=\"/root/gluster_bricks/vol3_b1\",device=\"/dev/mapper/centos_....-root\",disk=\"vda\",host=\"....\",id=\"dbe1378e-7991-44be-a70c-5f02b00f02e6\",instance=\"....:8080\",job=\"prometheus\",subvolume=\"displvol2-disperse-0\",volume=\"displvol2\"}\t0\r\ngluster_disk_read_ios{brick_path=\"/root/gluster_bricks/vol1_b2\",device=\"/dev/mapper/centos_....-root\",disk=\"vda\",host=\"....\",id=\"7933f8ac-ea2f-42ad-af15-ce1944bc55c5\",instance=\"....:8080\",job=\"prometheus\",subvolume=\"testvol-replicate-0\",volume=\"testvol\"}\t7064\r\n\r\nSigned-off-by: Shubhendu <shtripat@redhat.com>"},"comment":{"url":"https://api.github.com/repos/gluster/gluster-prometheus/issues/comments/428823480","html_url":"https://github.com/gluster/gluster-prometheus/pull/15#issuecomment-428823480","issue_url":"https://api.github.com/repos/gluster/gluster-prometheus/issues/15","id":428823480,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODgyMzQ4MA==","user":{"login":"shtripat","id":6771252,"node_id":"MDQ6VXNlcjY3NzEyNTI=","avatar_url":"https://avatars0.githubusercontent.com/u/6771252?v=4","gravatar_id":"","url":"https://api.github.com/users/shtripat","html_url":"https://github.com/shtripat","followers_url":"https://api.github.com/users/shtripat/followers","following_url":"https://api.github.com/users/shtripat/following{/other_user}","gists_url":"https://api.github.com/users/shtripat/gists{/gist_id}","starred_url":"https://api.github.com/users/shtripat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shtripat/subscriptions","organizations_url":"https://api.github.com/users/shtripat/orgs","repos_url":"https://api.github.com/users/shtripat/repos","events_url":"https://api.github.com/users/shtripat/events{/privacy}","received_events_url":"https://api.github.com/users/shtripat/received_events","type":"User","site_admin":false},"created_at":"2018-10-11T05:15:31Z","updated_at":"2018-10-11T05:15:31Z","author_association":"CONTRIBUTOR","body":">> Some time back I tried to get device details using df command. Can that be used instead of depending >> on Volume status command? https://github.com/gluster/glustercli-python/blob/master/gluster/metrics\r\n>> /diskstats.py#L98\r\n\r\nAt first look, I feel it could be used. Will try to redo this PR accordingly and check."}}
{"actor":{"display_login":"shtripat"}}