{"action":"created","issue":{"url":"https://api.github.com/repos/jetstack/cert-manager/issues/649","repository_url":"https://api.github.com/repos/jetstack/cert-manager","labels_url":"https://api.github.com/repos/jetstack/cert-manager/issues/649/labels{/name}","comments_url":"https://api.github.com/repos/jetstack/cert-manager/issues/649/comments","events_url":"https://api.github.com/repos/jetstack/cert-manager/issues/649/events","html_url":"https://github.com/jetstack/cert-manager/pull/649","id":331018484,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzODU2Mjky","number":649,"title":"Adds Kubernetes authentication type for Vault Issuer","user":{"login":"kunickiaj","id":746474,"node_id":"MDQ6VXNlcjc0NjQ3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/746474?v=4","gravatar_id":"","url":"https://api.github.com/users/kunickiaj","html_url":"https://github.com/kunickiaj","followers_url":"https://api.github.com/users/kunickiaj/followers","following_url":"https://api.github.com/users/kunickiaj/following{/other_user}","gists_url":"https://api.github.com/users/kunickiaj/gists{/gist_id}","starred_url":"https://api.github.com/users/kunickiaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunickiaj/subscriptions","organizations_url":"https://api.github.com/users/kunickiaj/orgs","repos_url":"https://api.github.com/users/kunickiaj/repos","events_url":"https://api.github.com/users/kunickiaj/events{/privacy}","received_events_url":"https://api.github.com/users/kunickiaj/received_events","type":"User","site_admin":false},"labels":[{"id":939724440,"node_id":"MDU6TGFiZWw5Mzk3MjQ0NDA=","url":"https://api.github.com/repos/jetstack/cert-manager/labels/area/provider-vault","name":"area/provider-vault","color":"0052cc","default":false},{"id":1039155671,"node_id":"MDU6TGFiZWwxMDM5MTU1Njcx","url":"https://api.github.com/repos/jetstack/cert-manager/labels/dco-signoff:%20no","name":"dco-signoff: no","color":"e11d21","default":false},{"id":728590545,"node_id":"MDU6TGFiZWw3Mjg1OTA1NDU=","url":"https://api.github.com/repos/jetstack/cert-manager/labels/needs-rebase","name":"needs-rebase","color":"BDBDBD","default":false},{"id":727722560,"node_id":"MDU6TGFiZWw3Mjc3MjI1NjA=","url":"https://api.github.com/repos/jetstack/cert-manager/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":727703419,"node_id":"MDU6TGFiZWw3Mjc3MDM0MTk=","url":"https://api.github.com/repos/jetstack/cert-manager/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"kragniz","id":735008,"node_id":"MDQ6VXNlcjczNTAwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/735008?v=4","gravatar_id":"","url":"https://api.github.com/users/kragniz","html_url":"https://github.com/kragniz","followers_url":"https://api.github.com/users/kragniz/followers","following_url":"https://api.github.com/users/kragniz/following{/other_user}","gists_url":"https://api.github.com/users/kragniz/gists{/gist_id}","starred_url":"https://api.github.com/users/kragniz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kragniz/subscriptions","organizations_url":"https://api.github.com/users/kragniz/orgs","repos_url":"https://api.github.com/users/kragniz/repos","events_url":"https://api.github.com/users/kragniz/events{/privacy}","received_events_url":"https://api.github.com/users/kragniz/received_events","type":"User","site_admin":false},"assignees":[{"login":"kragniz","id":735008,"node_id":"MDQ6VXNlcjczNTAwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/735008?v=4","gravatar_id":"","url":"https://api.github.com/users/kragniz","html_url":"https://github.com/kragniz","followers_url":"https://api.github.com/users/kragniz/followers","following_url":"https://api.github.com/users/kragniz/following{/other_user}","gists_url":"https://api.github.com/users/kragniz/gists{/gist_id}","starred_url":"https://api.github.com/users/kragniz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kragniz/subscriptions","organizations_url":"https://api.github.com/users/kragniz/orgs","repos_url":"https://api.github.com/users/kragniz/repos","events_url":"https://api.github.com/users/kragniz/events{/privacy}","received_events_url":"https://api.github.com/users/kragniz/received_events","type":"User","site_admin":false}],"milestone":null,"comments":14,"created_at":"2018-06-11T01:05:41Z","updated_at":"2018-12-11T15:54:19Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/jetstack/cert-manager/pulls/649","html_url":"https://github.com/jetstack/cert-manager/pull/649","diff_url":"https://github.com/jetstack/cert-manager/pull/649.diff","patch_url":"https://github.com/jetstack/cert-manager/pull/649.patch"},"body":"**What this PR does / why we need it**:\r\n\r\n**Which issue this PR fixes**\r\nfixes #647\r\n\r\n**Special notes for your reviewer**:\r\nSo I've actually put together a patch, and just trying to tie up the e2e tests. This requires that the VaultInitializer have a method that configures the kubernetes auth backend which requires at a minimum: the master url and CA cert.\r\n\r\nAnyone happen to know what the right way to get these in there are?\r\n\r\n**Release note**:\r\n```release-note\r\nAdds Kubernetes authentication type for Vault Issuer\r\n\r\nThis auth method uses the cert-manager's service account token to request a Vault token. See the Vault documentation for instructions on setting up the auth backend as well as the necessary role bindings on the Kubernetes side.\r\n\r\nExample configuration for using this auth method:\r\n\r\napiVersion: certmanager.k8s.io/v1alpha1\r\nkind: Issuer\r\nmetadata:\r\n  name: vault-issuer\r\n  namespace: default\r\nspec:\r\n  vault:\r\n    path: pki_int/sign/example-dot-com\r\n    server: https://vault\r\n    auth:\r\n      kubernetes:\r\n        role: \"cert-manager-role\"\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/jetstack/cert-manager/issues/comments/446253172","html_url":"https://github.com/jetstack/cert-manager/pull/649#issuecomment-446253172","issue_url":"https://api.github.com/repos/jetstack/cert-manager/issues/649","id":446253172,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjI1MzE3Mg==","user":{"login":"captncraig","id":192540,"node_id":"MDQ6VXNlcjE5MjU0MA==","avatar_url":"https://avatars2.githubusercontent.com/u/192540?v=4","gravatar_id":"","url":"https://api.github.com/users/captncraig","html_url":"https://github.com/captncraig","followers_url":"https://api.github.com/users/captncraig/followers","following_url":"https://api.github.com/users/captncraig/following{/other_user}","gists_url":"https://api.github.com/users/captncraig/gists{/gist_id}","starred_url":"https://api.github.com/users/captncraig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/captncraig/subscriptions","organizations_url":"https://api.github.com/users/captncraig/orgs","repos_url":"https://api.github.com/users/captncraig/repos","events_url":"https://api.github.com/users/captncraig/events{/privacy}","received_events_url":"https://api.github.com/users/captncraig/received_events","type":"User","site_admin":false},"created_at":"2018-12-11T15:54:19Z","updated_at":"2018-12-11T15:54:19Z","author_association":"NONE","body":"Is there anything we can do to get this feature in the near future? It would be extremely useful to have native k8s auth to vault."}}
{"actor":{"display_login":"captncraig"}}