{"action":"created","comment":{"url":"https://api.github.com/repos/sassoftware/virk/pulls/comments/187047517","pull_request_review_id":118747214,"id":187047517,"diff_hunk":"@@ -141,12 +141,17 @@ sas_yum_urls:\n   - bwp2.ses.sas.download\n   - sesbw.sas.download\n \n-## maximum number of network interfaces (excluding loopback)\n-max_num_nics: 1             ## maximum number of network interfaces (excluding loopback)\n+## maximum number of IP adresses (excluding loopback)\n+#max_num_nics: 1             ## maximum number of network interfaces (excluding loopback)\n ## the command used to count active NICs\n #nic_count_command: \"ls -A /sys/class/net | grep -v lo | wc -l\"\n #nic_count_command: \"netstat -i|grep -ve ^lo -e ^Iface -e ^Kernel | wc -l\"\n-nic_count_command: \"ip link show up | grep -ve link -e ': lo:' | wc -l\"\n+#nic_count_command: \"ip link show up | grep -ve link -e ': lo:' | wc -l\"\n+## we should be counting IPs, and not NICs.\n+##\n+max_num_priv_ips: 1             ## maximum number of network interfaces\n+#priv_ip_count_command: \"ip -4 -o addr | awk '!/^[0-9]*: ?lo|link\\\\/ether/ {gsub(\\\"/\\\", \\\" \\\"); print $4}' | wc -l\"","path":"playbooks/pre-install-playbook/roles/virk.preinstall/defaults/main.yml","position":16,"original_position":16,"commit_id":"a0697f3dd886014af0d933bf02aa87feb95c6fed","original_commit_id":"a0697f3dd886014af0d933bf02aa87feb95c6fed","user":{"login":"erwangranger","id":32554862,"avatar_url":"https://avatars2.githubusercontent.com/u/32554862?v=4","gravatar_id":"","url":"https://api.github.com/users/erwangranger","html_url":"https://github.com/erwangranger","followers_url":"https://api.github.com/users/erwangranger/followers","following_url":"https://api.github.com/users/erwangranger/following{/other_user}","gists_url":"https://api.github.com/users/erwangranger/gists{/gist_id}","starred_url":"https://api.github.com/users/erwangranger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwangranger/subscriptions","organizations_url":"https://api.github.com/users/erwangranger/orgs","repos_url":"https://api.github.com/users/erwangranger/repos","events_url":"https://api.github.com/users/erwangranger/events{/privacy}","received_events_url":"https://api.github.com/users/erwangranger/received_events","type":"User","site_admin":false},"body":"No particular reason. I commented it out when I switched to the new implementation, and forgot to remove it after I confirmed the new method worked. ","created_at":"2018-05-09T13:54:33Z","updated_at":"2018-05-09T13:54:33Z","html_url":"https://github.com/sassoftware/virk/pull/38#discussion_r187047517","pull_request_url":"https://api.github.com/repos/sassoftware/virk/pulls/38","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/sassoftware/virk/pulls/comments/187047517"},"html":{"href":"https://github.com/sassoftware/virk/pull/38#discussion_r187047517"},"pull_request":{"href":"https://api.github.com/repos/sassoftware/virk/pulls/38"}},"in_reply_to_id":187043437},"pull_request":{"url":"https://api.github.com/repos/sassoftware/virk/pulls/38","id":186921014,"html_url":"https://github.com/sassoftware/virk/pull/38","diff_url":"https://github.com/sassoftware/virk/pull/38.diff","patch_url":"https://github.com/sassoftware/virk/pull/38.patch","issue_url":"https://api.github.com/repos/sassoftware/virk/issues/38","number":38,"state":"open","locked":false,"title":"Viya 3.3 dev","user":{"login":"screnshaw","id":28984733,"avatar_url":"https://avatars2.githubusercontent.com/u/28984733?v=4","gravatar_id":"","url":"https://api.github.com/users/screnshaw","html_url":"https://github.com/screnshaw","followers_url":"https://api.github.com/users/screnshaw/followers","following_url":"https://api.github.com/users/screnshaw/following{/other_user}","gists_url":"https://api.github.com/users/screnshaw/gists{/gist_id}","starred_url":"https://api.github.com/users/screnshaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screnshaw/subscriptions","organizations_url":"https://api.github.com/users/screnshaw/orgs","repos_url":"https://api.github.com/users/screnshaw/repos","events_url":"https://api.github.com/users/screnshaw/events{/privacy}","received_events_url":"https://api.github.com/users/screnshaw/received_events","type":"User","site_admin":false},"body":"merging 3.3-dev nic and task cleanup.","created_at":"2018-05-09T13:25:07Z","updated_at":"2018-05-09T13:54:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9bbbe455ca7bcf13d8e0a3312b78555ec91b7bb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sassoftware/virk/pulls/38/commits","review_comments_url":"https://api.github.com/repos/sassoftware/virk/pulls/38/comments","review_comment_url":"https://api.github.com/repos/sassoftware/virk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sassoftware/virk/issues/38/comments","statuses_url":"https://api.github.com/repos/sassoftware/virk/statuses/a0697f3dd886014af0d933bf02aa87feb95c6fed","head":{"label":"sassoftware:viya-3.3-dev","ref":"viya-3.3-dev","sha":"a0697f3dd886014af0d933bf02aa87feb95c6fed","user":{"login":"sassoftware","id":5289877,"avatar_url":"https://avatars0.githubusercontent.com/u/5289877?v=4","gravatar_id":"","url":"https://api.github.com/users/sassoftware","html_url":"https://github.com/sassoftware","followers_url":"https://api.github.com/users/sassoftware/followers","following_url":"https://api.github.com/users/sassoftware/following{/other_user}","gists_url":"https://api.github.com/users/sassoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/sassoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sassoftware/subscriptions","organizations_url":"https://api.github.com/users/sassoftware/orgs","repos_url":"https://api.github.com/users/sassoftware/repos","events_url":"https://api.github.com/users/sassoftware/events{/privacy}","received_events_url":"https://api.github.com/users/sassoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":105686471,"name":"virk","full_name":"sassoftware/virk","owner":{"login":"sassoftware","id":5289877,"avatar_url":"https://avatars0.githubusercontent.com/u/5289877?v=4","gravatar_id":"","url":"https://api.github.com/users/sassoftware","html_url":"https://github.com/sassoftware","followers_url":"https://api.github.com/users/sassoftware/followers","following_url":"https://api.github.com/users/sassoftware/following{/other_user}","gists_url":"https://api.github.com/users/sassoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/sassoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sassoftware/subscriptions","organizations_url":"https://api.github.com/users/sassoftware/orgs","repos_url":"https://api.github.com/users/sassoftware/repos","events_url":"https://api.github.com/users/sassoftware/events{/privacy}","received_events_url":"https://api.github.com/users/sassoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sassoftware/virk","description":"SAS Viya Infrastructure Resource Kit (VIRK).  Tools and utilities to help SAS customers with SAS Viya readiness.","fork":false,"url":"https://api.github.com/repos/sassoftware/virk","forks_url":"https://api.github.com/repos/sassoftware/virk/forks","keys_url":"https://api.github.com/repos/sassoftware/virk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sassoftware/virk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sassoftware/virk/teams","hooks_url":"https://api.github.com/repos/sassoftware/virk/hooks","issue_events_url":"https://api.github.com/repos/sassoftware/virk/issues/events{/number}","events_url":"https://api.github.com/repos/sassoftware/virk/events","assignees_url":"https://api.github.com/repos/sassoftware/virk/assignees{/user}","branches_url":"https://api.github.com/repos/sassoftware/virk/branches{/branch}","tags_url":"https://api.github.com/repos/sassoftware/virk/tags","blobs_url":"https://api.github.com/repos/sassoftware/virk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sassoftware/virk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sassoftware/virk/git/refs{/sha}","trees_url":"https://api.github.com/repos/sassoftware/virk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sassoftware/virk/statuses/{sha}","languages_url":"https://api.github.com/repos/sassoftware/virk/languages","stargazers_url":"https://api.github.com/repos/sassoftware/virk/stargazers","contributors_url":"https://api.github.com/repos/sassoftware/virk/contributors","subscribers_url":"https://api.github.com/repos/sassoftware/virk/subscribers","subscription_url":"https://api.github.com/repos/sassoftware/virk/subscription","commits_url":"https://api.github.com/repos/sassoftware/virk/commits{/sha}","git_commits_url":"https://api.github.com/repos/sassoftware/virk/git/commits{/sha}","comments_url":"https://api.github.com/repos/sassoftware/virk/comments{/number}","issue_comment_url":"https://api.github.com/repos/sassoftware/virk/issues/comments{/number}","contents_url":"https://api.github.com/repos/sassoftware/virk/contents/{+path}","compare_url":"https://api.github.com/repos/sassoftware/virk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sassoftware/virk/merges","archive_url":"https://api.github.com/repos/sassoftware/virk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sassoftware/virk/downloads","issues_url":"https://api.github.com/repos/sassoftware/virk/issues{/number}","pulls_url":"https://api.github.com/repos/sassoftware/virk/pulls{/number}","milestones_url":"https://api.github.com/repos/sassoftware/virk/milestones{/number}","notifications_url":"https://api.github.com/repos/sassoftware/virk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sassoftware/virk/labels{/name}","releases_url":"https://api.github.com/repos/sassoftware/virk/releases{/id}","deployments_url":"https://api.github.com/repos/sassoftware/virk/deployments","created_at":"2017-10-03T18:16:40Z","updated_at":"2018-05-07T12:48:28Z","pushed_at":"2018-05-09T13:25:08Z","git_url":"git://github.com/sassoftware/virk.git","ssh_url":"git@github.com:sassoftware/virk.git","clone_url":"https://github.com/sassoftware/virk.git","svn_url":"https://github.com/sassoftware/virk","homepage":null,"size":116,"stargazers_count":14,"watchers_count":14,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":8,"open_issues":9,"watchers":14,"default_branch":"master"}},"base":{"label":"sassoftware:viya-3.3","ref":"viya-3.3","sha":"3ca35b3a8a941b966a803d1899001ae78581fdab","user":{"login":"sassoftware","id":5289877,"avatar_url":"https://avatars0.githubusercontent.com/u/5289877?v=4","gravatar_id":"","url":"https://api.github.com/users/sassoftware","html_url":"https://github.com/sassoftware","followers_url":"https://api.github.com/users/sassoftware/followers","following_url":"https://api.github.com/users/sassoftware/following{/other_user}","gists_url":"https://api.github.com/users/sassoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/sassoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sassoftware/subscriptions","organizations_url":"https://api.github.com/users/sassoftware/orgs","repos_url":"https://api.github.com/users/sassoftware/repos","events_url":"https://api.github.com/users/sassoftware/events{/privacy}","received_events_url":"https://api.github.com/users/sassoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":105686471,"name":"virk","full_name":"sassoftware/virk","owner":{"login":"sassoftware","id":5289877,"avatar_url":"https://avatars0.githubusercontent.com/u/5289877?v=4","gravatar_id":"","url":"https://api.github.com/users/sassoftware","html_url":"https://github.com/sassoftware","followers_url":"https://api.github.com/users/sassoftware/followers","following_url":"https://api.github.com/users/sassoftware/following{/other_user}","gists_url":"https://api.github.com/users/sassoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/sassoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sassoftware/subscriptions","organizations_url":"https://api.github.com/users/sassoftware/orgs","repos_url":"https://api.github.com/users/sassoftware/repos","events_url":"https://api.github.com/users/sassoftware/events{/privacy}","received_events_url":"https://api.github.com/users/sassoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sassoftware/virk","description":"SAS Viya Infrastructure Resource Kit (VIRK).  Tools and utilities to help SAS customers with SAS Viya readiness.","fork":false,"url":"https://api.github.com/repos/sassoftware/virk","forks_url":"https://api.github.com/repos/sassoftware/virk/forks","keys_url":"https://api.github.com/repos/sassoftware/virk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sassoftware/virk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sassoftware/virk/teams","hooks_url":"https://api.github.com/repos/sassoftware/virk/hooks","issue_events_url":"https://api.github.com/repos/sassoftware/virk/issues/events{/number}","events_url":"https://api.github.com/repos/sassoftware/virk/events","assignees_url":"https://api.github.com/repos/sassoftware/virk/assignees{/user}","branches_url":"https://api.github.com/repos/sassoftware/virk/branches{/branch}","tags_url":"https://api.github.com/repos/sassoftware/virk/tags","blobs_url":"https://api.github.com/repos/sassoftware/virk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sassoftware/virk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sassoftware/virk/git/refs{/sha}","trees_url":"https://api.github.com/repos/sassoftware/virk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sassoftware/virk/statuses/{sha}","languages_url":"https://api.github.com/repos/sassoftware/virk/languages","stargazers_url":"https://api.github.com/repos/sassoftware/virk/stargazers","contributors_url":"https://api.github.com/repos/sassoftware/virk/contributors","subscribers_url":"https://api.github.com/repos/sassoftware/virk/subscribers","subscription_url":"https://api.github.com/repos/sassoftware/virk/subscription","commits_url":"https://api.github.com/repos/sassoftware/virk/commits{/sha}","git_commits_url":"https://api.github.com/repos/sassoftware/virk/git/commits{/sha}","comments_url":"https://api.github.com/repos/sassoftware/virk/comments{/number}","issue_comment_url":"https://api.github.com/repos/sassoftware/virk/issues/comments{/number}","contents_url":"https://api.github.com/repos/sassoftware/virk/contents/{+path}","compare_url":"https://api.github.com/repos/sassoftware/virk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sassoftware/virk/merges","archive_url":"https://api.github.com/repos/sassoftware/virk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sassoftware/virk/downloads","issues_url":"https://api.github.com/repos/sassoftware/virk/issues{/number}","pulls_url":"https://api.github.com/repos/sassoftware/virk/pulls{/number}","milestones_url":"https://api.github.com/repos/sassoftware/virk/milestones{/number}","notifications_url":"https://api.github.com/repos/sassoftware/virk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sassoftware/virk/labels{/name}","releases_url":"https://api.github.com/repos/sassoftware/virk/releases{/id}","deployments_url":"https://api.github.com/repos/sassoftware/virk/deployments","created_at":"2017-10-03T18:16:40Z","updated_at":"2018-05-07T12:48:28Z","pushed_at":"2018-05-09T13:25:08Z","git_url":"git://github.com/sassoftware/virk.git","ssh_url":"git@github.com:sassoftware/virk.git","clone_url":"https://github.com/sassoftware/virk.git","svn_url":"https://github.com/sassoftware/virk","homepage":null,"size":116,"stargazers_count":14,"watchers_count":14,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":8,"open_issues":9,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sassoftware/virk/pulls/38"},"html":{"href":"https://github.com/sassoftware/virk/pull/38"},"issue":{"href":"https://api.github.com/repos/sassoftware/virk/issues/38"},"comments":{"href":"https://api.github.com/repos/sassoftware/virk/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/sassoftware/virk/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/sassoftware/virk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sassoftware/virk/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/sassoftware/virk/statuses/a0697f3dd886014af0d933bf02aa87feb95c6fed"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"erwangranger"}}