{"action":"created","comment":{"url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/pulls/comments/210092178","pull_request_review_id":146237758,"id":210092178,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDA5MjE3OA==","diff_hunk":"@@ -11,19 +11,32 @@ fi\n \n ok=yes\n vault=\"secret/$GENESIS_VAULT_PREFIX\"\n-domain=\"$(lookup params.static_ip)\"","path":"hooks/check","position":4,"original_position":4,"commit_id":"f6b203fa9ebb578f48a53e609a6459d841144db3","original_commit_id":"f6b203fa9ebb578f48a53e609a6459d841144db3","user":{"login":"dennisjbell","id":20423,"node_id":"MDQ6VXNlcjIwNDIz","avatar_url":"https://avatars0.githubusercontent.com/u/20423?v=4","gravatar_id":"","url":"https://api.github.com/users/dennisjbell","html_url":"https://github.com/dennisjbell","followers_url":"https://api.github.com/users/dennisjbell/followers","following_url":"https://api.github.com/users/dennisjbell/following{/other_user}","gists_url":"https://api.github.com/users/dennisjbell/gists{/gist_id}","starred_url":"https://api.github.com/users/dennisjbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dennisjbell/subscriptions","organizations_url":"https://api.github.com/users/dennisjbell/orgs","repos_url":"https://api.github.com/users/dennisjbell/repos","events_url":"https://api.github.com/users/dennisjbell/events{/privacy}","received_events_url":"https://api.github.com/users/dennisjbell/received_events","type":"User","site_admin":false},"body":"instead of removing this value, you should replace it with:\r\n```\r\nstatic_ip=\"$(lookup params.static_IP)\"\r\ndomain=\"$(lookup params.external_domain \"$static_ip\")\"\r\n```\r\nthen reference those values below.  This is because `lookup` is a very time-consuming task and will significantly slow down this script.","created_at":"2018-08-14T20:27:27Z","updated_at":"2018-08-14T20:31:44Z","html_url":"https://github.com/genesis-community/prometheus-genesis-kit/pull/5#discussion_r210092178","pull_request_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/pulls/5","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/pulls/comments/210092178"},"html":{"href":"https://github.com/genesis-community/prometheus-genesis-kit/pull/5#discussion_r210092178"},"pull_request":{"href":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/pulls/5","id":208397040,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4Mzk3MDQw","html_url":"https://github.com/genesis-community/prometheus-genesis-kit/pull/5","diff_url":"https://github.com/genesis-community/prometheus-genesis-kit/pull/5.diff","patch_url":"https://github.com/genesis-community/prometheus-genesis-kit/pull/5.patch","issue_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/issues/5","number":5,"state":"open","locked":false,"title":"fix for issue #4.","user":{"login":"patrick1378","id":21988571,"node_id":"MDQ6VXNlcjIxOTg4NTcx","avatar_url":"https://avatars3.githubusercontent.com/u/21988571?v=4","gravatar_id":"","url":"https://api.github.com/users/patrick1378","html_url":"https://github.com/patrick1378","followers_url":"https://api.github.com/users/patrick1378/followers","following_url":"https://api.github.com/users/patrick1378/following{/other_user}","gists_url":"https://api.github.com/users/patrick1378/gists{/gist_id}","starred_url":"https://api.github.com/users/patrick1378/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrick1378/subscriptions","organizations_url":"https://api.github.com/users/patrick1378/orgs","repos_url":"https://api.github.com/users/patrick1378/repos","events_url":"https://api.github.com/users/patrick1378/events{/privacy}","received_events_url":"https://api.github.com/users/patrick1378/received_events","type":"User","site_admin":false},"body":"This is a fix for #4.\r\nIf an external domain is specified that is not the static ip used to deploy Prometheus, we now check the validity of that domain and will throw a warning if the ip is not present on the cert.\r\n\r\nTested on lab with:\r\n- a kit generated cert with no external domain specified (ip only)\r\n- a safe generated cert for a test domain but missing the static ip from the san. (to test warning)\r\n- a safe generated cert with a test domain and the correct ip used to deploy Prometheus ","created_at":"2018-08-14T20:14:23Z","updated_at":"2018-08-14T20:31:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4bc1a000cb20c7ac3c9ee92caf58bb01c7fc384","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jhunt","id":20047,"node_id":"MDQ6VXNlcjIwMDQ3","avatar_url":"https://avatars2.githubusercontent.com/u/20047?v=4","gravatar_id":"","url":"https://api.github.com/users/jhunt","html_url":"https://github.com/jhunt","followers_url":"https://api.github.com/users/jhunt/followers","following_url":"https://api.github.com/users/jhunt/following{/other_user}","gists_url":"https://api.github.com/users/jhunt/gists{/gist_id}","starred_url":"https://api.github.com/users/jhunt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhunt/subscriptions","organizations_url":"https://api.github.com/users/jhunt/orgs","repos_url":"https://api.github.com/users/jhunt/repos","events_url":"https://api.github.com/users/jhunt/events{/privacy}","received_events_url":"https://api.github.com/users/jhunt/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/pulls/5/commits","review_comments_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/pulls/5/comments","review_comment_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/issues/5/comments","statuses_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/statuses/f6b203fa9ebb578f48a53e609a6459d841144db3","head":{"label":"genesis-community:external-domain","ref":"external-domain","sha":"f6b203fa9ebb578f48a53e609a6459d841144db3","user":{"login":"genesis-community","id":25448287,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NDQ4Mjg3","avatar_url":"https://avatars2.githubusercontent.com/u/25448287?v=4","gravatar_id":"","url":"https://api.github.com/users/genesis-community","html_url":"https://github.com/genesis-community","followers_url":"https://api.github.com/users/genesis-community/followers","following_url":"https://api.github.com/users/genesis-community/following{/other_user}","gists_url":"https://api.github.com/users/genesis-community/gists{/gist_id}","starred_url":"https://api.github.com/users/genesis-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genesis-community/subscriptions","organizations_url":"https://api.github.com/users/genesis-community/orgs","repos_url":"https://api.github.com/users/genesis-community/repos","events_url":"https://api.github.com/users/genesis-community/events{/privacy}","received_events_url":"https://api.github.com/users/genesis-community/received_events","type":"Organization","site_admin":false},"repo":{"id":95017907,"node_id":"MDEwOlJlcG9zaXRvcnk5NTAxNzkwNw==","name":"prometheus-genesis-kit","full_name":"genesis-community/prometheus-genesis-kit","owner":{"login":"genesis-community","id":25448287,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NDQ4Mjg3","avatar_url":"https://avatars2.githubusercontent.com/u/25448287?v=4","gravatar_id":"","url":"https://api.github.com/users/genesis-community","html_url":"https://github.com/genesis-community","followers_url":"https://api.github.com/users/genesis-community/followers","following_url":"https://api.github.com/users/genesis-community/following{/other_user}","gists_url":"https://api.github.com/users/genesis-community/gists{/gist_id}","starred_url":"https://api.github.com/users/genesis-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genesis-community/subscriptions","organizations_url":"https://api.github.com/users/genesis-community/orgs","repos_url":"https://api.github.com/users/genesis-community/repos","events_url":"https://api.github.com/users/genesis-community/events{/privacy}","received_events_url":"https://api.github.com/users/genesis-community/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/genesis-community/prometheus-genesis-kit","description":"Genesis Kit for Prometheus","fork":false,"url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit","forks_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/forks","keys_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/teams","hooks_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/hooks","issue_events_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/issues/events{/number}","events_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/events","assignees_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/assignees{/user}","branches_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/branches{/branch}","tags_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/tags","blobs_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/languages","stargazers_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/stargazers","contributors_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/contributors","subscribers_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/subscribers","subscription_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/subscription","commits_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/contents/{+path}","compare_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/merges","archive_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/downloads","issues_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/issues{/number}","pulls_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/labels{/name}","releases_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/releases{/id}","deployments_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/deployments","created_at":"2017-06-21T15:19:08Z","updated_at":"2018-08-09T13:20:08Z","pushed_at":"2018-08-14T20:14:23Z","git_url":"git://github.com/genesis-community/prometheus-genesis-kit.git","ssh_url":"git@github.com:genesis-community/prometheus-genesis-kit.git","clone_url":"https://github.com/genesis-community/prometheus-genesis-kit.git","svn_url":"https://github.com/genesis-community/prometheus-genesis-kit","homepage":null,"size":43,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"genesis-community:master","ref":"master","sha":"6685a51681ad8a64f67d42857ea37cf05a0d7894","user":{"login":"genesis-community","id":25448287,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NDQ4Mjg3","avatar_url":"https://avatars2.githubusercontent.com/u/25448287?v=4","gravatar_id":"","url":"https://api.github.com/users/genesis-community","html_url":"https://github.com/genesis-community","followers_url":"https://api.github.com/users/genesis-community/followers","following_url":"https://api.github.com/users/genesis-community/following{/other_user}","gists_url":"https://api.github.com/users/genesis-community/gists{/gist_id}","starred_url":"https://api.github.com/users/genesis-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genesis-community/subscriptions","organizations_url":"https://api.github.com/users/genesis-community/orgs","repos_url":"https://api.github.com/users/genesis-community/repos","events_url":"https://api.github.com/users/genesis-community/events{/privacy}","received_events_url":"https://api.github.com/users/genesis-community/received_events","type":"Organization","site_admin":false},"repo":{"id":95017907,"node_id":"MDEwOlJlcG9zaXRvcnk5NTAxNzkwNw==","name":"prometheus-genesis-kit","full_name":"genesis-community/prometheus-genesis-kit","owner":{"login":"genesis-community","id":25448287,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NDQ4Mjg3","avatar_url":"https://avatars2.githubusercontent.com/u/25448287?v=4","gravatar_id":"","url":"https://api.github.com/users/genesis-community","html_url":"https://github.com/genesis-community","followers_url":"https://api.github.com/users/genesis-community/followers","following_url":"https://api.github.com/users/genesis-community/following{/other_user}","gists_url":"https://api.github.com/users/genesis-community/gists{/gist_id}","starred_url":"https://api.github.com/users/genesis-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genesis-community/subscriptions","organizations_url":"https://api.github.com/users/genesis-community/orgs","repos_url":"https://api.github.com/users/genesis-community/repos","events_url":"https://api.github.com/users/genesis-community/events{/privacy}","received_events_url":"https://api.github.com/users/genesis-community/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/genesis-community/prometheus-genesis-kit","description":"Genesis Kit for Prometheus","fork":false,"url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit","forks_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/forks","keys_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/teams","hooks_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/hooks","issue_events_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/issues/events{/number}","events_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/events","assignees_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/assignees{/user}","branches_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/branches{/branch}","tags_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/tags","blobs_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/languages","stargazers_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/stargazers","contributors_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/contributors","subscribers_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/subscribers","subscription_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/subscription","commits_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/contents/{+path}","compare_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/merges","archive_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/downloads","issues_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/issues{/number}","pulls_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/labels{/name}","releases_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/releases{/id}","deployments_url":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/deployments","created_at":"2017-06-21T15:19:08Z","updated_at":"2018-08-09T13:20:08Z","pushed_at":"2018-08-14T20:14:23Z","git_url":"git://github.com/genesis-community/prometheus-genesis-kit.git","ssh_url":"git@github.com:genesis-community/prometheus-genesis-kit.git","clone_url":"https://github.com/genesis-community/prometheus-genesis-kit.git","svn_url":"https://github.com/genesis-community/prometheus-genesis-kit","homepage":null,"size":43,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/pulls/5"},"html":{"href":"https://github.com/genesis-community/prometheus-genesis-kit/pull/5"},"issue":{"href":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/issues/5"},"comments":{"href":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/genesis-community/prometheus-genesis-kit/statuses/f6b203fa9ebb578f48a53e609a6459d841144db3"}},"author_association":"NONE"}}
{"actor":{"display_login":"dennisjbell"}}