{"action":"created","issue":{"url":"https://api.github.com/repos/ceph/ceph/issues/24727","repository_url":"https://api.github.com/repos/ceph/ceph","labels_url":"https://api.github.com/repos/ceph/ceph/issues/24727/labels{/name}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/24727/comments","events_url":"https://api.github.com/repos/ceph/ceph/issues/24727/events","html_url":"https://github.com/ceph/ceph/pull/24727","id":373239816,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MjE2MDA2","number":24727,"title":"mgr/dashboard: Enable gzip compression","user":{"login":"zmc","id":58307,"node_id":"MDQ6VXNlcjU4MzA3","avatar_url":"https://avatars1.githubusercontent.com/u/58307?v=4","gravatar_id":"","url":"https://api.github.com/users/zmc","html_url":"https://github.com/zmc","followers_url":"https://api.github.com/users/zmc/followers","following_url":"https://api.github.com/users/zmc/following{/other_user}","gists_url":"https://api.github.com/users/zmc/gists{/gist_id}","starred_url":"https://api.github.com/users/zmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmc/subscriptions","organizations_url":"https://api.github.com/users/zmc/orgs","repos_url":"https://api.github.com/users/zmc/repos","events_url":"https://api.github.com/users/zmc/events{/privacy}","received_events_url":"https://api.github.com/users/zmc/received_events","type":"User","site_admin":false},"labels":[{"id":850326757,"node_id":"MDU6TGFiZWw4NTAzMjY3NTc=","url":"https://api.github.com/repos/ceph/ceph/labels/dashboard","name":"dashboard","color":"68a2c1","default":false},{"id":148431321,"node_id":"MDU6TGFiZWwxNDg0MzEzMjE=","url":"https://api.github.com/repos/ceph/ceph/labels/needs-qa","name":"needs-qa","color":"fad8c7","default":false},{"id":340048817,"node_id":"MDU6TGFiZWwzNDAwNDg4MTc=","url":"https://api.github.com/repos/ceph/ceph/labels/needs-review","name":"needs-review","color":"d4c5f9","default":false},{"id":204137300,"node_id":"MDU6TGFiZWwyMDQxMzczMDA=","url":"https://api.github.com/repos/ceph/ceph/labels/performance","name":"performance","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-23T23:12:16Z","updated_at":"2018-10-24T22:07:00Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/24727","html_url":"https://github.com/ceph/ceph/pull/24727","diff_url":"https://github.com/ceph/ceph/pull/24727.diff","patch_url":"https://github.com/ceph/ceph/pull/24727.patch"},"body":"This is related to http://tracker.ceph.com/issues/36453. It is far from\r\na complete solution, but seems like a positive move.\r\n\r\nI tested this change by first disabling my browser cache, and then used\r\nthe /docs endpoint to query /api/dashboard/health. Before compression:\r\n\r\n    Content-Length: 60748\r\n    Time: 615ms\r\n\r\nAfter:\r\n\r\n    Content-Length: 7505\r\n    Time: 92ms\r\n\r\nThen, I logged into the dashboard as normal and reloaded the page once I\r\nwas in. Some values for the reload operation before compression:\r\n\r\n    Total page load time: 58.48s\r\n    vendor.js Content-Length: 6486025\r\n    vendor.js time: 48.09s\r\n\r\nAfter:\r\n\r\n    Total page load time: 14.55s\r\n    vendor.js Content-Length: 1143178\r\n    vendor.js time: 4.50s\r\n\r\nSigned-off-by: Zack Cerza <zack@redhat.com>"},"comment":{"url":"https://api.github.com/repos/ceph/ceph/issues/comments/432844835","html_url":"https://github.com/ceph/ceph/pull/24727#issuecomment-432844835","issue_url":"https://api.github.com/repos/ceph/ceph/issues/24727","id":432844835,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjg0NDgzNQ==","user":{"login":"zmc","id":58307,"node_id":"MDQ6VXNlcjU4MzA3","avatar_url":"https://avatars1.githubusercontent.com/u/58307?v=4","gravatar_id":"","url":"https://api.github.com/users/zmc","html_url":"https://github.com/zmc","followers_url":"https://api.github.com/users/zmc/followers","following_url":"https://api.github.com/users/zmc/following{/other_user}","gists_url":"https://api.github.com/users/zmc/gists{/gist_id}","starred_url":"https://api.github.com/users/zmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmc/subscriptions","organizations_url":"https://api.github.com/users/zmc/orgs","repos_url":"https://api.github.com/users/zmc/repos","events_url":"https://api.github.com/users/zmc/events{/privacy}","received_events_url":"https://api.github.com/users/zmc/received_events","type":"User","site_admin":false},"created_at":"2018-10-24T22:07:00Z","updated_at":"2018-10-24T22:07:00Z","author_association":"MEMBER","body":"@sebastian-philipp Thanks for reminding me - I just pushed two tests. One ensures we actually use gzip by default, and the other checks that passing an Accept-Encoding header that is missing 'gzip' results in an uncompressed response."}}
{"actor":{"display_login":"zmc"}}