{"action":"opened","number":25,"pull_request":{"url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/pulls/25","id":181042233,"html_url":"https://github.com/logstash-plugins/logstash-input-google_pubsub/pull/25","diff_url":"https://github.com/logstash-plugins/logstash-input-google_pubsub/pull/25.diff","patch_url":"https://github.com/logstash-plugins/logstash-input-google_pubsub/pull/25.patch","issue_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/issues/25","number":25,"state":"open","locked":false,"title":"Skip sending acks if ids are empty","user":{"login":"josephlewis42","id":696193,"avatar_url":"https://avatars0.githubusercontent.com/u/696193?v=4","gravatar_id":"","url":"https://api.github.com/users/josephlewis42","html_url":"https://github.com/josephlewis42","followers_url":"https://api.github.com/users/josephlewis42/followers","following_url":"https://api.github.com/users/josephlewis42/following{/other_user}","gists_url":"https://api.github.com/users/josephlewis42/gists{/gist_id}","starred_url":"https://api.github.com/users/josephlewis42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephlewis42/subscriptions","organizations_url":"https://api.github.com/users/josephlewis42/orgs","repos_url":"https://api.github.com/users/josephlewis42/repos","events_url":"https://api.github.com/users/josephlewis42/events{/privacy}","received_events_url":"https://api.github.com/users/josephlewis42/received_events","type":"User","site_admin":false},"body":"This is a low-touch fix for #14 where errors are being thrown because Pub/Sub doesn't expect acknowledge requests with an empty array of IDs. If accepted, it will invalidate PRs #22 and #18.\r\n\r\n@jakelandis I'm tagging you because you were part of the review for #18 \r\n\r\nI'm not doing any major refactoring because @rosbo and I are looking at moving this over to the Java API soon to follow suit with `logstash-output-google_bigquery` and `logstash-output-google_cloud_storage`.","created_at":"2018-04-11T22:11:49Z","updated_at":"2018-04-11T22:11:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/pulls/25/commits","review_comments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/pulls/25/comments","review_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/pulls/comments{/number}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/issues/25/comments","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/statuses/5fb9ba3007764bc3d71c7b9e7972ef0aa34ba99b","head":{"label":"josephlewis42:skip-empty-acks","ref":"skip-empty-acks","sha":"5fb9ba3007764bc3d71c7b9e7972ef0aa34ba99b","user":{"login":"josephlewis42","id":696193,"avatar_url":"https://avatars0.githubusercontent.com/u/696193?v=4","gravatar_id":"","url":"https://api.github.com/users/josephlewis42","html_url":"https://github.com/josephlewis42","followers_url":"https://api.github.com/users/josephlewis42/followers","following_url":"https://api.github.com/users/josephlewis42/following{/other_user}","gists_url":"https://api.github.com/users/josephlewis42/gists{/gist_id}","starred_url":"https://api.github.com/users/josephlewis42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephlewis42/subscriptions","organizations_url":"https://api.github.com/users/josephlewis42/orgs","repos_url":"https://api.github.com/users/josephlewis42/repos","events_url":"https://api.github.com/users/josephlewis42/events{/privacy}","received_events_url":"https://api.github.com/users/josephlewis42/received_events","type":"User","site_admin":false},"repo":{"id":126866460,"name":"logstash-input-google_pubsub","full_name":"josephlewis42/logstash-input-google_pubsub","owner":{"login":"josephlewis42","id":696193,"avatar_url":"https://avatars0.githubusercontent.com/u/696193?v=4","gravatar_id":"","url":"https://api.github.com/users/josephlewis42","html_url":"https://github.com/josephlewis42","followers_url":"https://api.github.com/users/josephlewis42/followers","following_url":"https://api.github.com/users/josephlewis42/following{/other_user}","gists_url":"https://api.github.com/users/josephlewis42/gists{/gist_id}","starred_url":"https://api.github.com/users/josephlewis42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephlewis42/subscriptions","organizations_url":"https://api.github.com/users/josephlewis42/orgs","repos_url":"https://api.github.com/users/josephlewis42/repos","events_url":"https://api.github.com/users/josephlewis42/events{/privacy}","received_events_url":"https://api.github.com/users/josephlewis42/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/josephlewis42/logstash-input-google_pubsub","description":"Logstash input for pulling events from Google Pub/Sub service","fork":true,"url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub","forks_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/forks","keys_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/teams","hooks_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/hooks","issue_events_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/issues/events{/number}","events_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/events","assignees_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/assignees{/user}","branches_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/branches{/branch}","tags_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/tags","blobs_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/git/refs{/sha}","trees_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/statuses/{sha}","languages_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/languages","stargazers_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/stargazers","contributors_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/contributors","subscribers_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/subscribers","subscription_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/subscription","commits_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/commits{/sha}","git_commits_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/git/commits{/sha}","comments_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/comments{/number}","issue_comment_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/issues/comments{/number}","contents_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/contents/{+path}","compare_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/merges","archive_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/downloads","issues_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/issues{/number}","pulls_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/pulls{/number}","milestones_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/milestones{/number}","notifications_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/labels{/name}","releases_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/releases{/id}","deployments_url":"https://api.github.com/repos/josephlewis42/logstash-input-google_pubsub/deployments","created_at":"2018-03-26T17:41:50Z","updated_at":"2018-03-26T17:41:52Z","pushed_at":"2018-04-11T21:39:30Z","git_url":"git://github.com/josephlewis42/logstash-input-google_pubsub.git","ssh_url":"git@github.com:josephlewis42/logstash-input-google_pubsub.git","clone_url":"https://github.com/josephlewis42/logstash-input-google_pubsub.git","svn_url":"https://github.com/josephlewis42/logstash-input-google_pubsub","homepage":null,"size":34,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"logstash-plugins:master","ref":"master","sha":"bf479329cbc3843753c31ca4637c82002c7e3383","user":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars1.githubusercontent.com/u/8961934?v=4","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"repo":{"id":72584140,"name":"logstash-input-google_pubsub","full_name":"logstash-plugins/logstash-input-google_pubsub","owner":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars1.githubusercontent.com/u/8961934?v=4","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/logstash-plugins/logstash-input-google_pubsub","description":"Logstash input for pulling events from Google Pub/Sub service","fork":false,"url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub","forks_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/forks","keys_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/teams","hooks_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/hooks","issue_events_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/issues/events{/number}","events_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/events","assignees_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/assignees{/user}","branches_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/branches{/branch}","tags_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/tags","blobs_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/git/refs{/sha}","trees_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/statuses/{sha}","languages_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/languages","stargazers_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/stargazers","contributors_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/contributors","subscribers_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/subscribers","subscription_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/subscription","commits_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/commits{/sha}","git_commits_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/git/commits{/sha}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/comments{/number}","issue_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/issues/comments{/number}","contents_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/contents/{+path}","compare_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/merges","archive_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/downloads","issues_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/issues{/number}","pulls_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/pulls{/number}","milestones_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/milestones{/number}","notifications_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/labels{/name}","releases_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/releases{/id}","deployments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/deployments","created_at":"2016-11-01T23:02:11Z","updated_at":"2018-04-06T22:38:19Z","pushed_at":"2018-04-11T16:11:38Z","git_url":"git://github.com/logstash-plugins/logstash-input-google_pubsub.git","ssh_url":"git@github.com:logstash-plugins/logstash-input-google_pubsub.git","clone_url":"https://github.com/logstash-plugins/logstash-input-google_pubsub.git","svn_url":"https://github.com/logstash-plugins/logstash-input-google_pubsub","homepage":null,"size":28,"stargazers_count":8,"watchers_count":8,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":11,"open_issues":13,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/pulls/25"},"html":{"href":"https://github.com/logstash-plugins/logstash-input-google_pubsub/pull/25"},"issue":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/issues/25"},"comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-google_pubsub/statuses/5fb9ba3007764bc3d71c7b9e7972ef0aa34ba99b"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":2,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"josephlewis42"}}