{"action":"created","issue":{"url":"https://api.github.com/repos/prometheus/prometheus/issues/4821","repository_url":"https://api.github.com/repos/prometheus/prometheus","labels_url":"https://api.github.com/repos/prometheus/prometheus/issues/4821/labels{/name}","comments_url":"https://api.github.com/repos/prometheus/prometheus/issues/4821/comments","events_url":"https://api.github.com/repos/prometheus/prometheus/issues/4821/events","html_url":"https://github.com/prometheus/prometheus/pull/4821","id":377414568,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MzYzMzQ5","number":4821,"title":"web: Update from bootstrap 3.3.1 to bootstrap 4.0.0","user":{"login":"achiuBAE","id":44226927,"node_id":"MDQ6VXNlcjQ0MjI2OTI3","avatar_url":"https://avatars1.githubusercontent.com/u/44226927?v=4","gravatar_id":"","url":"https://api.github.com/users/achiuBAE","html_url":"https://github.com/achiuBAE","followers_url":"https://api.github.com/users/achiuBAE/followers","following_url":"https://api.github.com/users/achiuBAE/following{/other_user}","gists_url":"https://api.github.com/users/achiuBAE/gists{/gist_id}","starred_url":"https://api.github.com/users/achiuBAE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achiuBAE/subscriptions","organizations_url":"https://api.github.com/users/achiuBAE/orgs","repos_url":"https://api.github.com/users/achiuBAE/repos","events_url":"https://api.github.com/users/achiuBAE/events{/privacy}","received_events_url":"https://api.github.com/users/achiuBAE/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-11-05T14:05:24Z","updated_at":"2018-12-11T16:03:37Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/prometheus/prometheus/pulls/4821","html_url":"https://github.com/prometheus/prometheus/pull/4821","diff_url":"https://github.com/prometheus/prometheus/pull/4821.diff","patch_url":"https://github.com/prometheus/prometheus/pull/4821.patch"},"body":"implemented: #4754 \r\n\r\n- Updated the html template files to be bootstrap 4.0.0 compatible, ensuring that all the functionality and ui is the same.\r\nvendor: \r\n-reimplemented glyphicons from bootstrap 3 to work with 4.0.0. used: https://github.com/Darkseal/bootstrap4-glyphicons.\r\n-jquery to 3.3.1. \r\n-bootstrap3-typeahead updated to work with bootstrap 4\r\ncss:\r\n- minor css update to alerts.css, graph.css, prometheus.css. navbar and glyphicon button highlighting color inheritance. \r\nnote: commits show up as nov 5th, as we didn't do commit signoff messages in initial fork. \r\n\r\ncc @juliusv "},"comment":{"url":"https://api.github.com/repos/prometheus/prometheus/issues/comments/446257096","html_url":"https://github.com/prometheus/prometheus/pull/4821#issuecomment-446257096","issue_url":"https://api.github.com/repos/prometheus/prometheus/issues/4821","id":446257096,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjI1NzA5Ng==","user":{"login":"simonpasquier","id":2587585,"node_id":"MDQ6VXNlcjI1ODc1ODU=","avatar_url":"https://avatars1.githubusercontent.com/u/2587585?v=4","gravatar_id":"","url":"https://api.github.com/users/simonpasquier","html_url":"https://github.com/simonpasquier","followers_url":"https://api.github.com/users/simonpasquier/followers","following_url":"https://api.github.com/users/simonpasquier/following{/other_user}","gists_url":"https://api.github.com/users/simonpasquier/gists{/gist_id}","starred_url":"https://api.github.com/users/simonpasquier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonpasquier/subscriptions","organizations_url":"https://api.github.com/users/simonpasquier/orgs","repos_url":"https://api.github.com/users/simonpasquier/repos","events_url":"https://api.github.com/users/simonpasquier/events{/privacy}","received_events_url":"https://api.github.com/users/simonpasquier/received_events","type":"User","site_admin":false},"created_at":"2018-12-11T16:03:37Z","updated_at":"2018-12-11T16:03:37Z","author_association":"MEMBER","body":"Thanks a lot for doing this! This looks very good. A few minor comments:\r\n\r\n* `web/ui/static/vendor/bootstrap-4.1.3/css/.DS_Store` should be removed.\r\n* I still don't see the UI change introduced by https://github.com/prometheus/prometheus/pull/4764.\r\n\r\nWe're currently in feature freeze waiting for the final v2.6.0 so in any case this PR will have to wait a bit before being merged.\r\n\r\ncc @juliusv for feedback."}}
{"actor":{"display_login":"simonpasquier"}}