{"action":"created","issue":{"url":"https://api.github.com/repos/conveyal/gtfs-lib/issues/133","repository_url":"https://api.github.com/repos/conveyal/gtfs-lib","labels_url":"https://api.github.com/repos/conveyal/gtfs-lib/issues/133/labels{/name}","comments_url":"https://api.github.com/repos/conveyal/gtfs-lib/issues/133/comments","events_url":"https://api.github.com/repos/conveyal/gtfs-lib/issues/133/events","html_url":"https://github.com/conveyal/gtfs-lib/pull/133","id":353496798,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNTMzNjE3","number":133,"title":"Editor: Allow null values for foreign ref fields or required fields where permitted","user":{"login":"landonreed","id":2370911,"node_id":"MDQ6VXNlcjIzNzA5MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/2370911?v=4","gravatar_id":"","url":"https://api.github.com/users/landonreed","html_url":"https://github.com/landonreed","followers_url":"https://api.github.com/users/landonreed/followers","following_url":"https://api.github.com/users/landonreed/following{/other_user}","gists_url":"https://api.github.com/users/landonreed/gists{/gist_id}","starred_url":"https://api.github.com/users/landonreed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/landonreed/subscriptions","organizations_url":"https://api.github.com/users/landonreed/orgs","repos_url":"https://api.github.com/users/landonreed/repos","events_url":"https://api.github.com/users/landonreed/events{/privacy}","received_events_url":"https://api.github.com/users/landonreed/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"evansiroky","id":3112493,"node_id":"MDQ6VXNlcjMxMTI0OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/3112493?v=4","gravatar_id":"","url":"https://api.github.com/users/evansiroky","html_url":"https://github.com/evansiroky","followers_url":"https://api.github.com/users/evansiroky/followers","following_url":"https://api.github.com/users/evansiroky/following{/other_user}","gists_url":"https://api.github.com/users/evansiroky/gists{/gist_id}","starred_url":"https://api.github.com/users/evansiroky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evansiroky/subscriptions","organizations_url":"https://api.github.com/users/evansiroky/orgs","repos_url":"https://api.github.com/users/evansiroky/repos","events_url":"https://api.github.com/users/evansiroky/events{/privacy}","received_events_url":"https://api.github.com/users/evansiroky/received_events","type":"User","site_admin":false},"assignees":[{"login":"evansiroky","id":3112493,"node_id":"MDQ6VXNlcjMxMTI0OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/3112493?v=4","gravatar_id":"","url":"https://api.github.com/users/evansiroky","html_url":"https://github.com/evansiroky","followers_url":"https://api.github.com/users/evansiroky/followers","following_url":"https://api.github.com/users/evansiroky/following{/other_user}","gists_url":"https://api.github.com/users/evansiroky/gists{/gist_id}","starred_url":"https://api.github.com/users/evansiroky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evansiroky/subscriptions","organizations_url":"https://api.github.com/users/evansiroky/orgs","repos_url":"https://api.github.com/users/evansiroky/repos","events_url":"https://api.github.com/users/evansiroky/events{/privacy}","received_events_url":"https://api.github.com/users/evansiroky/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-08-23T18:18:10Z","updated_at":"2018-10-16T22:06:51Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/conveyal/gtfs-lib/pulls/133","html_url":"https://github.com/conveyal/gtfs-lib/pull/133","diff_url":"https://github.com/conveyal/gtfs-lib/pull/133.diff","patch_url":"https://github.com/conveyal/gtfs-lib/pull/133.patch"},"body":"This fixes a couple of editor bugs:\r\n- where create/update requests with foreign refs (such as `fare_rules#route_id`)\r\ncould not be null even if the table definition permits the null value (catalogueglobal/datatools-ui#224) and\r\n- where required fields that permit empty values (`fare_attributes#transfers`) were not allowed in create/update requests (catalogueglobal/datatools-ui#237)\r\n\r\nIt also adds a basic CRUD test for fares."},"comment":{"url":"https://api.github.com/repos/conveyal/gtfs-lib/issues/comments/430418079","html_url":"https://github.com/conveyal/gtfs-lib/pull/133#issuecomment-430418079","issue_url":"https://api.github.com/repos/conveyal/gtfs-lib/issues/133","id":430418079,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDQxODA3OQ==","user":{"login":"evansiroky","id":3112493,"node_id":"MDQ6VXNlcjMxMTI0OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/3112493?v=4","gravatar_id":"","url":"https://api.github.com/users/evansiroky","html_url":"https://github.com/evansiroky","followers_url":"https://api.github.com/users/evansiroky/followers","following_url":"https://api.github.com/users/evansiroky/following{/other_user}","gists_url":"https://api.github.com/users/evansiroky/gists{/gist_id}","starred_url":"https://api.github.com/users/evansiroky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evansiroky/subscriptions","organizations_url":"https://api.github.com/users/evansiroky/orgs","repos_url":"https://api.github.com/users/evansiroky/repos","events_url":"https://api.github.com/users/evansiroky/events{/privacy}","received_events_url":"https://api.github.com/users/evansiroky/received_events","type":"User","site_admin":false},"created_at":"2018-10-16T22:06:51Z","updated_at":"2018-10-16T22:06:51Z","author_association":"CONTRIBUTOR","body":"Excellent!  I gave an idea of how to improve the CRUD tests, but if that seems out of scope for this PR, let's create an issue for that and do that later."}}
{"actor":{"display_login":"evansiroky"}}