{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift-nio-ssl/pulls/comments/177096766","pull_request_review_id":106909941,"id":177096766,"diff_hunk":"@@ -14,11 +14,17 @@\n \n import XCTest\n import CNIOOpenSSL\n-@testable import NIO\n+import NIO\n @testable import NIOOpenSSL\n import NIOTLS\n import class Foundation.Process\n \n+#if os(macOS) || os(iOS) || os(watchOS) || os(tvOS)","path":"Tests/NIOOpenSSLTests/OpenSSLIntegrationTest.swift","position":10,"original_position":10,"commit_id":"4ae29f80b79be0602971b376c8643d8e33ce2cf5","original_commit_id":"24c095796dc78b7073709f2d9b3ec83c5957846c","user":{"login":"weissi","id":624238,"avatar_url":"https://avatars2.githubusercontent.com/u/624238?v=4","gravatar_id":"","url":"https://api.github.com/users/weissi","html_url":"https://github.com/weissi","followers_url":"https://api.github.com/users/weissi/followers","following_url":"https://api.github.com/users/weissi/following{/other_user}","gists_url":"https://api.github.com/users/weissi/gists{/gist_id}","starred_url":"https://api.github.com/users/weissi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weissi/subscriptions","organizations_url":"https://api.github.com/users/weissi/orgs","repos_url":"https://api.github.com/users/weissi/repos","events_url":"https://api.github.com/users/weissi/events{/privacy}","received_events_url":"https://api.github.com/users/weissi/received_events","type":"User","site_admin":false},"body":"I believe this shouldn't be necessary as the `NIO` should export them, no?","created_at":"2018-03-26T13:51:15Z","updated_at":"2018-03-26T13:54:47Z","html_url":"https://github.com/apple/swift-nio-ssl/pull/11#discussion_r177096766","pull_request_url":"https://api.github.com/repos/apple/swift-nio-ssl/pulls/11","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apple/swift-nio-ssl/pulls/comments/177096766"},"html":{"href":"https://github.com/apple/swift-nio-ssl/pull/11#discussion_r177096766"},"pull_request":{"href":"https://api.github.com/repos/apple/swift-nio-ssl/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift-nio-ssl/pulls/11","id":177452594,"html_url":"https://github.com/apple/swift-nio-ssl/pull/11","diff_url":"https://github.com/apple/swift-nio-ssl/pull/11.diff","patch_url":"https://github.com/apple/swift-nio-ssl/pull/11.patch","issue_url":"https://api.github.com/repos/apple/swift-nio-ssl/issues/11","number":11,"state":"open","locked":false,"title":"Remove @testable use of NIO.","user":{"login":"Lukasa","id":1382556,"avatar_url":"https://avatars1.githubusercontent.com/u/1382556?v=4","gravatar_id":"","url":"https://api.github.com/users/Lukasa","html_url":"https://github.com/Lukasa","followers_url":"https://api.github.com/users/Lukasa/followers","following_url":"https://api.github.com/users/Lukasa/following{/other_user}","gists_url":"https://api.github.com/users/Lukasa/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukasa/subscriptions","organizations_url":"https://api.github.com/users/Lukasa/orgs","repos_url":"https://api.github.com/users/Lukasa/repos","events_url":"https://api.github.com/users/Lukasa/events{/privacy}","received_events_url":"https://api.github.com/users/Lukasa/received_events","type":"User","site_admin":false},"body":"Motivation:\r\n\r\nWhen this was in-tree with NIO we could safely use @testable imports to\r\nget at the project internals, becuase we couldn't possibly regress against\r\nthem. This is no longer true, so we should avoid @testable imports.\r\n\r\nModifications:\r\n\r\nRemoved all @testable imports.\r\n\r\nChanged NIO.Posix.open to Darwin/Glibc.open.\r\n\r\nReplaced uses of fulfilled with either wait() or callbacks.\r\n\r\nResult:\r\n\r\nLess chance of randomly breaking due to NIO changes.","created_at":"2018-03-26T13:50:17Z","updated_at":"2018-03-26T13:54:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23bc01e6eb4460fee618758834b4ef0bf939edec","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":880055220,"url":"https://api.github.com/repos/apple/swift-nio-ssl/labels/patch-version-bump-only","name":"patch-version-bump-only","color":"DE76D2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift-nio-ssl/pulls/11/commits","review_comments_url":"https://api.github.com/repos/apple/swift-nio-ssl/pulls/11/comments","review_comment_url":"https://api.github.com/repos/apple/swift-nio-ssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift-nio-ssl/issues/11/comments","statuses_url":"https://api.github.com/repos/apple/swift-nio-ssl/statuses/4ae29f80b79be0602971b376c8643d8e33ce2cf5","head":{"label":"Lukasa:cb-fix-compatibility-issue","ref":"cb-fix-compatibility-issue","sha":"4ae29f80b79be0602971b376c8643d8e33ce2cf5","user":{"login":"Lukasa","id":1382556,"avatar_url":"https://avatars1.githubusercontent.com/u/1382556?v=4","gravatar_id":"","url":"https://api.github.com/users/Lukasa","html_url":"https://github.com/Lukasa","followers_url":"https://api.github.com/users/Lukasa/followers","following_url":"https://api.github.com/users/Lukasa/following{/other_user}","gists_url":"https://api.github.com/users/Lukasa/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukasa/subscriptions","organizations_url":"https://api.github.com/users/Lukasa/orgs","repos_url":"https://api.github.com/users/Lukasa/repos","events_url":"https://api.github.com/users/Lukasa/events{/privacy}","received_events_url":"https://api.github.com/users/Lukasa/received_events","type":"User","site_admin":false},"repo":{"id":126835914,"name":"swift-nio-ssl-1","full_name":"Lukasa/swift-nio-ssl-1","owner":{"login":"Lukasa","id":1382556,"avatar_url":"https://avatars1.githubusercontent.com/u/1382556?v=4","gravatar_id":"","url":"https://api.github.com/users/Lukasa","html_url":"https://github.com/Lukasa","followers_url":"https://api.github.com/users/Lukasa/followers","following_url":"https://api.github.com/users/Lukasa/following{/other_user}","gists_url":"https://api.github.com/users/Lukasa/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukasa/subscriptions","organizations_url":"https://api.github.com/users/Lukasa/orgs","repos_url":"https://api.github.com/users/Lukasa/repos","events_url":"https://api.github.com/users/Lukasa/events{/privacy}","received_events_url":"https://api.github.com/users/Lukasa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Lukasa/swift-nio-ssl-1","description":"Bindings to OpenSSL-compatible libraries for TLS support in SwiftNIO","fork":true,"url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1","forks_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/forks","keys_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/teams","hooks_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/hooks","issue_events_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/issues/events{/number}","events_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/events","assignees_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/assignees{/user}","branches_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/branches{/branch}","tags_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/tags","blobs_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/statuses/{sha}","languages_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/languages","stargazers_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/stargazers","contributors_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/contributors","subscribers_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/subscribers","subscription_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/subscription","commits_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/contents/{+path}","compare_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/merges","archive_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/downloads","issues_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/issues{/number}","pulls_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/pulls{/number}","milestones_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/milestones{/number}","notifications_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/labels{/name}","releases_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/releases{/id}","deployments_url":"https://api.github.com/repos/Lukasa/swift-nio-ssl-1/deployments","created_at":"2018-03-26T13:49:34Z","updated_at":"2018-03-26T13:49:36Z","pushed_at":"2018-03-26T13:52:30Z","git_url":"git://github.com/Lukasa/swift-nio-ssl-1.git","ssh_url":"git@github.com:Lukasa/swift-nio-ssl-1.git","clone_url":"https://github.com/Lukasa/swift-nio-ssl-1.git","svn_url":"https://github.com/Lukasa/swift-nio-ssl-1","homepage":"","size":84,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"85a55f91bf80afa96889426962f0e0369fae9187","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":122145065,"name":"swift-nio-ssl","full_name":"apple/swift-nio-ssl","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift-nio-ssl","description":"Bindings to OpenSSL-compatible libraries for TLS support in SwiftNIO","fork":false,"url":"https://api.github.com/repos/apple/swift-nio-ssl","forks_url":"https://api.github.com/repos/apple/swift-nio-ssl/forks","keys_url":"https://api.github.com/repos/apple/swift-nio-ssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift-nio-ssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift-nio-ssl/teams","hooks_url":"https://api.github.com/repos/apple/swift-nio-ssl/hooks","issue_events_url":"https://api.github.com/repos/apple/swift-nio-ssl/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift-nio-ssl/events","assignees_url":"https://api.github.com/repos/apple/swift-nio-ssl/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift-nio-ssl/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift-nio-ssl/tags","blobs_url":"https://api.github.com/repos/apple/swift-nio-ssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift-nio-ssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift-nio-ssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift-nio-ssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift-nio-ssl/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift-nio-ssl/languages","stargazers_url":"https://api.github.com/repos/apple/swift-nio-ssl/stargazers","contributors_url":"https://api.github.com/repos/apple/swift-nio-ssl/contributors","subscribers_url":"https://api.github.com/repos/apple/swift-nio-ssl/subscribers","subscription_url":"https://api.github.com/repos/apple/swift-nio-ssl/subscription","commits_url":"https://api.github.com/repos/apple/swift-nio-ssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift-nio-ssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift-nio-ssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift-nio-ssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift-nio-ssl/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift-nio-ssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift-nio-ssl/merges","archive_url":"https://api.github.com/repos/apple/swift-nio-ssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift-nio-ssl/downloads","issues_url":"https://api.github.com/repos/apple/swift-nio-ssl/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift-nio-ssl/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift-nio-ssl/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift-nio-ssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift-nio-ssl/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift-nio-ssl/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift-nio-ssl/deployments","created_at":"2018-02-20T02:03:33Z","updated_at":"2018-03-26T08:56:45Z","pushed_at":"2018-03-26T13:52:32Z","git_url":"git://github.com/apple/swift-nio-ssl.git","ssh_url":"git@github.com:apple/swift-nio-ssl.git","clone_url":"https://github.com/apple/swift-nio-ssl.git","svn_url":"https://github.com/apple/swift-nio-ssl","homepage":"","size":84,"stargazers_count":114,"watchers_count":114,"language":"Swift","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":6,"open_issues":2,"watchers":114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift-nio-ssl/pulls/11"},"html":{"href":"https://github.com/apple/swift-nio-ssl/pull/11"},"issue":{"href":"https://api.github.com/repos/apple/swift-nio-ssl/issues/11"},"comments":{"href":"https://api.github.com/repos/apple/swift-nio-ssl/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift-nio-ssl/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift-nio-ssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift-nio-ssl/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift-nio-ssl/statuses/4ae29f80b79be0602971b376c8643d8e33ce2cf5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"weissi"}}