{"action":"created","comment":{"url":"https://api.github.com/repos/swaywm/wlroots/pulls/comments/181893439","pull_request_review_id":112598236,"id":181893439,"diff_hunk":"@@ -435,3 +448,74 @@ void wlr_layer_shell_destroy(struct wlr_layer_shell *layer_shell) {\n \twl_global_destroy(layer_shell->wl_global);\n \tfree(layer_shell);\n }\n+\n+struct layer_surface_iterator_data {\n+\twlr_surface_iterator_func_t user_iterator;\n+\tvoid *user_data;\n+\tint x, y;\n+};\n+\n+static void layer_surface_iterator(struct wlr_surface *surface,\n+\t\tint sx, int sy, void *data) {\n+\tstruct layer_surface_iterator_data *iter_data = data;\n+\titer_data->user_iterator(surface, iter_data->x + sx, iter_data->y + sy,\n+\t\titer_data->user_data);\n+}\n+\n+static void xdg_surface_for_each_surface(struct wlr_xdg_surface *surface,\n+\t\tint x, int y, wlr_surface_iterator_func_t iterator, void *user_data) {","path":"types/wlr_layer_shell.c","position":64,"original_position":64,"commit_id":"744f905ad9a9f516d90c4f0bc02714c83fa8411a","original_commit_id":"744f905ad9a9f516d90c4f0bc02714c83fa8411a","user":{"login":"SirCmpwn","id":1310872,"avatar_url":"https://avatars0.githubusercontent.com/u/1310872?v=4","gravatar_id":"","url":"https://api.github.com/users/SirCmpwn","html_url":"https://github.com/SirCmpwn","followers_url":"https://api.github.com/users/SirCmpwn/followers","following_url":"https://api.github.com/users/SirCmpwn/following{/other_user}","gists_url":"https://api.github.com/users/SirCmpwn/gists{/gist_id}","starred_url":"https://api.github.com/users/SirCmpwn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SirCmpwn/subscriptions","organizations_url":"https://api.github.com/users/SirCmpwn/orgs","repos_url":"https://api.github.com/users/SirCmpwn/repos","events_url":"https://api.github.com/users/SirCmpwn/events{/privacy}","received_events_url":"https://api.github.com/users/SirCmpwn/received_events","type":"User","site_admin":false},"body":"That wasn't the issue. It was related to double-rendering popups","created_at":"2018-04-16T21:36:46Z","updated_at":"2018-04-16T21:36:46Z","html_url":"https://github.com/swaywm/wlroots/pull/867#discussion_r181893439","pull_request_url":"https://api.github.com/repos/swaywm/wlroots/pulls/867","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/swaywm/wlroots/pulls/comments/181893439"},"html":{"href":"https://github.com/swaywm/wlroots/pull/867#discussion_r181893439"},"pull_request":{"href":"https://api.github.com/repos/swaywm/wlroots/pulls/867"}},"in_reply_to_id":181858578},"pull_request":{"url":"https://api.github.com/repos/swaywm/wlroots/pulls/867","id":181664391,"html_url":"https://github.com/swaywm/wlroots/pull/867","diff_url":"https://github.com/swaywm/wlroots/pull/867.diff","patch_url":"https://github.com/swaywm/wlroots/pull/867.patch","issue_url":"https://api.github.com/repos/swaywm/wlroots/issues/867","number":867,"state":"open","locked":false,"title":"[WIP] Generalize xdg-shell popups and add to layer-shell","user":{"login":"SirCmpwn","id":1310872,"avatar_url":"https://avatars0.githubusercontent.com/u/1310872?v=4","gravatar_id":"","url":"https://api.github.com/users/SirCmpwn","html_url":"https://github.com/SirCmpwn","followers_url":"https://api.github.com/users/SirCmpwn/followers","following_url":"https://api.github.com/users/SirCmpwn/following{/other_user}","gists_url":"https://api.github.com/users/SirCmpwn/gists{/gist_id}","starred_url":"https://api.github.com/users/SirCmpwn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SirCmpwn/subscriptions","organizations_url":"https://api.github.com/users/SirCmpwn/orgs","repos_url":"https://api.github.com/users/SirCmpwn/repos","events_url":"https://api.github.com/users/SirCmpwn/events{/privacy}","received_events_url":"https://api.github.com/users/SirCmpwn/received_events","type":"User","site_admin":false},"body":"* [x] Server implementation\r\n* [x] Rendering\r\n  * [ ] At the correct depth\r\n  * [x] At the correct position\r\n* [ ] Damage\r\n* [ ] Grabs\r\n* [x] Example client","created_at":"2018-04-14T19:54:14Z","updated_at":"2018-04-16T21:36:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17557849d39e1bca82e6169b57abfbe00cb58127","assignee":null,"assignees":[],"requested_reviewers":[{"login":"acrisci","id":3258764,"avatar_url":"https://avatars2.githubusercontent.com/u/3258764?v=4","gravatar_id":"","url":"https://api.github.com/users/acrisci","html_url":"https://github.com/acrisci","followers_url":"https://api.github.com/users/acrisci/followers","following_url":"https://api.github.com/users/acrisci/following{/other_user}","gists_url":"https://api.github.com/users/acrisci/gists{/gist_id}","starred_url":"https://api.github.com/users/acrisci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acrisci/subscriptions","organizations_url":"https://api.github.com/users/acrisci/orgs","repos_url":"https://api.github.com/users/acrisci/repos","events_url":"https://api.github.com/users/acrisci/events{/privacy}","received_events_url":"https://api.github.com/users/acrisci/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/swaywm/wlroots/pulls/867/commits","review_comments_url":"https://api.github.com/repos/swaywm/wlroots/pulls/867/comments","review_comment_url":"https://api.github.com/repos/swaywm/wlroots/pulls/comments{/number}","comments_url":"https://api.github.com/repos/swaywm/wlroots/issues/867/comments","statuses_url":"https://api.github.com/repos/swaywm/wlroots/statuses/744f905ad9a9f516d90c4f0bc02714c83fa8411a","head":{"label":"swaywm:layer-popups","ref":"layer-popups","sha":"744f905ad9a9f516d90c4f0bc02714c83fa8411a","user":{"login":"swaywm","id":32400794,"avatar_url":"https://avatars1.githubusercontent.com/u/32400794?v=4","gravatar_id":"","url":"https://api.github.com/users/swaywm","html_url":"https://github.com/swaywm","followers_url":"https://api.github.com/users/swaywm/followers","following_url":"https://api.github.com/users/swaywm/following{/other_user}","gists_url":"https://api.github.com/users/swaywm/gists{/gist_id}","starred_url":"https://api.github.com/users/swaywm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swaywm/subscriptions","organizations_url":"https://api.github.com/users/swaywm/orgs","repos_url":"https://api.github.com/users/swaywm/repos","events_url":"https://api.github.com/users/swaywm/events{/privacy}","received_events_url":"https://api.github.com/users/swaywm/received_events","type":"Organization","site_admin":false},"repo":{"id":89377392,"name":"wlroots","full_name":"swaywm/wlroots","owner":{"login":"swaywm","id":32400794,"avatar_url":"https://avatars1.githubusercontent.com/u/32400794?v=4","gravatar_id":"","url":"https://api.github.com/users/swaywm","html_url":"https://github.com/swaywm","followers_url":"https://api.github.com/users/swaywm/followers","following_url":"https://api.github.com/users/swaywm/following{/other_user}","gists_url":"https://api.github.com/users/swaywm/gists{/gist_id}","starred_url":"https://api.github.com/users/swaywm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swaywm/subscriptions","organizations_url":"https://api.github.com/users/swaywm/orgs","repos_url":"https://api.github.com/users/swaywm/repos","events_url":"https://api.github.com/users/swaywm/events{/privacy}","received_events_url":"https://api.github.com/users/swaywm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/swaywm/wlroots","description":"A modular Wayland compositor library","fork":false,"url":"https://api.github.com/repos/swaywm/wlroots","forks_url":"https://api.github.com/repos/swaywm/wlroots/forks","keys_url":"https://api.github.com/repos/swaywm/wlroots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swaywm/wlroots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swaywm/wlroots/teams","hooks_url":"https://api.github.com/repos/swaywm/wlroots/hooks","issue_events_url":"https://api.github.com/repos/swaywm/wlroots/issues/events{/number}","events_url":"https://api.github.com/repos/swaywm/wlroots/events","assignees_url":"https://api.github.com/repos/swaywm/wlroots/assignees{/user}","branches_url":"https://api.github.com/repos/swaywm/wlroots/branches{/branch}","tags_url":"https://api.github.com/repos/swaywm/wlroots/tags","blobs_url":"https://api.github.com/repos/swaywm/wlroots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swaywm/wlroots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swaywm/wlroots/git/refs{/sha}","trees_url":"https://api.github.com/repos/swaywm/wlroots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swaywm/wlroots/statuses/{sha}","languages_url":"https://api.github.com/repos/swaywm/wlroots/languages","stargazers_url":"https://api.github.com/repos/swaywm/wlroots/stargazers","contributors_url":"https://api.github.com/repos/swaywm/wlroots/contributors","subscribers_url":"https://api.github.com/repos/swaywm/wlroots/subscribers","subscription_url":"https://api.github.com/repos/swaywm/wlroots/subscription","commits_url":"https://api.github.com/repos/swaywm/wlroots/commits{/sha}","git_commits_url":"https://api.github.com/repos/swaywm/wlroots/git/commits{/sha}","comments_url":"https://api.github.com/repos/swaywm/wlroots/comments{/number}","issue_comment_url":"https://api.github.com/repos/swaywm/wlroots/issues/comments{/number}","contents_url":"https://api.github.com/repos/swaywm/wlroots/contents/{+path}","compare_url":"https://api.github.com/repos/swaywm/wlroots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swaywm/wlroots/merges","archive_url":"https://api.github.com/repos/swaywm/wlroots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swaywm/wlroots/downloads","issues_url":"https://api.github.com/repos/swaywm/wlroots/issues{/number}","pulls_url":"https://api.github.com/repos/swaywm/wlroots/pulls{/number}","milestones_url":"https://api.github.com/repos/swaywm/wlroots/milestones{/number}","notifications_url":"https://api.github.com/repos/swaywm/wlroots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swaywm/wlroots/labels{/name}","releases_url":"https://api.github.com/repos/swaywm/wlroots/releases{/id}","deployments_url":"https://api.github.com/repos/swaywm/wlroots/deployments","created_at":"2017-04-25T15:33:43Z","updated_at":"2018-04-16T17:51:47Z","pushed_at":"2018-04-16T17:14:11Z","git_url":"git://github.com/swaywm/wlroots.git","ssh_url":"git@github.com:swaywm/wlroots.git","clone_url":"https://github.com/swaywm/wlroots.git","svn_url":"https://github.com/swaywm/wlroots","homepage":"http://swaywm.org","size":4034,"stargazers_count":340,"watchers_count":340,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"archived":false,"open_issues_count":98,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":57,"open_issues":98,"watchers":340,"default_branch":"master"}},"base":{"label":"swaywm:master","ref":"master","sha":"63763d327969a17af43ccaf8fe4c6da941f8efcb","user":{"login":"swaywm","id":32400794,"avatar_url":"https://avatars1.githubusercontent.com/u/32400794?v=4","gravatar_id":"","url":"https://api.github.com/users/swaywm","html_url":"https://github.com/swaywm","followers_url":"https://api.github.com/users/swaywm/followers","following_url":"https://api.github.com/users/swaywm/following{/other_user}","gists_url":"https://api.github.com/users/swaywm/gists{/gist_id}","starred_url":"https://api.github.com/users/swaywm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swaywm/subscriptions","organizations_url":"https://api.github.com/users/swaywm/orgs","repos_url":"https://api.github.com/users/swaywm/repos","events_url":"https://api.github.com/users/swaywm/events{/privacy}","received_events_url":"https://api.github.com/users/swaywm/received_events","type":"Organization","site_admin":false},"repo":{"id":89377392,"name":"wlroots","full_name":"swaywm/wlroots","owner":{"login":"swaywm","id":32400794,"avatar_url":"https://avatars1.githubusercontent.com/u/32400794?v=4","gravatar_id":"","url":"https://api.github.com/users/swaywm","html_url":"https://github.com/swaywm","followers_url":"https://api.github.com/users/swaywm/followers","following_url":"https://api.github.com/users/swaywm/following{/other_user}","gists_url":"https://api.github.com/users/swaywm/gists{/gist_id}","starred_url":"https://api.github.com/users/swaywm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swaywm/subscriptions","organizations_url":"https://api.github.com/users/swaywm/orgs","repos_url":"https://api.github.com/users/swaywm/repos","events_url":"https://api.github.com/users/swaywm/events{/privacy}","received_events_url":"https://api.github.com/users/swaywm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/swaywm/wlroots","description":"A modular Wayland compositor library","fork":false,"url":"https://api.github.com/repos/swaywm/wlroots","forks_url":"https://api.github.com/repos/swaywm/wlroots/forks","keys_url":"https://api.github.com/repos/swaywm/wlroots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swaywm/wlroots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swaywm/wlroots/teams","hooks_url":"https://api.github.com/repos/swaywm/wlroots/hooks","issue_events_url":"https://api.github.com/repos/swaywm/wlroots/issues/events{/number}","events_url":"https://api.github.com/repos/swaywm/wlroots/events","assignees_url":"https://api.github.com/repos/swaywm/wlroots/assignees{/user}","branches_url":"https://api.github.com/repos/swaywm/wlroots/branches{/branch}","tags_url":"https://api.github.com/repos/swaywm/wlroots/tags","blobs_url":"https://api.github.com/repos/swaywm/wlroots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swaywm/wlroots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swaywm/wlroots/git/refs{/sha}","trees_url":"https://api.github.com/repos/swaywm/wlroots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swaywm/wlroots/statuses/{sha}","languages_url":"https://api.github.com/repos/swaywm/wlroots/languages","stargazers_url":"https://api.github.com/repos/swaywm/wlroots/stargazers","contributors_url":"https://api.github.com/repos/swaywm/wlroots/contributors","subscribers_url":"https://api.github.com/repos/swaywm/wlroots/subscribers","subscription_url":"https://api.github.com/repos/swaywm/wlroots/subscription","commits_url":"https://api.github.com/repos/swaywm/wlroots/commits{/sha}","git_commits_url":"https://api.github.com/repos/swaywm/wlroots/git/commits{/sha}","comments_url":"https://api.github.com/repos/swaywm/wlroots/comments{/number}","issue_comment_url":"https://api.github.com/repos/swaywm/wlroots/issues/comments{/number}","contents_url":"https://api.github.com/repos/swaywm/wlroots/contents/{+path}","compare_url":"https://api.github.com/repos/swaywm/wlroots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swaywm/wlroots/merges","archive_url":"https://api.github.com/repos/swaywm/wlroots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swaywm/wlroots/downloads","issues_url":"https://api.github.com/repos/swaywm/wlroots/issues{/number}","pulls_url":"https://api.github.com/repos/swaywm/wlroots/pulls{/number}","milestones_url":"https://api.github.com/repos/swaywm/wlroots/milestones{/number}","notifications_url":"https://api.github.com/repos/swaywm/wlroots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swaywm/wlroots/labels{/name}","releases_url":"https://api.github.com/repos/swaywm/wlroots/releases{/id}","deployments_url":"https://api.github.com/repos/swaywm/wlroots/deployments","created_at":"2017-04-25T15:33:43Z","updated_at":"2018-04-16T17:51:47Z","pushed_at":"2018-04-16T17:14:11Z","git_url":"git://github.com/swaywm/wlroots.git","ssh_url":"git@github.com:swaywm/wlroots.git","clone_url":"https://github.com/swaywm/wlroots.git","svn_url":"https://github.com/swaywm/wlroots","homepage":"http://swaywm.org","size":4034,"stargazers_count":340,"watchers_count":340,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"archived":false,"open_issues_count":98,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":57,"open_issues":98,"watchers":340,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/swaywm/wlroots/pulls/867"},"html":{"href":"https://github.com/swaywm/wlroots/pull/867"},"issue":{"href":"https://api.github.com/repos/swaywm/wlroots/issues/867"},"comments":{"href":"https://api.github.com/repos/swaywm/wlroots/issues/867/comments"},"review_comments":{"href":"https://api.github.com/repos/swaywm/wlroots/pulls/867/comments"},"review_comment":{"href":"https://api.github.com/repos/swaywm/wlroots/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/swaywm/wlroots/pulls/867/commits"},"statuses":{"href":"https://api.github.com/repos/swaywm/wlroots/statuses/744f905ad9a9f516d90c4f0bc02714c83fa8411a"}},"author_association":"OWNER"}}
{"actor":{"display_login":"SirCmpwn"}}