{"action":"created","comment":{"url":"https://api.github.com/repos/gooddata/gooddata-react-components/pulls/comments/180348644","pull_request_review_id":110751293,"id":180348644,"diff_hunk":"@@ -0,0 +1,224 @@\n+// (C) 2007-2018 GoodData Corporation\n+import * as React from 'react';\n+import cloneDeep = require('lodash/cloneDeep');\n+import get = require('lodash/get');\n+import set = require('lodash/set');\n+import isEqual = require('lodash/isEqual');\n+import noop = require('lodash/noop');\n+import partial = require('lodash/partial');\n+import * as cx from 'classnames';\n+\n+import { VisualizationTypes } from '../../../constants/visualizationTypes';\n+import Chart from './Chart';\n+import Legend from './legend/Legend';\n+import { TOP, LEFT, BOTTOM, RIGHT } from './legend/PositionTypes';\n+\n+export interface IHighChartsRendererProps {\n+    chartOptions: any;\n+    hcOptions: any;\n+    height: number;\n+    width: number;\n+    legend: any;\n+    legendRenderer(legendProps: any): void;\n+    chartRenderer(chartProps: any): void;\n+    afterRender(): void;\n+    onLegendReady(legendItems: any): void;\n+}\n+\n+export function renderChart(props: any) {\n+    return <Chart {...props} />;\n+}\n+\n+export function renderLegend(props: any) {\n+    return <Legend {...props} />;\n+}\n+\n+export default class HighChartRenderer extends React.PureComponent<IHighChartsRendererProps, any> {","path":"src/components/visualizations/chart/HighChartRenderer.tsx","position":36,"original_position":36,"commit_id":"a07b42a32876d5edd7afb3a011cee7f94ef87c08","original_commit_id":"a07b42a32876d5edd7afb3a011cee7f94ef87c08","user":{"login":"vaclavbohac","id":139369,"avatar_url":"https://avatars2.githubusercontent.com/u/139369?v=4","gravatar_id":"","url":"https://api.github.com/users/vaclavbohac","html_url":"https://github.com/vaclavbohac","followers_url":"https://api.github.com/users/vaclavbohac/followers","following_url":"https://api.github.com/users/vaclavbohac/following{/other_user}","gists_url":"https://api.github.com/users/vaclavbohac/gists{/gist_id}","starred_url":"https://api.github.com/users/vaclavbohac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaclavbohac/subscriptions","organizations_url":"https://api.github.com/users/vaclavbohac/orgs","repos_url":"https://api.github.com/users/vaclavbohac/repos","events_url":"https://api.github.com/users/vaclavbohac/events{/privacy}","received_events_url":"https://api.github.com/users/vaclavbohac/received_events","type":"User","site_admin":false},"body":"First, shouldn't it be HighChartsRenderer instead of HighChartRenderer?\r\n\r\nI suggest to rewrite this as:\r\n\r\n```typescript\r\nexport interface IHighChartRendererState {\r\n    legendItemsEnabled: boolean[];\r\n}\r\n\r\nexport default class HightChartsRenderer extends React.PureComponent<IHighChartsRendererProps, IHighChartsRendererState> {","created_at":"2018-04-10T09:16:03Z","updated_at":"2018-04-10T09:59:48Z","html_url":"https://github.com/gooddata/gooddata-react-components/pull/248#discussion_r180348644","pull_request_url":"https://api.github.com/repos/gooddata/gooddata-react-components/pulls/248","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gooddata/gooddata-react-components/pulls/comments/180348644"},"html":{"href":"https://github.com/gooddata/gooddata-react-components/pull/248#discussion_r180348644"},"pull_request":{"href":"https://api.github.com/repos/gooddata/gooddata-react-components/pulls/248"}}},"pull_request":{"url":"https://api.github.com/repos/gooddata/gooddata-react-components/pulls/248","id":178247526,"html_url":"https://github.com/gooddata/gooddata-react-components/pull/248","diff_url":"https://github.com/gooddata/gooddata-react-components/pull/248.diff","patch_url":"https://github.com/gooddata/gooddata-react-components/pull/248.patch","issue_url":"https://api.github.com/repos/gooddata/gooddata-react-components/issues/248","number":248,"state":"open","locked":false,"title":" RELATED: FET-57 Move charts to react-components ","user":{"login":"pbenes","id":998317,"avatar_url":"https://avatars3.githubusercontent.com/u/998317?v=4","gravatar_id":"","url":"https://api.github.com/users/pbenes","html_url":"https://github.com/pbenes","followers_url":"https://api.github.com/users/pbenes/followers","following_url":"https://api.github.com/users/pbenes/following{/other_user}","gists_url":"https://api.github.com/users/pbenes/gists{/gist_id}","starred_url":"https://api.github.com/users/pbenes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbenes/subscriptions","organizations_url":"https://api.github.com/users/pbenes/orgs","repos_url":"https://api.github.com/users/pbenes/repos","events_url":"https://api.github.com/users/pbenes/events{/privacy}","received_events_url":"https://api.github.com/users/pbenes/received_events","type":"User","site_admin":false},"body":"Related pr: https://github.com/gooddata/gooddata-indigo-visualizations/pull/273\r\n(need to avoid including Highcharts twice)","created_at":"2018-03-29T07:29:28Z","updated_at":"2018-04-10T09:59:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fcceb339d405999789b4daa0ea1c7fceaff61a6a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":600734146,"url":"https://api.github.com/repos/gooddata/gooddata-react-components/labels/do%20not%20merge","name":"do not merge","color":"e11d21","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/gooddata/gooddata-react-components/pulls/248/commits","review_comments_url":"https://api.github.com/repos/gooddata/gooddata-react-components/pulls/248/comments","review_comment_url":"https://api.github.com/repos/gooddata/gooddata-react-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gooddata/gooddata-react-components/issues/248/comments","statuses_url":"https://api.github.com/repos/gooddata/gooddata-react-components/statuses/a07b42a32876d5edd7afb3a011cee7f94ef87c08","head":{"label":"pbenes:pb-move-charts","ref":"pb-move-charts","sha":"a07b42a32876d5edd7afb3a011cee7f94ef87c08","user":{"login":"pbenes","id":998317,"avatar_url":"https://avatars3.githubusercontent.com/u/998317?v=4","gravatar_id":"","url":"https://api.github.com/users/pbenes","html_url":"https://github.com/pbenes","followers_url":"https://api.github.com/users/pbenes/followers","following_url":"https://api.github.com/users/pbenes/following{/other_user}","gists_url":"https://api.github.com/users/pbenes/gists{/gist_id}","starred_url":"https://api.github.com/users/pbenes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbenes/subscriptions","organizations_url":"https://api.github.com/users/pbenes/orgs","repos_url":"https://api.github.com/users/pbenes/repos","events_url":"https://api.github.com/users/pbenes/events{/privacy}","received_events_url":"https://api.github.com/users/pbenes/received_events","type":"User","site_admin":false},"repo":{"id":108416194,"name":"gooddata-react-components","full_name":"pbenes/gooddata-react-components","owner":{"login":"pbenes","id":998317,"avatar_url":"https://avatars3.githubusercontent.com/u/998317?v=4","gravatar_id":"","url":"https://api.github.com/users/pbenes","html_url":"https://github.com/pbenes","followers_url":"https://api.github.com/users/pbenes/followers","following_url":"https://api.github.com/users/pbenes/following{/other_user}","gists_url":"https://api.github.com/users/pbenes/gists{/gist_id}","starred_url":"https://api.github.com/users/pbenes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbenes/subscriptions","organizations_url":"https://api.github.com/users/pbenes/orgs","repos_url":"https://api.github.com/users/pbenes/repos","events_url":"https://api.github.com/users/pbenes/events{/privacy}","received_events_url":"https://api.github.com/users/pbenes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pbenes/gooddata-react-components","description":"GoodData React Components","fork":true,"url":"https://api.github.com/repos/pbenes/gooddata-react-components","forks_url":"https://api.github.com/repos/pbenes/gooddata-react-components/forks","keys_url":"https://api.github.com/repos/pbenes/gooddata-react-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pbenes/gooddata-react-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pbenes/gooddata-react-components/teams","hooks_url":"https://api.github.com/repos/pbenes/gooddata-react-components/hooks","issue_events_url":"https://api.github.com/repos/pbenes/gooddata-react-components/issues/events{/number}","events_url":"https://api.github.com/repos/pbenes/gooddata-react-components/events","assignees_url":"https://api.github.com/repos/pbenes/gooddata-react-components/assignees{/user}","branches_url":"https://api.github.com/repos/pbenes/gooddata-react-components/branches{/branch}","tags_url":"https://api.github.com/repos/pbenes/gooddata-react-components/tags","blobs_url":"https://api.github.com/repos/pbenes/gooddata-react-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pbenes/gooddata-react-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pbenes/gooddata-react-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/pbenes/gooddata-react-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pbenes/gooddata-react-components/statuses/{sha}","languages_url":"https://api.github.com/repos/pbenes/gooddata-react-components/languages","stargazers_url":"https://api.github.com/repos/pbenes/gooddata-react-components/stargazers","contributors_url":"https://api.github.com/repos/pbenes/gooddata-react-components/contributors","subscribers_url":"https://api.github.com/repos/pbenes/gooddata-react-components/subscribers","subscription_url":"https://api.github.com/repos/pbenes/gooddata-react-components/subscription","commits_url":"https://api.github.com/repos/pbenes/gooddata-react-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/pbenes/gooddata-react-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/pbenes/gooddata-react-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/pbenes/gooddata-react-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/pbenes/gooddata-react-components/contents/{+path}","compare_url":"https://api.github.com/repos/pbenes/gooddata-react-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pbenes/gooddata-react-components/merges","archive_url":"https://api.github.com/repos/pbenes/gooddata-react-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pbenes/gooddata-react-components/downloads","issues_url":"https://api.github.com/repos/pbenes/gooddata-react-components/issues{/number}","pulls_url":"https://api.github.com/repos/pbenes/gooddata-react-components/pulls{/number}","milestones_url":"https://api.github.com/repos/pbenes/gooddata-react-components/milestones{/number}","notifications_url":"https://api.github.com/repos/pbenes/gooddata-react-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pbenes/gooddata-react-components/labels{/name}","releases_url":"https://api.github.com/repos/pbenes/gooddata-react-components/releases{/id}","deployments_url":"https://api.github.com/repos/pbenes/gooddata-react-components/deployments","created_at":"2017-10-26T13:36:47Z","updated_at":"2017-10-26T13:36:49Z","pushed_at":"2018-04-10T06:43:34Z","git_url":"git://github.com/pbenes/gooddata-react-components.git","ssh_url":"git@github.com:pbenes/gooddata-react-components.git","clone_url":"https://github.com/pbenes/gooddata-react-components.git","svn_url":"https://github.com/pbenes/gooddata-react-components","homepage":"","size":5891,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gooddata:next-5.0.0","ref":"next-5.0.0","sha":"170b678125bb91ea39ad7fa764932f0b05c42dc6","user":{"login":"gooddata","id":291394,"avatar_url":"https://avatars2.githubusercontent.com/u/291394?v=4","gravatar_id":"","url":"https://api.github.com/users/gooddata","html_url":"https://github.com/gooddata","followers_url":"https://api.github.com/users/gooddata/followers","following_url":"https://api.github.com/users/gooddata/following{/other_user}","gists_url":"https://api.github.com/users/gooddata/gists{/gist_id}","starred_url":"https://api.github.com/users/gooddata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gooddata/subscriptions","organizations_url":"https://api.github.com/users/gooddata/orgs","repos_url":"https://api.github.com/users/gooddata/repos","events_url":"https://api.github.com/users/gooddata/events{/privacy}","received_events_url":"https://api.github.com/users/gooddata/received_events","type":"Organization","site_admin":false},"repo":{"id":90664084,"name":"gooddata-react-components","full_name":"gooddata/gooddata-react-components","owner":{"login":"gooddata","id":291394,"avatar_url":"https://avatars2.githubusercontent.com/u/291394?v=4","gravatar_id":"","url":"https://api.github.com/users/gooddata","html_url":"https://github.com/gooddata","followers_url":"https://api.github.com/users/gooddata/followers","following_url":"https://api.github.com/users/gooddata/following{/other_user}","gists_url":"https://api.github.com/users/gooddata/gists{/gist_id}","starred_url":"https://api.github.com/users/gooddata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gooddata/subscriptions","organizations_url":"https://api.github.com/users/gooddata/orgs","repos_url":"https://api.github.com/users/gooddata/repos","events_url":"https://api.github.com/users/gooddata/events{/privacy}","received_events_url":"https://api.github.com/users/gooddata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gooddata/gooddata-react-components","description":"GoodData React Components","fork":false,"url":"https://api.github.com/repos/gooddata/gooddata-react-components","forks_url":"https://api.github.com/repos/gooddata/gooddata-react-components/forks","keys_url":"https://api.github.com/repos/gooddata/gooddata-react-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gooddata/gooddata-react-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gooddata/gooddata-react-components/teams","hooks_url":"https://api.github.com/repos/gooddata/gooddata-react-components/hooks","issue_events_url":"https://api.github.com/repos/gooddata/gooddata-react-components/issues/events{/number}","events_url":"https://api.github.com/repos/gooddata/gooddata-react-components/events","assignees_url":"https://api.github.com/repos/gooddata/gooddata-react-components/assignees{/user}","branches_url":"https://api.github.com/repos/gooddata/gooddata-react-components/branches{/branch}","tags_url":"https://api.github.com/repos/gooddata/gooddata-react-components/tags","blobs_url":"https://api.github.com/repos/gooddata/gooddata-react-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gooddata/gooddata-react-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gooddata/gooddata-react-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/gooddata/gooddata-react-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gooddata/gooddata-react-components/statuses/{sha}","languages_url":"https://api.github.com/repos/gooddata/gooddata-react-components/languages","stargazers_url":"https://api.github.com/repos/gooddata/gooddata-react-components/stargazers","contributors_url":"https://api.github.com/repos/gooddata/gooddata-react-components/contributors","subscribers_url":"https://api.github.com/repos/gooddata/gooddata-react-components/subscribers","subscription_url":"https://api.github.com/repos/gooddata/gooddata-react-components/subscription","commits_url":"https://api.github.com/repos/gooddata/gooddata-react-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/gooddata/gooddata-react-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/gooddata/gooddata-react-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/gooddata/gooddata-react-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/gooddata/gooddata-react-components/contents/{+path}","compare_url":"https://api.github.com/repos/gooddata/gooddata-react-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gooddata/gooddata-react-components/merges","archive_url":"https://api.github.com/repos/gooddata/gooddata-react-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gooddata/gooddata-react-components/downloads","issues_url":"https://api.github.com/repos/gooddata/gooddata-react-components/issues{/number}","pulls_url":"https://api.github.com/repos/gooddata/gooddata-react-components/pulls{/number}","milestones_url":"https://api.github.com/repos/gooddata/gooddata-react-components/milestones{/number}","notifications_url":"https://api.github.com/repos/gooddata/gooddata-react-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gooddata/gooddata-react-components/labels{/name}","releases_url":"https://api.github.com/repos/gooddata/gooddata-react-components/releases{/id}","deployments_url":"https://api.github.com/repos/gooddata/gooddata-react-components/deployments","created_at":"2017-05-08T19:18:42Z","updated_at":"2018-04-09T11:33:57Z","pushed_at":"2018-04-10T06:43:36Z","git_url":"git://github.com/gooddata/gooddata-react-components.git","ssh_url":"git@github.com:gooddata/gooddata-react-components.git","clone_url":"https://github.com/gooddata/gooddata-react-components.git","svn_url":"https://github.com/gooddata/gooddata-react-components","homepage":"","size":4026,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":24,"open_issues":15,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gooddata/gooddata-react-components/pulls/248"},"html":{"href":"https://github.com/gooddata/gooddata-react-components/pull/248"},"issue":{"href":"https://api.github.com/repos/gooddata/gooddata-react-components/issues/248"},"comments":{"href":"https://api.github.com/repos/gooddata/gooddata-react-components/issues/248/comments"},"review_comments":{"href":"https://api.github.com/repos/gooddata/gooddata-react-components/pulls/248/comments"},"review_comment":{"href":"https://api.github.com/repos/gooddata/gooddata-react-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gooddata/gooddata-react-components/pulls/248/commits"},"statuses":{"href":"https://api.github.com/repos/gooddata/gooddata-react-components/statuses/a07b42a32876d5edd7afb3a011cee7f94ef87c08"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vaclavbohac"}}