{"action":"created","comment":{"url":"https://api.github.com/repos/wireapp/wire-desktop/pulls/comments/173167022","pull_request_review_id":102309511,"id":173167022,"diff_hunk":"@@ -72,7 +72,7 @@ module.exports = {\n       publicKeyBytes = Buffer.from(publicKey.keyhex, 'hex').toString('binary');\n       publicKeyFingerprint = crypto.createHash('sha256').update(publicKeyBytes).digest('base64');\n     } catch (err) {\n-      console.error('verifyPinning', err);\n+      console.error('Certificate verification failed', err);","path":"electron/js/certutils.js","position":39,"original_position":39,"commit_id":"7696c41a5f144b8f4492154b89090518293a9940","original_commit_id":"7696c41a5f144b8f4492154b89090518293a9940","user":{"login":"bennyn","id":469989,"avatar_url":"https://avatars3.githubusercontent.com/u/469989?v=4","gravatar_id":"","url":"https://api.github.com/users/bennyn","html_url":"https://github.com/bennyn","followers_url":"https://api.github.com/users/bennyn/followers","following_url":"https://api.github.com/users/bennyn/following{/other_user}","gists_url":"https://api.github.com/users/bennyn/gists{/gist_id}","starred_url":"https://api.github.com/users/bennyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bennyn/subscriptions","organizations_url":"https://api.github.com/users/bennyn/orgs","repos_url":"https://api.github.com/users/bennyn/repos","events_url":"https://api.github.com/users/bennyn/events{/privacy}","received_events_url":"https://api.github.com/users/bennyn/received_events","type":"User","site_admin":false},"body":"`'Certificate verification failed'` → ``Certificate verification failed: ${error.message}``","created_at":"2018-03-08T14:09:25Z","updated_at":"2018-03-08T14:09:30Z","html_url":"https://github.com/wireapp/wire-desktop/pull/1333#discussion_r173167022","pull_request_url":"https://api.github.com/repos/wireapp/wire-desktop/pulls/1333","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-desktop/pulls/comments/173167022"},"html":{"href":"https://github.com/wireapp/wire-desktop/pull/1333#discussion_r173167022"},"pull_request":{"href":"https://api.github.com/repos/wireapp/wire-desktop/pulls/1333"}}},"pull_request":{"url":"https://api.github.com/repos/wireapp/wire-desktop/pulls/1333","id":173743912,"html_url":"https://github.com/wireapp/wire-desktop/pull/1333","diff_url":"https://github.com/wireapp/wire-desktop/pull/1333.diff","patch_url":"https://github.com/wireapp/wire-desktop/pull/1333.patch","issue_url":"https://api.github.com/repos/wireapp/wire-desktop/issues/1333","number":1333,"state":"open","locked":false,"title":"fix: Certificate pinning: CloudFront uses DigiCert","user":{"login":"ffflorian","id":5497598,"avatar_url":"https://avatars3.githubusercontent.com/u/5497598?v=4","gravatar_id":"","url":"https://api.github.com/users/ffflorian","html_url":"https://github.com/ffflorian","followers_url":"https://api.github.com/users/ffflorian/followers","following_url":"https://api.github.com/users/ffflorian/following{/other_user}","gists_url":"https://api.github.com/users/ffflorian/gists{/gist_id}","starred_url":"https://api.github.com/users/ffflorian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ffflorian/subscriptions","organizations_url":"https://api.github.com/users/ffflorian/orgs","repos_url":"https://api.github.com/users/ffflorian/repos","events_url":"https://api.github.com/users/ffflorian/events{/privacy}","received_events_url":"https://api.github.com/users/ffflorian/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-08T14:04:35Z","updated_at":"2018-03-08T14:09:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1010cd9ac0e3007005ff7bb0e4363c007f0a38a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wireapp/wire-desktop/pulls/1333/commits","review_comments_url":"https://api.github.com/repos/wireapp/wire-desktop/pulls/1333/comments","review_comment_url":"https://api.github.com/repos/wireapp/wire-desktop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wireapp/wire-desktop/issues/1333/comments","statuses_url":"https://api.github.com/repos/wireapp/wire-desktop/statuses/7696c41a5f144b8f4492154b89090518293a9940","head":{"label":"wireapp:fix/cert-pinning","ref":"fix/cert-pinning","sha":"7696c41a5f144b8f4492154b89090518293a9940","user":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":64225407,"name":"wire-desktop","full_name":"wireapp/wire-desktop","owner":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/wire-desktop","description":":computer: Wire for desktop","fork":false,"url":"https://api.github.com/repos/wireapp/wire-desktop","forks_url":"https://api.github.com/repos/wireapp/wire-desktop/forks","keys_url":"https://api.github.com/repos/wireapp/wire-desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-desktop/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-desktop/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-desktop/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-desktop/events","assignees_url":"https://api.github.com/repos/wireapp/wire-desktop/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-desktop/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-desktop/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-desktop/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-desktop/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-desktop/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-desktop/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-desktop/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-desktop/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-desktop/merges","archive_url":"https://api.github.com/repos/wireapp/wire-desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-desktop/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-desktop/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-desktop/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-desktop/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-desktop/deployments","created_at":"2016-07-26T13:55:48Z","updated_at":"2018-03-08T12:33:42Z","pushed_at":"2018-03-08T14:04:36Z","git_url":"git://github.com/wireapp/wire-desktop.git","ssh_url":"git@github.com:wireapp/wire-desktop.git","clone_url":"https://github.com/wireapp/wire-desktop.git","svn_url":"https://github.com/wireapp/wire-desktop","homepage":"https://wire.com/download/","size":3251,"stargazers_count":630,"watchers_count":630,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":124,"mirror_url":null,"archived":false,"open_issues_count":87,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":124,"open_issues":87,"watchers":630,"default_branch":"master"}},"base":{"label":"wireapp:master","ref":"master","sha":"88f2605717c713433928e1e865c40a5ad4f2f4d4","user":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":64225407,"name":"wire-desktop","full_name":"wireapp/wire-desktop","owner":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/wire-desktop","description":":computer: Wire for desktop","fork":false,"url":"https://api.github.com/repos/wireapp/wire-desktop","forks_url":"https://api.github.com/repos/wireapp/wire-desktop/forks","keys_url":"https://api.github.com/repos/wireapp/wire-desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-desktop/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-desktop/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-desktop/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-desktop/events","assignees_url":"https://api.github.com/repos/wireapp/wire-desktop/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-desktop/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-desktop/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-desktop/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-desktop/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-desktop/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-desktop/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-desktop/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-desktop/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-desktop/merges","archive_url":"https://api.github.com/repos/wireapp/wire-desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-desktop/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-desktop/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-desktop/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-desktop/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-desktop/deployments","created_at":"2016-07-26T13:55:48Z","updated_at":"2018-03-08T12:33:42Z","pushed_at":"2018-03-08T14:04:36Z","git_url":"git://github.com/wireapp/wire-desktop.git","ssh_url":"git@github.com:wireapp/wire-desktop.git","clone_url":"https://github.com/wireapp/wire-desktop.git","svn_url":"https://github.com/wireapp/wire-desktop","homepage":"https://wire.com/download/","size":3251,"stargazers_count":630,"watchers_count":630,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":124,"mirror_url":null,"archived":false,"open_issues_count":87,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":124,"open_issues":87,"watchers":630,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-desktop/pulls/1333"},"html":{"href":"https://github.com/wireapp/wire-desktop/pull/1333"},"issue":{"href":"https://api.github.com/repos/wireapp/wire-desktop/issues/1333"},"comments":{"href":"https://api.github.com/repos/wireapp/wire-desktop/issues/1333/comments"},"review_comments":{"href":"https://api.github.com/repos/wireapp/wire-desktop/pulls/1333/comments"},"review_comment":{"href":"https://api.github.com/repos/wireapp/wire-desktop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wireapp/wire-desktop/pulls/1333/commits"},"statuses":{"href":"https://api.github.com/repos/wireapp/wire-desktop/statuses/7696c41a5f144b8f4492154b89090518293a9940"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bennyn"}}