{"action":"closed","number":109,"pull_request":{"url":"https://api.github.com/repos/notVitaliy/magic8bot/pulls/109","id":203637778,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNjM3Nzc4","html_url":"https://github.com/notVitaliy/magic8bot/pull/109","diff_url":"https://github.com/notVitaliy/magic8bot/pull/109.diff","patch_url":"https://github.com/notVitaliy/magic8bot/pull/109.patch","issue_url":"https://api.github.com/repos/notVitaliy/magic8bot/issues/109","number":109,"state":"closed","locked":false,"title":"2 extra test cases for period.store.spec.ts","user":{"login":"Shawn8901","id":12239057,"node_id":"MDQ6VXNlcjEyMjM5MDU3","avatar_url":"https://avatars2.githubusercontent.com/u/12239057?v=4","gravatar_id":"","url":"https://api.github.com/users/Shawn8901","html_url":"https://github.com/Shawn8901","followers_url":"https://api.github.com/users/Shawn8901/followers","following_url":"https://api.github.com/users/Shawn8901/following{/other_user}","gists_url":"https://api.github.com/users/Shawn8901/gists{/gist_id}","starred_url":"https://api.github.com/users/Shawn8901/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shawn8901/subscriptions","organizations_url":"https://api.github.com/users/Shawn8901/orgs","repos_url":"https://api.github.com/users/Shawn8901/repos","events_url":"https://api.github.com/users/Shawn8901/events{/privacy}","received_events_url":"https://api.github.com/users/Shawn8901/received_events","type":"User","site_admin":false},"body":"Added 2 minimal extra test cases on period.store.spec which where somehow missing for me.\r\nOne just checks if the amount is not increasing after adding more periods than to store\r\nSecond checks if the order of periods is expected ( 0 = youngest, 1  = previous youngest)\r\n\r\nI am open for additional checks or improvements.","created_at":"2018-07-24T19:58:34Z","updated_at":"2018-07-24T23:50:10Z","closed_at":"2018-07-24T23:50:10Z","merged_at":"2018-07-24T23:50:10Z","merge_commit_sha":"7707d8e2955fe8643debde3156d97c67728aa8ee","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/notVitaliy/magic8bot/pulls/109/commits","review_comments_url":"https://api.github.com/repos/notVitaliy/magic8bot/pulls/109/comments","review_comment_url":"https://api.github.com/repos/notVitaliy/magic8bot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/notVitaliy/magic8bot/issues/109/comments","statuses_url":"https://api.github.com/repos/notVitaliy/magic8bot/statuses/701fcdf32d2febfc7d3fd09caafb15453e90d5e9","head":{"label":"notVitaliy:shawn8901/periodstore_2_testcase","ref":"shawn8901/periodstore_2_testcase","sha":"701fcdf32d2febfc7d3fd09caafb15453e90d5e9","user":{"login":"notVitaliy","id":3137491,"node_id":"MDQ6VXNlcjMxMzc0OTE=","avatar_url":"https://avatars3.githubusercontent.com/u/3137491?v=4","gravatar_id":"","url":"https://api.github.com/users/notVitaliy","html_url":"https://github.com/notVitaliy","followers_url":"https://api.github.com/users/notVitaliy/followers","following_url":"https://api.github.com/users/notVitaliy/following{/other_user}","gists_url":"https://api.github.com/users/notVitaliy/gists{/gist_id}","starred_url":"https://api.github.com/users/notVitaliy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/notVitaliy/subscriptions","organizations_url":"https://api.github.com/users/notVitaliy/orgs","repos_url":"https://api.github.com/users/notVitaliy/repos","events_url":"https://api.github.com/users/notVitaliy/events{/privacy}","received_events_url":"https://api.github.com/users/notVitaliy/received_events","type":"User","site_admin":false},"repo":{"id":140289364,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAyODkzNjQ=","name":"magic8bot","full_name":"notVitaliy/magic8bot","owner":{"login":"notVitaliy","id":3137491,"node_id":"MDQ6VXNlcjMxMzc0OTE=","avatar_url":"https://avatars3.githubusercontent.com/u/3137491?v=4","gravatar_id":"","url":"https://api.github.com/users/notVitaliy","html_url":"https://github.com/notVitaliy","followers_url":"https://api.github.com/users/notVitaliy/followers","following_url":"https://api.github.com/users/notVitaliy/following{/other_user}","gists_url":"https://api.github.com/users/notVitaliy/gists{/gist_id}","starred_url":"https://api.github.com/users/notVitaliy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/notVitaliy/subscriptions","organizations_url":"https://api.github.com/users/notVitaliy/orgs","repos_url":"https://api.github.com/users/notVitaliy/repos","events_url":"https://api.github.com/users/notVitaliy/events{/privacy}","received_events_url":"https://api.github.com/users/notVitaliy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/notVitaliy/magic8bot","description":"Magic8bot is a command-line cryptocurrency trading bot using Node.js and MongoDB.","fork":false,"url":"https://api.github.com/repos/notVitaliy/magic8bot","forks_url":"https://api.github.com/repos/notVitaliy/magic8bot/forks","keys_url":"https://api.github.com/repos/notVitaliy/magic8bot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/notVitaliy/magic8bot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/notVitaliy/magic8bot/teams","hooks_url":"https://api.github.com/repos/notVitaliy/magic8bot/hooks","issue_events_url":"https://api.github.com/repos/notVitaliy/magic8bot/issues/events{/number}","events_url":"https://api.github.com/repos/notVitaliy/magic8bot/events","assignees_url":"https://api.github.com/repos/notVitaliy/magic8bot/assignees{/user}","branches_url":"https://api.github.com/repos/notVitaliy/magic8bot/branches{/branch}","tags_url":"https://api.github.com/repos/notVitaliy/magic8bot/tags","blobs_url":"https://api.github.com/repos/notVitaliy/magic8bot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/notVitaliy/magic8bot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/notVitaliy/magic8bot/git/refs{/sha}","trees_url":"https://api.github.com/repos/notVitaliy/magic8bot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/notVitaliy/magic8bot/statuses/{sha}","languages_url":"https://api.github.com/repos/notVitaliy/magic8bot/languages","stargazers_url":"https://api.github.com/repos/notVitaliy/magic8bot/stargazers","contributors_url":"https://api.github.com/repos/notVitaliy/magic8bot/contributors","subscribers_url":"https://api.github.com/repos/notVitaliy/magic8bot/subscribers","subscription_url":"https://api.github.com/repos/notVitaliy/magic8bot/subscription","commits_url":"https://api.github.com/repos/notVitaliy/magic8bot/commits{/sha}","git_commits_url":"https://api.github.com/repos/notVitaliy/magic8bot/git/commits{/sha}","comments_url":"https://api.github.com/repos/notVitaliy/magic8bot/comments{/number}","issue_comment_url":"https://api.github.com/repos/notVitaliy/magic8bot/issues/comments{/number}","contents_url":"https://api.github.com/repos/notVitaliy/magic8bot/contents/{+path}","compare_url":"https://api.github.com/repos/notVitaliy/magic8bot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/notVitaliy/magic8bot/merges","archive_url":"https://api.github.com/repos/notVitaliy/magic8bot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/notVitaliy/magic8bot/downloads","issues_url":"https://api.github.com/repos/notVitaliy/magic8bot/issues{/number}","pulls_url":"https://api.github.com/repos/notVitaliy/magic8bot/pulls{/number}","milestones_url":"https://api.github.com/repos/notVitaliy/magic8bot/milestones{/number}","notifications_url":"https://api.github.com/repos/notVitaliy/magic8bot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/notVitaliy/magic8bot/labels{/name}","releases_url":"https://api.github.com/repos/notVitaliy/magic8bot/releases{/id}","deployments_url":"https://api.github.com/repos/notVitaliy/magic8bot/deployments","created_at":"2018-07-09T13:27:43Z","updated_at":"2018-07-24T16:50:51Z","pushed_at":"2018-07-24T23:50:10Z","git_url":"git://github.com/notVitaliy/magic8bot.git","ssh_url":"git@github.com:notVitaliy/magic8bot.git","clone_url":"https://github.com/notVitaliy/magic8bot.git","svn_url":"https://github.com/notVitaliy/magic8bot","homepage":"","size":2808,"stargazers_count":19,"watchers_count":19,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":95,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":95,"watchers":19,"default_branch":"master"}},"base":{"label":"notVitaliy:master","ref":"master","sha":"c28c32d263528a0cd26cb6122a3ed5cc043c2dc3","user":{"login":"notVitaliy","id":3137491,"node_id":"MDQ6VXNlcjMxMzc0OTE=","avatar_url":"https://avatars3.githubusercontent.com/u/3137491?v=4","gravatar_id":"","url":"https://api.github.com/users/notVitaliy","html_url":"https://github.com/notVitaliy","followers_url":"https://api.github.com/users/notVitaliy/followers","following_url":"https://api.github.com/users/notVitaliy/following{/other_user}","gists_url":"https://api.github.com/users/notVitaliy/gists{/gist_id}","starred_url":"https://api.github.com/users/notVitaliy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/notVitaliy/subscriptions","organizations_url":"https://api.github.com/users/notVitaliy/orgs","repos_url":"https://api.github.com/users/notVitaliy/repos","events_url":"https://api.github.com/users/notVitaliy/events{/privacy}","received_events_url":"https://api.github.com/users/notVitaliy/received_events","type":"User","site_admin":false},"repo":{"id":140289364,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAyODkzNjQ=","name":"magic8bot","full_name":"notVitaliy/magic8bot","owner":{"login":"notVitaliy","id":3137491,"node_id":"MDQ6VXNlcjMxMzc0OTE=","avatar_url":"https://avatars3.githubusercontent.com/u/3137491?v=4","gravatar_id":"","url":"https://api.github.com/users/notVitaliy","html_url":"https://github.com/notVitaliy","followers_url":"https://api.github.com/users/notVitaliy/followers","following_url":"https://api.github.com/users/notVitaliy/following{/other_user}","gists_url":"https://api.github.com/users/notVitaliy/gists{/gist_id}","starred_url":"https://api.github.com/users/notVitaliy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/notVitaliy/subscriptions","organizations_url":"https://api.github.com/users/notVitaliy/orgs","repos_url":"https://api.github.com/users/notVitaliy/repos","events_url":"https://api.github.com/users/notVitaliy/events{/privacy}","received_events_url":"https://api.github.com/users/notVitaliy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/notVitaliy/magic8bot","description":"Magic8bot is a command-line cryptocurrency trading bot using Node.js and MongoDB.","fork":false,"url":"https://api.github.com/repos/notVitaliy/magic8bot","forks_url":"https://api.github.com/repos/notVitaliy/magic8bot/forks","keys_url":"https://api.github.com/repos/notVitaliy/magic8bot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/notVitaliy/magic8bot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/notVitaliy/magic8bot/teams","hooks_url":"https://api.github.com/repos/notVitaliy/magic8bot/hooks","issue_events_url":"https://api.github.com/repos/notVitaliy/magic8bot/issues/events{/number}","events_url":"https://api.github.com/repos/notVitaliy/magic8bot/events","assignees_url":"https://api.github.com/repos/notVitaliy/magic8bot/assignees{/user}","branches_url":"https://api.github.com/repos/notVitaliy/magic8bot/branches{/branch}","tags_url":"https://api.github.com/repos/notVitaliy/magic8bot/tags","blobs_url":"https://api.github.com/repos/notVitaliy/magic8bot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/notVitaliy/magic8bot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/notVitaliy/magic8bot/git/refs{/sha}","trees_url":"https://api.github.com/repos/notVitaliy/magic8bot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/notVitaliy/magic8bot/statuses/{sha}","languages_url":"https://api.github.com/repos/notVitaliy/magic8bot/languages","stargazers_url":"https://api.github.com/repos/notVitaliy/magic8bot/stargazers","contributors_url":"https://api.github.com/repos/notVitaliy/magic8bot/contributors","subscribers_url":"https://api.github.com/repos/notVitaliy/magic8bot/subscribers","subscription_url":"https://api.github.com/repos/notVitaliy/magic8bot/subscription","commits_url":"https://api.github.com/repos/notVitaliy/magic8bot/commits{/sha}","git_commits_url":"https://api.github.com/repos/notVitaliy/magic8bot/git/commits{/sha}","comments_url":"https://api.github.com/repos/notVitaliy/magic8bot/comments{/number}","issue_comment_url":"https://api.github.com/repos/notVitaliy/magic8bot/issues/comments{/number}","contents_url":"https://api.github.com/repos/notVitaliy/magic8bot/contents/{+path}","compare_url":"https://api.github.com/repos/notVitaliy/magic8bot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/notVitaliy/magic8bot/merges","archive_url":"https://api.github.com/repos/notVitaliy/magic8bot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/notVitaliy/magic8bot/downloads","issues_url":"https://api.github.com/repos/notVitaliy/magic8bot/issues{/number}","pulls_url":"https://api.github.com/repos/notVitaliy/magic8bot/pulls{/number}","milestones_url":"https://api.github.com/repos/notVitaliy/magic8bot/milestones{/number}","notifications_url":"https://api.github.com/repos/notVitaliy/magic8bot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/notVitaliy/magic8bot/labels{/name}","releases_url":"https://api.github.com/repos/notVitaliy/magic8bot/releases{/id}","deployments_url":"https://api.github.com/repos/notVitaliy/magic8bot/deployments","created_at":"2018-07-09T13:27:43Z","updated_at":"2018-07-24T16:50:51Z","pushed_at":"2018-07-24T23:50:10Z","git_url":"git://github.com/notVitaliy/magic8bot.git","ssh_url":"git@github.com:notVitaliy/magic8bot.git","clone_url":"https://github.com/notVitaliy/magic8bot.git","svn_url":"https://github.com/notVitaliy/magic8bot","homepage":"","size":2808,"stargazers_count":19,"watchers_count":19,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":95,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":95,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/notVitaliy/magic8bot/pulls/109"},"html":{"href":"https://github.com/notVitaliy/magic8bot/pull/109"},"issue":{"href":"https://api.github.com/repos/notVitaliy/magic8bot/issues/109"},"comments":{"href":"https://api.github.com/repos/notVitaliy/magic8bot/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/notVitaliy/magic8bot/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/notVitaliy/magic8bot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/notVitaliy/magic8bot/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/notVitaliy/magic8bot/statuses/701fcdf32d2febfc7d3fd09caafb15453e90d5e9"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"notVitaliy","id":3137491,"node_id":"MDQ6VXNlcjMxMzc0OTE=","avatar_url":"https://avatars3.githubusercontent.com/u/3137491?v=4","gravatar_id":"","url":"https://api.github.com/users/notVitaliy","html_url":"https://github.com/notVitaliy","followers_url":"https://api.github.com/users/notVitaliy/followers","following_url":"https://api.github.com/users/notVitaliy/following{/other_user}","gists_url":"https://api.github.com/users/notVitaliy/gists{/gist_id}","starred_url":"https://api.github.com/users/notVitaliy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/notVitaliy/subscriptions","organizations_url":"https://api.github.com/users/notVitaliy/orgs","repos_url":"https://api.github.com/users/notVitaliy/repos","events_url":"https://api.github.com/users/notVitaliy/events{/privacy}","received_events_url":"https://api.github.com/users/notVitaliy/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":34,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"notVitaliy"}}