{"action":"created","comment":{"url":"https://api.github.com/repos/whatwg/html/pulls/comments/172069839","pull_request_review_id":101024722,"id":172069839,"diff_hunk":"@@ -52529,6 +52529,26 @@ interface <dfn>HTMLLegendElement</dfn> : <span>HTMLElement</span> {\n \n   </div>\n \n+  <div class=\"note\">\n+   <p>DOM clobbering is a common cause of security issues. Avoid using the names of\n+   built-in form properties with the <code data-x=\"attr-fe-name\">name</code> content attribute.</p>\n+\n+   <p>In this example, the input element overrides the built-in \"method\" property:</p>","path":"source","position":8,"original_position":8,"commit_id":"af879b718caba2f91aed0479ddf5a54c8459be11","original_commit_id":"af879b718caba2f91aed0479ddf5a54c8459be11","user":{"login":"GloverDonovan","id":2374245,"avatar_url":"https://avatars1.githubusercontent.com/u/2374245?v=4","gravatar_id":"","url":"https://api.github.com/users/GloverDonovan","html_url":"https://github.com/GloverDonovan","followers_url":"https://api.github.com/users/GloverDonovan/followers","following_url":"https://api.github.com/users/GloverDonovan/following{/other_user}","gists_url":"https://api.github.com/users/GloverDonovan/gists{/gist_id}","starred_url":"https://api.github.com/users/GloverDonovan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GloverDonovan/subscriptions","organizations_url":"https://api.github.com/users/GloverDonovan/orgs","repos_url":"https://api.github.com/users/GloverDonovan/repos","events_url":"https://api.github.com/users/GloverDonovan/events{/privacy}","received_events_url":"https://api.github.com/users/GloverDonovan/received_events","type":"User","site_admin":false},"body":"Found it. It's a lot easier to see what you're looking for on the actual page compared to viewing the source (all the patterns I grepped for didn't match any results).","created_at":"2018-03-04T23:27:08Z","updated_at":"2018-03-04T23:27:08Z","html_url":"https://github.com/whatwg/html/pull/3484#discussion_r172069839","pull_request_url":"https://api.github.com/repos/whatwg/html/pulls/3484","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/whatwg/html/pulls/comments/172069839"},"html":{"href":"https://github.com/whatwg/html/pull/3484#discussion_r172069839"},"pull_request":{"href":"https://api.github.com/repos/whatwg/html/pulls/3484"}},"in_reply_to_id":172049166},"pull_request":{"url":"https://api.github.com/repos/whatwg/html/pulls/3484","id":170047250,"html_url":"https://github.com/whatwg/html/pull/3484","diff_url":"https://github.com/whatwg/html/pull/3484.diff","patch_url":"https://github.com/whatwg/html/pull/3484.patch","issue_url":"https://api.github.com/repos/whatwg/html/issues/3484","number":3484,"state":"open","locked":false,"title":"Add DOM clobbering note to form controls section","user":{"login":"GloverDonovan","id":2374245,"avatar_url":"https://avatars1.githubusercontent.com/u/2374245?v=4","gravatar_id":"","url":"https://api.github.com/users/GloverDonovan","html_url":"https://github.com/GloverDonovan","followers_url":"https://api.github.com/users/GloverDonovan/followers","following_url":"https://api.github.com/users/GloverDonovan/following{/other_user}","gists_url":"https://api.github.com/users/GloverDonovan/gists{/gist_id}","starred_url":"https://api.github.com/users/GloverDonovan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GloverDonovan/subscriptions","organizations_url":"https://api.github.com/users/GloverDonovan/orgs","repos_url":"https://api.github.com/users/GloverDonovan/repos","events_url":"https://api.github.com/users/GloverDonovan/events{/privacy}","received_events_url":"https://api.github.com/users/GloverDonovan/received_events","type":"User","site_admin":false},"body":"This pull request attempts to fix #2720. Suggestions are welcome, and I'm not sure whether or not there should be a single `<input>` example or multiple.\n\n\n<!--\n    This comment and the below content is programatically generated.\n    You may add a comma-separated list of anchors you'd like a\n    direct link to below (e.g. #idl-serializers, #idl-sequence):\n\n    Don't remove this comment or modify anything below this line.\n    If you don't want a preview generated for this pull request,\n    just replace the whole of this comment's content by \"no preview\"\n    and remove what's below.\n-->\n***\n<a href=\"https://whatpr.org/html/3484/form-control-infrastructure.html\" title=\"Last updated on Feb 24, 2018, 8:27 PM GMT (af879b7)\">/form-control-infrastructure.html</a>  ( <a href=\"https://whatpr.org/html/3484/fc82f4f...af879b7/form-control-infrastructure.html\" title=\"Last updated on Feb 24, 2018, 8:27 PM GMT (af879b7)\">diff</a> )","created_at":"2018-02-19T20:31:37Z","updated_at":"2018-03-04T23:27:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef5df746b22b04af5dd0aed43535befe633885a5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/whatwg/html/pulls/3484/commits","review_comments_url":"https://api.github.com/repos/whatwg/html/pulls/3484/comments","review_comment_url":"https://api.github.com/repos/whatwg/html/pulls/comments{/number}","comments_url":"https://api.github.com/repos/whatwg/html/issues/3484/comments","statuses_url":"https://api.github.com/repos/whatwg/html/statuses/af879b718caba2f91aed0479ddf5a54c8459be11","head":{"label":"GloverDonovan:add/dom-clobbering-note","ref":"add/dom-clobbering-note","sha":"af879b718caba2f91aed0479ddf5a54c8459be11","user":{"login":"GloverDonovan","id":2374245,"avatar_url":"https://avatars1.githubusercontent.com/u/2374245?v=4","gravatar_id":"","url":"https://api.github.com/users/GloverDonovan","html_url":"https://github.com/GloverDonovan","followers_url":"https://api.github.com/users/GloverDonovan/followers","following_url":"https://api.github.com/users/GloverDonovan/following{/other_user}","gists_url":"https://api.github.com/users/GloverDonovan/gists{/gist_id}","starred_url":"https://api.github.com/users/GloverDonovan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GloverDonovan/subscriptions","organizations_url":"https://api.github.com/users/GloverDonovan/orgs","repos_url":"https://api.github.com/users/GloverDonovan/repos","events_url":"https://api.github.com/users/GloverDonovan/events{/privacy}","received_events_url":"https://api.github.com/users/GloverDonovan/received_events","type":"User","site_admin":false},"repo":{"id":120386993,"name":"html","full_name":"GloverDonovan/html","owner":{"login":"GloverDonovan","id":2374245,"avatar_url":"https://avatars1.githubusercontent.com/u/2374245?v=4","gravatar_id":"","url":"https://api.github.com/users/GloverDonovan","html_url":"https://github.com/GloverDonovan","followers_url":"https://api.github.com/users/GloverDonovan/followers","following_url":"https://api.github.com/users/GloverDonovan/following{/other_user}","gists_url":"https://api.github.com/users/GloverDonovan/gists{/gist_id}","starred_url":"https://api.github.com/users/GloverDonovan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GloverDonovan/subscriptions","organizations_url":"https://api.github.com/users/GloverDonovan/orgs","repos_url":"https://api.github.com/users/GloverDonovan/repos","events_url":"https://api.github.com/users/GloverDonovan/events{/privacy}","received_events_url":"https://api.github.com/users/GloverDonovan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GloverDonovan/html","description":"HTML Standard","fork":true,"url":"https://api.github.com/repos/GloverDonovan/html","forks_url":"https://api.github.com/repos/GloverDonovan/html/forks","keys_url":"https://api.github.com/repos/GloverDonovan/html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GloverDonovan/html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GloverDonovan/html/teams","hooks_url":"https://api.github.com/repos/GloverDonovan/html/hooks","issue_events_url":"https://api.github.com/repos/GloverDonovan/html/issues/events{/number}","events_url":"https://api.github.com/repos/GloverDonovan/html/events","assignees_url":"https://api.github.com/repos/GloverDonovan/html/assignees{/user}","branches_url":"https://api.github.com/repos/GloverDonovan/html/branches{/branch}","tags_url":"https://api.github.com/repos/GloverDonovan/html/tags","blobs_url":"https://api.github.com/repos/GloverDonovan/html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GloverDonovan/html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GloverDonovan/html/git/refs{/sha}","trees_url":"https://api.github.com/repos/GloverDonovan/html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GloverDonovan/html/statuses/{sha}","languages_url":"https://api.github.com/repos/GloverDonovan/html/languages","stargazers_url":"https://api.github.com/repos/GloverDonovan/html/stargazers","contributors_url":"https://api.github.com/repos/GloverDonovan/html/contributors","subscribers_url":"https://api.github.com/repos/GloverDonovan/html/subscribers","subscription_url":"https://api.github.com/repos/GloverDonovan/html/subscription","commits_url":"https://api.github.com/repos/GloverDonovan/html/commits{/sha}","git_commits_url":"https://api.github.com/repos/GloverDonovan/html/git/commits{/sha}","comments_url":"https://api.github.com/repos/GloverDonovan/html/comments{/number}","issue_comment_url":"https://api.github.com/repos/GloverDonovan/html/issues/comments{/number}","contents_url":"https://api.github.com/repos/GloverDonovan/html/contents/{+path}","compare_url":"https://api.github.com/repos/GloverDonovan/html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GloverDonovan/html/merges","archive_url":"https://api.github.com/repos/GloverDonovan/html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GloverDonovan/html/downloads","issues_url":"https://api.github.com/repos/GloverDonovan/html/issues{/number}","pulls_url":"https://api.github.com/repos/GloverDonovan/html/pulls{/number}","milestones_url":"https://api.github.com/repos/GloverDonovan/html/milestones{/number}","notifications_url":"https://api.github.com/repos/GloverDonovan/html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GloverDonovan/html/labels{/name}","releases_url":"https://api.github.com/repos/GloverDonovan/html/releases{/id}","deployments_url":"https://api.github.com/repos/GloverDonovan/html/deployments","created_at":"2018-02-06T01:53:32Z","updated_at":"2018-02-06T01:53:34Z","pushed_at":"2018-03-03T04:11:57Z","git_url":"git://github.com/GloverDonovan/html.git","ssh_url":"git@github.com:GloverDonovan/html.git","clone_url":"https://github.com/GloverDonovan/html.git","svn_url":"https://github.com/GloverDonovan/html","homepage":"https://html.spec.whatwg.org/multipage/","size":184241,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"whatwg:master","ref":"master","sha":"16de123059bd4b3660677fb4fdc03e2053815482","user":{"login":"whatwg","id":2226336,"avatar_url":"https://avatars1.githubusercontent.com/u/2226336?v=4","gravatar_id":"","url":"https://api.github.com/users/whatwg","html_url":"https://github.com/whatwg","followers_url":"https://api.github.com/users/whatwg/followers","following_url":"https://api.github.com/users/whatwg/following{/other_user}","gists_url":"https://api.github.com/users/whatwg/gists{/gist_id}","starred_url":"https://api.github.com/users/whatwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatwg/subscriptions","organizations_url":"https://api.github.com/users/whatwg/orgs","repos_url":"https://api.github.com/users/whatwg/repos","events_url":"https://api.github.com/users/whatwg/events{/privacy}","received_events_url":"https://api.github.com/users/whatwg/received_events","type":"Organization","site_admin":false},"repo":{"id":11969507,"name":"html","full_name":"whatwg/html","owner":{"login":"whatwg","id":2226336,"avatar_url":"https://avatars1.githubusercontent.com/u/2226336?v=4","gravatar_id":"","url":"https://api.github.com/users/whatwg","html_url":"https://github.com/whatwg","followers_url":"https://api.github.com/users/whatwg/followers","following_url":"https://api.github.com/users/whatwg/following{/other_user}","gists_url":"https://api.github.com/users/whatwg/gists{/gist_id}","starred_url":"https://api.github.com/users/whatwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatwg/subscriptions","organizations_url":"https://api.github.com/users/whatwg/orgs","repos_url":"https://api.github.com/users/whatwg/repos","events_url":"https://api.github.com/users/whatwg/events{/privacy}","received_events_url":"https://api.github.com/users/whatwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/whatwg/html","description":"HTML Standard","fork":false,"url":"https://api.github.com/repos/whatwg/html","forks_url":"https://api.github.com/repos/whatwg/html/forks","keys_url":"https://api.github.com/repos/whatwg/html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whatwg/html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whatwg/html/teams","hooks_url":"https://api.github.com/repos/whatwg/html/hooks","issue_events_url":"https://api.github.com/repos/whatwg/html/issues/events{/number}","events_url":"https://api.github.com/repos/whatwg/html/events","assignees_url":"https://api.github.com/repos/whatwg/html/assignees{/user}","branches_url":"https://api.github.com/repos/whatwg/html/branches{/branch}","tags_url":"https://api.github.com/repos/whatwg/html/tags","blobs_url":"https://api.github.com/repos/whatwg/html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whatwg/html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whatwg/html/git/refs{/sha}","trees_url":"https://api.github.com/repos/whatwg/html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whatwg/html/statuses/{sha}","languages_url":"https://api.github.com/repos/whatwg/html/languages","stargazers_url":"https://api.github.com/repos/whatwg/html/stargazers","contributors_url":"https://api.github.com/repos/whatwg/html/contributors","subscribers_url":"https://api.github.com/repos/whatwg/html/subscribers","subscription_url":"https://api.github.com/repos/whatwg/html/subscription","commits_url":"https://api.github.com/repos/whatwg/html/commits{/sha}","git_commits_url":"https://api.github.com/repos/whatwg/html/git/commits{/sha}","comments_url":"https://api.github.com/repos/whatwg/html/comments{/number}","issue_comment_url":"https://api.github.com/repos/whatwg/html/issues/comments{/number}","contents_url":"https://api.github.com/repos/whatwg/html/contents/{+path}","compare_url":"https://api.github.com/repos/whatwg/html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whatwg/html/merges","archive_url":"https://api.github.com/repos/whatwg/html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whatwg/html/downloads","issues_url":"https://api.github.com/repos/whatwg/html/issues{/number}","pulls_url":"https://api.github.com/repos/whatwg/html/pulls{/number}","milestones_url":"https://api.github.com/repos/whatwg/html/milestones{/number}","notifications_url":"https://api.github.com/repos/whatwg/html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whatwg/html/labels{/name}","releases_url":"https://api.github.com/repos/whatwg/html/releases{/id}","deployments_url":"https://api.github.com/repos/whatwg/html/deployments","created_at":"2013-08-08T06:26:07Z","updated_at":"2018-03-04T09:20:35Z","pushed_at":"2018-03-04T13:41:18Z","git_url":"git://github.com/whatwg/html.git","ssh_url":"git@github.com:whatwg/html.git","clone_url":"https://github.com/whatwg/html.git","svn_url":"https://github.com/whatwg/html","homepage":"https://html.spec.whatwg.org/multipage/","size":184146,"stargazers_count":1712,"watchers_count":1712,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":601,"mirror_url":null,"archived":false,"open_issues_count":780,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0"},"forks":601,"open_issues":780,"watchers":1712,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/whatwg/html/pulls/3484"},"html":{"href":"https://github.com/whatwg/html/pull/3484"},"issue":{"href":"https://api.github.com/repos/whatwg/html/issues/3484"},"comments":{"href":"https://api.github.com/repos/whatwg/html/issues/3484/comments"},"review_comments":{"href":"https://api.github.com/repos/whatwg/html/pulls/3484/comments"},"review_comment":{"href":"https://api.github.com/repos/whatwg/html/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/whatwg/html/pulls/3484/commits"},"statuses":{"href":"https://api.github.com/repos/whatwg/html/statuses/af879b718caba2f91aed0479ddf5a54c8459be11"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"GloverDonovan"}}