{"action":"created","comment":{"url":"https://api.github.com/repos/http4s/http4s/pulls/comments/212807069","pull_request_review_id":147489897,"id":212807069,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjgwNzA2OQ==","diff_hunk":"@@ -118,13 +106,11 @@ class AsyncHttp4sServlet[F[_]](\n object AsyncHttp4sServlet {\n   def apply[F[_]: ConcurrentEffect](\n       service: HttpRoutes[F],\n-      asyncTimeout: Duration = Duration.Inf,\n-      executionContext: ExecutionContext = ExecutionContext.global): AsyncHttp4sServlet[F] =\n+      asyncTimeout: Duration = Duration.Inf): AsyncHttp4sServlet[F] =\n     new AsyncHttp4sServlet[F](\n       service,\n       asyncTimeout,\n-      executionContext,\n-      BlockingServletIo[F](DefaultChunkSize),\n+      NonBlockingServletIo[F](DefaultChunkSize),","path":"servlet/src/main/scala/org/http4s/servlet/AsyncHttp4sServlet.scala","position":102,"original_position":102,"commit_id":"2363801569c4cbdd5c113256f3e6f51fc809dcf7","original_commit_id":"2363801569c4cbdd5c113256f3e6f51fc809dcf7","user":{"login":"rossabaker","id":142698,"node_id":"MDQ6VXNlcjE0MjY5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/142698?v=4","gravatar_id":"","url":"https://api.github.com/users/rossabaker","html_url":"https://github.com/rossabaker","followers_url":"https://api.github.com/users/rossabaker/followers","following_url":"https://api.github.com/users/rossabaker/following{/other_user}","gists_url":"https://api.github.com/users/rossabaker/gists{/gist_id}","starred_url":"https://api.github.com/users/rossabaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rossabaker/subscriptions","organizations_url":"https://api.github.com/users/rossabaker/orgs","repos_url":"https://api.github.com/users/rossabaker/repos","events_url":"https://api.github.com/users/rossabaker/events{/privacy}","received_events_url":"https://api.github.com/users/rossabaker/received_events","type":"User","site_admin":false},"body":"This is going to hurt benchmarks, but help in scalability.  We might gain a fair bit of it back losing that other shift.  And it's still pluggable.","created_at":"2018-08-25T19:39:23Z","updated_at":"2018-08-25T19:39:40Z","html_url":"https://github.com/http4s/http4s/pull/1993#discussion_r212807069","pull_request_url":"https://api.github.com/repos/http4s/http4s/pulls/1993","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/http4s/http4s/pulls/comments/212807069"},"html":{"href":"https://github.com/http4s/http4s/pull/1993#discussion_r212807069"},"pull_request":{"href":"https://api.github.com/repos/http4s/http4s/pulls/1993"}}},"pull_request":{"url":"https://api.github.com/repos/http4s/http4s/pulls/1993","id":208158374,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MTU4Mzc0","html_url":"https://github.com/http4s/http4s/pull/1993","diff_url":"https://github.com/http4s/http4s/pull/1993.diff","patch_url":"https://github.com/http4s/http4s/pull/1993.patch","issue_url":"https://api.github.com/repos/http4s/http4s/issues/1993","number":1993,"state":"open","locked":false,"title":"WIP: Upgrade to fs2-1.0.0-M3","user":{"login":"rossabaker","id":142698,"node_id":"MDQ6VXNlcjE0MjY5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/142698?v=4","gravatar_id":"","url":"https://api.github.com/users/rossabaker","html_url":"https://github.com/rossabaker","followers_url":"https://api.github.com/users/rossabaker/followers","following_url":"https://api.github.com/users/rossabaker/following{/other_user}","gists_url":"https://api.github.com/users/rossabaker/gists{/gist_id}","starred_url":"https://api.github.com/users/rossabaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rossabaker/subscriptions","organizations_url":"https://api.github.com/users/rossabaker/orgs","repos_url":"https://api.github.com/users/rossabaker/repos","events_url":"https://api.github.com/users/rossabaker/events{/privacy}","received_events_url":"https://api.github.com/users/rossabaker/received_events","type":"User","site_admin":false},"body":"See #1990.","created_at":"2018-08-14T03:17:49Z","updated_at":"2018-08-25T19:39:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2c0217acd137b2f3f6a50256eda742615271d79","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/http4s/http4s/milestones/21","html_url":"https://github.com/http4s/http4s/milestone/21","labels_url":"https://api.github.com/repos/http4s/http4s/milestones/21/labels","id":3562874,"node_id":"MDk6TWlsZXN0b25lMzU2Mjg3NA==","number":21,"title":"0.19.0-M2","description":null,"creator":{"login":"rossabaker","id":142698,"node_id":"MDQ6VXNlcjE0MjY5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/142698?v=4","gravatar_id":"","url":"https://api.github.com/users/rossabaker","html_url":"https://github.com/rossabaker","followers_url":"https://api.github.com/users/rossabaker/followers","following_url":"https://api.github.com/users/rossabaker/following{/other_user}","gists_url":"https://api.github.com/users/rossabaker/gists{/gist_id}","starred_url":"https://api.github.com/users/rossabaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rossabaker/subscriptions","organizations_url":"https://api.github.com/users/rossabaker/orgs","repos_url":"https://api.github.com/users/rossabaker/repos","events_url":"https://api.github.com/users/rossabaker/events{/privacy}","received_events_url":"https://api.github.com/users/rossabaker/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":4,"state":"open","created_at":"2018-08-12T01:30:22Z","updated_at":"2018-08-19T03:57:23Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/http4s/http4s/pulls/1993/commits","review_comments_url":"https://api.github.com/repos/http4s/http4s/pulls/1993/comments","review_comment_url":"https://api.github.com/repos/http4s/http4s/pulls/comments{/number}","comments_url":"https://api.github.com/repos/http4s/http4s/issues/1993/comments","statuses_url":"https://api.github.com/repos/http4s/http4s/statuses/2363801569c4cbdd5c113256f3e6f51fc809dcf7","head":{"label":"rossabaker:1.0.0-M4","ref":"1.0.0-M4","sha":"2363801569c4cbdd5c113256f3e6f51fc809dcf7","user":{"login":"rossabaker","id":142698,"node_id":"MDQ6VXNlcjE0MjY5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/142698?v=4","gravatar_id":"","url":"https://api.github.com/users/rossabaker","html_url":"https://github.com/rossabaker","followers_url":"https://api.github.com/users/rossabaker/followers","following_url":"https://api.github.com/users/rossabaker/following{/other_user}","gists_url":"https://api.github.com/users/rossabaker/gists{/gist_id}","starred_url":"https://api.github.com/users/rossabaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rossabaker/subscriptions","organizations_url":"https://api.github.com/users/rossabaker/orgs","repos_url":"https://api.github.com/users/rossabaker/repos","events_url":"https://api.github.com/users/rossabaker/events{/privacy}","received_events_url":"https://api.github.com/users/rossabaker/received_events","type":"User","site_admin":false},"repo":{"id":22358419,"node_id":"MDEwOlJlcG9zaXRvcnkyMjM1ODQxOQ==","name":"http4s","full_name":"rossabaker/http4s","owner":{"login":"rossabaker","id":142698,"node_id":"MDQ6VXNlcjE0MjY5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/142698?v=4","gravatar_id":"","url":"https://api.github.com/users/rossabaker","html_url":"https://github.com/rossabaker","followers_url":"https://api.github.com/users/rossabaker/followers","following_url":"https://api.github.com/users/rossabaker/following{/other_user}","gists_url":"https://api.github.com/users/rossabaker/gists{/gist_id}","starred_url":"https://api.github.com/users/rossabaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rossabaker/subscriptions","organizations_url":"https://api.github.com/users/rossabaker/orgs","repos_url":"https://api.github.com/users/rossabaker/repos","events_url":"https://api.github.com/users/rossabaker/events{/privacy}","received_events_url":"https://api.github.com/users/rossabaker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rossabaker/http4s","description":"A minimal, idiomatic Scala interface for HTTP services.","fork":true,"url":"https://api.github.com/repos/rossabaker/http4s","forks_url":"https://api.github.com/repos/rossabaker/http4s/forks","keys_url":"https://api.github.com/repos/rossabaker/http4s/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rossabaker/http4s/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rossabaker/http4s/teams","hooks_url":"https://api.github.com/repos/rossabaker/http4s/hooks","issue_events_url":"https://api.github.com/repos/rossabaker/http4s/issues/events{/number}","events_url":"https://api.github.com/repos/rossabaker/http4s/events","assignees_url":"https://api.github.com/repos/rossabaker/http4s/assignees{/user}","branches_url":"https://api.github.com/repos/rossabaker/http4s/branches{/branch}","tags_url":"https://api.github.com/repos/rossabaker/http4s/tags","blobs_url":"https://api.github.com/repos/rossabaker/http4s/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rossabaker/http4s/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rossabaker/http4s/git/refs{/sha}","trees_url":"https://api.github.com/repos/rossabaker/http4s/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rossabaker/http4s/statuses/{sha}","languages_url":"https://api.github.com/repos/rossabaker/http4s/languages","stargazers_url":"https://api.github.com/repos/rossabaker/http4s/stargazers","contributors_url":"https://api.github.com/repos/rossabaker/http4s/contributors","subscribers_url":"https://api.github.com/repos/rossabaker/http4s/subscribers","subscription_url":"https://api.github.com/repos/rossabaker/http4s/subscription","commits_url":"https://api.github.com/repos/rossabaker/http4s/commits{/sha}","git_commits_url":"https://api.github.com/repos/rossabaker/http4s/git/commits{/sha}","comments_url":"https://api.github.com/repos/rossabaker/http4s/comments{/number}","issue_comment_url":"https://api.github.com/repos/rossabaker/http4s/issues/comments{/number}","contents_url":"https://api.github.com/repos/rossabaker/http4s/contents/{+path}","compare_url":"https://api.github.com/repos/rossabaker/http4s/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rossabaker/http4s/merges","archive_url":"https://api.github.com/repos/rossabaker/http4s/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rossabaker/http4s/downloads","issues_url":"https://api.github.com/repos/rossabaker/http4s/issues{/number}","pulls_url":"https://api.github.com/repos/rossabaker/http4s/pulls{/number}","milestones_url":"https://api.github.com/repos/rossabaker/http4s/milestones{/number}","notifications_url":"https://api.github.com/repos/rossabaker/http4s/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rossabaker/http4s/labels{/name}","releases_url":"https://api.github.com/repos/rossabaker/http4s/releases{/id}","deployments_url":"https://api.github.com/repos/rossabaker/http4s/deployments","created_at":"2014-07-28T21:23:26Z","updated_at":"2018-05-10T12:46:35Z","pushed_at":"2018-08-25T19:33:01Z","git_url":"git://github.com/rossabaker/http4s.git","ssh_url":"git@github.com:rossabaker/http4s.git","clone_url":"https://github.com/rossabaker/http4s.git","svn_url":"https://github.com/rossabaker/http4s","homepage":"http://http4s.org/","size":16717,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"http4s:master","ref":"master","sha":"867cb8c36b31f129cf9cf4093b3af69603d97eeb","user":{"login":"http4s","id":1527492,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1Mjc0OTI=","avatar_url":"https://avatars3.githubusercontent.com/u/1527492?v=4","gravatar_id":"","url":"https://api.github.com/users/http4s","html_url":"https://github.com/http4s","followers_url":"https://api.github.com/users/http4s/followers","following_url":"https://api.github.com/users/http4s/following{/other_user}","gists_url":"https://api.github.com/users/http4s/gists{/gist_id}","starred_url":"https://api.github.com/users/http4s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/http4s/subscriptions","organizations_url":"https://api.github.com/users/http4s/orgs","repos_url":"https://api.github.com/users/http4s/repos","events_url":"https://api.github.com/users/http4s/events{/privacy}","received_events_url":"https://api.github.com/users/http4s/received_events","type":"Organization","site_admin":false},"repo":{"id":3692188,"node_id":"MDEwOlJlcG9zaXRvcnkzNjkyMTg4","name":"http4s","full_name":"http4s/http4s","owner":{"login":"http4s","id":1527492,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1Mjc0OTI=","avatar_url":"https://avatars3.githubusercontent.com/u/1527492?v=4","gravatar_id":"","url":"https://api.github.com/users/http4s","html_url":"https://github.com/http4s","followers_url":"https://api.github.com/users/http4s/followers","following_url":"https://api.github.com/users/http4s/following{/other_user}","gists_url":"https://api.github.com/users/http4s/gists{/gist_id}","starred_url":"https://api.github.com/users/http4s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/http4s/subscriptions","organizations_url":"https://api.github.com/users/http4s/orgs","repos_url":"https://api.github.com/users/http4s/repos","events_url":"https://api.github.com/users/http4s/events{/privacy}","received_events_url":"https://api.github.com/users/http4s/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/http4s/http4s","description":"A minimal, idiomatic Scala interface for HTTP","fork":false,"url":"https://api.github.com/repos/http4s/http4s","forks_url":"https://api.github.com/repos/http4s/http4s/forks","keys_url":"https://api.github.com/repos/http4s/http4s/keys{/key_id}","collaborators_url":"https://api.github.com/repos/http4s/http4s/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/http4s/http4s/teams","hooks_url":"https://api.github.com/repos/http4s/http4s/hooks","issue_events_url":"https://api.github.com/repos/http4s/http4s/issues/events{/number}","events_url":"https://api.github.com/repos/http4s/http4s/events","assignees_url":"https://api.github.com/repos/http4s/http4s/assignees{/user}","branches_url":"https://api.github.com/repos/http4s/http4s/branches{/branch}","tags_url":"https://api.github.com/repos/http4s/http4s/tags","blobs_url":"https://api.github.com/repos/http4s/http4s/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/http4s/http4s/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/http4s/http4s/git/refs{/sha}","trees_url":"https://api.github.com/repos/http4s/http4s/git/trees{/sha}","statuses_url":"https://api.github.com/repos/http4s/http4s/statuses/{sha}","languages_url":"https://api.github.com/repos/http4s/http4s/languages","stargazers_url":"https://api.github.com/repos/http4s/http4s/stargazers","contributors_url":"https://api.github.com/repos/http4s/http4s/contributors","subscribers_url":"https://api.github.com/repos/http4s/http4s/subscribers","subscription_url":"https://api.github.com/repos/http4s/http4s/subscription","commits_url":"https://api.github.com/repos/http4s/http4s/commits{/sha}","git_commits_url":"https://api.github.com/repos/http4s/http4s/git/commits{/sha}","comments_url":"https://api.github.com/repos/http4s/http4s/comments{/number}","issue_comment_url":"https://api.github.com/repos/http4s/http4s/issues/comments{/number}","contents_url":"https://api.github.com/repos/http4s/http4s/contents/{+path}","compare_url":"https://api.github.com/repos/http4s/http4s/compare/{base}...{head}","merges_url":"https://api.github.com/repos/http4s/http4s/merges","archive_url":"https://api.github.com/repos/http4s/http4s/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/http4s/http4s/downloads","issues_url":"https://api.github.com/repos/http4s/http4s/issues{/number}","pulls_url":"https://api.github.com/repos/http4s/http4s/pulls{/number}","milestones_url":"https://api.github.com/repos/http4s/http4s/milestones{/number}","notifications_url":"https://api.github.com/repos/http4s/http4s/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/http4s/http4s/labels{/name}","releases_url":"https://api.github.com/repos/http4s/http4s/releases{/id}","deployments_url":"https://api.github.com/repos/http4s/http4s/deployments","created_at":"2012-03-12T04:41:20Z","updated_at":"2018-08-25T10:15:50Z","pushed_at":"2018-08-25T19:33:03Z","git_url":"git://github.com/http4s/http4s.git","ssh_url":"git@github.com:http4s/http4s.git","clone_url":"https://github.com/http4s/http4s.git","svn_url":"https://github.com/http4s/http4s","homepage":"https://http4s.org/","size":130785,"stargazers_count":1165,"watchers_count":1165,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":328,"mirror_url":null,"archived":false,"open_issues_count":164,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":328,"open_issues":164,"watchers":1165,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/http4s/http4s/pulls/1993"},"html":{"href":"https://github.com/http4s/http4s/pull/1993"},"issue":{"href":"https://api.github.com/repos/http4s/http4s/issues/1993"},"comments":{"href":"https://api.github.com/repos/http4s/http4s/issues/1993/comments"},"review_comments":{"href":"https://api.github.com/repos/http4s/http4s/pulls/1993/comments"},"review_comment":{"href":"https://api.github.com/repos/http4s/http4s/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/http4s/http4s/pulls/1993/commits"},"statuses":{"href":"https://api.github.com/repos/http4s/http4s/statuses/2363801569c4cbdd5c113256f3e6f51fc809dcf7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rossabaker"}}