{"action":"created","comment":{"url":"https://api.github.com/repos/artsy/force/pulls/comments/198296574","pull_request_review_id":132203706,"id":198296574,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODI5NjU3NA==","diff_hunk":"@@ -19,28 +19,37 @@ describe('ModalContainer', () => {\n     sd.CSRF_TOKEN = 'sample-token'\n   })\n \n-  it('Mediator can open a login modal', () => {\n+  it('Mediator can open a login modal', done => {\n     const component = mount(<ModalContainer />)\n     mediator.trigger('open:auth', { mode: 'login' })\n-    const form = component.find(ModalManager).instance().state\n \n-    expect(form.currentType).toBe('login')\n+    setTimeout(() => {\n+      const form = component.find(ModalManager).instance().state\n+      expect(form.currentType).toBe('login')\n+      done()\n+    }, 800)\n   })\n \n-  it('Mediator can open a signup modal', () => {\n+  it('Mediator can open a signup modal', done => {\n     const component = mount(<ModalContainer />)\n     mediator.trigger('open:auth', { mode: 'register' })\n-    const form = component.find(ModalManager).instance().state\n \n-    expect(form.currentType).toBe('signup')\n+    setTimeout(() => {\n+      const form = component.find(ModalManager).instance().state\n+      expect(form.currentType).toBe('signup')\n+      done()\n+    }, 800)\n   })\n \n-  it('Mediator can open a reset_password modal', () => {\n+  it('Mediator can open a reset_password modal', done => {\n     const component = mount(<ModalContainer />)\n     mediator.trigger('open:auth', { mode: 'reset_password' })\n-    const form = component.find(ModalManager).instance().state\n \n-    expect(form.currentType).toBe('reset_password')\n+    setTimeout(() => {\n+      const form = component.find(ModalManager).instance().state\n+      expect(form.currentType).toBe('reset_password')\n+      done()\n+    }, 800)","path":"src/desktop/apps/auth2/components/__tests__/ModalContainer.jest.js","position":43,"original_position":43,"commit_id":"6cd19bd45b031ddfc55e733be1d5f80d670772d9","original_commit_id":"6cd19bd45b031ddfc55e733be1d5f80d670772d9","user":{"login":"l2succes","id":296775,"node_id":"MDQ6VXNlcjI5Njc3NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/296775?v=4","gravatar_id":"","url":"https://api.github.com/users/l2succes","html_url":"https://github.com/l2succes","followers_url":"https://api.github.com/users/l2succes/followers","following_url":"https://api.github.com/users/l2succes/following{/other_user}","gists_url":"https://api.github.com/users/l2succes/gists{/gist_id}","starred_url":"https://api.github.com/users/l2succes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l2succes/subscriptions","organizations_url":"https://api.github.com/users/l2succes/orgs","repos_url":"https://api.github.com/users/l2succes/repos","events_url":"https://api.github.com/users/l2succes/events{/privacy}","received_events_url":"https://api.github.com/users/l2succes/received_events","type":"User","site_admin":false},"body":"sure, ok i'll do that instead","created_at":"2018-06-26T21:02:21Z","updated_at":"2018-06-26T21:02:21Z","html_url":"https://github.com/artsy/force/pull/2659#discussion_r198296574","pull_request_url":"https://api.github.com/repos/artsy/force/pulls/2659","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/artsy/force/pulls/comments/198296574"},"html":{"href":"https://github.com/artsy/force/pull/2659#discussion_r198296574"},"pull_request":{"href":"https://api.github.com/repos/artsy/force/pulls/2659"}},"in_reply_to_id":198295554},"pull_request":{"url":"https://api.github.com/repos/artsy/force/pulls/2659","id":197534704,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NTM0NzA0","html_url":"https://github.com/artsy/force/pull/2659","diff_url":"https://github.com/artsy/force/pull/2659.diff","patch_url":"https://github.com/artsy/force/pull/2659.patch","issue_url":"https://api.github.com/repos/artsy/force/issues/2659","number":2659,"state":"open","locked":false,"title":"@kanaabe => Fb & Twitter fix ","user":{"login":"l2succes","id":296775,"node_id":"MDQ6VXNlcjI5Njc3NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/296775?v=4","gravatar_id":"","url":"https://api.github.com/users/l2succes","html_url":"https://github.com/l2succes","followers_url":"https://api.github.com/users/l2succes/followers","following_url":"https://api.github.com/users/l2succes/following{/other_user}","gists_url":"https://api.github.com/users/l2succes/gists{/gist_id}","starred_url":"https://api.github.com/users/l2succes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l2succes/subscriptions","organizations_url":"https://api.github.com/users/l2succes/orgs","repos_url":"https://api.github.com/users/l2succes/repos","events_url":"https://api.github.com/users/l2succes/events{/privacy}","received_events_url":"https://api.github.com/users/l2succes/received_events","type":"User","site_admin":false},"body":"UI\r\n\r\nTerms of use \"of\" should not be capitalized (luc)\r\nChange blur to 50px w/ no background color (luc)\r\n\r\nFunctionality\r\n\r\nServer errors should clear after retrying (luc)\r\nEnable submit button on forms always, and show errors if they try to submit (luc)\r\n/log_in and /sign_up are flashing the modal once and going away instead of sticking (luc)","created_at":"2018-06-26T20:01:15Z","updated_at":"2018-06-26T21:02:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"210608a6701a684905e5bb331d8a805f2adea877","assignee":{"login":"kanaabe","id":2236794,"node_id":"MDQ6VXNlcjIyMzY3OTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2236794?v=4","gravatar_id":"","url":"https://api.github.com/users/kanaabe","html_url":"https://github.com/kanaabe","followers_url":"https://api.github.com/users/kanaabe/followers","following_url":"https://api.github.com/users/kanaabe/following{/other_user}","gists_url":"https://api.github.com/users/kanaabe/gists{/gist_id}","starred_url":"https://api.github.com/users/kanaabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanaabe/subscriptions","organizations_url":"https://api.github.com/users/kanaabe/orgs","repos_url":"https://api.github.com/users/kanaabe/repos","events_url":"https://api.github.com/users/kanaabe/events{/privacy}","received_events_url":"https://api.github.com/users/kanaabe/received_events","type":"User","site_admin":false},"assignees":[{"login":"kanaabe","id":2236794,"node_id":"MDQ6VXNlcjIyMzY3OTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2236794?v=4","gravatar_id":"","url":"https://api.github.com/users/kanaabe","html_url":"https://github.com/kanaabe","followers_url":"https://api.github.com/users/kanaabe/followers","following_url":"https://api.github.com/users/kanaabe/following{/other_user}","gists_url":"https://api.github.com/users/kanaabe/gists{/gist_id}","starred_url":"https://api.github.com/users/kanaabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanaabe/subscriptions","organizations_url":"https://api.github.com/users/kanaabe/orgs","repos_url":"https://api.github.com/users/kanaabe/repos","events_url":"https://api.github.com/users/kanaabe/events{/privacy}","received_events_url":"https://api.github.com/users/kanaabe/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/artsy/force/pulls/2659/commits","review_comments_url":"https://api.github.com/repos/artsy/force/pulls/2659/comments","review_comment_url":"https://api.github.com/repos/artsy/force/pulls/comments{/number}","comments_url":"https://api.github.com/repos/artsy/force/issues/2659/comments","statuses_url":"https://api.github.com/repos/artsy/force/statuses/6cd19bd45b031ddfc55e733be1d5f80d670772d9","head":{"label":"l2succes:auth-system","ref":"auth-system","sha":"6cd19bd45b031ddfc55e733be1d5f80d670772d9","user":{"login":"l2succes","id":296775,"node_id":"MDQ6VXNlcjI5Njc3NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/296775?v=4","gravatar_id":"","url":"https://api.github.com/users/l2succes","html_url":"https://github.com/l2succes","followers_url":"https://api.github.com/users/l2succes/followers","following_url":"https://api.github.com/users/l2succes/following{/other_user}","gists_url":"https://api.github.com/users/l2succes/gists{/gist_id}","starred_url":"https://api.github.com/users/l2succes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l2succes/subscriptions","organizations_url":"https://api.github.com/users/l2succes/orgs","repos_url":"https://api.github.com/users/l2succes/repos","events_url":"https://api.github.com/users/l2succes/events{/privacy}","received_events_url":"https://api.github.com/users/l2succes/received_events","type":"User","site_admin":false},"repo":{"id":76884803,"node_id":"MDEwOlJlcG9zaXRvcnk3Njg4NDgwMw==","name":"force","full_name":"l2succes/force","owner":{"login":"l2succes","id":296775,"node_id":"MDQ6VXNlcjI5Njc3NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/296775?v=4","gravatar_id":"","url":"https://api.github.com/users/l2succes","html_url":"https://github.com/l2succes","followers_url":"https://api.github.com/users/l2succes/followers","following_url":"https://api.github.com/users/l2succes/following{/other_user}","gists_url":"https://api.github.com/users/l2succes/gists{/gist_id}","starred_url":"https://api.github.com/users/l2succes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l2succes/subscriptions","organizations_url":"https://api.github.com/users/l2succes/orgs","repos_url":"https://api.github.com/users/l2succes/repos","events_url":"https://api.github.com/users/l2succes/events{/privacy}","received_events_url":"https://api.github.com/users/l2succes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/l2succes/force","description":"The Artsy.net website:","fork":true,"url":"https://api.github.com/repos/l2succes/force","forks_url":"https://api.github.com/repos/l2succes/force/forks","keys_url":"https://api.github.com/repos/l2succes/force/keys{/key_id}","collaborators_url":"https://api.github.com/repos/l2succes/force/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/l2succes/force/teams","hooks_url":"https://api.github.com/repos/l2succes/force/hooks","issue_events_url":"https://api.github.com/repos/l2succes/force/issues/events{/number}","events_url":"https://api.github.com/repos/l2succes/force/events","assignees_url":"https://api.github.com/repos/l2succes/force/assignees{/user}","branches_url":"https://api.github.com/repos/l2succes/force/branches{/branch}","tags_url":"https://api.github.com/repos/l2succes/force/tags","blobs_url":"https://api.github.com/repos/l2succes/force/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/l2succes/force/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/l2succes/force/git/refs{/sha}","trees_url":"https://api.github.com/repos/l2succes/force/git/trees{/sha}","statuses_url":"https://api.github.com/repos/l2succes/force/statuses/{sha}","languages_url":"https://api.github.com/repos/l2succes/force/languages","stargazers_url":"https://api.github.com/repos/l2succes/force/stargazers","contributors_url":"https://api.github.com/repos/l2succes/force/contributors","subscribers_url":"https://api.github.com/repos/l2succes/force/subscribers","subscription_url":"https://api.github.com/repos/l2succes/force/subscription","commits_url":"https://api.github.com/repos/l2succes/force/commits{/sha}","git_commits_url":"https://api.github.com/repos/l2succes/force/git/commits{/sha}","comments_url":"https://api.github.com/repos/l2succes/force/comments{/number}","issue_comment_url":"https://api.github.com/repos/l2succes/force/issues/comments{/number}","contents_url":"https://api.github.com/repos/l2succes/force/contents/{+path}","compare_url":"https://api.github.com/repos/l2succes/force/compare/{base}...{head}","merges_url":"https://api.github.com/repos/l2succes/force/merges","archive_url":"https://api.github.com/repos/l2succes/force/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/l2succes/force/downloads","issues_url":"https://api.github.com/repos/l2succes/force/issues{/number}","pulls_url":"https://api.github.com/repos/l2succes/force/pulls{/number}","milestones_url":"https://api.github.com/repos/l2succes/force/milestones{/number}","notifications_url":"https://api.github.com/repos/l2succes/force/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/l2succes/force/labels{/name}","releases_url":"https://api.github.com/repos/l2succes/force/releases{/id}","deployments_url":"https://api.github.com/repos/l2succes/force/deployments","created_at":"2016-12-19T17:59:59Z","updated_at":"2016-12-19T18:00:05Z","pushed_at":"2018-06-26T20:33:41Z","git_url":"git://github.com/l2succes/force.git","ssh_url":"git@github.com:l2succes/force.git","clone_url":"https://github.com/l2succes/force.git","svn_url":"https://github.com/l2succes/force","homepage":"https://www.artsy.net","size":129460,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"artsy:master","ref":"master","sha":"0caadb4caff0453664d36ec4d6382ae2bd8dbd7c","user":{"login":"artsy","id":546231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NjIzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":22887404,"node_id":"MDEwOlJlcG9zaXRvcnkyMjg4NzQwNA==","name":"force","full_name":"artsy/force","owner":{"login":"artsy","id":546231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NjIzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/force","description":"The Artsy.net website:","fork":false,"url":"https://api.github.com/repos/artsy/force","forks_url":"https://api.github.com/repos/artsy/force/forks","keys_url":"https://api.github.com/repos/artsy/force/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/force/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/force/teams","hooks_url":"https://api.github.com/repos/artsy/force/hooks","issue_events_url":"https://api.github.com/repos/artsy/force/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/force/events","assignees_url":"https://api.github.com/repos/artsy/force/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/force/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/force/tags","blobs_url":"https://api.github.com/repos/artsy/force/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/force/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/force/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/force/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/force/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/force/languages","stargazers_url":"https://api.github.com/repos/artsy/force/stargazers","contributors_url":"https://api.github.com/repos/artsy/force/contributors","subscribers_url":"https://api.github.com/repos/artsy/force/subscribers","subscription_url":"https://api.github.com/repos/artsy/force/subscription","commits_url":"https://api.github.com/repos/artsy/force/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/force/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/force/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/force/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/force/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/force/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/force/merges","archive_url":"https://api.github.com/repos/artsy/force/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/force/downloads","issues_url":"https://api.github.com/repos/artsy/force/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/force/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/force/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/force/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/force/labels{/name}","releases_url":"https://api.github.com/repos/artsy/force/releases{/id}","deployments_url":"https://api.github.com/repos/artsy/force/deployments","created_at":"2014-08-12T18:14:34Z","updated_at":"2018-06-26T19:40:22Z","pushed_at":"2018-06-26T20:33:43Z","git_url":"git://github.com/artsy/force.git","ssh_url":"git@github.com:artsy/force.git","clone_url":"https://github.com/artsy/force.git","svn_url":"https://github.com/artsy/force","homepage":"https://www.artsy.net","size":129429,"stargazers_count":233,"watchers_count":233,"language":"CoffeeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":82,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":82,"open_issues":49,"watchers":233,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/artsy/force/pulls/2659"},"html":{"href":"https://github.com/artsy/force/pull/2659"},"issue":{"href":"https://api.github.com/repos/artsy/force/issues/2659"},"comments":{"href":"https://api.github.com/repos/artsy/force/issues/2659/comments"},"review_comments":{"href":"https://api.github.com/repos/artsy/force/pulls/2659/comments"},"review_comment":{"href":"https://api.github.com/repos/artsy/force/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/artsy/force/pulls/2659/commits"},"statuses":{"href":"https://api.github.com/repos/artsy/force/statuses/6cd19bd45b031ddfc55e733be1d5f80d670772d9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"l2succes"}}