{"action":"created","comment":{"url":"https://api.github.com/repos/mysteriumnetwork/node/pulls/comments/233917850","pull_request_review_id":175443186,"id":233917850,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzkxNzg1MA==","diff_hunk":"@@ -30,46 +32,81 @@ import (\n const logPrefix = \"[service-noop] \"\n \n // NewManager creates new instance of Noop service\n-func NewManager() *Manager {\n-\treturn &Manager{}\n+func NewManager(locationResolver location.Resolver, ipResolver ip.Resolver) *Manager {\n+\treturn &Manager{\n+\t\tlocationResolver: locationResolver,\n+\t\tipResolver:       ipResolver,\n+\t}\n }\n \n // Manager represents entrypoint for Noop service\n type Manager struct {\n-\tfakeProcess sync.WaitGroup\n+\tfakeProcess      sync.WaitGroup\n+\tlocationResolver location.Resolver\n+\tipResolver       ip.Resolver\n+\tisStarted        bool\n }\n \n // Start starts service - does not block\n func (manager *Manager) Start(providerID identity.Identity) (dto_discovery.ServiceProposal, session.ConfigProvider, error) {\n+\tsessionConfigProvider := func() (session.ServiceConfiguration, error) {\n+\t\treturn nil, nil\n+\t}\n+\n+\tif manager.isStarted {\n+\t\treturn dto_discovery.ServiceProposal{}, sessionConfigProvider, nil\n+\t}\n+\n \tmanager.fakeProcess.Add(1)","path":"services/noop/service.go","position":41,"original_position":41,"commit_id":"b0dac46035e197d1bcdca99e7d1c8ece3b941870","original_commit_id":"b0dac46035e197d1bcdca99e7d1c8ece3b941870","user":{"login":"zolia","id":13434315,"node_id":"MDQ6VXNlcjEzNDM0MzE1","avatar_url":"https://avatars3.githubusercontent.com/u/13434315?v=4","gravatar_id":"","url":"https://api.github.com/users/zolia","html_url":"https://github.com/zolia","followers_url":"https://api.github.com/users/zolia/followers","following_url":"https://api.github.com/users/zolia/following{/other_user}","gists_url":"https://api.github.com/users/zolia/gists{/gist_id}","starred_url":"https://api.github.com/users/zolia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zolia/subscriptions","organizations_url":"https://api.github.com/users/zolia/orgs","repos_url":"https://api.github.com/users/zolia/repos","events_url":"https://api.github.com/users/zolia/events{/privacy}","received_events_url":"https://api.github.com/users/zolia/received_events","type":"User","site_admin":false},"body":"We prob should not use 'fake' wording anymore here.","created_at":"2018-11-15T16:35:01Z","updated_at":"2018-11-15T16:35:02Z","html_url":"https://github.com/mysteriumnetwork/node/pull/541#discussion_r233917850","pull_request_url":"https://api.github.com/repos/mysteriumnetwork/node/pulls/541","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mysteriumnetwork/node/pulls/comments/233917850"},"html":{"href":"https://github.com/mysteriumnetwork/node/pull/541#discussion_r233917850"},"pull_request":{"href":"https://api.github.com/repos/mysteriumnetwork/node/pulls/541"}}},"pull_request":{"url":"https://api.github.com/repos/mysteriumnetwork/node/pulls/541","id":231093001,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMDkzMDAx","html_url":"https://github.com/mysteriumnetwork/node/pull/541","diff_url":"https://github.com/mysteriumnetwork/node/pull/541.diff","patch_url":"https://github.com/mysteriumnetwork/node/pull/541.patch","issue_url":"https://api.github.com/repos/mysteriumnetwork/node/issues/541","number":541,"state":"open","locked":false,"title":"Multiple services","user":{"login":"vkuznecovas","id":18392269,"node_id":"MDQ6VXNlcjE4MzkyMjY5","avatar_url":"https://avatars2.githubusercontent.com/u/18392269?v=4","gravatar_id":"","url":"https://api.github.com/users/vkuznecovas","html_url":"https://github.com/vkuznecovas","followers_url":"https://api.github.com/users/vkuznecovas/followers","following_url":"https://api.github.com/users/vkuznecovas/following{/other_user}","gists_url":"https://api.github.com/users/vkuznecovas/gists{/gist_id}","starred_url":"https://api.github.com/users/vkuznecovas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkuznecovas/subscriptions","organizations_url":"https://api.github.com/users/vkuznecovas/orgs","repos_url":"https://api.github.com/users/vkuznecovas/repos","events_url":"https://api.github.com/users/vkuznecovas/events{/privacy}","received_events_url":"https://api.github.com/users/vkuznecovas/received_events","type":"User","site_admin":false},"body":"`myst service` now runs all the supported services(openvpn, noop). Adjusted the cli accordingly, we're  now able to connect to a provider by specifying the service type as well. It's also possible to start a single service via `myst service openvpn` or `myst service noop`","created_at":"2018-11-15T07:24:06Z","updated_at":"2018-11-15T16:35:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39dd4b30c89ede0f0ed4c9d2861ca18a32e09df7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tadovas","id":1046590,"node_id":"MDQ6VXNlcjEwNDY1OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1046590?v=4","gravatar_id":"","url":"https://api.github.com/users/tadovas","html_url":"https://github.com/tadovas","followers_url":"https://api.github.com/users/tadovas/followers","following_url":"https://api.github.com/users/tadovas/following{/other_user}","gists_url":"https://api.github.com/users/tadovas/gists{/gist_id}","starred_url":"https://api.github.com/users/tadovas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tadovas/subscriptions","organizations_url":"https://api.github.com/users/tadovas/orgs","repos_url":"https://api.github.com/users/tadovas/repos","events_url":"https://api.github.com/users/tadovas/events{/privacy}","received_events_url":"https://api.github.com/users/tadovas/received_events","type":"User","site_admin":false},{"login":"soffokl","id":8612618,"node_id":"MDQ6VXNlcjg2MTI2MTg=","avatar_url":"https://avatars1.githubusercontent.com/u/8612618?v=4","gravatar_id":"","url":"https://api.github.com/users/soffokl","html_url":"https://github.com/soffokl","followers_url":"https://api.github.com/users/soffokl/followers","following_url":"https://api.github.com/users/soffokl/following{/other_user}","gists_url":"https://api.github.com/users/soffokl/gists{/gist_id}","starred_url":"https://api.github.com/users/soffokl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soffokl/subscriptions","organizations_url":"https://api.github.com/users/soffokl/orgs","repos_url":"https://api.github.com/users/soffokl/repos","events_url":"https://api.github.com/users/soffokl/events{/privacy}","received_events_url":"https://api.github.com/users/soffokl/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mysteriumnetwork/node/pulls/541/commits","review_comments_url":"https://api.github.com/repos/mysteriumnetwork/node/pulls/541/comments","review_comment_url":"https://api.github.com/repos/mysteriumnetwork/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mysteriumnetwork/node/issues/541/comments","statuses_url":"https://api.github.com/repos/mysteriumnetwork/node/statuses/b0dac46035e197d1bcdca99e7d1c8ece3b941870","head":{"label":"mysteriumnetwork:multiple-services","ref":"multiple-services","sha":"b0dac46035e197d1bcdca99e7d1c8ece3b941870","user":{"login":"mysteriumnetwork","id":23056638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDU2NjM4","avatar_url":"https://avatars3.githubusercontent.com/u/23056638?v=4","gravatar_id":"","url":"https://api.github.com/users/mysteriumnetwork","html_url":"https://github.com/mysteriumnetwork","followers_url":"https://api.github.com/users/mysteriumnetwork/followers","following_url":"https://api.github.com/users/mysteriumnetwork/following{/other_user}","gists_url":"https://api.github.com/users/mysteriumnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/mysteriumnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysteriumnetwork/subscriptions","organizations_url":"https://api.github.com/users/mysteriumnetwork/orgs","repos_url":"https://api.github.com/users/mysteriumnetwork/repos","events_url":"https://api.github.com/users/mysteriumnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/mysteriumnetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":80073079,"node_id":"MDEwOlJlcG9zaXRvcnk4MDA3MzA3OQ==","name":"node","full_name":"mysteriumnetwork/node","private":false,"owner":{"login":"mysteriumnetwork","id":23056638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDU2NjM4","avatar_url":"https://avatars3.githubusercontent.com/u/23056638?v=4","gravatar_id":"","url":"https://api.github.com/users/mysteriumnetwork","html_url":"https://github.com/mysteriumnetwork","followers_url":"https://api.github.com/users/mysteriumnetwork/followers","following_url":"https://api.github.com/users/mysteriumnetwork/following{/other_user}","gists_url":"https://api.github.com/users/mysteriumnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/mysteriumnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysteriumnetwork/subscriptions","organizations_url":"https://api.github.com/users/mysteriumnetwork/orgs","repos_url":"https://api.github.com/users/mysteriumnetwork/repos","events_url":"https://api.github.com/users/mysteriumnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/mysteriumnetwork/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mysteriumnetwork/node","description":"Mysterium Node - VPN server and client for Mysterium Network","fork":false,"url":"https://api.github.com/repos/mysteriumnetwork/node","forks_url":"https://api.github.com/repos/mysteriumnetwork/node/forks","keys_url":"https://api.github.com/repos/mysteriumnetwork/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mysteriumnetwork/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mysteriumnetwork/node/teams","hooks_url":"https://api.github.com/repos/mysteriumnetwork/node/hooks","issue_events_url":"https://api.github.com/repos/mysteriumnetwork/node/issues/events{/number}","events_url":"https://api.github.com/repos/mysteriumnetwork/node/events","assignees_url":"https://api.github.com/repos/mysteriumnetwork/node/assignees{/user}","branches_url":"https://api.github.com/repos/mysteriumnetwork/node/branches{/branch}","tags_url":"https://api.github.com/repos/mysteriumnetwork/node/tags","blobs_url":"https://api.github.com/repos/mysteriumnetwork/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mysteriumnetwork/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mysteriumnetwork/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/mysteriumnetwork/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mysteriumnetwork/node/statuses/{sha}","languages_url":"https://api.github.com/repos/mysteriumnetwork/node/languages","stargazers_url":"https://api.github.com/repos/mysteriumnetwork/node/stargazers","contributors_url":"https://api.github.com/repos/mysteriumnetwork/node/contributors","subscribers_url":"https://api.github.com/repos/mysteriumnetwork/node/subscribers","subscription_url":"https://api.github.com/repos/mysteriumnetwork/node/subscription","commits_url":"https://api.github.com/repos/mysteriumnetwork/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/mysteriumnetwork/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/mysteriumnetwork/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/mysteriumnetwork/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/mysteriumnetwork/node/contents/{+path}","compare_url":"https://api.github.com/repos/mysteriumnetwork/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mysteriumnetwork/node/merges","archive_url":"https://api.github.com/repos/mysteriumnetwork/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mysteriumnetwork/node/downloads","issues_url":"https://api.github.com/repos/mysteriumnetwork/node/issues{/number}","pulls_url":"https://api.github.com/repos/mysteriumnetwork/node/pulls{/number}","milestones_url":"https://api.github.com/repos/mysteriumnetwork/node/milestones{/number}","notifications_url":"https://api.github.com/repos/mysteriumnetwork/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mysteriumnetwork/node/labels{/name}","releases_url":"https://api.github.com/repos/mysteriumnetwork/node/releases{/id}","deployments_url":"https://api.github.com/repos/mysteriumnetwork/node/deployments","created_at":"2017-01-26T00:43:08Z","updated_at":"2018-11-15T10:54:27Z","pushed_at":"2018-11-15T12:56:35Z","git_url":"git://github.com/mysteriumnetwork/node.git","ssh_url":"git@github.com:mysteriumnetwork/node.git","clone_url":"https://github.com/mysteriumnetwork/node.git","svn_url":"https://github.com/mysteriumnetwork/node","homepage":"https://mysterium.network/","size":6738,"stargazers_count":474,"watchers_count":474,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":81,"mirror_url":null,"archived":false,"open_issues_count":81,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":81,"open_issues":81,"watchers":474,"default_branch":"master"}},"base":{"label":"mysteriumnetwork:master","ref":"master","sha":"29bf251d8785d110fab082467f4e61ab44df8e85","user":{"login":"mysteriumnetwork","id":23056638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDU2NjM4","avatar_url":"https://avatars3.githubusercontent.com/u/23056638?v=4","gravatar_id":"","url":"https://api.github.com/users/mysteriumnetwork","html_url":"https://github.com/mysteriumnetwork","followers_url":"https://api.github.com/users/mysteriumnetwork/followers","following_url":"https://api.github.com/users/mysteriumnetwork/following{/other_user}","gists_url":"https://api.github.com/users/mysteriumnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/mysteriumnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysteriumnetwork/subscriptions","organizations_url":"https://api.github.com/users/mysteriumnetwork/orgs","repos_url":"https://api.github.com/users/mysteriumnetwork/repos","events_url":"https://api.github.com/users/mysteriumnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/mysteriumnetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":80073079,"node_id":"MDEwOlJlcG9zaXRvcnk4MDA3MzA3OQ==","name":"node","full_name":"mysteriumnetwork/node","private":false,"owner":{"login":"mysteriumnetwork","id":23056638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDU2NjM4","avatar_url":"https://avatars3.githubusercontent.com/u/23056638?v=4","gravatar_id":"","url":"https://api.github.com/users/mysteriumnetwork","html_url":"https://github.com/mysteriumnetwork","followers_url":"https://api.github.com/users/mysteriumnetwork/followers","following_url":"https://api.github.com/users/mysteriumnetwork/following{/other_user}","gists_url":"https://api.github.com/users/mysteriumnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/mysteriumnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysteriumnetwork/subscriptions","organizations_url":"https://api.github.com/users/mysteriumnetwork/orgs","repos_url":"https://api.github.com/users/mysteriumnetwork/repos","events_url":"https://api.github.com/users/mysteriumnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/mysteriumnetwork/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mysteriumnetwork/node","description":"Mysterium Node - VPN server and client for Mysterium Network","fork":false,"url":"https://api.github.com/repos/mysteriumnetwork/node","forks_url":"https://api.github.com/repos/mysteriumnetwork/node/forks","keys_url":"https://api.github.com/repos/mysteriumnetwork/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mysteriumnetwork/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mysteriumnetwork/node/teams","hooks_url":"https://api.github.com/repos/mysteriumnetwork/node/hooks","issue_events_url":"https://api.github.com/repos/mysteriumnetwork/node/issues/events{/number}","events_url":"https://api.github.com/repos/mysteriumnetwork/node/events","assignees_url":"https://api.github.com/repos/mysteriumnetwork/node/assignees{/user}","branches_url":"https://api.github.com/repos/mysteriumnetwork/node/branches{/branch}","tags_url":"https://api.github.com/repos/mysteriumnetwork/node/tags","blobs_url":"https://api.github.com/repos/mysteriumnetwork/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mysteriumnetwork/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mysteriumnetwork/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/mysteriumnetwork/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mysteriumnetwork/node/statuses/{sha}","languages_url":"https://api.github.com/repos/mysteriumnetwork/node/languages","stargazers_url":"https://api.github.com/repos/mysteriumnetwork/node/stargazers","contributors_url":"https://api.github.com/repos/mysteriumnetwork/node/contributors","subscribers_url":"https://api.github.com/repos/mysteriumnetwork/node/subscribers","subscription_url":"https://api.github.com/repos/mysteriumnetwork/node/subscription","commits_url":"https://api.github.com/repos/mysteriumnetwork/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/mysteriumnetwork/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/mysteriumnetwork/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/mysteriumnetwork/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/mysteriumnetwork/node/contents/{+path}","compare_url":"https://api.github.com/repos/mysteriumnetwork/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mysteriumnetwork/node/merges","archive_url":"https://api.github.com/repos/mysteriumnetwork/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mysteriumnetwork/node/downloads","issues_url":"https://api.github.com/repos/mysteriumnetwork/node/issues{/number}","pulls_url":"https://api.github.com/repos/mysteriumnetwork/node/pulls{/number}","milestones_url":"https://api.github.com/repos/mysteriumnetwork/node/milestones{/number}","notifications_url":"https://api.github.com/repos/mysteriumnetwork/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mysteriumnetwork/node/labels{/name}","releases_url":"https://api.github.com/repos/mysteriumnetwork/node/releases{/id}","deployments_url":"https://api.github.com/repos/mysteriumnetwork/node/deployments","created_at":"2017-01-26T00:43:08Z","updated_at":"2018-11-15T10:54:27Z","pushed_at":"2018-11-15T12:56:35Z","git_url":"git://github.com/mysteriumnetwork/node.git","ssh_url":"git@github.com:mysteriumnetwork/node.git","clone_url":"https://github.com/mysteriumnetwork/node.git","svn_url":"https://github.com/mysteriumnetwork/node","homepage":"https://mysterium.network/","size":6738,"stargazers_count":474,"watchers_count":474,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":81,"mirror_url":null,"archived":false,"open_issues_count":81,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":81,"open_issues":81,"watchers":474,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mysteriumnetwork/node/pulls/541"},"html":{"href":"https://github.com/mysteriumnetwork/node/pull/541"},"issue":{"href":"https://api.github.com/repos/mysteriumnetwork/node/issues/541"},"comments":{"href":"https://api.github.com/repos/mysteriumnetwork/node/issues/541/comments"},"review_comments":{"href":"https://api.github.com/repos/mysteriumnetwork/node/pulls/541/comments"},"review_comment":{"href":"https://api.github.com/repos/mysteriumnetwork/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mysteriumnetwork/node/pulls/541/commits"},"statuses":{"href":"https://api.github.com/repos/mysteriumnetwork/node/statuses/b0dac46035e197d1bcdca99e7d1c8ece3b941870"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zolia"}}