{"action":"created","comment":{"url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/pulls/comments/191176133","pull_request_review_id":123696146,"id":191176133,"diff_hunk":"@@ -0,0 +1,34 @@\n+abstract type DataOnev2 <: DataRepo end\n+\n+export KNB\n+include(\"KNB.jl\")\n+\n+function description(repo::DataOnev2, mainpage)\n+    desc = try text_only(matchall(sel\"description para\", mainpage.root)) catch \"\" end\n+    authors = try [text_only(i) for i in matchall(sel\"individualName\", mainpage.root) if contains(string(i.parent), \"creator\")] catch [] end\n+    author = format_authors(authors)\n+    license = try text_only(first(matchall(sel\"intellectualRights\", mainpage.root))) catch \"\" end\n+    rawdate = try Dates.Date((text_only(first(matchall(sel\"pubDate\", mainpage.root)))), \"yyyy-mm-dd\") catch \"\" end\n+    year = try Dates.year(rawdate) catch \"\" end\n+    date = try Dates.format(rawdate, \"U d, yyyy\") catch \"\" end\n+    references = \"\"\n+    paper = join(authors, \", \") * \" ($(year)) \" * data_fullname(repo, mainpage) * \" \" * references","path":"src/DataOnev2/DataOnev2.jl","position":15,"original_position":15,"commit_id":"27732a7fd13d9d97e220ff09a212950d5c042a67","original_commit_id":"27732a7fd13d9d97e220ff09a212950d5c042a67","user":{"login":"oxinabox","id":5127634,"avatar_url":"https://avatars0.githubusercontent.com/u/5127634?v=4","gravatar_id":"","url":"https://api.github.com/users/oxinabox","html_url":"https://github.com/oxinabox","followers_url":"https://api.github.com/users/oxinabox/followers","following_url":"https://api.github.com/users/oxinabox/following{/other_user}","gists_url":"https://api.github.com/users/oxinabox/gists{/gist_id}","starred_url":"https://api.github.com/users/oxinabox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oxinabox/subscriptions","organizations_url":"https://api.github.com/users/oxinabox/orgs","repos_url":"https://api.github.com/users/oxinabox/repos","events_url":"https://api.github.com/users/oxinabox/events{/privacy}","received_events_url":"https://api.github.com/users/oxinabox/received_events","type":"User","site_admin":false},"body":"This does not give you the name of the paper.\r\nIf one can't get the name of the paper, it is fine to exclude it from the generation.\r\nIf the DataOne API doesn't keep that kinda metadata then it is not a worry.","created_at":"2018-05-28T10:49:03Z","updated_at":"2018-05-28T11:01:52Z","html_url":"https://github.com/oxinabox/DataDepsGenerators.jl/pull/21#discussion_r191176133","pull_request_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/pulls/21","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/pulls/comments/191176133"},"html":{"href":"https://github.com/oxinabox/DataDepsGenerators.jl/pull/21#discussion_r191176133"},"pull_request":{"href":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/pulls/21","id":190693460,"html_url":"https://github.com/oxinabox/DataDepsGenerators.jl/pull/21","diff_url":"https://github.com/oxinabox/DataDepsGenerators.jl/pull/21.diff","patch_url":"https://github.com/oxinabox/DataDepsGenerators.jl/pull/21.patch","issue_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/issues/21","number":21,"state":"open","locked":false,"title":"Implement DataOnev2 abstraction","user":{"login":"SebastinSanty","id":13795788,"avatar_url":"https://avatars2.githubusercontent.com/u/13795788?v=4","gravatar_id":"","url":"https://api.github.com/users/SebastinSanty","html_url":"https://github.com/SebastinSanty","followers_url":"https://api.github.com/users/SebastinSanty/followers","following_url":"https://api.github.com/users/SebastinSanty/following{/other_user}","gists_url":"https://api.github.com/users/SebastinSanty/gists{/gist_id}","starred_url":"https://api.github.com/users/SebastinSanty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SebastinSanty/subscriptions","organizations_url":"https://api.github.com/users/SebastinSanty/orgs","repos_url":"https://api.github.com/users/SebastinSanty/repos","events_url":"https://api.github.com/users/SebastinSanty/events{/privacy}","received_events_url":"https://api.github.com/users/SebastinSanty/received_events","type":"User","site_admin":false},"body":"Few points to make:\r\n\r\n* It happens that DataDryad is on a older version of DataOne API, hence what was described yesterday didn’t quite turn out as expected. Hence, I made a common base for DataOnev2 which includes KNB which in turn supports ArcticDataCenter. I was not able to find any other API (I was trying to get TERN AU, but didn’t work), hence it would be very helpful if you can point me to a few. Also, Merritt by UC3 which is supposed to be on DataOne API supports a completely different API.\r\n\r\n* Though ArcticDataCenter(ADC) mentions that it runs its API through KNB (check [here](https://arcticdata.io/catalog/#api)), I was not able to get ADC examples working with its API other than the one example mentioned in that doc.","created_at":"2018-05-25T21:02:10Z","updated_at":"2018-05-28T11:01:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2bbdcda2ed0c02c138027324ec5646fd39a6de9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/pulls/21/commits","review_comments_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/pulls/21/comments","review_comment_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/issues/21/comments","statuses_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/statuses/27732a7fd13d9d97e220ff09a212950d5c042a67","head":{"label":"SebastinSanty:arctic","ref":"arctic","sha":"27732a7fd13d9d97e220ff09a212950d5c042a67","user":{"login":"SebastinSanty","id":13795788,"avatar_url":"https://avatars2.githubusercontent.com/u/13795788?v=4","gravatar_id":"","url":"https://api.github.com/users/SebastinSanty","html_url":"https://github.com/SebastinSanty","followers_url":"https://api.github.com/users/SebastinSanty/followers","following_url":"https://api.github.com/users/SebastinSanty/following{/other_user}","gists_url":"https://api.github.com/users/SebastinSanty/gists{/gist_id}","starred_url":"https://api.github.com/users/SebastinSanty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SebastinSanty/subscriptions","organizations_url":"https://api.github.com/users/SebastinSanty/orgs","repos_url":"https://api.github.com/users/SebastinSanty/repos","events_url":"https://api.github.com/users/SebastinSanty/events{/privacy}","received_events_url":"https://api.github.com/users/SebastinSanty/received_events","type":"User","site_admin":false},"repo":{"id":123028886,"name":"DataDepsGenerators.jl","full_name":"SebastinSanty/DataDepsGenerators.jl","owner":{"login":"SebastinSanty","id":13795788,"avatar_url":"https://avatars2.githubusercontent.com/u/13795788?v=4","gravatar_id":"","url":"https://api.github.com/users/SebastinSanty","html_url":"https://github.com/SebastinSanty","followers_url":"https://api.github.com/users/SebastinSanty/followers","following_url":"https://api.github.com/users/SebastinSanty/following{/other_user}","gists_url":"https://api.github.com/users/SebastinSanty/gists{/gist_id}","starred_url":"https://api.github.com/users/SebastinSanty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SebastinSanty/subscriptions","organizations_url":"https://api.github.com/users/SebastinSanty/orgs","repos_url":"https://api.github.com/users/SebastinSanty/repos","events_url":"https://api.github.com/users/SebastinSanty/events{/privacy}","received_events_url":"https://api.github.com/users/SebastinSanty/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SebastinSanty/DataDepsGenerators.jl","description":"Utility for Developers to help define DataDeps registration lines","fork":true,"url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl","forks_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/forks","keys_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/teams","hooks_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/hooks","issue_events_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/issues/events{/number}","events_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/events","assignees_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/assignees{/user}","branches_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/branches{/branch}","tags_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/tags","blobs_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/languages","stargazers_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/stargazers","contributors_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/contributors","subscribers_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/subscribers","subscription_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/subscription","commits_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/contents/{+path}","compare_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/merges","archive_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/downloads","issues_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/issues{/number}","pulls_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/labels{/name}","releases_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/releases{/id}","deployments_url":"https://api.github.com/repos/SebastinSanty/DataDepsGenerators.jl/deployments","created_at":"2018-02-26T20:51:28Z","updated_at":"2018-05-25T15:36:41Z","pushed_at":"2018-05-25T20:59:27Z","git_url":"git://github.com/SebastinSanty/DataDepsGenerators.jl.git","ssh_url":"git@github.com:SebastinSanty/DataDepsGenerators.jl.git","clone_url":"https://github.com/SebastinSanty/DataDepsGenerators.jl.git","svn_url":"https://github.com/SebastinSanty/DataDepsGenerators.jl","homepage":null,"size":167,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"oxinabox:master","ref":"master","sha":"4261d42e5e374dfd7dd8f69b5c7cc7e5a094bc58","user":{"login":"oxinabox","id":5127634,"avatar_url":"https://avatars0.githubusercontent.com/u/5127634?v=4","gravatar_id":"","url":"https://api.github.com/users/oxinabox","html_url":"https://github.com/oxinabox","followers_url":"https://api.github.com/users/oxinabox/followers","following_url":"https://api.github.com/users/oxinabox/following{/other_user}","gists_url":"https://api.github.com/users/oxinabox/gists{/gist_id}","starred_url":"https://api.github.com/users/oxinabox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oxinabox/subscriptions","organizations_url":"https://api.github.com/users/oxinabox/orgs","repos_url":"https://api.github.com/users/oxinabox/repos","events_url":"https://api.github.com/users/oxinabox/events{/privacy}","received_events_url":"https://api.github.com/users/oxinabox/received_events","type":"User","site_admin":false},"repo":{"id":110497836,"name":"DataDepsGenerators.jl","full_name":"oxinabox/DataDepsGenerators.jl","owner":{"login":"oxinabox","id":5127634,"avatar_url":"https://avatars0.githubusercontent.com/u/5127634?v=4","gravatar_id":"","url":"https://api.github.com/users/oxinabox","html_url":"https://github.com/oxinabox","followers_url":"https://api.github.com/users/oxinabox/followers","following_url":"https://api.github.com/users/oxinabox/following{/other_user}","gists_url":"https://api.github.com/users/oxinabox/gists{/gist_id}","starred_url":"https://api.github.com/users/oxinabox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oxinabox/subscriptions","organizations_url":"https://api.github.com/users/oxinabox/orgs","repos_url":"https://api.github.com/users/oxinabox/repos","events_url":"https://api.github.com/users/oxinabox/events{/privacy}","received_events_url":"https://api.github.com/users/oxinabox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oxinabox/DataDepsGenerators.jl","description":"Utility for developers to help define DataDeps registration blocks, for reusing existing Data with DataDeps.jl","fork":false,"url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl","forks_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/forks","keys_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/teams","hooks_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/hooks","issue_events_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/issues/events{/number}","events_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/events","assignees_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/assignees{/user}","branches_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/branches{/branch}","tags_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/tags","blobs_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/languages","stargazers_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/stargazers","contributors_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/contributors","subscribers_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/subscribers","subscription_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/subscription","commits_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/contents/{+path}","compare_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/merges","archive_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/downloads","issues_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/issues{/number}","pulls_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/labels{/name}","releases_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/releases{/id}","deployments_url":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/deployments","created_at":"2017-11-13T03:53:45Z","updated_at":"2018-05-25T12:22:00Z","pushed_at":"2018-05-25T21:02:11Z","git_url":"git://github.com/oxinabox/DataDepsGenerators.jl.git","ssh_url":"git@github.com:oxinabox/DataDepsGenerators.jl.git","clone_url":"https://github.com/oxinabox/DataDepsGenerators.jl.git","svn_url":"https://github.com/oxinabox/DataDepsGenerators.jl","homepage":"","size":114,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/pulls/21"},"html":{"href":"https://github.com/oxinabox/DataDepsGenerators.jl/pull/21"},"issue":{"href":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/issues/21"},"comments":{"href":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/oxinabox/DataDepsGenerators.jl/statuses/27732a7fd13d9d97e220ff09a212950d5c042a67"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"oxinabox"}}