{"action":"created","comment":{"url":"https://api.github.com/repos/sunpy/ndcube/pulls/comments/167257367","pull_request_review_id":95455722,"id":167257367,"diff_hunk":"@@ -268,22 +294,37 @@ def dimensions(self):\n         shape = u.Quantity(self.data.shape, unit=u.pix)\n         return DimensionPair(shape=shape, axis_types=axes_ctype[::-1])\n \n-    def crop_by_coords(self, lower_left_corner, dimension_widths):\n+    def crop_by_coords(self, min_coord_values, interval_widths):\n         # The docstring is defined in NDDataBase\n \n         n_dim = len(self.dimensions.shape)\n-        if len(lower_left_corner) != len(dimension_widths) != n_dim:\n-            raise ValueError(\"lower_left_corner and dimension_widths must have \"\n+        if len(min_coord_values) != len(interval_widths) != n_dim:\n+            raise ValueError(\"min_coord_values and interval_widths must have \"\n                              \"same number of elements as number of data dimensions.\")\n         # Convert coords of lower left corner to pixel units.\n-        lower_pixels = self.world_to_pixel(lower_left_corner)\n-        upper_pixels = self.world_to_pixel([lower_left_corner[i]+dimension_widths[i]\n+        lower_pixels = self.world_to_pixel(min_coord_values)\n+        upper_pixels = self.world_to_pixel([min_coord_values[i]+interval_widths[i]","path":"ndcube/ndcube.py","position":99,"original_position":99,"commit_id":"dd1a14d6e875f4402d2cdb6fffa08fbf6342fbe7","original_commit_id":"dd1a14d6e875f4402d2cdb6fffa08fbf6342fbe7","user":{"login":"Cadair","id":1391051,"avatar_url":"https://avatars2.githubusercontent.com/u/1391051?v=4","gravatar_id":"","url":"https://api.github.com/users/Cadair","html_url":"https://github.com/Cadair","followers_url":"https://api.github.com/users/Cadair/followers","following_url":"https://api.github.com/users/Cadair/following{/other_user}","gists_url":"https://api.github.com/users/Cadair/gists{/gist_id}","starred_url":"https://api.github.com/users/Cadair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cadair/subscriptions","organizations_url":"https://api.github.com/users/Cadair/orgs","repos_url":"https://api.github.com/users/Cadair/repos","events_url":"https://api.github.com/users/Cadair/events{/privacy}","received_events_url":"https://api.github.com/users/Cadair/received_events","type":"User","site_admin":false},"body":"spaces around the `+` 😉 ","created_at":"2018-02-09T15:26:11Z","updated_at":"2018-02-09T15:27:11Z","html_url":"https://github.com/sunpy/ndcube/pull/41#discussion_r167257367","pull_request_url":"https://api.github.com/repos/sunpy/ndcube/pulls/41","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/sunpy/ndcube/pulls/comments/167257367"},"html":{"href":"https://github.com/sunpy/ndcube/pull/41#discussion_r167257367"},"pull_request":{"href":"https://api.github.com/repos/sunpy/ndcube/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/sunpy/ndcube/pulls/41","id":167548111,"html_url":"https://github.com/sunpy/ndcube/pull/41","diff_url":"https://github.com/sunpy/ndcube/pull/41.diff","patch_url":"https://github.com/sunpy/ndcube/pull/41.patch","issue_url":"https://api.github.com/repos/sunpy/ndcube/issues/41","number":41,"state":"open","locked":false,"title":"Added method to NDCube to crop by extra coordinate.","user":{"login":"DanRyanIrish","id":6806704,"avatar_url":"https://avatars1.githubusercontent.com/u/6806704?v=4","gravatar_id":"","url":"https://api.github.com/users/DanRyanIrish","html_url":"https://github.com/DanRyanIrish","followers_url":"https://api.github.com/users/DanRyanIrish/followers","following_url":"https://api.github.com/users/DanRyanIrish/following{/other_user}","gists_url":"https://api.github.com/users/DanRyanIrish/gists{/gist_id}","starred_url":"https://api.github.com/users/DanRyanIrish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanRyanIrish/subscriptions","organizations_url":"https://api.github.com/users/DanRyanIrish/orgs","repos_url":"https://api.github.com/users/DanRyanIrish/repos","events_url":"https://api.github.com/users/DanRyanIrish/events{/privacy}","received_events_url":"https://api.github.com/users/DanRyanIrish/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-06T22:32:08Z","updated_at":"2018-02-09T15:27:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"403b14349eb0d0796a141cf82c0412ee5804741c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":{"url":"https://api.github.com/repos/sunpy/ndcube/milestones/1","html_url":"https://github.com/sunpy/ndcube/milestone/1","labels_url":"https://api.github.com/repos/sunpy/ndcube/milestones/1/labels","id":2956475,"number":1,"title":"1.0","description":"The first release, primarily for IRISPy.","creator":{"login":"Cadair","id":1391051,"avatar_url":"https://avatars2.githubusercontent.com/u/1391051?v=4","gravatar_id":"","url":"https://api.github.com/users/Cadair","html_url":"https://github.com/Cadair","followers_url":"https://api.github.com/users/Cadair/followers","following_url":"https://api.github.com/users/Cadair/following{/other_user}","gists_url":"https://api.github.com/users/Cadair/gists{/gist_id}","starred_url":"https://api.github.com/users/Cadair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cadair/subscriptions","organizations_url":"https://api.github.com/users/Cadair/orgs","repos_url":"https://api.github.com/users/Cadair/repos","events_url":"https://api.github.com/users/Cadair/events{/privacy}","received_events_url":"https://api.github.com/users/Cadair/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":2,"state":"open","created_at":"2017-12-04T15:08:08Z","updated_at":"2018-02-09T15:22:38Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/sunpy/ndcube/pulls/41/commits","review_comments_url":"https://api.github.com/repos/sunpy/ndcube/pulls/41/comments","review_comment_url":"https://api.github.com/repos/sunpy/ndcube/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sunpy/ndcube/issues/41/comments","statuses_url":"https://api.github.com/repos/sunpy/ndcube/statuses/dd1a14d6e875f4402d2cdb6fffa08fbf6342fbe7","head":{"label":"DanRyanIrish:crop_extra_coords","ref":"crop_extra_coords","sha":"dd1a14d6e875f4402d2cdb6fffa08fbf6342fbe7","user":{"login":"DanRyanIrish","id":6806704,"avatar_url":"https://avatars1.githubusercontent.com/u/6806704?v=4","gravatar_id":"","url":"https://api.github.com/users/DanRyanIrish","html_url":"https://github.com/DanRyanIrish","followers_url":"https://api.github.com/users/DanRyanIrish/followers","following_url":"https://api.github.com/users/DanRyanIrish/following{/other_user}","gists_url":"https://api.github.com/users/DanRyanIrish/gists{/gist_id}","starred_url":"https://api.github.com/users/DanRyanIrish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanRyanIrish/subscriptions","organizations_url":"https://api.github.com/users/DanRyanIrish/orgs","repos_url":"https://api.github.com/users/DanRyanIrish/repos","events_url":"https://api.github.com/users/DanRyanIrish/events{/privacy}","received_events_url":"https://api.github.com/users/DanRyanIrish/received_events","type":"User","site_admin":false},"repo":{"id":100519547,"name":"ndcube","full_name":"DanRyanIrish/ndcube","owner":{"login":"DanRyanIrish","id":6806704,"avatar_url":"https://avatars1.githubusercontent.com/u/6806704?v=4","gravatar_id":"","url":"https://api.github.com/users/DanRyanIrish","html_url":"https://github.com/DanRyanIrish","followers_url":"https://api.github.com/users/DanRyanIrish/followers","following_url":"https://api.github.com/users/DanRyanIrish/following{/other_user}","gists_url":"https://api.github.com/users/DanRyanIrish/gists{/gist_id}","starred_url":"https://api.github.com/users/DanRyanIrish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanRyanIrish/subscriptions","organizations_url":"https://api.github.com/users/DanRyanIrish/orgs","repos_url":"https://api.github.com/users/DanRyanIrish/repos","events_url":"https://api.github.com/users/DanRyanIrish/events{/privacy}","received_events_url":"https://api.github.com/users/DanRyanIrish/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DanRyanIrish/ndcube","description":"A base package for multi-dimensional contiguious and non-contiguious spatially aware arrays. Maintainer: @danryanirish","fork":true,"url":"https://api.github.com/repos/DanRyanIrish/ndcube","forks_url":"https://api.github.com/repos/DanRyanIrish/ndcube/forks","keys_url":"https://api.github.com/repos/DanRyanIrish/ndcube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DanRyanIrish/ndcube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DanRyanIrish/ndcube/teams","hooks_url":"https://api.github.com/repos/DanRyanIrish/ndcube/hooks","issue_events_url":"https://api.github.com/repos/DanRyanIrish/ndcube/issues/events{/number}","events_url":"https://api.github.com/repos/DanRyanIrish/ndcube/events","assignees_url":"https://api.github.com/repos/DanRyanIrish/ndcube/assignees{/user}","branches_url":"https://api.github.com/repos/DanRyanIrish/ndcube/branches{/branch}","tags_url":"https://api.github.com/repos/DanRyanIrish/ndcube/tags","blobs_url":"https://api.github.com/repos/DanRyanIrish/ndcube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DanRyanIrish/ndcube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DanRyanIrish/ndcube/git/refs{/sha}","trees_url":"https://api.github.com/repos/DanRyanIrish/ndcube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DanRyanIrish/ndcube/statuses/{sha}","languages_url":"https://api.github.com/repos/DanRyanIrish/ndcube/languages","stargazers_url":"https://api.github.com/repos/DanRyanIrish/ndcube/stargazers","contributors_url":"https://api.github.com/repos/DanRyanIrish/ndcube/contributors","subscribers_url":"https://api.github.com/repos/DanRyanIrish/ndcube/subscribers","subscription_url":"https://api.github.com/repos/DanRyanIrish/ndcube/subscription","commits_url":"https://api.github.com/repos/DanRyanIrish/ndcube/commits{/sha}","git_commits_url":"https://api.github.com/repos/DanRyanIrish/ndcube/git/commits{/sha}","comments_url":"https://api.github.com/repos/DanRyanIrish/ndcube/comments{/number}","issue_comment_url":"https://api.github.com/repos/DanRyanIrish/ndcube/issues/comments{/number}","contents_url":"https://api.github.com/repos/DanRyanIrish/ndcube/contents/{+path}","compare_url":"https://api.github.com/repos/DanRyanIrish/ndcube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DanRyanIrish/ndcube/merges","archive_url":"https://api.github.com/repos/DanRyanIrish/ndcube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DanRyanIrish/ndcube/downloads","issues_url":"https://api.github.com/repos/DanRyanIrish/ndcube/issues{/number}","pulls_url":"https://api.github.com/repos/DanRyanIrish/ndcube/pulls{/number}","milestones_url":"https://api.github.com/repos/DanRyanIrish/ndcube/milestones{/number}","notifications_url":"https://api.github.com/repos/DanRyanIrish/ndcube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DanRyanIrish/ndcube/labels{/name}","releases_url":"https://api.github.com/repos/DanRyanIrish/ndcube/releases{/id}","deployments_url":"https://api.github.com/repos/DanRyanIrish/ndcube/deployments","created_at":"2017-08-16T18:21:14Z","updated_at":"2017-08-16T18:21:16Z","pushed_at":"2018-02-09T14:47:57Z","git_url":"git://github.com/DanRyanIrish/ndcube.git","ssh_url":"git@github.com:DanRyanIrish/ndcube.git","clone_url":"https://github.com/DanRyanIrish/ndcube.git","svn_url":"https://github.com/DanRyanIrish/ndcube","homepage":"","size":463,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sunpy:master","ref":"master","sha":"967943142ec49a5f27186d5b7294a11a0dd0abbf","user":{"login":"sunpy","id":963197,"avatar_url":"https://avatars0.githubusercontent.com/u/963197?v=4","gravatar_id":"","url":"https://api.github.com/users/sunpy","html_url":"https://github.com/sunpy","followers_url":"https://api.github.com/users/sunpy/followers","following_url":"https://api.github.com/users/sunpy/following{/other_user}","gists_url":"https://api.github.com/users/sunpy/gists{/gist_id}","starred_url":"https://api.github.com/users/sunpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunpy/subscriptions","organizations_url":"https://api.github.com/users/sunpy/orgs","repos_url":"https://api.github.com/users/sunpy/repos","events_url":"https://api.github.com/users/sunpy/events{/privacy}","received_events_url":"https://api.github.com/users/sunpy/received_events","type":"Organization","site_admin":false},"repo":{"id":100395296,"name":"ndcube","full_name":"sunpy/ndcube","owner":{"login":"sunpy","id":963197,"avatar_url":"https://avatars0.githubusercontent.com/u/963197?v=4","gravatar_id":"","url":"https://api.github.com/users/sunpy","html_url":"https://github.com/sunpy","followers_url":"https://api.github.com/users/sunpy/followers","following_url":"https://api.github.com/users/sunpy/following{/other_user}","gists_url":"https://api.github.com/users/sunpy/gists{/gist_id}","starred_url":"https://api.github.com/users/sunpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunpy/subscriptions","organizations_url":"https://api.github.com/users/sunpy/orgs","repos_url":"https://api.github.com/users/sunpy/repos","events_url":"https://api.github.com/users/sunpy/events{/privacy}","received_events_url":"https://api.github.com/users/sunpy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sunpy/ndcube","description":"A base package for multi-dimensional contiguious and non-contiguious spatially aware arrays. Maintainer: @danryanirish","fork":false,"url":"https://api.github.com/repos/sunpy/ndcube","forks_url":"https://api.github.com/repos/sunpy/ndcube/forks","keys_url":"https://api.github.com/repos/sunpy/ndcube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sunpy/ndcube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sunpy/ndcube/teams","hooks_url":"https://api.github.com/repos/sunpy/ndcube/hooks","issue_events_url":"https://api.github.com/repos/sunpy/ndcube/issues/events{/number}","events_url":"https://api.github.com/repos/sunpy/ndcube/events","assignees_url":"https://api.github.com/repos/sunpy/ndcube/assignees{/user}","branches_url":"https://api.github.com/repos/sunpy/ndcube/branches{/branch}","tags_url":"https://api.github.com/repos/sunpy/ndcube/tags","blobs_url":"https://api.github.com/repos/sunpy/ndcube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sunpy/ndcube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sunpy/ndcube/git/refs{/sha}","trees_url":"https://api.github.com/repos/sunpy/ndcube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sunpy/ndcube/statuses/{sha}","languages_url":"https://api.github.com/repos/sunpy/ndcube/languages","stargazers_url":"https://api.github.com/repos/sunpy/ndcube/stargazers","contributors_url":"https://api.github.com/repos/sunpy/ndcube/contributors","subscribers_url":"https://api.github.com/repos/sunpy/ndcube/subscribers","subscription_url":"https://api.github.com/repos/sunpy/ndcube/subscription","commits_url":"https://api.github.com/repos/sunpy/ndcube/commits{/sha}","git_commits_url":"https://api.github.com/repos/sunpy/ndcube/git/commits{/sha}","comments_url":"https://api.github.com/repos/sunpy/ndcube/comments{/number}","issue_comment_url":"https://api.github.com/repos/sunpy/ndcube/issues/comments{/number}","contents_url":"https://api.github.com/repos/sunpy/ndcube/contents/{+path}","compare_url":"https://api.github.com/repos/sunpy/ndcube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sunpy/ndcube/merges","archive_url":"https://api.github.com/repos/sunpy/ndcube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sunpy/ndcube/downloads","issues_url":"https://api.github.com/repos/sunpy/ndcube/issues{/number}","pulls_url":"https://api.github.com/repos/sunpy/ndcube/pulls{/number}","milestones_url":"https://api.github.com/repos/sunpy/ndcube/milestones{/number}","notifications_url":"https://api.github.com/repos/sunpy/ndcube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sunpy/ndcube/labels{/name}","releases_url":"https://api.github.com/repos/sunpy/ndcube/releases{/id}","deployments_url":"https://api.github.com/repos/sunpy/ndcube/deployments","created_at":"2017-08-15T16:07:57Z","updated_at":"2017-09-23T06:08:39Z","pushed_at":"2018-02-09T15:23:47Z","git_url":"git://github.com/sunpy/ndcube.git","ssh_url":"git@github.com:sunpy/ndcube.git","clone_url":"https://github.com/sunpy/ndcube.git","svn_url":"https://github.com/sunpy/ndcube","homepage":"","size":456,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":5,"open_issues":9,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sunpy/ndcube/pulls/41"},"html":{"href":"https://github.com/sunpy/ndcube/pull/41"},"issue":{"href":"https://api.github.com/repos/sunpy/ndcube/issues/41"},"comments":{"href":"https://api.github.com/repos/sunpy/ndcube/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/sunpy/ndcube/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/sunpy/ndcube/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sunpy/ndcube/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/sunpy/ndcube/statuses/dd1a14d6e875f4402d2cdb6fffa08fbf6342fbe7"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Cadair"}}