{"action":"created","comment":{"url":"https://api.github.com/repos/oppia/oppia/pulls/comments/166376639","pull_request_review_id":94425545,"id":166376639,"diff_hunk":"@@ -188,6 +180,17 @@ oppia.directive('audioBar', [\n             }\n           };\n \n+          $scope.track = {             \n+            progress: function(progress) {\n+              if (arguments.length){\n+                AudioPlayerService.setProgress(progress * 1.0 / 100);","path":"core/templates/dev/head/pages/exploration_player/AudioBarDirective.js","position":22,"original_position":22,"commit_id":"615f15ab6ccc55126f35e1a98f4d0080b8fa2f9c","original_commit_id":"615f15ab6ccc55126f35e1a98f4d0080b8fa2f9c","user":{"login":"tjiang11","id":11807091,"avatar_url":"https://avatars2.githubusercontent.com/u/11807091?v=4","gravatar_id":"","url":"https://api.github.com/users/tjiang11","html_url":"https://github.com/tjiang11","followers_url":"https://api.github.com/users/tjiang11/followers","following_url":"https://api.github.com/users/tjiang11/following{/other_user}","gists_url":"https://api.github.com/users/tjiang11/gists{/gist_id}","starred_url":"https://api.github.com/users/tjiang11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjiang11/subscriptions","organizations_url":"https://api.github.com/users/tjiang11/orgs","repos_url":"https://api.github.com/users/tjiang11/repos","events_url":"https://api.github.com/users/tjiang11/events{/privacy}","received_events_url":"https://api.github.com/users/tjiang11/received_events","type":"User","site_admin":false},"body":"Is the `* 1.0` necessary ?","created_at":"2018-02-06T17:15:40Z","updated_at":"2018-02-06T17:20:16Z","html_url":"https://github.com/oppia/oppia/pull/4659#discussion_r166376639","pull_request_url":"https://api.github.com/repos/oppia/oppia/pulls/4659","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments/166376639"},"html":{"href":"https://github.com/oppia/oppia/pull/4659#discussion_r166376639"},"pull_request":{"href":"https://api.github.com/repos/oppia/oppia/pulls/4659"}}},"pull_request":{"url":"https://api.github.com/repos/oppia/oppia/pulls/4659","id":167183922,"html_url":"https://github.com/oppia/oppia/pull/4659","diff_url":"https://github.com/oppia/oppia/pull/4659.diff","patch_url":"https://github.com/oppia/oppia/pull/4659.patch","issue_url":"https://api.github.com/repos/oppia/oppia/issues/4659","number":4659,"state":"open","locked":false,"title":"Fix #4295: Added slider for audio bar","user":{"login":"bansalnitish","id":22434689,"avatar_url":"https://avatars1.githubusercontent.com/u/22434689?v=4","gravatar_id":"","url":"https://api.github.com/users/bansalnitish","html_url":"https://github.com/bansalnitish","followers_url":"https://api.github.com/users/bansalnitish/followers","following_url":"https://api.github.com/users/bansalnitish/following{/other_user}","gists_url":"https://api.github.com/users/bansalnitish/gists{/gist_id}","starred_url":"https://api.github.com/users/bansalnitish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bansalnitish/subscriptions","organizations_url":"https://api.github.com/users/bansalnitish/orgs","repos_url":"https://api.github.com/users/bansalnitish/repos","events_url":"https://api.github.com/users/bansalnitish/events{/privacy}","received_events_url":"https://api.github.com/users/bansalnitish/received_events","type":"User","site_admin":false},"body":"This PR changes the progress bar in the audio bar to a slider. Audio's progress property is used as ``ng-model`` for the slider.\r\n**Checklist**\r\n- [x] The PR title starts with \"Fix #bugnum: \", followed by a short, clear summary of the changes.\r\n- [x] The linter/Karma presubmit checks have passed.\r\n  - These should run automatically, but if not, you can manually trigger them locally using `python scripts/pre_commit_linter.py` and `bash scripts/run_frontend_tests.sh`.\r\n- [x] The PR is made from a branch that's **not** called \"develop\".\r\n- [x] The PR follows the [style guide](https://github.com/oppia/oppia/wiki/Coding-style-guide).\r\n- [x] The PR is assigned to an appropriate reviewer.\r\n  - If you're a new contributor, please ask on [Gitter](https://gitter.im/oppia/oppia-chat) for someone to assign a reviewer.\r\n  - If you're not sure who the appropriate reviewer is, please assign to the issue's \"owner\" -- see the \"talk-to\" label on the issue.\r\n","created_at":"2018-02-05T16:03:02Z","updated_at":"2018-02-06T17:20:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d2023de63245f293295911df56a4a47f845b3a1","assignee":{"login":"tjiang11","id":11807091,"avatar_url":"https://avatars2.githubusercontent.com/u/11807091?v=4","gravatar_id":"","url":"https://api.github.com/users/tjiang11","html_url":"https://github.com/tjiang11","followers_url":"https://api.github.com/users/tjiang11/followers","following_url":"https://api.github.com/users/tjiang11/following{/other_user}","gists_url":"https://api.github.com/users/tjiang11/gists{/gist_id}","starred_url":"https://api.github.com/users/tjiang11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjiang11/subscriptions","organizations_url":"https://api.github.com/users/tjiang11/orgs","repos_url":"https://api.github.com/users/tjiang11/repos","events_url":"https://api.github.com/users/tjiang11/events{/privacy}","received_events_url":"https://api.github.com/users/tjiang11/received_events","type":"User","site_admin":false},"assignees":[{"login":"tjiang11","id":11807091,"avatar_url":"https://avatars2.githubusercontent.com/u/11807091?v=4","gravatar_id":"","url":"https://api.github.com/users/tjiang11","html_url":"https://github.com/tjiang11","followers_url":"https://api.github.com/users/tjiang11/followers","following_url":"https://api.github.com/users/tjiang11/following{/other_user}","gists_url":"https://api.github.com/users/tjiang11/gists{/gist_id}","starred_url":"https://api.github.com/users/tjiang11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjiang11/subscriptions","organizations_url":"https://api.github.com/users/tjiang11/orgs","repos_url":"https://api.github.com/users/tjiang11/repos","events_url":"https://api.github.com/users/tjiang11/events{/privacy}","received_events_url":"https://api.github.com/users/tjiang11/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/oppia/oppia/pulls/4659/commits","review_comments_url":"https://api.github.com/repos/oppia/oppia/pulls/4659/comments","review_comment_url":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oppia/oppia/issues/4659/comments","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/615f15ab6ccc55126f35e1a98f4d0080b8fa2f9c","head":{"label":"bansalnitish:audio-fix","ref":"audio-fix","sha":"615f15ab6ccc55126f35e1a98f4d0080b8fa2f9c","user":{"login":"bansalnitish","id":22434689,"avatar_url":"https://avatars1.githubusercontent.com/u/22434689?v=4","gravatar_id":"","url":"https://api.github.com/users/bansalnitish","html_url":"https://github.com/bansalnitish","followers_url":"https://api.github.com/users/bansalnitish/followers","following_url":"https://api.github.com/users/bansalnitish/following{/other_user}","gists_url":"https://api.github.com/users/bansalnitish/gists{/gist_id}","starred_url":"https://api.github.com/users/bansalnitish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bansalnitish/subscriptions","organizations_url":"https://api.github.com/users/bansalnitish/orgs","repos_url":"https://api.github.com/users/bansalnitish/repos","events_url":"https://api.github.com/users/bansalnitish/events{/privacy}","received_events_url":"https://api.github.com/users/bansalnitish/received_events","type":"User","site_admin":false},"repo":{"id":118839208,"name":"oppia","full_name":"bansalnitish/oppia","owner":{"login":"bansalnitish","id":22434689,"avatar_url":"https://avatars1.githubusercontent.com/u/22434689?v=4","gravatar_id":"","url":"https://api.github.com/users/bansalnitish","html_url":"https://github.com/bansalnitish","followers_url":"https://api.github.com/users/bansalnitish/followers","following_url":"https://api.github.com/users/bansalnitish/following{/other_user}","gists_url":"https://api.github.com/users/bansalnitish/gists{/gist_id}","starred_url":"https://api.github.com/users/bansalnitish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bansalnitish/subscriptions","organizations_url":"https://api.github.com/users/bansalnitish/orgs","repos_url":"https://api.github.com/users/bansalnitish/repos","events_url":"https://api.github.com/users/bansalnitish/events{/privacy}","received_events_url":"https://api.github.com/users/bansalnitish/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bansalnitish/oppia","description":"Tool for collaboratively building interactive lessons.","fork":true,"url":"https://api.github.com/repos/bansalnitish/oppia","forks_url":"https://api.github.com/repos/bansalnitish/oppia/forks","keys_url":"https://api.github.com/repos/bansalnitish/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bansalnitish/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bansalnitish/oppia/teams","hooks_url":"https://api.github.com/repos/bansalnitish/oppia/hooks","issue_events_url":"https://api.github.com/repos/bansalnitish/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/bansalnitish/oppia/events","assignees_url":"https://api.github.com/repos/bansalnitish/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/bansalnitish/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/bansalnitish/oppia/tags","blobs_url":"https://api.github.com/repos/bansalnitish/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bansalnitish/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bansalnitish/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/bansalnitish/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bansalnitish/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/bansalnitish/oppia/languages","stargazers_url":"https://api.github.com/repos/bansalnitish/oppia/stargazers","contributors_url":"https://api.github.com/repos/bansalnitish/oppia/contributors","subscribers_url":"https://api.github.com/repos/bansalnitish/oppia/subscribers","subscription_url":"https://api.github.com/repos/bansalnitish/oppia/subscription","commits_url":"https://api.github.com/repos/bansalnitish/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/bansalnitish/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/bansalnitish/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/bansalnitish/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/bansalnitish/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/bansalnitish/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bansalnitish/oppia/merges","archive_url":"https://api.github.com/repos/bansalnitish/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bansalnitish/oppia/downloads","issues_url":"https://api.github.com/repos/bansalnitish/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/bansalnitish/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/bansalnitish/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/bansalnitish/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bansalnitish/oppia/labels{/name}","releases_url":"https://api.github.com/repos/bansalnitish/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/bansalnitish/oppia/deployments","created_at":"2018-01-25T00:19:07Z","updated_at":"2018-01-25T00:19:13Z","pushed_at":"2018-02-06T12:28:18Z","git_url":"git://github.com/bansalnitish/oppia.git","ssh_url":"git@github.com:bansalnitish/oppia.git","clone_url":"https://github.com/bansalnitish/oppia.git","svn_url":"https://github.com/bansalnitish/oppia","homepage":"https://www.oppia.org","size":99474,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"oppia:develop","ref":"develop","sha":"37c1860f7a3b198f05b4f5d290e81308eb4a0ee0","user":{"login":"oppia","id":11620230,"avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"repo":{"id":40687563,"name":"oppia","full_name":"oppia/oppia","owner":{"login":"oppia","id":11620230,"avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oppia/oppia","description":"Tool for collaboratively building interactive lessons.","fork":false,"url":"https://api.github.com/repos/oppia/oppia","forks_url":"https://api.github.com/repos/oppia/oppia/forks","keys_url":"https://api.github.com/repos/oppia/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oppia/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oppia/oppia/teams","hooks_url":"https://api.github.com/repos/oppia/oppia/hooks","issue_events_url":"https://api.github.com/repos/oppia/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/oppia/oppia/events","assignees_url":"https://api.github.com/repos/oppia/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/oppia/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/oppia/oppia/tags","blobs_url":"https://api.github.com/repos/oppia/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oppia/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oppia/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/oppia/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/oppia/oppia/languages","stargazers_url":"https://api.github.com/repos/oppia/oppia/stargazers","contributors_url":"https://api.github.com/repos/oppia/oppia/contributors","subscribers_url":"https://api.github.com/repos/oppia/oppia/subscribers","subscription_url":"https://api.github.com/repos/oppia/oppia/subscription","commits_url":"https://api.github.com/repos/oppia/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/oppia/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/oppia/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/oppia/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/oppia/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/oppia/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oppia/oppia/merges","archive_url":"https://api.github.com/repos/oppia/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oppia/oppia/downloads","issues_url":"https://api.github.com/repos/oppia/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/oppia/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/oppia/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/oppia/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oppia/oppia/labels{/name}","releases_url":"https://api.github.com/repos/oppia/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/oppia/oppia/deployments","created_at":"2015-08-14T00:16:14Z","updated_at":"2018-02-06T11:30:55Z","pushed_at":"2018-02-06T17:03:38Z","git_url":"git://github.com/oppia/oppia.git","ssh_url":"git@github.com:oppia/oppia.git","clone_url":"https://github.com/oppia/oppia.git","svn_url":"https://github.com/oppia/oppia","homepage":"https://www.oppia.org","size":99529,"stargazers_count":538,"watchers_count":538,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":571,"mirror_url":null,"archived":false,"open_issues_count":339,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":571,"open_issues":339,"watchers":538,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/4659"},"html":{"href":"https://github.com/oppia/oppia/pull/4659"},"issue":{"href":"https://api.github.com/repos/oppia/oppia/issues/4659"},"comments":{"href":"https://api.github.com/repos/oppia/oppia/issues/4659/comments"},"review_comments":{"href":"https://api.github.com/repos/oppia/oppia/pulls/4659/comments"},"review_comment":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oppia/oppia/pulls/4659/commits"},"statuses":{"href":"https://api.github.com/repos/oppia/oppia/statuses/615f15ab6ccc55126f35e1a98f4d0080b8fa2f9c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tjiang11"}}