{"action":"created","comment":{"url":"https://api.github.com/repos/EOSIO/eos/pulls/comments/233121932","pull_request_review_id":174463538,"id":233121932,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzEyMTkzMg==","diff_hunk":"@@ -495,6 +495,7 @@ void chain_plugin::plugin_initialize(const variables_map& options) {\n                fc::copy( backup_dir / config::reversible_blocks_dir_name / \"shared_memory.meta\",\n                          my->chain_config->blocks_dir / config::reversible_blocks_dir_name / \"shared_memory.meta\" );\n             }\n+          fc::remove_all( backup_dir ); // Replay complete, delete the unuseful backup_dir.","path":"plugins/chain_plugin/chain_plugin.cpp","position":4,"original_position":4,"commit_id":"420dbbf33faf09b33a10abb5d1a685a8c50eaf04","original_commit_id":"420dbbf33faf09b33a10abb5d1a685a8c50eaf04","user":{"login":"wanderingbort","id":2494946,"node_id":"MDQ6VXNlcjI0OTQ5NDY=","avatar_url":"https://avatars0.githubusercontent.com/u/2494946?v=4","gravatar_id":"","url":"https://api.github.com/users/wanderingbort","html_url":"https://github.com/wanderingbort","followers_url":"https://api.github.com/users/wanderingbort/followers","following_url":"https://api.github.com/users/wanderingbort/following{/other_user}","gists_url":"https://api.github.com/users/wanderingbort/gists{/gist_id}","starred_url":"https://api.github.com/users/wanderingbort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wanderingbort/subscriptions","organizations_url":"https://api.github.com/users/wanderingbort/orgs","repos_url":"https://api.github.com/users/wanderingbort/repos","events_url":"https://api.github.com/users/wanderingbort/events{/privacy}","received_events_url":"https://api.github.com/users/wanderingbort/received_events","type":"User","site_admin":false},"body":"The actual replay doesn't happen until later.  What has happened by this point is `block_log::repair_log` and `recover_reversible_blocks`.  The comment is erroneous. \r\n\r\nI agree with @heifner  that the backups have value and can be cleaned up out-of-process.  That said, I would entertain a CLI option that prevents the backup from persisting after the process.","created_at":"2018-11-13T16:32:43Z","updated_at":"2018-11-13T16:32:43Z","html_url":"https://github.com/EOSIO/eos/pull/6197#discussion_r233121932","pull_request_url":"https://api.github.com/repos/EOSIO/eos/pulls/6197","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/EOSIO/eos/pulls/comments/233121932"},"html":{"href":"https://github.com/EOSIO/eos/pull/6197#discussion_r233121932"},"pull_request":{"href":"https://api.github.com/repos/EOSIO/eos/pulls/6197"}},"in_reply_to_id":230102810},"pull_request":{"url":"https://api.github.com/repos/EOSIO/eos/pulls/6197","id":227262782,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MjYyNzgy","html_url":"https://github.com/EOSIO/eos/pull/6197","diff_url":"https://github.com/EOSIO/eos/pull/6197.diff","patch_url":"https://github.com/EOSIO/eos/pull/6197.patch","issue_url":"https://api.github.com/repos/EOSIO/eos/issues/6197","number":6197,"state":"open","locked":false,"title":"Replay complete, delete the unuseful backup dir.","user":{"login":"evsward","id":2832508,"node_id":"MDQ6VXNlcjI4MzI1MDg=","avatar_url":"https://avatars0.githubusercontent.com/u/2832508?v=4","gravatar_id":"","url":"https://api.github.com/users/evsward","html_url":"https://github.com/evsward","followers_url":"https://api.github.com/users/evsward/followers","following_url":"https://api.github.com/users/evsward/following{/other_user}","gists_url":"https://api.github.com/users/evsward/gists{/gist_id}","starred_url":"https://api.github.com/users/evsward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evsward/subscriptions","organizations_url":"https://api.github.com/users/evsward/orgs","repos_url":"https://api.github.com/users/evsward/repos","events_url":"https://api.github.com/users/evsward/events{/privacy}","received_events_url":"https://api.github.com/users/evsward/received_events","type":"User","site_admin":false},"body":"## delete backup dir after replay\r\n\r\n**change**\r\nAdd oneline code after replay complete.\r\n```\r\nfc::remove_all(backup_dir)\r\n```\r\n\r\n**two reasons for change:**\r\n- The old 'backup_dir' data is wasting of space. \r\n- The operator just want recover the 'blocks.log' as the same with the old one.  It's puzzled about the complex directory structure. \r\n\r\nRelated the space issue, maybe lead to [GH-6190](https://github.com/EOSIO/eos/issues/6190)\r\n\r\n**potential impact**\r\nIf this PR was merged, I think there's no impact to the current blockchain.  Because the  old 'backup_dir' data is recovered into the real 'blocks.log'.\r\n\r\n","created_at":"2018-10-31T12:14:31Z","updated_at":"2018-11-13T16:32:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"752a2311d5946b3f6365d5beb9e9d0efb58aef85","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/EOSIO/eos/pulls/6197/commits","review_comments_url":"https://api.github.com/repos/EOSIO/eos/pulls/6197/comments","review_comment_url":"https://api.github.com/repos/EOSIO/eos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EOSIO/eos/issues/6197/comments","statuses_url":"https://api.github.com/repos/EOSIO/eos/statuses/420dbbf33faf09b33a10abb5d1a685a8c50eaf04","head":{"label":"evsward:lwb-work","ref":"lwb-work","sha":"420dbbf33faf09b33a10abb5d1a685a8c50eaf04","user":{"login":"evsward","id":2832508,"node_id":"MDQ6VXNlcjI4MzI1MDg=","avatar_url":"https://avatars0.githubusercontent.com/u/2832508?v=4","gravatar_id":"","url":"https://api.github.com/users/evsward","html_url":"https://github.com/evsward","followers_url":"https://api.github.com/users/evsward/followers","following_url":"https://api.github.com/users/evsward/following{/other_user}","gists_url":"https://api.github.com/users/evsward/gists{/gist_id}","starred_url":"https://api.github.com/users/evsward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evsward/subscriptions","organizations_url":"https://api.github.com/users/evsward/orgs","repos_url":"https://api.github.com/users/evsward/repos","events_url":"https://api.github.com/users/evsward/events{/privacy}","received_events_url":"https://api.github.com/users/evsward/received_events","type":"User","site_admin":false},"repo":{"id":143379258,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMzNzkyNTg=","name":"eos","full_name":"evsward/eos","private":false,"owner":{"login":"evsward","id":2832508,"node_id":"MDQ6VXNlcjI4MzI1MDg=","avatar_url":"https://avatars0.githubusercontent.com/u/2832508?v=4","gravatar_id":"","url":"https://api.github.com/users/evsward","html_url":"https://github.com/evsward","followers_url":"https://api.github.com/users/evsward/followers","following_url":"https://api.github.com/users/evsward/following{/other_user}","gists_url":"https://api.github.com/users/evsward/gists{/gist_id}","starred_url":"https://api.github.com/users/evsward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evsward/subscriptions","organizations_url":"https://api.github.com/users/evsward/orgs","repos_url":"https://api.github.com/users/evsward/repos","events_url":"https://api.github.com/users/evsward/events{/privacy}","received_events_url":"https://api.github.com/users/evsward/received_events","type":"User","site_admin":false},"html_url":"https://github.com/evsward/eos","description":"An open source smart contract platform ","fork":true,"url":"https://api.github.com/repos/evsward/eos","forks_url":"https://api.github.com/repos/evsward/eos/forks","keys_url":"https://api.github.com/repos/evsward/eos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evsward/eos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evsward/eos/teams","hooks_url":"https://api.github.com/repos/evsward/eos/hooks","issue_events_url":"https://api.github.com/repos/evsward/eos/issues/events{/number}","events_url":"https://api.github.com/repos/evsward/eos/events","assignees_url":"https://api.github.com/repos/evsward/eos/assignees{/user}","branches_url":"https://api.github.com/repos/evsward/eos/branches{/branch}","tags_url":"https://api.github.com/repos/evsward/eos/tags","blobs_url":"https://api.github.com/repos/evsward/eos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evsward/eos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evsward/eos/git/refs{/sha}","trees_url":"https://api.github.com/repos/evsward/eos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evsward/eos/statuses/{sha}","languages_url":"https://api.github.com/repos/evsward/eos/languages","stargazers_url":"https://api.github.com/repos/evsward/eos/stargazers","contributors_url":"https://api.github.com/repos/evsward/eos/contributors","subscribers_url":"https://api.github.com/repos/evsward/eos/subscribers","subscription_url":"https://api.github.com/repos/evsward/eos/subscription","commits_url":"https://api.github.com/repos/evsward/eos/commits{/sha}","git_commits_url":"https://api.github.com/repos/evsward/eos/git/commits{/sha}","comments_url":"https://api.github.com/repos/evsward/eos/comments{/number}","issue_comment_url":"https://api.github.com/repos/evsward/eos/issues/comments{/number}","contents_url":"https://api.github.com/repos/evsward/eos/contents/{+path}","compare_url":"https://api.github.com/repos/evsward/eos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evsward/eos/merges","archive_url":"https://api.github.com/repos/evsward/eos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evsward/eos/downloads","issues_url":"https://api.github.com/repos/evsward/eos/issues{/number}","pulls_url":"https://api.github.com/repos/evsward/eos/pulls{/number}","milestones_url":"https://api.github.com/repos/evsward/eos/milestones{/number}","notifications_url":"https://api.github.com/repos/evsward/eos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evsward/eos/labels{/name}","releases_url":"https://api.github.com/repos/evsward/eos/releases{/id}","deployments_url":"https://api.github.com/repos/evsward/eos/deployments","created_at":"2018-08-03T04:51:47Z","updated_at":"2018-10-31T11:50:42Z","pushed_at":"2018-11-10T07:23:56Z","git_url":"git://github.com/evsward/eos.git","ssh_url":"git@github.com:evsward/eos.git","clone_url":"https://github.com/evsward/eos.git","svn_url":"https://github.com/evsward/eos","homepage":"https://github.com/EOSIO/eos","size":112062,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"EOSIO:develop","ref":"develop","sha":"463f109c015db8b52faa4ecfebb34a8eacb870aa","user":{"login":"EOSIO","id":26932212,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2OTMyMjEy","avatar_url":"https://avatars2.githubusercontent.com/u/26932212?v=4","gravatar_id":"","url":"https://api.github.com/users/EOSIO","html_url":"https://github.com/EOSIO","followers_url":"https://api.github.com/users/EOSIO/followers","following_url":"https://api.github.com/users/EOSIO/following{/other_user}","gists_url":"https://api.github.com/users/EOSIO/gists{/gist_id}","starred_url":"https://api.github.com/users/EOSIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EOSIO/subscriptions","organizations_url":"https://api.github.com/users/EOSIO/orgs","repos_url":"https://api.github.com/users/EOSIO/repos","events_url":"https://api.github.com/users/EOSIO/events{/privacy}","received_events_url":"https://api.github.com/users/EOSIO/received_events","type":"Organization","site_admin":false},"repo":{"id":87335980,"node_id":"MDEwOlJlcG9zaXRvcnk4NzMzNTk4MA==","name":"eos","full_name":"EOSIO/eos","private":false,"owner":{"login":"EOSIO","id":26932212,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2OTMyMjEy","avatar_url":"https://avatars2.githubusercontent.com/u/26932212?v=4","gravatar_id":"","url":"https://api.github.com/users/EOSIO","html_url":"https://github.com/EOSIO","followers_url":"https://api.github.com/users/EOSIO/followers","following_url":"https://api.github.com/users/EOSIO/following{/other_user}","gists_url":"https://api.github.com/users/EOSIO/gists{/gist_id}","starred_url":"https://api.github.com/users/EOSIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EOSIO/subscriptions","organizations_url":"https://api.github.com/users/EOSIO/orgs","repos_url":"https://api.github.com/users/EOSIO/repos","events_url":"https://api.github.com/users/EOSIO/events{/privacy}","received_events_url":"https://api.github.com/users/EOSIO/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/EOSIO/eos","description":"An open source smart contract platform ","fork":false,"url":"https://api.github.com/repos/EOSIO/eos","forks_url":"https://api.github.com/repos/EOSIO/eos/forks","keys_url":"https://api.github.com/repos/EOSIO/eos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EOSIO/eos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EOSIO/eos/teams","hooks_url":"https://api.github.com/repos/EOSIO/eos/hooks","issue_events_url":"https://api.github.com/repos/EOSIO/eos/issues/events{/number}","events_url":"https://api.github.com/repos/EOSIO/eos/events","assignees_url":"https://api.github.com/repos/EOSIO/eos/assignees{/user}","branches_url":"https://api.github.com/repos/EOSIO/eos/branches{/branch}","tags_url":"https://api.github.com/repos/EOSIO/eos/tags","blobs_url":"https://api.github.com/repos/EOSIO/eos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EOSIO/eos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EOSIO/eos/git/refs{/sha}","trees_url":"https://api.github.com/repos/EOSIO/eos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EOSIO/eos/statuses/{sha}","languages_url":"https://api.github.com/repos/EOSIO/eos/languages","stargazers_url":"https://api.github.com/repos/EOSIO/eos/stargazers","contributors_url":"https://api.github.com/repos/EOSIO/eos/contributors","subscribers_url":"https://api.github.com/repos/EOSIO/eos/subscribers","subscription_url":"https://api.github.com/repos/EOSIO/eos/subscription","commits_url":"https://api.github.com/repos/EOSIO/eos/commits{/sha}","git_commits_url":"https://api.github.com/repos/EOSIO/eos/git/commits{/sha}","comments_url":"https://api.github.com/repos/EOSIO/eos/comments{/number}","issue_comment_url":"https://api.github.com/repos/EOSIO/eos/issues/comments{/number}","contents_url":"https://api.github.com/repos/EOSIO/eos/contents/{+path}","compare_url":"https://api.github.com/repos/EOSIO/eos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EOSIO/eos/merges","archive_url":"https://api.github.com/repos/EOSIO/eos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EOSIO/eos/downloads","issues_url":"https://api.github.com/repos/EOSIO/eos/issues{/number}","pulls_url":"https://api.github.com/repos/EOSIO/eos/pulls{/number}","milestones_url":"https://api.github.com/repos/EOSIO/eos/milestones{/number}","notifications_url":"https://api.github.com/repos/EOSIO/eos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EOSIO/eos/labels{/name}","releases_url":"https://api.github.com/repos/EOSIO/eos/releases{/id}","deployments_url":"https://api.github.com/repos/EOSIO/eos/deployments","created_at":"2017-04-05T17:09:53Z","updated_at":"2018-11-13T16:22:14Z","pushed_at":"2018-11-13T14:09:47Z","git_url":"git://github.com/EOSIO/eos.git","ssh_url":"git@github.com:EOSIO/eos.git","clone_url":"https://github.com/EOSIO/eos.git","svn_url":"https://github.com/EOSIO/eos","homepage":"https://developers.eos.io/","size":112652,"stargazers_count":9701,"watchers_count":9701,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2902,"mirror_url":null,"archived":false,"open_issues_count":296,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2902,"open_issues":296,"watchers":9701,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EOSIO/eos/pulls/6197"},"html":{"href":"https://github.com/EOSIO/eos/pull/6197"},"issue":{"href":"https://api.github.com/repos/EOSIO/eos/issues/6197"},"comments":{"href":"https://api.github.com/repos/EOSIO/eos/issues/6197/comments"},"review_comments":{"href":"https://api.github.com/repos/EOSIO/eos/pulls/6197/comments"},"review_comment":{"href":"https://api.github.com/repos/EOSIO/eos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EOSIO/eos/pulls/6197/commits"},"statuses":{"href":"https://api.github.com/repos/EOSIO/eos/statuses/420dbbf33faf09b33a10abb5d1a685a8c50eaf04"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"wanderingbort"}}