{"action":"created","comment":{"url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/pulls/comments/201993761","pull_request_review_id":136600428,"id":201993761,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTk5Mzc2MQ==","diff_hunk":"@@ -2,25 +2,20 @@\n \n $toolsDir = \"$(Split-Path -parent $MyInvocation.MyCommand.Definition)\"\n \n-$fileName = if ((Get-OSArchitectureWidth 64) -and ($env:chocolateyForceX86 -ne 'true')) {\n-  Write-Host \"Installing 64 bit version\" ; 'qbittorrent_4.1.1_x64_setup.exe' # 64-bit\n-} else {\n-  Write-Host \"Installing 32 bit version\" ; 'qbittorrent_4.1.1_setup.exe' # 32-bit\n-}\n-\n $packageArgs = @{\n   packageName    = 'qbittorrent'\n   fileType       = 'exe'\n   softwareName   = 'qBittorrent*'\n-  file           = \"$toolsDir\\$fileName\"\n+  file           = \"$toolsDir\\qbittorrent_4.1.1_setup.exe\"\n+  file64         = \"$toolsDir\\qbittorrent_4.1.1_x64_setup.exe\"\n   silentArgs     = '/S'\n   validExitCodes = @(0, 1223)\n }\n \n Install-ChocolateyInstallPackage @packageArgs\n \n # Lets remove the installer as there is no more need for it\n-Remove-Item -Force \"$toolsDir\\*.exe\",\"$toolsDir\\*.exe.ignore\" -ea 0\n+Get-ChildItem $toolsDir\\*.exe | ForEach-Object { Remove-Item $_ -ea 0; if (Test-Path $_) { Set-Content \"$_.ignore\" '' } }","path":"automatic/qbittorrent/tools/chocolateyinstall.ps1","position":25,"original_position":25,"commit_id":"5ce9d215c4577ac9062111da6ccdcf0bc2e3cc82","original_commit_id":"5ce9d215c4577ac9062111da6ccdcf0bc2e3cc82","user":{"login":"wget","id":2997662,"node_id":"MDQ6VXNlcjI5OTc2NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/2997662?v=4","gravatar_id":"","url":"https://api.github.com/users/wget","html_url":"https://github.com/wget","followers_url":"https://api.github.com/users/wget/followers","following_url":"https://api.github.com/users/wget/following{/other_user}","gists_url":"https://api.github.com/users/wget/gists{/gist_id}","starred_url":"https://api.github.com/users/wget/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wget/subscriptions","organizations_url":"https://api.github.com/users/wget/orgs","repos_url":"https://api.github.com/users/wget/repos","events_url":"https://api.github.com/users/wget/events{/privacy}","received_events_url":"https://api.github.com/users/wget/received_events","type":"User","site_admin":false},"body":"Sure, but I find it more easier to read the code when the cmdlets are expanded. A personal matter of choice :)","created_at":"2018-07-12T10:59:58Z","updated_at":"2018-07-12T10:59:58Z","html_url":"https://github.com/chocolatey/chocolatey-coreteampackages/pull/1073#discussion_r201993761","pull_request_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/pulls/1073","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/pulls/comments/201993761"},"html":{"href":"https://github.com/chocolatey/chocolatey-coreteampackages/pull/1073#discussion_r201993761"},"pull_request":{"href":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/pulls/1073"}},"in_reply_to_id":201971273},"pull_request":{"url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/pulls/1073","id":200929479,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwOTI5NDc5","html_url":"https://github.com/chocolatey/chocolatey-coreteampackages/pull/1073","diff_url":"https://github.com/chocolatey/chocolatey-coreteampackages/pull/1073.diff","patch_url":"https://github.com/chocolatey/chocolatey-coreteampackages/pull/1073.patch","issue_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/issues/1073","number":1073,"state":"open","locked":false,"title":"Clean qbittorrent package to respect convention","user":{"login":"wget","id":2997662,"node_id":"MDQ6VXNlcjI5OTc2NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/2997662?v=4","gravatar_id":"","url":"https://api.github.com/users/wget","html_url":"https://github.com/wget","followers_url":"https://api.github.com/users/wget/followers","following_url":"https://api.github.com/users/wget/following{/other_user}","gists_url":"https://api.github.com/users/wget/gists{/gist_id}","starred_url":"https://api.github.com/users/wget/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wget/subscriptions","organizations_url":"https://api.github.com/users/wget/orgs","repos_url":"https://api.github.com/users/wget/repos","events_url":"https://api.github.com/users/wget/events{/privacy}","received_events_url":"https://api.github.com/users/wget/received_events","type":"User","site_admin":false},"body":"## Description\r\nThis package is often cited as an example of good package. However, the way installation and update process was made was outdated. The architecture bitness was still detected manually, while Chocolatey+AU could do it via the `file` and `file64` statements.\r\n\r\nWe removed a bunch of unneeded stuff and cleaned the package to respect convention (legal file path, no semi colon, etc.)\r\n\r\n## Motivation and Context\r\nCleaning and avoid new comers to make issues when they check this package showcased as example.\r\n\r\n## How Has this Been Tested?\r\nNot tested. Waiting for CI build to complete.\r\n\r\n## Screenshot (if appropriate, usually isn't needed):\r\n\r\n## Types of changes\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n- [ ] Migrated package (a package has been migrated from another repository)\r\n\r\n## Checklist:\r\n- [x] My code follows the code style of this repository.\r\n- [ ] My change requires a change to documentation (this usually means the notes in the description of a package).\r\n- [ ] I have updated the documentation accordingly (this usually means the notes in the description of a package).\r\n- [x] All files are up to date with the latest [Contributing Guidelines](https://github.com/chocolatey/chocolatey-coreteampackages/blob/master/CONTRIBUTING.md)\r\n- [ ] The added/modified package passed install/uninstall in the chocolatey test environment.\r\n- [x] The changes only affect a single package (not including meta package).","created_at":"2018-07-12T08:49:20Z","updated_at":"2018-07-12T10:59:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7aa53a8d1758d79b623a929d59e53a1dd07dda55","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/pulls/1073/commits","review_comments_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/pulls/1073/comments","review_comment_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/issues/1073/comments","statuses_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/statuses/5ce9d215c4577ac9062111da6ccdcf0bc2e3cc82","head":{"label":"wget:qbittorrent-fix","ref":"qbittorrent-fix","sha":"5ce9d215c4577ac9062111da6ccdcf0bc2e3cc82","user":{"login":"wget","id":2997662,"node_id":"MDQ6VXNlcjI5OTc2NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/2997662?v=4","gravatar_id":"","url":"https://api.github.com/users/wget","html_url":"https://github.com/wget","followers_url":"https://api.github.com/users/wget/followers","following_url":"https://api.github.com/users/wget/following{/other_user}","gists_url":"https://api.github.com/users/wget/gists{/gist_id}","starred_url":"https://api.github.com/users/wget/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wget/subscriptions","organizations_url":"https://api.github.com/users/wget/orgs","repos_url":"https://api.github.com/users/wget/repos","events_url":"https://api.github.com/users/wget/events{/privacy}","received_events_url":"https://api.github.com/users/wget/received_events","type":"User","site_admin":false},"repo":{"id":72382417,"node_id":"MDEwOlJlcG9zaXRvcnk3MjM4MjQxNw==","name":"chocolatey-coreteampackages","full_name":"wget/chocolatey-coreteampackages","owner":{"login":"wget","id":2997662,"node_id":"MDQ6VXNlcjI5OTc2NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/2997662?v=4","gravatar_id":"","url":"https://api.github.com/users/wget","html_url":"https://github.com/wget","followers_url":"https://api.github.com/users/wget/followers","following_url":"https://api.github.com/users/wget/following{/other_user}","gists_url":"https://api.github.com/users/wget/gists{/gist_id}","starred_url":"https://api.github.com/users/wget/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wget/subscriptions","organizations_url":"https://api.github.com/users/wget/orgs","repos_url":"https://api.github.com/users/wget/repos","events_url":"https://api.github.com/users/wget/events{/privacy}","received_events_url":"https://api.github.com/users/wget/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wget/chocolatey-coreteampackages","description":"These packages that are managed by the chocolatey core team. To get a package added here, the official chocolatey account needs to have push access to the package on chocolatey.org.","fork":true,"url":"https://api.github.com/repos/wget/chocolatey-coreteampackages","forks_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/forks","keys_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/teams","hooks_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/hooks","issue_events_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/issues/events{/number}","events_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/events","assignees_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/assignees{/user}","branches_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/branches{/branch}","tags_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/tags","blobs_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/git/refs{/sha}","trees_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/statuses/{sha}","languages_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/languages","stargazers_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/stargazers","contributors_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/contributors","subscribers_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/subscribers","subscription_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/subscription","commits_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/commits{/sha}","git_commits_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/git/commits{/sha}","comments_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/comments{/number}","issue_comment_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/issues/comments{/number}","contents_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/contents/{+path}","compare_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/merges","archive_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/downloads","issues_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/issues{/number}","pulls_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/pulls{/number}","milestones_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/milestones{/number}","notifications_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/labels{/name}","releases_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/releases{/id}","deployments_url":"https://api.github.com/repos/wget/chocolatey-coreteampackages/deployments","created_at":"2016-10-30T23:40:42Z","updated_at":"2018-05-21T20:37:01Z","pushed_at":"2018-07-12T09:35:41Z","git_url":"git://github.com/wget/chocolatey-coreteampackages.git","ssh_url":"git@github.com:wget/chocolatey-coreteampackages.git","clone_url":"https://github.com/wget/chocolatey-coreteampackages.git","svn_url":"https://github.com/wget/chocolatey-coreteampackages","homepage":"http://chocolatey.org/profiles/chocolatey","size":76807,"stargazers_count":0,"watchers_count":0,"language":"PowerShell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chocolatey:master","ref":"master","sha":"1b4b147c1a5ef78713b3694d6a8a2172f7d87fb9","user":{"login":"chocolatey","id":811025,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxMTAyNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/811025?v=4","gravatar_id":"","url":"https://api.github.com/users/chocolatey","html_url":"https://github.com/chocolatey","followers_url":"https://api.github.com/users/chocolatey/followers","following_url":"https://api.github.com/users/chocolatey/following{/other_user}","gists_url":"https://api.github.com/users/chocolatey/gists{/gist_id}","starred_url":"https://api.github.com/users/chocolatey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chocolatey/subscriptions","organizations_url":"https://api.github.com/users/chocolatey/orgs","repos_url":"https://api.github.com/users/chocolatey/repos","events_url":"https://api.github.com/users/chocolatey/events{/privacy}","received_events_url":"https://api.github.com/users/chocolatey/received_events","type":"Organization","site_admin":false},"repo":{"id":8542523,"node_id":"MDEwOlJlcG9zaXRvcnk4NTQyNTIz","name":"chocolatey-coreteampackages","full_name":"chocolatey/chocolatey-coreteampackages","owner":{"login":"chocolatey","id":811025,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxMTAyNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/811025?v=4","gravatar_id":"","url":"https://api.github.com/users/chocolatey","html_url":"https://github.com/chocolatey","followers_url":"https://api.github.com/users/chocolatey/followers","following_url":"https://api.github.com/users/chocolatey/following{/other_user}","gists_url":"https://api.github.com/users/chocolatey/gists{/gist_id}","starred_url":"https://api.github.com/users/chocolatey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chocolatey/subscriptions","organizations_url":"https://api.github.com/users/chocolatey/orgs","repos_url":"https://api.github.com/users/chocolatey/repos","events_url":"https://api.github.com/users/chocolatey/events{/privacy}","received_events_url":"https://api.github.com/users/chocolatey/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chocolatey/chocolatey-coreteampackages","description":"Chocolatey Core Community Maintainers Team Packages - packages that are managed and maintained by core community team for community package repository (https://chocolatey.org/packages)","fork":false,"url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages","forks_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/forks","keys_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/teams","hooks_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/hooks","issue_events_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/issues/events{/number}","events_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/events","assignees_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/assignees{/user}","branches_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/branches{/branch}","tags_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/tags","blobs_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/git/refs{/sha}","trees_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/statuses/{sha}","languages_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/languages","stargazers_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/stargazers","contributors_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/contributors","subscribers_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/subscribers","subscription_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/subscription","commits_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/commits{/sha}","git_commits_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/git/commits{/sha}","comments_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/comments{/number}","issue_comment_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/issues/comments{/number}","contents_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/contents/{+path}","compare_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/merges","archive_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/downloads","issues_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/issues{/number}","pulls_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/pulls{/number}","milestones_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/milestones{/number}","notifications_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/labels{/name}","releases_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/releases{/id}","deployments_url":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/deployments","created_at":"2013-03-03T21:00:44Z","updated_at":"2018-07-12T08:27:51Z","pushed_at":"2018-07-12T09:35:42Z","git_url":"git://github.com/chocolatey/chocolatey-coreteampackages.git","ssh_url":"git@github.com:chocolatey/chocolatey-coreteampackages.git","clone_url":"https://github.com/chocolatey/chocolatey-coreteampackages.git","svn_url":"https://github.com/chocolatey/chocolatey-coreteampackages","homepage":"http://chocolatey.org/profiles/chocolatey","size":68384,"stargazers_count":127,"watchers_count":127,"language":"PowerShell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":139,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":139,"open_issues":20,"watchers":127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/pulls/1073"},"html":{"href":"https://github.com/chocolatey/chocolatey-coreteampackages/pull/1073"},"issue":{"href":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/issues/1073"},"comments":{"href":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/issues/1073/comments"},"review_comments":{"href":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/pulls/1073/comments"},"review_comment":{"href":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/pulls/1073/commits"},"statuses":{"href":"https://api.github.com/repos/chocolatey/chocolatey-coreteampackages/statuses/5ce9d215c4577ac9062111da6ccdcf0bc2e3cc82"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"wget"}}