{"action":"closed","number":51,"pull_request":{"url":"https://api.github.com/repos/danailbd/gpii-app/pulls/51","id":224631142,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NjMxMTQy","html_url":"https://github.com/danailbd/gpii-app/pull/51","diff_url":"https://github.com/danailbd/gpii-app/pull/51.diff","patch_url":"https://github.com/danailbd/gpii-app/pull/51.patch","issue_url":"https://api.github.com/repos/danailbd/gpii-app/issues/51","number":51,"state":"closed","locked":false,"title":"GPII-3446: Renderer coverage","user":{"login":"danailbd","id":3736954,"node_id":"MDQ6VXNlcjM3MzY5NTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3736954?v=4","gravatar_id":"","url":"https://api.github.com/users/danailbd","html_url":"https://github.com/danailbd","followers_url":"https://api.github.com/users/danailbd/followers","following_url":"https://api.github.com/users/danailbd/following{/other_user}","gists_url":"https://api.github.com/users/danailbd/gists{/gist_id}","starred_url":"https://api.github.com/users/danailbd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danailbd/subscriptions","organizations_url":"https://api.github.com/users/danailbd/orgs","repos_url":"https://api.github.com/users/danailbd/repos","events_url":"https://api.github.com/users/danailbd/events{/privacy}","received_events_url":"https://api.github.com/users/danailbd/received_events","type":"User","site_admin":false},"body":"Introduces coverage data for renderer processes generated from the\r\nexecution of the \"main process\" integration tests as we have tests that directly interact with the renderer processes. In other words this\r\nregisters end-to-end tests coverage.\r\n\r\n### How it is done:\r\n- Run coverage server (gpii.testem.coverage.express) that will be collecting the renderer's coverage data\r\n- Ensure all BrowserWindows are loading instrumented code to introduce coverage collecting in the renderer processes' code\r\n- Ensure dialogs (BrowserWindows) are not destroyed before their coverage is collected\r\n    - currently the only dialogs that are being destroyed are the `closable` dialogs and we simply prevent\r\n    their destruction for until their coverage is collected which is done at the end of a test sequence;\r\n    - this is done by disabling both their mechanism for getting destroyed by being closed and getting destroyed with their wrapping component destruction;\r\n    - Note that we don't destroy every dialog in the final step but only the ones that are `closable` and have their wrapping component destroyed. This is so as these components might be used in some post test sequence code execution;\r\n- Collect coverage data from BrowserWindows after every test sequence and destroy postponed dialogs\r\n    - this is needed as we need to collect coverage data before the BrowserWindows are destructed;\r\n    - once a test sequence has finished snippet in all running BrowserWindows is executed - this sends coverage data\r\n      to the running coverage server which stores this BrowserWindow coverage inforamtion;\r\n    - Note that single BrowserWindows type (e.g. QSS) would get multiple coverage data\r\n      reports (for every test sequence) that might test different elements of the renderer code. These coverage files are then merged by \"istanbul\" (nyc) in the final coverage report.\r\n","created_at":"2018-10-22T09:41:48Z","updated_at":"2018-11-02T08:18:51Z","closed_at":"2018-11-02T08:18:51Z","merged_at":null,"merge_commit_sha":"cf906ba3f02184caafb5b3cfba9194a48d78b1ec","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/danailbd/gpii-app/pulls/51/commits","review_comments_url":"https://api.github.com/repos/danailbd/gpii-app/pulls/51/comments","review_comment_url":"https://api.github.com/repos/danailbd/gpii-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/danailbd/gpii-app/issues/51/comments","statuses_url":"https://api.github.com/repos/danailbd/gpii-app/statuses/a146864e1a452fd1389dffd76991d672f1d67eed","head":{"label":"danailbd:GPII-3446","ref":"GPII-3446","sha":"a146864e1a452fd1389dffd76991d672f1d67eed","user":{"login":"danailbd","id":3736954,"node_id":"MDQ6VXNlcjM3MzY5NTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3736954?v=4","gravatar_id":"","url":"https://api.github.com/users/danailbd","html_url":"https://github.com/danailbd","followers_url":"https://api.github.com/users/danailbd/followers","following_url":"https://api.github.com/users/danailbd/following{/other_user}","gists_url":"https://api.github.com/users/danailbd/gists{/gist_id}","starred_url":"https://api.github.com/users/danailbd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danailbd/subscriptions","organizations_url":"https://api.github.com/users/danailbd/orgs","repos_url":"https://api.github.com/users/danailbd/repos","events_url":"https://api.github.com/users/danailbd/events{/privacy}","received_events_url":"https://api.github.com/users/danailbd/received_events","type":"User","site_admin":false},"repo":{"id":99244136,"node_id":"MDEwOlJlcG9zaXRvcnk5OTI0NDEzNg==","name":"gpii-app","full_name":"danailbd/gpii-app","private":false,"owner":{"login":"danailbd","id":3736954,"node_id":"MDQ6VXNlcjM3MzY5NTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3736954?v=4","gravatar_id":"","url":"https://api.github.com/users/danailbd","html_url":"https://github.com/danailbd","followers_url":"https://api.github.com/users/danailbd/followers","following_url":"https://api.github.com/users/danailbd/following{/other_user}","gists_url":"https://api.github.com/users/danailbd/gists{/gist_id}","starred_url":"https://api.github.com/users/danailbd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danailbd/subscriptions","organizations_url":"https://api.github.com/users/danailbd/orgs","repos_url":"https://api.github.com/users/danailbd/repos","events_url":"https://api.github.com/users/danailbd/events{/privacy}","received_events_url":"https://api.github.com/users/danailbd/received_events","type":"User","site_admin":false},"html_url":"https://github.com/danailbd/gpii-app","description":"Electron application and libraries to run the GPII as a native user space application on the desktop.","fork":true,"url":"https://api.github.com/repos/danailbd/gpii-app","forks_url":"https://api.github.com/repos/danailbd/gpii-app/forks","keys_url":"https://api.github.com/repos/danailbd/gpii-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danailbd/gpii-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danailbd/gpii-app/teams","hooks_url":"https://api.github.com/repos/danailbd/gpii-app/hooks","issue_events_url":"https://api.github.com/repos/danailbd/gpii-app/issues/events{/number}","events_url":"https://api.github.com/repos/danailbd/gpii-app/events","assignees_url":"https://api.github.com/repos/danailbd/gpii-app/assignees{/user}","branches_url":"https://api.github.com/repos/danailbd/gpii-app/branches{/branch}","tags_url":"https://api.github.com/repos/danailbd/gpii-app/tags","blobs_url":"https://api.github.com/repos/danailbd/gpii-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danailbd/gpii-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danailbd/gpii-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/danailbd/gpii-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danailbd/gpii-app/statuses/{sha}","languages_url":"https://api.github.com/repos/danailbd/gpii-app/languages","stargazers_url":"https://api.github.com/repos/danailbd/gpii-app/stargazers","contributors_url":"https://api.github.com/repos/danailbd/gpii-app/contributors","subscribers_url":"https://api.github.com/repos/danailbd/gpii-app/subscribers","subscription_url":"https://api.github.com/repos/danailbd/gpii-app/subscription","commits_url":"https://api.github.com/repos/danailbd/gpii-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/danailbd/gpii-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/danailbd/gpii-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/danailbd/gpii-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/danailbd/gpii-app/contents/{+path}","compare_url":"https://api.github.com/repos/danailbd/gpii-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danailbd/gpii-app/merges","archive_url":"https://api.github.com/repos/danailbd/gpii-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danailbd/gpii-app/downloads","issues_url":"https://api.github.com/repos/danailbd/gpii-app/issues{/number}","pulls_url":"https://api.github.com/repos/danailbd/gpii-app/pulls{/number}","milestones_url":"https://api.github.com/repos/danailbd/gpii-app/milestones{/number}","notifications_url":"https://api.github.com/repos/danailbd/gpii-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danailbd/gpii-app/labels{/name}","releases_url":"https://api.github.com/repos/danailbd/gpii-app/releases{/id}","deployments_url":"https://api.github.com/repos/danailbd/gpii-app/deployments","created_at":"2017-08-03T14:53:09Z","updated_at":"2018-05-23T11:28:44Z","pushed_at":"2018-11-01T13:33:45Z","git_url":"git://github.com/danailbd/gpii-app.git","ssh_url":"git@github.com:danailbd/gpii-app.git","clone_url":"https://github.com/danailbd/gpii-app.git","svn_url":"https://github.com/danailbd/gpii-app","homepage":null,"size":3769,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"danailbd:feature/QSS1.1","ref":"feature/QSS1.1","sha":"a5a527ec79ce55dae8110090707807c1bd5c3fc9","user":{"login":"danailbd","id":3736954,"node_id":"MDQ6VXNlcjM3MzY5NTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3736954?v=4","gravatar_id":"","url":"https://api.github.com/users/danailbd","html_url":"https://github.com/danailbd","followers_url":"https://api.github.com/users/danailbd/followers","following_url":"https://api.github.com/users/danailbd/following{/other_user}","gists_url":"https://api.github.com/users/danailbd/gists{/gist_id}","starred_url":"https://api.github.com/users/danailbd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danailbd/subscriptions","organizations_url":"https://api.github.com/users/danailbd/orgs","repos_url":"https://api.github.com/users/danailbd/repos","events_url":"https://api.github.com/users/danailbd/events{/privacy}","received_events_url":"https://api.github.com/users/danailbd/received_events","type":"User","site_admin":false},"repo":{"id":99244136,"node_id":"MDEwOlJlcG9zaXRvcnk5OTI0NDEzNg==","name":"gpii-app","full_name":"danailbd/gpii-app","private":false,"owner":{"login":"danailbd","id":3736954,"node_id":"MDQ6VXNlcjM3MzY5NTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3736954?v=4","gravatar_id":"","url":"https://api.github.com/users/danailbd","html_url":"https://github.com/danailbd","followers_url":"https://api.github.com/users/danailbd/followers","following_url":"https://api.github.com/users/danailbd/following{/other_user}","gists_url":"https://api.github.com/users/danailbd/gists{/gist_id}","starred_url":"https://api.github.com/users/danailbd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danailbd/subscriptions","organizations_url":"https://api.github.com/users/danailbd/orgs","repos_url":"https://api.github.com/users/danailbd/repos","events_url":"https://api.github.com/users/danailbd/events{/privacy}","received_events_url":"https://api.github.com/users/danailbd/received_events","type":"User","site_admin":false},"html_url":"https://github.com/danailbd/gpii-app","description":"Electron application and libraries to run the GPII as a native user space application on the desktop.","fork":true,"url":"https://api.github.com/repos/danailbd/gpii-app","forks_url":"https://api.github.com/repos/danailbd/gpii-app/forks","keys_url":"https://api.github.com/repos/danailbd/gpii-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danailbd/gpii-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danailbd/gpii-app/teams","hooks_url":"https://api.github.com/repos/danailbd/gpii-app/hooks","issue_events_url":"https://api.github.com/repos/danailbd/gpii-app/issues/events{/number}","events_url":"https://api.github.com/repos/danailbd/gpii-app/events","assignees_url":"https://api.github.com/repos/danailbd/gpii-app/assignees{/user}","branches_url":"https://api.github.com/repos/danailbd/gpii-app/branches{/branch}","tags_url":"https://api.github.com/repos/danailbd/gpii-app/tags","blobs_url":"https://api.github.com/repos/danailbd/gpii-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danailbd/gpii-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danailbd/gpii-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/danailbd/gpii-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danailbd/gpii-app/statuses/{sha}","languages_url":"https://api.github.com/repos/danailbd/gpii-app/languages","stargazers_url":"https://api.github.com/repos/danailbd/gpii-app/stargazers","contributors_url":"https://api.github.com/repos/danailbd/gpii-app/contributors","subscribers_url":"https://api.github.com/repos/danailbd/gpii-app/subscribers","subscription_url":"https://api.github.com/repos/danailbd/gpii-app/subscription","commits_url":"https://api.github.com/repos/danailbd/gpii-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/danailbd/gpii-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/danailbd/gpii-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/danailbd/gpii-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/danailbd/gpii-app/contents/{+path}","compare_url":"https://api.github.com/repos/danailbd/gpii-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danailbd/gpii-app/merges","archive_url":"https://api.github.com/repos/danailbd/gpii-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danailbd/gpii-app/downloads","issues_url":"https://api.github.com/repos/danailbd/gpii-app/issues{/number}","pulls_url":"https://api.github.com/repos/danailbd/gpii-app/pulls{/number}","milestones_url":"https://api.github.com/repos/danailbd/gpii-app/milestones{/number}","notifications_url":"https://api.github.com/repos/danailbd/gpii-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danailbd/gpii-app/labels{/name}","releases_url":"https://api.github.com/repos/danailbd/gpii-app/releases{/id}","deployments_url":"https://api.github.com/repos/danailbd/gpii-app/deployments","created_at":"2017-08-03T14:53:09Z","updated_at":"2018-05-23T11:28:44Z","pushed_at":"2018-11-01T13:33:45Z","git_url":"git://github.com/danailbd/gpii-app.git","ssh_url":"git@github.com:danailbd/gpii-app.git","clone_url":"https://github.com/danailbd/gpii-app.git","svn_url":"https://github.com/danailbd/gpii-app","homepage":null,"size":3769,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/danailbd/gpii-app/pulls/51"},"html":{"href":"https://github.com/danailbd/gpii-app/pull/51"},"issue":{"href":"https://api.github.com/repos/danailbd/gpii-app/issues/51"},"comments":{"href":"https://api.github.com/repos/danailbd/gpii-app/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/danailbd/gpii-app/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/danailbd/gpii-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/danailbd/gpii-app/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/danailbd/gpii-app/statuses/a146864e1a452fd1389dffd76991d672f1d67eed"}},"author_association":"OWNER","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":8,"review_comments":21,"maintainer_can_modify":false,"commits":7,"additions":490,"deletions":178,"changed_files":16}}
{"actor":{"display_login":"danailbd"}}