{"action":"created","issue":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/23111","repository_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/23111/labels{/name}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/23111/comments","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/23111/events","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/23111","id":301989589,"number":23111,"title":"[CR] Unhardcoded NPC destinations (using overmap locations)","user":{"login":"ZhilkinSerg","id":16213433,"avatar_url":"https://avatars0.githubusercontent.com/u/16213433?v=4","gravatar_id":"","url":"https://api.github.com/users/ZhilkinSerg","html_url":"https://github.com/ZhilkinSerg","followers_url":"https://api.github.com/users/ZhilkinSerg/followers","following_url":"https://api.github.com/users/ZhilkinSerg/following{/other_user}","gists_url":"https://api.github.com/users/ZhilkinSerg/gists{/gist_id}","starred_url":"https://api.github.com/users/ZhilkinSerg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZhilkinSerg/subscriptions","organizations_url":"https://api.github.com/users/ZhilkinSerg/orgs","repos_url":"https://api.github.com/users/ZhilkinSerg/repos","events_url":"https://api.github.com/users/ZhilkinSerg/events{/privacy}","received_events_url":"https://api.github.com/users/ZhilkinSerg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-03-03T11:06:26Z","updated_at":"2018-03-13T17:25:04Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/23111","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/23111","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/23111.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/23111.patch"},"body":"# What was changed:\r\n\r\n- NPC destination terrains for various needs are now loaded from overmap locations (`\\data\\json\\npc_destination_locations.json`)."},"comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/372748772","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/23111#issuecomment-372748772","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/23111","id":372748772,"user":{"login":"ZhilkinSerg","id":16213433,"avatar_url":"https://avatars0.githubusercontent.com/u/16213433?v=4","gravatar_id":"","url":"https://api.github.com/users/ZhilkinSerg","html_url":"https://github.com/ZhilkinSerg","followers_url":"https://api.github.com/users/ZhilkinSerg/followers","following_url":"https://api.github.com/users/ZhilkinSerg/following{/other_user}","gists_url":"https://api.github.com/users/ZhilkinSerg/gists{/gist_id}","starred_url":"https://api.github.com/users/ZhilkinSerg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZhilkinSerg/subscriptions","organizations_url":"https://api.github.com/users/ZhilkinSerg/orgs","repos_url":"https://api.github.com/users/ZhilkinSerg/repos","events_url":"https://api.github.com/users/ZhilkinSerg/events{/privacy}","received_events_url":"https://api.github.com/users/ZhilkinSerg/received_events","type":"User","site_admin":false},"created_at":"2018-03-13T17:25:04Z","updated_at":"2018-03-13T17:25:04Z","author_association":"CONTRIBUTOR","body":"> You need a definition of `int_id<overmap_location>::obj() const` and `int_id<overmap_location>::int_id(string_id<overmap_location> const&)`. See \"trap.cpp\" for examples of those functions.\r\n\r\nSomething like this, right?\r\n\r\n```CPP\r\n/** @relates string_id */\r\ntemplate<>\r\ninline bool int_id<trap>::is_valid() const\r\n{\r\n    return trap_factory.is_valid( *this );\r\n}\r\n```"}}
{"actor":{"display_login":"ZhilkinSerg"}}