{"action":"created","comment":{"url":"https://api.github.com/repos/ThreeMammals/Ocelot/pulls/comments/217525719","pull_request_review_id":155261889,"id":217525719,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzUyNTcxOQ==","diff_hunk":"@@ -42,7 +42,7 @@ public async Task Invoke(DownstreamContext context)\n             if (ServiceFabricRequest(context))\n             {\n                 var pathAndQuery = CreateServiceFabricUri(context, response);\n-                context.DownstreamRequest.AbsolutePath = pathAndQuery.path;\n+                context.DownstreamRequest.AbsolutePath = (context.DownstreamRequest.ApplicationName ?? string.Empty) + pathAndQuery.path;","path":"src/Ocelot/DownstreamUrlCreator/Middleware/DownstreamUrlCreatorMiddleware.cs","position":5,"original_position":5,"commit_id":"88f9ded23e26485ae3c81b3b98c16f5523bd8047","original_commit_id":"88f9ded23e26485ae3c81b3b98c16f5523bd8047","user":{"login":"akasexdev","id":11787920,"node_id":"MDQ6VXNlcjExNzg3OTIw","avatar_url":"https://avatars3.githubusercontent.com/u/11787920?v=4","gravatar_id":"","url":"https://api.github.com/users/akasexdev","html_url":"https://github.com/akasexdev","followers_url":"https://api.github.com/users/akasexdev/followers","following_url":"https://api.github.com/users/akasexdev/following{/other_user}","gists_url":"https://api.github.com/users/akasexdev/gists{/gist_id}","starred_url":"https://api.github.com/users/akasexdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akasexdev/subscriptions","organizations_url":"https://api.github.com/users/akasexdev/orgs","repos_url":"https://api.github.com/users/akasexdev/repos","events_url":"https://api.github.com/users/akasexdev/events{/privacy}","received_events_url":"https://api.github.com/users/akasexdev/received_events","type":"User","site_admin":false},"body":"This is essentially mean to hold \"/appname\" value so it can be added to the downstream absolute url ","created_at":"2018-09-13T20:37:01Z","updated_at":"2018-09-13T20:37:01Z","html_url":"https://github.com/ThreeMammals/Ocelot/pull/613#discussion_r217525719","pull_request_url":"https://api.github.com/repos/ThreeMammals/Ocelot/pulls/613","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ThreeMammals/Ocelot/pulls/comments/217525719"},"html":{"href":"https://github.com/ThreeMammals/Ocelot/pull/613#discussion_r217525719"},"pull_request":{"href":"https://api.github.com/repos/ThreeMammals/Ocelot/pulls/613"}},"in_reply_to_id":217465696},"pull_request":{"url":"https://api.github.com/repos/ThreeMammals/Ocelot/pulls/613","id":214735317,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NzM1MzE3","html_url":"https://github.com/ThreeMammals/Ocelot/pull/613","diff_url":"https://github.com/ThreeMammals/Ocelot/pull/613.diff","patch_url":"https://github.com/ThreeMammals/Ocelot/pull/613.patch","issue_url":"https://api.github.com/repos/ThreeMammals/Ocelot/issues/613","number":613,"state":"open","locked":false,"title":"Fixes #571. Added IDownstreamRequestBaseHostProvider to resolve actua…","user":{"login":"akasexdev","id":11787920,"node_id":"MDQ6VXNlcjExNzg3OTIw","avatar_url":"https://avatars3.githubusercontent.com/u/11787920?v=4","gravatar_id":"","url":"https://api.github.com/users/akasexdev","html_url":"https://github.com/akasexdev","followers_url":"https://api.github.com/users/akasexdev/followers","following_url":"https://api.github.com/users/akasexdev/following{/other_user}","gists_url":"https://api.github.com/users/akasexdev/gists{/gist_id}","starred_url":"https://api.github.com/users/akasexdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akasexdev/subscriptions","organizations_url":"https://api.github.com/users/akasexdev/orgs","repos_url":"https://api.github.com/users/akasexdev/repos","events_url":"https://api.github.com/users/akasexdev/events{/privacy}","received_events_url":"https://api.github.com/users/akasexdev/received_events","type":"User","site_admin":false},"body":"Added `IDownstreamRequestBaseHostProvider `to resolve actual downstream host and application name from downstream host address with sub application name in it\r\n\r\nNew Feature support path's in service discovery provider addresses\r\n\r\n## Proposed Changes\r\nThis will handle downstream hosts with sub application name in it, e.g. www.foo.com/app\r\n`DownstreamRequestBaseHostProvider `will set `DownstreamRequest.Host` value to \"www.foo.com\" and `DownstreamRequest.ApplicationName` to \"/app\".\r\n\r\n`DownstreamRequest.ApplicationName` will be later used (if set) to prefix the actual `AbsoluteUrl `of the downstream request.\r\n\r\nSo, given:\r\nDownstream route: \"/api/test\"\r\nProxy Host: \"http://localhost:5555/\"\r\nDownstream Host: \"www.foo.com/appname\"\r\nDownstream Port: 443\r\nDownstream Schema: \"https\"\r\n\r\nThe downstream request will be:\r\n`\"https://www.foo.com:443/appname/api/test\"`\r\n\r\n\r\n","created_at":"2018-09-11T19:09:20Z","updated_at":"2018-09-13T20:37:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ThreeMammals/Ocelot/pulls/613/commits","review_comments_url":"https://api.github.com/repos/ThreeMammals/Ocelot/pulls/613/comments","review_comment_url":"https://api.github.com/repos/ThreeMammals/Ocelot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ThreeMammals/Ocelot/issues/613/comments","statuses_url":"https://api.github.com/repos/ThreeMammals/Ocelot/statuses/88f9ded23e26485ae3c81b3b98c16f5523bd8047","head":{"label":"akasexdev:features/fix_iis_sub_app","ref":"features/fix_iis_sub_app","sha":"88f9ded23e26485ae3c81b3b98c16f5523bd8047","user":{"login":"akasexdev","id":11787920,"node_id":"MDQ6VXNlcjExNzg3OTIw","avatar_url":"https://avatars3.githubusercontent.com/u/11787920?v=4","gravatar_id":"","url":"https://api.github.com/users/akasexdev","html_url":"https://github.com/akasexdev","followers_url":"https://api.github.com/users/akasexdev/followers","following_url":"https://api.github.com/users/akasexdev/following{/other_user}","gists_url":"https://api.github.com/users/akasexdev/gists{/gist_id}","starred_url":"https://api.github.com/users/akasexdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akasexdev/subscriptions","organizations_url":"https://api.github.com/users/akasexdev/orgs","repos_url":"https://api.github.com/users/akasexdev/repos","events_url":"https://api.github.com/users/akasexdev/events{/privacy}","received_events_url":"https://api.github.com/users/akasexdev/received_events","type":"User","site_admin":false},"repo":{"id":141303724,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEzMDM3MjQ=","name":"Ocelot","full_name":"akasexdev/Ocelot","owner":{"login":"akasexdev","id":11787920,"node_id":"MDQ6VXNlcjExNzg3OTIw","avatar_url":"https://avatars3.githubusercontent.com/u/11787920?v=4","gravatar_id":"","url":"https://api.github.com/users/akasexdev","html_url":"https://github.com/akasexdev","followers_url":"https://api.github.com/users/akasexdev/followers","following_url":"https://api.github.com/users/akasexdev/following{/other_user}","gists_url":"https://api.github.com/users/akasexdev/gists{/gist_id}","starred_url":"https://api.github.com/users/akasexdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akasexdev/subscriptions","organizations_url":"https://api.github.com/users/akasexdev/orgs","repos_url":"https://api.github.com/users/akasexdev/repos","events_url":"https://api.github.com/users/akasexdev/events{/privacy}","received_events_url":"https://api.github.com/users/akasexdev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akasexdev/Ocelot","description":".NET core API Gateway","fork":true,"url":"https://api.github.com/repos/akasexdev/Ocelot","forks_url":"https://api.github.com/repos/akasexdev/Ocelot/forks","keys_url":"https://api.github.com/repos/akasexdev/Ocelot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akasexdev/Ocelot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akasexdev/Ocelot/teams","hooks_url":"https://api.github.com/repos/akasexdev/Ocelot/hooks","issue_events_url":"https://api.github.com/repos/akasexdev/Ocelot/issues/events{/number}","events_url":"https://api.github.com/repos/akasexdev/Ocelot/events","assignees_url":"https://api.github.com/repos/akasexdev/Ocelot/assignees{/user}","branches_url":"https://api.github.com/repos/akasexdev/Ocelot/branches{/branch}","tags_url":"https://api.github.com/repos/akasexdev/Ocelot/tags","blobs_url":"https://api.github.com/repos/akasexdev/Ocelot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akasexdev/Ocelot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akasexdev/Ocelot/git/refs{/sha}","trees_url":"https://api.github.com/repos/akasexdev/Ocelot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akasexdev/Ocelot/statuses/{sha}","languages_url":"https://api.github.com/repos/akasexdev/Ocelot/languages","stargazers_url":"https://api.github.com/repos/akasexdev/Ocelot/stargazers","contributors_url":"https://api.github.com/repos/akasexdev/Ocelot/contributors","subscribers_url":"https://api.github.com/repos/akasexdev/Ocelot/subscribers","subscription_url":"https://api.github.com/repos/akasexdev/Ocelot/subscription","commits_url":"https://api.github.com/repos/akasexdev/Ocelot/commits{/sha}","git_commits_url":"https://api.github.com/repos/akasexdev/Ocelot/git/commits{/sha}","comments_url":"https://api.github.com/repos/akasexdev/Ocelot/comments{/number}","issue_comment_url":"https://api.github.com/repos/akasexdev/Ocelot/issues/comments{/number}","contents_url":"https://api.github.com/repos/akasexdev/Ocelot/contents/{+path}","compare_url":"https://api.github.com/repos/akasexdev/Ocelot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akasexdev/Ocelot/merges","archive_url":"https://api.github.com/repos/akasexdev/Ocelot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akasexdev/Ocelot/downloads","issues_url":"https://api.github.com/repos/akasexdev/Ocelot/issues{/number}","pulls_url":"https://api.github.com/repos/akasexdev/Ocelot/pulls{/number}","milestones_url":"https://api.github.com/repos/akasexdev/Ocelot/milestones{/number}","notifications_url":"https://api.github.com/repos/akasexdev/Ocelot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akasexdev/Ocelot/labels{/name}","releases_url":"https://api.github.com/repos/akasexdev/Ocelot/releases{/id}","deployments_url":"https://api.github.com/repos/akasexdev/Ocelot/deployments","created_at":"2018-07-17T14:47:31Z","updated_at":"2018-07-17T14:47:34Z","pushed_at":"2018-09-11T19:00:13Z","git_url":"git://github.com/akasexdev/Ocelot.git","ssh_url":"git@github.com:akasexdev/Ocelot.git","clone_url":"https://github.com/akasexdev/Ocelot.git","svn_url":"https://github.com/akasexdev/Ocelot","homepage":"http://threemammals.com/ocelot","size":2878,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ThreeMammals:develop","ref":"develop","sha":"a5c1839ed770365a313a351eaa24fdc337559d55","user":{"login":"ThreeMammals","id":25903473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1OTAzNDcz","avatar_url":"https://avatars3.githubusercontent.com/u/25903473?v=4","gravatar_id":"","url":"https://api.github.com/users/ThreeMammals","html_url":"https://github.com/ThreeMammals","followers_url":"https://api.github.com/users/ThreeMammals/followers","following_url":"https://api.github.com/users/ThreeMammals/following{/other_user}","gists_url":"https://api.github.com/users/ThreeMammals/gists{/gist_id}","starred_url":"https://api.github.com/users/ThreeMammals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThreeMammals/subscriptions","organizations_url":"https://api.github.com/users/ThreeMammals/orgs","repos_url":"https://api.github.com/users/ThreeMammals/repos","events_url":"https://api.github.com/users/ThreeMammals/events{/privacy}","received_events_url":"https://api.github.com/users/ThreeMammals/received_events","type":"Organization","site_admin":false},"repo":{"id":62256097,"node_id":"MDEwOlJlcG9zaXRvcnk2MjI1NjA5Nw==","name":"Ocelot","full_name":"ThreeMammals/Ocelot","owner":{"login":"ThreeMammals","id":25903473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1OTAzNDcz","avatar_url":"https://avatars3.githubusercontent.com/u/25903473?v=4","gravatar_id":"","url":"https://api.github.com/users/ThreeMammals","html_url":"https://github.com/ThreeMammals","followers_url":"https://api.github.com/users/ThreeMammals/followers","following_url":"https://api.github.com/users/ThreeMammals/following{/other_user}","gists_url":"https://api.github.com/users/ThreeMammals/gists{/gist_id}","starred_url":"https://api.github.com/users/ThreeMammals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThreeMammals/subscriptions","organizations_url":"https://api.github.com/users/ThreeMammals/orgs","repos_url":"https://api.github.com/users/ThreeMammals/repos","events_url":"https://api.github.com/users/ThreeMammals/events{/privacy}","received_events_url":"https://api.github.com/users/ThreeMammals/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ThreeMammals/Ocelot","description":".NET core API Gateway","fork":false,"url":"https://api.github.com/repos/ThreeMammals/Ocelot","forks_url":"https://api.github.com/repos/ThreeMammals/Ocelot/forks","keys_url":"https://api.github.com/repos/ThreeMammals/Ocelot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ThreeMammals/Ocelot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ThreeMammals/Ocelot/teams","hooks_url":"https://api.github.com/repos/ThreeMammals/Ocelot/hooks","issue_events_url":"https://api.github.com/repos/ThreeMammals/Ocelot/issues/events{/number}","events_url":"https://api.github.com/repos/ThreeMammals/Ocelot/events","assignees_url":"https://api.github.com/repos/ThreeMammals/Ocelot/assignees{/user}","branches_url":"https://api.github.com/repos/ThreeMammals/Ocelot/branches{/branch}","tags_url":"https://api.github.com/repos/ThreeMammals/Ocelot/tags","blobs_url":"https://api.github.com/repos/ThreeMammals/Ocelot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ThreeMammals/Ocelot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ThreeMammals/Ocelot/git/refs{/sha}","trees_url":"https://api.github.com/repos/ThreeMammals/Ocelot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ThreeMammals/Ocelot/statuses/{sha}","languages_url":"https://api.github.com/repos/ThreeMammals/Ocelot/languages","stargazers_url":"https://api.github.com/repos/ThreeMammals/Ocelot/stargazers","contributors_url":"https://api.github.com/repos/ThreeMammals/Ocelot/contributors","subscribers_url":"https://api.github.com/repos/ThreeMammals/Ocelot/subscribers","subscription_url":"https://api.github.com/repos/ThreeMammals/Ocelot/subscription","commits_url":"https://api.github.com/repos/ThreeMammals/Ocelot/commits{/sha}","git_commits_url":"https://api.github.com/repos/ThreeMammals/Ocelot/git/commits{/sha}","comments_url":"https://api.github.com/repos/ThreeMammals/Ocelot/comments{/number}","issue_comment_url":"https://api.github.com/repos/ThreeMammals/Ocelot/issues/comments{/number}","contents_url":"https://api.github.com/repos/ThreeMammals/Ocelot/contents/{+path}","compare_url":"https://api.github.com/repos/ThreeMammals/Ocelot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ThreeMammals/Ocelot/merges","archive_url":"https://api.github.com/repos/ThreeMammals/Ocelot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ThreeMammals/Ocelot/downloads","issues_url":"https://api.github.com/repos/ThreeMammals/Ocelot/issues{/number}","pulls_url":"https://api.github.com/repos/ThreeMammals/Ocelot/pulls{/number}","milestones_url":"https://api.github.com/repos/ThreeMammals/Ocelot/milestones{/number}","notifications_url":"https://api.github.com/repos/ThreeMammals/Ocelot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ThreeMammals/Ocelot/labels{/name}","releases_url":"https://api.github.com/repos/ThreeMammals/Ocelot/releases{/id}","deployments_url":"https://api.github.com/repos/ThreeMammals/Ocelot/deployments","created_at":"2016-06-29T20:35:24Z","updated_at":"2018-09-13T14:48:18Z","pushed_at":"2018-09-13T17:42:31Z","git_url":"git://github.com/ThreeMammals/Ocelot.git","ssh_url":"git@github.com:ThreeMammals/Ocelot.git","clone_url":"https://github.com/ThreeMammals/Ocelot.git","svn_url":"https://github.com/ThreeMammals/Ocelot","homepage":"http://threemammals.com/ocelot","size":3195,"stargazers_count":2252,"watchers_count":2252,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":503,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":503,"open_issues":41,"watchers":2252,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ThreeMammals/Ocelot/pulls/613"},"html":{"href":"https://github.com/ThreeMammals/Ocelot/pull/613"},"issue":{"href":"https://api.github.com/repos/ThreeMammals/Ocelot/issues/613"},"comments":{"href":"https://api.github.com/repos/ThreeMammals/Ocelot/issues/613/comments"},"review_comments":{"href":"https://api.github.com/repos/ThreeMammals/Ocelot/pulls/613/comments"},"review_comment":{"href":"https://api.github.com/repos/ThreeMammals/Ocelot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ThreeMammals/Ocelot/pulls/613/commits"},"statuses":{"href":"https://api.github.com/repos/ThreeMammals/Ocelot/statuses/88f9ded23e26485ae3c81b3b98c16f5523bd8047"}},"author_association":"NONE"}}
{"actor":{"display_login":"akasexdev"}}