{"action":"created","comment":{"url":"https://api.github.com/repos/mapsme/omim/pulls/comments/224383354","pull_request_review_id":163732225,"id":224383354,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDM4MzM1NA==","diff_hunk":"@@ -311,7 +311,12 @@ class WorldMapGenerator\n \n   bool PushFeature(FeatureBuilder1 & fb)\n   {\n-    switch (fb.GetGeomType())\n+    auto const isIsland = fb.HasType(classif().GetTypeByPath({\"place\", \"island\"}));","path":"generator/world_map_generator.hpp","position":5,"original_position":5,"commit_id":"40e45aeb67683aca2241b0ffb3101227d04d09e1","original_commit_id":"40e45aeb67683aca2241b0ffb3101227d04d09e1","user":{"login":"tatiana-yan","id":9213190,"node_id":"MDQ6VXNlcjkyMTMxOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/9213190?v=4","gravatar_id":"","url":"https://api.github.com/users/tatiana-yan","html_url":"https://github.com/tatiana-yan","followers_url":"https://api.github.com/users/tatiana-yan/followers","following_url":"https://api.github.com/users/tatiana-yan/following{/other_user}","gists_url":"https://api.github.com/users/tatiana-yan/gists{/gist_id}","starred_url":"https://api.github.com/users/tatiana-yan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatiana-yan/subscriptions","organizations_url":"https://api.github.com/users/tatiana-yan/orgs","repos_url":"https://api.github.com/users/tatiana-yan/repos","events_url":"https://api.github.com/users/tatiana-yan/events{/privacy}","received_events_url":"https://api.github.com/users/tatiana-yan/received_events","type":"User","site_admin":false},"body":"islet не надо -- это мелкие острова, они по стилям не попадают в world\r\n\r\narchipelago пока не поняла -- они замаплены не единообразно, если проверять, то отдельной проверкой, т.к. они как раз могут быть c геометрией не типа area (например https://www.openstreetmap.org/relation/7827680 ), а могут быть типа area (например https://www.openstreetmap.org/relation/7259209 ), многие архипелаги не замаплены как архипелаг, например багамы. \r\nНесколько примеров прекрасного мапинга архипелагов из карибского бассейна:\r\nhttps://www.openstreetmap.org/relation/8066823\r\nhttps://www.openstreetmap.org/way/39890363\r\nhttps://www.openstreetmap.org/node/3237148061","created_at":"2018-10-11T09:44:06Z","updated_at":"2018-10-11T09:44:07Z","html_url":"https://github.com/mapsme/omim/pull/9635#discussion_r224383354","pull_request_url":"https://api.github.com/repos/mapsme/omim/pulls/9635","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments/224383354"},"html":{"href":"https://github.com/mapsme/omim/pull/9635#discussion_r224383354"},"pull_request":{"href":"https://api.github.com/repos/mapsme/omim/pulls/9635"}},"in_reply_to_id":224065563},"pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/9635","id":221350641,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMzUwNjQx","html_url":"https://github.com/mapsme/omim/pull/9635","diff_url":"https://github.com/mapsme/omim/pull/9635.diff","patch_url":"https://github.com/mapsme/omim/pull/9635.patch","issue_url":"https://api.github.com/repos/mapsme/omim/issues/9635","number":9635,"state":"open","locked":false,"title":"[DNM] Add islands to world","user":{"login":"tatiana-yan","id":9213190,"node_id":"MDQ6VXNlcjkyMTMxOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/9213190?v=4","gravatar_id":"","url":"https://api.github.com/users/tatiana-yan","html_url":"https://github.com/tatiana-yan","followers_url":"https://api.github.com/users/tatiana-yan/followers","following_url":"https://api.github.com/users/tatiana-yan/following{/other_user}","gists_url":"https://api.github.com/users/tatiana-yan/gists{/gist_id}","starred_url":"https://api.github.com/users/tatiana-yan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatiana-yan/subscriptions","organizations_url":"https://api.github.com/users/tatiana-yan/orgs","repos_url":"https://api.github.com/users/tatiana-yan/repos","events_url":"https://api.github.com/users/tatiana-yan/events{/privacy}","received_events_url":"https://api.github.com/users/tatiana-yan/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-09T08:33:19Z","updated_at":"2018-10-11T09:44:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0cf1eecc1221972a76185b44c580f07ae6d4371","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapsme/omim/pulls/9635/commits","review_comments_url":"https://api.github.com/repos/mapsme/omim/pulls/9635/comments","review_comment_url":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/9635/comments","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/40e45aeb67683aca2241b0ffb3101227d04d09e1","head":{"label":"tatiana-yan:add_islands_to_world","ref":"add_islands_to_world","sha":"40e45aeb67683aca2241b0ffb3101227d04d09e1","user":{"login":"tatiana-yan","id":9213190,"node_id":"MDQ6VXNlcjkyMTMxOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/9213190?v=4","gravatar_id":"","url":"https://api.github.com/users/tatiana-yan","html_url":"https://github.com/tatiana-yan","followers_url":"https://api.github.com/users/tatiana-yan/followers","following_url":"https://api.github.com/users/tatiana-yan/following{/other_user}","gists_url":"https://api.github.com/users/tatiana-yan/gists{/gist_id}","starred_url":"https://api.github.com/users/tatiana-yan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatiana-yan/subscriptions","organizations_url":"https://api.github.com/users/tatiana-yan/orgs","repos_url":"https://api.github.com/users/tatiana-yan/repos","events_url":"https://api.github.com/users/tatiana-yan/events{/privacy}","received_events_url":"https://api.github.com/users/tatiana-yan/received_events","type":"User","site_admin":false},"repo":{"id":98180090,"node_id":"MDEwOlJlcG9zaXRvcnk5ODE4MDA5MA==","name":"omim","full_name":"tatiana-yan/omim","private":false,"owner":{"login":"tatiana-yan","id":9213190,"node_id":"MDQ6VXNlcjkyMTMxOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/9213190?v=4","gravatar_id":"","url":"https://api.github.com/users/tatiana-yan","html_url":"https://github.com/tatiana-yan","followers_url":"https://api.github.com/users/tatiana-yan/followers","following_url":"https://api.github.com/users/tatiana-yan/following{/other_user}","gists_url":"https://api.github.com/users/tatiana-yan/gists{/gist_id}","starred_url":"https://api.github.com/users/tatiana-yan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatiana-yan/subscriptions","organizations_url":"https://api.github.com/users/tatiana-yan/orgs","repos_url":"https://api.github.com/users/tatiana-yan/repos","events_url":"https://api.github.com/users/tatiana-yan/events{/privacy}","received_events_url":"https://api.github.com/users/tatiana-yan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tatiana-yan/omim","description":"🗺️ MAPS.ME — Offline OpenStreetMap maps for iOS and Android","fork":true,"url":"https://api.github.com/repos/tatiana-yan/omim","forks_url":"https://api.github.com/repos/tatiana-yan/omim/forks","keys_url":"https://api.github.com/repos/tatiana-yan/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tatiana-yan/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tatiana-yan/omim/teams","hooks_url":"https://api.github.com/repos/tatiana-yan/omim/hooks","issue_events_url":"https://api.github.com/repos/tatiana-yan/omim/issues/events{/number}","events_url":"https://api.github.com/repos/tatiana-yan/omim/events","assignees_url":"https://api.github.com/repos/tatiana-yan/omim/assignees{/user}","branches_url":"https://api.github.com/repos/tatiana-yan/omim/branches{/branch}","tags_url":"https://api.github.com/repos/tatiana-yan/omim/tags","blobs_url":"https://api.github.com/repos/tatiana-yan/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tatiana-yan/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tatiana-yan/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/tatiana-yan/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tatiana-yan/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/tatiana-yan/omim/languages","stargazers_url":"https://api.github.com/repos/tatiana-yan/omim/stargazers","contributors_url":"https://api.github.com/repos/tatiana-yan/omim/contributors","subscribers_url":"https://api.github.com/repos/tatiana-yan/omim/subscribers","subscription_url":"https://api.github.com/repos/tatiana-yan/omim/subscription","commits_url":"https://api.github.com/repos/tatiana-yan/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/tatiana-yan/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/tatiana-yan/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/tatiana-yan/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/tatiana-yan/omim/contents/{+path}","compare_url":"https://api.github.com/repos/tatiana-yan/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tatiana-yan/omim/merges","archive_url":"https://api.github.com/repos/tatiana-yan/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tatiana-yan/omim/downloads","issues_url":"https://api.github.com/repos/tatiana-yan/omim/issues{/number}","pulls_url":"https://api.github.com/repos/tatiana-yan/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/tatiana-yan/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/tatiana-yan/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tatiana-yan/omim/labels{/name}","releases_url":"https://api.github.com/repos/tatiana-yan/omim/releases{/id}","deployments_url":"https://api.github.com/repos/tatiana-yan/omim/deployments","created_at":"2017-07-24T10:44:21Z","updated_at":"2018-04-27T18:53:14Z","pushed_at":"2018-10-10T15:38:17Z","git_url":"git://github.com/tatiana-yan/omim.git","ssh_url":"git@github.com:tatiana-yan/omim.git","clone_url":"https://github.com/tatiana-yan/omim.git","svn_url":"https://github.com/tatiana-yan/omim","homepage":"","size":4095898,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapsme:master","ref":"master","sha":"7eb4c7871e8d09812eae74452c5718bdd9ec797d","user":{"login":"mapsme","id":14185141,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTg1MTQx","avatar_url":"https://avatars1.githubusercontent.com/u/14185141?v=4","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"repo":{"id":42798033,"node_id":"MDEwOlJlcG9zaXRvcnk0Mjc5ODAzMw==","name":"omim","full_name":"mapsme/omim","private":false,"owner":{"login":"mapsme","id":14185141,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTg1MTQx","avatar_url":"https://avatars1.githubusercontent.com/u/14185141?v=4","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mapsme/omim","description":"🗺️ MAPS.ME — Offline OpenStreetMap maps for iOS and Android","fork":false,"url":"https://api.github.com/repos/mapsme/omim","forks_url":"https://api.github.com/repos/mapsme/omim/forks","keys_url":"https://api.github.com/repos/mapsme/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapsme/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapsme/omim/teams","hooks_url":"https://api.github.com/repos/mapsme/omim/hooks","issue_events_url":"https://api.github.com/repos/mapsme/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mapsme/omim/events","assignees_url":"https://api.github.com/repos/mapsme/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mapsme/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mapsme/omim/tags","blobs_url":"https://api.github.com/repos/mapsme/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapsme/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapsme/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapsme/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mapsme/omim/languages","stargazers_url":"https://api.github.com/repos/mapsme/omim/stargazers","contributors_url":"https://api.github.com/repos/mapsme/omim/contributors","subscribers_url":"https://api.github.com/repos/mapsme/omim/subscribers","subscription_url":"https://api.github.com/repos/mapsme/omim/subscription","commits_url":"https://api.github.com/repos/mapsme/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapsme/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapsme/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapsme/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapsme/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mapsme/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapsme/omim/merges","archive_url":"https://api.github.com/repos/mapsme/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapsme/omim/downloads","issues_url":"https://api.github.com/repos/mapsme/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mapsme/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mapsme/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mapsme/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapsme/omim/labels{/name}","releases_url":"https://api.github.com/repos/mapsme/omim/releases{/id}","deployments_url":"https://api.github.com/repos/mapsme/omim/deployments","created_at":"2015-09-20T02:57:13Z","updated_at":"2018-10-11T09:35:00Z","pushed_at":"2018-10-11T09:34:51Z","git_url":"git://github.com/mapsme/omim.git","ssh_url":"git@github.com:mapsme/omim.git","clone_url":"https://github.com/mapsme/omim.git","svn_url":"https://github.com/mapsme/omim","homepage":"","size":4129684,"stargazers_count":2815,"watchers_count":2815,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":603,"mirror_url":null,"archived":false,"open_issues_count":749,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":603,"open_issues":749,"watchers":2815,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/9635"},"html":{"href":"https://github.com/mapsme/omim/pull/9635"},"issue":{"href":"https://api.github.com/repos/mapsme/omim/issues/9635"},"comments":{"href":"https://api.github.com/repos/mapsme/omim/issues/9635/comments"},"review_comments":{"href":"https://api.github.com/repos/mapsme/omim/pulls/9635/comments"},"review_comment":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapsme/omim/pulls/9635/commits"},"statuses":{"href":"https://api.github.com/repos/mapsme/omim/statuses/40e45aeb67683aca2241b0ffb3101227d04d09e1"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"tatiana-yan"}}