{"action":"created","comment":{"url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/pulls/comments/216768100","pull_request_review_id":154328031,"id":216768100,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjc2ODEwMA==","diff_hunk":"@@ -186,18 +188,27 @@ public ImageRetrieverResults getImage(Map<String, ?> request) throws ImageAcquis\n         return results;\n     }\n     \n-    public void diagnoseConnection() throws ImageAcquisitionException{\n+    public void diagnoseConnection() throws ImageAcquisitionException {\n         try {\n-            URL urlProtocolTest = new URL((String) camera);\n-            InputStream urlReadTest = urlProtocolTest.openStream();\n-        } catch (MalformedURLException e) {\n-//            throw new IllegalArgumentException(this.getClass().getCanonicalName() + \".unknownProtocol: \"\n-//                    + \"URL specifies unknown protocol\");\n-            log.error(\".unknownProtocol: Error parsing URL: \", e);\n-            \n-        } catch (java.io.IOException e) {\n-            throw new ImageAcquisitionException(this.getClass().getCanonicalName() + \".badRead: \"\n-                    + \"URL was unable to be read\");\n+            URI URITest = new URI(camera);\n+            if (URITest.getScheme().equals(\"http\") || URITest.getScheme().equals(\"https\")) {\n+                try {\n+                  URL urlProtocolTest = new URL((String) camera);\n+                  InputStream urlReadTest = urlProtocolTest.openStream();\n+              } catch (MalformedURLException e) {\n+                  throw new IllegalArgumentException(this.getClass().getCanonicalName() + \".unknownProtocol: \"\n+                          + \"URL specifies unknown protocol, or protocol was improperly formatted\");\n+              } catch (java.io.IOException e) {\n+                  throw new ImageAcquisitionException(this.getClass().getCanonicalName() + \".badRead: \"\n+                          + \"URL was unable to be read\");\n+              }\n+            } else {\n+                throw new ImageAcquisitionException(this.getClass().getCanonicalName() + \".badRead: \"\n+                        + \"URL was unable to be read\");\n+            }\n+        } catch (URISyntaxException e) {\n+            throw new IllegalArgumentException(this.getClass().getCanonicalName() + \".unknownProtocol: \"\n+                    + \"URL specifies unknown protocol, or protocol was improperly formatted\");","path":"objectRecognitionSource/src/main/java/io/vantiq/extsrc/objectRecognition/imageRetriever/NetworkStreamRetriever.java","position":55,"original_position":55,"commit_id":"9de5ea6c28ed1d86596bb4462e4570ad1b6dc8a3","original_commit_id":"9de5ea6c28ed1d86596bb4462e4570ad1b6dc8a3","user":{"login":"fhcarter","id":27981763,"node_id":"MDQ6VXNlcjI3OTgxNzYz","avatar_url":"https://avatars3.githubusercontent.com/u/27981763?v=4","gravatar_id":"","url":"https://api.github.com/users/fhcarter","html_url":"https://github.com/fhcarter","followers_url":"https://api.github.com/users/fhcarter/followers","following_url":"https://api.github.com/users/fhcarter/following{/other_user}","gists_url":"https://api.github.com/users/fhcarter/gists{/gist_id}","starred_url":"https://api.github.com/users/fhcarter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhcarter/subscriptions","organizations_url":"https://api.github.com/users/fhcarter/orgs","repos_url":"https://api.github.com/users/fhcarter/repos","events_url":"https://api.github.com/users/fhcarter/events{/privacy}","received_events_url":"https://api.github.com/users/fhcarter/received_events","type":"User","site_admin":false},"body":"same here","created_at":"2018-09-11T18:12:51Z","updated_at":"2018-09-11T18:13:28Z","html_url":"https://github.com/Vantiq/vantiq-extension-sources/pull/62#discussion_r216768100","pull_request_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/pulls/62","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/pulls/comments/216768100"},"html":{"href":"https://github.com/Vantiq/vantiq-extension-sources/pull/62#discussion_r216768100"},"pull_request":{"href":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/pulls/62","id":214718393,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NzE4Mzkz","html_url":"https://github.com/Vantiq/vantiq-extension-sources/pull/62","diff_url":"https://github.com/Vantiq/vantiq-extension-sources/pull/62.diff","patch_url":"https://github.com/Vantiq/vantiq-extension-sources/pull/62.patch","issue_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/issues/62","number":62,"state":"open","locked":false,"title":"Diagnose Connection Fix","user":{"login":"namirfa","id":15003692,"node_id":"MDQ6VXNlcjE1MDAzNjky","avatar_url":"https://avatars0.githubusercontent.com/u/15003692?v=4","gravatar_id":"","url":"https://api.github.com/users/namirfa","html_url":"https://github.com/namirfa","followers_url":"https://api.github.com/users/namirfa/followers","following_url":"https://api.github.com/users/namirfa/following{/other_user}","gists_url":"https://api.github.com/users/namirfa/gists{/gist_id}","starred_url":"https://api.github.com/users/namirfa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/namirfa/subscriptions","organizations_url":"https://api.github.com/users/namirfa/orgs","repos_url":"https://api.github.com/users/namirfa/repos","events_url":"https://api.github.com/users/namirfa/events{/privacy}","received_events_url":"https://api.github.com/users/namirfa/received_events","type":"User","site_admin":false},"body":"Modified diagnoseConnection() method to handle RTSP as well as HTTP","created_at":"2018-09-11T18:06:49Z","updated_at":"2018-09-11T18:13:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15d48380e405455b84d3601198d0b706968eea79","assignee":null,"assignees":[],"requested_reviewers":[{"login":"AlexBlumer","id":9043537,"node_id":"MDQ6VXNlcjkwNDM1Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/9043537?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexBlumer","html_url":"https://github.com/AlexBlumer","followers_url":"https://api.github.com/users/AlexBlumer/followers","following_url":"https://api.github.com/users/AlexBlumer/following{/other_user}","gists_url":"https://api.github.com/users/AlexBlumer/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexBlumer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexBlumer/subscriptions","organizations_url":"https://api.github.com/users/AlexBlumer/orgs","repos_url":"https://api.github.com/users/AlexBlumer/repos","events_url":"https://api.github.com/users/AlexBlumer/events{/privacy}","received_events_url":"https://api.github.com/users/AlexBlumer/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/pulls/62/commits","review_comments_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/pulls/62/comments","review_comment_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/issues/62/comments","statuses_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/statuses/9de5ea6c28ed1d86596bb4462e4570ad1b6dc8a3","head":{"label":"Vantiq:naf-obj-diagnoseConnectionFix","ref":"naf-obj-diagnoseConnectionFix","sha":"9de5ea6c28ed1d86596bb4462e4570ad1b6dc8a3","user":{"login":"Vantiq","id":16842966,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODQyOTY2","avatar_url":"https://avatars3.githubusercontent.com/u/16842966?v=4","gravatar_id":"","url":"https://api.github.com/users/Vantiq","html_url":"https://github.com/Vantiq","followers_url":"https://api.github.com/users/Vantiq/followers","following_url":"https://api.github.com/users/Vantiq/following{/other_user}","gists_url":"https://api.github.com/users/Vantiq/gists{/gist_id}","starred_url":"https://api.github.com/users/Vantiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vantiq/subscriptions","organizations_url":"https://api.github.com/users/Vantiq/orgs","repos_url":"https://api.github.com/users/Vantiq/repos","events_url":"https://api.github.com/users/Vantiq/events{/privacy}","received_events_url":"https://api.github.com/users/Vantiq/received_events","type":"Organization","site_admin":false},"repo":{"id":141492069,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE0OTIwNjk=","name":"vantiq-extension-sources","full_name":"Vantiq/vantiq-extension-sources","owner":{"login":"Vantiq","id":16842966,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODQyOTY2","avatar_url":"https://avatars3.githubusercontent.com/u/16842966?v=4","gravatar_id":"","url":"https://api.github.com/users/Vantiq","html_url":"https://github.com/Vantiq","followers_url":"https://api.github.com/users/Vantiq/followers","following_url":"https://api.github.com/users/Vantiq/following{/other_user}","gists_url":"https://api.github.com/users/Vantiq/gists{/gist_id}","starred_url":"https://api.github.com/users/Vantiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vantiq/subscriptions","organizations_url":"https://api.github.com/users/Vantiq/orgs","repos_url":"https://api.github.com/users/Vantiq/repos","events_url":"https://api.github.com/users/Vantiq/events{/privacy}","received_events_url":"https://api.github.com/users/Vantiq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Vantiq/vantiq-extension-sources","description":"Contains source code for VANTIQ Extension sources as well as SDKs for building these sources.","fork":false,"url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources","forks_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/forks","keys_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/teams","hooks_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/hooks","issue_events_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/issues/events{/number}","events_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/events","assignees_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/assignees{/user}","branches_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/branches{/branch}","tags_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/tags","blobs_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/statuses/{sha}","languages_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/languages","stargazers_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/stargazers","contributors_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/contributors","subscribers_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/subscribers","subscription_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/subscription","commits_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/contents/{+path}","compare_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/merges","archive_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/downloads","issues_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/issues{/number}","pulls_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/pulls{/number}","milestones_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/milestones{/number}","notifications_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/labels{/name}","releases_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/releases{/id}","deployments_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/deployments","created_at":"2018-07-18T21:27:30Z","updated_at":"2018-09-10T23:06:53Z","pushed_at":"2018-09-11T18:06:49Z","git_url":"git://github.com/Vantiq/vantiq-extension-sources.git","ssh_url":"git@github.com:Vantiq/vantiq-extension-sources.git","clone_url":"https://github.com/Vantiq/vantiq-extension-sources.git","svn_url":"https://github.com/Vantiq/vantiq-extension-sources","homepage":null,"size":1166,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"Vantiq:master","ref":"master","sha":"d62e862796fe2260f4415fe36a89b1d920e31783","user":{"login":"Vantiq","id":16842966,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODQyOTY2","avatar_url":"https://avatars3.githubusercontent.com/u/16842966?v=4","gravatar_id":"","url":"https://api.github.com/users/Vantiq","html_url":"https://github.com/Vantiq","followers_url":"https://api.github.com/users/Vantiq/followers","following_url":"https://api.github.com/users/Vantiq/following{/other_user}","gists_url":"https://api.github.com/users/Vantiq/gists{/gist_id}","starred_url":"https://api.github.com/users/Vantiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vantiq/subscriptions","organizations_url":"https://api.github.com/users/Vantiq/orgs","repos_url":"https://api.github.com/users/Vantiq/repos","events_url":"https://api.github.com/users/Vantiq/events{/privacy}","received_events_url":"https://api.github.com/users/Vantiq/received_events","type":"Organization","site_admin":false},"repo":{"id":141492069,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE0OTIwNjk=","name":"vantiq-extension-sources","full_name":"Vantiq/vantiq-extension-sources","owner":{"login":"Vantiq","id":16842966,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODQyOTY2","avatar_url":"https://avatars3.githubusercontent.com/u/16842966?v=4","gravatar_id":"","url":"https://api.github.com/users/Vantiq","html_url":"https://github.com/Vantiq","followers_url":"https://api.github.com/users/Vantiq/followers","following_url":"https://api.github.com/users/Vantiq/following{/other_user}","gists_url":"https://api.github.com/users/Vantiq/gists{/gist_id}","starred_url":"https://api.github.com/users/Vantiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vantiq/subscriptions","organizations_url":"https://api.github.com/users/Vantiq/orgs","repos_url":"https://api.github.com/users/Vantiq/repos","events_url":"https://api.github.com/users/Vantiq/events{/privacy}","received_events_url":"https://api.github.com/users/Vantiq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Vantiq/vantiq-extension-sources","description":"Contains source code for VANTIQ Extension sources as well as SDKs for building these sources.","fork":false,"url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources","forks_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/forks","keys_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/teams","hooks_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/hooks","issue_events_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/issues/events{/number}","events_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/events","assignees_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/assignees{/user}","branches_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/branches{/branch}","tags_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/tags","blobs_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/statuses/{sha}","languages_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/languages","stargazers_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/stargazers","contributors_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/contributors","subscribers_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/subscribers","subscription_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/subscription","commits_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/contents/{+path}","compare_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/merges","archive_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/downloads","issues_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/issues{/number}","pulls_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/pulls{/number}","milestones_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/milestones{/number}","notifications_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/labels{/name}","releases_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/releases{/id}","deployments_url":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/deployments","created_at":"2018-07-18T21:27:30Z","updated_at":"2018-09-10T23:06:53Z","pushed_at":"2018-09-11T18:06:49Z","git_url":"git://github.com/Vantiq/vantiq-extension-sources.git","ssh_url":"git@github.com:Vantiq/vantiq-extension-sources.git","clone_url":"https://github.com/Vantiq/vantiq-extension-sources.git","svn_url":"https://github.com/Vantiq/vantiq-extension-sources","homepage":null,"size":1166,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/pulls/62"},"html":{"href":"https://github.com/Vantiq/vantiq-extension-sources/pull/62"},"issue":{"href":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/issues/62"},"comments":{"href":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/Vantiq/vantiq-extension-sources/statuses/9de5ea6c28ed1d86596bb4462e4570ad1b6dc8a3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fhcarter"}}