{"action":"created","issue":{"url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/2314","repository_url":"https://api.github.com/repos/buttonmen-dev/buttonmen","labels_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/2314/labels{/name}","comments_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/2314/comments","events_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/2314/events","html_url":"https://github.com/buttonmen-dev/buttonmen/pull/2314","id":285588634,"node_id":"MDExOlB1bGxSZXF1ZXN0MTYwODQwNzYz","number":2314,"title":"Implemented combo boxes for game creation","user":{"login":"blackshadowshade","id":2898401,"node_id":"MDQ6VXNlcjI4OTg0MDE=","avatar_url":"https://avatars3.githubusercontent.com/u/2898401?v=4","gravatar_id":"","url":"https://api.github.com/users/blackshadowshade","html_url":"https://github.com/blackshadowshade","followers_url":"https://api.github.com/users/blackshadowshade/followers","following_url":"https://api.github.com/users/blackshadowshade/following{/other_user}","gists_url":"https://api.github.com/users/blackshadowshade/gists{/gist_id}","starred_url":"https://api.github.com/users/blackshadowshade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackshadowshade/subscriptions","organizations_url":"https://api.github.com/users/blackshadowshade/orgs","repos_url":"https://api.github.com/users/blackshadowshade/repos","events_url":"https://api.github.com/users/blackshadowshade/events{/privacy}","received_events_url":"https://api.github.com/users/blackshadowshade/received_events","type":"User","site_admin":false},"labels":[{"id":778765248,"node_id":"MDU6TGFiZWw3Nzg3NjUyNDg=","url":"https://api.github.com/repos/buttonmen-dev/buttonmen/labels/dev%20site","name":"dev site","color":"867ee5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":40,"created_at":"2018-01-03T02:54:20Z","updated_at":"2018-08-17T02:25:50Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/2314","html_url":"https://github.com/buttonmen-dev/buttonmen/pull/2314","diff_url":"https://github.com/buttonmen-dev/buttonmen/pull/2314.diff","patch_url":"https://github.com/buttonmen-dev/buttonmen/pull/2314.patch"},"body":"Fixes #108. Fixes #1316.\r\n\r\nI'm submitting this pull request incomplete so that testers can have their say. I request that this be put up as a dev site to allow testing on various devices.\r\n\r\nBefore this pull request is accepted, I'd like:\r\n- ~~the QUnit stubs to be filled in~~\r\n- @AdmiralJota to have his say on the customisation of the CSS\r\n- functionality to be tested on various devices\r\n- ~~any potential conflicts with currently open pull requests to be resolved~~\r\n- ~~CircleCI to pass~~\r\n\r\nMany of the changes in this pull request are a generic refactoring of Newgame.actionCreateGame, which was a monolith function with 242 lines of code.\r\n\r\nI've added the external Chosen JS plugin (https://harvesthq.github.io/chosen/) which is by default disabled for iPods, iPhones, and Android devices signalling that they are mobile devices (https://github.com/harvesthq/chosen/pull/1388). We can artificially re-enable these devices, but I'm starting out with the default behaviour.\r\n  \r\n  "},"comment":{"url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/comments/413738988","html_url":"https://github.com/buttonmen-dev/buttonmen/pull/2314#issuecomment-413738988","issue_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/2314","id":413738988,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzczODk4OA==","user":{"login":"irilyth","id":4923138,"node_id":"MDQ6VXNlcjQ5MjMxMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/4923138?v=4","gravatar_id":"","url":"https://api.github.com/users/irilyth","html_url":"https://github.com/irilyth","followers_url":"https://api.github.com/users/irilyth/followers","following_url":"https://api.github.com/users/irilyth/following{/other_user}","gists_url":"https://api.github.com/users/irilyth/gists{/gist_id}","starred_url":"https://api.github.com/users/irilyth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irilyth/subscriptions","organizations_url":"https://api.github.com/users/irilyth/orgs","repos_url":"https://api.github.com/users/irilyth/repos","events_url":"https://api.github.com/users/irilyth/events{/privacy}","received_events_url":"https://api.github.com/users/irilyth/received_events","type":"User","site_admin":false},"created_at":"2018-08-17T02:25:50Z","updated_at":"2018-08-17T02:25:50Z","author_association":"NONE","body":"The other bug seems fixed now, yay.\r\n\r\nWhen you type in the box, it seems to only filter from the start of the name. Is that configurable? If I type \"bla\", it filters to blackshadowshade, but if I type \"sha\", it doesn't find anyone. If that's just the way it is, that's fine, but if there's an option to have it match anywhere in the name, I think that might be an improvement."}}
{"actor":{"display_login":"irilyth"}}