{"action":"closed","number":2881,"pull_request":{"url":"https://api.github.com/repos/iNavFlight/inav/pulls/2881","id":173128784,"html_url":"https://github.com/iNavFlight/inav/pull/2881","diff_url":"https://github.com/iNavFlight/inav/pull/2881.diff","patch_url":"https://github.com/iNavFlight/inav/pull/2881.patch","issue_url":"https://api.github.com/repos/iNavFlight/inav/issues/2881","number":2881,"state":"closed","locked":false,"title":"Save 6952 bytes of RAM","user":{"login":"fiam","id":41529,"avatar_url":"https://avatars1.githubusercontent.com/u/41529?v=4","gravatar_id":"","url":"https://api.github.com/users/fiam","html_url":"https://github.com/fiam","followers_url":"https://api.github.com/users/fiam/followers","following_url":"https://api.github.com/users/fiam/following{/other_user}","gists_url":"https://api.github.com/users/fiam/gists{/gist_id}","starred_url":"https://api.github.com/users/fiam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fiam/subscriptions","organizations_url":"https://api.github.com/users/fiam/orgs","repos_url":"https://api.github.com/users/fiam/repos","events_url":"https://api.github.com/users/fiam/events{/privacy}","received_events_url":"https://api.github.com/users/fiam/received_events","type":"User","site_admin":false},"body":"Make CMS use a separate static array for keeping track of the items that need redrawing rather than modifying each OSD_Entry_t item. This lets us move all items and most menus to flash (the SA menu uses dynamic entries, so it needs to stay in ram). Note that text increases by 6728 bytes due to these changes, but even F3 still has ~31K free.\r\n\r\nAlso, a bunch of macros have been added to CMS to make both the code cleaner and changes like this one easier. Please, try to use them in the future when adding new menus.\r\n\r\nBefore:\r\n\r\n```\r\nLinking OMNIBUS\r\narm-none-eabi-size ./obj/main/inav_OMNIBUS.elf\r\n   text\t   data\t    bss\t    dec\t    hex\tfilename\r\n 218430\t  10136\t  37900\t 266466\t  410e2\t./obj/main/inav_OMNIBUS.elf\r\n```\r\n\r\nAfter:\r\n\r\n```\r\narm-none-eabi-size ./obj/main/inav_OMNIBUS.elf\r\n   text\t   data\t    bss\t    dec\t    hex\tfilename\r\n 225158\t   3224\t  37860\t 266242\t  41002\t./obj/main/inav_OMNIBUS.elf\r\n```","created_at":"2018-03-06T11:21:03Z","updated_at":"2018-03-07T05:19:21Z","closed_at":"2018-03-07T05:19:20Z","merged_at":"2018-03-07T05:19:20Z","merge_commit_sha":"4d44954c463a89bc6ab63aab33085355ad281790","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/iNavFlight/inav/milestones/17","html_url":"https://github.com/iNavFlight/inav/milestone/17","labels_url":"https://api.github.com/repos/iNavFlight/inav/milestones/17/labels","id":3141440,"number":17,"title":"1.9.1","description":"Milestone for bugfix and small improvements that might hold the 1.9","creator":{"login":"digitalentity","id":11059099,"avatar_url":"https://avatars2.githubusercontent.com/u/11059099?v=4","gravatar_id":"","url":"https://api.github.com/users/digitalentity","html_url":"https://github.com/digitalentity","followers_url":"https://api.github.com/users/digitalentity/followers","following_url":"https://api.github.com/users/digitalentity/following{/other_user}","gists_url":"https://api.github.com/users/digitalentity/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalentity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalentity/subscriptions","organizations_url":"https://api.github.com/users/digitalentity/orgs","repos_url":"https://api.github.com/users/digitalentity/repos","events_url":"https://api.github.com/users/digitalentity/events{/privacy}","received_events_url":"https://api.github.com/users/digitalentity/received_events","type":"User","site_admin":false},"open_issues":29,"closed_issues":4,"state":"open","created_at":"2018-02-25T12:43:16Z","updated_at":"2018-03-07T05:19:21Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/iNavFlight/inav/pulls/2881/commits","review_comments_url":"https://api.github.com/repos/iNavFlight/inav/pulls/2881/comments","review_comment_url":"https://api.github.com/repos/iNavFlight/inav/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iNavFlight/inav/issues/2881/comments","statuses_url":"https://api.github.com/repos/iNavFlight/inav/statuses/26a04dcfe36a652a9e0d8f9c7970eba867a9b0d4","head":{"label":"iNavFlight:agh_make_free_ram_on_f3_great_again","ref":"agh_make_free_ram_on_f3_great_again","sha":"26a04dcfe36a652a9e0d8f9c7970eba867a9b0d4","user":{"login":"iNavFlight","id":15979895,"avatar_url":"https://avatars2.githubusercontent.com/u/15979895?v=4","gravatar_id":"","url":"https://api.github.com/users/iNavFlight","html_url":"https://github.com/iNavFlight","followers_url":"https://api.github.com/users/iNavFlight/followers","following_url":"https://api.github.com/users/iNavFlight/following{/other_user}","gists_url":"https://api.github.com/users/iNavFlight/gists{/gist_id}","starred_url":"https://api.github.com/users/iNavFlight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iNavFlight/subscriptions","organizations_url":"https://api.github.com/users/iNavFlight/orgs","repos_url":"https://api.github.com/users/iNavFlight/repos","events_url":"https://api.github.com/users/iNavFlight/events{/privacy}","received_events_url":"https://api.github.com/users/iNavFlight/received_events","type":"Organization","site_admin":false},"repo":{"id":32148604,"name":"inav","full_name":"iNavFlight/inav","owner":{"login":"iNavFlight","id":15979895,"avatar_url":"https://avatars2.githubusercontent.com/u/15979895?v=4","gravatar_id":"","url":"https://api.github.com/users/iNavFlight","html_url":"https://github.com/iNavFlight","followers_url":"https://api.github.com/users/iNavFlight/followers","following_url":"https://api.github.com/users/iNavFlight/following{/other_user}","gists_url":"https://api.github.com/users/iNavFlight/gists{/gist_id}","starred_url":"https://api.github.com/users/iNavFlight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iNavFlight/subscriptions","organizations_url":"https://api.github.com/users/iNavFlight/orgs","repos_url":"https://api.github.com/users/iNavFlight/repos","events_url":"https://api.github.com/users/iNavFlight/events{/privacy}","received_events_url":"https://api.github.com/users/iNavFlight/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iNavFlight/inav","description":"INAV: Navigation-enabled flight control software","fork":false,"url":"https://api.github.com/repos/iNavFlight/inav","forks_url":"https://api.github.com/repos/iNavFlight/inav/forks","keys_url":"https://api.github.com/repos/iNavFlight/inav/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iNavFlight/inav/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iNavFlight/inav/teams","hooks_url":"https://api.github.com/repos/iNavFlight/inav/hooks","issue_events_url":"https://api.github.com/repos/iNavFlight/inav/issues/events{/number}","events_url":"https://api.github.com/repos/iNavFlight/inav/events","assignees_url":"https://api.github.com/repos/iNavFlight/inav/assignees{/user}","branches_url":"https://api.github.com/repos/iNavFlight/inav/branches{/branch}","tags_url":"https://api.github.com/repos/iNavFlight/inav/tags","blobs_url":"https://api.github.com/repos/iNavFlight/inav/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iNavFlight/inav/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iNavFlight/inav/git/refs{/sha}","trees_url":"https://api.github.com/repos/iNavFlight/inav/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iNavFlight/inav/statuses/{sha}","languages_url":"https://api.github.com/repos/iNavFlight/inav/languages","stargazers_url":"https://api.github.com/repos/iNavFlight/inav/stargazers","contributors_url":"https://api.github.com/repos/iNavFlight/inav/contributors","subscribers_url":"https://api.github.com/repos/iNavFlight/inav/subscribers","subscription_url":"https://api.github.com/repos/iNavFlight/inav/subscription","commits_url":"https://api.github.com/repos/iNavFlight/inav/commits{/sha}","git_commits_url":"https://api.github.com/repos/iNavFlight/inav/git/commits{/sha}","comments_url":"https://api.github.com/repos/iNavFlight/inav/comments{/number}","issue_comment_url":"https://api.github.com/repos/iNavFlight/inav/issues/comments{/number}","contents_url":"https://api.github.com/repos/iNavFlight/inav/contents/{+path}","compare_url":"https://api.github.com/repos/iNavFlight/inav/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iNavFlight/inav/merges","archive_url":"https://api.github.com/repos/iNavFlight/inav/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iNavFlight/inav/downloads","issues_url":"https://api.github.com/repos/iNavFlight/inav/issues{/number}","pulls_url":"https://api.github.com/repos/iNavFlight/inav/pulls{/number}","milestones_url":"https://api.github.com/repos/iNavFlight/inav/milestones{/number}","notifications_url":"https://api.github.com/repos/iNavFlight/inav/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iNavFlight/inav/labels{/name}","releases_url":"https://api.github.com/repos/iNavFlight/inav/releases{/id}","deployments_url":"https://api.github.com/repos/iNavFlight/inav/deployments","created_at":"2015-03-13T09:58:19Z","updated_at":"2018-03-06T05:38:14Z","pushed_at":"2018-03-07T05:19:20Z","git_url":"git://github.com/iNavFlight/inav.git","ssh_url":"git@github.com:iNavFlight/inav.git","clone_url":"https://github.com/iNavFlight/inav.git","svn_url":"https://github.com/iNavFlight/inav","homepage":"https://inavflight.github.io","size":150068,"stargazers_count":473,"watchers_count":473,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":245,"mirror_url":null,"archived":false,"open_issues_count":335,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":245,"open_issues":335,"watchers":473,"default_branch":"master"}},"base":{"label":"iNavFlight:development","ref":"development","sha":"ae05b1c99357fb0d2c7226508ffb2671fcea4be5","user":{"login":"iNavFlight","id":15979895,"avatar_url":"https://avatars2.githubusercontent.com/u/15979895?v=4","gravatar_id":"","url":"https://api.github.com/users/iNavFlight","html_url":"https://github.com/iNavFlight","followers_url":"https://api.github.com/users/iNavFlight/followers","following_url":"https://api.github.com/users/iNavFlight/following{/other_user}","gists_url":"https://api.github.com/users/iNavFlight/gists{/gist_id}","starred_url":"https://api.github.com/users/iNavFlight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iNavFlight/subscriptions","organizations_url":"https://api.github.com/users/iNavFlight/orgs","repos_url":"https://api.github.com/users/iNavFlight/repos","events_url":"https://api.github.com/users/iNavFlight/events{/privacy}","received_events_url":"https://api.github.com/users/iNavFlight/received_events","type":"Organization","site_admin":false},"repo":{"id":32148604,"name":"inav","full_name":"iNavFlight/inav","owner":{"login":"iNavFlight","id":15979895,"avatar_url":"https://avatars2.githubusercontent.com/u/15979895?v=4","gravatar_id":"","url":"https://api.github.com/users/iNavFlight","html_url":"https://github.com/iNavFlight","followers_url":"https://api.github.com/users/iNavFlight/followers","following_url":"https://api.github.com/users/iNavFlight/following{/other_user}","gists_url":"https://api.github.com/users/iNavFlight/gists{/gist_id}","starred_url":"https://api.github.com/users/iNavFlight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iNavFlight/subscriptions","organizations_url":"https://api.github.com/users/iNavFlight/orgs","repos_url":"https://api.github.com/users/iNavFlight/repos","events_url":"https://api.github.com/users/iNavFlight/events{/privacy}","received_events_url":"https://api.github.com/users/iNavFlight/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iNavFlight/inav","description":"INAV: Navigation-enabled flight control software","fork":false,"url":"https://api.github.com/repos/iNavFlight/inav","forks_url":"https://api.github.com/repos/iNavFlight/inav/forks","keys_url":"https://api.github.com/repos/iNavFlight/inav/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iNavFlight/inav/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iNavFlight/inav/teams","hooks_url":"https://api.github.com/repos/iNavFlight/inav/hooks","issue_events_url":"https://api.github.com/repos/iNavFlight/inav/issues/events{/number}","events_url":"https://api.github.com/repos/iNavFlight/inav/events","assignees_url":"https://api.github.com/repos/iNavFlight/inav/assignees{/user}","branches_url":"https://api.github.com/repos/iNavFlight/inav/branches{/branch}","tags_url":"https://api.github.com/repos/iNavFlight/inav/tags","blobs_url":"https://api.github.com/repos/iNavFlight/inav/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iNavFlight/inav/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iNavFlight/inav/git/refs{/sha}","trees_url":"https://api.github.com/repos/iNavFlight/inav/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iNavFlight/inav/statuses/{sha}","languages_url":"https://api.github.com/repos/iNavFlight/inav/languages","stargazers_url":"https://api.github.com/repos/iNavFlight/inav/stargazers","contributors_url":"https://api.github.com/repos/iNavFlight/inav/contributors","subscribers_url":"https://api.github.com/repos/iNavFlight/inav/subscribers","subscription_url":"https://api.github.com/repos/iNavFlight/inav/subscription","commits_url":"https://api.github.com/repos/iNavFlight/inav/commits{/sha}","git_commits_url":"https://api.github.com/repos/iNavFlight/inav/git/commits{/sha}","comments_url":"https://api.github.com/repos/iNavFlight/inav/comments{/number}","issue_comment_url":"https://api.github.com/repos/iNavFlight/inav/issues/comments{/number}","contents_url":"https://api.github.com/repos/iNavFlight/inav/contents/{+path}","compare_url":"https://api.github.com/repos/iNavFlight/inav/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iNavFlight/inav/merges","archive_url":"https://api.github.com/repos/iNavFlight/inav/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iNavFlight/inav/downloads","issues_url":"https://api.github.com/repos/iNavFlight/inav/issues{/number}","pulls_url":"https://api.github.com/repos/iNavFlight/inav/pulls{/number}","milestones_url":"https://api.github.com/repos/iNavFlight/inav/milestones{/number}","notifications_url":"https://api.github.com/repos/iNavFlight/inav/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iNavFlight/inav/labels{/name}","releases_url":"https://api.github.com/repos/iNavFlight/inav/releases{/id}","deployments_url":"https://api.github.com/repos/iNavFlight/inav/deployments","created_at":"2015-03-13T09:58:19Z","updated_at":"2018-03-06T05:38:14Z","pushed_at":"2018-03-07T05:19:20Z","git_url":"git://github.com/iNavFlight/inav.git","ssh_url":"git@github.com:iNavFlight/inav.git","clone_url":"https://github.com/iNavFlight/inav.git","svn_url":"https://github.com/iNavFlight/inav","homepage":"https://inavflight.github.io","size":150068,"stargazers_count":473,"watchers_count":473,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":245,"mirror_url":null,"archived":false,"open_issues_count":335,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":245,"open_issues":335,"watchers":473,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iNavFlight/inav/pulls/2881"},"html":{"href":"https://github.com/iNavFlight/inav/pull/2881"},"issue":{"href":"https://api.github.com/repos/iNavFlight/inav/issues/2881"},"comments":{"href":"https://api.github.com/repos/iNavFlight/inav/issues/2881/comments"},"review_comments":{"href":"https://api.github.com/repos/iNavFlight/inav/pulls/2881/comments"},"review_comment":{"href":"https://api.github.com/repos/iNavFlight/inav/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iNavFlight/inav/pulls/2881/commits"},"statuses":{"href":"https://api.github.com/repos/iNavFlight/inav/statuses/26a04dcfe36a652a9e0d8f9c7970eba867a9b0d4"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"digitalentity","id":11059099,"avatar_url":"https://avatars2.githubusercontent.com/u/11059099?v=4","gravatar_id":"","url":"https://api.github.com/users/digitalentity","html_url":"https://github.com/digitalentity","followers_url":"https://api.github.com/users/digitalentity/followers","following_url":"https://api.github.com/users/digitalentity/following{/other_user}","gists_url":"https://api.github.com/users/digitalentity/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalentity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalentity/subscriptions","organizations_url":"https://api.github.com/users/digitalentity/orgs","repos_url":"https://api.github.com/users/digitalentity/repos","events_url":"https://api.github.com/users/digitalentity/events{/privacy}","received_events_url":"https://api.github.com/users/digitalentity/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":6,"additions":511,"deletions":439,"changed_files":21}}
{"actor":{"display_login":"digitalentity"}}