{"action":"created","comment":{"url":"https://api.github.com/repos/src-d/style-analyzer/pulls/comments/215670803","pull_request_review_id":152987352,"id":215670803,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTY3MDgwMw==","diff_hunk":"@@ -151,6 +148,31 @@ def __init__(self, language: str, siblings_window: int = 5, parents_depth: int =\n         self.tokens = importlib.import_module(\"lookout.style.format.langs.%s.tokens\" % language)\n         self.roles = importlib.import_module(\"lookout.style.format.langs.%s.roles\" % language)\n \n+        # Order is important and should be consistent with _inplace_write_vnode_features function\n+        # where features generation happens.\n+        self.feature_layout = OrderedDict([","path":"lookout/style/format/features.py","position":35,"original_position":35,"commit_id":"f89239a2e895d3b1719d8b219a007ed782c2de34","original_commit_id":"f89239a2e895d3b1719d8b219a007ed782c2de34","user":{"login":"vmarkovtsev","id":2793551,"node_id":"MDQ6VXNlcjI3OTM1NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/2793551?v=4","gravatar_id":"","url":"https://api.github.com/users/vmarkovtsev","html_url":"https://github.com/vmarkovtsev","followers_url":"https://api.github.com/users/vmarkovtsev/followers","following_url":"https://api.github.com/users/vmarkovtsev/following{/other_user}","gists_url":"https://api.github.com/users/vmarkovtsev/gists{/gist_id}","starred_url":"https://api.github.com/users/vmarkovtsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmarkovtsev/subscriptions","organizations_url":"https://api.github.com/users/vmarkovtsev/orgs","repos_url":"https://api.github.com/users/vmarkovtsev/repos","events_url":"https://api.github.com/users/vmarkovtsev/events{/privacy}","received_events_url":"https://api.github.com/users/vmarkovtsev/received_events","type":"User","site_admin":false},"body":"Better to make it protected and add a read-only property","created_at":"2018-09-06T15:27:21Z","updated_at":"2018-09-06T15:30:17Z","html_url":"https://github.com/src-d/style-analyzer/pull/108#discussion_r215670803","pull_request_url":"https://api.github.com/repos/src-d/style-analyzer/pulls/108","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/src-d/style-analyzer/pulls/comments/215670803"},"html":{"href":"https://github.com/src-d/style-analyzer/pull/108#discussion_r215670803"},"pull_request":{"href":"https://api.github.com/repos/src-d/style-analyzer/pulls/108"}}},"pull_request":{"url":"https://api.github.com/repos/src-d/style-analyzer/pulls/108","id":213645882,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNjQ1ODgy","html_url":"https://github.com/src-d/style-analyzer/pull/108","diff_url":"https://github.com/src-d/style-analyzer/pull/108.diff","patch_url":"https://github.com/src-d/style-analyzer/pull/108.patch","issue_url":"https://api.github.com/repos/src-d/style-analyzer/issues/108","number":108,"state":"open","locked":false,"title":"Add feature names to FeatureExtractor","user":{"login":"zurk","id":516045,"node_id":"MDQ6VXNlcjUxNjA0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/516045?v=4","gravatar_id":"","url":"https://api.github.com/users/zurk","html_url":"https://github.com/zurk","followers_url":"https://api.github.com/users/zurk/followers","following_url":"https://api.github.com/users/zurk/following{/other_user}","gists_url":"https://api.github.com/users/zurk/gists{/gist_id}","starred_url":"https://api.github.com/users/zurk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zurk/subscriptions","organizations_url":"https://api.github.com/users/zurk/orgs","repos_url":"https://api.github.com/users/zurk/repos","events_url":"https://api.github.com/users/zurk/events{/privacy}","received_events_url":"https://api.github.com/users/zurk/received_events","type":"User","site_admin":false},"body":"I add `feature_layout` field to `FeatureExtractor` class. Now we have features names in the corresponding attribute. But it is still independent of feature generation function (`_inplace_write_vnode_features`). First, I was trying to them because in case you change one you should always fix the second. It is inconvenient and can lead to bugs.\r\nHowever, I decided to keep it simple for now to avoid conflicts in future changes when we decide to add more complex features than one node related.\r\n","created_at":"2018-09-06T14:48:18Z","updated_at":"2018-09-06T15:30:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a416ad99db6b2f366e29e5df15ac2e437cec53d0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/src-d/style-analyzer/pulls/108/commits","review_comments_url":"https://api.github.com/repos/src-d/style-analyzer/pulls/108/comments","review_comment_url":"https://api.github.com/repos/src-d/style-analyzer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/src-d/style-analyzer/issues/108/comments","statuses_url":"https://api.github.com/repos/src-d/style-analyzer/statuses/f89239a2e895d3b1719d8b219a007ed782c2de34","head":{"label":"zurk:master","ref":"master","sha":"f89239a2e895d3b1719d8b219a007ed782c2de34","user":{"login":"zurk","id":516045,"node_id":"MDQ6VXNlcjUxNjA0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/516045?v=4","gravatar_id":"","url":"https://api.github.com/users/zurk","html_url":"https://github.com/zurk","followers_url":"https://api.github.com/users/zurk/followers","following_url":"https://api.github.com/users/zurk/following{/other_user}","gists_url":"https://api.github.com/users/zurk/gists{/gist_id}","starred_url":"https://api.github.com/users/zurk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zurk/subscriptions","organizations_url":"https://api.github.com/users/zurk/orgs","repos_url":"https://api.github.com/users/zurk/repos","events_url":"https://api.github.com/users/zurk/events{/privacy}","received_events_url":"https://api.github.com/users/zurk/received_events","type":"User","site_admin":false},"repo":{"id":143881897,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM4ODE4OTc=","name":"style-analyzer","full_name":"zurk/style-analyzer","owner":{"login":"zurk","id":516045,"node_id":"MDQ6VXNlcjUxNjA0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/516045?v=4","gravatar_id":"","url":"https://api.github.com/users/zurk","html_url":"https://github.com/zurk","followers_url":"https://api.github.com/users/zurk/followers","following_url":"https://api.github.com/users/zurk/following{/other_user}","gists_url":"https://api.github.com/users/zurk/gists{/gist_id}","starred_url":"https://api.github.com/users/zurk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zurk/subscriptions","organizations_url":"https://api.github.com/users/zurk/orgs","repos_url":"https://api.github.com/users/zurk/repos","events_url":"https://api.github.com/users/zurk/events{/privacy}","received_events_url":"https://api.github.com/users/zurk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zurk/style-analyzer","description":"Style analyzer experiments","fork":true,"url":"https://api.github.com/repos/zurk/style-analyzer","forks_url":"https://api.github.com/repos/zurk/style-analyzer/forks","keys_url":"https://api.github.com/repos/zurk/style-analyzer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zurk/style-analyzer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zurk/style-analyzer/teams","hooks_url":"https://api.github.com/repos/zurk/style-analyzer/hooks","issue_events_url":"https://api.github.com/repos/zurk/style-analyzer/issues/events{/number}","events_url":"https://api.github.com/repos/zurk/style-analyzer/events","assignees_url":"https://api.github.com/repos/zurk/style-analyzer/assignees{/user}","branches_url":"https://api.github.com/repos/zurk/style-analyzer/branches{/branch}","tags_url":"https://api.github.com/repos/zurk/style-analyzer/tags","blobs_url":"https://api.github.com/repos/zurk/style-analyzer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zurk/style-analyzer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zurk/style-analyzer/git/refs{/sha}","trees_url":"https://api.github.com/repos/zurk/style-analyzer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zurk/style-analyzer/statuses/{sha}","languages_url":"https://api.github.com/repos/zurk/style-analyzer/languages","stargazers_url":"https://api.github.com/repos/zurk/style-analyzer/stargazers","contributors_url":"https://api.github.com/repos/zurk/style-analyzer/contributors","subscribers_url":"https://api.github.com/repos/zurk/style-analyzer/subscribers","subscription_url":"https://api.github.com/repos/zurk/style-analyzer/subscription","commits_url":"https://api.github.com/repos/zurk/style-analyzer/commits{/sha}","git_commits_url":"https://api.github.com/repos/zurk/style-analyzer/git/commits{/sha}","comments_url":"https://api.github.com/repos/zurk/style-analyzer/comments{/number}","issue_comment_url":"https://api.github.com/repos/zurk/style-analyzer/issues/comments{/number}","contents_url":"https://api.github.com/repos/zurk/style-analyzer/contents/{+path}","compare_url":"https://api.github.com/repos/zurk/style-analyzer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zurk/style-analyzer/merges","archive_url":"https://api.github.com/repos/zurk/style-analyzer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zurk/style-analyzer/downloads","issues_url":"https://api.github.com/repos/zurk/style-analyzer/issues{/number}","pulls_url":"https://api.github.com/repos/zurk/style-analyzer/pulls{/number}","milestones_url":"https://api.github.com/repos/zurk/style-analyzer/milestones{/number}","notifications_url":"https://api.github.com/repos/zurk/style-analyzer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zurk/style-analyzer/labels{/name}","releases_url":"https://api.github.com/repos/zurk/style-analyzer/releases{/id}","deployments_url":"https://api.github.com/repos/zurk/style-analyzer/deployments","created_at":"2018-08-07T14:04:29Z","updated_at":"2018-09-06T14:50:01Z","pushed_at":"2018-09-06T14:49:59Z","git_url":"git://github.com/zurk/style-analyzer.git","ssh_url":"git@github.com:zurk/style-analyzer.git","clone_url":"https://github.com/zurk/style-analyzer.git","svn_url":"https://github.com/zurk/style-analyzer","homepage":null,"size":5440,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"src-d:master","ref":"master","sha":"99e8a47d97f447ed0bc25e195f37e913c1db39ea","user":{"login":"src-d","id":15128793,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTI4Nzkz","avatar_url":"https://avatars2.githubusercontent.com/u/15128793?v=4","gravatar_id":"","url":"https://api.github.com/users/src-d","html_url":"https://github.com/src-d","followers_url":"https://api.github.com/users/src-d/followers","following_url":"https://api.github.com/users/src-d/following{/other_user}","gists_url":"https://api.github.com/users/src-d/gists{/gist_id}","starred_url":"https://api.github.com/users/src-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/src-d/subscriptions","organizations_url":"https://api.github.com/users/src-d/orgs","repos_url":"https://api.github.com/users/src-d/repos","events_url":"https://api.github.com/users/src-d/events{/privacy}","received_events_url":"https://api.github.com/users/src-d/received_events","type":"Organization","site_admin":false},"repo":{"id":139746338,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk3NDYzMzg=","name":"style-analyzer","full_name":"src-d/style-analyzer","owner":{"login":"src-d","id":15128793,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTI4Nzkz","avatar_url":"https://avatars2.githubusercontent.com/u/15128793?v=4","gravatar_id":"","url":"https://api.github.com/users/src-d","html_url":"https://github.com/src-d","followers_url":"https://api.github.com/users/src-d/followers","following_url":"https://api.github.com/users/src-d/following{/other_user}","gists_url":"https://api.github.com/users/src-d/gists{/gist_id}","starred_url":"https://api.github.com/users/src-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/src-d/subscriptions","organizations_url":"https://api.github.com/users/src-d/orgs","repos_url":"https://api.github.com/users/src-d/repos","events_url":"https://api.github.com/users/src-d/events{/privacy}","received_events_url":"https://api.github.com/users/src-d/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/src-d/style-analyzer","description":"Style analyzer experiments","fork":false,"url":"https://api.github.com/repos/src-d/style-analyzer","forks_url":"https://api.github.com/repos/src-d/style-analyzer/forks","keys_url":"https://api.github.com/repos/src-d/style-analyzer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/src-d/style-analyzer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/src-d/style-analyzer/teams","hooks_url":"https://api.github.com/repos/src-d/style-analyzer/hooks","issue_events_url":"https://api.github.com/repos/src-d/style-analyzer/issues/events{/number}","events_url":"https://api.github.com/repos/src-d/style-analyzer/events","assignees_url":"https://api.github.com/repos/src-d/style-analyzer/assignees{/user}","branches_url":"https://api.github.com/repos/src-d/style-analyzer/branches{/branch}","tags_url":"https://api.github.com/repos/src-d/style-analyzer/tags","blobs_url":"https://api.github.com/repos/src-d/style-analyzer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/src-d/style-analyzer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/src-d/style-analyzer/git/refs{/sha}","trees_url":"https://api.github.com/repos/src-d/style-analyzer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/src-d/style-analyzer/statuses/{sha}","languages_url":"https://api.github.com/repos/src-d/style-analyzer/languages","stargazers_url":"https://api.github.com/repos/src-d/style-analyzer/stargazers","contributors_url":"https://api.github.com/repos/src-d/style-analyzer/contributors","subscribers_url":"https://api.github.com/repos/src-d/style-analyzer/subscribers","subscription_url":"https://api.github.com/repos/src-d/style-analyzer/subscription","commits_url":"https://api.github.com/repos/src-d/style-analyzer/commits{/sha}","git_commits_url":"https://api.github.com/repos/src-d/style-analyzer/git/commits{/sha}","comments_url":"https://api.github.com/repos/src-d/style-analyzer/comments{/number}","issue_comment_url":"https://api.github.com/repos/src-d/style-analyzer/issues/comments{/number}","contents_url":"https://api.github.com/repos/src-d/style-analyzer/contents/{+path}","compare_url":"https://api.github.com/repos/src-d/style-analyzer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/src-d/style-analyzer/merges","archive_url":"https://api.github.com/repos/src-d/style-analyzer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/src-d/style-analyzer/downloads","issues_url":"https://api.github.com/repos/src-d/style-analyzer/issues{/number}","pulls_url":"https://api.github.com/repos/src-d/style-analyzer/pulls{/number}","milestones_url":"https://api.github.com/repos/src-d/style-analyzer/milestones{/number}","notifications_url":"https://api.github.com/repos/src-d/style-analyzer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/src-d/style-analyzer/labels{/name}","releases_url":"https://api.github.com/repos/src-d/style-analyzer/releases{/id}","deployments_url":"https://api.github.com/repos/src-d/style-analyzer/deployments","created_at":"2018-07-04T16:42:30Z","updated_at":"2018-09-06T09:56:24Z","pushed_at":"2018-09-06T15:24:30Z","git_url":"git://github.com/src-d/style-analyzer.git","ssh_url":"git@github.com:src-d/style-analyzer.git","clone_url":"https://github.com/src-d/style-analyzer.git","svn_url":"https://github.com/src-d/style-analyzer","homepage":null,"size":5565,"stargazers_count":1,"watchers_count":1,"language":"Jupyter Notebook","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7,"open_issues":12,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/src-d/style-analyzer/pulls/108"},"html":{"href":"https://github.com/src-d/style-analyzer/pull/108"},"issue":{"href":"https://api.github.com/repos/src-d/style-analyzer/issues/108"},"comments":{"href":"https://api.github.com/repos/src-d/style-analyzer/issues/108/comments"},"review_comments":{"href":"https://api.github.com/repos/src-d/style-analyzer/pulls/108/comments"},"review_comment":{"href":"https://api.github.com/repos/src-d/style-analyzer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/src-d/style-analyzer/pulls/108/commits"},"statuses":{"href":"https://api.github.com/repos/src-d/style-analyzer/statuses/f89239a2e895d3b1719d8b219a007ed782c2de34"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"vmarkovtsev"}}