{"action":"created","issue":{"url":"https://api.github.com/repos/knowm/XChange/issues/2507","repository_url":"https://api.github.com/repos/knowm/XChange","labels_url":"https://api.github.com/repos/knowm/XChange/issues/2507/labels{/name}","comments_url":"https://api.github.com/repos/knowm/XChange/issues/2507/comments","events_url":"https://api.github.com/repos/knowm/XChange/issues/2507/events","html_url":"https://github.com/knowm/XChange/pull/2507","id":314831549,"number":2507,"title":"Balance,Currency,CurrencyPair,Wallet,AccountInfo as Interface","user":{"login":"jnorthrup","id":73514,"avatar_url":"https://avatars2.githubusercontent.com/u/73514?v=4","gravatar_id":"","url":"https://api.github.com/users/jnorthrup","html_url":"https://github.com/jnorthrup","followers_url":"https://api.github.com/users/jnorthrup/followers","following_url":"https://api.github.com/users/jnorthrup/following{/other_user}","gists_url":"https://api.github.com/users/jnorthrup/gists{/gist_id}","starred_url":"https://api.github.com/users/jnorthrup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnorthrup/subscriptions","organizations_url":"https://api.github.com/users/jnorthrup/orgs","repos_url":"https://api.github.com/users/jnorthrup/repos","events_url":"https://api.github.com/users/jnorthrup/events{/privacy}","received_events_url":"https://api.github.com/users/jnorthrup/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2018-04-16T21:51:58Z","updated_at":"2018-04-21T17:28:47Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/knowm/XChange/pulls/2507","html_url":"https://github.com/knowm/XChange/pull/2507","diff_url":"https://github.com/knowm/XChange/pull/2507.diff","patch_url":"https://github.com/knowm/XChange/pull/2507.patch"},"body":"testing against conversation in #2495, also moves bitmex metadata into bitmex module since i was refactoring currency.   ( #2506 )\r\n\r\nthere was no code modified to speak of, this didn't require annotation hell like i expected, just need method called valueOf in the interface that matched the existing instanceOf method, so that was renamed.  now jackson reads the interface as a factory \r\n\r\n@see https://github.com/FasterXML/jackson-databind/wiki/Mapper-Features for ValueOf documentation to provide deserialization to Interfaces\r\n"},"comment":{"url":"https://api.github.com/repos/knowm/XChange/issues/comments/383314715","html_url":"https://github.com/knowm/XChange/pull/2507#issuecomment-383314715","issue_url":"https://api.github.com/repos/knowm/XChange/issues/2507","id":383314715,"user":{"login":"jnorthrup","id":73514,"avatar_url":"https://avatars2.githubusercontent.com/u/73514?v=4","gravatar_id":"","url":"https://api.github.com/users/jnorthrup","html_url":"https://github.com/jnorthrup","followers_url":"https://api.github.com/users/jnorthrup/followers","following_url":"https://api.github.com/users/jnorthrup/following{/other_user}","gists_url":"https://api.github.com/users/jnorthrup/gists{/gist_id}","starred_url":"https://api.github.com/users/jnorthrup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnorthrup/subscriptions","organizations_url":"https://api.github.com/users/jnorthrup/orgs","repos_url":"https://api.github.com/users/jnorthrup/repos","events_url":"https://api.github.com/users/jnorthrup/events{/privacy}","received_events_url":"https://api.github.com/users/jnorthrup/received_events","type":"User","site_admin":false},"created_at":"2018-04-21T17:28:47Z","updated_at":"2018-04-21T17:28:47Z","author_association":"CONTRIBUTOR","body":"@timmolter I do spend a lot of time trying to preserve existing functionality and minimize the alice in wonderland nature of old growth features here, please go ahead and fix whatever conflicts you create if this  work is a positive contribution, otherwise, just reiterate \"it is what it is\" and close the PR "}}
{"actor":{"display_login":"jnorthrup"}}