{"action":"opened","issue":{"url":"https://api.github.com/repos/octobercms/october/issues/3912","repository_url":"https://api.github.com/repos/octobercms/october","labels_url":"https://api.github.com/repos/octobercms/october/issues/3912/labels{/name}","comments_url":"https://api.github.com/repos/octobercms/october/issues/3912/comments","events_url":"https://api.github.com/repos/octobercms/october/issues/3912/events","html_url":"https://github.com/octobercms/october/issues/3912","id":379434651,"node_id":"MDU6SXNzdWUzNzk0MzQ2NTE=","number":3912,"title":"OctoberCMS asset links broken behind load balancer/proxy that terminates SSL connection","user":{"login":"sNuuFix","id":832367,"node_id":"MDQ6VXNlcjgzMjM2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/832367?v=4","gravatar_id":"","url":"https://api.github.com/users/sNuuFix","html_url":"https://github.com/sNuuFix","followers_url":"https://api.github.com/users/sNuuFix/followers","following_url":"https://api.github.com/users/sNuuFix/following{/other_user}","gists_url":"https://api.github.com/users/sNuuFix/gists{/gist_id}","starred_url":"https://api.github.com/users/sNuuFix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sNuuFix/subscriptions","organizations_url":"https://api.github.com/users/sNuuFix/orgs","repos_url":"https://api.github.com/users/sNuuFix/repos","events_url":"https://api.github.com/users/sNuuFix/events{/privacy}","received_events_url":"https://api.github.com/users/sNuuFix/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-10T16:10:29Z","updated_at":"2018-11-10T16:10:29Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"##### Expected behavior\r\nWhen deoploying OctoberCMS on cloud infrastructure as Docker Swarm, behind reverse proxy/load balancer, asset links should be inlined with hostname and protocol taken from config or fowarded headers. Logging into backend should be possible.\r\n\r\n##### Actual behavior\r\ndepending on link policy setting, all assets are either without https or with with wrong hostname. autodetecting the hostname doesn't work when nodes are deployed as tasks under Docker Swarm using DNS as internal discovery and health check. SSL termination happens at load balancer and internal traffic is raw HTTP, so protocol detection fails too, even `force` setting completely ignores the `https://` set in `app.url`, only outputs correct hostname. (it's the only setting that does) All of the trusted proxy plugins doesn't work by either throwing 500 errors on default installation or just aren't compatible with latest OctoberCMS anymore. In any case, all proxy requests from private IP ranges should be treated as trusted by default. The easiest way how to make OctoberCMS support scalable hosting at this point would be fixing the `force` link policy setting to obey protocol config from `app.url` too when generating asset links.\r\n\r\n##### Reproduce steps\r\nDeploy any OctoberCMS as Docker service on Docker Swarm with more than one node. Or try any other scalable/cloud hosting solution with load balancer infront.\r\n\r\n##### October build\r\nDragontek/octobercms Docker image that downloads latest stable OctoberCMS from git at the time of depoloy - v1.0.443 as of writing this.\r\n"}}
{"actor":{"display_login":"sNuuFix"}}