{"action":"created","comment":{"url":"https://api.github.com/repos/decidim/decidim/pulls/comments/172514873","pull_request_review_id":101542113,"id":172514873,"diff_hunk":"@@ -1,27 +1 @@\n-<div class=\"column\">\n-  <article class=\"card card--proposal\">\n-    <div class=\"card__content\">\n-      <div class=\"card__header\">\n-        <%= link_to resource_locator(proposal).path do%>\n-            <h5 class=\"card__title\"><%= proposal.title %></h5>\n-        <% end %>\n-        <div class=\"card__author author-data author-data--small\">\n-          <%= render partial: \"decidim/shared/author_reference\", locals: { author: present(proposal).author } %>\n-        </div>\n-        <div class=\"tech-info tech-info--text-left\">\n-          <%= t(\".creation_date\", date: l(proposal.created_at, format: :decidim_short)) %>\n-        </div>\n-        <%= resource_reference(proposal, class: \"tech-info--text-left\") %>\n-      </div>\n-      <%= render partial: \"decidim/proposals/proposals/proposal_badge\", locals: { proposal: proposal } %>\n-      <p><%= truncate(proposal.body, length: 100) %></p>\n-      <%= render partial: \"decidim/shared/tags\", locals: { resource: proposal, tags_class_extra: \"tags--proposal\" } %>\n-    </div>\n-    <div class=\"card__footer\">\n-      <div class=\"card__support\">\n-        <div class=\"card__support__data\"></div>\n-        <%= link_to t(\".view_proposal\"), resource_locator(proposal).path, class: \"card__button button small secondary\" %>\n-      </div>\n-    </div>\n-  </article>\n-</div>\n+<%= cell \"decidim/proposals/proposal_m\", proposal %>","path":"decidim-proposals/app/views/decidim/participatory_spaces/_proposal.html.erb","position":null,"original_position":28,"commit_id":"ade851b50d4958136704efda92288b2feca97f16","original_commit_id":"f7db0a55c0361a74da87790453bc761365dd1ff4","user":{"login":"mrcasals","id":491891,"avatar_url":"https://avatars3.githubusercontent.com/u/491891?v=4","gravatar_id":"","url":"https://api.github.com/users/mrcasals","html_url":"https://github.com/mrcasals","followers_url":"https://api.github.com/users/mrcasals/followers","following_url":"https://api.github.com/users/mrcasals/following{/other_user}","gists_url":"https://api.github.com/users/mrcasals/gists{/gist_id}","starred_url":"https://api.github.com/users/mrcasals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrcasals/subscriptions","organizations_url":"https://api.github.com/users/mrcasals/orgs","repos_url":"https://api.github.com/users/mrcasals/repos","events_url":"https://api.github.com/users/mrcasals/events{/privacy}","received_events_url":"https://api.github.com/users/mrcasals/received_events","type":"User","site_admin":false},"body":"Same here","created_at":"2018-03-06T13:30:59Z","updated_at":"2018-03-06T13:30:59Z","html_url":"https://github.com/decidim/decidim/pull/2897#discussion_r172514873","pull_request_url":"https://api.github.com/repos/decidim/decidim/pulls/2897","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/decidim/decidim/pulls/comments/172514873"},"html":{"href":"https://github.com/decidim/decidim/pull/2897#discussion_r172514873"},"pull_request":{"href":"https://api.github.com/repos/decidim/decidim/pulls/2897"}}},"pull_request":{"url":"https://api.github.com/repos/decidim/decidim/pulls/2897","id":172679220,"html_url":"https://github.com/decidim/decidim/pull/2897","diff_url":"https://github.com/decidim/decidim/pull/2897.diff","patch_url":"https://github.com/decidim/decidim/pull/2897.patch","issue_url":"https://api.github.com/repos/decidim/decidim/issues/2897","number":2897,"state":"open","locked":false,"title":"[RFC] Use cells to componentize the views (2nd take)","user":{"login":"mrcasals","id":491891,"avatar_url":"https://avatars3.githubusercontent.com/u/491891?v=4","gravatar_id":"","url":"https://api.github.com/users/mrcasals","html_url":"https://github.com/mrcasals","followers_url":"https://api.github.com/users/mrcasals/followers","following_url":"https://api.github.com/users/mrcasals/following{/other_user}","gists_url":"https://api.github.com/users/mrcasals/gists{/gist_id}","starred_url":"https://api.github.com/users/mrcasals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrcasals/subscriptions","organizations_url":"https://api.github.com/users/mrcasals/orgs","repos_url":"https://api.github.com/users/mrcasals/repos","events_url":"https://api.github.com/users/mrcasals/events{/privacy}","received_events_url":"https://api.github.com/users/mrcasals/received_events","type":"User","site_admin":false},"body":"# This is a Request For Comments\r\n\r\n#### :tophat: What? Why?\r\nThis PR builds on top of #2521 by @josepjaume.\r\n\r\nBasically this PR copies the commits from #2521, updates them to work with current `master` and reuses cells in some other places to show how to use them.\r\n\r\nThis work is done outside the work of @decidim/lot-core, and can serve as a basis for @decidim/lot-mods when they need to add cards to resources.\r\n\r\nSince we'll have to add the idea of cards, and I wanted to have a real use case for this, I too added a simple `Decidim::Proposals::ProposalMCell` (naming is not the best, I know), you call it like this:\r\n\r\n```erb\r\n<%= cell \"decidim/proposals/proposal_m\", my_proposal %>\r\n```\r\n\r\nYou'll see other changes in unrelated views too. Those are partials that are rendered from *within* the cell, and the cells don't have the context of the path, so I need to specify a full path for both partials and i18n strings. Also, when rendering partials from within the cell you need to add the `.html` suffix to the partial name, otherwise it won't be found.\r\n\r\nWhile this is cumbersome, this means those partials can be extracted to their own cells, which is a better solution IMHO.\r\n\r\nFor the specific case of card versions, maybe we could create a `ProposalCell` that is rendered like this:\r\n\r\n```erb\r\n<%= cell \"decidim/proposals/proposal\", my_proposal, version: :m %>\r\n```\r\n\r\nAnd this `ProposalCell` knows how to render the `:m` version of the proposal. It would act as a delegator/presenter/facade, but we'd force it to be a cell. This pattern can be extracted to all resources, since all will have cards. See #2872 for a discussion what can be considered as a \"resource\". This delegator/presenter/facade cell can be specified within the `ResourceManifest`.\r\n\r\n\r\n\r\n#### :pushpin: Related Issues\r\n- Related to #2521\r\n\r\n#### :clipboard: Subtasks\r\n- [ ] Add `CHANGELOG` entry\r\n- [ ] Allow conversations with user groups. In `master`, a conversation with a user group is actually a conversation with the user holding the user group, and it links to the user profile. this cells implementation does not have this, and does not show a conversation icon for user groups. My guess is that this can be added to the `Decidim::UserPresenter` and `Decidim::UserGroupPresenter`: add a `conversation_with` method that returns the user ID, and use it in the views\r\n\r\n### :camera: Screenshots (optional)\r\nNone. My own visual checks say nothing has changed, apart from the missing conversation icon on user groups.\r\n","created_at":"2018-03-03T17:58:51Z","updated_at":"2018-03-06T13:30:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5554003c3aec896657ac96d713089fa4c24a3934","assignee":{"login":"mrcasals","id":491891,"avatar_url":"https://avatars3.githubusercontent.com/u/491891?v=4","gravatar_id":"","url":"https://api.github.com/users/mrcasals","html_url":"https://github.com/mrcasals","followers_url":"https://api.github.com/users/mrcasals/followers","following_url":"https://api.github.com/users/mrcasals/following{/other_user}","gists_url":"https://api.github.com/users/mrcasals/gists{/gist_id}","starred_url":"https://api.github.com/users/mrcasals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrcasals/subscriptions","organizations_url":"https://api.github.com/users/mrcasals/orgs","repos_url":"https://api.github.com/users/mrcasals/repos","events_url":"https://api.github.com/users/mrcasals/events{/privacy}","received_events_url":"https://api.github.com/users/mrcasals/received_events","type":"User","site_admin":false},"assignees":[{"login":"agustibr","id":210216,"avatar_url":"https://avatars1.githubusercontent.com/u/210216?v=4","gravatar_id":"","url":"https://api.github.com/users/agustibr","html_url":"https://github.com/agustibr","followers_url":"https://api.github.com/users/agustibr/followers","following_url":"https://api.github.com/users/agustibr/following{/other_user}","gists_url":"https://api.github.com/users/agustibr/gists{/gist_id}","starred_url":"https://api.github.com/users/agustibr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agustibr/subscriptions","organizations_url":"https://api.github.com/users/agustibr/orgs","repos_url":"https://api.github.com/users/agustibr/repos","events_url":"https://api.github.com/users/agustibr/events{/privacy}","received_events_url":"https://api.github.com/users/agustibr/received_events","type":"User","site_admin":false},{"login":"mrcasals","id":491891,"avatar_url":"https://avatars3.githubusercontent.com/u/491891?v=4","gravatar_id":"","url":"https://api.github.com/users/mrcasals","html_url":"https://github.com/mrcasals","followers_url":"https://api.github.com/users/mrcasals/followers","following_url":"https://api.github.com/users/mrcasals/following{/other_user}","gists_url":"https://api.github.com/users/mrcasals/gists{/gist_id}","starred_url":"https://api.github.com/users/mrcasals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrcasals/subscriptions","organizations_url":"https://api.github.com/users/mrcasals/orgs","repos_url":"https://api.github.com/users/mrcasals/repos","events_url":"https://api.github.com/users/mrcasals/events{/privacy}","received_events_url":"https://api.github.com/users/mrcasals/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":518062863,"url":"https://api.github.com/repos/decidim/decidim/labels/in-review","name":"in-review","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/decidim/decidim/pulls/2897/commits","review_comments_url":"https://api.github.com/repos/decidim/decidim/pulls/2897/comments","review_comment_url":"https://api.github.com/repos/decidim/decidim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/decidim/decidim/issues/2897/comments","statuses_url":"https://api.github.com/repos/decidim/decidim/statuses/ade851b50d4958136704efda92288b2feca97f16","head":{"label":"decidim:cells-reloaded","ref":"cells-reloaded","sha":"ade851b50d4958136704efda92288b2feca97f16","user":{"login":"decidim","id":22474646,"avatar_url":"https://avatars3.githubusercontent.com/u/22474646?v=4","gravatar_id":"","url":"https://api.github.com/users/decidim","html_url":"https://github.com/decidim","followers_url":"https://api.github.com/users/decidim/followers","following_url":"https://api.github.com/users/decidim/following{/other_user}","gists_url":"https://api.github.com/users/decidim/gists{/gist_id}","starred_url":"https://api.github.com/users/decidim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decidim/subscriptions","organizations_url":"https://api.github.com/users/decidim/orgs","repos_url":"https://api.github.com/users/decidim/repos","events_url":"https://api.github.com/users/decidim/events{/privacy}","received_events_url":"https://api.github.com/users/decidim/received_events","type":"Organization","site_admin":false},"repo":{"id":65914086,"name":"decidim","full_name":"decidim/decidim","owner":{"login":"decidim","id":22474646,"avatar_url":"https://avatars3.githubusercontent.com/u/22474646?v=4","gravatar_id":"","url":"https://api.github.com/users/decidim","html_url":"https://github.com/decidim","followers_url":"https://api.github.com/users/decidim/followers","following_url":"https://api.github.com/users/decidim/following{/other_user}","gists_url":"https://api.github.com/users/decidim/gists{/gist_id}","starred_url":"https://api.github.com/users/decidim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decidim/subscriptions","organizations_url":"https://api.github.com/users/decidim/orgs","repos_url":"https://api.github.com/users/decidim/repos","events_url":"https://api.github.com/users/decidim/events{/privacy}","received_events_url":"https://api.github.com/users/decidim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/decidim/decidim","description":"The participatory democracy framework. A generator and multiple gems made with Ruby on Rails. ","fork":false,"url":"https://api.github.com/repos/decidim/decidim","forks_url":"https://api.github.com/repos/decidim/decidim/forks","keys_url":"https://api.github.com/repos/decidim/decidim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/decidim/decidim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/decidim/decidim/teams","hooks_url":"https://api.github.com/repos/decidim/decidim/hooks","issue_events_url":"https://api.github.com/repos/decidim/decidim/issues/events{/number}","events_url":"https://api.github.com/repos/decidim/decidim/events","assignees_url":"https://api.github.com/repos/decidim/decidim/assignees{/user}","branches_url":"https://api.github.com/repos/decidim/decidim/branches{/branch}","tags_url":"https://api.github.com/repos/decidim/decidim/tags","blobs_url":"https://api.github.com/repos/decidim/decidim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/decidim/decidim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/decidim/decidim/git/refs{/sha}","trees_url":"https://api.github.com/repos/decidim/decidim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/decidim/decidim/statuses/{sha}","languages_url":"https://api.github.com/repos/decidim/decidim/languages","stargazers_url":"https://api.github.com/repos/decidim/decidim/stargazers","contributors_url":"https://api.github.com/repos/decidim/decidim/contributors","subscribers_url":"https://api.github.com/repos/decidim/decidim/subscribers","subscription_url":"https://api.github.com/repos/decidim/decidim/subscription","commits_url":"https://api.github.com/repos/decidim/decidim/commits{/sha}","git_commits_url":"https://api.github.com/repos/decidim/decidim/git/commits{/sha}","comments_url":"https://api.github.com/repos/decidim/decidim/comments{/number}","issue_comment_url":"https://api.github.com/repos/decidim/decidim/issues/comments{/number}","contents_url":"https://api.github.com/repos/decidim/decidim/contents/{+path}","compare_url":"https://api.github.com/repos/decidim/decidim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/decidim/decidim/merges","archive_url":"https://api.github.com/repos/decidim/decidim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/decidim/decidim/downloads","issues_url":"https://api.github.com/repos/decidim/decidim/issues{/number}","pulls_url":"https://api.github.com/repos/decidim/decidim/pulls{/number}","milestones_url":"https://api.github.com/repos/decidim/decidim/milestones{/number}","notifications_url":"https://api.github.com/repos/decidim/decidim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/decidim/decidim/labels{/name}","releases_url":"https://api.github.com/repos/decidim/decidim/releases{/id}","deployments_url":"https://api.github.com/repos/decidim/decidim/deployments","created_at":"2016-08-17T14:27:06Z","updated_at":"2018-03-05T05:49:41Z","pushed_at":"2018-03-06T13:27:12Z","git_url":"git://github.com/decidim/decidim.git","ssh_url":"git@github.com:decidim/decidim.git","clone_url":"https://github.com/decidim/decidim.git","svn_url":"https://github.com/decidim/decidim","homepage":"http://www.decidim.org","size":39507,"stargazers_count":156,"watchers_count":156,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":261,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":62,"open_issues":261,"watchers":156,"default_branch":"master"}},"base":{"label":"decidim:master","ref":"master","sha":"91e0a841cdafc5bd593593a308f0b46693e91619","user":{"login":"decidim","id":22474646,"avatar_url":"https://avatars3.githubusercontent.com/u/22474646?v=4","gravatar_id":"","url":"https://api.github.com/users/decidim","html_url":"https://github.com/decidim","followers_url":"https://api.github.com/users/decidim/followers","following_url":"https://api.github.com/users/decidim/following{/other_user}","gists_url":"https://api.github.com/users/decidim/gists{/gist_id}","starred_url":"https://api.github.com/users/decidim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decidim/subscriptions","organizations_url":"https://api.github.com/users/decidim/orgs","repos_url":"https://api.github.com/users/decidim/repos","events_url":"https://api.github.com/users/decidim/events{/privacy}","received_events_url":"https://api.github.com/users/decidim/received_events","type":"Organization","site_admin":false},"repo":{"id":65914086,"name":"decidim","full_name":"decidim/decidim","owner":{"login":"decidim","id":22474646,"avatar_url":"https://avatars3.githubusercontent.com/u/22474646?v=4","gravatar_id":"","url":"https://api.github.com/users/decidim","html_url":"https://github.com/decidim","followers_url":"https://api.github.com/users/decidim/followers","following_url":"https://api.github.com/users/decidim/following{/other_user}","gists_url":"https://api.github.com/users/decidim/gists{/gist_id}","starred_url":"https://api.github.com/users/decidim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decidim/subscriptions","organizations_url":"https://api.github.com/users/decidim/orgs","repos_url":"https://api.github.com/users/decidim/repos","events_url":"https://api.github.com/users/decidim/events{/privacy}","received_events_url":"https://api.github.com/users/decidim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/decidim/decidim","description":"The participatory democracy framework. A generator and multiple gems made with Ruby on Rails. ","fork":false,"url":"https://api.github.com/repos/decidim/decidim","forks_url":"https://api.github.com/repos/decidim/decidim/forks","keys_url":"https://api.github.com/repos/decidim/decidim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/decidim/decidim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/decidim/decidim/teams","hooks_url":"https://api.github.com/repos/decidim/decidim/hooks","issue_events_url":"https://api.github.com/repos/decidim/decidim/issues/events{/number}","events_url":"https://api.github.com/repos/decidim/decidim/events","assignees_url":"https://api.github.com/repos/decidim/decidim/assignees{/user}","branches_url":"https://api.github.com/repos/decidim/decidim/branches{/branch}","tags_url":"https://api.github.com/repos/decidim/decidim/tags","blobs_url":"https://api.github.com/repos/decidim/decidim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/decidim/decidim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/decidim/decidim/git/refs{/sha}","trees_url":"https://api.github.com/repos/decidim/decidim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/decidim/decidim/statuses/{sha}","languages_url":"https://api.github.com/repos/decidim/decidim/languages","stargazers_url":"https://api.github.com/repos/decidim/decidim/stargazers","contributors_url":"https://api.github.com/repos/decidim/decidim/contributors","subscribers_url":"https://api.github.com/repos/decidim/decidim/subscribers","subscription_url":"https://api.github.com/repos/decidim/decidim/subscription","commits_url":"https://api.github.com/repos/decidim/decidim/commits{/sha}","git_commits_url":"https://api.github.com/repos/decidim/decidim/git/commits{/sha}","comments_url":"https://api.github.com/repos/decidim/decidim/comments{/number}","issue_comment_url":"https://api.github.com/repos/decidim/decidim/issues/comments{/number}","contents_url":"https://api.github.com/repos/decidim/decidim/contents/{+path}","compare_url":"https://api.github.com/repos/decidim/decidim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/decidim/decidim/merges","archive_url":"https://api.github.com/repos/decidim/decidim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/decidim/decidim/downloads","issues_url":"https://api.github.com/repos/decidim/decidim/issues{/number}","pulls_url":"https://api.github.com/repos/decidim/decidim/pulls{/number}","milestones_url":"https://api.github.com/repos/decidim/decidim/milestones{/number}","notifications_url":"https://api.github.com/repos/decidim/decidim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/decidim/decidim/labels{/name}","releases_url":"https://api.github.com/repos/decidim/decidim/releases{/id}","deployments_url":"https://api.github.com/repos/decidim/decidim/deployments","created_at":"2016-08-17T14:27:06Z","updated_at":"2018-03-05T05:49:41Z","pushed_at":"2018-03-06T13:27:12Z","git_url":"git://github.com/decidim/decidim.git","ssh_url":"git@github.com:decidim/decidim.git","clone_url":"https://github.com/decidim/decidim.git","svn_url":"https://github.com/decidim/decidim","homepage":"http://www.decidim.org","size":39507,"stargazers_count":156,"watchers_count":156,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":261,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":62,"open_issues":261,"watchers":156,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/decidim/decidim/pulls/2897"},"html":{"href":"https://github.com/decidim/decidim/pull/2897"},"issue":{"href":"https://api.github.com/repos/decidim/decidim/issues/2897"},"comments":{"href":"https://api.github.com/repos/decidim/decidim/issues/2897/comments"},"review_comments":{"href":"https://api.github.com/repos/decidim/decidim/pulls/2897/comments"},"review_comment":{"href":"https://api.github.com/repos/decidim/decidim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/decidim/decidim/pulls/2897/commits"},"statuses":{"href":"https://api.github.com/repos/decidim/decidim/statuses/ade851b50d4958136704efda92288b2feca97f16"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mrcasals"}}