{"action":"created","issue":{"url":"https://api.github.com/repos/cloudigrade/shiftigrade/issues/15","repository_url":"https://api.github.com/repos/cloudigrade/shiftigrade","labels_url":"https://api.github.com/repos/cloudigrade/shiftigrade/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/cloudigrade/shiftigrade/issues/15/comments","events_url":"https://api.github.com/repos/cloudigrade/shiftigrade/issues/15/events","html_url":"https://github.com/cloudigrade/shiftigrade/issues/15","id":334623649,"node_id":"MDU6SXNzdWUzMzQ2MjM2NDk=","number":15,"title":"oc dry-run doesn't always catch issues","user":{"login":"ilyavw","id":34514071,"node_id":"MDQ6VXNlcjM0NTE0MDcx","avatar_url":"https://avatars3.githubusercontent.com/u/34514071?v=4","gravatar_id":"","url":"https://api.github.com/users/ilyavw","html_url":"https://github.com/ilyavw","followers_url":"https://api.github.com/users/ilyavw/followers","following_url":"https://api.github.com/users/ilyavw/following{/other_user}","gists_url":"https://api.github.com/users/ilyavw/gists{/gist_id}","starred_url":"https://api.github.com/users/ilyavw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilyavw/subscriptions","organizations_url":"https://api.github.com/users/ilyavw/orgs","repos_url":"https://api.github.com/users/ilyavw/repos","events_url":"https://api.github.com/users/ilyavw/events{/privacy}","received_events_url":"https://api.github.com/users/ilyavw/received_events","type":"User","site_admin":false},"labels":[{"id":936344024,"node_id":"MDU6TGFiZWw5MzYzNDQwMjQ=","url":"https://api.github.com/repos/cloudigrade/shiftigrade/labels/bug","name":"bug","color":"b60205","default":true},{"id":968048296,"node_id":"MDU6TGFiZWw5NjgwNDgyOTY=","url":"https://api.github.com/repos/cloudigrade/shiftigrade/labels/needs%20definition","name":"needs definition","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-21T19:19:47Z","updated_at":"2018-06-21T19:39:23Z","closed_at":null,"author_association":"MEMBER","body":"We pipe our templates to `oc apply --dry-run -f -` to verify that they are valid, but I believe since they are not actually being sent to the server and verified there that we are only passing client side validation. This unfortunately has the side effect of making it seem like our templates are sound (https://travis-ci.org/cloudigrade/shiftigrade/builds/395145967?utm_source=github_status&utm_medium=notification) when they are not (https://travis-ci.org/cloudigrade/shiftigrade/builds/395151169?utm_source=github_status&utm_medium=notification)\r\n\r\nPerhaps we should replace using dry-run with creating a one off namespace, creating the objects, and then nuking said namespace?"},"comment":{"url":"https://api.github.com/repos/cloudigrade/shiftigrade/issues/comments/399219297","html_url":"https://github.com/cloudigrade/shiftigrade/issues/15#issuecomment-399219297","issue_url":"https://api.github.com/repos/cloudigrade/shiftigrade/issues/15","id":399219297,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTIxOTI5Nw==","user":{"login":"ilyavw","id":34514071,"node_id":"MDQ6VXNlcjM0NTE0MDcx","avatar_url":"https://avatars3.githubusercontent.com/u/34514071?v=4","gravatar_id":"","url":"https://api.github.com/users/ilyavw","html_url":"https://github.com/ilyavw","followers_url":"https://api.github.com/users/ilyavw/followers","following_url":"https://api.github.com/users/ilyavw/following{/other_user}","gists_url":"https://api.github.com/users/ilyavw/gists{/gist_id}","starred_url":"https://api.github.com/users/ilyavw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilyavw/subscriptions","organizations_url":"https://api.github.com/users/ilyavw/orgs","repos_url":"https://api.github.com/users/ilyavw/repos","events_url":"https://api.github.com/users/ilyavw/events{/privacy}","received_events_url":"https://api.github.com/users/ilyavw/received_events","type":"User","site_admin":false},"created_at":"2018-06-21T19:39:23Z","updated_at":"2018-06-21T19:39:23Z","author_association":"MEMBER","body":"That's a good idea, although regardless we'd never actually wait for it to complete, nuking the namespace as soon as we got a 👍 from the apply."}}
{"actor":{"display_login":"ilyavw"}}