{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/addons-server/pulls/comments/165332563","pull_request_review_id":93252299,"id":165332563,"diff_hunk":"@@ -585,6 +585,14 @@ def get_locale_from_lang(lang):\n     if not lang or lang in ('dbg', 'dbr', 'dbl'):\n         lang = 'en'\n \n+    if lang == 'cak':\n+        # 'cak' is not in http://cldr.unicode.org/ and therefore not supported\n+        # by Babel. That breaks get_locale_from_lang() entirely, so this hack\n+        # creates a fake Locale class for this locale.\n+        locale = Locale('en')","path":"src/olympia/amo/utils.py","position":8,"original_position":8,"commit_id":"83430cb34492f221f2a23e4d8050b2b0e81dbe1e","original_commit_id":"83430cb34492f221f2a23e4d8050b2b0e81dbe1e","user":{"login":"EnTeQuAk","id":139033,"avatar_url":"https://avatars1.githubusercontent.com/u/139033?v=4","gravatar_id":"","url":"https://api.github.com/users/EnTeQuAk","html_url":"https://github.com/EnTeQuAk","followers_url":"https://api.github.com/users/EnTeQuAk/followers","following_url":"https://api.github.com/users/EnTeQuAk/following{/other_user}","gists_url":"https://api.github.com/users/EnTeQuAk/gists{/gist_id}","starred_url":"https://api.github.com/users/EnTeQuAk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EnTeQuAk/subscriptions","organizations_url":"https://api.github.com/users/EnTeQuAk/orgs","repos_url":"https://api.github.com/users/EnTeQuAk/repos","events_url":"https://api.github.com/users/EnTeQuAk/events{/privacy}","received_events_url":"https://api.github.com/users/EnTeQuAk/received_events","type":"User","site_admin":false},"body":"We might be able to hack this a bit better and get inspired by https://github.com/mastizada/focus-android/commit/a47e823b0f7ed7cfe641e1d511bf660376f4e7f6#diff-835b365a7ad8b4806be4fb468f33b480R58 (and see more below for the `Locale.parse` part) but I'm not sure this is overkill","created_at":"2018-02-01T11:42:50Z","updated_at":"2018-02-01T11:43:07Z","html_url":"https://github.com/mozilla/addons-server/pull/7452#discussion_r165332563","pull_request_url":"https://api.github.com/repos/mozilla/addons-server/pulls/7452","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/comments/165332563"},"html":{"href":"https://github.com/mozilla/addons-server/pull/7452#discussion_r165332563"},"pull_request":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/7452"}},"in_reply_to_id":165274995},"pull_request":{"url":"https://api.github.com/repos/mozilla/addons-server/pulls/7452","id":166310563,"html_url":"https://github.com/mozilla/addons-server/pull/7452","diff_url":"https://github.com/mozilla/addons-server/pull/7452.diff","patch_url":"https://github.com/mozilla/addons-server/pull/7452.patch","issue_url":"https://api.github.com/repos/mozilla/addons-server/issues/7452","number":7452,"state":"open","locked":false,"title":"Add locales that addons-frontend supports for parity","user":{"login":"diox","id":187006,"avatar_url":"https://avatars0.githubusercontent.com/u/187006?v=4","gravatar_id":"","url":"https://api.github.com/users/diox","html_url":"https://github.com/diox","followers_url":"https://api.github.com/users/diox/followers","following_url":"https://api.github.com/users/diox/following{/other_user}","gists_url":"https://api.github.com/users/diox/gists{/gist_id}","starred_url":"https://api.github.com/users/diox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diox/subscriptions","organizations_url":"https://api.github.com/users/diox/orgs","repos_url":"https://api.github.com/users/diox/repos","events_url":"https://api.github.com/users/diox/events{/privacy}","received_events_url":"https://api.github.com/users/diox/received_events","type":"User","site_admin":false},"body":"This is a temporary measure while we wait for a better solution like a shared package between the two repos. This is needed because addons-server tries to redirect some URLs, adding missing locales,\r\nand that code trips up on unknown locales.\r\n\r\nFix #7004 ","created_at":"2018-01-31T16:31:47Z","updated_at":"2018-02-01T11:43:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5f3ccb6382e245a921a530698dbecdd469426d2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/addons-server/pulls/7452/commits","review_comments_url":"https://api.github.com/repos/mozilla/addons-server/pulls/7452/comments","review_comment_url":"https://api.github.com/repos/mozilla/addons-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/addons-server/issues/7452/comments","statuses_url":"https://api.github.com/repos/mozilla/addons-server/statuses/83430cb34492f221f2a23e4d8050b2b0e81dbe1e","head":{"label":"diox:locales-parity-with-addons-frontend","ref":"locales-parity-with-addons-frontend","sha":"83430cb34492f221f2a23e4d8050b2b0e81dbe1e","user":{"login":"diox","id":187006,"avatar_url":"https://avatars0.githubusercontent.com/u/187006?v=4","gravatar_id":"","url":"https://api.github.com/users/diox","html_url":"https://github.com/diox","followers_url":"https://api.github.com/users/diox/followers","following_url":"https://api.github.com/users/diox/following{/other_user}","gists_url":"https://api.github.com/users/diox/gists{/gist_id}","starred_url":"https://api.github.com/users/diox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diox/subscriptions","organizations_url":"https://api.github.com/users/diox/orgs","repos_url":"https://api.github.com/users/diox/repos","events_url":"https://api.github.com/users/diox/events{/privacy}","received_events_url":"https://api.github.com/users/diox/received_events","type":"User","site_admin":false},"repo":{"id":16844921,"name":"olympia","full_name":"diox/olympia","owner":{"login":"diox","id":187006,"avatar_url":"https://avatars0.githubusercontent.com/u/187006?v=4","gravatar_id":"","url":"https://api.github.com/users/diox","html_url":"https://github.com/diox","followers_url":"https://api.github.com/users/diox/followers","following_url":"https://api.github.com/users/diox/following{/other_user}","gists_url":"https://api.github.com/users/diox/gists{/gist_id}","starred_url":"https://api.github.com/users/diox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diox/subscriptions","organizations_url":"https://api.github.com/users/diox/orgs","repos_url":"https://api.github.com/users/diox/repos","events_url":"https://api.github.com/users/diox/events{/privacy}","received_events_url":"https://api.github.com/users/diox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/diox/olympia","description":"AMO, reloaded.","fork":true,"url":"https://api.github.com/repos/diox/olympia","forks_url":"https://api.github.com/repos/diox/olympia/forks","keys_url":"https://api.github.com/repos/diox/olympia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diox/olympia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diox/olympia/teams","hooks_url":"https://api.github.com/repos/diox/olympia/hooks","issue_events_url":"https://api.github.com/repos/diox/olympia/issues/events{/number}","events_url":"https://api.github.com/repos/diox/olympia/events","assignees_url":"https://api.github.com/repos/diox/olympia/assignees{/user}","branches_url":"https://api.github.com/repos/diox/olympia/branches{/branch}","tags_url":"https://api.github.com/repos/diox/olympia/tags","blobs_url":"https://api.github.com/repos/diox/olympia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diox/olympia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diox/olympia/git/refs{/sha}","trees_url":"https://api.github.com/repos/diox/olympia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diox/olympia/statuses/{sha}","languages_url":"https://api.github.com/repos/diox/olympia/languages","stargazers_url":"https://api.github.com/repos/diox/olympia/stargazers","contributors_url":"https://api.github.com/repos/diox/olympia/contributors","subscribers_url":"https://api.github.com/repos/diox/olympia/subscribers","subscription_url":"https://api.github.com/repos/diox/olympia/subscription","commits_url":"https://api.github.com/repos/diox/olympia/commits{/sha}","git_commits_url":"https://api.github.com/repos/diox/olympia/git/commits{/sha}","comments_url":"https://api.github.com/repos/diox/olympia/comments{/number}","issue_comment_url":"https://api.github.com/repos/diox/olympia/issues/comments{/number}","contents_url":"https://api.github.com/repos/diox/olympia/contents/{+path}","compare_url":"https://api.github.com/repos/diox/olympia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diox/olympia/merges","archive_url":"https://api.github.com/repos/diox/olympia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diox/olympia/downloads","issues_url":"https://api.github.com/repos/diox/olympia/issues{/number}","pulls_url":"https://api.github.com/repos/diox/olympia/pulls{/number}","milestones_url":"https://api.github.com/repos/diox/olympia/milestones{/number}","notifications_url":"https://api.github.com/repos/diox/olympia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diox/olympia/labels{/name}","releases_url":"https://api.github.com/repos/diox/olympia/releases{/id}","deployments_url":"https://api.github.com/repos/diox/olympia/deployments","created_at":"2014-02-14T17:54:49Z","updated_at":"2014-12-16T18:15:35Z","pushed_at":"2018-01-31T19:24:29Z","git_url":"git://github.com/diox/olympia.git","ssh_url":"git@github.com:diox/olympia.git","clone_url":"https://github.com/diox/olympia.git","svn_url":"https://github.com/diox/olympia","homepage":"","size":833437,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"8360ea1ee715a728813e40cdead6e717dac470de","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":16416867,"name":"addons-server","full_name":"mozilla/addons-server","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/addons-server","description":"🕶 addons.mozilla.org Django app and API 🎉","fork":false,"url":"https://api.github.com/repos/mozilla/addons-server","forks_url":"https://api.github.com/repos/mozilla/addons-server/forks","keys_url":"https://api.github.com/repos/mozilla/addons-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/addons-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/addons-server/teams","hooks_url":"https://api.github.com/repos/mozilla/addons-server/hooks","issue_events_url":"https://api.github.com/repos/mozilla/addons-server/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/addons-server/events","assignees_url":"https://api.github.com/repos/mozilla/addons-server/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/addons-server/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/addons-server/tags","blobs_url":"https://api.github.com/repos/mozilla/addons-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/addons-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/addons-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/addons-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/addons-server/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/addons-server/languages","stargazers_url":"https://api.github.com/repos/mozilla/addons-server/stargazers","contributors_url":"https://api.github.com/repos/mozilla/addons-server/contributors","subscribers_url":"https://api.github.com/repos/mozilla/addons-server/subscribers","subscription_url":"https://api.github.com/repos/mozilla/addons-server/subscription","commits_url":"https://api.github.com/repos/mozilla/addons-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/addons-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/addons-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/addons-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/addons-server/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/addons-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/addons-server/merges","archive_url":"https://api.github.com/repos/mozilla/addons-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/addons-server/downloads","issues_url":"https://api.github.com/repos/mozilla/addons-server/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/addons-server/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/addons-server/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/addons-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/addons-server/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/addons-server/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/addons-server/deployments","created_at":"2014-01-31T18:44:15Z","updated_at":"2018-01-30T12:52:56Z","pushed_at":"2018-02-01T10:51:32Z","git_url":"git://github.com/mozilla/addons-server.git","ssh_url":"git@github.com:mozilla/addons-server.git","clone_url":"https://github.com/mozilla/addons-server.git","svn_url":"https://github.com/mozilla/addons-server","homepage":"https://addons.mozilla.org/","size":838211,"stargazers_count":241,"watchers_count":241,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":275,"mirror_url":null,"archived":false,"open_issues_count":386,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":275,"open_issues":386,"watchers":241,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/7452"},"html":{"href":"https://github.com/mozilla/addons-server/pull/7452"},"issue":{"href":"https://api.github.com/repos/mozilla/addons-server/issues/7452"},"comments":{"href":"https://api.github.com/repos/mozilla/addons-server/issues/7452/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/7452/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/7452/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/addons-server/statuses/83430cb34492f221f2a23e4d8050b2b0e81dbe1e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"EnTeQuAk"}}