{"action":"created","comment":{"url":"https://api.github.com/repos/giantswarm/cluster-operator/pulls/comments/215337001","pull_request_review_id":152578253,"id":215337001,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTMzNzAwMQ==","diff_hunk":"@@ -63,25 +59,57 @@ func TestChartConfigChartsInstalled(t *testing.T) {\n \t\treturn\n \t}\n \n-\tguestNamespace := \"giantswarm\"\n \tguestG8sClient := g.G8sClient()\n \n \t// Wait for chart configs as they may not have been created yet.\n \terr := waitForChartConfigs(guestG8sClient)\n \tif err != nil {\n \t\tt.Fatalf(\"could not get chartconfigs %v\", err)\n \t}\n+}\n+\n+func TestChartConfigPatchDeploy(t *testing.T) {","path":"integration/test/basic/basic_test.go","position":55,"original_position":55,"commit_id":"78c9c3621fc70c6fcc48dd3e621d16ab370053fe","original_commit_id":"cd7a9e68dac6c1b6b309a8ef31bf7e13f384766a","user":{"login":"indyfree","id":3405210,"node_id":"MDQ6VXNlcjM0MDUyMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3405210?v=4","gravatar_id":"","url":"https://api.github.com/users/indyfree","html_url":"https://github.com/indyfree","followers_url":"https://api.github.com/users/indyfree/followers","following_url":"https://api.github.com/users/indyfree/following{/other_user}","gists_url":"https://api.github.com/users/indyfree/gists{/gist_id}","starred_url":"https://api.github.com/users/indyfree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indyfree/subscriptions","organizations_url":"https://api.github.com/users/indyfree/orgs","repos_url":"https://api.github.com/users/indyfree/repos","events_url":"https://api.github.com/users/indyfree/events{/privacy}","received_events_url":"https://api.github.com/users/indyfree/received_events","type":"User","site_admin":false},"body":"Yes I was considering putting it in another package. But since this is closely related I thought its worth the tradeoff to not have another tenant cluster spin up, since cluster-operator e2e are already a pain waiting.","created_at":"2018-09-05T16:18:28Z","updated_at":"2018-09-05T16:18:28Z","html_url":"https://github.com/giantswarm/cluster-operator/pull/227#discussion_r215337001","pull_request_url":"https://api.github.com/repos/giantswarm/cluster-operator/pulls/227","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/giantswarm/cluster-operator/pulls/comments/215337001"},"html":{"href":"https://github.com/giantswarm/cluster-operator/pull/227#discussion_r215337001"},"pull_request":{"href":"https://api.github.com/repos/giantswarm/cluster-operator/pulls/227"}},"in_reply_to_id":213581115},"pull_request":{"url":"https://api.github.com/repos/giantswarm/cluster-operator/pulls/227","id":211661777,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNjYxNzc3","html_url":"https://github.com/giantswarm/cluster-operator/pull/227","diff_url":"https://github.com/giantswarm/cluster-operator/pull/227.diff","patch_url":"https://github.com/giantswarm/cluster-operator/pull/227.patch","issue_url":"https://api.github.com/repos/giantswarm/cluster-operator/issues/227","number":227,"state":"open","locked":false,"title":"Add e2e to patch chartconfig","user":{"login":"indyfree","id":3405210,"node_id":"MDQ6VXNlcjM0MDUyMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3405210?v=4","gravatar_id":"","url":"https://api.github.com/users/indyfree","html_url":"https://github.com/indyfree","followers_url":"https://api.github.com/users/indyfree/followers","following_url":"https://api.github.com/users/indyfree/following{/other_user}","gists_url":"https://api.github.com/users/indyfree/gists{/gist_id}","starred_url":"https://api.github.com/users/indyfree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indyfree/subscriptions","organizations_url":"https://api.github.com/users/indyfree/orgs","repos_url":"https://api.github.com/users/indyfree/repos","events_url":"https://api.github.com/users/indyfree/events{/privacy}","received_events_url":"https://api.github.com/users/indyfree/received_events","type":"User","site_admin":false},"body":"Towards https://github.com/giantswarm/giantswarm/issues/4012\r\n\r\nThis is the preparation for a e2e-test that checks if the new chart will get deployed, when patching the resource. ","created_at":"2018-08-29T08:00:33Z","updated_at":"2018-09-05T16:18:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c821b5c3d883a8c3e2133c837b6f42399b7708a","assignee":{"login":"indyfree","id":3405210,"node_id":"MDQ6VXNlcjM0MDUyMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3405210?v=4","gravatar_id":"","url":"https://api.github.com/users/indyfree","html_url":"https://github.com/indyfree","followers_url":"https://api.github.com/users/indyfree/followers","following_url":"https://api.github.com/users/indyfree/following{/other_user}","gists_url":"https://api.github.com/users/indyfree/gists{/gist_id}","starred_url":"https://api.github.com/users/indyfree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indyfree/subscriptions","organizations_url":"https://api.github.com/users/indyfree/orgs","repos_url":"https://api.github.com/users/indyfree/repos","events_url":"https://api.github.com/users/indyfree/events{/privacy}","received_events_url":"https://api.github.com/users/indyfree/received_events","type":"User","site_admin":false},"assignees":[{"login":"indyfree","id":3405210,"node_id":"MDQ6VXNlcjM0MDUyMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3405210?v=4","gravatar_id":"","url":"https://api.github.com/users/indyfree","html_url":"https://github.com/indyfree","followers_url":"https://api.github.com/users/indyfree/followers","following_url":"https://api.github.com/users/indyfree/following{/other_user}","gists_url":"https://api.github.com/users/indyfree/gists{/gist_id}","starred_url":"https://api.github.com/users/indyfree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indyfree/subscriptions","organizations_url":"https://api.github.com/users/indyfree/orgs","repos_url":"https://api.github.com/users/indyfree/repos","events_url":"https://api.github.com/users/indyfree/events{/privacy}","received_events_url":"https://api.github.com/users/indyfree/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[{"name":"team-batman","id":2564034,"node_id":"MDQ6VGVhbTI1NjQwMzQ=","slug":"team-batman","description":"","privacy":"closed","url":"https://api.github.com/teams/2564034","members_url":"https://api.github.com/teams/2564034/members{/member}","repositories_url":"https://api.github.com/teams/2564034/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/giantswarm/cluster-operator/pulls/227/commits","review_comments_url":"https://api.github.com/repos/giantswarm/cluster-operator/pulls/227/comments","review_comment_url":"https://api.github.com/repos/giantswarm/cluster-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/giantswarm/cluster-operator/issues/227/comments","statuses_url":"https://api.github.com/repos/giantswarm/cluster-operator/statuses/78c9c3621fc70c6fcc48dd3e621d16ab370053fe","head":{"label":"giantswarm:e2e-patch-chartconfig","ref":"e2e-patch-chartconfig","sha":"78c9c3621fc70c6fcc48dd3e621d16ab370053fe","user":{"login":"giantswarm","id":7556340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTYzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":113968263,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM5NjgyNjM=","name":"cluster-operator","full_name":"giantswarm/cluster-operator","owner":{"login":"giantswarm","id":7556340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTYzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/giantswarm/cluster-operator","description":"The cluster-operator is an in-cluster agent that handles Giant Swarm guest cluster specific resources.","fork":false,"url":"https://api.github.com/repos/giantswarm/cluster-operator","forks_url":"https://api.github.com/repos/giantswarm/cluster-operator/forks","keys_url":"https://api.github.com/repos/giantswarm/cluster-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantswarm/cluster-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantswarm/cluster-operator/teams","hooks_url":"https://api.github.com/repos/giantswarm/cluster-operator/hooks","issue_events_url":"https://api.github.com/repos/giantswarm/cluster-operator/issues/events{/number}","events_url":"https://api.github.com/repos/giantswarm/cluster-operator/events","assignees_url":"https://api.github.com/repos/giantswarm/cluster-operator/assignees{/user}","branches_url":"https://api.github.com/repos/giantswarm/cluster-operator/branches{/branch}","tags_url":"https://api.github.com/repos/giantswarm/cluster-operator/tags","blobs_url":"https://api.github.com/repos/giantswarm/cluster-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantswarm/cluster-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantswarm/cluster-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantswarm/cluster-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantswarm/cluster-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/giantswarm/cluster-operator/languages","stargazers_url":"https://api.github.com/repos/giantswarm/cluster-operator/stargazers","contributors_url":"https://api.github.com/repos/giantswarm/cluster-operator/contributors","subscribers_url":"https://api.github.com/repos/giantswarm/cluster-operator/subscribers","subscription_url":"https://api.github.com/repos/giantswarm/cluster-operator/subscription","commits_url":"https://api.github.com/repos/giantswarm/cluster-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantswarm/cluster-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantswarm/cluster-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantswarm/cluster-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantswarm/cluster-operator/contents/{+path}","compare_url":"https://api.github.com/repos/giantswarm/cluster-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantswarm/cluster-operator/merges","archive_url":"https://api.github.com/repos/giantswarm/cluster-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantswarm/cluster-operator/downloads","issues_url":"https://api.github.com/repos/giantswarm/cluster-operator/issues{/number}","pulls_url":"https://api.github.com/repos/giantswarm/cluster-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/giantswarm/cluster-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/giantswarm/cluster-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantswarm/cluster-operator/labels{/name}","releases_url":"https://api.github.com/repos/giantswarm/cluster-operator/releases{/id}","deployments_url":"https://api.github.com/repos/giantswarm/cluster-operator/deployments","created_at":"2017-12-12T09:10:47Z","updated_at":"2018-09-05T09:28:58Z","pushed_at":"2018-09-05T14:44:32Z","git_url":"git://github.com/giantswarm/cluster-operator.git","ssh_url":"git@github.com:giantswarm/cluster-operator.git","clone_url":"https://github.com/giantswarm/cluster-operator.git","svn_url":"https://github.com/giantswarm/cluster-operator","homepage":null,"size":32949,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":4,"watchers":3,"default_branch":"master"}},"base":{"label":"giantswarm:master","ref":"master","sha":"be2942bd837703bf59af84014df71e9a6bb4b555","user":{"login":"giantswarm","id":7556340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTYzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":113968263,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM5NjgyNjM=","name":"cluster-operator","full_name":"giantswarm/cluster-operator","owner":{"login":"giantswarm","id":7556340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTYzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/giantswarm/cluster-operator","description":"The cluster-operator is an in-cluster agent that handles Giant Swarm guest cluster specific resources.","fork":false,"url":"https://api.github.com/repos/giantswarm/cluster-operator","forks_url":"https://api.github.com/repos/giantswarm/cluster-operator/forks","keys_url":"https://api.github.com/repos/giantswarm/cluster-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantswarm/cluster-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantswarm/cluster-operator/teams","hooks_url":"https://api.github.com/repos/giantswarm/cluster-operator/hooks","issue_events_url":"https://api.github.com/repos/giantswarm/cluster-operator/issues/events{/number}","events_url":"https://api.github.com/repos/giantswarm/cluster-operator/events","assignees_url":"https://api.github.com/repos/giantswarm/cluster-operator/assignees{/user}","branches_url":"https://api.github.com/repos/giantswarm/cluster-operator/branches{/branch}","tags_url":"https://api.github.com/repos/giantswarm/cluster-operator/tags","blobs_url":"https://api.github.com/repos/giantswarm/cluster-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantswarm/cluster-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantswarm/cluster-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantswarm/cluster-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantswarm/cluster-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/giantswarm/cluster-operator/languages","stargazers_url":"https://api.github.com/repos/giantswarm/cluster-operator/stargazers","contributors_url":"https://api.github.com/repos/giantswarm/cluster-operator/contributors","subscribers_url":"https://api.github.com/repos/giantswarm/cluster-operator/subscribers","subscription_url":"https://api.github.com/repos/giantswarm/cluster-operator/subscription","commits_url":"https://api.github.com/repos/giantswarm/cluster-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantswarm/cluster-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantswarm/cluster-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantswarm/cluster-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantswarm/cluster-operator/contents/{+path}","compare_url":"https://api.github.com/repos/giantswarm/cluster-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantswarm/cluster-operator/merges","archive_url":"https://api.github.com/repos/giantswarm/cluster-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantswarm/cluster-operator/downloads","issues_url":"https://api.github.com/repos/giantswarm/cluster-operator/issues{/number}","pulls_url":"https://api.github.com/repos/giantswarm/cluster-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/giantswarm/cluster-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/giantswarm/cluster-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantswarm/cluster-operator/labels{/name}","releases_url":"https://api.github.com/repos/giantswarm/cluster-operator/releases{/id}","deployments_url":"https://api.github.com/repos/giantswarm/cluster-operator/deployments","created_at":"2017-12-12T09:10:47Z","updated_at":"2018-09-05T09:28:58Z","pushed_at":"2018-09-05T14:44:32Z","git_url":"git://github.com/giantswarm/cluster-operator.git","ssh_url":"git@github.com:giantswarm/cluster-operator.git","clone_url":"https://github.com/giantswarm/cluster-operator.git","svn_url":"https://github.com/giantswarm/cluster-operator","homepage":null,"size":32949,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":4,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/giantswarm/cluster-operator/pulls/227"},"html":{"href":"https://github.com/giantswarm/cluster-operator/pull/227"},"issue":{"href":"https://api.github.com/repos/giantswarm/cluster-operator/issues/227"},"comments":{"href":"https://api.github.com/repos/giantswarm/cluster-operator/issues/227/comments"},"review_comments":{"href":"https://api.github.com/repos/giantswarm/cluster-operator/pulls/227/comments"},"review_comment":{"href":"https://api.github.com/repos/giantswarm/cluster-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/giantswarm/cluster-operator/pulls/227/commits"},"statuses":{"href":"https://api.github.com/repos/giantswarm/cluster-operator/statuses/78c9c3621fc70c6fcc48dd3e621d16ab370053fe"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"indyfree"}}