{"action":"created","issue":{"url":"https://api.github.com/repos/euvl/vue-js-modal/issues/340","repository_url":"https://api.github.com/repos/euvl/vue-js-modal","labels_url":"https://api.github.com/repos/euvl/vue-js-modal/issues/340/labels{/name}","comments_url":"https://api.github.com/repos/euvl/vue-js-modal/issues/340/comments","events_url":"https://api.github.com/repos/euvl/vue-js-modal/issues/340/events","html_url":"https://github.com/euvl/vue-js-modal/issues/340","id":369302516,"node_id":"MDU6SXNzdWUzNjkzMDI1MTY=","number":340,"title":"Common props for modal-container","user":{"login":"suhodolskiy","id":8992530,"node_id":"MDQ6VXNlcjg5OTI1MzA=","avatar_url":"https://avatars3.githubusercontent.com/u/8992530?v=4","gravatar_id":"","url":"https://api.github.com/users/suhodolskiy","html_url":"https://github.com/suhodolskiy","followers_url":"https://api.github.com/users/suhodolskiy/followers","following_url":"https://api.github.com/users/suhodolskiy/following{/other_user}","gists_url":"https://api.github.com/users/suhodolskiy/gists{/gist_id}","starred_url":"https://api.github.com/users/suhodolskiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suhodolskiy/subscriptions","organizations_url":"https://api.github.com/users/suhodolskiy/orgs","repos_url":"https://api.github.com/users/suhodolskiy/repos","events_url":"https://api.github.com/users/suhodolskiy/events{/privacy}","received_events_url":"https://api.github.com/users/suhodolskiy/received_events","type":"User","site_admin":false},"labels":[{"id":481242191,"node_id":"MDU6TGFiZWw0ODEyNDIxOTE=","url":"https://api.github.com/repos/euvl/vue-js-modal/labels/enhancement","name":"enhancement","color":"0052cc","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-11T20:58:25Z","updated_at":"2018-12-17T14:40:54Z","closed_at":null,"author_association":"NONE","body":"Hello! Why not add common props/actions (height, width, before-close) to the `<modal-container>`? That would not prescribe every time you call the show method 🤔\r\n\r\nBad: \r\n```js\r\nthis.$modal.show(ProductManageModal, { product: data }, { width: 600, height: 'auto', classes: '...' }, { 'before-close': unlockViewport, 'before-open': lockViewport })\r\nthis.$modal.show(OrderManageModal, { product: data }, { width: 600, height: 'auto', classes: '...' }, { 'before-close': unlockViewport, 'before-open': lockViewport })\r\n...\r\n\r\n```\r\nAnd repeating the same when calling others modals\r\n\r\nGood:\r\n```js\r\n<modal-container @before-close=\"\" @before-open=\"\" height=\"\">\r\n```\r\nAnd if you need to redefine when calling `$modal.show(...)`\r\n\r\nThanks 🙂 "},"comment":{"url":"https://api.github.com/repos/euvl/vue-js-modal/issues/comments/447868482","html_url":"https://github.com/euvl/vue-js-modal/issues/340#issuecomment-447868482","issue_url":"https://api.github.com/repos/euvl/vue-js-modal/issues/340","id":447868482,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Nzg2ODQ4Mg==","user":{"login":"stale[bot]","id":26384082,"node_id":"MDM6Qm90MjYzODQwODI=","avatar_url":"https://avatars3.githubusercontent.com/in/1724?v=4","gravatar_id":"","url":"https://api.github.com/users/stale%5Bbot%5D","html_url":"https://github.com/apps/stale","followers_url":"https://api.github.com/users/stale%5Bbot%5D/followers","following_url":"https://api.github.com/users/stale%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/stale%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/stale%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stale%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/stale%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/stale%5Bbot%5D/repos","events_url":"https://api.github.com/users/stale%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/stale%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-12-17T14:40:54Z","updated_at":"2018-12-17T14:40:54Z","author_association":"NONE","body":"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n"}}
{"actor":{"display_login":"stale"}}