{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/comments/225744328","pull_request_review_id":165412603,"id":225744328,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTc0NDMyOA==","diff_hunk":"@@ -82,7 +116,7 @@ private ReactChoreographer(CoreApplicationView applicationView)\n         public event EventHandler<FrameEventArgs> IdleCallback;\n \n         /// <summary>\n-        /// The choreographer instance.\n+        /// The choreographer main instance.\n         /// </summary>\n         public static IReactChoreographer Instance","path":"ReactWindows/ReactNative.Shared/Modules/Core/ReactChoreographer.cs","position":65,"original_position":65,"commit_id":"23248819b9920e65f8f44e0fbdcbf9434ce3f89b","original_commit_id":"23248819b9920e65f8f44e0fbdcbf9434ce3f89b","user":{"login":"reseul","id":11672053,"node_id":"MDQ6VXNlcjExNjcyMDUz","avatar_url":"https://avatars3.githubusercontent.com/u/11672053?v=4","gravatar_id":"","url":"https://api.github.com/users/reseul","html_url":"https://github.com/reseul","followers_url":"https://api.github.com/users/reseul/followers","following_url":"https://api.github.com/users/reseul/following{/other_user}","gists_url":"https://api.github.com/users/reseul/gists{/gist_id}","starred_url":"https://api.github.com/users/reseul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reseul/subscriptions","organizations_url":"https://api.github.com/users/reseul/orgs","repos_url":"https://api.github.com/users/reseul/repos","events_url":"https://api.github.com/users/reseul/events{/privacy}","received_events_url":"https://api.github.com/users/reseul/received_events","type":"User","site_admin":false},"body":"I think I know where you're headed, but ReactChoreographer.Instance is called from random threads (module one, etc.), making any thread affinity dangerous.\r\n\r\n---\r\nIn reply to: [225740827](https://github.com/Microsoft/react-native-windows/pull/2000#discussion_r225740827) [](ancestors = 225740827)","created_at":"2018-10-16T23:54:21Z","updated_at":"2018-10-16T23:54:21Z","html_url":"https://github.com/Microsoft/react-native-windows/pull/2000#discussion_r225744328","pull_request_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/2000","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/comments/225744328"},"html":{"href":"https://github.com/Microsoft/react-native-windows/pull/2000#discussion_r225744328"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/2000"}},"in_reply_to_id":225740827},"pull_request":{"url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/2000","id":223057601,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMDU3NjAx","html_url":"https://github.com/Microsoft/react-native-windows/pull/2000","diff_url":"https://github.com/Microsoft/react-native-windows/pull/2000.diff","patch_url":"https://github.com/Microsoft/react-native-windows/pull/2000.patch","issue_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues/2000","number":2000,"state":"open","locked":false,"title":"Per instance ReactChoreographer accessor","user":{"login":"reseul","id":11672053,"node_id":"MDQ6VXNlcjExNjcyMDUz","avatar_url":"https://avatars3.githubusercontent.com/u/11672053?v=4","gravatar_id":"","url":"https://api.github.com/users/reseul","html_url":"https://github.com/reseul","followers_url":"https://api.github.com/users/reseul/followers","following_url":"https://api.github.com/users/reseul/following{/other_user}","gists_url":"https://api.github.com/users/reseul/gists{/gist_id}","starred_url":"https://api.github.com/users/reseul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reseul/subscriptions","organizations_url":"https://api.github.com/users/reseul/orgs","repos_url":"https://api.github.com/users/reseul/repos","events_url":"https://api.github.com/users/reseul/events{/privacy}","received_events_url":"https://api.github.com/users/reseul/received_events","type":"User","site_admin":false},"body":"An accessor that can be used to access a ReactChoreographer pertaining to a particular top level window.\r\nCan be used to hook custom animations/etc into the correct choreographer.","created_at":"2018-10-15T22:05:31Z","updated_at":"2018-10-16T23:54:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85de3c8f080d70aa7dc82bc1f1d2a196b51ebae6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/2000/commits","review_comments_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/2000/comments","review_comment_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues/2000/comments","statuses_url":"https://api.github.com/repos/Microsoft/react-native-windows/statuses/23248819b9920e65f8f44e0fbdcbf9434ce3f89b","head":{"label":"reseul:port_perinst_ch","ref":"port_perinst_ch","sha":"23248819b9920e65f8f44e0fbdcbf9434ce3f89b","user":{"login":"reseul","id":11672053,"node_id":"MDQ6VXNlcjExNjcyMDUz","avatar_url":"https://avatars3.githubusercontent.com/u/11672053?v=4","gravatar_id":"","url":"https://api.github.com/users/reseul","html_url":"https://github.com/reseul","followers_url":"https://api.github.com/users/reseul/followers","following_url":"https://api.github.com/users/reseul/following{/other_user}","gists_url":"https://api.github.com/users/reseul/gists{/gist_id}","starred_url":"https://api.github.com/users/reseul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reseul/subscriptions","organizations_url":"https://api.github.com/users/reseul/orgs","repos_url":"https://api.github.com/users/reseul/repos","events_url":"https://api.github.com/users/reseul/events{/privacy}","received_events_url":"https://api.github.com/users/reseul/received_events","type":"User","site_admin":false},"repo":{"id":113353887,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMzNTM4ODc=","name":"react-native-windows","full_name":"reseul/react-native-windows","private":false,"owner":{"login":"reseul","id":11672053,"node_id":"MDQ6VXNlcjExNjcyMDUz","avatar_url":"https://avatars3.githubusercontent.com/u/11672053?v=4","gravatar_id":"","url":"https://api.github.com/users/reseul","html_url":"https://github.com/reseul","followers_url":"https://api.github.com/users/reseul/followers","following_url":"https://api.github.com/users/reseul/following{/other_user}","gists_url":"https://api.github.com/users/reseul/gists{/gist_id}","starred_url":"https://api.github.com/users/reseul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reseul/subscriptions","organizations_url":"https://api.github.com/users/reseul/orgs","repos_url":"https://api.github.com/users/reseul/repos","events_url":"https://api.github.com/users/reseul/events{/privacy}","received_events_url":"https://api.github.com/users/reseul/received_events","type":"User","site_admin":false},"html_url":"https://github.com/reseul/react-native-windows","description":"A framework for building native UWP and WPF apps with React.","fork":true,"url":"https://api.github.com/repos/reseul/react-native-windows","forks_url":"https://api.github.com/repos/reseul/react-native-windows/forks","keys_url":"https://api.github.com/repos/reseul/react-native-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reseul/react-native-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reseul/react-native-windows/teams","hooks_url":"https://api.github.com/repos/reseul/react-native-windows/hooks","issue_events_url":"https://api.github.com/repos/reseul/react-native-windows/issues/events{/number}","events_url":"https://api.github.com/repos/reseul/react-native-windows/events","assignees_url":"https://api.github.com/repos/reseul/react-native-windows/assignees{/user}","branches_url":"https://api.github.com/repos/reseul/react-native-windows/branches{/branch}","tags_url":"https://api.github.com/repos/reseul/react-native-windows/tags","blobs_url":"https://api.github.com/repos/reseul/react-native-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reseul/react-native-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reseul/react-native-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/reseul/react-native-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reseul/react-native-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/reseul/react-native-windows/languages","stargazers_url":"https://api.github.com/repos/reseul/react-native-windows/stargazers","contributors_url":"https://api.github.com/repos/reseul/react-native-windows/contributors","subscribers_url":"https://api.github.com/repos/reseul/react-native-windows/subscribers","subscription_url":"https://api.github.com/repos/reseul/react-native-windows/subscription","commits_url":"https://api.github.com/repos/reseul/react-native-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/reseul/react-native-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/reseul/react-native-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/reseul/react-native-windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/reseul/react-native-windows/contents/{+path}","compare_url":"https://api.github.com/repos/reseul/react-native-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reseul/react-native-windows/merges","archive_url":"https://api.github.com/repos/reseul/react-native-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reseul/react-native-windows/downloads","issues_url":"https://api.github.com/repos/reseul/react-native-windows/issues{/number}","pulls_url":"https://api.github.com/repos/reseul/react-native-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/reseul/react-native-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/reseul/react-native-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reseul/react-native-windows/labels{/name}","releases_url":"https://api.github.com/repos/reseul/react-native-windows/releases{/id}","deployments_url":"https://api.github.com/repos/reseul/react-native-windows/deployments","created_at":"2017-12-06T18:40:10Z","updated_at":"2018-10-12T21:29:49Z","pushed_at":"2018-10-16T23:45:51Z","git_url":"git://github.com/reseul/react-native-windows.git","ssh_url":"git@github.com:reseul/react-native-windows.git","clone_url":"https://github.com/reseul/react-native-windows.git","svn_url":"https://github.com/reseul/react-native-windows","homepage":"http://facebook.github.io/react-native/","size":22115,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"6125d90c6002c3d4b09e624e719e4656262f851e","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":48009214,"node_id":"MDEwOlJlcG9zaXRvcnk0ODAwOTIxNA==","name":"react-native-windows","full_name":"Microsoft/react-native-windows","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/react-native-windows","description":"A framework for building native UWP and WPF apps with React.","fork":false,"url":"https://api.github.com/repos/Microsoft/react-native-windows","forks_url":"https://api.github.com/repos/Microsoft/react-native-windows/forks","keys_url":"https://api.github.com/repos/Microsoft/react-native-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/react-native-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/react-native-windows/teams","hooks_url":"https://api.github.com/repos/Microsoft/react-native-windows/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/react-native-windows/events","assignees_url":"https://api.github.com/repos/Microsoft/react-native-windows/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/react-native-windows/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/react-native-windows/tags","blobs_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/react-native-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/react-native-windows/languages","stargazers_url":"https://api.github.com/repos/Microsoft/react-native-windows/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/react-native-windows/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/react-native-windows/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/react-native-windows/subscription","commits_url":"https://api.github.com/repos/Microsoft/react-native-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/react-native-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/react-native-windows/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/react-native-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/react-native-windows/merges","archive_url":"https://api.github.com/repos/Microsoft/react-native-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/react-native-windows/downloads","issues_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/react-native-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/react-native-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/react-native-windows/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/react-native-windows/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/react-native-windows/deployments","created_at":"2015-12-15T00:16:54Z","updated_at":"2018-10-16T23:48:15Z","pushed_at":"2018-10-16T23:46:51Z","git_url":"git://github.com/Microsoft/react-native-windows.git","ssh_url":"git@github.com:Microsoft/react-native-windows.git","clone_url":"https://github.com/Microsoft/react-native-windows.git","svn_url":"https://github.com/Microsoft/react-native-windows","homepage":"http://facebook.github.io/react-native/","size":160873,"stargazers_count":5485,"watchers_count":5485,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":444,"mirror_url":null,"archived":false,"open_issues_count":193,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":444,"open_issues":193,"watchers":5485,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/2000"},"html":{"href":"https://github.com/Microsoft/react-native-windows/pull/2000"},"issue":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/issues/2000"},"comments":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/issues/2000/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/2000/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/2000/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/statuses/23248819b9920e65f8f44e0fbdcbf9434ce3f89b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"reseul"}}