{"action":"created","comment":{"url":"https://api.github.com/repos/all-of-us/workbench/pulls/comments/176545616","pull_request_review_id":106269300,"id":176545616,"diff_hunk":"@@ -33,10 +34,15 @@ const routes: Routes = [\n     path: 'data-browser/browse',\n     component: SearchComponent,\n     data: {title: 'Browse'}\n+  }, {\n+    path: 'login',\n+    component: SignedOutComponent,","path":"ui/src/app/app-routing.module.ts","position":14,"original_position":14,"commit_id":"0022d7a402e661338471fa96493610035b75e4ad","original_commit_id":"0022d7a402e661338471fa96493610035b75e4ad","user":{"login":"blrubenstein","id":15351021,"avatar_url":"https://avatars0.githubusercontent.com/u/15351021?v=4","gravatar_id":"","url":"https://api.github.com/users/blrubenstein","html_url":"https://github.com/blrubenstein","followers_url":"https://api.github.com/users/blrubenstein/followers","following_url":"https://api.github.com/users/blrubenstein/following{/other_user}","gists_url":"https://api.github.com/users/blrubenstein/gists{/gist_id}","starred_url":"https://api.github.com/users/blrubenstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blrubenstein/subscriptions","organizations_url":"https://api.github.com/users/blrubenstein/orgs","repos_url":"https://api.github.com/users/blrubenstein/repos","events_url":"https://api.github.com/users/blrubenstein/events{/privacy}","received_events_url":"https://api.github.com/users/blrubenstein/received_events","type":"User","site_admin":false},"body":"I can definitely go for LoginPage? But I'm not sure what I would do for SignedInComponent that was more descriptive?","created_at":"2018-03-22T19:28:51Z","updated_at":"2018-03-22T19:33:28Z","html_url":"https://github.com/all-of-us/workbench/pull/636#discussion_r176545616","pull_request_url":"https://api.github.com/repos/all-of-us/workbench/pulls/636","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/comments/176545616"},"html":{"href":"https://github.com/all-of-us/workbench/pull/636#discussion_r176545616"},"pull_request":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/636"}},"in_reply_to_id":176536079},"pull_request":{"url":"https://api.github.com/repos/all-of-us/workbench/pulls/636","id":176872341,"html_url":"https://github.com/all-of-us/workbench/pull/636","diff_url":"https://github.com/all-of-us/workbench/pull/636.diff","patch_url":"https://github.com/all-of-us/workbench/pull/636.patch","issue_url":"https://api.github.com/repos/all-of-us/workbench/issues/636","number":636,"state":"open","locked":false,"title":"Blrubenstein/new signin method","user":{"login":"blrubenstein","id":15351021,"avatar_url":"https://avatars0.githubusercontent.com/u/15351021?v=4","gravatar_id":"","url":"https://api.github.com/users/blrubenstein","html_url":"https://github.com/blrubenstein","followers_url":"https://api.github.com/users/blrubenstein/followers","following_url":"https://api.github.com/users/blrubenstein/following{/other_user}","gists_url":"https://api.github.com/users/blrubenstein/gists{/gist_id}","starred_url":"https://api.github.com/users/blrubenstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blrubenstein/subscriptions","organizations_url":"https://api.github.com/users/blrubenstein/orgs","repos_url":"https://api.github.com/users/blrubenstein/repos","events_url":"https://api.github.com/users/blrubenstein/events{/privacy}","received_events_url":"https://api.github.com/users/blrubenstein/received_events","type":"User","site_admin":false},"body":"Still need to rebase, but this is the basics! \r\n\r\n(edit: Rebase has happened.)","created_at":"2018-03-22T18:36:58Z","updated_at":"2018-03-22T19:33:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14d6717925562e9ab4f607509f29d27b49bbe0e2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dmohs","id":1545444,"avatar_url":"https://avatars2.githubusercontent.com/u/1545444?v=4","gravatar_id":"","url":"https://api.github.com/users/dmohs","html_url":"https://github.com/dmohs","followers_url":"https://api.github.com/users/dmohs/followers","following_url":"https://api.github.com/users/dmohs/following{/other_user}","gists_url":"https://api.github.com/users/dmohs/gists{/gist_id}","starred_url":"https://api.github.com/users/dmohs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmohs/subscriptions","organizations_url":"https://api.github.com/users/dmohs/orgs","repos_url":"https://api.github.com/users/dmohs/repos","events_url":"https://api.github.com/users/dmohs/events{/privacy}","received_events_url":"https://api.github.com/users/dmohs/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/all-of-us/workbench/pulls/636/commits","review_comments_url":"https://api.github.com/repos/all-of-us/workbench/pulls/636/comments","review_comment_url":"https://api.github.com/repos/all-of-us/workbench/pulls/comments{/number}","comments_url":"https://api.github.com/repos/all-of-us/workbench/issues/636/comments","statuses_url":"https://api.github.com/repos/all-of-us/workbench/statuses/0022d7a402e661338471fa96493610035b75e4ad","head":{"label":"all-of-us:blrubenstein/new-signin-method","ref":"blrubenstein/new-signin-method","sha":"0022d7a402e661338471fa96493610035b75e4ad","user":{"login":"all-of-us","id":22846942,"avatar_url":"https://avatars0.githubusercontent.com/u/22846942?v=4","gravatar_id":"","url":"https://api.github.com/users/all-of-us","html_url":"https://github.com/all-of-us","followers_url":"https://api.github.com/users/all-of-us/followers","following_url":"https://api.github.com/users/all-of-us/following{/other_user}","gists_url":"https://api.github.com/users/all-of-us/gists{/gist_id}","starred_url":"https://api.github.com/users/all-of-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all-of-us/subscriptions","organizations_url":"https://api.github.com/users/all-of-us/orgs","repos_url":"https://api.github.com/users/all-of-us/repos","events_url":"https://api.github.com/users/all-of-us/events{/privacy}","received_events_url":"https://api.github.com/users/all-of-us/received_events","type":"Organization","site_admin":false},"repo":{"id":95247186,"name":"workbench","full_name":"all-of-us/workbench","owner":{"login":"all-of-us","id":22846942,"avatar_url":"https://avatars0.githubusercontent.com/u/22846942?v=4","gravatar_id":"","url":"https://api.github.com/users/all-of-us","html_url":"https://github.com/all-of-us","followers_url":"https://api.github.com/users/all-of-us/followers","following_url":"https://api.github.com/users/all-of-us/following{/other_user}","gists_url":"https://api.github.com/users/all-of-us/gists{/gist_id}","starred_url":"https://api.github.com/users/all-of-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all-of-us/subscriptions","organizations_url":"https://api.github.com/users/all-of-us/orgs","repos_url":"https://api.github.com/users/all-of-us/repos","events_url":"https://api.github.com/users/all-of-us/events{/privacy}","received_events_url":"https://api.github.com/users/all-of-us/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/all-of-us/workbench","description":null,"fork":false,"url":"https://api.github.com/repos/all-of-us/workbench","forks_url":"https://api.github.com/repos/all-of-us/workbench/forks","keys_url":"https://api.github.com/repos/all-of-us/workbench/keys{/key_id}","collaborators_url":"https://api.github.com/repos/all-of-us/workbench/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/all-of-us/workbench/teams","hooks_url":"https://api.github.com/repos/all-of-us/workbench/hooks","issue_events_url":"https://api.github.com/repos/all-of-us/workbench/issues/events{/number}","events_url":"https://api.github.com/repos/all-of-us/workbench/events","assignees_url":"https://api.github.com/repos/all-of-us/workbench/assignees{/user}","branches_url":"https://api.github.com/repos/all-of-us/workbench/branches{/branch}","tags_url":"https://api.github.com/repos/all-of-us/workbench/tags","blobs_url":"https://api.github.com/repos/all-of-us/workbench/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/all-of-us/workbench/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/all-of-us/workbench/git/refs{/sha}","trees_url":"https://api.github.com/repos/all-of-us/workbench/git/trees{/sha}","statuses_url":"https://api.github.com/repos/all-of-us/workbench/statuses/{sha}","languages_url":"https://api.github.com/repos/all-of-us/workbench/languages","stargazers_url":"https://api.github.com/repos/all-of-us/workbench/stargazers","contributors_url":"https://api.github.com/repos/all-of-us/workbench/contributors","subscribers_url":"https://api.github.com/repos/all-of-us/workbench/subscribers","subscription_url":"https://api.github.com/repos/all-of-us/workbench/subscription","commits_url":"https://api.github.com/repos/all-of-us/workbench/commits{/sha}","git_commits_url":"https://api.github.com/repos/all-of-us/workbench/git/commits{/sha}","comments_url":"https://api.github.com/repos/all-of-us/workbench/comments{/number}","issue_comment_url":"https://api.github.com/repos/all-of-us/workbench/issues/comments{/number}","contents_url":"https://api.github.com/repos/all-of-us/workbench/contents/{+path}","compare_url":"https://api.github.com/repos/all-of-us/workbench/compare/{base}...{head}","merges_url":"https://api.github.com/repos/all-of-us/workbench/merges","archive_url":"https://api.github.com/repos/all-of-us/workbench/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/all-of-us/workbench/downloads","issues_url":"https://api.github.com/repos/all-of-us/workbench/issues{/number}","pulls_url":"https://api.github.com/repos/all-of-us/workbench/pulls{/number}","milestones_url":"https://api.github.com/repos/all-of-us/workbench/milestones{/number}","notifications_url":"https://api.github.com/repos/all-of-us/workbench/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/all-of-us/workbench/labels{/name}","releases_url":"https://api.github.com/repos/all-of-us/workbench/releases{/id}","deployments_url":"https://api.github.com/repos/all-of-us/workbench/deployments","created_at":"2017-06-23T18:44:24Z","updated_at":"2018-03-22T16:21:46Z","pushed_at":"2018-03-22T19:28:41Z","git_url":"git://github.com/all-of-us/workbench.git","ssh_url":"git@github.com:all-of-us/workbench.git","clone_url":"https://github.com/all-of-us/workbench.git","svn_url":"https://github.com/all-of-us/workbench","homepage":null,"size":62479,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":1,"open_issues":10,"watchers":3,"default_branch":"master"}},"base":{"label":"all-of-us:master","ref":"master","sha":"6af98868f7b3e5c715757bce2931ca1651d08f3a","user":{"login":"all-of-us","id":22846942,"avatar_url":"https://avatars0.githubusercontent.com/u/22846942?v=4","gravatar_id":"","url":"https://api.github.com/users/all-of-us","html_url":"https://github.com/all-of-us","followers_url":"https://api.github.com/users/all-of-us/followers","following_url":"https://api.github.com/users/all-of-us/following{/other_user}","gists_url":"https://api.github.com/users/all-of-us/gists{/gist_id}","starred_url":"https://api.github.com/users/all-of-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all-of-us/subscriptions","organizations_url":"https://api.github.com/users/all-of-us/orgs","repos_url":"https://api.github.com/users/all-of-us/repos","events_url":"https://api.github.com/users/all-of-us/events{/privacy}","received_events_url":"https://api.github.com/users/all-of-us/received_events","type":"Organization","site_admin":false},"repo":{"id":95247186,"name":"workbench","full_name":"all-of-us/workbench","owner":{"login":"all-of-us","id":22846942,"avatar_url":"https://avatars0.githubusercontent.com/u/22846942?v=4","gravatar_id":"","url":"https://api.github.com/users/all-of-us","html_url":"https://github.com/all-of-us","followers_url":"https://api.github.com/users/all-of-us/followers","following_url":"https://api.github.com/users/all-of-us/following{/other_user}","gists_url":"https://api.github.com/users/all-of-us/gists{/gist_id}","starred_url":"https://api.github.com/users/all-of-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all-of-us/subscriptions","organizations_url":"https://api.github.com/users/all-of-us/orgs","repos_url":"https://api.github.com/users/all-of-us/repos","events_url":"https://api.github.com/users/all-of-us/events{/privacy}","received_events_url":"https://api.github.com/users/all-of-us/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/all-of-us/workbench","description":null,"fork":false,"url":"https://api.github.com/repos/all-of-us/workbench","forks_url":"https://api.github.com/repos/all-of-us/workbench/forks","keys_url":"https://api.github.com/repos/all-of-us/workbench/keys{/key_id}","collaborators_url":"https://api.github.com/repos/all-of-us/workbench/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/all-of-us/workbench/teams","hooks_url":"https://api.github.com/repos/all-of-us/workbench/hooks","issue_events_url":"https://api.github.com/repos/all-of-us/workbench/issues/events{/number}","events_url":"https://api.github.com/repos/all-of-us/workbench/events","assignees_url":"https://api.github.com/repos/all-of-us/workbench/assignees{/user}","branches_url":"https://api.github.com/repos/all-of-us/workbench/branches{/branch}","tags_url":"https://api.github.com/repos/all-of-us/workbench/tags","blobs_url":"https://api.github.com/repos/all-of-us/workbench/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/all-of-us/workbench/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/all-of-us/workbench/git/refs{/sha}","trees_url":"https://api.github.com/repos/all-of-us/workbench/git/trees{/sha}","statuses_url":"https://api.github.com/repos/all-of-us/workbench/statuses/{sha}","languages_url":"https://api.github.com/repos/all-of-us/workbench/languages","stargazers_url":"https://api.github.com/repos/all-of-us/workbench/stargazers","contributors_url":"https://api.github.com/repos/all-of-us/workbench/contributors","subscribers_url":"https://api.github.com/repos/all-of-us/workbench/subscribers","subscription_url":"https://api.github.com/repos/all-of-us/workbench/subscription","commits_url":"https://api.github.com/repos/all-of-us/workbench/commits{/sha}","git_commits_url":"https://api.github.com/repos/all-of-us/workbench/git/commits{/sha}","comments_url":"https://api.github.com/repos/all-of-us/workbench/comments{/number}","issue_comment_url":"https://api.github.com/repos/all-of-us/workbench/issues/comments{/number}","contents_url":"https://api.github.com/repos/all-of-us/workbench/contents/{+path}","compare_url":"https://api.github.com/repos/all-of-us/workbench/compare/{base}...{head}","merges_url":"https://api.github.com/repos/all-of-us/workbench/merges","archive_url":"https://api.github.com/repos/all-of-us/workbench/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/all-of-us/workbench/downloads","issues_url":"https://api.github.com/repos/all-of-us/workbench/issues{/number}","pulls_url":"https://api.github.com/repos/all-of-us/workbench/pulls{/number}","milestones_url":"https://api.github.com/repos/all-of-us/workbench/milestones{/number}","notifications_url":"https://api.github.com/repos/all-of-us/workbench/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/all-of-us/workbench/labels{/name}","releases_url":"https://api.github.com/repos/all-of-us/workbench/releases{/id}","deployments_url":"https://api.github.com/repos/all-of-us/workbench/deployments","created_at":"2017-06-23T18:44:24Z","updated_at":"2018-03-22T16:21:46Z","pushed_at":"2018-03-22T19:28:41Z","git_url":"git://github.com/all-of-us/workbench.git","ssh_url":"git@github.com:all-of-us/workbench.git","clone_url":"https://github.com/all-of-us/workbench.git","svn_url":"https://github.com/all-of-us/workbench","homepage":null,"size":62479,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":1,"open_issues":10,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/636"},"html":{"href":"https://github.com/all-of-us/workbench/pull/636"},"issue":{"href":"https://api.github.com/repos/all-of-us/workbench/issues/636"},"comments":{"href":"https://api.github.com/repos/all-of-us/workbench/issues/636/comments"},"review_comments":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/636/comments"},"review_comment":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/636/commits"},"statuses":{"href":"https://api.github.com/repos/all-of-us/workbench/statuses/0022d7a402e661338471fa96493610035b75e4ad"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"blrubenstein"}}