{"action":"created","comment":{"url":"https://api.github.com/repos/LCOGT/banzai/pulls/comments/212454066","pull_request_review_id":149093714,"id":212454066,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjQ1NDA2Ng==","diff_hunk":"@@ -211,16 +211,19 @@ def apply_master_calibration(self, images, master_calibration_image, logging_tag\n             qc_results = {\"master_comparison.fraction\": bad_pixel_fraction,\n                           \"master_comparison.snr_threshold\": self.SIGNAL_TO_NOISE_THRESHOLD,\n                           \"master_comparison.pixel_threshold\": self.ACCEPTABLE_PIXEL_FRACTION,\n-                          \"master_comparison.failed\": frame_is_bad,\n                           \"master_comparison.comparison_master_filename\": master_calibration_image.filename}\n \n             for qc_check, qc_result in qc_results.items():\n                 logs.add_tag(logging_tags, qc_check, qc_result)\n             logs.add_tag(logging_tags, 'filename', image.filename)\n             logs.add_tag(logging_tags, 'master_comparison_filename', master_calibration_image.filename)\n+\n             self.logger.info(\"Performing comparison to last good master {caltype} frame\".format(\n                 caltype=self.calibration_type), extra=logging_tags)","path":"banzai/stages.py","position":13,"original_position":13,"commit_id":"902235038e134b7ec0f33e1a43b71d78fe4daedf","original_commit_id":"902235038e134b7ec0f33e1a43b71d78fe4daedf","user":{"login":"cmccully","id":5331996,"node_id":"MDQ6VXNlcjUzMzE5OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/5331996?v=4","gravatar_id":"","url":"https://api.github.com/users/cmccully","html_url":"https://github.com/cmccully","followers_url":"https://api.github.com/users/cmccully/followers","following_url":"https://api.github.com/users/cmccully/following{/other_user}","gists_url":"https://api.github.com/users/cmccully/gists{/gist_id}","starred_url":"https://api.github.com/users/cmccully/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmccully/subscriptions","organizations_url":"https://api.github.com/users/cmccully/orgs","repos_url":"https://api.github.com/users/cmccully/repos","events_url":"https://api.github.com/users/cmccully/events{/privacy}","received_events_url":"https://api.github.com/users/cmccully/received_events","type":"User","site_admin":false},"body":"While you are here, this is weird spacing. It would be better to define a message variable and then call format in a separate line.","created_at":"2018-08-23T20:54:52Z","updated_at":"2018-08-23T20:55:12Z","html_url":"https://github.com/LCOGT/banzai/pull/124#discussion_r212454066","pull_request_url":"https://api.github.com/repos/LCOGT/banzai/pulls/124","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/LCOGT/banzai/pulls/comments/212454066"},"html":{"href":"https://github.com/LCOGT/banzai/pull/124#discussion_r212454066"},"pull_request":{"href":"https://api.github.com/repos/LCOGT/banzai/pulls/124"}}},"pull_request":{"url":"https://api.github.com/repos/LCOGT/banzai/pulls/124","id":210509159,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNTA5MTU5","html_url":"https://github.com/LCOGT/banzai/pull/124","diff_url":"https://github.com/LCOGT/banzai/pull/124.diff","patch_url":"https://github.com/LCOGT/banzai/pull/124.patch","issue_url":"https://api.github.com/repos/LCOGT/banzai/issues/124","number":124,"state":"open","locked":false,"title":"Took boolean out of add_tag","user":{"login":"turnerm","id":6585693,"node_id":"MDQ6VXNlcjY1ODU2OTM=","avatar_url":"https://avatars2.githubusercontent.com/u/6585693?v=4","gravatar_id":"","url":"https://api.github.com/users/turnerm","html_url":"https://github.com/turnerm","followers_url":"https://api.github.com/users/turnerm/followers","following_url":"https://api.github.com/users/turnerm/following{/other_user}","gists_url":"https://api.github.com/users/turnerm/gists{/gist_id}","starred_url":"https://api.github.com/users/turnerm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turnerm/subscriptions","organizations_url":"https://api.github.com/users/turnerm/orgs","repos_url":"https://api.github.com/users/turnerm/repos","events_url":"https://api.github.com/users/turnerm/events{/privacy}","received_events_url":"https://api.github.com/users/turnerm/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-23T16:40:53Z","updated_at":"2018-08-23T20:55:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"536e9cd96bee8ebe59c75c5bcefb978ce194a516","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/LCOGT/banzai/pulls/124/commits","review_comments_url":"https://api.github.com/repos/LCOGT/banzai/pulls/124/comments","review_comment_url":"https://api.github.com/repos/LCOGT/banzai/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LCOGT/banzai/issues/124/comments","statuses_url":"https://api.github.com/repos/LCOGT/banzai/statuses/902235038e134b7ec0f33e1a43b71d78fe4daedf","head":{"label":"LCOGT:hotfix/logging_boolean_error","ref":"hotfix/logging_boolean_error","sha":"902235038e134b7ec0f33e1a43b71d78fe4daedf","user":{"login":"LCOGT","id":3358238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNTgyMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/3358238?v=4","gravatar_id":"","url":"https://api.github.com/users/LCOGT","html_url":"https://github.com/LCOGT","followers_url":"https://api.github.com/users/LCOGT/followers","following_url":"https://api.github.com/users/LCOGT/following{/other_user}","gists_url":"https://api.github.com/users/LCOGT/gists{/gist_id}","starred_url":"https://api.github.com/users/LCOGT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LCOGT/subscriptions","organizations_url":"https://api.github.com/users/LCOGT/orgs","repos_url":"https://api.github.com/users/LCOGT/repos","events_url":"https://api.github.com/users/LCOGT/events{/privacy}","received_events_url":"https://api.github.com/users/LCOGT/received_events","type":"Organization","site_admin":false},"repo":{"id":26836413,"node_id":"MDEwOlJlcG9zaXRvcnkyNjgzNjQxMw==","name":"banzai","full_name":"LCOGT/banzai","owner":{"login":"LCOGT","id":3358238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNTgyMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/3358238?v=4","gravatar_id":"","url":"https://api.github.com/users/LCOGT","html_url":"https://github.com/LCOGT","followers_url":"https://api.github.com/users/LCOGT/followers","following_url":"https://api.github.com/users/LCOGT/following{/other_user}","gists_url":"https://api.github.com/users/LCOGT/gists{/gist_id}","starred_url":"https://api.github.com/users/LCOGT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LCOGT/subscriptions","organizations_url":"https://api.github.com/users/LCOGT/orgs","repos_url":"https://api.github.com/users/LCOGT/repos","events_url":"https://api.github.com/users/LCOGT/events{/privacy}","received_events_url":"https://api.github.com/users/LCOGT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LCOGT/banzai","description":"Beautiful Algorithms to Normalize Zillions of Astronomical Images","fork":false,"url":"https://api.github.com/repos/LCOGT/banzai","forks_url":"https://api.github.com/repos/LCOGT/banzai/forks","keys_url":"https://api.github.com/repos/LCOGT/banzai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LCOGT/banzai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LCOGT/banzai/teams","hooks_url":"https://api.github.com/repos/LCOGT/banzai/hooks","issue_events_url":"https://api.github.com/repos/LCOGT/banzai/issues/events{/number}","events_url":"https://api.github.com/repos/LCOGT/banzai/events","assignees_url":"https://api.github.com/repos/LCOGT/banzai/assignees{/user}","branches_url":"https://api.github.com/repos/LCOGT/banzai/branches{/branch}","tags_url":"https://api.github.com/repos/LCOGT/banzai/tags","blobs_url":"https://api.github.com/repos/LCOGT/banzai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LCOGT/banzai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LCOGT/banzai/git/refs{/sha}","trees_url":"https://api.github.com/repos/LCOGT/banzai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LCOGT/banzai/statuses/{sha}","languages_url":"https://api.github.com/repos/LCOGT/banzai/languages","stargazers_url":"https://api.github.com/repos/LCOGT/banzai/stargazers","contributors_url":"https://api.github.com/repos/LCOGT/banzai/contributors","subscribers_url":"https://api.github.com/repos/LCOGT/banzai/subscribers","subscription_url":"https://api.github.com/repos/LCOGT/banzai/subscription","commits_url":"https://api.github.com/repos/LCOGT/banzai/commits{/sha}","git_commits_url":"https://api.github.com/repos/LCOGT/banzai/git/commits{/sha}","comments_url":"https://api.github.com/repos/LCOGT/banzai/comments{/number}","issue_comment_url":"https://api.github.com/repos/LCOGT/banzai/issues/comments{/number}","contents_url":"https://api.github.com/repos/LCOGT/banzai/contents/{+path}","compare_url":"https://api.github.com/repos/LCOGT/banzai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LCOGT/banzai/merges","archive_url":"https://api.github.com/repos/LCOGT/banzai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LCOGT/banzai/downloads","issues_url":"https://api.github.com/repos/LCOGT/banzai/issues{/number}","pulls_url":"https://api.github.com/repos/LCOGT/banzai/pulls{/number}","milestones_url":"https://api.github.com/repos/LCOGT/banzai/milestones{/number}","notifications_url":"https://api.github.com/repos/LCOGT/banzai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LCOGT/banzai/labels{/name}","releases_url":"https://api.github.com/repos/LCOGT/banzai/releases{/id}","deployments_url":"https://api.github.com/repos/LCOGT/banzai/deployments","created_at":"2014-11-19T00:11:47Z","updated_at":"2018-08-23T16:02:20Z","pushed_at":"2018-08-23T20:51:14Z","git_url":"git://github.com/LCOGT/banzai.git","ssh_url":"git@github.com:LCOGT/banzai.git","clone_url":"https://github.com/LCOGT/banzai.git","svn_url":"https://github.com/LCOGT/banzai","homepage":"","size":14377,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":14,"open_issues":8,"watchers":12,"default_branch":"master"}},"base":{"label":"LCOGT:master","ref":"master","sha":"a6a734c5ec3f1208047bbf81857358c71a28bbe0","user":{"login":"LCOGT","id":3358238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNTgyMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/3358238?v=4","gravatar_id":"","url":"https://api.github.com/users/LCOGT","html_url":"https://github.com/LCOGT","followers_url":"https://api.github.com/users/LCOGT/followers","following_url":"https://api.github.com/users/LCOGT/following{/other_user}","gists_url":"https://api.github.com/users/LCOGT/gists{/gist_id}","starred_url":"https://api.github.com/users/LCOGT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LCOGT/subscriptions","organizations_url":"https://api.github.com/users/LCOGT/orgs","repos_url":"https://api.github.com/users/LCOGT/repos","events_url":"https://api.github.com/users/LCOGT/events{/privacy}","received_events_url":"https://api.github.com/users/LCOGT/received_events","type":"Organization","site_admin":false},"repo":{"id":26836413,"node_id":"MDEwOlJlcG9zaXRvcnkyNjgzNjQxMw==","name":"banzai","full_name":"LCOGT/banzai","owner":{"login":"LCOGT","id":3358238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNTgyMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/3358238?v=4","gravatar_id":"","url":"https://api.github.com/users/LCOGT","html_url":"https://github.com/LCOGT","followers_url":"https://api.github.com/users/LCOGT/followers","following_url":"https://api.github.com/users/LCOGT/following{/other_user}","gists_url":"https://api.github.com/users/LCOGT/gists{/gist_id}","starred_url":"https://api.github.com/users/LCOGT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LCOGT/subscriptions","organizations_url":"https://api.github.com/users/LCOGT/orgs","repos_url":"https://api.github.com/users/LCOGT/repos","events_url":"https://api.github.com/users/LCOGT/events{/privacy}","received_events_url":"https://api.github.com/users/LCOGT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LCOGT/banzai","description":"Beautiful Algorithms to Normalize Zillions of Astronomical Images","fork":false,"url":"https://api.github.com/repos/LCOGT/banzai","forks_url":"https://api.github.com/repos/LCOGT/banzai/forks","keys_url":"https://api.github.com/repos/LCOGT/banzai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LCOGT/banzai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LCOGT/banzai/teams","hooks_url":"https://api.github.com/repos/LCOGT/banzai/hooks","issue_events_url":"https://api.github.com/repos/LCOGT/banzai/issues/events{/number}","events_url":"https://api.github.com/repos/LCOGT/banzai/events","assignees_url":"https://api.github.com/repos/LCOGT/banzai/assignees{/user}","branches_url":"https://api.github.com/repos/LCOGT/banzai/branches{/branch}","tags_url":"https://api.github.com/repos/LCOGT/banzai/tags","blobs_url":"https://api.github.com/repos/LCOGT/banzai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LCOGT/banzai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LCOGT/banzai/git/refs{/sha}","trees_url":"https://api.github.com/repos/LCOGT/banzai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LCOGT/banzai/statuses/{sha}","languages_url":"https://api.github.com/repos/LCOGT/banzai/languages","stargazers_url":"https://api.github.com/repos/LCOGT/banzai/stargazers","contributors_url":"https://api.github.com/repos/LCOGT/banzai/contributors","subscribers_url":"https://api.github.com/repos/LCOGT/banzai/subscribers","subscription_url":"https://api.github.com/repos/LCOGT/banzai/subscription","commits_url":"https://api.github.com/repos/LCOGT/banzai/commits{/sha}","git_commits_url":"https://api.github.com/repos/LCOGT/banzai/git/commits{/sha}","comments_url":"https://api.github.com/repos/LCOGT/banzai/comments{/number}","issue_comment_url":"https://api.github.com/repos/LCOGT/banzai/issues/comments{/number}","contents_url":"https://api.github.com/repos/LCOGT/banzai/contents/{+path}","compare_url":"https://api.github.com/repos/LCOGT/banzai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LCOGT/banzai/merges","archive_url":"https://api.github.com/repos/LCOGT/banzai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LCOGT/banzai/downloads","issues_url":"https://api.github.com/repos/LCOGT/banzai/issues{/number}","pulls_url":"https://api.github.com/repos/LCOGT/banzai/pulls{/number}","milestones_url":"https://api.github.com/repos/LCOGT/banzai/milestones{/number}","notifications_url":"https://api.github.com/repos/LCOGT/banzai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LCOGT/banzai/labels{/name}","releases_url":"https://api.github.com/repos/LCOGT/banzai/releases{/id}","deployments_url":"https://api.github.com/repos/LCOGT/banzai/deployments","created_at":"2014-11-19T00:11:47Z","updated_at":"2018-08-23T16:02:20Z","pushed_at":"2018-08-23T20:51:14Z","git_url":"git://github.com/LCOGT/banzai.git","ssh_url":"git@github.com:LCOGT/banzai.git","clone_url":"https://github.com/LCOGT/banzai.git","svn_url":"https://github.com/LCOGT/banzai","homepage":"","size":14377,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":14,"open_issues":8,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LCOGT/banzai/pulls/124"},"html":{"href":"https://github.com/LCOGT/banzai/pull/124"},"issue":{"href":"https://api.github.com/repos/LCOGT/banzai/issues/124"},"comments":{"href":"https://api.github.com/repos/LCOGT/banzai/issues/124/comments"},"review_comments":{"href":"https://api.github.com/repos/LCOGT/banzai/pulls/124/comments"},"review_comment":{"href":"https://api.github.com/repos/LCOGT/banzai/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LCOGT/banzai/pulls/124/commits"},"statuses":{"href":"https://api.github.com/repos/LCOGT/banzai/statuses/902235038e134b7ec0f33e1a43b71d78fe4daedf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cmccully"}}