{"action":"created","comment":{"url":"https://api.github.com/repos/refinery/refinerycms/pulls/comments/173147893","pull_request_review_id":102286681,"id":173147893,"diff_hunk":"@@ -2,7 +2,7 @@\n require File.expand_path('../../core/lib/refinery/version', __FILE__)\n \n version = Refinery::Version.to_s\n-rails_version = ['>= 5.1.0', '< 5.2']\n+rails_version = ['>= 5.2.0.rc1', '< 6']","path":"core/refinerycms-core.gemspec","position":5,"original_position":5,"commit_id":"ee0b74b7d9bb81f5d46dee2103de7237e9730065","original_commit_id":"ee0b74b7d9bb81f5d46dee2103de7237e9730065","user":{"login":"bricesanchez","id":1678530,"avatar_url":"https://avatars1.githubusercontent.com/u/1678530?v=4","gravatar_id":"","url":"https://api.github.com/users/bricesanchez","html_url":"https://github.com/bricesanchez","followers_url":"https://api.github.com/users/bricesanchez/followers","following_url":"https://api.github.com/users/bricesanchez/following{/other_user}","gists_url":"https://api.github.com/users/bricesanchez/gists{/gist_id}","starred_url":"https://api.github.com/users/bricesanchez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bricesanchez/subscriptions","organizations_url":"https://api.github.com/users/bricesanchez/orgs","repos_url":"https://api.github.com/users/bricesanchez/repos","events_url":"https://api.github.com/users/bricesanchez/events{/privacy}","received_events_url":"https://api.github.com/users/bricesanchez/received_events","type":"User","site_admin":false},"body":"At this time the only breaking change between Rails 5.1 and 5.2 is this : https://github.com/refinery/refinerycms/pull/3352/commits/70cd41cb09afec28ff65fc4b02dd636a9a201591 \r\n\r\nSo i'm ok to do what to say.\r\n\r\nAny thoughts for this last remaining error `undefined method `except!' for nil:NilClass` ?","created_at":"2018-03-08T12:49:06Z","updated_at":"2018-03-08T12:49:06Z","html_url":"https://github.com/refinery/refinerycms/pull/3352#discussion_r173147893","pull_request_url":"https://api.github.com/repos/refinery/refinerycms/pulls/3352","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/refinery/refinerycms/pulls/comments/173147893"},"html":{"href":"https://github.com/refinery/refinerycms/pull/3352#discussion_r173147893"},"pull_request":{"href":"https://api.github.com/repos/refinery/refinerycms/pulls/3352"}},"in_reply_to_id":173061016},"pull_request":{"url":"https://api.github.com/repos/refinery/refinerycms/pulls/3352","id":173351124,"html_url":"https://github.com/refinery/refinerycms/pull/3352","diff_url":"https://github.com/refinery/refinerycms/pull/3352.diff","patch_url":"https://github.com/refinery/refinerycms/pull/3352.patch","issue_url":"https://api.github.com/repos/refinery/refinerycms/issues/3352","number":3352,"state":"open","locked":false,"title":"WIP: Feature/rails 5.2","user":{"login":"bricesanchez","id":1678530,"avatar_url":"https://avatars1.githubusercontent.com/u/1678530?v=4","gravatar_id":"","url":"https://api.github.com/users/bricesanchez","html_url":"https://github.com/bricesanchez","followers_url":"https://api.github.com/users/bricesanchez/followers","following_url":"https://api.github.com/users/bricesanchez/following{/other_user}","gists_url":"https://api.github.com/users/bricesanchez/gists{/gist_id}","starred_url":"https://api.github.com/users/bricesanchez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bricesanchez/subscriptions","organizations_url":"https://api.github.com/users/bricesanchez/orgs","repos_url":"https://api.github.com/users/bricesanchez/repos","events_url":"https://api.github.com/users/bricesanchez/events{/privacy}","received_events_url":"https://api.github.com/users/bricesanchez/received_events","type":"User","site_admin":false},"body":"We support Rails 5.2, we need to have a green build to merge this PR.","created_at":"2018-03-07T04:36:50Z","updated_at":"2018-03-08T12:49:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ea2831b7f69a1fcc7b4ccb09461f8bc8dfe0cea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/refinery/refinerycms/milestones/10","html_url":"https://github.com/refinery/refinerycms/milestone/10","labels_url":"https://api.github.com/repos/refinery/refinerycms/milestones/10/labels","id":1049739,"number":10,"title":"4.1","description":"New admin UI","creator":{"login":"bricesanchez","id":1678530,"avatar_url":"https://avatars1.githubusercontent.com/u/1678530?v=4","gravatar_id":"","url":"https://api.github.com/users/bricesanchez","html_url":"https://github.com/bricesanchez","followers_url":"https://api.github.com/users/bricesanchez/followers","following_url":"https://api.github.com/users/bricesanchez/following{/other_user}","gists_url":"https://api.github.com/users/bricesanchez/gists{/gist_id}","starred_url":"https://api.github.com/users/bricesanchez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bricesanchez/subscriptions","organizations_url":"https://api.github.com/users/bricesanchez/orgs","repos_url":"https://api.github.com/users/bricesanchez/repos","events_url":"https://api.github.com/users/bricesanchez/events{/privacy}","received_events_url":"https://api.github.com/users/bricesanchez/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":6,"state":"open","created_at":"2015-04-02T03:28:17Z","updated_at":"2018-03-08T04:13:20Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/refinery/refinerycms/pulls/3352/commits","review_comments_url":"https://api.github.com/repos/refinery/refinerycms/pulls/3352/comments","review_comment_url":"https://api.github.com/repos/refinery/refinerycms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/refinery/refinerycms/issues/3352/comments","statuses_url":"https://api.github.com/repos/refinery/refinerycms/statuses/ee0b74b7d9bb81f5d46dee2103de7237e9730065","head":{"label":"refinery:feature/rails-5-2","ref":"feature/rails-5-2","sha":"ee0b74b7d9bb81f5d46dee2103de7237e9730065","user":{"login":"refinery","id":339098,"avatar_url":"https://avatars3.githubusercontent.com/u/339098?v=4","gravatar_id":"","url":"https://api.github.com/users/refinery","html_url":"https://github.com/refinery","followers_url":"https://api.github.com/users/refinery/followers","following_url":"https://api.github.com/users/refinery/following{/other_user}","gists_url":"https://api.github.com/users/refinery/gists{/gist_id}","starred_url":"https://api.github.com/users/refinery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refinery/subscriptions","organizations_url":"https://api.github.com/users/refinery/orgs","repos_url":"https://api.github.com/users/refinery/repos","events_url":"https://api.github.com/users/refinery/events{/privacy}","received_events_url":"https://api.github.com/users/refinery/received_events","type":"Organization","site_admin":false},"repo":{"id":212862,"name":"refinerycms","full_name":"refinery/refinerycms","owner":{"login":"refinery","id":339098,"avatar_url":"https://avatars3.githubusercontent.com/u/339098?v=4","gravatar_id":"","url":"https://api.github.com/users/refinery","html_url":"https://github.com/refinery","followers_url":"https://api.github.com/users/refinery/followers","following_url":"https://api.github.com/users/refinery/following{/other_user}","gists_url":"https://api.github.com/users/refinery/gists{/gist_id}","starred_url":"https://api.github.com/users/refinery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refinery/subscriptions","organizations_url":"https://api.github.com/users/refinery/orgs","repos_url":"https://api.github.com/users/refinery/repos","events_url":"https://api.github.com/users/refinery/events{/privacy}","received_events_url":"https://api.github.com/users/refinery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/refinery/refinerycms","description":"An extendable Ruby on Rails CMS that supports Rails 5.1+","fork":false,"url":"https://api.github.com/repos/refinery/refinerycms","forks_url":"https://api.github.com/repos/refinery/refinerycms/forks","keys_url":"https://api.github.com/repos/refinery/refinerycms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/refinery/refinerycms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/refinery/refinerycms/teams","hooks_url":"https://api.github.com/repos/refinery/refinerycms/hooks","issue_events_url":"https://api.github.com/repos/refinery/refinerycms/issues/events{/number}","events_url":"https://api.github.com/repos/refinery/refinerycms/events","assignees_url":"https://api.github.com/repos/refinery/refinerycms/assignees{/user}","branches_url":"https://api.github.com/repos/refinery/refinerycms/branches{/branch}","tags_url":"https://api.github.com/repos/refinery/refinerycms/tags","blobs_url":"https://api.github.com/repos/refinery/refinerycms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/refinery/refinerycms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/refinery/refinerycms/git/refs{/sha}","trees_url":"https://api.github.com/repos/refinery/refinerycms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/refinery/refinerycms/statuses/{sha}","languages_url":"https://api.github.com/repos/refinery/refinerycms/languages","stargazers_url":"https://api.github.com/repos/refinery/refinerycms/stargazers","contributors_url":"https://api.github.com/repos/refinery/refinerycms/contributors","subscribers_url":"https://api.github.com/repos/refinery/refinerycms/subscribers","subscription_url":"https://api.github.com/repos/refinery/refinerycms/subscription","commits_url":"https://api.github.com/repos/refinery/refinerycms/commits{/sha}","git_commits_url":"https://api.github.com/repos/refinery/refinerycms/git/commits{/sha}","comments_url":"https://api.github.com/repos/refinery/refinerycms/comments{/number}","issue_comment_url":"https://api.github.com/repos/refinery/refinerycms/issues/comments{/number}","contents_url":"https://api.github.com/repos/refinery/refinerycms/contents/{+path}","compare_url":"https://api.github.com/repos/refinery/refinerycms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/refinery/refinerycms/merges","archive_url":"https://api.github.com/repos/refinery/refinerycms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/refinery/refinerycms/downloads","issues_url":"https://api.github.com/repos/refinery/refinerycms/issues{/number}","pulls_url":"https://api.github.com/repos/refinery/refinerycms/pulls{/number}","milestones_url":"https://api.github.com/repos/refinery/refinerycms/milestones{/number}","notifications_url":"https://api.github.com/repos/refinery/refinerycms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/refinery/refinerycms/labels{/name}","releases_url":"https://api.github.com/repos/refinery/refinerycms/releases{/id}","deployments_url":"https://api.github.com/repos/refinery/refinerycms/deployments","created_at":"2009-05-28T20:13:21Z","updated_at":"2018-03-07T17:38:41Z","pushed_at":"2018-03-08T04:12:58Z","git_url":"git://github.com/refinery/refinerycms.git","ssh_url":"git@github.com:refinery/refinerycms.git","clone_url":"https://github.com/refinery/refinerycms.git","svn_url":"https://github.com/refinery/refinerycms","homepage":"http://refinerycms.com","size":26902,"stargazers_count":3553,"watchers_count":3553,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":1282,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1282,"open_issues":10,"watchers":3553,"default_branch":"master"}},"base":{"label":"refinery:master","ref":"master","sha":"acd444b879ce1f655190a3d172a03547238a1d0f","user":{"login":"refinery","id":339098,"avatar_url":"https://avatars3.githubusercontent.com/u/339098?v=4","gravatar_id":"","url":"https://api.github.com/users/refinery","html_url":"https://github.com/refinery","followers_url":"https://api.github.com/users/refinery/followers","following_url":"https://api.github.com/users/refinery/following{/other_user}","gists_url":"https://api.github.com/users/refinery/gists{/gist_id}","starred_url":"https://api.github.com/users/refinery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refinery/subscriptions","organizations_url":"https://api.github.com/users/refinery/orgs","repos_url":"https://api.github.com/users/refinery/repos","events_url":"https://api.github.com/users/refinery/events{/privacy}","received_events_url":"https://api.github.com/users/refinery/received_events","type":"Organization","site_admin":false},"repo":{"id":212862,"name":"refinerycms","full_name":"refinery/refinerycms","owner":{"login":"refinery","id":339098,"avatar_url":"https://avatars3.githubusercontent.com/u/339098?v=4","gravatar_id":"","url":"https://api.github.com/users/refinery","html_url":"https://github.com/refinery","followers_url":"https://api.github.com/users/refinery/followers","following_url":"https://api.github.com/users/refinery/following{/other_user}","gists_url":"https://api.github.com/users/refinery/gists{/gist_id}","starred_url":"https://api.github.com/users/refinery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refinery/subscriptions","organizations_url":"https://api.github.com/users/refinery/orgs","repos_url":"https://api.github.com/users/refinery/repos","events_url":"https://api.github.com/users/refinery/events{/privacy}","received_events_url":"https://api.github.com/users/refinery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/refinery/refinerycms","description":"An extendable Ruby on Rails CMS that supports Rails 5.1+","fork":false,"url":"https://api.github.com/repos/refinery/refinerycms","forks_url":"https://api.github.com/repos/refinery/refinerycms/forks","keys_url":"https://api.github.com/repos/refinery/refinerycms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/refinery/refinerycms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/refinery/refinerycms/teams","hooks_url":"https://api.github.com/repos/refinery/refinerycms/hooks","issue_events_url":"https://api.github.com/repos/refinery/refinerycms/issues/events{/number}","events_url":"https://api.github.com/repos/refinery/refinerycms/events","assignees_url":"https://api.github.com/repos/refinery/refinerycms/assignees{/user}","branches_url":"https://api.github.com/repos/refinery/refinerycms/branches{/branch}","tags_url":"https://api.github.com/repos/refinery/refinerycms/tags","blobs_url":"https://api.github.com/repos/refinery/refinerycms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/refinery/refinerycms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/refinery/refinerycms/git/refs{/sha}","trees_url":"https://api.github.com/repos/refinery/refinerycms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/refinery/refinerycms/statuses/{sha}","languages_url":"https://api.github.com/repos/refinery/refinerycms/languages","stargazers_url":"https://api.github.com/repos/refinery/refinerycms/stargazers","contributors_url":"https://api.github.com/repos/refinery/refinerycms/contributors","subscribers_url":"https://api.github.com/repos/refinery/refinerycms/subscribers","subscription_url":"https://api.github.com/repos/refinery/refinerycms/subscription","commits_url":"https://api.github.com/repos/refinery/refinerycms/commits{/sha}","git_commits_url":"https://api.github.com/repos/refinery/refinerycms/git/commits{/sha}","comments_url":"https://api.github.com/repos/refinery/refinerycms/comments{/number}","issue_comment_url":"https://api.github.com/repos/refinery/refinerycms/issues/comments{/number}","contents_url":"https://api.github.com/repos/refinery/refinerycms/contents/{+path}","compare_url":"https://api.github.com/repos/refinery/refinerycms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/refinery/refinerycms/merges","archive_url":"https://api.github.com/repos/refinery/refinerycms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/refinery/refinerycms/downloads","issues_url":"https://api.github.com/repos/refinery/refinerycms/issues{/number}","pulls_url":"https://api.github.com/repos/refinery/refinerycms/pulls{/number}","milestones_url":"https://api.github.com/repos/refinery/refinerycms/milestones{/number}","notifications_url":"https://api.github.com/repos/refinery/refinerycms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/refinery/refinerycms/labels{/name}","releases_url":"https://api.github.com/repos/refinery/refinerycms/releases{/id}","deployments_url":"https://api.github.com/repos/refinery/refinerycms/deployments","created_at":"2009-05-28T20:13:21Z","updated_at":"2018-03-07T17:38:41Z","pushed_at":"2018-03-08T04:12:58Z","git_url":"git://github.com/refinery/refinerycms.git","ssh_url":"git@github.com:refinery/refinerycms.git","clone_url":"https://github.com/refinery/refinerycms.git","svn_url":"https://github.com/refinery/refinerycms","homepage":"http://refinerycms.com","size":26902,"stargazers_count":3553,"watchers_count":3553,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":1282,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1282,"open_issues":10,"watchers":3553,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/refinery/refinerycms/pulls/3352"},"html":{"href":"https://github.com/refinery/refinerycms/pull/3352"},"issue":{"href":"https://api.github.com/repos/refinery/refinerycms/issues/3352"},"comments":{"href":"https://api.github.com/repos/refinery/refinerycms/issues/3352/comments"},"review_comments":{"href":"https://api.github.com/repos/refinery/refinerycms/pulls/3352/comments"},"review_comment":{"href":"https://api.github.com/repos/refinery/refinerycms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/refinery/refinerycms/pulls/3352/commits"},"statuses":{"href":"https://api.github.com/repos/refinery/refinerycms/statuses/ee0b74b7d9bb81f5d46dee2103de7237e9730065"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bricesanchez"}}