{"action":"created","comment":{"url":"https://api.github.com/repos/astropy/astropy-APEs/pulls/comments/190577678","pull_request_review_id":122981855,"id":190577678,"diff_hunk":"@@ -242,13 +248,18 @@ low-level API recommends:\n             n_world scalars or arrays as input in units given by ``world_axis_units``.\n             Returns n_pixel scalars or arrays. Note that pixel coordinates are\n             assumed to be 0 at the center of the first pixel in each dimension.\n+            to be 0 at the center of the first pixel in each dimension. If a\n+            world coordinate does not have a matching pixel coordinate, NaN can\n+            be returned.  The coordinates should be returned in the ``(x, y)``","path":"APE14.rst","position":35,"original_position":35,"commit_id":"fe5c295a77f34e1d464fd79530a0f2ac9802731c","original_commit_id":"fe5c295a77f34e1d464fd79530a0f2ac9802731c","user":{"login":"nden","id":1110361,"avatar_url":"https://avatars2.githubusercontent.com/u/1110361?v=4","gravatar_id":"","url":"https://api.github.com/users/nden","html_url":"https://github.com/nden","followers_url":"https://api.github.com/users/nden/followers","following_url":"https://api.github.com/users/nden/following{/other_user}","gists_url":"https://api.github.com/users/nden/gists{/gist_id}","starred_url":"https://api.github.com/users/nden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nden/subscriptions","organizations_url":"https://api.github.com/users/nden/orgs","repos_url":"https://api.github.com/users/nden/repos","events_url":"https://api.github.com/users/nden/events{/privacy}","received_events_url":"https://api.github.com/users/nden/received_events","type":"User","site_admin":false},"body":"I think of this as a WCS API and as such it is Cartesian coordinates order, i.e. (x, y, z). I believe this is what is common for other packages as well so there's some expectation of this order.\r\n\r\nIn practical terms, since `astropy.wcs` and `gwcs` use Cartesian order too (not sure about LSST's software), this means the implementation does not have to rearrange the order of the inputs. It would be awkward for the high level interface and the low level object to work with a different order of inputs.\r\nAlthough I see the appeal of using numpy order.\r\n\r\n","created_at":"2018-05-24T13:06:13Z","updated_at":"2018-05-24T13:06:13Z","html_url":"https://github.com/astropy/astropy-APEs/pull/45#discussion_r190577678","pull_request_url":"https://api.github.com/repos/astropy/astropy-APEs/pulls/45","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy-APEs/pulls/comments/190577678"},"html":{"href":"https://github.com/astropy/astropy-APEs/pull/45#discussion_r190577678"},"pull_request":{"href":"https://api.github.com/repos/astropy/astropy-APEs/pulls/45"}},"in_reply_to_id":190567092},"pull_request":{"url":"https://api.github.com/repos/astropy/astropy-APEs/pulls/45","id":190107944,"html_url":"https://github.com/astropy/astropy-APEs/pull/45","diff_url":"https://github.com/astropy/astropy-APEs/pull/45.diff","patch_url":"https://github.com/astropy/astropy-APEs/pull/45.patch","issue_url":"https://api.github.com/repos/astropy/astropy-APEs/issues/45","number":45,"state":"open","locked":false,"title":"WIP: revisions for APE14","user":{"login":"astrofrog","id":314716,"avatar_url":"https://avatars2.githubusercontent.com/u/314716?v=4","gravatar_id":"","url":"https://api.github.com/users/astrofrog","html_url":"https://github.com/astrofrog","followers_url":"https://api.github.com/users/astrofrog/followers","following_url":"https://api.github.com/users/astrofrog/following{/other_user}","gists_url":"https://api.github.com/users/astrofrog/gists{/gist_id}","starred_url":"https://api.github.com/users/astrofrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astrofrog/subscriptions","organizations_url":"https://api.github.com/users/astrofrog/orgs","repos_url":"https://api.github.com/users/astrofrog/repos","events_url":"https://api.github.com/users/astrofrog/events{/privacy}","received_events_url":"https://api.github.com/users/astrofrog/received_events","type":"User","site_admin":false},"body":"As described in https://docs.google.com/document/d/13bJ-tHOuI6pVmB8KtthYB_fBFIYNDF2cApJwt92G6w8/edit, APE14 has significant issues that prevent implementation. Thus, this PR makes revisions to help with the implementation.\r\n\r\n@eteq @Cadair @keflavich @nden @parejkoj - please review and let me know what you think! See the google doc above for more justification about the changes.\r\n\r\n**Note:** I believe we should keep this open until at least one implementation has been completed to avoid more revisions","created_at":"2018-05-23T21:18:33Z","updated_at":"2018-05-24T13:06:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0240691d037b29a6658c1f68c23c5c8b68b3216b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/astropy/astropy-APEs/pulls/45/commits","review_comments_url":"https://api.github.com/repos/astropy/astropy-APEs/pulls/45/comments","review_comment_url":"https://api.github.com/repos/astropy/astropy-APEs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astropy/astropy-APEs/issues/45/comments","statuses_url":"https://api.github.com/repos/astropy/astropy-APEs/statuses/fe5c295a77f34e1d464fd79530a0f2ac9802731c","head":{"label":"astrofrog:ape14-revisions","ref":"ape14-revisions","sha":"fe5c295a77f34e1d464fd79530a0f2ac9802731c","user":{"login":"astrofrog","id":314716,"avatar_url":"https://avatars2.githubusercontent.com/u/314716?v=4","gravatar_id":"","url":"https://api.github.com/users/astrofrog","html_url":"https://github.com/astrofrog","followers_url":"https://api.github.com/users/astrofrog/followers","following_url":"https://api.github.com/users/astrofrog/following{/other_user}","gists_url":"https://api.github.com/users/astrofrog/gists{/gist_id}","starred_url":"https://api.github.com/users/astrofrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astrofrog/subscriptions","organizations_url":"https://api.github.com/users/astrofrog/orgs","repos_url":"https://api.github.com/users/astrofrog/repos","events_url":"https://api.github.com/users/astrofrog/events{/privacy}","received_events_url":"https://api.github.com/users/astrofrog/received_events","type":"User","site_admin":false},"repo":{"id":19323376,"name":"astropy-APEs","full_name":"astrofrog/astropy-APEs","owner":{"login":"astrofrog","id":314716,"avatar_url":"https://avatars2.githubusercontent.com/u/314716?v=4","gravatar_id":"","url":"https://api.github.com/users/astrofrog","html_url":"https://github.com/astrofrog","followers_url":"https://api.github.com/users/astrofrog/followers","following_url":"https://api.github.com/users/astrofrog/following{/other_user}","gists_url":"https://api.github.com/users/astrofrog/gists{/gist_id}","starred_url":"https://api.github.com/users/astrofrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astrofrog/subscriptions","organizations_url":"https://api.github.com/users/astrofrog/orgs","repos_url":"https://api.github.com/users/astrofrog/repos","events_url":"https://api.github.com/users/astrofrog/events{/privacy}","received_events_url":"https://api.github.com/users/astrofrog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/astrofrog/astropy-APEs","description":"A repository storing the Astropy Proposals for Enhancement.","fork":true,"url":"https://api.github.com/repos/astrofrog/astropy-APEs","forks_url":"https://api.github.com/repos/astrofrog/astropy-APEs/forks","keys_url":"https://api.github.com/repos/astrofrog/astropy-APEs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astrofrog/astropy-APEs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astrofrog/astropy-APEs/teams","hooks_url":"https://api.github.com/repos/astrofrog/astropy-APEs/hooks","issue_events_url":"https://api.github.com/repos/astrofrog/astropy-APEs/issues/events{/number}","events_url":"https://api.github.com/repos/astrofrog/astropy-APEs/events","assignees_url":"https://api.github.com/repos/astrofrog/astropy-APEs/assignees{/user}","branches_url":"https://api.github.com/repos/astrofrog/astropy-APEs/branches{/branch}","tags_url":"https://api.github.com/repos/astrofrog/astropy-APEs/tags","blobs_url":"https://api.github.com/repos/astrofrog/astropy-APEs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astrofrog/astropy-APEs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astrofrog/astropy-APEs/git/refs{/sha}","trees_url":"https://api.github.com/repos/astrofrog/astropy-APEs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astrofrog/astropy-APEs/statuses/{sha}","languages_url":"https://api.github.com/repos/astrofrog/astropy-APEs/languages","stargazers_url":"https://api.github.com/repos/astrofrog/astropy-APEs/stargazers","contributors_url":"https://api.github.com/repos/astrofrog/astropy-APEs/contributors","subscribers_url":"https://api.github.com/repos/astrofrog/astropy-APEs/subscribers","subscription_url":"https://api.github.com/repos/astrofrog/astropy-APEs/subscription","commits_url":"https://api.github.com/repos/astrofrog/astropy-APEs/commits{/sha}","git_commits_url":"https://api.github.com/repos/astrofrog/astropy-APEs/git/commits{/sha}","comments_url":"https://api.github.com/repos/astrofrog/astropy-APEs/comments{/number}","issue_comment_url":"https://api.github.com/repos/astrofrog/astropy-APEs/issues/comments{/number}","contents_url":"https://api.github.com/repos/astrofrog/astropy-APEs/contents/{+path}","compare_url":"https://api.github.com/repos/astrofrog/astropy-APEs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astrofrog/astropy-APEs/merges","archive_url":"https://api.github.com/repos/astrofrog/astropy-APEs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astrofrog/astropy-APEs/downloads","issues_url":"https://api.github.com/repos/astrofrog/astropy-APEs/issues{/number}","pulls_url":"https://api.github.com/repos/astrofrog/astropy-APEs/pulls{/number}","milestones_url":"https://api.github.com/repos/astrofrog/astropy-APEs/milestones{/number}","notifications_url":"https://api.github.com/repos/astrofrog/astropy-APEs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astrofrog/astropy-APEs/labels{/name}","releases_url":"https://api.github.com/repos/astrofrog/astropy-APEs/releases{/id}","deployments_url":"https://api.github.com/repos/astrofrog/astropy-APEs/deployments","created_at":"2014-04-30T18:35:51Z","updated_at":"2016-07-13T03:37:31Z","pushed_at":"2018-05-23T21:16:28Z","git_url":"git://github.com/astrofrog/astropy-APEs.git","ssh_url":"git@github.com:astrofrog/astropy-APEs.git","clone_url":"https://github.com/astrofrog/astropy-APEs.git","svn_url":"https://github.com/astrofrog/astropy-APEs","homepage":null,"size":483,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"astropy:master","ref":"master","sha":"54ecdf8587e3e7d72cdd9079d527e694549d4c41","user":{"login":"astropy","id":847984,"avatar_url":"https://avatars0.githubusercontent.com/u/847984?v=4","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"repo":{"id":14154504,"name":"astropy-APEs","full_name":"astropy/astropy-APEs","owner":{"login":"astropy","id":847984,"avatar_url":"https://avatars0.githubusercontent.com/u/847984?v=4","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/astropy/astropy-APEs","description":"A repository storing the Astropy Proposals for Enhancement.","fork":false,"url":"https://api.github.com/repos/astropy/astropy-APEs","forks_url":"https://api.github.com/repos/astropy/astropy-APEs/forks","keys_url":"https://api.github.com/repos/astropy/astropy-APEs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astropy/astropy-APEs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astropy/astropy-APEs/teams","hooks_url":"https://api.github.com/repos/astropy/astropy-APEs/hooks","issue_events_url":"https://api.github.com/repos/astropy/astropy-APEs/issues/events{/number}","events_url":"https://api.github.com/repos/astropy/astropy-APEs/events","assignees_url":"https://api.github.com/repos/astropy/astropy-APEs/assignees{/user}","branches_url":"https://api.github.com/repos/astropy/astropy-APEs/branches{/branch}","tags_url":"https://api.github.com/repos/astropy/astropy-APEs/tags","blobs_url":"https://api.github.com/repos/astropy/astropy-APEs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astropy/astropy-APEs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astropy/astropy-APEs/git/refs{/sha}","trees_url":"https://api.github.com/repos/astropy/astropy-APEs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astropy/astropy-APEs/statuses/{sha}","languages_url":"https://api.github.com/repos/astropy/astropy-APEs/languages","stargazers_url":"https://api.github.com/repos/astropy/astropy-APEs/stargazers","contributors_url":"https://api.github.com/repos/astropy/astropy-APEs/contributors","subscribers_url":"https://api.github.com/repos/astropy/astropy-APEs/subscribers","subscription_url":"https://api.github.com/repos/astropy/astropy-APEs/subscription","commits_url":"https://api.github.com/repos/astropy/astropy-APEs/commits{/sha}","git_commits_url":"https://api.github.com/repos/astropy/astropy-APEs/git/commits{/sha}","comments_url":"https://api.github.com/repos/astropy/astropy-APEs/comments{/number}","issue_comment_url":"https://api.github.com/repos/astropy/astropy-APEs/issues/comments{/number}","contents_url":"https://api.github.com/repos/astropy/astropy-APEs/contents/{+path}","compare_url":"https://api.github.com/repos/astropy/astropy-APEs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astropy/astropy-APEs/merges","archive_url":"https://api.github.com/repos/astropy/astropy-APEs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astropy/astropy-APEs/downloads","issues_url":"https://api.github.com/repos/astropy/astropy-APEs/issues{/number}","pulls_url":"https://api.github.com/repos/astropy/astropy-APEs/pulls{/number}","milestones_url":"https://api.github.com/repos/astropy/astropy-APEs/milestones{/number}","notifications_url":"https://api.github.com/repos/astropy/astropy-APEs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astropy/astropy-APEs/labels{/name}","releases_url":"https://api.github.com/repos/astropy/astropy-APEs/releases{/id}","deployments_url":"https://api.github.com/repos/astropy/astropy-APEs/deployments","created_at":"2013-11-05T21:20:15Z","updated_at":"2018-05-14T19:43:40Z","pushed_at":"2018-05-23T21:18:34Z","git_url":"git://github.com/astropy/astropy-APEs.git","ssh_url":"git@github.com:astropy/astropy-APEs.git","clone_url":"https://github.com/astropy/astropy-APEs.git","svn_url":"https://github.com/astropy/astropy-APEs","homepage":null,"size":459,"stargazers_count":16,"watchers_count":16,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":22,"open_issues":8,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy-APEs/pulls/45"},"html":{"href":"https://github.com/astropy/astropy-APEs/pull/45"},"issue":{"href":"https://api.github.com/repos/astropy/astropy-APEs/issues/45"},"comments":{"href":"https://api.github.com/repos/astropy/astropy-APEs/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/astropy/astropy-APEs/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/astropy/astropy-APEs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astropy/astropy-APEs/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/astropy/astropy-APEs/statuses/fe5c295a77f34e1d464fd79530a0f2ac9802731c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"nden"}}