{"action":"created","comment":{"url":"https://api.github.com/repos/indec-it/react-native-survey-commons/pulls/comments/195716166","pull_request_review_id":129141802,"id":195716166,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTcxNjE2Ng==","diff_hunk":"@@ -40,16 +51,21 @@ class HouseholdCloseVisit extends Component {\n \n     componentDidMount() {\n         const {id, dwellingOrder, householdOrder} = this.props.match.params;\n-        this.props.requestHouseholdVisits(id, dwellingOrder, householdOrder);\n+        this.props.requestCurrentHouseholdVisit(id, dwellingOrder, householdOrder);\n     }\n \n-    componentWillReceiveProps(nextProps) {\n-        const {saving, household, householdVisits} = nextProps;\n-        if (!isEmpty(householdVisits)) {\n-            this.state.currentVisit = last(householdVisits);\n+    static getDerivedStateFromProps(nextProps) {\n+        if (!isEmpty(nextProps.householdVisit)) {\n+            return {\n+                currentVisit: nextProps.householdVisit","path":"src/components/HouseholdCloseVisit/index.js","position":68,"original_position":68,"commit_id":"645022709e5dfabaaa3b3147ccc8717a71671526","original_commit_id":"645022709e5dfabaaa3b3147ccc8717a71671526","user":{"login":"navarroaxel","id":1536740,"node_id":"MDQ6VXNlcjE1MzY3NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1536740?v=4","gravatar_id":"","url":"https://api.github.com/users/navarroaxel","html_url":"https://github.com/navarroaxel","followers_url":"https://api.github.com/users/navarroaxel/followers","following_url":"https://api.github.com/users/navarroaxel/following{/other_user}","gists_url":"https://api.github.com/users/navarroaxel/gists{/gist_id}","starred_url":"https://api.github.com/users/navarroaxel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navarroaxel/subscriptions","organizations_url":"https://api.github.com/users/navarroaxel/orgs","repos_url":"https://api.github.com/users/navarroaxel/repos","events_url":"https://api.github.com/users/navarroaxel/events{/privacy}","received_events_url":"https://api.github.com/users/navarroaxel/received_events","type":"User","site_admin":false},"body":"al prop y al state ponele el mismo nombre `currentHouseholdVisit`.","created_at":"2018-06-15T12:27:32Z","updated_at":"2018-06-15T12:28:02Z","html_url":"https://github.com/indec-it/react-native-survey-commons/pull/195#discussion_r195716166","pull_request_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/pulls/195","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/indec-it/react-native-survey-commons/pulls/comments/195716166"},"html":{"href":"https://github.com/indec-it/react-native-survey-commons/pull/195#discussion_r195716166"},"pull_request":{"href":"https://api.github.com/repos/indec-it/react-native-survey-commons/pulls/195"}}},"pull_request":{"url":"https://api.github.com/repos/indec-it/react-native-survey-commons/pulls/195","id":194969087,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0OTY5MDg3","html_url":"https://github.com/indec-it/react-native-survey-commons/pull/195","diff_url":"https://github.com/indec-it/react-native-survey-commons/pull/195.diff","patch_url":"https://github.com/indec-it/react-native-survey-commons/pull/195.patch","issue_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/issues/195","number":195,"state":"open","locked":false,"title":"refactor(householdCloseVisit): add getDerivedStateFromProps","user":{"login":"maximilianoforlenza","id":16277027,"node_id":"MDQ6VXNlcjE2Mjc3MDI3","avatar_url":"https://avatars2.githubusercontent.com/u/16277027?v=4","gravatar_id":"","url":"https://api.github.com/users/maximilianoforlenza","html_url":"https://github.com/maximilianoforlenza","followers_url":"https://api.github.com/users/maximilianoforlenza/followers","following_url":"https://api.github.com/users/maximilianoforlenza/following{/other_user}","gists_url":"https://api.github.com/users/maximilianoforlenza/gists{/gist_id}","starred_url":"https://api.github.com/users/maximilianoforlenza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximilianoforlenza/subscriptions","organizations_url":"https://api.github.com/users/maximilianoforlenza/orgs","repos_url":"https://api.github.com/users/maximilianoforlenza/repos","events_url":"https://api.github.com/users/maximilianoforlenza/events{/privacy}","received_events_url":"https://api.github.com/users/maximilianoforlenza/received_events","type":"User","site_admin":false},"body":"replace componentWillReceiveProps for getDerivedStateFromProps","created_at":"2018-06-14T17:46:20Z","updated_at":"2018-06-15T12:28:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f63af35b52ce3f38218acc5f9d534a5fb9ad977f","assignee":{"login":"navarroaxel","id":1536740,"node_id":"MDQ6VXNlcjE1MzY3NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1536740?v=4","gravatar_id":"","url":"https://api.github.com/users/navarroaxel","html_url":"https://github.com/navarroaxel","followers_url":"https://api.github.com/users/navarroaxel/followers","following_url":"https://api.github.com/users/navarroaxel/following{/other_user}","gists_url":"https://api.github.com/users/navarroaxel/gists{/gist_id}","starred_url":"https://api.github.com/users/navarroaxel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navarroaxel/subscriptions","organizations_url":"https://api.github.com/users/navarroaxel/orgs","repos_url":"https://api.github.com/users/navarroaxel/repos","events_url":"https://api.github.com/users/navarroaxel/events{/privacy}","received_events_url":"https://api.github.com/users/navarroaxel/received_events","type":"User","site_admin":false},"assignees":[{"login":"navarroaxel","id":1536740,"node_id":"MDQ6VXNlcjE1MzY3NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1536740?v=4","gravatar_id":"","url":"https://api.github.com/users/navarroaxel","html_url":"https://github.com/navarroaxel","followers_url":"https://api.github.com/users/navarroaxel/followers","following_url":"https://api.github.com/users/navarroaxel/following{/other_user}","gists_url":"https://api.github.com/users/navarroaxel/gists{/gist_id}","starred_url":"https://api.github.com/users/navarroaxel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navarroaxel/subscriptions","organizations_url":"https://api.github.com/users/navarroaxel/orgs","repos_url":"https://api.github.com/users/navarroaxel/repos","events_url":"https://api.github.com/users/navarroaxel/events{/privacy}","received_events_url":"https://api.github.com/users/navarroaxel/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/pulls/195/commits","review_comments_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/pulls/195/comments","review_comment_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/issues/195/comments","statuses_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/statuses/645022709e5dfabaaa3b3147ccc8717a71671526","head":{"label":"indec-it:refactorHouseholdCloseVisit","ref":"refactorHouseholdCloseVisit","sha":"645022709e5dfabaaa3b3147ccc8717a71671526","user":{"login":"indec-it","id":17549399,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NTQ5Mzk5","avatar_url":"https://avatars3.githubusercontent.com/u/17549399?v=4","gravatar_id":"","url":"https://api.github.com/users/indec-it","html_url":"https://github.com/indec-it","followers_url":"https://api.github.com/users/indec-it/followers","following_url":"https://api.github.com/users/indec-it/following{/other_user}","gists_url":"https://api.github.com/users/indec-it/gists{/gist_id}","starred_url":"https://api.github.com/users/indec-it/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indec-it/subscriptions","organizations_url":"https://api.github.com/users/indec-it/orgs","repos_url":"https://api.github.com/users/indec-it/repos","events_url":"https://api.github.com/users/indec-it/events{/privacy}","received_events_url":"https://api.github.com/users/indec-it/received_events","type":"Organization","site_admin":false},"repo":{"id":117115784,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcxMTU3ODQ=","name":"react-native-survey-commons","full_name":"indec-it/react-native-survey-commons","owner":{"login":"indec-it","id":17549399,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NTQ5Mzk5","avatar_url":"https://avatars3.githubusercontent.com/u/17549399?v=4","gravatar_id":"","url":"https://api.github.com/users/indec-it","html_url":"https://github.com/indec-it","followers_url":"https://api.github.com/users/indec-it/followers","following_url":"https://api.github.com/users/indec-it/following{/other_user}","gists_url":"https://api.github.com/users/indec-it/gists{/gist_id}","starred_url":"https://api.github.com/users/indec-it/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indec-it/subscriptions","organizations_url":"https://api.github.com/users/indec-it/orgs","repos_url":"https://api.github.com/users/indec-it/repos","events_url":"https://api.github.com/users/indec-it/events{/privacy}","received_events_url":"https://api.github.com/users/indec-it/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/indec-it/react-native-survey-commons","description":"Common react-native components for survey apps","fork":false,"url":"https://api.github.com/repos/indec-it/react-native-survey-commons","forks_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/forks","keys_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/teams","hooks_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/hooks","issue_events_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/issues/events{/number}","events_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/events","assignees_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/assignees{/user}","branches_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/branches{/branch}","tags_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/tags","blobs_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/languages","stargazers_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/stargazers","contributors_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/contributors","subscribers_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/subscribers","subscription_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/subscription","commits_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/contents/{+path}","compare_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/merges","archive_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/downloads","issues_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/issues{/number}","pulls_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/labels{/name}","releases_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/releases{/id}","deployments_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/deployments","created_at":"2018-01-11T15:05:20Z","updated_at":"2018-06-14T18:48:18Z","pushed_at":"2018-06-15T12:26:16Z","git_url":"git://github.com/indec-it/react-native-survey-commons.git","ssh_url":"git@github.com:indec-it/react-native-survey-commons.git","clone_url":"https://github.com/indec-it/react-native-survey-commons.git","svn_url":"https://github.com/indec-it/react-native-survey-commons","homepage":"","size":508,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":5,"watchers":8,"default_branch":"master"}},"base":{"label":"indec-it:master","ref":"master","sha":"a0abb13edbb10c0e68283872eab9649944764a51","user":{"login":"indec-it","id":17549399,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NTQ5Mzk5","avatar_url":"https://avatars3.githubusercontent.com/u/17549399?v=4","gravatar_id":"","url":"https://api.github.com/users/indec-it","html_url":"https://github.com/indec-it","followers_url":"https://api.github.com/users/indec-it/followers","following_url":"https://api.github.com/users/indec-it/following{/other_user}","gists_url":"https://api.github.com/users/indec-it/gists{/gist_id}","starred_url":"https://api.github.com/users/indec-it/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indec-it/subscriptions","organizations_url":"https://api.github.com/users/indec-it/orgs","repos_url":"https://api.github.com/users/indec-it/repos","events_url":"https://api.github.com/users/indec-it/events{/privacy}","received_events_url":"https://api.github.com/users/indec-it/received_events","type":"Organization","site_admin":false},"repo":{"id":117115784,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcxMTU3ODQ=","name":"react-native-survey-commons","full_name":"indec-it/react-native-survey-commons","owner":{"login":"indec-it","id":17549399,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NTQ5Mzk5","avatar_url":"https://avatars3.githubusercontent.com/u/17549399?v=4","gravatar_id":"","url":"https://api.github.com/users/indec-it","html_url":"https://github.com/indec-it","followers_url":"https://api.github.com/users/indec-it/followers","following_url":"https://api.github.com/users/indec-it/following{/other_user}","gists_url":"https://api.github.com/users/indec-it/gists{/gist_id}","starred_url":"https://api.github.com/users/indec-it/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indec-it/subscriptions","organizations_url":"https://api.github.com/users/indec-it/orgs","repos_url":"https://api.github.com/users/indec-it/repos","events_url":"https://api.github.com/users/indec-it/events{/privacy}","received_events_url":"https://api.github.com/users/indec-it/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/indec-it/react-native-survey-commons","description":"Common react-native components for survey apps","fork":false,"url":"https://api.github.com/repos/indec-it/react-native-survey-commons","forks_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/forks","keys_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/teams","hooks_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/hooks","issue_events_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/issues/events{/number}","events_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/events","assignees_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/assignees{/user}","branches_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/branches{/branch}","tags_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/tags","blobs_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/languages","stargazers_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/stargazers","contributors_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/contributors","subscribers_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/subscribers","subscription_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/subscription","commits_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/contents/{+path}","compare_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/merges","archive_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/downloads","issues_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/issues{/number}","pulls_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/labels{/name}","releases_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/releases{/id}","deployments_url":"https://api.github.com/repos/indec-it/react-native-survey-commons/deployments","created_at":"2018-01-11T15:05:20Z","updated_at":"2018-06-14T18:48:18Z","pushed_at":"2018-06-15T12:26:16Z","git_url":"git://github.com/indec-it/react-native-survey-commons.git","ssh_url":"git@github.com:indec-it/react-native-survey-commons.git","clone_url":"https://github.com/indec-it/react-native-survey-commons.git","svn_url":"https://github.com/indec-it/react-native-survey-commons","homepage":"","size":508,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":5,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/indec-it/react-native-survey-commons/pulls/195"},"html":{"href":"https://github.com/indec-it/react-native-survey-commons/pull/195"},"issue":{"href":"https://api.github.com/repos/indec-it/react-native-survey-commons/issues/195"},"comments":{"href":"https://api.github.com/repos/indec-it/react-native-survey-commons/issues/195/comments"},"review_comments":{"href":"https://api.github.com/repos/indec-it/react-native-survey-commons/pulls/195/comments"},"review_comment":{"href":"https://api.github.com/repos/indec-it/react-native-survey-commons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/indec-it/react-native-survey-commons/pulls/195/commits"},"statuses":{"href":"https://api.github.com/repos/indec-it/react-native-survey-commons/statuses/645022709e5dfabaaa3b3147ccc8717a71671526"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"navarroaxel"}}