{"action":"created","issue":{"url":"https://api.github.com/repos/aragon/aragon-ui/issues/269","repository_url":"https://api.github.com/repos/aragon/aragon-ui","labels_url":"https://api.github.com/repos/aragon/aragon-ui/issues/269/labels{/name}","comments_url":"https://api.github.com/repos/aragon/aragon-ui/issues/269/comments","events_url":"https://api.github.com/repos/aragon/aragon-ui/issues/269/events","html_url":"https://github.com/aragon/aragon-ui/pull/269","id":389675768,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NjExMTMy","number":269,"title":"Add a utility component to emulate :focus-visible","user":{"login":"bpierre","id":36158,"node_id":"MDQ6VXNlcjM2MTU4","avatar_url":"https://avatars2.githubusercontent.com/u/36158?v=4","gravatar_id":"","url":"https://api.github.com/users/bpierre","html_url":"https://github.com/bpierre","followers_url":"https://api.github.com/users/bpierre/followers","following_url":"https://api.github.com/users/bpierre/following{/other_user}","gists_url":"https://api.github.com/users/bpierre/gists{/gist_id}","starred_url":"https://api.github.com/users/bpierre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpierre/subscriptions","organizations_url":"https://api.github.com/users/bpierre/orgs","repos_url":"https://api.github.com/users/bpierre/repos","events_url":"https://api.github.com/users/bpierre/events{/privacy}","received_events_url":"https://api.github.com/users/bpierre/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-11T09:47:55Z","updated_at":"2018-12-11T15:47:24Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/aragon/aragon-ui/pulls/269","html_url":"https://github.com/aragon/aragon-ui/pull/269","diff_url":"https://github.com/aragon/aragon-ui/pull/269.diff","patch_url":"https://github.com/aragon/aragon-ui/pull/269.patch"},"body":"Implements a behavior similar to :focus-visible for browsers that are not supporting it yet.\r\n\r\nIt follows the Chrome implementation, checking for a pointer device rather than a keyboard event.\r\n\r\nResources:\r\n- https://caniuse.com/#search=%3Afocus-visible\r\n- https://github.com/WICG/focus-visible/issues/88#issuecomment-363227219\r\n- https://chromium-review.googlesource.com/c/chromium/src/+/897002<Paste> "},"comment":{"url":"https://api.github.com/repos/aragon/aragon-ui/issues/comments/446250358","html_url":"https://github.com/aragon/aragon-ui/pull/269#issuecomment-446250358","issue_url":"https://api.github.com/repos/aragon/aragon-ui/issues/269","id":446250358,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjI1MDM1OA==","user":{"login":"bpierre","id":36158,"node_id":"MDQ6VXNlcjM2MTU4","avatar_url":"https://avatars2.githubusercontent.com/u/36158?v=4","gravatar_id":"","url":"https://api.github.com/users/bpierre","html_url":"https://github.com/bpierre","followers_url":"https://api.github.com/users/bpierre/followers","following_url":"https://api.github.com/users/bpierre/following{/other_user}","gists_url":"https://api.github.com/users/bpierre/gists{/gist_id}","starred_url":"https://api.github.com/users/bpierre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpierre/subscriptions","organizations_url":"https://api.github.com/users/bpierre/orgs","repos_url":"https://api.github.com/users/bpierre/repos","events_url":"https://api.github.com/users/bpierre/events{/privacy}","received_events_url":"https://api.github.com/users/bpierre/received_events","type":"User","site_admin":false},"created_at":"2018-12-11T15:47:24Z","updated_at":"2018-12-11T15:47:24Z","author_association":"MEMBER","body":"> There's also a polyfill that uses class names, which you've probably run into.\r\n\r\nYes, heavily inspired from it!\r\n\r\n> However, given how this is meant to be used as part of a library, I think it makes sense to scope it as a component (otherwise we'd have to add a FocusVisibleProvider or something weird).\r\n\r\nYes exactly, I think it would be weird to depend on an external provider just to handle focus states. Firefox supports `:focus-visible`, Chrome is really close (behind a flag), and hopefully Safari will follow. When the support will be good enough, we could decide to remove the component altogether and support older browsers by having a visible focus on click (or more precisely, have the different behaviors browsers have for `:focus`)."}}
{"actor":{"display_login":"bpierre"}}