{"action":"created","issue":{"url":"https://api.github.com/repos/Gmousse/dataframe-js/issues/54","repository_url":"https://api.github.com/repos/Gmousse/dataframe-js","labels_url":"https://api.github.com/repos/Gmousse/dataframe-js/issues/54/labels{/name}","comments_url":"https://api.github.com/repos/Gmousse/dataframe-js/issues/54/comments","events_url":"https://api.github.com/repos/Gmousse/dataframe-js/issues/54/events","html_url":"https://github.com/Gmousse/dataframe-js/issues/54","id":325237771,"number":54,"title":"join on empty dataframe returns an array instead of an empty dataset","user":{"login":"fgutmann","id":236795,"avatar_url":"https://avatars2.githubusercontent.com/u/236795?v=4","gravatar_id":"","url":"https://api.github.com/users/fgutmann","html_url":"https://github.com/fgutmann","followers_url":"https://api.github.com/users/fgutmann/followers","following_url":"https://api.github.com/users/fgutmann/following{/other_user}","gists_url":"https://api.github.com/users/fgutmann/gists{/gist_id}","starred_url":"https://api.github.com/users/fgutmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgutmann/subscriptions","organizations_url":"https://api.github.com/users/fgutmann/orgs","repos_url":"https://api.github.com/users/fgutmann/repos","events_url":"https://api.github.com/users/fgutmann/events{/privacy}","received_events_url":"https://api.github.com/users/fgutmann/received_events","type":"User","site_admin":false},"labels":[{"id":413295697,"url":"https://api.github.com/repos/Gmousse/dataframe-js/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"open","locked":false,"assignee":{"login":"Gmousse","id":11961940,"avatar_url":"https://avatars0.githubusercontent.com/u/11961940?v=4","gravatar_id":"","url":"https://api.github.com/users/Gmousse","html_url":"https://github.com/Gmousse","followers_url":"https://api.github.com/users/Gmousse/followers","following_url":"https://api.github.com/users/Gmousse/following{/other_user}","gists_url":"https://api.github.com/users/Gmousse/gists{/gist_id}","starred_url":"https://api.github.com/users/Gmousse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gmousse/subscriptions","organizations_url":"https://api.github.com/users/Gmousse/orgs","repos_url":"https://api.github.com/users/Gmousse/repos","events_url":"https://api.github.com/users/Gmousse/events{/privacy}","received_events_url":"https://api.github.com/users/Gmousse/received_events","type":"User","site_admin":false},"assignees":[{"login":"Gmousse","id":11961940,"avatar_url":"https://avatars0.githubusercontent.com/u/11961940?v=4","gravatar_id":"","url":"https://api.github.com/users/Gmousse","html_url":"https://github.com/Gmousse","followers_url":"https://api.github.com/users/Gmousse/followers","following_url":"https://api.github.com/users/Gmousse/following{/other_user}","gists_url":"https://api.github.com/users/Gmousse/gists{/gist_id}","starred_url":"https://api.github.com/users/Gmousse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gmousse/subscriptions","organizations_url":"https://api.github.com/users/Gmousse/orgs","repos_url":"https://api.github.com/users/Gmousse/repos","events_url":"https://api.github.com/users/Gmousse/events{/privacy}","received_events_url":"https://api.github.com/users/Gmousse/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-05-22T10:43:02Z","updated_at":"2018-05-22T16:56:50Z","closed_at":null,"author_association":"NONE","body":"When joining with an empty dataframe the result is an array.\r\nI'd expect it to be an empty dataframe.\r\n\r\nExample:\r\n```\r\nlet df1 = new dfjs.DataFrame([]);\r\nlet df2 = new dfjs.DataFrame([]);\r\ndf1.join(df2, 'col1'); // empty array\r\n```\r\n\r\nThe empty array is quite unhandy in situations where `filter()` is followed by `join()`.\r\nWhat are your thoughts on this?"},"comment":{"url":"https://api.github.com/repos/Gmousse/dataframe-js/issues/comments/391064496","html_url":"https://github.com/Gmousse/dataframe-js/issues/54#issuecomment-391064496","issue_url":"https://api.github.com/repos/Gmousse/dataframe-js/issues/54","id":391064496,"user":{"login":"Gmousse","id":11961940,"avatar_url":"https://avatars0.githubusercontent.com/u/11961940?v=4","gravatar_id":"","url":"https://api.github.com/users/Gmousse","html_url":"https://github.com/Gmousse","followers_url":"https://api.github.com/users/Gmousse/followers","following_url":"https://api.github.com/users/Gmousse/following{/other_user}","gists_url":"https://api.github.com/users/Gmousse/gists{/gist_id}","starred_url":"https://api.github.com/users/Gmousse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gmousse/subscriptions","organizations_url":"https://api.github.com/users/Gmousse/orgs","repos_url":"https://api.github.com/users/Gmousse/repos","events_url":"https://api.github.com/users/Gmousse/events{/privacy}","received_events_url":"https://api.github.com/users/Gmousse/received_events","type":"User","site_admin":false},"created_at":"2018-05-22T16:56:50Z","updated_at":"2018-05-22T16:56:50Z","author_association":"OWNER","body":"Hum it's clearly a bug.\r\nthanks @fgutmann I will see for a fix when I can find some free time.\r\n"}}
{"actor":{"display_login":"Gmousse"}}