{"action":"created","comment":{"url":"https://api.github.com/repos/corda/corda/pulls/comments/227213757","pull_request_review_id":167201371,"id":227213757,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzIxMzc1Nw==","diff_hunk":"@@ -414,12 +414,12 @@ interface NodeStartupLogging {\n \n     fun <RESULT> attempt(action: () -> RESULT): Try<RESULT> = Try.on(action)\n \n-    fun Exception.log(message: String? = this.message, print: (String?, Throwable) -> Unit = logger::error) = print(\"$message${this.message?.let { \": $it\" } ?: \"\"}\", this)\n+    fun Exception.log(message: String? = this.message, exception: Throwable? = null, print: (String?, Throwable?) -> Unit = logger::error) = print(\"$this${exception?.message?.let { \": $it\" } ?: \"\"}\", exception)\n \n     fun handleRegistrationError(error: Exception) {\n         when (error) {\n             is NodeRegistrationException -> error.log(\"Issue with Node registration: ${error.message}\")\n-            else -> error.log(\"Exception during node registration\")\n+            else -> error.log(\"Exception during node registration\", error)","path":"node/src/main/kotlin/net/corda/node/internal/NodeStartup.kt","position":527,"original_position":20,"commit_id":"2b9a057fccee4faec99d13fb963d3b79689e56bc","original_commit_id":"0cd78afd03b01f5c496fb778d34d0dd1b23115cf","user":{"login":"tlil","id":5948145,"node_id":"MDQ6VXNlcjU5NDgxNDU=","avatar_url":"https://avatars0.githubusercontent.com/u/5948145?v=4","gravatar_id":"","url":"https://api.github.com/users/tlil","html_url":"https://github.com/tlil","followers_url":"https://api.github.com/users/tlil/followers","following_url":"https://api.github.com/users/tlil/following{/other_user}","gists_url":"https://api.github.com/users/tlil/gists{/gist_id}","starred_url":"https://api.github.com/users/tlil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlil/subscriptions","organizations_url":"https://api.github.com/users/tlil/orgs","repos_url":"https://api.github.com/users/tlil/repos","events_url":"https://api.github.com/users/tlil/events{/privacy}","received_events_url":"https://api.github.com/users/tlil/received_events","type":"User","site_admin":false},"body":"See above; you're essentially passing in `error` twice here :)","created_at":"2018-10-23T03:41:59Z","updated_at":"2018-10-23T03:41:59Z","html_url":"https://github.com/corda/corda/pull/4091#discussion_r227213757","pull_request_url":"https://api.github.com/repos/corda/corda/pulls/4091","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/comments/227213757"},"html":{"href":"https://github.com/corda/corda/pull/4091#discussion_r227213757"},"pull_request":{"href":"https://api.github.com/repos/corda/corda/pulls/4091"}}},"pull_request":{"url":"https://api.github.com/repos/corda/corda/pulls/4091","id":223973567,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzOTczNTY3","html_url":"https://github.com/corda/corda/pull/4091","diff_url":"https://github.com/corda/corda/pull/4091.diff","patch_url":"https://github.com/corda/corda/pull/4091.patch","issue_url":"https://api.github.com/repos/corda/corda/issues/4091","number":4091,"state":"open","locked":false,"title":"CORDA-1838: Add subcommands to node","user":{"login":"anthonykeenan","id":34482776,"node_id":"MDQ6VXNlcjM0NDgyNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/34482776?v=4","gravatar_id":"","url":"https://api.github.com/users/anthonykeenan","html_url":"https://github.com/anthonykeenan","followers_url":"https://api.github.com/users/anthonykeenan/followers","following_url":"https://api.github.com/users/anthonykeenan/following{/other_user}","gists_url":"https://api.github.com/users/anthonykeenan/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonykeenan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonykeenan/subscriptions","organizations_url":"https://api.github.com/users/anthonykeenan/orgs","repos_url":"https://api.github.com/users/anthonykeenan/repos","events_url":"https://api.github.com/users/anthonykeenan/events{/privacy}","received_events_url":"https://api.github.com/users/anthonykeenan/received_events","type":"User","site_admin":false},"body":"* Replaced `--install-shell-extensions` flag with `install-shell-extensions` command which ignores required parameters\r\n* Replaced `--clear-network-map-cache` flag with `clear-network-cache` command\r\n* Replaced `--just-generate-node-info` flag with `generate-node-info` command\r\n* Replaced `--just-generate-rpc-ssl-settings` flag with `generate-rpc-ssl-settings` command\r\n* Replaced `--bootstrap-raft-cluster` flag with `bootstrap-raft-cluster` command\r\n* Replaced `--initial-registration` flag with `initial-registration` command\r\n\r\nAll previous flags are still there, but don't show up in the help usage. If a deprecated flag is used it logs a WARN message to the log file and to the screen.","created_at":"2018-10-18T14:15:17Z","updated_at":"2018-10-23T03:41:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c3614ad114aa3fe49ddd7ecfbc64c1a8eca2094","assignee":{"login":"anthonykeenan","id":34482776,"node_id":"MDQ6VXNlcjM0NDgyNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/34482776?v=4","gravatar_id":"","url":"https://api.github.com/users/anthonykeenan","html_url":"https://github.com/anthonykeenan","followers_url":"https://api.github.com/users/anthonykeenan/followers","following_url":"https://api.github.com/users/anthonykeenan/following{/other_user}","gists_url":"https://api.github.com/users/anthonykeenan/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonykeenan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonykeenan/subscriptions","organizations_url":"https://api.github.com/users/anthonykeenan/orgs","repos_url":"https://api.github.com/users/anthonykeenan/repos","events_url":"https://api.github.com/users/anthonykeenan/events{/privacy}","received_events_url":"https://api.github.com/users/anthonykeenan/received_events","type":"User","site_admin":false},"assignees":[{"login":"anthonykeenan","id":34482776,"node_id":"MDQ6VXNlcjM0NDgyNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/34482776?v=4","gravatar_id":"","url":"https://api.github.com/users/anthonykeenan","html_url":"https://github.com/anthonykeenan","followers_url":"https://api.github.com/users/anthonykeenan/followers","following_url":"https://api.github.com/users/anthonykeenan/following{/other_user}","gists_url":"https://api.github.com/users/anthonykeenan/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonykeenan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonykeenan/subscriptions","organizations_url":"https://api.github.com/users/anthonykeenan/orgs","repos_url":"https://api.github.com/users/anthonykeenan/repos","events_url":"https://api.github.com/users/anthonykeenan/events{/privacy}","received_events_url":"https://api.github.com/users/anthonykeenan/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/corda/corda/pulls/4091/commits","review_comments_url":"https://api.github.com/repos/corda/corda/pulls/4091/comments","review_comment_url":"https://api.github.com/repos/corda/corda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/corda/corda/issues/4091/comments","statuses_url":"https://api.github.com/repos/corda/corda/statuses/2b9a057fccee4faec99d13fb963d3b79689e56bc","head":{"label":"corda:anthony/features/CORDA-1838","ref":"anthony/features/CORDA-1838","sha":"2b9a057fccee4faec99d13fb963d3b79689e56bc","user":{"login":"corda","id":22600631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjAwNjMx","avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"node_id":"MDEwOlJlcG9zaXRvcnk3MDEzNzQxNw==","name":"corda","full_name":"corda/corda","private":false,"owner":{"login":"corda","id":22600631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjAwNjMx","avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/corda/corda","description":"Corda is an open source blockchain project, designed for business from the start. Only Corda allows you to build interoperable blockchain networks that transact in strict privacy. Corda's smart contract technology allows businesses to transact directly, with value.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2018-10-22T20:17:31Z","pushed_at":"2018-10-22T20:17:28Z","git_url":"git://github.com/corda/corda.git","ssh_url":"git@github.com:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":164868,"stargazers_count":2386,"watchers_count":2386,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":617,"mirror_url":null,"archived":false,"open_issues_count":92,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":617,"open_issues":92,"watchers":2386,"default_branch":"master"}},"base":{"label":"corda:master","ref":"master","sha":"6c315d6adfb332c3048b39b45c43c9ba804434cf","user":{"login":"corda","id":22600631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjAwNjMx","avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"node_id":"MDEwOlJlcG9zaXRvcnk3MDEzNzQxNw==","name":"corda","full_name":"corda/corda","private":false,"owner":{"login":"corda","id":22600631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjAwNjMx","avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/corda/corda","description":"Corda is an open source blockchain project, designed for business from the start. Only Corda allows you to build interoperable blockchain networks that transact in strict privacy. Corda's smart contract technology allows businesses to transact directly, with value.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2018-10-22T20:17:31Z","pushed_at":"2018-10-22T20:17:28Z","git_url":"git://github.com/corda/corda.git","ssh_url":"git@github.com:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":164868,"stargazers_count":2386,"watchers_count":2386,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":617,"mirror_url":null,"archived":false,"open_issues_count":92,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":617,"open_issues":92,"watchers":2386,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/4091"},"html":{"href":"https://github.com/corda/corda/pull/4091"},"issue":{"href":"https://api.github.com/repos/corda/corda/issues/4091"},"comments":{"href":"https://api.github.com/repos/corda/corda/issues/4091/comments"},"review_comments":{"href":"https://api.github.com/repos/corda/corda/pulls/4091/comments"},"review_comment":{"href":"https://api.github.com/repos/corda/corda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/corda/corda/pulls/4091/commits"},"statuses":{"href":"https://api.github.com/repos/corda/corda/statuses/2b9a057fccee4faec99d13fb963d3b79689e56bc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tlil"}}