{"action":"created","issue":{"url":"https://api.github.com/repos/maruohon/itemscroller/issues/17","repository_url":"https://api.github.com/repos/maruohon/itemscroller","labels_url":"https://api.github.com/repos/maruohon/itemscroller/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/maruohon/itemscroller/issues/17/comments","events_url":"https://api.github.com/repos/maruohon/itemscroller/issues/17/events","html_url":"https://github.com/maruohon/itemscroller/pull/17","id":367892440,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMTk2MzIz","number":17,"title":"fix reverse scroll direction","user":{"login":"CerulanLumina","id":1103450,"node_id":"MDQ6VXNlcjExMDM0NTA=","avatar_url":"https://avatars2.githubusercontent.com/u/1103450?v=4","gravatar_id":"","url":"https://api.github.com/users/CerulanLumina","html_url":"https://github.com/CerulanLumina","followers_url":"https://api.github.com/users/CerulanLumina/followers","following_url":"https://api.github.com/users/CerulanLumina/following{/other_user}","gists_url":"https://api.github.com/users/CerulanLumina/gists{/gist_id}","starred_url":"https://api.github.com/users/CerulanLumina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CerulanLumina/subscriptions","organizations_url":"https://api.github.com/users/CerulanLumina/orgs","repos_url":"https://api.github.com/users/CerulanLumina/repos","events_url":"https://api.github.com/users/CerulanLumina/events{/privacy}","received_events_url":"https://api.github.com/users/CerulanLumina/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-08T17:51:31Z","updated_at":"2018-10-08T18:32:06Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/maruohon/itemscroller/pulls/17","html_url":"https://github.com/maruohon/itemscroller/pull/17","diff_url":"https://github.com/maruohon/itemscroller/pull/17.diff","patch_url":"https://github.com/maruohon/itemscroller/pull/17.patch"},"body":"This fixes the reverse scrolling direction configuration option for single items not affecting anything (the value was never read in the code). According to the commit history of this project, this line was changed but I can't figure out why, so I think it's a bug, so this fix just changes it back.\r\n\r\nFull disclosure: I'm not 100% sure this fix doesn't break anything else, but it definitely fixes being unable to reverse scrolling direction for single items."},"comment":{"url":"https://api.github.com/repos/maruohon/itemscroller/issues/comments/427935938","html_url":"https://github.com/maruohon/itemscroller/pull/17#issuecomment-427935938","issue_url":"https://api.github.com/repos/maruohon/itemscroller/issues/17","id":427935938,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzkzNTkzOA==","user":{"login":"maruohon","id":2331050,"node_id":"MDQ6VXNlcjIzMzEwNTA=","avatar_url":"https://avatars1.githubusercontent.com/u/2331050?v=4","gravatar_id":"","url":"https://api.github.com/users/maruohon","html_url":"https://github.com/maruohon","followers_url":"https://api.github.com/users/maruohon/followers","following_url":"https://api.github.com/users/maruohon/following{/other_user}","gists_url":"https://api.github.com/users/maruohon/gists{/gist_id}","starred_url":"https://api.github.com/users/maruohon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maruohon/subscriptions","organizations_url":"https://api.github.com/users/maruohon/orgs","repos_url":"https://api.github.com/users/maruohon/repos","events_url":"https://api.github.com/users/maruohon/events{/privacy}","received_events_url":"https://api.github.com/users/maruohon/received_events","type":"User","site_admin":false},"created_at":"2018-10-08T18:32:06Z","updated_at":"2018-10-08T18:32:06Z","author_association":"OWNER","body":"Thanks.\r\n\r\nIt was most likely a copy-paste fail while I was taking the changes from the Liteloader branch... I didn't merge because I didn't want all the config related differences that branch has, so I mostly manually copy pasted blobs of code from the Liteloader version back to the Forge version and then adjusted the config variables back to what they are in the Forge version, and probably forgot to rename that config variable after copy pasting, or something like that."}}
{"actor":{"display_login":"maruohon"}}