{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/pcs-config-java/pulls/comments/177270205","pull_request_review_id":107113149,"id":177270205,"diff_hunk":"@@ -138,38 +141,101 @@ public void setUserSettingAsyncTest() throws BaseException, ExecutionException,\n \n     @Test(timeout = 100000)\n     @Category({UnitTest.class})\n-    public void getLogoAsyncTest() throws BaseException, ExecutionException, InterruptedException {\n+    public void getLogoShouldReturnExpectedLogo() throws BaseException, ExecutionException, InterruptedException {\n         String image = rand.NextString();\n         String type = rand.NextString();\n-        String jsonData = String.format(\"{\\\"Image\\\":\\\"%s\\\",\\\"Type\\\":\\\"%s\\\"}\", image, type);\n-        ValueApiModel model = new ValueApiModel();\n-        model.setData(jsonData);\n-        Mockito.when(mockClient.getAsync(Mockito.any(String.class), Mockito.any(String.class)))\n-                .thenReturn(CompletableFuture.supplyAsync(() -> model));\n+        String isDefault = \"false\";\n+        String jsonData = String.format(\"{\\\"Image\\\":\\\"%s\\\",\\\"Type\\\":\\\"%s\\\",\\\"IsDefault\\\":%s}\", image, type, isDefault);","path":"test/com/microsoft/azure/iotsolutions/uiconfig/services/StorageTest.java","position":31,"original_position":31,"commit_id":"5ee7b254522dae8858895480316d19c2c3798fcf","original_commit_id":"5ee7b254522dae8858895480316d19c2c3798fcf","user":{"login":"molly-moen","id":33666587,"avatar_url":"https://avatars1.githubusercontent.com/u/33666587?v=4","gravatar_id":"","url":"https://api.github.com/users/molly-moen","html_url":"https://github.com/molly-moen","followers_url":"https://api.github.com/users/molly-moen/followers","following_url":"https://api.github.com/users/molly-moen/following{/other_user}","gists_url":"https://api.github.com/users/molly-moen/gists{/gist_id}","starred_url":"https://api.github.com/users/molly-moen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/molly-moen/subscriptions","organizations_url":"https://api.github.com/users/molly-moen/orgs","repos_url":"https://api.github.com/users/molly-moen/repos","events_url":"https://api.github.com/users/molly-moen/events{/privacy}","received_events_url":"https://api.github.com/users/molly-moen/received_events","type":"User","site_admin":false},"body":"that string is actually only used once--made a constant for the other version (includes name) which is used twice","created_at":"2018-03-26T23:57:38Z","updated_at":"2018-03-26T23:57:38Z","html_url":"https://github.com/Azure/pcs-config-java/pull/65#discussion_r177270205","pull_request_url":"https://api.github.com/repos/Azure/pcs-config-java/pulls/65","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Azure/pcs-config-java/pulls/comments/177270205"},"html":{"href":"https://github.com/Azure/pcs-config-java/pull/65#discussion_r177270205"},"pull_request":{"href":"https://api.github.com/repos/Azure/pcs-config-java/pulls/65"}},"in_reply_to_id":177243489},"pull_request":{"url":"https://api.github.com/repos/Azure/pcs-config-java/pulls/65","id":177561702,"html_url":"https://github.com/Azure/pcs-config-java/pull/65","diff_url":"https://github.com/Azure/pcs-config-java/pull/65.diff","patch_url":"https://github.com/Azure/pcs-config-java/pull/65.patch","issue_url":"https://api.github.com/repos/Azure/pcs-config-java/issues/65","number":65,"state":"open","locked":false,"title":"Logo Update","user":{"login":"molly-moen","id":33666587,"avatar_url":"https://avatars1.githubusercontent.com/u/33666587?v=4","gravatar_id":"","url":"https://api.github.com/users/molly-moen","html_url":"https://github.com/molly-moen","followers_url":"https://api.github.com/users/molly-moen/followers","following_url":"https://api.github.com/users/molly-moen/following{/other_user}","gists_url":"https://api.github.com/users/molly-moen/gists{/gist_id}","starred_url":"https://api.github.com/users/molly-moen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/molly-moen/subscriptions","organizations_url":"https://api.github.com/users/molly-moen/orgs","repos_url":"https://api.github.com/users/molly-moen/repos","events_url":"https://api.github.com/users/molly-moen/events{/privacy}","received_events_url":"https://api.github.com/users/molly-moen/received_events","type":"User","site_admin":false},"body":"# Type of change? <!-- [x] all the boxes that apply -->\r\n\r\n- [x] Bug fix\r\n- [x] New feature\r\n- [ ] Enhancement\r\n- [ ] Breaking change (breaks backward compatibility)\r\n\r\n# Description, Context, Motivation <!-- Please help us reviewing your PR -->\r\nUpload logo was broken (it was not translating image binary properly), fixed that issue. Also added \"name\" header to get/set logo so company name can be stored alongside logo, and isDefault header to indicate if the returned value is the default or not. If set logo is called without name or logo, the old name or logo will not be overwritten. Updated and added tests for the logo methods. This brings java config to parity with dotnet config changes that were previously added.\r\n\r\n**Checklist:**\r\n\r\n- [x] All tests passed\r\n- [x] The code follows the code style and conventions of this project\r\n- [x] The change requires a change to the documentation\r\n- [ ] I have updated the documentation accordingly\r\n","created_at":"2018-03-26T20:40:57Z","updated_at":"2018-03-26T23:57:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2b46a2f16a008b770e039bc0ed5ce853d8c781a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ppathan","id":16170750,"avatar_url":"https://avatars2.githubusercontent.com/u/16170750?v=4","gravatar_id":"","url":"https://api.github.com/users/ppathan","html_url":"https://github.com/ppathan","followers_url":"https://api.github.com/users/ppathan/followers","following_url":"https://api.github.com/users/ppathan/following{/other_user}","gists_url":"https://api.github.com/users/ppathan/gists{/gist_id}","starred_url":"https://api.github.com/users/ppathan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppathan/subscriptions","organizations_url":"https://api.github.com/users/ppathan/orgs","repos_url":"https://api.github.com/users/ppathan/repos","events_url":"https://api.github.com/users/ppathan/events{/privacy}","received_events_url":"https://api.github.com/users/ppathan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/pcs-config-java/pulls/65/commits","review_comments_url":"https://api.github.com/repos/Azure/pcs-config-java/pulls/65/comments","review_comment_url":"https://api.github.com/repos/Azure/pcs-config-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/pcs-config-java/issues/65/comments","statuses_url":"https://api.github.com/repos/Azure/pcs-config-java/statuses/5ee7b254522dae8858895480316d19c2c3798fcf","head":{"label":"Azure:Logo-Update","ref":"Logo-Update","sha":"5ee7b254522dae8858895480316d19c2c3798fcf","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":96269429,"name":"pcs-config-java","full_name":"Azure/pcs-config-java","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/pcs-config-java","description":"The configuration microservice for Azure IoT Solutions","fork":false,"url":"https://api.github.com/repos/Azure/pcs-config-java","forks_url":"https://api.github.com/repos/Azure/pcs-config-java/forks","keys_url":"https://api.github.com/repos/Azure/pcs-config-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/pcs-config-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/pcs-config-java/teams","hooks_url":"https://api.github.com/repos/Azure/pcs-config-java/hooks","issue_events_url":"https://api.github.com/repos/Azure/pcs-config-java/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/pcs-config-java/events","assignees_url":"https://api.github.com/repos/Azure/pcs-config-java/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/pcs-config-java/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/pcs-config-java/tags","blobs_url":"https://api.github.com/repos/Azure/pcs-config-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/pcs-config-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/pcs-config-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/pcs-config-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/pcs-config-java/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/pcs-config-java/languages","stargazers_url":"https://api.github.com/repos/Azure/pcs-config-java/stargazers","contributors_url":"https://api.github.com/repos/Azure/pcs-config-java/contributors","subscribers_url":"https://api.github.com/repos/Azure/pcs-config-java/subscribers","subscription_url":"https://api.github.com/repos/Azure/pcs-config-java/subscription","commits_url":"https://api.github.com/repos/Azure/pcs-config-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/pcs-config-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/pcs-config-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/pcs-config-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/pcs-config-java/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/pcs-config-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/pcs-config-java/merges","archive_url":"https://api.github.com/repos/Azure/pcs-config-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/pcs-config-java/downloads","issues_url":"https://api.github.com/repos/Azure/pcs-config-java/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/pcs-config-java/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/pcs-config-java/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/pcs-config-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/pcs-config-java/labels{/name}","releases_url":"https://api.github.com/repos/Azure/pcs-config-java/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/pcs-config-java/deployments","created_at":"2017-07-05T02:37:33Z","updated_at":"2018-03-20T00:54:39Z","pushed_at":"2018-03-26T21:32:13Z","git_url":"git://github.com/Azure/pcs-config-java.git","ssh_url":"git@github.com:Azure/pcs-config-java.git","clone_url":"https://github.com/Azure/pcs-config-java.git","svn_url":"https://github.com/Azure/pcs-config-java","homepage":"","size":1259,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":7,"watchers":1,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"4058f10c6a1538c514210dea1a2a2101d0684178","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":96269429,"name":"pcs-config-java","full_name":"Azure/pcs-config-java","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/pcs-config-java","description":"The configuration microservice for Azure IoT Solutions","fork":false,"url":"https://api.github.com/repos/Azure/pcs-config-java","forks_url":"https://api.github.com/repos/Azure/pcs-config-java/forks","keys_url":"https://api.github.com/repos/Azure/pcs-config-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/pcs-config-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/pcs-config-java/teams","hooks_url":"https://api.github.com/repos/Azure/pcs-config-java/hooks","issue_events_url":"https://api.github.com/repos/Azure/pcs-config-java/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/pcs-config-java/events","assignees_url":"https://api.github.com/repos/Azure/pcs-config-java/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/pcs-config-java/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/pcs-config-java/tags","blobs_url":"https://api.github.com/repos/Azure/pcs-config-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/pcs-config-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/pcs-config-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/pcs-config-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/pcs-config-java/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/pcs-config-java/languages","stargazers_url":"https://api.github.com/repos/Azure/pcs-config-java/stargazers","contributors_url":"https://api.github.com/repos/Azure/pcs-config-java/contributors","subscribers_url":"https://api.github.com/repos/Azure/pcs-config-java/subscribers","subscription_url":"https://api.github.com/repos/Azure/pcs-config-java/subscription","commits_url":"https://api.github.com/repos/Azure/pcs-config-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/pcs-config-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/pcs-config-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/pcs-config-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/pcs-config-java/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/pcs-config-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/pcs-config-java/merges","archive_url":"https://api.github.com/repos/Azure/pcs-config-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/pcs-config-java/downloads","issues_url":"https://api.github.com/repos/Azure/pcs-config-java/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/pcs-config-java/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/pcs-config-java/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/pcs-config-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/pcs-config-java/labels{/name}","releases_url":"https://api.github.com/repos/Azure/pcs-config-java/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/pcs-config-java/deployments","created_at":"2017-07-05T02:37:33Z","updated_at":"2018-03-20T00:54:39Z","pushed_at":"2018-03-26T21:32:13Z","git_url":"git://github.com/Azure/pcs-config-java.git","ssh_url":"git@github.com:Azure/pcs-config-java.git","clone_url":"https://github.com/Azure/pcs-config-java.git","svn_url":"https://github.com/Azure/pcs-config-java","homepage":"","size":1259,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":7,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/pcs-config-java/pulls/65"},"html":{"href":"https://github.com/Azure/pcs-config-java/pull/65"},"issue":{"href":"https://api.github.com/repos/Azure/pcs-config-java/issues/65"},"comments":{"href":"https://api.github.com/repos/Azure/pcs-config-java/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/pcs-config-java/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/pcs-config-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/pcs-config-java/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/pcs-config-java/statuses/5ee7b254522dae8858895480316d19c2c3798fcf"}},"author_association":"NONE"}}
{"actor":{"display_login":"molly-moen"}}