{"action":"closed","number":1299,"pull_request":{"url":"https://api.github.com/repos/line/armeria/pulls/1299","id":202470583,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNDcwNTgz","html_url":"https://github.com/line/armeria/pull/1299","diff_url":"https://github.com/line/armeria/pull/1299.diff","patch_url":"https://github.com/line/armeria/pull/1299.patch","issue_url":"https://api.github.com/repos/line/armeria/issues/1299","number":1299,"state":"closed","locked":false,"title":"Fix a bug where Endpoint.toString() does not include IP address","user":{"login":"trustin","id":173918,"node_id":"MDQ6VXNlcjE3MzkxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/173918?v=4","gravatar_id":"","url":"https://api.github.com/users/trustin","html_url":"https://github.com/trustin","followers_url":"https://api.github.com/users/trustin/followers","following_url":"https://api.github.com/users/trustin/following{/other_user}","gists_url":"https://api.github.com/users/trustin/gists{/gist_id}","starred_url":"https://api.github.com/users/trustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustin/subscriptions","organizations_url":"https://api.github.com/users/trustin/orgs","repos_url":"https://api.github.com/users/trustin/repos","events_url":"https://api.github.com/users/trustin/events{/privacy}","received_events_url":"https://api.github.com/users/trustin/received_events","type":"User","site_admin":false},"body":"Motivation:\r\n\r\nEndpoint.toString() should include the IP address of an endpoint if\r\nnecessary. It currently does not include it at all.\r\n\r\nModifications:\r\n\r\n- Fix incorrect `if` statement.\r\n- Update the test case.\r\n\r\nResult:\r\n\r\n- The string representation of an `Endpoint` now includes its IP\r\n  address.","created_at":"2018-07-19T07:39:59Z","updated_at":"2018-07-19T09:04:56Z","closed_at":"2018-07-19T09:04:56Z","merged_at":"2018-07-19T09:04:56Z","merge_commit_sha":"8e58fe03783300dd3db02b9c8d644da90ecc9cd2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":287189526,"node_id":"MDU6TGFiZWwyODcxODk1MjY=","url":"https://api.github.com/repos/line/armeria/labels/defect","name":"defect","color":"b60205","default":false}],"milestone":{"url":"https://api.github.com/repos/line/armeria/milestones/109","html_url":"https://github.com/line/armeria/milestone/109","labels_url":"https://api.github.com/repos/line/armeria/milestones/109/labels","id":3490312,"node_id":"MDk6TWlsZXN0b25lMzQ5MDMxMg==","number":109,"title":"0.68.0","description":"","creator":{"login":"trustin","id":173918,"node_id":"MDQ6VXNlcjE3MzkxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/173918?v=4","gravatar_id":"","url":"https://api.github.com/users/trustin","html_url":"https://github.com/trustin","followers_url":"https://api.github.com/users/trustin/followers","following_url":"https://api.github.com/users/trustin/following{/other_user}","gists_url":"https://api.github.com/users/trustin/gists{/gist_id}","starred_url":"https://api.github.com/users/trustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustin/subscriptions","organizations_url":"https://api.github.com/users/trustin/orgs","repos_url":"https://api.github.com/users/trustin/repos","events_url":"https://api.github.com/users/trustin/events{/privacy}","received_events_url":"https://api.github.com/users/trustin/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":6,"state":"open","created_at":"2018-07-12T04:02:47Z","updated_at":"2018-07-19T09:04:56Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/line/armeria/pulls/1299/commits","review_comments_url":"https://api.github.com/repos/line/armeria/pulls/1299/comments","review_comment_url":"https://api.github.com/repos/line/armeria/pulls/comments{/number}","comments_url":"https://api.github.com/repos/line/armeria/issues/1299/comments","statuses_url":"https://api.github.com/repos/line/armeria/statuses/b8d3486edcaedada6aab50bc2cfbb29c533c2286","head":{"label":"trustin:endpoint_to_string","ref":"endpoint_to_string","sha":"b8d3486edcaedada6aab50bc2cfbb29c533c2286","user":{"login":"trustin","id":173918,"node_id":"MDQ6VXNlcjE3MzkxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/173918?v=4","gravatar_id":"","url":"https://api.github.com/users/trustin","html_url":"https://github.com/trustin","followers_url":"https://api.github.com/users/trustin/followers","following_url":"https://api.github.com/users/trustin/following{/other_user}","gists_url":"https://api.github.com/users/trustin/gists{/gist_id}","starred_url":"https://api.github.com/users/trustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustin/subscriptions","organizations_url":"https://api.github.com/users/trustin/orgs","repos_url":"https://api.github.com/users/trustin/repos","events_url":"https://api.github.com/users/trustin/events{/privacy}","received_events_url":"https://api.github.com/users/trustin/received_events","type":"User","site_admin":false},"repo":{"id":46322160,"node_id":"MDEwOlJlcG9zaXRvcnk0NjMyMjE2MA==","name":"armeria","full_name":"trustin/armeria","owner":{"login":"trustin","id":173918,"node_id":"MDQ6VXNlcjE3MzkxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/173918?v=4","gravatar_id":"","url":"https://api.github.com/users/trustin","html_url":"https://github.com/trustin","followers_url":"https://api.github.com/users/trustin/followers","following_url":"https://api.github.com/users/trustin/following{/other_user}","gists_url":"https://api.github.com/users/trustin/gists{/gist_id}","starred_url":"https://api.github.com/users/trustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustin/subscriptions","organizations_url":"https://api.github.com/users/trustin/orgs","repos_url":"https://api.github.com/users/trustin/repos","events_url":"https://api.github.com/users/trustin/events{/privacy}","received_events_url":"https://api.github.com/users/trustin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trustin/armeria","description":"Asynchronous RPC/API client/server library built on top of Java 8, Netty 4.1, HTTP/2, and Thrift","fork":true,"url":"https://api.github.com/repos/trustin/armeria","forks_url":"https://api.github.com/repos/trustin/armeria/forks","keys_url":"https://api.github.com/repos/trustin/armeria/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trustin/armeria/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trustin/armeria/teams","hooks_url":"https://api.github.com/repos/trustin/armeria/hooks","issue_events_url":"https://api.github.com/repos/trustin/armeria/issues/events{/number}","events_url":"https://api.github.com/repos/trustin/armeria/events","assignees_url":"https://api.github.com/repos/trustin/armeria/assignees{/user}","branches_url":"https://api.github.com/repos/trustin/armeria/branches{/branch}","tags_url":"https://api.github.com/repos/trustin/armeria/tags","blobs_url":"https://api.github.com/repos/trustin/armeria/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trustin/armeria/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trustin/armeria/git/refs{/sha}","trees_url":"https://api.github.com/repos/trustin/armeria/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trustin/armeria/statuses/{sha}","languages_url":"https://api.github.com/repos/trustin/armeria/languages","stargazers_url":"https://api.github.com/repos/trustin/armeria/stargazers","contributors_url":"https://api.github.com/repos/trustin/armeria/contributors","subscribers_url":"https://api.github.com/repos/trustin/armeria/subscribers","subscription_url":"https://api.github.com/repos/trustin/armeria/subscription","commits_url":"https://api.github.com/repos/trustin/armeria/commits{/sha}","git_commits_url":"https://api.github.com/repos/trustin/armeria/git/commits{/sha}","comments_url":"https://api.github.com/repos/trustin/armeria/comments{/number}","issue_comment_url":"https://api.github.com/repos/trustin/armeria/issues/comments{/number}","contents_url":"https://api.github.com/repos/trustin/armeria/contents/{+path}","compare_url":"https://api.github.com/repos/trustin/armeria/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trustin/armeria/merges","archive_url":"https://api.github.com/repos/trustin/armeria/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trustin/armeria/downloads","issues_url":"https://api.github.com/repos/trustin/armeria/issues{/number}","pulls_url":"https://api.github.com/repos/trustin/armeria/pulls{/number}","milestones_url":"https://api.github.com/repos/trustin/armeria/milestones{/number}","notifications_url":"https://api.github.com/repos/trustin/armeria/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trustin/armeria/labels{/name}","releases_url":"https://api.github.com/repos/trustin/armeria/releases{/id}","deployments_url":"https://api.github.com/repos/trustin/armeria/deployments","created_at":"2015-11-17T03:59:08Z","updated_at":"2018-07-19T08:27:25Z","pushed_at":"2018-07-19T08:43:08Z","git_url":"git://github.com/trustin/armeria.git","ssh_url":"git@github.com:trustin/armeria.git","clone_url":"https://github.com/trustin/armeria.git","svn_url":"https://github.com/trustin/armeria","homepage":"http://line.github.io/armeria/","size":51774,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":8,"default_branch":"master"}},"base":{"label":"line:master","ref":"master","sha":"c1c8681c7a05e6e2516da98e4085690157be5205","user":{"login":"line","id":13128444,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTI4NDQ0","avatar_url":"https://avatars2.githubusercontent.com/u/13128444?v=4","gravatar_id":"","url":"https://api.github.com/users/line","html_url":"https://github.com/line","followers_url":"https://api.github.com/users/line/followers","following_url":"https://api.github.com/users/line/following{/other_user}","gists_url":"https://api.github.com/users/line/gists{/gist_id}","starred_url":"https://api.github.com/users/line/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/line/subscriptions","organizations_url":"https://api.github.com/users/line/orgs","repos_url":"https://api.github.com/users/line/repos","events_url":"https://api.github.com/users/line/events{/privacy}","received_events_url":"https://api.github.com/users/line/received_events","type":"Organization","site_admin":false},"repo":{"id":46251204,"node_id":"MDEwOlJlcG9zaXRvcnk0NjI1MTIwNA==","name":"armeria","full_name":"line/armeria","owner":{"login":"line","id":13128444,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTI4NDQ0","avatar_url":"https://avatars2.githubusercontent.com/u/13128444?v=4","gravatar_id":"","url":"https://api.github.com/users/line","html_url":"https://github.com/line","followers_url":"https://api.github.com/users/line/followers","following_url":"https://api.github.com/users/line/following{/other_user}","gists_url":"https://api.github.com/users/line/gists{/gist_id}","starred_url":"https://api.github.com/users/line/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/line/subscriptions","organizations_url":"https://api.github.com/users/line/orgs","repos_url":"https://api.github.com/users/line/repos","events_url":"https://api.github.com/users/line/events{/privacy}","received_events_url":"https://api.github.com/users/line/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/line/armeria","description":"Asynchronous RPC/REST library built on top of Java 8, Netty, HTTP/2, Thrift and gRPC","fork":false,"url":"https://api.github.com/repos/line/armeria","forks_url":"https://api.github.com/repos/line/armeria/forks","keys_url":"https://api.github.com/repos/line/armeria/keys{/key_id}","collaborators_url":"https://api.github.com/repos/line/armeria/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/line/armeria/teams","hooks_url":"https://api.github.com/repos/line/armeria/hooks","issue_events_url":"https://api.github.com/repos/line/armeria/issues/events{/number}","events_url":"https://api.github.com/repos/line/armeria/events","assignees_url":"https://api.github.com/repos/line/armeria/assignees{/user}","branches_url":"https://api.github.com/repos/line/armeria/branches{/branch}","tags_url":"https://api.github.com/repos/line/armeria/tags","blobs_url":"https://api.github.com/repos/line/armeria/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/line/armeria/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/line/armeria/git/refs{/sha}","trees_url":"https://api.github.com/repos/line/armeria/git/trees{/sha}","statuses_url":"https://api.github.com/repos/line/armeria/statuses/{sha}","languages_url":"https://api.github.com/repos/line/armeria/languages","stargazers_url":"https://api.github.com/repos/line/armeria/stargazers","contributors_url":"https://api.github.com/repos/line/armeria/contributors","subscribers_url":"https://api.github.com/repos/line/armeria/subscribers","subscription_url":"https://api.github.com/repos/line/armeria/subscription","commits_url":"https://api.github.com/repos/line/armeria/commits{/sha}","git_commits_url":"https://api.github.com/repos/line/armeria/git/commits{/sha}","comments_url":"https://api.github.com/repos/line/armeria/comments{/number}","issue_comment_url":"https://api.github.com/repos/line/armeria/issues/comments{/number}","contents_url":"https://api.github.com/repos/line/armeria/contents/{+path}","compare_url":"https://api.github.com/repos/line/armeria/compare/{base}...{head}","merges_url":"https://api.github.com/repos/line/armeria/merges","archive_url":"https://api.github.com/repos/line/armeria/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/line/armeria/downloads","issues_url":"https://api.github.com/repos/line/armeria/issues{/number}","pulls_url":"https://api.github.com/repos/line/armeria/pulls{/number}","milestones_url":"https://api.github.com/repos/line/armeria/milestones{/number}","notifications_url":"https://api.github.com/repos/line/armeria/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/line/armeria/labels{/name}","releases_url":"https://api.github.com/repos/line/armeria/releases{/id}","deployments_url":"https://api.github.com/repos/line/armeria/deployments","created_at":"2015-11-16T04:04:01Z","updated_at":"2018-07-19T08:27:19Z","pushed_at":"2018-07-19T09:04:56Z","git_url":"git://github.com/line/armeria.git","ssh_url":"git@github.com:line/armeria.git","clone_url":"https://github.com/line/armeria.git","svn_url":"https://github.com/line/armeria","homepage":"https://line.github.io/armeria/","size":57061,"stargazers_count":1341,"watchers_count":1341,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":294,"mirror_url":null,"archived":false,"open_issues_count":104,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":294,"open_issues":104,"watchers":1341,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/line/armeria/pulls/1299"},"html":{"href":"https://github.com/line/armeria/pull/1299"},"issue":{"href":"https://api.github.com/repos/line/armeria/issues/1299"},"comments":{"href":"https://api.github.com/repos/line/armeria/issues/1299/comments"},"review_comments":{"href":"https://api.github.com/repos/line/armeria/pulls/1299/comments"},"review_comment":{"href":"https://api.github.com/repos/line/armeria/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/line/armeria/pulls/1299/commits"},"statuses":{"href":"https://api.github.com/repos/line/armeria/statuses/b8d3486edcaedada6aab50bc2cfbb29c533c2286"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"trustin","id":173918,"node_id":"MDQ6VXNlcjE3MzkxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/173918?v=4","gravatar_id":"","url":"https://api.github.com/users/trustin","html_url":"https://github.com/trustin","followers_url":"https://api.github.com/users/trustin/followers","following_url":"https://api.github.com/users/trustin/following{/other_user}","gists_url":"https://api.github.com/users/trustin/gists{/gist_id}","starred_url":"https://api.github.com/users/trustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustin/subscriptions","organizations_url":"https://api.github.com/users/trustin/orgs","repos_url":"https://api.github.com/users/trustin/repos","events_url":"https://api.github.com/users/trustin/events{/privacy}","received_events_url":"https://api.github.com/users/trustin/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":12,"deletions":5,"changed_files":2}}
{"actor":{"display_login":"trustin"}}