{"action":"created","comment":{"url":"https://api.github.com/repos/adshares/adserver/pulls/comments/201866916","pull_request_review_id":136453832,"id":201866916,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTg2NjkxNg==","diff_hunk":"@@ -78,7 +86,7 @@ protected function readBroadcasts(Esc $esc)\n                 $this->info(\"Found $host -> {$log['address']}\");\n                 // TODO: extract algo\n                 if (preg_match('/^([a-z0-9][a-z0-9-]{0,62}\\.)+([a-z]{2,})$/i', $host)) {\n-                    NetworkHost::registerHost(Esc::normalizeAddress($log['address']), $host);\n+                    NetworkHost::registerHost(AdsUtils::normalizeAddress($log['address']), $host);\n                 // TODO: check this with Jacek in adserver symfony code\n                     // $nHost->setAccountMsid($log['account_msid']);","path":"app/Console/Commands/AdsharesCrawlCommand.php","position":63,"original_position":63,"commit_id":"adeb94284ea757fc3ac1d3d929436a7af3700ebf","original_commit_id":"adeb94284ea757fc3ac1d3d929436a7af3700ebf","user":{"login":"adshares-tech","id":37212325,"node_id":"MDQ6VXNlcjM3MjEyMzI1","avatar_url":"https://avatars2.githubusercontent.com/u/37212325?v=4","gravatar_id":"","url":"https://api.github.com/users/adshares-tech","html_url":"https://github.com/adshares-tech","followers_url":"https://api.github.com/users/adshares-tech/followers","following_url":"https://api.github.com/users/adshares-tech/following{/other_user}","gists_url":"https://api.github.com/users/adshares-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/adshares-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adshares-tech/subscriptions","organizations_url":"https://api.github.com/users/adshares-tech/orgs","repos_url":"https://api.github.com/users/adshares-tech/repos","events_url":"https://api.github.com/users/adshares-tech/events{/privacy}","received_events_url":"https://api.github.com/users/adshares-tech/received_events","type":"User","site_admin":false},"body":"![MAJOR](https://sonarsource.github.io/sonar-github/severity-major.png 'Severity: MAJOR') Remove this commented out code. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=php%3AS125)\n","created_at":"2018-07-11T23:08:19Z","updated_at":"2018-07-11T23:08:19Z","html_url":"https://github.com/adshares/adserver/pull/61#discussion_r201866916","pull_request_url":"https://api.github.com/repos/adshares/adserver/pulls/61","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/adshares/adserver/pulls/comments/201866916"},"html":{"href":"https://github.com/adshares/adserver/pull/61#discussion_r201866916"},"pull_request":{"href":"https://api.github.com/repos/adshares/adserver/pulls/61"}}},"pull_request":{"url":"https://api.github.com/repos/adshares/adserver/pulls/61","id":200848941,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwODQ4OTQx","html_url":"https://github.com/adshares/adserver/pull/61","diff_url":"https://github.com/adshares/adserver/pull/61.diff","patch_url":"https://github.com/adshares/adserver/pull/61.patch","issue_url":"https://api.github.com/repos/adshares/adserver/issues/61","number":61,"state":"closed","locked":false,"title":"Services integration followup fixes refactoring","user":{"login":"yodahack","id":19958053,"node_id":"MDQ6VXNlcjE5OTU4MDUz","avatar_url":"https://avatars1.githubusercontent.com/u/19958053?v=4","gravatar_id":"","url":"https://api.github.com/users/yodahack","html_url":"https://github.com/yodahack","followers_url":"https://api.github.com/users/yodahack/followers","following_url":"https://api.github.com/users/yodahack/following{/other_user}","gists_url":"https://api.github.com/users/yodahack/gists{/gist_id}","starred_url":"https://api.github.com/users/yodahack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yodahack/subscriptions","organizations_url":"https://api.github.com/users/yodahack/orgs","repos_url":"https://api.github.com/users/yodahack/repos","events_url":"https://api.github.com/users/yodahack/events{/privacy}","received_events_url":"https://api.github.com/users/yodahack/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-11T23:06:37Z","updated_at":"2018-07-11T23:08:19Z","closed_at":"2018-07-11T23:07:46Z","merged_at":"2018-07-11T23:07:46Z","merge_commit_sha":"27ef5945272e13086662782defc692784ac3cdad","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/adshares/adserver/pulls/61/commits","review_comments_url":"https://api.github.com/repos/adshares/adserver/pulls/61/comments","review_comment_url":"https://api.github.com/repos/adshares/adserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adshares/adserver/issues/61/comments","statuses_url":"https://api.github.com/repos/adshares/adserver/statuses/adeb94284ea757fc3ac1d3d929436a7af3700ebf","head":{"label":"adshares:services-integration-followup-fixes-refactoring","ref":"services-integration-followup-fixes-refactoring","sha":"adeb94284ea757fc3ac1d3d929436a7af3700ebf","user":{"login":"adshares","id":19405131,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDA1MTMx","avatar_url":"https://avatars2.githubusercontent.com/u/19405131?v=4","gravatar_id":"","url":"https://api.github.com/users/adshares","html_url":"https://github.com/adshares","followers_url":"https://api.github.com/users/adshares/followers","following_url":"https://api.github.com/users/adshares/following{/other_user}","gists_url":"https://api.github.com/users/adshares/gists{/gist_id}","starred_url":"https://api.github.com/users/adshares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adshares/subscriptions","organizations_url":"https://api.github.com/users/adshares/orgs","repos_url":"https://api.github.com/users/adshares/repos","events_url":"https://api.github.com/users/adshares/events{/privacy}","received_events_url":"https://api.github.com/users/adshares/received_events","type":"Organization","site_admin":false},"repo":{"id":127163371,"node_id":"MDEwOlJlcG9zaXRvcnkxMjcxNjMzNzE=","name":"adserver","full_name":"adshares/adserver","owner":{"login":"adshares","id":19405131,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDA1MTMx","avatar_url":"https://avatars2.githubusercontent.com/u/19405131?v=4","gravatar_id":"","url":"https://api.github.com/users/adshares","html_url":"https://github.com/adshares","followers_url":"https://api.github.com/users/adshares/followers","following_url":"https://api.github.com/users/adshares/following{/other_user}","gists_url":"https://api.github.com/users/adshares/gists{/gist_id}","starred_url":"https://api.github.com/users/adshares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adshares/subscriptions","organizations_url":"https://api.github.com/users/adshares/orgs","repos_url":"https://api.github.com/users/adshares/repos","events_url":"https://api.github.com/users/adshares/events{/privacy}","received_events_url":"https://api.github.com/users/adshares/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adshares/adserver","description":null,"fork":false,"url":"https://api.github.com/repos/adshares/adserver","forks_url":"https://api.github.com/repos/adshares/adserver/forks","keys_url":"https://api.github.com/repos/adshares/adserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adshares/adserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adshares/adserver/teams","hooks_url":"https://api.github.com/repos/adshares/adserver/hooks","issue_events_url":"https://api.github.com/repos/adshares/adserver/issues/events{/number}","events_url":"https://api.github.com/repos/adshares/adserver/events","assignees_url":"https://api.github.com/repos/adshares/adserver/assignees{/user}","branches_url":"https://api.github.com/repos/adshares/adserver/branches{/branch}","tags_url":"https://api.github.com/repos/adshares/adserver/tags","blobs_url":"https://api.github.com/repos/adshares/adserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adshares/adserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adshares/adserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/adshares/adserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adshares/adserver/statuses/{sha}","languages_url":"https://api.github.com/repos/adshares/adserver/languages","stargazers_url":"https://api.github.com/repos/adshares/adserver/stargazers","contributors_url":"https://api.github.com/repos/adshares/adserver/contributors","subscribers_url":"https://api.github.com/repos/adshares/adserver/subscribers","subscription_url":"https://api.github.com/repos/adshares/adserver/subscription","commits_url":"https://api.github.com/repos/adshares/adserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/adshares/adserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/adshares/adserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/adshares/adserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/adshares/adserver/contents/{+path}","compare_url":"https://api.github.com/repos/adshares/adserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adshares/adserver/merges","archive_url":"https://api.github.com/repos/adshares/adserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adshares/adserver/downloads","issues_url":"https://api.github.com/repos/adshares/adserver/issues{/number}","pulls_url":"https://api.github.com/repos/adshares/adserver/pulls{/number}","milestones_url":"https://api.github.com/repos/adshares/adserver/milestones{/number}","notifications_url":"https://api.github.com/repos/adshares/adserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adshares/adserver/labels{/name}","releases_url":"https://api.github.com/repos/adshares/adserver/releases{/id}","deployments_url":"https://api.github.com/repos/adshares/adserver/deployments","created_at":"2018-03-28T15:46:40Z","updated_at":"2018-07-11T23:07:48Z","pushed_at":"2018-07-11T23:07:49Z","git_url":"git://github.com/adshares/adserver.git","ssh_url":"git@github.com:adshares/adserver.git","clone_url":"https://github.com/adshares/adserver.git","svn_url":"https://github.com/adshares/adserver","homepage":null,"size":664,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":16,"license":null,"forks":0,"open_issues":16,"watchers":2,"default_branch":"develop"}},"base":{"label":"adshares:develop","ref":"develop","sha":"c5d2a91984499dd2631028d6f2879578765b770e","user":{"login":"adshares","id":19405131,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDA1MTMx","avatar_url":"https://avatars2.githubusercontent.com/u/19405131?v=4","gravatar_id":"","url":"https://api.github.com/users/adshares","html_url":"https://github.com/adshares","followers_url":"https://api.github.com/users/adshares/followers","following_url":"https://api.github.com/users/adshares/following{/other_user}","gists_url":"https://api.github.com/users/adshares/gists{/gist_id}","starred_url":"https://api.github.com/users/adshares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adshares/subscriptions","organizations_url":"https://api.github.com/users/adshares/orgs","repos_url":"https://api.github.com/users/adshares/repos","events_url":"https://api.github.com/users/adshares/events{/privacy}","received_events_url":"https://api.github.com/users/adshares/received_events","type":"Organization","site_admin":false},"repo":{"id":127163371,"node_id":"MDEwOlJlcG9zaXRvcnkxMjcxNjMzNzE=","name":"adserver","full_name":"adshares/adserver","owner":{"login":"adshares","id":19405131,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDA1MTMx","avatar_url":"https://avatars2.githubusercontent.com/u/19405131?v=4","gravatar_id":"","url":"https://api.github.com/users/adshares","html_url":"https://github.com/adshares","followers_url":"https://api.github.com/users/adshares/followers","following_url":"https://api.github.com/users/adshares/following{/other_user}","gists_url":"https://api.github.com/users/adshares/gists{/gist_id}","starred_url":"https://api.github.com/users/adshares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adshares/subscriptions","organizations_url":"https://api.github.com/users/adshares/orgs","repos_url":"https://api.github.com/users/adshares/repos","events_url":"https://api.github.com/users/adshares/events{/privacy}","received_events_url":"https://api.github.com/users/adshares/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adshares/adserver","description":null,"fork":false,"url":"https://api.github.com/repos/adshares/adserver","forks_url":"https://api.github.com/repos/adshares/adserver/forks","keys_url":"https://api.github.com/repos/adshares/adserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adshares/adserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adshares/adserver/teams","hooks_url":"https://api.github.com/repos/adshares/adserver/hooks","issue_events_url":"https://api.github.com/repos/adshares/adserver/issues/events{/number}","events_url":"https://api.github.com/repos/adshares/adserver/events","assignees_url":"https://api.github.com/repos/adshares/adserver/assignees{/user}","branches_url":"https://api.github.com/repos/adshares/adserver/branches{/branch}","tags_url":"https://api.github.com/repos/adshares/adserver/tags","blobs_url":"https://api.github.com/repos/adshares/adserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adshares/adserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adshares/adserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/adshares/adserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adshares/adserver/statuses/{sha}","languages_url":"https://api.github.com/repos/adshares/adserver/languages","stargazers_url":"https://api.github.com/repos/adshares/adserver/stargazers","contributors_url":"https://api.github.com/repos/adshares/adserver/contributors","subscribers_url":"https://api.github.com/repos/adshares/adserver/subscribers","subscription_url":"https://api.github.com/repos/adshares/adserver/subscription","commits_url":"https://api.github.com/repos/adshares/adserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/adshares/adserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/adshares/adserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/adshares/adserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/adshares/adserver/contents/{+path}","compare_url":"https://api.github.com/repos/adshares/adserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adshares/adserver/merges","archive_url":"https://api.github.com/repos/adshares/adserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adshares/adserver/downloads","issues_url":"https://api.github.com/repos/adshares/adserver/issues{/number}","pulls_url":"https://api.github.com/repos/adshares/adserver/pulls{/number}","milestones_url":"https://api.github.com/repos/adshares/adserver/milestones{/number}","notifications_url":"https://api.github.com/repos/adshares/adserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adshares/adserver/labels{/name}","releases_url":"https://api.github.com/repos/adshares/adserver/releases{/id}","deployments_url":"https://api.github.com/repos/adshares/adserver/deployments","created_at":"2018-03-28T15:46:40Z","updated_at":"2018-07-11T23:07:48Z","pushed_at":"2018-07-11T23:07:49Z","git_url":"git://github.com/adshares/adserver.git","ssh_url":"git@github.com:adshares/adserver.git","clone_url":"https://github.com/adshares/adserver.git","svn_url":"https://github.com/adshares/adserver","homepage":null,"size":664,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":16,"license":null,"forks":0,"open_issues":16,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/adshares/adserver/pulls/61"},"html":{"href":"https://github.com/adshares/adserver/pull/61"},"issue":{"href":"https://api.github.com/repos/adshares/adserver/issues/61"},"comments":{"href":"https://api.github.com/repos/adshares/adserver/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/adshares/adserver/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/adshares/adserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adshares/adserver/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/adshares/adserver/statuses/adeb94284ea757fc3ac1d3d929436a7af3700ebf"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"adshares-tech"}}