{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/vaadin-grid-flow/issues/241","repository_url":"https://api.github.com/repos/vaadin/vaadin-grid-flow","labels_url":"https://api.github.com/repos/vaadin/vaadin-grid-flow/issues/241/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/vaadin-grid-flow/issues/241/comments","events_url":"https://api.github.com/repos/vaadin/vaadin-grid-flow/issues/241/events","html_url":"https://github.com/vaadin/vaadin-grid-flow/pull/241","id":335707792,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MzM4Mjgy","number":241,"title":"Merge tree grid","user":{"login":"denis-anisimov","id":11425472,"node_id":"MDQ6VXNlcjExNDI1NDcy","avatar_url":"https://avatars0.githubusercontent.com/u/11425472?v=4","gravatar_id":"","url":"https://api.github.com/users/denis-anisimov","html_url":"https://github.com/denis-anisimov","followers_url":"https://api.github.com/users/denis-anisimov/followers","following_url":"https://api.github.com/users/denis-anisimov/following{/other_user}","gists_url":"https://api.github.com/users/denis-anisimov/gists{/gist_id}","starred_url":"https://api.github.com/users/denis-anisimov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denis-anisimov/subscriptions","organizations_url":"https://api.github.com/users/denis-anisimov/orgs","repos_url":"https://api.github.com/users/denis-anisimov/repos","events_url":"https://api.github.com/users/denis-anisimov/events{/privacy}","received_events_url":"https://api.github.com/users/denis-anisimov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-26T08:18:03Z","updated_at":"2018-06-27T06:11:45Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/vaadin/vaadin-grid-flow/pulls/241","html_url":"https://github.com/vaadin/vaadin-grid-flow/pull/241","diff_url":"https://github.com/vaadin/vaadin-grid-flow/pull/241.diff","patch_url":"https://github.com/vaadin/vaadin-grid-flow/pull/241.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/241)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/vaadin/vaadin-grid-flow/issues/comments/400554329","html_url":"https://github.com/vaadin/vaadin-grid-flow/pull/241#issuecomment-400554329","issue_url":"https://api.github.com/repos/vaadin/vaadin-grid-flow/issues/241","id":400554329,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDU1NDMyOQ==","user":{"login":"denis-anisimov","id":11425472,"node_id":"MDQ6VXNlcjExNDI1NDcy","avatar_url":"https://avatars0.githubusercontent.com/u/11425472?v=4","gravatar_id":"","url":"https://api.github.com/users/denis-anisimov","html_url":"https://github.com/denis-anisimov","followers_url":"https://api.github.com/users/denis-anisimov/followers","following_url":"https://api.github.com/users/denis-anisimov/following{/other_user}","gists_url":"https://api.github.com/users/denis-anisimov/gists{/gist_id}","starred_url":"https://api.github.com/users/denis-anisimov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denis-anisimov/subscriptions","organizations_url":"https://api.github.com/users/denis-anisimov/orgs","repos_url":"https://api.github.com/users/denis-anisimov/repos","events_url":"https://api.github.com/users/denis-anisimov/events{/privacy}","received_events_url":"https://api.github.com/users/denis-anisimov/received_events","type":"User","site_admin":false},"created_at":"2018-06-27T06:11:45Z","updated_at":"2018-06-27T06:11:45Z","author_association":"CONTRIBUTOR","body":"\n\n\n\nDismissed @vaadin-bot from 30 discussions.\nReview status: :shipit: complete! all files reviewed, all discussions resolved\n\n---\n\n*[src/main/java/com/vaadin/flow/component/grid/Grid.java, line 115 at r1](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/241#-LFv9xyqhSLkboLOzP3v-r1-115:-LFzrYIJ2wjW4IA-VNOV:b-896fix) ([raw file](https://github.com/vaadin/vaadin-grid-flow/blob/8b67e07f1f382c2d02c24d0f1bb7e4974635f033/src/main/java/com/vaadin/flow/component/grid/Grid.java#L115)):*\n<details><summary><i>Previously, vaadin-bot (Vaadin Bot) wrote…</i></summary><blockquote>\n\n![CRITICAL](https://sonarsource.github.io/sonar-github/severity-critical.png 'Severity: CRITICAL') Make \"queue\" transient or serializable. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS1948)\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/main/java/com/vaadin/flow/component/treegrid/CollapseEvent.java, line 27 at r1](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/241#-LFv9xyqhSLkboLOzP41-r1-27:-LFzrZfB3WQ5I37Quh8i:b-896fix) ([raw file](https://github.com/vaadin/vaadin-grid-flow/blob/8b67e07f1f382c2d02c24d0f1bb7e4974635f033/src/main/java/com/vaadin/flow/component/treegrid/CollapseEvent.java#L27)):*\n<details><summary><i>Previously, vaadin-bot (Vaadin Bot) wrote…</i></summary><blockquote>\n\n![CRITICAL](https://sonarsource.github.io/sonar-github/severity-critical.png 'Severity: CRITICAL') Make \"items\" transient or serializable. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS1948)\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/main/java/com/vaadin/flow/component/treegrid/ExpandEvent.java, line 27 at r1](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/241#-LFv9xyqhSLkboLOzP42-r1-27:-LFzrJURCpI-gekL7qy7:b-896fix) ([raw file](https://github.com/vaadin/vaadin-grid-flow/blob/8b67e07f1f382c2d02c24d0f1bb7e4974635f033/src/main/java/com/vaadin/flow/component/treegrid/ExpandEvent.java#L27)):*\n<details><summary><i>Previously, vaadin-bot (Vaadin Bot) wrote…</i></summary><blockquote>\n\n![CRITICAL](https://sonarsource.github.io/sonar-github/severity-critical.png 'Severity: CRITICAL') Make \"items\" transient or serializable. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS1948)\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/main/java/com/vaadin/flow/component/treegrid/TreeGrid.java, line 68 at r1](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/241#-LFv9xyqhSLkboLOzP43-r1-68:-LFzrKH88O1BwUSQ8AjM:b-896fix) ([raw file](https://github.com/vaadin/vaadin-grid-flow/blob/8b67e07f1f382c2d02c24d0f1bb7e4974635f033/src/main/java/com/vaadin/flow/component/treegrid/TreeGrid.java#L68)):*\n<details><summary><i>Previously, vaadin-bot (Vaadin Bot) wrote…</i></summary><blockquote>\n\n![CRITICAL](https://sonarsource.github.io/sonar-github/severity-critical.png 'Severity: CRITICAL') Rename this class. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS2176)\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/main/java/com/vaadin/flow/component/treegrid/TreeGrid.java, line 401 at r1](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/241#-LFv9xyqhSLkboLOzP43-r1-401:-LFzrL4cDSdM-JNaXZDy:b-896fix) ([raw file](https://github.com/vaadin/vaadin-grid-flow/blob/8b67e07f1f382c2d02c24d0f1bb7e4974635f033/src/main/java/com/vaadin/flow/component/treegrid/TreeGrid.java#L401)):*\n<details><summary><i>Previously, vaadin-bot (Vaadin Bot) wrote…</i></summary><blockquote>\n\n![MAJOR](https://sonarsource.github.io/sonar-github/severity-major.png 'Severity: MAJOR') Call \"Optional#isPresent()\" before accessing the value. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS3655)\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/main/java/com/vaadin/flow/component/treegrid/TreeGrid.java, line 402 at r1](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/241#-LFv9xyqhSLkboLOzP43-r1-402:-LFzrLiV0H-p3PUoGC_Y:b-896fix) ([raw file](https://github.com/vaadin/vaadin-grid-flow/blob/8b67e07f1f382c2d02c24d0f1bb7e4974635f033/src/main/java/com/vaadin/flow/component/treegrid/TreeGrid.java#L402)):*\n<details><summary><i>Previously, vaadin-bot (Vaadin Bot) wrote…</i></summary><blockquote>\n\n![MAJOR](https://sonarsource.github.io/sonar-github/severity-major.png 'Severity: MAJOR') Either log or rethrow this exception. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS1166)\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/main/java/com/vaadin/flow/component/treegrid/TreeGrid.java, line 416 at r1](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/241#-LFv9xyqhSLkboLOzP43-r1-416:-LFzrM9i6yPwKirpl7Ny:b-896fix) ([raw file](https://github.com/vaadin/vaadin-grid-flow/blob/8b67e07f1f382c2d02c24d0f1bb7e4974635f033/src/main/java/com/vaadin/flow/component/treegrid/TreeGrid.java#L416)):*\n<details><summary><i>Previously, vaadin-bot (Vaadin Bot) wrote…</i></summary><blockquote>\n\n![MAJOR](https://sonarsource.github.io/sonar-github/severity-major.png 'Severity: MAJOR') Either log or rethrow this exception. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS1166)\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/main/java/com/vaadin/flow/data/provider/CommunicationController.java, line 43 at r1](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/241#-LFv9xyqhSLkboLOzP44-r1-43:-LFzrMfb-BzLQXcrubka:b-896fix) ([raw file](https://github.com/vaadin/vaadin-grid-flow/blob/8b67e07f1f382c2d02c24d0f1bb7e4974635f033/src/main/java/com/vaadin/flow/data/provider/CommunicationController.java#L43)):*\n<details><summary><i>Previously, vaadin-bot (Vaadin Bot) wrote…</i></summary><blockquote>\n\n![INFO](https://sonarsource.github.io/sonar-github/severity-info.png 'Severity: INFO') Complete the task associated to this TODO comment. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS1135)\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/main/java/com/vaadin/flow/data/provider/CommunicationController.java, line 172 at r1](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/241#-LFv9xyqhSLkboLOzP44-r1-172:-LFzrN7QDen9xcwX7qoQ:b-896fix) ([raw file](https://github.com/vaadin/vaadin-grid-flow/blob/8b67e07f1f382c2d02c24d0f1bb7e4974635f033/src/main/java/com/vaadin/flow/data/provider/CommunicationController.java#L172)):*\n<details><summary><i>Previously, vaadin-bot (Vaadin Bot) wrote…</i></summary><blockquote>\n\n![INFO](https://sonarsource.github.io/sonar-github/severity-info.png 'Severity: INFO') Complete the task associated to this TODO comment. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS1135)\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/main/java/com/vaadin/flow/data/provider/hierarchy/HierarchicalDataCommunicator.java, line 71 at r1](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/241#-LFv9xyqhSLkboLOzP4A-r1-71:-LFzrNpJ4qpheJRME3O_:b-896fix) ([raw file](https://github.com/vaadin/vaadin-grid-flow/blob/8b67e07f1f382c2d02c24d0f1bb7e4974635f033/src/main/java/com/vaadin/flow/data/provider/hierarchy/HierarchicalDataCommunicator.java#L71)):*\n<details><summary><i>Previously, vaadin-bot (Vaadin Bot) wrote…</i></summary><blockquote>\n\n![CRITICAL](https://sonarsource.github.io/sonar-github/severity-critical.png 'Severity: CRITICAL') Make \"object\" transient or serializable. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS1948)\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/main/java/com/vaadin/flow/data/provider/hierarchy/HierarchicalDataCommunicator.java, line 118 at r1](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/241#-LFv9xyqhSLkboLOzP4A-r1-118:-LFzrOLiAcw3cYXWHFPr:b-896fix) ([raw file](https://github.com/vaadin/vaadin-grid-flow/blob/8b67e07f1f382c2d02c24d0f1bb7e4974635f033/src/main/java/com/vaadin/flow/data/provider/hierarchy/HierarchicalDataCommunicator.java#L118)):*\n<details><summary><i>Previously, vaadin-bot (Vaadin Bot) wrote…</i></summary><blockquote>\n\n![INFO](https://sonarsource.github.io/sonar-github/severity-info.png 'Severity: INFO') Complete the task associated to this TODO comment. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS1135)\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/main/java/com/vaadin/flow/data/provider/hierarchy/HierarchicalDataCommunicator.java, line 120 at r1](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/241#-LFv9xyqhSLkboLOzP4A-r1-120:-LFzrP8cEEhwoKUwZcmM:b-896fix) ([raw file](https://github.com/vaadin/vaadin-grid-flow/blob/8b67e07f1f382c2d02c24d0f1bb7e4974635f033/src/main/java/com/vaadin/flow/data/provider/hierarchy/HierarchicalDataCommunicator.java#L120)):*\n<details><summary><i>Previously, vaadin-bot (Vaadin Bot) wrote…</i></summary><blockquote>\n\n![MAJOR](https://sonarsource.github.io/sonar-github/severity-major.png 'Severity: MAJOR') Either log or rethrow this exception. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS1166)\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/main/java/com/vaadin/flow/data/provider/hierarchy/HierarchicalDataCommunicator.java, line 121 at r1](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/241#-LFv9xyqhSLkboLOzP4A-r1-121:-LFzrPiz35rBh3vzUacj:b-896fix) ([raw file](https://github.com/vaadin/vaadin-grid-flow/blob/8b67e07f1f382c2d02c24d0f1bb7e4974635f033/src/main/java/com/vaadin/flow/data/provider/hierarchy/HierarchicalDataCommunicator.java#L121)):*\n<details><summary><i>Previously, vaadin-bot (Vaadin Bot) wrote…</i></summary><blockquote>\n\n![INFO](https://sonarsource.github.io/sonar-github/severity-info.png 'Severity: INFO') Complete the task associated to this TODO comment. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS1135)\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/main/java/com/vaadin/flow/data/provider/hierarchy/HierarchicalDataCommunicator.java, line 122 at r1](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/241#-LFv9xyqhSLkboLOzP4A-r1-122:-LFzrQFAACrq_A6Mua4H:b-896fix) ([raw file](https://github.com/vaadin/vaadin-grid-flow/blob/8b67e07f1f382c2d02c24d0f1bb7e4974635f033/src/main/java/com/vaadin/flow/data/provider/hierarchy/HierarchicalDataCommunicator.java#L122)):*\n<details><summary><i>Previously, vaadin-bot (Vaadin Bot) wrote…</i></summary><blockquote>\n\n![MINOR](https://sonarsource.github.io/sonar-github/severity-minor.png 'Severity: MINOR') Use a logger to log this exception. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS1148)\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/main/java/com/vaadin/flow/data/provider/hierarchy/HierarchicalDataCommunicator.java, line 523 at r1](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/241#-LFv9xyqhSLkboLOzP4A-r1-523:-LFzrQiLEWxHKofl6461:b-896fix) ([raw file](https://github.com/vaadin/vaadin-grid-flow/blob/8b67e07f1f382c2d02c24d0f1bb7e4974635f033/src/main/java/com/vaadin/flow/data/provider/hierarchy/HierarchicalDataCommunicator.java#L523)):*\n<details><summary><i>Previously, vaadin-bot (Vaadin Bot) wrote…</i></summary><blockquote>\n\n![CRITICAL](https://sonarsource.github.io/sonar-github/severity-critical.png 'Severity: CRITICAL') Remove usage of generic wildcard type. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS1452)\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/main/java/com/vaadin/flow/data/provider/hierarchy/HierarchicalQuery.java, line 37 at r1](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/241#-LFv9xyqhSLkboLOzP4C-r1-37:-LFzrREY8VjEDMDnFLTP:b-896fix) ([raw file](https://github.com/vaadin/vaadin-grid-flow/blob/8b67e07f1f382c2d02c24d0f1bb7e4974635f033/src/main/java/com/vaadin/flow/data/provider/hierarchy/HierarchicalQuery.java#L37)):*\n<details><summary><i>Previously, vaadin-bot (Vaadin Bot) wrote…</i></summary><blockquote>\n\n![CRITICAL](https://sonarsource.github.io/sonar-github/severity-critical.png 'Severity: CRITICAL') Make \"parent\" transient or serializable. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS1948)\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/main/java/com/vaadin/flow/data/provider/hierarchy/HierarchyMapper.java, line 57 at r1](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/241#-LFv9xyqhSLkboLOzP4D-r1-57:-LFzrRkh--1gdstkF-97:b-896fix) ([raw file](https://github.com/vaadin/vaadin-grid-flow/blob/8b67e07f1f382c2d02c24d0f1bb7e4974635f033/src/main/java/com/vaadin/flow/data/provider/hierarchy/HierarchyMapper.java#L57)):*\n<details><summary><i>Previously, vaadin-bot (Vaadin Bot) wrote…</i></summary><blockquote>\n\n![CRITICAL](https://sonarsource.github.io/sonar-github/severity-critical.png 'Severity: CRITICAL') Make \"childMap\" transient or serializable. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS1948)\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/main/java/com/vaadin/flow/data/provider/hierarchy/HierarchyMapper.java, line 58 at r1](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/241#-LFv9xyqhSLkboLOzP4D-r1-58:-LFzrS7u1Jzk9ULJz_aF:b-896fix) ([raw file](https://github.com/vaadin/vaadin-grid-flow/blob/8b67e07f1f382c2d02c24d0f1bb7e4974635f033/src/main/java/com/vaadin/flow/data/provider/hierarchy/HierarchyMapper.java#L58)):*\n<details><summary><i>Previously, vaadin-bot (Vaadin Bot) wrote…</i></summary><blockquote>\n\n![CRITICAL](https://sonarsource.github.io/sonar-github/severity-critical.png 'Severity: CRITICAL') Make \"parentIdMap\" transient or serializable. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS1948)\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/main/java/com/vaadin/flow/data/provider/hierarchy/HierarchyMapper.java, line 61 at r1](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/241#-LFv9xyqhSLkboLOzP4D-r1-61:-LFzrSnEBdoC-YT5jcik:b-896fix) ([raw file](https://github.com/vaadin/vaadin-grid-flow/blob/8b67e07f1f382c2d02c24d0f1bb7e4974635f033/src/main/java/com/vaadin/flow/data/provider/hierarchy/HierarchyMapper.java#L61)):*\n<details><summary><i>Previously, vaadin-bot (Vaadin Bot) wrote…</i></summary><blockquote>\n\n![CRITICAL](https://sonarsource.github.io/sonar-github/severity-critical.png 'Severity: CRITICAL') Make \"filter\" transient or serializable. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS1948)\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/main/java/com/vaadin/flow/data/provider/hierarchy/HierarchyMapper.java, line 63 at r1](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/241#-LFv9xyqhSLkboLOzP4D-r1-63:-LFzrT7I6zOZp1S0f3zB:b-896fix) ([raw file](https://github.com/vaadin/vaadin-grid-flow/blob/8b67e07f1f382c2d02c24d0f1bb7e4974635f033/src/main/java/com/vaadin/flow/data/provider/hierarchy/HierarchyMapper.java#L63)):*\n<details><summary><i>Previously, vaadin-bot (Vaadin Bot) wrote…</i></summary><blockquote>\n\n![CRITICAL](https://sonarsource.github.io/sonar-github/severity-critical.png 'Severity: CRITICAL') Make \"inMemorySorting\" transient or serializable. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS1948)\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/main/java/com/vaadin/flow/data/provider/hierarchy/HierarchyMapper.java, line 65 at r1](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/241#-LFv9xyqhSLkboLOzP4D-r1-65:-LFzrTeb2nqpZ8JM5XKS:b-896fix) ([raw file](https://github.com/vaadin/vaadin-grid-flow/blob/8b67e07f1f382c2d02c24d0f1bb7e4974635f033/src/main/java/com/vaadin/flow/data/provider/hierarchy/HierarchyMapper.java#L65)):*\n<details><summary><i>Previously, vaadin-bot (Vaadin Bot) wrote…</i></summary><blockquote>\n\n![CRITICAL](https://sonarsource.github.io/sonar-github/severity-critical.png 'Severity: CRITICAL') Make \"expandedItemIds\" transient or serializable. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS1948)\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/main/java/com/vaadin/flow/data/provider/hierarchy/TreeData.java, line 45 at r1](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/241#-LFv9xyqhSLkboLOzP4E-r1-45:-LFzrUQmDUpyHlMqN4-9:b-896fix) ([raw file](https://github.com/vaadin/vaadin-grid-flow/blob/8b67e07f1f382c2d02c24d0f1bb7e4974635f033/src/main/java/com/vaadin/flow/data/provider/hierarchy/TreeData.java#L45)):*\n<details><summary><i>Previously, vaadin-bot (Vaadin Bot) wrote…</i></summary><blockquote>\n\n![CRITICAL](https://sonarsource.github.io/sonar-github/severity-critical.png 'Severity: CRITICAL') Make \"parent\" transient or serializable. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS1948)\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/main/java/com/vaadin/flow/data/provider/hierarchy/TreeData.java, line 46 at r1](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/241#-LFv9xyqhSLkboLOzP4E-r1-46:-LFzrUjk3156KVe55Ep5:b-896fix) ([raw file](https://github.com/vaadin/vaadin-grid-flow/blob/8b67e07f1f382c2d02c24d0f1bb7e4974635f033/src/main/java/com/vaadin/flow/data/provider/hierarchy/TreeData.java#L46)):*\n<details><summary><i>Previously, vaadin-bot (Vaadin Bot) wrote…</i></summary><blockquote>\n\n![CRITICAL](https://sonarsource.github.io/sonar-github/severity-critical.png 'Severity: CRITICAL') Make \"children\" transient or serializable. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS1948)\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/main/java/com/vaadin/flow/data/provider/hierarchy/TreeData.java, line 70 at r1](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/241#-LFv9xyqhSLkboLOzP4E-r1-70:-LFzrVIx6Wr-aExPBQV-:b-896fix) ([raw file](https://github.com/vaadin/vaadin-grid-flow/blob/8b67e07f1f382c2d02c24d0f1bb7e4974635f033/src/main/java/com/vaadin/flow/data/provider/hierarchy/TreeData.java#L70)):*\n<details><summary><i>Previously, vaadin-bot (Vaadin Bot) wrote…</i></summary><blockquote>\n\n![MINOR](https://sonarsource.github.io/sonar-github/severity-minor.png 'Severity: MINOR') This call to \"remove()\" may be a performance hot spot if the collection is large. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS2250)\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/main/java/com/vaadin/flow/data/provider/hierarchy/TreeData.java, line 74 at r1](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/241#-LFv9xyqhSLkboLOzP4E-r1-74:-LFzrVds62w7vLQbRRE2:b-896fix) ([raw file](https://github.com/vaadin/vaadin-grid-flow/blob/8b67e07f1f382c2d02c24d0f1bb7e4974635f033/src/main/java/com/vaadin/flow/data/provider/hierarchy/TreeData.java#L74)):*\n<details><summary><i>Previously, vaadin-bot (Vaadin Bot) wrote…</i></summary><blockquote>\n\n![CRITICAL](https://sonarsource.github.io/sonar-github/severity-critical.png 'Severity: CRITICAL') Make \"itemToWrapperMap\" transient or serializable. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS1948)\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/main/java/com/vaadin/flow/data/provider/hierarchy/TreeData.java, line 303 at r1](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/241#-LFv9xyqhSLkboLOzP4E-r1-303:-LFzrW7tDDLeS37wefnY:b-896fix) ([raw file](https://github.com/vaadin/vaadin-grid-flow/blob/8b67e07f1f382c2d02c24d0f1bb7e4974635f033/src/main/java/com/vaadin/flow/data/provider/hierarchy/TreeData.java#L303)):*\n<details><summary><i>Previously, vaadin-bot (Vaadin Bot) wrote…</i></summary><blockquote>\n\n![CRITICAL](https://sonarsource.github.io/sonar-github/severity-critical.png 'Severity: CRITICAL') Define a constant instead of duplicating this literal \"Item '\" 6 times. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS1192)\n![CRITICAL](https://sonarsource.github.io/sonar-github/severity-critical.png 'Severity: CRITICAL') Define a constant instead of duplicating this literal \"' not in the hierarchy\" 5 times. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS1192)\n\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/main/java/com/vaadin/flow/data/provider/hierarchy/TreeData.java, line 305 at r1](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/241#-LFv9xyqhSLkboLOzP4E-r1-305:-LFzrWTC1Ke_Nb7kMZKm:b-896fix) ([raw file](https://github.com/vaadin/vaadin-grid-flow/blob/8b67e07f1f382c2d02c24d0f1bb7e4974635f033/src/main/java/com/vaadin/flow/data/provider/hierarchy/TreeData.java#L305)):*\n<details><summary><i>Previously, vaadin-bot (Vaadin Bot) wrote…</i></summary><blockquote>\n\n![MINOR](https://sonarsource.github.io/sonar-github/severity-minor.png 'Severity: MINOR') Replace this lambda with a method reference. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS1612)\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/main/java/com/vaadin/flow/data/provider/hierarchy/TreeDataProvider.java, line 153 at r1](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/241#-LFv9xyqhSLkboLOzP4F-r1-153:-LFzrX14BRSR54WKPkEw:b-896fix) ([raw file](https://github.com/vaadin/vaadin-grid-flow/blob/8b67e07f1f382c2d02c24d0f1bb7e4974635f033/src/main/java/com/vaadin/flow/data/provider/hierarchy/TreeDataProvider.java#L153)):*\n<details><summary><i>Previously, vaadin-bot (Vaadin Bot) wrote…</i></summary><blockquote>\n\n![MAJOR](https://sonarsource.github.io/sonar-github/severity-major.png 'Severity: MAJOR') Reduce this anonymous class number of lines from 28 to at most 20, or make it a named class. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS1188)\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/test/java/com/vaadin/flow/component/grid/it/ButtonInGridIT.java, line 42 at r1](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/241#-LFv9xyqhSLkboLOzP3z-r1-42:-LFzrXgJA6e5P_xU3JK-:b-896fix) ([raw file](https://github.com/vaadin/vaadin-grid-flow/blob/8b67e07f1f382c2d02c24d0f1bb7e4974635f033/src/test/java/com/vaadin/flow/component/grid/it/ButtonInGridIT.java#L42)):*\n<details><summary><i>Previously, vaadin-bot (Vaadin Bot) wrote…</i></summary><blockquote>\n\n![MAJOR](https://sonarsource.github.io/sonar-github/severity-major.png 'Severity: MAJOR') Fix or remove this skipped unit test [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS1607)\n</blockquote></details>\n\nDone.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/241)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"denis-anisimov"}}