{"push_id":2736872216,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"a14d5ac88e60cc511014f876943095a1ffceb1e2","before":"1155437e5523a60dae60d2dbefdd286cbbef17eb","commits":[{"sha":"57d68a555d7d0af32558e5ec0331319939ac9257","author":{"name":"Doug Patti","email":"02f96c470f8a8074c3f6a1f3ebae7632840915eb@gmail.com"},"message":"fix advancing request queue\n\nDue to a complicated chain of if/then/else expressions, the\n`advance_request_queue_if_necessary` function was structured in such a\nway that the branch to handle requests ending a persistent connection\nwas actually being applied to non-complete requests.\n\nThis fix exposed a bug in the tests where the `connection: close` header\nwould cause the request to be closed immediately. This was because\n`Reqd.is_complete` is true as long as there is nothing to be read or\nwritten -- that is, the request body is complete and the entire response\nbody has made it to `t.writer` but _not necessarily flushed_. Combine\nthis with the fact that the proceeding `shutdown` would close the\nwriter, causing it to be drained of pending writes, and you have\nconnections that close immediately.\n\nWe fix this by changing the behavior of shutdown. Now it only closes the\nwriter and does not drain it, which allows the external world to flush\nit as normal. This is a nice fit, since as it is now, closing the reader\nstill allows the server to finish reading the request it is currently\nworking on.","distinct":true,"url":"https://api.github.com/repos/inhabitedtype/httpaf/commits/57d68a555d7d0af32558e5ec0331319939ac9257"},{"sha":"a14d5ac88e60cc511014f876943095a1ffceb1e2","author":{"name":"Spiros Eliopoulos","email":"4191bf1ecd32591bb7f5842e503996855e5f7b2d@gmail.com"},"message":"Merge pull request #62 from dpatti/fix-advance-request-queue\n\nfix advancing request queue","distinct":true,"url":"https://api.github.com/repos/inhabitedtype/httpaf/commits/a14d5ac88e60cc511014f876943095a1ffceb1e2"}]}
{"actor":{"display_login":"seliopou"}}