{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-netbeans/issues/715","repository_url":"https://api.github.com/repos/apache/incubator-netbeans","labels_url":"https://api.github.com/repos/apache/incubator-netbeans/issues/715/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-netbeans/issues/715/comments","events_url":"https://api.github.com/repos/apache/incubator-netbeans/issues/715/events","html_url":"https://github.com/apache/incubator-netbeans/pull/715","id":351792257,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5Mjk1NjQ4","number":715,"title":"WIP: Download nbjavac when turning on support for Java","user":{"login":"jtulach","id":1842422,"node_id":"MDQ6VXNlcjE4NDI0MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1842422?v=4","gravatar_id":"","url":"https://api.github.com/users/jtulach","html_url":"https://github.com/jtulach","followers_url":"https://api.github.com/users/jtulach/followers","following_url":"https://api.github.com/users/jtulach/following{/other_user}","gists_url":"https://api.github.com/users/jtulach/gists{/gist_id}","starred_url":"https://api.github.com/users/jtulach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtulach/subscriptions","organizations_url":"https://api.github.com/users/jtulach/orgs","repos_url":"https://api.github.com/users/jtulach/repos","events_url":"https://api.github.com/users/jtulach/events{/privacy}","received_events_url":"https://api.github.com/users/jtulach/received_events","type":"User","site_admin":false},"labels":[{"id":759430899,"node_id":"MDU6TGFiZWw3NTk0MzA4OTk=","url":"https://api.github.com/repos/apache/incubator-netbeans/labels/work-in-progress","name":"work-in-progress","color":"377296","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-18T05:29:11Z","updated_at":"2018-08-18T09:37:34Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/incubator-netbeans/pulls/715","html_url":"https://github.com/apache/incubator-netbeans/pull/715","diff_url":"https://github.com/apache/incubator-netbeans/pull/715.diff","patch_url":"https://github.com/apache/incubator-netbeans/pull/715.patch"},"body":"I am trying to use `ide.ergonomics` module to solve NetBeans Javac problem. E.g. to download a module before the whole **Java** support is enabled. Turns out the downloading capability is already in there. Enough to:\r\n* download fresh catalog: b3731bb\r\n* and add the module to list of \"to be installed ones\": 18a6032 \r\n\r\nProblems:\r\n* downloading happens without user confirmation - we should ask\r\n* we should show the license of the downloaded code\r\n* module isn't installed immediately after download - workarounded as 8956f83\r\n    * future version of the NBM shouldn't require restart\r\n* getting `ClassNotFoundException: Will not load class com.sun.source.tree.Tree arbitrarily from one of [org.netbeans.libs.javacapi] and [org.netbeans.modules.nbjavac.api]` after the module is installed\r\n\r\n@jlahoda, feel free to join and help to shape this essential (Nb)Javac related feature."},"comment":{"url":"https://api.github.com/repos/apache/incubator-netbeans/issues/comments/414045483","html_url":"https://github.com/apache/incubator-netbeans/pull/715#issuecomment-414045483","issue_url":"https://api.github.com/repos/apache/incubator-netbeans/issues/715","id":414045483,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDA0NTQ4Mw==","user":{"login":"jlahoda","id":124144,"node_id":"MDQ6VXNlcjEyNDE0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/124144?v=4","gravatar_id":"","url":"https://api.github.com/users/jlahoda","html_url":"https://github.com/jlahoda","followers_url":"https://api.github.com/users/jlahoda/followers","following_url":"https://api.github.com/users/jlahoda/following{/other_user}","gists_url":"https://api.github.com/users/jlahoda/gists{/gist_id}","starred_url":"https://api.github.com/users/jlahoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlahoda/subscriptions","organizations_url":"https://api.github.com/users/jlahoda/orgs","repos_url":"https://api.github.com/users/jlahoda/repos","events_url":"https://api.github.com/users/jlahoda/events{/privacy}","received_events_url":"https://api.github.com/users/jlahoda/received_events","type":"User","site_admin":false},"created_at":"2018-08-18T09:37:34Z","updated_at":"2018-08-18T09:37:34Z","author_association":"CONTRIBUTOR","body":"@matthiasblaesing, please note that a) the Java features can't (reasonably) work on JDK 8 without nb-javac, as they are using the JDK 9 javac's API; b) it is still believed NetBeans works better with nb-javac, and so installing it is suggested to the user even on JDK 9+. When ergonomics is enabling the Java support, then without any further tweaks, after it is enabled, a dialog (on JDK 8) or a \"status bar tooltip\" would come up suggesting installing nb-javac, which would then require a restart. That feels like a poor user experience. If, while the Java support is being enabled, we can ask the user if he/she wants to install nb-javac, and avoid the restart and further inconvenience, that'd significantly improve the user experience IMO.\r\n\r\nRegarding using ecj, even though I wouldn't prevent anyone from looking into that, I personally think it would be an enormous effort, the benefits would be limited, and it may not be a good strategic choice. In any case, I doubt I myself could contribute to that.\r\n"}}
{"actor":{"display_login":"jlahoda"}}