{"action":"created","issue":{"url":"https://api.github.com/repos/cosullivan/SmtpServer/issues/83","repository_url":"https://api.github.com/repos/cosullivan/SmtpServer","labels_url":"https://api.github.com/repos/cosullivan/SmtpServer/issues/83/labels{/name}","comments_url":"https://api.github.com/repos/cosullivan/SmtpServer/issues/83/comments","events_url":"https://api.github.com/repos/cosullivan/SmtpServer/issues/83/events","html_url":"https://github.com/cosullivan/SmtpServer/pull/83","id":340923813,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMjE3ODQ5","number":83,"title":" Introduce EndPointStarted and EndPointStopped events on SmtpServer.","user":{"login":"MPRavn","id":27730905,"node_id":"MDQ6VXNlcjI3NzMwOTA1","avatar_url":"https://avatars3.githubusercontent.com/u/27730905?v=4","gravatar_id":"","url":"https://api.github.com/users/MPRavn","html_url":"https://github.com/MPRavn","followers_url":"https://api.github.com/users/MPRavn/followers","following_url":"https://api.github.com/users/MPRavn/following{/other_user}","gists_url":"https://api.github.com/users/MPRavn/gists{/gist_id}","starred_url":"https://api.github.com/users/MPRavn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MPRavn/subscriptions","organizations_url":"https://api.github.com/users/MPRavn/orgs","repos_url":"https://api.github.com/users/MPRavn/repos","events_url":"https://api.github.com/users/MPRavn/events{/privacy}","received_events_url":"https://api.github.com/users/MPRavn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-13T08:12:47Z","updated_at":"2018-07-16T12:02:27Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/cosullivan/SmtpServer/pulls/83","html_url":"https://github.com/cosullivan/SmtpServer/pull/83","diff_url":"https://github.com/cosullivan/SmtpServer/pull/83.diff","patch_url":"https://github.com/cosullivan/SmtpServer/pull/83.patch"},"body":"I'd like to use your SmtpServer, but it is hard to write integration tests using the code, since it is not possible to observe what port gets assigned if you configure it to port 0. To this end I introduced EndPointStarted and EndPointStopped events that make this bound port observable. Hope this makes sense.\r\n\r\nPS. Also added xunit.runner.visualstudio to make it easier to run the tests."},"comment":{"url":"https://api.github.com/repos/cosullivan/SmtpServer/issues/comments/405224909","html_url":"https://github.com/cosullivan/SmtpServer/pull/83#issuecomment-405224909","issue_url":"https://api.github.com/repos/cosullivan/SmtpServer/issues/83","id":405224909,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTIyNDkwOQ==","user":{"login":"cosullivan","id":2428335,"node_id":"MDQ6VXNlcjI0MjgzMzU=","avatar_url":"https://avatars0.githubusercontent.com/u/2428335?v=4","gravatar_id":"","url":"https://api.github.com/users/cosullivan","html_url":"https://github.com/cosullivan","followers_url":"https://api.github.com/users/cosullivan/followers","following_url":"https://api.github.com/users/cosullivan/following{/other_user}","gists_url":"https://api.github.com/users/cosullivan/gists{/gist_id}","starred_url":"https://api.github.com/users/cosullivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosullivan/subscriptions","organizations_url":"https://api.github.com/users/cosullivan/orgs","repos_url":"https://api.github.com/users/cosullivan/repos","events_url":"https://api.github.com/users/cosullivan/events{/privacy}","received_events_url":"https://api.github.com/users/cosullivan/received_events","type":"User","site_admin":false},"created_at":"2018-07-16T12:02:27Z","updated_at":"2018-07-16T12:02:27Z","author_association":"OWNER","body":"Hi, thanks for you PR.\r\n\r\nBefore I review this I would like to know what the issue is you are trying to solve? If you are running integrations tests why can't you specify the port? What are you then doing on the internal port?\r\n\r\nThanks,\r\nCain.\r\n\r\n"}}
{"actor":{"display_login":"cosullivan"}}