{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/aks-engine/pulls/comments/245172526","pull_request_review_id":189231219,"id":245172526,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTE3MjUyNg==","diff_hunk":"@@ -568,7 +569,7 @@ var _ = Describe(\"Azure Container Cluster using the Kubernetes Orchestrator\", fu\n \t\t\t\tcurlDeploymentName := fmt.Sprintf(\"ilb-test-deployment-%s\", cfg.Name)\n \t\t\t\tcurlDeploy, err := deployment.CreateLinuxDeployIfNotExist(\"library/nginx:latest\", curlDeploymentName, \"default\", \"\")\n \t\t\t\tExpect(err).NotTo(HaveOccurred())\n-\t\t\t\trunning, err := pod.WaitOnReady(curlDeploymentName, \"default\", 3, 30*time.Second, cfg.Timeout)\n+\t\t\t\trunning, err := pod.WaitOnReady(curlDeploymentName, \"default\", 3, 1*time.Second, cfg.Timeout)","path":"test/e2e/kubernetes/kubernetes_test.go","position":89,"original_position":89,"commit_id":"a1631e6facd5c6921309ae151307b1378d350b54","original_commit_id":"a1631e6facd5c6921309ae151307b1378d350b54","user":{"login":"jackfrancis","id":1494193,"node_id":"MDQ6VXNlcjE0OTQxOTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1494193?v=4","gravatar_id":"","url":"https://api.github.com/users/jackfrancis","html_url":"https://github.com/jackfrancis","followers_url":"https://api.github.com/users/jackfrancis/followers","following_url":"https://api.github.com/users/jackfrancis/following{/other_user}","gists_url":"https://api.github.com/users/jackfrancis/gists{/gist_id}","starred_url":"https://api.github.com/users/jackfrancis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackfrancis/subscriptions","organizations_url":"https://api.github.com/users/jackfrancis/orgs","repos_url":"https://api.github.com/users/jackfrancis/repos","events_url":"https://api.github.com/users/jackfrancis/events{/privacy}","received_events_url":"https://api.github.com/users/jackfrancis/received_events","type":"User","site_admin":false},"body":"Should've mentioned this in the description. There's no reason to wait so long in between \"check again for ready\" tests. So, basically, while I was auditiong the \"wait on ready\" checks in the E2E code, I came across this and rationalized it.\r\n\r\nBasically, decreasing the retry interval should speed up test runs. (The timeout until failure is untouched, so the only practical change is more kubectl commands against the apiserver).","created_at":"2019-01-04T00:08:56Z","updated_at":"2019-01-04T00:08:56Z","html_url":"https://github.com/Azure/aks-engine/pull/220#discussion_r245172526","pull_request_url":"https://api.github.com/repos/Azure/aks-engine/pulls/220","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/aks-engine/pulls/comments/245172526"},"html":{"href":"https://github.com/Azure/aks-engine/pull/220#discussion_r245172526"},"pull_request":{"href":"https://api.github.com/repos/Azure/aks-engine/pulls/220"}},"in_reply_to_id":245168753},"pull_request":{"url":"https://api.github.com/repos/Azure/aks-engine/pulls/220","id":242063290,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMDYzMjkw","html_url":"https://github.com/Azure/aks-engine/pull/220","diff_url":"https://github.com/Azure/aks-engine/pull/220.diff","patch_url":"https://github.com/Azure/aks-engine/pull/220.patch","issue_url":"https://api.github.com/repos/Azure/aks-engine/issues/220","number":220,"state":"open","locked":false,"title":"test: more tolerance for kube-system pod startup in E2E","user":{"login":"jackfrancis","id":1494193,"node_id":"MDQ6VXNlcjE0OTQxOTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1494193?v=4","gravatar_id":"","url":"https://api.github.com/users/jackfrancis","html_url":"https://github.com/jackfrancis","followers_url":"https://api.github.com/users/jackfrancis/followers","following_url":"https://api.github.com/users/jackfrancis/following{/other_user}","gists_url":"https://api.github.com/users/jackfrancis/gists{/gist_id}","starred_url":"https://api.github.com/users/jackfrancis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackfrancis/subscriptions","organizations_url":"https://api.github.com/users/jackfrancis/orgs","repos_url":"https://api.github.com/users/jackfrancis/repos","events_url":"https://api.github.com/users/jackfrancis/events{/privacy}","received_events_url":"https://api.github.com/users/jackfrancis/received_events","type":"User","site_admin":false},"body":"<!-- Thank you for helping aks-engine with a pull request!\r\nUse conventional commit messages, such as\r\n  feat: add a knob to the frobnitz\r\nor\r\n  fix: repair hole in wumpus\r\nAnd read this for faster PR reviews: https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#best-practices-for-faster-reviews -->\r\n\r\nIncreases the tolerance for pod startup thrashing (i.e., ratio of Ready/NotReady count) during cluster startup in kube-system namespace. Also standardizes wait retry to 1 second for quicker reconciliation.\r\n\r\n**Reason for Change**:\r\n<!-- What does this PR improve or fix in aks-engine? -->\r\n\r\nThis intends to eliminate some E2E flakiness around kube-system pod readiness checks. E.g.:\r\n\r\n```\r\n\"Pods from deployment (kube-addon-manager) in namespace (kube-system) have been checked out as all Ready 2 times, but NotReady 3 times. This behavior may mean it is in a crashloop\"\r\n```\r\n\r\nBy increasing the Ready count requirement to 6, we also tolerate more NotReady counts. See this code snippet for how this is currently implemented:\r\n\r\nhttps://github.com/Azure/aks-engine/blob/bc250139f3f08ce7e63e42691c68282535bae216/test/e2e/kubernetes/pod/pod.go#L457\r\n\r\n**Issue Fixed**:\r\n<!-- If this PR fixes GitHub issue 1234, add \"Fixes #1234\" to the next line. -->\r\n\r\n\r\n**Requirements**:\r\n<!-- Put an \"X\" character inside the brackets of each completed task. Some may be optional depending on the PR. -->\r\n- [x] uses [conventional commit messages](https://www.conventionalcommits.org/)\r\n- [ ] includes documentation\r\n- [ ] adds unit tests\r\n- [ ] tested upgrade from previous version\r\n\r\n**Notes**:\r\n","created_at":"2019-01-03T17:39:29Z","updated_at":"2019-01-04T00:08:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc0a5ec26925e95953c27ca43a8f7b10171acbe9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1128153706,"node_id":"MDU6TGFiZWwxMTI4MTUzNzA2","url":"https://api.github.com/repos/Azure/aks-engine/labels/approved","name":"approved","color":"5df7c4","default":false},{"id":1128168795,"node_id":"MDU6TGFiZWwxMTI4MTY4Nzk1","url":"https://api.github.com/repos/Azure/aks-engine/labels/size/M","name":"size/M","color":"ddc433","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/aks-engine/pulls/220/commits","review_comments_url":"https://api.github.com/repos/Azure/aks-engine/pulls/220/comments","review_comment_url":"https://api.github.com/repos/Azure/aks-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/aks-engine/issues/220/comments","statuses_url":"https://api.github.com/repos/Azure/aks-engine/statuses/a1631e6facd5c6921309ae151307b1378d350b54","head":{"label":"jackfrancis:pod-wait-on-ready","ref":"pod-wait-on-ready","sha":"a1631e6facd5c6921309ae151307b1378d350b54","user":{"login":"jackfrancis","id":1494193,"node_id":"MDQ6VXNlcjE0OTQxOTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1494193?v=4","gravatar_id":"","url":"https://api.github.com/users/jackfrancis","html_url":"https://github.com/jackfrancis","followers_url":"https://api.github.com/users/jackfrancis/followers","following_url":"https://api.github.com/users/jackfrancis/following{/other_user}","gists_url":"https://api.github.com/users/jackfrancis/gists{/gist_id}","starred_url":"https://api.github.com/users/jackfrancis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackfrancis/subscriptions","organizations_url":"https://api.github.com/users/jackfrancis/orgs","repos_url":"https://api.github.com/users/jackfrancis/repos","events_url":"https://api.github.com/users/jackfrancis/events{/privacy}","received_events_url":"https://api.github.com/users/jackfrancis/received_events","type":"User","site_admin":false},"repo":{"id":157768090,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc3NjgwOTA=","name":"aks-engine","full_name":"jackfrancis/aks-engine","private":false,"owner":{"login":"jackfrancis","id":1494193,"node_id":"MDQ6VXNlcjE0OTQxOTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1494193?v=4","gravatar_id":"","url":"https://api.github.com/users/jackfrancis","html_url":"https://github.com/jackfrancis","followers_url":"https://api.github.com/users/jackfrancis/followers","following_url":"https://api.github.com/users/jackfrancis/following{/other_user}","gists_url":"https://api.github.com/users/jackfrancis/gists{/gist_id}","starred_url":"https://api.github.com/users/jackfrancis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackfrancis/subscriptions","organizations_url":"https://api.github.com/users/jackfrancis/orgs","repos_url":"https://api.github.com/users/jackfrancis/repos","events_url":"https://api.github.com/users/jackfrancis/events{/privacy}","received_events_url":"https://api.github.com/users/jackfrancis/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jackfrancis/aks-engine","description":"Azure Kubernetes Service Engine","fork":true,"url":"https://api.github.com/repos/jackfrancis/aks-engine","forks_url":"https://api.github.com/repos/jackfrancis/aks-engine/forks","keys_url":"https://api.github.com/repos/jackfrancis/aks-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jackfrancis/aks-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jackfrancis/aks-engine/teams","hooks_url":"https://api.github.com/repos/jackfrancis/aks-engine/hooks","issue_events_url":"https://api.github.com/repos/jackfrancis/aks-engine/issues/events{/number}","events_url":"https://api.github.com/repos/jackfrancis/aks-engine/events","assignees_url":"https://api.github.com/repos/jackfrancis/aks-engine/assignees{/user}","branches_url":"https://api.github.com/repos/jackfrancis/aks-engine/branches{/branch}","tags_url":"https://api.github.com/repos/jackfrancis/aks-engine/tags","blobs_url":"https://api.github.com/repos/jackfrancis/aks-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jackfrancis/aks-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jackfrancis/aks-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/jackfrancis/aks-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jackfrancis/aks-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/jackfrancis/aks-engine/languages","stargazers_url":"https://api.github.com/repos/jackfrancis/aks-engine/stargazers","contributors_url":"https://api.github.com/repos/jackfrancis/aks-engine/contributors","subscribers_url":"https://api.github.com/repos/jackfrancis/aks-engine/subscribers","subscription_url":"https://api.github.com/repos/jackfrancis/aks-engine/subscription","commits_url":"https://api.github.com/repos/jackfrancis/aks-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/jackfrancis/aks-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/jackfrancis/aks-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/jackfrancis/aks-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/jackfrancis/aks-engine/contents/{+path}","compare_url":"https://api.github.com/repos/jackfrancis/aks-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jackfrancis/aks-engine/merges","archive_url":"https://api.github.com/repos/jackfrancis/aks-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jackfrancis/aks-engine/downloads","issues_url":"https://api.github.com/repos/jackfrancis/aks-engine/issues{/number}","pulls_url":"https://api.github.com/repos/jackfrancis/aks-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/jackfrancis/aks-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/jackfrancis/aks-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jackfrancis/aks-engine/labels{/name}","releases_url":"https://api.github.com/repos/jackfrancis/aks-engine/releases{/id}","deployments_url":"https://api.github.com/repos/jackfrancis/aks-engine/deployments","created_at":"2018-11-15T20:24:05Z","updated_at":"2018-12-04T23:01:11Z","pushed_at":"2019-01-03T23:40:42Z","git_url":"git://github.com/jackfrancis/aks-engine.git","ssh_url":"git@github.com:jackfrancis/aks-engine.git","clone_url":"https://github.com/jackfrancis/aks-engine.git","svn_url":"https://github.com/jackfrancis/aks-engine","homepage":"https://azure.microsoft.com/","size":60678,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"fe4333c150e799cd67615b1250debede67a19fbe","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":155447233,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU0NDcyMzM=","name":"aks-engine","full_name":"Azure/aks-engine","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/aks-engine","description":"AKS-Engine: Units of Kubernetes on Azure!","fork":false,"url":"https://api.github.com/repos/Azure/aks-engine","forks_url":"https://api.github.com/repos/Azure/aks-engine/forks","keys_url":"https://api.github.com/repos/Azure/aks-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/aks-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/aks-engine/teams","hooks_url":"https://api.github.com/repos/Azure/aks-engine/hooks","issue_events_url":"https://api.github.com/repos/Azure/aks-engine/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/aks-engine/events","assignees_url":"https://api.github.com/repos/Azure/aks-engine/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/aks-engine/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/aks-engine/tags","blobs_url":"https://api.github.com/repos/Azure/aks-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/aks-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/aks-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/aks-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/aks-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/aks-engine/languages","stargazers_url":"https://api.github.com/repos/Azure/aks-engine/stargazers","contributors_url":"https://api.github.com/repos/Azure/aks-engine/contributors","subscribers_url":"https://api.github.com/repos/Azure/aks-engine/subscribers","subscription_url":"https://api.github.com/repos/Azure/aks-engine/subscription","commits_url":"https://api.github.com/repos/Azure/aks-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/aks-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/aks-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/aks-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/aks-engine/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/aks-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/aks-engine/merges","archive_url":"https://api.github.com/repos/Azure/aks-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/aks-engine/downloads","issues_url":"https://api.github.com/repos/Azure/aks-engine/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/aks-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/aks-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/aks-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/aks-engine/labels{/name}","releases_url":"https://api.github.com/repos/Azure/aks-engine/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/aks-engine/deployments","created_at":"2018-10-30T19:50:54Z","updated_at":"2019-01-03T22:06:11Z","pushed_at":"2019-01-04T00:08:26Z","git_url":"git://github.com/Azure/aks-engine.git","ssh_url":"git@github.com:Azure/aks-engine.git","clone_url":"https://github.com/Azure/aks-engine.git","svn_url":"https://github.com/Azure/aks-engine","homepage":"https://github.com/Azure/aks-engine","size":60669,"stargazers_count":86,"watchers_count":86,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":73,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":37,"open_issues":73,"watchers":86,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/aks-engine/pulls/220"},"html":{"href":"https://github.com/Azure/aks-engine/pull/220"},"issue":{"href":"https://api.github.com/repos/Azure/aks-engine/issues/220"},"comments":{"href":"https://api.github.com/repos/Azure/aks-engine/issues/220/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/aks-engine/pulls/220/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/aks-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/aks-engine/pulls/220/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/aks-engine/statuses/a1631e6facd5c6921309ae151307b1378d350b54"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jackfrancis"}}