{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/58370","repository_url":"https://api.github.com/repos/Microsoft/vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/58370/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/58370/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/58370/events","html_url":"https://github.com/Microsoft/vscode/issues/58370","id":358714594,"node_id":"MDU6SXNzdWUzNTg3MTQ1OTQ=","number":58370,"title":"Can't search if there is a workspace folder for a scheme that has no search provider","user":{"login":"eamodio","id":641685,"node_id":"MDQ6VXNlcjY0MTY4NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/641685?v=4","gravatar_id":"","url":"https://api.github.com/users/eamodio","html_url":"https://github.com/eamodio","followers_url":"https://api.github.com/users/eamodio/followers","following_url":"https://api.github.com/users/eamodio/following{/other_user}","gists_url":"https://api.github.com/users/eamodio/gists{/gist_id}","starred_url":"https://api.github.com/users/eamodio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eamodio/subscriptions","organizations_url":"https://api.github.com/users/eamodio/orgs","repos_url":"https://api.github.com/users/eamodio/repos","events_url":"https://api.github.com/users/eamodio/events{/privacy}","received_events_url":"https://api.github.com/users/eamodio/received_events","type":"User","site_admin":false},"labels":[{"id":256129993,"node_id":"MDU6TGFiZWwyNTYxMjk5OTM=","url":"https://api.github.com/repos/Microsoft/vscode/labels/bug","name":"bug","color":"8D6673","default":true},{"id":1037423629,"node_id":"MDU6TGFiZWwxMDM3NDIzNjI5","url":"https://api.github.com/repos/Microsoft/vscode/labels/insiders","name":"insiders","color":"006b75","default":false},{"id":301186618,"node_id":"MDU6TGFiZWwzMDExODY2MTg=","url":"https://api.github.com/repos/Microsoft/vscode/labels/search","name":"search","color":"1d76db","default":false}],"state":"open","locked":false,"assignee":{"login":"roblourens","id":323878,"node_id":"MDQ6VXNlcjMyMzg3OA==","avatar_url":"https://avatars3.githubusercontent.com/u/323878?v=4","gravatar_id":"","url":"https://api.github.com/users/roblourens","html_url":"https://github.com/roblourens","followers_url":"https://api.github.com/users/roblourens/followers","following_url":"https://api.github.com/users/roblourens/following{/other_user}","gists_url":"https://api.github.com/users/roblourens/gists{/gist_id}","starred_url":"https://api.github.com/users/roblourens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roblourens/subscriptions","organizations_url":"https://api.github.com/users/roblourens/orgs","repos_url":"https://api.github.com/users/roblourens/repos","events_url":"https://api.github.com/users/roblourens/events{/privacy}","received_events_url":"https://api.github.com/users/roblourens/received_events","type":"User","site_admin":false},"assignees":[{"login":"roblourens","id":323878,"node_id":"MDQ6VXNlcjMyMzg3OA==","avatar_url":"https://avatars3.githubusercontent.com/u/323878?v=4","gravatar_id":"","url":"https://api.github.com/users/roblourens","html_url":"https://github.com/roblourens","followers_url":"https://api.github.com/users/roblourens/followers","following_url":"https://api.github.com/users/roblourens/following{/other_user}","gists_url":"https://api.github.com/users/roblourens/gists{/gist_id}","starred_url":"https://api.github.com/users/roblourens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roblourens/subscriptions","organizations_url":"https://api.github.com/users/roblourens/orgs","repos_url":"https://api.github.com/users/roblourens/repos","events_url":"https://api.github.com/users/roblourens/events{/privacy}","received_events_url":"https://api.github.com/users/roblourens/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Microsoft/vscode/milestones/75","html_url":"https://github.com/Microsoft/vscode/milestone/75","labels_url":"https://api.github.com/repos/Microsoft/vscode/milestones/75/labels","id":3510752,"node_id":"MDk6TWlsZXN0b25lMzUxMDc1Mg==","number":75,"title":"September 2018","description":"","creator":{"login":"dbaeumer","id":1931590,"node_id":"MDQ6VXNlcjE5MzE1OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1931590?v=4","gravatar_id":"","url":"https://api.github.com/users/dbaeumer","html_url":"https://github.com/dbaeumer","followers_url":"https://api.github.com/users/dbaeumer/followers","following_url":"https://api.github.com/users/dbaeumer/following{/other_user}","gists_url":"https://api.github.com/users/dbaeumer/gists{/gist_id}","starred_url":"https://api.github.com/users/dbaeumer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbaeumer/subscriptions","organizations_url":"https://api.github.com/users/dbaeumer/orgs","repos_url":"https://api.github.com/users/dbaeumer/repos","events_url":"https://api.github.com/users/dbaeumer/events{/privacy}","received_events_url":"https://api.github.com/users/dbaeumer/received_events","type":"User","site_admin":false},"open_issues":177,"closed_issues":353,"state":"open","created_at":"2018-07-20T07:00:42Z","updated_at":"2018-09-14T13:35:56Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2018-09-10T17:12:26Z","updated_at":"2018-09-14T13:53:15Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Issue Type: <b>Bug</b>\r\n\r\nIf you have a workspace opened where one of the folders is a non-`file://` scheme (a `FileSystemProvider`) you can't search across the files in the workspace folders that can be searched.\r\n\r\n![image](https://user-images.githubusercontent.com/641685/45312698-c71a1880-b4fa-11e8-9f0f-e6ebf235f379.png)\r\n\r\nI would have expected the search to only return results for the workspace folders that supported searching with optionally a notice that not all workspaces were searched\r\n\r\n/cc @roblourens \r\n\r\nVS Code version: Code - Insiders 1.28.0-insider (96854113091424c07b28ba84b82b75a88b8455cb, 2018-09-10T05:18:57.119Z)\r\nOS version: Windows_NT x64 10.0.17755\r\n\r\n<details>\r\n<summary>System Info</summary>\r\n\r\n|Item|Value|\r\n|---|---|\r\n|CPUs|Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 x 4008)|\r\n|GPU Status|2d_canvas: enabled<br>checker_imaging: disabled_off<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>native_gpu_memory_buffers: disabled_software<br>rasterization: enabled<br>video_decode: enabled<br>video_encode: enabled<br>webgl: enabled<br>webgl2: enabled|\r\n|Memory (System)|31.93GB (15.32GB free)|\r\n|Process Argv|C:\\Users\\Eric\\AppData\\Local\\Programs\\Microsoft VS Code Insiders\\Code - Insiders.exe|\r\n|Screen Reader|no|\r\n|VM|0%|\r\n\r\n</details>\r\n<!-- generated by issue reporter -->"},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/comments/421365569","html_url":"https://github.com/Microsoft/vscode/issues/58370#issuecomment-421365569","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/58370","id":421365569,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTM2NTU2OQ==","user":{"login":"eamodio","id":641685,"node_id":"MDQ6VXNlcjY0MTY4NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/641685?v=4","gravatar_id":"","url":"https://api.github.com/users/eamodio","html_url":"https://github.com/eamodio","followers_url":"https://api.github.com/users/eamodio/followers","following_url":"https://api.github.com/users/eamodio/following{/other_user}","gists_url":"https://api.github.com/users/eamodio/gists{/gist_id}","starred_url":"https://api.github.com/users/eamodio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eamodio/subscriptions","organizations_url":"https://api.github.com/users/eamodio/orgs","repos_url":"https://api.github.com/users/eamodio/repos","events_url":"https://api.github.com/users/eamodio/events{/privacy}","received_events_url":"https://api.github.com/users/eamodio/received_events","type":"User","site_admin":false},"created_at":"2018-09-14T13:53:15Z","updated_at":"2018-09-14T13:53:15Z","author_association":"CONTRIBUTOR","body":"imo having a warning (not error) notice when searching across all files might be nice (but maybe dismissable per workspace?). Because once you know it's just going to be annoying. As for the other places I would just leave it silent (other than in the documentation for the apis).\r\n\r\nTo me search becomes something folders can participate in just like other (code intelligence) apis. It's not a guaranteed feature. "}}
{"actor":{"display_login":"eamodio"}}