{"action":"created","comment":{"url":"https://api.github.com/repos/yggdrash/yggdrash/pulls/comments/236928315","pull_request_review_id":179107902,"id":236928315,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjkyODMxNQ==","diff_hunk":"@@ -177,34 +177,29 @@ public void setUp() {\n \n     @Test\n     public void createAssetBranchTest() {","path":"yggdrash-core/src/test/java/io/yggdrash/core/contract/AssetContractTest.java","position":12,"original_position":3,"commit_id":"a57d99b0980c7453149bac0a706b6c7667546f86","original_commit_id":"a57d99b0980c7453149bac0a706b6c7667546f86","user":{"login":"dezang","id":1762310,"node_id":"MDQ6VXNlcjE3NjIzMTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1762310?v=4","gravatar_id":"","url":"https://api.github.com/users/dezang","html_url":"https://github.com/dezang","followers_url":"https://api.github.com/users/dezang/followers","following_url":"https://api.github.com/users/dezang/following{/other_user}","gists_url":"https://api.github.com/users/dezang/gists{/gist_id}","starred_url":"https://api.github.com/users/dezang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dezang/subscriptions","organizations_url":"https://api.github.com/users/dezang/orgs","repos_url":"https://api.github.com/users/dezang/repos","events_url":"https://api.github.com/users/dezang/events{/privacy}","received_events_url":"https://api.github.com/users/dezang/received_events","type":"User","site_admin":false},"body":"막상 수정하려고 하니 무엇을 검증하고자 만들어진 테스트인지가 명확하지 않네요. ^^;;\r\n그래도 한번 만들어 넣어보겠습니다.","created_at":"2018-11-28T03:11:57Z","updated_at":"2018-11-28T03:11:57Z","html_url":"https://github.com/yggdrash/yggdrash/pull/8#discussion_r236928315","pull_request_url":"https://api.github.com/repos/yggdrash/yggdrash/pulls/8","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/yggdrash/yggdrash/pulls/comments/236928315"},"html":{"href":"https://github.com/yggdrash/yggdrash/pull/8#discussion_r236928315"},"pull_request":{"href":"https://api.github.com/repos/yggdrash/yggdrash/pulls/8"}},"in_reply_to_id":236515084},"pull_request":{"url":"https://api.github.com/repos/yggdrash/yggdrash/pulls/8","id":233447619,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNDQ3NjE5","html_url":"https://github.com/yggdrash/yggdrash/pull/8","diff_url":"https://github.com/yggdrash/yggdrash/pull/8.diff","patch_url":"https://github.com/yggdrash/yggdrash/pull/8.patch","issue_url":"https://api.github.com/repos/yggdrash/yggdrash/issues/8","number":8,"state":"open","locked":false,"title":"Refactor/package","user":{"login":"brianr2v","id":40161282,"node_id":"MDQ6VXNlcjQwMTYxMjgy","avatar_url":"https://avatars1.githubusercontent.com/u/40161282?v=4","gravatar_id":"","url":"https://api.github.com/users/brianr2v","html_url":"https://github.com/brianr2v","followers_url":"https://api.github.com/users/brianr2v/followers","following_url":"https://api.github.com/users/brianr2v/following{/other_user}","gists_url":"https://api.github.com/users/brianr2v/gists{/gist_id}","starred_url":"https://api.github.com/users/brianr2v/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianr2v/subscriptions","organizations_url":"https://api.github.com/users/brianr2v/orgs","repos_url":"https://api.github.com/users/brianr2v/repos","events_url":"https://api.github.com/users/brianr2v/events{/privacy}","received_events_url":"https://api.github.com/users/brianr2v/received_events","type":"User","site_admin":false},"body":"- 패키지 리팩토링으로 asset contact id가 변경되어 수정\r\n- AssetContactTest 에서 가독성 및 디버깅 향상을 위해 assert false 제거\r\n  - 테스트코드는 코딩이 아니고(try-catch, if로 검증) 기대값과 실제값을 assertion 하는 스펙문서라는 개념으로 작성되면 좋겠습니다.","created_at":"2018-11-26T06:07:51Z","updated_at":"2018-11-28T03:11:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"315c9093be5bc2374e1c0e2ad0395e878a79c5ad","assignee":null,"assignees":[],"requested_reviewers":[{"login":"popldo","id":71657,"node_id":"MDQ6VXNlcjcxNjU3","avatar_url":"https://avatars0.githubusercontent.com/u/71657?v=4","gravatar_id":"","url":"https://api.github.com/users/popldo","html_url":"https://github.com/popldo","followers_url":"https://api.github.com/users/popldo/followers","following_url":"https://api.github.com/users/popldo/following{/other_user}","gists_url":"https://api.github.com/users/popldo/gists{/gist_id}","starred_url":"https://api.github.com/users/popldo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/popldo/subscriptions","organizations_url":"https://api.github.com/users/popldo/orgs","repos_url":"https://api.github.com/users/popldo/repos","events_url":"https://api.github.com/users/popldo/events{/privacy}","received_events_url":"https://api.github.com/users/popldo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yggdrash/yggdrash/pulls/8/commits","review_comments_url":"https://api.github.com/repos/yggdrash/yggdrash/pulls/8/comments","review_comment_url":"https://api.github.com/repos/yggdrash/yggdrash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yggdrash/yggdrash/issues/8/comments","statuses_url":"https://api.github.com/repos/yggdrash/yggdrash/statuses/a57d99b0980c7453149bac0a706b6c7667546f86","head":{"label":"yggdrash:refactor/package","ref":"refactor/package","sha":"a57d99b0980c7453149bac0a706b6c7667546f86","user":{"login":"yggdrash","id":35519231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTE5MjMx","avatar_url":"https://avatars1.githubusercontent.com/u/35519231?v=4","gravatar_id":"","url":"https://api.github.com/users/yggdrash","html_url":"https://github.com/yggdrash","followers_url":"https://api.github.com/users/yggdrash/followers","following_url":"https://api.github.com/users/yggdrash/following{/other_user}","gists_url":"https://api.github.com/users/yggdrash/gists{/gist_id}","starred_url":"https://api.github.com/users/yggdrash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yggdrash/subscriptions","organizations_url":"https://api.github.com/users/yggdrash/orgs","repos_url":"https://api.github.com/users/yggdrash/repos","events_url":"https://api.github.com/users/yggdrash/events{/privacy}","received_events_url":"https://api.github.com/users/yggdrash/received_events","type":"Organization","site_admin":false},"repo":{"id":122426223,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI0MjYyMjM=","name":"yggdrash","full_name":"yggdrash/yggdrash","private":false,"owner":{"login":"yggdrash","id":35519231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTE5MjMx","avatar_url":"https://avatars1.githubusercontent.com/u/35519231?v=4","gravatar_id":"","url":"https://api.github.com/users/yggdrash","html_url":"https://github.com/yggdrash","followers_url":"https://api.github.com/users/yggdrash/followers","following_url":"https://api.github.com/users/yggdrash/following{/other_user}","gists_url":"https://api.github.com/users/yggdrash/gists{/gist_id}","starred_url":"https://api.github.com/users/yggdrash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yggdrash/subscriptions","organizations_url":"https://api.github.com/users/yggdrash/orgs","repos_url":"https://api.github.com/users/yggdrash/repos","events_url":"https://api.github.com/users/yggdrash/events{/privacy}","received_events_url":"https://api.github.com/users/yggdrash/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/yggdrash/yggdrash","description":"Trust-based Multi-dimensional Blockchains","fork":false,"url":"https://api.github.com/repos/yggdrash/yggdrash","forks_url":"https://api.github.com/repos/yggdrash/yggdrash/forks","keys_url":"https://api.github.com/repos/yggdrash/yggdrash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yggdrash/yggdrash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yggdrash/yggdrash/teams","hooks_url":"https://api.github.com/repos/yggdrash/yggdrash/hooks","issue_events_url":"https://api.github.com/repos/yggdrash/yggdrash/issues/events{/number}","events_url":"https://api.github.com/repos/yggdrash/yggdrash/events","assignees_url":"https://api.github.com/repos/yggdrash/yggdrash/assignees{/user}","branches_url":"https://api.github.com/repos/yggdrash/yggdrash/branches{/branch}","tags_url":"https://api.github.com/repos/yggdrash/yggdrash/tags","blobs_url":"https://api.github.com/repos/yggdrash/yggdrash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yggdrash/yggdrash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yggdrash/yggdrash/git/refs{/sha}","trees_url":"https://api.github.com/repos/yggdrash/yggdrash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yggdrash/yggdrash/statuses/{sha}","languages_url":"https://api.github.com/repos/yggdrash/yggdrash/languages","stargazers_url":"https://api.github.com/repos/yggdrash/yggdrash/stargazers","contributors_url":"https://api.github.com/repos/yggdrash/yggdrash/contributors","subscribers_url":"https://api.github.com/repos/yggdrash/yggdrash/subscribers","subscription_url":"https://api.github.com/repos/yggdrash/yggdrash/subscription","commits_url":"https://api.github.com/repos/yggdrash/yggdrash/commits{/sha}","git_commits_url":"https://api.github.com/repos/yggdrash/yggdrash/git/commits{/sha}","comments_url":"https://api.github.com/repos/yggdrash/yggdrash/comments{/number}","issue_comment_url":"https://api.github.com/repos/yggdrash/yggdrash/issues/comments{/number}","contents_url":"https://api.github.com/repos/yggdrash/yggdrash/contents/{+path}","compare_url":"https://api.github.com/repos/yggdrash/yggdrash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yggdrash/yggdrash/merges","archive_url":"https://api.github.com/repos/yggdrash/yggdrash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yggdrash/yggdrash/downloads","issues_url":"https://api.github.com/repos/yggdrash/yggdrash/issues{/number}","pulls_url":"https://api.github.com/repos/yggdrash/yggdrash/pulls{/number}","milestones_url":"https://api.github.com/repos/yggdrash/yggdrash/milestones{/number}","notifications_url":"https://api.github.com/repos/yggdrash/yggdrash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yggdrash/yggdrash/labels{/name}","releases_url":"https://api.github.com/repos/yggdrash/yggdrash/releases{/id}","deployments_url":"https://api.github.com/repos/yggdrash/yggdrash/deployments","created_at":"2018-02-22T03:30:13Z","updated_at":"2018-11-23T03:44:22Z","pushed_at":"2018-11-27T09:17:10Z","git_url":"git://github.com/yggdrash/yggdrash.git","ssh_url":"git@github.com:yggdrash/yggdrash.git","clone_url":"https://github.com/yggdrash/yggdrash.git","svn_url":"https://github.com/yggdrash/yggdrash","homepage":null,"size":3456,"stargazers_count":31,"watchers_count":31,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":9,"open_issues":3,"watchers":31,"default_branch":"develop"}},"base":{"label":"yggdrash:develop","ref":"develop","sha":"38d51338a19e3ad39142f451eedbcd1d1641a364","user":{"login":"yggdrash","id":35519231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTE5MjMx","avatar_url":"https://avatars1.githubusercontent.com/u/35519231?v=4","gravatar_id":"","url":"https://api.github.com/users/yggdrash","html_url":"https://github.com/yggdrash","followers_url":"https://api.github.com/users/yggdrash/followers","following_url":"https://api.github.com/users/yggdrash/following{/other_user}","gists_url":"https://api.github.com/users/yggdrash/gists{/gist_id}","starred_url":"https://api.github.com/users/yggdrash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yggdrash/subscriptions","organizations_url":"https://api.github.com/users/yggdrash/orgs","repos_url":"https://api.github.com/users/yggdrash/repos","events_url":"https://api.github.com/users/yggdrash/events{/privacy}","received_events_url":"https://api.github.com/users/yggdrash/received_events","type":"Organization","site_admin":false},"repo":{"id":122426223,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI0MjYyMjM=","name":"yggdrash","full_name":"yggdrash/yggdrash","private":false,"owner":{"login":"yggdrash","id":35519231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTE5MjMx","avatar_url":"https://avatars1.githubusercontent.com/u/35519231?v=4","gravatar_id":"","url":"https://api.github.com/users/yggdrash","html_url":"https://github.com/yggdrash","followers_url":"https://api.github.com/users/yggdrash/followers","following_url":"https://api.github.com/users/yggdrash/following{/other_user}","gists_url":"https://api.github.com/users/yggdrash/gists{/gist_id}","starred_url":"https://api.github.com/users/yggdrash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yggdrash/subscriptions","organizations_url":"https://api.github.com/users/yggdrash/orgs","repos_url":"https://api.github.com/users/yggdrash/repos","events_url":"https://api.github.com/users/yggdrash/events{/privacy}","received_events_url":"https://api.github.com/users/yggdrash/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/yggdrash/yggdrash","description":"Trust-based Multi-dimensional Blockchains","fork":false,"url":"https://api.github.com/repos/yggdrash/yggdrash","forks_url":"https://api.github.com/repos/yggdrash/yggdrash/forks","keys_url":"https://api.github.com/repos/yggdrash/yggdrash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yggdrash/yggdrash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yggdrash/yggdrash/teams","hooks_url":"https://api.github.com/repos/yggdrash/yggdrash/hooks","issue_events_url":"https://api.github.com/repos/yggdrash/yggdrash/issues/events{/number}","events_url":"https://api.github.com/repos/yggdrash/yggdrash/events","assignees_url":"https://api.github.com/repos/yggdrash/yggdrash/assignees{/user}","branches_url":"https://api.github.com/repos/yggdrash/yggdrash/branches{/branch}","tags_url":"https://api.github.com/repos/yggdrash/yggdrash/tags","blobs_url":"https://api.github.com/repos/yggdrash/yggdrash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yggdrash/yggdrash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yggdrash/yggdrash/git/refs{/sha}","trees_url":"https://api.github.com/repos/yggdrash/yggdrash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yggdrash/yggdrash/statuses/{sha}","languages_url":"https://api.github.com/repos/yggdrash/yggdrash/languages","stargazers_url":"https://api.github.com/repos/yggdrash/yggdrash/stargazers","contributors_url":"https://api.github.com/repos/yggdrash/yggdrash/contributors","subscribers_url":"https://api.github.com/repos/yggdrash/yggdrash/subscribers","subscription_url":"https://api.github.com/repos/yggdrash/yggdrash/subscription","commits_url":"https://api.github.com/repos/yggdrash/yggdrash/commits{/sha}","git_commits_url":"https://api.github.com/repos/yggdrash/yggdrash/git/commits{/sha}","comments_url":"https://api.github.com/repos/yggdrash/yggdrash/comments{/number}","issue_comment_url":"https://api.github.com/repos/yggdrash/yggdrash/issues/comments{/number}","contents_url":"https://api.github.com/repos/yggdrash/yggdrash/contents/{+path}","compare_url":"https://api.github.com/repos/yggdrash/yggdrash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yggdrash/yggdrash/merges","archive_url":"https://api.github.com/repos/yggdrash/yggdrash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yggdrash/yggdrash/downloads","issues_url":"https://api.github.com/repos/yggdrash/yggdrash/issues{/number}","pulls_url":"https://api.github.com/repos/yggdrash/yggdrash/pulls{/number}","milestones_url":"https://api.github.com/repos/yggdrash/yggdrash/milestones{/number}","notifications_url":"https://api.github.com/repos/yggdrash/yggdrash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yggdrash/yggdrash/labels{/name}","releases_url":"https://api.github.com/repos/yggdrash/yggdrash/releases{/id}","deployments_url":"https://api.github.com/repos/yggdrash/yggdrash/deployments","created_at":"2018-02-22T03:30:13Z","updated_at":"2018-11-23T03:44:22Z","pushed_at":"2018-11-27T09:17:10Z","git_url":"git://github.com/yggdrash/yggdrash.git","ssh_url":"git@github.com:yggdrash/yggdrash.git","clone_url":"https://github.com/yggdrash/yggdrash.git","svn_url":"https://github.com/yggdrash/yggdrash","homepage":null,"size":3456,"stargazers_count":31,"watchers_count":31,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":9,"open_issues":3,"watchers":31,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/yggdrash/yggdrash/pulls/8"},"html":{"href":"https://github.com/yggdrash/yggdrash/pull/8"},"issue":{"href":"https://api.github.com/repos/yggdrash/yggdrash/issues/8"},"comments":{"href":"https://api.github.com/repos/yggdrash/yggdrash/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/yggdrash/yggdrash/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/yggdrash/yggdrash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yggdrash/yggdrash/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/yggdrash/yggdrash/statuses/a57d99b0980c7453149bac0a706b6c7667546f86"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dezang"}}