{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/1648","repository_url":"https://api.github.com/repos/JuliaData/DataFrames.jl","labels_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/1648/labels{/name}","comments_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/1648/comments","events_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/1648/events","html_url":"https://github.com/JuliaData/DataFrames.jl/pull/1648","id":393262729,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMzM5OTI0","number":1648,"title":"better parent for view","user":{"login":"bkamins","id":6187170,"node_id":"MDQ6VXNlcjYxODcxNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/6187170?v=4","gravatar_id":"","url":"https://api.github.com/users/bkamins","html_url":"https://github.com/bkamins","followers_url":"https://api.github.com/users/bkamins/followers","following_url":"https://api.github.com/users/bkamins/following{/other_user}","gists_url":"https://api.github.com/users/bkamins/gists{/gist_id}","starred_url":"https://api.github.com/users/bkamins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkamins/subscriptions","organizations_url":"https://api.github.com/users/bkamins/orgs","repos_url":"https://api.github.com/users/bkamins/repos","events_url":"https://api.github.com/users/bkamins/events{/privacy}","received_events_url":"https://api.github.com/users/bkamins/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":22,"created_at":"2018-12-21T00:24:35Z","updated_at":"2018-12-30T10:50:41Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1648","html_url":"https://github.com/JuliaData/DataFrames.jl/pull/1648","diff_url":"https://github.com/JuliaData/DataFrames.jl/pull/1648.diff","patch_url":"https://github.com/JuliaData/DataFrames.jl/pull/1648.patch"},"body":"This follows the discussion in #1647. I have not tested it yet, but have implemented all the the required changes (hopefully) so the design approach can be discussed.\r\n"},"comment":{"url":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/comments/450552580","html_url":"https://github.com/JuliaData/DataFrames.jl/pull/1648#issuecomment-450552580","issue_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/1648","id":450552580,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDU1MjU4MA==","user":{"login":"nalimilan","id":1120448,"node_id":"MDQ6VXNlcjExMjA0NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/1120448?v=4","gravatar_id":"","url":"https://api.github.com/users/nalimilan","html_url":"https://github.com/nalimilan","followers_url":"https://api.github.com/users/nalimilan/followers","following_url":"https://api.github.com/users/nalimilan/following{/other_user}","gists_url":"https://api.github.com/users/nalimilan/gists{/gist_id}","starred_url":"https://api.github.com/users/nalimilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nalimilan/subscriptions","organizations_url":"https://api.github.com/users/nalimilan/orgs","repos_url":"https://api.github.com/users/nalimilan/repos","events_url":"https://api.github.com/users/nalimilan/events{/privacy}","received_events_url":"https://api.github.com/users/nalimilan/received_events","type":"User","site_admin":false},"created_at":"2018-12-30T10:50:41Z","updated_at":"2018-12-30T10:50:41Z","author_association":"CONTRIBUTOR","body":"OK. Is there any drawback to using `view` in `parentindices`? E.g. what happens if the index is modified afterwards? Maybe it should be copied before storing it in a field (as opposed to using it just once for indexing)? It could also make sense to use a view for `AbstractArray{Symbol}`, but technically I don't think that's possible (as generators cannot be used for indexing)."}}
{"actor":{"display_login":"nalimilan"}}