{"action":"created","issue":{"url":"https://api.github.com/repos/omeka/omeka-s/issues/1100","repository_url":"https://api.github.com/repos/omeka/omeka-s","labels_url":"https://api.github.com/repos/omeka/omeka-s/issues/1100/labels{/name}","comments_url":"https://api.github.com/repos/omeka/omeka-s/issues/1100/comments","events_url":"https://api.github.com/repos/omeka/omeka-s/issues/1100/events","html_url":"https://github.com/omeka/omeka-s/pull/1100","id":267567330,"number":1100,"title":"Feature/batch edit factorize and trigger events for modules ","user":{"login":"Daniel-KM","id":2138485,"avatar_url":"https://avatars2.githubusercontent.com/u/2138485?v=4","gravatar_id":"","url":"https://api.github.com/users/Daniel-KM","html_url":"https://github.com/Daniel-KM","followers_url":"https://api.github.com/users/Daniel-KM/followers","following_url":"https://api.github.com/users/Daniel-KM/following{/other_user}","gists_url":"https://api.github.com/users/Daniel-KM/gists{/gist_id}","starred_url":"https://api.github.com/users/Daniel-KM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Daniel-KM/subscriptions","organizations_url":"https://api.github.com/users/Daniel-KM/orgs","repos_url":"https://api.github.com/users/Daniel-KM/repos","events_url":"https://api.github.com/users/Daniel-KM/events{/privacy}","received_events_url":"https://api.github.com/users/Daniel-KM/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-10-23T07:32:08Z","updated_at":"2018-04-03T13:33:52Z","closed_at":"2018-04-03T13:33:52Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/omeka/omeka-s/pulls/1100","html_url":"https://github.com/omeka/omeka-s/pull/1100","diff_url":"https://github.com/omeka/omeka-s/pull/1100.diff","patch_url":"https://github.com/omeka/omeka-s/pull/1100.patch"},"body":"It factorizes batch edit item and batch edit item set, and added triggers `view.batch_edit.before / after` (may be renamed) in the view and `form.add_elements / add_input_filters` in the form. \r\n\r\nThe main purpose is to simplify the maintenance of the batch-edit (but the resource controllers are not factorized), and to allow modules to set values to add/remove too.\r\n\r\nNote that there is an issue for modules : currently, they can't use the event `api.update.pre/post`, that is used by the `AbstractEntityAdapter::batchUpdate()`, because the request is strictly filtered in [application/src/Api/Adapter/AbstractEntityAdapter.php#L375](https://github.com/omeka/omeka-s/blob/develop/application/src/Api/Adapter/AbstractEntityAdapter.php#L375) (default to empty array), so everything in the request is removed except core values of the resources. \r\n\r\nThis filter is not used for other resources, so I was wondering if there is a particular reason for that. If not, the filter should be improved to allow a preprocess, but without removing unidentified keys from the raw data (they belong to modules that use the batch-edit).\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/omeka/omeka-s/issues/comments/378251609","html_url":"https://github.com/omeka/omeka-s/pull/1100#issuecomment-378251609","issue_url":"https://api.github.com/repos/omeka/omeka-s/issues/1100","id":378251609,"user":{"login":"Daniel-KM","id":2138485,"avatar_url":"https://avatars2.githubusercontent.com/u/2138485?v=4","gravatar_id":"","url":"https://api.github.com/users/Daniel-KM","html_url":"https://github.com/Daniel-KM","followers_url":"https://api.github.com/users/Daniel-KM/followers","following_url":"https://api.github.com/users/Daniel-KM/following{/other_user}","gists_url":"https://api.github.com/users/Daniel-KM/gists{/gist_id}","starred_url":"https://api.github.com/users/Daniel-KM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Daniel-KM/subscriptions","organizations_url":"https://api.github.com/users/Daniel-KM/orgs","repos_url":"https://api.github.com/users/Daniel-KM/repos","events_url":"https://api.github.com/users/Daniel-KM/events{/privacy}","received_events_url":"https://api.github.com/users/Daniel-KM/received_events","type":"User","site_admin":false},"created_at":"2018-04-03T13:33:52Z","updated_at":"2018-04-03T13:33:52Z","author_association":"CONTRIBUTOR","body":"Merged via #1101."}}
{"actor":{"display_login":"Daniel-KM"}}