{"action":"created","issue":{"url":"https://api.github.com/repos/contao/contao/issues/65","repository_url":"https://api.github.com/repos/contao/contao","labels_url":"https://api.github.com/repos/contao/contao/issues/65/labels{/name}","comments_url":"https://api.github.com/repos/contao/contao/issues/65/comments","events_url":"https://api.github.com/repos/contao/contao/issues/65/events","html_url":"https://github.com/contao/contao/issues/65","id":361252211,"node_id":"MDU6SXNzdWUzNjEyNTIyMTE=","number":65,"title":"Make requirement of tecnickcom/tcpdf optional","user":{"login":"dmolineus","id":1186266,"node_id":"MDQ6VXNlcjExODYyNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1186266?v=4","gravatar_id":"","url":"https://api.github.com/users/dmolineus","html_url":"https://github.com/dmolineus","followers_url":"https://api.github.com/users/dmolineus/followers","following_url":"https://api.github.com/users/dmolineus/following{/other_user}","gists_url":"https://api.github.com/users/dmolineus/gists{/gist_id}","starred_url":"https://api.github.com/users/dmolineus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmolineus/subscriptions","organizations_url":"https://api.github.com/users/dmolineus/orgs","repos_url":"https://api.github.com/users/dmolineus/repos","events_url":"https://api.github.com/users/dmolineus/events{/privacy}","received_events_url":"https://api.github.com/users/dmolineus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-18T11:08:32Z","updated_at":"2018-09-18T18:03:41Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Afaik the tcpdf library is only used for exporting articles in Contao. However, this is a feature I only use in 1% of my extensions. So the size of this library is really huge (~30 MB). Since Contao 4 uses composer to manage dependenecies it's not a big deal to make it an optional dependency. The pdf export for articles should be only available if it's installed then. \r\n"},"comment":{"url":"https://api.github.com/repos/contao/contao/issues/comments/422491239","html_url":"https://github.com/contao/contao/issues/65#issuecomment-422491239","issue_url":"https://api.github.com/repos/contao/contao/issues/65","id":422491239,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjQ5MTIzOQ==","user":{"login":"ausi","id":367169,"node_id":"MDQ6VXNlcjM2NzE2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/367169?v=4","gravatar_id":"","url":"https://api.github.com/users/ausi","html_url":"https://github.com/ausi","followers_url":"https://api.github.com/users/ausi/followers","following_url":"https://api.github.com/users/ausi/following{/other_user}","gists_url":"https://api.github.com/users/ausi/gists{/gist_id}","starred_url":"https://api.github.com/users/ausi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ausi/subscriptions","organizations_url":"https://api.github.com/users/ausi/orgs","repos_url":"https://api.github.com/users/ausi/repos","events_url":"https://api.github.com/users/ausi/events{/privacy}","received_events_url":"https://api.github.com/users/ausi/received_events","type":"User","site_admin":false},"created_at":"2018-09-18T18:03:40Z","updated_at":"2018-09-18T18:03:40Z","author_association":"MEMBER","body":"👍 from me.\r\n\r\nBut I think we should then make it installable via the Contao Manager. Maybe by creating a `pdf-export-bundle` and moving the code from `ModuleArticle::generatePdf()` and `tl_article.printable` there?\r\n\r\nThe biggest problem I see here is backwards compatibility. Maybe we can install the `contao/pdf-export-bundle` by default for the managed-edition? But even then, everyone that would update from Contao 4.6 to 4.7 would lose the PDF export."}}
{"actor":{"display_login":"ausi"}}