{"action":"created","issue":{"url":"https://api.github.com/repos/lionleaf/dwitter/issues/373","repository_url":"https://api.github.com/repos/lionleaf/dwitter","labels_url":"https://api.github.com/repos/lionleaf/dwitter/issues/373/labels{/name}","comments_url":"https://api.github.com/repos/lionleaf/dwitter/issues/373/comments","events_url":"https://api.github.com/repos/lionleaf/dwitter/issues/373/events","html_url":"https://github.com/lionleaf/dwitter/issues/373","id":348123593,"node_id":"MDU6SXNzdWUzNDgxMjM1OTM=","number":373,"title":"Error display let's you get outside the iframe and affect the main site","user":{"login":"lionleaf","id":610925,"node_id":"MDQ6VXNlcjYxMDkyNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/610925?v=4","gravatar_id":"","url":"https://api.github.com/users/lionleaf","html_url":"https://github.com/lionleaf","followers_url":"https://api.github.com/users/lionleaf/followers","following_url":"https://api.github.com/users/lionleaf/following{/other_user}","gists_url":"https://api.github.com/users/lionleaf/gists{/gist_id}","starred_url":"https://api.github.com/users/lionleaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lionleaf/subscriptions","organizations_url":"https://api.github.com/users/lionleaf/orgs","repos_url":"https://api.github.com/users/lionleaf/repos","events_url":"https://api.github.com/users/lionleaf/events{/privacy}","received_events_url":"https://api.github.com/users/lionleaf/received_events","type":"User","site_admin":false},"labels":[{"id":1016614414,"node_id":"MDU6TGFiZWwxMDE2NjE0NDE0","url":"https://api.github.com/repos/lionleaf/dwitter/labels/dweet-breaking","name":"dweet-breaking","color":"b60205","default":false},{"id":811183204,"node_id":"MDU6TGFiZWw4MTExODMyMDQ=","url":"https://api.github.com/repos/lionleaf/dwitter/labels/security","name":"security","color":"ead131","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-07T00:19:55Z","updated_at":"2018-09-07T05:51:32Z","closed_at":null,"author_association":"OWNER","body":"While I'm on the security side; it is possible to post dweets that, while maybe not a real security threat, can really affect the flow of the website by throwing exceptions with interesting strings. For instance hundreds of newlines.\r\n\r\nOne way to solve it is to deal with those specific instances, ie. don't allow it to grow with newlines etc.\r\n\r\nBut I suggest we simply disable the viewing of errors when you are not editing the code. Now this breaks some old dweets that relied on `throw \"text\"` as a cheap way to print text, but there aren't too many of them. How do people (especially authors of such dweets) feel about this change? As far as I have seen, most of those dweets are fun small ones; not big efforts with hours of golfing (but I could be wrong).\r\n\r\nYou'd still be able to show of clever `throw` tricks, you would just have to have the users edit the dweet first.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/lionleaf/dwitter/issues/comments/419330609","html_url":"https://github.com/lionleaf/dwitter/issues/373#issuecomment-419330609","issue_url":"https://api.github.com/repos/lionleaf/dwitter/issues/373","id":419330609,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTMzMDYwOQ==","user":{"login":"lionleaf","id":610925,"node_id":"MDQ6VXNlcjYxMDkyNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/610925?v=4","gravatar_id":"","url":"https://api.github.com/users/lionleaf","html_url":"https://github.com/lionleaf","followers_url":"https://api.github.com/users/lionleaf/followers","following_url":"https://api.github.com/users/lionleaf/following{/other_user}","gists_url":"https://api.github.com/users/lionleaf/gists{/gist_id}","starred_url":"https://api.github.com/users/lionleaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lionleaf/subscriptions","organizations_url":"https://api.github.com/users/lionleaf/orgs","repos_url":"https://api.github.com/users/lionleaf/repos","events_url":"https://api.github.com/users/lionleaf/events{/privacy}","received_events_url":"https://api.github.com/users/lionleaf/received_events","type":"User","site_admin":false},"created_at":"2018-09-07T05:51:32Z","updated_at":"2018-09-07T05:51:32Z","author_association":"OWNER","body":"Alright, I've made up my mind. Even though there's been a good amount of fun error-dweets lately, I want to hide the error display until you edit (you can still view the dweets if you edit it).\r\n\r\nIf anyone is interested in implementing that fix, just assign yourself to this issue. If not I'll do it whenever I have some time to sit down properly with dwitter again.  (I'm basically busy for the next 3-4 weeks, so you'll have some time)\r\n\r\nThat would also fix #389 "}}
{"actor":{"display_login":"lionleaf"}}