{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/177791509","pull_request_review_id":107729830,"id":177791509,"diff_hunk":"@@ -149,7 +149,8 @@\n       \"a019acaf8d6fb1f0512414d072f667cc2749b1d9\",\n       \"a884fdc0639ae4e17299838ec9de4fddd83cf93c\",\n       \"6c827cb5879bc096e45efd992dfadcb96c1d50bc\",\n-      \"919282322e106b82fea50878f41b6c75a7eb356b\"\n+      \"919282322e106b82fea50878f41b6c75a7eb356b\",","path":"tools/importer/cmsis_importer.json","position":5,"original_position":5,"commit_id":"5425e827ff562f425d10feac609777ed7fafe7b2","original_commit_id":"a289285bfc863ac2f14936646c79ff3586e3607e","user":{"login":"deepikabhavnani","id":28542450,"avatar_url":"https://avatars3.githubusercontent.com/u/28542450?v=4","gravatar_id":"","url":"https://api.github.com/users/deepikabhavnani","html_url":"https://github.com/deepikabhavnani","followers_url":"https://api.github.com/users/deepikabhavnani/followers","following_url":"https://api.github.com/users/deepikabhavnani/following{/other_user}","gists_url":"https://api.github.com/users/deepikabhavnani/gists{/gist_id}","starred_url":"https://api.github.com/users/deepikabhavnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepikabhavnani/subscriptions","organizations_url":"https://api.github.com/users/deepikabhavnani/orgs","repos_url":"https://api.github.com/users/deepikabhavnani/repos","events_url":"https://api.github.com/users/deepikabhavnani/events{/privacy}","received_events_url":"https://api.github.com/users/deepikabhavnani/received_events","type":"User","site_admin":false},"body":"@bulislaw - Sorry I missed the header part, but the change I wanted to address was conditional compilation. https://github.com/ARMmbed/mbed-os/commit/b93aca294646a72fe8d91f8801a41c288b362a3b#diff-ae477765d86108e79533ea6617f50737R28\r\n\r\nFile should be compiled only in case of secure build and not for non-secure build, will check with @theotherjimmy if we can have some option from tools\r\n","created_at":"2018-03-28T15:29:57Z","updated_at":"2018-03-28T15:29:57Z","html_url":"https://github.com/ARMmbed/mbed-os/pull/6483#discussion_r177791509","pull_request_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6483","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/177791509"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/6483#discussion_r177791509"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6483"}},"in_reply_to_id":177494144},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6483","id":177793068,"html_url":"https://github.com/ARMmbed/mbed-os/pull/6483","diff_url":"https://github.com/ARMmbed/mbed-os/pull/6483.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/6483.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/6483","number":6483,"state":"open","locked":false,"title":"Add tz functions","user":{"login":"deepikabhavnani","id":28542450,"avatar_url":"https://avatars3.githubusercontent.com/u/28542450?v=4","gravatar_id":"","url":"https://api.github.com/users/deepikabhavnani","html_url":"https://github.com/deepikabhavnani","followers_url":"https://api.github.com/users/deepikabhavnani/followers","following_url":"https://api.github.com/users/deepikabhavnani/following{/other_user}","gists_url":"https://api.github.com/users/deepikabhavnani/gists{/gist_id}","starred_url":"https://api.github.com/users/deepikabhavnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepikabhavnani/subscriptions","organizations_url":"https://api.github.com/users/deepikabhavnani/orgs","repos_url":"https://api.github.com/users/deepikabhavnani/repos","events_url":"https://api.github.com/users/deepikabhavnani/events{/privacy}","received_events_url":"https://api.github.com/users/deepikabhavnani/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nAdd TZ functions to mbed-os build from CMSIS repo. These functions are required to be part of secure library when RTOS support is required in non-secure mbed-os.\r\n\r\n### Pull request type\r\n    [ ] Fix\r\n    [ ] Refactor\r\n    [ ] New target\r\n    [X] Feature\r\n    [ ] Breaking change\r\n\r\nCC @bulislaw ","created_at":"2018-03-27T16:16:56Z","updated_at":"2018-03-28T15:29:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6319db4c4301152080177be37fb7ad64fa371ad1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":147112891,"url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/needs:%20review","name":"needs: review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6483/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6483/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/6483/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/5425e827ff562f425d10feac609777ed7fafe7b2","head":{"label":"deepikabhavnani:add_tz_functions","ref":"add_tz_functions","sha":"5425e827ff562f425d10feac609777ed7fafe7b2","user":{"login":"deepikabhavnani","id":28542450,"avatar_url":"https://avatars3.githubusercontent.com/u/28542450?v=4","gravatar_id":"","url":"https://api.github.com/users/deepikabhavnani","html_url":"https://github.com/deepikabhavnani","followers_url":"https://api.github.com/users/deepikabhavnani/followers","following_url":"https://api.github.com/users/deepikabhavnani/following{/other_user}","gists_url":"https://api.github.com/users/deepikabhavnani/gists{/gist_id}","starred_url":"https://api.github.com/users/deepikabhavnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepikabhavnani/subscriptions","organizations_url":"https://api.github.com/users/deepikabhavnani/orgs","repos_url":"https://api.github.com/users/deepikabhavnani/repos","events_url":"https://api.github.com/users/deepikabhavnani/events{/privacy}","received_events_url":"https://api.github.com/users/deepikabhavnani/received_events","type":"User","site_admin":false},"repo":{"id":90886942,"name":"mbed-os","full_name":"deepikabhavnani/mbed-os","owner":{"login":"deepikabhavnani","id":28542450,"avatar_url":"https://avatars3.githubusercontent.com/u/28542450?v=4","gravatar_id":"","url":"https://api.github.com/users/deepikabhavnani","html_url":"https://github.com/deepikabhavnani","followers_url":"https://api.github.com/users/deepikabhavnani/followers","following_url":"https://api.github.com/users/deepikabhavnani/following{/other_user}","gists_url":"https://api.github.com/users/deepikabhavnani/gists{/gist_id}","starred_url":"https://api.github.com/users/deepikabhavnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepikabhavnani/subscriptions","organizations_url":"https://api.github.com/users/deepikabhavnani/orgs","repos_url":"https://api.github.com/users/deepikabhavnani/repos","events_url":"https://api.github.com/users/deepikabhavnani/events{/privacy}","received_events_url":"https://api.github.com/users/deepikabhavnani/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/deepikabhavnani/mbed-os","description":"ARM mbed OS is a platform operating system designed for the internet of things","fork":true,"url":"https://api.github.com/repos/deepikabhavnani/mbed-os","forks_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/forks","keys_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/teams","hooks_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/events","assignees_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/tags","blobs_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/languages","stargazers_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/subscription","commits_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/merges","archive_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/downloads","issues_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/deepikabhavnani/mbed-os/deployments","created_at":"2017-05-10T16:44:29Z","updated_at":"2018-03-26T20:08:35Z","pushed_at":"2018-03-27T19:06:16Z","git_url":"git://github.com/deepikabhavnani/mbed-os.git","ssh_url":"git@github.com:deepikabhavnani/mbed-os.git","clone_url":"https://github.com/deepikabhavnani/mbed-os.git","svn_url":"https://github.com/deepikabhavnani/mbed-os","homepage":"https://mbed.com","size":200090,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"062164eaad9c36299a9b30eaac9077b8c02472a5","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":8270972,"name":"mbed-os","full_name":"ARMmbed/mbed-os","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/mbed-os","description":"ARM Mbed OS is a platform operating system designed for the internet of things","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-os","forks_url":"https://api.github.com/repos/ARMmbed/mbed-os/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-os/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-os/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-os/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-os/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-os/deployments","created_at":"2013-02-18T15:23:11Z","updated_at":"2018-03-28T14:55:47Z","pushed_at":"2018-03-28T15:12:26Z","git_url":"git://github.com/ARMmbed/mbed-os.git","ssh_url":"git@github.com:ARMmbed/mbed-os.git","clone_url":"https://github.com/ARMmbed/mbed-os.git","svn_url":"https://github.com/ARMmbed/mbed-os","homepage":"https://mbed.com","size":203724,"stargazers_count":1562,"watchers_count":1562,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1379,"mirror_url":null,"archived":false,"open_issues_count":433,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1379,"open_issues":433,"watchers":1562,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6483"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/6483"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/6483"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/6483/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6483/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6483/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/5425e827ff562f425d10feac609777ed7fafe7b2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"deepikabhavnani"}}