{"action":"opened","number":317,"pull_request":{"url":"https://api.github.com/repos/neulab/xnmt/pulls/317","id":180232507,"html_url":"https://github.com/neulab/xnmt/pull/317","diff_url":"https://github.com/neulab/xnmt/pull/317.diff","patch_url":"https://github.com/neulab/xnmt/pull/317.patch","issue_url":"https://api.github.com/repos/neulab/xnmt/issues/317","number":317,"state":"open","locked":false,"title":"Better Persistence","user":{"login":"msperber","id":1821303,"avatar_url":"https://avatars2.githubusercontent.com/u/1821303?v=4","gravatar_id":"","url":"https://api.github.com/users/msperber","html_url":"https://github.com/msperber","followers_url":"https://api.github.com/users/msperber/followers","following_url":"https://api.github.com/users/msperber/following{/other_user}","gists_url":"https://api.github.com/users/msperber/gists{/gist_id}","starred_url":"https://api.github.com/users/msperber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msperber/subscriptions","organizations_url":"https://api.github.com/users/msperber/orgs","repos_url":"https://api.github.com/users/msperber/repos","events_url":"https://api.github.com/users/msperber/events{/privacy}","received_events_url":"https://api.github.com/users/msperber/received_events","type":"User","site_admin":false},"body":"- fix an issue that caused Linear and MLP to be not saved properly\r\n- make YAML (de-)serialization a bit less confusing and reduce the chance of introducing bugs:\r\n  - imports.py is moved to package init and no longer needs to be imported manually\r\n  - other modules are merged into a new \"persistence.py\" module so stuff doesn't have to be imported from multiple modules (division was not super clean in the first place).\r\n  - OptionParser is renamed -> YamlPreloader\r\n  - YamlSerializer no longer needs to be instantiated by hand\r\n  - instead, the main functions for loading / saving are now module-level: initialize_if_needed(), initialize_object(), save_to_file()\r\n  - Serializable.shared_params() can now return sets of strings instead of sets of Path objects\r\n  - Serializable.overwrite_serialize_param is renamed -> save_processed_arg()\r\n  - some more bug checks, informative error messages, doc in some places","created_at":"2018-04-09T07:38:00Z","updated_at":"2018-04-09T07:38:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/neulab/xnmt/pulls/317/commits","review_comments_url":"https://api.github.com/repos/neulab/xnmt/pulls/317/comments","review_comment_url":"https://api.github.com/repos/neulab/xnmt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neulab/xnmt/issues/317/comments","statuses_url":"https://api.github.com/repos/neulab/xnmt/statuses/58a023ce27d540ae57da7994619f74c5b3269e52","head":{"label":"neulab:persistence","ref":"persistence","sha":"58a023ce27d540ae57da7994619f74c5b3269e52","user":{"login":"neulab","id":22324665,"avatar_url":"https://avatars2.githubusercontent.com/u/22324665?v=4","gravatar_id":"","url":"https://api.github.com/users/neulab","html_url":"https://github.com/neulab","followers_url":"https://api.github.com/users/neulab/followers","following_url":"https://api.github.com/users/neulab/following{/other_user}","gists_url":"https://api.github.com/users/neulab/gists{/gist_id}","starred_url":"https://api.github.com/users/neulab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neulab/subscriptions","organizations_url":"https://api.github.com/users/neulab/orgs","repos_url":"https://api.github.com/users/neulab/repos","events_url":"https://api.github.com/users/neulab/events{/privacy}","received_events_url":"https://api.github.com/users/neulab/received_events","type":"Organization","site_admin":false},"repo":{"id":79833244,"name":"xnmt","full_name":"neulab/xnmt","owner":{"login":"neulab","id":22324665,"avatar_url":"https://avatars2.githubusercontent.com/u/22324665?v=4","gravatar_id":"","url":"https://api.github.com/users/neulab","html_url":"https://github.com/neulab","followers_url":"https://api.github.com/users/neulab/followers","following_url":"https://api.github.com/users/neulab/following{/other_user}","gists_url":"https://api.github.com/users/neulab/gists{/gist_id}","starred_url":"https://api.github.com/users/neulab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neulab/subscriptions","organizations_url":"https://api.github.com/users/neulab/orgs","repos_url":"https://api.github.com/users/neulab/repos","events_url":"https://api.github.com/users/neulab/events{/privacy}","received_events_url":"https://api.github.com/users/neulab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neulab/xnmt","description":"eXtensible Neural Machine Translation","fork":false,"url":"https://api.github.com/repos/neulab/xnmt","forks_url":"https://api.github.com/repos/neulab/xnmt/forks","keys_url":"https://api.github.com/repos/neulab/xnmt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neulab/xnmt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neulab/xnmt/teams","hooks_url":"https://api.github.com/repos/neulab/xnmt/hooks","issue_events_url":"https://api.github.com/repos/neulab/xnmt/issues/events{/number}","events_url":"https://api.github.com/repos/neulab/xnmt/events","assignees_url":"https://api.github.com/repos/neulab/xnmt/assignees{/user}","branches_url":"https://api.github.com/repos/neulab/xnmt/branches{/branch}","tags_url":"https://api.github.com/repos/neulab/xnmt/tags","blobs_url":"https://api.github.com/repos/neulab/xnmt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neulab/xnmt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neulab/xnmt/git/refs{/sha}","trees_url":"https://api.github.com/repos/neulab/xnmt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neulab/xnmt/statuses/{sha}","languages_url":"https://api.github.com/repos/neulab/xnmt/languages","stargazers_url":"https://api.github.com/repos/neulab/xnmt/stargazers","contributors_url":"https://api.github.com/repos/neulab/xnmt/contributors","subscribers_url":"https://api.github.com/repos/neulab/xnmt/subscribers","subscription_url":"https://api.github.com/repos/neulab/xnmt/subscription","commits_url":"https://api.github.com/repos/neulab/xnmt/commits{/sha}","git_commits_url":"https://api.github.com/repos/neulab/xnmt/git/commits{/sha}","comments_url":"https://api.github.com/repos/neulab/xnmt/comments{/number}","issue_comment_url":"https://api.github.com/repos/neulab/xnmt/issues/comments{/number}","contents_url":"https://api.github.com/repos/neulab/xnmt/contents/{+path}","compare_url":"https://api.github.com/repos/neulab/xnmt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neulab/xnmt/merges","archive_url":"https://api.github.com/repos/neulab/xnmt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neulab/xnmt/downloads","issues_url":"https://api.github.com/repos/neulab/xnmt/issues{/number}","pulls_url":"https://api.github.com/repos/neulab/xnmt/pulls{/number}","milestones_url":"https://api.github.com/repos/neulab/xnmt/milestones{/number}","notifications_url":"https://api.github.com/repos/neulab/xnmt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neulab/xnmt/labels{/name}","releases_url":"https://api.github.com/repos/neulab/xnmt/releases{/id}","deployments_url":"https://api.github.com/repos/neulab/xnmt/deployments","created_at":"2017-01-23T18:18:54Z","updated_at":"2018-04-07T13:35:01Z","pushed_at":"2018-04-09T07:22:47Z","git_url":"git://github.com/neulab/xnmt.git","ssh_url":"git@github.com:neulab/xnmt.git","clone_url":"https://github.com/neulab/xnmt.git","svn_url":"https://github.com/neulab/xnmt","homepage":null,"size":16798,"stargazers_count":83,"watchers_count":83,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":23,"open_issues":15,"watchers":83,"default_branch":"master"}},"base":{"label":"neulab:master","ref":"master","sha":"04488825016222ecee94c23a579a3deb504f6c2b","user":{"login":"neulab","id":22324665,"avatar_url":"https://avatars2.githubusercontent.com/u/22324665?v=4","gravatar_id":"","url":"https://api.github.com/users/neulab","html_url":"https://github.com/neulab","followers_url":"https://api.github.com/users/neulab/followers","following_url":"https://api.github.com/users/neulab/following{/other_user}","gists_url":"https://api.github.com/users/neulab/gists{/gist_id}","starred_url":"https://api.github.com/users/neulab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neulab/subscriptions","organizations_url":"https://api.github.com/users/neulab/orgs","repos_url":"https://api.github.com/users/neulab/repos","events_url":"https://api.github.com/users/neulab/events{/privacy}","received_events_url":"https://api.github.com/users/neulab/received_events","type":"Organization","site_admin":false},"repo":{"id":79833244,"name":"xnmt","full_name":"neulab/xnmt","owner":{"login":"neulab","id":22324665,"avatar_url":"https://avatars2.githubusercontent.com/u/22324665?v=4","gravatar_id":"","url":"https://api.github.com/users/neulab","html_url":"https://github.com/neulab","followers_url":"https://api.github.com/users/neulab/followers","following_url":"https://api.github.com/users/neulab/following{/other_user}","gists_url":"https://api.github.com/users/neulab/gists{/gist_id}","starred_url":"https://api.github.com/users/neulab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neulab/subscriptions","organizations_url":"https://api.github.com/users/neulab/orgs","repos_url":"https://api.github.com/users/neulab/repos","events_url":"https://api.github.com/users/neulab/events{/privacy}","received_events_url":"https://api.github.com/users/neulab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neulab/xnmt","description":"eXtensible Neural Machine Translation","fork":false,"url":"https://api.github.com/repos/neulab/xnmt","forks_url":"https://api.github.com/repos/neulab/xnmt/forks","keys_url":"https://api.github.com/repos/neulab/xnmt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neulab/xnmt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neulab/xnmt/teams","hooks_url":"https://api.github.com/repos/neulab/xnmt/hooks","issue_events_url":"https://api.github.com/repos/neulab/xnmt/issues/events{/number}","events_url":"https://api.github.com/repos/neulab/xnmt/events","assignees_url":"https://api.github.com/repos/neulab/xnmt/assignees{/user}","branches_url":"https://api.github.com/repos/neulab/xnmt/branches{/branch}","tags_url":"https://api.github.com/repos/neulab/xnmt/tags","blobs_url":"https://api.github.com/repos/neulab/xnmt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neulab/xnmt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neulab/xnmt/git/refs{/sha}","trees_url":"https://api.github.com/repos/neulab/xnmt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neulab/xnmt/statuses/{sha}","languages_url":"https://api.github.com/repos/neulab/xnmt/languages","stargazers_url":"https://api.github.com/repos/neulab/xnmt/stargazers","contributors_url":"https://api.github.com/repos/neulab/xnmt/contributors","subscribers_url":"https://api.github.com/repos/neulab/xnmt/subscribers","subscription_url":"https://api.github.com/repos/neulab/xnmt/subscription","commits_url":"https://api.github.com/repos/neulab/xnmt/commits{/sha}","git_commits_url":"https://api.github.com/repos/neulab/xnmt/git/commits{/sha}","comments_url":"https://api.github.com/repos/neulab/xnmt/comments{/number}","issue_comment_url":"https://api.github.com/repos/neulab/xnmt/issues/comments{/number}","contents_url":"https://api.github.com/repos/neulab/xnmt/contents/{+path}","compare_url":"https://api.github.com/repos/neulab/xnmt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neulab/xnmt/merges","archive_url":"https://api.github.com/repos/neulab/xnmt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neulab/xnmt/downloads","issues_url":"https://api.github.com/repos/neulab/xnmt/issues{/number}","pulls_url":"https://api.github.com/repos/neulab/xnmt/pulls{/number}","milestones_url":"https://api.github.com/repos/neulab/xnmt/milestones{/number}","notifications_url":"https://api.github.com/repos/neulab/xnmt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neulab/xnmt/labels{/name}","releases_url":"https://api.github.com/repos/neulab/xnmt/releases{/id}","deployments_url":"https://api.github.com/repos/neulab/xnmt/deployments","created_at":"2017-01-23T18:18:54Z","updated_at":"2018-04-07T13:35:01Z","pushed_at":"2018-04-09T07:22:47Z","git_url":"git://github.com/neulab/xnmt.git","ssh_url":"git@github.com:neulab/xnmt.git","clone_url":"https://github.com/neulab/xnmt.git","svn_url":"https://github.com/neulab/xnmt","homepage":null,"size":16798,"stargazers_count":83,"watchers_count":83,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":23,"open_issues":15,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neulab/xnmt/pulls/317"},"html":{"href":"https://github.com/neulab/xnmt/pull/317"},"issue":{"href":"https://api.github.com/repos/neulab/xnmt/issues/317"},"comments":{"href":"https://api.github.com/repos/neulab/xnmt/issues/317/comments"},"review_comments":{"href":"https://api.github.com/repos/neulab/xnmt/pulls/317/comments"},"review_comment":{"href":"https://api.github.com/repos/neulab/xnmt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neulab/xnmt/pulls/317/commits"},"statuses":{"href":"https://api.github.com/repos/neulab/xnmt/statuses/58a023ce27d540ae57da7994619f74c5b3269e52"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":14,"additions":1420,"deletions":1261,"changed_files":51}}
{"actor":{"display_login":"msperber"}}