{"action":"closed","number":4,"pull_request":{"url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/pulls/4","id":191121471,"html_url":"https://github.com/transistorsoft/cordova-google-api-version/pull/4","diff_url":"https://github.com/transistorsoft/cordova-google-api-version/pull/4.diff","patch_url":"https://github.com/transistorsoft/cordova-google-api-version/pull/4.patch","issue_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/issues/4","number":4,"state":"closed","locked":false,"title":"Use android.json instead of config.xml","user":{"login":"steveetm","id":11589541,"avatar_url":"https://avatars1.githubusercontent.com/u/11589541?v=4","gravatar_id":"","url":"https://api.github.com/users/steveetm","html_url":"https://github.com/steveetm","followers_url":"https://api.github.com/users/steveetm/followers","following_url":"https://api.github.com/users/steveetm/following{/other_user}","gists_url":"https://api.github.com/users/steveetm/gists{/gist_id}","starred_url":"https://api.github.com/users/steveetm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveetm/subscriptions","organizations_url":"https://api.github.com/users/steveetm/orgs","repos_url":"https://api.github.com/users/steveetm/repos","events_url":"https://api.github.com/users/steveetm/events{/privacy}","received_events_url":"https://api.github.com/users/steveetm/received_events","type":"User","site_admin":false},"body":"Can't use config.xml if someone adds plugins with plugman as it won't save plugin states to config.xml.\r\n\r\nI also didn't like the method to parse the whole config.xml just to find the plugin itself then simply pop the variable. I don't really know if someone ever need to add another variable to this plugin, but if that is the case the old method will break immediately, or at least depends on the order of variables.\r\n\r\nTested with cordova-android@6.3.0 and cordova-android@7.1.0","created_at":"2018-05-29T11:57:01Z","updated_at":"2018-05-29T12:02:22Z","closed_at":"2018-05-29T12:02:22Z","merged_at":null,"merge_commit_sha":"68865d8bc8fa10a0ce45ec8e7f9b467aa629fdc4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/pulls/4/commits","review_comments_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/pulls/4/comments","review_comment_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/pulls/comments{/number}","comments_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/issues/4/comments","statuses_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/statuses/f7e08af33295d7a0e86f1fcccbc866475ab30e99","head":{"label":"steveetm:master","ref":"master","sha":"f7e08af33295d7a0e86f1fcccbc866475ab30e99","user":{"login":"steveetm","id":11589541,"avatar_url":"https://avatars1.githubusercontent.com/u/11589541?v=4","gravatar_id":"","url":"https://api.github.com/users/steveetm","html_url":"https://github.com/steveetm","followers_url":"https://api.github.com/users/steveetm/followers","following_url":"https://api.github.com/users/steveetm/following{/other_user}","gists_url":"https://api.github.com/users/steveetm/gists{/gist_id}","starred_url":"https://api.github.com/users/steveetm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveetm/subscriptions","organizations_url":"https://api.github.com/users/steveetm/orgs","repos_url":"https://api.github.com/users/steveetm/repos","events_url":"https://api.github.com/users/steveetm/events{/privacy}","received_events_url":"https://api.github.com/users/steveetm/received_events","type":"User","site_admin":false},"repo":{"id":135286331,"name":"cordova-google-api-version","full_name":"steveetm/cordova-google-api-version","owner":{"login":"steveetm","id":11589541,"avatar_url":"https://avatars1.githubusercontent.com/u/11589541?v=4","gravatar_id":"","url":"https://api.github.com/users/steveetm","html_url":"https://github.com/steveetm","followers_url":"https://api.github.com/users/steveetm/followers","following_url":"https://api.github.com/users/steveetm/following{/other_user}","gists_url":"https://api.github.com/users/steveetm/gists{/gist_id}","starred_url":"https://api.github.com/users/steveetm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveetm/subscriptions","organizations_url":"https://api.github.com/users/steveetm/orgs","repos_url":"https://api.github.com/users/steveetm/repos","events_url":"https://api.github.com/users/steveetm/events{/privacy}","received_events_url":"https://api.github.com/users/steveetm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/steveetm/cordova-google-api-version","description":"Cordova plugin to solve Google API version conflicts by pining a desired version for all Google APIs (eg: play-services, firebase)","fork":true,"url":"https://api.github.com/repos/steveetm/cordova-google-api-version","forks_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/forks","keys_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/keys{/key_id}","collaborators_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/teams","hooks_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/hooks","issue_events_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/issues/events{/number}","events_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/events","assignees_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/assignees{/user}","branches_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/branches{/branch}","tags_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/tags","blobs_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/git/refs{/sha}","trees_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/git/trees{/sha}","statuses_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/statuses/{sha}","languages_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/languages","stargazers_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/stargazers","contributors_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/contributors","subscribers_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/subscribers","subscription_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/subscription","commits_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/commits{/sha}","git_commits_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/git/commits{/sha}","comments_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/comments{/number}","issue_comment_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/issues/comments{/number}","contents_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/contents/{+path}","compare_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/compare/{base}...{head}","merges_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/merges","archive_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/downloads","issues_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/issues{/number}","pulls_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/pulls{/number}","milestones_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/milestones{/number}","notifications_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/labels{/name}","releases_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/releases{/id}","deployments_url":"https://api.github.com/repos/steveetm/cordova-google-api-version/deployments","created_at":"2018-05-29T11:31:32Z","updated_at":"2018-05-29T11:53:56Z","pushed_at":"2018-05-29T11:53:54Z","git_url":"git://github.com/steveetm/cordova-google-api-version.git","ssh_url":"git@github.com:steveetm/cordova-google-api-version.git","clone_url":"https://github.com/steveetm/cordova-google-api-version.git","svn_url":"https://github.com/steveetm/cordova-google-api-version","homepage":null,"size":13,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"transistorsoft:master","ref":"master","sha":"5d647f7f49f974c0ad50d5024a14b9ed6f886fec","user":{"login":"transistorsoft","id":2099918,"avatar_url":"https://avatars1.githubusercontent.com/u/2099918?v=4","gravatar_id":"","url":"https://api.github.com/users/transistorsoft","html_url":"https://github.com/transistorsoft","followers_url":"https://api.github.com/users/transistorsoft/followers","following_url":"https://api.github.com/users/transistorsoft/following{/other_user}","gists_url":"https://api.github.com/users/transistorsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/transistorsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transistorsoft/subscriptions","organizations_url":"https://api.github.com/users/transistorsoft/orgs","repos_url":"https://api.github.com/users/transistorsoft/repos","events_url":"https://api.github.com/users/transistorsoft/events{/privacy}","received_events_url":"https://api.github.com/users/transistorsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":101652487,"name":"cordova-google-api-version","full_name":"transistorsoft/cordova-google-api-version","owner":{"login":"transistorsoft","id":2099918,"avatar_url":"https://avatars1.githubusercontent.com/u/2099918?v=4","gravatar_id":"","url":"https://api.github.com/users/transistorsoft","html_url":"https://github.com/transistorsoft","followers_url":"https://api.github.com/users/transistorsoft/followers","following_url":"https://api.github.com/users/transistorsoft/following{/other_user}","gists_url":"https://api.github.com/users/transistorsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/transistorsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transistorsoft/subscriptions","organizations_url":"https://api.github.com/users/transistorsoft/orgs","repos_url":"https://api.github.com/users/transistorsoft/repos","events_url":"https://api.github.com/users/transistorsoft/events{/privacy}","received_events_url":"https://api.github.com/users/transistorsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/transistorsoft/cordova-google-api-version","description":"Cordova plugin to solve Google API version conflicts by pining a desired version for all Google APIs (eg: play-services, firebase)","fork":false,"url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version","forks_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/forks","keys_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/keys{/key_id}","collaborators_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/teams","hooks_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/hooks","issue_events_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/issues/events{/number}","events_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/events","assignees_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/assignees{/user}","branches_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/branches{/branch}","tags_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/tags","blobs_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/git/refs{/sha}","trees_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/git/trees{/sha}","statuses_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/statuses/{sha}","languages_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/languages","stargazers_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/stargazers","contributors_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/contributors","subscribers_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/subscribers","subscription_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/subscription","commits_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/commits{/sha}","git_commits_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/git/commits{/sha}","comments_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/comments{/number}","issue_comment_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/issues/comments{/number}","contents_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/contents/{+path}","compare_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/compare/{base}...{head}","merges_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/merges","archive_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/downloads","issues_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/issues{/number}","pulls_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/pulls{/number}","milestones_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/milestones{/number}","notifications_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/labels{/name}","releases_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/releases{/id}","deployments_url":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/deployments","created_at":"2017-08-28T14:37:32Z","updated_at":"2018-05-23T12:05:20Z","pushed_at":"2018-05-29T11:57:02Z","git_url":"git://github.com/transistorsoft/cordova-google-api-version.git","ssh_url":"git@github.com:transistorsoft/cordova-google-api-version.git","clone_url":"https://github.com/transistorsoft/cordova-google-api-version.git","svn_url":"https://github.com/transistorsoft/cordova-google-api-version","homepage":null,"size":13,"stargazers_count":18,"watchers_count":18,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":0,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/pulls/4"},"html":{"href":"https://github.com/transistorsoft/cordova-google-api-version/pull/4"},"issue":{"href":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/issues/4"},"comments":{"href":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/transistorsoft/cordova-google-api-version/statuses/f7e08af33295d7a0e86f1fcccbc866475ab30e99"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":12,"deletions":24,"changed_files":2}}
{"actor":{"display_login":"christocracy"}}