{"action":"created","comment":{"url":"https://api.github.com/repos/aragon/aragon.js/pulls/comments/213383473","pull_request_review_id":150208582,"id":213383473,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzM4MzQ3Mw==","diff_hunk":"@@ -218,7 +234,7 @@ export default class Aragon {\n           apps.map(async (app) => Object.assign(\n             app,\n             await this.apm.getLatestVersionForContract(app.appId, app.codeAddress)\n-              .catch(() => ({}))\n+              .catch(() => getAragonOSAppInfo(app.appId)) // for unpublished apps we check local mapping","path":"packages/aragon-wrapper/src/index.js","position":69,"original_position":69,"commit_id":"a3376e586d598ab7bf6715e2dd559a1bc0b61178","original_commit_id":"a3376e586d598ab7bf6715e2dd559a1bc0b61178","user":{"login":"sohkai","id":4166642,"node_id":"MDQ6VXNlcjQxNjY2NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/4166642?v=4","gravatar_id":"","url":"https://api.github.com/users/sohkai","html_url":"https://github.com/sohkai","followers_url":"https://api.github.com/users/sohkai/followers","following_url":"https://api.github.com/users/sohkai/following{/other_user}","gists_url":"https://api.github.com/users/sohkai/gists{/gist_id}","starred_url":"https://api.github.com/users/sohkai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sohkai/subscriptions","organizations_url":"https://api.github.com/users/sohkai/orgs","repos_url":"https://api.github.com/users/sohkai/repos","events_url":"https://api.github.com/users/sohkai/events{/privacy}","received_events_url":"https://api.github.com/users/sohkai/received_events","type":"User","site_admin":false},"body":"Was thinking about that too... not sure if it really belongs in the same list as it's not really an \"app\", but that would likely be the most convenient.\r\n\r\nAnother alternative is a `kernel` observable that returns the artifact and address of the kernel.","created_at":"2018-08-28T16:27:26Z","updated_at":"2018-08-28T16:27:26Z","html_url":"https://github.com/aragon/aragon.js/pull/138#discussion_r213383473","pull_request_url":"https://api.github.com/repos/aragon/aragon.js/pulls/138","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aragon/aragon.js/pulls/comments/213383473"},"html":{"href":"https://github.com/aragon/aragon.js/pull/138#discussion_r213383473"},"pull_request":{"href":"https://api.github.com/repos/aragon/aragon.js/pulls/138"}},"in_reply_to_id":213347880},"pull_request":{"url":"https://api.github.com/repos/aragon/aragon.js/pulls/138","id":210951006,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwOTUxMDA2","html_url":"https://github.com/aragon/aragon.js/pull/138","diff_url":"https://github.com/aragon/aragon.js/pull/138.diff","patch_url":"https://github.com/aragon/aragon.js/pull/138.patch","issue_url":"https://api.github.com/repos/aragon/aragon.js/issues/138","number":138,"state":"open","locked":false,"title":"Implements ACL intents","user":{"login":"izqui","id":447328,"node_id":"MDQ6VXNlcjQ0NzMyOA==","avatar_url":"https://avatars3.githubusercontent.com/u/447328?v=4","gravatar_id":"","url":"https://api.github.com/users/izqui","html_url":"https://github.com/izqui","followers_url":"https://api.github.com/users/izqui/followers","following_url":"https://api.github.com/users/izqui/following{/other_user}","gists_url":"https://api.github.com/users/izqui/gists{/gist_id}","starred_url":"https://api.github.com/users/izqui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/izqui/subscriptions","organizations_url":"https://api.github.com/users/izqui/orgs","repos_url":"https://api.github.com/users/izqui/repos","events_url":"https://api.github.com/users/izqui/events{/privacy}","received_events_url":"https://api.github.com/users/izqui/received_events","type":"User","site_admin":false},"body":"Builds on #137 \r\n\r\n- Modified `calculateTransactionPath` function so if a `finalForwarder` address is provided, it will always try to forward using that forwarder. In the case of ACL actions that don't have a role, but need the permission manager to perform the action, it passes the permission manager as the `finalForwarder`. Closes #136.\r\n- Added an artifact file for the `ACL` generated locally with the aid of the CLI. This is needed because the ACL app is not currently being published as a regular app.\r\n\r\n`wrapper.performACLIntent(method, params)` is used in the same way that intents are used inside regular apps. It will perform a special case of transaction pathing taking permission managers into account (except for `createPermission` which uses a normal role) and then add the transaction.\r\n- `method` is the function name (i.e. `grantPermission`)\r\n- `params` is an array of the parameters (i.e.`[entity, app, role]`)","created_at":"2018-08-26T13:13:18Z","updated_at":"2018-08-28T16:27:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6752b872bcbc194a80d6529906b6ee5a7ebd8f47","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1038074345,"node_id":"MDU6TGFiZWwxMDM4MDc0MzQ1","url":"https://api.github.com/repos/aragon/aragon.js/labels/epic:%20Permissions","name":"epic: Permissions","color":"c7f2fc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/aragon/aragon.js/pulls/138/commits","review_comments_url":"https://api.github.com/repos/aragon/aragon.js/pulls/138/comments","review_comment_url":"https://api.github.com/repos/aragon/aragon.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aragon/aragon.js/issues/138/comments","statuses_url":"https://api.github.com/repos/aragon/aragon.js/statuses/a3376e586d598ab7bf6715e2dd559a1bc0b61178","head":{"label":"aragon:acl-actions","ref":"acl-actions","sha":"a3376e586d598ab7bf6715e2dd559a1bc0b61178","user":{"login":"aragon","id":24612534,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NjEyNTM0","avatar_url":"https://avatars1.githubusercontent.com/u/24612534?v=4","gravatar_id":"","url":"https://api.github.com/users/aragon","html_url":"https://github.com/aragon","followers_url":"https://api.github.com/users/aragon/followers","following_url":"https://api.github.com/users/aragon/following{/other_user}","gists_url":"https://api.github.com/users/aragon/gists{/gist_id}","starred_url":"https://api.github.com/users/aragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aragon/subscriptions","organizations_url":"https://api.github.com/users/aragon/orgs","repos_url":"https://api.github.com/users/aragon/repos","events_url":"https://api.github.com/users/aragon/events{/privacy}","received_events_url":"https://api.github.com/users/aragon/received_events","type":"Organization","site_admin":false},"repo":{"id":98191281,"node_id":"MDEwOlJlcG9zaXRvcnk5ODE5MTI4MQ==","name":"aragon.js","full_name":"aragon/aragon.js","owner":{"login":"aragon","id":24612534,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NjEyNTM0","avatar_url":"https://avatars1.githubusercontent.com/u/24612534?v=4","gravatar_id":"","url":"https://api.github.com/users/aragon","html_url":"https://github.com/aragon","followers_url":"https://api.github.com/users/aragon/followers","following_url":"https://api.github.com/users/aragon/following{/other_user}","gists_url":"https://api.github.com/users/aragon/gists{/gist_id}","starred_url":"https://api.github.com/users/aragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aragon/subscriptions","organizations_url":"https://api.github.com/users/aragon/orgs","repos_url":"https://api.github.com/users/aragon/repos","events_url":"https://api.github.com/users/aragon/events{/privacy}","received_events_url":"https://api.github.com/users/aragon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aragon/aragon.js","description":"A JavaScript library for interacting with Aragon","fork":false,"url":"https://api.github.com/repos/aragon/aragon.js","forks_url":"https://api.github.com/repos/aragon/aragon.js/forks","keys_url":"https://api.github.com/repos/aragon/aragon.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aragon/aragon.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aragon/aragon.js/teams","hooks_url":"https://api.github.com/repos/aragon/aragon.js/hooks","issue_events_url":"https://api.github.com/repos/aragon/aragon.js/issues/events{/number}","events_url":"https://api.github.com/repos/aragon/aragon.js/events","assignees_url":"https://api.github.com/repos/aragon/aragon.js/assignees{/user}","branches_url":"https://api.github.com/repos/aragon/aragon.js/branches{/branch}","tags_url":"https://api.github.com/repos/aragon/aragon.js/tags","blobs_url":"https://api.github.com/repos/aragon/aragon.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aragon/aragon.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aragon/aragon.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/aragon/aragon.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aragon/aragon.js/statuses/{sha}","languages_url":"https://api.github.com/repos/aragon/aragon.js/languages","stargazers_url":"https://api.github.com/repos/aragon/aragon.js/stargazers","contributors_url":"https://api.github.com/repos/aragon/aragon.js/contributors","subscribers_url":"https://api.github.com/repos/aragon/aragon.js/subscribers","subscription_url":"https://api.github.com/repos/aragon/aragon.js/subscription","commits_url":"https://api.github.com/repos/aragon/aragon.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/aragon/aragon.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/aragon/aragon.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/aragon/aragon.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/aragon/aragon.js/contents/{+path}","compare_url":"https://api.github.com/repos/aragon/aragon.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aragon/aragon.js/merges","archive_url":"https://api.github.com/repos/aragon/aragon.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aragon/aragon.js/downloads","issues_url":"https://api.github.com/repos/aragon/aragon.js/issues{/number}","pulls_url":"https://api.github.com/repos/aragon/aragon.js/pulls{/number}","milestones_url":"https://api.github.com/repos/aragon/aragon.js/milestones{/number}","notifications_url":"https://api.github.com/repos/aragon/aragon.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aragon/aragon.js/labels{/name}","releases_url":"https://api.github.com/repos/aragon/aragon.js/releases{/id}","deployments_url":"https://api.github.com/repos/aragon/aragon.js/deployments","created_at":"2017-07-24T13:03:16Z","updated_at":"2018-08-27T17:01:22Z","pushed_at":"2018-08-28T15:24:17Z","git_url":"git://github.com/aragon/aragon.js.git","ssh_url":"git@github.com:aragon/aragon.js.git","clone_url":"https://github.com/aragon/aragon.js.git","svn_url":"https://github.com/aragon/aragon.js","homepage":"https://aragon.one","size":1578,"stargazers_count":51,"watchers_count":51,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":20,"open_issues":44,"watchers":51,"default_branch":"master"}},"base":{"label":"aragon:master","ref":"master","sha":"48d414fc1505535564b7f92b3561e6b6866df9f1","user":{"login":"aragon","id":24612534,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NjEyNTM0","avatar_url":"https://avatars1.githubusercontent.com/u/24612534?v=4","gravatar_id":"","url":"https://api.github.com/users/aragon","html_url":"https://github.com/aragon","followers_url":"https://api.github.com/users/aragon/followers","following_url":"https://api.github.com/users/aragon/following{/other_user}","gists_url":"https://api.github.com/users/aragon/gists{/gist_id}","starred_url":"https://api.github.com/users/aragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aragon/subscriptions","organizations_url":"https://api.github.com/users/aragon/orgs","repos_url":"https://api.github.com/users/aragon/repos","events_url":"https://api.github.com/users/aragon/events{/privacy}","received_events_url":"https://api.github.com/users/aragon/received_events","type":"Organization","site_admin":false},"repo":{"id":98191281,"node_id":"MDEwOlJlcG9zaXRvcnk5ODE5MTI4MQ==","name":"aragon.js","full_name":"aragon/aragon.js","owner":{"login":"aragon","id":24612534,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NjEyNTM0","avatar_url":"https://avatars1.githubusercontent.com/u/24612534?v=4","gravatar_id":"","url":"https://api.github.com/users/aragon","html_url":"https://github.com/aragon","followers_url":"https://api.github.com/users/aragon/followers","following_url":"https://api.github.com/users/aragon/following{/other_user}","gists_url":"https://api.github.com/users/aragon/gists{/gist_id}","starred_url":"https://api.github.com/users/aragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aragon/subscriptions","organizations_url":"https://api.github.com/users/aragon/orgs","repos_url":"https://api.github.com/users/aragon/repos","events_url":"https://api.github.com/users/aragon/events{/privacy}","received_events_url":"https://api.github.com/users/aragon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aragon/aragon.js","description":"A JavaScript library for interacting with Aragon","fork":false,"url":"https://api.github.com/repos/aragon/aragon.js","forks_url":"https://api.github.com/repos/aragon/aragon.js/forks","keys_url":"https://api.github.com/repos/aragon/aragon.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aragon/aragon.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aragon/aragon.js/teams","hooks_url":"https://api.github.com/repos/aragon/aragon.js/hooks","issue_events_url":"https://api.github.com/repos/aragon/aragon.js/issues/events{/number}","events_url":"https://api.github.com/repos/aragon/aragon.js/events","assignees_url":"https://api.github.com/repos/aragon/aragon.js/assignees{/user}","branches_url":"https://api.github.com/repos/aragon/aragon.js/branches{/branch}","tags_url":"https://api.github.com/repos/aragon/aragon.js/tags","blobs_url":"https://api.github.com/repos/aragon/aragon.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aragon/aragon.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aragon/aragon.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/aragon/aragon.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aragon/aragon.js/statuses/{sha}","languages_url":"https://api.github.com/repos/aragon/aragon.js/languages","stargazers_url":"https://api.github.com/repos/aragon/aragon.js/stargazers","contributors_url":"https://api.github.com/repos/aragon/aragon.js/contributors","subscribers_url":"https://api.github.com/repos/aragon/aragon.js/subscribers","subscription_url":"https://api.github.com/repos/aragon/aragon.js/subscription","commits_url":"https://api.github.com/repos/aragon/aragon.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/aragon/aragon.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/aragon/aragon.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/aragon/aragon.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/aragon/aragon.js/contents/{+path}","compare_url":"https://api.github.com/repos/aragon/aragon.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aragon/aragon.js/merges","archive_url":"https://api.github.com/repos/aragon/aragon.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aragon/aragon.js/downloads","issues_url":"https://api.github.com/repos/aragon/aragon.js/issues{/number}","pulls_url":"https://api.github.com/repos/aragon/aragon.js/pulls{/number}","milestones_url":"https://api.github.com/repos/aragon/aragon.js/milestones{/number}","notifications_url":"https://api.github.com/repos/aragon/aragon.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aragon/aragon.js/labels{/name}","releases_url":"https://api.github.com/repos/aragon/aragon.js/releases{/id}","deployments_url":"https://api.github.com/repos/aragon/aragon.js/deployments","created_at":"2017-07-24T13:03:16Z","updated_at":"2018-08-27T17:01:22Z","pushed_at":"2018-08-28T15:24:17Z","git_url":"git://github.com/aragon/aragon.js.git","ssh_url":"git@github.com:aragon/aragon.js.git","clone_url":"https://github.com/aragon/aragon.js.git","svn_url":"https://github.com/aragon/aragon.js","homepage":"https://aragon.one","size":1578,"stargazers_count":51,"watchers_count":51,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":20,"open_issues":44,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aragon/aragon.js/pulls/138"},"html":{"href":"https://github.com/aragon/aragon.js/pull/138"},"issue":{"href":"https://api.github.com/repos/aragon/aragon.js/issues/138"},"comments":{"href":"https://api.github.com/repos/aragon/aragon.js/issues/138/comments"},"review_comments":{"href":"https://api.github.com/repos/aragon/aragon.js/pulls/138/comments"},"review_comment":{"href":"https://api.github.com/repos/aragon/aragon.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aragon/aragon.js/pulls/138/commits"},"statuses":{"href":"https://api.github.com/repos/aragon/aragon.js/statuses/a3376e586d598ab7bf6715e2dd559a1bc0b61178"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"sohkai"}}