{"action":"opened","issue":{"url":"https://api.github.com/repos/react-native-training/react-native-elements/issues/1063","repository_url":"https://api.github.com/repos/react-native-training/react-native-elements","labels_url":"https://api.github.com/repos/react-native-training/react-native-elements/issues/1063/labels{/name}","comments_url":"https://api.github.com/repos/react-native-training/react-native-elements/issues/1063/comments","events_url":"https://api.github.com/repos/react-native-training/react-native-elements/issues/1063/events","html_url":"https://github.com/react-native-training/react-native-elements/issues/1063","id":310631646,"number":1063,"title":"Button: Inconsistency about button's disabled style","user":{"login":"mhsekhavat","id":767425,"avatar_url":"https://avatars1.githubusercontent.com/u/767425?v=4","gravatar_id":"","url":"https://api.github.com/users/mhsekhavat","html_url":"https://github.com/mhsekhavat","followers_url":"https://api.github.com/users/mhsekhavat/followers","following_url":"https://api.github.com/users/mhsekhavat/following{/other_user}","gists_url":"https://api.github.com/users/mhsekhavat/gists{/gist_id}","starred_url":"https://api.github.com/users/mhsekhavat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhsekhavat/subscriptions","organizations_url":"https://api.github.com/users/mhsekhavat/orgs","repos_url":"https://api.github.com/users/mhsekhavat/repos","events_url":"https://api.github.com/users/mhsekhavat/events{/privacy}","received_events_url":"https://api.github.com/users/mhsekhavat/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-02T22:25:38Z","updated_at":"2018-04-02T22:25:38Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"`Button` component renders a `<ViewComponent/>` and a `<Text/>` inside it. For a `Button` with `disabled` attribute, `styles.disabled` overrides `buttonStyle` in styles of `ViewComponent` but `styles.disabledTitle` does not override `titleStyle` in styles of `Text`. \r\n\r\nCommit https://github.com/react-native-training/react-native-elements/commit/5af9b15a16935440aa25db6a03d53a80e5be197a has moved `buttonStyle` after `styles.disabled` but `titleStyle` is still before `styles.disabledTitle`:\r\n\r\nhttps://github.com/react-native-training/react-native-elements/blob/1c1561c00cdfeb6e554388707bc1c44e6097b646/src/buttons/Button.js#L72-L74\r\n\r\nhttps://github.com/react-native-training/react-native-elements/blob/1c1561c00cdfeb6e554388707bc1c44e6097b646/src/buttons/Button.js#L100-L101\r\n\r\nThis causes inconsistency in a component like this:\r\n```jsx\r\n<Button buttonStyle={{backgroundColor:'black', color:'white'}} disabled={true} />\r\n```\r\nThis component will have black background but gray text color."}}
{"actor":{"display_login":"mhsekhavat"}}