{"action":"opened","number":270,"pull_request":{"url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/pulls/270","id":195232594,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MjMyNTk0","html_url":"https://github.com/xcode-project-manager/xcodeproj/pull/270","diff_url":"https://github.com/xcode-project-manager/xcodeproj/pull/270.diff","patch_url":"https://github.com/xcode-project-manager/xcodeproj/pull/270.patch","issue_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/issues/270","number":270,"state":"open","locked":false,"title":"Generate references before saving","user":{"login":"pepibumur","id":663605,"node_id":"MDQ6VXNlcjY2MzYwNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/663605?v=4","gravatar_id":"","url":"https://api.github.com/users/pepibumur","html_url":"https://github.com/pepibumur","followers_url":"https://api.github.com/users/pepibumur/followers","following_url":"https://api.github.com/users/pepibumur/following{/other_user}","gists_url":"https://api.github.com/users/pepibumur/gists{/gist_id}","starred_url":"https://api.github.com/users/pepibumur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pepibumur/subscriptions","organizations_url":"https://api.github.com/users/pepibumur/orgs","repos_url":"https://api.github.com/users/pepibumur/repos","events_url":"https://api.github.com/users/pepibumur/events{/privacy}","received_events_url":"https://api.github.com/users/pepibumur/received_events","type":"User","site_admin":false},"body":"### Short description 📝\r\nWhen developers interact with the project by adding new objects, those are added with non-deterministic temporary references. Generating non-deterministic references for generated projects every time causes Xcode to recompile things all the time.\r\n\r\n### Solution 📦\r\nAdd a new utility, `ReferenceGenerator` that is used by the encoder to generate deterministic references for those objects that have temporary references.\r\n\r\n### Implementation 👩‍💻👨‍💻\r\n- [ ] Implement `ReferenceGenerator`\r\n- [x] Update `PBXProjEncoder` to use it.\r\n- [ ] Add some tests that ensure that all project objects get their reference generated before saving. We can implement the test to use existing projects, as we are already doing to validate the parsing logic.\r\n","created_at":"2018-06-15T16:57:45Z","updated_at":"2018-06-15T16:57:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"pepibumur","id":663605,"node_id":"MDQ6VXNlcjY2MzYwNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/663605?v=4","gravatar_id":"","url":"https://api.github.com/users/pepibumur","html_url":"https://github.com/pepibumur","followers_url":"https://api.github.com/users/pepibumur/followers","following_url":"https://api.github.com/users/pepibumur/following{/other_user}","gists_url":"https://api.github.com/users/pepibumur/gists{/gist_id}","starred_url":"https://api.github.com/users/pepibumur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pepibumur/subscriptions","organizations_url":"https://api.github.com/users/pepibumur/orgs","repos_url":"https://api.github.com/users/pepibumur/repos","events_url":"https://api.github.com/users/pepibumur/events{/privacy}","received_events_url":"https://api.github.com/users/pepibumur/received_events","type":"User","site_admin":false},"assignees":[{"login":"pepibumur","id":663605,"node_id":"MDQ6VXNlcjY2MzYwNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/663605?v=4","gravatar_id":"","url":"https://api.github.com/users/pepibumur","html_url":"https://github.com/pepibumur","followers_url":"https://api.github.com/users/pepibumur/followers","following_url":"https://api.github.com/users/pepibumur/following{/other_user}","gists_url":"https://api.github.com/users/pepibumur/gists{/gist_id}","starred_url":"https://api.github.com/users/pepibumur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pepibumur/subscriptions","organizations_url":"https://api.github.com/users/pepibumur/orgs","repos_url":"https://api.github.com/users/pepibumur/repos","events_url":"https://api.github.com/users/pepibumur/events{/privacy}","received_events_url":"https://api.github.com/users/pepibumur/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/pulls/270/commits","review_comments_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/pulls/270/comments","review_comment_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/issues/270/comments","statuses_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/statuses/7626d37de936aa4c14396cb31dfd648a20dbe905","head":{"label":"xcode-project-manager:reference-generator","ref":"reference-generator","sha":"7626d37de936aa4c14396cb31dfd648a20dbe905","user":{"login":"xcode-project-manager","id":38419084,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NDE5MDg0","avatar_url":"https://avatars2.githubusercontent.com/u/38419084?v=4","gravatar_id":"","url":"https://api.github.com/users/xcode-project-manager","html_url":"https://github.com/xcode-project-manager","followers_url":"https://api.github.com/users/xcode-project-manager/followers","following_url":"https://api.github.com/users/xcode-project-manager/following{/other_user}","gists_url":"https://api.github.com/users/xcode-project-manager/gists{/gist_id}","starred_url":"https://api.github.com/users/xcode-project-manager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcode-project-manager/subscriptions","organizations_url":"https://api.github.com/users/xcode-project-manager/orgs","repos_url":"https://api.github.com/users/xcode-project-manager/repos","events_url":"https://api.github.com/users/xcode-project-manager/events{/privacy}","received_events_url":"https://api.github.com/users/xcode-project-manager/received_events","type":"Organization","site_admin":false},"repo":{"id":93763457,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzc2MzQ1Nw==","name":"xcodeproj","full_name":"xcode-project-manager/xcodeproj","owner":{"login":"xcode-project-manager","id":38419084,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NDE5MDg0","avatar_url":"https://avatars2.githubusercontent.com/u/38419084?v=4","gravatar_id":"","url":"https://api.github.com/users/xcode-project-manager","html_url":"https://github.com/xcode-project-manager","followers_url":"https://api.github.com/users/xcode-project-manager/followers","following_url":"https://api.github.com/users/xcode-project-manager/following{/other_user}","gists_url":"https://api.github.com/users/xcode-project-manager/gists{/gist_id}","starred_url":"https://api.github.com/users/xcode-project-manager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcode-project-manager/subscriptions","organizations_url":"https://api.github.com/users/xcode-project-manager/orgs","repos_url":"https://api.github.com/users/xcode-project-manager/repos","events_url":"https://api.github.com/users/xcode-project-manager/events{/privacy}","received_events_url":"https://api.github.com/users/xcode-project-manager/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xcode-project-manager/xcodeproj","description":" 📝 Read, update and write your Xcode projects","fork":false,"url":"https://api.github.com/repos/xcode-project-manager/xcodeproj","forks_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/forks","keys_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/teams","hooks_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/hooks","issue_events_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/issues/events{/number}","events_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/events","assignees_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/assignees{/user}","branches_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/branches{/branch}","tags_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/tags","blobs_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/git/refs{/sha}","trees_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/statuses/{sha}","languages_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/languages","stargazers_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/stargazers","contributors_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/contributors","subscribers_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/subscribers","subscription_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/subscription","commits_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/commits{/sha}","git_commits_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/git/commits{/sha}","comments_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/comments{/number}","issue_comment_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/issues/comments{/number}","contents_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/contents/{+path}","compare_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/merges","archive_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/downloads","issues_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/issues{/number}","pulls_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/pulls{/number}","milestones_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/milestones{/number}","notifications_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/labels{/name}","releases_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/releases{/id}","deployments_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/deployments","created_at":"2017-06-08T15:12:40Z","updated_at":"2018-06-15T14:59:06Z","pushed_at":"2018-06-15T16:54:35Z","git_url":"git://github.com/xcode-project-manager/xcodeproj.git","ssh_url":"git@github.com:xcode-project-manager/xcodeproj.git","clone_url":"https://github.com/xcode-project-manager/xcodeproj.git","svn_url":"https://github.com/xcode-project-manager/xcodeproj","homepage":"https://xcbuddy.github.io/xcodeproj/","size":12852,"stargazers_count":657,"watchers_count":657,"language":"Swift","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":62,"open_issues":11,"watchers":657,"default_branch":"master"}},"base":{"label":"xcode-project-manager:master","ref":"master","sha":"70e455761d87ca6b5acd8482622635b86f5f42bf","user":{"login":"xcode-project-manager","id":38419084,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NDE5MDg0","avatar_url":"https://avatars2.githubusercontent.com/u/38419084?v=4","gravatar_id":"","url":"https://api.github.com/users/xcode-project-manager","html_url":"https://github.com/xcode-project-manager","followers_url":"https://api.github.com/users/xcode-project-manager/followers","following_url":"https://api.github.com/users/xcode-project-manager/following{/other_user}","gists_url":"https://api.github.com/users/xcode-project-manager/gists{/gist_id}","starred_url":"https://api.github.com/users/xcode-project-manager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcode-project-manager/subscriptions","organizations_url":"https://api.github.com/users/xcode-project-manager/orgs","repos_url":"https://api.github.com/users/xcode-project-manager/repos","events_url":"https://api.github.com/users/xcode-project-manager/events{/privacy}","received_events_url":"https://api.github.com/users/xcode-project-manager/received_events","type":"Organization","site_admin":false},"repo":{"id":93763457,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzc2MzQ1Nw==","name":"xcodeproj","full_name":"xcode-project-manager/xcodeproj","owner":{"login":"xcode-project-manager","id":38419084,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NDE5MDg0","avatar_url":"https://avatars2.githubusercontent.com/u/38419084?v=4","gravatar_id":"","url":"https://api.github.com/users/xcode-project-manager","html_url":"https://github.com/xcode-project-manager","followers_url":"https://api.github.com/users/xcode-project-manager/followers","following_url":"https://api.github.com/users/xcode-project-manager/following{/other_user}","gists_url":"https://api.github.com/users/xcode-project-manager/gists{/gist_id}","starred_url":"https://api.github.com/users/xcode-project-manager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcode-project-manager/subscriptions","organizations_url":"https://api.github.com/users/xcode-project-manager/orgs","repos_url":"https://api.github.com/users/xcode-project-manager/repos","events_url":"https://api.github.com/users/xcode-project-manager/events{/privacy}","received_events_url":"https://api.github.com/users/xcode-project-manager/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xcode-project-manager/xcodeproj","description":" 📝 Read, update and write your Xcode projects","fork":false,"url":"https://api.github.com/repos/xcode-project-manager/xcodeproj","forks_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/forks","keys_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/teams","hooks_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/hooks","issue_events_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/issues/events{/number}","events_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/events","assignees_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/assignees{/user}","branches_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/branches{/branch}","tags_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/tags","blobs_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/git/refs{/sha}","trees_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/statuses/{sha}","languages_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/languages","stargazers_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/stargazers","contributors_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/contributors","subscribers_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/subscribers","subscription_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/subscription","commits_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/commits{/sha}","git_commits_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/git/commits{/sha}","comments_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/comments{/number}","issue_comment_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/issues/comments{/number}","contents_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/contents/{+path}","compare_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/merges","archive_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/downloads","issues_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/issues{/number}","pulls_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/pulls{/number}","milestones_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/milestones{/number}","notifications_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/labels{/name}","releases_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/releases{/id}","deployments_url":"https://api.github.com/repos/xcode-project-manager/xcodeproj/deployments","created_at":"2017-06-08T15:12:40Z","updated_at":"2018-06-15T14:59:06Z","pushed_at":"2018-06-15T16:54:35Z","git_url":"git://github.com/xcode-project-manager/xcodeproj.git","ssh_url":"git@github.com:xcode-project-manager/xcodeproj.git","clone_url":"https://github.com/xcode-project-manager/xcodeproj.git","svn_url":"https://github.com/xcode-project-manager/xcodeproj","homepage":"https://xcbuddy.github.io/xcodeproj/","size":12852,"stargazers_count":657,"watchers_count":657,"language":"Swift","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":62,"open_issues":11,"watchers":657,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xcode-project-manager/xcodeproj/pulls/270"},"html":{"href":"https://github.com/xcode-project-manager/xcodeproj/pull/270"},"issue":{"href":"https://api.github.com/repos/xcode-project-manager/xcodeproj/issues/270"},"comments":{"href":"https://api.github.com/repos/xcode-project-manager/xcodeproj/issues/270/comments"},"review_comments":{"href":"https://api.github.com/repos/xcode-project-manager/xcodeproj/pulls/270/comments"},"review_comment":{"href":"https://api.github.com/repos/xcode-project-manager/xcodeproj/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xcode-project-manager/xcodeproj/pulls/270/commits"},"statuses":{"href":"https://api.github.com/repos/xcode-project-manager/xcodeproj/statuses/7626d37de936aa4c14396cb31dfd648a20dbe905"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":232,"deletions":0,"changed_files":3}}
{"actor":{"display_login":"pepibumur"}}