{"action":"created","issue":{"url":"https://api.github.com/repos/gammapy/gammapy/issues/1844","repository_url":"https://api.github.com/repos/gammapy/gammapy","labels_url":"https://api.github.com/repos/gammapy/gammapy/issues/1844/labels{/name}","comments_url":"https://api.github.com/repos/gammapy/gammapy/issues/1844/comments","events_url":"https://api.github.com/repos/gammapy/gammapy/issues/1844/events","html_url":"https://github.com/gammapy/gammapy/issues/1844","id":366068953,"node_id":"MDU6SXNzdWUzNjYwNjg5NTM=","number":1844,"title":"Optional filed ONTIME in the observation index table","user":{"login":"tony32lin","id":6865696,"node_id":"MDQ6VXNlcjY4NjU2OTY=","avatar_url":"https://avatars0.githubusercontent.com/u/6865696?v=4","gravatar_id":"","url":"https://api.github.com/users/tony32lin","html_url":"https://github.com/tony32lin","followers_url":"https://api.github.com/users/tony32lin/followers","following_url":"https://api.github.com/users/tony32lin/following{/other_user}","gists_url":"https://api.github.com/users/tony32lin/gists{/gist_id}","starred_url":"https://api.github.com/users/tony32lin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tony32lin/subscriptions","organizations_url":"https://api.github.com/users/tony32lin/orgs","repos_url":"https://api.github.com/users/tony32lin/repos","events_url":"https://api.github.com/users/tony32lin/events{/privacy}","received_events_url":"https://api.github.com/users/tony32lin/received_events","type":"User","site_admin":false},"labels":[{"id":39740769,"node_id":"MDU6TGFiZWwzOTc0MDc2OQ==","url":"https://api.github.com/repos/gammapy/gammapy/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":{"login":"dcfidalgo","id":15979778,"node_id":"MDQ6VXNlcjE1OTc5Nzc4","avatar_url":"https://avatars2.githubusercontent.com/u/15979778?v=4","gravatar_id":"","url":"https://api.github.com/users/dcfidalgo","html_url":"https://github.com/dcfidalgo","followers_url":"https://api.github.com/users/dcfidalgo/followers","following_url":"https://api.github.com/users/dcfidalgo/following{/other_user}","gists_url":"https://api.github.com/users/dcfidalgo/gists{/gist_id}","starred_url":"https://api.github.com/users/dcfidalgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcfidalgo/subscriptions","organizations_url":"https://api.github.com/users/dcfidalgo/orgs","repos_url":"https://api.github.com/users/dcfidalgo/repos","events_url":"https://api.github.com/users/dcfidalgo/events{/privacy}","received_events_url":"https://api.github.com/users/dcfidalgo/received_events","type":"User","site_admin":false},"assignees":[{"login":"dcfidalgo","id":15979778,"node_id":"MDQ6VXNlcjE1OTc5Nzc4","avatar_url":"https://avatars2.githubusercontent.com/u/15979778?v=4","gravatar_id":"","url":"https://api.github.com/users/dcfidalgo","html_url":"https://github.com/dcfidalgo","followers_url":"https://api.github.com/users/dcfidalgo/followers","following_url":"https://api.github.com/users/dcfidalgo/following{/other_user}","gists_url":"https://api.github.com/users/dcfidalgo/gists{/gist_id}","starred_url":"https://api.github.com/users/dcfidalgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcfidalgo/subscriptions","organizations_url":"https://api.github.com/users/dcfidalgo/orgs","repos_url":"https://api.github.com/users/dcfidalgo/repos","events_url":"https://api.github.com/users/dcfidalgo/events{/privacy}","received_events_url":"https://api.github.com/users/dcfidalgo/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/gammapy/gammapy/milestones/12","html_url":"https://github.com/gammapy/gammapy/milestone/12","labels_url":"https://api.github.com/repos/gammapy/gammapy/milestones/12/labels","id":3288050,"node_id":"MDk6TWlsZXN0b25lMzI4ODA1MA==","number":12,"title":"0.9","description":"","creator":{"login":"cdeil","id":852409,"node_id":"MDQ6VXNlcjg1MjQwOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/852409?v=4","gravatar_id":"","url":"https://api.github.com/users/cdeil","html_url":"https://github.com/cdeil","followers_url":"https://api.github.com/users/cdeil/followers","following_url":"https://api.github.com/users/cdeil/following{/other_user}","gists_url":"https://api.github.com/users/cdeil/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeil/subscriptions","organizations_url":"https://api.github.com/users/cdeil/orgs","repos_url":"https://api.github.com/users/cdeil/repos","events_url":"https://api.github.com/users/cdeil/events{/privacy}","received_events_url":"https://api.github.com/users/cdeil/received_events","type":"User","site_admin":false},"open_issues":105,"closed_issues":38,"state":"open","created_at":"2018-04-23T07:23:54Z","updated_at":"2018-10-02T20:35:57Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-10-02T20:35:19Z","updated_at":"2018-10-02T20:45:56Z","closed_at":null,"author_association":"NONE","body":"According to the current version of DL3 spec(https://github.com/open-gamma-ray-astro/gamma-astro-data-formats), the ONTIME filed in observation index table is listed as optional yet it's been used by gammapy.  More details can be seen at open-gamma-ray-astro/gamma-astro-data-formats/issues/131.\r\n\r\nIs this something that is planned to be changed in gammapy in the future?"},"comment":{"url":"https://api.github.com/repos/gammapy/gammapy/issues/comments/426423885","html_url":"https://github.com/gammapy/gammapy/issues/1844#issuecomment-426423885","issue_url":"https://api.github.com/repos/gammapy/gammapy/issues/1844","id":426423885,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjQyMzg4NQ==","user":{"login":"cdeil","id":852409,"node_id":"MDQ6VXNlcjg1MjQwOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/852409?v=4","gravatar_id":"","url":"https://api.github.com/users/cdeil","html_url":"https://github.com/cdeil","followers_url":"https://api.github.com/users/cdeil/followers","following_url":"https://api.github.com/users/cdeil/following{/other_user}","gists_url":"https://api.github.com/users/cdeil/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeil/subscriptions","organizations_url":"https://api.github.com/users/cdeil/orgs","repos_url":"https://api.github.com/users/cdeil/repos","events_url":"https://api.github.com/users/cdeil/events{/privacy}","received_events_url":"https://api.github.com/users/cdeil/received_events","type":"User","site_admin":false},"created_at":"2018-10-02T20:45:56Z","updated_at":"2018-10-02T20:45:56Z","author_association":"MEMBER","body":"@tony32lin - Thanks for reporting the issue!\r\n\r\nMaybe short-term we should change this line to use the required columns `TSTOP` and `TSTART` instead of the optional column `ONTIME` to avoid the issue?\r\nhttps://github.com/gammapy/gammapy/blob/5a9027d99f814dafcd8239cb65add438528c803b/gammapy/data/observations.py#L253\r\n\r\nAlthough this doesn't help much, because `DEADC` and `LIVETIME` are also optional in the obs index table, so a similar issue would likely appear here:\r\nhttps://github.com/gammapy/gammapy/blob/5a9027d99f814dafcd8239cb65add438528c803b/gammapy/data/observations.py#L264\r\n\r\nReally the solution is probably not to rely on info from the obs index table at all, but to read the info from the \"data\" files directly, i.e. mostly from the EVENTS header at the moment, and possibly a TECH3 HDU in the future.\r\n\r\n@dcfidalgo @cboisson @registerrier - let's discuss tomorrow, to have a clear picture how the observation classes should work for now (irrespective of the fact that we'll proably have to change them again in a year once things become clear in CTA)."}}
{"actor":{"display_login":"cdeil"}}