{"action":"created","comment":{"url":"https://api.github.com/repos/tendermint/tendermint/pulls/comments/209058653","pull_request_review_id":145000608,"id":209058653,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTA1ODY1Mw==","diff_hunk":"@@ -539,13 +539,25 @@ func (voteSet *VoteSet) MakeCommit() *Commit {\n \tif voteSet.maj23 == nil {\n \t\tcmn.PanicSanity(\"Cannot MakeCommit() unless a blockhash has +2/3\")\n \t}\n+\tblockID := *voteSet.maj23\n \n \t// For every validator, get the precommit\n \tvotesCopy := make([]*Vote, len(voteSet.votes))\n \tcopy(votesCopy, voteSet.votes)\n+\tprecommits := make([]*CommitSig, len(voteSet.votes))","path":"types/vote_set.go","position":9,"original_position":9,"commit_id":"b202edca9b42e5b457556d418300f19c0b0d0608","original_commit_id":"7065fd213c977b211a1e070b714b3fe019a8199b","user":{"login":"jlandrews","id":20493822,"node_id":"MDQ6VXNlcjIwNDkzODIy","avatar_url":"https://avatars1.githubusercontent.com/u/20493822?v=4","gravatar_id":"","url":"https://api.github.com/users/jlandrews","html_url":"https://github.com/jlandrews","followers_url":"https://api.github.com/users/jlandrews/followers","following_url":"https://api.github.com/users/jlandrews/following{/other_user}","gists_url":"https://api.github.com/users/jlandrews/gists{/gist_id}","starred_url":"https://api.github.com/users/jlandrews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlandrews/subscriptions","organizations_url":"https://api.github.com/users/jlandrews/orgs","repos_url":"https://api.github.com/users/jlandrews/repos","events_url":"https://api.github.com/users/jlandrews/events{/privacy}","received_events_url":"https://api.github.com/users/jlandrews/received_events","type":"User","site_admin":false},"body":"It is ok to have some precommits be `nil`. We use the full array so that the `CommitSigs` have matching indices to the validators who signed them. Then when verifying we just skip any that are `nil`. I imagine we could make this work without any `nil` values by using the bit array and counting to determine indices at verification time, but I don't know if that would end up using less total space when serialized. ","created_at":"2018-08-09T19:55:50Z","updated_at":"2018-08-09T19:55:51Z","html_url":"https://github.com/tendermint/tendermint/pull/2179#discussion_r209058653","pull_request_url":"https://api.github.com/repos/tendermint/tendermint/pulls/2179","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/comments/209058653"},"html":{"href":"https://github.com/tendermint/tendermint/pull/2179#discussion_r209058653"},"pull_request":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/2179"}},"in_reply_to_id":208807854},"pull_request":{"url":"https://api.github.com/repos/tendermint/tendermint/pulls/2179","id":206853821,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2ODUzODIx","html_url":"https://github.com/tendermint/tendermint/pull/2179","diff_url":"https://github.com/tendermint/tendermint/pull/2179.diff","patch_url":"https://github.com/tendermint/tendermint/pull/2179.patch","issue_url":"https://api.github.com/repos/tendermint/tendermint/issues/2179","number":2179,"state":"open","locked":false,"title":"Reduce Commit to Signatures and Timestamps","user":{"login":"jlandrews","id":20493822,"node_id":"MDQ6VXNlcjIwNDkzODIy","avatar_url":"https://avatars1.githubusercontent.com/u/20493822?v=4","gravatar_id":"","url":"https://api.github.com/users/jlandrews","html_url":"https://github.com/jlandrews","followers_url":"https://api.github.com/users/jlandrews/followers","following_url":"https://api.github.com/users/jlandrews/following{/other_user}","gists_url":"https://api.github.com/users/jlandrews/gists{/gist_id}","starred_url":"https://api.github.com/users/jlandrews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlandrews/subscriptions","organizations_url":"https://api.github.com/users/jlandrews/orgs","repos_url":"https://api.github.com/users/jlandrews/repos","events_url":"https://api.github.com/users/jlandrews/events{/privacy}","received_events_url":"https://api.github.com/users/jlandrews/received_events","type":"User","site_admin":false},"body":"<!-- Thanks for filing a PR! Before hitting the button, please check the following items.-->\r\nCloses #1648 \r\n* [x] Updated all relevant documentation in docs\r\n* [x] Updated all code comments where relevant\r\n* [x] Wrote tests\r\n* [x] Updated CHANGELOG_PENDING.md\r\n","created_at":"2018-08-07T23:28:20Z","updated_at":"2018-08-09T19:55:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea4080bdd4a6dc6ba40b883f905d9a4eea3bf0ea","assignee":null,"assignees":[],"requested_reviewers":[{"login":"xla","id":1585,"node_id":"MDQ6VXNlcjE1ODU=","avatar_url":"https://avatars1.githubusercontent.com/u/1585?v=4","gravatar_id":"","url":"https://api.github.com/users/xla","html_url":"https://github.com/xla","followers_url":"https://api.github.com/users/xla/followers","following_url":"https://api.github.com/users/xla/following{/other_user}","gists_url":"https://api.github.com/users/xla/gists{/gist_id}","starred_url":"https://api.github.com/users/xla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xla/subscriptions","organizations_url":"https://api.github.com/users/xla/orgs","repos_url":"https://api.github.com/users/xla/repos","events_url":"https://api.github.com/users/xla/events{/privacy}","received_events_url":"https://api.github.com/users/xla/received_events","type":"User","site_admin":false},{"login":"ebuchman","id":2300911,"node_id":"MDQ6VXNlcjIzMDA5MTE=","avatar_url":"https://avatars3.githubusercontent.com/u/2300911?v=4","gravatar_id":"","url":"https://api.github.com/users/ebuchman","html_url":"https://github.com/ebuchman","followers_url":"https://api.github.com/users/ebuchman/followers","following_url":"https://api.github.com/users/ebuchman/following{/other_user}","gists_url":"https://api.github.com/users/ebuchman/gists{/gist_id}","starred_url":"https://api.github.com/users/ebuchman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebuchman/subscriptions","organizations_url":"https://api.github.com/users/ebuchman/orgs","repos_url":"https://api.github.com/users/ebuchman/repos","events_url":"https://api.github.com/users/ebuchman/events{/privacy}","received_events_url":"https://api.github.com/users/ebuchman/received_events","type":"User","site_admin":false},{"login":"zramsay","id":8304391,"node_id":"MDQ6VXNlcjgzMDQzOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/8304391?v=4","gravatar_id":"","url":"https://api.github.com/users/zramsay","html_url":"https://github.com/zramsay","followers_url":"https://api.github.com/users/zramsay/followers","following_url":"https://api.github.com/users/zramsay/following{/other_user}","gists_url":"https://api.github.com/users/zramsay/gists{/gist_id}","starred_url":"https://api.github.com/users/zramsay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zramsay/subscriptions","organizations_url":"https://api.github.com/users/zramsay/orgs","repos_url":"https://api.github.com/users/zramsay/repos","events_url":"https://api.github.com/users/zramsay/events{/privacy}","received_events_url":"https://api.github.com/users/zramsay/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1007048207,"node_id":"MDU6TGFiZWwxMDA3MDQ4MjA3","url":"https://api.github.com/repos/tendermint/tendermint/labels/breaking","name":"breaking","color":"b60205","default":false},{"id":795907908,"node_id":"MDU6TGFiZWw3OTU5MDc5MDg=","url":"https://api.github.com/repos/tendermint/tendermint/labels/consensus","name":"consensus","color":"fafad2","default":false},{"id":789775642,"node_id":"MDU6TGFiZWw3ODk3NzU2NDI=","url":"https://api.github.com/repos/tendermint/tendermint/labels/perf","name":"perf","color":"fafad2","default":false},{"id":1007052408,"node_id":"MDU6TGFiZWwxMDA3MDUyNDA4","url":"https://api.github.com/repos/tendermint/tendermint/labels/protocol","name":"protocol","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tendermint/tendermint/pulls/2179/commits","review_comments_url":"https://api.github.com/repos/tendermint/tendermint/pulls/2179/comments","review_comment_url":"https://api.github.com/repos/tendermint/tendermint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tendermint/tendermint/issues/2179/comments","statuses_url":"https://api.github.com/repos/tendermint/tendermint/statuses/b202edca9b42e5b457556d418300f19c0b0d0608","head":{"label":"tendermint:jlandrews/trim_commit","ref":"jlandrews/trim_commit","sha":"b202edca9b42e5b457556d418300f19c0b0d0608","user":{"login":"tendermint","id":7572940,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NzI5NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/7572940?v=4","gravatar_id":"","url":"https://api.github.com/users/tendermint","html_url":"https://github.com/tendermint","followers_url":"https://api.github.com/users/tendermint/followers","following_url":"https://api.github.com/users/tendermint/following{/other_user}","gists_url":"https://api.github.com/users/tendermint/gists{/gist_id}","starred_url":"https://api.github.com/users/tendermint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tendermint/subscriptions","organizations_url":"https://api.github.com/users/tendermint/orgs","repos_url":"https://api.github.com/users/tendermint/repos","events_url":"https://api.github.com/users/tendermint/events{/privacy}","received_events_url":"https://api.github.com/users/tendermint/received_events","type":"Organization","site_admin":false},"repo":{"id":19799491,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc5OTQ5MQ==","name":"tendermint","full_name":"tendermint/tendermint","owner":{"login":"tendermint","id":7572940,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NzI5NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/7572940?v=4","gravatar_id":"","url":"https://api.github.com/users/tendermint","html_url":"https://github.com/tendermint","followers_url":"https://api.github.com/users/tendermint/followers","following_url":"https://api.github.com/users/tendermint/following{/other_user}","gists_url":"https://api.github.com/users/tendermint/gists{/gist_id}","starred_url":"https://api.github.com/users/tendermint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tendermint/subscriptions","organizations_url":"https://api.github.com/users/tendermint/orgs","repos_url":"https://api.github.com/users/tendermint/repos","events_url":"https://api.github.com/users/tendermint/events{/privacy}","received_events_url":"https://api.github.com/users/tendermint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tendermint/tendermint","description":"⟁ Tendermint Core (BFT Consensus) in Go","fork":false,"url":"https://api.github.com/repos/tendermint/tendermint","forks_url":"https://api.github.com/repos/tendermint/tendermint/forks","keys_url":"https://api.github.com/repos/tendermint/tendermint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tendermint/tendermint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tendermint/tendermint/teams","hooks_url":"https://api.github.com/repos/tendermint/tendermint/hooks","issue_events_url":"https://api.github.com/repos/tendermint/tendermint/issues/events{/number}","events_url":"https://api.github.com/repos/tendermint/tendermint/events","assignees_url":"https://api.github.com/repos/tendermint/tendermint/assignees{/user}","branches_url":"https://api.github.com/repos/tendermint/tendermint/branches{/branch}","tags_url":"https://api.github.com/repos/tendermint/tendermint/tags","blobs_url":"https://api.github.com/repos/tendermint/tendermint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tendermint/tendermint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tendermint/tendermint/git/refs{/sha}","trees_url":"https://api.github.com/repos/tendermint/tendermint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tendermint/tendermint/statuses/{sha}","languages_url":"https://api.github.com/repos/tendermint/tendermint/languages","stargazers_url":"https://api.github.com/repos/tendermint/tendermint/stargazers","contributors_url":"https://api.github.com/repos/tendermint/tendermint/contributors","subscribers_url":"https://api.github.com/repos/tendermint/tendermint/subscribers","subscription_url":"https://api.github.com/repos/tendermint/tendermint/subscription","commits_url":"https://api.github.com/repos/tendermint/tendermint/commits{/sha}","git_commits_url":"https://api.github.com/repos/tendermint/tendermint/git/commits{/sha}","comments_url":"https://api.github.com/repos/tendermint/tendermint/comments{/number}","issue_comment_url":"https://api.github.com/repos/tendermint/tendermint/issues/comments{/number}","contents_url":"https://api.github.com/repos/tendermint/tendermint/contents/{+path}","compare_url":"https://api.github.com/repos/tendermint/tendermint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tendermint/tendermint/merges","archive_url":"https://api.github.com/repos/tendermint/tendermint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tendermint/tendermint/downloads","issues_url":"https://api.github.com/repos/tendermint/tendermint/issues{/number}","pulls_url":"https://api.github.com/repos/tendermint/tendermint/pulls{/number}","milestones_url":"https://api.github.com/repos/tendermint/tendermint/milestones{/number}","notifications_url":"https://api.github.com/repos/tendermint/tendermint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tendermint/tendermint/labels{/name}","releases_url":"https://api.github.com/repos/tendermint/tendermint/releases{/id}","deployments_url":"https://api.github.com/repos/tendermint/tendermint/deployments","created_at":"2014-05-14T23:21:35Z","updated_at":"2018-08-09T08:12:36Z","pushed_at":"2018-08-09T19:43:37Z","git_url":"git://github.com/tendermint/tendermint.git","ssh_url":"git@github.com:tendermint/tendermint.git","clone_url":"https://github.com/tendermint/tendermint.git","svn_url":"https://github.com/tendermint/tendermint","homepage":"https://tendermint.com/","size":50695,"stargazers_count":2141,"watchers_count":2141,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":490,"mirror_url":null,"archived":false,"open_issues_count":291,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":490,"open_issues":291,"watchers":2141,"default_branch":"master"}},"base":{"label":"tendermint:develop","ref":"develop","sha":"3c98cec2c28584c71f7019f8a8afc13dfc0e14af","user":{"login":"tendermint","id":7572940,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NzI5NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/7572940?v=4","gravatar_id":"","url":"https://api.github.com/users/tendermint","html_url":"https://github.com/tendermint","followers_url":"https://api.github.com/users/tendermint/followers","following_url":"https://api.github.com/users/tendermint/following{/other_user}","gists_url":"https://api.github.com/users/tendermint/gists{/gist_id}","starred_url":"https://api.github.com/users/tendermint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tendermint/subscriptions","organizations_url":"https://api.github.com/users/tendermint/orgs","repos_url":"https://api.github.com/users/tendermint/repos","events_url":"https://api.github.com/users/tendermint/events{/privacy}","received_events_url":"https://api.github.com/users/tendermint/received_events","type":"Organization","site_admin":false},"repo":{"id":19799491,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc5OTQ5MQ==","name":"tendermint","full_name":"tendermint/tendermint","owner":{"login":"tendermint","id":7572940,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NzI5NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/7572940?v=4","gravatar_id":"","url":"https://api.github.com/users/tendermint","html_url":"https://github.com/tendermint","followers_url":"https://api.github.com/users/tendermint/followers","following_url":"https://api.github.com/users/tendermint/following{/other_user}","gists_url":"https://api.github.com/users/tendermint/gists{/gist_id}","starred_url":"https://api.github.com/users/tendermint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tendermint/subscriptions","organizations_url":"https://api.github.com/users/tendermint/orgs","repos_url":"https://api.github.com/users/tendermint/repos","events_url":"https://api.github.com/users/tendermint/events{/privacy}","received_events_url":"https://api.github.com/users/tendermint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tendermint/tendermint","description":"⟁ Tendermint Core (BFT Consensus) in Go","fork":false,"url":"https://api.github.com/repos/tendermint/tendermint","forks_url":"https://api.github.com/repos/tendermint/tendermint/forks","keys_url":"https://api.github.com/repos/tendermint/tendermint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tendermint/tendermint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tendermint/tendermint/teams","hooks_url":"https://api.github.com/repos/tendermint/tendermint/hooks","issue_events_url":"https://api.github.com/repos/tendermint/tendermint/issues/events{/number}","events_url":"https://api.github.com/repos/tendermint/tendermint/events","assignees_url":"https://api.github.com/repos/tendermint/tendermint/assignees{/user}","branches_url":"https://api.github.com/repos/tendermint/tendermint/branches{/branch}","tags_url":"https://api.github.com/repos/tendermint/tendermint/tags","blobs_url":"https://api.github.com/repos/tendermint/tendermint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tendermint/tendermint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tendermint/tendermint/git/refs{/sha}","trees_url":"https://api.github.com/repos/tendermint/tendermint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tendermint/tendermint/statuses/{sha}","languages_url":"https://api.github.com/repos/tendermint/tendermint/languages","stargazers_url":"https://api.github.com/repos/tendermint/tendermint/stargazers","contributors_url":"https://api.github.com/repos/tendermint/tendermint/contributors","subscribers_url":"https://api.github.com/repos/tendermint/tendermint/subscribers","subscription_url":"https://api.github.com/repos/tendermint/tendermint/subscription","commits_url":"https://api.github.com/repos/tendermint/tendermint/commits{/sha}","git_commits_url":"https://api.github.com/repos/tendermint/tendermint/git/commits{/sha}","comments_url":"https://api.github.com/repos/tendermint/tendermint/comments{/number}","issue_comment_url":"https://api.github.com/repos/tendermint/tendermint/issues/comments{/number}","contents_url":"https://api.github.com/repos/tendermint/tendermint/contents/{+path}","compare_url":"https://api.github.com/repos/tendermint/tendermint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tendermint/tendermint/merges","archive_url":"https://api.github.com/repos/tendermint/tendermint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tendermint/tendermint/downloads","issues_url":"https://api.github.com/repos/tendermint/tendermint/issues{/number}","pulls_url":"https://api.github.com/repos/tendermint/tendermint/pulls{/number}","milestones_url":"https://api.github.com/repos/tendermint/tendermint/milestones{/number}","notifications_url":"https://api.github.com/repos/tendermint/tendermint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tendermint/tendermint/labels{/name}","releases_url":"https://api.github.com/repos/tendermint/tendermint/releases{/id}","deployments_url":"https://api.github.com/repos/tendermint/tendermint/deployments","created_at":"2014-05-14T23:21:35Z","updated_at":"2018-08-09T08:12:36Z","pushed_at":"2018-08-09T19:43:37Z","git_url":"git://github.com/tendermint/tendermint.git","ssh_url":"git@github.com:tendermint/tendermint.git","clone_url":"https://github.com/tendermint/tendermint.git","svn_url":"https://github.com/tendermint/tendermint","homepage":"https://tendermint.com/","size":50695,"stargazers_count":2141,"watchers_count":2141,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":490,"mirror_url":null,"archived":false,"open_issues_count":291,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":490,"open_issues":291,"watchers":2141,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/2179"},"html":{"href":"https://github.com/tendermint/tendermint/pull/2179"},"issue":{"href":"https://api.github.com/repos/tendermint/tendermint/issues/2179"},"comments":{"href":"https://api.github.com/repos/tendermint/tendermint/issues/2179/comments"},"review_comments":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/2179/comments"},"review_comment":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/2179/commits"},"statuses":{"href":"https://api.github.com/repos/tendermint/tendermint/statuses/b202edca9b42e5b457556d418300f19c0b0d0608"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jlandrews"}}