{"action":"created","issue":{"url":"https://api.github.com/repos/mumble-voip/mumble/issues/3328","repository_url":"https://api.github.com/repos/mumble-voip/mumble","labels_url":"https://api.github.com/repos/mumble-voip/mumble/issues/3328/labels{/name}","comments_url":"https://api.github.com/repos/mumble-voip/mumble/issues/3328/comments","events_url":"https://api.github.com/repos/mumble-voip/mumble/issues/3328/events","html_url":"https://github.com/mumble-voip/mumble/issues/3328","id":293168134,"number":3328,"title":"registerLocation should not depend on certificate C or registerHostname","user":{"login":"AlD","id":124690,"avatar_url":"https://avatars3.githubusercontent.com/u/124690?v=4","gravatar_id":"","url":"https://api.github.com/users/AlD","html_url":"https://github.com/AlD","followers_url":"https://api.github.com/users/AlD/followers","following_url":"https://api.github.com/users/AlD/following{/other_user}","gists_url":"https://api.github.com/users/AlD/gists{/gist_id}","starred_url":"https://api.github.com/users/AlD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlD/subscriptions","organizations_url":"https://api.github.com/users/AlD/orgs","repos_url":"https://api.github.com/users/AlD/repos","events_url":"https://api.github.com/users/AlD/events{/privacy}","received_events_url":"https://api.github.com/users/AlD/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-01-31T14:01:00Z","updated_at":"2018-02-09T22:30:33Z","closed_at":null,"author_association":"NONE","body":"Through #1784 a restriction on registerLocation was implemented, to only accept the provided value if at least 1 of these 2 conditions is true:\r\n* The TLD of `registerHostname` matches the country code provided in `registerLocation`.\r\n* The server certificate isn't self-signed and the certificate country (`C=`) matches `registerLocation`.\r\n\r\nIMHO this doesn't work very well in a number of situations:\r\n- FQDN doesn't have a CCTLD (e.g. _.info_) → Neither requirement can be fulfilled, so server has to be in-country.\r\n- Target language doesn't actually match server location, e.g. one may want to run a server for Icelandic speakers in Thailand.\r\n- Countries like Germany, Austria, Switzerland share a common language and the location of the server doesn't matter with regards to network latency, language or even culture.\r\n\r\nIt's not clear to me what these restrictions are trying to protect against in the first place. Latency is a much better indicator of server connectivity and I think the location categorization would work much better as a signal for target audience.\r\nAdditionally it's also trivial to circumvent these checks.\r\n\r\nSo, easiest solution would be to simply lift the restrictions on `registerLocation` and let people choose freely where their server should show up.\r\n\r\nFollowing the logic of separating signals for connectivity (for which we have Ping) and target audience, we could instead replace `registerLocation` with e.g. `registerLanguage` and show that in the server list. That's obviously a significantly larger effort with backwards compatibility implications, though.\r\n\r\n@klausenbusk, @hacst, appreciate your comments :)"},"comment":{"url":"https://api.github.com/repos/mumble-voip/mumble/issues/comments/364588208","html_url":"https://github.com/mumble-voip/mumble/issues/3328#issuecomment-364588208","issue_url":"https://api.github.com/repos/mumble-voip/mumble/issues/3328","id":364588208,"user":{"login":"mkrautz","id":36527,"avatar_url":"https://avatars0.githubusercontent.com/u/36527?v=4","gravatar_id":"","url":"https://api.github.com/users/mkrautz","html_url":"https://github.com/mkrautz","followers_url":"https://api.github.com/users/mkrautz/followers","following_url":"https://api.github.com/users/mkrautz/following{/other_user}","gists_url":"https://api.github.com/users/mkrautz/gists{/gist_id}","starred_url":"https://api.github.com/users/mkrautz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkrautz/subscriptions","organizations_url":"https://api.github.com/users/mkrautz/orgs","repos_url":"https://api.github.com/users/mkrautz/repos","events_url":"https://api.github.com/users/mkrautz/events{/privacy}","received_events_url":"https://api.github.com/users/mkrautz/received_events","type":"User","site_admin":false},"created_at":"2018-02-09T22:30:33Z","updated_at":"2018-02-09T22:30:33Z","author_association":"OWNER","body":"@Kissaki @davidebeatrici @Natenom @bontibon Thoughts? Should we drop these requirements? It seems like hacst and I are for."}}
{"actor":{"display_login":"mkrautz"}}