{"action":"created","comment":{"url":"https://api.github.com/repos/lightbend/reactive-lib/pulls/comments/216001280","pull_request_review_id":153396124,"id":216001280,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjAwMTI4MA==","diff_hunk":"@@ -24,24 +24,24 @@ import scala.concurrent.{ ExecutionContext, Future }\n class ClusterStatusCheck extends ReadinessCheck with HealthCheck {\n   def healthy(actorSystem: ExtendedActorSystem)(implicit ec: ExecutionContext): Future[Boolean] =\n     status(actorSystem) map {\n-      case MemberStatus.Joining  => true\n+      case MemberStatus.Joining => true\n       case MemberStatus.WeaklyUp => true\n-      case MemberStatus.Up       => true\n-      case MemberStatus.Leaving  => true\n-      case MemberStatus.Exiting  => true\n-      case MemberStatus.Down     => false\n-      case MemberStatus.Removed  => false\n+      case MemberStatus.Up => true\n+      case MemberStatus.Leaving => true\n+      case MemberStatus.Exiting => true\n+      case MemberStatus.Down => false\n+      case MemberStatus.Removed => false\n     }\n \n   def ready(actorSystem: ExtendedActorSystem)(implicit ec: ExecutionContext): Future[Boolean] =\n     status(actorSystem) map {\n-      case MemberStatus.Joining  => false\n+      case MemberStatus.Joining => false\n       case MemberStatus.WeaklyUp => true\n-      case MemberStatus.Up       => true\n-      case MemberStatus.Leaving  => false\n-      case MemberStatus.Exiting  => false\n-      case MemberStatus.Down     => false\n-      case MemberStatus.Removed  => false\n+      case MemberStatus.Up => true\n+      case MemberStatus.Leaving => false\n+      case MemberStatus.Exiting => false\n+      case MemberStatus.Down => false\n+      case MemberStatus.Removed => false\n     }","path":"akka-cluster-bootstrap/src/main/scala/com/lightbend/rp/akkaclusterbootstrap/ClusterStatusCheck.scala","position":34,"original_position":34,"commit_id":"b83bb8da5343e7831d33cfd5169feb0af3e52bf4","original_commit_id":"b83bb8da5343e7831d33cfd5169feb0af3e52bf4","user":{"login":"eed3si9n","id":184683,"node_id":"MDQ6VXNlcjE4NDY4Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/184683?v=4","gravatar_id":"","url":"https://api.github.com/users/eed3si9n","html_url":"https://github.com/eed3si9n","followers_url":"https://api.github.com/users/eed3si9n/followers","following_url":"https://api.github.com/users/eed3si9n/following{/other_user}","gists_url":"https://api.github.com/users/eed3si9n/gists{/gist_id}","starred_url":"https://api.github.com/users/eed3si9n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eed3si9n/subscriptions","organizations_url":"https://api.github.com/users/eed3si9n/orgs","repos_url":"https://api.github.com/users/eed3si9n/repos","events_url":"https://api.github.com/users/eed3si9n/events{/privacy}","received_events_url":"https://api.github.com/users/eed3si9n/received_events","type":"User","site_admin":false},"body":"I am committing what sbt-scalariform did. Not sure how @dwijnand got this to compile in 72e67d236bf6df49851f47ef7352002335ce7439.  ","created_at":"2018-09-07T15:38:10Z","updated_at":"2018-09-07T15:38:10Z","html_url":"https://github.com/lightbend/reactive-lib/pull/75#discussion_r216001280","pull_request_url":"https://api.github.com/repos/lightbend/reactive-lib/pulls/75","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/lightbend/reactive-lib/pulls/comments/216001280"},"html":{"href":"https://github.com/lightbend/reactive-lib/pull/75#discussion_r216001280"},"pull_request":{"href":"https://api.github.com/repos/lightbend/reactive-lib/pulls/75"}},"in_reply_to_id":215810694},"pull_request":{"url":"https://api.github.com/repos/lightbend/reactive-lib/pulls/75","id":213064234,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMDY0MjM0","html_url":"https://github.com/lightbend/reactive-lib/pull/75","diff_url":"https://github.com/lightbend/reactive-lib/pull/75.diff","patch_url":"https://github.com/lightbend/reactive-lib/pull/75.patch","issue_url":"https://api.github.com/repos/lightbend/reactive-lib/issues/75","number":75,"state":"closed","locked":false,"title":"make DNS parsing more robust","user":{"login":"eed3si9n","id":184683,"node_id":"MDQ6VXNlcjE4NDY4Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/184683?v=4","gravatar_id":"","url":"https://api.github.com/users/eed3si9n","html_url":"https://github.com/eed3si9n","followers_url":"https://api.github.com/users/eed3si9n/followers","following_url":"https://api.github.com/users/eed3si9n/following{/other_user}","gists_url":"https://api.github.com/users/eed3si9n/gists{/gist_id}","starred_url":"https://api.github.com/users/eed3si9n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eed3si9n/subscriptions","organizations_url":"https://api.github.com/users/eed3si9n/orgs","repos_url":"https://api.github.com/users/eed3si9n/repos","events_url":"https://api.github.com/users/eed3si9n/events{/privacy}","received_events_url":"https://api.github.com/users/eed3si9n/received_events","type":"User","site_admin":false},"body":"Fixes #74\r\n","created_at":"2018-09-04T18:26:29Z","updated_at":"2018-09-07T15:38:10Z","closed_at":"2018-09-05T21:38:06Z","merged_at":"2018-09-05T21:38:06Z","merge_commit_sha":"cabf68393d7ee6d3676c682ae0a833ac22841c73","assignee":{"login":"eed3si9n","id":184683,"node_id":"MDQ6VXNlcjE4NDY4Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/184683?v=4","gravatar_id":"","url":"https://api.github.com/users/eed3si9n","html_url":"https://github.com/eed3si9n","followers_url":"https://api.github.com/users/eed3si9n/followers","following_url":"https://api.github.com/users/eed3si9n/following{/other_user}","gists_url":"https://api.github.com/users/eed3si9n/gists{/gist_id}","starred_url":"https://api.github.com/users/eed3si9n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eed3si9n/subscriptions","organizations_url":"https://api.github.com/users/eed3si9n/orgs","repos_url":"https://api.github.com/users/eed3si9n/repos","events_url":"https://api.github.com/users/eed3si9n/events{/privacy}","received_events_url":"https://api.github.com/users/eed3si9n/received_events","type":"User","site_admin":false},"assignees":[{"login":"eed3si9n","id":184683,"node_id":"MDQ6VXNlcjE4NDY4Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/184683?v=4","gravatar_id":"","url":"https://api.github.com/users/eed3si9n","html_url":"https://github.com/eed3si9n","followers_url":"https://api.github.com/users/eed3si9n/followers","following_url":"https://api.github.com/users/eed3si9n/following{/other_user}","gists_url":"https://api.github.com/users/eed3si9n/gists{/gist_id}","starred_url":"https://api.github.com/users/eed3si9n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eed3si9n/subscriptions","organizations_url":"https://api.github.com/users/eed3si9n/orgs","repos_url":"https://api.github.com/users/eed3si9n/repos","events_url":"https://api.github.com/users/eed3si9n/events{/privacy}","received_events_url":"https://api.github.com/users/eed3si9n/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"cunei","id":686260,"node_id":"MDQ6VXNlcjY4NjI2MA==","avatar_url":"https://avatars3.githubusercontent.com/u/686260?v=4","gravatar_id":"","url":"https://api.github.com/users/cunei","html_url":"https://github.com/cunei","followers_url":"https://api.github.com/users/cunei/followers","following_url":"https://api.github.com/users/cunei/following{/other_user}","gists_url":"https://api.github.com/users/cunei/gists{/gist_id}","starred_url":"https://api.github.com/users/cunei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cunei/subscriptions","organizations_url":"https://api.github.com/users/cunei/orgs","repos_url":"https://api.github.com/users/cunei/repos","events_url":"https://api.github.com/users/cunei/events{/privacy}","received_events_url":"https://api.github.com/users/cunei/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lightbend/reactive-lib/pulls/75/commits","review_comments_url":"https://api.github.com/repos/lightbend/reactive-lib/pulls/75/comments","review_comment_url":"https://api.github.com/repos/lightbend/reactive-lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lightbend/reactive-lib/issues/75/comments","statuses_url":"https://api.github.com/repos/lightbend/reactive-lib/statuses/b83bb8da5343e7831d33cfd5169feb0af3e52bf4","head":{"label":"eed3si9n:wip/dns","ref":"wip/dns","sha":"b83bb8da5343e7831d33cfd5169feb0af3e52bf4","user":{"login":"eed3si9n","id":184683,"node_id":"MDQ6VXNlcjE4NDY4Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/184683?v=4","gravatar_id":"","url":"https://api.github.com/users/eed3si9n","html_url":"https://github.com/eed3si9n","followers_url":"https://api.github.com/users/eed3si9n/followers","following_url":"https://api.github.com/users/eed3si9n/following{/other_user}","gists_url":"https://api.github.com/users/eed3si9n/gists{/gist_id}","starred_url":"https://api.github.com/users/eed3si9n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eed3si9n/subscriptions","organizations_url":"https://api.github.com/users/eed3si9n/orgs","repos_url":"https://api.github.com/users/eed3si9n/repos","events_url":"https://api.github.com/users/eed3si9n/events{/privacy}","received_events_url":"https://api.github.com/users/eed3si9n/received_events","type":"User","site_admin":false},"repo":{"id":141492708,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE0OTI3MDg=","name":"reactive-lib","full_name":"eed3si9n/reactive-lib","owner":{"login":"eed3si9n","id":184683,"node_id":"MDQ6VXNlcjE4NDY4Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/184683?v=4","gravatar_id":"","url":"https://api.github.com/users/eed3si9n","html_url":"https://github.com/eed3si9n","followers_url":"https://api.github.com/users/eed3si9n/followers","following_url":"https://api.github.com/users/eed3si9n/following{/other_user}","gists_url":"https://api.github.com/users/eed3si9n/gists{/gist_id}","starred_url":"https://api.github.com/users/eed3si9n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eed3si9n/subscriptions","organizations_url":"https://api.github.com/users/eed3si9n/orgs","repos_url":"https://api.github.com/users/eed3si9n/repos","events_url":"https://api.github.com/users/eed3si9n/events{/privacy}","received_events_url":"https://api.github.com/users/eed3si9n/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eed3si9n/reactive-lib","description":null,"fork":true,"url":"https://api.github.com/repos/eed3si9n/reactive-lib","forks_url":"https://api.github.com/repos/eed3si9n/reactive-lib/forks","keys_url":"https://api.github.com/repos/eed3si9n/reactive-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eed3si9n/reactive-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eed3si9n/reactive-lib/teams","hooks_url":"https://api.github.com/repos/eed3si9n/reactive-lib/hooks","issue_events_url":"https://api.github.com/repos/eed3si9n/reactive-lib/issues/events{/number}","events_url":"https://api.github.com/repos/eed3si9n/reactive-lib/events","assignees_url":"https://api.github.com/repos/eed3si9n/reactive-lib/assignees{/user}","branches_url":"https://api.github.com/repos/eed3si9n/reactive-lib/branches{/branch}","tags_url":"https://api.github.com/repos/eed3si9n/reactive-lib/tags","blobs_url":"https://api.github.com/repos/eed3si9n/reactive-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eed3si9n/reactive-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eed3si9n/reactive-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/eed3si9n/reactive-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eed3si9n/reactive-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/eed3si9n/reactive-lib/languages","stargazers_url":"https://api.github.com/repos/eed3si9n/reactive-lib/stargazers","contributors_url":"https://api.github.com/repos/eed3si9n/reactive-lib/contributors","subscribers_url":"https://api.github.com/repos/eed3si9n/reactive-lib/subscribers","subscription_url":"https://api.github.com/repos/eed3si9n/reactive-lib/subscription","commits_url":"https://api.github.com/repos/eed3si9n/reactive-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/eed3si9n/reactive-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/eed3si9n/reactive-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/eed3si9n/reactive-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/eed3si9n/reactive-lib/contents/{+path}","compare_url":"https://api.github.com/repos/eed3si9n/reactive-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eed3si9n/reactive-lib/merges","archive_url":"https://api.github.com/repos/eed3si9n/reactive-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eed3si9n/reactive-lib/downloads","issues_url":"https://api.github.com/repos/eed3si9n/reactive-lib/issues{/number}","pulls_url":"https://api.github.com/repos/eed3si9n/reactive-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/eed3si9n/reactive-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/eed3si9n/reactive-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eed3si9n/reactive-lib/labels{/name}","releases_url":"https://api.github.com/repos/eed3si9n/reactive-lib/releases{/id}","deployments_url":"https://api.github.com/repos/eed3si9n/reactive-lib/deployments","created_at":"2018-07-18T21:36:05Z","updated_at":"2018-07-18T21:36:07Z","pushed_at":"2018-09-05T21:38:09Z","git_url":"git://github.com/eed3si9n/reactive-lib.git","ssh_url":"git@github.com:eed3si9n/reactive-lib.git","clone_url":"https://github.com/eed3si9n/reactive-lib.git","svn_url":"https://github.com/eed3si9n/reactive-lib","homepage":"https://developer.lightbend.com/docs/lightbend-orchestration/current/","size":242,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lightbend:master","ref":"master","sha":"d740a94c462344d19a4ca806942ee824174c890c","user":{"login":"lightbend","id":16247783,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjQ3Nzgz","avatar_url":"https://avatars3.githubusercontent.com/u/16247783?v=4","gravatar_id":"","url":"https://api.github.com/users/lightbend","html_url":"https://github.com/lightbend","followers_url":"https://api.github.com/users/lightbend/followers","following_url":"https://api.github.com/users/lightbend/following{/other_user}","gists_url":"https://api.github.com/users/lightbend/gists{/gist_id}","starred_url":"https://api.github.com/users/lightbend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightbend/subscriptions","organizations_url":"https://api.github.com/users/lightbend/orgs","repos_url":"https://api.github.com/users/lightbend/repos","events_url":"https://api.github.com/users/lightbend/events{/privacy}","received_events_url":"https://api.github.com/users/lightbend/received_events","type":"Organization","site_admin":false},"repo":{"id":104394876,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQzOTQ4NzY=","name":"reactive-lib","full_name":"lightbend/reactive-lib","owner":{"login":"lightbend","id":16247783,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjQ3Nzgz","avatar_url":"https://avatars3.githubusercontent.com/u/16247783?v=4","gravatar_id":"","url":"https://api.github.com/users/lightbend","html_url":"https://github.com/lightbend","followers_url":"https://api.github.com/users/lightbend/followers","following_url":"https://api.github.com/users/lightbend/following{/other_user}","gists_url":"https://api.github.com/users/lightbend/gists{/gist_id}","starred_url":"https://api.github.com/users/lightbend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightbend/subscriptions","organizations_url":"https://api.github.com/users/lightbend/orgs","repos_url":"https://api.github.com/users/lightbend/repos","events_url":"https://api.github.com/users/lightbend/events{/privacy}","received_events_url":"https://api.github.com/users/lightbend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lightbend/reactive-lib","description":null,"fork":false,"url":"https://api.github.com/repos/lightbend/reactive-lib","forks_url":"https://api.github.com/repos/lightbend/reactive-lib/forks","keys_url":"https://api.github.com/repos/lightbend/reactive-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lightbend/reactive-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lightbend/reactive-lib/teams","hooks_url":"https://api.github.com/repos/lightbend/reactive-lib/hooks","issue_events_url":"https://api.github.com/repos/lightbend/reactive-lib/issues/events{/number}","events_url":"https://api.github.com/repos/lightbend/reactive-lib/events","assignees_url":"https://api.github.com/repos/lightbend/reactive-lib/assignees{/user}","branches_url":"https://api.github.com/repos/lightbend/reactive-lib/branches{/branch}","tags_url":"https://api.github.com/repos/lightbend/reactive-lib/tags","blobs_url":"https://api.github.com/repos/lightbend/reactive-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lightbend/reactive-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lightbend/reactive-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/lightbend/reactive-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lightbend/reactive-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/lightbend/reactive-lib/languages","stargazers_url":"https://api.github.com/repos/lightbend/reactive-lib/stargazers","contributors_url":"https://api.github.com/repos/lightbend/reactive-lib/contributors","subscribers_url":"https://api.github.com/repos/lightbend/reactive-lib/subscribers","subscription_url":"https://api.github.com/repos/lightbend/reactive-lib/subscription","commits_url":"https://api.github.com/repos/lightbend/reactive-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/lightbend/reactive-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/lightbend/reactive-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/lightbend/reactive-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/lightbend/reactive-lib/contents/{+path}","compare_url":"https://api.github.com/repos/lightbend/reactive-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lightbend/reactive-lib/merges","archive_url":"https://api.github.com/repos/lightbend/reactive-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lightbend/reactive-lib/downloads","issues_url":"https://api.github.com/repos/lightbend/reactive-lib/issues{/number}","pulls_url":"https://api.github.com/repos/lightbend/reactive-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/lightbend/reactive-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/lightbend/reactive-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lightbend/reactive-lib/labels{/name}","releases_url":"https://api.github.com/repos/lightbend/reactive-lib/releases{/id}","deployments_url":"https://api.github.com/repos/lightbend/reactive-lib/deployments","created_at":"2017-09-21T20:20:31Z","updated_at":"2018-09-07T08:25:28Z","pushed_at":"2018-09-05T21:38:06Z","git_url":"git://github.com/lightbend/reactive-lib.git","ssh_url":"git@github.com:lightbend/reactive-lib.git","clone_url":"https://github.com/lightbend/reactive-lib.git","svn_url":"https://github.com/lightbend/reactive-lib","homepage":"https://developer.lightbend.com/docs/lightbend-orchestration/current/","size":257,"stargazers_count":13,"watchers_count":13,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":11,"open_issues":9,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lightbend/reactive-lib/pulls/75"},"html":{"href":"https://github.com/lightbend/reactive-lib/pull/75"},"issue":{"href":"https://api.github.com/repos/lightbend/reactive-lib/issues/75"},"comments":{"href":"https://api.github.com/repos/lightbend/reactive-lib/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/lightbend/reactive-lib/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/lightbend/reactive-lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lightbend/reactive-lib/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/lightbend/reactive-lib/statuses/b83bb8da5343e7831d33cfd5169feb0af3e52bf4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"eed3si9n"}}