{"action":"created","comment":{"url":"https://api.github.com/repos/findologic/libflexport/pulls/comments/225201100","pull_request_review_id":164750549,"id":225201100,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTIwMTEwMA==","diff_hunk":"@@ -325,4 +325,22 @@ public function testAddingRelativeUrlIsNotCausingAnException()\n \n         $this->assertEquals($imageWithRelativePath, $image->getCsvFragment());\n     }\n+\n+    public function testNewLineCharactersAreRemoved()","path":"tests/FINDOLOGIC/Export/Tests/CSVSerializationTest.php","position":null,"original_position":5,"commit_id":"f7dbaa498c8c08d0c011f600e54f370c04337688","original_commit_id":"73c18b4b5d73dda8625f74faddb1912187627713","user":{"login":"mmachatschek","id":10237069,"node_id":"MDQ6VXNlcjEwMjM3MDY5","avatar_url":"https://avatars2.githubusercontent.com/u/10237069?v=4","gravatar_id":"","url":"https://api.github.com/users/mmachatschek","html_url":"https://github.com/mmachatschek","followers_url":"https://api.github.com/users/mmachatschek/followers","following_url":"https://api.github.com/users/mmachatschek/following{/other_user}","gists_url":"https://api.github.com/users/mmachatschek/gists{/gist_id}","starred_url":"https://api.github.com/users/mmachatschek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmachatschek/subscriptions","organizations_url":"https://api.github.com/users/mmachatschek/orgs","repos_url":"https://api.github.com/users/mmachatschek/repos","events_url":"https://api.github.com/users/mmachatschek/events{/privacy}","received_events_url":"https://api.github.com/users/mmachatschek/received_events","type":"User","site_admin":false},"body":"Added a data provide vor some of the elements which do not have specific checks for integer or float values. :+1: ","created_at":"2018-10-15T15:04:24Z","updated_at":"2018-10-15T15:04:24Z","html_url":"https://github.com/findologic/libflexport/pull/70#discussion_r225201100","pull_request_url":"https://api.github.com/repos/findologic/libflexport/pulls/70","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/findologic/libflexport/pulls/comments/225201100"},"html":{"href":"https://github.com/findologic/libflexport/pull/70#discussion_r225201100"},"pull_request":{"href":"https://api.github.com/repos/findologic/libflexport/pulls/70"}},"in_reply_to_id":223593010},"pull_request":{"url":"https://api.github.com/repos/findologic/libflexport/pulls/70","id":220920489,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwOTIwNDg5","html_url":"https://github.com/findologic/libflexport/pull/70","diff_url":"https://github.com/findologic/libflexport/pull/70.diff","patch_url":"https://github.com/findologic/libflexport/pull/70.patch","issue_url":"https://api.github.com/repos/findologic/libflexport/issues/70","number":70,"state":"open","locked":false,"title":"Replace new line characters with spaces in CSV export","user":{"login":"mmachatschek","id":10237069,"node_id":"MDQ6VXNlcjEwMjM3MDY5","avatar_url":"https://avatars2.githubusercontent.com/u/10237069?v=4","gravatar_id":"","url":"https://api.github.com/users/mmachatschek","html_url":"https://github.com/mmachatschek","followers_url":"https://api.github.com/users/mmachatschek/followers","following_url":"https://api.github.com/users/mmachatschek/following{/other_user}","gists_url":"https://api.github.com/users/mmachatschek/gists{/gist_id}","starred_url":"https://api.github.com/users/mmachatschek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmachatschek/subscriptions","organizations_url":"https://api.github.com/users/mmachatschek/orgs","repos_url":"https://api.github.com/users/mmachatschek/repos","events_url":"https://api.github.com/users/mmachatschek/events{/privacy}","received_events_url":"https://api.github.com/users/mmachatschek/received_events","type":"User","site_admin":false},"body":"This will fix #69.","created_at":"2018-10-07T01:05:32Z","updated_at":"2018-10-15T15:04:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"783678d81dba9e34ac94c95a21588ba052cb0300","assignee":{"login":"mmachatschek","id":10237069,"node_id":"MDQ6VXNlcjEwMjM3MDY5","avatar_url":"https://avatars2.githubusercontent.com/u/10237069?v=4","gravatar_id":"","url":"https://api.github.com/users/mmachatschek","html_url":"https://github.com/mmachatschek","followers_url":"https://api.github.com/users/mmachatschek/followers","following_url":"https://api.github.com/users/mmachatschek/following{/other_user}","gists_url":"https://api.github.com/users/mmachatschek/gists{/gist_id}","starred_url":"https://api.github.com/users/mmachatschek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmachatschek/subscriptions","organizations_url":"https://api.github.com/users/mmachatschek/orgs","repos_url":"https://api.github.com/users/mmachatschek/repos","events_url":"https://api.github.com/users/mmachatschek/events{/privacy}","received_events_url":"https://api.github.com/users/mmachatschek/received_events","type":"User","site_admin":false},"assignees":[{"login":"mmachatschek","id":10237069,"node_id":"MDQ6VXNlcjEwMjM3MDY5","avatar_url":"https://avatars2.githubusercontent.com/u/10237069?v=4","gravatar_id":"","url":"https://api.github.com/users/mmachatschek","html_url":"https://github.com/mmachatschek","followers_url":"https://api.github.com/users/mmachatschek/followers","following_url":"https://api.github.com/users/mmachatschek/following{/other_user}","gists_url":"https://api.github.com/users/mmachatschek/gists{/gist_id}","starred_url":"https://api.github.com/users/mmachatschek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmachatschek/subscriptions","organizations_url":"https://api.github.com/users/mmachatschek/orgs","repos_url":"https://api.github.com/users/mmachatschek/repos","events_url":"https://api.github.com/users/mmachatschek/events{/privacy}","received_events_url":"https://api.github.com/users/mmachatschek/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":613836014,"node_id":"MDU6TGFiZWw2MTM4MzYwMTQ=","url":"https://api.github.com/repos/findologic/libflexport/labels/bug","name":"bug","color":"ee0701","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/findologic/libflexport/pulls/70/commits","review_comments_url":"https://api.github.com/repos/findologic/libflexport/pulls/70/comments","review_comment_url":"https://api.github.com/repos/findologic/libflexport/pulls/comments{/number}","comments_url":"https://api.github.com/repos/findologic/libflexport/issues/70/comments","statuses_url":"https://api.github.com/repos/findologic/libflexport/statuses/f7dbaa498c8c08d0c011f600e54f370c04337688","head":{"label":"findologic:new_line_characters_csv","ref":"new_line_characters_csv","sha":"f7dbaa498c8c08d0c011f600e54f370c04337688","user":{"login":"findologic","id":3425374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MjUzNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3425374?v=4","gravatar_id":"","url":"https://api.github.com/users/findologic","html_url":"https://github.com/findologic","followers_url":"https://api.github.com/users/findologic/followers","following_url":"https://api.github.com/users/findologic/following{/other_user}","gists_url":"https://api.github.com/users/findologic/gists{/gist_id}","starred_url":"https://api.github.com/users/findologic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/findologic/subscriptions","organizations_url":"https://api.github.com/users/findologic/orgs","repos_url":"https://api.github.com/users/findologic/repos","events_url":"https://api.github.com/users/findologic/events{/privacy}","received_events_url":"https://api.github.com/users/findologic/received_events","type":"Organization","site_admin":false},"repo":{"id":92524380,"node_id":"MDEwOlJlcG9zaXRvcnk5MjUyNDM4MA==","name":"libflexport","full_name":"findologic/libflexport","private":false,"owner":{"login":"findologic","id":3425374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MjUzNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3425374?v=4","gravatar_id":"","url":"https://api.github.com/users/findologic","html_url":"https://github.com/findologic","followers_url":"https://api.github.com/users/findologic/followers","following_url":"https://api.github.com/users/findologic/following{/other_user}","gists_url":"https://api.github.com/users/findologic/gists{/gist_id}","starred_url":"https://api.github.com/users/findologic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/findologic/subscriptions","organizations_url":"https://api.github.com/users/findologic/orgs","repos_url":"https://api.github.com/users/findologic/repos","events_url":"https://api.github.com/users/findologic/events{/privacy}","received_events_url":"https://api.github.com/users/findologic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/findologic/libflexport","description":"FINDOLOGIC export toolkit for XML and CSV data export","fork":false,"url":"https://api.github.com/repos/findologic/libflexport","forks_url":"https://api.github.com/repos/findologic/libflexport/forks","keys_url":"https://api.github.com/repos/findologic/libflexport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/findologic/libflexport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/findologic/libflexport/teams","hooks_url":"https://api.github.com/repos/findologic/libflexport/hooks","issue_events_url":"https://api.github.com/repos/findologic/libflexport/issues/events{/number}","events_url":"https://api.github.com/repos/findologic/libflexport/events","assignees_url":"https://api.github.com/repos/findologic/libflexport/assignees{/user}","branches_url":"https://api.github.com/repos/findologic/libflexport/branches{/branch}","tags_url":"https://api.github.com/repos/findologic/libflexport/tags","blobs_url":"https://api.github.com/repos/findologic/libflexport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/findologic/libflexport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/findologic/libflexport/git/refs{/sha}","trees_url":"https://api.github.com/repos/findologic/libflexport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/findologic/libflexport/statuses/{sha}","languages_url":"https://api.github.com/repos/findologic/libflexport/languages","stargazers_url":"https://api.github.com/repos/findologic/libflexport/stargazers","contributors_url":"https://api.github.com/repos/findologic/libflexport/contributors","subscribers_url":"https://api.github.com/repos/findologic/libflexport/subscribers","subscription_url":"https://api.github.com/repos/findologic/libflexport/subscription","commits_url":"https://api.github.com/repos/findologic/libflexport/commits{/sha}","git_commits_url":"https://api.github.com/repos/findologic/libflexport/git/commits{/sha}","comments_url":"https://api.github.com/repos/findologic/libflexport/comments{/number}","issue_comment_url":"https://api.github.com/repos/findologic/libflexport/issues/comments{/number}","contents_url":"https://api.github.com/repos/findologic/libflexport/contents/{+path}","compare_url":"https://api.github.com/repos/findologic/libflexport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/findologic/libflexport/merges","archive_url":"https://api.github.com/repos/findologic/libflexport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/findologic/libflexport/downloads","issues_url":"https://api.github.com/repos/findologic/libflexport/issues{/number}","pulls_url":"https://api.github.com/repos/findologic/libflexport/pulls{/number}","milestones_url":"https://api.github.com/repos/findologic/libflexport/milestones{/number}","notifications_url":"https://api.github.com/repos/findologic/libflexport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/findologic/libflexport/labels{/name}","releases_url":"https://api.github.com/repos/findologic/libflexport/releases{/id}","deployments_url":"https://api.github.com/repos/findologic/libflexport/deployments","created_at":"2017-05-26T15:31:43Z","updated_at":"2018-07-03T14:56:22Z","pushed_at":"2018-10-15T15:03:32Z","git_url":"git://github.com/findologic/libflexport.git","ssh_url":"git@github.com:findologic/libflexport.git","clone_url":"https://github.com/findologic/libflexport.git","svn_url":"https://github.com/findologic/libflexport","homepage":"https://docs.findologic.com/doku.php?id=export_patterns","size":142,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":12,"watchers":2,"default_branch":"develop"}},"base":{"label":"findologic:develop","ref":"develop","sha":"a36db9067342c2c3eea22603d48c6330ef68eaec","user":{"login":"findologic","id":3425374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MjUzNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3425374?v=4","gravatar_id":"","url":"https://api.github.com/users/findologic","html_url":"https://github.com/findologic","followers_url":"https://api.github.com/users/findologic/followers","following_url":"https://api.github.com/users/findologic/following{/other_user}","gists_url":"https://api.github.com/users/findologic/gists{/gist_id}","starred_url":"https://api.github.com/users/findologic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/findologic/subscriptions","organizations_url":"https://api.github.com/users/findologic/orgs","repos_url":"https://api.github.com/users/findologic/repos","events_url":"https://api.github.com/users/findologic/events{/privacy}","received_events_url":"https://api.github.com/users/findologic/received_events","type":"Organization","site_admin":false},"repo":{"id":92524380,"node_id":"MDEwOlJlcG9zaXRvcnk5MjUyNDM4MA==","name":"libflexport","full_name":"findologic/libflexport","private":false,"owner":{"login":"findologic","id":3425374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MjUzNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3425374?v=4","gravatar_id":"","url":"https://api.github.com/users/findologic","html_url":"https://github.com/findologic","followers_url":"https://api.github.com/users/findologic/followers","following_url":"https://api.github.com/users/findologic/following{/other_user}","gists_url":"https://api.github.com/users/findologic/gists{/gist_id}","starred_url":"https://api.github.com/users/findologic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/findologic/subscriptions","organizations_url":"https://api.github.com/users/findologic/orgs","repos_url":"https://api.github.com/users/findologic/repos","events_url":"https://api.github.com/users/findologic/events{/privacy}","received_events_url":"https://api.github.com/users/findologic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/findologic/libflexport","description":"FINDOLOGIC export toolkit for XML and CSV data export","fork":false,"url":"https://api.github.com/repos/findologic/libflexport","forks_url":"https://api.github.com/repos/findologic/libflexport/forks","keys_url":"https://api.github.com/repos/findologic/libflexport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/findologic/libflexport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/findologic/libflexport/teams","hooks_url":"https://api.github.com/repos/findologic/libflexport/hooks","issue_events_url":"https://api.github.com/repos/findologic/libflexport/issues/events{/number}","events_url":"https://api.github.com/repos/findologic/libflexport/events","assignees_url":"https://api.github.com/repos/findologic/libflexport/assignees{/user}","branches_url":"https://api.github.com/repos/findologic/libflexport/branches{/branch}","tags_url":"https://api.github.com/repos/findologic/libflexport/tags","blobs_url":"https://api.github.com/repos/findologic/libflexport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/findologic/libflexport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/findologic/libflexport/git/refs{/sha}","trees_url":"https://api.github.com/repos/findologic/libflexport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/findologic/libflexport/statuses/{sha}","languages_url":"https://api.github.com/repos/findologic/libflexport/languages","stargazers_url":"https://api.github.com/repos/findologic/libflexport/stargazers","contributors_url":"https://api.github.com/repos/findologic/libflexport/contributors","subscribers_url":"https://api.github.com/repos/findologic/libflexport/subscribers","subscription_url":"https://api.github.com/repos/findologic/libflexport/subscription","commits_url":"https://api.github.com/repos/findologic/libflexport/commits{/sha}","git_commits_url":"https://api.github.com/repos/findologic/libflexport/git/commits{/sha}","comments_url":"https://api.github.com/repos/findologic/libflexport/comments{/number}","issue_comment_url":"https://api.github.com/repos/findologic/libflexport/issues/comments{/number}","contents_url":"https://api.github.com/repos/findologic/libflexport/contents/{+path}","compare_url":"https://api.github.com/repos/findologic/libflexport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/findologic/libflexport/merges","archive_url":"https://api.github.com/repos/findologic/libflexport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/findologic/libflexport/downloads","issues_url":"https://api.github.com/repos/findologic/libflexport/issues{/number}","pulls_url":"https://api.github.com/repos/findologic/libflexport/pulls{/number}","milestones_url":"https://api.github.com/repos/findologic/libflexport/milestones{/number}","notifications_url":"https://api.github.com/repos/findologic/libflexport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/findologic/libflexport/labels{/name}","releases_url":"https://api.github.com/repos/findologic/libflexport/releases{/id}","deployments_url":"https://api.github.com/repos/findologic/libflexport/deployments","created_at":"2017-05-26T15:31:43Z","updated_at":"2018-07-03T14:56:22Z","pushed_at":"2018-10-15T15:03:32Z","git_url":"git://github.com/findologic/libflexport.git","ssh_url":"git@github.com:findologic/libflexport.git","clone_url":"https://github.com/findologic/libflexport.git","svn_url":"https://github.com/findologic/libflexport","homepage":"https://docs.findologic.com/doku.php?id=export_patterns","size":142,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":12,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/findologic/libflexport/pulls/70"},"html":{"href":"https://github.com/findologic/libflexport/pull/70"},"issue":{"href":"https://api.github.com/repos/findologic/libflexport/issues/70"},"comments":{"href":"https://api.github.com/repos/findologic/libflexport/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/findologic/libflexport/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/findologic/libflexport/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/findologic/libflexport/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/findologic/libflexport/statuses/f7dbaa498c8c08d0c011f600e54f370c04337688"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mmachatschek"}}