{"action":"created","issue":{"url":"https://api.github.com/repos/input-output-hk/daedalus/issues/1069","repository_url":"https://api.github.com/repos/input-output-hk/daedalus","labels_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/1069/labels{/name}","comments_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/1069/comments","events_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/1069/events","html_url":"https://github.com/input-output-hk/daedalus/pull/1069","id":355225030,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExODAzMjg4","number":1069,"title":"[DDW-338]  Transaction fees calculation error improvements","user":{"login":"daniloprates","id":1504716,"node_id":"MDQ6VXNlcjE1MDQ3MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1504716?v=4","gravatar_id":"","url":"https://api.github.com/users/daniloprates","html_url":"https://github.com/daniloprates","followers_url":"https://api.github.com/users/daniloprates/followers","following_url":"https://api.github.com/users/daniloprates/following{/other_user}","gists_url":"https://api.github.com/users/daniloprates/gists{/gist_id}","starred_url":"https://api.github.com/users/daniloprates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniloprates/subscriptions","organizations_url":"https://api.github.com/users/daniloprates/orgs","repos_url":"https://api.github.com/users/daniloprates/repos","events_url":"https://api.github.com/users/daniloprates/events{/privacy}","received_events_url":"https://api.github.com/users/daniloprates/received_events","type":"User","site_admin":false},"labels":[{"id":455603673,"node_id":"MDU6TGFiZWw0NTU2MDM2NzM=","url":"https://api.github.com/repos/input-output-hk/daedalus/labels/feature","name":"feature","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":{"login":"daniloprates","id":1504716,"node_id":"MDQ6VXNlcjE1MDQ3MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1504716?v=4","gravatar_id":"","url":"https://api.github.com/users/daniloprates","html_url":"https://github.com/daniloprates","followers_url":"https://api.github.com/users/daniloprates/followers","following_url":"https://api.github.com/users/daniloprates/following{/other_user}","gists_url":"https://api.github.com/users/daniloprates/gists{/gist_id}","starred_url":"https://api.github.com/users/daniloprates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniloprates/subscriptions","organizations_url":"https://api.github.com/users/daniloprates/orgs","repos_url":"https://api.github.com/users/daniloprates/repos","events_url":"https://api.github.com/users/daniloprates/events{/privacy}","received_events_url":"https://api.github.com/users/daniloprates/received_events","type":"User","site_admin":false},"assignees":[{"login":"daniloprates","id":1504716,"node_id":"MDQ6VXNlcjE1MDQ3MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1504716?v=4","gravatar_id":"","url":"https://api.github.com/users/daniloprates","html_url":"https://github.com/daniloprates","followers_url":"https://api.github.com/users/daniloprates/followers","following_url":"https://api.github.com/users/daniloprates/following{/other_user}","gists_url":"https://api.github.com/users/daniloprates/gists{/gist_id}","starred_url":"https://api.github.com/users/daniloprates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniloprates/subscriptions","organizations_url":"https://api.github.com/users/daniloprates/orgs","repos_url":"https://api.github.com/users/daniloprates/repos","events_url":"https://api.github.com/users/daniloprates/events{/privacy}","received_events_url":"https://api.github.com/users/daniloprates/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-08-29T15:51:45Z","updated_at":"2018-08-30T17:26:55Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/input-output-hk/daedalus/pulls/1069","html_url":"https://github.com/input-output-hk/daedalus/pull/1069","diff_url":"https://github.com/input-output-hk/daedalus/pull/1069.diff","patch_url":"https://github.com/input-output-hk/daedalus/pull/1069.patch"},"body":"This PR improves the transaction fees calculation error.\r\n\r\n## Todo:\r\n\r\n- [x] Get the `needMore` value returned by the API to improve the fees calculation error\r\n- [ ] Define the new text. For now it was changed to `Not enough Ada for fees. Missing 1.155381 ADA`\r\n- [ ] Get translations\r\n\r\n## Screenshots:\r\n\r\n### Before\r\n\r\n![image](https://user-images.githubusercontent.com/1504716/44814469-31ee5a00-abb3-11e8-8fef-78d6dd2df2c0.png)\r\n\r\n### After\r\n\r\n![image](https://user-images.githubusercontent.com/1504716/44814398-f6539000-abb2-11e8-9f88-7770d92a7e6e.png)\r\n\r\n\r\n---\r\n\r\n## Review Checklist:\r\n\r\n### Basics\r\n\r\n- [ ] PR is updated to the most recent version of target branch (and there are no conflicts)\r\n- [ ] PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes\r\n- [ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub\r\n- [ ] Automated tests: All acceptance tests are passing (`yarn run test`)\r\n- [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *development* build (`yarn run dev`)\r\n- [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *production* build (`yarn run package` / CI builds)\r\n- [ ] There are no *flow* errors or warnings (`yarn run flow:test`)\r\n- [ ] There are no *lint* errors or warnings (`yarn run lint`)\r\n- [ ] Text changes are proofread and approved (Jane Wild)\r\n- [ ] There are no missing translations (running `yarn run manage:translations` produces no changes)\r\n- [ ] UI changes look good in all themes (Alexander Rukin)\r\n- [ ] Storybook works and no stories are broken (`yarn run storybook`)\r\n- [ ] In case of dependency changes `yarn.lock` file is updated\r\n\r\n### Code Quality\r\n- [ ] Important parts of the code are properly documented and commented\r\n- [ ] Code is properly typed with flow\r\n- [ ] React components are split-up enough to avoid unnecessary re-rendering\r\n- [ ] Any code that only works in Electron is neatly separated from components\r\n\r\n### Testing\r\n- [ ] New feature / change is covered by acceptance tests\r\n- [ ] All existing acceptance tests are still up-to-date\r\n- [ ] New feature / change is covered by Daedalus Testing scenario\r\n- [ ] All existing Daedalus Testing scenarios are still up-to-date\r\n\r\n### After Review:\r\n- [ ] Merge PR\r\n- [ ] Delete source branch\r\n- [ ] Move ticket to `done` on the Youtrack board\r\n"},"comment":{"url":"https://api.github.com/repos/input-output-hk/daedalus/issues/comments/417400913","html_url":"https://github.com/input-output-hk/daedalus/pull/1069#issuecomment-417400913","issue_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/1069","id":417400913,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzQwMDkxMw==","user":{"login":"daniloprates","id":1504716,"node_id":"MDQ6VXNlcjE1MDQ3MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1504716?v=4","gravatar_id":"","url":"https://api.github.com/users/daniloprates","html_url":"https://github.com/daniloprates","followers_url":"https://api.github.com/users/daniloprates/followers","following_url":"https://api.github.com/users/daniloprates/following{/other_user}","gists_url":"https://api.github.com/users/daniloprates/gists{/gist_id}","starred_url":"https://api.github.com/users/daniloprates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniloprates/subscriptions","organizations_url":"https://api.github.com/users/daniloprates/orgs","repos_url":"https://api.github.com/users/daniloprates/repos","events_url":"https://api.github.com/users/daniloprates/events{/privacy}","received_events_url":"https://api.github.com/users/daniloprates/received_events","type":"User","site_admin":false},"created_at":"2018-08-30T17:26:55Z","updated_at":"2018-08-30T17:26:55Z","author_association":"MEMBER","body":"@nikolaglumac who should be assigned regarding text/translations, since Dark is on holiday?"}}
{"actor":{"display_login":"daniloprates"}}