{"action":"opened","number":1915,"pull_request":{"url":"https://api.github.com/repos/nasa/openmct/pulls/1915","id":169003297,"html_url":"https://github.com/nasa/openmct/pull/1915","diff_url":"https://github.com/nasa/openmct/pull/1915.diff","patch_url":"https://github.com/nasa/openmct/pull/1915.patch","issue_url":"https://api.github.com/repos/nasa/openmct/issues/1915","number":1915,"state":"open","locked":false,"title":"[API] provider support for dynamic composition is optional","user":{"login":"larkin","id":226503,"avatar_url":"https://avatars0.githubusercontent.com/u/226503?v=4","gravatar_id":"","url":"https://api.github.com/users/larkin","html_url":"https://github.com/larkin","followers_url":"https://api.github.com/users/larkin/followers","following_url":"https://api.github.com/users/larkin/following{/other_user}","gists_url":"https://api.github.com/users/larkin/gists{/gist_id}","starred_url":"https://api.github.com/users/larkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larkin/subscriptions","organizations_url":"https://api.github.com/users/larkin/orgs","repos_url":"https://api.github.com/users/larkin/repos","events_url":"https://api.github.com/users/larkin/events{/privacy}","received_events_url":"https://api.github.com/users/larkin/received_events","type":"User","site_admin":false},"body":"All views are expected to implement dynamic composition handling\r\nby listening for the \"add\" and \"remove\" events and then calling\r\n\"collection.load()\" when they are ready to handle these events.\r\n\r\nHowever, it does not make sense that every composition provider will\r\nbe dynamic, so implementing support for dynamic composition should\r\nnot be a requirement.  This commit removes that requirement, without \r\nchanging the interface of the Composition Collection.\r\n\r\nFixes #1914\r\n\r\n# Reviewer Checklist\r\n\r\n1. Changes appear to address issue? Y\r\n2. Appropriate unit tests included? N/A, issues exist for API test backfill.\r\n3. Code style and in-line documentation are appropriate? Y\r\n4. Commit messages meet standards? Y\r\n\r\nI am currently backfilling tests for the Composition API and will be opening a separate pull request for those tests.","created_at":"2018-02-14T01:44:45Z","updated_at":"2018-02-14T01:44:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"akhenry","id":4215777,"avatar_url":"https://avatars1.githubusercontent.com/u/4215777?v=4","gravatar_id":"","url":"https://api.github.com/users/akhenry","html_url":"https://github.com/akhenry","followers_url":"https://api.github.com/users/akhenry/followers","following_url":"https://api.github.com/users/akhenry/following{/other_user}","gists_url":"https://api.github.com/users/akhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/akhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhenry/subscriptions","organizations_url":"https://api.github.com/users/akhenry/orgs","repos_url":"https://api.github.com/users/akhenry/repos","events_url":"https://api.github.com/users/akhenry/events{/privacy}","received_events_url":"https://api.github.com/users/akhenry/received_events","type":"User","site_admin":false},"assignees":[{"login":"akhenry","id":4215777,"avatar_url":"https://avatars1.githubusercontent.com/u/4215777?v=4","gravatar_id":"","url":"https://api.github.com/users/akhenry","html_url":"https://github.com/akhenry","followers_url":"https://api.github.com/users/akhenry/followers","following_url":"https://api.github.com/users/akhenry/following{/other_user}","gists_url":"https://api.github.com/users/akhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/akhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhenry/subscriptions","organizations_url":"https://api.github.com/users/akhenry/orgs","repos_url":"https://api.github.com/users/akhenry/repos","events_url":"https://api.github.com/users/akhenry/events{/privacy}","received_events_url":"https://api.github.com/users/akhenry/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nasa/openmct/pulls/1915/commits","review_comments_url":"https://api.github.com/repos/nasa/openmct/pulls/1915/comments","review_comment_url":"https://api.github.com/repos/nasa/openmct/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nasa/openmct/issues/1915/comments","statuses_url":"https://api.github.com/repos/nasa/openmct/statuses/195f48a26787209ab37c45bbad566ea7734efbc4","head":{"label":"nasa:composition-api-optional-support","ref":"composition-api-optional-support","sha":"195f48a26787209ab37c45bbad566ea7734efbc4","user":{"login":"nasa","id":848102,"avatar_url":"https://avatars2.githubusercontent.com/u/848102?v=4","gravatar_id":"","url":"https://api.github.com/users/nasa","html_url":"https://github.com/nasa","followers_url":"https://api.github.com/users/nasa/followers","following_url":"https://api.github.com/users/nasa/following{/other_user}","gists_url":"https://api.github.com/users/nasa/gists{/gist_id}","starred_url":"https://api.github.com/users/nasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nasa/subscriptions","organizations_url":"https://api.github.com/users/nasa/orgs","repos_url":"https://api.github.com/users/nasa/repos","events_url":"https://api.github.com/users/nasa/events{/privacy}","received_events_url":"https://api.github.com/users/nasa/received_events","type":"Organization","site_admin":false},"repo":{"id":36753839,"name":"openmct","full_name":"nasa/openmct","owner":{"login":"nasa","id":848102,"avatar_url":"https://avatars2.githubusercontent.com/u/848102?v=4","gravatar_id":"","url":"https://api.github.com/users/nasa","html_url":"https://github.com/nasa","followers_url":"https://api.github.com/users/nasa/followers","following_url":"https://api.github.com/users/nasa/following{/other_user}","gists_url":"https://api.github.com/users/nasa/gists{/gist_id}","starred_url":"https://api.github.com/users/nasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nasa/subscriptions","organizations_url":"https://api.github.com/users/nasa/orgs","repos_url":"https://api.github.com/users/nasa/repos","events_url":"https://api.github.com/users/nasa/events{/privacy}","received_events_url":"https://api.github.com/users/nasa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nasa/openmct","description":"A web based mission control framework. ","fork":false,"url":"https://api.github.com/repos/nasa/openmct","forks_url":"https://api.github.com/repos/nasa/openmct/forks","keys_url":"https://api.github.com/repos/nasa/openmct/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nasa/openmct/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nasa/openmct/teams","hooks_url":"https://api.github.com/repos/nasa/openmct/hooks","issue_events_url":"https://api.github.com/repos/nasa/openmct/issues/events{/number}","events_url":"https://api.github.com/repos/nasa/openmct/events","assignees_url":"https://api.github.com/repos/nasa/openmct/assignees{/user}","branches_url":"https://api.github.com/repos/nasa/openmct/branches{/branch}","tags_url":"https://api.github.com/repos/nasa/openmct/tags","blobs_url":"https://api.github.com/repos/nasa/openmct/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nasa/openmct/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nasa/openmct/git/refs{/sha}","trees_url":"https://api.github.com/repos/nasa/openmct/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nasa/openmct/statuses/{sha}","languages_url":"https://api.github.com/repos/nasa/openmct/languages","stargazers_url":"https://api.github.com/repos/nasa/openmct/stargazers","contributors_url":"https://api.github.com/repos/nasa/openmct/contributors","subscribers_url":"https://api.github.com/repos/nasa/openmct/subscribers","subscription_url":"https://api.github.com/repos/nasa/openmct/subscription","commits_url":"https://api.github.com/repos/nasa/openmct/commits{/sha}","git_commits_url":"https://api.github.com/repos/nasa/openmct/git/commits{/sha}","comments_url":"https://api.github.com/repos/nasa/openmct/comments{/number}","issue_comment_url":"https://api.github.com/repos/nasa/openmct/issues/comments{/number}","contents_url":"https://api.github.com/repos/nasa/openmct/contents/{+path}","compare_url":"https://api.github.com/repos/nasa/openmct/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nasa/openmct/merges","archive_url":"https://api.github.com/repos/nasa/openmct/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nasa/openmct/downloads","issues_url":"https://api.github.com/repos/nasa/openmct/issues{/number}","pulls_url":"https://api.github.com/repos/nasa/openmct/pulls{/number}","milestones_url":"https://api.github.com/repos/nasa/openmct/milestones{/number}","notifications_url":"https://api.github.com/repos/nasa/openmct/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nasa/openmct/labels{/name}","releases_url":"https://api.github.com/repos/nasa/openmct/releases{/id}","deployments_url":"https://api.github.com/repos/nasa/openmct/deployments","created_at":"2015-06-02T18:40:28Z","updated_at":"2018-02-13T22:56:47Z","pushed_at":"2018-02-14T01:40:30Z","git_url":"git://github.com/nasa/openmct.git","ssh_url":"git@github.com:nasa/openmct.git","clone_url":"https://github.com/nasa/openmct.git","svn_url":"https://github.com/nasa/openmct","homepage":"https://nasa.github.io/openmct/","size":28721,"stargazers_count":4907,"watchers_count":4907,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":508,"mirror_url":null,"archived":false,"open_issues_count":307,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":508,"open_issues":307,"watchers":4907,"default_branch":"master"}},"base":{"label":"nasa:master","ref":"master","sha":"d4e3e6689cdf3790a7b6c572bf8e6db5f7f53ff8","user":{"login":"nasa","id":848102,"avatar_url":"https://avatars2.githubusercontent.com/u/848102?v=4","gravatar_id":"","url":"https://api.github.com/users/nasa","html_url":"https://github.com/nasa","followers_url":"https://api.github.com/users/nasa/followers","following_url":"https://api.github.com/users/nasa/following{/other_user}","gists_url":"https://api.github.com/users/nasa/gists{/gist_id}","starred_url":"https://api.github.com/users/nasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nasa/subscriptions","organizations_url":"https://api.github.com/users/nasa/orgs","repos_url":"https://api.github.com/users/nasa/repos","events_url":"https://api.github.com/users/nasa/events{/privacy}","received_events_url":"https://api.github.com/users/nasa/received_events","type":"Organization","site_admin":false},"repo":{"id":36753839,"name":"openmct","full_name":"nasa/openmct","owner":{"login":"nasa","id":848102,"avatar_url":"https://avatars2.githubusercontent.com/u/848102?v=4","gravatar_id":"","url":"https://api.github.com/users/nasa","html_url":"https://github.com/nasa","followers_url":"https://api.github.com/users/nasa/followers","following_url":"https://api.github.com/users/nasa/following{/other_user}","gists_url":"https://api.github.com/users/nasa/gists{/gist_id}","starred_url":"https://api.github.com/users/nasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nasa/subscriptions","organizations_url":"https://api.github.com/users/nasa/orgs","repos_url":"https://api.github.com/users/nasa/repos","events_url":"https://api.github.com/users/nasa/events{/privacy}","received_events_url":"https://api.github.com/users/nasa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nasa/openmct","description":"A web based mission control framework. ","fork":false,"url":"https://api.github.com/repos/nasa/openmct","forks_url":"https://api.github.com/repos/nasa/openmct/forks","keys_url":"https://api.github.com/repos/nasa/openmct/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nasa/openmct/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nasa/openmct/teams","hooks_url":"https://api.github.com/repos/nasa/openmct/hooks","issue_events_url":"https://api.github.com/repos/nasa/openmct/issues/events{/number}","events_url":"https://api.github.com/repos/nasa/openmct/events","assignees_url":"https://api.github.com/repos/nasa/openmct/assignees{/user}","branches_url":"https://api.github.com/repos/nasa/openmct/branches{/branch}","tags_url":"https://api.github.com/repos/nasa/openmct/tags","blobs_url":"https://api.github.com/repos/nasa/openmct/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nasa/openmct/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nasa/openmct/git/refs{/sha}","trees_url":"https://api.github.com/repos/nasa/openmct/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nasa/openmct/statuses/{sha}","languages_url":"https://api.github.com/repos/nasa/openmct/languages","stargazers_url":"https://api.github.com/repos/nasa/openmct/stargazers","contributors_url":"https://api.github.com/repos/nasa/openmct/contributors","subscribers_url":"https://api.github.com/repos/nasa/openmct/subscribers","subscription_url":"https://api.github.com/repos/nasa/openmct/subscription","commits_url":"https://api.github.com/repos/nasa/openmct/commits{/sha}","git_commits_url":"https://api.github.com/repos/nasa/openmct/git/commits{/sha}","comments_url":"https://api.github.com/repos/nasa/openmct/comments{/number}","issue_comment_url":"https://api.github.com/repos/nasa/openmct/issues/comments{/number}","contents_url":"https://api.github.com/repos/nasa/openmct/contents/{+path}","compare_url":"https://api.github.com/repos/nasa/openmct/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nasa/openmct/merges","archive_url":"https://api.github.com/repos/nasa/openmct/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nasa/openmct/downloads","issues_url":"https://api.github.com/repos/nasa/openmct/issues{/number}","pulls_url":"https://api.github.com/repos/nasa/openmct/pulls{/number}","milestones_url":"https://api.github.com/repos/nasa/openmct/milestones{/number}","notifications_url":"https://api.github.com/repos/nasa/openmct/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nasa/openmct/labels{/name}","releases_url":"https://api.github.com/repos/nasa/openmct/releases{/id}","deployments_url":"https://api.github.com/repos/nasa/openmct/deployments","created_at":"2015-06-02T18:40:28Z","updated_at":"2018-02-13T22:56:47Z","pushed_at":"2018-02-14T01:40:30Z","git_url":"git://github.com/nasa/openmct.git","ssh_url":"git@github.com:nasa/openmct.git","clone_url":"https://github.com/nasa/openmct.git","svn_url":"https://github.com/nasa/openmct","homepage":"https://nasa.github.io/openmct/","size":28721,"stargazers_count":4907,"watchers_count":4907,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":508,"mirror_url":null,"archived":false,"open_issues_count":307,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":508,"open_issues":307,"watchers":4907,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nasa/openmct/pulls/1915"},"html":{"href":"https://github.com/nasa/openmct/pull/1915"},"issue":{"href":"https://api.github.com/repos/nasa/openmct/issues/1915"},"comments":{"href":"https://api.github.com/repos/nasa/openmct/issues/1915/comments"},"review_comments":{"href":"https://api.github.com/repos/nasa/openmct/pulls/1915/comments"},"review_comment":{"href":"https://api.github.com/repos/nasa/openmct/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nasa/openmct/pulls/1915/commits"},"statuses":{"href":"https://api.github.com/repos/nasa/openmct/statuses/195f48a26787209ab37c45bbad566ea7734efbc4"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":32,"deletions":28,"changed_files":1}}
{"actor":{"display_login":"larkin"}}