{"action":"created","comment":{"url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/pulls/comments/206854790","pull_request_review_id":142346241,"id":206854790,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjg1NDc5MA==","diff_hunk":"@@ -30,14 +30,31 @@ source \"${NVOC}/1bash\"\n current_1bash_ver=\"$nvOC_1bash_ver\"\n source \"${NVOC}/1bash.template\"\n template_1bash_ver=\"$nvOC_1bash_ver\"\n+last_compatible_1bash_ver=\"$nvOC_1bash_last_compatible\"\n+last_incompatible_1bash_ver=\"$nvOC_1bash_last_incompatible\"\n \n-if [[ ${current_1bash_ver} != ${template_1bash_ver} ]]\n+\n+if [[ ${current_1bash_ver} -lt ${last_incompatible_1bash_ver} ]]\n+then\n+  echo -e \" $(tput bold)################################################################################ $(tput sgr0)\"\n+  echo \"\"\n+  echo -e \" \\e[31m     Your 1bash revision is not compatible with latest update\"\n+  echo \"      Please update your 1bash with latest 1bash.template and restart nvOC\"\n+  echo \"      SSH access will be enabled and this program restarts in a minute\"\n+  echo -e \" $(tput sgr0)\"\n+  echo -e \" $(tput bold)################################################################################ $(tput sgr0)\"\n+  sudo cp /etc/init/ssh.conf-on /etc/init/ssh.conf\n+  sleep 60\n+  exit\n+fi\n+\n+if [[ ${current_1bash_ver} le ${last_compatible_1bash_ver} ]]","path":"2unix","position":32,"original_position":32,"commit_id":"ed011a907edef32eeb59317eba15f772fd83a950","original_commit_id":"ed011a907edef32eeb59317eba15f772fd83a950","user":{"login":"LuKePicci","id":8722358,"node_id":"MDQ6VXNlcjg3MjIzNTg=","avatar_url":"https://avatars3.githubusercontent.com/u/8722358?v=4","gravatar_id":"","url":"https://api.github.com/users/LuKePicci","html_url":"https://github.com/LuKePicci","followers_url":"https://api.github.com/users/LuKePicci/followers","following_url":"https://api.github.com/users/LuKePicci/following{/other_user}","gists_url":"https://api.github.com/users/LuKePicci/gists{/gist_id}","starred_url":"https://api.github.com/users/LuKePicci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuKePicci/subscriptions","organizations_url":"https://api.github.com/users/LuKePicci/orgs","repos_url":"https://api.github.com/users/LuKePicci/repos","events_url":"https://api.github.com/users/LuKePicci/events{/privacy}","received_events_url":"https://api.github.com/users/LuKePicci/received_events","type":"User","site_admin":false},"body":"Here is a missing dash near \"le\"","created_at":"2018-08-01T12:12:56Z","updated_at":"2018-08-01T12:13:00Z","html_url":"https://github.com/papampi/nvOC_by_fullzero_Community_Release/pull/169#discussion_r206854790","pull_request_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/pulls/169","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/pulls/comments/206854790"},"html":{"href":"https://github.com/papampi/nvOC_by_fullzero_Community_Release/pull/169#discussion_r206854790"},"pull_request":{"href":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/pulls/169"}}},"pull_request":{"url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/pulls/169","id":204664407,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NjY0NDA3","html_url":"https://github.com/papampi/nvOC_by_fullzero_Community_Release/pull/169","diff_url":"https://github.com/papampi/nvOC_by_fullzero_Community_Release/pull/169.diff","patch_url":"https://github.com/papampi/nvOC_by_fullzero_Community_Release/pull/169.patch","issue_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/issues/169","number":169,"state":"open","locked":false,"title":"Compare 1bash & 1bash.template","user":{"login":"papampi","id":1108483,"node_id":"MDQ6VXNlcjExMDg0ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1108483?v=4","gravatar_id":"","url":"https://api.github.com/users/papampi","html_url":"https://github.com/papampi","followers_url":"https://api.github.com/users/papampi/followers","following_url":"https://api.github.com/users/papampi/following{/other_user}","gists_url":"https://api.github.com/users/papampi/gists{/gist_id}","starred_url":"https://api.github.com/users/papampi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papampi/subscriptions","organizations_url":"https://api.github.com/users/papampi/orgs","repos_url":"https://api.github.com/users/papampi/repos","events_url":"https://api.github.com/users/papampi/events{/privacy}","received_events_url":"https://api.github.com/users/papampi/received_events","type":"User","site_admin":false},"body":"We dont need to enable SSH and notify about it in 2unix.\r\nIf any one update and restart nvOC from SSH, they won't see these messages.\r\ngnome-terminal output only shows up on local machine.\r\n\r\nWe should add a check and notify after \"nvOC upgrade\" finished.","created_at":"2018-07-29T22:18:33Z","updated_at":"2018-08-01T12:13:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff371660b312da00cf8c90e3c7c29232f4da017c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/pulls/169/commits","review_comments_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/pulls/169/comments","review_comment_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/pulls/comments{/number}","comments_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/issues/169/comments","statuses_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/statuses/ed011a907edef32eeb59317eba15f772fd83a950","head":{"label":"papampi:papampi-2unix_1bash_check","ref":"papampi-2unix_1bash_check","sha":"ed011a907edef32eeb59317eba15f772fd83a950","user":{"login":"papampi","id":1108483,"node_id":"MDQ6VXNlcjExMDg0ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1108483?v=4","gravatar_id":"","url":"https://api.github.com/users/papampi","html_url":"https://github.com/papampi","followers_url":"https://api.github.com/users/papampi/followers","following_url":"https://api.github.com/users/papampi/following{/other_user}","gists_url":"https://api.github.com/users/papampi/gists{/gist_id}","starred_url":"https://api.github.com/users/papampi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papampi/subscriptions","organizations_url":"https://api.github.com/users/papampi/orgs","repos_url":"https://api.github.com/users/papampi/repos","events_url":"https://api.github.com/users/papampi/events{/privacy}","received_events_url":"https://api.github.com/users/papampi/received_events","type":"User","site_admin":false},"repo":{"id":111461441,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE0NjE0NDE=","name":"nvOC_by_fullzero_Community_Release","full_name":"papampi/nvOC_by_fullzero_Community_Release","owner":{"login":"papampi","id":1108483,"node_id":"MDQ6VXNlcjExMDg0ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1108483?v=4","gravatar_id":"","url":"https://api.github.com/users/papampi","html_url":"https://github.com/papampi","followers_url":"https://api.github.com/users/papampi/followers","following_url":"https://api.github.com/users/papampi/following{/other_user}","gists_url":"https://api.github.com/users/papampi/gists{/gist_id}","starred_url":"https://api.github.com/users/papampi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papampi/subscriptions","organizations_url":"https://api.github.com/users/papampi/orgs","repos_url":"https://api.github.com/users/papampi/repos","events_url":"https://api.github.com/users/papampi/events{/privacy}","received_events_url":"https://api.github.com/users/papampi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/papampi/nvOC_by_fullzero_Community_Release","description":"nvOC easy-to-use Linux Nvidia Mining OS, Community Edition","fork":false,"url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release","forks_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/forks","keys_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/keys{/key_id}","collaborators_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/teams","hooks_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/hooks","issue_events_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/issues/events{/number}","events_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/events","assignees_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/assignees{/user}","branches_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/branches{/branch}","tags_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/tags","blobs_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/git/refs{/sha}","trees_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/git/trees{/sha}","statuses_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/statuses/{sha}","languages_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/languages","stargazers_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/stargazers","contributors_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/contributors","subscribers_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/subscribers","subscription_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/subscription","commits_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/commits{/sha}","git_commits_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/git/commits{/sha}","comments_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/comments{/number}","issue_comment_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/issues/comments{/number}","contents_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/contents/{+path}","compare_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/compare/{base}...{head}","merges_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/merges","archive_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/downloads","issues_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/issues{/number}","pulls_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/pulls{/number}","milestones_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/milestones{/number}","notifications_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/labels{/name}","releases_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/releases{/id}","deployments_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/deployments","created_at":"2017-11-20T20:51:08Z","updated_at":"2018-07-31T08:22:27Z","pushed_at":"2018-07-31T20:55:05Z","git_url":"git://github.com/papampi/nvOC_by_fullzero_Community_Release.git","ssh_url":"git@github.com:papampi/nvOC_by_fullzero_Community_Release.git","clone_url":"https://github.com/papampi/nvOC_by_fullzero_Community_Release.git","svn_url":"https://github.com/papampi/nvOC_by_fullzero_Community_Release","homepage":"","size":1728,"stargazers_count":23,"watchers_count":23,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":21,"open_issues":10,"watchers":23,"default_branch":"19-2.1"}},"base":{"label":"papampi:19-2.1","ref":"19-2.1","sha":"5b255ef030809fd09cfe816b011f52d0d0498497","user":{"login":"papampi","id":1108483,"node_id":"MDQ6VXNlcjExMDg0ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1108483?v=4","gravatar_id":"","url":"https://api.github.com/users/papampi","html_url":"https://github.com/papampi","followers_url":"https://api.github.com/users/papampi/followers","following_url":"https://api.github.com/users/papampi/following{/other_user}","gists_url":"https://api.github.com/users/papampi/gists{/gist_id}","starred_url":"https://api.github.com/users/papampi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papampi/subscriptions","organizations_url":"https://api.github.com/users/papampi/orgs","repos_url":"https://api.github.com/users/papampi/repos","events_url":"https://api.github.com/users/papampi/events{/privacy}","received_events_url":"https://api.github.com/users/papampi/received_events","type":"User","site_admin":false},"repo":{"id":111461441,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE0NjE0NDE=","name":"nvOC_by_fullzero_Community_Release","full_name":"papampi/nvOC_by_fullzero_Community_Release","owner":{"login":"papampi","id":1108483,"node_id":"MDQ6VXNlcjExMDg0ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1108483?v=4","gravatar_id":"","url":"https://api.github.com/users/papampi","html_url":"https://github.com/papampi","followers_url":"https://api.github.com/users/papampi/followers","following_url":"https://api.github.com/users/papampi/following{/other_user}","gists_url":"https://api.github.com/users/papampi/gists{/gist_id}","starred_url":"https://api.github.com/users/papampi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papampi/subscriptions","organizations_url":"https://api.github.com/users/papampi/orgs","repos_url":"https://api.github.com/users/papampi/repos","events_url":"https://api.github.com/users/papampi/events{/privacy}","received_events_url":"https://api.github.com/users/papampi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/papampi/nvOC_by_fullzero_Community_Release","description":"nvOC easy-to-use Linux Nvidia Mining OS, Community Edition","fork":false,"url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release","forks_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/forks","keys_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/keys{/key_id}","collaborators_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/teams","hooks_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/hooks","issue_events_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/issues/events{/number}","events_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/events","assignees_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/assignees{/user}","branches_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/branches{/branch}","tags_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/tags","blobs_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/git/refs{/sha}","trees_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/git/trees{/sha}","statuses_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/statuses/{sha}","languages_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/languages","stargazers_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/stargazers","contributors_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/contributors","subscribers_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/subscribers","subscription_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/subscription","commits_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/commits{/sha}","git_commits_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/git/commits{/sha}","comments_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/comments{/number}","issue_comment_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/issues/comments{/number}","contents_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/contents/{+path}","compare_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/compare/{base}...{head}","merges_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/merges","archive_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/downloads","issues_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/issues{/number}","pulls_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/pulls{/number}","milestones_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/milestones{/number}","notifications_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/labels{/name}","releases_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/releases{/id}","deployments_url":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/deployments","created_at":"2017-11-20T20:51:08Z","updated_at":"2018-07-31T08:22:27Z","pushed_at":"2018-07-31T20:55:05Z","git_url":"git://github.com/papampi/nvOC_by_fullzero_Community_Release.git","ssh_url":"git@github.com:papampi/nvOC_by_fullzero_Community_Release.git","clone_url":"https://github.com/papampi/nvOC_by_fullzero_Community_Release.git","svn_url":"https://github.com/papampi/nvOC_by_fullzero_Community_Release","homepage":"","size":1728,"stargazers_count":23,"watchers_count":23,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":21,"open_issues":10,"watchers":23,"default_branch":"19-2.1"}},"_links":{"self":{"href":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/pulls/169"},"html":{"href":"https://github.com/papampi/nvOC_by_fullzero_Community_Release/pull/169"},"issue":{"href":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/issues/169"},"comments":{"href":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/issues/169/comments"},"review_comments":{"href":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/pulls/169/comments"},"review_comment":{"href":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/pulls/169/commits"},"statuses":{"href":"https://api.github.com/repos/papampi/nvOC_by_fullzero_Community_Release/statuses/ed011a907edef32eeb59317eba15f772fd83a950"}},"author_association":"OWNER"}}
{"actor":{"display_login":"LuKePicci"}}