{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corert/pulls/comments/230499074","pull_request_review_id":171259741,"id":230499074,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDQ5OTA3NA==","diff_hunk":"@@ -452,6 +452,44 @@ protected override IMethodNode CreateMethodEntrypointNode(MethodDesc method)\n         protected override IMethodNode CreateUnboxingStubNode(MethodDesc method)\n         {\n             throw new NotImplementedException();\n-        }   \n+        }\n+\n+        protected override ISymbolNode CreateGenericLookupFromDictionaryNode(ReadyToRunGenericHelperKey helperKey)","path":"src/ILCompiler.ReadyToRun/src/Compiler/DependencyAnalysis/ReadyToRunCodegenNodeFactory.cs","position":7,"original_position":7,"commit_id":"8b9385236104888a414df7e65d5bebca9794ac2b","original_commit_id":"8b9385236104888a414df7e65d5bebca9794ac2b","user":{"login":"zamont","id":13769665,"node_id":"MDQ6VXNlcjEzNzY5NjY1","avatar_url":"https://avatars1.githubusercontent.com/u/13769665?v=4","gravatar_id":"","url":"https://api.github.com/users/zamont","html_url":"https://github.com/zamont","followers_url":"https://api.github.com/users/zamont/followers","following_url":"https://api.github.com/users/zamont/following{/other_user}","gists_url":"https://api.github.com/users/zamont/gists{/gist_id}","starred_url":"https://api.github.com/users/zamont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zamont/subscriptions","organizations_url":"https://api.github.com/users/zamont/orgs","repos_url":"https://api.github.com/users/zamont/repos","events_url":"https://api.github.com/users/zamont/events{/privacy}","received_events_url":"https://api.github.com/users/zamont/received_events","type":"User","site_admin":false},"body":"These two methods look identical to me. Do we expect the implementations to diverge or could they share implementation with a private method?","created_at":"2018-11-02T20:29:00Z","updated_at":"2018-11-02T20:29:00Z","html_url":"https://github.com/dotnet/corert/pull/6521#discussion_r230499074","pull_request_url":"https://api.github.com/repos/dotnet/corert/pulls/6521","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corert/pulls/comments/230499074"},"html":{"href":"https://github.com/dotnet/corert/pull/6521#discussion_r230499074"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corert/pulls/6521"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corert/pulls/6521","id":227769086,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NzY5MDg2","html_url":"https://github.com/dotnet/corert/pull/6521","diff_url":"https://github.com/dotnet/corert/pull/6521.diff","patch_url":"https://github.com/dotnet/corert/pull/6521.patch","issue_url":"https://api.github.com/repos/dotnet/corert/issues/6521","number":6521,"state":"closed","locked":false,"title":"Separate dynamic statics change","user":{"login":"trylek","id":15313784,"node_id":"MDQ6VXNlcjE1MzEzNzg0","avatar_url":"https://avatars1.githubusercontent.com/u/15313784?v=4","gravatar_id":"","url":"https://api.github.com/users/trylek","html_url":"https://github.com/trylek","followers_url":"https://api.github.com/users/trylek/followers","following_url":"https://api.github.com/users/trylek/following{/other_user}","gists_url":"https://api.github.com/users/trylek/gists{/gist_id}","starred_url":"https://api.github.com/users/trylek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trylek/subscriptions","organizations_url":"https://api.github.com/users/trylek/orgs","repos_url":"https://api.github.com/users/trylek/repos","events_url":"https://api.github.com/users/trylek/events{/privacy}","received_events_url":"https://api.github.com/users/trylek/received_events","type":"User","site_admin":false},"body":"After rebasing against the latest FI from master, I have separated\r\nout the parts of my previous PR that actually deal with dynamic\r\nstatics.\r\n\r\nThanks\r\n\r\nTomas","created_at":"2018-11-01T21:42:45Z","updated_at":"2018-11-02T20:29:00Z","closed_at":"2018-11-02T20:25:34Z","merged_at":"2018-11-02T20:25:34Z","merge_commit_sha":"a70b90eafd8207352db20d2adc6470285210d278","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jkotas","id":6668460,"node_id":"MDQ6VXNlcjY2Njg0NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/6668460?v=4","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},{"login":"MichalStrehovsky","id":13110571,"node_id":"MDQ6VXNlcjEzMTEwNTcx","avatar_url":"https://avatars0.githubusercontent.com/u/13110571?v=4","gravatar_id":"","url":"https://api.github.com/users/MichalStrehovsky","html_url":"https://github.com/MichalStrehovsky","followers_url":"https://api.github.com/users/MichalStrehovsky/followers","following_url":"https://api.github.com/users/MichalStrehovsky/following{/other_user}","gists_url":"https://api.github.com/users/MichalStrehovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/MichalStrehovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichalStrehovsky/subscriptions","organizations_url":"https://api.github.com/users/MichalStrehovsky/orgs","repos_url":"https://api.github.com/users/MichalStrehovsky/repos","events_url":"https://api.github.com/users/MichalStrehovsky/events{/privacy}","received_events_url":"https://api.github.com/users/MichalStrehovsky/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corert/pulls/6521/commits","review_comments_url":"https://api.github.com/repos/dotnet/corert/pulls/6521/comments","review_comment_url":"https://api.github.com/repos/dotnet/corert/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corert/issues/6521/comments","statuses_url":"https://api.github.com/repos/dotnet/corert/statuses/8b9385236104888a414df7e65d5bebca9794ac2b","head":{"label":"trylek:DynamicStaticsSeparate","ref":"DynamicStaticsSeparate","sha":"8b9385236104888a414df7e65d5bebca9794ac2b","user":{"login":"trylek","id":15313784,"node_id":"MDQ6VXNlcjE1MzEzNzg0","avatar_url":"https://avatars1.githubusercontent.com/u/15313784?v=4","gravatar_id":"","url":"https://api.github.com/users/trylek","html_url":"https://github.com/trylek","followers_url":"https://api.github.com/users/trylek/followers","following_url":"https://api.github.com/users/trylek/following{/other_user}","gists_url":"https://api.github.com/users/trylek/gists{/gist_id}","starred_url":"https://api.github.com/users/trylek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trylek/subscriptions","organizations_url":"https://api.github.com/users/trylek/orgs","repos_url":"https://api.github.com/users/trylek/repos","events_url":"https://api.github.com/users/trylek/events{/privacy}","received_events_url":"https://api.github.com/users/trylek/received_events","type":"User","site_admin":false},"repo":{"id":87426770,"node_id":"MDEwOlJlcG9zaXRvcnk4NzQyNjc3MA==","name":"corert","full_name":"trylek/corert","private":false,"owner":{"login":"trylek","id":15313784,"node_id":"MDQ6VXNlcjE1MzEzNzg0","avatar_url":"https://avatars1.githubusercontent.com/u/15313784?v=4","gravatar_id":"","url":"https://api.github.com/users/trylek","html_url":"https://github.com/trylek","followers_url":"https://api.github.com/users/trylek/followers","following_url":"https://api.github.com/users/trylek/following{/other_user}","gists_url":"https://api.github.com/users/trylek/gists{/gist_id}","starred_url":"https://api.github.com/users/trylek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trylek/subscriptions","organizations_url":"https://api.github.com/users/trylek/orgs","repos_url":"https://api.github.com/users/trylek/repos","events_url":"https://api.github.com/users/trylek/events{/privacy}","received_events_url":"https://api.github.com/users/trylek/received_events","type":"User","site_admin":false},"html_url":"https://github.com/trylek/corert","description":"This repo contains CoreRT, a .NET Core runtime optimized for AOT (ahead of time compilation) scenarios, with the accompanying .NET Native compiler toolchain.","fork":true,"url":"https://api.github.com/repos/trylek/corert","forks_url":"https://api.github.com/repos/trylek/corert/forks","keys_url":"https://api.github.com/repos/trylek/corert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trylek/corert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trylek/corert/teams","hooks_url":"https://api.github.com/repos/trylek/corert/hooks","issue_events_url":"https://api.github.com/repos/trylek/corert/issues/events{/number}","events_url":"https://api.github.com/repos/trylek/corert/events","assignees_url":"https://api.github.com/repos/trylek/corert/assignees{/user}","branches_url":"https://api.github.com/repos/trylek/corert/branches{/branch}","tags_url":"https://api.github.com/repos/trylek/corert/tags","blobs_url":"https://api.github.com/repos/trylek/corert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trylek/corert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trylek/corert/git/refs{/sha}","trees_url":"https://api.github.com/repos/trylek/corert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trylek/corert/statuses/{sha}","languages_url":"https://api.github.com/repos/trylek/corert/languages","stargazers_url":"https://api.github.com/repos/trylek/corert/stargazers","contributors_url":"https://api.github.com/repos/trylek/corert/contributors","subscribers_url":"https://api.github.com/repos/trylek/corert/subscribers","subscription_url":"https://api.github.com/repos/trylek/corert/subscription","commits_url":"https://api.github.com/repos/trylek/corert/commits{/sha}","git_commits_url":"https://api.github.com/repos/trylek/corert/git/commits{/sha}","comments_url":"https://api.github.com/repos/trylek/corert/comments{/number}","issue_comment_url":"https://api.github.com/repos/trylek/corert/issues/comments{/number}","contents_url":"https://api.github.com/repos/trylek/corert/contents/{+path}","compare_url":"https://api.github.com/repos/trylek/corert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trylek/corert/merges","archive_url":"https://api.github.com/repos/trylek/corert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trylek/corert/downloads","issues_url":"https://api.github.com/repos/trylek/corert/issues{/number}","pulls_url":"https://api.github.com/repos/trylek/corert/pulls{/number}","milestones_url":"https://api.github.com/repos/trylek/corert/milestones{/number}","notifications_url":"https://api.github.com/repos/trylek/corert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trylek/corert/labels{/name}","releases_url":"https://api.github.com/repos/trylek/corert/releases{/id}","deployments_url":"https://api.github.com/repos/trylek/corert/deployments","created_at":"2017-04-06T12:27:11Z","updated_at":"2018-10-15T00:27:10Z","pushed_at":"2018-11-01T21:41:26Z","git_url":"git://github.com/trylek/corert.git","ssh_url":"git@github.com:trylek/corert.git","clone_url":"https://github.com/trylek/corert.git","svn_url":"https://github.com/trylek/corert","homepage":"http://dot.net","size":31608,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:r2r","ref":"r2r","sha":"a4697336491f8d33f7588bd6c89bb33db34b04c1","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":42552143,"node_id":"MDEwOlJlcG9zaXRvcnk0MjU1MjE0Mw==","name":"corert","full_name":"dotnet/corert","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/corert","description":"This repo contains CoreRT, a .NET Core runtime optimized for AOT (ahead of time compilation) scenarios, with the accompanying compiler toolchain.","fork":false,"url":"https://api.github.com/repos/dotnet/corert","forks_url":"https://api.github.com/repos/dotnet/corert/forks","keys_url":"https://api.github.com/repos/dotnet/corert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corert/teams","hooks_url":"https://api.github.com/repos/dotnet/corert/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corert/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corert/events","assignees_url":"https://api.github.com/repos/dotnet/corert/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corert/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corert/tags","blobs_url":"https://api.github.com/repos/dotnet/corert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corert/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corert/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corert/languages","stargazers_url":"https://api.github.com/repos/dotnet/corert/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corert/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corert/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corert/subscription","commits_url":"https://api.github.com/repos/dotnet/corert/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corert/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corert/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corert/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corert/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corert/merges","archive_url":"https://api.github.com/repos/dotnet/corert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corert/downloads","issues_url":"https://api.github.com/repos/dotnet/corert/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corert/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corert/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corert/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corert/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corert/deployments","created_at":"2015-09-15T23:10:53Z","updated_at":"2018-11-02T19:17:19Z","pushed_at":"2018-11-02T20:25:34Z","git_url":"git://github.com/dotnet/corert.git","ssh_url":"git@github.com:dotnet/corert.git","clone_url":"https://github.com/dotnet/corert.git","svn_url":"https://github.com/dotnet/corert","homepage":"http://dot.net","size":31517,"stargazers_count":1592,"watchers_count":1592,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":344,"mirror_url":null,"archived":false,"open_issues_count":287,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":344,"open_issues":287,"watchers":1592,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corert/pulls/6521"},"html":{"href":"https://github.com/dotnet/corert/pull/6521"},"issue":{"href":"https://api.github.com/repos/dotnet/corert/issues/6521"},"comments":{"href":"https://api.github.com/repos/dotnet/corert/issues/6521/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corert/pulls/6521/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corert/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corert/pulls/6521/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corert/statuses/8b9385236104888a414df7e65d5bebca9794ac2b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zamont"}}