{"action":"reopened","number":26,"pull_request":{"url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/pulls/26","id":180093453,"html_url":"https://github.com/salt-formulas/salt-formula-reclass/pull/26","diff_url":"https://github.com/salt-formulas/salt-formula-reclass/pull/26.diff","patch_url":"https://github.com/salt-formulas/salt-formula-reclass/pull/26.patch","issue_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/issues/26","number":26,"state":"open","locked":false,"title":"reclass.storage.node: Merge duplicate nodes","user":{"login":"alexandruavadanii","id":11544783,"avatar_url":"https://avatars2.githubusercontent.com/u/11544783?v=4","gravatar_id":"","url":"https://api.github.com/users/alexandruavadanii","html_url":"https://github.com/alexandruavadanii","followers_url":"https://api.github.com/users/alexandruavadanii/followers","following_url":"https://api.github.com/users/alexandruavadanii/following{/other_user}","gists_url":"https://api.github.com/users/alexandruavadanii/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandruavadanii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandruavadanii/subscriptions","organizations_url":"https://api.github.com/users/alexandruavadanii/orgs","repos_url":"https://api.github.com/users/alexandruavadanii/repos","events_url":"https://api.github.com/users/alexandruavadanii/events{/privacy}","received_events_url":"https://api.github.com/users/alexandruavadanii/received_events","type":"User","site_admin":false},"body":"Reclass does not support duplicate nodes in top pillar, so merge all\r\nnodes with the same name into a single node, inheriting classes from\r\nall instances.\r\n\r\nThis allows using multiple \"system.reclass.storage.system.*_cluster\"\r\nclasses for the same node, based on re-using the name (hostname); by\r\nsimply overriding the hostname parameters, e.g.:\r\n  openstack_gateway_node01_hostname: ctl01\r\n\r\nNOTE: defaults.merge module does not merge lists (e.g. for classes),\r\nso handle that case separately. Also, leave repeated nodes alone.\r\n\r\n--\r\nThis is a refined version of [1], which we use for a \"no virtualized control plane\" cluster in OPNFV (for smaller AArch64 boards that work better when control plane is directly on baremetal). To leverage it, we just override the hostnames of otherwise virtualized hosts to 'kvm{01,02,03}'.\r\nThe change should not affect current bevahior for existing clusters.\r\n\r\n[1] https://github.com/opnfv/fuel/blob/master/mcp/patches/0014-reclass.storage.node-Merge-duplicate-nodes.patch","created_at":"2018-04-07T07:07:59Z","updated_at":"2018-04-09T01:05:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92162c0346437c8a76565760d851e5dccb23092b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/pulls/26/commits","review_comments_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/pulls/26/comments","review_comment_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/pulls/comments{/number}","comments_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/issues/26/comments","statuses_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/statuses/4a8b450d4a31c6f38e010b8124d76b8e9da41b63","head":{"label":"alexandruavadanii:merge-by-hostnme","ref":"merge-by-hostnme","sha":"4a8b450d4a31c6f38e010b8124d76b8e9da41b63","user":{"login":"alexandruavadanii","id":11544783,"avatar_url":"https://avatars2.githubusercontent.com/u/11544783?v=4","gravatar_id":"","url":"https://api.github.com/users/alexandruavadanii","html_url":"https://github.com/alexandruavadanii","followers_url":"https://api.github.com/users/alexandruavadanii/followers","following_url":"https://api.github.com/users/alexandruavadanii/following{/other_user}","gists_url":"https://api.github.com/users/alexandruavadanii/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandruavadanii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandruavadanii/subscriptions","organizations_url":"https://api.github.com/users/alexandruavadanii/orgs","repos_url":"https://api.github.com/users/alexandruavadanii/repos","events_url":"https://api.github.com/users/alexandruavadanii/events{/privacy}","received_events_url":"https://api.github.com/users/alexandruavadanii/received_events","type":"User","site_admin":false},"repo":{"id":128501940,"name":"salt-formula-reclass","full_name":"alexandruavadanii/salt-formula-reclass","owner":{"login":"alexandruavadanii","id":11544783,"avatar_url":"https://avatars2.githubusercontent.com/u/11544783?v=4","gravatar_id":"","url":"https://api.github.com/users/alexandruavadanii","html_url":"https://github.com/alexandruavadanii","followers_url":"https://api.github.com/users/alexandruavadanii/followers","following_url":"https://api.github.com/users/alexandruavadanii/following{/other_user}","gists_url":"https://api.github.com/users/alexandruavadanii/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandruavadanii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandruavadanii/subscriptions","organizations_url":"https://api.github.com/users/alexandruavadanii/orgs","repos_url":"https://api.github.com/users/alexandruavadanii/repos","events_url":"https://api.github.com/users/alexandruavadanii/events{/privacy}","received_events_url":"https://api.github.com/users/alexandruavadanii/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexandruavadanii/salt-formula-reclass","description":null,"fork":true,"url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass","forks_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/forks","keys_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/teams","hooks_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/hooks","issue_events_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/issues/events{/number}","events_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/events","assignees_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/assignees{/user}","branches_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/branches{/branch}","tags_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/tags","blobs_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/statuses/{sha}","languages_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/languages","stargazers_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/stargazers","contributors_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/contributors","subscribers_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/subscribers","subscription_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/subscription","commits_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/contents/{+path}","compare_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/merges","archive_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/downloads","issues_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/issues{/number}","pulls_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/pulls{/number}","milestones_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/milestones{/number}","notifications_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/labels{/name}","releases_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/releases{/id}","deployments_url":"https://api.github.com/repos/alexandruavadanii/salt-formula-reclass/deployments","created_at":"2018-04-07T06:14:27Z","updated_at":"2018-04-07T06:14:29Z","pushed_at":"2018-04-09T00:58:15Z","git_url":"git://github.com/alexandruavadanii/salt-formula-reclass.git","ssh_url":"git@github.com:alexandruavadanii/salt-formula-reclass.git","clone_url":"https://github.com/alexandruavadanii/salt-formula-reclass.git","svn_url":"https://github.com/alexandruavadanii/salt-formula-reclass","homepage":null,"size":103,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"salt-formulas:master","ref":"master","sha":"0a44985418af78e5a4c83408556eb125e832a62f","user":{"login":"salt-formulas","id":20041042,"avatar_url":"https://avatars3.githubusercontent.com/u/20041042?v=4","gravatar_id":"","url":"https://api.github.com/users/salt-formulas","html_url":"https://github.com/salt-formulas","followers_url":"https://api.github.com/users/salt-formulas/followers","following_url":"https://api.github.com/users/salt-formulas/following{/other_user}","gists_url":"https://api.github.com/users/salt-formulas/gists{/gist_id}","starred_url":"https://api.github.com/users/salt-formulas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salt-formulas/subscriptions","organizations_url":"https://api.github.com/users/salt-formulas/orgs","repos_url":"https://api.github.com/users/salt-formulas/repos","events_url":"https://api.github.com/users/salt-formulas/events{/privacy}","received_events_url":"https://api.github.com/users/salt-formulas/received_events","type":"Organization","site_admin":false},"repo":{"id":43755594,"name":"salt-formula-reclass","full_name":"salt-formulas/salt-formula-reclass","owner":{"login":"salt-formulas","id":20041042,"avatar_url":"https://avatars3.githubusercontent.com/u/20041042?v=4","gravatar_id":"","url":"https://api.github.com/users/salt-formulas","html_url":"https://github.com/salt-formulas","followers_url":"https://api.github.com/users/salt-formulas/followers","following_url":"https://api.github.com/users/salt-formulas/following{/other_user}","gists_url":"https://api.github.com/users/salt-formulas/gists{/gist_id}","starred_url":"https://api.github.com/users/salt-formulas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salt-formulas/subscriptions","organizations_url":"https://api.github.com/users/salt-formulas/orgs","repos_url":"https://api.github.com/users/salt-formulas/repos","events_url":"https://api.github.com/users/salt-formulas/events{/privacy}","received_events_url":"https://api.github.com/users/salt-formulas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/salt-formulas/salt-formula-reclass","description":null,"fork":false,"url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass","forks_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/forks","keys_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/keys{/key_id}","collaborators_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/teams","hooks_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/hooks","issue_events_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/issues/events{/number}","events_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/events","assignees_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/assignees{/user}","branches_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/branches{/branch}","tags_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/tags","blobs_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/git/refs{/sha}","trees_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/git/trees{/sha}","statuses_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/statuses/{sha}","languages_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/languages","stargazers_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/stargazers","contributors_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/contributors","subscribers_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/subscribers","subscription_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/subscription","commits_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/commits{/sha}","git_commits_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/git/commits{/sha}","comments_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/comments{/number}","issue_comment_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/issues/comments{/number}","contents_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/contents/{+path}","compare_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/compare/{base}...{head}","merges_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/merges","archive_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/downloads","issues_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/issues{/number}","pulls_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/pulls{/number}","milestones_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/milestones{/number}","notifications_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/labels{/name}","releases_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/releases{/id}","deployments_url":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/deployments","created_at":"2015-10-06T14:22:41Z","updated_at":"2018-04-06T08:44:21Z","pushed_at":"2018-04-09T00:58:16Z","git_url":"git://github.com/salt-formulas/salt-formula-reclass.git","ssh_url":"git@github.com:salt-formulas/salt-formula-reclass.git","clone_url":"https://github.com/salt-formulas/salt-formula-reclass.git","svn_url":"https://github.com/salt-formulas/salt-formula-reclass","homepage":null,"size":101,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":12,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/pulls/26"},"html":{"href":"https://github.com/salt-formulas/salt-formula-reclass/pull/26"},"issue":{"href":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/issues/26"},"comments":{"href":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/salt-formulas/salt-formula-reclass/statuses/4a8b450d4a31c6f38e010b8124d76b8e9da41b63"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":31,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"alexandruavadanii"}}