{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/234508994","pull_request_review_id":176161423,"id":234508994,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDUwODk5NA==","diff_hunk":"@@ -0,0 +1,55 @@\n+/*\n+Copyright 2018 The Kubernetes Authors.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package options\n+\n+import (\n+\t\"flag\"\n+\t\"fmt\"\n+\t\"os\"\n+\n+\t\"github.com/spf13/pflag\"\n+\n+\t// ensure libs have a chance to globally register their flags\n+\t_ \"k8s.io/kubernetes/pkg/cloudprovider/providers\"\n+)\n+\n+// AddGenericFlags explicitly registers flags that internal packages register\n+// against the global flagsets from \"flag\". We do this in order to prevent\n+// unwanted flags from leaking into the kube-controller-manager's flagset.\n+func AddGenericFlags(fs *pflag.FlagSet) {\n+\taddCloudProviderFlags(fs)\n+}\n+\n+// addCloudProviderFlags adds flags from k8s.io/kubernetes/pkg/cloudprovider/providers.\n+func addCloudProviderFlags(fs *pflag.FlagSet) {\n+\t// lookup flags in global flag set and re-register the values with our flagset\n+\tglobal := flag.CommandLine\n+\tlocal := pflag.NewFlagSet(os.Args[0], pflag.ExitOnError)\n+\n+\tregister(global, local, \"cloud-provider-gce-lb-src-cidrs\")","path":"cmd/kube-controller-manager/app/options/customflags.go","position":43,"original_position":43,"commit_id":"9e57c62032285ff799c9a3da39dd83a04e394a35","original_commit_id":"9e57c62032285ff799c9a3da39dd83a04e394a35","user":{"login":"stewart-yu","id":30410021,"node_id":"MDQ6VXNlcjMwNDEwMDIx","avatar_url":"https://avatars2.githubusercontent.com/u/30410021?v=4","gravatar_id":"","url":"https://api.github.com/users/stewart-yu","html_url":"https://github.com/stewart-yu","followers_url":"https://api.github.com/users/stewart-yu/followers","following_url":"https://api.github.com/users/stewart-yu/following{/other_user}","gists_url":"https://api.github.com/users/stewart-yu/gists{/gist_id}","starred_url":"https://api.github.com/users/stewart-yu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stewart-yu/subscriptions","organizations_url":"https://api.github.com/users/stewart-yu/orgs","repos_url":"https://api.github.com/users/stewart-yu/repos","events_url":"https://api.github.com/users/stewart-yu/events{/privacy}","received_events_url":"https://api.github.com/users/stewart-yu/received_events","type":"User","site_admin":false},"body":"i think it's OK for now, and we should find out more elegant way later. @andrewsykim ","created_at":"2018-11-19T06:52:47Z","updated_at":"2018-11-19T06:52:48Z","html_url":"https://github.com/kubernetes/kubernetes/pull/70216#discussion_r234508994","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/70216","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/234508994"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/70216#discussion_r234508994"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/70216"}},"in_reply_to_id":234327977},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/70216","id":225615561,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NjE1NTYx","html_url":"https://github.com/kubernetes/kubernetes/pull/70216","diff_url":"https://github.com/kubernetes/kubernetes/pull/70216.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/70216.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70216","number":70216,"state":"open","locked":false,"title":"kube-controller-manager: fix missing global flags for --help","user":{"login":"imjching","id":6175557,"node_id":"MDQ6VXNlcjYxNzU1NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/6175557?v=4","gravatar_id":"","url":"https://api.github.com/users/imjching","html_url":"https://github.com/imjching","followers_url":"https://api.github.com/users/imjching/followers","following_url":"https://api.github.com/users/imjching/following{/other_user}","gists_url":"https://api.github.com/users/imjching/gists{/gist_id}","starred_url":"https://api.github.com/users/imjching/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imjching/subscriptions","organizations_url":"https://api.github.com/users/imjching/orgs","repos_url":"https://api.github.com/users/imjching/repos","events_url":"https://api.github.com/users/imjching/events{/privacy}","received_events_url":"https://api.github.com/users/imjching/received_events","type":"User","site_admin":false},"body":"**What type of PR is this?**\r\n/kind bug\r\n\r\n**What this PR does / why we need it**: In #67362, we introduced logical sections for the `--help` output in the `kube-controller-manager` binary. It seems like it does not consider global flags that were registered through the `flag` package. This PR fixes that issue. We will output glog related and version flags in the \"global\" section, and everything else in the \"generic\" section.\r\n\r\n**Which issue(s) this PR fixes**:\r\nSee #70145.\r\n\r\n**Special notes for your reviewer**: The original PR is in #70164. The plan to is to break it down into individual PRs.\r\n\r\n**Does this PR introduce a user-facing change?**:\r\n```release-note\r\nFix missing flags in kube-controller-manager --help.\r\n```\r\n\r\n/sig cli\r\n/cc @stewart-yu @andrewsykim @dims \r\n/assign @deads2k","created_at":"2018-10-25T03:49:08Z","updated_at":"2018-11-19T06:52:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6518bf7b3ed61f0a10b6be994a7f4e4be9c78057","assignee":{"login":"deads2k","id":8225098,"node_id":"MDQ6VXNlcjgyMjUwOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"assignees":[{"login":"dims","id":23304,"node_id":"MDQ6VXNlcjIzMzA0","avatar_url":"https://avatars2.githubusercontent.com/u/23304?v=4","gravatar_id":"","url":"https://api.github.com/users/dims","html_url":"https://github.com/dims","followers_url":"https://api.github.com/users/dims/followers","following_url":"https://api.github.com/users/dims/following{/other_user}","gists_url":"https://api.github.com/users/dims/gists{/gist_id}","starred_url":"https://api.github.com/users/dims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dims/subscriptions","organizations_url":"https://api.github.com/users/dims/orgs","repos_url":"https://api.github.com/users/dims/repos","events_url":"https://api.github.com/users/dims/events{/privacy}","received_events_url":"https://api.github.com/users/dims/received_events","type":"User","site_admin":false},{"login":"deads2k","id":8225098,"node_id":"MDQ6VXNlcjgyMjUwOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"dims","id":23304,"node_id":"MDQ6VXNlcjIzMzA0","avatar_url":"https://avatars2.githubusercontent.com/u/23304?v=4","gravatar_id":"","url":"https://api.github.com/users/dims","html_url":"https://github.com/dims","followers_url":"https://api.github.com/users/dims/followers","following_url":"https://api.github.com/users/dims/following{/other_user}","gists_url":"https://api.github.com/users/dims/gists{/gist_id}","starred_url":"https://api.github.com/users/dims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dims/subscriptions","organizations_url":"https://api.github.com/users/dims/orgs","repos_url":"https://api.github.com/users/dims/repos","events_url":"https://api.github.com/users/dims/events{/privacy}","received_events_url":"https://api.github.com/users/dims/received_events","type":"User","site_admin":false},{"login":"stewart-yu","id":30410021,"node_id":"MDQ6VXNlcjMwNDEwMDIx","avatar_url":"https://avatars2.githubusercontent.com/u/30410021?v=4","gravatar_id":"","url":"https://api.github.com/users/stewart-yu","html_url":"https://github.com/stewart-yu","followers_url":"https://api.github.com/users/stewart-yu/followers","following_url":"https://api.github.com/users/stewart-yu/following{/other_user}","gists_url":"https://api.github.com/users/stewart-yu/gists{/gist_id}","starred_url":"https://api.github.com/users/stewart-yu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stewart-yu/subscriptions","organizations_url":"https://api.github.com/users/stewart-yu/orgs","repos_url":"https://api.github.com/users/stewart-yu/repos","events_url":"https://api.github.com/users/stewart-yu/events{/privacy}","received_events_url":"https://api.github.com/users/stewart-yu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":105146071,"node_id":"MDU6TGFiZWwxMDUxNDYwNzE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":148225179,"node_id":"MDU6TGFiZWwxNDgyMjUxNzk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":1086787260,"node_id":"MDU6TGFiZWwxMDg2Nzg3MjYw","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/ok-to-test","name":"ok-to-test","color":"15dd18","default":false},{"id":114528068,"node_id":"MDU6TGFiZWwxMTQ1MjgwNjg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/critical-urgent","name":"priority/critical-urgent","color":"e11d21","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":173493835,"node_id":"MDU6TGFiZWwxNzM0OTM4MzU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/api-machinery","name":"sig/api-machinery","color":"d2b48c","default":false},{"id":450823910,"node_id":"MDU6TGFiZWw0NTA4MjM5MTA=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/cli","name":"sig/cli","color":"d2b48c","default":false},{"id":253450934,"node_id":"MDU6TGFiZWwyNTM0NTA5MzQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/40","html_url":"https://github.com/kubernetes/kubernetes/milestone/40","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/40/labels","id":2913713,"node_id":"MDk6TWlsZXN0b25lMjkxMzcxMw==","number":40,"title":"v1.13","description":"","creator":{"login":"thockin","id":5595220,"node_id":"MDQ6VXNlcjU1OTUyMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/5595220?v=4","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"open_issues":34,"closed_issues":275,"state":"open","created_at":"2017-11-15T06:32:59Z","updated_at":"2018-11-19T05:43:59Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/70216/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/70216/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70216/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/9e57c62032285ff799c9a3da39dd83a04e394a35","head":{"label":"imjching:70145-fix-global-flags-kube-controller-manager","ref":"70145-fix-global-flags-kube-controller-manager","sha":"9e57c62032285ff799c9a3da39dd83a04e394a35","user":{"login":"imjching","id":6175557,"node_id":"MDQ6VXNlcjYxNzU1NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/6175557?v=4","gravatar_id":"","url":"https://api.github.com/users/imjching","html_url":"https://github.com/imjching","followers_url":"https://api.github.com/users/imjching/followers","following_url":"https://api.github.com/users/imjching/following{/other_user}","gists_url":"https://api.github.com/users/imjching/gists{/gist_id}","starred_url":"https://api.github.com/users/imjching/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imjching/subscriptions","organizations_url":"https://api.github.com/users/imjching/orgs","repos_url":"https://api.github.com/users/imjching/repos","events_url":"https://api.github.com/users/imjching/events{/privacy}","received_events_url":"https://api.github.com/users/imjching/received_events","type":"User","site_admin":false},"repo":{"id":154213238,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQyMTMyMzg=","name":"kubernetes","full_name":"imjching/kubernetes","private":false,"owner":{"login":"imjching","id":6175557,"node_id":"MDQ6VXNlcjYxNzU1NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/6175557?v=4","gravatar_id":"","url":"https://api.github.com/users/imjching","html_url":"https://github.com/imjching","followers_url":"https://api.github.com/users/imjching/followers","following_url":"https://api.github.com/users/imjching/following{/other_user}","gists_url":"https://api.github.com/users/imjching/gists{/gist_id}","starred_url":"https://api.github.com/users/imjching/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imjching/subscriptions","organizations_url":"https://api.github.com/users/imjching/orgs","repos_url":"https://api.github.com/users/imjching/repos","events_url":"https://api.github.com/users/imjching/events{/privacy}","received_events_url":"https://api.github.com/users/imjching/received_events","type":"User","site_admin":false},"html_url":"https://github.com/imjching/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/imjching/kubernetes","forks_url":"https://api.github.com/repos/imjching/kubernetes/forks","keys_url":"https://api.github.com/repos/imjching/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/imjching/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/imjching/kubernetes/teams","hooks_url":"https://api.github.com/repos/imjching/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/imjching/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/imjching/kubernetes/events","assignees_url":"https://api.github.com/repos/imjching/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/imjching/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/imjching/kubernetes/tags","blobs_url":"https://api.github.com/repos/imjching/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/imjching/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/imjching/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/imjching/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/imjching/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/imjching/kubernetes/languages","stargazers_url":"https://api.github.com/repos/imjching/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/imjching/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/imjching/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/imjching/kubernetes/subscription","commits_url":"https://api.github.com/repos/imjching/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/imjching/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/imjching/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/imjching/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/imjching/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/imjching/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/imjching/kubernetes/merges","archive_url":"https://api.github.com/repos/imjching/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/imjching/kubernetes/downloads","issues_url":"https://api.github.com/repos/imjching/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/imjching/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/imjching/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/imjching/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/imjching/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/imjching/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/imjching/kubernetes/deployments","created_at":"2018-10-22T20:36:07Z","updated_at":"2018-10-22T21:06:27Z","pushed_at":"2018-11-16T19:25:07Z","git_url":"git://github.com/imjching/kubernetes.git","ssh_url":"git@github.com:imjching/kubernetes.git","clone_url":"https://github.com/imjching/kubernetes.git","svn_url":"https://github.com/imjching/kubernetes","homepage":"https://kubernetes.io","size":595950,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"d0c3cd182cffb3e722b14322fd1ca854a8bf62b0","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4MDQ5OA==","name":"kubernetes","full_name":"kubernetes/kubernetes","private":false,"owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-11-19T06:31:58Z","pushed_at":"2018-11-19T06:45:45Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"https://kubernetes.io","size":815914,"stargazers_count":43988,"watchers_count":43988,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15287,"mirror_url":null,"archived":false,"open_issues_count":3121,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":15287,"open_issues":3121,"watchers":43988,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/70216"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/70216"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/70216"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/70216/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/70216/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/70216/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/9e57c62032285ff799c9a3da39dd83a04e394a35"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"stewart-yu"}}