{"action":"closed","number":5394,"pull_request":{"url":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/5394","id":224471383,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NDcxMzgz","html_url":"https://github.com/BabylonJS/Babylon.js/pull/5394","diff_url":"https://github.com/BabylonJS/Babylon.js/pull/5394.diff","patch_url":"https://github.com/BabylonJS/Babylon.js/pull/5394.patch","issue_url":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/5394","number":5394,"state":"closed","locked":false,"title":"Solve typescript 3.1.x compatibility issues for babylonjs 3.3 release","user":{"login":"pascalbayer","id":3659792,"node_id":"MDQ6VXNlcjM2NTk3OTI=","avatar_url":"https://avatars3.githubusercontent.com/u/3659792?v=4","gravatar_id":"","url":"https://api.github.com/users/pascalbayer","html_url":"https://github.com/pascalbayer","followers_url":"https://api.github.com/users/pascalbayer/followers","following_url":"https://api.github.com/users/pascalbayer/following{/other_user}","gists_url":"https://api.github.com/users/pascalbayer/gists{/gist_id}","starred_url":"https://api.github.com/users/pascalbayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascalbayer/subscriptions","organizations_url":"https://api.github.com/users/pascalbayer/orgs","repos_url":"https://api.github.com/users/pascalbayer/repos","events_url":"https://api.github.com/users/pascalbayer/events{/privacy}","received_events_url":"https://api.github.com/users/pascalbayer/received_events","type":"User","site_admin":false},"body":"This PR will solve typing incompatibilities with typescript v3.1.3 (between `lib.dom.d.ts` and `babylon.d.ts`) which is the minimum required version of typescript for Angular 7 applications.\r\n\r\nIf possible I would like to see this PR result in a v3.3.1 of Babylon.js. Please provide further guidance if there are any other changes necessary.","created_at":"2018-10-20T12:15:10Z","updated_at":"2018-10-20T17:12:21Z","closed_at":"2018-10-20T17:12:21Z","merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/5394/commits","review_comments_url":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/5394/comments","review_comment_url":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/5394/comments","statuses_url":"https://api.github.com/repos/BabylonJS/Babylon.js/statuses/5b922e05c263ffc4fba46ae7c17d344d746d5190","head":{"label":"pascalbayer:feature/typescript-3-1-support","ref":"feature/typescript-3-1-support","sha":"5b922e05c263ffc4fba46ae7c17d344d746d5190","user":{"login":"pascalbayer","id":3659792,"node_id":"MDQ6VXNlcjM2NTk3OTI=","avatar_url":"https://avatars3.githubusercontent.com/u/3659792?v=4","gravatar_id":"","url":"https://api.github.com/users/pascalbayer","html_url":"https://github.com/pascalbayer","followers_url":"https://api.github.com/users/pascalbayer/followers","following_url":"https://api.github.com/users/pascalbayer/following{/other_user}","gists_url":"https://api.github.com/users/pascalbayer/gists{/gist_id}","starred_url":"https://api.github.com/users/pascalbayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascalbayer/subscriptions","organizations_url":"https://api.github.com/users/pascalbayer/orgs","repos_url":"https://api.github.com/users/pascalbayer/repos","events_url":"https://api.github.com/users/pascalbayer/events{/privacy}","received_events_url":"https://api.github.com/users/pascalbayer/received_events","type":"User","site_admin":false},"repo":{"id":139476335,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk0NzYzMzU=","name":"Babylon.js","full_name":"pascalbayer/Babylon.js","private":false,"owner":{"login":"pascalbayer","id":3659792,"node_id":"MDQ6VXNlcjM2NTk3OTI=","avatar_url":"https://avatars3.githubusercontent.com/u/3659792?v=4","gravatar_id":"","url":"https://api.github.com/users/pascalbayer","html_url":"https://github.com/pascalbayer","followers_url":"https://api.github.com/users/pascalbayer/followers","following_url":"https://api.github.com/users/pascalbayer/following{/other_user}","gists_url":"https://api.github.com/users/pascalbayer/gists{/gist_id}","starred_url":"https://api.github.com/users/pascalbayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascalbayer/subscriptions","organizations_url":"https://api.github.com/users/pascalbayer/orgs","repos_url":"https://api.github.com/users/pascalbayer/repos","events_url":"https://api.github.com/users/pascalbayer/events{/privacy}","received_events_url":"https://api.github.com/users/pascalbayer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pascalbayer/Babylon.js","description":"Babylon.js: a complete JavaScript framework for building 3D games with HTML 5 and WebGL","fork":true,"url":"https://api.github.com/repos/pascalbayer/Babylon.js","forks_url":"https://api.github.com/repos/pascalbayer/Babylon.js/forks","keys_url":"https://api.github.com/repos/pascalbayer/Babylon.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pascalbayer/Babylon.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pascalbayer/Babylon.js/teams","hooks_url":"https://api.github.com/repos/pascalbayer/Babylon.js/hooks","issue_events_url":"https://api.github.com/repos/pascalbayer/Babylon.js/issues/events{/number}","events_url":"https://api.github.com/repos/pascalbayer/Babylon.js/events","assignees_url":"https://api.github.com/repos/pascalbayer/Babylon.js/assignees{/user}","branches_url":"https://api.github.com/repos/pascalbayer/Babylon.js/branches{/branch}","tags_url":"https://api.github.com/repos/pascalbayer/Babylon.js/tags","blobs_url":"https://api.github.com/repos/pascalbayer/Babylon.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pascalbayer/Babylon.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pascalbayer/Babylon.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/pascalbayer/Babylon.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pascalbayer/Babylon.js/statuses/{sha}","languages_url":"https://api.github.com/repos/pascalbayer/Babylon.js/languages","stargazers_url":"https://api.github.com/repos/pascalbayer/Babylon.js/stargazers","contributors_url":"https://api.github.com/repos/pascalbayer/Babylon.js/contributors","subscribers_url":"https://api.github.com/repos/pascalbayer/Babylon.js/subscribers","subscription_url":"https://api.github.com/repos/pascalbayer/Babylon.js/subscription","commits_url":"https://api.github.com/repos/pascalbayer/Babylon.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/pascalbayer/Babylon.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/pascalbayer/Babylon.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/pascalbayer/Babylon.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/pascalbayer/Babylon.js/contents/{+path}","compare_url":"https://api.github.com/repos/pascalbayer/Babylon.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pascalbayer/Babylon.js/merges","archive_url":"https://api.github.com/repos/pascalbayer/Babylon.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pascalbayer/Babylon.js/downloads","issues_url":"https://api.github.com/repos/pascalbayer/Babylon.js/issues{/number}","pulls_url":"https://api.github.com/repos/pascalbayer/Babylon.js/pulls{/number}","milestones_url":"https://api.github.com/repos/pascalbayer/Babylon.js/milestones{/number}","notifications_url":"https://api.github.com/repos/pascalbayer/Babylon.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pascalbayer/Babylon.js/labels{/name}","releases_url":"https://api.github.com/repos/pascalbayer/Babylon.js/releases{/id}","deployments_url":"https://api.github.com/repos/pascalbayer/Babylon.js/deployments","created_at":"2018-07-02T17:51:44Z","updated_at":"2018-10-20T11:31:18Z","pushed_at":"2018-10-20T12:13:13Z","git_url":"git://github.com/pascalbayer/Babylon.js.git","ssh_url":"git@github.com:pascalbayer/Babylon.js.git","clone_url":"https://github.com/pascalbayer/Babylon.js.git","svn_url":"https://github.com/pascalbayer/Babylon.js","homepage":"http://www.babylonjs.com","size":1375306,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BabylonJS:master","ref":"master","sha":"c9cb6dff477d6c51f4f7a1a960f90d284d5f70f5","user":{"login":"BabylonJS","id":4855800,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NTU4MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/4855800?v=4","gravatar_id":"","url":"https://api.github.com/users/BabylonJS","html_url":"https://github.com/BabylonJS","followers_url":"https://api.github.com/users/BabylonJS/followers","following_url":"https://api.github.com/users/BabylonJS/following{/other_user}","gists_url":"https://api.github.com/users/BabylonJS/gists{/gist_id}","starred_url":"https://api.github.com/users/BabylonJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BabylonJS/subscriptions","organizations_url":"https://api.github.com/users/BabylonJS/orgs","repos_url":"https://api.github.com/users/BabylonJS/repos","events_url":"https://api.github.com/users/BabylonJS/events{/privacy}","received_events_url":"https://api.github.com/users/BabylonJS/received_events","type":"Organization","site_admin":false},"repo":{"id":11007313,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAwNzMxMw==","name":"Babylon.js","full_name":"BabylonJS/Babylon.js","private":false,"owner":{"login":"BabylonJS","id":4855800,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NTU4MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/4855800?v=4","gravatar_id":"","url":"https://api.github.com/users/BabylonJS","html_url":"https://github.com/BabylonJS","followers_url":"https://api.github.com/users/BabylonJS/followers","following_url":"https://api.github.com/users/BabylonJS/following{/other_user}","gists_url":"https://api.github.com/users/BabylonJS/gists{/gist_id}","starred_url":"https://api.github.com/users/BabylonJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BabylonJS/subscriptions","organizations_url":"https://api.github.com/users/BabylonJS/orgs","repos_url":"https://api.github.com/users/BabylonJS/repos","events_url":"https://api.github.com/users/BabylonJS/events{/privacy}","received_events_url":"https://api.github.com/users/BabylonJS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/BabylonJS/Babylon.js","description":"Babylon.js: a complete JavaScript framework for building 3D games with HTML 5 and WebGL","fork":false,"url":"https://api.github.com/repos/BabylonJS/Babylon.js","forks_url":"https://api.github.com/repos/BabylonJS/Babylon.js/forks","keys_url":"https://api.github.com/repos/BabylonJS/Babylon.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BabylonJS/Babylon.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BabylonJS/Babylon.js/teams","hooks_url":"https://api.github.com/repos/BabylonJS/Babylon.js/hooks","issue_events_url":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/events{/number}","events_url":"https://api.github.com/repos/BabylonJS/Babylon.js/events","assignees_url":"https://api.github.com/repos/BabylonJS/Babylon.js/assignees{/user}","branches_url":"https://api.github.com/repos/BabylonJS/Babylon.js/branches{/branch}","tags_url":"https://api.github.com/repos/BabylonJS/Babylon.js/tags","blobs_url":"https://api.github.com/repos/BabylonJS/Babylon.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BabylonJS/Babylon.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BabylonJS/Babylon.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/BabylonJS/Babylon.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BabylonJS/Babylon.js/statuses/{sha}","languages_url":"https://api.github.com/repos/BabylonJS/Babylon.js/languages","stargazers_url":"https://api.github.com/repos/BabylonJS/Babylon.js/stargazers","contributors_url":"https://api.github.com/repos/BabylonJS/Babylon.js/contributors","subscribers_url":"https://api.github.com/repos/BabylonJS/Babylon.js/subscribers","subscription_url":"https://api.github.com/repos/BabylonJS/Babylon.js/subscription","commits_url":"https://api.github.com/repos/BabylonJS/Babylon.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/BabylonJS/Babylon.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/BabylonJS/Babylon.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/BabylonJS/Babylon.js/contents/{+path}","compare_url":"https://api.github.com/repos/BabylonJS/Babylon.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BabylonJS/Babylon.js/merges","archive_url":"https://api.github.com/repos/BabylonJS/Babylon.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BabylonJS/Babylon.js/downloads","issues_url":"https://api.github.com/repos/BabylonJS/Babylon.js/issues{/number}","pulls_url":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls{/number}","milestones_url":"https://api.github.com/repos/BabylonJS/Babylon.js/milestones{/number}","notifications_url":"https://api.github.com/repos/BabylonJS/Babylon.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BabylonJS/Babylon.js/labels{/name}","releases_url":"https://api.github.com/repos/BabylonJS/Babylon.js/releases{/id}","deployments_url":"https://api.github.com/repos/BabylonJS/Babylon.js/deployments","created_at":"2013-06-27T20:40:42Z","updated_at":"2018-10-20T16:35:18Z","pushed_at":"2018-10-20T12:15:11Z","git_url":"git://github.com/BabylonJS/Babylon.js.git","ssh_url":"git@github.com:BabylonJS/Babylon.js.git","clone_url":"https://github.com/BabylonJS/Babylon.js.git","svn_url":"https://github.com/BabylonJS/Babylon.js","homepage":"http://www.babylonjs.com","size":1397327,"stargazers_count":7629,"watchers_count":7629,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1581,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1581,"open_issues":58,"watchers":7629,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/5394"},"html":{"href":"https://github.com/BabylonJS/Babylon.js/pull/5394"},"issue":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/5394"},"comments":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/5394/comments"},"review_comments":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/5394/comments"},"review_comment":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/5394/commits"},"statuses":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/statuses/5b922e05c263ffc4fba46ae7c17d344d746d5190"}},"author_association":"NONE","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":3504,"deletions":3410,"changed_files":2}}
{"actor":{"display_login":"pascalbayer"}}