{"action":"created","issue":{"url":"https://api.github.com/repos/neojato/DeLorean-v2/issues/34","repository_url":"https://api.github.com/repos/neojato/DeLorean-v2","labels_url":"https://api.github.com/repos/neojato/DeLorean-v2/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/neojato/DeLorean-v2/issues/34/comments","events_url":"https://api.github.com/repos/neojato/DeLorean-v2/issues/34/events","html_url":"https://github.com/neojato/DeLorean-v2/issues/34","id":378160424,"node_id":"MDU6SXNzdWUzNzgxNjA0MjQ=","number":34,"title":"Update angularfire2 to @angular/fire, getting rid of Angular 4 transitive dependencies","user":{"login":"MrCsabaToth","id":744949,"node_id":"MDQ6VXNlcjc0NDk0OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/744949?v=4","gravatar_id":"","url":"https://api.github.com/users/MrCsabaToth","html_url":"https://github.com/MrCsabaToth","followers_url":"https://api.github.com/users/MrCsabaToth/followers","following_url":"https://api.github.com/users/MrCsabaToth/following{/other_user}","gists_url":"https://api.github.com/users/MrCsabaToth/gists{/gist_id}","starred_url":"https://api.github.com/users/MrCsabaToth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrCsabaToth/subscriptions","organizations_url":"https://api.github.com/users/MrCsabaToth/orgs","repos_url":"https://api.github.com/users/MrCsabaToth/repos","events_url":"https://api.github.com/users/MrCsabaToth/events{/privacy}","received_events_url":"https://api.github.com/users/MrCsabaToth/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-07T06:38:16Z","updated_at":"2018-11-24T20:54:01Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"We are having trouble getting the LA DevFest site running. In the past I just ignored the transitive unfulfilled Angular 4 npm dependencies, we are already on Angular 6.1.x+. However the LA DevFest throws JavaScript error.\r\n\r\n![screenshot_2018-11-06_22-36-31](https://user-images.githubusercontent.com/744949/48114629-a3cacb80-e214-11e8-9787-d949843106d9.png)\r\n\r\nBasically this would be a successor of the almost recent npm package updates, and we'd get rid of the `angularfire2/database-deprecated` imports in favor of `@angular/fire...`.\r\n\r\n## Expected Behavior\r\nThe project would use some more recent packages i some areas and the bootstrap of it would be even more robust.\r\n\r\n## Current Behavior\r\nLA DevFest freshly forked website compiles, but JS error when site visited.\r\n\r\n## Possible Solution\r\nTrying to run ahead and hoping that the upgrade would eventually solve the JS errors.\r\n\r\n## Steps to Reproduce\r\n1. Fork the repo\r\n2. Perform the described installation and deployment / hosting modifications\r\n3. JS error\r\n\r\n## Context (Environment)\r\nI can provide more details but it was reproduced both on Matt Kaufmann's machine + my machine, as well as at some point it rendered the live site inoperable. Fortunately we could roll back to the last working snapshot with Firebase hosting's features.\r\n\r\n## Details\r\nangularfire2's obsolete dependencies:\r\n\r\n> npm WARN angularfire2@5.0.0-rc.3 requires a peer of @angular/common@^4.0.0 but none is installed. You must install peer dependencies yourself.\r\n> npm WARN angularfire2@5.0.0-rc.3 requires a peer of @angular/core@^4.0.0 but none is installed. You must install peer dependencies yourself.\r\n> npm WARN angularfire2@5.0.0-rc.3 requires a peer of @angular/platform-browser@^4.0.0 but none is installed. You must install peer dependencies yourself.\r\n> npm WARN angularfire2@5.0.0-rc.3 requires a peer of @angular/platform-browser-dynamic@^4.0.0 but none is installed. You must install peer dependencies yourself.\r\n> npm WARN angularfire2@5.0.0-rc.3 requires a peer of rxjs@^5.0.1 but none is installed. You must install peer dependencies yourself.\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/neojato/DeLorean-v2/issues/comments/441395033","html_url":"https://github.com/neojato/DeLorean-v2/issues/34#issuecomment-441395033","issue_url":"https://api.github.com/repos/neojato/DeLorean-v2/issues/34","id":441395033,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTM5NTAzMw==","user":{"login":"MrCsabaToth","id":744949,"node_id":"MDQ6VXNlcjc0NDk0OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/744949?v=4","gravatar_id":"","url":"https://api.github.com/users/MrCsabaToth","html_url":"https://github.com/MrCsabaToth","followers_url":"https://api.github.com/users/MrCsabaToth/followers","following_url":"https://api.github.com/users/MrCsabaToth/following{/other_user}","gists_url":"https://api.github.com/users/MrCsabaToth/gists{/gist_id}","starred_url":"https://api.github.com/users/MrCsabaToth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrCsabaToth/subscriptions","organizations_url":"https://api.github.com/users/MrCsabaToth/orgs","repos_url":"https://api.github.com/users/MrCsabaToth/repos","events_url":"https://api.github.com/users/MrCsabaToth/events{/privacy}","received_events_url":"https://api.github.com/users/MrCsabaToth/received_events","type":"User","site_admin":false},"created_at":"2018-11-24T20:54:01Z","updated_at":"2018-11-24T20:54:01Z","author_association":"CONTRIBUTOR","body":"I keep working on a fork off of the LA DevFest fork (https://github.com/CsabaConsulting/DeLorean-v2). The site does not throw such JS errors any more what triggered this issue, but still several parts don't work. We need help."}}
{"actor":{"display_login":"MrCsabaToth"}}