{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/cn/pulls/comments/242136893","pull_request_review_id":185517416,"id":242136893,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjEzNjg5Mw==","diff_hunk":"@@ -57,35 +57,43 @@ func cliClusterStart() *cobra.Command {\n \t\tArgs:  cobra.ExactArgs(1),\n \t\tRun:   startNano,\n \t\tExample: \"cn cluster start mycluster \\n\" +\n+\t\t\t\"cn cluster start mycluster -f tiny \\n\" +\n \t\t\t\"cn cluster start mycluster --work-dir /tmp \\n\" +\n \t\t\t\"cn cluster start mycluster --image ceph/daemon:latest-luminous \\n\" +\n \t\t\t\"cn cluster start mycluster -b /dev/sdb \\n\" +\n-\t\t\t\"cn cluster start mycluster -b /srv/nano -s 20GB \\n\" +\n-\t\t\t\"cn cluster start mycluster --privileged \\n\",\n+\t\t\t\"cn cluster start mycluster -b /srv/nano -s 20GB \\n\",\n \t}\n \tcmd.Flags().SortFlags = false\n-\tcmd.Flags().StringVarP(&workingDirectory, \"work-dir\", \"d\", \"/usr/share/ceph-nano\", \"Directory to work from\")\n-\tcmd.Flags().StringVarP(&imageName, \"image\", \"i\", \"ceph/daemon\", \"USE AT YOUR OWN RISK. Ceph container image to use, format is 'registry/username/image:tag'. The registry is optional\")\n-\tcmd.Flags().StringVarP(&dataOsd, \"data\", \"b\", \"\", \"Configure Ceph Nano underlying storage with a specific directory or physical block device. Block device support only works on Linux running under 'root', only also directory might need running as 'root' if SeLinux is enabled.\")\n+\tcmd.Flags().StringVarP(&workingDirectory, \"work-dir\", \"d\", DEFAULTWORKDIRECTORY, \"Directory to work from\")\n+\tcmd.Flags().StringVarP(&imageName, \"image\", \"i\", DEFAULTIMAGE, \"USE AT YOUR OWN RISK. Ceph container image to use, format is 'registry/username/image:tag'.\\nThe image name could also be an alias coming from the hardcoded values or the configuration file.\\nUse 'image show-aliases' to list all existing aliases.\")\n+\tcmd.Flags().StringVarP(&dataOsd, \"data\", \"b\", \"\", \"Configure Ceph Nano underlying storage with a specific directory or physical block device.\\nBlock device support only works on Linux running under 'root', only also directory might need running as 'root' if SeLinux is enabled.\")\n \tcmd.Flags().StringVarP(&sizeBluestoreBlock, \"size\", \"s\", \"\", \"Configure Ceph Nano underlying storage size when using a specific directory\")\n-\tcmd.Flags().BoolVar(&privilegedContainer, \"privileged\", false, \"Starts the container in privileged mode\")\n+\tcmd.Flags().StringVarP(&flavor, \"flavor\", \"f\", \"default\", \"Select the container flavor. Use 'flavors ls' command to list available flavors.\")\n \tcmd.Flags().BoolVar(&Help, \"help\", false, \"help for start\")\n \n \treturn cmd\n }\n \n // startNano starts Ceph Nano\n func startNano(cmd *cobra.Command, args []string) {\n+\n+\t// Ensure the flavor exist or report an error\n+\tif !isEntryExist(FLAVORS, flavor) {\n+\t\tif len(configurationFile) == 0 {\n+\t\t\tlog.Fatal(\"Using flavors requires a configuration file\")","path":"cmd/start.go","position":53,"original_position":53,"commit_id":"09e24cfcfb8642e3eba2ee3804e4e198bf909546","original_commit_id":"09e24cfcfb8642e3eba2ee3804e4e198bf909546","user":{"login":"leseb","id":912735,"node_id":"MDQ6VXNlcjkxMjczNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/912735?v=4","gravatar_id":"","url":"https://api.github.com/users/leseb","html_url":"https://github.com/leseb","followers_url":"https://api.github.com/users/leseb/followers","following_url":"https://api.github.com/users/leseb/following{/other_user}","gists_url":"https://api.github.com/users/leseb/gists{/gist_id}","starred_url":"https://api.github.com/users/leseb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leseb/subscriptions","organizations_url":"https://api.github.com/users/leseb/orgs","repos_url":"https://api.github.com/users/leseb/repos","events_url":"https://api.github.com/users/leseb/events{/privacy}","received_events_url":"https://api.github.com/users/leseb/received_events","type":"User","site_admin":false},"body":"I don't think this is true anymore, given that flavors are internal now.","created_at":"2018-12-17T13:00:58Z","updated_at":"2018-12-17T13:05:49Z","html_url":"https://github.com/ceph/cn/pull/100#discussion_r242136893","pull_request_url":"https://api.github.com/repos/ceph/cn/pulls/100","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ceph/cn/pulls/comments/242136893"},"html":{"href":"https://github.com/ceph/cn/pull/100#discussion_r242136893"},"pull_request":{"href":"https://api.github.com/repos/ceph/cn/pulls/100"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/cn/pulls/100","id":236816067,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2ODE2MDY3","html_url":"https://github.com/ceph/cn/pull/100","diff_url":"https://github.com/ceph/cn/pull/100.diff","patch_url":"https://github.com/ceph/cn/pull/100.patch","issue_url":"https://api.github.com/repos/ceph/cn/issues/100","number":100,"state":"open","locked":false,"title":"Implementing configuration file","user":{"login":"ErwanAliasr1","id":4539421,"node_id":"MDQ6VXNlcjQ1Mzk0MjE=","avatar_url":"https://avatars3.githubusercontent.com/u/4539421?v=4","gravatar_id":"","url":"https://api.github.com/users/ErwanAliasr1","html_url":"https://github.com/ErwanAliasr1","followers_url":"https://api.github.com/users/ErwanAliasr1/followers","following_url":"https://api.github.com/users/ErwanAliasr1/following{/other_user}","gists_url":"https://api.github.com/users/ErwanAliasr1/gists{/gist_id}","starred_url":"https://api.github.com/users/ErwanAliasr1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ErwanAliasr1/subscriptions","organizations_url":"https://api.github.com/users/ErwanAliasr1/orgs","repos_url":"https://api.github.com/users/ErwanAliasr1/repos","events_url":"https://api.github.com/users/ErwanAliasr1/events{/privacy}","received_events_url":"https://api.github.com/users/ErwanAliasr1/received_events","type":"User","site_admin":false},"body":"As per issue #94 & #53 , we need to implement a configuration file to tune the behavior of ceph-nano regarding the expectations of users.\r\n\r\nThis PR will implement all the needed to get a configuration mecanism to override or define some tuning parameters.\r\n\r\nAs the exisiting cn is not supporting any config file, not having one must not be fatal.","created_at":"2018-12-07T10:14:00Z","updated_at":"2018-12-17T13:05:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"147a7d00d7470d57059d75bdea6d9114cb64e6bc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/cn/pulls/100/commits","review_comments_url":"https://api.github.com/repos/ceph/cn/pulls/100/comments","review_comment_url":"https://api.github.com/repos/ceph/cn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/cn/issues/100/comments","statuses_url":"https://api.github.com/repos/ceph/cn/statuses/09e24cfcfb8642e3eba2ee3804e4e198bf909546","head":{"label":"ceph:evelu-config","ref":"evelu-config","sha":"09e24cfcfb8642e3eba2ee3804e4e198bf909546","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":112131383,"node_id":"MDEwOlJlcG9zaXRvcnkxMTIxMzEzODM=","name":"cn","full_name":"ceph/cn","private":false,"owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ceph/cn","description":"Ceph Nano - One step S3 in container with Ceph.","fork":false,"url":"https://api.github.com/repos/ceph/cn","forks_url":"https://api.github.com/repos/ceph/cn/forks","keys_url":"https://api.github.com/repos/ceph/cn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/cn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/cn/teams","hooks_url":"https://api.github.com/repos/ceph/cn/hooks","issue_events_url":"https://api.github.com/repos/ceph/cn/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/cn/events","assignees_url":"https://api.github.com/repos/ceph/cn/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/cn/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/cn/tags","blobs_url":"https://api.github.com/repos/ceph/cn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/cn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/cn/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/cn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/cn/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/cn/languages","stargazers_url":"https://api.github.com/repos/ceph/cn/stargazers","contributors_url":"https://api.github.com/repos/ceph/cn/contributors","subscribers_url":"https://api.github.com/repos/ceph/cn/subscribers","subscription_url":"https://api.github.com/repos/ceph/cn/subscription","commits_url":"https://api.github.com/repos/ceph/cn/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/cn/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/cn/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/cn/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/cn/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/cn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/cn/merges","archive_url":"https://api.github.com/repos/ceph/cn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/cn/downloads","issues_url":"https://api.github.com/repos/ceph/cn/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/cn/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/cn/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/cn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/cn/labels{/name}","releases_url":"https://api.github.com/repos/ceph/cn/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/cn/deployments","created_at":"2017-11-27T01:19:15Z","updated_at":"2018-12-17T08:56:00Z","pushed_at":"2018-12-17T10:24:49Z","git_url":"git://github.com/ceph/cn.git","ssh_url":"git@github.com:ceph/cn.git","clone_url":"https://github.com/ceph/cn.git","svn_url":"https://github.com/ceph/cn","homepage":"","size":377,"stargazers_count":87,"watchers_count":87,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":12,"license":null,"forks":13,"open_issues":12,"watchers":87,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"3db4d1f94ad84182e8450d101e30f765a3976fe8","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":112131383,"node_id":"MDEwOlJlcG9zaXRvcnkxMTIxMzEzODM=","name":"cn","full_name":"ceph/cn","private":false,"owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ceph/cn","description":"Ceph Nano - One step S3 in container with Ceph.","fork":false,"url":"https://api.github.com/repos/ceph/cn","forks_url":"https://api.github.com/repos/ceph/cn/forks","keys_url":"https://api.github.com/repos/ceph/cn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/cn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/cn/teams","hooks_url":"https://api.github.com/repos/ceph/cn/hooks","issue_events_url":"https://api.github.com/repos/ceph/cn/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/cn/events","assignees_url":"https://api.github.com/repos/ceph/cn/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/cn/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/cn/tags","blobs_url":"https://api.github.com/repos/ceph/cn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/cn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/cn/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/cn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/cn/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/cn/languages","stargazers_url":"https://api.github.com/repos/ceph/cn/stargazers","contributors_url":"https://api.github.com/repos/ceph/cn/contributors","subscribers_url":"https://api.github.com/repos/ceph/cn/subscribers","subscription_url":"https://api.github.com/repos/ceph/cn/subscription","commits_url":"https://api.github.com/repos/ceph/cn/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/cn/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/cn/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/cn/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/cn/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/cn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/cn/merges","archive_url":"https://api.github.com/repos/ceph/cn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/cn/downloads","issues_url":"https://api.github.com/repos/ceph/cn/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/cn/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/cn/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/cn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/cn/labels{/name}","releases_url":"https://api.github.com/repos/ceph/cn/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/cn/deployments","created_at":"2017-11-27T01:19:15Z","updated_at":"2018-12-17T08:56:00Z","pushed_at":"2018-12-17T10:24:49Z","git_url":"git://github.com/ceph/cn.git","ssh_url":"git@github.com:ceph/cn.git","clone_url":"https://github.com/ceph/cn.git","svn_url":"https://github.com/ceph/cn","homepage":"","size":377,"stargazers_count":87,"watchers_count":87,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":12,"license":null,"forks":13,"open_issues":12,"watchers":87,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/cn/pulls/100"},"html":{"href":"https://github.com/ceph/cn/pull/100"},"issue":{"href":"https://api.github.com/repos/ceph/cn/issues/100"},"comments":{"href":"https://api.github.com/repos/ceph/cn/issues/100/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/cn/pulls/100/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/cn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/cn/pulls/100/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/cn/statuses/09e24cfcfb8642e3eba2ee3804e4e198bf909546"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"leseb"}}