{"action":"created","issue":{"url":"https://api.github.com/repos/octokit/webhooks.js/issues/23","repository_url":"https://api.github.com/repos/octokit/webhooks.js","labels_url":"https://api.github.com/repos/octokit/webhooks.js/issues/23/labels{/name}","comments_url":"https://api.github.com/repos/octokit/webhooks.js/issues/23/comments","events_url":"https://api.github.com/repos/octokit/webhooks.js/issues/23/events","html_url":"https://github.com/octokit/webhooks.js/pull/23","id":310656273,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc4OTY3MzYz","number":23,"title":"adding failing test for request.body","user":{"login":"dylancarlone","id":1057162,"node_id":"MDQ6VXNlcjEwNTcxNjI=","avatar_url":"https://avatars0.githubusercontent.com/u/1057162?v=4","gravatar_id":"","url":"https://api.github.com/users/dylancarlone","html_url":"https://github.com/dylancarlone","followers_url":"https://api.github.com/users/dylancarlone/followers","following_url":"https://api.github.com/users/dylancarlone/following{/other_user}","gists_url":"https://api.github.com/users/dylancarlone/gists{/gist_id}","starred_url":"https://api.github.com/users/dylancarlone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dylancarlone/subscriptions","organizations_url":"https://api.github.com/users/dylancarlone/orgs","repos_url":"https://api.github.com/users/dylancarlone/repos","events_url":"https://api.github.com/users/dylancarlone/events{/privacy}","received_events_url":"https://api.github.com/users/dylancarlone/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"gr2m","id":39992,"node_id":"MDQ6VXNlcjM5OTky","avatar_url":"https://avatars3.githubusercontent.com/u/39992?v=4","gravatar_id":"","url":"https://api.github.com/users/gr2m","html_url":"https://github.com/gr2m","followers_url":"https://api.github.com/users/gr2m/followers","following_url":"https://api.github.com/users/gr2m/following{/other_user}","gists_url":"https://api.github.com/users/gr2m/gists{/gist_id}","starred_url":"https://api.github.com/users/gr2m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gr2m/subscriptions","organizations_url":"https://api.github.com/users/gr2m/orgs","repos_url":"https://api.github.com/users/gr2m/repos","events_url":"https://api.github.com/users/gr2m/events{/privacy}","received_events_url":"https://api.github.com/users/gr2m/received_events","type":"User","site_admin":false},"assignees":[{"login":"gr2m","id":39992,"node_id":"MDQ6VXNlcjM5OTky","avatar_url":"https://avatars3.githubusercontent.com/u/39992?v=4","gravatar_id":"","url":"https://api.github.com/users/gr2m","html_url":"https://github.com/gr2m","followers_url":"https://api.github.com/users/gr2m/followers","following_url":"https://api.github.com/users/gr2m/following{/other_user}","gists_url":"https://api.github.com/users/gr2m/gists{/gist_id}","starred_url":"https://api.github.com/users/gr2m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gr2m/subscriptions","organizations_url":"https://api.github.com/users/gr2m/orgs","repos_url":"https://api.github.com/users/gr2m/repos","events_url":"https://api.github.com/users/gr2m/events{/privacy}","received_events_url":"https://api.github.com/users/gr2m/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-04-03T00:45:57Z","updated_at":"2018-10-22T06:58:47Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/octokit/webhooks.js/pulls/23","html_url":"https://github.com/octokit/webhooks.js/pull/23","diff_url":"https://github.com/octokit/webhooks.js/pull/23.diff","patch_url":"https://github.com/octokit/webhooks.js/pull/23.patch"},"body":"This test shows that the middleware will hang when request.body is created by consuming the request data stream. "},"comment":{"url":"https://api.github.com/repos/octokit/webhooks.js/issues/comments/431754730","html_url":"https://github.com/octokit/webhooks.js/pull/23#issuecomment-431754730","issue_url":"https://api.github.com/repos/octokit/webhooks.js/issues/23","id":431754730,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTc1NDczMA==","user":{"login":"dylancarlone","id":1057162,"node_id":"MDQ6VXNlcjEwNTcxNjI=","avatar_url":"https://avatars0.githubusercontent.com/u/1057162?v=4","gravatar_id":"","url":"https://api.github.com/users/dylancarlone","html_url":"https://github.com/dylancarlone","followers_url":"https://api.github.com/users/dylancarlone/followers","following_url":"https://api.github.com/users/dylancarlone/following{/other_user}","gists_url":"https://api.github.com/users/dylancarlone/gists{/gist_id}","starred_url":"https://api.github.com/users/dylancarlone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dylancarlone/subscriptions","organizations_url":"https://api.github.com/users/dylancarlone/orgs","repos_url":"https://api.github.com/users/dylancarlone/repos","events_url":"https://api.github.com/users/dylancarlone/events{/privacy}","received_events_url":"https://api.github.com/users/dylancarlone/received_events","type":"User","site_admin":false},"created_at":"2018-10-22T06:58:47Z","updated_at":"2018-10-22T06:58:47Z","author_association":"NONE","body":"@BerkeleyTrue I had success duplicating the logic I added to this PR in my own app:\r\nhttps://github.com/octokit/webhooks.js/blob/41c0930737c635e926f8c360a1a531c5e6fd5a24/middleware/middleware.js#L70\r\n\r\nMy problem initially came from FireBase parsing the request body before any of my own code ran."}}
{"actor":{"display_login":"dylancarlone"}}