{"action":"created","comment":{"url":"https://api.github.com/repos/carldata/timeseries/pulls/comments/168760352","pull_request_review_id":97182576,"id":168760352,"diff_hunk":"@@ -132,6 +133,18 @@ object TimeSeries {\n     Iterator.iterate(start)(_.plusNanos(delta.toNanos)).takeWhile(_.isBefore(end)).toVector\n   }\n \n+  /** Find most frequent duration in time series */\n+  def resolution[V: Numeric](ts: TimeSeries[V]): Duration = {","path":"src/main/scala/carldata/series/TimeSeries.scala","position":12,"original_position":12,"commit_id":"b0bf75dff30a50b3a3bb4c7f0f2d1e0135e4cc69","original_commit_id":"b0bf75dff30a50b3a3bb4c7f0f2d1e0135e4cc69","user":{"login":"klangner","id":420474,"avatar_url":"https://avatars0.githubusercontent.com/u/420474?v=4","gravatar_id":"","url":"https://api.github.com/users/klangner","html_url":"https://github.com/klangner","followers_url":"https://api.github.com/users/klangner/followers","following_url":"https://api.github.com/users/klangner/following{/other_user}","gists_url":"https://api.github.com/users/klangner/gists{/gist_id}","starred_url":"https://api.github.com/users/klangner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klangner/subscriptions","organizations_url":"https://api.github.com/users/klangner/orgs","repos_url":"https://api.github.com/users/klangner/repos","events_url":"https://api.github.com/users/klangner/events{/privacy}","received_events_url":"https://api.github.com/users/klangner/received_events","type":"User","site_admin":false},"body":"Maybe one more thing. It would be better to define it is val:\r\n```scala\r\nval resolution: Duration = {\r\n ...\r\n}\r\n```","created_at":"2018-02-16T13:50:20Z","updated_at":"2018-02-16T13:50:28Z","html_url":"https://github.com/carldata/timeseries/pull/98#discussion_r168760352","pull_request_url":"https://api.github.com/repos/carldata/timeseries/pulls/98","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/carldata/timeseries/pulls/comments/168760352"},"html":{"href":"https://github.com/carldata/timeseries/pull/98#discussion_r168760352"},"pull_request":{"href":"https://api.github.com/repos/carldata/timeseries/pulls/98"}}},"pull_request":{"url":"https://api.github.com/repos/carldata/timeseries/pulls/98","id":169626262,"html_url":"https://github.com/carldata/timeseries/pull/98","diff_url":"https://github.com/carldata/timeseries/pull/98.diff","patch_url":"https://github.com/carldata/timeseries/pull/98.patch","issue_url":"https://api.github.com/repos/carldata/timeseries/issues/98","number":98,"state":"open","locked":false,"title":"Create resolution function. Fixed #96","user":{"login":"wenta","id":5645998,"avatar_url":"https://avatars0.githubusercontent.com/u/5645998?v=4","gravatar_id":"","url":"https://api.github.com/users/wenta","html_url":"https://github.com/wenta","followers_url":"https://api.github.com/users/wenta/followers","following_url":"https://api.github.com/users/wenta/following{/other_user}","gists_url":"https://api.github.com/users/wenta/gists{/gist_id}","starred_url":"https://api.github.com/users/wenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wenta/subscriptions","organizations_url":"https://api.github.com/users/wenta/orgs","repos_url":"https://api.github.com/users/wenta/repos","events_url":"https://api.github.com/users/wenta/events{/privacy}","received_events_url":"https://api.github.com/users/wenta/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-16T13:39:06Z","updated_at":"2018-02-16T13:50:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"58b422eb91dbd8c627e6b395962342cdd1b1caa7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/carldata/timeseries/pulls/98/commits","review_comments_url":"https://api.github.com/repos/carldata/timeseries/pulls/98/comments","review_comment_url":"https://api.github.com/repos/carldata/timeseries/pulls/comments{/number}","comments_url":"https://api.github.com/repos/carldata/timeseries/issues/98/comments","statuses_url":"https://api.github.com/repos/carldata/timeseries/statuses/b0bf75dff30a50b3a3bb4c7f0f2d1e0135e4cc69","head":{"label":"carldata:Issue_#96","ref":"Issue_#96","sha":"b0bf75dff30a50b3a3bb4c7f0f2d1e0135e4cc69","user":{"login":"carldata","id":22315557,"avatar_url":"https://avatars2.githubusercontent.com/u/22315557?v=4","gravatar_id":"","url":"https://api.github.com/users/carldata","html_url":"https://github.com/carldata","followers_url":"https://api.github.com/users/carldata/followers","following_url":"https://api.github.com/users/carldata/following{/other_user}","gists_url":"https://api.github.com/users/carldata/gists{/gist_id}","starred_url":"https://api.github.com/users/carldata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carldata/subscriptions","organizations_url":"https://api.github.com/users/carldata/orgs","repos_url":"https://api.github.com/users/carldata/repos","events_url":"https://api.github.com/users/carldata/events{/privacy}","received_events_url":"https://api.github.com/users/carldata/received_events","type":"Organization","site_admin":false},"repo":{"id":97588608,"name":"timeseries","full_name":"carldata/timeseries","owner":{"login":"carldata","id":22315557,"avatar_url":"https://avatars2.githubusercontent.com/u/22315557?v=4","gravatar_id":"","url":"https://api.github.com/users/carldata","html_url":"https://github.com/carldata","followers_url":"https://api.github.com/users/carldata/followers","following_url":"https://api.github.com/users/carldata/following{/other_user}","gists_url":"https://api.github.com/users/carldata/gists{/gist_id}","starred_url":"https://api.github.com/users/carldata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carldata/subscriptions","organizations_url":"https://api.github.com/users/carldata/orgs","repos_url":"https://api.github.com/users/carldata/repos","events_url":"https://api.github.com/users/carldata/events{/privacy}","received_events_url":"https://api.github.com/users/carldata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/carldata/timeseries","description":"Time Series library for Scala","fork":false,"url":"https://api.github.com/repos/carldata/timeseries","forks_url":"https://api.github.com/repos/carldata/timeseries/forks","keys_url":"https://api.github.com/repos/carldata/timeseries/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carldata/timeseries/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carldata/timeseries/teams","hooks_url":"https://api.github.com/repos/carldata/timeseries/hooks","issue_events_url":"https://api.github.com/repos/carldata/timeseries/issues/events{/number}","events_url":"https://api.github.com/repos/carldata/timeseries/events","assignees_url":"https://api.github.com/repos/carldata/timeseries/assignees{/user}","branches_url":"https://api.github.com/repos/carldata/timeseries/branches{/branch}","tags_url":"https://api.github.com/repos/carldata/timeseries/tags","blobs_url":"https://api.github.com/repos/carldata/timeseries/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carldata/timeseries/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carldata/timeseries/git/refs{/sha}","trees_url":"https://api.github.com/repos/carldata/timeseries/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carldata/timeseries/statuses/{sha}","languages_url":"https://api.github.com/repos/carldata/timeseries/languages","stargazers_url":"https://api.github.com/repos/carldata/timeseries/stargazers","contributors_url":"https://api.github.com/repos/carldata/timeseries/contributors","subscribers_url":"https://api.github.com/repos/carldata/timeseries/subscribers","subscription_url":"https://api.github.com/repos/carldata/timeseries/subscription","commits_url":"https://api.github.com/repos/carldata/timeseries/commits{/sha}","git_commits_url":"https://api.github.com/repos/carldata/timeseries/git/commits{/sha}","comments_url":"https://api.github.com/repos/carldata/timeseries/comments{/number}","issue_comment_url":"https://api.github.com/repos/carldata/timeseries/issues/comments{/number}","contents_url":"https://api.github.com/repos/carldata/timeseries/contents/{+path}","compare_url":"https://api.github.com/repos/carldata/timeseries/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carldata/timeseries/merges","archive_url":"https://api.github.com/repos/carldata/timeseries/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carldata/timeseries/downloads","issues_url":"https://api.github.com/repos/carldata/timeseries/issues{/number}","pulls_url":"https://api.github.com/repos/carldata/timeseries/pulls{/number}","milestones_url":"https://api.github.com/repos/carldata/timeseries/milestones{/number}","notifications_url":"https://api.github.com/repos/carldata/timeseries/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carldata/timeseries/labels{/name}","releases_url":"https://api.github.com/repos/carldata/timeseries/releases{/id}","deployments_url":"https://api.github.com/repos/carldata/timeseries/deployments","created_at":"2017-07-18T11:06:46Z","updated_at":"2017-11-11T21:03:06Z","pushed_at":"2018-02-16T13:39:06Z","git_url":"git://github.com/carldata/timeseries.git","ssh_url":"git@github.com:carldata/timeseries.git","clone_url":"https://github.com/carldata/timeseries.git","svn_url":"https://github.com/carldata/timeseries","homepage":"","size":831,"stargazers_count":5,"watchers_count":5,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":9,"watchers":5,"default_branch":"master"}},"base":{"label":"carldata:master","ref":"master","sha":"9cafd69a9b6d0c67cfb8142d6910fd91d8a1defb","user":{"login":"carldata","id":22315557,"avatar_url":"https://avatars2.githubusercontent.com/u/22315557?v=4","gravatar_id":"","url":"https://api.github.com/users/carldata","html_url":"https://github.com/carldata","followers_url":"https://api.github.com/users/carldata/followers","following_url":"https://api.github.com/users/carldata/following{/other_user}","gists_url":"https://api.github.com/users/carldata/gists{/gist_id}","starred_url":"https://api.github.com/users/carldata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carldata/subscriptions","organizations_url":"https://api.github.com/users/carldata/orgs","repos_url":"https://api.github.com/users/carldata/repos","events_url":"https://api.github.com/users/carldata/events{/privacy}","received_events_url":"https://api.github.com/users/carldata/received_events","type":"Organization","site_admin":false},"repo":{"id":97588608,"name":"timeseries","full_name":"carldata/timeseries","owner":{"login":"carldata","id":22315557,"avatar_url":"https://avatars2.githubusercontent.com/u/22315557?v=4","gravatar_id":"","url":"https://api.github.com/users/carldata","html_url":"https://github.com/carldata","followers_url":"https://api.github.com/users/carldata/followers","following_url":"https://api.github.com/users/carldata/following{/other_user}","gists_url":"https://api.github.com/users/carldata/gists{/gist_id}","starred_url":"https://api.github.com/users/carldata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carldata/subscriptions","organizations_url":"https://api.github.com/users/carldata/orgs","repos_url":"https://api.github.com/users/carldata/repos","events_url":"https://api.github.com/users/carldata/events{/privacy}","received_events_url":"https://api.github.com/users/carldata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/carldata/timeseries","description":"Time Series library for Scala","fork":false,"url":"https://api.github.com/repos/carldata/timeseries","forks_url":"https://api.github.com/repos/carldata/timeseries/forks","keys_url":"https://api.github.com/repos/carldata/timeseries/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carldata/timeseries/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carldata/timeseries/teams","hooks_url":"https://api.github.com/repos/carldata/timeseries/hooks","issue_events_url":"https://api.github.com/repos/carldata/timeseries/issues/events{/number}","events_url":"https://api.github.com/repos/carldata/timeseries/events","assignees_url":"https://api.github.com/repos/carldata/timeseries/assignees{/user}","branches_url":"https://api.github.com/repos/carldata/timeseries/branches{/branch}","tags_url":"https://api.github.com/repos/carldata/timeseries/tags","blobs_url":"https://api.github.com/repos/carldata/timeseries/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carldata/timeseries/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carldata/timeseries/git/refs{/sha}","trees_url":"https://api.github.com/repos/carldata/timeseries/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carldata/timeseries/statuses/{sha}","languages_url":"https://api.github.com/repos/carldata/timeseries/languages","stargazers_url":"https://api.github.com/repos/carldata/timeseries/stargazers","contributors_url":"https://api.github.com/repos/carldata/timeseries/contributors","subscribers_url":"https://api.github.com/repos/carldata/timeseries/subscribers","subscription_url":"https://api.github.com/repos/carldata/timeseries/subscription","commits_url":"https://api.github.com/repos/carldata/timeseries/commits{/sha}","git_commits_url":"https://api.github.com/repos/carldata/timeseries/git/commits{/sha}","comments_url":"https://api.github.com/repos/carldata/timeseries/comments{/number}","issue_comment_url":"https://api.github.com/repos/carldata/timeseries/issues/comments{/number}","contents_url":"https://api.github.com/repos/carldata/timeseries/contents/{+path}","compare_url":"https://api.github.com/repos/carldata/timeseries/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carldata/timeseries/merges","archive_url":"https://api.github.com/repos/carldata/timeseries/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carldata/timeseries/downloads","issues_url":"https://api.github.com/repos/carldata/timeseries/issues{/number}","pulls_url":"https://api.github.com/repos/carldata/timeseries/pulls{/number}","milestones_url":"https://api.github.com/repos/carldata/timeseries/milestones{/number}","notifications_url":"https://api.github.com/repos/carldata/timeseries/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carldata/timeseries/labels{/name}","releases_url":"https://api.github.com/repos/carldata/timeseries/releases{/id}","deployments_url":"https://api.github.com/repos/carldata/timeseries/deployments","created_at":"2017-07-18T11:06:46Z","updated_at":"2017-11-11T21:03:06Z","pushed_at":"2018-02-16T13:39:06Z","git_url":"git://github.com/carldata/timeseries.git","ssh_url":"git@github.com:carldata/timeseries.git","clone_url":"https://github.com/carldata/timeseries.git","svn_url":"https://github.com/carldata/timeseries","homepage":"","size":831,"stargazers_count":5,"watchers_count":5,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":9,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/carldata/timeseries/pulls/98"},"html":{"href":"https://github.com/carldata/timeseries/pull/98"},"issue":{"href":"https://api.github.com/repos/carldata/timeseries/issues/98"},"comments":{"href":"https://api.github.com/repos/carldata/timeseries/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/carldata/timeseries/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/carldata/timeseries/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/carldata/timeseries/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/carldata/timeseries/statuses/b0bf75dff30a50b3a3bb4c7f0f2d1e0135e4cc69"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"klangner"}}