{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/vsts-agent/pulls/comments/201613954","pull_request_review_id":136145639,"id":201613954,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTYxMzk1NA==","diff_hunk":"@@ -389,6 +391,35 @@ private List<TestCaseResultData> ReadActualResults(XmlNodeList resultsNodes, str\n \n                 resultCreateModel.RunBy = _runUserIdRef;\n \n+                List<string> resulLeveltAttachments = new List<string>() { };\n+\n+                XmlNodeList resultAttachmentNodes = resultNode.SelectNodes(\"CollectorDataEntries/Collector/UriAttachments/UriAttachment/A\");\n+                if (resultAttachmentNodes.Count > 0 && executionId != null)\n+                {\n+                    foreach (XmlNode resultAttachmentNode in resultAttachmentNodes)\n+                    {\n+                        if (resultAttachmentNode.Attributes[\"href\"] != null && resultAttachmentNode.Attributes[\"href\"].Value != null)\n+                        {\n+                            resulLeveltAttachments.Add(Path.Combine(_attachmentLocation, executionId, resultAttachmentNode.Attributes[\"href\"].Value));\n+                        }\n+                    }\n+                }\n+\n+                XmlNodeList resultFileNodes = resultNode.SelectNodes(\"ResultFiles/ResultFile\");\n+\n+                if (resultFileNodes.Count > 0 && executionId != null)\n+                {\n+                    foreach (XmlNode resultFileNode in resultFileNodes)\n+                    {\n+                        if (resultFileNode.Attributes[\"path\"] != null && resultFileNode.Attributes[\"path\"].Value != null)\n+                        {\n+                            resulLeveltAttachments.Add(Path.Combine(_attachmentLocation, executionId, resultFileNode.Attributes[\"path\"].Value));\n+                        }\n+                    }\n+                }\n+\n+                resultCreateModel.AttachmentData = new AttachmentData() { AttachmentsFilePathList = resulLeveltAttachments.ToArray() };","path":"src/Agent.Worker/TestResults/TrxResultReader.cs","position":76,"original_position":76,"commit_id":"b242338ffc85457d5fff2c4935757f1f808774eb","original_commit_id":"b242338ffc85457d5fff2c4935757f1f808774eb","user":{"login":"navin22","id":19592945,"node_id":"MDQ6VXNlcjE5NTkyOTQ1","avatar_url":"https://avatars1.githubusercontent.com/u/19592945?v=4","gravatar_id":"","url":"https://api.github.com/users/navin22","html_url":"https://github.com/navin22","followers_url":"https://api.github.com/users/navin22/followers","following_url":"https://api.github.com/users/navin22/following{/other_user}","gists_url":"https://api.github.com/users/navin22/gists{/gist_id}","starred_url":"https://api.github.com/users/navin22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navin22/subscriptions","organizations_url":"https://api.github.com/users/navin22/orgs","repos_url":"https://api.github.com/users/navin22/repos","events_url":"https://api.github.com/users/navin22/events{/privacy}","received_events_url":"https://api.github.com/users/navin22/received_events","type":"User","site_admin":false},"body":"Refactor into a new method","created_at":"2018-07-11T08:59:32Z","updated_at":"2018-07-11T09:02:46Z","html_url":"https://github.com/Microsoft/vsts-agent/pull/1697#discussion_r201613954","pull_request_url":"https://api.github.com/repos/Microsoft/vsts-agent/pulls/1697","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vsts-agent/pulls/comments/201613954"},"html":{"href":"https://github.com/Microsoft/vsts-agent/pull/1697#discussion_r201613954"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/vsts-agent/pulls/1697"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/vsts-agent/pulls/1697","id":200596670,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNTk2Njcw","html_url":"https://github.com/Microsoft/vsts-agent/pull/1697","diff_url":"https://github.com/Microsoft/vsts-agent/pull/1697.diff","patch_url":"https://github.com/Microsoft/vsts-agent/pull/1697.patch","issue_url":"https://api.github.com/repos/Microsoft/vsts-agent/issues/1697","number":1697,"state":"open","locked":false,"title":"trx parsing for hierarchical results","user":{"login":"Sachin077","id":7456601,"node_id":"MDQ6VXNlcjc0NTY2MDE=","avatar_url":"https://avatars0.githubusercontent.com/u/7456601?v=4","gravatar_id":"","url":"https://api.github.com/users/Sachin077","html_url":"https://github.com/Sachin077","followers_url":"https://api.github.com/users/Sachin077/followers","following_url":"https://api.github.com/users/Sachin077/following{/other_user}","gists_url":"https://api.github.com/users/Sachin077/gists{/gist_id}","starred_url":"https://api.github.com/users/Sachin077/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sachin077/subscriptions","organizations_url":"https://api.github.com/users/Sachin077/orgs","repos_url":"https://api.github.com/users/Sachin077/repos","events_url":"https://api.github.com/users/Sachin077/events{/privacy}","received_events_url":"https://api.github.com/users/Sachin077/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-11T06:16:27Z","updated_at":"2018-07-11T09:02:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df2fa9d0de60b1232af26d25acfbded12bec5a66","assignee":null,"assignees":[],"requested_reviewers":[{"login":"SadagopanRajaram","id":22239082,"node_id":"MDQ6VXNlcjIyMjM5MDgy","avatar_url":"https://avatars0.githubusercontent.com/u/22239082?v=4","gravatar_id":"","url":"https://api.github.com/users/SadagopanRajaram","html_url":"https://github.com/SadagopanRajaram","followers_url":"https://api.github.com/users/SadagopanRajaram/followers","following_url":"https://api.github.com/users/SadagopanRajaram/following{/other_user}","gists_url":"https://api.github.com/users/SadagopanRajaram/gists{/gist_id}","starred_url":"https://api.github.com/users/SadagopanRajaram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SadagopanRajaram/subscriptions","organizations_url":"https://api.github.com/users/SadagopanRajaram/orgs","repos_url":"https://api.github.com/users/SadagopanRajaram/repos","events_url":"https://api.github.com/users/SadagopanRajaram/events{/privacy}","received_events_url":"https://api.github.com/users/SadagopanRajaram/received_events","type":"User","site_admin":false},{"login":"puagarwa","id":28705989,"node_id":"MDQ6VXNlcjI4NzA1OTg5","avatar_url":"https://avatars0.githubusercontent.com/u/28705989?v=4","gravatar_id":"","url":"https://api.github.com/users/puagarwa","html_url":"https://github.com/puagarwa","followers_url":"https://api.github.com/users/puagarwa/followers","following_url":"https://api.github.com/users/puagarwa/following{/other_user}","gists_url":"https://api.github.com/users/puagarwa/gists{/gist_id}","starred_url":"https://api.github.com/users/puagarwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puagarwa/subscriptions","organizations_url":"https://api.github.com/users/puagarwa/orgs","repos_url":"https://api.github.com/users/puagarwa/repos","events_url":"https://api.github.com/users/puagarwa/events{/privacy}","received_events_url":"https://api.github.com/users/puagarwa/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vsts-agent/pulls/1697/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vsts-agent/pulls/1697/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vsts-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vsts-agent/issues/1697/comments","statuses_url":"https://api.github.com/repos/Microsoft/vsts-agent/statuses/b242338ffc85457d5fff2c4935757f1f808774eb","head":{"label":"Microsoft:users/saaggar/trxParsingForHierarchicalResults","ref":"users/saaggar/trxParsingForHierarchicalResults","sha":"b242338ffc85457d5fff2c4935757f1f808774eb","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":53052789,"node_id":"MDEwOlJlcG9zaXRvcnk1MzA1Mjc4OQ==","name":"vsts-agent","full_name":"Microsoft/vsts-agent","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vsts-agent","description":"Visual Studio Team Services Build and Release Agent","fork":false,"url":"https://api.github.com/repos/Microsoft/vsts-agent","forks_url":"https://api.github.com/repos/Microsoft/vsts-agent/forks","keys_url":"https://api.github.com/repos/Microsoft/vsts-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vsts-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vsts-agent/teams","hooks_url":"https://api.github.com/repos/Microsoft/vsts-agent/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vsts-agent/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vsts-agent/events","assignees_url":"https://api.github.com/repos/Microsoft/vsts-agent/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vsts-agent/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vsts-agent/tags","blobs_url":"https://api.github.com/repos/Microsoft/vsts-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vsts-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vsts-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vsts-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vsts-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vsts-agent/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vsts-agent/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vsts-agent/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vsts-agent/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vsts-agent/subscription","commits_url":"https://api.github.com/repos/Microsoft/vsts-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vsts-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vsts-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vsts-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vsts-agent/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vsts-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vsts-agent/merges","archive_url":"https://api.github.com/repos/Microsoft/vsts-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vsts-agent/downloads","issues_url":"https://api.github.com/repos/Microsoft/vsts-agent/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vsts-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vsts-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vsts-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vsts-agent/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vsts-agent/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vsts-agent/deployments","created_at":"2016-03-03T13:36:48Z","updated_at":"2018-07-10T20:52:49Z","pushed_at":"2018-07-11T08:31:25Z","git_url":"git://github.com/Microsoft/vsts-agent.git","ssh_url":"git@github.com:Microsoft/vsts-agent.git","clone_url":"https://github.com/Microsoft/vsts-agent.git","svn_url":"https://github.com/Microsoft/vsts-agent","homepage":null,"size":6574,"stargazers_count":463,"watchers_count":463,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":289,"mirror_url":null,"archived":false,"open_issues_count":94,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":289,"open_issues":94,"watchers":463,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"5bc3885f6eaa439ce2fb2125714fd9e4ad80b297","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":53052789,"node_id":"MDEwOlJlcG9zaXRvcnk1MzA1Mjc4OQ==","name":"vsts-agent","full_name":"Microsoft/vsts-agent","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vsts-agent","description":"Visual Studio Team Services Build and Release Agent","fork":false,"url":"https://api.github.com/repos/Microsoft/vsts-agent","forks_url":"https://api.github.com/repos/Microsoft/vsts-agent/forks","keys_url":"https://api.github.com/repos/Microsoft/vsts-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vsts-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vsts-agent/teams","hooks_url":"https://api.github.com/repos/Microsoft/vsts-agent/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vsts-agent/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vsts-agent/events","assignees_url":"https://api.github.com/repos/Microsoft/vsts-agent/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vsts-agent/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vsts-agent/tags","blobs_url":"https://api.github.com/repos/Microsoft/vsts-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vsts-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vsts-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vsts-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vsts-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vsts-agent/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vsts-agent/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vsts-agent/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vsts-agent/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vsts-agent/subscription","commits_url":"https://api.github.com/repos/Microsoft/vsts-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vsts-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vsts-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vsts-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vsts-agent/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vsts-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vsts-agent/merges","archive_url":"https://api.github.com/repos/Microsoft/vsts-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vsts-agent/downloads","issues_url":"https://api.github.com/repos/Microsoft/vsts-agent/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vsts-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vsts-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vsts-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vsts-agent/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vsts-agent/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vsts-agent/deployments","created_at":"2016-03-03T13:36:48Z","updated_at":"2018-07-10T20:52:49Z","pushed_at":"2018-07-11T08:31:25Z","git_url":"git://github.com/Microsoft/vsts-agent.git","ssh_url":"git@github.com:Microsoft/vsts-agent.git","clone_url":"https://github.com/Microsoft/vsts-agent.git","svn_url":"https://github.com/Microsoft/vsts-agent","homepage":null,"size":6574,"stargazers_count":463,"watchers_count":463,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":289,"mirror_url":null,"archived":false,"open_issues_count":94,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":289,"open_issues":94,"watchers":463,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vsts-agent/pulls/1697"},"html":{"href":"https://github.com/Microsoft/vsts-agent/pull/1697"},"issue":{"href":"https://api.github.com/repos/Microsoft/vsts-agent/issues/1697"},"comments":{"href":"https://api.github.com/repos/Microsoft/vsts-agent/issues/1697/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vsts-agent/pulls/1697/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vsts-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vsts-agent/pulls/1697/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vsts-agent/statuses/b242338ffc85457d5fff2c4935757f1f808774eb"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"navin22"}}