{"action":"created","comment":{"url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/pulls/comments/231449912","pull_request_review_id":172421398,"id":231449912,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTQ0OTkxMg==","diff_hunk":"@@ -931,6 +993,25 @@ api-usage-monitoring-configuration:\n           Path template in /articles/{article-id} (OpenAPI 3) or in /articles/:article-id format.\n           NOTE: They will be normalized to the :this format for metrics naming.\n         example: /orders/{order-id}\n+    client_tracking_pattern:\n+        description: >\n+            The pattern that the combination `realm.clientId` must match in order for the client\n+            based metrics to be tracked, in form of a regular expression. If it is not provided\n+            or is empty, no client metric is be tracked.\n+        type: string\n+        examples:\n+            disable:\n+                summary: No client metric is tracked.\n+                value: \"\"\n+            everything:\n+                summary: All realms and all client ID are tracked.\n+                value: \".*\"\n+            all_services:\n+                summary: Only log the services.\n+                value: \"services\\\\..*\"\n+            just_some_users:\n+                summary: Only users Joe and and Sabine from realm users are tracked.\n+                value: \"users\\\\.(?:joe|sabine)\"","path":"docs/reference/filters.md","position":124,"original_position":124,"commit_id":"c4b23eda92211e83f1fb618b398a22c5c33b07bd","original_commit_id":"c4b23eda92211e83f1fb618b398a22c5c33b07bd","user":{"login":"ddufourboivin-zalando","id":39987010,"node_id":"MDQ6VXNlcjM5OTg3MDEw","avatar_url":"https://avatars3.githubusercontent.com/u/39987010?v=4","gravatar_id":"","url":"https://api.github.com/users/ddufourboivin-zalando","html_url":"https://github.com/ddufourboivin-zalando","followers_url":"https://api.github.com/users/ddufourboivin-zalando/followers","following_url":"https://api.github.com/users/ddufourboivin-zalando/following{/other_user}","gists_url":"https://api.github.com/users/ddufourboivin-zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/ddufourboivin-zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddufourboivin-zalando/subscriptions","organizations_url":"https://api.github.com/users/ddufourboivin-zalando/orgs","repos_url":"https://api.github.com/users/ddufourboivin-zalando/repos","events_url":"https://api.github.com/users/ddufourboivin-zalando/events{/privacy}","received_events_url":"https://api.github.com/users/ddufourboivin-zalando/received_events","type":"User","site_admin":false},"body":"![image](https://user-images.githubusercontent.com/39987010/48125517-2d16e800-e27f-11e8-9bd4-ccaa25aa4cc9.png)\r\n","created_at":"2018-11-07T10:20:53Z","updated_at":"2018-11-07T10:20:53Z","html_url":"https://github.com/ddufourboivin-zalando/skipper/pull/2#discussion_r231449912","pull_request_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/pulls/2","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ddufourboivin-zalando/skipper/pulls/comments/231449912"},"html":{"href":"https://github.com/ddufourboivin-zalando/skipper/pull/2#discussion_r231449912"},"pull_request":{"href":"https://api.github.com/repos/ddufourboivin-zalando/skipper/pulls/2"}},"in_reply_to_id":231443811},"pull_request":{"url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/pulls/2","id":228689285,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4Njg5Mjg1","html_url":"https://github.com/ddufourboivin-zalando/skipper/pull/2","diff_url":"https://github.com/ddufourboivin-zalando/skipper/pull/2.diff","patch_url":"https://github.com/ddufourboivin-zalando/skipper/pull/2.patch","issue_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/issues/2","number":2,"state":"open","locked":false,"title":"API Usage Monitoring - Caller Metrics - PRE-PR Team Review","user":{"login":"ddufourboivin-zalando","id":39987010,"node_id":"MDQ6VXNlcjM5OTg3MDEw","avatar_url":"https://avatars3.githubusercontent.com/u/39987010?v=4","gravatar_id":"","url":"https://api.github.com/users/ddufourboivin-zalando","html_url":"https://github.com/ddufourboivin-zalando","followers_url":"https://api.github.com/users/ddufourboivin-zalando/followers","following_url":"https://api.github.com/users/ddufourboivin-zalando/following{/other_user}","gists_url":"https://api.github.com/users/ddufourboivin-zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/ddufourboivin-zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddufourboivin-zalando/subscriptions","organizations_url":"https://api.github.com/users/ddufourboivin-zalando/orgs","repos_url":"https://api.github.com/users/ddufourboivin-zalando/repos","events_url":"https://api.github.com/users/ddufourboivin-zalando/events{/privacy}","received_events_url":"https://api.github.com/users/ddufourboivin-zalando/received_events","type":"User","site_admin":false},"body":"🚨🛑 DO NOT MERGE 🛑🚨","created_at":"2018-11-06T13:21:49Z","updated_at":"2018-11-07T10:20:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"feaf7ae149dc8b791c460ba012dee464238cf44c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1118058105,"node_id":"MDU6TGFiZWwxMTE4MDU4MTA1","url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/labels/do-not-merge","name":"do-not-merge","color":"d93f0b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/pulls/2/commits","review_comments_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/pulls/2/comments","review_comment_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/issues/2/comments","statuses_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/statuses/c4b23eda92211e83f1fb618b398a22c5c33b07bd","head":{"label":"ddufourboivin-zalando:apiUsageMonitoring-caller-info","ref":"apiUsageMonitoring-caller-info","sha":"c4b23eda92211e83f1fb618b398a22c5c33b07bd","user":{"login":"ddufourboivin-zalando","id":39987010,"node_id":"MDQ6VXNlcjM5OTg3MDEw","avatar_url":"https://avatars3.githubusercontent.com/u/39987010?v=4","gravatar_id":"","url":"https://api.github.com/users/ddufourboivin-zalando","html_url":"https://github.com/ddufourboivin-zalando","followers_url":"https://api.github.com/users/ddufourboivin-zalando/followers","following_url":"https://api.github.com/users/ddufourboivin-zalando/following{/other_user}","gists_url":"https://api.github.com/users/ddufourboivin-zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/ddufourboivin-zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddufourboivin-zalando/subscriptions","organizations_url":"https://api.github.com/users/ddufourboivin-zalando/orgs","repos_url":"https://api.github.com/users/ddufourboivin-zalando/repos","events_url":"https://api.github.com/users/ddufourboivin-zalando/events{/privacy}","received_events_url":"https://api.github.com/users/ddufourboivin-zalando/received_events","type":"User","site_admin":false},"repo":{"id":147189613,"node_id":"MDEwOlJlcG9zaXRvcnkxNDcxODk2MTM=","name":"skipper","full_name":"ddufourboivin-zalando/skipper","private":false,"owner":{"login":"ddufourboivin-zalando","id":39987010,"node_id":"MDQ6VXNlcjM5OTg3MDEw","avatar_url":"https://avatars3.githubusercontent.com/u/39987010?v=4","gravatar_id":"","url":"https://api.github.com/users/ddufourboivin-zalando","html_url":"https://github.com/ddufourboivin-zalando","followers_url":"https://api.github.com/users/ddufourboivin-zalando/followers","following_url":"https://api.github.com/users/ddufourboivin-zalando/following{/other_user}","gists_url":"https://api.github.com/users/ddufourboivin-zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/ddufourboivin-zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddufourboivin-zalando/subscriptions","organizations_url":"https://api.github.com/users/ddufourboivin-zalando/orgs","repos_url":"https://api.github.com/users/ddufourboivin-zalando/repos","events_url":"https://api.github.com/users/ddufourboivin-zalando/events{/privacy}","received_events_url":"https://api.github.com/users/ddufourboivin-zalando/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ddufourboivin-zalando/skipper","description":"An HTTP router and reverse proxy for service composition, including use cases like Kubernetes Ingress","fork":true,"url":"https://api.github.com/repos/ddufourboivin-zalando/skipper","forks_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/forks","keys_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/teams","hooks_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/hooks","issue_events_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/issues/events{/number}","events_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/events","assignees_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/assignees{/user}","branches_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/branches{/branch}","tags_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/tags","blobs_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/git/refs{/sha}","trees_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/statuses/{sha}","languages_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/languages","stargazers_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/stargazers","contributors_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/contributors","subscribers_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/subscribers","subscription_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/subscription","commits_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/commits{/sha}","git_commits_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/git/commits{/sha}","comments_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/comments{/number}","issue_comment_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/issues/comments{/number}","contents_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/contents/{+path}","compare_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/merges","archive_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/downloads","issues_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/issues{/number}","pulls_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/pulls{/number}","milestones_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/milestones{/number}","notifications_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/labels{/name}","releases_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/releases{/id}","deployments_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/deployments","created_at":"2018-09-03T10:34:55Z","updated_at":"2018-11-02T09:09:43Z","pushed_at":"2018-11-06T14:51:29Z","git_url":"git://github.com/ddufourboivin-zalando/skipper.git","ssh_url":"git@github.com:ddufourboivin-zalando/skipper.git","clone_url":"https://github.com/ddufourboivin-zalando/skipper.git","svn_url":"https://github.com/ddufourboivin-zalando/skipper","homepage":"https://opensource.zalando.com/skipper/","size":8703,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ddufourboivin-zalando:apiUsageMonitoring-caller-info--PRE-PR","ref":"apiUsageMonitoring-caller-info--PRE-PR","sha":"353e69b59f5b61f208d9698c69ffa343e7b186a0","user":{"login":"ddufourboivin-zalando","id":39987010,"node_id":"MDQ6VXNlcjM5OTg3MDEw","avatar_url":"https://avatars3.githubusercontent.com/u/39987010?v=4","gravatar_id":"","url":"https://api.github.com/users/ddufourboivin-zalando","html_url":"https://github.com/ddufourboivin-zalando","followers_url":"https://api.github.com/users/ddufourboivin-zalando/followers","following_url":"https://api.github.com/users/ddufourboivin-zalando/following{/other_user}","gists_url":"https://api.github.com/users/ddufourboivin-zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/ddufourboivin-zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddufourboivin-zalando/subscriptions","organizations_url":"https://api.github.com/users/ddufourboivin-zalando/orgs","repos_url":"https://api.github.com/users/ddufourboivin-zalando/repos","events_url":"https://api.github.com/users/ddufourboivin-zalando/events{/privacy}","received_events_url":"https://api.github.com/users/ddufourboivin-zalando/received_events","type":"User","site_admin":false},"repo":{"id":147189613,"node_id":"MDEwOlJlcG9zaXRvcnkxNDcxODk2MTM=","name":"skipper","full_name":"ddufourboivin-zalando/skipper","private":false,"owner":{"login":"ddufourboivin-zalando","id":39987010,"node_id":"MDQ6VXNlcjM5OTg3MDEw","avatar_url":"https://avatars3.githubusercontent.com/u/39987010?v=4","gravatar_id":"","url":"https://api.github.com/users/ddufourboivin-zalando","html_url":"https://github.com/ddufourboivin-zalando","followers_url":"https://api.github.com/users/ddufourboivin-zalando/followers","following_url":"https://api.github.com/users/ddufourboivin-zalando/following{/other_user}","gists_url":"https://api.github.com/users/ddufourboivin-zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/ddufourboivin-zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddufourboivin-zalando/subscriptions","organizations_url":"https://api.github.com/users/ddufourboivin-zalando/orgs","repos_url":"https://api.github.com/users/ddufourboivin-zalando/repos","events_url":"https://api.github.com/users/ddufourboivin-zalando/events{/privacy}","received_events_url":"https://api.github.com/users/ddufourboivin-zalando/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ddufourboivin-zalando/skipper","description":"An HTTP router and reverse proxy for service composition, including use cases like Kubernetes Ingress","fork":true,"url":"https://api.github.com/repos/ddufourboivin-zalando/skipper","forks_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/forks","keys_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/teams","hooks_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/hooks","issue_events_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/issues/events{/number}","events_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/events","assignees_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/assignees{/user}","branches_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/branches{/branch}","tags_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/tags","blobs_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/git/refs{/sha}","trees_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/statuses/{sha}","languages_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/languages","stargazers_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/stargazers","contributors_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/contributors","subscribers_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/subscribers","subscription_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/subscription","commits_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/commits{/sha}","git_commits_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/git/commits{/sha}","comments_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/comments{/number}","issue_comment_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/issues/comments{/number}","contents_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/contents/{+path}","compare_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/merges","archive_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/downloads","issues_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/issues{/number}","pulls_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/pulls{/number}","milestones_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/milestones{/number}","notifications_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/labels{/name}","releases_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/releases{/id}","deployments_url":"https://api.github.com/repos/ddufourboivin-zalando/skipper/deployments","created_at":"2018-09-03T10:34:55Z","updated_at":"2018-11-02T09:09:43Z","pushed_at":"2018-11-06T14:51:29Z","git_url":"git://github.com/ddufourboivin-zalando/skipper.git","ssh_url":"git@github.com:ddufourboivin-zalando/skipper.git","clone_url":"https://github.com/ddufourboivin-zalando/skipper.git","svn_url":"https://github.com/ddufourboivin-zalando/skipper","homepage":"https://opensource.zalando.com/skipper/","size":8703,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ddufourboivin-zalando/skipper/pulls/2"},"html":{"href":"https://github.com/ddufourboivin-zalando/skipper/pull/2"},"issue":{"href":"https://api.github.com/repos/ddufourboivin-zalando/skipper/issues/2"},"comments":{"href":"https://api.github.com/repos/ddufourboivin-zalando/skipper/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/ddufourboivin-zalando/skipper/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/ddufourboivin-zalando/skipper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ddufourboivin-zalando/skipper/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/ddufourboivin-zalando/skipper/statuses/c4b23eda92211e83f1fb618b398a22c5c33b07bd"}},"author_association":"OWNER"}}
{"actor":{"display_login":"ddufourboivin-zalando"}}