{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/Exawind/nalu-wind/pulls/2","id":187997023,"html_url":"https://github.com/Exawind/nalu-wind/pull/2","diff_url":"https://github.com/Exawind/nalu-wind/pull/2.diff","patch_url":"https://github.com/Exawind/nalu-wind/pull/2.patch","issue_url":"https://api.github.com/repos/Exawind/nalu-wind/issues/2","number":2,"state":"closed","locked":false,"title":"List sources explicitly in CMake","user":{"login":"jrood-nrel","id":23264326,"avatar_url":"https://avatars1.githubusercontent.com/u/23264326?v=4","gravatar_id":"","url":"https://api.github.com/users/jrood-nrel","html_url":"https://github.com/jrood-nrel","followers_url":"https://api.github.com/users/jrood-nrel/followers","following_url":"https://api.github.com/users/jrood-nrel/following{/other_user}","gists_url":"https://api.github.com/users/jrood-nrel/gists{/gist_id}","starred_url":"https://api.github.com/users/jrood-nrel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrood-nrel/subscriptions","organizations_url":"https://api.github.com/users/jrood-nrel/orgs","repos_url":"https://api.github.com/users/jrood-nrel/repos","events_url":"https://api.github.com/users/jrood-nrel/events{/privacy}","received_events_url":"https://api.github.com/users/jrood-nrel/received_events","type":"User","site_admin":false},"body":"- This brings Nalu-Wind closer to CMake best practices\r\n- This allows for CMake to know when files have been modified so the configure will be run again if necessary\r\n- This also allows for conditional omission of source files to get rid of warnings when TPL-specific source files don't have symbols\r\n\r\n@sayerhs This is how I remember listing sources explicitly in CMake in previous projects, but there might be better ways to do this now. I tried to read about using `target_sources` but was not able to understand its advantages or how to use it. I'm considering this a WIP because I'm open to any improvements that can be made on it, but it's ready to review as is.","created_at":"2018-05-15T02:18:20Z","updated_at":"2018-05-15T19:51:39Z","closed_at":"2018-05-15T19:51:39Z","merged_at":"2018-05-15T19:51:39Z","merge_commit_sha":"9a79593ac102cf0d9661921945c6b4f2a42804f8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Exawind/nalu-wind/pulls/2/commits","review_comments_url":"https://api.github.com/repos/Exawind/nalu-wind/pulls/2/comments","review_comment_url":"https://api.github.com/repos/Exawind/nalu-wind/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Exawind/nalu-wind/issues/2/comments","statuses_url":"https://api.github.com/repos/Exawind/nalu-wind/statuses/3362c0746474fbc40958d0433d06fceacca95bee","head":{"label":"jrood-nrel:explicit_sources","ref":"explicit_sources","sha":"3362c0746474fbc40958d0433d06fceacca95bee","user":{"login":"jrood-nrel","id":23264326,"avatar_url":"https://avatars1.githubusercontent.com/u/23264326?v=4","gravatar_id":"","url":"https://api.github.com/users/jrood-nrel","html_url":"https://github.com/jrood-nrel","followers_url":"https://api.github.com/users/jrood-nrel/followers","following_url":"https://api.github.com/users/jrood-nrel/following{/other_user}","gists_url":"https://api.github.com/users/jrood-nrel/gists{/gist_id}","starred_url":"https://api.github.com/users/jrood-nrel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrood-nrel/subscriptions","organizations_url":"https://api.github.com/users/jrood-nrel/orgs","repos_url":"https://api.github.com/users/jrood-nrel/repos","events_url":"https://api.github.com/users/jrood-nrel/events{/privacy}","received_events_url":"https://api.github.com/users/jrood-nrel/received_events","type":"User","site_admin":false},"repo":{"id":133432644,"name":"nalu-wind","full_name":"jrood-nrel/nalu-wind","owner":{"login":"jrood-nrel","id":23264326,"avatar_url":"https://avatars1.githubusercontent.com/u/23264326?v=4","gravatar_id":"","url":"https://api.github.com/users/jrood-nrel","html_url":"https://github.com/jrood-nrel","followers_url":"https://api.github.com/users/jrood-nrel/followers","following_url":"https://api.github.com/users/jrood-nrel/following{/other_user}","gists_url":"https://api.github.com/users/jrood-nrel/gists{/gist_id}","starred_url":"https://api.github.com/users/jrood-nrel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrood-nrel/subscriptions","organizations_url":"https://api.github.com/users/jrood-nrel/orgs","repos_url":"https://api.github.com/users/jrood-nrel/repos","events_url":"https://api.github.com/users/jrood-nrel/events{/privacy}","received_events_url":"https://api.github.com/users/jrood-nrel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrood-nrel/nalu-wind","description":null,"fork":true,"url":"https://api.github.com/repos/jrood-nrel/nalu-wind","forks_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/forks","keys_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/teams","hooks_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/hooks","issue_events_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/issues/events{/number}","events_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/events","assignees_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/assignees{/user}","branches_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/branches{/branch}","tags_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/tags","blobs_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/statuses/{sha}","languages_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/languages","stargazers_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/stargazers","contributors_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/contributors","subscribers_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/subscribers","subscription_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/subscription","commits_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/contents/{+path}","compare_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/merges","archive_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/downloads","issues_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/issues{/number}","pulls_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/pulls{/number}","milestones_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/milestones{/number}","notifications_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/labels{/name}","releases_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/releases{/id}","deployments_url":"https://api.github.com/repos/jrood-nrel/nalu-wind/deployments","created_at":"2018-05-14T23:24:21Z","updated_at":"2018-05-14T23:24:25Z","pushed_at":"2018-05-15T19:28:55Z","git_url":"git://github.com/jrood-nrel/nalu-wind.git","ssh_url":"git@github.com:jrood-nrel/nalu-wind.git","clone_url":"https://github.com/jrood-nrel/nalu-wind.git","svn_url":"https://github.com/jrood-nrel/nalu-wind","homepage":null,"size":11185,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Exawind:master","ref":"master","sha":"75f697bf8fe4d6ee10a918a3bf976b4ffb0d7660","user":{"login":"Exawind","id":22328575,"avatar_url":"https://avatars1.githubusercontent.com/u/22328575?v=4","gravatar_id":"","url":"https://api.github.com/users/Exawind","html_url":"https://github.com/Exawind","followers_url":"https://api.github.com/users/Exawind/followers","following_url":"https://api.github.com/users/Exawind/following{/other_user}","gists_url":"https://api.github.com/users/Exawind/gists{/gist_id}","starred_url":"https://api.github.com/users/Exawind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exawind/subscriptions","organizations_url":"https://api.github.com/users/Exawind/orgs","repos_url":"https://api.github.com/users/Exawind/repos","events_url":"https://api.github.com/users/Exawind/events{/privacy}","received_events_url":"https://api.github.com/users/Exawind/received_events","type":"Organization","site_admin":false},"repo":{"id":132016365,"name":"nalu-wind","full_name":"Exawind/nalu-wind","owner":{"login":"Exawind","id":22328575,"avatar_url":"https://avatars1.githubusercontent.com/u/22328575?v=4","gravatar_id":"","url":"https://api.github.com/users/Exawind","html_url":"https://github.com/Exawind","followers_url":"https://api.github.com/users/Exawind/followers","following_url":"https://api.github.com/users/Exawind/following{/other_user}","gists_url":"https://api.github.com/users/Exawind/gists{/gist_id}","starred_url":"https://api.github.com/users/Exawind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exawind/subscriptions","organizations_url":"https://api.github.com/users/Exawind/orgs","repos_url":"https://api.github.com/users/Exawind/repos","events_url":"https://api.github.com/users/Exawind/events{/privacy}","received_events_url":"https://api.github.com/users/Exawind/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Exawind/nalu-wind","description":null,"fork":false,"url":"https://api.github.com/repos/Exawind/nalu-wind","forks_url":"https://api.github.com/repos/Exawind/nalu-wind/forks","keys_url":"https://api.github.com/repos/Exawind/nalu-wind/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Exawind/nalu-wind/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Exawind/nalu-wind/teams","hooks_url":"https://api.github.com/repos/Exawind/nalu-wind/hooks","issue_events_url":"https://api.github.com/repos/Exawind/nalu-wind/issues/events{/number}","events_url":"https://api.github.com/repos/Exawind/nalu-wind/events","assignees_url":"https://api.github.com/repos/Exawind/nalu-wind/assignees{/user}","branches_url":"https://api.github.com/repos/Exawind/nalu-wind/branches{/branch}","tags_url":"https://api.github.com/repos/Exawind/nalu-wind/tags","blobs_url":"https://api.github.com/repos/Exawind/nalu-wind/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Exawind/nalu-wind/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Exawind/nalu-wind/git/refs{/sha}","trees_url":"https://api.github.com/repos/Exawind/nalu-wind/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Exawind/nalu-wind/statuses/{sha}","languages_url":"https://api.github.com/repos/Exawind/nalu-wind/languages","stargazers_url":"https://api.github.com/repos/Exawind/nalu-wind/stargazers","contributors_url":"https://api.github.com/repos/Exawind/nalu-wind/contributors","subscribers_url":"https://api.github.com/repos/Exawind/nalu-wind/subscribers","subscription_url":"https://api.github.com/repos/Exawind/nalu-wind/subscription","commits_url":"https://api.github.com/repos/Exawind/nalu-wind/commits{/sha}","git_commits_url":"https://api.github.com/repos/Exawind/nalu-wind/git/commits{/sha}","comments_url":"https://api.github.com/repos/Exawind/nalu-wind/comments{/number}","issue_comment_url":"https://api.github.com/repos/Exawind/nalu-wind/issues/comments{/number}","contents_url":"https://api.github.com/repos/Exawind/nalu-wind/contents/{+path}","compare_url":"https://api.github.com/repos/Exawind/nalu-wind/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Exawind/nalu-wind/merges","archive_url":"https://api.github.com/repos/Exawind/nalu-wind/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Exawind/nalu-wind/downloads","issues_url":"https://api.github.com/repos/Exawind/nalu-wind/issues{/number}","pulls_url":"https://api.github.com/repos/Exawind/nalu-wind/pulls{/number}","milestones_url":"https://api.github.com/repos/Exawind/nalu-wind/milestones{/number}","notifications_url":"https://api.github.com/repos/Exawind/nalu-wind/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Exawind/nalu-wind/labels{/name}","releases_url":"https://api.github.com/repos/Exawind/nalu-wind/releases{/id}","deployments_url":"https://api.github.com/repos/Exawind/nalu-wind/deployments","created_at":"2018-05-03T15:39:32Z","updated_at":"2018-05-15T17:41:12Z","pushed_at":"2018-05-15T19:51:39Z","git_url":"git://github.com/Exawind/nalu-wind.git","ssh_url":"git@github.com:Exawind/nalu-wind.git","clone_url":"https://github.com/Exawind/nalu-wind.git","svn_url":"https://github.com/Exawind/nalu-wind","homepage":null,"size":11173,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Exawind/nalu-wind/pulls/2"},"html":{"href":"https://github.com/Exawind/nalu-wind/pull/2"},"issue":{"href":"https://api.github.com/repos/Exawind/nalu-wind/issues/2"},"comments":{"href":"https://api.github.com/repos/Exawind/nalu-wind/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/Exawind/nalu-wind/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/Exawind/nalu-wind/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Exawind/nalu-wind/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/Exawind/nalu-wind/statuses/3362c0746474fbc40958d0433d06fceacca95bee"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jrood-nrel","id":23264326,"avatar_url":"https://avatars1.githubusercontent.com/u/23264326?v=4","gravatar_id":"","url":"https://api.github.com/users/jrood-nrel","html_url":"https://github.com/jrood-nrel","followers_url":"https://api.github.com/users/jrood-nrel/followers","following_url":"https://api.github.com/users/jrood-nrel/following{/other_user}","gists_url":"https://api.github.com/users/jrood-nrel/gists{/gist_id}","starred_url":"https://api.github.com/users/jrood-nrel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrood-nrel/subscriptions","organizations_url":"https://api.github.com/users/jrood-nrel/orgs","repos_url":"https://api.github.com/users/jrood-nrel/repos","events_url":"https://api.github.com/users/jrood-nrel/events{/privacy}","received_events_url":"https://api.github.com/users/jrood-nrel/received_events","type":"User","site_admin":false},"comments":7,"review_comments":6,"maintainer_can_modify":false,"commits":6,"additions":918,"deletions":11,"changed_files":33}}
{"actor":{"display_login":"jrood-nrel"}}