{"action":"created","comment":{"url":"https://api.github.com/repos/grafana/grafana/pulls/comments/197767703","pull_request_review_id":131572815,"id":197767703,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Nzc2NzcwMw==","diff_hunk":"@@ -3,6 +3,7 @@ import { Variable, assignModelProperties, variableTypes } from './variable';\n \n export class AdhocVariable implements Variable {\n   filters: any[];\n+  removeFromUrl: number;","path":"public/app/features/templating/adhoc_variable.ts","position":4,"original_position":4,"commit_id":"ffa3a90aa7d3bb07dacc1a16f190f81c2a89c10c","original_commit_id":"ffa3a90aa7d3bb07dacc1a16f190f81c2a89c10c","user":{"login":"torkelo","id":10999,"node_id":"MDQ6VXNlcjEwOTk5","avatar_url":"https://avatars3.githubusercontent.com/u/10999?v=4","gravatar_id":"","url":"https://api.github.com/users/torkelo","html_url":"https://github.com/torkelo","followers_url":"https://api.github.com/users/torkelo/followers","following_url":"https://api.github.com/users/torkelo/following{/other_user}","gists_url":"https://api.github.com/users/torkelo/gists{/gist_id}","starred_url":"https://api.github.com/users/torkelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torkelo/subscriptions","organizations_url":"https://api.github.com/users/torkelo/orgs","repos_url":"https://api.github.com/users/torkelo/repos","events_url":"https://api.github.com/users/torkelo/events{/privacy}","received_events_url":"https://api.github.com/users/torkelo/received_events","type":"User","site_admin":false},"body":"Think skipUrlSync is better, and make it a boolean?   (removeFromUrl  seems like it's an action that removes it already rendered urls) ","created_at":"2018-06-25T11:49:17Z","updated_at":"2018-06-25T11:55:20Z","html_url":"https://github.com/grafana/grafana/pull/12297#discussion_r197767703","pull_request_url":"https://api.github.com/repos/grafana/grafana/pulls/12297","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/grafana/grafana/pulls/comments/197767703"},"html":{"href":"https://github.com/grafana/grafana/pull/12297#discussion_r197767703"},"pull_request":{"href":"https://api.github.com/repos/grafana/grafana/pulls/12297"}}},"pull_request":{"url":"https://api.github.com/repos/grafana/grafana/pulls/12297","id":195143231,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MTQzMjMx","html_url":"https://github.com/grafana/grafana/pull/12297","diff_url":"https://github.com/grafana/grafana/pull/12297.diff","patch_url":"https://github.com/grafana/grafana/pull/12297.patch","issue_url":"https://api.github.com/repos/grafana/grafana/issues/12297","number":12297,"state":"open","locked":false,"title":"Add support for skipping variable value in URL, fixes #12174","user":{"login":"lukaszgryglicki","id":2469783,"node_id":"MDQ6VXNlcjI0Njk3ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/2469783?v=4","gravatar_id":"","url":"https://api.github.com/users/lukaszgryglicki","html_url":"https://github.com/lukaszgryglicki","followers_url":"https://api.github.com/users/lukaszgryglicki/followers","following_url":"https://api.github.com/users/lukaszgryglicki/following{/other_user}","gists_url":"https://api.github.com/users/lukaszgryglicki/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaszgryglicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaszgryglicki/subscriptions","organizations_url":"https://api.github.com/users/lukaszgryglicki/orgs","repos_url":"https://api.github.com/users/lukaszgryglicki/repos","events_url":"https://api.github.com/users/lukaszgryglicki/events{/privacy}","received_events_url":"https://api.github.com/users/lukaszgryglicki/received_events","type":"User","site_admin":false},"body":"This is an alternate PR because https://github.com/grafana/grafana/pull/12259 was closed.\r\nThis contains no UI changes, it adds JSON only option to allow skipping including template variable value in URL.\r\nPlease see [issue](https://github.com/grafana/grafana/issues/12174) and [closed PR](https://github.com/grafana/grafana/pull/12259) for details\r\n\r\nAdded Template Variable option (JSON only) to remove it from URL.\r\nAvailable for all template variable types.\r\n\r\nSuch template variables with \"removeFromUrl\": \"1\" (in JSON) won't be included in URL when you change any variable value in the dashboard.\r\n\r\nWe need that feature (already working on patched Grafanas to support that).\r\nAll dashboards in https://devstats.cncf.io and https://cncftest.io already use this feature.\r\nAll variables that are hidden also have \"removeFromUrl\": \"1\", so URLs are prettier. I see no sense toi include them in URL because the user cannot change them and initially dashboard has no template variables in the URL (fetches them from whatever source) and that value remains unchanged, so why should it be included in the URL?\r\n\r\nThanks.\r\ncc @dankohn @jberkus @torkelo \r\n\r\nSigned-off-by: Lukasz Gryglicki lukaszgryglicki@o2.pl","created_at":"2018-06-15T11:04:24Z","updated_at":"2018-06-25T11:55:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b5fec3680ad69674d963d65bd463e6b4ff045c1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/grafana/grafana/pulls/12297/commits","review_comments_url":"https://api.github.com/repos/grafana/grafana/pulls/12297/comments","review_comment_url":"https://api.github.com/repos/grafana/grafana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grafana/grafana/issues/12297/comments","statuses_url":"https://api.github.com/repos/grafana/grafana/statuses/ffa3a90aa7d3bb07dacc1a16f190f81c2a89c10c","head":{"label":"lukaszgryglicki:lukaszgryglicki-12174-template-variables-remove-from-url-json-option","ref":"lukaszgryglicki-12174-template-variables-remove-from-url-json-option","sha":"ffa3a90aa7d3bb07dacc1a16f190f81c2a89c10c","user":{"login":"lukaszgryglicki","id":2469783,"node_id":"MDQ6VXNlcjI0Njk3ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/2469783?v=4","gravatar_id":"","url":"https://api.github.com/users/lukaszgryglicki","html_url":"https://github.com/lukaszgryglicki","followers_url":"https://api.github.com/users/lukaszgryglicki/followers","following_url":"https://api.github.com/users/lukaszgryglicki/following{/other_user}","gists_url":"https://api.github.com/users/lukaszgryglicki/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaszgryglicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaszgryglicki/subscriptions","organizations_url":"https://api.github.com/users/lukaszgryglicki/orgs","repos_url":"https://api.github.com/users/lukaszgryglicki/repos","events_url":"https://api.github.com/users/lukaszgryglicki/events{/privacy}","received_events_url":"https://api.github.com/users/lukaszgryglicki/received_events","type":"User","site_admin":false},"repo":{"id":132137799,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIxMzc3OTk=","name":"grafana","full_name":"lukaszgryglicki/grafana","owner":{"login":"lukaszgryglicki","id":2469783,"node_id":"MDQ6VXNlcjI0Njk3ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/2469783?v=4","gravatar_id":"","url":"https://api.github.com/users/lukaszgryglicki","html_url":"https://github.com/lukaszgryglicki","followers_url":"https://api.github.com/users/lukaszgryglicki/followers","following_url":"https://api.github.com/users/lukaszgryglicki/following{/other_user}","gists_url":"https://api.github.com/users/lukaszgryglicki/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaszgryglicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaszgryglicki/subscriptions","organizations_url":"https://api.github.com/users/lukaszgryglicki/orgs","repos_url":"https://api.github.com/users/lukaszgryglicki/repos","events_url":"https://api.github.com/users/lukaszgryglicki/events{/privacy}","received_events_url":"https://api.github.com/users/lukaszgryglicki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lukaszgryglicki/grafana","description":"The tool for beautiful monitoring and metric analytics & dashboards for Graphite, InfluxDB & Prometheus & More","fork":true,"url":"https://api.github.com/repos/lukaszgryglicki/grafana","forks_url":"https://api.github.com/repos/lukaszgryglicki/grafana/forks","keys_url":"https://api.github.com/repos/lukaszgryglicki/grafana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lukaszgryglicki/grafana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lukaszgryglicki/grafana/teams","hooks_url":"https://api.github.com/repos/lukaszgryglicki/grafana/hooks","issue_events_url":"https://api.github.com/repos/lukaszgryglicki/grafana/issues/events{/number}","events_url":"https://api.github.com/repos/lukaszgryglicki/grafana/events","assignees_url":"https://api.github.com/repos/lukaszgryglicki/grafana/assignees{/user}","branches_url":"https://api.github.com/repos/lukaszgryglicki/grafana/branches{/branch}","tags_url":"https://api.github.com/repos/lukaszgryglicki/grafana/tags","blobs_url":"https://api.github.com/repos/lukaszgryglicki/grafana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lukaszgryglicki/grafana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lukaszgryglicki/grafana/git/refs{/sha}","trees_url":"https://api.github.com/repos/lukaszgryglicki/grafana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lukaszgryglicki/grafana/statuses/{sha}","languages_url":"https://api.github.com/repos/lukaszgryglicki/grafana/languages","stargazers_url":"https://api.github.com/repos/lukaszgryglicki/grafana/stargazers","contributors_url":"https://api.github.com/repos/lukaszgryglicki/grafana/contributors","subscribers_url":"https://api.github.com/repos/lukaszgryglicki/grafana/subscribers","subscription_url":"https://api.github.com/repos/lukaszgryglicki/grafana/subscription","commits_url":"https://api.github.com/repos/lukaszgryglicki/grafana/commits{/sha}","git_commits_url":"https://api.github.com/repos/lukaszgryglicki/grafana/git/commits{/sha}","comments_url":"https://api.github.com/repos/lukaszgryglicki/grafana/comments{/number}","issue_comment_url":"https://api.github.com/repos/lukaszgryglicki/grafana/issues/comments{/number}","contents_url":"https://api.github.com/repos/lukaszgryglicki/grafana/contents/{+path}","compare_url":"https://api.github.com/repos/lukaszgryglicki/grafana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lukaszgryglicki/grafana/merges","archive_url":"https://api.github.com/repos/lukaszgryglicki/grafana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lukaszgryglicki/grafana/downloads","issues_url":"https://api.github.com/repos/lukaszgryglicki/grafana/issues{/number}","pulls_url":"https://api.github.com/repos/lukaszgryglicki/grafana/pulls{/number}","milestones_url":"https://api.github.com/repos/lukaszgryglicki/grafana/milestones{/number}","notifications_url":"https://api.github.com/repos/lukaszgryglicki/grafana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lukaszgryglicki/grafana/labels{/name}","releases_url":"https://api.github.com/repos/lukaszgryglicki/grafana/releases{/id}","deployments_url":"https://api.github.com/repos/lukaszgryglicki/grafana/deployments","created_at":"2018-05-04T12:32:22Z","updated_at":"2018-05-04T12:32:30Z","pushed_at":"2018-06-15T10:57:10Z","git_url":"git://github.com/lukaszgryglicki/grafana.git","ssh_url":"git@github.com:lukaszgryglicki/grafana.git","clone_url":"https://github.com/lukaszgryglicki/grafana.git","svn_url":"https://github.com/lukaszgryglicki/grafana","homepage":"https://grafana.com","size":181514,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grafana:master","ref":"master","sha":"4be6ef4ab3684b116bc85f3aa18117601e2c8526","user":{"login":"grafana","id":7195757,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxOTU3NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/7195757?v=4","gravatar_id":"","url":"https://api.github.com/users/grafana","html_url":"https://github.com/grafana","followers_url":"https://api.github.com/users/grafana/followers","following_url":"https://api.github.com/users/grafana/following{/other_user}","gists_url":"https://api.github.com/users/grafana/gists{/gist_id}","starred_url":"https://api.github.com/users/grafana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grafana/subscriptions","organizations_url":"https://api.github.com/users/grafana/orgs","repos_url":"https://api.github.com/users/grafana/repos","events_url":"https://api.github.com/users/grafana/events{/privacy}","received_events_url":"https://api.github.com/users/grafana/received_events","type":"Organization","site_admin":false},"repo":{"id":15111821,"node_id":"MDEwOlJlcG9zaXRvcnkxNTExMTgyMQ==","name":"grafana","full_name":"grafana/grafana","owner":{"login":"grafana","id":7195757,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxOTU3NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/7195757?v=4","gravatar_id":"","url":"https://api.github.com/users/grafana","html_url":"https://github.com/grafana","followers_url":"https://api.github.com/users/grafana/followers","following_url":"https://api.github.com/users/grafana/following{/other_user}","gists_url":"https://api.github.com/users/grafana/gists{/gist_id}","starred_url":"https://api.github.com/users/grafana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grafana/subscriptions","organizations_url":"https://api.github.com/users/grafana/orgs","repos_url":"https://api.github.com/users/grafana/repos","events_url":"https://api.github.com/users/grafana/events{/privacy}","received_events_url":"https://api.github.com/users/grafana/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grafana/grafana","description":"The tool for beautiful monitoring and metric analytics & dashboards for Graphite, InfluxDB & Prometheus & More","fork":false,"url":"https://api.github.com/repos/grafana/grafana","forks_url":"https://api.github.com/repos/grafana/grafana/forks","keys_url":"https://api.github.com/repos/grafana/grafana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grafana/grafana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grafana/grafana/teams","hooks_url":"https://api.github.com/repos/grafana/grafana/hooks","issue_events_url":"https://api.github.com/repos/grafana/grafana/issues/events{/number}","events_url":"https://api.github.com/repos/grafana/grafana/events","assignees_url":"https://api.github.com/repos/grafana/grafana/assignees{/user}","branches_url":"https://api.github.com/repos/grafana/grafana/branches{/branch}","tags_url":"https://api.github.com/repos/grafana/grafana/tags","blobs_url":"https://api.github.com/repos/grafana/grafana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grafana/grafana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grafana/grafana/git/refs{/sha}","trees_url":"https://api.github.com/repos/grafana/grafana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grafana/grafana/statuses/{sha}","languages_url":"https://api.github.com/repos/grafana/grafana/languages","stargazers_url":"https://api.github.com/repos/grafana/grafana/stargazers","contributors_url":"https://api.github.com/repos/grafana/grafana/contributors","subscribers_url":"https://api.github.com/repos/grafana/grafana/subscribers","subscription_url":"https://api.github.com/repos/grafana/grafana/subscription","commits_url":"https://api.github.com/repos/grafana/grafana/commits{/sha}","git_commits_url":"https://api.github.com/repos/grafana/grafana/git/commits{/sha}","comments_url":"https://api.github.com/repos/grafana/grafana/comments{/number}","issue_comment_url":"https://api.github.com/repos/grafana/grafana/issues/comments{/number}","contents_url":"https://api.github.com/repos/grafana/grafana/contents/{+path}","compare_url":"https://api.github.com/repos/grafana/grafana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grafana/grafana/merges","archive_url":"https://api.github.com/repos/grafana/grafana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grafana/grafana/downloads","issues_url":"https://api.github.com/repos/grafana/grafana/issues{/number}","pulls_url":"https://api.github.com/repos/grafana/grafana/pulls{/number}","milestones_url":"https://api.github.com/repos/grafana/grafana/milestones{/number}","notifications_url":"https://api.github.com/repos/grafana/grafana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grafana/grafana/labels{/name}","releases_url":"https://api.github.com/repos/grafana/grafana/releases{/id}","deployments_url":"https://api.github.com/repos/grafana/grafana/deployments","created_at":"2013-12-11T15:59:56Z","updated_at":"2018-06-25T11:46:00Z","pushed_at":"2018-06-25T11:53:39Z","git_url":"git://github.com/grafana/grafana.git","ssh_url":"git@github.com:grafana/grafana.git","clone_url":"https://github.com/grafana/grafana.git","svn_url":"https://github.com/grafana/grafana","homepage":"https://grafana.com","size":182432,"stargazers_count":22371,"watchers_count":22371,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3967,"mirror_url":null,"archived":false,"open_issues_count":1419,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3967,"open_issues":1419,"watchers":22371,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grafana/grafana/pulls/12297"},"html":{"href":"https://github.com/grafana/grafana/pull/12297"},"issue":{"href":"https://api.github.com/repos/grafana/grafana/issues/12297"},"comments":{"href":"https://api.github.com/repos/grafana/grafana/issues/12297/comments"},"review_comments":{"href":"https://api.github.com/repos/grafana/grafana/pulls/12297/comments"},"review_comment":{"href":"https://api.github.com/repos/grafana/grafana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grafana/grafana/pulls/12297/commits"},"statuses":{"href":"https://api.github.com/repos/grafana/grafana/statuses/ffa3a90aa7d3bb07dacc1a16f190f81c2a89c10c"}},"author_association":"NONE"}}
{"actor":{"display_login":"torkelo"}}