{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/jest/pulls/comments/205463899","pull_request_review_id":140736640,"id":205463899,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTQ2Mzg5OQ==","diff_hunk":"@@ -364,6 +364,139 @@ describe('Watch mode flows', () => {\n     expect(run).toHaveBeenCalled();\n   });\n \n+  describe('when dealing with potential watch plugin key conflicts', () => {\n+","path":"packages/jest-cli/src/__tests__/watch.test.js","position":23,"original_position":23,"commit_id":"00567a84c83d168a169970319081c8a15db5737e","original_commit_id":"00567a84c83d168a169970319081c8a15db5737e","user":{"login":"tdd","id":3752,"node_id":"MDQ6VXNlcjM3NTI=","avatar_url":"https://avatars3.githubusercontent.com/u/3752?v=4","gravatar_id":"","url":"https://api.github.com/users/tdd","html_url":"https://github.com/tdd","followers_url":"https://api.github.com/users/tdd/followers","following_url":"https://api.github.com/users/tdd/following{/other_user}","gists_url":"https://api.github.com/users/tdd/gists{/gist_id}","starred_url":"https://api.github.com/users/tdd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdd/subscriptions","organizations_url":"https://api.github.com/users/tdd/orgs","repos_url":"https://api.github.com/users/tdd/repos","events_url":"https://api.github.com/users/tdd/events{/privacy}","received_events_url":"https://api.github.com/users/tdd/received_events","type":"User","site_admin":false},"body":"It's odd, I guess my VS Code was overwhelmed with some extension, not to have auto-run Prettier on this.","created_at":"2018-07-26T13:50:24Z","updated_at":"2018-07-26T13:50:24Z","html_url":"https://github.com/facebook/jest/pull/6697#discussion_r205463899","pull_request_url":"https://api.github.com/repos/facebook/jest/pulls/6697","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/facebook/jest/pulls/comments/205463899"},"html":{"href":"https://github.com/facebook/jest/pull/6697#discussion_r205463899"},"pull_request":{"href":"https://api.github.com/repos/facebook/jest/pulls/6697"}},"in_reply_to_id":205456809},"pull_request":{"url":"https://api.github.com/repos/facebook/jest/pulls/6697","id":201495177,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNDk1MTc3","html_url":"https://github.com/facebook/jest/pull/6697","diff_url":"https://github.com/facebook/jest/pull/6697.diff","patch_url":"https://github.com/facebook/jest/pull/6697.patch","issue_url":"https://api.github.com/repos/facebook/jest/issues/6697","number":6697,"state":"open","locked":false,"title":"Check watch plugins for key conflicts","user":{"login":"tdd","id":3752,"node_id":"MDQ6VXNlcjM3NTI=","avatar_url":"https://avatars3.githubusercontent.com/u/3752?v=4","gravatar_id":"","url":"https://api.github.com/users/tdd","html_url":"https://github.com/tdd","followers_url":"https://api.github.com/users/tdd/followers","following_url":"https://api.github.com/users/tdd/following{/other_user}","gists_url":"https://api.github.com/users/tdd/gists{/gist_id}","starred_url":"https://api.github.com/users/tdd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdd/subscriptions","organizations_url":"https://api.github.com/users/tdd/orgs","repos_url":"https://api.github.com/users/tdd/repos","events_url":"https://api.github.com/users/tdd/events{/privacy}","received_events_url":"https://api.github.com/users/tdd/received_events","type":"User","site_admin":false},"body":"## Summary\r\n\r\nWatch plugins now are checked for key conflicts…\r\n\r\n- Some built-in keys remain overridable (specificically `t` and `p`).\r\n- Any key registered by a third-party watch plugin cannot be overridden by one listed later in the plugins list config.\r\n\r\nFixes #6693.\r\nRefs #6473.\r\n\r\n## Test plan\r\n\r\nAdditional tests are provided that check every conflict / overwritable scenario discussed.\r\n\r\n## Request for feedback / “spec” evolution\r\n\r\nThe “spec” is an ongoing discussion in #6693 — in particular, the overwritability of some built-in keys, such as `a`, `f` and `o`, may be subject to discussion. This PR tracks the decisions in there and may evolve a bit still.\r\n\r\nPing @SimenB @thymikee @rogeliog for review and discussion.","created_at":"2018-07-15T12:13:29Z","updated_at":"2018-07-26T13:50:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6cde3f3d0c5b7cdc449e889f950a178dfeae9a38","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":847426897,"node_id":"MDU6TGFiZWw4NDc0MjY4OTc=","url":"https://api.github.com/repos/facebook/jest/labels/cla%20signed","name":"cla signed","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/jest/pulls/6697/commits","review_comments_url":"https://api.github.com/repos/facebook/jest/pulls/6697/comments","review_comment_url":"https://api.github.com/repos/facebook/jest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/jest/issues/6697/comments","statuses_url":"https://api.github.com/repos/facebook/jest/statuses/00567a84c83d168a169970319081c8a15db5737e","head":{"label":"deliciousinsights:feat/watch-plugin-key-conflicts","ref":"feat/watch-plugin-key-conflicts","sha":"00567a84c83d168a169970319081c8a15db5737e","user":{"login":"deliciousinsights","id":9801352,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4MDEzNTI=","avatar_url":"https://avatars2.githubusercontent.com/u/9801352?v=4","gravatar_id":"","url":"https://api.github.com/users/deliciousinsights","html_url":"https://github.com/deliciousinsights","followers_url":"https://api.github.com/users/deliciousinsights/followers","following_url":"https://api.github.com/users/deliciousinsights/following{/other_user}","gists_url":"https://api.github.com/users/deliciousinsights/gists{/gist_id}","starred_url":"https://api.github.com/users/deliciousinsights/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deliciousinsights/subscriptions","organizations_url":"https://api.github.com/users/deliciousinsights/orgs","repos_url":"https://api.github.com/users/deliciousinsights/repos","events_url":"https://api.github.com/users/deliciousinsights/events{/privacy}","received_events_url":"https://api.github.com/users/deliciousinsights/received_events","type":"Organization","site_admin":false},"repo":{"id":95803136,"node_id":"MDEwOlJlcG9zaXRvcnk5NTgwMzEzNg==","name":"jest","full_name":"deliciousinsights/jest","owner":{"login":"deliciousinsights","id":9801352,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4MDEzNTI=","avatar_url":"https://avatars2.githubusercontent.com/u/9801352?v=4","gravatar_id":"","url":"https://api.github.com/users/deliciousinsights","html_url":"https://github.com/deliciousinsights","followers_url":"https://api.github.com/users/deliciousinsights/followers","following_url":"https://api.github.com/users/deliciousinsights/following{/other_user}","gists_url":"https://api.github.com/users/deliciousinsights/gists{/gist_id}","starred_url":"https://api.github.com/users/deliciousinsights/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deliciousinsights/subscriptions","organizations_url":"https://api.github.com/users/deliciousinsights/orgs","repos_url":"https://api.github.com/users/deliciousinsights/repos","events_url":"https://api.github.com/users/deliciousinsights/events{/privacy}","received_events_url":"https://api.github.com/users/deliciousinsights/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deliciousinsights/jest","description":"🃏 Delightful JavaScript Testing.","fork":true,"url":"https://api.github.com/repos/deliciousinsights/jest","forks_url":"https://api.github.com/repos/deliciousinsights/jest/forks","keys_url":"https://api.github.com/repos/deliciousinsights/jest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deliciousinsights/jest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deliciousinsights/jest/teams","hooks_url":"https://api.github.com/repos/deliciousinsights/jest/hooks","issue_events_url":"https://api.github.com/repos/deliciousinsights/jest/issues/events{/number}","events_url":"https://api.github.com/repos/deliciousinsights/jest/events","assignees_url":"https://api.github.com/repos/deliciousinsights/jest/assignees{/user}","branches_url":"https://api.github.com/repos/deliciousinsights/jest/branches{/branch}","tags_url":"https://api.github.com/repos/deliciousinsights/jest/tags","blobs_url":"https://api.github.com/repos/deliciousinsights/jest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deliciousinsights/jest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deliciousinsights/jest/git/refs{/sha}","trees_url":"https://api.github.com/repos/deliciousinsights/jest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deliciousinsights/jest/statuses/{sha}","languages_url":"https://api.github.com/repos/deliciousinsights/jest/languages","stargazers_url":"https://api.github.com/repos/deliciousinsights/jest/stargazers","contributors_url":"https://api.github.com/repos/deliciousinsights/jest/contributors","subscribers_url":"https://api.github.com/repos/deliciousinsights/jest/subscribers","subscription_url":"https://api.github.com/repos/deliciousinsights/jest/subscription","commits_url":"https://api.github.com/repos/deliciousinsights/jest/commits{/sha}","git_commits_url":"https://api.github.com/repos/deliciousinsights/jest/git/commits{/sha}","comments_url":"https://api.github.com/repos/deliciousinsights/jest/comments{/number}","issue_comment_url":"https://api.github.com/repos/deliciousinsights/jest/issues/comments{/number}","contents_url":"https://api.github.com/repos/deliciousinsights/jest/contents/{+path}","compare_url":"https://api.github.com/repos/deliciousinsights/jest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deliciousinsights/jest/merges","archive_url":"https://api.github.com/repos/deliciousinsights/jest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deliciousinsights/jest/downloads","issues_url":"https://api.github.com/repos/deliciousinsights/jest/issues{/number}","pulls_url":"https://api.github.com/repos/deliciousinsights/jest/pulls{/number}","milestones_url":"https://api.github.com/repos/deliciousinsights/jest/milestones{/number}","notifications_url":"https://api.github.com/repos/deliciousinsights/jest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deliciousinsights/jest/labels{/name}","releases_url":"https://api.github.com/repos/deliciousinsights/jest/releases{/id}","deployments_url":"https://api.github.com/repos/deliciousinsights/jest/deployments","created_at":"2017-06-29T17:36:31Z","updated_at":"2018-07-14T12:02:28Z","pushed_at":"2018-07-26T13:25:28Z","git_url":"git://github.com/deliciousinsights/jest.git","ssh_url":"git@github.com:deliciousinsights/jest.git","clone_url":"https://github.com/deliciousinsights/jest.git","svn_url":"https://github.com/deliciousinsights/jest","homepage":"http://facebook.github.io/jest/","size":54703,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"6ebdd3dd44ab71160fd2d3d78a4a37ef4d4d3c5a","user":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":15062869,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA2Mjg2OQ==","name":"jest","full_name":"facebook/jest","owner":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/jest","description":"🃏 Delightful JavaScript Testing.","fork":false,"url":"https://api.github.com/repos/facebook/jest","forks_url":"https://api.github.com/repos/facebook/jest/forks","keys_url":"https://api.github.com/repos/facebook/jest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/jest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/jest/teams","hooks_url":"https://api.github.com/repos/facebook/jest/hooks","issue_events_url":"https://api.github.com/repos/facebook/jest/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/jest/events","assignees_url":"https://api.github.com/repos/facebook/jest/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/jest/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/jest/tags","blobs_url":"https://api.github.com/repos/facebook/jest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/jest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/jest/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/jest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/jest/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/jest/languages","stargazers_url":"https://api.github.com/repos/facebook/jest/stargazers","contributors_url":"https://api.github.com/repos/facebook/jest/contributors","subscribers_url":"https://api.github.com/repos/facebook/jest/subscribers","subscription_url":"https://api.github.com/repos/facebook/jest/subscription","commits_url":"https://api.github.com/repos/facebook/jest/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/jest/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/jest/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/jest/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/jest/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/jest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/jest/merges","archive_url":"https://api.github.com/repos/facebook/jest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/jest/downloads","issues_url":"https://api.github.com/repos/facebook/jest/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/jest/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/jest/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/jest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/jest/labels{/name}","releases_url":"https://api.github.com/repos/facebook/jest/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/jest/deployments","created_at":"2013-12-10T00:18:04Z","updated_at":"2018-07-26T13:00:34Z","pushed_at":"2018-07-26T13:25:33Z","git_url":"git://github.com/facebook/jest.git","ssh_url":"git@github.com:facebook/jest.git","clone_url":"https://github.com/facebook/jest.git","svn_url":"https://github.com/facebook/jest","homepage":"https://facebook.github.io/jest/","size":91410,"stargazers_count":19241,"watchers_count":19241,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2515,"mirror_url":null,"archived":false,"open_issues_count":452,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2515,"open_issues":452,"watchers":19241,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/jest/pulls/6697"},"html":{"href":"https://github.com/facebook/jest/pull/6697"},"issue":{"href":"https://api.github.com/repos/facebook/jest/issues/6697"},"comments":{"href":"https://api.github.com/repos/facebook/jest/issues/6697/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/jest/pulls/6697/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/jest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/jest/pulls/6697/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/jest/statuses/00567a84c83d168a169970319081c8a15db5737e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tdd"}}