{"action":"created","comment":{"url":"https://api.github.com/repos/v3io/v3io-tsdb/pulls/comments/206212573","pull_request_review_id":141593996,"id":206212573,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjIxMjU3Mw==","diff_hunk":"@@ -1,9 +1,13 @@\n+// +build nuclio_integration","path":"examples/nuclio/ingest/ingest_example_test.go","position":1,"original_position":1,"commit_id":"c506576976c3ca6c1196ea2e4dc67091f41a3719","original_commit_id":"c506576976c3ca6c1196ea2e4dc67091f41a3719","user":{"login":"gtopper","id":4675524,"node_id":"MDQ6VXNlcjQ2NzU1MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4675524?v=4","gravatar_id":"","url":"https://api.github.com/users/gtopper","html_url":"https://github.com/gtopper","followers_url":"https://api.github.com/users/gtopper/followers","following_url":"https://api.github.com/users/gtopper/following{/other_user}","gists_url":"https://api.github.com/users/gtopper/gists{/gist_id}","starred_url":"https://api.github.com/users/gtopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtopper/subscriptions","organizations_url":"https://api.github.com/users/gtopper/orgs","repos_url":"https://api.github.com/users/gtopper/repos","events_url":"https://api.github.com/users/gtopper/events{/privacy}","received_events_url":"https://api.github.com/users/gtopper/received_events","type":"User","site_admin":false},"body":"This one doesn't have a make target. Also, not really clear to me what this means... This integrates with a nuclio instance? Where does it find it? Or is this just integration against the sdk? If it's the latter, I don't see why we would want a tag for that. We use all kinds of libraries and don't mention it.","created_at":"2018-07-30T15:41:46Z","updated_at":"2018-07-30T15:41:46Z","html_url":"https://github.com/v3io/v3io-tsdb/pull/28#discussion_r206212573","pull_request_url":"https://api.github.com/repos/v3io/v3io-tsdb/pulls/28","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/v3io/v3io-tsdb/pulls/comments/206212573"},"html":{"href":"https://github.com/v3io/v3io-tsdb/pull/28#discussion_r206212573"},"pull_request":{"href":"https://api.github.com/repos/v3io/v3io-tsdb/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/v3io/v3io-tsdb/pulls/28","id":204765726,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NzY1NzI2","html_url":"https://github.com/v3io/v3io-tsdb/pull/28","diff_url":"https://github.com/v3io/v3io-tsdb/pull/28.diff","patch_url":"https://github.com/v3io/v3io-tsdb/pull/28.patch","issue_url":"https://api.github.com/repos/v3io/v3io-tsdb/issues/28","number":28,"state":"open","locked":false,"title":"Add tests","user":{"login":"talIguaz","id":33829179,"node_id":"MDQ6VXNlcjMzODI5MTc5","avatar_url":"https://avatars1.githubusercontent.com/u/33829179?v=4","gravatar_id":"","url":"https://api.github.com/users/talIguaz","html_url":"https://github.com/talIguaz","followers_url":"https://api.github.com/users/talIguaz/followers","following_url":"https://api.github.com/users/talIguaz/following{/other_user}","gists_url":"https://api.github.com/users/talIguaz/gists{/gist_id}","starred_url":"https://api.github.com/users/talIguaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talIguaz/subscriptions","organizations_url":"https://api.github.com/users/talIguaz/orgs","repos_url":"https://api.github.com/users/talIguaz/repos","events_url":"https://api.github.com/users/talIguaz/events{/privacy}","received_events_url":"https://api.github.com/users/talIguaz/received_events","type":"User","site_admin":false},"body":"Added also three build tags:\r\n`unit` - for all unit tests (run `make test`)\r\n`integration` - for all integration tests (run `make integration`)\r\n`nuclio_integration` - for all `Nuclio` related tests.","created_at":"2018-07-30T10:51:34Z","updated_at":"2018-07-30T15:41:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5bbf8f6549d5f778f78effe761f75449d1542e03","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/v3io/v3io-tsdb/pulls/28/commits","review_comments_url":"https://api.github.com/repos/v3io/v3io-tsdb/pulls/28/comments","review_comment_url":"https://api.github.com/repos/v3io/v3io-tsdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/v3io/v3io-tsdb/issues/28/comments","statuses_url":"https://api.github.com/repos/v3io/v3io-tsdb/statuses/c506576976c3ca6c1196ea2e4dc67091f41a3719","head":{"label":"talIguaz:add-tests-part-1","ref":"add-tests-part-1","sha":"c506576976c3ca6c1196ea2e4dc67091f41a3719","user":{"login":"talIguaz","id":33829179,"node_id":"MDQ6VXNlcjMzODI5MTc5","avatar_url":"https://avatars1.githubusercontent.com/u/33829179?v=4","gravatar_id":"","url":"https://api.github.com/users/talIguaz","html_url":"https://github.com/talIguaz","followers_url":"https://api.github.com/users/talIguaz/followers","following_url":"https://api.github.com/users/talIguaz/following{/other_user}","gists_url":"https://api.github.com/users/talIguaz/gists{/gist_id}","starred_url":"https://api.github.com/users/talIguaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talIguaz/subscriptions","organizations_url":"https://api.github.com/users/talIguaz/orgs","repos_url":"https://api.github.com/users/talIguaz/repos","events_url":"https://api.github.com/users/talIguaz/events{/privacy}","received_events_url":"https://api.github.com/users/talIguaz/received_events","type":"User","site_admin":false},"repo":{"id":141990879,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE5OTA4Nzk=","name":"v3io-tsdb","full_name":"talIguaz/v3io-tsdb","owner":{"login":"talIguaz","id":33829179,"node_id":"MDQ6VXNlcjMzODI5MTc5","avatar_url":"https://avatars1.githubusercontent.com/u/33829179?v=4","gravatar_id":"","url":"https://api.github.com/users/talIguaz","html_url":"https://github.com/talIguaz","followers_url":"https://api.github.com/users/talIguaz/followers","following_url":"https://api.github.com/users/talIguaz/following{/other_user}","gists_url":"https://api.github.com/users/talIguaz/gists{/gist_id}","starred_url":"https://api.github.com/users/talIguaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talIguaz/subscriptions","organizations_url":"https://api.github.com/users/talIguaz/orgs","repos_url":"https://api.github.com/users/talIguaz/repos","events_url":"https://api.github.com/users/talIguaz/events{/privacy}","received_events_url":"https://api.github.com/users/talIguaz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/talIguaz/v3io-tsdb","description":"iguazio API lib for time-series DB access and Prometheus TSDB storage driver ","fork":true,"url":"https://api.github.com/repos/talIguaz/v3io-tsdb","forks_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/forks","keys_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/teams","hooks_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/hooks","issue_events_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/issues/events{/number}","events_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/events","assignees_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/assignees{/user}","branches_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/branches{/branch}","tags_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/tags","blobs_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/statuses/{sha}","languages_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/languages","stargazers_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/stargazers","contributors_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/contributors","subscribers_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/subscribers","subscription_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/subscription","commits_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/contents/{+path}","compare_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/merges","archive_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/downloads","issues_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/issues{/number}","pulls_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/pulls{/number}","milestones_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/milestones{/number}","notifications_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/labels{/name}","releases_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/releases{/id}","deployments_url":"https://api.github.com/repos/talIguaz/v3io-tsdb/deployments","created_at":"2018-07-23T09:17:30Z","updated_at":"2018-07-23T09:17:32Z","pushed_at":"2018-07-30T15:17:45Z","git_url":"git://github.com/talIguaz/v3io-tsdb.git","ssh_url":"git@github.com:talIguaz/v3io-tsdb.git","clone_url":"https://github.com/talIguaz/v3io-tsdb.git","svn_url":"https://github.com/talIguaz/v3io-tsdb","homepage":"https://www.iguazio.com/","size":1691,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"v3io:development","ref":"development","sha":"26ac78058cd524ae4b98777f03c770e0b69039c8","user":{"login":"v3io","id":23224979,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjI0OTc5","avatar_url":"https://avatars1.githubusercontent.com/u/23224979?v=4","gravatar_id":"","url":"https://api.github.com/users/v3io","html_url":"https://github.com/v3io","followers_url":"https://api.github.com/users/v3io/followers","following_url":"https://api.github.com/users/v3io/following{/other_user}","gists_url":"https://api.github.com/users/v3io/gists{/gist_id}","starred_url":"https://api.github.com/users/v3io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v3io/subscriptions","organizations_url":"https://api.github.com/users/v3io/orgs","repos_url":"https://api.github.com/users/v3io/repos","events_url":"https://api.github.com/users/v3io/events{/privacy}","received_events_url":"https://api.github.com/users/v3io/received_events","type":"Organization","site_admin":false},"repo":{"id":125124689,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUxMjQ2ODk=","name":"v3io-tsdb","full_name":"v3io/v3io-tsdb","owner":{"login":"v3io","id":23224979,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjI0OTc5","avatar_url":"https://avatars1.githubusercontent.com/u/23224979?v=4","gravatar_id":"","url":"https://api.github.com/users/v3io","html_url":"https://github.com/v3io","followers_url":"https://api.github.com/users/v3io/followers","following_url":"https://api.github.com/users/v3io/following{/other_user}","gists_url":"https://api.github.com/users/v3io/gists{/gist_id}","starred_url":"https://api.github.com/users/v3io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v3io/subscriptions","organizations_url":"https://api.github.com/users/v3io/orgs","repos_url":"https://api.github.com/users/v3io/repos","events_url":"https://api.github.com/users/v3io/events{/privacy}","received_events_url":"https://api.github.com/users/v3io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/v3io/v3io-tsdb","description":"iguazio API lib for time-series DB access and Prometheus TSDB storage driver ","fork":false,"url":"https://api.github.com/repos/v3io/v3io-tsdb","forks_url":"https://api.github.com/repos/v3io/v3io-tsdb/forks","keys_url":"https://api.github.com/repos/v3io/v3io-tsdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/v3io/v3io-tsdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/v3io/v3io-tsdb/teams","hooks_url":"https://api.github.com/repos/v3io/v3io-tsdb/hooks","issue_events_url":"https://api.github.com/repos/v3io/v3io-tsdb/issues/events{/number}","events_url":"https://api.github.com/repos/v3io/v3io-tsdb/events","assignees_url":"https://api.github.com/repos/v3io/v3io-tsdb/assignees{/user}","branches_url":"https://api.github.com/repos/v3io/v3io-tsdb/branches{/branch}","tags_url":"https://api.github.com/repos/v3io/v3io-tsdb/tags","blobs_url":"https://api.github.com/repos/v3io/v3io-tsdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/v3io/v3io-tsdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/v3io/v3io-tsdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/v3io/v3io-tsdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/v3io/v3io-tsdb/statuses/{sha}","languages_url":"https://api.github.com/repos/v3io/v3io-tsdb/languages","stargazers_url":"https://api.github.com/repos/v3io/v3io-tsdb/stargazers","contributors_url":"https://api.github.com/repos/v3io/v3io-tsdb/contributors","subscribers_url":"https://api.github.com/repos/v3io/v3io-tsdb/subscribers","subscription_url":"https://api.github.com/repos/v3io/v3io-tsdb/subscription","commits_url":"https://api.github.com/repos/v3io/v3io-tsdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/v3io/v3io-tsdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/v3io/v3io-tsdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/v3io/v3io-tsdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/v3io/v3io-tsdb/contents/{+path}","compare_url":"https://api.github.com/repos/v3io/v3io-tsdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/v3io/v3io-tsdb/merges","archive_url":"https://api.github.com/repos/v3io/v3io-tsdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/v3io/v3io-tsdb/downloads","issues_url":"https://api.github.com/repos/v3io/v3io-tsdb/issues{/number}","pulls_url":"https://api.github.com/repos/v3io/v3io-tsdb/pulls{/number}","milestones_url":"https://api.github.com/repos/v3io/v3io-tsdb/milestones{/number}","notifications_url":"https://api.github.com/repos/v3io/v3io-tsdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/v3io/v3io-tsdb/labels{/name}","releases_url":"https://api.github.com/repos/v3io/v3io-tsdb/releases{/id}","deployments_url":"https://api.github.com/repos/v3io/v3io-tsdb/deployments","created_at":"2018-03-13T22:51:15Z","updated_at":"2018-07-25T12:39:52Z","pushed_at":"2018-07-30T15:17:46Z","git_url":"git://github.com/v3io/v3io-tsdb.git","ssh_url":"git@github.com:v3io/v3io-tsdb.git","clone_url":"https://github.com/v3io/v3io-tsdb.git","svn_url":"https://github.com/v3io/v3io-tsdb","homepage":"https://www.iguazio.com/","size":1653,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":10,"open_issues":2,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/v3io/v3io-tsdb/pulls/28"},"html":{"href":"https://github.com/v3io/v3io-tsdb/pull/28"},"issue":{"href":"https://api.github.com/repos/v3io/v3io-tsdb/issues/28"},"comments":{"href":"https://api.github.com/repos/v3io/v3io-tsdb/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/v3io/v3io-tsdb/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/v3io/v3io-tsdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/v3io/v3io-tsdb/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/v3io/v3io-tsdb/statuses/c506576976c3ca6c1196ea2e4dc67091f41a3719"}},"author_association":"NONE"}}
{"actor":{"display_login":"gtopper"}}