{"action":"closed","number":188,"pull_request":{"url":"https://api.github.com/repos/lodgify/lodgify-ui/pulls/188","id":194607802,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NjA3ODAy","html_url":"https://github.com/lodgify/lodgify-ui/pull/188","diff_url":"https://github.com/lodgify/lodgify-ui/pull/188.diff","patch_url":"https://github.com/lodgify/lodgify-ui/pull/188.patch","issue_url":"https://api.github.com/repos/lodgify/lodgify-ui/issues/188","number":188,"state":"closed","locked":false,"title":"TE-455 Fix server side render DOMPurify bug","user":{"login":"marcdavi-es","id":8591501,"node_id":"MDQ6VXNlcjg1OTE1MDE=","avatar_url":"https://avatars0.githubusercontent.com/u/8591501?v=4","gravatar_id":"","url":"https://api.github.com/users/marcdavi-es","html_url":"https://github.com/marcdavi-es","followers_url":"https://api.github.com/users/marcdavi-es/followers","following_url":"https://api.github.com/users/marcdavi-es/following{/other_user}","gists_url":"https://api.github.com/users/marcdavi-es/gists{/gist_id}","starred_url":"https://api.github.com/users/marcdavi-es/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcdavi-es/subscriptions","organizations_url":"https://api.github.com/users/marcdavi-es/orgs","repos_url":"https://api.github.com/users/marcdavi-es/repos","events_url":"https://api.github.com/users/marcdavi-es/events{/privacy}","received_events_url":"https://api.github.com/users/marcdavi-es/received_events","type":"User","site_admin":false},"body":"[Related YouTrack issue](https://youtrack.lodgify.net/issue/TE-455)\r\n\r\n### What **one** thing does this PR do?\r\nFixes server side render DOMPurify bug\r\n\r\n### Any other notes\r\nRight now we get the following error at npreview-livingstone.lodgifystaging.com ...\r\n\r\n![screen shot 2018-06-13 at 16 29 49](https://user-images.githubusercontent.com/8591501/41357727-13f2072c-6f27-11e8-9b8b-281afc4bac2d.png)\r\n\r\nThis is because `DOMPurify.sanitize` is being called in render methods of the `Video` and `HTML` components during server side rendering.\r\n\r\n`DOMPurify` is a browser technology and relies on browser features to work. It fails when run on the server.\r\n\r\nBy moving the call of `DOMPurify.sanitize` to `componentDidMount`, we ensure that it only gets called when mounted in the DOM, which guarantees that `DOMPurify` can access the features it needs to run.","created_at":"2018-06-13T14:32:57Z","updated_at":"2018-06-13T15:20:44Z","closed_at":"2018-06-13T15:20:43Z","merged_at":"2018-06-13T15:20:43Z","merge_commit_sha":"1d08f3f9d179ced9e242e23ecf9559187c734b53","assignee":{"login":"davidpelayo","id":84540,"node_id":"MDQ6VXNlcjg0NTQw","avatar_url":"https://avatars1.githubusercontent.com/u/84540?v=4","gravatar_id":"","url":"https://api.github.com/users/davidpelayo","html_url":"https://github.com/davidpelayo","followers_url":"https://api.github.com/users/davidpelayo/followers","following_url":"https://api.github.com/users/davidpelayo/following{/other_user}","gists_url":"https://api.github.com/users/davidpelayo/gists{/gist_id}","starred_url":"https://api.github.com/users/davidpelayo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidpelayo/subscriptions","organizations_url":"https://api.github.com/users/davidpelayo/orgs","repos_url":"https://api.github.com/users/davidpelayo/repos","events_url":"https://api.github.com/users/davidpelayo/events{/privacy}","received_events_url":"https://api.github.com/users/davidpelayo/received_events","type":"User","site_admin":false},"assignees":[{"login":"davidpelayo","id":84540,"node_id":"MDQ6VXNlcjg0NTQw","avatar_url":"https://avatars1.githubusercontent.com/u/84540?v=4","gravatar_id":"","url":"https://api.github.com/users/davidpelayo","html_url":"https://github.com/davidpelayo","followers_url":"https://api.github.com/users/davidpelayo/followers","following_url":"https://api.github.com/users/davidpelayo/following{/other_user}","gists_url":"https://api.github.com/users/davidpelayo/gists{/gist_id}","starred_url":"https://api.github.com/users/davidpelayo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidpelayo/subscriptions","organizations_url":"https://api.github.com/users/davidpelayo/orgs","repos_url":"https://api.github.com/users/davidpelayo/repos","events_url":"https://api.github.com/users/davidpelayo/events{/privacy}","received_events_url":"https://api.github.com/users/davidpelayo/received_events","type":"User","site_admin":false},{"login":"Jonnygwi","id":10498995,"node_id":"MDQ6VXNlcjEwNDk4OTk1","avatar_url":"https://avatars0.githubusercontent.com/u/10498995?v=4","gravatar_id":"","url":"https://api.github.com/users/Jonnygwi","html_url":"https://github.com/Jonnygwi","followers_url":"https://api.github.com/users/Jonnygwi/followers","following_url":"https://api.github.com/users/Jonnygwi/following{/other_user}","gists_url":"https://api.github.com/users/Jonnygwi/gists{/gist_id}","starred_url":"https://api.github.com/users/Jonnygwi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jonnygwi/subscriptions","organizations_url":"https://api.github.com/users/Jonnygwi/orgs","repos_url":"https://api.github.com/users/Jonnygwi/repos","events_url":"https://api.github.com/users/Jonnygwi/events{/privacy}","received_events_url":"https://api.github.com/users/Jonnygwi/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"davidpelayo","id":84540,"node_id":"MDQ6VXNlcjg0NTQw","avatar_url":"https://avatars1.githubusercontent.com/u/84540?v=4","gravatar_id":"","url":"https://api.github.com/users/davidpelayo","html_url":"https://github.com/davidpelayo","followers_url":"https://api.github.com/users/davidpelayo/followers","following_url":"https://api.github.com/users/davidpelayo/following{/other_user}","gists_url":"https://api.github.com/users/davidpelayo/gists{/gist_id}","starred_url":"https://api.github.com/users/davidpelayo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidpelayo/subscriptions","organizations_url":"https://api.github.com/users/davidpelayo/orgs","repos_url":"https://api.github.com/users/davidpelayo/repos","events_url":"https://api.github.com/users/davidpelayo/events{/privacy}","received_events_url":"https://api.github.com/users/davidpelayo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":866970670,"node_id":"MDU6TGFiZWw4NjY5NzA2NzA=","url":"https://api.github.com/repos/lodgify/lodgify-ui/labels/:wave:%20David%20-%20have%20a%20look","name":":wave: David - have a look","color":"d93f0b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/lodgify/lodgify-ui/pulls/188/commits","review_comments_url":"https://api.github.com/repos/lodgify/lodgify-ui/pulls/188/comments","review_comment_url":"https://api.github.com/repos/lodgify/lodgify-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lodgify/lodgify-ui/issues/188/comments","statuses_url":"https://api.github.com/repos/lodgify/lodgify-ui/statuses/318ba8caccfb02871ac0959c3497177cc7fe4f39","head":{"label":"lodgify:TE-455-fix-ssr-dom-purify-bug","ref":"TE-455-fix-ssr-dom-purify-bug","sha":"318ba8caccfb02871ac0959c3497177cc7fe4f39","user":{"login":"lodgify","id":7839242,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MzkyNDI=","avatar_url":"https://avatars1.githubusercontent.com/u/7839242?v=4","gravatar_id":"","url":"https://api.github.com/users/lodgify","html_url":"https://github.com/lodgify","followers_url":"https://api.github.com/users/lodgify/followers","following_url":"https://api.github.com/users/lodgify/following{/other_user}","gists_url":"https://api.github.com/users/lodgify/gists{/gist_id}","starred_url":"https://api.github.com/users/lodgify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lodgify/subscriptions","organizations_url":"https://api.github.com/users/lodgify/orgs","repos_url":"https://api.github.com/users/lodgify/repos","events_url":"https://api.github.com/users/lodgify/events{/privacy}","received_events_url":"https://api.github.com/users/lodgify/received_events","type":"Organization","site_admin":false},"repo":{"id":122183769,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIxODM3Njk=","name":"lodgify-ui","full_name":"lodgify/lodgify-ui","owner":{"login":"lodgify","id":7839242,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MzkyNDI=","avatar_url":"https://avatars1.githubusercontent.com/u/7839242?v=4","gravatar_id":"","url":"https://api.github.com/users/lodgify","html_url":"https://github.com/lodgify","followers_url":"https://api.github.com/users/lodgify/followers","following_url":"https://api.github.com/users/lodgify/following{/other_user}","gists_url":"https://api.github.com/users/lodgify/gists{/gist_id}","starred_url":"https://api.github.com/users/lodgify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lodgify/subscriptions","organizations_url":"https://api.github.com/users/lodgify/orgs","repos_url":"https://api.github.com/users/lodgify/repos","events_url":"https://api.github.com/users/lodgify/events{/privacy}","received_events_url":"https://api.github.com/users/lodgify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lodgify/lodgify-ui","description":"React components for building amazing websites with Lodgify","fork":false,"url":"https://api.github.com/repos/lodgify/lodgify-ui","forks_url":"https://api.github.com/repos/lodgify/lodgify-ui/forks","keys_url":"https://api.github.com/repos/lodgify/lodgify-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lodgify/lodgify-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lodgify/lodgify-ui/teams","hooks_url":"https://api.github.com/repos/lodgify/lodgify-ui/hooks","issue_events_url":"https://api.github.com/repos/lodgify/lodgify-ui/issues/events{/number}","events_url":"https://api.github.com/repos/lodgify/lodgify-ui/events","assignees_url":"https://api.github.com/repos/lodgify/lodgify-ui/assignees{/user}","branches_url":"https://api.github.com/repos/lodgify/lodgify-ui/branches{/branch}","tags_url":"https://api.github.com/repos/lodgify/lodgify-ui/tags","blobs_url":"https://api.github.com/repos/lodgify/lodgify-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lodgify/lodgify-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lodgify/lodgify-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/lodgify/lodgify-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lodgify/lodgify-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/lodgify/lodgify-ui/languages","stargazers_url":"https://api.github.com/repos/lodgify/lodgify-ui/stargazers","contributors_url":"https://api.github.com/repos/lodgify/lodgify-ui/contributors","subscribers_url":"https://api.github.com/repos/lodgify/lodgify-ui/subscribers","subscription_url":"https://api.github.com/repos/lodgify/lodgify-ui/subscription","commits_url":"https://api.github.com/repos/lodgify/lodgify-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/lodgify/lodgify-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/lodgify/lodgify-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/lodgify/lodgify-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/lodgify/lodgify-ui/contents/{+path}","compare_url":"https://api.github.com/repos/lodgify/lodgify-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lodgify/lodgify-ui/merges","archive_url":"https://api.github.com/repos/lodgify/lodgify-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lodgify/lodgify-ui/downloads","issues_url":"https://api.github.com/repos/lodgify/lodgify-ui/issues{/number}","pulls_url":"https://api.github.com/repos/lodgify/lodgify-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/lodgify/lodgify-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/lodgify/lodgify-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lodgify/lodgify-ui/labels{/name}","releases_url":"https://api.github.com/repos/lodgify/lodgify-ui/releases{/id}","deployments_url":"https://api.github.com/repos/lodgify/lodgify-ui/deployments","created_at":"2018-02-20T10:27:00Z","updated_at":"2018-06-13T08:40:54Z","pushed_at":"2018-06-13T15:20:43Z","git_url":"git://github.com/lodgify/lodgify-ui.git","ssh_url":"git@github.com:lodgify/lodgify-ui.git","clone_url":"https://github.com/lodgify/lodgify-ui.git","svn_url":"https://github.com/lodgify/lodgify-ui","homepage":"https://lodgify.github.io/lodgify-ui/","size":7312,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":3,"default_branch":"production"}},"base":{"label":"lodgify:production","ref":"production","sha":"d7811e95718a1b51e00e101c63c0c0a6e25c840d","user":{"login":"lodgify","id":7839242,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MzkyNDI=","avatar_url":"https://avatars1.githubusercontent.com/u/7839242?v=4","gravatar_id":"","url":"https://api.github.com/users/lodgify","html_url":"https://github.com/lodgify","followers_url":"https://api.github.com/users/lodgify/followers","following_url":"https://api.github.com/users/lodgify/following{/other_user}","gists_url":"https://api.github.com/users/lodgify/gists{/gist_id}","starred_url":"https://api.github.com/users/lodgify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lodgify/subscriptions","organizations_url":"https://api.github.com/users/lodgify/orgs","repos_url":"https://api.github.com/users/lodgify/repos","events_url":"https://api.github.com/users/lodgify/events{/privacy}","received_events_url":"https://api.github.com/users/lodgify/received_events","type":"Organization","site_admin":false},"repo":{"id":122183769,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIxODM3Njk=","name":"lodgify-ui","full_name":"lodgify/lodgify-ui","owner":{"login":"lodgify","id":7839242,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MzkyNDI=","avatar_url":"https://avatars1.githubusercontent.com/u/7839242?v=4","gravatar_id":"","url":"https://api.github.com/users/lodgify","html_url":"https://github.com/lodgify","followers_url":"https://api.github.com/users/lodgify/followers","following_url":"https://api.github.com/users/lodgify/following{/other_user}","gists_url":"https://api.github.com/users/lodgify/gists{/gist_id}","starred_url":"https://api.github.com/users/lodgify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lodgify/subscriptions","organizations_url":"https://api.github.com/users/lodgify/orgs","repos_url":"https://api.github.com/users/lodgify/repos","events_url":"https://api.github.com/users/lodgify/events{/privacy}","received_events_url":"https://api.github.com/users/lodgify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lodgify/lodgify-ui","description":"React components for building amazing websites with Lodgify","fork":false,"url":"https://api.github.com/repos/lodgify/lodgify-ui","forks_url":"https://api.github.com/repos/lodgify/lodgify-ui/forks","keys_url":"https://api.github.com/repos/lodgify/lodgify-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lodgify/lodgify-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lodgify/lodgify-ui/teams","hooks_url":"https://api.github.com/repos/lodgify/lodgify-ui/hooks","issue_events_url":"https://api.github.com/repos/lodgify/lodgify-ui/issues/events{/number}","events_url":"https://api.github.com/repos/lodgify/lodgify-ui/events","assignees_url":"https://api.github.com/repos/lodgify/lodgify-ui/assignees{/user}","branches_url":"https://api.github.com/repos/lodgify/lodgify-ui/branches{/branch}","tags_url":"https://api.github.com/repos/lodgify/lodgify-ui/tags","blobs_url":"https://api.github.com/repos/lodgify/lodgify-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lodgify/lodgify-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lodgify/lodgify-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/lodgify/lodgify-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lodgify/lodgify-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/lodgify/lodgify-ui/languages","stargazers_url":"https://api.github.com/repos/lodgify/lodgify-ui/stargazers","contributors_url":"https://api.github.com/repos/lodgify/lodgify-ui/contributors","subscribers_url":"https://api.github.com/repos/lodgify/lodgify-ui/subscribers","subscription_url":"https://api.github.com/repos/lodgify/lodgify-ui/subscription","commits_url":"https://api.github.com/repos/lodgify/lodgify-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/lodgify/lodgify-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/lodgify/lodgify-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/lodgify/lodgify-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/lodgify/lodgify-ui/contents/{+path}","compare_url":"https://api.github.com/repos/lodgify/lodgify-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lodgify/lodgify-ui/merges","archive_url":"https://api.github.com/repos/lodgify/lodgify-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lodgify/lodgify-ui/downloads","issues_url":"https://api.github.com/repos/lodgify/lodgify-ui/issues{/number}","pulls_url":"https://api.github.com/repos/lodgify/lodgify-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/lodgify/lodgify-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/lodgify/lodgify-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lodgify/lodgify-ui/labels{/name}","releases_url":"https://api.github.com/repos/lodgify/lodgify-ui/releases{/id}","deployments_url":"https://api.github.com/repos/lodgify/lodgify-ui/deployments","created_at":"2018-02-20T10:27:00Z","updated_at":"2018-06-13T08:40:54Z","pushed_at":"2018-06-13T15:20:43Z","git_url":"git://github.com/lodgify/lodgify-ui.git","ssh_url":"git@github.com:lodgify/lodgify-ui.git","clone_url":"https://github.com/lodgify/lodgify-ui.git","svn_url":"https://github.com/lodgify/lodgify-ui","homepage":"https://lodgify.github.io/lodgify-ui/","size":7312,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":3,"default_branch":"production"}},"_links":{"self":{"href":"https://api.github.com/repos/lodgify/lodgify-ui/pulls/188"},"html":{"href":"https://github.com/lodgify/lodgify-ui/pull/188"},"issue":{"href":"https://api.github.com/repos/lodgify/lodgify-ui/issues/188"},"comments":{"href":"https://api.github.com/repos/lodgify/lodgify-ui/issues/188/comments"},"review_comments":{"href":"https://api.github.com/repos/lodgify/lodgify-ui/pulls/188/comments"},"review_comment":{"href":"https://api.github.com/repos/lodgify/lodgify-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lodgify/lodgify-ui/pulls/188/commits"},"statuses":{"href":"https://api.github.com/repos/lodgify/lodgify-ui/statuses/318ba8caccfb02871ac0959c3497177cc7fe4f39"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Jonnygwi","id":10498995,"node_id":"MDQ6VXNlcjEwNDk4OTk1","avatar_url":"https://avatars0.githubusercontent.com/u/10498995?v=4","gravatar_id":"","url":"https://api.github.com/users/Jonnygwi","html_url":"https://github.com/Jonnygwi","followers_url":"https://api.github.com/users/Jonnygwi/followers","following_url":"https://api.github.com/users/Jonnygwi/following{/other_user}","gists_url":"https://api.github.com/users/Jonnygwi/gists{/gist_id}","starred_url":"https://api.github.com/users/Jonnygwi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jonnygwi/subscriptions","organizations_url":"https://api.github.com/users/Jonnygwi/orgs","repos_url":"https://api.github.com/users/Jonnygwi/repos","events_url":"https://api.github.com/users/Jonnygwi/events{/privacy}","received_events_url":"https://api.github.com/users/Jonnygwi/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":62,"deletions":88,"changed_files":5}}
{"actor":{"display_login":"Jonnygwi"}}