{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph-container/pulls/comments/200336214","pull_request_review_id":134630618,"id":200336214,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDMzNjIxNA==","diff_hunk":"@@ -33,8 +33,10 @@ function get_ip {\n         # We don't want local scope, so let's remove field 4 if not 00\n         local ip\n         ip=$(flat_to_ipv6 \"$(grep \"$nic\" /proc/net/if_inet6 | awk '$4==00 {print $1}')\")\n-        # IPv6 IPs should be surrounded by brackets to let ceph-monmap being happy\n-        echo \"[$ip]\"\n+        if [ -n \"$ip\" ]; then\n+          # IPv6 IPs should be surrounded by brackets to let ceph-monmap being happy\n+          echo \"$ip\"","path":"src/daemon/start_mon.sh","position":8,"original_position":8,"commit_id":"8d391eb54b779a8bcb3471416cf77069556cbe1f","original_commit_id":"8d391eb54b779a8bcb3471416cf77069556cbe1f","user":{"login":"leseb","id":912735,"node_id":"MDQ6VXNlcjkxMjczNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/912735?v=4","gravatar_id":"","url":"https://api.github.com/users/leseb","html_url":"https://github.com/leseb","followers_url":"https://api.github.com/users/leseb/followers","following_url":"https://api.github.com/users/leseb/following{/other_user}","gists_url":"https://api.github.com/users/leseb/gists{/gist_id}","starred_url":"https://api.github.com/users/leseb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leseb/subscriptions","organizations_url":"https://api.github.com/users/leseb/orgs","repos_url":"https://api.github.com/users/leseb/repos","events_url":"https://api.github.com/users/leseb/events{/privacy}","received_events_url":"https://api.github.com/users/leseb/received_events","type":"User","site_admin":false},"body":"why are the brackets gone?","created_at":"2018-07-05T12:40:10Z","updated_at":"2018-07-05T12:41:12Z","html_url":"https://github.com/ceph/ceph-container/pull/1109#discussion_r200336214","pull_request_url":"https://api.github.com/repos/ceph/ceph-container/pulls/1109","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph-container/pulls/comments/200336214"},"html":{"href":"https://github.com/ceph/ceph-container/pull/1109#discussion_r200336214"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph-container/pulls/1109"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph-container/pulls/1109","id":198698814,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4Njk4ODE0","html_url":"https://github.com/ceph/ceph-container/pull/1109","diff_url":"https://github.com/ceph/ceph-container/pull/1109.diff","patch_url":"https://github.com/ceph/ceph-container/pull/1109.patch","issue_url":"https://api.github.com/repos/ceph/ceph-container/issues/1109","number":1109,"state":"open","locked":false,"title":"start_mon: fix NETWORK_AUTO_DETECT=1 IPv4 lookup","user":{"login":"mhumpula","id":40766419,"node_id":"MDQ6VXNlcjQwNzY2NDE5","avatar_url":"https://avatars0.githubusercontent.com/u/40766419?v=4","gravatar_id":"","url":"https://api.github.com/users/mhumpula","html_url":"https://github.com/mhumpula","followers_url":"https://api.github.com/users/mhumpula/followers","following_url":"https://api.github.com/users/mhumpula/following{/other_user}","gists_url":"https://api.github.com/users/mhumpula/gists{/gist_id}","starred_url":"https://api.github.com/users/mhumpula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhumpula/subscriptions","organizations_url":"https://api.github.com/users/mhumpula/orgs","repos_url":"https://api.github.com/users/mhumpula/repos","events_url":"https://api.github.com/users/mhumpula/events{/privacy}","received_events_url":"https://api.github.com/users/mhumpula/received_events","type":"User","site_admin":false},"body":"Please consider for merging.\r\n\r\nDescription of your changes:\r\n\r\n`get_ip` incorrently returned string `[]` when IPv6 detection\r\nfailed, leading to skipped IPv4 auto detection and unknown\r\naddress to continue.\r\n\r\nChecklist:\r\n- [ ] Documentation has been updated, if necessary.\r\n- [ ] Pending release notes updated with breaking and/or notable changes, if necessary.\r\n","created_at":"2018-07-02T14:33:32Z","updated_at":"2018-07-05T12:41:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec54ae86956dc6d5de8b0e1c0668756e53a07c1b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph-container/pulls/1109/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph-container/pulls/1109/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph-container/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph-container/issues/1109/comments","statuses_url":"https://api.github.com/repos/ceph/ceph-container/statuses/8d391eb54b779a8bcb3471416cf77069556cbe1f","head":{"label":"mhumpula:auto_network","ref":"auto_network","sha":"8d391eb54b779a8bcb3471416cf77069556cbe1f","user":{"login":"mhumpula","id":40766419,"node_id":"MDQ6VXNlcjQwNzY2NDE5","avatar_url":"https://avatars0.githubusercontent.com/u/40766419?v=4","gravatar_id":"","url":"https://api.github.com/users/mhumpula","html_url":"https://github.com/mhumpula","followers_url":"https://api.github.com/users/mhumpula/followers","following_url":"https://api.github.com/users/mhumpula/following{/other_user}","gists_url":"https://api.github.com/users/mhumpula/gists{/gist_id}","starred_url":"https://api.github.com/users/mhumpula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhumpula/subscriptions","organizations_url":"https://api.github.com/users/mhumpula/orgs","repos_url":"https://api.github.com/users/mhumpula/repos","events_url":"https://api.github.com/users/mhumpula/events{/privacy}","received_events_url":"https://api.github.com/users/mhumpula/received_events","type":"User","site_admin":false},"repo":{"id":139452641,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk0NTI2NDE=","name":"ceph-container","full_name":"mhumpula/ceph-container","owner":{"login":"mhumpula","id":40766419,"node_id":"MDQ6VXNlcjQwNzY2NDE5","avatar_url":"https://avatars0.githubusercontent.com/u/40766419?v=4","gravatar_id":"","url":"https://api.github.com/users/mhumpula","html_url":"https://github.com/mhumpula","followers_url":"https://api.github.com/users/mhumpula/followers","following_url":"https://api.github.com/users/mhumpula/following{/other_user}","gists_url":"https://api.github.com/users/mhumpula/gists{/gist_id}","starred_url":"https://api.github.com/users/mhumpula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhumpula/subscriptions","organizations_url":"https://api.github.com/users/mhumpula/orgs","repos_url":"https://api.github.com/users/mhumpula/repos","events_url":"https://api.github.com/users/mhumpula/events{/privacy}","received_events_url":"https://api.github.com/users/mhumpula/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mhumpula/ceph-container","description":"Docker files and images to run Ceph in containers","fork":true,"url":"https://api.github.com/repos/mhumpula/ceph-container","forks_url":"https://api.github.com/repos/mhumpula/ceph-container/forks","keys_url":"https://api.github.com/repos/mhumpula/ceph-container/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhumpula/ceph-container/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhumpula/ceph-container/teams","hooks_url":"https://api.github.com/repos/mhumpula/ceph-container/hooks","issue_events_url":"https://api.github.com/repos/mhumpula/ceph-container/issues/events{/number}","events_url":"https://api.github.com/repos/mhumpula/ceph-container/events","assignees_url":"https://api.github.com/repos/mhumpula/ceph-container/assignees{/user}","branches_url":"https://api.github.com/repos/mhumpula/ceph-container/branches{/branch}","tags_url":"https://api.github.com/repos/mhumpula/ceph-container/tags","blobs_url":"https://api.github.com/repos/mhumpula/ceph-container/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhumpula/ceph-container/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhumpula/ceph-container/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhumpula/ceph-container/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhumpula/ceph-container/statuses/{sha}","languages_url":"https://api.github.com/repos/mhumpula/ceph-container/languages","stargazers_url":"https://api.github.com/repos/mhumpula/ceph-container/stargazers","contributors_url":"https://api.github.com/repos/mhumpula/ceph-container/contributors","subscribers_url":"https://api.github.com/repos/mhumpula/ceph-container/subscribers","subscription_url":"https://api.github.com/repos/mhumpula/ceph-container/subscription","commits_url":"https://api.github.com/repos/mhumpula/ceph-container/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhumpula/ceph-container/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhumpula/ceph-container/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhumpula/ceph-container/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhumpula/ceph-container/contents/{+path}","compare_url":"https://api.github.com/repos/mhumpula/ceph-container/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhumpula/ceph-container/merges","archive_url":"https://api.github.com/repos/mhumpula/ceph-container/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhumpula/ceph-container/downloads","issues_url":"https://api.github.com/repos/mhumpula/ceph-container/issues{/number}","pulls_url":"https://api.github.com/repos/mhumpula/ceph-container/pulls{/number}","milestones_url":"https://api.github.com/repos/mhumpula/ceph-container/milestones{/number}","notifications_url":"https://api.github.com/repos/mhumpula/ceph-container/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhumpula/ceph-container/labels{/name}","releases_url":"https://api.github.com/repos/mhumpula/ceph-container/releases{/id}","deployments_url":"https://api.github.com/repos/mhumpula/ceph-container/deployments","created_at":"2018-07-02T14:12:14Z","updated_at":"2018-07-02T14:12:16Z","pushed_at":"2018-07-02T14:31:36Z","git_url":"git://github.com/mhumpula/ceph-container.git","ssh_url":"git@github.com:mhumpula/ceph-container.git","clone_url":"https://github.com/mhumpula/ceph-container.git","svn_url":"https://github.com/mhumpula/ceph-container","homepage":null,"size":7318,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"29f1e9c653bd4b27ff223bc9c4192be136b95850","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":29601598,"node_id":"MDEwOlJlcG9zaXRvcnkyOTYwMTU5OA==","name":"ceph-container","full_name":"ceph/ceph-container","owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph-container","description":"Docker files and images to run Ceph in containers","fork":false,"url":"https://api.github.com/repos/ceph/ceph-container","forks_url":"https://api.github.com/repos/ceph/ceph-container/forks","keys_url":"https://api.github.com/repos/ceph/ceph-container/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph-container/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph-container/teams","hooks_url":"https://api.github.com/repos/ceph/ceph-container/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph-container/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph-container/events","assignees_url":"https://api.github.com/repos/ceph/ceph-container/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph-container/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph-container/tags","blobs_url":"https://api.github.com/repos/ceph/ceph-container/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph-container/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph-container/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph-container/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph-container/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph-container/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph-container/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph-container/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph-container/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph-container/subscription","commits_url":"https://api.github.com/repos/ceph/ceph-container/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph-container/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph-container/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph-container/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph-container/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph-container/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph-container/merges","archive_url":"https://api.github.com/repos/ceph/ceph-container/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph-container/downloads","issues_url":"https://api.github.com/repos/ceph/ceph-container/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph-container/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph-container/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph-container/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph-container/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph-container/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph-container/deployments","created_at":"2015-01-21T17:22:51Z","updated_at":"2018-07-02T05:57:09Z","pushed_at":"2018-07-02T14:33:33Z","git_url":"git://github.com/ceph/ceph-container.git","ssh_url":"git@github.com:ceph/ceph-container.git","clone_url":"https://github.com/ceph/ceph-container.git","svn_url":"https://github.com/ceph/ceph-container","homepage":null,"size":7317,"stargazers_count":744,"watchers_count":744,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":321,"mirror_url":null,"archived":false,"open_issues_count":135,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":321,"open_issues":135,"watchers":744,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph-container/pulls/1109"},"html":{"href":"https://github.com/ceph/ceph-container/pull/1109"},"issue":{"href":"https://api.github.com/repos/ceph/ceph-container/issues/1109"},"comments":{"href":"https://api.github.com/repos/ceph/ceph-container/issues/1109/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph-container/pulls/1109/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph-container/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph-container/pulls/1109/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph-container/statuses/8d391eb54b779a8bcb3471416cf77069556cbe1f"}},"author_association":"NONE"}}
{"actor":{"display_login":"leseb"}}