{"action":"opened","issue":{"url":"https://api.github.com/repos/spacetelescope/poppy/issues/201","repository_url":"https://api.github.com/repos/spacetelescope/poppy","labels_url":"https://api.github.com/repos/spacetelescope/poppy/issues/201/labels{/name}","comments_url":"https://api.github.com/repos/spacetelescope/poppy/issues/201/comments","events_url":"https://api.github.com/repos/spacetelescope/poppy/issues/201/events","html_url":"https://github.com/spacetelescope/poppy/issues/201","id":353585989,"node_id":"MDU6SXNzdWUzNTM1ODU5ODk=","number":201,"title":"DET_OVERSAMP header keyword does not return detector oversampling","user":{"login":"mperrin","id":1151745,"node_id":"MDQ6VXNlcjExNTE3NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/1151745?v=4","gravatar_id":"","url":"https://api.github.com/users/mperrin","html_url":"https://github.com/mperrin","followers_url":"https://api.github.com/users/mperrin/followers","following_url":"https://api.github.com/users/mperrin/following{/other_user}","gists_url":"https://api.github.com/users/mperrin/gists{/gist_id}","starred_url":"https://api.github.com/users/mperrin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mperrin/subscriptions","organizations_url":"https://api.github.com/users/mperrin/orgs","repos_url":"https://api.github.com/users/mperrin/repos","events_url":"https://api.github.com/users/mperrin/events{/privacy}","received_events_url":"https://api.github.com/users/mperrin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-23T23:06:07Z","updated_at":"2018-08-23T23:06:07Z","closed_at":null,"author_association":"COLLABORATOR","body":"<a href=\"https://github.com/douglase\"><img src=\"https://avatars1.githubusercontent.com/u/1025951?v=4\" align=\"left\" width=\"96\" height=\"96\" hspace=\"10\"></img></a> **Issue by [douglase](https://github.com/douglase)**\n_Monday Jan 16, 2017 at 01:00 GMT_\n_Originally opened as https://github.com/mperrin/poppy/issues/201_\n\n----\n\nWhen the MFT detector sampling is not equal to the wavefront oversampling the correct value is not passed to the output FITS file header.\r\n\r\nExample code:\r\n```\r\nosys = poppy.OpticalSystem(oversample=18)\r\nosys.add_pupil(poppy.CircularAperture())\r\nosys.add_detector(0.1, fov_pixels=30,oversample=10)\r\npsf=osys.calc_psf()\r\npsf[0].header[\"OVERSAMP\"], psf[0].header[\"DET_SAMP\"]\r\n```\r\nreturns:\r\n```(18,18)```\r\n\r\nrather than `(18,10)`  as expected.\r\n\n"}}
{"actor":{"display_login":"mperrin"}}