{"action":"created","issue":{"url":"https://api.github.com/repos/vstakhov/rspamd/issues/2106","repository_url":"https://api.github.com/repos/vstakhov/rspamd","labels_url":"https://api.github.com/repos/vstakhov/rspamd/issues/2106/labels{/name}","comments_url":"https://api.github.com/repos/vstakhov/rspamd/issues/2106/comments","events_url":"https://api.github.com/repos/vstakhov/rspamd/issues/2106/events","html_url":"https://github.com/vstakhov/rspamd/issues/2106","id":307743588,"number":2106,"title":"dkim_signing doesn't work anymore after upgrade from 1.6.6 to 1.7.1","user":{"login":"philfry","id":1649785,"avatar_url":"https://avatars0.githubusercontent.com/u/1649785?v=4","gravatar_id":"","url":"https://api.github.com/users/philfry","html_url":"https://github.com/philfry","followers_url":"https://api.github.com/users/philfry/followers","following_url":"https://api.github.com/users/philfry/following{/other_user}","gists_url":"https://api.github.com/users/philfry/gists{/gist_id}","starred_url":"https://api.github.com/users/philfry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philfry/subscriptions","organizations_url":"https://api.github.com/users/philfry/orgs","repos_url":"https://api.github.com/users/philfry/repos","events_url":"https://api.github.com/users/philfry/events{/privacy}","received_events_url":"https://api.github.com/users/philfry/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-22T17:31:13Z","updated_at":"2018-03-22T19:35:38Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"### Classification (Please choose *one* option):\r\n\r\n* [ ] Crash/Hang/Data loss\r\n* [ ] WebUI/Usability\r\n* [x] Serious bug\r\n* [ ] Other bug\r\n* [ ] Feature\r\n* [ ] Enhancement\r\n\r\n### Reproducibility (Please choose *one* option):\r\n\r\n* [X] Always\r\n* [ ] Sometimes\r\n* [ ] Rarely\r\n* [ ] Unable\r\n* [ ] I didn’t try\r\n* [ ] Not applicable\r\n\r\n### Rspamd version:\r\n1.7.1\r\n\r\n### Operation system, CPU, memory and environment:\r\nRHEL 7, x86_64, 16GiB\r\n\r\n### Description (Please provide a descriptive summary of the issue):\r\nAfter upgrading from 1.6.6 to 1.7.1 mails from authenticated users are not signed anymore. Mails sent from local networks are signed, though.\r\n\r\n### Compile errors (if any):\r\n\r\n### Steps to reproduce:\r\n1. configure rspamd for dkim signing\r\n2. send mail as authenticated user\r\n\r\n### Expected results:\r\ndkim-signed mail\r\n\r\n### Actual results:\r\nno dkim signature\r\n\r\n### Debugging information (see details [here](https://rspamd.com/doc/faq.html#how-to-figure-out-why-rspamd-process-crashed)):\r\n\r\n### Configuration:\r\n```\r\nrspamadm configdump settings dkim_signing worker\r\n** Section settings ***\r\nauthenticated {\r\n    authenticated = true;\r\n    priority = \"high\";\r\n    apply {\r\n        default {\r\n            groups_disabled [\r\n                \"dkim\",\r\n                \"bayes\",\r\n                \"spf\",\r\n                \"dmarc\",\r\n                \"rbl\",\r\n                \"surbl\",\r\n                \"dcc\",\r\n                \"header\",\r\n                \"headers\",\r\n                \"subject\",\r\n                \"mua\",\r\n                \"fuzzy\",\r\n                \"phishing\",\r\n                \"hfilter\",\r\n                \"mime_types\",\r\n                \"excessb64\",\r\n                \"compromised_hosts\",\r\n                \"upstream_spam_filters\",\r\n                \"scams\",\r\n                \"HTML\",\r\n            ]\r\n        }\r\n    }\r\n}\r\n\r\n*** End of section settings ***\r\n*** Section dkim_signing ***\r\nuse_esld = true;\r\nallow_hdrfrom_mismatch = false;\r\nselector = \"itchy\";\r\nsymbol = \"DKIM_SIGNED\";\r\nauth_only = true;\r\nallow_envfrom_empty = true;\r\ntry_fallback = true;\r\npath = \"/etc/rspamd/dkim/$selector.key\";\r\nuse_redis = false;\r\nallow_username_mismatch = true;\r\nsign_local = true;\r\nkey_prefix = \"DKIM_KEYS\";\r\nuse_domain = \"header\";\r\nallow_hdrfrom_multiple = false;\r\n\r\n*** End of section dkim_signing ***\r\n*** Section worker ***\r\nfuzzy {\r\n    backend = \"redis\";\r\n    database = 2;\r\n    allow_update [\r\n        \"127.0.0.1\",\r\n        \"::1\",\r\n    ]\r\n    expire = 7776000;\r\n    count = 4;\r\n    bind_socket = \"localhost:11335\";\r\n    sync = 60;\r\n}\r\n\r\n*** End of section worker ***\r\n*** Section worker ***\r\ntask_timeout = 8;\r\nmime = true;\r\ntype = \"normal\";\r\nenabled = false;\r\nbind_socket = \"*:11333\";\r\n\r\n*** End of section worker ***\r\n*** Section worker ***\r\nenable_password = \"nothingtoseehere\";\r\nstatic_dir = \"/usr/share/rspamd/www\";\r\npassword = \"nothingtoseehere\";\r\nsecure_ip = \"127.0.0.1\";\r\n = \"::1\";\r\ntype = \"controller\";\r\ncount = 1;\r\nbind_socket = \"localhost:11334\";\r\n = \"192.168.255.1:11334\";\r\n\r\n*** End of section worker ***\r\n*** Section worker ***\r\nrspamd_proxy {\r\n    count = 1;\r\n    timeout = 120;\r\n    type = \"proxy\";\r\n    upstream {\r\n        local {\r\n            hosts = \"localhost\";\r\n            self_scan = true;\r\n            default = true;\r\n        }\r\n    }\r\n    bind_socket = \"/run/rspamd/milter.socket mode=0660 owner=_rspamd group=mail\";\r\n    milter = true;\r\n}\r\n\r\n*** End of section worker ***\r\n```\r\n\r\n### Additional information:\r\nlogs show that the user is recognized as authenticated user:\r\n```\r\n2018-03-22 17:57:08 #7790(rspamd_proxy) <b9a876>; lua; settings.lua:312: check for settings\r\n2018-03-22 17:57:08 #7790(rspamd_proxy) <b9a876>; lua; settings.lua:339: <cd075ec0-70e7-6d4e-c220-c5ef21f7963c@mydomain> apply settings according to rule authenticated\r\n2018-03-22 17:57:08 #7790(rspamd_proxy) <b9a876>; proxy; dkim_symbol_callback: skip DKIM checks for local networks and authorized users\r\n2018-03-22 17:57:08 #7790(rspamd_proxy) <b9a876>; proxy; spf_symbol_callback: skip SPF checks for local networks and authorized users\r\n2018-03-22 17:57:08 #7790(rspamd_proxy) <b9a876>; lua; ip_score.lua:312: skip IP Score for local networks and authorized users\r\n```\r\nbut, sadly, no lines with `dkim_signing` following.\r\n"},"comment":{"url":"https://api.github.com/repos/vstakhov/rspamd/issues/comments/375431366","html_url":"https://github.com/vstakhov/rspamd/issues/2106#issuecomment-375431366","issue_url":"https://api.github.com/repos/vstakhov/rspamd/issues/2106","id":375431366,"user":{"login":"vstakhov","id":487344,"avatar_url":"https://avatars3.githubusercontent.com/u/487344?v=4","gravatar_id":"","url":"https://api.github.com/users/vstakhov","html_url":"https://github.com/vstakhov","followers_url":"https://api.github.com/users/vstakhov/followers","following_url":"https://api.github.com/users/vstakhov/following{/other_user}","gists_url":"https://api.github.com/users/vstakhov/gists{/gist_id}","starred_url":"https://api.github.com/users/vstakhov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vstakhov/subscriptions","organizations_url":"https://api.github.com/users/vstakhov/orgs","repos_url":"https://api.github.com/users/vstakhov/repos","events_url":"https://api.github.com/users/vstakhov/events{/privacy}","received_events_url":"https://api.github.com/users/vstakhov/received_events","type":"User","site_admin":false},"created_at":"2018-03-22T19:35:38Z","updated_at":"2018-03-22T19:35:38Z","author_association":"OWNER","body":"And why do you disable group `dkim`? It doesn't make sense at all! You definitely need to enable `DKIM_SIGNING` symbol in your settings."}}
{"actor":{"display_login":"vstakhov"}}