{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/litho/pulls/comments/245118834","pull_request_review_id":189162726,"id":245118834,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTExODgzNA==","diff_hunk":"@@ -18,22 +18,26 @@ import com.facebook.litho.ComponentContext\n import com.facebook.litho.Row\n import com.facebook.litho.annotations.LayoutSpec\n import com.facebook.litho.annotations.OnCreateLayout\n+import com.facebook.litho.kotlin.children\n+import com.facebook.litho.kotlin.row\n import com.facebook.litho.widget.Text\n import com.facebook.yoga.YogaEdge\n \n @LayoutSpec\n object DashPathEffectBorderSpec {\n \n   @OnCreateLayout\n-  fun onCreateLayout(c: ComponentContext): Component =\n-      Row.create(c)\n-          .child(\n-              Text.create(c).textSizeSp(20f).text(\"This component has a dash path effect applied\"))\n-          .border(\n-              Border.create(c)\n-                  .color(YogaEdge.ALL, NiceColor.BLUE)\n-                  .widthDip(YogaEdge.ALL, 5)\n-                  .dashEffect(floatArrayOf(10f, 5f), 0f)\n-                  .build())\n-          .build()\n+  fun onCreateLayout(c: ComponentContext): Component = row(c) {\n+    children {\n+      text {","path":"sample-kotlin/src/main/java/com/fblitho/lithoktsample/bordereffects/DashPathEffectBorderSpec.kt","position":26,"original_position":26,"commit_id":"6543722299124944c859dd86524d06f189874165","original_commit_id":"6543722299124944c859dd86524d06f189874165","user":{"login":"xiphirx","id":993832,"node_id":"MDQ6VXNlcjk5MzgzMg==","avatar_url":"https://avatars0.githubusercontent.com/u/993832?v=4","gravatar_id":"","url":"https://api.github.com/users/xiphirx","html_url":"https://github.com/xiphirx","followers_url":"https://api.github.com/users/xiphirx/followers","following_url":"https://api.github.com/users/xiphirx/following{/other_user}","gists_url":"https://api.github.com/users/xiphirx/gists{/gist_id}","starred_url":"https://api.github.com/users/xiphirx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiphirx/subscriptions","organizations_url":"https://api.github.com/users/xiphirx/orgs","repos_url":"https://api.github.com/users/xiphirx/repos","events_url":"https://api.github.com/users/xiphirx/events{/privacy}","received_events_url":"https://api.github.com/users/xiphirx/received_events","type":"User","site_admin":false},"body":"I wonder if it is worth differentiating when you're creating a component vs specifying an attribute. Upper casing the functions that create a component seems good to me although it breaks convention. It would look like\r\n\r\n```\r\nRow(c) {\r\n  children {\r\n    Text {\r\n      text(\"hi\")\r\n...\r\n\r\n```","created_at":"2019-01-03T20:09:37Z","updated_at":"2019-01-03T20:16:11Z","html_url":"https://github.com/facebook/litho/pull/406#discussion_r245118834","pull_request_url":"https://api.github.com/repos/facebook/litho/pulls/406","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/facebook/litho/pulls/comments/245118834"},"html":{"href":"https://github.com/facebook/litho/pull/406#discussion_r245118834"},"pull_request":{"href":"https://api.github.com/repos/facebook/litho/pulls/406"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/litho/pulls/406","id":204038917,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MDM4OTE3","html_url":"https://github.com/facebook/litho/pull/406","diff_url":"https://github.com/facebook/litho/pull/406.diff","patch_url":"https://github.com/facebook/litho/pull/406.patch","issue_url":"https://api.github.com/repos/facebook/litho/issues/406","number":406,"state":"open","locked":false,"title":"Add litho-kotlin with LithoKotlinDsl","user":{"login":"vinc3m1","id":498852,"node_id":"MDQ6VXNlcjQ5ODg1Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/498852?v=4","gravatar_id":"","url":"https://api.github.com/users/vinc3m1","html_url":"https://github.com/vinc3m1","followers_url":"https://api.github.com/users/vinc3m1/followers","following_url":"https://api.github.com/users/vinc3m1/following{/other_user}","gists_url":"https://api.github.com/users/vinc3m1/gists{/gist_id}","starred_url":"https://api.github.com/users/vinc3m1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinc3m1/subscriptions","organizations_url":"https://api.github.com/users/vinc3m1/orgs","repos_url":"https://api.github.com/users/vinc3m1/repos","events_url":"https://api.github.com/users/vinc3m1/events{/privacy}","received_events_url":"https://api.github.com/users/vinc3m1/received_events","type":"User","site_admin":false},"body":"This isn't ready yet, but open to discussion. Or if you all want to take what is here and import/modify, that's fine too.","created_at":"2018-07-26T06:20:32Z","updated_at":"2019-01-03T20:16:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe010ead81b6c73eb6cdd8b036169215bf30e608","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":526868498,"node_id":"MDU6TGFiZWw1MjY4Njg0OTg=","url":"https://api.github.com/repos/facebook/litho/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/litho/pulls/406/commits","review_comments_url":"https://api.github.com/repos/facebook/litho/pulls/406/comments","review_comment_url":"https://api.github.com/repos/facebook/litho/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/litho/issues/406/comments","statuses_url":"https://api.github.com/repos/facebook/litho/statuses/6543722299124944c859dd86524d06f189874165","head":{"label":"vinc3m1:kotlin-dsl","ref":"kotlin-dsl","sha":"6543722299124944c859dd86524d06f189874165","user":{"login":"vinc3m1","id":498852,"node_id":"MDQ6VXNlcjQ5ODg1Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/498852?v=4","gravatar_id":"","url":"https://api.github.com/users/vinc3m1","html_url":"https://github.com/vinc3m1","followers_url":"https://api.github.com/users/vinc3m1/followers","following_url":"https://api.github.com/users/vinc3m1/following{/other_user}","gists_url":"https://api.github.com/users/vinc3m1/gists{/gist_id}","starred_url":"https://api.github.com/users/vinc3m1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinc3m1/subscriptions","organizations_url":"https://api.github.com/users/vinc3m1/orgs","repos_url":"https://api.github.com/users/vinc3m1/repos","events_url":"https://api.github.com/users/vinc3m1/events{/privacy}","received_events_url":"https://api.github.com/users/vinc3m1/received_events","type":"User","site_admin":false},"repo":{"id":112376482,"node_id":"MDEwOlJlcG9zaXRvcnkxMTIzNzY0ODI=","name":"litho","full_name":"vinc3m1/litho","private":false,"owner":{"login":"vinc3m1","id":498852,"node_id":"MDQ6VXNlcjQ5ODg1Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/498852?v=4","gravatar_id":"","url":"https://api.github.com/users/vinc3m1","html_url":"https://github.com/vinc3m1","followers_url":"https://api.github.com/users/vinc3m1/followers","following_url":"https://api.github.com/users/vinc3m1/following{/other_user}","gists_url":"https://api.github.com/users/vinc3m1/gists{/gist_id}","starred_url":"https://api.github.com/users/vinc3m1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinc3m1/subscriptions","organizations_url":"https://api.github.com/users/vinc3m1/orgs","repos_url":"https://api.github.com/users/vinc3m1/repos","events_url":"https://api.github.com/users/vinc3m1/events{/privacy}","received_events_url":"https://api.github.com/users/vinc3m1/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vinc3m1/litho","description":"A declarative framework for building efficient UIs on Android.","fork":true,"url":"https://api.github.com/repos/vinc3m1/litho","forks_url":"https://api.github.com/repos/vinc3m1/litho/forks","keys_url":"https://api.github.com/repos/vinc3m1/litho/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vinc3m1/litho/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vinc3m1/litho/teams","hooks_url":"https://api.github.com/repos/vinc3m1/litho/hooks","issue_events_url":"https://api.github.com/repos/vinc3m1/litho/issues/events{/number}","events_url":"https://api.github.com/repos/vinc3m1/litho/events","assignees_url":"https://api.github.com/repos/vinc3m1/litho/assignees{/user}","branches_url":"https://api.github.com/repos/vinc3m1/litho/branches{/branch}","tags_url":"https://api.github.com/repos/vinc3m1/litho/tags","blobs_url":"https://api.github.com/repos/vinc3m1/litho/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vinc3m1/litho/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vinc3m1/litho/git/refs{/sha}","trees_url":"https://api.github.com/repos/vinc3m1/litho/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vinc3m1/litho/statuses/{sha}","languages_url":"https://api.github.com/repos/vinc3m1/litho/languages","stargazers_url":"https://api.github.com/repos/vinc3m1/litho/stargazers","contributors_url":"https://api.github.com/repos/vinc3m1/litho/contributors","subscribers_url":"https://api.github.com/repos/vinc3m1/litho/subscribers","subscription_url":"https://api.github.com/repos/vinc3m1/litho/subscription","commits_url":"https://api.github.com/repos/vinc3m1/litho/commits{/sha}","git_commits_url":"https://api.github.com/repos/vinc3m1/litho/git/commits{/sha}","comments_url":"https://api.github.com/repos/vinc3m1/litho/comments{/number}","issue_comment_url":"https://api.github.com/repos/vinc3m1/litho/issues/comments{/number}","contents_url":"https://api.github.com/repos/vinc3m1/litho/contents/{+path}","compare_url":"https://api.github.com/repos/vinc3m1/litho/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vinc3m1/litho/merges","archive_url":"https://api.github.com/repos/vinc3m1/litho/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vinc3m1/litho/downloads","issues_url":"https://api.github.com/repos/vinc3m1/litho/issues{/number}","pulls_url":"https://api.github.com/repos/vinc3m1/litho/pulls{/number}","milestones_url":"https://api.github.com/repos/vinc3m1/litho/milestones{/number}","notifications_url":"https://api.github.com/repos/vinc3m1/litho/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vinc3m1/litho/labels{/name}","releases_url":"https://api.github.com/repos/vinc3m1/litho/releases{/id}","deployments_url":"https://api.github.com/repos/vinc3m1/litho/deployments","created_at":"2017-11-28T18:59:56Z","updated_at":"2018-12-21T17:58:36Z","pushed_at":"2018-12-21T17:58:33Z","git_url":"git://github.com/vinc3m1/litho.git","ssh_url":"git@github.com:vinc3m1/litho.git","clone_url":"https://github.com/vinc3m1/litho.git","svn_url":"https://github.com/vinc3m1/litho","homepage":"http://fblitho.com","size":325980,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"a5a918aaa12515d782422ff3e2dc56337d8671e4","user":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":80179724,"node_id":"MDEwOlJlcG9zaXRvcnk4MDE3OTcyNA==","name":"litho","full_name":"facebook/litho","private":false,"owner":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/facebook/litho","description":"A declarative framework for building efficient UIs on Android.","fork":false,"url":"https://api.github.com/repos/facebook/litho","forks_url":"https://api.github.com/repos/facebook/litho/forks","keys_url":"https://api.github.com/repos/facebook/litho/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/litho/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/litho/teams","hooks_url":"https://api.github.com/repos/facebook/litho/hooks","issue_events_url":"https://api.github.com/repos/facebook/litho/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/litho/events","assignees_url":"https://api.github.com/repos/facebook/litho/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/litho/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/litho/tags","blobs_url":"https://api.github.com/repos/facebook/litho/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/litho/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/litho/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/litho/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/litho/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/litho/languages","stargazers_url":"https://api.github.com/repos/facebook/litho/stargazers","contributors_url":"https://api.github.com/repos/facebook/litho/contributors","subscribers_url":"https://api.github.com/repos/facebook/litho/subscribers","subscription_url":"https://api.github.com/repos/facebook/litho/subscription","commits_url":"https://api.github.com/repos/facebook/litho/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/litho/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/litho/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/litho/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/litho/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/litho/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/litho/merges","archive_url":"https://api.github.com/repos/facebook/litho/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/litho/downloads","issues_url":"https://api.github.com/repos/facebook/litho/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/litho/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/litho/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/litho/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/litho/labels{/name}","releases_url":"https://api.github.com/repos/facebook/litho/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/litho/deployments","created_at":"2017-01-27T03:59:11Z","updated_at":"2019-01-03T14:49:20Z","pushed_at":"2019-01-03T14:49:16Z","git_url":"git://github.com/facebook/litho.git","ssh_url":"git@github.com:facebook/litho.git","clone_url":"https://github.com/facebook/litho.git","svn_url":"https://github.com/facebook/litho","homepage":"https://fblitho.com","size":326133,"stargazers_count":5545,"watchers_count":5545,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":474,"mirror_url":null,"archived":false,"open_issues_count":73,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":474,"open_issues":73,"watchers":5545,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/litho/pulls/406"},"html":{"href":"https://github.com/facebook/litho/pull/406"},"issue":{"href":"https://api.github.com/repos/facebook/litho/issues/406"},"comments":{"href":"https://api.github.com/repos/facebook/litho/issues/406/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/litho/pulls/406/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/litho/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/litho/pulls/406/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/litho/statuses/6543722299124944c859dd86524d06f189874165"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"xiphirx"}}