{"action":"created","issue":{"url":"https://api.github.com/repos/linkerd/linkerd2/issues/187","repository_url":"https://api.github.com/repos/linkerd/linkerd2","labels_url":"https://api.github.com/repos/linkerd/linkerd2/issues/187/labels{/name}","comments_url":"https://api.github.com/repos/linkerd/linkerd2/issues/187/comments","events_url":"https://api.github.com/repos/linkerd/linkerd2/issues/187/events","html_url":"https://github.com/linkerd/linkerd2/issues/187","id":290123968,"node_id":"MDU6SXNzdWUyOTAxMjM5Njg=","number":187,"title":"Adjust telemetry reporting of paths to handle higher cardinality","user":{"login":"seanmonstar","id":51479,"node_id":"MDQ6VXNlcjUxNDc5","avatar_url":"https://avatars1.githubusercontent.com/u/51479?v=4","gravatar_id":"","url":"https://api.github.com/users/seanmonstar","html_url":"https://github.com/seanmonstar","followers_url":"https://api.github.com/users/seanmonstar/followers","following_url":"https://api.github.com/users/seanmonstar/following{/other_user}","gists_url":"https://api.github.com/users/seanmonstar/gists{/gist_id}","starred_url":"https://api.github.com/users/seanmonstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanmonstar/subscriptions","organizations_url":"https://api.github.com/users/seanmonstar/orgs","repos_url":"https://api.github.com/users/seanmonstar/repos","events_url":"https://api.github.com/users/seanmonstar/events{/privacy}","received_events_url":"https://api.github.com/users/seanmonstar/received_events","type":"User","site_admin":false},"labels":[{"id":773710190,"node_id":"MDU6TGFiZWw3NzM3MTAxOTA=","url":"https://api.github.com/repos/linkerd/linkerd2/labels/area/controller","name":"area/controller","color":"0052CC","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-01-19T22:16:57Z","updated_at":"2018-10-09T17:57:25Z","closed_at":"2018-10-09T17:57:25Z","author_association":"CONTRIBUTOR","body":"WIth the inclusion of HTTP/1 traffic through the proxy, there will likely be many more unique paths reported through the telemetry than when just proxying gRPC traffic. The controller currently stores the request path as a label in Prometheus. Prometheus documentation recommends not using labels with high cardinality, or things go badly, so we need to adjust this before shipping Proxy Transparency.\r\n\r\nSome things we can do:\r\n\r\n1. Remove the path from telemetry entirely. This is the easiest approach, but request paths can be very useful, so this would seem unfortunate to lose completely.\r\n2. Try to dynamically build up patterns of paths to collapse them. This would probably be a lot more work, but is probably the most desirable.\r\n3. Allow a user to configure patterns and/or the reporting of paths. We're hoping to be a no-config tool, so this is probably not the way forward.\r\n\r\ncc #167 "},"comment":{"url":"https://api.github.com/repos/linkerd/linkerd2/issues/comments/428289237","html_url":"https://github.com/linkerd/linkerd2/issues/187#issuecomment-428289237","issue_url":"https://api.github.com/repos/linkerd/linkerd2/issues/187","id":428289237,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODI4OTIzNw==","user":{"login":"klingerf","id":9226,"node_id":"MDQ6VXNlcjkyMjY=","avatar_url":"https://avatars0.githubusercontent.com/u/9226?v=4","gravatar_id":"","url":"https://api.github.com/users/klingerf","html_url":"https://github.com/klingerf","followers_url":"https://api.github.com/users/klingerf/followers","following_url":"https://api.github.com/users/klingerf/following{/other_user}","gists_url":"https://api.github.com/users/klingerf/gists{/gist_id}","starred_url":"https://api.github.com/users/klingerf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klingerf/subscriptions","organizations_url":"https://api.github.com/users/klingerf/orgs","repos_url":"https://api.github.com/users/klingerf/repos","events_url":"https://api.github.com/users/klingerf/events{/privacy}","received_events_url":"https://api.github.com/users/klingerf/received_events","type":"User","site_admin":false},"created_at":"2018-10-09T17:57:25Z","updated_at":"2018-10-09T17:57:25Z","author_association":"MEMBER","body":"Am going to close this as fixed. For the record, the fix that's in place now is this proposal from the issue description:\r\n\r\n> 1. Remove the path from telemetry entirely. This is the easiest approach, but request paths can be very useful, so this would seem unfortunate to lose completely.\r\n\r\nAdditional work for recording historical path stats is being tracked in #1737."}}
{"actor":{"display_login":"klingerf"}}