{"push_id":2977886868,"size":30,"distinct_size":2,"ref":"refs/heads/iconTest","head":"c2a450cc785364356047b1b0313205fbeed63a1e","before":"e9713a1ba1af21076594fbd6602ba1c366026f73","commits":[{"sha":"441cdc5abd37b91295b10c23f2e053726ddf3e9c","author":{"name":"Sereri","email":"fa7ac9992e0f44d027b174fe2b0d691ffc662e5e@gmx.net"},"message":"Fix forum iframes not using cookies","distinct":false,"url":"https://api.github.com/repos/Sereri/Awful.apk/commits/441cdc5abd37b91295b10c23f2e053726ddf3e9c"},{"sha":"c477c2eaffd655291f5b9670f24717175077c23a","author":{"name":"Sereri","email":"fa7ac9992e0f44d027b174fe2b0d691ffc662e5e@gmx.net"},"message":"Implemented longtap to show URL menu for video tags. Refactored tagname logic in thread.js","distinct":false,"url":"https://api.github.com/repos/Sereri/Awful.apk/commits/c477c2eaffd655291f5b9670f24717175077c23a"},{"sha":"d09e18fa5c3031868651e36134535e282024989e","author":{"name":"Sereri","email":"85f49d192e11784fffed472ee5ca8b9b21c3b888@users.noreply.github.com"},"message":"Merge pull request #619 from Sereri/iframeFix\n\nFix forum iframes not using cookies","distinct":false,"url":"https://api.github.com/repos/Sereri/Awful.apk/commits/d09e18fa5c3031868651e36134535e282024989e"},{"sha":"587f0ce87a82e813cdfb8abc261b075c0bb7158f","author":{"name":"Sereri","email":"85f49d192e11784fffed472ee5ca8b9b21c3b888@users.noreply.github.com"},"message":"Merge pull request #621 from Sereri/videoLongTap\n\nImplemented longtap to show URL menu for video tags. Refactored tagna…","distinct":false,"url":"https://api.github.com/repos/Sereri/Awful.apk/commits/587f0ce87a82e813cdfb8abc261b075c0bb7158f"},{"sha":"854a1d4111837995cb1b047b9a745784abd04e64","author":{"name":"Sereri","email":"85f49d192e11784fffed472ee5ca8b9b21c3b888@users.noreply.github.com"},"message":"Fixed instagram embedding which was crashing useful stuff (#623)\n\n* Fixed instagram embedding which was crashing useful stuff","distinct":false,"url":"https://api.github.com/repos/Sereri/Awful.apk/commits/854a1d4111837995cb1b047b9a745784abd04e64"},{"sha":"378bfff4a2b7a21737ea6fa32df6b938b7d394da","author":{"name":"baka-kaba","email":"ea5e5c4b748f3f079859d2eaac1de9f77ca10d39@users.noreply.github.com"},"message":"Rework search filters, fix NavigationEvent.Url serialisation (#624)\n\nThe Url event wasn't fully implemented, so the #toIntent handling\r\nbasically created an Intent with no data. I've added that, so now\r\nthe Intents we create will parse back correctly.\r\n\r\nI've overhauled search's filtering system - now there's a separate\r\nSearchFilter class contains one of the filter types we handle, and\r\nthe data for that filter. The menu is automatically populated from\r\nthese types, each type can spawn a dialog for the data it needs, and\r\nthe fragment gets a callback when a new filter is added.\r\n\r\nThere are two ideas behind this. The first is implemented - the Search\r\nNavigationEvent now takes an optional set of configured SearchFilters,\r\nwhich means that other components can navigate to the Search section\r\nand specify some filters to populate it with. I've added a \"search\r\nthis forum\" option to the thread list context menu which does this, but\r\nyou can specify any combination. \"Search for this user in this thread\",\r\n\"who quoted me today\", that kind of thing.\r\n\r\nThe second idea is to make the filter UI easier to work with - ideally\r\nsomething like a list of added filters, where you can edit each one\r\n(maybe to change some terms) or swipe it away. Right now it still adds\r\neach new filter to the text field like before, but they're represented\r\nby SearchFilter objects - the fragment just needs to store them as a\r\ndata set and let the RecyclerView work with it. You can query each of\r\nthem to build up the final query string for the request, and keep that\r\ntext representation out of sight","distinct":false,"url":"https://api.github.com/repos/Sereri/Awful.apk/commits/378bfff4a2b7a21737ea6fa32df6b938b7d394da"},{"sha":"7b6233a780835834178f57cc5c77baa31f9894b8","author":{"name":"baka-kaba","email":"ea5e5c4b748f3f079859d2eaac1de9f77ca10d39@users.noreply.github.com"},"message":"Revert support library to 27.0.2 to avoid a breaking change (#625)\n\nSee Issue #616\r\nThey changed the behaviour of Loaders, including forcing them to reload\r\nwhen a fragment or activity hits #onStart\r\nChanges:\r\nhttps://developer.android.com/topic/libraries/support-library/revisions#27-1-0\r\nIntended behavior / WONTFIX:\r\nhttps://issuetracker.google.com/issues/74278849\r\n\r\nThis makes the thread page reload every time the user switches away from\r\nthe app, or visits a link and returns, turns the screen off... page\r\nloading isn't designed to handle this, and if it was initially loaded\r\nwith a post to jump to (either a post ID fragment or \"jump to last read\")\r\nit'll jump back there again, every time. It makes catching up with a\r\nthread a really bad experience\r\n\r\nA real fix would require an overhaul - I can't see any reliable way to\r\nblock these specific reloads and not others (e.g. recreating a fragment)\r\nwithout a lot of additional complexity. Vetoing the scroll behaviour\r\nwould require keeping track of when a post jump has been \"consumed\" so\r\nit doesn't happen more than once, but it also needs to be able to identify\r\na \"new\" load - if the user hits a \"jump to post\" link that scrolls\r\nsomewhere in the same page, and then scrolls down, you don't want it to\r\nscroll back if they navigate away and back to the app. But if they scroll\r\nto the jump link again and hit it, the scroll needs to happen this time\r\n\r\nScrolling in the WebView needs fixing in general - right now there's no\r\nway to get and restore the current scroll position, so we can't really\r\nrecreate fragment state","distinct":false,"url":"https://api.github.com/repos/Sereri/Awful.apk/commits/7b6233a780835834178f57cc5c77baa31f9894b8"},{"sha":"34e6c184bee32a004e83bfbdb9d2e3c4f229a6da","author":{"name":"Sereri","email":"fa7ac9992e0f44d027b174fe2b0d691ffc662e5e@gmx.net"},"message":"Overhaul all the CSS. Sorry ArcMage","distinct":false,"url":"https://api.github.com/repos/Sereri/Awful.apk/commits/34e6c184bee32a004e83bfbdb9d2e3c4f229a6da"},{"sha":"d52469ed4f9c087906112d9a7604e80eb81522dc","author":{"name":"Sereri","email":"fa7ac9992e0f44d027b174fe2b0d691ffc662e5e@gmx.net"},"message":"Merge remote-tracking branch 'upstream/develop' into develop\n\n# Conflicts:\n#\tAwful.apk/src/main/assets/javascript/thread.js","distinct":false,"url":"https://api.github.com/repos/Sereri/Awful.apk/commits/d52469ed4f9c087906112d9a7604e80eb81522dc"},{"sha":"c3cdab5f575571e1c8746e08a30eb4d0e11cb2da","author":{"name":"Sereri","email":"fa7ac9992e0f44d027b174fe2b0d691ffc662e5e@gmx.net"},"message":"Fix top border in oled theme","distinct":false,"url":"https://api.github.com/repos/Sereri/Awful.apk/commits/c3cdab5f575571e1c8746e08a30eb4d0e11cb2da"},{"sha":"2b6f49cce0747ed31dd95e8dba1ff509b1229dbf","author":{"name":"Sereri","email":"fa7ac9992e0f44d027b174fe2b0d691ffc662e5e@gmx.net"},"message":"Increase postmenu button interaction area to accommodate goonish fingers","distinct":false,"url":"https://api.github.com/repos/Sereri/Awful.apk/commits/2b6f49cce0747ed31dd95e8dba1ff509b1229dbf"},{"sha":"bd461cec28cce496ad1799d9dca1c56129a4dd13","author":{"name":"baka-kaba","email":"ea5e5c4b748f3f079859d2eaac1de9f77ca10d39@users.noreply.github.com"},"message":"Enable fullscreen videos in the WebView (#629)\n\nCreates a fullscreen dialog and sets the view passed by the webview as\r\nthe dialog's contents. This sets the system UI flags to the standard\r\nfullscreen/immersive-sticky setup, and resets them when the activity\r\nregains focus.\r\n\r\nThere are a couple of issues - one is that the fullscreen dialog is\r\nsometimes blank, but the content is there and you can still interact\r\nwith it - you just can't see it. Swiping on the screen makes it appear.\r\nThe main issue is that the navigation and status bars remain hidden\r\nafter the UI flags are reset, until the userdoes something to bring them\r\nback (poking those areas, flipping the viewpager, rotating the screen\r\netc).\r\n\r\nI've added a handler and a runnable to post to it that forces the\r\n\"show UI\" flags on a delay, but the delay doesn't seem to make any\r\ndifference to when the flag is applied. It doesn't work without setting\r\nthe flag, but it can take effect and the UI can pop back in at any time,\r\nbefore the runnable itself is executed. It Is A Mystery!\r\n\r\nSo sometimes it behaves and the layout has space ready for the UI to\r\nneatly slide back in, and sometimes the UI appears over the layout and\r\nit redraws and looks janky. I've tried a lot and it seems like you can\r\neither have this inconsistent behaviour, or leave the UI hidden until\r\nthe user does something to bring it back.","distinct":false,"url":"https://api.github.com/repos/Sereri/Awful.apk/commits/bd461cec28cce496ad1799d9dca1c56129a4dd13"},{"sha":"b6d88acb663d7a59ddd96aa8e9ed2b3081712b60","author":{"name":"mensab","email":"390fe71ef8d8b41a9beab781c16415246f89b0ef@users.noreply.github.com"},"message":"Modified processPostImage to handle images that are wrapped in an a tag when images are disabled.\n\nissue #627","distinct":false,"url":"https://api.github.com/repos/Sereri/Awful.apk/commits/b6d88acb663d7a59ddd96aa8e9ed2b3081712b60"},{"sha":"e295a7882b88ecc245a664ef5bd47b5b637defec","author":{"name":"mensab","email":"390fe71ef8d8b41a9beab781c16415246f89b0ef@users.noreply.github.com"},"message":"Modified processPostImage to handle images that are wrapped in an a tag when images are disabled.\nSmall update\n\nissue #627","distinct":false,"url":"https://api.github.com/repos/Sereri/Awful.apk/commits/e295a7882b88ecc245a664ef5bd47b5b637defec"},{"sha":"9f910d16b7850ac972ebbbb4a0205cd0d0e733d0","author":{"name":"mensab","email":"390fe71ef8d8b41a9beab781c16415246f89b0ef@users.noreply.github.com"},"message":"Image url appears before link url\nissue #627","distinct":false,"url":"https://api.github.com/repos/Sereri/Awful.apk/commits/9f910d16b7850ac972ebbbb4a0205cd0d0e733d0"},{"sha":"a0f84bb7d2649688b608a91ce8209db6f7650a73","author":{"name":"mensab","email":"390fe71ef8d8b41a9beab781c16415246f89b0ef@users.noreply.github.com"},"message":"Modified processPostImage to handle images that are wrapped in an a tag when images are disabled.\n\nissue #627","distinct":false,"url":"https://api.github.com/repos/Sereri/Awful.apk/commits/a0f84bb7d2649688b608a91ce8209db6f7650a73"},{"sha":"e11d3e9a93bda08d382dc4f869b09484151d8cc9","author":{"name":"baka-kaba","email":"ea5e5c4b748f3f079859d2eaac1de9f77ca10d39@users.noreply.github.com"},"message":"Fix loader behaviour with new Support Libraries (#630)\n\nUpdated support libraries to 27.1.1\r\n\r\nMoved \"current body HTML\" state (i.e. the HTML that's displayed in the\r\ncontainer div) into the WebView components, instead of making the\r\nWebView's owner responsible for storing it and providing it - now that\r\njust pushes the data to the WebView when it wants something displayed.\r\nThe HTML state is stored in the WebViewJsInterface along with other\r\nstate like the preferences, and also avoids issues with being called on the\r\nJS thread (since the WebView is a UI component on the main thread)\r\n\r\nAdded a check to skip body HTML updates when the content hasn't\r\nchanged. This fixes the \"reloading\" behaviour triggered by the loader that\r\nwas resetting the page scroll position - since the loader is just pulling the\r\nsame data from the cache (it's not even updating from the site) then the\r\ncontents haven't changed. An actual reload over the network will trigger\r\nan update if that page data is different (edits, new posts etc). The new HTML\r\nis compared to the last version passed to the WebView - *not* the HTML\r\ncurrently being displayed, since the DOM may have changed e.g. rewriting\r\ncontent, expanding or hiding posts etc.\r\n\r\nFixes #616\r\n\r\nSome cleanup:\r\n\r\nI've removed WebViewClient#onPageFinished methods that were\r\nrefreshing the WebView with this stored state - as far as I can tell\r\nthey don't actually do anything. I assume the idea was to refresh the\r\npage (and scroll position) when the content finishes loading and the\r\nlayout is stable. But that method only seems to fire once, when the\r\ncontainer HTML is loaded - after that we just switch out the contents\r\nof the container div, and that doesn't trigger any loading callback.\r\nMaybe we can add one?\r\n\r\nAlso removed the showBlankPage behaviour in ThreadDisplayFragment#syncPosts\r\nsince it's not really anything to do with syncing and all the sync calls\r\nare preceded by a call to that method anyway. \r\n\r\nRemoved 'force'/'checkFirst' flags from html display functions -\r\nnot sure what this was even for, only one method call wanted to use this\r\n'checkFirst' behaviour and I don't know why (it would ignore the request\r\nto update the displayed html unless the page was blank, and I don't know\r\nwhy you'd want to do that)","distinct":false,"url":"https://api.github.com/repos/Sereri/Awful.apk/commits/e11d3e9a93bda08d382dc4f869b09484151d8cc9"},{"sha":"1359fb933bdd0af1347644ea7d0efbb979bd8f1a","author":{"name":"baka kaba","email":"aa3b120ee7e74d549cf969eeadcafd3172a631d4@email.nope"},"message":"Add confirmation dialog when locking/unlocking a thread","distinct":false,"url":"https://api.github.com/repos/Sereri/Awful.apk/commits/1359fb933bdd0af1347644ea7d0efbb979bd8f1a"},{"sha":"def8013c03c44e51dedfd99d2646f6b4eac7445b","author":{"name":"baka kaba","email":"aa3b120ee7e74d549cf969eeadcafd3172a631d4@email.nope"},"message":"Rename \"open/close thread\" methods and variables as \"lock/unlock\"\n\nThis is clearer and easier to talk about - \"open\" especially sounds like\nviewing a thread, and people discussing this issue were already getting\nconfused about what people meant by \"close\".\n\nThe site itself uses an action parameter called \"threadopenclose\" but\nthat's their problem","distinct":false,"url":"https://api.github.com/repos/Sereri/Awful.apk/commits/def8013c03c44e51dedfd99d2646f6b4eac7445b"},{"sha":"7700909be25b600a2bd5518a555fd8ec9ae1ff2f","author":{"name":"baka kaba","email":"aa3b120ee7e74d549cf969eeadcafd3172a631d4@email.nope"},"message":"Fix jump-to-post behaviour for 'showthread.php' links\n\nFragment strings were being handled inconsistently, with the 'post'\nprefix being stripped if you were redirected to a showthread.php link,\nbut not if you opened one directly. thread.js was readding the prefix,\nso on some links you got 'postpost1234' and it obviously wouldn't work.\n\nI moved all that code into the postJump setter so it formats everything\nconsistently and in one place. Now those URLs actually work I've\nimplemented the postJump parameter in the NavigationEvent's intent parser\n\nSome apps helpfully strip out the fragment when passing a URL in as\nIntent data (e.g. Contacts app), so there's not a lot we can do about that...","distinct":false,"url":"https://api.github.com/repos/Sereri/Awful.apk/commits/7700909be25b600a2bd5518a555fd8ec9ae1ff2f"}]}
{"actor":{"display_login":"Sereri"}}