{"action":"closed","number":27996,"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/27996","id":202535156,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNTM1MTU2","html_url":"https://github.com/symfony/symfony/pull/27996","diff_url":"https://github.com/symfony/symfony/pull/27996.diff","patch_url":"https://github.com/symfony/symfony/pull/27996.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/27996","number":27996,"state":"closed","locked":false,"title":"Form theme that removed custom bootstrap css class from input type file","user":{"login":"lsv","id":20708,"node_id":"MDQ6VXNlcjIwNzA4","avatar_url":"https://avatars3.githubusercontent.com/u/20708?v=4","gravatar_id":"","url":"https://api.github.com/users/lsv","html_url":"https://github.com/lsv","followers_url":"https://api.github.com/users/lsv/followers","following_url":"https://api.github.com/users/lsv/following{/other_user}","gists_url":"https://api.github.com/users/lsv/gists{/gist_id}","starred_url":"https://api.github.com/users/lsv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsv/subscriptions","organizations_url":"https://api.github.com/users/lsv/orgs","repos_url":"https://api.github.com/users/lsv/repos","events_url":"https://api.github.com/users/lsv/events{/privacy}","received_events_url":"https://api.github.com/users/lsv/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master\r\n| Bug fix?      | no\r\n| New feature?  | yes \r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | #27477 \r\n| License       | MIT\r\n| Doc PR        | I will create a little info box on the https://github.com/symfony/symfony-docs/blob/master/form/bootstrap4.rst if approved\r\n\r\nThis will create a new bootstrap theme that removes the custom css class from `<input type=\"file\">` so the user can now see what files that are selected in the input.\r\n\r\nI have decided to keep the custom radio/checkbox, as these dont break the functionality.\r\n\r\n### Before\r\n\r\n![selection_111](https://user-images.githubusercontent.com/20708/42940905-4752d5ce-8b5b-11e8-9d2c-c963acc70d47.png)\r\n\r\n### After\r\n\r\n![selection_109](https://user-images.githubusercontent.com/20708/42940920-50f6b60e-8b5b-11e8-84cb-8024e5c7c9cc.png)\r\n\r\n### Usage\r\n\r\n```yaml\r\ntwig:\r\n    form_themes: ['bootstrap_4_nocustom_layout.html.twig']\r\n```\r\n\r\nThis a follow up to #27478 ","created_at":"2018-07-19T11:55:59Z","updated_at":"2018-09-21T08:42:17Z","closed_at":"2018-09-21T08:42:16Z","merged_at":null,"merge_commit_sha":"06d72125ced3579e237dabb43a11ed15a2b6c179","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":100378,"node_id":"MDU6TGFiZWwxMDAzNzg=","url":"https://api.github.com/repos/symfony/symfony/labels/Feature","name":"Feature","color":"02e10c","default":false},{"id":237003792,"node_id":"MDU6TGFiZWwyMzcwMDM3OTI=","url":"https://api.github.com/repos/symfony/symfony/labels/Status:%20Needs%20Review","name":"Status: Needs Review","color":"ededed","default":false}],"milestone":{"url":"https://api.github.com/repos/symfony/symfony/milestones/18","html_url":"https://github.com/symfony/symfony/milestone/18","labels_url":"https://api.github.com/repos/symfony/symfony/milestones/18/labels","id":3234645,"node_id":"MDk6TWlsZXN0b25lMzIzNDY0NQ==","number":18,"title":"next","description":"https://symfony.com/roadmap?version=4.2#checker","creator":{"login":"nicolas-grekas","id":243674,"node_id":"MDQ6VXNlcjI0MzY3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/243674?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"open_issues":152,"closed_issues":235,"state":"open","created_at":"2018-04-02T12:03:21Z","updated_at":"2018-09-21T08:42:17Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/27996/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/27996/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/27996/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/b77c1ae76d55925649fdea53aac2c3ca4b0a5042","head":{"label":"lsv:feature/twig-remove-custom-bootstrap","ref":"feature/twig-remove-custom-bootstrap","sha":"b77c1ae76d55925649fdea53aac2c3ca4b0a5042","user":{"login":"lsv","id":20708,"node_id":"MDQ6VXNlcjIwNzA4","avatar_url":"https://avatars3.githubusercontent.com/u/20708?v=4","gravatar_id":"","url":"https://api.github.com/users/lsv","html_url":"https://github.com/lsv","followers_url":"https://api.github.com/users/lsv/followers","following_url":"https://api.github.com/users/lsv/following{/other_user}","gists_url":"https://api.github.com/users/lsv/gists{/gist_id}","starred_url":"https://api.github.com/users/lsv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsv/subscriptions","organizations_url":"https://api.github.com/users/lsv/orgs","repos_url":"https://api.github.com/users/lsv/repos","events_url":"https://api.github.com/users/lsv/events{/privacy}","received_events_url":"https://api.github.com/users/lsv/received_events","type":"User","site_admin":false},"repo":{"id":135856090,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU4NTYwOTA=","name":"symfony","full_name":"lsv/symfony","private":false,"owner":{"login":"lsv","id":20708,"node_id":"MDQ6VXNlcjIwNzA4","avatar_url":"https://avatars3.githubusercontent.com/u/20708?v=4","gravatar_id":"","url":"https://api.github.com/users/lsv","html_url":"https://github.com/lsv","followers_url":"https://api.github.com/users/lsv/followers","following_url":"https://api.github.com/users/lsv/following{/other_user}","gists_url":"https://api.github.com/users/lsv/gists{/gist_id}","starred_url":"https://api.github.com/users/lsv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsv/subscriptions","organizations_url":"https://api.github.com/users/lsv/orgs","repos_url":"https://api.github.com/users/lsv/repos","events_url":"https://api.github.com/users/lsv/events{/privacy}","received_events_url":"https://api.github.com/users/lsv/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lsv/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/lsv/symfony","forks_url":"https://api.github.com/repos/lsv/symfony/forks","keys_url":"https://api.github.com/repos/lsv/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsv/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsv/symfony/teams","hooks_url":"https://api.github.com/repos/lsv/symfony/hooks","issue_events_url":"https://api.github.com/repos/lsv/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/lsv/symfony/events","assignees_url":"https://api.github.com/repos/lsv/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/lsv/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/lsv/symfony/tags","blobs_url":"https://api.github.com/repos/lsv/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsv/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsv/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsv/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsv/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/lsv/symfony/languages","stargazers_url":"https://api.github.com/repos/lsv/symfony/stargazers","contributors_url":"https://api.github.com/repos/lsv/symfony/contributors","subscribers_url":"https://api.github.com/repos/lsv/symfony/subscribers","subscription_url":"https://api.github.com/repos/lsv/symfony/subscription","commits_url":"https://api.github.com/repos/lsv/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsv/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsv/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsv/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsv/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/lsv/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsv/symfony/merges","archive_url":"https://api.github.com/repos/lsv/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsv/symfony/downloads","issues_url":"https://api.github.com/repos/lsv/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/lsv/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/lsv/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/lsv/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsv/symfony/labels{/name}","releases_url":"https://api.github.com/repos/lsv/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/lsv/symfony/deployments","created_at":"2018-06-02T22:16:57Z","updated_at":"2018-07-19T11:34:09Z","pushed_at":"2018-07-19T11:46:38Z","git_url":"git://github.com/lsv/symfony.git","ssh_url":"git@github.com:lsv/symfony.git","clone_url":"https://github.com/lsv/symfony.git","svn_url":"https://github.com/lsv/symfony","homepage":"https://symfony.com","size":115758,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"4b92b96796d381b225b6665b15160c4c9b06cf41","user":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"node_id":"MDEwOlJlcG9zaXRvcnk0NTgwNTg=","name":"symfony","full_name":"symfony/symfony","private":false,"owner":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2018-09-21T07:43:02Z","pushed_at":"2018-09-21T07:21:20Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"https://symfony.com","size":124698,"stargazers_count":18612,"watchers_count":18612,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":6399,"mirror_url":null,"archived":false,"open_issues_count":911,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6399,"open_issues":911,"watchers":18612,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/27996"},"html":{"href":"https://github.com/symfony/symfony/pull/27996"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/27996"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/27996/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/27996/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/27996/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/b77c1ae76d55925649fdea53aac2c3ca4b0a5042"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":2,"review_comments":1,"maintainer_can_modify":false,"commits":1,"additions":25,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"lsv"}}