{"action":"created","comment":{"url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/comments/232948280","pull_request_review_id":174194583,"id":232948280,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjk0ODI4MA==","diff_hunk":"@@ -0,0 +1,39 @@\n+import * as React from 'react';\n+import { t } from 'i18next';\n+import { getLoadoutClassDisplay } from './loadout.service';\n+import './loadout-edit-popup.scss';\n+\n+interface Props {\n+  loadoutClassType: number;\n+  loadoutName: string;\n+  changeNameHandler(): void;\n+  editHandler(): void;\n+}\n+\n+const getAlreadyExistsTranslation = (loadoutClassType: number) => {","path":"src/app/loadout/LoadoutEditPopup.tsx","position":13,"original_position":13,"commit_id":"f847f8baf48bff6b8b31f770917a5525b11808ac","original_commit_id":"f847f8baf48bff6b8b31f770917a5525b11808ac","user":{"login":"bhollis","id":313208,"node_id":"MDQ6VXNlcjMxMzIwOA==","avatar_url":"https://avatars0.githubusercontent.com/u/313208?v=4","gravatar_id":"","url":"https://api.github.com/users/bhollis","html_url":"https://github.com/bhollis","followers_url":"https://api.github.com/users/bhollis/followers","following_url":"https://api.github.com/users/bhollis/following{/other_user}","gists_url":"https://api.github.com/users/bhollis/gists{/gist_id}","starred_url":"https://api.github.com/users/bhollis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhollis/subscriptions","organizations_url":"https://api.github.com/users/bhollis/orgs","repos_url":"https://api.github.com/users/bhollis/repos","events_url":"https://api.github.com/users/bhollis/events{/privacy}","received_events_url":"https://api.github.com/users/bhollis/received_events","type":"User","site_admin":false},"body":"In the DIM codebase we generally prefer a function to an arrow declaration, so like:\r\n\r\n```\r\nfunction getAlreadyExistsTranslation(loadoutClassType: number) {\r\n   ...\r\n}\r\n```","created_at":"2018-11-13T09:07:06Z","updated_at":"2018-11-13T09:16:43Z","html_url":"https://github.com/DestinyItemManager/DIM/pull/3298#discussion_r232948280","pull_request_url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/3298","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/comments/232948280"},"html":{"href":"https://github.com/DestinyItemManager/DIM/pull/3298#discussion_r232948280"},"pull_request":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/3298"}}},"pull_request":{"url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/3298","id":229886116,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5ODg2MTE2","html_url":"https://github.com/DestinyItemManager/DIM/pull/3298","diff_url":"https://github.com/DestinyItemManager/DIM/pull/3298.diff","patch_url":"https://github.com/DestinyItemManager/DIM/pull/3298.patch","issue_url":"https://api.github.com/repos/DestinyItemManager/DIM/issues/3298","number":3298,"state":"open","locked":false,"title":"prevent-duplicate-loadout-names","user":{"login":"rushton3179","id":7344652,"node_id":"MDQ6VXNlcjczNDQ2NTI=","avatar_url":"https://avatars0.githubusercontent.com/u/7344652?v=4","gravatar_id":"","url":"https://api.github.com/users/rushton3179","html_url":"https://github.com/rushton3179","followers_url":"https://api.github.com/users/rushton3179/followers","following_url":"https://api.github.com/users/rushton3179/following{/other_user}","gists_url":"https://api.github.com/users/rushton3179/gists{/gist_id}","starred_url":"https://api.github.com/users/rushton3179/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rushton3179/subscriptions","organizations_url":"https://api.github.com/users/rushton3179/orgs","repos_url":"https://api.github.com/users/rushton3179/repos","events_url":"https://api.github.com/users/rushton3179/events{/privacy}","received_events_url":"https://api.github.com/users/rushton3179/received_events","type":"User","site_admin":false},"body":"Added functionality to stop clashing class specific loadout names.\r\nRefactored a little render functionality in  LoadoutDrawer.","created_at":"2018-11-10T12:03:20Z","updated_at":"2018-11-13T09:16:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a9d9b34b8471e92fc39a9860be3a6b052fbf67f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":638761721,"node_id":"MDU6TGFiZWw2Mzg3NjE3MjE=","url":"https://api.github.com/repos/DestinyItemManager/DIM/labels/Feature:%20Loadouts","name":"Feature: Loadouts","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/3298/commits","review_comments_url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/3298/comments","review_comment_url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DestinyItemManager/DIM/issues/3298/comments","statuses_url":"https://api.github.com/repos/DestinyItemManager/DIM/statuses/f847f8baf48bff6b8b31f770917a5525b11808ac","head":{"label":"rushton3179:feature/prevent-duplicate-loadout-names","ref":"feature/prevent-duplicate-loadout-names","sha":"f847f8baf48bff6b8b31f770917a5525b11808ac","user":{"login":"rushton3179","id":7344652,"node_id":"MDQ6VXNlcjczNDQ2NTI=","avatar_url":"https://avatars0.githubusercontent.com/u/7344652?v=4","gravatar_id":"","url":"https://api.github.com/users/rushton3179","html_url":"https://github.com/rushton3179","followers_url":"https://api.github.com/users/rushton3179/followers","following_url":"https://api.github.com/users/rushton3179/following{/other_user}","gists_url":"https://api.github.com/users/rushton3179/gists{/gist_id}","starred_url":"https://api.github.com/users/rushton3179/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rushton3179/subscriptions","organizations_url":"https://api.github.com/users/rushton3179/orgs","repos_url":"https://api.github.com/users/rushton3179/repos","events_url":"https://api.github.com/users/rushton3179/events{/privacy}","received_events_url":"https://api.github.com/users/rushton3179/received_events","type":"User","site_admin":false},"repo":{"id":132696414,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI2OTY0MTQ=","name":"DIM","full_name":"rushton3179/DIM","private":false,"owner":{"login":"rushton3179","id":7344652,"node_id":"MDQ6VXNlcjczNDQ2NTI=","avatar_url":"https://avatars0.githubusercontent.com/u/7344652?v=4","gravatar_id":"","url":"https://api.github.com/users/rushton3179","html_url":"https://github.com/rushton3179","followers_url":"https://api.github.com/users/rushton3179/followers","following_url":"https://api.github.com/users/rushton3179/following{/other_user}","gists_url":"https://api.github.com/users/rushton3179/gists{/gist_id}","starred_url":"https://api.github.com/users/rushton3179/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rushton3179/subscriptions","organizations_url":"https://api.github.com/users/rushton3179/orgs","repos_url":"https://api.github.com/users/rushton3179/repos","events_url":"https://api.github.com/users/rushton3179/events{/privacy}","received_events_url":"https://api.github.com/users/rushton3179/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rushton3179/DIM","description":"Destiny Item Manager","fork":true,"url":"https://api.github.com/repos/rushton3179/DIM","forks_url":"https://api.github.com/repos/rushton3179/DIM/forks","keys_url":"https://api.github.com/repos/rushton3179/DIM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rushton3179/DIM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rushton3179/DIM/teams","hooks_url":"https://api.github.com/repos/rushton3179/DIM/hooks","issue_events_url":"https://api.github.com/repos/rushton3179/DIM/issues/events{/number}","events_url":"https://api.github.com/repos/rushton3179/DIM/events","assignees_url":"https://api.github.com/repos/rushton3179/DIM/assignees{/user}","branches_url":"https://api.github.com/repos/rushton3179/DIM/branches{/branch}","tags_url":"https://api.github.com/repos/rushton3179/DIM/tags","blobs_url":"https://api.github.com/repos/rushton3179/DIM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rushton3179/DIM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rushton3179/DIM/git/refs{/sha}","trees_url":"https://api.github.com/repos/rushton3179/DIM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rushton3179/DIM/statuses/{sha}","languages_url":"https://api.github.com/repos/rushton3179/DIM/languages","stargazers_url":"https://api.github.com/repos/rushton3179/DIM/stargazers","contributors_url":"https://api.github.com/repos/rushton3179/DIM/contributors","subscribers_url":"https://api.github.com/repos/rushton3179/DIM/subscribers","subscription_url":"https://api.github.com/repos/rushton3179/DIM/subscription","commits_url":"https://api.github.com/repos/rushton3179/DIM/commits{/sha}","git_commits_url":"https://api.github.com/repos/rushton3179/DIM/git/commits{/sha}","comments_url":"https://api.github.com/repos/rushton3179/DIM/comments{/number}","issue_comment_url":"https://api.github.com/repos/rushton3179/DIM/issues/comments{/number}","contents_url":"https://api.github.com/repos/rushton3179/DIM/contents/{+path}","compare_url":"https://api.github.com/repos/rushton3179/DIM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rushton3179/DIM/merges","archive_url":"https://api.github.com/repos/rushton3179/DIM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rushton3179/DIM/downloads","issues_url":"https://api.github.com/repos/rushton3179/DIM/issues{/number}","pulls_url":"https://api.github.com/repos/rushton3179/DIM/pulls{/number}","milestones_url":"https://api.github.com/repos/rushton3179/DIM/milestones{/number}","notifications_url":"https://api.github.com/repos/rushton3179/DIM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rushton3179/DIM/labels{/name}","releases_url":"https://api.github.com/repos/rushton3179/DIM/releases{/id}","deployments_url":"https://api.github.com/repos/rushton3179/DIM/deployments","created_at":"2018-05-09T03:24:14Z","updated_at":"2018-11-13T08:15:00Z","pushed_at":"2018-11-13T08:38:23Z","git_url":"git://github.com/rushton3179/DIM.git","ssh_url":"git@github.com:rushton3179/DIM.git","clone_url":"https://github.com/rushton3179/DIM.git","svn_url":"https://github.com/rushton3179/DIM","homepage":"https://destinyitemmanager.com","size":271654,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DestinyItemManager:master","ref":"master","sha":"6e55b323ec69d73f61ed8e7a2dcad864ff3bb0c2","user":{"login":"DestinyItemManager","id":12777189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzc3MTg5","avatar_url":"https://avatars3.githubusercontent.com/u/12777189?v=4","gravatar_id":"","url":"https://api.github.com/users/DestinyItemManager","html_url":"https://github.com/DestinyItemManager","followers_url":"https://api.github.com/users/DestinyItemManager/followers","following_url":"https://api.github.com/users/DestinyItemManager/following{/other_user}","gists_url":"https://api.github.com/users/DestinyItemManager/gists{/gist_id}","starred_url":"https://api.github.com/users/DestinyItemManager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DestinyItemManager/subscriptions","organizations_url":"https://api.github.com/users/DestinyItemManager/orgs","repos_url":"https://api.github.com/users/DestinyItemManager/repos","events_url":"https://api.github.com/users/DestinyItemManager/events{/privacy}","received_events_url":"https://api.github.com/users/DestinyItemManager/received_events","type":"Organization","site_admin":false},"repo":{"id":31681575,"node_id":"MDEwOlJlcG9zaXRvcnkzMTY4MTU3NQ==","name":"DIM","full_name":"DestinyItemManager/DIM","private":false,"owner":{"login":"DestinyItemManager","id":12777189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzc3MTg5","avatar_url":"https://avatars3.githubusercontent.com/u/12777189?v=4","gravatar_id":"","url":"https://api.github.com/users/DestinyItemManager","html_url":"https://github.com/DestinyItemManager","followers_url":"https://api.github.com/users/DestinyItemManager/followers","following_url":"https://api.github.com/users/DestinyItemManager/following{/other_user}","gists_url":"https://api.github.com/users/DestinyItemManager/gists{/gist_id}","starred_url":"https://api.github.com/users/DestinyItemManager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DestinyItemManager/subscriptions","organizations_url":"https://api.github.com/users/DestinyItemManager/orgs","repos_url":"https://api.github.com/users/DestinyItemManager/repos","events_url":"https://api.github.com/users/DestinyItemManager/events{/privacy}","received_events_url":"https://api.github.com/users/DestinyItemManager/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DestinyItemManager/DIM","description":"Destiny Item Manager","fork":false,"url":"https://api.github.com/repos/DestinyItemManager/DIM","forks_url":"https://api.github.com/repos/DestinyItemManager/DIM/forks","keys_url":"https://api.github.com/repos/DestinyItemManager/DIM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DestinyItemManager/DIM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DestinyItemManager/DIM/teams","hooks_url":"https://api.github.com/repos/DestinyItemManager/DIM/hooks","issue_events_url":"https://api.github.com/repos/DestinyItemManager/DIM/issues/events{/number}","events_url":"https://api.github.com/repos/DestinyItemManager/DIM/events","assignees_url":"https://api.github.com/repos/DestinyItemManager/DIM/assignees{/user}","branches_url":"https://api.github.com/repos/DestinyItemManager/DIM/branches{/branch}","tags_url":"https://api.github.com/repos/DestinyItemManager/DIM/tags","blobs_url":"https://api.github.com/repos/DestinyItemManager/DIM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DestinyItemManager/DIM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DestinyItemManager/DIM/git/refs{/sha}","trees_url":"https://api.github.com/repos/DestinyItemManager/DIM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DestinyItemManager/DIM/statuses/{sha}","languages_url":"https://api.github.com/repos/DestinyItemManager/DIM/languages","stargazers_url":"https://api.github.com/repos/DestinyItemManager/DIM/stargazers","contributors_url":"https://api.github.com/repos/DestinyItemManager/DIM/contributors","subscribers_url":"https://api.github.com/repos/DestinyItemManager/DIM/subscribers","subscription_url":"https://api.github.com/repos/DestinyItemManager/DIM/subscription","commits_url":"https://api.github.com/repos/DestinyItemManager/DIM/commits{/sha}","git_commits_url":"https://api.github.com/repos/DestinyItemManager/DIM/git/commits{/sha}","comments_url":"https://api.github.com/repos/DestinyItemManager/DIM/comments{/number}","issue_comment_url":"https://api.github.com/repos/DestinyItemManager/DIM/issues/comments{/number}","contents_url":"https://api.github.com/repos/DestinyItemManager/DIM/contents/{+path}","compare_url":"https://api.github.com/repos/DestinyItemManager/DIM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DestinyItemManager/DIM/merges","archive_url":"https://api.github.com/repos/DestinyItemManager/DIM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DestinyItemManager/DIM/downloads","issues_url":"https://api.github.com/repos/DestinyItemManager/DIM/issues{/number}","pulls_url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls{/number}","milestones_url":"https://api.github.com/repos/DestinyItemManager/DIM/milestones{/number}","notifications_url":"https://api.github.com/repos/DestinyItemManager/DIM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DestinyItemManager/DIM/labels{/name}","releases_url":"https://api.github.com/repos/DestinyItemManager/DIM/releases{/id}","deployments_url":"https://api.github.com/repos/DestinyItemManager/DIM/deployments","created_at":"2015-03-04T21:46:50Z","updated_at":"2018-11-13T08:59:30Z","pushed_at":"2018-11-13T08:59:27Z","git_url":"git://github.com/DestinyItemManager/DIM.git","ssh_url":"git@github.com:DestinyItemManager/DIM.git","clone_url":"https://github.com/DestinyItemManager/DIM.git","svn_url":"https://github.com/DestinyItemManager/DIM","homepage":"https://destinyitemmanager.com","size":271857,"stargazers_count":765,"watchers_count":765,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":270,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":270,"open_issues":55,"watchers":765,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/3298"},"html":{"href":"https://github.com/DestinyItemManager/DIM/pull/3298"},"issue":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/issues/3298"},"comments":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/issues/3298/comments"},"review_comments":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/3298/comments"},"review_comment":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/3298/commits"},"statuses":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/statuses/f847f8baf48bff6b8b31f770917a5525b11808ac"}},"author_association":"NONE"}}
{"actor":{"display_login":"bhollis"}}