{"action":"created","issue":{"url":"https://api.github.com/repos/ethers-io/ethers.js/issues/310","repository_url":"https://api.github.com/repos/ethers-io/ethers.js","labels_url":"https://api.github.com/repos/ethers-io/ethers.js/issues/310/labels{/name}","comments_url":"https://api.github.com/repos/ethers-io/ethers.js/issues/310/comments","events_url":"https://api.github.com/repos/ethers-io/ethers.js/issues/310/events","html_url":"https://github.com/ethers-io/ethers.js/issues/310","id":370523110,"node_id":"MDU6SXNzdWUzNzA1MjMxMTA=","number":310,"title":"Error while validating the address: network does support ENS","user":{"login":"LogvinovLeon","id":6204356,"node_id":"MDQ6VXNlcjYyMDQzNTY=","avatar_url":"https://avatars1.githubusercontent.com/u/6204356?v=4","gravatar_id":"","url":"https://api.github.com/users/LogvinovLeon","html_url":"https://github.com/LogvinovLeon","followers_url":"https://api.github.com/users/LogvinovLeon/followers","following_url":"https://api.github.com/users/LogvinovLeon/following{/other_user}","gists_url":"https://api.github.com/users/LogvinovLeon/gists{/gist_id}","starred_url":"https://api.github.com/users/LogvinovLeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LogvinovLeon/subscriptions","organizations_url":"https://api.github.com/users/LogvinovLeon/orgs","repos_url":"https://api.github.com/users/LogvinovLeon/repos","events_url":"https://api.github.com/users/LogvinovLeon/events{/privacy}","received_events_url":"https://api.github.com/users/LogvinovLeon/received_events","type":"User","site_admin":false},"labels":[{"id":409075434,"node_id":"MDU6TGFiZWw0MDkwNzU0MzQ=","url":"https://api.github.com/repos/ethers-io/ethers.js/labels/discussion","name":"discussion","color":"c5def5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-16T09:36:12Z","updated_at":"2018-10-16T16:51:45Z","closed_at":null,"author_association":"NONE","body":"Playing around with ethers.js and testing it's input validation.\r\nStarted with the `this._ethersProvider.getBalance(owner)` function.\r\nTried to pass an incorrect ethereum address (`0xdeadbeef`) and got the `network does support ENS` error.\r\nWhile this is technically correct (I'm using ganache and it doesn't support ENS) it's not a very useful error message. Maybe we should first check if the address even \"looks like\" an ENS name before trying to resolve it? I understand that there might be some overlap between invalid ETH addresses and invalid ENS names, but if I remember it right - ENS should at least have a dot in it."},"comment":{"url":"https://api.github.com/repos/ethers-io/ethers.js/issues/comments/430312830","html_url":"https://github.com/ethers-io/ethers.js/issues/310#issuecomment-430312830","issue_url":"https://api.github.com/repos/ethers-io/ethers.js/issues/310","id":430312830,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDMxMjgzMA==","user":{"login":"ricmoo","id":975687,"node_id":"MDQ6VXNlcjk3NTY4Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/975687?v=4","gravatar_id":"","url":"https://api.github.com/users/ricmoo","html_url":"https://github.com/ricmoo","followers_url":"https://api.github.com/users/ricmoo/followers","following_url":"https://api.github.com/users/ricmoo/following{/other_user}","gists_url":"https://api.github.com/users/ricmoo/gists{/gist_id}","starred_url":"https://api.github.com/users/ricmoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricmoo/subscriptions","organizations_url":"https://api.github.com/users/ricmoo/orgs","repos_url":"https://api.github.com/users/ricmoo/repos","events_url":"https://api.github.com/users/ricmoo/events{/privacy}","received_events_url":"https://api.github.com/users/ricmoo/received_events","type":"User","site_admin":false},"created_at":"2018-10-16T16:51:45Z","updated_at":"2018-10-16T16:51:45Z","author_association":"MEMBER","body":"It doesn’t say `eth` is not a valid name on that link. It says mainnet has two top-level domains, but that doesn’t preclude others. `eth` must be a valid ENS name, because that is how the `owner` call determines the address of the hash registrar, to register .eth against the registry, which it can do because it is the owner. :)\r\n\r\nAlso, I personally deploy ENS to my desktop, I deployed `eth` as a root registrar, but nothing is stopping me from registering everything at the top-level in my test environment.\r\n\r\nPerhaps it would make sense to include an ensRegex on each network, for what domains are available.\r\n\r\nOverall though, this doesn’t seem like an out-of-place error. Would you be happier if the human text said: “network does not support ENS or invalid address”?"}}
{"actor":{"display_login":"ricmoo"}}