{"action":"created","comment":{"url":"https://api.github.com/repos/kyuupichan/electrumx/pulls/comments/191289387","pull_request_review_id":123830039,"id":191289387,"diff_hunk":"@@ -552,10 +553,16 @@ def notify(self, height, touched):\n         '''Notify the client about changes in masternode list.'''\n         result = super().notify(height, touched)\n \n-        for masternode in self.mns:\n-            status = self.daemon.masternode_list(['status', masternode])\n-            self.send_notification('masternode.subscribe',\n-                                   [masternode, status.get(masternode)])\n+        try:\n+            for masternode in self.mns:\n+                status = self.daemon.masternode_list(['status', masternode])\n+                if hasattr(status, 'get'):\n+                    self.send_notification('masternode.subscribe',\n+                                           [masternode, status.get(masternode)])\n+        except DaemonError as e:\n+            error, = e.args\n+            message = error['message']\n+            self.logger.info('there was an error when notifying the masternode status: {}'.format(message))","path":"server/session.py","position":34,"original_position":34,"commit_id":"e7e35f4142ce69e9004b8db2792c20ab91ec7c98","original_commit_id":"e7e35f4142ce69e9004b8db2792c20ab91ec7c98","user":{"login":"kyuupichan","id":3319176,"avatar_url":"https://avatars1.githubusercontent.com/u/3319176?v=4","gravatar_id":"","url":"https://api.github.com/users/kyuupichan","html_url":"https://github.com/kyuupichan","followers_url":"https://api.github.com/users/kyuupichan/followers","following_url":"https://api.github.com/users/kyuupichan/following{/other_user}","gists_url":"https://api.github.com/users/kyuupichan/gists{/gist_id}","starred_url":"https://api.github.com/users/kyuupichan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyuupichan/subscriptions","organizations_url":"https://api.github.com/users/kyuupichan/orgs","repos_url":"https://api.github.com/users/kyuupichan/repos","events_url":"https://api.github.com/users/kyuupichan/events{/privacy}","received_events_url":"https://api.github.com/users/kyuupichan/received_events","type":"User","site_admin":false},"body":"You're right, it's not a workaround at all.  You will get that every time.  The clue is in the error message - it's a coroutine because you missed the \"await\".","created_at":"2018-05-29T01:54:02Z","updated_at":"2018-05-29T01:54:46Z","html_url":"https://github.com/kyuupichan/electrumx/pull/474#discussion_r191289387","pull_request_url":"https://api.github.com/repos/kyuupichan/electrumx/pulls/474","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/kyuupichan/electrumx/pulls/comments/191289387"},"html":{"href":"https://github.com/kyuupichan/electrumx/pull/474#discussion_r191289387"},"pull_request":{"href":"https://api.github.com/repos/kyuupichan/electrumx/pulls/474"}},"in_reply_to_id":191260926},"pull_request":{"url":"https://api.github.com/repos/kyuupichan/electrumx/pulls/474","id":190120924,"html_url":"https://github.com/kyuupichan/electrumx/pull/474","diff_url":"https://github.com/kyuupichan/electrumx/pull/474.diff","patch_url":"https://github.com/kyuupichan/electrumx/pull/474.patch","issue_url":"https://api.github.com/repos/kyuupichan/electrumx/issues/474","number":474,"state":"open","locked":false,"title":"Add $PAC","user":{"login":"elmora-do","id":2745076,"avatar_url":"https://avatars3.githubusercontent.com/u/2745076?v=4","gravatar_id":"","url":"https://api.github.com/users/elmora-do","html_url":"https://github.com/elmora-do","followers_url":"https://api.github.com/users/elmora-do/followers","following_url":"https://api.github.com/users/elmora-do/following{/other_user}","gists_url":"https://api.github.com/users/elmora-do/gists{/gist_id}","starred_url":"https://api.github.com/users/elmora-do/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elmora-do/subscriptions","organizations_url":"https://api.github.com/users/elmora-do/orgs","repos_url":"https://api.github.com/users/elmora-do/repos","events_url":"https://api.github.com/users/elmora-do/events{/privacy}","received_events_url":"https://api.github.com/users/elmora-do/received_events","type":"User","site_admin":false},"body":"- $PAC support added.\r\n- $PAC masternode tracking feature added.\r\n- $PAC blocks for tests added.","created_at":"2018-05-23T22:18:29Z","updated_at":"2018-05-29T01:54:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eec1ac9c8fa047af3ac9c837efa9da86d63a0dab","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kyuupichan/electrumx/pulls/474/commits","review_comments_url":"https://api.github.com/repos/kyuupichan/electrumx/pulls/474/comments","review_comment_url":"https://api.github.com/repos/kyuupichan/electrumx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kyuupichan/electrumx/issues/474/comments","statuses_url":"https://api.github.com/repos/kyuupichan/electrumx/statuses/e7e35f4142ce69e9004b8db2792c20ab91ec7c98","head":{"label":"PACCommunity:master","ref":"master","sha":"e7e35f4142ce69e9004b8db2792c20ab91ec7c98","user":{"login":"PACCommunity","id":35778524,"avatar_url":"https://avatars3.githubusercontent.com/u/35778524?v=4","gravatar_id":"","url":"https://api.github.com/users/PACCommunity","html_url":"https://github.com/PACCommunity","followers_url":"https://api.github.com/users/PACCommunity/followers","following_url":"https://api.github.com/users/PACCommunity/following{/other_user}","gists_url":"https://api.github.com/users/PACCommunity/gists{/gist_id}","starred_url":"https://api.github.com/users/PACCommunity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PACCommunity/subscriptions","organizations_url":"https://api.github.com/users/PACCommunity/orgs","repos_url":"https://api.github.com/users/PACCommunity/repos","events_url":"https://api.github.com/users/PACCommunity/events{/privacy}","received_events_url":"https://api.github.com/users/PACCommunity/received_events","type":"Organization","site_admin":false},"repo":{"id":134628081,"name":"electrumx","full_name":"PACCommunity/electrumx","owner":{"login":"PACCommunity","id":35778524,"avatar_url":"https://avatars3.githubusercontent.com/u/35778524?v=4","gravatar_id":"","url":"https://api.github.com/users/PACCommunity","html_url":"https://github.com/PACCommunity","followers_url":"https://api.github.com/users/PACCommunity/followers","following_url":"https://api.github.com/users/PACCommunity/following{/other_user}","gists_url":"https://api.github.com/users/PACCommunity/gists{/gist_id}","starred_url":"https://api.github.com/users/PACCommunity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PACCommunity/subscriptions","organizations_url":"https://api.github.com/users/PACCommunity/orgs","repos_url":"https://api.github.com/users/PACCommunity/repos","events_url":"https://api.github.com/users/PACCommunity/events{/privacy}","received_events_url":"https://api.github.com/users/PACCommunity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PACCommunity/electrumx","description":"Alternative implementation of spesmilo/electrum-server","fork":true,"url":"https://api.github.com/repos/PACCommunity/electrumx","forks_url":"https://api.github.com/repos/PACCommunity/electrumx/forks","keys_url":"https://api.github.com/repos/PACCommunity/electrumx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PACCommunity/electrumx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PACCommunity/electrumx/teams","hooks_url":"https://api.github.com/repos/PACCommunity/electrumx/hooks","issue_events_url":"https://api.github.com/repos/PACCommunity/electrumx/issues/events{/number}","events_url":"https://api.github.com/repos/PACCommunity/electrumx/events","assignees_url":"https://api.github.com/repos/PACCommunity/electrumx/assignees{/user}","branches_url":"https://api.github.com/repos/PACCommunity/electrumx/branches{/branch}","tags_url":"https://api.github.com/repos/PACCommunity/electrumx/tags","blobs_url":"https://api.github.com/repos/PACCommunity/electrumx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PACCommunity/electrumx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PACCommunity/electrumx/git/refs{/sha}","trees_url":"https://api.github.com/repos/PACCommunity/electrumx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PACCommunity/electrumx/statuses/{sha}","languages_url":"https://api.github.com/repos/PACCommunity/electrumx/languages","stargazers_url":"https://api.github.com/repos/PACCommunity/electrumx/stargazers","contributors_url":"https://api.github.com/repos/PACCommunity/electrumx/contributors","subscribers_url":"https://api.github.com/repos/PACCommunity/electrumx/subscribers","subscription_url":"https://api.github.com/repos/PACCommunity/electrumx/subscription","commits_url":"https://api.github.com/repos/PACCommunity/electrumx/commits{/sha}","git_commits_url":"https://api.github.com/repos/PACCommunity/electrumx/git/commits{/sha}","comments_url":"https://api.github.com/repos/PACCommunity/electrumx/comments{/number}","issue_comment_url":"https://api.github.com/repos/PACCommunity/electrumx/issues/comments{/number}","contents_url":"https://api.github.com/repos/PACCommunity/electrumx/contents/{+path}","compare_url":"https://api.github.com/repos/PACCommunity/electrumx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PACCommunity/electrumx/merges","archive_url":"https://api.github.com/repos/PACCommunity/electrumx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PACCommunity/electrumx/downloads","issues_url":"https://api.github.com/repos/PACCommunity/electrumx/issues{/number}","pulls_url":"https://api.github.com/repos/PACCommunity/electrumx/pulls{/number}","milestones_url":"https://api.github.com/repos/PACCommunity/electrumx/milestones{/number}","notifications_url":"https://api.github.com/repos/PACCommunity/electrumx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PACCommunity/electrumx/labels{/name}","releases_url":"https://api.github.com/repos/PACCommunity/electrumx/releases{/id}","deployments_url":"https://api.github.com/repos/PACCommunity/electrumx/deployments","created_at":"2018-05-23T21:36:50Z","updated_at":"2018-05-28T19:09:40Z","pushed_at":"2018-05-28T19:09:38Z","git_url":"git://github.com/PACCommunity/electrumx.git","ssh_url":"git@github.com:PACCommunity/electrumx.git","clone_url":"https://github.com/PACCommunity/electrumx.git","svn_url":"https://github.com/PACCommunity/electrumx","homepage":null,"size":1802,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kyuupichan:master","ref":"master","sha":"379fef17dee414d4f8069ef1d5af1b428501ebae","user":{"login":"kyuupichan","id":3319176,"avatar_url":"https://avatars1.githubusercontent.com/u/3319176?v=4","gravatar_id":"","url":"https://api.github.com/users/kyuupichan","html_url":"https://github.com/kyuupichan","followers_url":"https://api.github.com/users/kyuupichan/followers","following_url":"https://api.github.com/users/kyuupichan/following{/other_user}","gists_url":"https://api.github.com/users/kyuupichan/gists{/gist_id}","starred_url":"https://api.github.com/users/kyuupichan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyuupichan/subscriptions","organizations_url":"https://api.github.com/users/kyuupichan/orgs","repos_url":"https://api.github.com/users/kyuupichan/repos","events_url":"https://api.github.com/users/kyuupichan/events{/privacy}","received_events_url":"https://api.github.com/users/kyuupichan/received_events","type":"User","site_admin":false},"repo":{"id":70314805,"name":"electrumx","full_name":"kyuupichan/electrumx","owner":{"login":"kyuupichan","id":3319176,"avatar_url":"https://avatars1.githubusercontent.com/u/3319176?v=4","gravatar_id":"","url":"https://api.github.com/users/kyuupichan","html_url":"https://github.com/kyuupichan","followers_url":"https://api.github.com/users/kyuupichan/followers","following_url":"https://api.github.com/users/kyuupichan/following{/other_user}","gists_url":"https://api.github.com/users/kyuupichan/gists{/gist_id}","starred_url":"https://api.github.com/users/kyuupichan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyuupichan/subscriptions","organizations_url":"https://api.github.com/users/kyuupichan/orgs","repos_url":"https://api.github.com/users/kyuupichan/repos","events_url":"https://api.github.com/users/kyuupichan/events{/privacy}","received_events_url":"https://api.github.com/users/kyuupichan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kyuupichan/electrumx","description":"Alternative implementation of spesmilo/electrum-server","fork":false,"url":"https://api.github.com/repos/kyuupichan/electrumx","forks_url":"https://api.github.com/repos/kyuupichan/electrumx/forks","keys_url":"https://api.github.com/repos/kyuupichan/electrumx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kyuupichan/electrumx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kyuupichan/electrumx/teams","hooks_url":"https://api.github.com/repos/kyuupichan/electrumx/hooks","issue_events_url":"https://api.github.com/repos/kyuupichan/electrumx/issues/events{/number}","events_url":"https://api.github.com/repos/kyuupichan/electrumx/events","assignees_url":"https://api.github.com/repos/kyuupichan/electrumx/assignees{/user}","branches_url":"https://api.github.com/repos/kyuupichan/electrumx/branches{/branch}","tags_url":"https://api.github.com/repos/kyuupichan/electrumx/tags","blobs_url":"https://api.github.com/repos/kyuupichan/electrumx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kyuupichan/electrumx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kyuupichan/electrumx/git/refs{/sha}","trees_url":"https://api.github.com/repos/kyuupichan/electrumx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kyuupichan/electrumx/statuses/{sha}","languages_url":"https://api.github.com/repos/kyuupichan/electrumx/languages","stargazers_url":"https://api.github.com/repos/kyuupichan/electrumx/stargazers","contributors_url":"https://api.github.com/repos/kyuupichan/electrumx/contributors","subscribers_url":"https://api.github.com/repos/kyuupichan/electrumx/subscribers","subscription_url":"https://api.github.com/repos/kyuupichan/electrumx/subscription","commits_url":"https://api.github.com/repos/kyuupichan/electrumx/commits{/sha}","git_commits_url":"https://api.github.com/repos/kyuupichan/electrumx/git/commits{/sha}","comments_url":"https://api.github.com/repos/kyuupichan/electrumx/comments{/number}","issue_comment_url":"https://api.github.com/repos/kyuupichan/electrumx/issues/comments{/number}","contents_url":"https://api.github.com/repos/kyuupichan/electrumx/contents/{+path}","compare_url":"https://api.github.com/repos/kyuupichan/electrumx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kyuupichan/electrumx/merges","archive_url":"https://api.github.com/repos/kyuupichan/electrumx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kyuupichan/electrumx/downloads","issues_url":"https://api.github.com/repos/kyuupichan/electrumx/issues{/number}","pulls_url":"https://api.github.com/repos/kyuupichan/electrumx/pulls{/number}","milestones_url":"https://api.github.com/repos/kyuupichan/electrumx/milestones{/number}","notifications_url":"https://api.github.com/repos/kyuupichan/electrumx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kyuupichan/electrumx/labels{/name}","releases_url":"https://api.github.com/repos/kyuupichan/electrumx/releases{/id}","deployments_url":"https://api.github.com/repos/kyuupichan/electrumx/deployments","created_at":"2016-10-08T08:00:49Z","updated_at":"2018-05-28T20:55:43Z","pushed_at":"2018-05-28T19:09:39Z","git_url":"git://github.com/kyuupichan/electrumx.git","ssh_url":"git@github.com:kyuupichan/electrumx.git","clone_url":"https://github.com/kyuupichan/electrumx.git","svn_url":"https://github.com/kyuupichan/electrumx","homepage":null,"size":1828,"stargazers_count":321,"watchers_count":321,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":328,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":328,"open_issues":19,"watchers":321,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kyuupichan/electrumx/pulls/474"},"html":{"href":"https://github.com/kyuupichan/electrumx/pull/474"},"issue":{"href":"https://api.github.com/repos/kyuupichan/electrumx/issues/474"},"comments":{"href":"https://api.github.com/repos/kyuupichan/electrumx/issues/474/comments"},"review_comments":{"href":"https://api.github.com/repos/kyuupichan/electrumx/pulls/474/comments"},"review_comment":{"href":"https://api.github.com/repos/kyuupichan/electrumx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kyuupichan/electrumx/pulls/474/commits"},"statuses":{"href":"https://api.github.com/repos/kyuupichan/electrumx/statuses/e7e35f4142ce69e9004b8db2792c20ab91ec7c98"}},"author_association":"NONE"}}
{"actor":{"display_login":"kyuupichan"}}