{"action":"created","issue":{"url":"https://api.github.com/repos/bjorn/tiled/issues/1978","repository_url":"https://api.github.com/repos/bjorn/tiled","labels_url":"https://api.github.com/repos/bjorn/tiled/issues/1978/labels{/name}","comments_url":"https://api.github.com/repos/bjorn/tiled/issues/1978/comments","events_url":"https://api.github.com/repos/bjorn/tiled/issues/1978/events","html_url":"https://github.com/bjorn/tiled/issues/1978","id":342002579,"node_id":"MDU6SXNzdWUzNDIwMDI1Nzk=","number":1978,"title":"Shortcuts no longer visible in context menus since Qt 5.10","user":{"login":"bjorn","id":531764,"node_id":"MDQ6VXNlcjUzMTc2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/531764?v=4","gravatar_id":"","url":"https://api.github.com/users/bjorn","html_url":"https://github.com/bjorn","followers_url":"https://api.github.com/users/bjorn/followers","following_url":"https://api.github.com/users/bjorn/following{/other_user}","gists_url":"https://api.github.com/users/bjorn/gists{/gist_id}","starred_url":"https://api.github.com/users/bjorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjorn/subscriptions","organizations_url":"https://api.github.com/users/bjorn/orgs","repos_url":"https://api.github.com/users/bjorn/repos","events_url":"https://api.github.com/users/bjorn/events{/privacy}","received_events_url":"https://api.github.com/users/bjorn/received_events","type":"User","site_admin":false},"labels":[{"id":91395,"node_id":"MDU6TGFiZWw5MTM5NQ==","url":"https://api.github.com/repos/bjorn/tiled/labels/bug","name":"bug","color":"9b3324","default":true},{"id":262753355,"node_id":"MDU6TGFiZWwyNjI3NTMzNTU=","url":"https://api.github.com/repos/bjorn/tiled/labels/qt%20issue","name":"qt issue","color":"bfe5bf","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-07-17T16:54:28Z","updated_at":"2018-12-27T08:20:12Z","closed_at":null,"author_association":"OWNER","body":"In Qt 5.10, shortcuts are no longer shown by default in context menus. However, I'd generally prefer them to be there to make them discoverable. Several actions that are only available from context menus have shortcuts that are now completely hidden.\r\n\r\nIt seems the only way to fix this is to manually specify that the shortcut should be visible for each affected action. Setting `setAttribute(Qt::AA_DontShowShortcutsInContextMenus, false)` has no effect, since `QAction` is doing:\r\n\r\n```c++\r\nbool QAction::isShortcutVisibleInContextMenu() const\r\n{\r\n    Q_D(const QAction);\r\n    if (d->shortcutVisibleInContextMenu == -1) {\r\n        return !QCoreApplication::testAttribute(Qt::AA_DontShowShortcutsInContextMenus)\r\n            && QGuiApplication::styleHints()->showShortcutsInContextMenus();\r\n    }\r\n    return d->shortcutVisibleInContextMenu;\r\n}\r\n```\r\nAnd the style hints say they should not be visible."},"comment":{"url":"https://api.github.com/repos/bjorn/tiled/issues/comments/450101575","html_url":"https://github.com/bjorn/tiled/issues/1978#issuecomment-450101575","issue_url":"https://api.github.com/repos/bjorn/tiled/issues/1978","id":450101575,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDEwMTU3NQ==","user":{"login":"bjorn","id":531764,"node_id":"MDQ6VXNlcjUzMTc2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/531764?v=4","gravatar_id":"","url":"https://api.github.com/users/bjorn","html_url":"https://github.com/bjorn","followers_url":"https://api.github.com/users/bjorn/followers","following_url":"https://api.github.com/users/bjorn/following{/other_user}","gists_url":"https://api.github.com/users/bjorn/gists{/gist_id}","starred_url":"https://api.github.com/users/bjorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjorn/subscriptions","organizations_url":"https://api.github.com/users/bjorn/orgs","repos_url":"https://api.github.com/users/bjorn/repos","events_url":"https://api.github.com/users/bjorn/events{/privacy}","received_events_url":"https://api.github.com/users/bjorn/received_events","type":"User","site_admin":false},"created_at":"2018-12-27T08:20:12Z","updated_at":"2018-12-27T08:20:12Z","author_association":"OWNER","body":"Unfortunately this issue persists in Qt 5.11 and Qt 5.12 (LTS). This means for now I'm going to stick to releasing against Qt 5.9, which may be a better choice in regards to stability anyway."}}
{"actor":{"display_login":"bjorn"}}