{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/pulls/comments/239625779","pull_request_review_id":182461950,"id":239625779,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTYyNTc3OQ==","diff_hunk":"@@ -364,15 +364,15 @@ Use the [`google-beta` provider](#google-beta-provider) to use these resources.\n \n ## Resource: `google_container_cluster`\n \n-### `enable_binary_authorization`, `enable_tpu`, `pod_security_policy_config`, `private_cluster`, and `master_ipv4_cidr_block` have been removed from the GA provider\n+### `enable_binary_authorization`, `enable_tpu`, `pod_security_policy_config`, `private_cluster`, and `master_ipv4_cidr_block`, `node_config.taints`, `node_config.workload_metadata_config` have been removed from the GA provider\n \n Use the [`google-beta` provider](#google-beta-provider) to set these fields.\n \n ## Resource: `google_container_node_pool`\n \n-### `max_pods_per_node` has been removed from the GA provider\n+### `max_pods_per_node`, `node_config.taints`, `node_config.workload_metadata_config` have been removed from the GA provider\n \n-Use the [`google-beta` provider](#google-beta-provider) to set this field.\n+Use the [`google-beta` provider](#google-beta-provider) to set these field.","path":"third_party/terraform/website/docs/version_2_upgrade.html.markdown","position":15,"original_position":15,"commit_id":"b7696ae1782bf63dd0259c87131da52b75d88b6e","original_commit_id":"b7696ae1782bf63dd0259c87131da52b75d88b6e","user":{"login":"danawillow","id":1130694,"node_id":"MDQ6VXNlcjExMzA2OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1130694?v=4","gravatar_id":"","url":"https://api.github.com/users/danawillow","html_url":"https://github.com/danawillow","followers_url":"https://api.github.com/users/danawillow/followers","following_url":"https://api.github.com/users/danawillow/following{/other_user}","gists_url":"https://api.github.com/users/danawillow/gists{/gist_id}","starred_url":"https://api.github.com/users/danawillow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danawillow/subscriptions","organizations_url":"https://api.github.com/users/danawillow/orgs","repos_url":"https://api.github.com/users/danawillow/repos","events_url":"https://api.github.com/users/danawillow/events{/privacy}","received_events_url":"https://api.github.com/users/danawillow/received_events","type":"User","site_admin":false},"body":"nit: fields","created_at":"2018-12-06T21:43:08Z","updated_at":"2018-12-06T21:43:12Z","html_url":"https://github.com/GoogleCloudPlatform/magic-modules/pull/1009#discussion_r239625779","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/pulls/1009","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/pulls/comments/239625779"},"html":{"href":"https://github.com/GoogleCloudPlatform/magic-modules/pull/1009#discussion_r239625779"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/pulls/1009"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/pulls/1009","id":236676693,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2Njc2Njkz","html_url":"https://github.com/GoogleCloudPlatform/magic-modules/pull/1009","diff_url":"https://github.com/GoogleCloudPlatform/magic-modules/pull/1009.diff","patch_url":"https://github.com/GoogleCloudPlatform/magic-modules/pull/1009.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/issues/1009","number":1009,"state":"open","locked":false,"title":"[Terraform]: Add node_config properties to version_2_upgrade.html.markdown","user":{"login":"rileykarson","id":2080520,"node_id":"MDQ6VXNlcjIwODA1MjA=","avatar_url":"https://avatars2.githubusercontent.com/u/2080520?v=4","gravatar_id":"","url":"https://api.github.com/users/rileykarson","html_url":"https://github.com/rileykarson","followers_url":"https://api.github.com/users/rileykarson/followers","following_url":"https://api.github.com/users/rileykarson/following{/other_user}","gists_url":"https://api.github.com/users/rileykarson/gists{/gist_id}","starred_url":"https://api.github.com/users/rileykarson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rileykarson/subscriptions","organizations_url":"https://api.github.com/users/rileykarson/orgs","repos_url":"https://api.github.com/users/rileykarson/repos","events_url":"https://api.github.com/users/rileykarson/events{/privacy}","received_events_url":"https://api.github.com/users/rileykarson/received_events","type":"User","site_admin":false},"body":"https://github.com/GoogleCloudPlatform/magic-modules/pull/1008\r\n\r\n-----------------------------------------------------------------\r\n# [all]\r\n## [terraform]\r\nAdd node_config properties to version_2_upgrade.html.markdown\r\n### [terraform-beta]\r\n## [ansible]\r\n## [inspec]\r\n","created_at":"2018-12-06T21:23:04Z","updated_at":"2018-12-06T21:43:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d8dd0071d59e8cb17253d4a20f10caade22d2d1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":995484256,"node_id":"MDU6TGFiZWw5OTU0ODQyNTY=","url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false},{"id":918813420,"node_id":"MDU6TGFiZWw5MTg4MTM0MjA=","url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/labels/downstream-generated","name":"downstream-generated","color":"aaffd9","default":false},{"id":891510289,"node_id":"MDU6TGFiZWw4OTE1MTAyODk=","url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/labels/terraform","name":"terraform","color":"5C4EE5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/pulls/1009/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/pulls/1009/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/issues/1009/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/statuses/b7696ae1782bf63dd0259c87131da52b75d88b6e","head":{"label":"GoogleCloudPlatform:rileykarson-patch-4","ref":"rileykarson-patch-4","sha":"b7696ae1782bf63dd0259c87131da52b75d88b6e","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":114834469,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ4MzQ0Njk=","name":"magic-modules","full_name":"GoogleCloudPlatform/magic-modules","private":false,"owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleCloudPlatform/magic-modules","description":"Magic Modules: Automagically generate Google Cloud Platform support for OSS","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/deployments","created_at":"2017-12-20T02:39:56Z","updated_at":"2018-12-06T21:24:05Z","pushed_at":"2018-12-06T21:24:00Z","git_url":"git://github.com/GoogleCloudPlatform/magic-modules.git","ssh_url":"git@github.com:GoogleCloudPlatform/magic-modules.git","clone_url":"https://github.com/GoogleCloudPlatform/magic-modules.git","svn_url":"https://github.com/GoogleCloudPlatform/magic-modules","homepage":"","size":6867,"stargazers_count":105,"watchers_count":105,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":84,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":41,"open_issues":84,"watchers":105,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"f5c7356d02fb80911e82baf0466a10f16adbaf51","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":114834469,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ4MzQ0Njk=","name":"magic-modules","full_name":"GoogleCloudPlatform/magic-modules","private":false,"owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleCloudPlatform/magic-modules","description":"Magic Modules: Automagically generate Google Cloud Platform support for OSS","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/deployments","created_at":"2017-12-20T02:39:56Z","updated_at":"2018-12-06T21:24:05Z","pushed_at":"2018-12-06T21:24:00Z","git_url":"git://github.com/GoogleCloudPlatform/magic-modules.git","ssh_url":"git@github.com:GoogleCloudPlatform/magic-modules.git","clone_url":"https://github.com/GoogleCloudPlatform/magic-modules.git","svn_url":"https://github.com/GoogleCloudPlatform/magic-modules","homepage":"","size":6867,"stargazers_count":105,"watchers_count":105,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":84,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":41,"open_issues":84,"watchers":105,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/pulls/1009"},"html":{"href":"https://github.com/GoogleCloudPlatform/magic-modules/pull/1009"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/issues/1009"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/issues/1009/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/pulls/1009/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/pulls/1009/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/statuses/b7696ae1782bf63dd0259c87131da52b75d88b6e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"danawillow"}}