{"action":"created","comment":{"url":"https://api.github.com/repos/OpenModelica/OMSimulator/pulls/comments/230813075","pull_request_review_id":171635334,"id":230813075,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDgxMzA3NQ==","diff_hunk":"@@ -262,13 +291,9 @@ void oms3::SystemTLM::disconnectFromSockets(const oms3::ComRef cref)\n \n oms_status_enu_t oms3::SystemTLM::setSocketData(const std::string &address, int managerPort, int monitorPort)\n {\n-  omtlm_setAddress(model, address);\n-  omtlm_setManagerPort(model, managerPort);\n-  omtlm_setMonitorPort(model, monitorPort);\n-\n   this->address = address;\n-  this->managerPort = managerPort;\n-  this->monitorPort = monitorPort;\n+  this->desiredManagerPort = managerPort;","path":"src/OMSimulatorLib/SystemTLM.cpp","position":94,"original_position":94,"commit_id":"af5d48d48071d782697d7f74fce973a5074f95d4","original_commit_id":"af5d48d48071d782697d7f74fce973a5074f95d4","user":{"login":"lochel","id":8457302,"node_id":"MDQ6VXNlcjg0NTczMDI=","avatar_url":"https://avatars3.githubusercontent.com/u/8457302?v=4","gravatar_id":"","url":"https://api.github.com/users/lochel","html_url":"https://github.com/lochel","followers_url":"https://api.github.com/users/lochel/followers","following_url":"https://api.github.com/users/lochel/following{/other_user}","gists_url":"https://api.github.com/users/lochel/gists{/gist_id}","starred_url":"https://api.github.com/users/lochel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lochel/subscriptions","organizations_url":"https://api.github.com/users/lochel/orgs","repos_url":"https://api.github.com/users/lochel/repos","events_url":"https://api.github.com/users/lochel/events{/privacy}","received_events_url":"https://api.github.com/users/lochel/received_events","type":"User","site_admin":false},"body":"I think it would be better to check the model state and reject calls to `oms3::SystemTLM::setSocketData` if the model is instantiated, initialized or in simulation mode.","created_at":"2018-11-05T16:18:06Z","updated_at":"2018-11-05T16:18:06Z","html_url":"https://github.com/OpenModelica/OMSimulator/pull/463#discussion_r230813075","pull_request_url":"https://api.github.com/repos/OpenModelica/OMSimulator/pulls/463","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OpenModelica/OMSimulator/pulls/comments/230813075"},"html":{"href":"https://github.com/OpenModelica/OMSimulator/pull/463#discussion_r230813075"},"pull_request":{"href":"https://api.github.com/repos/OpenModelica/OMSimulator/pulls/463"}}},"pull_request":{"url":"https://api.github.com/repos/OpenModelica/OMSimulator/pulls/463","id":227945230,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3OTQ1MjMw","html_url":"https://github.com/OpenModelica/OMSimulator/pull/463","diff_url":"https://github.com/OpenModelica/OMSimulator/pull/463.diff","patch_url":"https://github.com/OpenModelica/OMSimulator/pull/463.patch","issue_url":"https://api.github.com/repos/OpenModelica/OMSimulator/issues/463","number":463,"state":"open","locked":false,"title":"Make TLM simulations work with oms3","user":{"login":"robbr48","id":17850153,"node_id":"MDQ6VXNlcjE3ODUwMTUz","avatar_url":"https://avatars0.githubusercontent.com/u/17850153?v=4","gravatar_id":"","url":"https://api.github.com/users/robbr48","html_url":"https://github.com/robbr48","followers_url":"https://api.github.com/users/robbr48/followers","following_url":"https://api.github.com/users/robbr48/following{/other_user}","gists_url":"https://api.github.com/users/robbr48/gists{/gist_id}","starred_url":"https://api.github.com/users/robbr48/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbr48/subscriptions","organizations_url":"https://api.github.com/users/robbr48/orgs","repos_url":"https://api.github.com/users/robbr48/repos","events_url":"https://api.github.com/users/robbr48/events{/privacy}","received_events_url":"https://api.github.com/users/robbr48/received_events","type":"User","site_admin":false},"body":"### Purpose\r\n\r\nVarious fixes for enabling TLM simulations with oms3.\r\n\r\n### Type of Change\r\n\r\n- New feature (non-breaking change which adds functionality)\r\n\r\n### Checklist\r\n\r\n- I have performed a self-review of my own code\r\n- I have commented my code, particularly in hard-to-understand areas","created_at":"2018-11-02T13:59:00Z","updated_at":"2018-11-05T16:18:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"965a2d7faac7e179555aef5fcb6ef195cb823483","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenModelica/OMSimulator/pulls/463/commits","review_comments_url":"https://api.github.com/repos/OpenModelica/OMSimulator/pulls/463/comments","review_comment_url":"https://api.github.com/repos/OpenModelica/OMSimulator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenModelica/OMSimulator/issues/463/comments","statuses_url":"https://api.github.com/repos/OpenModelica/OMSimulator/statuses/af5d48d48071d782697d7f74fce973a5074f95d4","head":{"label":"robbr48:tlm_simulation_fixes","ref":"tlm_simulation_fixes","sha":"af5d48d48071d782697d7f74fce973a5074f95d4","user":{"login":"robbr48","id":17850153,"node_id":"MDQ6VXNlcjE3ODUwMTUz","avatar_url":"https://avatars0.githubusercontent.com/u/17850153?v=4","gravatar_id":"","url":"https://api.github.com/users/robbr48","html_url":"https://github.com/robbr48","followers_url":"https://api.github.com/users/robbr48/followers","following_url":"https://api.github.com/users/robbr48/following{/other_user}","gists_url":"https://api.github.com/users/robbr48/gists{/gist_id}","starred_url":"https://api.github.com/users/robbr48/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbr48/subscriptions","organizations_url":"https://api.github.com/users/robbr48/orgs","repos_url":"https://api.github.com/users/robbr48/repos","events_url":"https://api.github.com/users/robbr48/events{/privacy}","received_events_url":"https://api.github.com/users/robbr48/received_events","type":"User","site_admin":false},"repo":{"id":117209523,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcyMDk1MjM=","name":"OMSimulator","full_name":"robbr48/OMSimulator","private":false,"owner":{"login":"robbr48","id":17850153,"node_id":"MDQ6VXNlcjE3ODUwMTUz","avatar_url":"https://avatars0.githubusercontent.com/u/17850153?v=4","gravatar_id":"","url":"https://api.github.com/users/robbr48","html_url":"https://github.com/robbr48","followers_url":"https://api.github.com/users/robbr48/followers","following_url":"https://api.github.com/users/robbr48/following{/other_user}","gists_url":"https://api.github.com/users/robbr48/gists{/gist_id}","starred_url":"https://api.github.com/users/robbr48/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbr48/subscriptions","organizations_url":"https://api.github.com/users/robbr48/orgs","repos_url":"https://api.github.com/users/robbr48/repos","events_url":"https://api.github.com/users/robbr48/events{/privacy}","received_events_url":"https://api.github.com/users/robbr48/received_events","type":"User","site_admin":false},"html_url":"https://github.com/robbr48/OMSimulator","description":"OpenModelica FMI & TLM based simulator","fork":true,"url":"https://api.github.com/repos/robbr48/OMSimulator","forks_url":"https://api.github.com/repos/robbr48/OMSimulator/forks","keys_url":"https://api.github.com/repos/robbr48/OMSimulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robbr48/OMSimulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robbr48/OMSimulator/teams","hooks_url":"https://api.github.com/repos/robbr48/OMSimulator/hooks","issue_events_url":"https://api.github.com/repos/robbr48/OMSimulator/issues/events{/number}","events_url":"https://api.github.com/repos/robbr48/OMSimulator/events","assignees_url":"https://api.github.com/repos/robbr48/OMSimulator/assignees{/user}","branches_url":"https://api.github.com/repos/robbr48/OMSimulator/branches{/branch}","tags_url":"https://api.github.com/repos/robbr48/OMSimulator/tags","blobs_url":"https://api.github.com/repos/robbr48/OMSimulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robbr48/OMSimulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robbr48/OMSimulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/robbr48/OMSimulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robbr48/OMSimulator/statuses/{sha}","languages_url":"https://api.github.com/repos/robbr48/OMSimulator/languages","stargazers_url":"https://api.github.com/repos/robbr48/OMSimulator/stargazers","contributors_url":"https://api.github.com/repos/robbr48/OMSimulator/contributors","subscribers_url":"https://api.github.com/repos/robbr48/OMSimulator/subscribers","subscription_url":"https://api.github.com/repos/robbr48/OMSimulator/subscription","commits_url":"https://api.github.com/repos/robbr48/OMSimulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/robbr48/OMSimulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/robbr48/OMSimulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/robbr48/OMSimulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/robbr48/OMSimulator/contents/{+path}","compare_url":"https://api.github.com/repos/robbr48/OMSimulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robbr48/OMSimulator/merges","archive_url":"https://api.github.com/repos/robbr48/OMSimulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robbr48/OMSimulator/downloads","issues_url":"https://api.github.com/repos/robbr48/OMSimulator/issues{/number}","pulls_url":"https://api.github.com/repos/robbr48/OMSimulator/pulls{/number}","milestones_url":"https://api.github.com/repos/robbr48/OMSimulator/milestones{/number}","notifications_url":"https://api.github.com/repos/robbr48/OMSimulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robbr48/OMSimulator/labels{/name}","releases_url":"https://api.github.com/repos/robbr48/OMSimulator/releases{/id}","deployments_url":"https://api.github.com/repos/robbr48/OMSimulator/deployments","created_at":"2018-01-12T07:37:20Z","updated_at":"2018-11-05T07:48:20Z","pushed_at":"2018-11-05T16:12:23Z","git_url":"git://github.com/robbr48/OMSimulator.git","ssh_url":"git@github.com:robbr48/OMSimulator.git","clone_url":"https://github.com/robbr48/OMSimulator.git","svn_url":"https://github.com/robbr48/OMSimulator","homepage":null,"size":1675,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"OpenModelica:master","ref":"master","sha":"d8c229f21c253231d3783665961214c06c039b0a","user":{"login":"OpenModelica","id":4006504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMDY1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4006504?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenModelica","html_url":"https://github.com/OpenModelica","followers_url":"https://api.github.com/users/OpenModelica/followers","following_url":"https://api.github.com/users/OpenModelica/following{/other_user}","gists_url":"https://api.github.com/users/OpenModelica/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenModelica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenModelica/subscriptions","organizations_url":"https://api.github.com/users/OpenModelica/orgs","repos_url":"https://api.github.com/users/OpenModelica/repos","events_url":"https://api.github.com/users/OpenModelica/events{/privacy}","received_events_url":"https://api.github.com/users/OpenModelica/received_events","type":"Organization","site_admin":false},"repo":{"id":111417328,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE0MTczMjg=","name":"OMSimulator","full_name":"OpenModelica/OMSimulator","private":false,"owner":{"login":"OpenModelica","id":4006504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMDY1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4006504?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenModelica","html_url":"https://github.com/OpenModelica","followers_url":"https://api.github.com/users/OpenModelica/followers","following_url":"https://api.github.com/users/OpenModelica/following{/other_user}","gists_url":"https://api.github.com/users/OpenModelica/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenModelica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenModelica/subscriptions","organizations_url":"https://api.github.com/users/OpenModelica/orgs","repos_url":"https://api.github.com/users/OpenModelica/repos","events_url":"https://api.github.com/users/OpenModelica/events{/privacy}","received_events_url":"https://api.github.com/users/OpenModelica/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OpenModelica/OMSimulator","description":"OpenModelica FMI & TLM based simulator","fork":false,"url":"https://api.github.com/repos/OpenModelica/OMSimulator","forks_url":"https://api.github.com/repos/OpenModelica/OMSimulator/forks","keys_url":"https://api.github.com/repos/OpenModelica/OMSimulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenModelica/OMSimulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenModelica/OMSimulator/teams","hooks_url":"https://api.github.com/repos/OpenModelica/OMSimulator/hooks","issue_events_url":"https://api.github.com/repos/OpenModelica/OMSimulator/issues/events{/number}","events_url":"https://api.github.com/repos/OpenModelica/OMSimulator/events","assignees_url":"https://api.github.com/repos/OpenModelica/OMSimulator/assignees{/user}","branches_url":"https://api.github.com/repos/OpenModelica/OMSimulator/branches{/branch}","tags_url":"https://api.github.com/repos/OpenModelica/OMSimulator/tags","blobs_url":"https://api.github.com/repos/OpenModelica/OMSimulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenModelica/OMSimulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenModelica/OMSimulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenModelica/OMSimulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenModelica/OMSimulator/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenModelica/OMSimulator/languages","stargazers_url":"https://api.github.com/repos/OpenModelica/OMSimulator/stargazers","contributors_url":"https://api.github.com/repos/OpenModelica/OMSimulator/contributors","subscribers_url":"https://api.github.com/repos/OpenModelica/OMSimulator/subscribers","subscription_url":"https://api.github.com/repos/OpenModelica/OMSimulator/subscription","commits_url":"https://api.github.com/repos/OpenModelica/OMSimulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenModelica/OMSimulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenModelica/OMSimulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenModelica/OMSimulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenModelica/OMSimulator/contents/{+path}","compare_url":"https://api.github.com/repos/OpenModelica/OMSimulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenModelica/OMSimulator/merges","archive_url":"https://api.github.com/repos/OpenModelica/OMSimulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenModelica/OMSimulator/downloads","issues_url":"https://api.github.com/repos/OpenModelica/OMSimulator/issues{/number}","pulls_url":"https://api.github.com/repos/OpenModelica/OMSimulator/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenModelica/OMSimulator/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenModelica/OMSimulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenModelica/OMSimulator/labels{/name}","releases_url":"https://api.github.com/repos/OpenModelica/OMSimulator/releases{/id}","deployments_url":"https://api.github.com/repos/OpenModelica/OMSimulator/deployments","created_at":"2017-11-20T13:58:42Z","updated_at":"2018-11-05T11:22:29Z","pushed_at":"2018-11-05T16:12:24Z","git_url":"git://github.com/OpenModelica/OMSimulator.git","ssh_url":"git@github.com:OpenModelica/OMSimulator.git","clone_url":"https://github.com/OpenModelica/OMSimulator.git","svn_url":"https://github.com/OpenModelica/OMSimulator","homepage":null,"size":1675,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":14,"open_issues":32,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenModelica/OMSimulator/pulls/463"},"html":{"href":"https://github.com/OpenModelica/OMSimulator/pull/463"},"issue":{"href":"https://api.github.com/repos/OpenModelica/OMSimulator/issues/463"},"comments":{"href":"https://api.github.com/repos/OpenModelica/OMSimulator/issues/463/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenModelica/OMSimulator/pulls/463/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenModelica/OMSimulator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenModelica/OMSimulator/pulls/463/commits"},"statuses":{"href":"https://api.github.com/repos/OpenModelica/OMSimulator/statuses/af5d48d48071d782697d7f74fce973a5074f95d4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lochel"}}