{"action":"created","issue":{"url":"https://api.github.com/repos/apache/nifi-minifi/issues/115","repository_url":"https://api.github.com/repos/apache/nifi-minifi","labels_url":"https://api.github.com/repos/apache/nifi-minifi/issues/115/labels{/name}","comments_url":"https://api.github.com/repos/apache/nifi-minifi/issues/115/comments","events_url":"https://api.github.com/repos/apache/nifi-minifi/issues/115/events","html_url":"https://github.com/apache/nifi-minifi/pull/115","id":294318234,"number":115,"title":"MINIFI-433 - PG Variable Registry support in templates","user":{"login":"pvillard31","id":11541012,"avatar_url":"https://avatars0.githubusercontent.com/u/11541012?v=4","gravatar_id":"","url":"https://api.github.com/users/pvillard31","html_url":"https://github.com/pvillard31","followers_url":"https://api.github.com/users/pvillard31/followers","following_url":"https://api.github.com/users/pvillard31/following{/other_user}","gists_url":"https://api.github.com/users/pvillard31/gists{/gist_id}","starred_url":"https://api.github.com/users/pvillard31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvillard31/subscriptions","organizations_url":"https://api.github.com/users/pvillard31/orgs","repos_url":"https://api.github.com/users/pvillard31/repos","events_url":"https://api.github.com/users/pvillard31/events{/privacy}","received_events_url":"https://api.github.com/users/pvillard31/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-05T09:07:19Z","updated_at":"2018-02-05T09:11:08Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/nifi-minifi/pulls/115","html_url":"https://github.com/apache/nifi-minifi/pull/115","diff_url":"https://github.com/apache/nifi-minifi/pull/115.diff","patch_url":"https://github.com/apache/nifi-minifi/pull/115.patch"},"body":"Thank you for submitting a contribution to Apache NiFi - MiNiFi.\r\n\r\nIn order to streamline the review of the contribution we ask you\r\nto ensure the following steps have been taken:\r\n\r\n### For all changes:\r\n- [ ] Is there a JIRA ticket associated with this PR? Is it referenced \r\n     in the commit message?\r\n\r\n- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen \"-\" character.\r\n\r\n- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?\r\n\r\n- [ ] Is your initial contribution a single, squashed commit?\r\n\r\n### For code changes:\r\n- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi-minifi folder?\r\n- [ ] Have you written or updated unit tests to verify your changes?\r\n- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? \r\n- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under minifi-assembly?\r\n- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under minifi-assembly?\r\n\r\n### For documentation related changes:\r\n- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?\r\n\r\n### Note:\r\nPlease ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.\r\n"},"comment":{"url":"https://api.github.com/repos/apache/nifi-minifi/issues/comments/363023139","html_url":"https://github.com/apache/nifi-minifi/pull/115#issuecomment-363023139","issue_url":"https://api.github.com/repos/apache/nifi-minifi/issues/115","id":363023139,"user":{"login":"pvillard31","id":11541012,"avatar_url":"https://avatars0.githubusercontent.com/u/11541012?v=4","gravatar_id":"","url":"https://api.github.com/users/pvillard31","html_url":"https://github.com/pvillard31","followers_url":"https://api.github.com/users/pvillard31/followers","following_url":"https://api.github.com/users/pvillard31/following{/other_user}","gists_url":"https://api.github.com/users/pvillard31/gists{/gist_id}","starred_url":"https://api.github.com/users/pvillard31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvillard31/subscriptions","organizations_url":"https://api.github.com/users/pvillard31/orgs","repos_url":"https://api.github.com/users/pvillard31/repos","events_url":"https://api.github.com/users/pvillard31/events{/privacy}","received_events_url":"https://api.github.com/users/pvillard31/received_events","type":"User","site_admin":false},"created_at":"2018-02-05T09:11:08Z","updated_at":"2018-02-05T09:11:08Z","author_association":"CONTRIBUTOR","body":"**Do not merge as-is.**\r\n\r\nI added unit tests, and it seems to behave as expected but when testing with a local build, variables are not included in the flow.xml.gz generated from the config.yml. I guess I missed something somewhere, but didn't find it so far. I still submitted the PR in case someone wants to have a look."}}
{"actor":{"display_login":"pvillard31"}}