{"action":"created","comment":{"url":"https://api.github.com/repos/odlgroup/odl/pulls/comments/186260206","pull_request_review_id":117812183,"id":186260206,"diff_hunk":"@@ -232,10 +232,10 @@ def bregman(self, point, subgrad=None):\n         ----------\n         point : element of ``functional.domain``\n             Point from which to define the Bregman distance.\n-        subgrad : `Operator`, optional\n-            A subgradient operator. Operator which that takes an element in\n-            `functional.domain` and returns a subdifferential of the functional\n-            in that point.\n+        subgrad : element of ``functional.domain`` or `Operator`, optional\n+            A subgradient of ``functional`` in ``point``, or an operator\n+            which that takes an element in ``functional.domain`` and returns a\n+            subdifferential of the functional in that point.","path":"odl/solvers/functional/functional.py","position":11,"original_position":11,"commit_id":"2f4de226d9875e107337343153c5f2fbc3ed0a91","original_commit_id":"2f4de226d9875e107337343153c5f2fbc3ed0a91","user":{"login":"mehrhardt","id":6604653,"avatar_url":"https://avatars0.githubusercontent.com/u/6604653?v=4","gravatar_id":"","url":"https://api.github.com/users/mehrhardt","html_url":"https://github.com/mehrhardt","followers_url":"https://api.github.com/users/mehrhardt/followers","following_url":"https://api.github.com/users/mehrhardt/following{/other_user}","gists_url":"https://api.github.com/users/mehrhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/mehrhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mehrhardt/subscriptions","organizations_url":"https://api.github.com/users/mehrhardt/orgs","repos_url":"https://api.github.com/users/mehrhardt/repos","events_url":"https://api.github.com/users/mehrhardt/events{/privacy}","received_events_url":"https://api.github.com/users/mehrhardt/received_events","type":"User","site_admin":false},"body":"I am also in favour of no intelligence and make the `subgrad` mandatory.","created_at":"2018-05-05T11:42:35Z","updated_at":"2018-05-05T11:42:35Z","html_url":"https://github.com/odlgroup/odl/pull/1340#discussion_r186260206","pull_request_url":"https://api.github.com/repos/odlgroup/odl/pulls/1340","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/odlgroup/odl/pulls/comments/186260206"},"html":{"href":"https://github.com/odlgroup/odl/pull/1340#discussion_r186260206"},"pull_request":{"href":"https://api.github.com/repos/odlgroup/odl/pulls/1340"}},"in_reply_to_id":186126155},"pull_request":{"url":"https://api.github.com/repos/odlgroup/odl/pulls/1340","id":186008151,"html_url":"https://github.com/odlgroup/odl/pull/1340","diff_url":"https://github.com/odlgroup/odl/pull/1340.diff","patch_url":"https://github.com/odlgroup/odl/pull/1340.patch","issue_url":"https://api.github.com/repos/odlgroup/odl/issues/1340","number":1340,"state":"open","locked":false,"title":"Update the Bregman functional implementation","user":{"login":"aringh","id":15774494,"avatar_url":"https://avatars0.githubusercontent.com/u/15774494?v=4","gravatar_id":"","url":"https://api.github.com/users/aringh","html_url":"https://github.com/aringh","followers_url":"https://api.github.com/users/aringh/followers","following_url":"https://api.github.com/users/aringh/following{/other_user}","gists_url":"https://api.github.com/users/aringh/gists{/gist_id}","starred_url":"https://api.github.com/users/aringh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aringh/subscriptions","organizations_url":"https://api.github.com/users/aringh/orgs","repos_url":"https://api.github.com/users/aringh/repos","events_url":"https://api.github.com/users/aringh/events{/privacy}","received_events_url":"https://api.github.com/users/aringh/received_events","type":"User","site_admin":false},"body":"Closes #1312 ","created_at":"2018-05-04T14:56:05Z","updated_at":"2018-05-05T11:42:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3b76a04904c1bafbc5266cf4b8f03b971469804","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":285444738,"url":"https://api.github.com/repos/odlgroup/odl/labels/needs%20review","name":"needs review","color":"fbca04","default":false},{"id":289000326,"url":"https://api.github.com/repos/odlgroup/odl/labels/odl%20solvers","name":"odl solvers","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/odlgroup/odl/pulls/1340/commits","review_comments_url":"https://api.github.com/repos/odlgroup/odl/pulls/1340/comments","review_comment_url":"https://api.github.com/repos/odlgroup/odl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/odlgroup/odl/issues/1340/comments","statuses_url":"https://api.github.com/repos/odlgroup/odl/statuses/2f4de226d9875e107337343153c5f2fbc3ed0a91","head":{"label":"aringh:issue-1312__updates_to_bregman_distance_impl","ref":"issue-1312__updates_to_bregman_distance_impl","sha":"2f4de226d9875e107337343153c5f2fbc3ed0a91","user":{"login":"aringh","id":15774494,"avatar_url":"https://avatars0.githubusercontent.com/u/15774494?v=4","gravatar_id":"","url":"https://api.github.com/users/aringh","html_url":"https://github.com/aringh","followers_url":"https://api.github.com/users/aringh/followers","following_url":"https://api.github.com/users/aringh/following{/other_user}","gists_url":"https://api.github.com/users/aringh/gists{/gist_id}","starred_url":"https://api.github.com/users/aringh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aringh/subscriptions","organizations_url":"https://api.github.com/users/aringh/orgs","repos_url":"https://api.github.com/users/aringh/repos","events_url":"https://api.github.com/users/aringh/events{/privacy}","received_events_url":"https://api.github.com/users/aringh/received_events","type":"User","site_admin":false},"repo":{"id":79563820,"name":"odl","full_name":"aringh/odl","owner":{"login":"aringh","id":15774494,"avatar_url":"https://avatars0.githubusercontent.com/u/15774494?v=4","gravatar_id":"","url":"https://api.github.com/users/aringh","html_url":"https://github.com/aringh","followers_url":"https://api.github.com/users/aringh/followers","following_url":"https://api.github.com/users/aringh/following{/other_user}","gists_url":"https://api.github.com/users/aringh/gists{/gist_id}","starred_url":"https://api.github.com/users/aringh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aringh/subscriptions","organizations_url":"https://api.github.com/users/aringh/orgs","repos_url":"https://api.github.com/users/aringh/repos","events_url":"https://api.github.com/users/aringh/events{/privacy}","received_events_url":"https://api.github.com/users/aringh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aringh/odl","description":"Operator Discretization Library","fork":true,"url":"https://api.github.com/repos/aringh/odl","forks_url":"https://api.github.com/repos/aringh/odl/forks","keys_url":"https://api.github.com/repos/aringh/odl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aringh/odl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aringh/odl/teams","hooks_url":"https://api.github.com/repos/aringh/odl/hooks","issue_events_url":"https://api.github.com/repos/aringh/odl/issues/events{/number}","events_url":"https://api.github.com/repos/aringh/odl/events","assignees_url":"https://api.github.com/repos/aringh/odl/assignees{/user}","branches_url":"https://api.github.com/repos/aringh/odl/branches{/branch}","tags_url":"https://api.github.com/repos/aringh/odl/tags","blobs_url":"https://api.github.com/repos/aringh/odl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aringh/odl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aringh/odl/git/refs{/sha}","trees_url":"https://api.github.com/repos/aringh/odl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aringh/odl/statuses/{sha}","languages_url":"https://api.github.com/repos/aringh/odl/languages","stargazers_url":"https://api.github.com/repos/aringh/odl/stargazers","contributors_url":"https://api.github.com/repos/aringh/odl/contributors","subscribers_url":"https://api.github.com/repos/aringh/odl/subscribers","subscription_url":"https://api.github.com/repos/aringh/odl/subscription","commits_url":"https://api.github.com/repos/aringh/odl/commits{/sha}","git_commits_url":"https://api.github.com/repos/aringh/odl/git/commits{/sha}","comments_url":"https://api.github.com/repos/aringh/odl/comments{/number}","issue_comment_url":"https://api.github.com/repos/aringh/odl/issues/comments{/number}","contents_url":"https://api.github.com/repos/aringh/odl/contents/{+path}","compare_url":"https://api.github.com/repos/aringh/odl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aringh/odl/merges","archive_url":"https://api.github.com/repos/aringh/odl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aringh/odl/downloads","issues_url":"https://api.github.com/repos/aringh/odl/issues{/number}","pulls_url":"https://api.github.com/repos/aringh/odl/pulls{/number}","milestones_url":"https://api.github.com/repos/aringh/odl/milestones{/number}","notifications_url":"https://api.github.com/repos/aringh/odl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aringh/odl/labels{/name}","releases_url":"https://api.github.com/repos/aringh/odl/releases{/id}","deployments_url":"https://api.github.com/repos/aringh/odl/deployments","created_at":"2017-01-20T14:01:52Z","updated_at":"2017-01-20T14:01:55Z","pushed_at":"2018-05-04T14:52:46Z","git_url":"git://github.com/aringh/odl.git","ssh_url":"git@github.com:aringh/odl.git","clone_url":"https://github.com/aringh/odl.git","svn_url":"https://github.com/aringh/odl","homepage":null,"size":38774,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"odlgroup:master","ref":"master","sha":"dfc63836e2c3faaa2d817e391fb0a3052f079c87","user":{"login":"odlgroup","id":15667171,"avatar_url":"https://avatars1.githubusercontent.com/u/15667171?v=4","gravatar_id":"","url":"https://api.github.com/users/odlgroup","html_url":"https://github.com/odlgroup","followers_url":"https://api.github.com/users/odlgroup/followers","following_url":"https://api.github.com/users/odlgroup/following{/other_user}","gists_url":"https://api.github.com/users/odlgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/odlgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odlgroup/subscriptions","organizations_url":"https://api.github.com/users/odlgroup/orgs","repos_url":"https://api.github.com/users/odlgroup/repos","events_url":"https://api.github.com/users/odlgroup/events{/privacy}","received_events_url":"https://api.github.com/users/odlgroup/received_events","type":"Organization","site_admin":false},"repo":{"id":45596393,"name":"odl","full_name":"odlgroup/odl","owner":{"login":"odlgroup","id":15667171,"avatar_url":"https://avatars1.githubusercontent.com/u/15667171?v=4","gravatar_id":"","url":"https://api.github.com/users/odlgroup","html_url":"https://github.com/odlgroup","followers_url":"https://api.github.com/users/odlgroup/followers","following_url":"https://api.github.com/users/odlgroup/following{/other_user}","gists_url":"https://api.github.com/users/odlgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/odlgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odlgroup/subscriptions","organizations_url":"https://api.github.com/users/odlgroup/orgs","repos_url":"https://api.github.com/users/odlgroup/repos","events_url":"https://api.github.com/users/odlgroup/events{/privacy}","received_events_url":"https://api.github.com/users/odlgroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odlgroup/odl","description":"Operator Discretization Library  https://odlgroup.github.io/odl/","fork":false,"url":"https://api.github.com/repos/odlgroup/odl","forks_url":"https://api.github.com/repos/odlgroup/odl/forks","keys_url":"https://api.github.com/repos/odlgroup/odl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odlgroup/odl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odlgroup/odl/teams","hooks_url":"https://api.github.com/repos/odlgroup/odl/hooks","issue_events_url":"https://api.github.com/repos/odlgroup/odl/issues/events{/number}","events_url":"https://api.github.com/repos/odlgroup/odl/events","assignees_url":"https://api.github.com/repos/odlgroup/odl/assignees{/user}","branches_url":"https://api.github.com/repos/odlgroup/odl/branches{/branch}","tags_url":"https://api.github.com/repos/odlgroup/odl/tags","blobs_url":"https://api.github.com/repos/odlgroup/odl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odlgroup/odl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odlgroup/odl/git/refs{/sha}","trees_url":"https://api.github.com/repos/odlgroup/odl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odlgroup/odl/statuses/{sha}","languages_url":"https://api.github.com/repos/odlgroup/odl/languages","stargazers_url":"https://api.github.com/repos/odlgroup/odl/stargazers","contributors_url":"https://api.github.com/repos/odlgroup/odl/contributors","subscribers_url":"https://api.github.com/repos/odlgroup/odl/subscribers","subscription_url":"https://api.github.com/repos/odlgroup/odl/subscription","commits_url":"https://api.github.com/repos/odlgroup/odl/commits{/sha}","git_commits_url":"https://api.github.com/repos/odlgroup/odl/git/commits{/sha}","comments_url":"https://api.github.com/repos/odlgroup/odl/comments{/number}","issue_comment_url":"https://api.github.com/repos/odlgroup/odl/issues/comments{/number}","contents_url":"https://api.github.com/repos/odlgroup/odl/contents/{+path}","compare_url":"https://api.github.com/repos/odlgroup/odl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odlgroup/odl/merges","archive_url":"https://api.github.com/repos/odlgroup/odl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odlgroup/odl/downloads","issues_url":"https://api.github.com/repos/odlgroup/odl/issues{/number}","pulls_url":"https://api.github.com/repos/odlgroup/odl/pulls{/number}","milestones_url":"https://api.github.com/repos/odlgroup/odl/milestones{/number}","notifications_url":"https://api.github.com/repos/odlgroup/odl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odlgroup/odl/labels{/name}","releases_url":"https://api.github.com/repos/odlgroup/odl/releases{/id}","deployments_url":"https://api.github.com/repos/odlgroup/odl/deployments","created_at":"2015-11-05T07:57:55Z","updated_at":"2018-05-04T08:23:15Z","pushed_at":"2018-05-04T14:56:06Z","git_url":"git://github.com/odlgroup/odl.git","ssh_url":"git@github.com:odlgroup/odl.git","clone_url":"https://github.com/odlgroup/odl.git","svn_url":"https://github.com/odlgroup/odl","homepage":"","size":34392,"stargazers_count":59,"watchers_count":59,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":189,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":38,"open_issues":189,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/odlgroup/odl/pulls/1340"},"html":{"href":"https://github.com/odlgroup/odl/pull/1340"},"issue":{"href":"https://api.github.com/repos/odlgroup/odl/issues/1340"},"comments":{"href":"https://api.github.com/repos/odlgroup/odl/issues/1340/comments"},"review_comments":{"href":"https://api.github.com/repos/odlgroup/odl/pulls/1340/comments"},"review_comment":{"href":"https://api.github.com/repos/odlgroup/odl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/odlgroup/odl/pulls/1340/commits"},"statuses":{"href":"https://api.github.com/repos/odlgroup/odl/statuses/2f4de226d9875e107337343153c5f2fbc3ed0a91"}},"author_association":"OWNER"}}
{"actor":{"display_login":"mehrhardt"}}