{"action":"created","comment":{"url":"https://api.github.com/repos/Stanford-Online/configuration/pulls/comments/167751410","pull_request_review_id":96015303,"id":167751410,"diff_hunk":"@@ -0,0 +1,18 @@\n+#!/usr/bin/env ansible-playbook\n+---\n+- include: ../playbooks/cluster.yml\n+  vars:\n+    CLUSTER_NAME: analytics-jenkins\n+  when: redeploy | default(False) | bool\n+- name: \"Setup {{ COMMON_HOSTNAME }}\"\n+  hosts: \"tag_Cluster_{{ CLUSTER_NAME }}:&tag_todo_deploy:&tag_Deployment_{{ COMMON_DEPLOYMENT }}:&tag_Number_{{ CLUSTER_NUMBER }}\"\n+  gather_facts: True\n+  become: true\n+  vars_files:","path":"stanford/playbooks/analytics-jenkins.yml","position":11,"original_position":11,"commit_id":"f894fe973ac8468441dfcac1665974cb872d4ad3","original_commit_id":"f894fe973ac8468441dfcac1665974cb872d4ad3","user":{"login":"stvstnfrd","id":7300975,"avatar_url":"https://avatars0.githubusercontent.com/u/7300975?v=4","gravatar_id":"","url":"https://api.github.com/users/stvstnfrd","html_url":"https://github.com/stvstnfrd","followers_url":"https://api.github.com/users/stvstnfrd/followers","following_url":"https://api.github.com/users/stvstnfrd/following{/other_user}","gists_url":"https://api.github.com/users/stvstnfrd/gists{/gist_id}","starred_url":"https://api.github.com/users/stvstnfrd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stvstnfrd/subscriptions","organizations_url":"https://api.github.com/users/stvstnfrd/orgs","repos_url":"https://api.github.com/users/stvstnfrd/repos","events_url":"https://api.github.com/users/stvstnfrd/events{/privacy}","received_events_url":"https://api.github.com/users/stvstnfrd/received_events","type":"User","site_admin":false},"body":"The yaml file is a list.\r\n- The first item is an `include` that loads a complete playbook file `../playbooks/cluster.yml`.\r\n- The second item is a new play named \"Setup {{ COMMON_HOSTNAME }}\", etc.\r\n\r\nEach item above is a play within a playbook (`stanford/playbooks/analytics-jenkins.yml`).\r\n\r\nSee more here [1].\r\n\r\n> Each playbook is composed of one or more ‘plays’ in a list.\r\n\r\n> The goal of a play is to map a group of hosts to some well defined roles, represented by things ansible calls tasks. At a basic level, a task is nothing more than a call to an ansible module.\r\n\r\n> By composing a playbook of multiple ‘plays’, it is possible to orchestrate multi-machine deployments, running certain steps on all machines in the webservers group, then certain steps on the database server group, then more commands back on the webservers group, etc.\r\n\r\n[1] http://docs.ansible.com/ansible/latest/playbooks_intro.html#playbook-language-example","created_at":"2018-02-13T03:14:51Z","updated_at":"2018-02-13T03:17:49Z","html_url":"https://github.com/Stanford-Online/configuration/pull/219#discussion_r167751410","pull_request_url":"https://api.github.com/repos/Stanford-Online/configuration/pulls/219","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Stanford-Online/configuration/pulls/comments/167751410"},"html":{"href":"https://github.com/Stanford-Online/configuration/pull/219#discussion_r167751410"},"pull_request":{"href":"https://api.github.com/repos/Stanford-Online/configuration/pulls/219"}},"in_reply_to_id":166409403},"pull_request":{"url":"https://api.github.com/repos/Stanford-Online/configuration/pulls/219","id":167282939,"html_url":"https://github.com/Stanford-Online/configuration/pull/219","diff_url":"https://github.com/Stanford-Online/configuration/pull/219.diff","patch_url":"https://github.com/Stanford-Online/configuration/pull/219.patch","issue_url":"https://api.github.com/repos/Stanford-Online/configuration/issues/219","number":219,"state":"open","locked":false,"title":"WIP: Setup machines for Insights.","user":{"login":"dcadams","id":1840555,"avatar_url":"https://avatars3.githubusercontent.com/u/1840555?v=4","gravatar_id":"","url":"https://api.github.com/users/dcadams","html_url":"https://github.com/dcadams","followers_url":"https://api.github.com/users/dcadams/followers","following_url":"https://api.github.com/users/dcadams/following{/other_user}","gists_url":"https://api.github.com/users/dcadams/gists{/gist_id}","starred_url":"https://api.github.com/users/dcadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcadams/subscriptions","organizations_url":"https://api.github.com/users/dcadams/orgs","repos_url":"https://api.github.com/users/dcadams/repos","events_url":"https://api.github.com/users/dcadams/events{/privacy}","received_events_url":"https://api.github.com/users/dcadams/received_events","type":"User","site_admin":false},"body":"@stvstnfrd time for some eyeballs and a few questions:\r\n---------------------------------------------------\r\n\r\nThree new playbooks folded into the cluster role:\r\n  insights, analytics_api, analytics-jenkins\r\n\r\nFor now there is only cluster_number = 1 but we should have 1,2 for insights, analytics_api and just 1 for analytics-jenkins.\r\n\r\nTake a look in stanford/roles/cluster/defaults/main.yml, I start the cidr's at 145 since looking in AWS (e.g. CME) I see 125/126, 135/136 present but it doesn't look like they were created with the playbook.\r\n\r\nFor stage, I'm not seeing DEPLOYMENT_CIDR_BASE set. In fact, I don't see it for Lagunita either.\r\n\r\nIt doesn't look like you're creating much for the db (e.g. cme-subnet-db-1, cme-group-db) in the playbook. I've added a new role, insights_deployment, that creates the extra subnets, RT's, SG's I need them but they don't fit into the semantics of a cluster. One of the issues with this is that I have lines of the type:\r\ncidr:  \"{{ DEPLOYMENT_CIDR_BASE }}.175.0/24\"\r\n\r\nsince there doesn't seem to be anywhere outside of cluster/defaults/main.yml to define the vars.\r\n\r\n","created_at":"2018-02-05T23:30:35Z","updated_at":"2018-02-13T03:17:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e245c9c5c177dba99acc374cbb81ea6289270c5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Stanford-Online/configuration/pulls/219/commits","review_comments_url":"https://api.github.com/repos/Stanford-Online/configuration/pulls/219/comments","review_comment_url":"https://api.github.com/repos/Stanford-Online/configuration/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Stanford-Online/configuration/issues/219/comments","statuses_url":"https://api.github.com/repos/Stanford-Online/configuration/statuses/f894fe973ac8468441dfcac1665974cb872d4ad3","head":{"label":"Stanford-Online:dcadams/insights_deploy","ref":"dcadams/insights_deploy","sha":"f894fe973ac8468441dfcac1665974cb872d4ad3","user":{"login":"Stanford-Online","id":2159497,"avatar_url":"https://avatars3.githubusercontent.com/u/2159497?v=4","gravatar_id":"","url":"https://api.github.com/users/Stanford-Online","html_url":"https://github.com/Stanford-Online","followers_url":"https://api.github.com/users/Stanford-Online/followers","following_url":"https://api.github.com/users/Stanford-Online/following{/other_user}","gists_url":"https://api.github.com/users/Stanford-Online/gists{/gist_id}","starred_url":"https://api.github.com/users/Stanford-Online/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stanford-Online/subscriptions","organizations_url":"https://api.github.com/users/Stanford-Online/orgs","repos_url":"https://api.github.com/users/Stanford-Online/repos","events_url":"https://api.github.com/users/Stanford-Online/events{/privacy}","received_events_url":"https://api.github.com/users/Stanford-Online/received_events","type":"Organization","site_admin":false},"repo":{"id":20904958,"name":"configuration","full_name":"Stanford-Online/configuration","owner":{"login":"Stanford-Online","id":2159497,"avatar_url":"https://avatars3.githubusercontent.com/u/2159497?v=4","gravatar_id":"","url":"https://api.github.com/users/Stanford-Online","html_url":"https://github.com/Stanford-Online","followers_url":"https://api.github.com/users/Stanford-Online/followers","following_url":"https://api.github.com/users/Stanford-Online/following{/other_user}","gists_url":"https://api.github.com/users/Stanford-Online/gists{/gist_id}","starred_url":"https://api.github.com/users/Stanford-Online/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stanford-Online/subscriptions","organizations_url":"https://api.github.com/users/Stanford-Online/orgs","repos_url":"https://api.github.com/users/Stanford-Online/repos","events_url":"https://api.github.com/users/Stanford-Online/events{/privacy}","received_events_url":"https://api.github.com/users/Stanford-Online/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Stanford-Online/configuration","description":"a simple, but flexible, way for anyone to stand up an instance of the edX platform that is fully configured and ready-to-go","fork":true,"url":"https://api.github.com/repos/Stanford-Online/configuration","forks_url":"https://api.github.com/repos/Stanford-Online/configuration/forks","keys_url":"https://api.github.com/repos/Stanford-Online/configuration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Stanford-Online/configuration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Stanford-Online/configuration/teams","hooks_url":"https://api.github.com/repos/Stanford-Online/configuration/hooks","issue_events_url":"https://api.github.com/repos/Stanford-Online/configuration/issues/events{/number}","events_url":"https://api.github.com/repos/Stanford-Online/configuration/events","assignees_url":"https://api.github.com/repos/Stanford-Online/configuration/assignees{/user}","branches_url":"https://api.github.com/repos/Stanford-Online/configuration/branches{/branch}","tags_url":"https://api.github.com/repos/Stanford-Online/configuration/tags","blobs_url":"https://api.github.com/repos/Stanford-Online/configuration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Stanford-Online/configuration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Stanford-Online/configuration/git/refs{/sha}","trees_url":"https://api.github.com/repos/Stanford-Online/configuration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Stanford-Online/configuration/statuses/{sha}","languages_url":"https://api.github.com/repos/Stanford-Online/configuration/languages","stargazers_url":"https://api.github.com/repos/Stanford-Online/configuration/stargazers","contributors_url":"https://api.github.com/repos/Stanford-Online/configuration/contributors","subscribers_url":"https://api.github.com/repos/Stanford-Online/configuration/subscribers","subscription_url":"https://api.github.com/repos/Stanford-Online/configuration/subscription","commits_url":"https://api.github.com/repos/Stanford-Online/configuration/commits{/sha}","git_commits_url":"https://api.github.com/repos/Stanford-Online/configuration/git/commits{/sha}","comments_url":"https://api.github.com/repos/Stanford-Online/configuration/comments{/number}","issue_comment_url":"https://api.github.com/repos/Stanford-Online/configuration/issues/comments{/number}","contents_url":"https://api.github.com/repos/Stanford-Online/configuration/contents/{+path}","compare_url":"https://api.github.com/repos/Stanford-Online/configuration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Stanford-Online/configuration/merges","archive_url":"https://api.github.com/repos/Stanford-Online/configuration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Stanford-Online/configuration/downloads","issues_url":"https://api.github.com/repos/Stanford-Online/configuration/issues{/number}","pulls_url":"https://api.github.com/repos/Stanford-Online/configuration/pulls{/number}","milestones_url":"https://api.github.com/repos/Stanford-Online/configuration/milestones{/number}","notifications_url":"https://api.github.com/repos/Stanford-Online/configuration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Stanford-Online/configuration/labels{/name}","releases_url":"https://api.github.com/repos/Stanford-Online/configuration/releases{/id}","deployments_url":"https://api.github.com/repos/Stanford-Online/configuration/deployments","created_at":"2014-06-17T00:24:26Z","updated_at":"2017-09-15T02:19:19Z","pushed_at":"2018-02-12T19:12:34Z","git_url":"git://github.com/Stanford-Online/configuration.git","ssh_url":"git@github.com:Stanford-Online/configuration.git","clone_url":"https://github.com/Stanford-Online/configuration.git","svn_url":"https://github.com/Stanford-Online/configuration","homepage":"","size":13038,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":8,"open_issues":13,"watchers":0,"default_branch":"master"}},"base":{"label":"Stanford-Online:master","ref":"master","sha":"d97a89d81743c29cd8353d9f482e9384c01b4d50","user":{"login":"Stanford-Online","id":2159497,"avatar_url":"https://avatars3.githubusercontent.com/u/2159497?v=4","gravatar_id":"","url":"https://api.github.com/users/Stanford-Online","html_url":"https://github.com/Stanford-Online","followers_url":"https://api.github.com/users/Stanford-Online/followers","following_url":"https://api.github.com/users/Stanford-Online/following{/other_user}","gists_url":"https://api.github.com/users/Stanford-Online/gists{/gist_id}","starred_url":"https://api.github.com/users/Stanford-Online/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stanford-Online/subscriptions","organizations_url":"https://api.github.com/users/Stanford-Online/orgs","repos_url":"https://api.github.com/users/Stanford-Online/repos","events_url":"https://api.github.com/users/Stanford-Online/events{/privacy}","received_events_url":"https://api.github.com/users/Stanford-Online/received_events","type":"Organization","site_admin":false},"repo":{"id":20904958,"name":"configuration","full_name":"Stanford-Online/configuration","owner":{"login":"Stanford-Online","id":2159497,"avatar_url":"https://avatars3.githubusercontent.com/u/2159497?v=4","gravatar_id":"","url":"https://api.github.com/users/Stanford-Online","html_url":"https://github.com/Stanford-Online","followers_url":"https://api.github.com/users/Stanford-Online/followers","following_url":"https://api.github.com/users/Stanford-Online/following{/other_user}","gists_url":"https://api.github.com/users/Stanford-Online/gists{/gist_id}","starred_url":"https://api.github.com/users/Stanford-Online/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stanford-Online/subscriptions","organizations_url":"https://api.github.com/users/Stanford-Online/orgs","repos_url":"https://api.github.com/users/Stanford-Online/repos","events_url":"https://api.github.com/users/Stanford-Online/events{/privacy}","received_events_url":"https://api.github.com/users/Stanford-Online/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Stanford-Online/configuration","description":"a simple, but flexible, way for anyone to stand up an instance of the edX platform that is fully configured and ready-to-go","fork":true,"url":"https://api.github.com/repos/Stanford-Online/configuration","forks_url":"https://api.github.com/repos/Stanford-Online/configuration/forks","keys_url":"https://api.github.com/repos/Stanford-Online/configuration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Stanford-Online/configuration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Stanford-Online/configuration/teams","hooks_url":"https://api.github.com/repos/Stanford-Online/configuration/hooks","issue_events_url":"https://api.github.com/repos/Stanford-Online/configuration/issues/events{/number}","events_url":"https://api.github.com/repos/Stanford-Online/configuration/events","assignees_url":"https://api.github.com/repos/Stanford-Online/configuration/assignees{/user}","branches_url":"https://api.github.com/repos/Stanford-Online/configuration/branches{/branch}","tags_url":"https://api.github.com/repos/Stanford-Online/configuration/tags","blobs_url":"https://api.github.com/repos/Stanford-Online/configuration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Stanford-Online/configuration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Stanford-Online/configuration/git/refs{/sha}","trees_url":"https://api.github.com/repos/Stanford-Online/configuration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Stanford-Online/configuration/statuses/{sha}","languages_url":"https://api.github.com/repos/Stanford-Online/configuration/languages","stargazers_url":"https://api.github.com/repos/Stanford-Online/configuration/stargazers","contributors_url":"https://api.github.com/repos/Stanford-Online/configuration/contributors","subscribers_url":"https://api.github.com/repos/Stanford-Online/configuration/subscribers","subscription_url":"https://api.github.com/repos/Stanford-Online/configuration/subscription","commits_url":"https://api.github.com/repos/Stanford-Online/configuration/commits{/sha}","git_commits_url":"https://api.github.com/repos/Stanford-Online/configuration/git/commits{/sha}","comments_url":"https://api.github.com/repos/Stanford-Online/configuration/comments{/number}","issue_comment_url":"https://api.github.com/repos/Stanford-Online/configuration/issues/comments{/number}","contents_url":"https://api.github.com/repos/Stanford-Online/configuration/contents/{+path}","compare_url":"https://api.github.com/repos/Stanford-Online/configuration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Stanford-Online/configuration/merges","archive_url":"https://api.github.com/repos/Stanford-Online/configuration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Stanford-Online/configuration/downloads","issues_url":"https://api.github.com/repos/Stanford-Online/configuration/issues{/number}","pulls_url":"https://api.github.com/repos/Stanford-Online/configuration/pulls{/number}","milestones_url":"https://api.github.com/repos/Stanford-Online/configuration/milestones{/number}","notifications_url":"https://api.github.com/repos/Stanford-Online/configuration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Stanford-Online/configuration/labels{/name}","releases_url":"https://api.github.com/repos/Stanford-Online/configuration/releases{/id}","deployments_url":"https://api.github.com/repos/Stanford-Online/configuration/deployments","created_at":"2014-06-17T00:24:26Z","updated_at":"2017-09-15T02:19:19Z","pushed_at":"2018-02-12T19:12:34Z","git_url":"git://github.com/Stanford-Online/configuration.git","ssh_url":"git@github.com:Stanford-Online/configuration.git","clone_url":"https://github.com/Stanford-Online/configuration.git","svn_url":"https://github.com/Stanford-Online/configuration","homepage":"","size":13038,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":8,"open_issues":13,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Stanford-Online/configuration/pulls/219"},"html":{"href":"https://github.com/Stanford-Online/configuration/pull/219"},"issue":{"href":"https://api.github.com/repos/Stanford-Online/configuration/issues/219"},"comments":{"href":"https://api.github.com/repos/Stanford-Online/configuration/issues/219/comments"},"review_comments":{"href":"https://api.github.com/repos/Stanford-Online/configuration/pulls/219/comments"},"review_comment":{"href":"https://api.github.com/repos/Stanford-Online/configuration/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Stanford-Online/configuration/pulls/219/commits"},"statuses":{"href":"https://api.github.com/repos/Stanford-Online/configuration/statuses/f894fe973ac8468441dfcac1665974cb872d4ad3"}},"author_association":"OWNER"}}
{"actor":{"display_login":"stvstnfrd"}}