{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/63437","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/63437/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/63437/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/63437/events","html_url":"https://github.com/kubernetes/kubernetes/pull/63437","id":320324985,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg2MDIxODcz","number":63437,"title":"fix #51135 make CFS quota period configurable","user":{"login":"szuecs","id":50872,"node_id":"MDQ6VXNlcjUwODcy","avatar_url":"https://avatars2.githubusercontent.com/u/50872?v=4","gravatar_id":"","url":"https://api.github.com/users/szuecs","html_url":"https://github.com/szuecs","followers_url":"https://api.github.com/users/szuecs/followers","following_url":"https://api.github.com/users/szuecs/following{/other_user}","gists_url":"https://api.github.com/users/szuecs/gists{/gist_id}","starred_url":"https://api.github.com/users/szuecs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szuecs/subscriptions","organizations_url":"https://api.github.com/users/szuecs/orgs","repos_url":"https://api.github.com/users/szuecs/repos","events_url":"https://api.github.com/users/szuecs/events{/privacy}","received_events_url":"https://api.github.com/users/szuecs/received_events","type":"User","site_admin":false},"labels":[{"id":414883982,"node_id":"MDU6TGFiZWw0MTQ4ODM5ODI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":451459590,"node_id":"MDU6TGFiZWw0NTE0NTk1OTA=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/kubeadm","name":"area/kubeadm","color":"0052cc","default":false},{"id":116719829,"node_id":"MDU6TGFiZWwxMTY3MTk4Mjk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/kubelet","name":"area/kubelet","color":"0052cc","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":267761362,"node_id":"MDU6TGFiZWwyNjc3NjEzNjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/feature","name":"kind/feature","color":"c7def8","default":false},{"id":114528223,"node_id":"MDU6TGFiZWwxMTQ1MjgyMjM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/important-soon","name":"priority/important-soon","color":"eb6420","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":173494222,"node_id":"MDU6TGFiZWwxNzM0OTQyMjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/cluster-lifecycle","name":"sig/cluster-lifecycle","color":"d2b48c","default":false},{"id":173493665,"node_id":"MDU6TGFiZWwxNzM0OTM2NjU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/node","name":"sig/node","color":"d2b48c","default":false},{"id":125550211,"node_id":"MDU6TGFiZWwxMjU1NTAyMTE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/scheduling","name":"sig/scheduling","color":"d2b48c","default":false},{"id":253451057,"node_id":"MDU6TGFiZWwyNTM0NTEwNTc=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XL","name":"size/XL","color":"ee5500","default":false},{"id":611767149,"node_id":"MDU6TGFiZWw2MTE3NjcxNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/status/approved-for-milestone","name":"status/approved-for-milestone","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":{"login":"dims","id":23304,"node_id":"MDQ6VXNlcjIzMzA0","avatar_url":"https://avatars2.githubusercontent.com/u/23304?v=4","gravatar_id":"","url":"https://api.github.com/users/dims","html_url":"https://github.com/dims","followers_url":"https://api.github.com/users/dims/followers","following_url":"https://api.github.com/users/dims/following{/other_user}","gists_url":"https://api.github.com/users/dims/gists{/gist_id}","starred_url":"https://api.github.com/users/dims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dims/subscriptions","organizations_url":"https://api.github.com/users/dims/orgs","repos_url":"https://api.github.com/users/dims/repos","events_url":"https://api.github.com/users/dims/events{/privacy}","received_events_url":"https://api.github.com/users/dims/received_events","type":"User","site_admin":false},"assignees":[{"login":"dims","id":23304,"node_id":"MDQ6VXNlcjIzMzA0","avatar_url":"https://avatars2.githubusercontent.com/u/23304?v=4","gravatar_id":"","url":"https://api.github.com/users/dims","html_url":"https://github.com/dims","followers_url":"https://api.github.com/users/dims/followers","following_url":"https://api.github.com/users/dims/following{/other_user}","gists_url":"https://api.github.com/users/dims/gists{/gist_id}","starred_url":"https://api.github.com/users/dims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dims/subscriptions","organizations_url":"https://api.github.com/users/dims/orgs","repos_url":"https://api.github.com/users/dims/repos","events_url":"https://api.github.com/users/dims/events{/privacy}","received_events_url":"https://api.github.com/users/dims/received_events","type":"User","site_admin":false},{"login":"Random-Liu","id":5821883,"node_id":"MDQ6VXNlcjU4MjE4ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/5821883?v=4","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false},{"login":"derekwaynecarr","id":6233452,"node_id":"MDQ6VXNlcjYyMzM0NTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6233452?v=4","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false},{"login":"vishh","id":7063592,"node_id":"MDQ6VXNlcjcwNjM1OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/7063592?v=4","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false},{"login":"yujuhong","id":10524058,"node_id":"MDQ6VXNlcjEwNTI0MDU4","avatar_url":"https://avatars1.githubusercontent.com/u/10524058?v=4","gravatar_id":"","url":"https://api.github.com/users/yujuhong","html_url":"https://github.com/yujuhong","followers_url":"https://api.github.com/users/yujuhong/followers","following_url":"https://api.github.com/users/yujuhong/following{/other_user}","gists_url":"https://api.github.com/users/yujuhong/gists{/gist_id}","starred_url":"https://api.github.com/users/yujuhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yujuhong/subscriptions","organizations_url":"https://api.github.com/users/yujuhong/orgs","repos_url":"https://api.github.com/users/yujuhong/repos","events_url":"https://api.github.com/users/yujuhong/events{/privacy}","received_events_url":"https://api.github.com/users/yujuhong/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/39","html_url":"https://github.com/kubernetes/kubernetes/milestone/39","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/39/labels","id":2913712,"node_id":"MDk6TWlsZXN0b25lMjkxMzcxMg==","number":39,"title":"v1.12","description":"","creator":{"login":"thockin","id":5595220,"node_id":"MDQ6VXNlcjU1OTUyMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/5595220?v=4","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"open_issues":105,"closed_issues":99,"state":"open","created_at":"2017-11-15T06:32:51Z","updated_at":"2018-08-31T15:26:05Z","due_on":null,"closed_at":null},"comments":63,"created_at":"2018-05-04T15:44:57Z","updated_at":"2018-08-31T15:55:46Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63437","html_url":"https://github.com/kubernetes/kubernetes/pull/63437","diff_url":"https://github.com/kubernetes/kubernetes/pull/63437.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/63437.patch"},"body":"**What this PR does / why we need it**:\r\n\r\nThis PR makes it possible for users to change CFS quota period from the default 100ms to some other value between 1µs and 1s.\r\n#51135 shows that multiple production users have serious issues running reasonable workloads in kubernetes. The latency added by the 100ms CFS quota period is adding way too much time.\r\n\r\n**Which issue(s) this PR fixes**:\r\nFixes #51135 \r\n\r\n**Special notes for your reviewer**:\r\n- 5ms is used by user experience https://github.com/kubernetes/kubernetes/issues/51135#issuecomment-384908627\r\n- Latency added caused by CFS 100ms is shown at https://github.com/kubernetes/kubernetes/issues/51135#issuecomment-373454012\r\n- explanation why we should not disable limits https://github.com/kubernetes/kubernetes/issues/51135#issuecomment-385346661\r\n- agreement found at kubecon EU 2018: https://github.com/kubernetes/kubernetes/issues/51135#issuecomment-386623964\r\n\r\n**Release note**:\r\n```release-note\r\nAdds a kubelet parameter and config option to change CFS quota period from the default 100ms to some other value between 1µs and 1s. This was done to improve response latencies for workloads running in clusters with guaranteed and burstable QoS classes.  \r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/417708908","html_url":"https://github.com/kubernetes/kubernetes/pull/63437#issuecomment-417708908","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/63437","id":417708908,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzcwODkwOA==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-08-31T15:55:46Z","updated_at":"2018-08-31T15:55:46Z","author_association":"NONE","body":"@szuecs: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-local-e2e | 0a3c4dbc6c8fd43ade794aa7a5cd8fa0bc251637 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/63437/pull-kubernetes-local-e2e/284/) | `/test pull-kubernetes-local-e2e`\npull-kubernetes-verify | 7228a3f4d34222611b72579e653b7491a6deeec2 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/63437/pull-kubernetes-verify/105111/) | `/test pull-kubernetes-verify`\npull-kubernetes-node-e2e | b7ae4e58f4edd4cccc14692544b8c4cee11a369a | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/63437/pull-kubernetes-node-e2e/102979/) | `/test pull-kubernetes-node-e2e`\npull-kubernetes-e2e-gce-100-performance | b7ae4e58f4edd4cccc14692544b8c4cee11a369a | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/63437/pull-kubernetes-e2e-gce-100-performance/18810/) | `/test pull-kubernetes-e2e-gce-100-performance`\npull-kubernetes-local-e2e-containerized | b7ae4e58f4edd4cccc14692544b8c4cee11a369a | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/63437/pull-kubernetes-local-e2e-containerized/2462/) | `/test pull-kubernetes-local-e2e-containerized`\npull-kubernetes-kubemark-e2e-gce-big | b7ae4e58f4edd4cccc14692544b8c4cee11a369a | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/63437/pull-kubernetes-kubemark-e2e-gce-big/20725/) | `/test pull-kubernetes-kubemark-e2e-gce-big`\npull-kubernetes-bazel-build | 437fa83dd4201392bf7161a8c235c90a386047f9 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/63437/pull-kubernetes-bazel-build/56480/) | `/test pull-kubernetes-bazel-build`\npull-kubernetes-e2e-gce | 437fa83dd4201392bf7161a8c235c90a386047f9 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/63437/pull-kubernetes-e2e-gce/51125/) | `/test pull-kubernetes-e2e-gce`\npull-kubernetes-e2e-gce-device-plugin-gpu | 437fa83dd4201392bf7161a8c235c90a386047f9 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/63437/pull-kubernetes-e2e-gce-device-plugin-gpu/46287/) | `/test pull-kubernetes-e2e-gce-device-plugin-gpu`\npull-kubernetes-e2e-kops-aws | 437fa83dd4201392bf7161a8c235c90a386047f9 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/63437/pull-kubernetes-e2e-kops-aws/104369/) | `/test pull-kubernetes-e2e-kops-aws`\npull-kubernetes-bazel-test | 437fa83dd4201392bf7161a8c235c90a386047f9 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/63437/pull-kubernetes-bazel-test/59026/) | `/test pull-kubernetes-bazel-test`\npull-kubernetes-typecheck | 437fa83dd4201392bf7161a8c235c90a386047f9 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/63437/pull-kubernetes-typecheck/23298/) | `/test pull-kubernetes-typecheck`\npull-kubernetes-integration | 437fa83dd4201392bf7161a8c235c90a386047f9 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/63437/pull-kubernetes-integration/26083/) | `/test pull-kubernetes-integration`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/63437). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/szuecs). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}