{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/241936005","pull_request_review_id":185340195,"id":241936005,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTkzNjAwNQ==","diff_hunk":"@@ -2831,7 +2831,23 @@ namespace {\n     }\n \n     Expr *visitTupleExpr(TupleExpr *expr) {\n-      return simplifyExprType(expr);\n+      auto toType = simplifyType(cs.getType(expr))->castTo<TupleType>();","path":"lib/Sema/CSApply.cpp","position":5,"original_position":5,"commit_id":"4b033ac6571110ad177f9db69f54fe9d7de9b3c0","original_commit_id":"ea22115dc8c2cf0935aa61b1efc93a8e37a6e16b","user":{"login":"xedin","id":21240,"node_id":"MDQ6VXNlcjIxMjQw","avatar_url":"https://avatars1.githubusercontent.com/u/21240?v=4","gravatar_id":"","url":"https://api.github.com/users/xedin","html_url":"https://github.com/xedin","followers_url":"https://api.github.com/users/xedin/followers","following_url":"https://api.github.com/users/xedin/following{/other_user}","gists_url":"https://api.github.com/users/xedin/gists{/gist_id}","starred_url":"https://api.github.com/users/xedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xedin/subscriptions","organizations_url":"https://api.github.com/users/xedin/orgs","repos_url":"https://api.github.com/users/xedin/repos","events_url":"https://api.github.com/users/xedin/events{/privacy}","received_events_url":"https://api.github.com/users/xedin/received_events","type":"User","site_admin":false},"body":"I will take a look at coerceToTupleType thank you! But I think it’s effectively a noop when types are the same. Also I can’t come up with example to reproduce crash with paren, because it simply forwards it’s sub-expr type to wrap into paren type, there can’t be a mismatch like in case of tuple.","created_at":"2018-12-15T03:12:25Z","updated_at":"2018-12-15T03:12:25Z","html_url":"https://github.com/apple/swift/pull/21338#discussion_r241936005","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/21338","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/241936005"},"html":{"href":"https://github.com/apple/swift/pull/21338#discussion_r241936005"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/21338"}},"in_reply_to_id":241932026},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/21338","id":238879474,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4ODc5NDc0","html_url":"https://github.com/apple/swift/pull/21338","diff_url":"https://github.com/apple/swift/pull/21338.diff","patch_url":"https://github.com/apple/swift/pull/21338.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/21338","number":21338,"state":"open","locked":false,"title":"[CSApply] `ExprRewritter` has to make sure that tuple elements are of…","user":{"login":"xedin","id":21240,"node_id":"MDQ6VXNlcjIxMjQw","avatar_url":"https://avatars1.githubusercontent.com/u/21240?v=4","gravatar_id":"","url":"https://api.github.com/users/xedin","html_url":"https://github.com/xedin","followers_url":"https://api.github.com/users/xedin/followers","following_url":"https://api.github.com/users/xedin/following{/other_user}","gists_url":"https://api.github.com/users/xedin/gists{/gist_id}","starred_url":"https://api.github.com/users/xedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xedin/subscriptions","organizations_url":"https://api.github.com/users/xedin/orgs","repos_url":"https://api.github.com/users/xedin/repos","events_url":"https://api.github.com/users/xedin/events{/privacy}","received_events_url":"https://api.github.com/users/xedin/received_events","type":"User","site_admin":false},"body":"… expected type\r\n\r\nProblem exposed by SE-0230 - `Flatten nested optionals resulting from 'try?'`\r\n\r\nExample:\r\n\r\n```swift\r\nprotocol P : class {}\r\n\r\nclass F<T> {\r\n  func wait() throws -> T { fatalError() }\r\n}\r\n\r\nfunc bar(_ a: F<P>, _ b: F<P>) throws {\r\n  _ = (try? a.wait()) === (try? b.wait())\r\n}\r\n```\r\n\r\nHere result of `try? {a, b}.wait()` used to be inferred to `P` because\r\nof `OptionalObject` constraint connecting type of `{a, b}.wait()` with\r\n`try?`. Since `OptionalObject` has been replaced with `Conversion`\r\nconstraint to avoid introducing new level of optionality it creates\r\na side-effect of inferring type of `try?` to be `AnyObject?` which\r\ncomes from parameter-to-argument conversion.\r\n\r\nResolves: rdar://problem/46742002\r\n\r\n<!--\r\nBefore merging this pull request, you must run the Swift continuous integration tests.\r\nFor information about triggering CI builds via @swift-ci, see:\r\nhttps://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci\r\n\r\nThank you for your contribution to Swift!\r\n-->\r\n","created_at":"2018-12-15T00:59:08Z","updated_at":"2018-12-15T03:12:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f17efe8e9a781eb40ca838b269e06c34ce052485","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/21338/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/21338/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/21338/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/4b033ac6571110ad177f9db69f54fe9d7de9b3c0","head":{"label":"xedin:rdar-46742002","ref":"rdar-46742002","sha":"4b033ac6571110ad177f9db69f54fe9d7de9b3c0","user":{"login":"xedin","id":21240,"node_id":"MDQ6VXNlcjIxMjQw","avatar_url":"https://avatars1.githubusercontent.com/u/21240?v=4","gravatar_id":"","url":"https://api.github.com/users/xedin","html_url":"https://github.com/xedin","followers_url":"https://api.github.com/users/xedin/followers","following_url":"https://api.github.com/users/xedin/following{/other_user}","gists_url":"https://api.github.com/users/xedin/gists{/gist_id}","starred_url":"https://api.github.com/users/xedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xedin/subscriptions","organizations_url":"https://api.github.com/users/xedin/orgs","repos_url":"https://api.github.com/users/xedin/repos","events_url":"https://api.github.com/users/xedin/events{/privacy}","received_events_url":"https://api.github.com/users/xedin/received_events","type":"User","site_admin":false},"repo":{"id":66491687,"node_id":"MDEwOlJlcG9zaXRvcnk2NjQ5MTY4Nw==","name":"swift","full_name":"xedin/swift","private":false,"owner":{"login":"xedin","id":21240,"node_id":"MDQ6VXNlcjIxMjQw","avatar_url":"https://avatars1.githubusercontent.com/u/21240?v=4","gravatar_id":"","url":"https://api.github.com/users/xedin","html_url":"https://github.com/xedin","followers_url":"https://api.github.com/users/xedin/followers","following_url":"https://api.github.com/users/xedin/following{/other_user}","gists_url":"https://api.github.com/users/xedin/gists{/gist_id}","starred_url":"https://api.github.com/users/xedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xedin/subscriptions","organizations_url":"https://api.github.com/users/xedin/orgs","repos_url":"https://api.github.com/users/xedin/repos","events_url":"https://api.github.com/users/xedin/events{/privacy}","received_events_url":"https://api.github.com/users/xedin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xedin/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/xedin/swift","forks_url":"https://api.github.com/repos/xedin/swift/forks","keys_url":"https://api.github.com/repos/xedin/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xedin/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xedin/swift/teams","hooks_url":"https://api.github.com/repos/xedin/swift/hooks","issue_events_url":"https://api.github.com/repos/xedin/swift/issues/events{/number}","events_url":"https://api.github.com/repos/xedin/swift/events","assignees_url":"https://api.github.com/repos/xedin/swift/assignees{/user}","branches_url":"https://api.github.com/repos/xedin/swift/branches{/branch}","tags_url":"https://api.github.com/repos/xedin/swift/tags","blobs_url":"https://api.github.com/repos/xedin/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xedin/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xedin/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/xedin/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xedin/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/xedin/swift/languages","stargazers_url":"https://api.github.com/repos/xedin/swift/stargazers","contributors_url":"https://api.github.com/repos/xedin/swift/contributors","subscribers_url":"https://api.github.com/repos/xedin/swift/subscribers","subscription_url":"https://api.github.com/repos/xedin/swift/subscription","commits_url":"https://api.github.com/repos/xedin/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/xedin/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/xedin/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/xedin/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/xedin/swift/contents/{+path}","compare_url":"https://api.github.com/repos/xedin/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xedin/swift/merges","archive_url":"https://api.github.com/repos/xedin/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xedin/swift/downloads","issues_url":"https://api.github.com/repos/xedin/swift/issues{/number}","pulls_url":"https://api.github.com/repos/xedin/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/xedin/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/xedin/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xedin/swift/labels{/name}","releases_url":"https://api.github.com/repos/xedin/swift/releases{/id}","deployments_url":"https://api.github.com/repos/xedin/swift/deployments","created_at":"2016-08-24T19:04:17Z","updated_at":"2016-08-24T19:04:41Z","pushed_at":"2018-12-15T01:48:18Z","git_url":"git://github.com/xedin/swift.git","ssh_url":"git@github.com:xedin/swift.git","clone_url":"https://github.com/xedin/swift.git","svn_url":"https://github.com/xedin/swift","homepage":"https://swift.org/","size":348211,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"d98b5d1fdbf841be320c99c3e5a60c4e332eec1e","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","private":false,"owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-12-15T02:51:17Z","pushed_at":"2018-12-15T02:53:13Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org","size":373617,"stargazers_count":46040,"watchers_count":46040,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7315,"mirror_url":null,"archived":false,"open_issues_count":444,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7315,"open_issues":444,"watchers":46040,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/21338"},"html":{"href":"https://github.com/apple/swift/pull/21338"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/21338"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/21338/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/21338/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/21338/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/4b033ac6571110ad177f9db69f54fe9d7de9b3c0"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"xedin"}}