{"action":"created","comment":{"url":"https://api.github.com/repos/openscad/openscad/pulls/comments/169868874","pull_request_review_id":98458068,"id":169868874,"diff_hunk":"@@ -12,9 +12,9 @@ class CGALCache\n \n \tstatic CGALCache *instance() { if (!inst) inst = new CGALCache; return inst; }\n \n-\tbool contains(const std::string &id) const { return this->cache.contains(id); }\n-\tshared_ptr<const class CGAL_Nef_polyhedron> get(const std::string &id) const;\n-\tbool insert(const std::string &id, const shared_ptr<const CGAL_Nef_polyhedron> &N);\n+\tbool contains(const size_t id) const { return this->cache.contains(id); }","path":"src/CGALCache.h","position":7,"original_position":7,"commit_id":"10ce9bdf05ebca20352943ee1395ed835d836164","original_commit_id":"10ce9bdf05ebca20352943ee1395ed835d836164","user":{"login":"kintel","id":186094,"avatar_url":"https://avatars2.githubusercontent.com/u/186094?v=4","gravatar_id":"","url":"https://api.github.com/users/kintel","html_url":"https://github.com/kintel","followers_url":"https://api.github.com/users/kintel/followers","following_url":"https://api.github.com/users/kintel/following{/other_user}","gists_url":"https://api.github.com/users/kintel/gists{/gist_id}","starred_url":"https://api.github.com/users/kintel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kintel/subscriptions","organizations_url":"https://api.github.com/users/kintel/orgs","repos_url":"https://api.github.com/users/kintel/repos","events_url":"https://api.github.com/users/kintel/events{/privacy}","received_events_url":"https://api.github.com/users/kintel/received_events","type":"User","site_admin":false},"body":"I find this slightly scary. Hashed containers are usually designed such that they gracefully handle hash collisions. In this case, it looks like we'd potentially do significant damage in case of a hash collision.","created_at":"2018-02-22T07:03:55Z","updated_at":"2018-02-22T07:14:18Z","html_url":"https://github.com/openscad/openscad/pull/2313#discussion_r169868874","pull_request_url":"https://api.github.com/repos/openscad/openscad/pulls/2313","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/openscad/openscad/pulls/comments/169868874"},"html":{"href":"https://github.com/openscad/openscad/pull/2313#discussion_r169868874"},"pull_request":{"href":"https://api.github.com/repos/openscad/openscad/pulls/2313"}}},"pull_request":{"url":"https://api.github.com/repos/openscad/openscad/pulls/2313","id":170255720,"html_url":"https://github.com/openscad/openscad/pull/2313","diff_url":"https://github.com/openscad/openscad/pull/2313.diff","patch_url":"https://github.com/openscad/openscad/pull/2313.patch","issue_url":"https://api.github.com/repos/openscad/openscad/issues/2313","number":2313,"state":"open","locked":false,"title":"Rewrite NodeCache to store single string with indices","user":{"login":"thehans","id":252233,"avatar_url":"https://avatars3.githubusercontent.com/u/252233?v=4","gravatar_id":"","url":"https://api.github.com/users/thehans","html_url":"https://github.com/thehans","followers_url":"https://api.github.com/users/thehans/followers","following_url":"https://api.github.com/users/thehans/following{/other_user}","gists_url":"https://api.github.com/users/thehans/gists{/gist_id}","starred_url":"https://api.github.com/users/thehans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thehans/subscriptions","organizations_url":"https://api.github.com/users/thehans/orgs","repos_url":"https://api.github.com/users/thehans/repos","events_url":"https://api.github.com/users/thehans/events{/privacy}","received_events_url":"https://api.github.com/users/thehans/received_events","type":"User","site_admin":false},"body":"Still WIP, trying to debug a segfault\r\nFor Issue #2303","created_at":"2018-02-20T17:17:15Z","updated_at":"2018-02-22T07:14:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a638948a293e99f7217b6880f37c3fffba47ec9c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openscad/openscad/pulls/2313/commits","review_comments_url":"https://api.github.com/repos/openscad/openscad/pulls/2313/comments","review_comment_url":"https://api.github.com/repos/openscad/openscad/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openscad/openscad/issues/2313/comments","statuses_url":"https://api.github.com/repos/openscad/openscad/statuses/10ce9bdf05ebca20352943ee1395ed835d836164","head":{"label":"thehans:issue2303","ref":"issue2303","sha":"10ce9bdf05ebca20352943ee1395ed835d836164","user":{"login":"thehans","id":252233,"avatar_url":"https://avatars3.githubusercontent.com/u/252233?v=4","gravatar_id":"","url":"https://api.github.com/users/thehans","html_url":"https://github.com/thehans","followers_url":"https://api.github.com/users/thehans/followers","following_url":"https://api.github.com/users/thehans/following{/other_user}","gists_url":"https://api.github.com/users/thehans/gists{/gist_id}","starred_url":"https://api.github.com/users/thehans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thehans/subscriptions","organizations_url":"https://api.github.com/users/thehans/orgs","repos_url":"https://api.github.com/users/thehans/repos","events_url":"https://api.github.com/users/thehans/events{/privacy}","received_events_url":"https://api.github.com/users/thehans/received_events","type":"User","site_admin":false},"repo":{"id":45902888,"name":"openscad","full_name":"thehans/openscad","owner":{"login":"thehans","id":252233,"avatar_url":"https://avatars3.githubusercontent.com/u/252233?v=4","gravatar_id":"","url":"https://api.github.com/users/thehans","html_url":"https://github.com/thehans","followers_url":"https://api.github.com/users/thehans/followers","following_url":"https://api.github.com/users/thehans/following{/other_user}","gists_url":"https://api.github.com/users/thehans/gists{/gist_id}","starred_url":"https://api.github.com/users/thehans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thehans/subscriptions","organizations_url":"https://api.github.com/users/thehans/orgs","repos_url":"https://api.github.com/users/thehans/repos","events_url":"https://api.github.com/users/thehans/events{/privacy}","received_events_url":"https://api.github.com/users/thehans/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thehans/openscad","description":"OpenSCAD - The Programmers Solid 3D CAD Modeller  ","fork":true,"url":"https://api.github.com/repos/thehans/openscad","forks_url":"https://api.github.com/repos/thehans/openscad/forks","keys_url":"https://api.github.com/repos/thehans/openscad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thehans/openscad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thehans/openscad/teams","hooks_url":"https://api.github.com/repos/thehans/openscad/hooks","issue_events_url":"https://api.github.com/repos/thehans/openscad/issues/events{/number}","events_url":"https://api.github.com/repos/thehans/openscad/events","assignees_url":"https://api.github.com/repos/thehans/openscad/assignees{/user}","branches_url":"https://api.github.com/repos/thehans/openscad/branches{/branch}","tags_url":"https://api.github.com/repos/thehans/openscad/tags","blobs_url":"https://api.github.com/repos/thehans/openscad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thehans/openscad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thehans/openscad/git/refs{/sha}","trees_url":"https://api.github.com/repos/thehans/openscad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thehans/openscad/statuses/{sha}","languages_url":"https://api.github.com/repos/thehans/openscad/languages","stargazers_url":"https://api.github.com/repos/thehans/openscad/stargazers","contributors_url":"https://api.github.com/repos/thehans/openscad/contributors","subscribers_url":"https://api.github.com/repos/thehans/openscad/subscribers","subscription_url":"https://api.github.com/repos/thehans/openscad/subscription","commits_url":"https://api.github.com/repos/thehans/openscad/commits{/sha}","git_commits_url":"https://api.github.com/repos/thehans/openscad/git/commits{/sha}","comments_url":"https://api.github.com/repos/thehans/openscad/comments{/number}","issue_comment_url":"https://api.github.com/repos/thehans/openscad/issues/comments{/number}","contents_url":"https://api.github.com/repos/thehans/openscad/contents/{+path}","compare_url":"https://api.github.com/repos/thehans/openscad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thehans/openscad/merges","archive_url":"https://api.github.com/repos/thehans/openscad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thehans/openscad/downloads","issues_url":"https://api.github.com/repos/thehans/openscad/issues{/number}","pulls_url":"https://api.github.com/repos/thehans/openscad/pulls{/number}","milestones_url":"https://api.github.com/repos/thehans/openscad/milestones{/number}","notifications_url":"https://api.github.com/repos/thehans/openscad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thehans/openscad/labels{/name}","releases_url":"https://api.github.com/repos/thehans/openscad/releases{/id}","deployments_url":"https://api.github.com/repos/thehans/openscad/deployments","created_at":"2015-11-10T09:52:53Z","updated_at":"2017-07-15T00:54:27Z","pushed_at":"2018-02-22T02:59:39Z","git_url":"git://github.com/thehans/openscad.git","ssh_url":"git@github.com:thehans/openscad.git","clone_url":"https://github.com/thehans/openscad.git","svn_url":"https://github.com/thehans/openscad","homepage":"openscad.org","size":46759,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openscad:master","ref":"master","sha":"a175d3a7e0ca6fd1de269f20e44cf2ccee1664fb","user":{"login":"openscad","id":466370,"avatar_url":"https://avatars1.githubusercontent.com/u/466370?v=4","gravatar_id":"","url":"https://api.github.com/users/openscad","html_url":"https://github.com/openscad","followers_url":"https://api.github.com/users/openscad/followers","following_url":"https://api.github.com/users/openscad/following{/other_user}","gists_url":"https://api.github.com/users/openscad/gists{/gist_id}","starred_url":"https://api.github.com/users/openscad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openscad/subscriptions","organizations_url":"https://api.github.com/users/openscad/orgs","repos_url":"https://api.github.com/users/openscad/repos","events_url":"https://api.github.com/users/openscad/events{/privacy}","received_events_url":"https://api.github.com/users/openscad/received_events","type":"Organization","site_admin":false},"repo":{"id":1049088,"name":"openscad","full_name":"openscad/openscad","owner":{"login":"openscad","id":466370,"avatar_url":"https://avatars1.githubusercontent.com/u/466370?v=4","gravatar_id":"","url":"https://api.github.com/users/openscad","html_url":"https://github.com/openscad","followers_url":"https://api.github.com/users/openscad/followers","following_url":"https://api.github.com/users/openscad/following{/other_user}","gists_url":"https://api.github.com/users/openscad/gists{/gist_id}","starred_url":"https://api.github.com/users/openscad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openscad/subscriptions","organizations_url":"https://api.github.com/users/openscad/orgs","repos_url":"https://api.github.com/users/openscad/repos","events_url":"https://api.github.com/users/openscad/events{/privacy}","received_events_url":"https://api.github.com/users/openscad/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openscad/openscad","description":"OpenSCAD - The Programmers Solid 3D CAD Modeller  ","fork":false,"url":"https://api.github.com/repos/openscad/openscad","forks_url":"https://api.github.com/repos/openscad/openscad/forks","keys_url":"https://api.github.com/repos/openscad/openscad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openscad/openscad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openscad/openscad/teams","hooks_url":"https://api.github.com/repos/openscad/openscad/hooks","issue_events_url":"https://api.github.com/repos/openscad/openscad/issues/events{/number}","events_url":"https://api.github.com/repos/openscad/openscad/events","assignees_url":"https://api.github.com/repos/openscad/openscad/assignees{/user}","branches_url":"https://api.github.com/repos/openscad/openscad/branches{/branch}","tags_url":"https://api.github.com/repos/openscad/openscad/tags","blobs_url":"https://api.github.com/repos/openscad/openscad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openscad/openscad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openscad/openscad/git/refs{/sha}","trees_url":"https://api.github.com/repos/openscad/openscad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openscad/openscad/statuses/{sha}","languages_url":"https://api.github.com/repos/openscad/openscad/languages","stargazers_url":"https://api.github.com/repos/openscad/openscad/stargazers","contributors_url":"https://api.github.com/repos/openscad/openscad/contributors","subscribers_url":"https://api.github.com/repos/openscad/openscad/subscribers","subscription_url":"https://api.github.com/repos/openscad/openscad/subscription","commits_url":"https://api.github.com/repos/openscad/openscad/commits{/sha}","git_commits_url":"https://api.github.com/repos/openscad/openscad/git/commits{/sha}","comments_url":"https://api.github.com/repos/openscad/openscad/comments{/number}","issue_comment_url":"https://api.github.com/repos/openscad/openscad/issues/comments{/number}","contents_url":"https://api.github.com/repos/openscad/openscad/contents/{+path}","compare_url":"https://api.github.com/repos/openscad/openscad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openscad/openscad/merges","archive_url":"https://api.github.com/repos/openscad/openscad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openscad/openscad/downloads","issues_url":"https://api.github.com/repos/openscad/openscad/issues{/number}","pulls_url":"https://api.github.com/repos/openscad/openscad/pulls{/number}","milestones_url":"https://api.github.com/repos/openscad/openscad/milestones{/number}","notifications_url":"https://api.github.com/repos/openscad/openscad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openscad/openscad/labels{/name}","releases_url":"https://api.github.com/repos/openscad/openscad/releases{/id}","deployments_url":"https://api.github.com/repos/openscad/openscad/deployments","created_at":"2010-11-03T20:25:33Z","updated_at":"2018-02-22T06:50:11Z","pushed_at":"2018-02-22T02:59:41Z","git_url":"git://github.com/openscad/openscad.git","ssh_url":"git@github.com:openscad/openscad.git","clone_url":"https://github.com/openscad/openscad.git","svn_url":"https://github.com/openscad/openscad","homepage":"openscad.org","size":47985,"stargazers_count":1996,"watchers_count":1996,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":522,"mirror_url":null,"archived":false,"open_issues_count":584,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":522,"open_issues":584,"watchers":1996,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openscad/openscad/pulls/2313"},"html":{"href":"https://github.com/openscad/openscad/pull/2313"},"issue":{"href":"https://api.github.com/repos/openscad/openscad/issues/2313"},"comments":{"href":"https://api.github.com/repos/openscad/openscad/issues/2313/comments"},"review_comments":{"href":"https://api.github.com/repos/openscad/openscad/pulls/2313/comments"},"review_comment":{"href":"https://api.github.com/repos/openscad/openscad/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openscad/openscad/pulls/2313/commits"},"statuses":{"href":"https://api.github.com/repos/openscad/openscad/statuses/10ce9bdf05ebca20352943ee1395ed835d836164"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kintel"}}