{"action":"created","comment":{"url":"https://api.github.com/repos/cginternals/webgl-operate/pulls/comments/234536057","pull_request_review_id":176194051,"id":234536057,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDUzNjA1Nw==","diff_hunk":"@@ -13,7 +13,7 @@ window.onload = function () {\n     aboutCode = window.document.getElementById('context-about');\n     aboutCode.innerText = context.aboutString();\n \n-    canvas.controller.multiFrameNumber = 8;\n+    canvas.controller.multiFrameNumber = 1;","path":"website/js/website.js","position":5,"original_position":5,"commit_id":"aeb1be0a86bb54710e0f780d4abc5355a5214fe6","original_commit_id":"aeb1be0a86bb54710e0f780d4abc5355a5214fe6","user":{"login":"cgcostume","id":3909980,"node_id":"MDQ6VXNlcjM5MDk5ODA=","avatar_url":"https://avatars1.githubusercontent.com/u/3909980?v=4","gravatar_id":"","url":"https://api.github.com/users/cgcostume","html_url":"https://github.com/cgcostume","followers_url":"https://api.github.com/users/cgcostume/followers","following_url":"https://api.github.com/users/cgcostume/following{/other_user}","gists_url":"https://api.github.com/users/cgcostume/gists{/gist_id}","starred_url":"https://api.github.com/users/cgcostume/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgcostume/subscriptions","organizations_url":"https://api.github.com/users/cgcostume/orgs","repos_url":"https://api.github.com/users/cgcostume/repos","events_url":"https://api.github.com/users/cgcostume/events{/privacy}","received_events_url":"https://api.github.com/users/cgcostume/received_events","type":"User","site_admin":false},"body":"debug session and ok for now, since the default example is always adjusted to its current needs","created_at":"2018-11-19T09:01:28Z","updated_at":"2018-11-19T09:01:28Z","html_url":"https://github.com/cginternals/webgl-operate/pull/147#discussion_r234536057","pull_request_url":"https://api.github.com/repos/cginternals/webgl-operate/pulls/147","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cginternals/webgl-operate/pulls/comments/234536057"},"html":{"href":"https://github.com/cginternals/webgl-operate/pull/147#discussion_r234536057"},"pull_request":{"href":"https://api.github.com/repos/cginternals/webgl-operate/pulls/147"}},"in_reply_to_id":234532489},"pull_request":{"url":"https://api.github.com/repos/cginternals/webgl-operate/pulls/147","id":231265213,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMjY1MjEz","html_url":"https://github.com/cginternals/webgl-operate/pull/147","diff_url":"https://github.com/cginternals/webgl-operate/pull/147.diff","patch_url":"https://github.com/cginternals/webgl-operate/pull/147.patch","issue_url":"https://api.github.com/repos/cginternals/webgl-operate/issues/147","number":147,"state":"open","locked":false,"title":"refined labeling","user":{"login":"cgcostume","id":3909980,"node_id":"MDQ6VXNlcjM5MDk5ODA=","avatar_url":"https://avatars1.githubusercontent.com/u/3909980?v=4","gravatar_id":"","url":"https://api.github.com/users/cgcostume","html_url":"https://github.com/cgcostume","followers_url":"https://api.github.com/users/cgcostume/followers","following_url":"https://api.github.com/users/cgcostume/following{/other_user}","gists_url":"https://api.github.com/users/cgcostume/gists{/gist_id}","starred_url":"https://api.github.com/users/cgcostume/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgcostume/subscriptions","organizations_url":"https://api.github.com/users/cgcostume/orgs","repos_url":"https://api.github.com/users/cgcostume/repos","events_url":"https://api.github.com/users/cgcostume/events{/privacy}","received_events_url":"https://api.github.com/users/cgcostume/received_events","type":"User","site_admin":false},"body":"* [x] dynamic labels are transformed statically and dynamically\r\n* [x] the dynamic transformations is set per label as uniform\r\n* [x] dynamic labels are not drawn with single call but dispatched per label (in order to change uniforms)\r\n* [x] labels themselves must decide where to put a all relevant transforms, e.g., a 2d screenspace label with size in pt will use static baking and re-typesetting etc. when frame size changes - the dynamic label can provide an additional scale that is applied in the vertex shader. No typesetting required.\r\n* [x] decided against instanced with texture lookup (16 float32 texel fetches with no easy fallback for ie11)\r\n* [x] issues to be fixed: macOS safari label rendering (also ie11)\r\n* [x] major memory/perf improvement, since for now, typeset results are cached and computed in-place instead of multiple vertex to vec to vertex to float32 conversions.","created_at":"2018-11-15T16:54:02Z","updated_at":"2018-11-19T09:01:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac9b8a464b678d7adbcb1b983b3ad3174c2ff71a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cginternals/webgl-operate/pulls/147/commits","review_comments_url":"https://api.github.com/repos/cginternals/webgl-operate/pulls/147/comments","review_comment_url":"https://api.github.com/repos/cginternals/webgl-operate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cginternals/webgl-operate/issues/147/comments","statuses_url":"https://api.github.com/repos/cginternals/webgl-operate/statuses/aeb1be0a86bb54710e0f780d4abc5355a5214fe6","head":{"label":"cginternals:refine-label-rendering","ref":"refine-label-rendering","sha":"aeb1be0a86bb54710e0f780d4abc5355a5214fe6","user":{"login":"cginternals","id":13125552,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTI1NTUy","avatar_url":"https://avatars2.githubusercontent.com/u/13125552?v=4","gravatar_id":"","url":"https://api.github.com/users/cginternals","html_url":"https://github.com/cginternals","followers_url":"https://api.github.com/users/cginternals/followers","following_url":"https://api.github.com/users/cginternals/following{/other_user}","gists_url":"https://api.github.com/users/cginternals/gists{/gist_id}","starred_url":"https://api.github.com/users/cginternals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cginternals/subscriptions","organizations_url":"https://api.github.com/users/cginternals/orgs","repos_url":"https://api.github.com/users/cginternals/repos","events_url":"https://api.github.com/users/cginternals/events{/privacy}","received_events_url":"https://api.github.com/users/cginternals/received_events","type":"Organization","site_admin":false},"repo":{"id":117073650,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcwNzM2NTA=","name":"webgl-operate","full_name":"cginternals/webgl-operate","private":false,"owner":{"login":"cginternals","id":13125552,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTI1NTUy","avatar_url":"https://avatars2.githubusercontent.com/u/13125552?v=4","gravatar_id":"","url":"https://api.github.com/users/cginternals","html_url":"https://github.com/cginternals","followers_url":"https://api.github.com/users/cginternals/followers","following_url":"https://api.github.com/users/cginternals/following{/other_user}","gists_url":"https://api.github.com/users/cginternals/gists{/gist_id}","starred_url":"https://api.github.com/users/cginternals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cginternals/subscriptions","organizations_url":"https://api.github.com/users/cginternals/orgs","repos_url":"https://api.github.com/users/cginternals/repos","events_url":"https://api.github.com/users/cginternals/events{/privacy}","received_events_url":"https://api.github.com/users/cginternals/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cginternals/webgl-operate","description":"A TypeScript based WebGL rendering framework.","fork":false,"url":"https://api.github.com/repos/cginternals/webgl-operate","forks_url":"https://api.github.com/repos/cginternals/webgl-operate/forks","keys_url":"https://api.github.com/repos/cginternals/webgl-operate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cginternals/webgl-operate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cginternals/webgl-operate/teams","hooks_url":"https://api.github.com/repos/cginternals/webgl-operate/hooks","issue_events_url":"https://api.github.com/repos/cginternals/webgl-operate/issues/events{/number}","events_url":"https://api.github.com/repos/cginternals/webgl-operate/events","assignees_url":"https://api.github.com/repos/cginternals/webgl-operate/assignees{/user}","branches_url":"https://api.github.com/repos/cginternals/webgl-operate/branches{/branch}","tags_url":"https://api.github.com/repos/cginternals/webgl-operate/tags","blobs_url":"https://api.github.com/repos/cginternals/webgl-operate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cginternals/webgl-operate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cginternals/webgl-operate/git/refs{/sha}","trees_url":"https://api.github.com/repos/cginternals/webgl-operate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cginternals/webgl-operate/statuses/{sha}","languages_url":"https://api.github.com/repos/cginternals/webgl-operate/languages","stargazers_url":"https://api.github.com/repos/cginternals/webgl-operate/stargazers","contributors_url":"https://api.github.com/repos/cginternals/webgl-operate/contributors","subscribers_url":"https://api.github.com/repos/cginternals/webgl-operate/subscribers","subscription_url":"https://api.github.com/repos/cginternals/webgl-operate/subscription","commits_url":"https://api.github.com/repos/cginternals/webgl-operate/commits{/sha}","git_commits_url":"https://api.github.com/repos/cginternals/webgl-operate/git/commits{/sha}","comments_url":"https://api.github.com/repos/cginternals/webgl-operate/comments{/number}","issue_comment_url":"https://api.github.com/repos/cginternals/webgl-operate/issues/comments{/number}","contents_url":"https://api.github.com/repos/cginternals/webgl-operate/contents/{+path}","compare_url":"https://api.github.com/repos/cginternals/webgl-operate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cginternals/webgl-operate/merges","archive_url":"https://api.github.com/repos/cginternals/webgl-operate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cginternals/webgl-operate/downloads","issues_url":"https://api.github.com/repos/cginternals/webgl-operate/issues{/number}","pulls_url":"https://api.github.com/repos/cginternals/webgl-operate/pulls{/number}","milestones_url":"https://api.github.com/repos/cginternals/webgl-operate/milestones{/number}","notifications_url":"https://api.github.com/repos/cginternals/webgl-operate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cginternals/webgl-operate/labels{/name}","releases_url":"https://api.github.com/repos/cginternals/webgl-operate/releases{/id}","deployments_url":"https://api.github.com/repos/cginternals/webgl-operate/deployments","created_at":"2018-01-11T08:44:50Z","updated_at":"2018-11-16T10:32:32Z","pushed_at":"2018-11-19T02:06:40Z","git_url":"git://github.com/cginternals/webgl-operate.git","ssh_url":"git@github.com:cginternals/webgl-operate.git","clone_url":"https://github.com/cginternals/webgl-operate.git","svn_url":"https://github.com/cginternals/webgl-operate","homepage":"https://webgl-operate.org","size":2697,"stargazers_count":21,"watchers_count":21,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":35,"watchers":21,"default_branch":"master"}},"base":{"label":"cginternals:master","ref":"master","sha":"e63a98513d5b37d8c419fe66cef6f055d40818d6","user":{"login":"cginternals","id":13125552,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTI1NTUy","avatar_url":"https://avatars2.githubusercontent.com/u/13125552?v=4","gravatar_id":"","url":"https://api.github.com/users/cginternals","html_url":"https://github.com/cginternals","followers_url":"https://api.github.com/users/cginternals/followers","following_url":"https://api.github.com/users/cginternals/following{/other_user}","gists_url":"https://api.github.com/users/cginternals/gists{/gist_id}","starred_url":"https://api.github.com/users/cginternals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cginternals/subscriptions","organizations_url":"https://api.github.com/users/cginternals/orgs","repos_url":"https://api.github.com/users/cginternals/repos","events_url":"https://api.github.com/users/cginternals/events{/privacy}","received_events_url":"https://api.github.com/users/cginternals/received_events","type":"Organization","site_admin":false},"repo":{"id":117073650,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcwNzM2NTA=","name":"webgl-operate","full_name":"cginternals/webgl-operate","private":false,"owner":{"login":"cginternals","id":13125552,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTI1NTUy","avatar_url":"https://avatars2.githubusercontent.com/u/13125552?v=4","gravatar_id":"","url":"https://api.github.com/users/cginternals","html_url":"https://github.com/cginternals","followers_url":"https://api.github.com/users/cginternals/followers","following_url":"https://api.github.com/users/cginternals/following{/other_user}","gists_url":"https://api.github.com/users/cginternals/gists{/gist_id}","starred_url":"https://api.github.com/users/cginternals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cginternals/subscriptions","organizations_url":"https://api.github.com/users/cginternals/orgs","repos_url":"https://api.github.com/users/cginternals/repos","events_url":"https://api.github.com/users/cginternals/events{/privacy}","received_events_url":"https://api.github.com/users/cginternals/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cginternals/webgl-operate","description":"A TypeScript based WebGL rendering framework.","fork":false,"url":"https://api.github.com/repos/cginternals/webgl-operate","forks_url":"https://api.github.com/repos/cginternals/webgl-operate/forks","keys_url":"https://api.github.com/repos/cginternals/webgl-operate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cginternals/webgl-operate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cginternals/webgl-operate/teams","hooks_url":"https://api.github.com/repos/cginternals/webgl-operate/hooks","issue_events_url":"https://api.github.com/repos/cginternals/webgl-operate/issues/events{/number}","events_url":"https://api.github.com/repos/cginternals/webgl-operate/events","assignees_url":"https://api.github.com/repos/cginternals/webgl-operate/assignees{/user}","branches_url":"https://api.github.com/repos/cginternals/webgl-operate/branches{/branch}","tags_url":"https://api.github.com/repos/cginternals/webgl-operate/tags","blobs_url":"https://api.github.com/repos/cginternals/webgl-operate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cginternals/webgl-operate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cginternals/webgl-operate/git/refs{/sha}","trees_url":"https://api.github.com/repos/cginternals/webgl-operate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cginternals/webgl-operate/statuses/{sha}","languages_url":"https://api.github.com/repos/cginternals/webgl-operate/languages","stargazers_url":"https://api.github.com/repos/cginternals/webgl-operate/stargazers","contributors_url":"https://api.github.com/repos/cginternals/webgl-operate/contributors","subscribers_url":"https://api.github.com/repos/cginternals/webgl-operate/subscribers","subscription_url":"https://api.github.com/repos/cginternals/webgl-operate/subscription","commits_url":"https://api.github.com/repos/cginternals/webgl-operate/commits{/sha}","git_commits_url":"https://api.github.com/repos/cginternals/webgl-operate/git/commits{/sha}","comments_url":"https://api.github.com/repos/cginternals/webgl-operate/comments{/number}","issue_comment_url":"https://api.github.com/repos/cginternals/webgl-operate/issues/comments{/number}","contents_url":"https://api.github.com/repos/cginternals/webgl-operate/contents/{+path}","compare_url":"https://api.github.com/repos/cginternals/webgl-operate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cginternals/webgl-operate/merges","archive_url":"https://api.github.com/repos/cginternals/webgl-operate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cginternals/webgl-operate/downloads","issues_url":"https://api.github.com/repos/cginternals/webgl-operate/issues{/number}","pulls_url":"https://api.github.com/repos/cginternals/webgl-operate/pulls{/number}","milestones_url":"https://api.github.com/repos/cginternals/webgl-operate/milestones{/number}","notifications_url":"https://api.github.com/repos/cginternals/webgl-operate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cginternals/webgl-operate/labels{/name}","releases_url":"https://api.github.com/repos/cginternals/webgl-operate/releases{/id}","deployments_url":"https://api.github.com/repos/cginternals/webgl-operate/deployments","created_at":"2018-01-11T08:44:50Z","updated_at":"2018-11-16T10:32:32Z","pushed_at":"2018-11-19T02:06:40Z","git_url":"git://github.com/cginternals/webgl-operate.git","ssh_url":"git@github.com:cginternals/webgl-operate.git","clone_url":"https://github.com/cginternals/webgl-operate.git","svn_url":"https://github.com/cginternals/webgl-operate","homepage":"https://webgl-operate.org","size":2697,"stargazers_count":21,"watchers_count":21,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":35,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cginternals/webgl-operate/pulls/147"},"html":{"href":"https://github.com/cginternals/webgl-operate/pull/147"},"issue":{"href":"https://api.github.com/repos/cginternals/webgl-operate/issues/147"},"comments":{"href":"https://api.github.com/repos/cginternals/webgl-operate/issues/147/comments"},"review_comments":{"href":"https://api.github.com/repos/cginternals/webgl-operate/pulls/147/comments"},"review_comment":{"href":"https://api.github.com/repos/cginternals/webgl-operate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cginternals/webgl-operate/pulls/147/commits"},"statuses":{"href":"https://api.github.com/repos/cginternals/webgl-operate/statuses/aeb1be0a86bb54710e0f780d4abc5355a5214fe6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"cgcostume"}}