{"action":"created","comment":{"url":"https://api.github.com/repos/ubc/compair/pulls/comments/215808654","pull_request_review_id":153159634,"id":215808654,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTgwODY1NA==","diff_hunk":"@@ -61,23 +61,39 @@ module.factory(\n /***** Controllers *****/\n module.controller(\n     'AddGroupModalController',\n-    [\"$rootScope\", \"$scope\", \"$uibModalInstance\", \"GroupResource\",\n-    function ($rootScope, $scope, $uibModalInstance, GroupResource) {\n+    [\"$rootScope\", \"$scope\", \"$uibModalInstance\", \"$filter\", \"Toaster\", \"GroupResource\",\n+    function ($rootScope, $scope, $uibModalInstance, $filter, Toaster, GroupResource) {\n         $scope.group = {};\n         $scope.modalInstance = $uibModalInstance;\n         $scope.submitted = false;\n \n         $scope.groupSubmit = function () {\n             $scope.submitted = true;\n \n-            GroupResource.save({'courseId': $scope.courseId}, $scope.group).$promise.then(\n-                function (ret) {\n-                    $scope.group = ret;\n-                    $uibModalInstance.close($scope.group.id);\n+            // Ensure name is unique\n+            $scope.groups = GroupResource.get({'courseId': $scope.courseId}).$promise.then(","path":"compair/static/modules/group/group-module.js","position":20,"original_position":20,"commit_id":"3c8e32832e409e7f5f0c4fe92be82c39dee8fdde","original_commit_id":"3c8e32832e409e7f5f0c4fe92be82c39dee8fdde","user":{"login":"andrew-gardener","id":3082802,"node_id":"MDQ6VXNlcjMwODI4MDI=","avatar_url":"https://avatars0.githubusercontent.com/u/3082802?v=4","gravatar_id":"","url":"https://api.github.com/users/andrew-gardener","html_url":"https://github.com/andrew-gardener","followers_url":"https://api.github.com/users/andrew-gardener/followers","following_url":"https://api.github.com/users/andrew-gardener/following{/other_user}","gists_url":"https://api.github.com/users/andrew-gardener/gists{/gist_id}","starred_url":"https://api.github.com/users/andrew-gardener/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrew-gardener/subscriptions","organizations_url":"https://api.github.com/users/andrew-gardener/orgs","repos_url":"https://api.github.com/users/andrew-gardener/repos","events_url":"https://api.github.com/users/andrew-gardener/events{/privacy}","received_events_url":"https://api.github.com/users/andrew-gardener/received_events","type":"User","site_admin":false},"body":"Why not allow the backend to handle it? (it is generally good to do it in the front end but since it requires an api call, I think its better to do it in the backend the one time)","created_at":"2018-09-06T23:35:16Z","updated_at":"2018-09-06T23:40:22Z","html_url":"https://github.com/ubc/compair/pull/832#discussion_r215808654","pull_request_url":"https://api.github.com/repos/ubc/compair/pulls/832","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ubc/compair/pulls/comments/215808654"},"html":{"href":"https://github.com/ubc/compair/pull/832#discussion_r215808654"},"pull_request":{"href":"https://api.github.com/repos/ubc/compair/pulls/832"}}},"pull_request":{"url":"https://api.github.com/repos/ubc/compair/pulls/832","id":211569596,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNTY5NTk2","html_url":"https://github.com/ubc/compair/pull/832","diff_url":"https://github.com/ubc/compair/pull/832.diff","patch_url":"https://github.com/ubc/compair/pull/832.patch","issue_url":"https://api.github.com/repos/ubc/compair/issues/832","number":832,"state":"open","locked":false,"title":"Allow easier adding of groups on Manage Users screen","user":{"login":"wynnset","id":8981258,"node_id":"MDQ6VXNlcjg5ODEyNTg=","avatar_url":"https://avatars1.githubusercontent.com/u/8981258?v=4","gravatar_id":"","url":"https://api.github.com/users/wynnset","html_url":"https://github.com/wynnset","followers_url":"https://api.github.com/users/wynnset/followers","following_url":"https://api.github.com/users/wynnset/following{/other_user}","gists_url":"https://api.github.com/users/wynnset/gists{/gist_id}","starred_url":"https://api.github.com/users/wynnset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wynnset/subscriptions","organizations_url":"https://api.github.com/users/wynnset/orgs","repos_url":"https://api.github.com/users/wynnset/repos","events_url":"https://api.github.com/users/wynnset/events{/privacy}","received_events_url":"https://api.github.com/users/wynnset/received_events","type":"User","site_admin":false},"body":"- Always show the Course Groups column in the class list\r\n- Always have an option 'Add New Group' as the last option\r\n- Selecting 'Add New Group' would allow the user to add a new group to which the user would then be automatically added\r\n\r\nFixes #792","created_at":"2018-08-28T21:54:06Z","updated_at":"2018-09-06T23:40:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7619ffc0f93c9630a6d9dc6b43290901ac831413","assignee":{"login":"wynnset","id":8981258,"node_id":"MDQ6VXNlcjg5ODEyNTg=","avatar_url":"https://avatars1.githubusercontent.com/u/8981258?v=4","gravatar_id":"","url":"https://api.github.com/users/wynnset","html_url":"https://github.com/wynnset","followers_url":"https://api.github.com/users/wynnset/followers","following_url":"https://api.github.com/users/wynnset/following{/other_user}","gists_url":"https://api.github.com/users/wynnset/gists{/gist_id}","starred_url":"https://api.github.com/users/wynnset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wynnset/subscriptions","organizations_url":"https://api.github.com/users/wynnset/orgs","repos_url":"https://api.github.com/users/wynnset/repos","events_url":"https://api.github.com/users/wynnset/events{/privacy}","received_events_url":"https://api.github.com/users/wynnset/received_events","type":"User","site_admin":false},"assignees":[{"login":"wynnset","id":8981258,"node_id":"MDQ6VXNlcjg5ODEyNTg=","avatar_url":"https://avatars1.githubusercontent.com/u/8981258?v=4","gravatar_id":"","url":"https://api.github.com/users/wynnset","html_url":"https://github.com/wynnset","followers_url":"https://api.github.com/users/wynnset/followers","following_url":"https://api.github.com/users/wynnset/following{/other_user}","gists_url":"https://api.github.com/users/wynnset/gists{/gist_id}","starred_url":"https://api.github.com/users/wynnset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wynnset/subscriptions","organizations_url":"https://api.github.com/users/wynnset/orgs","repos_url":"https://api.github.com/users/wynnset/repos","events_url":"https://api.github.com/users/wynnset/events{/privacy}","received_events_url":"https://api.github.com/users/wynnset/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/ubc/compair/milestones/23","html_url":"https://github.com/ubc/compair/milestone/23","labels_url":"https://api.github.com/repos/ubc/compair/milestones/23/labels","id":3545141,"node_id":"MDk6TWlsZXN0b25lMzU0NTE0MQ==","number":23,"title":"Version 1.2.1","description":"","creator":{"login":"andrew-gardener","id":3082802,"node_id":"MDQ6VXNlcjMwODI4MDI=","avatar_url":"https://avatars0.githubusercontent.com/u/3082802?v=4","gravatar_id":"","url":"https://api.github.com/users/andrew-gardener","html_url":"https://github.com/andrew-gardener","followers_url":"https://api.github.com/users/andrew-gardener/followers","following_url":"https://api.github.com/users/andrew-gardener/following{/other_user}","gists_url":"https://api.github.com/users/andrew-gardener/gists{/gist_id}","starred_url":"https://api.github.com/users/andrew-gardener/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrew-gardener/subscriptions","organizations_url":"https://api.github.com/users/andrew-gardener/orgs","repos_url":"https://api.github.com/users/andrew-gardener/repos","events_url":"https://api.github.com/users/andrew-gardener/events{/privacy}","received_events_url":"https://api.github.com/users/andrew-gardener/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":0,"state":"open","created_at":"2018-08-03T16:32:50Z","updated_at":"2018-08-28T21:54:06Z","due_on":"2018-09-26T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/ubc/compair/pulls/832/commits","review_comments_url":"https://api.github.com/repos/ubc/compair/pulls/832/comments","review_comment_url":"https://api.github.com/repos/ubc/compair/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ubc/compair/issues/832/comments","statuses_url":"https://api.github.com/repos/ubc/compair/statuses/3c8e32832e409e7f5f0c4fe92be82c39dee8fdde","head":{"label":"ubc:#792-easier-adding-user-to-group","ref":"#792-easier-adding-user-to-group","sha":"3c8e32832e409e7f5f0c4fe92be82c39dee8fdde","user":{"login":"ubc","id":1396118,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTYxMTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1396118?v=4","gravatar_id":"","url":"https://api.github.com/users/ubc","html_url":"https://github.com/ubc","followers_url":"https://api.github.com/users/ubc/followers","following_url":"https://api.github.com/users/ubc/following{/other_user}","gists_url":"https://api.github.com/users/ubc/gists{/gist_id}","starred_url":"https://api.github.com/users/ubc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubc/subscriptions","organizations_url":"https://api.github.com/users/ubc/orgs","repos_url":"https://api.github.com/users/ubc/repos","events_url":"https://api.github.com/users/ubc/events{/privacy}","received_events_url":"https://api.github.com/users/ubc/received_events","type":"Organization","site_admin":false},"repo":{"id":10607020,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYwNzAyMA==","name":"compair","full_name":"ubc/compair","owner":{"login":"ubc","id":1396118,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTYxMTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1396118?v=4","gravatar_id":"","url":"https://api.github.com/users/ubc","html_url":"https://github.com/ubc","followers_url":"https://api.github.com/users/ubc/followers","following_url":"https://api.github.com/users/ubc/following{/other_user}","gists_url":"https://api.github.com/users/ubc/gists{/gist_id}","starred_url":"https://api.github.com/users/ubc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubc/subscriptions","organizations_url":"https://api.github.com/users/ubc/orgs","repos_url":"https://api.github.com/users/ubc/repos","events_url":"https://api.github.com/users/ubc/events{/privacy}","received_events_url":"https://api.github.com/users/ubc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ubc/compair","description":"ComPAIR: a peer review application pairing student answers for deeper learning through comparison of peer work","fork":false,"url":"https://api.github.com/repos/ubc/compair","forks_url":"https://api.github.com/repos/ubc/compair/forks","keys_url":"https://api.github.com/repos/ubc/compair/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ubc/compair/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ubc/compair/teams","hooks_url":"https://api.github.com/repos/ubc/compair/hooks","issue_events_url":"https://api.github.com/repos/ubc/compair/issues/events{/number}","events_url":"https://api.github.com/repos/ubc/compair/events","assignees_url":"https://api.github.com/repos/ubc/compair/assignees{/user}","branches_url":"https://api.github.com/repos/ubc/compair/branches{/branch}","tags_url":"https://api.github.com/repos/ubc/compair/tags","blobs_url":"https://api.github.com/repos/ubc/compair/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ubc/compair/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ubc/compair/git/refs{/sha}","trees_url":"https://api.github.com/repos/ubc/compair/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ubc/compair/statuses/{sha}","languages_url":"https://api.github.com/repos/ubc/compair/languages","stargazers_url":"https://api.github.com/repos/ubc/compair/stargazers","contributors_url":"https://api.github.com/repos/ubc/compair/contributors","subscribers_url":"https://api.github.com/repos/ubc/compair/subscribers","subscription_url":"https://api.github.com/repos/ubc/compair/subscription","commits_url":"https://api.github.com/repos/ubc/compair/commits{/sha}","git_commits_url":"https://api.github.com/repos/ubc/compair/git/commits{/sha}","comments_url":"https://api.github.com/repos/ubc/compair/comments{/number}","issue_comment_url":"https://api.github.com/repos/ubc/compair/issues/comments{/number}","contents_url":"https://api.github.com/repos/ubc/compair/contents/{+path}","compare_url":"https://api.github.com/repos/ubc/compair/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ubc/compair/merges","archive_url":"https://api.github.com/repos/ubc/compair/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ubc/compair/downloads","issues_url":"https://api.github.com/repos/ubc/compair/issues{/number}","pulls_url":"https://api.github.com/repos/ubc/compair/pulls{/number}","milestones_url":"https://api.github.com/repos/ubc/compair/milestones{/number}","notifications_url":"https://api.github.com/repos/ubc/compair/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ubc/compair/labels{/name}","releases_url":"https://api.github.com/repos/ubc/compair/releases{/id}","deployments_url":"https://api.github.com/repos/ubc/compair/deployments","created_at":"2013-06-10T18:52:38Z","updated_at":"2018-08-24T18:45:56Z","pushed_at":"2018-09-06T22:59:12Z","git_url":"git://github.com/ubc/compair.git","ssh_url":"git@github.com:ubc/compair.git","clone_url":"https://github.com/ubc/compair.git","svn_url":"https://github.com/ubc/compair","homepage":"http://ubc.github.io/compair","size":16953,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":3,"open_issues":59,"watchers":12,"default_branch":"master"}},"base":{"label":"ubc:master","ref":"master","sha":"1404bd255eb83aa820a98a64451e88f59aeca20d","user":{"login":"ubc","id":1396118,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTYxMTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1396118?v=4","gravatar_id":"","url":"https://api.github.com/users/ubc","html_url":"https://github.com/ubc","followers_url":"https://api.github.com/users/ubc/followers","following_url":"https://api.github.com/users/ubc/following{/other_user}","gists_url":"https://api.github.com/users/ubc/gists{/gist_id}","starred_url":"https://api.github.com/users/ubc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubc/subscriptions","organizations_url":"https://api.github.com/users/ubc/orgs","repos_url":"https://api.github.com/users/ubc/repos","events_url":"https://api.github.com/users/ubc/events{/privacy}","received_events_url":"https://api.github.com/users/ubc/received_events","type":"Organization","site_admin":false},"repo":{"id":10607020,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYwNzAyMA==","name":"compair","full_name":"ubc/compair","owner":{"login":"ubc","id":1396118,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTYxMTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1396118?v=4","gravatar_id":"","url":"https://api.github.com/users/ubc","html_url":"https://github.com/ubc","followers_url":"https://api.github.com/users/ubc/followers","following_url":"https://api.github.com/users/ubc/following{/other_user}","gists_url":"https://api.github.com/users/ubc/gists{/gist_id}","starred_url":"https://api.github.com/users/ubc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubc/subscriptions","organizations_url":"https://api.github.com/users/ubc/orgs","repos_url":"https://api.github.com/users/ubc/repos","events_url":"https://api.github.com/users/ubc/events{/privacy}","received_events_url":"https://api.github.com/users/ubc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ubc/compair","description":"ComPAIR: a peer review application pairing student answers for deeper learning through comparison of peer work","fork":false,"url":"https://api.github.com/repos/ubc/compair","forks_url":"https://api.github.com/repos/ubc/compair/forks","keys_url":"https://api.github.com/repos/ubc/compair/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ubc/compair/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ubc/compair/teams","hooks_url":"https://api.github.com/repos/ubc/compair/hooks","issue_events_url":"https://api.github.com/repos/ubc/compair/issues/events{/number}","events_url":"https://api.github.com/repos/ubc/compair/events","assignees_url":"https://api.github.com/repos/ubc/compair/assignees{/user}","branches_url":"https://api.github.com/repos/ubc/compair/branches{/branch}","tags_url":"https://api.github.com/repos/ubc/compair/tags","blobs_url":"https://api.github.com/repos/ubc/compair/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ubc/compair/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ubc/compair/git/refs{/sha}","trees_url":"https://api.github.com/repos/ubc/compair/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ubc/compair/statuses/{sha}","languages_url":"https://api.github.com/repos/ubc/compair/languages","stargazers_url":"https://api.github.com/repos/ubc/compair/stargazers","contributors_url":"https://api.github.com/repos/ubc/compair/contributors","subscribers_url":"https://api.github.com/repos/ubc/compair/subscribers","subscription_url":"https://api.github.com/repos/ubc/compair/subscription","commits_url":"https://api.github.com/repos/ubc/compair/commits{/sha}","git_commits_url":"https://api.github.com/repos/ubc/compair/git/commits{/sha}","comments_url":"https://api.github.com/repos/ubc/compair/comments{/number}","issue_comment_url":"https://api.github.com/repos/ubc/compair/issues/comments{/number}","contents_url":"https://api.github.com/repos/ubc/compair/contents/{+path}","compare_url":"https://api.github.com/repos/ubc/compair/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ubc/compair/merges","archive_url":"https://api.github.com/repos/ubc/compair/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ubc/compair/downloads","issues_url":"https://api.github.com/repos/ubc/compair/issues{/number}","pulls_url":"https://api.github.com/repos/ubc/compair/pulls{/number}","milestones_url":"https://api.github.com/repos/ubc/compair/milestones{/number}","notifications_url":"https://api.github.com/repos/ubc/compair/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ubc/compair/labels{/name}","releases_url":"https://api.github.com/repos/ubc/compair/releases{/id}","deployments_url":"https://api.github.com/repos/ubc/compair/deployments","created_at":"2013-06-10T18:52:38Z","updated_at":"2018-08-24T18:45:56Z","pushed_at":"2018-09-06T22:59:12Z","git_url":"git://github.com/ubc/compair.git","ssh_url":"git@github.com:ubc/compair.git","clone_url":"https://github.com/ubc/compair.git","svn_url":"https://github.com/ubc/compair","homepage":"http://ubc.github.io/compair","size":16953,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":3,"open_issues":59,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ubc/compair/pulls/832"},"html":{"href":"https://github.com/ubc/compair/pull/832"},"issue":{"href":"https://api.github.com/repos/ubc/compair/issues/832"},"comments":{"href":"https://api.github.com/repos/ubc/compair/issues/832/comments"},"review_comments":{"href":"https://api.github.com/repos/ubc/compair/pulls/832/comments"},"review_comment":{"href":"https://api.github.com/repos/ubc/compair/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ubc/compair/pulls/832/commits"},"statuses":{"href":"https://api.github.com/repos/ubc/compair/statuses/3c8e32832e409e7f5f0c4fe92be82c39dee8fdde"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"andrew-gardener"}}