{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/addons-frontend/issues/2595","repository_url":"https://api.github.com/repos/mozilla/addons-frontend","labels_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/2595/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/2595/comments","events_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/2595/events","html_url":"https://github.com/mozilla/addons-frontend/issues/2595","id":236319249,"node_id":"MDU6SXNzdWUyMzYzMTkyNDk=","number":2595,"title":"We should not change icon_url to iconUrl","user":{"login":"tofumatt","id":90871,"node_id":"MDQ6VXNlcjkwODcx","avatar_url":"https://avatars2.githubusercontent.com/u/90871?v=4","gravatar_id":"","url":"https://api.github.com/users/tofumatt","html_url":"https://github.com/tofumatt","followers_url":"https://api.github.com/users/tofumatt/followers","following_url":"https://api.github.com/users/tofumatt/following{/other_user}","gists_url":"https://api.github.com/users/tofumatt/gists{/gist_id}","starred_url":"https://api.github.com/users/tofumatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tofumatt/subscriptions","organizations_url":"https://api.github.com/users/tofumatt/orgs","repos_url":"https://api.github.com/users/tofumatt/repos","events_url":"https://api.github.com/users/tofumatt/events{/privacy}","received_events_url":"https://api.github.com/users/tofumatt/received_events","type":"User","site_admin":false},"labels":[{"id":357492876,"node_id":"MDU6TGFiZWwzNTc0OTI4NzY=","url":"https://api.github.com/repos/mozilla/addons-frontend/labels/component:%20code%20quality","name":"component: code quality","color":"107c05","default":false},{"id":603031818,"node_id":"MDU6TGFiZWw2MDMwMzE4MTg=","url":"https://api.github.com/repos/mozilla/addons-frontend/labels/contrib:%20welcome","name":"contrib: welcome","color":"c9b4f9","default":false},{"id":820355113,"node_id":"MDU6TGFiZWw4MjAzNTUxMTM=","url":"https://api.github.com/repos/mozilla/addons-frontend/labels/priority:%20p4","name":"priority: p4","color":"5a0002","default":false},{"id":328844188,"node_id":"MDU6TGFiZWwzMjg4NDQxODg=","url":"https://api.github.com/repos/mozilla/addons-frontend/labels/state:%20wontfix","name":"state: wontfix","color":"eeeeee","default":false},{"id":350682014,"node_id":"MDU6TGFiZWwzNTA2ODIwMTQ=","url":"https://api.github.com/repos/mozilla/addons-frontend/labels/triaged","name":"triaged","color":"eeeeee","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-06-15T21:27:18Z","updated_at":"2018-09-17T11:56:36Z","closed_at":null,"author_association":"MEMBER","body":"### Describe the problem and steps to reproduce it:\r\nThis code https://github.com/mozilla/addons-frontend/blob/master/src/core/reducers/addons.js#L12 doesn't really do much but is really annoying and weird to debug. We should remove it.\r\n\r\n### What happened?\r\nI wanted to refactor a test.\r\n\r\n### What did you expect to happen?\r\nIt was annoying to refactor because we rename this one property.\r\n\r\n### Anything else we should know?\r\n@kumar303 is going to run out of GIFs, be sure to bring him extra at the All-Hands.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/mozilla/addons-frontend/issues/comments/421984658","html_url":"https://github.com/mozilla/addons-frontend/issues/2595#issuecomment-421984658","issue_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/2595","id":421984658,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTk4NDY1OA==","user":{"login":"willdurand","id":217628,"node_id":"MDQ6VXNlcjIxNzYyOA==","avatar_url":"https://avatars0.githubusercontent.com/u/217628?v=4","gravatar_id":"","url":"https://api.github.com/users/willdurand","html_url":"https://github.com/willdurand","followers_url":"https://api.github.com/users/willdurand/followers","following_url":"https://api.github.com/users/willdurand/following{/other_user}","gists_url":"https://api.github.com/users/willdurand/gists{/gist_id}","starred_url":"https://api.github.com/users/willdurand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willdurand/subscriptions","organizations_url":"https://api.github.com/users/willdurand/orgs","repos_url":"https://api.github.com/users/willdurand/repos","events_url":"https://api.github.com/users/willdurand/events{/privacy}","received_events_url":"https://api.github.com/users/willdurand/received_events","type":"User","site_admin":false},"created_at":"2018-09-17T11:56:36Z","updated_at":"2018-09-17T11:56:36Z","author_association":"MEMBER","body":"mmh I thought it was a more generic issue stating that aliasing `iconUrl` to `icon_url` was counter-productive, not just this prop. I don't understand why we would like to keep a 1:1 binding for this property and not for other props to be honest.\r\n\r\n> As far as I can tell, Discopane is no longer camel casing keys so I think it's safe to remove?\r\n\r\nI think so yes."}}
{"actor":{"display_login":"willdurand"}}