{"action":"created","comment":{"url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/comments/245452218","pull_request_review_id":189568129,"id":245452218,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTQ1MjIxOA==","diff_hunk":"@@ -140,51 +140,54 @@ function<void(EMIT_ARGS)> runtime::gpu::GPU_Emitter::get_emit_function(const Nod\n \n     return it->second;\n }\n+#pragma clang diagnostic push\n+#pragma clang diagnostic ignored \"-Wunused-variable\"","path":"src/ngraph/runtime/gpu/gpu_emitter.cpp","position":null,"original_position":24,"commit_id":"ba781a2526e32c7d6a370e8c25e501ee4ae01af3","original_commit_id":"76737fcfee8e276e7efd43772552babec5a9fa3a","user":{"login":"csullivan","id":4804563,"node_id":"MDQ6VXNlcjQ4MDQ1NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/4804563?v=4","gravatar_id":"","url":"https://api.github.com/users/csullivan","html_url":"https://github.com/csullivan","followers_url":"https://api.github.com/users/csullivan/followers","following_url":"https://api.github.com/users/csullivan/following{/other_user}","gists_url":"https://api.github.com/users/csullivan/gists{/gist_id}","starred_url":"https://api.github.com/users/csullivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csullivan/subscriptions","organizations_url":"https://api.github.com/users/csullivan/orgs","repos_url":"https://api.github.com/users/csullivan/repos","events_url":"https://api.github.com/users/csullivan/events{/privacy}","received_events_url":"https://api.github.com/users/csullivan/received_events","type":"User","site_admin":false},"body":"Good catch, thanks.","created_at":"2019-01-04T23:54:38Z","updated_at":"2019-01-04T23:54:39Z","html_url":"https://github.com/NervanaSystems/ngraph/pull/2115#discussion_r245452218","pull_request_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/2115","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/comments/245452218"},"html":{"href":"https://github.com/NervanaSystems/ngraph/pull/2115#discussion_r245452218"},"pull_request":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/2115"}},"in_reply_to_id":240417213},"pull_request":{"url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/2115","id":233654313,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNjU0MzEz","html_url":"https://github.com/NervanaSystems/ngraph/pull/2115","diff_url":"https://github.com/NervanaSystems/ngraph/pull/2115.diff","patch_url":"https://github.com/NervanaSystems/ngraph/pull/2115.patch","issue_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/2115","number":2115,"state":"open","locked":false,"title":"nvgpu backend without clang","user":{"login":"csullivan","id":4804563,"node_id":"MDQ6VXNlcjQ4MDQ1NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/4804563?v=4","gravatar_id":"","url":"https://api.github.com/users/csullivan","html_url":"https://github.com/csullivan","followers_url":"https://api.github.com/users/csullivan/followers","following_url":"https://api.github.com/users/csullivan/following{/other_user}","gists_url":"https://api.github.com/users/csullivan/gists{/gist_id}","starred_url":"https://api.github.com/users/csullivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csullivan/subscriptions","organizations_url":"https://api.github.com/users/csullivan/orgs","repos_url":"https://api.github.com/users/csullivan/repos","events_url":"https://api.github.com/users/csullivan/events{/privacy}","received_events_url":"https://api.github.com/users/csullivan/received_events","type":"User","site_admin":false},"body":"Please see commit messages.\r\n\r\nBasic overview:\r\n* GPUExternalFunction functions the same as previous, emitting code for clang to compile\r\n* GPUInternalFunction builds closures and resolves the runtime memory addresses\r\n* Both of these inherit from a GPUCompiledFunction (many refactors to decrease repetition)\r\n* Minimal changes required to emitters\r\n\r\nAdditions:\r\n* GPUCompiledFunction has virtual method `add_to_runtime`; for external functions this emits needed invocation code into a CodeWriter, for internal functions a invoker lambda is made which captures the primitive index and calls gpu_invoke_primitive. This invoker lambda is added to the GPURuntimeConstructor.\r\n* Introduce GPURuntimeConstructor, a utility class which consumes primitive invocations for ngraph functions and stores them in separate runtimes for each function.\r\n* Introduce GPUCallFrame, a container which holds device pointers that can be lazily resolved when they are available. A call frame is captured by the runtime constructor which then resolves the input and output device pointers needed for calling each of the primitive invocations. \r\n\r\nLimitations:\r\n* Internal functions do not yet support nbench timers for performance data\r\n* Internal functions do not yet support in-place propagation of inputs/outputs\r\n* The following tests are disabled as this PR requires different implementation than currently used for reduction ops that have `zero-length dimensions`:\r\n```\r\nproduct_matrix_rows_zero\r\nproduct_matrix_cols_zero\r\nproduct_vector_zero\r\nproduct_matrix_to_scalar_zero_by_zero\r\nproduct_3d_eliminate_zero_dim\r\nmax_matrix_rows_zero_int32\r\nreduce_matrix_rows_zero\r\nreduce_matrix_cols_zero\r\nreduce_vector_zero\r\nreduce_matrix_to_scalar_zero_by_zero\r\n```\r\n\r\nNote:\r\n* Made codegen::CodeWriter header only so that it can be used without the clang dependence (it is useful for our NVRTC kernels)","created_at":"2018-11-26T18:27:39Z","updated_at":"2019-01-04T23:54:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"615e564da9aa5a36755c89dba6ad7c4adf602eaa","assignee":{"login":"csullivan","id":4804563,"node_id":"MDQ6VXNlcjQ4MDQ1NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/4804563?v=4","gravatar_id":"","url":"https://api.github.com/users/csullivan","html_url":"https://github.com/csullivan","followers_url":"https://api.github.com/users/csullivan/followers","following_url":"https://api.github.com/users/csullivan/following{/other_user}","gists_url":"https://api.github.com/users/csullivan/gists{/gist_id}","starred_url":"https://api.github.com/users/csullivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csullivan/subscriptions","organizations_url":"https://api.github.com/users/csullivan/orgs","repos_url":"https://api.github.com/users/csullivan/repos","events_url":"https://api.github.com/users/csullivan/events{/privacy}","received_events_url":"https://api.github.com/users/csullivan/received_events","type":"User","site_admin":false},"assignees":[{"login":"csullivan","id":4804563,"node_id":"MDQ6VXNlcjQ4MDQ1NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/4804563?v=4","gravatar_id":"","url":"https://api.github.com/users/csullivan","html_url":"https://github.com/csullivan","followers_url":"https://api.github.com/users/csullivan/followers","following_url":"https://api.github.com/users/csullivan/following{/other_user}","gists_url":"https://api.github.com/users/csullivan/gists{/gist_id}","starred_url":"https://api.github.com/users/csullivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csullivan/subscriptions","organizations_url":"https://api.github.com/users/csullivan/orgs","repos_url":"https://api.github.com/users/csullivan/repos","events_url":"https://api.github.com/users/csullivan/events{/privacy}","received_events_url":"https://api.github.com/users/csullivan/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":825174556,"node_id":"MDU6TGFiZWw4MjUxNzQ1NTY=","url":"https://api.github.com/repos/NervanaSystems/ngraph/labels/NvidiaGPU","name":"NvidiaGPU","color":"76b900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/2115/commits","review_comments_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/2115/comments","review_comment_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/2115/comments","statuses_url":"https://api.github.com/repos/NervanaSystems/ngraph/statuses/ba781a2526e32c7d6a370e8c25e501ee4ae01af3","head":{"label":"NervanaSystems:cs/nvgpu_without_clang2","ref":"cs/nvgpu_without_clang2","sha":"ba781a2526e32c7d6a370e8c25e501ee4ae01af3","user":{"login":"NervanaSystems","id":9260121,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNjAxMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":98252973,"node_id":"MDEwOlJlcG9zaXRvcnk5ODI1Mjk3Mw==","name":"ngraph","full_name":"NervanaSystems/ngraph","private":false,"owner":{"login":"NervanaSystems","id":9260121,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNjAxMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NervanaSystems/ngraph","description":"nGraph is an open source C++ library, compiler and runtime for Deep Learning frameworks","fork":false,"url":"https://api.github.com/repos/NervanaSystems/ngraph","forks_url":"https://api.github.com/repos/NervanaSystems/ngraph/forks","keys_url":"https://api.github.com/repos/NervanaSystems/ngraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NervanaSystems/ngraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NervanaSystems/ngraph/teams","hooks_url":"https://api.github.com/repos/NervanaSystems/ngraph/hooks","issue_events_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/events{/number}","events_url":"https://api.github.com/repos/NervanaSystems/ngraph/events","assignees_url":"https://api.github.com/repos/NervanaSystems/ngraph/assignees{/user}","branches_url":"https://api.github.com/repos/NervanaSystems/ngraph/branches{/branch}","tags_url":"https://api.github.com/repos/NervanaSystems/ngraph/tags","blobs_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NervanaSystems/ngraph/statuses/{sha}","languages_url":"https://api.github.com/repos/NervanaSystems/ngraph/languages","stargazers_url":"https://api.github.com/repos/NervanaSystems/ngraph/stargazers","contributors_url":"https://api.github.com/repos/NervanaSystems/ngraph/contributors","subscribers_url":"https://api.github.com/repos/NervanaSystems/ngraph/subscribers","subscription_url":"https://api.github.com/repos/NervanaSystems/ngraph/subscription","commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/NervanaSystems/ngraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/NervanaSystems/ngraph/contents/{+path}","compare_url":"https://api.github.com/repos/NervanaSystems/ngraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NervanaSystems/ngraph/merges","archive_url":"https://api.github.com/repos/NervanaSystems/ngraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NervanaSystems/ngraph/downloads","issues_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues{/number}","pulls_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls{/number}","milestones_url":"https://api.github.com/repos/NervanaSystems/ngraph/milestones{/number}","notifications_url":"https://api.github.com/repos/NervanaSystems/ngraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NervanaSystems/ngraph/labels{/name}","releases_url":"https://api.github.com/repos/NervanaSystems/ngraph/releases{/id}","deployments_url":"https://api.github.com/repos/NervanaSystems/ngraph/deployments","created_at":"2017-07-25T02:02:38Z","updated_at":"2019-01-04T07:00:57Z","pushed_at":"2019-01-04T23:54:14Z","git_url":"git://github.com/NervanaSystems/ngraph.git","ssh_url":"git@github.com:NervanaSystems/ngraph.git","clone_url":"https://github.com/NervanaSystems/ngraph.git","svn_url":"https://github.com/NervanaSystems/ngraph","homepage":"https://ngraph.nervanasys.com/docs/latest","size":71876,"stargazers_count":780,"watchers_count":780,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":103,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":103,"open_issues":75,"watchers":780,"default_branch":"master"}},"base":{"label":"NervanaSystems:master","ref":"master","sha":"7e310e209720afa0cbaa914be6950834f1fd314e","user":{"login":"NervanaSystems","id":9260121,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNjAxMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":98252973,"node_id":"MDEwOlJlcG9zaXRvcnk5ODI1Mjk3Mw==","name":"ngraph","full_name":"NervanaSystems/ngraph","private":false,"owner":{"login":"NervanaSystems","id":9260121,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNjAxMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NervanaSystems/ngraph","description":"nGraph is an open source C++ library, compiler and runtime for Deep Learning frameworks","fork":false,"url":"https://api.github.com/repos/NervanaSystems/ngraph","forks_url":"https://api.github.com/repos/NervanaSystems/ngraph/forks","keys_url":"https://api.github.com/repos/NervanaSystems/ngraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NervanaSystems/ngraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NervanaSystems/ngraph/teams","hooks_url":"https://api.github.com/repos/NervanaSystems/ngraph/hooks","issue_events_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/events{/number}","events_url":"https://api.github.com/repos/NervanaSystems/ngraph/events","assignees_url":"https://api.github.com/repos/NervanaSystems/ngraph/assignees{/user}","branches_url":"https://api.github.com/repos/NervanaSystems/ngraph/branches{/branch}","tags_url":"https://api.github.com/repos/NervanaSystems/ngraph/tags","blobs_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NervanaSystems/ngraph/statuses/{sha}","languages_url":"https://api.github.com/repos/NervanaSystems/ngraph/languages","stargazers_url":"https://api.github.com/repos/NervanaSystems/ngraph/stargazers","contributors_url":"https://api.github.com/repos/NervanaSystems/ngraph/contributors","subscribers_url":"https://api.github.com/repos/NervanaSystems/ngraph/subscribers","subscription_url":"https://api.github.com/repos/NervanaSystems/ngraph/subscription","commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/NervanaSystems/ngraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/NervanaSystems/ngraph/contents/{+path}","compare_url":"https://api.github.com/repos/NervanaSystems/ngraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NervanaSystems/ngraph/merges","archive_url":"https://api.github.com/repos/NervanaSystems/ngraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NervanaSystems/ngraph/downloads","issues_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues{/number}","pulls_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls{/number}","milestones_url":"https://api.github.com/repos/NervanaSystems/ngraph/milestones{/number}","notifications_url":"https://api.github.com/repos/NervanaSystems/ngraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NervanaSystems/ngraph/labels{/name}","releases_url":"https://api.github.com/repos/NervanaSystems/ngraph/releases{/id}","deployments_url":"https://api.github.com/repos/NervanaSystems/ngraph/deployments","created_at":"2017-07-25T02:02:38Z","updated_at":"2019-01-04T07:00:57Z","pushed_at":"2019-01-04T23:54:14Z","git_url":"git://github.com/NervanaSystems/ngraph.git","ssh_url":"git@github.com:NervanaSystems/ngraph.git","clone_url":"https://github.com/NervanaSystems/ngraph.git","svn_url":"https://github.com/NervanaSystems/ngraph","homepage":"https://ngraph.nervanasys.com/docs/latest","size":71876,"stargazers_count":780,"watchers_count":780,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":103,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":103,"open_issues":75,"watchers":780,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/2115"},"html":{"href":"https://github.com/NervanaSystems/ngraph/pull/2115"},"issue":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/issues/2115"},"comments":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/issues/2115/comments"},"review_comments":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/2115/comments"},"review_comment":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/2115/commits"},"statuses":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/statuses/ba781a2526e32c7d6a370e8c25e501ee4ae01af3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"csullivan"}}