{"action":"created","issue":{"url":"https://api.github.com/repos/lorenzo/audit-stash/issues/19","repository_url":"https://api.github.com/repos/lorenzo/audit-stash","labels_url":"https://api.github.com/repos/lorenzo/audit-stash/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/lorenzo/audit-stash/issues/19/comments","events_url":"https://api.github.com/repos/lorenzo/audit-stash/issues/19/events","html_url":"https://github.com/lorenzo/audit-stash/issues/19","id":256838096,"node_id":"MDU6SXNzdWUyNTY4MzgwOTY=","number":19,"title":"Why doesn't AuditDeleteEvent track the original entity?","user":{"login":"kevinquinnyo","id":593681,"node_id":"MDQ6VXNlcjU5MzY4MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/593681?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinquinnyo","html_url":"https://github.com/kevinquinnyo","followers_url":"https://api.github.com/users/kevinquinnyo/followers","following_url":"https://api.github.com/users/kevinquinnyo/following{/other_user}","gists_url":"https://api.github.com/users/kevinquinnyo/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinquinnyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinquinnyo/subscriptions","organizations_url":"https://api.github.com/users/kevinquinnyo/orgs","repos_url":"https://api.github.com/users/kevinquinnyo/repos","events_url":"https://api.github.com/users/kevinquinnyo/events{/privacy}","received_events_url":"https://api.github.com/users/kevinquinnyo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2017-09-11T20:51:16Z","updated_at":"2018-10-01T22:43:08Z","closed_at":null,"author_association":"NONE","body":"The AuditDeleteEvent implements EventInterface but unlike AuditCreateEvent and AuditUpdateEvent, does not extend the BaseEvent class and as such, does not keep track of the original and changed values.\r\n\r\nWe know that the changed value is meaningless on a delete, but it seems like it should be tracking the original value shouldn't it?\r\n\r\nIf this were to be added, could it simply be passed to the AuditDeleteEvent::__construct() as an optional (default null) value?\r\n\r\nI'd be happy to patch unless there's a specific reason the original entity data is not being tracked on deletes.\r\n\r\nThanks!"},"comment":{"url":"https://api.github.com/repos/lorenzo/audit-stash/issues/comments/426088591","html_url":"https://github.com/lorenzo/audit-stash/issues/19#issuecomment-426088591","issue_url":"https://api.github.com/repos/lorenzo/audit-stash/issues/19","id":426088591,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjA4ODU5MQ==","user":{"login":"kevinquinnyo","id":593681,"node_id":"MDQ6VXNlcjU5MzY4MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/593681?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinquinnyo","html_url":"https://github.com/kevinquinnyo","followers_url":"https://api.github.com/users/kevinquinnyo/followers","following_url":"https://api.github.com/users/kevinquinnyo/following{/other_user}","gists_url":"https://api.github.com/users/kevinquinnyo/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinquinnyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinquinnyo/subscriptions","organizations_url":"https://api.github.com/users/kevinquinnyo/orgs","repos_url":"https://api.github.com/users/kevinquinnyo/repos","events_url":"https://api.github.com/users/kevinquinnyo/events{/privacy}","received_events_url":"https://api.github.com/users/kevinquinnyo/received_events","type":"User","site_admin":false},"created_at":"2018-10-01T22:43:08Z","updated_at":"2018-10-01T22:43:08Z","author_association":"NONE","body":"@bmudda @GeekWiinik @lorenzo I finally found a half hour today to try adding this.  https://github.com/lorenzo/audit-stash/pull/35\r\n\r\nThe problem is making sure not to break backwards compatibility with the previous `AuditDeleteEvent` signature, and I don't think it's quite right.  I can probably add some tests soon."}}
{"actor":{"display_login":"kevinquinnyo"}}