{"action":"created","comment":{"url":"https://api.github.com/repos/ChronoBank/ChronoMint/pulls/comments/210006157","pull_request_review_id":146132189,"id":210006157,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDAwNjE1Nw==","diff_hunk":"@@ -34,73 +17,27 @@ export default class UserManagerDAO extends AbstractContractDAO {\n \n   connect (web3, options) {\n     super.connect(web3, options)\n-\n-    this.CBEUpdateEmitter = this.contract.events.CBEUpdate({})\n-      .on('data', this.handleCBEUpdateData.bind(this))\n-      .on('error', this.handleCBEUpdateError.bind(this))\n-\n-    this.NewUserRegisteredEmitter = this.contract.events.NewUserRegistered({})\n-      .on('data', this.handleNewUserRegisteredData.bind(this))\n-      .on('error', this.handleNewUserRegisteredError.bind(this))\n   }\n \n   disconnect () {\n     if (this.isConnected) {\n-      this.CBEUpdateEmitter.removeAllListeners()\n-      this.NewUserRegisteredEmitter.removeAllListeners()\n       this.contract = null\n       this.history = null\n       this.web3 = null\n     }\n   }\n \n-  handleCBEUpdateData = (data) => {\n-    if (!data.event) {\n-      return\n-    }\n-\n-    this.emit('CBEUpdate', data)\n-  }\n-\n-  handleCBEUpdateError = (data) => {\n-    this.emit('CBEUpdate_error', data)\n-  }\n-\n-  handleNewUserRegisteredData = (data) => {\n-    if (!data.event) {\n-      return\n-    }\n-\n-    this.emit('NewUserRegistered', data)\n-  }\n-\n-  handleNewUserRegisteredError = (data) => {\n-    this.emit('NewUserRegistered_error', data)\n-  }\n-\n   isCBE (account): Promise<boolean> {\n     return this.contract.methods.getCBE(account).call()\n   }\n \n-  async usersTotal () {\n-    const userCount = await this.contract.methods.userCount().call()\n-    return userCount - 1\n-  }\n-\n   getMemberId (account) {\n     return this.contract.methods.getMemberId(account).call()\n   }\n \n-  getSignsRequired () {\n-    return this.contract.methods.required().call()\n-  }\n-\n-  getAdminCount () {\n-    return this.contract.methods.adminCount().call()\n-  }\n-\n   async getCBEList (): Immutable.Map<CBEModel> {\n-    const [ addresses, hashes ] = await this.contract.methods.getCBEMembers().call()\n+    const result = await this.contract.methods.getCBEMembers().call()\n+    const [addresses, hashes] = Object.values(result)","path":"packages/core/dao/UserManagerDAO.js","position":103,"original_position":103,"commit_id":"12b22ad747bf0bcc98e7e389934515469e3e13ce","original_commit_id":"12b22ad747bf0bcc98e7e389934515469e3e13ce","user":{"login":"ozalexo","id":661889,"node_id":"MDQ6VXNlcjY2MTg4OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/661889?v=4","gravatar_id":"","url":"https://api.github.com/users/ozalexo","html_url":"https://github.com/ozalexo","followers_url":"https://api.github.com/users/ozalexo/followers","following_url":"https://api.github.com/users/ozalexo/following{/other_user}","gists_url":"https://api.github.com/users/ozalexo/gists{/gist_id}","starred_url":"https://api.github.com/users/ozalexo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ozalexo/subscriptions","organizations_url":"https://api.github.com/users/ozalexo/orgs","repos_url":"https://api.github.com/users/ozalexo/repos","events_url":"https://api.github.com/users/ozalexo/events{/privacy}","received_events_url":"https://api.github.com/users/ozalexo/received_events","type":"User","site_admin":false},"body":"What if result will be undefined? Object.values will throw the exception `TypeError: Cannot convert undefined or null to object`.","created_at":"2018-08-14T15:52:40Z","updated_at":"2018-08-14T15:52:40Z","html_url":"https://github.com/ChronoBank/ChronoMint/pull/743#discussion_r210006157","pull_request_url":"https://api.github.com/repos/ChronoBank/ChronoMint/pulls/743","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ChronoBank/ChronoMint/pulls/comments/210006157"},"html":{"href":"https://github.com/ChronoBank/ChronoMint/pull/743#discussion_r210006157"},"pull_request":{"href":"https://api.github.com/repos/ChronoBank/ChronoMint/pulls/743"}}},"pull_request":{"url":"https://api.github.com/repos/ChronoBank/ChronoMint/pulls/743","id":208027561,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MDI3NTYx","html_url":"https://github.com/ChronoBank/ChronoMint/pull/743","diff_url":"https://github.com/ChronoBank/ChronoMint/pull/743.diff","patch_url":"https://github.com/ChronoBank/ChronoMint/pull/743.patch","issue_url":"https://api.github.com/repos/ChronoBank/ChronoMint/issues/743","number":743,"state":"open","locked":false,"title":"[WIP] MINT-1728 remove contract manager dao and other useless code","user":{"login":"wAISw","id":5791100,"node_id":"MDQ6VXNlcjU3OTExMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/5791100?v=4","gravatar_id":"","url":"https://api.github.com/users/wAISw","html_url":"https://github.com/wAISw","followers_url":"https://api.github.com/users/wAISw/followers","following_url":"https://api.github.com/users/wAISw/following{/other_user}","gists_url":"https://api.github.com/users/wAISw/gists{/gist_id}","starred_url":"https://api.github.com/users/wAISw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wAISw/subscriptions","organizations_url":"https://api.github.com/users/wAISw/orgs","repos_url":"https://api.github.com/users/wAISw/repos","events_url":"https://api.github.com/users/wAISw/events{/privacy}","received_events_url":"https://api.github.com/users/wAISw/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-13T16:07:58Z","updated_at":"2018-08-14T15:52:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06de9b519b4d558b59468b4709d6f7650d36f85f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ChronoBank/ChronoMint/pulls/743/commits","review_comments_url":"https://api.github.com/repos/ChronoBank/ChronoMint/pulls/743/comments","review_comment_url":"https://api.github.com/repos/ChronoBank/ChronoMint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ChronoBank/ChronoMint/issues/743/comments","statuses_url":"https://api.github.com/repos/ChronoBank/ChronoMint/statuses/12b22ad747bf0bcc98e7e389934515469e3e13ce","head":{"label":"wAISw:refactoring/MINT-1728-Remove-ContractManagerDao-and-other-useless-code","ref":"refactoring/MINT-1728-Remove-ContractManagerDao-and-other-useless-code","sha":"12b22ad747bf0bcc98e7e389934515469e3e13ce","user":{"login":"wAISw","id":5791100,"node_id":"MDQ6VXNlcjU3OTExMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/5791100?v=4","gravatar_id":"","url":"https://api.github.com/users/wAISw","html_url":"https://github.com/wAISw","followers_url":"https://api.github.com/users/wAISw/followers","following_url":"https://api.github.com/users/wAISw/following{/other_user}","gists_url":"https://api.github.com/users/wAISw/gists{/gist_id}","starred_url":"https://api.github.com/users/wAISw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wAISw/subscriptions","organizations_url":"https://api.github.com/users/wAISw/orgs","repos_url":"https://api.github.com/users/wAISw/repos","events_url":"https://api.github.com/users/wAISw/events{/privacy}","received_events_url":"https://api.github.com/users/wAISw/received_events","type":"User","site_admin":false},"repo":{"id":103130600,"node_id":"MDEwOlJlcG9zaXRvcnkxMDMxMzA2MDA=","name":"ChronoMint","full_name":"wAISw/ChronoMint","owner":{"login":"wAISw","id":5791100,"node_id":"MDQ6VXNlcjU3OTExMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/5791100?v=4","gravatar_id":"","url":"https://api.github.com/users/wAISw","html_url":"https://github.com/wAISw","followers_url":"https://api.github.com/users/wAISw/followers","following_url":"https://api.github.com/users/wAISw/following{/other_user}","gists_url":"https://api.github.com/users/wAISw/gists{/gist_id}","starred_url":"https://api.github.com/users/wAISw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wAISw/subscriptions","organizations_url":"https://api.github.com/users/wAISw/orgs","repos_url":"https://api.github.com/users/wAISw/repos","events_url":"https://api.github.com/users/wAISw/events{/privacy}","received_events_url":"https://api.github.com/users/wAISw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wAISw/ChronoMint","description":"ChronoBank client","fork":true,"url":"https://api.github.com/repos/wAISw/ChronoMint","forks_url":"https://api.github.com/repos/wAISw/ChronoMint/forks","keys_url":"https://api.github.com/repos/wAISw/ChronoMint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wAISw/ChronoMint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wAISw/ChronoMint/teams","hooks_url":"https://api.github.com/repos/wAISw/ChronoMint/hooks","issue_events_url":"https://api.github.com/repos/wAISw/ChronoMint/issues/events{/number}","events_url":"https://api.github.com/repos/wAISw/ChronoMint/events","assignees_url":"https://api.github.com/repos/wAISw/ChronoMint/assignees{/user}","branches_url":"https://api.github.com/repos/wAISw/ChronoMint/branches{/branch}","tags_url":"https://api.github.com/repos/wAISw/ChronoMint/tags","blobs_url":"https://api.github.com/repos/wAISw/ChronoMint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wAISw/ChronoMint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wAISw/ChronoMint/git/refs{/sha}","trees_url":"https://api.github.com/repos/wAISw/ChronoMint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wAISw/ChronoMint/statuses/{sha}","languages_url":"https://api.github.com/repos/wAISw/ChronoMint/languages","stargazers_url":"https://api.github.com/repos/wAISw/ChronoMint/stargazers","contributors_url":"https://api.github.com/repos/wAISw/ChronoMint/contributors","subscribers_url":"https://api.github.com/repos/wAISw/ChronoMint/subscribers","subscription_url":"https://api.github.com/repos/wAISw/ChronoMint/subscription","commits_url":"https://api.github.com/repos/wAISw/ChronoMint/commits{/sha}","git_commits_url":"https://api.github.com/repos/wAISw/ChronoMint/git/commits{/sha}","comments_url":"https://api.github.com/repos/wAISw/ChronoMint/comments{/number}","issue_comment_url":"https://api.github.com/repos/wAISw/ChronoMint/issues/comments{/number}","contents_url":"https://api.github.com/repos/wAISw/ChronoMint/contents/{+path}","compare_url":"https://api.github.com/repos/wAISw/ChronoMint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wAISw/ChronoMint/merges","archive_url":"https://api.github.com/repos/wAISw/ChronoMint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wAISw/ChronoMint/downloads","issues_url":"https://api.github.com/repos/wAISw/ChronoMint/issues{/number}","pulls_url":"https://api.github.com/repos/wAISw/ChronoMint/pulls{/number}","milestones_url":"https://api.github.com/repos/wAISw/ChronoMint/milestones{/number}","notifications_url":"https://api.github.com/repos/wAISw/ChronoMint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wAISw/ChronoMint/labels{/name}","releases_url":"https://api.github.com/repos/wAISw/ChronoMint/releases{/id}","deployments_url":"https://api.github.com/repos/wAISw/ChronoMint/deployments","created_at":"2017-09-11T12:02:02Z","updated_at":"2018-06-25T08:40:18Z","pushed_at":"2018-08-14T14:42:17Z","git_url":"git://github.com/wAISw/ChronoMint.git","ssh_url":"git@github.com:wAISw/ChronoMint.git","clone_url":"https://github.com/wAISw/ChronoMint.git","svn_url":"https://github.com/wAISw/ChronoMint","homepage":"https://mint.chronobank.io","size":23638,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ChronoBank:develop","ref":"develop","sha":"6951433a076f43aba589afcc2c5339790b397eec","user":{"login":"ChronoBank","id":23405498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDA1NDk4","avatar_url":"https://avatars2.githubusercontent.com/u/23405498?v=4","gravatar_id":"","url":"https://api.github.com/users/ChronoBank","html_url":"https://github.com/ChronoBank","followers_url":"https://api.github.com/users/ChronoBank/followers","following_url":"https://api.github.com/users/ChronoBank/following{/other_user}","gists_url":"https://api.github.com/users/ChronoBank/gists{/gist_id}","starred_url":"https://api.github.com/users/ChronoBank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChronoBank/subscriptions","organizations_url":"https://api.github.com/users/ChronoBank/orgs","repos_url":"https://api.github.com/users/ChronoBank/repos","events_url":"https://api.github.com/users/ChronoBank/events{/privacy}","received_events_url":"https://api.github.com/users/ChronoBank/received_events","type":"Organization","site_admin":false},"repo":{"id":73798361,"node_id":"MDEwOlJlcG9zaXRvcnk3Mzc5ODM2MQ==","name":"ChronoMint","full_name":"ChronoBank/ChronoMint","owner":{"login":"ChronoBank","id":23405498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDA1NDk4","avatar_url":"https://avatars2.githubusercontent.com/u/23405498?v=4","gravatar_id":"","url":"https://api.github.com/users/ChronoBank","html_url":"https://github.com/ChronoBank","followers_url":"https://api.github.com/users/ChronoBank/followers","following_url":"https://api.github.com/users/ChronoBank/following{/other_user}","gists_url":"https://api.github.com/users/ChronoBank/gists{/gist_id}","starred_url":"https://api.github.com/users/ChronoBank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChronoBank/subscriptions","organizations_url":"https://api.github.com/users/ChronoBank/orgs","repos_url":"https://api.github.com/users/ChronoBank/repos","events_url":"https://api.github.com/users/ChronoBank/events{/privacy}","received_events_url":"https://api.github.com/users/ChronoBank/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ChronoBank/ChronoMint","description":"ChronoBank client","fork":false,"url":"https://api.github.com/repos/ChronoBank/ChronoMint","forks_url":"https://api.github.com/repos/ChronoBank/ChronoMint/forks","keys_url":"https://api.github.com/repos/ChronoBank/ChronoMint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChronoBank/ChronoMint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChronoBank/ChronoMint/teams","hooks_url":"https://api.github.com/repos/ChronoBank/ChronoMint/hooks","issue_events_url":"https://api.github.com/repos/ChronoBank/ChronoMint/issues/events{/number}","events_url":"https://api.github.com/repos/ChronoBank/ChronoMint/events","assignees_url":"https://api.github.com/repos/ChronoBank/ChronoMint/assignees{/user}","branches_url":"https://api.github.com/repos/ChronoBank/ChronoMint/branches{/branch}","tags_url":"https://api.github.com/repos/ChronoBank/ChronoMint/tags","blobs_url":"https://api.github.com/repos/ChronoBank/ChronoMint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChronoBank/ChronoMint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChronoBank/ChronoMint/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChronoBank/ChronoMint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChronoBank/ChronoMint/statuses/{sha}","languages_url":"https://api.github.com/repos/ChronoBank/ChronoMint/languages","stargazers_url":"https://api.github.com/repos/ChronoBank/ChronoMint/stargazers","contributors_url":"https://api.github.com/repos/ChronoBank/ChronoMint/contributors","subscribers_url":"https://api.github.com/repos/ChronoBank/ChronoMint/subscribers","subscription_url":"https://api.github.com/repos/ChronoBank/ChronoMint/subscription","commits_url":"https://api.github.com/repos/ChronoBank/ChronoMint/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChronoBank/ChronoMint/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChronoBank/ChronoMint/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChronoBank/ChronoMint/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChronoBank/ChronoMint/contents/{+path}","compare_url":"https://api.github.com/repos/ChronoBank/ChronoMint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChronoBank/ChronoMint/merges","archive_url":"https://api.github.com/repos/ChronoBank/ChronoMint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChronoBank/ChronoMint/downloads","issues_url":"https://api.github.com/repos/ChronoBank/ChronoMint/issues{/number}","pulls_url":"https://api.github.com/repos/ChronoBank/ChronoMint/pulls{/number}","milestones_url":"https://api.github.com/repos/ChronoBank/ChronoMint/milestones{/number}","notifications_url":"https://api.github.com/repos/ChronoBank/ChronoMint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChronoBank/ChronoMint/labels{/name}","releases_url":"https://api.github.com/repos/ChronoBank/ChronoMint/releases{/id}","deployments_url":"https://api.github.com/repos/ChronoBank/ChronoMint/deployments","created_at":"2016-11-15T09:34:13Z","updated_at":"2018-08-14T14:38:23Z","pushed_at":"2018-08-14T14:42:18Z","git_url":"git://github.com/ChronoBank/ChronoMint.git","ssh_url":"git@github.com:ChronoBank/ChronoMint.git","clone_url":"https://github.com/ChronoBank/ChronoMint.git","svn_url":"https://github.com/ChronoBank/ChronoMint","homepage":"https://mint.chronobank.io","size":20549,"stargazers_count":30,"watchers_count":30,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":34,"open_issues":4,"watchers":30,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ChronoBank/ChronoMint/pulls/743"},"html":{"href":"https://github.com/ChronoBank/ChronoMint/pull/743"},"issue":{"href":"https://api.github.com/repos/ChronoBank/ChronoMint/issues/743"},"comments":{"href":"https://api.github.com/repos/ChronoBank/ChronoMint/issues/743/comments"},"review_comments":{"href":"https://api.github.com/repos/ChronoBank/ChronoMint/pulls/743/comments"},"review_comment":{"href":"https://api.github.com/repos/ChronoBank/ChronoMint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ChronoBank/ChronoMint/pulls/743/commits"},"statuses":{"href":"https://api.github.com/repos/ChronoBank/ChronoMint/statuses/12b22ad747bf0bcc98e7e389934515469e3e13ce"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ozalexo"}}