{"action":"created","issue":{"url":"https://api.github.com/repos/OpenShot/openshot-qt/issues/1365","repository_url":"https://api.github.com/repos/OpenShot/openshot-qt","labels_url":"https://api.github.com/repos/OpenShot/openshot-qt/issues/1365/labels{/name}","comments_url":"https://api.github.com/repos/OpenShot/openshot-qt/issues/1365/comments","events_url":"https://api.github.com/repos/OpenShot/openshot-qt/issues/1365/events","html_url":"https://github.com/OpenShot/openshot-qt/issues/1365","id":304212092,"number":1365,"title":"Marker positioning is off by a frame.","user":{"login":"ferdnyc","id":538020,"avatar_url":"https://avatars0.githubusercontent.com/u/538020?v=4","gravatar_id":"","url":"https://api.github.com/users/ferdnyc","html_url":"https://github.com/ferdnyc","followers_url":"https://api.github.com/users/ferdnyc/followers","following_url":"https://api.github.com/users/ferdnyc/following{/other_user}","gists_url":"https://api.github.com/users/ferdnyc/gists{/gist_id}","starred_url":"https://api.github.com/users/ferdnyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferdnyc/subscriptions","organizations_url":"https://api.github.com/users/ferdnyc/orgs","repos_url":"https://api.github.com/users/ferdnyc/repos","events_url":"https://api.github.com/users/ferdnyc/events{/privacy}","received_events_url":"https://api.github.com/users/ferdnyc/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-03-12T00:55:47Z","updated_at":"2018-04-28T07:58:15Z","closed_at":"2018-04-28T07:58:15Z","author_association":"CONTRIBUTOR","body":"**System Details:**\r\n* Operating System / Distro: Fedora Linux 27\r\n* OpenShot Version: 2.4.1\r\n\r\n**Issue Description and steps to reproduce:**\r\n\r\nIt took me a while to convince myself of this, but now I'm sure. Markers are being placed one frame ahead of where they should be. Steps:\r\n\r\n1. Zoom all the way in to 1-second granularity on the timeline.\r\n1. Somewhere in the middle of a clip, create a keyframe by (say) adjusting the Volume to less than 1.00.\r\n1. Immediately and without moving the head, click Add Marker. Note the timecode position (mine is 00:00:02:17).\r\n1. Use Next Marker to skip ahead, and then Previous Marker to skip back to the marker you just set.\r\n1. Notice that the Volume parameter is _not_ on a keyframe — it's blue. That's because you're now positioned at 00:00:02:18.\r\n1. Use <kbd>←</kbd> to move one frame left. Timecode changes to 00:00:02:17, Volume turns green.\r\n\r\nThis occurs when approaching the marker from either direction, and it occurs whether you create the marker first or the keyframe first. The marker's always a frame AHEAD of the keyframe, even though they were both set from the same position in the video.\r\n\r\nActually, looking at the timeline, the marker and the keyframe indicator _appear_ to line up (though they don't). The play head lines up visually with the marker (which is positioned one frame ahead of where it's placed), and improperly with the keyframe indicator (which is positioned where it's placed, but **displayed** one frame ahead).\r\n\r\nHere are a marker and keyframe created using the steps above.\r\n\r\n![screenshot from 2018-03-11 20-42-58](https://user-images.githubusercontent.com/538020/37260754-2a44d51c-256d-11e8-89b2-0af8da7060d8.png)\r\n\r\nHere's the position after I skip to the marker (keyframe indicator is _blue_ at this point, timecode is one frame higher than expected):\r\n\r\n![screenshot from 2018-03-11 20-43-08](https://user-images.githubusercontent.com/538020/37260763-35b0c294-256d-11e8-931a-e2f4af97a4df.png)\r\n\r\nAnd after I move one frame left to the keyframe position (head moves to expected timecode, keyframe turns _green_ in properties):\r\n\r\n![screenshot from 2018-03-11 20-43-15](https://user-images.githubusercontent.com/538020/37260771-4647c53a-256d-11e8-9de8-5739163ad721.png)\r\n"},"comment":{"url":"https://api.github.com/repos/OpenShot/openshot-qt/issues/comments/385150770","html_url":"https://github.com/OpenShot/openshot-qt/issues/1365#issuecomment-385150770","issue_url":"https://api.github.com/repos/OpenShot/openshot-qt/issues/1365","id":385150770,"user":{"login":"ferdnyc","id":538020,"avatar_url":"https://avatars0.githubusercontent.com/u/538020?v=4","gravatar_id":"","url":"https://api.github.com/users/ferdnyc","html_url":"https://github.com/ferdnyc","followers_url":"https://api.github.com/users/ferdnyc/followers","following_url":"https://api.github.com/users/ferdnyc/following{/other_user}","gists_url":"https://api.github.com/users/ferdnyc/gists{/gist_id}","starred_url":"https://api.github.com/users/ferdnyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferdnyc/subscriptions","organizations_url":"https://api.github.com/users/ferdnyc/orgs","repos_url":"https://api.github.com/users/ferdnyc/repos","events_url":"https://api.github.com/users/ferdnyc/events{/privacy}","received_events_url":"https://api.github.com/users/ferdnyc/received_events","type":"User","site_admin":false},"created_at":"2018-04-28T07:58:15Z","updated_at":"2018-04-28T07:58:15Z","author_association":"CONTRIBUTOR","body":"The particular issue of marker-positioning (and keyframe-position-display) should be fixed with the merge of #1384."}}
{"actor":{"display_login":"ferdnyc"}}