{"action":"created","issue":{"url":"https://api.github.com/repos/ckeditor/ckeditor5-table/issues/10","repository_url":"https://api.github.com/repos/ckeditor/ckeditor5-table","labels_url":"https://api.github.com/repos/ckeditor/ckeditor5-table/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-table/issues/10/comments","events_url":"https://api.github.com/repos/ckeditor/ckeditor5-table/issues/10/events","html_url":"https://github.com/ckeditor/ckeditor5-table/pull/10","id":321875483,"number":10,"title":"T/9: Table feature","user":{"login":"jodator","id":247363,"avatar_url":"https://avatars3.githubusercontent.com/u/247363?v=4","gravatar_id":"","url":"https://api.github.com/users/jodator","html_url":"https://github.com/jodator","followers_url":"https://api.github.com/users/jodator/followers","following_url":"https://api.github.com/users/jodator/following{/other_user}","gists_url":"https://api.github.com/users/jodator/gists{/gist_id}","starred_url":"https://api.github.com/users/jodator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jodator/subscriptions","organizations_url":"https://api.github.com/users/jodator/orgs","repos_url":"https://api.github.com/users/jodator/repos","events_url":"https://api.github.com/users/jodator/events{/privacy}","received_events_url":"https://api.github.com/users/jodator/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-05-10T09:57:09Z","updated_at":"2018-05-21T08:34:03Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ckeditor/ckeditor5-table/pulls/10","html_url":"https://github.com/ckeditor/ckeditor5-table/pull/10","diff_url":"https://github.com/ckeditor/ckeditor5-table/pull/10.diff","patch_url":"https://github.com/ckeditor/ckeditor5-table/pull/10.patch"},"body":"### Suggested merge commit message ([convention](https://github.com/ckeditor/ckeditor5-design/wiki/Git-commit-message-convention))\r\n\r\nFeature: Initial table support. Closes #4, Closes #7, Closes #9.\r\n\r\n---\r\n\r\n### Additional information\r\n\r\nBased on @Reinmar's input I've updated the code from #6 and this PR introduces:\r\n- The upcast/downcast conversion.\r\n- Table as a widget with table cells as nested editables.\r\n- Full `colspan` and `rowspan` attributes handling.\r\n- Full commands implementation.\r\n- Arbitrary table headers rows/columns.\r\n\r\nWhat this PR does not cover from MVP (#3):\r\n- table styles\r\n- UI\r\n- the `<p>` inside table cell thingy\r\n- clipboad, copy-paste, etc\r\n- probably collaboration will break something\r\n- no caption\r\n\r\nI think that there might be some small issues with commands - resulting in broken table in some situations (mostly related to `rowspan`/`colspan`) but those might be fixed after we start doing UI since using commands from console is not ideal."},"comment":{"url":"https://api.github.com/repos/ckeditor/ckeditor5-table/issues/comments/390589740","html_url":"https://github.com/ckeditor/ckeditor5-table/pull/10#issuecomment-390589740","issue_url":"https://api.github.com/repos/ckeditor/ckeditor5-table/issues/10","id":390589740,"user":{"login":"Reinmar","id":156149,"avatar_url":"https://avatars2.githubusercontent.com/u/156149?v=4","gravatar_id":"","url":"https://api.github.com/users/Reinmar","html_url":"https://github.com/Reinmar","followers_url":"https://api.github.com/users/Reinmar/followers","following_url":"https://api.github.com/users/Reinmar/following{/other_user}","gists_url":"https://api.github.com/users/Reinmar/gists{/gist_id}","starred_url":"https://api.github.com/users/Reinmar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Reinmar/subscriptions","organizations_url":"https://api.github.com/users/Reinmar/orgs","repos_url":"https://api.github.com/users/Reinmar/repos","events_url":"https://api.github.com/users/Reinmar/events{/privacy}","received_events_url":"https://api.github.com/users/Reinmar/received_events","type":"User","site_admin":false},"created_at":"2018-05-21T08:34:03Z","updated_at":"2018-05-21T08:34:03Z","author_association":"MEMBER","body":"> So the colspan/rowspan attribute will be always present on the model so I'd drop it from there. WDYT @scofalik? The only con is that model be a bit bigger this way.\r\n\r\nI don't like this. Ideally, the model should be as clean as possible so other features are able to easily manipulate it without creating issues (like missing attributes). This attribute isn't even needed in HTML so requiring its existence in our model would be a step back."}}
{"actor":{"display_login":"Reinmar"}}