{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/226834257","pull_request_review_id":166756639,"id":226834257,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjgzNDI1Nw==","diff_hunk":"@@ -29,8 +29,8 @@ buildPythonApplication rec {\n   outputs = [ \"out\" \"terminfo\" ];\n \n   postPatch = ''\n-    substituteInPlace kitty/utils.py \\","path":"pkgs/applications/misc/kitty/default.nix","position":4,"original_position":4,"commit_id":"665c7646de5c64b7920890eaf6d9d873f026b789","original_commit_id":"665c7646de5c64b7920890eaf6d9d873f026b789","user":{"login":"vlaci","id":1771332,"node_id":"MDQ6VXNlcjE3NzEzMzI=","avatar_url":"https://avatars2.githubusercontent.com/u/1771332?v=4","gravatar_id":"","url":"https://api.github.com/users/vlaci","html_url":"https://github.com/vlaci","followers_url":"https://api.github.com/users/vlaci/followers","following_url":"https://api.github.com/users/vlaci/following{/other_user}","gists_url":"https://api.github.com/users/vlaci/gists{/gist_id}","starred_url":"https://api.github.com/users/vlaci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlaci/subscriptions","organizations_url":"https://api.github.com/users/vlaci/orgs","repos_url":"https://api.github.com/users/vlaci/repos","events_url":"https://api.github.com/users/vlaci/events{/privacy}","received_events_url":"https://api.github.com/users/vlaci/received_events","type":"User","site_admin":false},"body":"Hm, the other substitution in the Makefile is f[ishy too](https://hydra.nixos.org/build/82946154/log):\r\n```PYTHONPATH=YTHONPATH:.. HOME=MPDIR/nowhere sphinx-build -M html \".\" \"_build\" -T  ```\r\nThe variable substituioons without curly brackets are invalid in makefiles. Will fix it too.","created_at":"2018-10-20T17:38:22Z","updated_at":"2018-10-20T17:38:22Z","html_url":"https://github.com/NixOS/nixpkgs/pull/48747#discussion_r226834257","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48747","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/226834257"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/48747#discussion_r226834257"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48747"}},"in_reply_to_id":226831903},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48747","id":224477459,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NDc3NDU5","html_url":"https://github.com/NixOS/nixpkgs/pull/48747","diff_url":"https://github.com/NixOS/nixpkgs/pull/48747.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/48747.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/48747","number":48747,"state":"open","locked":false,"title":"kitty: fix locating libstartup-notification-1","user":{"login":"vlaci","id":1771332,"node_id":"MDQ6VXNlcjE3NzEzMzI=","avatar_url":"https://avatars2.githubusercontent.com/u/1771332?v=4","gravatar_id":"","url":"https://api.github.com/users/vlaci","html_url":"https://github.com/vlaci","followers_url":"https://api.github.com/users/vlaci/followers","following_url":"https://api.github.com/users/vlaci/following{/other_user}","gists_url":"https://api.github.com/users/vlaci/gists{/gist_id}","starred_url":"https://api.github.com/users/vlaci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlaci/subscriptions","organizations_url":"https://api.github.com/users/vlaci/orgs","repos_url":"https://api.github.com/users/vlaci/repos","events_url":"https://api.github.com/users/vlaci/events{/privacy}","received_events_url":"https://api.github.com/users/vlaci/received_events","type":"User","site_admin":false},"body":"Startup notification doesn't work in recent versions of Kitty:\r\n> Traceback (most recent call last):\r\n>   File \"/nix/store/3a3b0xd952gp8jw70k5kh3a4zhgzf0p7-kitty-0.12.3/bin/../lib/kitty/kitty/utils.py\", line 216, in init_startup_notification\r\n>     return init_startup_notification_x11(window_handle, startup_id)\r\n>   File \"/nix/store/3a3b0xd952gp8jw70k5kh3a4zhgzf0p7-kitty-0.12.3/bin/../lib/kitty/kitty/utils.py\", line 201, in init_startup_notification_x11\r\n>     return init_x11_startup_notification(display, window_handle, sid)\r\n> OSError: Failed to load libstartup-notification-1.so with error: libstartup-notification-1.so: cannot open shared object file: No such file or directory\r\n\r\n###### Motivation for this change\r\n\r\nApparently dispatching of startup notification has been moved to a C\r\nbinding in kitty 0.6.0 [1] so the substituion had to be modified to reflect\r\nthat. Without this fix Kitty still works except that window managers\r\nwhich depend on startup notifications to be fired (e.g. Awesome)\r\ncannot apply special placement rules.\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n\\[1\\]: https://github.com/kovidgoyal/kitty/commit/b08f4ab5937199187581aa20e3a7aba7b2a34ac6\r\n","created_at":"2018-10-20T14:17:07Z","updated_at":"2018-10-20T17:38:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b081a9a1e832ff917657165b8db0d1b2759594d3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":737642262,"node_id":"MDU6TGFiZWw3Mzc2NDIyNjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":731733923,"node_id":"MDU6TGFiZWw3MzE3MzM5MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%201-10","name":"10.rebuild-linux: 1-10","color":"eeffee","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48747/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48747/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/48747/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/665c7646de5c64b7920890eaf6d9d873f026b789","head":{"label":"vlaci:master","ref":"master","sha":"665c7646de5c64b7920890eaf6d9d873f026b789","user":{"login":"vlaci","id":1771332,"node_id":"MDQ6VXNlcjE3NzEzMzI=","avatar_url":"https://avatars2.githubusercontent.com/u/1771332?v=4","gravatar_id":"","url":"https://api.github.com/users/vlaci","html_url":"https://github.com/vlaci","followers_url":"https://api.github.com/users/vlaci/followers","following_url":"https://api.github.com/users/vlaci/following{/other_user}","gists_url":"https://api.github.com/users/vlaci/gists{/gist_id}","starred_url":"https://api.github.com/users/vlaci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlaci/subscriptions","organizations_url":"https://api.github.com/users/vlaci/orgs","repos_url":"https://api.github.com/users/vlaci/repos","events_url":"https://api.github.com/users/vlaci/events{/privacy}","received_events_url":"https://api.github.com/users/vlaci/received_events","type":"User","site_admin":false},"repo":{"id":153911874,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM5MTE4NzQ=","name":"nixpkgs","full_name":"vlaci/nixpkgs","private":false,"owner":{"login":"vlaci","id":1771332,"node_id":"MDQ6VXNlcjE3NzEzMzI=","avatar_url":"https://avatars2.githubusercontent.com/u/1771332?v=4","gravatar_id":"","url":"https://api.github.com/users/vlaci","html_url":"https://github.com/vlaci","followers_url":"https://api.github.com/users/vlaci/followers","following_url":"https://api.github.com/users/vlaci/following{/other_user}","gists_url":"https://api.github.com/users/vlaci/gists{/gist_id}","starred_url":"https://api.github.com/users/vlaci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlaci/subscriptions","organizations_url":"https://api.github.com/users/vlaci/orgs","repos_url":"https://api.github.com/users/vlaci/repos","events_url":"https://api.github.com/users/vlaci/events{/privacy}","received_events_url":"https://api.github.com/users/vlaci/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vlaci/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/vlaci/nixpkgs","forks_url":"https://api.github.com/repos/vlaci/nixpkgs/forks","keys_url":"https://api.github.com/repos/vlaci/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vlaci/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vlaci/nixpkgs/teams","hooks_url":"https://api.github.com/repos/vlaci/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/vlaci/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/vlaci/nixpkgs/events","assignees_url":"https://api.github.com/repos/vlaci/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/vlaci/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/vlaci/nixpkgs/tags","blobs_url":"https://api.github.com/repos/vlaci/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vlaci/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vlaci/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/vlaci/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vlaci/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/vlaci/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/vlaci/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/vlaci/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/vlaci/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/vlaci/nixpkgs/subscription","commits_url":"https://api.github.com/repos/vlaci/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/vlaci/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/vlaci/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/vlaci/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/vlaci/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/vlaci/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vlaci/nixpkgs/merges","archive_url":"https://api.github.com/repos/vlaci/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vlaci/nixpkgs/downloads","issues_url":"https://api.github.com/repos/vlaci/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/vlaci/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/vlaci/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/vlaci/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vlaci/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/vlaci/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/vlaci/nixpkgs/deployments","created_at":"2018-10-20T14:06:11Z","updated_at":"2018-10-20T14:10:31Z","pushed_at":"2018-10-20T14:10:27Z","git_url":"git://github.com/vlaci/nixpkgs.git","ssh_url":"git@github.com:vlaci/nixpkgs.git","clone_url":"https://github.com/vlaci/nixpkgs.git","svn_url":"https://github.com/vlaci/nixpkgs","homepage":null,"size":861412,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"2be930cc4a891a166ee71bc353ce9af297471e2b","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","private":false,"owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-10-20T16:47:25Z","pushed_at":"2018-10-20T17:16:46Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":870808,"stargazers_count":2907,"watchers_count":2907,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3089,"mirror_url":null,"archived":false,"open_issues_count":3314,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3089,"open_issues":3314,"watchers":2907,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48747"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/48747"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/48747"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/48747/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48747/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48747/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/665c7646de5c64b7920890eaf6d9d873f026b789"}},"author_association":"NONE"}}
{"actor":{"display_login":"vlaci"}}