{"action":"created","issue":{"url":"https://api.github.com/repos/Azure/aks-engine/issues/33","repository_url":"https://api.github.com/repos/Azure/aks-engine","labels_url":"https://api.github.com/repos/Azure/aks-engine/issues/33/labels{/name}","comments_url":"https://api.github.com/repos/Azure/aks-engine/issues/33/comments","events_url":"https://api.github.com/repos/Azure/aks-engine/issues/33/events","html_url":"https://github.com/Azure/aks-engine/pull/33","id":381770264,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNjYzMTk0","number":33,"title":"E2E: rationalize node check + kube-system check, no kms","user":{"login":"jackfrancis","id":1494193,"node_id":"MDQ6VXNlcjE0OTQxOTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1494193?v=4","gravatar_id":"","url":"https://api.github.com/users/jackfrancis","html_url":"https://github.com/jackfrancis","followers_url":"https://api.github.com/users/jackfrancis/followers","following_url":"https://api.github.com/users/jackfrancis/following{/other_user}","gists_url":"https://api.github.com/users/jackfrancis/gists{/gist_id}","starred_url":"https://api.github.com/users/jackfrancis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackfrancis/subscriptions","organizations_url":"https://api.github.com/users/jackfrancis/orgs","repos_url":"https://api.github.com/users/jackfrancis/repos","events_url":"https://api.github.com/users/jackfrancis/events{/privacy}","received_events_url":"https://api.github.com/users/jackfrancis/received_events","type":"User","site_admin":false},"labels":[{"id":1128153706,"node_id":"MDU6TGFiZWwxMTI4MTUzNzA2","url":"https://api.github.com/repos/Azure/aks-engine/labels/approved","name":"approved","color":"5df7c4","default":false},{"id":1110478667,"node_id":"MDU6TGFiZWwxMTEwNDc4NjY3","url":"https://api.github.com/repos/Azure/aks-engine/labels/bug","name":"bug","color":"d73a4a","default":true},{"id":1129026020,"node_id":"MDU6TGFiZWwxMTI5MDI2MDIw","url":"https://api.github.com/repos/Azure/aks-engine/labels/lgtm","name":"lgtm","color":"33bc01","default":false},{"id":1128168795,"node_id":"MDU6TGFiZWwxMTI4MTY4Nzk1","url":"https://api.github.com/repos/Azure/aks-engine/labels/size/M","name":"size/M","color":"ddc433","default":false}],"state":"open","locked":false,"assignee":{"login":"tariq1890","id":2658224,"node_id":"MDQ6VXNlcjI2NTgyMjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2658224?v=4","gravatar_id":"","url":"https://api.github.com/users/tariq1890","html_url":"https://github.com/tariq1890","followers_url":"https://api.github.com/users/tariq1890/followers","following_url":"https://api.github.com/users/tariq1890/following{/other_user}","gists_url":"https://api.github.com/users/tariq1890/gists{/gist_id}","starred_url":"https://api.github.com/users/tariq1890/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tariq1890/subscriptions","organizations_url":"https://api.github.com/users/tariq1890/orgs","repos_url":"https://api.github.com/users/tariq1890/repos","events_url":"https://api.github.com/users/tariq1890/events{/privacy}","received_events_url":"https://api.github.com/users/tariq1890/received_events","type":"User","site_admin":false},"assignees":[{"login":"tariq1890","id":2658224,"node_id":"MDQ6VXNlcjI2NTgyMjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2658224?v=4","gravatar_id":"","url":"https://api.github.com/users/tariq1890","html_url":"https://github.com/tariq1890","followers_url":"https://api.github.com/users/tariq1890/followers","following_url":"https://api.github.com/users/tariq1890/following{/other_user}","gists_url":"https://api.github.com/users/tariq1890/gists{/gist_id}","starred_url":"https://api.github.com/users/tariq1890/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tariq1890/subscriptions","organizations_url":"https://api.github.com/users/tariq1890/orgs","repos_url":"https://api.github.com/users/tariq1890/repos","events_url":"https://api.github.com/users/tariq1890/events{/privacy}","received_events_url":"https://api.github.com/users/tariq1890/received_events","type":"User","site_admin":false},{"login":"CecileRobertMichon","id":8650424,"node_id":"MDQ6VXNlcjg2NTA0MjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/8650424?v=4","gravatar_id":"","url":"https://api.github.com/users/CecileRobertMichon","html_url":"https://github.com/CecileRobertMichon","followers_url":"https://api.github.com/users/CecileRobertMichon/followers","following_url":"https://api.github.com/users/CecileRobertMichon/following{/other_user}","gists_url":"https://api.github.com/users/CecileRobertMichon/gists{/gist_id}","starred_url":"https://api.github.com/users/CecileRobertMichon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CecileRobertMichon/subscriptions","organizations_url":"https://api.github.com/users/CecileRobertMichon/orgs","repos_url":"https://api.github.com/users/CecileRobertMichon/repos","events_url":"https://api.github.com/users/CecileRobertMichon/events{/privacy}","received_events_url":"https://api.github.com/users/CecileRobertMichon/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-11-16T21:41:05Z","updated_at":"2018-11-21T16:33:38Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Azure/aks-engine/pulls/33","html_url":"https://github.com/Azure/aks-engine/pull/33","diff_url":"https://github.com/Azure/aks-engine/pull/33.diff","patch_url":"https://github.com/Azure/aks-engine/pull/33.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If you want *faster* PR reviews, read how: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n-->\r\n\r\n**What this PR does / why we need it**: An active \"intermittent zero byte `/etc/kubernetes/azure.json` on master nodes issue\" reveals that we aren't properly (1) testing for the integrity of this cloudprovider file, and (2) our E2E tests are implemented in a way that masks this.\r\n\r\nThis PR re-arranges node readiness checks so that they more clearly communicate the state of nodes before testing, and during the E2E run.\r\n\r\nWe haven't root caused the azure.json issue, but we have repro'd it in isolation w/ KMS encryption enabled, so we're disabling that feature on standard cluster definitions.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Testing**:\r\n- [x] disabled rescheduler addon\r\n- [x] disabled flexvol addons\r\n- [ ] disabled KMS <-- this is the one :)\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```\r\nE2E: rationalize node check + kube-system check, no kms\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/Azure/aks-engine/issues/comments/440729797","html_url":"https://github.com/Azure/aks-engine/pull/33#issuecomment-440729797","issue_url":"https://api.github.com/repos/Azure/aks-engine/issues/33","id":440729797,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDcyOTc5Nw==","user":{"login":"acs-bot","id":24280864,"node_id":"MDQ6VXNlcjI0MjgwODY0","avatar_url":"https://avatars2.githubusercontent.com/u/24280864?v=4","gravatar_id":"","url":"https://api.github.com/users/acs-bot","html_url":"https://github.com/acs-bot","followers_url":"https://api.github.com/users/acs-bot/followers","following_url":"https://api.github.com/users/acs-bot/following{/other_user}","gists_url":"https://api.github.com/users/acs-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/acs-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acs-bot/subscriptions","organizations_url":"https://api.github.com/users/acs-bot/orgs","repos_url":"https://api.github.com/users/acs-bot/repos","events_url":"https://api.github.com/users/acs-bot/events{/privacy}","received_events_url":"https://api.github.com/users/acs-bot/received_events","type":"User","site_admin":false},"created_at":"2018-11-21T16:33:38Z","updated_at":"2018-11-21T16:33:38Z","author_association":"COLLABORATOR","body":"[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/Azure/aks-engine/pull/33#pullrequestreview-177329740\" title=\"LGTM\">CecileRobertMichon</a>*, *<a href=\"https://github.com/Azure/aks-engine/pull/33#\" title=\"Author self-approved\">jackfrancis</a>*, *<a href=\"https://github.com/Azure/aks-engine/pull/33#issuecomment-439562861\" title=\"LGTM\">tariq1890</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[OWNERS](https://github.com/Azure/aks-engine/blob/master/OWNERS)~~ [CecileRobertMichon,jackfrancis,tariq1890]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->"}}
{"actor":{"display_login":"acs-bot"}}