{"action":"created","issue":{"url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/issues/2028","repository_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot","labels_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/issues/2028/labels{/name}","comments_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/issues/2028/comments","events_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/issues/2028/events","html_url":"https://github.com/Cog-Creators/Red-DiscordBot/pull/2028","id":351818750,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MzExMTIy","number":2028,"title":"[Trivia] Move Trivia lists back home","user":{"login":"Tobotimus","id":7438501,"node_id":"MDQ6VXNlcjc0Mzg1MDE=","avatar_url":"https://avatars1.githubusercontent.com/u/7438501?v=4","gravatar_id":"","url":"https://api.github.com/users/Tobotimus","html_url":"https://github.com/Tobotimus","followers_url":"https://api.github.com/users/Tobotimus/followers","following_url":"https://api.github.com/users/Tobotimus/following{/other_user}","gists_url":"https://api.github.com/users/Tobotimus/gists{/gist_id}","starred_url":"https://api.github.com/users/Tobotimus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tobotimus/subscriptions","organizations_url":"https://api.github.com/users/Tobotimus/orgs","repos_url":"https://api.github.com/users/Tobotimus/repos","events_url":"https://api.github.com/users/Tobotimus/events{/privacy}","received_events_url":"https://api.github.com/users/Tobotimus/received_events","type":"User","site_admin":false},"labels":[{"id":1029233076,"node_id":"MDU6TGFiZWwxMDI5MjMzMDc2","url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/labels/QA:%20Bypassed","name":"QA: Bypassed","color":"fcc900","default":false},{"id":1022565515,"node_id":"MDU6TGFiZWwxMDIyNTY1NTE1","url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/labels/Type:%20Fix","name":"Type: Fix","color":"84b6eb","default":false},{"id":593836458,"node_id":"MDU6TGFiZWw1OTM4MzY0NTg=","url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/labels/V3","name":"V3","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/milestones/4","html_url":"https://github.com/Cog-Creators/Red-DiscordBot/milestone/4","labels_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/milestones/4/labels","id":3341613,"node_id":"MDk6TWlsZXN0b25lMzM0MTYxMw==","number":4,"title":"Beta 20","description":"","creator":{"login":"palmtree5","id":3577255,"node_id":"MDQ6VXNlcjM1NzcyNTU=","avatar_url":"https://avatars0.githubusercontent.com/u/3577255?v=4","gravatar_id":"","url":"https://api.github.com/users/palmtree5","html_url":"https://github.com/palmtree5","followers_url":"https://api.github.com/users/palmtree5/followers","following_url":"https://api.github.com/users/palmtree5/following{/other_user}","gists_url":"https://api.github.com/users/palmtree5/gists{/gist_id}","starred_url":"https://api.github.com/users/palmtree5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palmtree5/subscriptions","organizations_url":"https://api.github.com/users/palmtree5/orgs","repos_url":"https://api.github.com/users/palmtree5/repos","events_url":"https://api.github.com/users/palmtree5/events{/privacy}","received_events_url":"https://api.github.com/users/palmtree5/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":16,"state":"open","created_at":"2018-05-13T04:46:18Z","updated_at":"2018-08-24T13:51:27Z","due_on":"2018-08-26T07:00:00Z","closed_at":null},"comments":8,"created_at":"2018-08-18T13:02:22Z","updated_at":"2018-08-24T14:00:56Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/pulls/2028","html_url":"https://github.com/Cog-Creators/Red-DiscordBot/pull/2028","diff_url":"https://github.com/Cog-Creators/Red-DiscordBot/pull/2028.diff","patch_url":"https://github.com/Cog-Creators/Red-DiscordBot/pull/2028.patch"},"body":"This still needs discussion, but this means saying no to namespace packages (*yay*) and also everything I listed on #1973. Discussion on that issue still needs to occur, but I want to get it rolling and make a decision on this soon.\r\n\r\nWhat I've done is move the trivia lists to the `redbot/cogs/trivia/data/lists` directory. The reason I chose and extra `data` sub-directory is for the interest of ease of extensibility, the distribution will now include all files in an existing `data` sub-directory of a package.\r\n\r\nThis also fixes our issue (which has only just been recently discovered) that locale files haven't been included with the distribution since beta 9, due to a line added in #1420: `include_package_data=True`. This reverts that change and also greatly simplifies the data file discovery for the distribution. I'm for more maintainable and straightforward code where possible."},"comment":{"url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/issues/comments/415767801","html_url":"https://github.com/Cog-Creators/Red-DiscordBot/pull/2028#issuecomment-415767801","issue_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/issues/2028","id":415767801,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTc2NzgwMQ==","user":{"login":"Tobotimus","id":7438501,"node_id":"MDQ6VXNlcjc0Mzg1MDE=","avatar_url":"https://avatars1.githubusercontent.com/u/7438501?v=4","gravatar_id":"","url":"https://api.github.com/users/Tobotimus","html_url":"https://github.com/Tobotimus","followers_url":"https://api.github.com/users/Tobotimus/followers","following_url":"https://api.github.com/users/Tobotimus/following{/other_user}","gists_url":"https://api.github.com/users/Tobotimus/gists{/gist_id}","starred_url":"https://api.github.com/users/Tobotimus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tobotimus/subscriptions","organizations_url":"https://api.github.com/users/Tobotimus/orgs","repos_url":"https://api.github.com/users/Tobotimus/repos","events_url":"https://api.github.com/users/Tobotimus/events{/privacy}","received_events_url":"https://api.github.com/users/Tobotimus/received_events","type":"User","site_admin":false},"created_at":"2018-08-24T14:00:56Z","updated_at":"2018-08-24T14:00:56Z","author_association":"MEMBER","body":"Despite the mixed feelings about this I'm putting it into beta 20 as a *possibly temporary* fix for the namespace package issues. It's also a permanent fix for all of our missing translations, and that certainly needs to be fixed for beta 20. Personally I think the trivia files are going to stay where they are regardless."}}
{"actor":{"display_login":"Tobotimus"}}