{"action":"created","issue":{"url":"https://api.github.com/repos/SAP/jenkins-library/issues/183","repository_url":"https://api.github.com/repos/SAP/jenkins-library","labels_url":"https://api.github.com/repos/SAP/jenkins-library/issues/183/labels{/name}","comments_url":"https://api.github.com/repos/SAP/jenkins-library/issues/183/comments","events_url":"https://api.github.com/repos/SAP/jenkins-library/issues/183/events","html_url":"https://github.com/SAP/jenkins-library/pull/183","id":337393241,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NTg5MDE1","number":183,"title":"add step for Sonar scan ","user":{"login":"CCFenner","id":26137398,"node_id":"MDQ6VXNlcjI2MTM3Mzk4","avatar_url":"https://avatars2.githubusercontent.com/u/26137398?v=4","gravatar_id":"","url":"https://api.github.com/users/CCFenner","html_url":"https://github.com/CCFenner","followers_url":"https://api.github.com/users/CCFenner/followers","following_url":"https://api.github.com/users/CCFenner/following{/other_user}","gists_url":"https://api.github.com/users/CCFenner/gists{/gist_id}","starred_url":"https://api.github.com/users/CCFenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CCFenner/subscriptions","organizations_url":"https://api.github.com/users/CCFenner/orgs","repos_url":"https://api.github.com/users/CCFenner/repos","events_url":"https://api.github.com/users/CCFenner/events{/privacy}","received_events_url":"https://api.github.com/users/CCFenner/received_events","type":"User","site_admin":false},"labels":[{"id":983798731,"node_id":"MDU6TGFiZWw5ODM3OTg3MzE=","url":"https://api.github.com/repos/SAP/jenkins-library/labels/ON%20HOLD","name":"ON HOLD","color":"b60205","default":false}],"state":"open","locked":false,"assignee":{"login":"CCFenner","id":26137398,"node_id":"MDQ6VXNlcjI2MTM3Mzk4","avatar_url":"https://avatars2.githubusercontent.com/u/26137398?v=4","gravatar_id":"","url":"https://api.github.com/users/CCFenner","html_url":"https://github.com/CCFenner","followers_url":"https://api.github.com/users/CCFenner/followers","following_url":"https://api.github.com/users/CCFenner/following{/other_user}","gists_url":"https://api.github.com/users/CCFenner/gists{/gist_id}","starred_url":"https://api.github.com/users/CCFenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CCFenner/subscriptions","organizations_url":"https://api.github.com/users/CCFenner/orgs","repos_url":"https://api.github.com/users/CCFenner/repos","events_url":"https://api.github.com/users/CCFenner/events{/privacy}","received_events_url":"https://api.github.com/users/CCFenner/received_events","type":"User","site_admin":false},"assignees":[{"login":"CCFenner","id":26137398,"node_id":"MDQ6VXNlcjI2MTM3Mzk4","avatar_url":"https://avatars2.githubusercontent.com/u/26137398?v=4","gravatar_id":"","url":"https://api.github.com/users/CCFenner","html_url":"https://github.com/CCFenner","followers_url":"https://api.github.com/users/CCFenner/followers","following_url":"https://api.github.com/users/CCFenner/following{/other_user}","gists_url":"https://api.github.com/users/CCFenner/gists{/gist_id}","starred_url":"https://api.github.com/users/CCFenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CCFenner/subscriptions","organizations_url":"https://api.github.com/users/CCFenner/orgs","repos_url":"https://api.github.com/users/CCFenner/repos","events_url":"https://api.github.com/users/CCFenner/events{/privacy}","received_events_url":"https://api.github.com/users/CCFenner/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-07-02T07:04:51Z","updated_at":"2018-11-07T10:14:29Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/SAP/jenkins-library/pulls/183","html_url":"https://github.com/SAP/jenkins-library/pull/183","diff_url":"https://github.com/SAP/jenkins-library/pull/183.diff","patch_url":"https://github.com/SAP/jenkins-library/pull/183.patch"},"body":"**changes**\r\n- add new step `sonarExecute` to execute scan with [sonarcloud.io](https://sonarcloud.io)\r\n- [x] add tests for new step"},"comment":{"url":"https://api.github.com/repos/SAP/jenkins-library/issues/comments/436574095","html_url":"https://github.com/SAP/jenkins-library/pull/183#issuecomment-436574095","issue_url":"https://api.github.com/repos/SAP/jenkins-library/issues/183","id":436574095,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjU3NDA5NQ==","user":{"login":"marcusholl","id":1853183,"node_id":"MDQ6VXNlcjE4NTMxODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1853183?v=4","gravatar_id":"","url":"https://api.github.com/users/marcusholl","html_url":"https://github.com/marcusholl","followers_url":"https://api.github.com/users/marcusholl/followers","following_url":"https://api.github.com/users/marcusholl/following{/other_user}","gists_url":"https://api.github.com/users/marcusholl/gists{/gist_id}","starred_url":"https://api.github.com/users/marcusholl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcusholl/subscriptions","organizations_url":"https://api.github.com/users/marcusholl/orgs","repos_url":"https://api.github.com/users/marcusholl/repos","events_url":"https://api.github.com/users/marcusholl/events{/privacy}","received_events_url":"https://api.github.com/users/marcusholl/received_events","type":"User","site_admin":false},"created_at":"2018-11-07T10:14:29Z","updated_at":"2018-11-07T10:14:29Z","author_association":"CONTRIBUTOR","body":"How should we deal with simply using docker images from the outside world? Basically we should review those images since we actually don't know what happens in those images. And of course we should have some kind of a process so that we can reproduce a certain image has been reviewed. \r\n\r\nIn case we are not able to review images from outside: what about providing our own images where we know what is contained in it (... of course we have to review the base image(s) in this case or agree on some trusted provided images). Bad thing here: maintaining images where we have already existing corresponding  images in the outside world images outside is also not that cool.\r\n\r\nInstalling additional tools on the fly from whatever location is also problematic. In case the site we are downloading from is not reachable we get build failures ... also not that cool. Site note: are there any hashes published we can check the downloaded entity in order to verify we install what we think we install?\r\n\r\n"}}
{"actor":{"display_login":"marcusholl"}}