{"action":"created","issue":{"url":"https://api.github.com/repos/Bioconductor/Contributions/issues/878","repository_url":"https://api.github.com/repos/Bioconductor/Contributions","labels_url":"https://api.github.com/repos/Bioconductor/Contributions/issues/878/labels{/name}","comments_url":"https://api.github.com/repos/Bioconductor/Contributions/issues/878/comments","events_url":"https://api.github.com/repos/Bioconductor/Contributions/issues/878/events","html_url":"https://github.com/Bioconductor/Contributions/issues/878","id":362067423,"node_id":"MDU6SXNzdWUzNjIwNjc0MjM=","number":878,"title":"bayNorm","user":{"login":"WT215","id":17357061,"node_id":"MDQ6VXNlcjE3MzU3MDYx","avatar_url":"https://avatars0.githubusercontent.com/u/17357061?v=4","gravatar_id":"","url":"https://api.github.com/users/WT215","html_url":"https://github.com/WT215","followers_url":"https://api.github.com/users/WT215/followers","following_url":"https://api.github.com/users/WT215/following{/other_user}","gists_url":"https://api.github.com/users/WT215/gists{/gist_id}","starred_url":"https://api.github.com/users/WT215/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WT215/subscriptions","organizations_url":"https://api.github.com/users/WT215/orgs","repos_url":"https://api.github.com/users/WT215/repos","events_url":"https://api.github.com/users/WT215/events{/privacy}","received_events_url":"https://api.github.com/users/WT215/received_events","type":"User","site_admin":false},"labels":[{"id":335833554,"node_id":"MDU6TGFiZWwzMzU4MzM1NTQ=","url":"https://api.github.com/repos/Bioconductor/Contributions/labels/2.%20review%20in%20progress","name":"2. review in progress","color":"1881c2","default":false},{"id":335833326,"node_id":"MDU6TGFiZWwzMzU4MzMzMjY=","url":"https://api.github.com/repos/Bioconductor/Contributions/labels/OK","name":"OK","color":"228822","default":false}],"state":"open","locked":false,"assignee":{"login":"lshep","id":18724380,"node_id":"MDQ6VXNlcjE4NzI0Mzgw","avatar_url":"https://avatars3.githubusercontent.com/u/18724380?v=4","gravatar_id":"","url":"https://api.github.com/users/lshep","html_url":"https://github.com/lshep","followers_url":"https://api.github.com/users/lshep/followers","following_url":"https://api.github.com/users/lshep/following{/other_user}","gists_url":"https://api.github.com/users/lshep/gists{/gist_id}","starred_url":"https://api.github.com/users/lshep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lshep/subscriptions","organizations_url":"https://api.github.com/users/lshep/orgs","repos_url":"https://api.github.com/users/lshep/repos","events_url":"https://api.github.com/users/lshep/events{/privacy}","received_events_url":"https://api.github.com/users/lshep/received_events","type":"User","site_admin":false},"assignees":[{"login":"lshep","id":18724380,"node_id":"MDQ6VXNlcjE4NzI0Mzgw","avatar_url":"https://avatars3.githubusercontent.com/u/18724380?v=4","gravatar_id":"","url":"https://api.github.com/users/lshep","html_url":"https://github.com/lshep","followers_url":"https://api.github.com/users/lshep/followers","following_url":"https://api.github.com/users/lshep/following{/other_user}","gists_url":"https://api.github.com/users/lshep/gists{/gist_id}","starred_url":"https://api.github.com/users/lshep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lshep/subscriptions","organizations_url":"https://api.github.com/users/lshep/orgs","repos_url":"https://api.github.com/users/lshep/repos","events_url":"https://api.github.com/users/lshep/events{/privacy}","received_events_url":"https://api.github.com/users/lshep/received_events","type":"User","site_admin":false}],"milestone":null,"comments":27,"created_at":"2018-09-20T08:09:58Z","updated_at":"2018-10-05T15:37:47Z","closed_at":null,"author_association":"NONE","body":"Update the following URL to point to the GitHub repository of\r\nthe package you wish to submit to _Bioconductor_\r\n\r\n- Repository: https://github.com/WT215/bayNorm\r\n\r\nConfirm the following by editing each check box to '[x]'\r\n\r\n- [x] I understand that by submitting my package to _Bioconductor_,\r\n  the package source and all review commentary are visible to the\r\n  general public.\r\n\r\n- [x] I have read the _Bioconductor_ [Package Submission][2]\r\n  instructions. My package is consistent with the _Bioconductor_\r\n  [Package Guidelines][1].\r\n\r\n- [x] I understand that a minimum requirement for package acceptance \r\n  is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. \r\n  Passing these checks does not result in automatic acceptance. The \r\n  package will then undergo a formal review and recommendations for \r\n  acceptance regarding other Bioconductor standards will be addressed.\r\n\r\n- [x] My package addresses statistical or bioinformatic issues related\r\n  to the analysis and comprehension of high throughput genomic data.\r\n\r\n- [x] I am committed to the long-term maintenance of my package. This\r\n  includes monitoring the [support site][3] for issues that users may\r\n  have, subscribing to the [bioc-devel][4] mailing list to stay aware\r\n  of developments in the _Bioconductor_ community, responding promptly\r\n  to requests for updates from the Core team in response to changes in\r\n  _R_ or underlying software.\r\n\r\nI am familiar with the essential aspects of _Bioconductor_ software\r\nmanagement, including:\r\n\r\n- [x] The 'devel' branch for new packages and features.\r\n- [x] The stable 'release' branch, made available every six\r\n      months, for bug fixes.\r\n- [x] _Bioconductor_ version control using [Git][5]\r\n  (optionally [via GitHub][6]).\r\n\r\nFor help with submitting your package, please subscribe and post questions\r\nto the [bioc-devel][4] mailing list.\r\n\r\n[1]: https://bioconductor.org/developers/package-guidelines/\r\n[2]: https://bioconductor.org/developers/package-submission/\r\n[3]: https://support.bioconductor.org\r\n[4]: https://stat.ethz.ch/mailman/listinfo/bioc-devel\r\n[5]: http://bioconductor.org/developers/how-to/git/\r\n[6]: http://bioconductor.org/developers/how-to/git/sync-existing-repositories/\r\n"},"comment":{"url":"https://api.github.com/repos/Bioconductor/Contributions/issues/comments/427408025","html_url":"https://github.com/Bioconductor/Contributions/issues/878#issuecomment-427408025","issue_url":"https://api.github.com/repos/Bioconductor/Contributions/issues/878","id":427408025,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzQwODAyNQ==","user":{"login":"WT215","id":17357061,"node_id":"MDQ6VXNlcjE3MzU3MDYx","avatar_url":"https://avatars0.githubusercontent.com/u/17357061?v=4","gravatar_id":"","url":"https://api.github.com/users/WT215","html_url":"https://github.com/WT215","followers_url":"https://api.github.com/users/WT215/followers","following_url":"https://api.github.com/users/WT215/following{/other_user}","gists_url":"https://api.github.com/users/WT215/gists{/gist_id}","starred_url":"https://api.github.com/users/WT215/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WT215/subscriptions","organizations_url":"https://api.github.com/users/WT215/orgs","repos_url":"https://api.github.com/users/WT215/repos","events_url":"https://api.github.com/users/WT215/events{/privacy}","received_events_url":"https://api.github.com/users/WT215/received_events","type":"User","site_admin":false},"created_at":"2018-10-05T15:37:47Z","updated_at":"2018-10-05T15:37:47Z","author_association":"NONE","body":"Hi @lshep, thank you for your re-review. \r\n\r\nRegard to your **General** opinions:\r\n\r\n1. `bayNorm` is adapted with `SummarizedExperiment`, so do I still incorporated `SingleCellExperiment` class?\r\n2. The algorithms and comparison between `bayNorm` and other normalization methods (like `SCnorm`) have been posted in `bioRxiv`: <a href=\"https://www.biorxiv.org/content/early/2018/08/03/384586\">Tang <em>et al.</em> (2018). bioRxiv. </a>. We cited the paper in `README`. The vignette could be too verbose if we discussed details of algorithms there.\r\n\r\nI will updated the `vignette` as soon as possible.\r\n\r\nThank you very much!\r\n\r\nBest wishes,\r\nWenhao"}}
{"actor":{"display_login":"WT215"}}