{"action":"closed","number":178,"pull_request":{"url":"https://api.github.com/repos/drcmda/react-spring/pulls/178","id":207778682,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3Nzc4Njgy","html_url":"https://github.com/drcmda/react-spring/pull/178","diff_url":"https://github.com/drcmda/react-spring/pull/178.diff","patch_url":"https://github.com/drcmda/react-spring/pull/178.patch","issue_url":"https://api.github.com/repos/drcmda/react-spring/issues/178","number":178,"state":"closed","locked":false,"title":"Storybook and unit tests","user":{"login":"wilcoschoneveld","id":3064588,"node_id":"MDQ6VXNlcjMwNjQ1ODg=","avatar_url":"https://avatars1.githubusercontent.com/u/3064588?v=4","gravatar_id":"","url":"https://api.github.com/users/wilcoschoneveld","html_url":"https://github.com/wilcoschoneveld","followers_url":"https://api.github.com/users/wilcoschoneveld/followers","following_url":"https://api.github.com/users/wilcoschoneveld/following{/other_user}","gists_url":"https://api.github.com/users/wilcoschoneveld/gists{/gist_id}","starred_url":"https://api.github.com/users/wilcoschoneveld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilcoschoneveld/subscriptions","organizations_url":"https://api.github.com/users/wilcoschoneveld/orgs","repos_url":"https://api.github.com/users/wilcoschoneveld/repos","events_url":"https://api.github.com/users/wilcoschoneveld/events{/privacy}","received_events_url":"https://api.github.com/users/wilcoschoneveld/received_events","type":"User","site_admin":false},"body":"Hey!\r\n\r\nI've smashed together a proof of concept for creating unit tests with storybooks. The stories can be used for demonstration purposes as well as testing the animation logic.\r\n\r\n- I've used yarn to set things up ([storybooks doesn't work well with npm](https://github.com/storybooks/storybook/issues/3044)) \r\n- I don't fully understand what your dev workflow is yet, so I might have broken some things\r\n- You can start storybooks with `yarn storybook`\r\n- I've added two basic stories (a fade in and move to right animation)\r\n- I stub the requestAnimationFrame method to allow stepping through the animations\r\n- I've shown that the properties of the animated div can be inspected in a unit test\r\n\r\nIt's a very rough proof of concept, what do you think?","created_at":"2018-08-11T15:10:03Z","updated_at":"2018-08-28T07:07:37Z","closed_at":"2018-08-28T07:07:36Z","merged_at":"2018-08-28T07:07:36Z","merge_commit_sha":"1dcc5ec4c48687d79d926bc95beda3d88b7f646f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/drcmda/react-spring/pulls/178/commits","review_comments_url":"https://api.github.com/repos/drcmda/react-spring/pulls/178/comments","review_comment_url":"https://api.github.com/repos/drcmda/react-spring/pulls/comments{/number}","comments_url":"https://api.github.com/repos/drcmda/react-spring/issues/178/comments","statuses_url":"https://api.github.com/repos/drcmda/react-spring/statuses/472f56b5a5cd12b4375cb3c79396813f96e82de5","head":{"label":"wilcoschoneveld:storybooks","ref":"storybooks","sha":"472f56b5a5cd12b4375cb3c79396813f96e82de5","user":{"login":"wilcoschoneveld","id":3064588,"node_id":"MDQ6VXNlcjMwNjQ1ODg=","avatar_url":"https://avatars1.githubusercontent.com/u/3064588?v=4","gravatar_id":"","url":"https://api.github.com/users/wilcoschoneveld","html_url":"https://github.com/wilcoschoneveld","followers_url":"https://api.github.com/users/wilcoschoneveld/followers","following_url":"https://api.github.com/users/wilcoschoneveld/following{/other_user}","gists_url":"https://api.github.com/users/wilcoschoneveld/gists{/gist_id}","starred_url":"https://api.github.com/users/wilcoschoneveld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilcoschoneveld/subscriptions","organizations_url":"https://api.github.com/users/wilcoschoneveld/orgs","repos_url":"https://api.github.com/users/wilcoschoneveld/repos","events_url":"https://api.github.com/users/wilcoschoneveld/events{/privacy}","received_events_url":"https://api.github.com/users/wilcoschoneveld/received_events","type":"User","site_admin":false},"repo":{"id":144394344,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQzOTQzNDQ=","name":"react-spring","full_name":"wilcoschoneveld/react-spring","owner":{"login":"wilcoschoneveld","id":3064588,"node_id":"MDQ6VXNlcjMwNjQ1ODg=","avatar_url":"https://avatars1.githubusercontent.com/u/3064588?v=4","gravatar_id":"","url":"https://api.github.com/users/wilcoschoneveld","html_url":"https://github.com/wilcoschoneveld","followers_url":"https://api.github.com/users/wilcoschoneveld/followers","following_url":"https://api.github.com/users/wilcoschoneveld/following{/other_user}","gists_url":"https://api.github.com/users/wilcoschoneveld/gists{/gist_id}","starred_url":"https://api.github.com/users/wilcoschoneveld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilcoschoneveld/subscriptions","organizations_url":"https://api.github.com/users/wilcoschoneveld/orgs","repos_url":"https://api.github.com/users/wilcoschoneveld/repos","events_url":"https://api.github.com/users/wilcoschoneveld/events{/privacy}","received_events_url":"https://api.github.com/users/wilcoschoneveld/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wilcoschoneveld/react-spring","description":"🙌 Helping react-motion and animated to become best friends","fork":true,"url":"https://api.github.com/repos/wilcoschoneveld/react-spring","forks_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/forks","keys_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/teams","hooks_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/hooks","issue_events_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/issues/events{/number}","events_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/events","assignees_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/assignees{/user}","branches_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/branches{/branch}","tags_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/tags","blobs_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/git/refs{/sha}","trees_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/statuses/{sha}","languages_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/languages","stargazers_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/stargazers","contributors_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/contributors","subscribers_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/subscribers","subscription_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/subscription","commits_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/commits{/sha}","git_commits_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/git/commits{/sha}","comments_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/comments{/number}","issue_comment_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/issues/comments{/number}","contents_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/contents/{+path}","compare_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/merges","archive_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/downloads","issues_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/issues{/number}","pulls_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/pulls{/number}","milestones_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/milestones{/number}","notifications_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/labels{/name}","releases_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/releases{/id}","deployments_url":"https://api.github.com/repos/wilcoschoneveld/react-spring/deployments","created_at":"2018-08-11T15:00:18Z","updated_at":"2018-08-11T15:00:20Z","pushed_at":"2018-08-26T14:42:34Z","git_url":"git://github.com/wilcoschoneveld/react-spring.git","ssh_url":"git@github.com:wilcoschoneveld/react-spring.git","clone_url":"https://github.com/wilcoschoneveld/react-spring.git","svn_url":"https://github.com/wilcoschoneveld/react-spring","homepage":"http://react-spring.surge.sh/","size":43331,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"drcmda:master","ref":"master","sha":"3f0deadd5bf2f1ea6e5ea852c95872af54975361","user":{"login":"drcmda","id":2223602,"node_id":"MDQ6VXNlcjIyMjM2MDI=","avatar_url":"https://avatars0.githubusercontent.com/u/2223602?v=4","gravatar_id":"","url":"https://api.github.com/users/drcmda","html_url":"https://github.com/drcmda","followers_url":"https://api.github.com/users/drcmda/followers","following_url":"https://api.github.com/users/drcmda/following{/other_user}","gists_url":"https://api.github.com/users/drcmda/gists{/gist_id}","starred_url":"https://api.github.com/users/drcmda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drcmda/subscriptions","organizations_url":"https://api.github.com/users/drcmda/orgs","repos_url":"https://api.github.com/users/drcmda/repos","events_url":"https://api.github.com/users/drcmda/events{/privacy}","received_events_url":"https://api.github.com/users/drcmda/received_events","type":"User","site_admin":false},"repo":{"id":124257233,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQyNTcyMzM=","name":"react-spring","full_name":"drcmda/react-spring","owner":{"login":"drcmda","id":2223602,"node_id":"MDQ6VXNlcjIyMjM2MDI=","avatar_url":"https://avatars0.githubusercontent.com/u/2223602?v=4","gravatar_id":"","url":"https://api.github.com/users/drcmda","html_url":"https://github.com/drcmda","followers_url":"https://api.github.com/users/drcmda/followers","following_url":"https://api.github.com/users/drcmda/following{/other_user}","gists_url":"https://api.github.com/users/drcmda/gists{/gist_id}","starred_url":"https://api.github.com/users/drcmda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drcmda/subscriptions","organizations_url":"https://api.github.com/users/drcmda/orgs","repos_url":"https://api.github.com/users/drcmda/repos","events_url":"https://api.github.com/users/drcmda/events{/privacy}","received_events_url":"https://api.github.com/users/drcmda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drcmda/react-spring","description":"🙌 Helping react-motion and animated to become best friends","fork":false,"url":"https://api.github.com/repos/drcmda/react-spring","forks_url":"https://api.github.com/repos/drcmda/react-spring/forks","keys_url":"https://api.github.com/repos/drcmda/react-spring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drcmda/react-spring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drcmda/react-spring/teams","hooks_url":"https://api.github.com/repos/drcmda/react-spring/hooks","issue_events_url":"https://api.github.com/repos/drcmda/react-spring/issues/events{/number}","events_url":"https://api.github.com/repos/drcmda/react-spring/events","assignees_url":"https://api.github.com/repos/drcmda/react-spring/assignees{/user}","branches_url":"https://api.github.com/repos/drcmda/react-spring/branches{/branch}","tags_url":"https://api.github.com/repos/drcmda/react-spring/tags","blobs_url":"https://api.github.com/repos/drcmda/react-spring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drcmda/react-spring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drcmda/react-spring/git/refs{/sha}","trees_url":"https://api.github.com/repos/drcmda/react-spring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drcmda/react-spring/statuses/{sha}","languages_url":"https://api.github.com/repos/drcmda/react-spring/languages","stargazers_url":"https://api.github.com/repos/drcmda/react-spring/stargazers","contributors_url":"https://api.github.com/repos/drcmda/react-spring/contributors","subscribers_url":"https://api.github.com/repos/drcmda/react-spring/subscribers","subscription_url":"https://api.github.com/repos/drcmda/react-spring/subscription","commits_url":"https://api.github.com/repos/drcmda/react-spring/commits{/sha}","git_commits_url":"https://api.github.com/repos/drcmda/react-spring/git/commits{/sha}","comments_url":"https://api.github.com/repos/drcmda/react-spring/comments{/number}","issue_comment_url":"https://api.github.com/repos/drcmda/react-spring/issues/comments{/number}","contents_url":"https://api.github.com/repos/drcmda/react-spring/contents/{+path}","compare_url":"https://api.github.com/repos/drcmda/react-spring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drcmda/react-spring/merges","archive_url":"https://api.github.com/repos/drcmda/react-spring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drcmda/react-spring/downloads","issues_url":"https://api.github.com/repos/drcmda/react-spring/issues{/number}","pulls_url":"https://api.github.com/repos/drcmda/react-spring/pulls{/number}","milestones_url":"https://api.github.com/repos/drcmda/react-spring/milestones{/number}","notifications_url":"https://api.github.com/repos/drcmda/react-spring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drcmda/react-spring/labels{/name}","releases_url":"https://api.github.com/repos/drcmda/react-spring/releases{/id}","deployments_url":"https://api.github.com/repos/drcmda/react-spring/deployments","created_at":"2018-03-07T15:39:32Z","updated_at":"2018-08-28T06:50:28Z","pushed_at":"2018-08-28T07:07:36Z","git_url":"git://github.com/drcmda/react-spring.git","ssh_url":"git@github.com:drcmda/react-spring.git","clone_url":"https://github.com/drcmda/react-spring.git","svn_url":"https://github.com/drcmda/react-spring","homepage":"http://react-spring.surge.sh/","size":43220,"stargazers_count":7010,"watchers_count":7010,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":261,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":261,"open_issues":12,"watchers":7010,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/drcmda/react-spring/pulls/178"},"html":{"href":"https://github.com/drcmda/react-spring/pull/178"},"issue":{"href":"https://api.github.com/repos/drcmda/react-spring/issues/178"},"comments":{"href":"https://api.github.com/repos/drcmda/react-spring/issues/178/comments"},"review_comments":{"href":"https://api.github.com/repos/drcmda/react-spring/pulls/178/comments"},"review_comment":{"href":"https://api.github.com/repos/drcmda/react-spring/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/drcmda/react-spring/pulls/178/commits"},"statuses":{"href":"https://api.github.com/repos/drcmda/react-spring/statuses/472f56b5a5cd12b4375cb3c79396813f96e82de5"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"drcmda","id":2223602,"node_id":"MDQ6VXNlcjIyMjM2MDI=","avatar_url":"https://avatars0.githubusercontent.com/u/2223602?v=4","gravatar_id":"","url":"https://api.github.com/users/drcmda","html_url":"https://github.com/drcmda","followers_url":"https://api.github.com/users/drcmda/followers","following_url":"https://api.github.com/users/drcmda/following{/other_user}","gists_url":"https://api.github.com/users/drcmda/gists{/gist_id}","starred_url":"https://api.github.com/users/drcmda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drcmda/subscriptions","organizations_url":"https://api.github.com/users/drcmda/orgs","repos_url":"https://api.github.com/users/drcmda/repos","events_url":"https://api.github.com/users/drcmda/events{/privacy}","received_events_url":"https://api.github.com/users/drcmda/received_events","type":"User","site_admin":false},"comments":9,"review_comments":0,"maintainer_can_modify":false,"commits":16,"additions":3029,"deletions":10098,"changed_files":23}}
{"actor":{"display_login":"drcmda"}}