{"action":"created","comment":{"url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/pulls/comments/194045236","pull_request_review_id":127146029,"id":194045236,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDA0NTIzNg==","diff_hunk":"@@ -140,7 +165,8 @@ EFUArgs::Status EFUArgs::parseFirstPass(const int argc, char *argv[]) {\n   } catch (const CLI::ParseError &e) {\n     CLIParser.exit(e);\n   }\n-  if ((*HelpOption and not *DetectorOption) or (not *HelpOption and not *DetectorOption)) {\n+  if ((*HelpOption and not*DetectorOption) or\n+      (not*HelpOption and not*DetectorOption)) {","path":"prototype2/common/EFUArgs.cpp","position":115,"original_position":115,"commit_id":"6da995a08d1cba46ce4b2793217ba9a5772cc0c3","original_commit_id":"4e5d2648b0fcaf466eacc92286381c66f99a6ff3","user":{"login":"SkyToGround","id":58835,"node_id":"MDQ6VXNlcjU4ODM1","avatar_url":"https://avatars1.githubusercontent.com/u/58835?v=4","gravatar_id":"","url":"https://api.github.com/users/SkyToGround","html_url":"https://github.com/SkyToGround","followers_url":"https://api.github.com/users/SkyToGround/followers","following_url":"https://api.github.com/users/SkyToGround/following{/other_user}","gists_url":"https://api.github.com/users/SkyToGround/gists{/gist_id}","starred_url":"https://api.github.com/users/SkyToGround/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkyToGround/subscriptions","organizations_url":"https://api.github.com/users/SkyToGround/orgs","repos_url":"https://api.github.com/users/SkyToGround/repos","events_url":"https://api.github.com/users/SkyToGround/events{/privacy}","received_events_url":"https://api.github.com/users/SkyToGround/received_events","type":"User","site_admin":false},"body":"Looking at it one last time, the code __is correct__. However, despite your first comment I had not noticed that the Help-flag did nothing.\r\nWith that said, seeing as the code __is correct__ and that the current version better explains what is happening than `not *DetectorOption` and that we have no performance to worry about, I suggest that we leave it as is.","created_at":"2018-06-08T12:44:49Z","updated_at":"2018-06-08T12:44:49Z","html_url":"https://github.com/ess-dmsc/event-formation-unit/pull/69#discussion_r194045236","pull_request_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/pulls/69","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ess-dmsc/event-formation-unit/pulls/comments/194045236"},"html":{"href":"https://github.com/ess-dmsc/event-formation-unit/pull/69#discussion_r194045236"},"pull_request":{"href":"https://api.github.com/repos/ess-dmsc/event-formation-unit/pulls/69"}},"in_reply_to_id":193785224},"pull_request":{"url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/pulls/69","id":193215712,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMjE1NzEy","html_url":"https://github.com/ess-dmsc/event-formation-unit/pull/69","diff_url":"https://github.com/ess-dmsc/event-formation-unit/pull/69.diff","patch_url":"https://github.com/ess-dmsc/event-formation-unit/pull/69.patch","issue_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/issues/69","number":69,"state":"open","locked":false,"title":"Add statically linked modules and simplify dynamically loaded modules","user":{"login":"SkyToGround","id":58835,"node_id":"MDQ6VXNlcjU4ODM1","avatar_url":"https://avatars1.githubusercontent.com/u/58835?v=4","gravatar_id":"","url":"https://api.github.com/users/SkyToGround","html_url":"https://github.com/SkyToGround","followers_url":"https://api.github.com/users/SkyToGround/followers","following_url":"https://api.github.com/users/SkyToGround/following{/other_user}","gists_url":"https://api.github.com/users/SkyToGround/gists{/gist_id}","starred_url":"https://api.github.com/users/SkyToGround/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkyToGround/subscriptions","organizations_url":"https://api.github.com/users/SkyToGround/orgs","repos_url":"https://api.github.com/users/SkyToGround/repos","events_url":"https://api.github.com/users/SkyToGround/events{/privacy}","received_events_url":"https://api.github.com/users/SkyToGround/received_events","type":"User","site_admin":false},"body":"Adds code support for statically linked detector modules. Some minor CMake changes are also required for them to work but these are left out for now. Has unit tests for the registration part of the code but not for the CLI part or the module loading part as no unit tests existed for these to begin with.","created_at":"2018-06-07T06:30:01Z","updated_at":"2018-06-08T12:44:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aeb4388e53e03640f00d71a14d0f89c76c6e4967","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/pulls/69/commits","review_comments_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/pulls/69/comments","review_comment_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/issues/69/comments","statuses_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/statuses/6da995a08d1cba46ce4b2793217ba9a5772cc0c3","head":{"label":"ess-dmsc:JIRA_issue_DM-948","ref":"JIRA_issue_DM-948","sha":"6da995a08d1cba46ce4b2793217ba9a5772cc0c3","user":{"login":"ess-dmsc","id":12100833,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAwODMz","avatar_url":"https://avatars1.githubusercontent.com/u/12100833?v=4","gravatar_id":"","url":"https://api.github.com/users/ess-dmsc","html_url":"https://github.com/ess-dmsc","followers_url":"https://api.github.com/users/ess-dmsc/followers","following_url":"https://api.github.com/users/ess-dmsc/following{/other_user}","gists_url":"https://api.github.com/users/ess-dmsc/gists{/gist_id}","starred_url":"https://api.github.com/users/ess-dmsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ess-dmsc/subscriptions","organizations_url":"https://api.github.com/users/ess-dmsc/orgs","repos_url":"https://api.github.com/users/ess-dmsc/repos","events_url":"https://api.github.com/users/ess-dmsc/events{/privacy}","received_events_url":"https://api.github.com/users/ess-dmsc/received_events","type":"Organization","site_admin":false},"repo":{"id":80731668,"node_id":"MDEwOlJlcG9zaXRvcnk4MDczMTY2OA==","name":"event-formation-unit","full_name":"ess-dmsc/event-formation-unit","owner":{"login":"ess-dmsc","id":12100833,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAwODMz","avatar_url":"https://avatars1.githubusercontent.com/u/12100833?v=4","gravatar_id":"","url":"https://api.github.com/users/ess-dmsc","html_url":"https://github.com/ess-dmsc","followers_url":"https://api.github.com/users/ess-dmsc/followers","following_url":"https://api.github.com/users/ess-dmsc/following{/other_user}","gists_url":"https://api.github.com/users/ess-dmsc/gists{/gist_id}","starred_url":"https://api.github.com/users/ess-dmsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ess-dmsc/subscriptions","organizations_url":"https://api.github.com/users/ess-dmsc/orgs","repos_url":"https://api.github.com/users/ess-dmsc/repos","events_url":"https://api.github.com/users/ess-dmsc/events{/privacy}","received_events_url":"https://api.github.com/users/ess-dmsc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ess-dmsc/event-formation-unit","description":"Implementation of neutron event formation pipeline for ESS","fork":false,"url":"https://api.github.com/repos/ess-dmsc/event-formation-unit","forks_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/forks","keys_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/teams","hooks_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/hooks","issue_events_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/issues/events{/number}","events_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/events","assignees_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/assignees{/user}","branches_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/branches{/branch}","tags_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/tags","blobs_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/git/refs{/sha}","trees_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/statuses/{sha}","languages_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/languages","stargazers_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/stargazers","contributors_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/contributors","subscribers_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/subscribers","subscription_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/subscription","commits_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/commits{/sha}","git_commits_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/git/commits{/sha}","comments_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/comments{/number}","issue_comment_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/issues/comments{/number}","contents_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/contents/{+path}","compare_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/merges","archive_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/downloads","issues_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/issues{/number}","pulls_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/pulls{/number}","milestones_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/milestones{/number}","notifications_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/labels{/name}","releases_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/releases{/id}","deployments_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/deployments","created_at":"2017-02-02T14:17:01Z","updated_at":"2018-06-07T16:39:30Z","pushed_at":"2018-06-08T12:08:21Z","git_url":"git://github.com/ess-dmsc/event-formation-unit.git","ssh_url":"git@github.com:ess-dmsc/event-formation-unit.git","clone_url":"https://github.com/ess-dmsc/event-formation-unit.git","svn_url":"https://github.com/ess-dmsc/event-formation-unit","homepage":null,"size":12582,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":1,"open_issues":13,"watchers":1,"default_branch":"master"}},"base":{"label":"ess-dmsc:master","ref":"master","sha":"a01a174452966f2fed9e01955a5120a806cc4828","user":{"login":"ess-dmsc","id":12100833,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAwODMz","avatar_url":"https://avatars1.githubusercontent.com/u/12100833?v=4","gravatar_id":"","url":"https://api.github.com/users/ess-dmsc","html_url":"https://github.com/ess-dmsc","followers_url":"https://api.github.com/users/ess-dmsc/followers","following_url":"https://api.github.com/users/ess-dmsc/following{/other_user}","gists_url":"https://api.github.com/users/ess-dmsc/gists{/gist_id}","starred_url":"https://api.github.com/users/ess-dmsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ess-dmsc/subscriptions","organizations_url":"https://api.github.com/users/ess-dmsc/orgs","repos_url":"https://api.github.com/users/ess-dmsc/repos","events_url":"https://api.github.com/users/ess-dmsc/events{/privacy}","received_events_url":"https://api.github.com/users/ess-dmsc/received_events","type":"Organization","site_admin":false},"repo":{"id":80731668,"node_id":"MDEwOlJlcG9zaXRvcnk4MDczMTY2OA==","name":"event-formation-unit","full_name":"ess-dmsc/event-formation-unit","owner":{"login":"ess-dmsc","id":12100833,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAwODMz","avatar_url":"https://avatars1.githubusercontent.com/u/12100833?v=4","gravatar_id":"","url":"https://api.github.com/users/ess-dmsc","html_url":"https://github.com/ess-dmsc","followers_url":"https://api.github.com/users/ess-dmsc/followers","following_url":"https://api.github.com/users/ess-dmsc/following{/other_user}","gists_url":"https://api.github.com/users/ess-dmsc/gists{/gist_id}","starred_url":"https://api.github.com/users/ess-dmsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ess-dmsc/subscriptions","organizations_url":"https://api.github.com/users/ess-dmsc/orgs","repos_url":"https://api.github.com/users/ess-dmsc/repos","events_url":"https://api.github.com/users/ess-dmsc/events{/privacy}","received_events_url":"https://api.github.com/users/ess-dmsc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ess-dmsc/event-formation-unit","description":"Implementation of neutron event formation pipeline for ESS","fork":false,"url":"https://api.github.com/repos/ess-dmsc/event-formation-unit","forks_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/forks","keys_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/teams","hooks_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/hooks","issue_events_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/issues/events{/number}","events_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/events","assignees_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/assignees{/user}","branches_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/branches{/branch}","tags_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/tags","blobs_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/git/refs{/sha}","trees_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/statuses/{sha}","languages_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/languages","stargazers_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/stargazers","contributors_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/contributors","subscribers_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/subscribers","subscription_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/subscription","commits_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/commits{/sha}","git_commits_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/git/commits{/sha}","comments_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/comments{/number}","issue_comment_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/issues/comments{/number}","contents_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/contents/{+path}","compare_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/merges","archive_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/downloads","issues_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/issues{/number}","pulls_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/pulls{/number}","milestones_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/milestones{/number}","notifications_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/labels{/name}","releases_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/releases{/id}","deployments_url":"https://api.github.com/repos/ess-dmsc/event-formation-unit/deployments","created_at":"2017-02-02T14:17:01Z","updated_at":"2018-06-07T16:39:30Z","pushed_at":"2018-06-08T12:08:21Z","git_url":"git://github.com/ess-dmsc/event-formation-unit.git","ssh_url":"git@github.com:ess-dmsc/event-formation-unit.git","clone_url":"https://github.com/ess-dmsc/event-formation-unit.git","svn_url":"https://github.com/ess-dmsc/event-formation-unit","homepage":null,"size":12582,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":1,"open_issues":13,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ess-dmsc/event-formation-unit/pulls/69"},"html":{"href":"https://github.com/ess-dmsc/event-formation-unit/pull/69"},"issue":{"href":"https://api.github.com/repos/ess-dmsc/event-formation-unit/issues/69"},"comments":{"href":"https://api.github.com/repos/ess-dmsc/event-formation-unit/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/ess-dmsc/event-formation-unit/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/ess-dmsc/event-formation-unit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ess-dmsc/event-formation-unit/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/ess-dmsc/event-formation-unit/statuses/6da995a08d1cba46ce4b2793217ba9a5772cc0c3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"SkyToGround"}}