{"action":"created","issue":{"url":"https://api.github.com/repos/patternfly/patternfly-react/issues/330","repository_url":"https://api.github.com/repos/patternfly/patternfly-react","labels_url":"https://api.github.com/repos/patternfly/patternfly-react/issues/330/labels{/name}","comments_url":"https://api.github.com/repos/patternfly/patternfly-react/issues/330/comments","events_url":"https://api.github.com/repos/patternfly/patternfly-react/issues/330/events","html_url":"https://github.com/patternfly/patternfly-react/pull/330","id":321173290,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg2NjI0MjQ5","number":330,"title":"feat(VerticalNav): Add Divider as a Secondary Item","user":{"login":"gilad215","id":24938324,"node_id":"MDQ6VXNlcjI0OTM4MzI0","avatar_url":"https://avatars1.githubusercontent.com/u/24938324?v=4","gravatar_id":"","url":"https://api.github.com/users/gilad215","html_url":"https://github.com/gilad215","followers_url":"https://api.github.com/users/gilad215/followers","following_url":"https://api.github.com/users/gilad215/following{/other_user}","gists_url":"https://api.github.com/users/gilad215/gists{/gist_id}","starred_url":"https://api.github.com/users/gilad215/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilad215/subscriptions","organizations_url":"https://api.github.com/users/gilad215/orgs","repos_url":"https://api.github.com/users/gilad215/repos","events_url":"https://api.github.com/users/gilad215/events{/privacy}","received_events_url":"https://api.github.com/users/gilad215/received_events","type":"User","site_admin":false},"labels":[{"id":821921778,"node_id":"MDU6TGFiZWw4MjE5MjE3Nzg=","url":"https://api.github.com/repos/patternfly/patternfly-react/labels/css%20approved","name":"css approved","color":"0e8a16","default":false},{"id":821921876,"node_id":"MDU6TGFiZWw4MjE5MjE4NzY=","url":"https://api.github.com/repos/patternfly/patternfly-react/labels/ux%20approved","name":"ux approved","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":24,"created_at":"2018-05-08T12:51:55Z","updated_at":"2018-06-19T07:35:24Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/patternfly/patternfly-react/pulls/330","html_url":"https://github.com/patternfly/patternfly-react/pull/330","diff_url":"https://github.com/patternfly/patternfly-react/pull/330.diff","patch_url":"https://github.com/patternfly/patternfly-react/pull/330.patch"},"body":"<!--\r\nThanks for your interest in patternfly-react. We appreciate all issues filed and PRs submitted!\r\n\r\nPlease make sure you're familiar with and follow the instructions in the\r\ncontributing guidelines (found in the CONTRIBUTING.md file).\r\n\r\nPlease fill out the information below to expedite the review and (hopefully)\r\nmerge of your pull request!\r\n-->\r\n\r\n<!-- What changes are being made? (What issue is being addressed here?) -->\r\n**What**:\r\nAdded the ability to show a divider between secondary items instead of the Tertiary approach.\r\nThis functionality is needed in Foreman's VerticalNav. I tried to keep the pattern of the code, but suggestions are welcome.\r\n\r\nResult:\r\n<img width=\"299\" alt=\"screen shot 2018-05-08 at 15 30 39\" src=\"https://user-images.githubusercontent.com/24938324/39758014-507c5920-52d7-11e8-83fd-99bc62452a5a.png\">\r\n\r\n<!-- Please provide a link to your fork's Storybook. See README notes on how to do this. -->\r\n**Link to Storybook**:\r\n[Storybook](https://rawgit.com/gilad215/patternfly-react/storybook/feature/verticalnavdivider/index.html?selectedKind=Vertical%20Navigation&selectedStory=Items%20as%20Objects&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybooks%2Fstorybook-addon-knobs)\r\n<!-- Are there any upstream issues or separate issues you need to reference? -->\r\n\r\n\r\n\r\n<!-- feel free to add additional comments -->"},"comment":{"url":"https://api.github.com/repos/patternfly/patternfly-react/issues/comments/398303865","html_url":"https://github.com/patternfly/patternfly-react/pull/330#issuecomment-398303865","issue_url":"https://api.github.com/repos/patternfly/patternfly-react/issues/330","id":398303865,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODMwMzg2NQ==","user":{"login":"gilad215","id":24938324,"node_id":"MDQ6VXNlcjI0OTM4MzI0","avatar_url":"https://avatars1.githubusercontent.com/u/24938324?v=4","gravatar_id":"","url":"https://api.github.com/users/gilad215","html_url":"https://github.com/gilad215","followers_url":"https://api.github.com/users/gilad215/followers","following_url":"https://api.github.com/users/gilad215/following{/other_user}","gists_url":"https://api.github.com/users/gilad215/gists{/gist_id}","starred_url":"https://api.github.com/users/gilad215/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilad215/subscriptions","organizations_url":"https://api.github.com/users/gilad215/orgs","repos_url":"https://api.github.com/users/gilad215/repos","events_url":"https://api.github.com/users/gilad215/events{/privacy}","received_events_url":"https://api.github.com/users/gilad215/received_events","type":"User","site_admin":false},"created_at":"2018-06-19T07:35:24Z","updated_at":"2018-06-19T07:35:24Z","author_association":"CONTRIBUTOR","body":"@jeff-phillips-18 \r\nThe tests are using `mockNavItems`, I added dividers in there, so they are being tested."}}
{"actor":{"display_login":"gilad215"}}