{"action":"created","issue":{"url":"https://api.github.com/repos/Readify/Neo4jClient/issues/275","repository_url":"https://api.github.com/repos/Readify/Neo4jClient","labels_url":"https://api.github.com/repos/Readify/Neo4jClient/issues/275/labels{/name}","comments_url":"https://api.github.com/repos/Readify/Neo4jClient/issues/275/comments","events_url":"https://api.github.com/repos/Readify/Neo4jClient/issues/275/events","html_url":"https://github.com/Readify/Neo4jClient/pull/275","id":319813865,"number":275,"title":"Direct Deserialization from Binary Driver when using BoltGraphClient","user":{"login":"arturosevilla","id":398184,"avatar_url":"https://avatars3.githubusercontent.com/u/398184?v=4","gravatar_id":"","url":"https://api.github.com/users/arturosevilla","html_url":"https://github.com/arturosevilla","followers_url":"https://api.github.com/users/arturosevilla/followers","following_url":"https://api.github.com/users/arturosevilla/following{/other_user}","gists_url":"https://api.github.com/users/arturosevilla/gists{/gist_id}","starred_url":"https://api.github.com/users/arturosevilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arturosevilla/subscriptions","organizations_url":"https://api.github.com/users/arturosevilla/orgs","repos_url":"https://api.github.com/users/arturosevilla/repos","events_url":"https://api.github.com/users/arturosevilla/events{/privacy}","received_events_url":"https://api.github.com/users/arturosevilla/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-05-03T07:31:27Z","updated_at":"2018-05-15T08:36:13Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Readify/Neo4jClient/pulls/275","html_url":"https://github.com/Readify/Neo4jClient/pull/275","diff_url":"https://github.com/Readify/Neo4jClient/pull/275.diff","patch_url":"https://github.com/Readify/Neo4jClient/pull/275.patch"},"body":"Right now the deserializar for `BoltGraphClient` serializes (on a per-record basis) the results into JSON, which is then sent to the existing `CypherJsonDeserializer`.\r\n\r\nThis set of changes removes that serialization into JSON by extracting the common functionality of `CypherJsonDeserializer` and creating a new `DriverDeserializer`. In this way a change in the deserialization algorithm is not dependent on the underlying serialization.\r\n\r\nSummary of changes:\r\n* Most of `CommonDeserializerMethods` and the structure of `CypherJsonDeserializer` was transformed into `BaseDeserializer` which is a generic abstract class that holds the skeleton of the deserializer.\r\n* Both `DriverSerializer` and `CypherJsonDeserializer` implement `BaseDeserializer`.\r\n* `CustomJsonDeserializer` uses `CypherJsonDeserializer` instead of `CommonDeserializerMethods`.\r\n* Removed `StatementResultHelper` extension methods.\r\n* Added `DriverDeserializerTests`.\r\n* Added support for `DataMemberAttribute` property \"renaming\" while deserializing and `IgnoreDataMemberAttribute` when serializing.\r\n* Added support for `DataMemberAttribute` and `JsonProperty` while serializing and using `BoltGraphClient`.\r\n* Created a new interface called `ITypeSerializer` which substitutes `JsonConverter` for `BoltGraphClient`."},"comment":{"url":"https://api.github.com/repos/Readify/Neo4jClient/issues/comments/389088666","html_url":"https://github.com/Readify/Neo4jClient/pull/275#issuecomment-389088666","issue_url":"https://api.github.com/repos/Readify/Neo4jClient/issues/275","id":389088666,"user":{"login":"arturosevilla","id":398184,"avatar_url":"https://avatars3.githubusercontent.com/u/398184?v=4","gravatar_id":"","url":"https://api.github.com/users/arturosevilla","html_url":"https://github.com/arturosevilla","followers_url":"https://api.github.com/users/arturosevilla/followers","following_url":"https://api.github.com/users/arturosevilla/following{/other_user}","gists_url":"https://api.github.com/users/arturosevilla/gists{/gist_id}","starred_url":"https://api.github.com/users/arturosevilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arturosevilla/subscriptions","organizations_url":"https://api.github.com/users/arturosevilla/orgs","repos_url":"https://api.github.com/users/arturosevilla/repos","events_url":"https://api.github.com/users/arturosevilla/events{/privacy}","received_events_url":"https://api.github.com/users/arturosevilla/received_events","type":"User","site_admin":false},"created_at":"2018-05-15T08:36:13Z","updated_at":"2018-05-15T08:36:13Z","author_association":"CONTRIBUTOR","body":"@cskardon This is no longer Work in Progress. It could be merged as is, if the given functionality completely meets the expectations."}}
{"actor":{"display_login":"arturosevilla"}}