{"action":"created","comment":{"url":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/comments/193241544","pull_request_review_id":126176634,"id":193241544,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzI0MTU0NA==","diff_hunk":"@@ -41,6 +47,12 @@ void piksi_log(int priority, const char *format, ...)\n \n void piksi_vlog(int priority, const char *format, va_list ap)\n {\n+  if (debug_printf) {\n+    char *with_return = (char *)malloc(strlen(format) + 1);","path":"package/libpiksi/libpiksi/src/logging.c","position":32,"original_position":25,"commit_id":"49d85e6b36eb7c6154e5ae73af15fdb225680cc9","original_commit_id":"6d163d5ebfe1f6e18707770519e14e8ca806f65e","user":{"login":"benjaminaltieri","id":5225320,"node_id":"MDQ6VXNlcjUyMjUzMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/5225320?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaminaltieri","html_url":"https://github.com/benjaminaltieri","followers_url":"https://api.github.com/users/benjaminaltieri/followers","following_url":"https://api.github.com/users/benjaminaltieri/following{/other_user}","gists_url":"https://api.github.com/users/benjaminaltieri/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminaltieri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminaltieri/subscriptions","organizations_url":"https://api.github.com/users/benjaminaltieri/orgs","repos_url":"https://api.github.com/users/benjaminaltieri/repos","events_url":"https://api.github.com/users/benjaminaltieri/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminaltieri/received_events","type":"User","site_admin":false},"body":"Ouch, thanks for the catch!","created_at":"2018-06-05T22:27:10Z","updated_at":"2018-06-05T22:27:10Z","html_url":"https://github.com/swift-nav/piksi_buildroot/pull/644#discussion_r193241544","pull_request_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/644","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/comments/193241544"},"html":{"href":"https://github.com/swift-nav/piksi_buildroot/pull/644#discussion_r193241544"},"pull_request":{"href":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/644"}},"in_reply_to_id":192931981},"pull_request":{"url":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/644","id":192567359,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNTY3MzU5","html_url":"https://github.com/swift-nav/piksi_buildroot/pull/644","diff_url":"https://github.com/swift-nav/piksi_buildroot/pull/644.diff","patch_url":"https://github.com/swift-nav/piksi_buildroot/pull/644.patch","issue_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues/644","number":644,"state":"open","locked":false,"title":"[DEVC-322] Replace czmq with nanomsg","user":{"login":"benjaminaltieri","id":5225320,"node_id":"MDQ6VXNlcjUyMjUzMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/5225320?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaminaltieri","html_url":"https://github.com/benjaminaltieri","followers_url":"https://api.github.com/users/benjaminaltieri/followers","following_url":"https://api.github.com/users/benjaminaltieri/following{/other_user}","gists_url":"https://api.github.com/users/benjaminaltieri/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminaltieri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminaltieri/subscriptions","organizations_url":"https://api.github.com/users/benjaminaltieri/orgs","repos_url":"https://api.github.com/users/benjaminaltieri/repos","events_url":"https://api.github.com/users/benjaminaltieri/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminaltieri/received_events","type":"User","site_admin":false},"body":"As a follow-up to #639, `czmq` has been completely removed from the codebase and replaced with [`nanomsg`](http://nanomsg.org/index.html). As `nanomsg` is a fork of `zmq`, the replacement was rather trivial and actually simplified much of the inner mechanics of the `endpoint` module. The commits have been split as clearly as possible to separate the functional changes from the cleanup steps.\r\n\r\nHigh-level notes:\r\n * Since `czmq.h` had a lot of tag-along headers included, removing it meant having to chase down dependencies for many packages that ended up having missing includes.\r\n * Sockets created with `nn_socket` reveal a file descriptor that is level-triggered, as opposed to edge-triggered, so each `libuv` receive callback should correspond to a single message. The API has not changed but it was a detail that I had to comment on in the initial refactor that is slightly different now.\r\n * Our endpoint addresses have been revised to omit the '@' and '>' symbols that were used in `czmq` to indicate whether or not a socket should bind when created (vs connect). Since this was a unique and non-standard usage, I removed it in favor of explicitly creating *_SERVER versions of the PUB and SUB endpoint types. This has no impact on the current infrastructure since the only endpoints using bind were those created by the router so those are created as server types, while all others are unchanged in implementation and default to 'connect'. Practically, however, this removes the ability for an endpoint address to be trivially amended, in say a command line invocation, in order to affect these behaviors. From this point forward such options need to be routed into code, or hard coded into the process.","created_at":"2018-06-05T01:19:37Z","updated_at":"2018-06-05T22:27:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c937c37b1b2b9c419ed2f9bdb74a650d891a4906","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/644/commits","review_comments_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/644/comments","review_comment_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues/644/comments","statuses_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/statuses/49d85e6b36eb7c6154e5ae73af15fdb225680cc9","head":{"label":"swift-nav:benaltieri/replace_czmq_with_nanomsg","ref":"benaltieri/replace_czmq_with_nanomsg","sha":"49d85e6b36eb7c6154e5ae73af15fdb225680cc9","user":{"login":"swift-nav","id":1069835,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjk4MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1069835?v=4","gravatar_id":"","url":"https://api.github.com/users/swift-nav","html_url":"https://github.com/swift-nav","followers_url":"https://api.github.com/users/swift-nav/followers","following_url":"https://api.github.com/users/swift-nav/following{/other_user}","gists_url":"https://api.github.com/users/swift-nav/gists{/gist_id}","starred_url":"https://api.github.com/users/swift-nav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swift-nav/subscriptions","organizations_url":"https://api.github.com/users/swift-nav/orgs","repos_url":"https://api.github.com/users/swift-nav/repos","events_url":"https://api.github.com/users/swift-nav/events{/privacy}","received_events_url":"https://api.github.com/users/swift-nav/received_events","type":"Organization","site_admin":false},"repo":{"id":62339278,"node_id":"MDEwOlJlcG9zaXRvcnk2MjMzOTI3OA==","name":"piksi_buildroot","full_name":"swift-nav/piksi_buildroot","owner":{"login":"swift-nav","id":1069835,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjk4MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1069835?v=4","gravatar_id":"","url":"https://api.github.com/users/swift-nav","html_url":"https://github.com/swift-nav","followers_url":"https://api.github.com/users/swift-nav/followers","following_url":"https://api.github.com/users/swift-nav/following{/other_user}","gists_url":"https://api.github.com/users/swift-nav/gists{/gist_id}","starred_url":"https://api.github.com/users/swift-nav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swift-nav/subscriptions","organizations_url":"https://api.github.com/users/swift-nav/orgs","repos_url":"https://api.github.com/users/swift-nav/repos","events_url":"https://api.github.com/users/swift-nav/events{/privacy}","received_events_url":"https://api.github.com/users/swift-nav/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/swift-nav/piksi_buildroot","description":"Tools for building Linux and the system image for Piksi Multi","fork":false,"url":"https://api.github.com/repos/swift-nav/piksi_buildroot","forks_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/forks","keys_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/teams","hooks_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/hooks","issue_events_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues/events{/number}","events_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/events","assignees_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/assignees{/user}","branches_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/branches{/branch}","tags_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/tags","blobs_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/git/refs{/sha}","trees_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/statuses/{sha}","languages_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/languages","stargazers_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/stargazers","contributors_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/contributors","subscribers_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/subscribers","subscription_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/subscription","commits_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/commits{/sha}","git_commits_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/git/commits{/sha}","comments_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/comments{/number}","issue_comment_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues/comments{/number}","contents_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/contents/{+path}","compare_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/merges","archive_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/downloads","issues_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues{/number}","pulls_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls{/number}","milestones_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/milestones{/number}","notifications_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/labels{/name}","releases_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/releases{/id}","deployments_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/deployments","created_at":"2016-06-30T20:09:21Z","updated_at":"2018-05-29T19:58:44Z","pushed_at":"2018-06-05T22:21:22Z","git_url":"git://github.com/swift-nav/piksi_buildroot.git","ssh_url":"git@github.com:swift-nav/piksi_buildroot.git","clone_url":"https://github.com/swift-nav/piksi_buildroot.git","svn_url":"https://github.com/swift-nav/piksi_buildroot","homepage":"http://www.swiftnav.com","size":5613,"stargazers_count":4,"watchers_count":4,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":22,"open_issues":40,"watchers":4,"default_branch":"v1.5.0-release"}},"base":{"label":"swift-nav:benaltieri/zloop_refactor_to_libuv","ref":"benaltieri/zloop_refactor_to_libuv","sha":"0efc39e38f2779b00b9dd486a8ffe3a11ca202a7","user":{"login":"swift-nav","id":1069835,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjk4MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1069835?v=4","gravatar_id":"","url":"https://api.github.com/users/swift-nav","html_url":"https://github.com/swift-nav","followers_url":"https://api.github.com/users/swift-nav/followers","following_url":"https://api.github.com/users/swift-nav/following{/other_user}","gists_url":"https://api.github.com/users/swift-nav/gists{/gist_id}","starred_url":"https://api.github.com/users/swift-nav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swift-nav/subscriptions","organizations_url":"https://api.github.com/users/swift-nav/orgs","repos_url":"https://api.github.com/users/swift-nav/repos","events_url":"https://api.github.com/users/swift-nav/events{/privacy}","received_events_url":"https://api.github.com/users/swift-nav/received_events","type":"Organization","site_admin":false},"repo":{"id":62339278,"node_id":"MDEwOlJlcG9zaXRvcnk2MjMzOTI3OA==","name":"piksi_buildroot","full_name":"swift-nav/piksi_buildroot","owner":{"login":"swift-nav","id":1069835,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjk4MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1069835?v=4","gravatar_id":"","url":"https://api.github.com/users/swift-nav","html_url":"https://github.com/swift-nav","followers_url":"https://api.github.com/users/swift-nav/followers","following_url":"https://api.github.com/users/swift-nav/following{/other_user}","gists_url":"https://api.github.com/users/swift-nav/gists{/gist_id}","starred_url":"https://api.github.com/users/swift-nav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swift-nav/subscriptions","organizations_url":"https://api.github.com/users/swift-nav/orgs","repos_url":"https://api.github.com/users/swift-nav/repos","events_url":"https://api.github.com/users/swift-nav/events{/privacy}","received_events_url":"https://api.github.com/users/swift-nav/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/swift-nav/piksi_buildroot","description":"Tools for building Linux and the system image for Piksi Multi","fork":false,"url":"https://api.github.com/repos/swift-nav/piksi_buildroot","forks_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/forks","keys_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/teams","hooks_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/hooks","issue_events_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues/events{/number}","events_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/events","assignees_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/assignees{/user}","branches_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/branches{/branch}","tags_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/tags","blobs_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/git/refs{/sha}","trees_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/statuses/{sha}","languages_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/languages","stargazers_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/stargazers","contributors_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/contributors","subscribers_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/subscribers","subscription_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/subscription","commits_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/commits{/sha}","git_commits_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/git/commits{/sha}","comments_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/comments{/number}","issue_comment_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues/comments{/number}","contents_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/contents/{+path}","compare_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/merges","archive_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/downloads","issues_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues{/number}","pulls_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls{/number}","milestones_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/milestones{/number}","notifications_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/labels{/name}","releases_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/releases{/id}","deployments_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/deployments","created_at":"2016-06-30T20:09:21Z","updated_at":"2018-05-29T19:58:44Z","pushed_at":"2018-06-05T22:21:22Z","git_url":"git://github.com/swift-nav/piksi_buildroot.git","ssh_url":"git@github.com:swift-nav/piksi_buildroot.git","clone_url":"https://github.com/swift-nav/piksi_buildroot.git","svn_url":"https://github.com/swift-nav/piksi_buildroot","homepage":"http://www.swiftnav.com","size":5613,"stargazers_count":4,"watchers_count":4,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":22,"open_issues":40,"watchers":4,"default_branch":"v1.5.0-release"}},"_links":{"self":{"href":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/644"},"html":{"href":"https://github.com/swift-nav/piksi_buildroot/pull/644"},"issue":{"href":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues/644"},"comments":{"href":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues/644/comments"},"review_comments":{"href":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/644/comments"},"review_comment":{"href":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/644/commits"},"statuses":{"href":"https://api.github.com/repos/swift-nav/piksi_buildroot/statuses/49d85e6b36eb7c6154e5ae73af15fdb225680cc9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"benjaminaltieri"}}