{"action":"created","issue":{"url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/11517","repository_url":"https://api.github.com/repos/Yoast/wordpress-seo","labels_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/11517/labels{/name}","comments_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/11517/comments","events_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/11517/events","html_url":"https://github.com/Yoast/wordpress-seo/pull/11517","id":377856706,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4Njk5MjU5","number":11517,"title":"Deprecate class-yoast-modal.php","user":{"login":"IreneStr","id":17744553,"node_id":"MDQ6VXNlcjE3NzQ0NTUz","avatar_url":"https://avatars3.githubusercontent.com/u/17744553?v=4","gravatar_id":"","url":"https://api.github.com/users/IreneStr","html_url":"https://github.com/IreneStr","followers_url":"https://api.github.com/users/IreneStr/followers","following_url":"https://api.github.com/users/IreneStr/following{/other_user}","gists_url":"https://api.github.com/users/IreneStr/gists{/gist_id}","starred_url":"https://api.github.com/users/IreneStr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IreneStr/subscriptions","organizations_url":"https://api.github.com/users/IreneStr/orgs","repos_url":"https://api.github.com/users/IreneStr/repos","events_url":"https://api.github.com/users/IreneStr/events{/privacy}","received_events_url":"https://api.github.com/users/IreneStr/received_events","type":"User","site_admin":false},"labels":[{"id":267594565,"node_id":"MDU6TGFiZWwyNjc1OTQ1NjU=","url":"https://api.github.com/repos/Yoast/wordpress-seo/labels/needs-code-review","name":"needs-code-review","color":"78BDF2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/Yoast/wordpress-seo/milestones/133","html_url":"https://github.com/Yoast/wordpress-seo/milestone/133","labels_url":"https://api.github.com/repos/Yoast/wordpress-seo/milestones/133/labels","id":3762027,"node_id":"MDk6TWlsZXN0b25lMzc2MjAyNw==","number":133,"title":"9.2","description":null,"creator":{"login":"IreneStr","id":17744553,"node_id":"MDQ6VXNlcjE3NzQ0NTUz","avatar_url":"https://avatars3.githubusercontent.com/u/17744553?v=4","gravatar_id":"","url":"https://api.github.com/users/IreneStr","html_url":"https://github.com/IreneStr","followers_url":"https://api.github.com/users/IreneStr/followers","following_url":"https://api.github.com/users/IreneStr/following{/other_user}","gists_url":"https://api.github.com/users/IreneStr/gists{/gist_id}","starred_url":"https://api.github.com/users/IreneStr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IreneStr/subscriptions","organizations_url":"https://api.github.com/users/IreneStr/orgs","repos_url":"https://api.github.com/users/IreneStr/repos","events_url":"https://api.github.com/users/IreneStr/events{/privacy}","received_events_url":"https://api.github.com/users/IreneStr/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":17,"state":"open","created_at":"2018-10-23T14:48:07Z","updated_at":"2018-11-07T07:06:54Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2018-11-06T13:54:12Z","updated_at":"2018-11-07T08:44:47Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/11517","html_url":"https://github.com/Yoast/wordpress-seo/pull/11517","diff_url":"https://github.com/Yoast/wordpress-seo/pull/11517.diff","patch_url":"https://github.com/Yoast/wordpress-seo/pull/11517.patch"},"body":"## Summary\r\n\r\nThis PR can be summarized in the following changelog entry:\r\n\r\n* Deprecates the Yoast_Modal class.\r\n\r\n## Relevant technical choices:\r\n\r\n* When looking into https://github.com/Yoast/wordpress-seo/pull/11504/files, I noticed the Yoast_Modal class is no longer being used. More specificly: the class was used in 2 modal configs (`class-metabox-keyword-synonyms-config.php` and `class-metabox-multiple-keywords-config.php`), but those configs were no longer used, because the modals have been replaced by react modals. \r\n\r\n## Test instructions\r\n<!--\r\nPlease follow these guidelines when creating test instructions:\r\n- Please provide step-by-step instructions how to reproduce the issue, if applicable.\r\n- Write step-by-step test instructions aimed at non-tech-savvy users, even if the PR is not user-facing.\r\n-->\r\nThis PR can be tested by following these steps:\r\n\r\n* In the metabox/sidebar click '+ Add synonyms' and '+ Add additional keyphrase'. In both cases, you should get a functional (React) modal. \r\n\r\n## Quality assurance\r\n\r\n* [x] I have tested this code to the best of my abilities\r\n* [ ] I have added unittests to verify the code works as intended\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/comments/436547998","html_url":"https://github.com/Yoast/wordpress-seo/pull/11517#issuecomment-436547998","issue_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/11517","id":436547998,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjU0Nzk5OA==","user":{"login":"afercia","id":1682452,"node_id":"MDQ6VXNlcjE2ODI0NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1682452?v=4","gravatar_id":"","url":"https://api.github.com/users/afercia","html_url":"https://github.com/afercia","followers_url":"https://api.github.com/users/afercia/followers","following_url":"https://api.github.com/users/afercia/following{/other_user}","gists_url":"https://api.github.com/users/afercia/gists{/gist_id}","starred_url":"https://api.github.com/users/afercia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afercia/subscriptions","organizations_url":"https://api.github.com/users/afercia/orgs","repos_url":"https://api.github.com/users/afercia/repos","events_url":"https://api.github.com/users/afercia/events{/privacy}","received_events_url":"https://api.github.com/users/afercia/received_events","type":"User","site_admin":false},"created_at":"2018-11-07T08:44:47Z","updated_at":"2018-11-07T08:44:47Z","author_association":"COLLABORATOR","body":"Worth considering the related https://github.com/Yoast/wordpress-seo/issues/11051\r\n"}}
{"actor":{"display_login":"afercia"}}