{"action":"created","issue":{"url":"https://api.github.com/repos/sighmon/mjml-rails/issues/37","repository_url":"https://api.github.com/repos/sighmon/mjml-rails","labels_url":"https://api.github.com/repos/sighmon/mjml-rails/issues/37/labels{/name}","comments_url":"https://api.github.com/repos/sighmon/mjml-rails/issues/37/comments","events_url":"https://api.github.com/repos/sighmon/mjml-rails/issues/37/events","html_url":"https://github.com/sighmon/mjml-rails/pull/37","id":354695886,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMzk1MzIx","number":37,"title":"Raise render errors per default","user":{"login":"sbiastoch","id":18593760,"node_id":"MDQ6VXNlcjE4NTkzNzYw","avatar_url":"https://avatars1.githubusercontent.com/u/18593760?v=4","gravatar_id":"","url":"https://api.github.com/users/sbiastoch","html_url":"https://github.com/sbiastoch","followers_url":"https://api.github.com/users/sbiastoch/followers","following_url":"https://api.github.com/users/sbiastoch/following{/other_user}","gists_url":"https://api.github.com/users/sbiastoch/gists{/gist_id}","starred_url":"https://api.github.com/users/sbiastoch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbiastoch/subscriptions","organizations_url":"https://api.github.com/users/sbiastoch/orgs","repos_url":"https://api.github.com/users/sbiastoch/repos","events_url":"https://api.github.com/users/sbiastoch/events{/privacy}","received_events_url":"https://api.github.com/users/sbiastoch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-28T11:52:32Z","updated_at":"2018-08-29T12:08:48Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/sighmon/mjml-rails/pulls/37","html_url":"https://github.com/sighmon/mjml-rails/pull/37","diff_url":"https://github.com/sighmon/mjml-rails/pull/37.diff","patch_url":"https://github.com/sighmon/mjml-rails/pull/37.patch"},"body":"Hi everybody,\r\nI do not see any reason why errors during mjml-compilation should be silently ignored? I had an issue where due to a unintended update of jemalloc the compilation of mjml fails silently in production only, which lead to sending blank emails (since mjml created no html output) to my users in production. Also, erroneous templates syntax results in silent fails, which makes it really hard to debug when you are not aware that mjml has disabled error propagation.\r\nI am sure that there are scenarios why you want to disable errors, but the default should be the most common case, not an \"use-with-caution\" setting.\r\nCheers!"},"comment":{"url":"https://api.github.com/repos/sighmon/mjml-rails/issues/comments/416929288","html_url":"https://github.com/sighmon/mjml-rails/pull/37#issuecomment-416929288","issue_url":"https://api.github.com/repos/sighmon/mjml-rails/issues/37","id":416929288,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjkyOTI4OA==","user":{"login":"sighmon","id":314298,"node_id":"MDQ6VXNlcjMxNDI5OA==","avatar_url":"https://avatars1.githubusercontent.com/u/314298?v=4","gravatar_id":"","url":"https://api.github.com/users/sighmon","html_url":"https://github.com/sighmon","followers_url":"https://api.github.com/users/sighmon/followers","following_url":"https://api.github.com/users/sighmon/following{/other_user}","gists_url":"https://api.github.com/users/sighmon/gists{/gist_id}","starred_url":"https://api.github.com/users/sighmon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sighmon/subscriptions","organizations_url":"https://api.github.com/users/sighmon/orgs","repos_url":"https://api.github.com/users/sighmon/repos","events_url":"https://api.github.com/users/sighmon/events{/privacy}","received_events_url":"https://api.github.com/users/sighmon/received_events","type":"User","site_admin":false},"created_at":"2018-08-29T12:08:48Z","updated_at":"2018-08-29T12:08:48Z","author_association":"OWNER","body":"Hi @sbiastoch, looks good to me.\r\n\r\nThe feature was introduced by @anhtrantuan here: https://github.com/sighmon/mjml-rails/commit/ef469b2d04bea69e225cbc4a772b1e1e67281c5f - so perhaps they might have an opinion.\r\n\r\nBut if we haven't heard back in a few days I'm happy to merge this."}}
{"actor":{"display_login":"sighmon"}}