{"action":"created","comment":{"url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/pulls/comments/175816445","pull_request_review_id":105408692,"id":175816445,"diff_hunk":"@@ -0,0 +1,113 @@\n+#!/bin/sh\n+\n+configure_directories()\n+{\n+\t# Create folders for app data if they don't already exist\n+    mkdir -p /var/lib/nextcloud/apps2 /var/lib/nextcloud/config \\\n+        /var/lib/nextcloud/data /var/lib/nextcloud/session\n+\t# Update permissions on nextcloud folders","path":"rootfs/entrypoint.sh","position":null,"original_position":8,"commit_id":"79741fbd69ea107c566a867c9d6daaf6cff1f612","original_commit_id":"ab18b5386c0ee5dea28526f439c11a70ae3b30cf","user":{"login":"lower29","id":386260,"avatar_url":"https://avatars3.githubusercontent.com/u/386260?v=4","gravatar_id":"","url":"https://api.github.com/users/lower29","html_url":"https://github.com/lower29","followers_url":"https://api.github.com/users/lower29/followers","following_url":"https://api.github.com/users/lower29/following{/other_user}","gists_url":"https://api.github.com/users/lower29/gists{/gist_id}","starred_url":"https://api.github.com/users/lower29/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lower29/subscriptions","organizations_url":"https://api.github.com/users/lower29/orgs","repos_url":"https://api.github.com/users/lower29/repos","events_url":"https://api.github.com/users/lower29/events{/privacy}","received_events_url":"https://api.github.com/users/lower29/received_events","type":"User","site_admin":false},"body":"Thanks @sevein, I can always depend on you to keep me honest. Fixed.","created_at":"2018-03-20T15:42:10Z","updated_at":"2018-03-20T15:42:10Z","html_url":"https://github.com/JiscRDSS/rdss-arkivum-nextcloud/pull/18#discussion_r175816445","pull_request_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/pulls/18","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/pulls/comments/175816445"},"html":{"href":"https://github.com/JiscRDSS/rdss-arkivum-nextcloud/pull/18#discussion_r175816445"},"pull_request":{"href":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/pulls/18"}},"in_reply_to_id":175807166},"pull_request":{"url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/pulls/18","id":176145622,"html_url":"https://github.com/JiscRDSS/rdss-arkivum-nextcloud/pull/18","diff_url":"https://github.com/JiscRDSS/rdss-arkivum-nextcloud/pull/18.diff","patch_url":"https://github.com/JiscRDSS/rdss-arkivum-nextcloud/pull/18.patch","issue_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/issues/18","number":18,"state":"open","locked":false,"title":"avoid using wonderfall/nextcloud as base image","user":{"login":"lower29","id":386260,"avatar_url":"https://avatars3.githubusercontent.com/u/386260?v=4","gravatar_id":"","url":"https://api.github.com/users/lower29","html_url":"https://github.com/lower29","followers_url":"https://api.github.com/users/lower29/followers","following_url":"https://api.github.com/users/lower29/following{/other_user}","gists_url":"https://api.github.com/users/lower29/gists{/gist_id}","starred_url":"https://api.github.com/users/lower29/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lower29/subscriptions","organizations_url":"https://api.github.com/users/lower29/orgs","repos_url":"https://api.github.com/users/lower29/repos","events_url":"https://api.github.com/users/lower29/events{/privacy}","received_events_url":"https://api.github.com/users/lower29/received_events","type":"User","site_admin":false},"body":"This pull request addresses issue #7. Our upstream image, `wonderfall/nextcloud`, has been discontinued so we need to find an alternative, plus it uses s6 which is very hard to configure and maintain.\r\n\r\nWe now base our image on [boxedcode/alpine-nginx-php-fpm](https://hub.docker.com/r/boxedcode/alpine-nginx-php-fpm/), which whilst not a pure OS image is a useful compromise, including ready-built nginx and PHP-FPM. It uses supervisor instead of s6 to run the multiple processes, which is much simpler to comprehend and maintain.\r\n\r\nThe nextcloud install and configuration from the wonderfall image has been copied into our image, so we're now in full control of what nextcloud version etc is installed and how it's configured. It also means we can remove a number of shims that were in place to change the default behaviour. \r\n\r\nSome of the old scripts have been renamed/refactored, for example `run.sh` is now `entrypoint.sh` because that's what the `alpine-nginx-php-fpm` uses, so we just override the base image.\r\n\r\nI also took the opportunity to update the NextCloud version to the latest 12.x, v12.0.6. I stopped short of going to v13.0.1 - I didn't want to risk destabilising things.","created_at":"2018-03-20T10:26:26Z","updated_at":"2018-03-20T15:42:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"868c59727fe7a7776cdebb1a748d394c43e06ed9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/pulls/18/commits","review_comments_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/pulls/18/comments","review_comment_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/issues/18/comments","statuses_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/statuses/79741fbd69ea107c566a867c9d6daaf6cff1f612","head":{"label":"JiscRDSS:dev/standalone-image","ref":"dev/standalone-image","sha":"79741fbd69ea107c566a867c9d6daaf6cff1f612","user":{"login":"JiscRDSS","id":22818449,"avatar_url":"https://avatars0.githubusercontent.com/u/22818449?v=4","gravatar_id":"","url":"https://api.github.com/users/JiscRDSS","html_url":"https://github.com/JiscRDSS","followers_url":"https://api.github.com/users/JiscRDSS/followers","following_url":"https://api.github.com/users/JiscRDSS/following{/other_user}","gists_url":"https://api.github.com/users/JiscRDSS/gists{/gist_id}","starred_url":"https://api.github.com/users/JiscRDSS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JiscRDSS/subscriptions","organizations_url":"https://api.github.com/users/JiscRDSS/orgs","repos_url":"https://api.github.com/users/JiscRDSS/repos","events_url":"https://api.github.com/users/JiscRDSS/events{/privacy}","received_events_url":"https://api.github.com/users/JiscRDSS/received_events","type":"Organization","site_admin":false},"repo":{"id":99229851,"name":"rdss-arkivum-nextcloud","full_name":"JiscRDSS/rdss-arkivum-nextcloud","owner":{"login":"JiscRDSS","id":22818449,"avatar_url":"https://avatars0.githubusercontent.com/u/22818449?v=4","gravatar_id":"","url":"https://api.github.com/users/JiscRDSS","html_url":"https://github.com/JiscRDSS","followers_url":"https://api.github.com/users/JiscRDSS/followers","following_url":"https://api.github.com/users/JiscRDSS/following{/other_user}","gists_url":"https://api.github.com/users/JiscRDSS/gists{/gist_id}","starred_url":"https://api.github.com/users/JiscRDSS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JiscRDSS/subscriptions","organizations_url":"https://api.github.com/users/JiscRDSS/orgs","repos_url":"https://api.github.com/users/JiscRDSS/repos","events_url":"https://api.github.com/users/JiscRDSS/events{/privacy}","received_events_url":"https://api.github.com/users/JiscRDSS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JiscRDSS/rdss-arkivum-nextcloud","description":"NextCloud as provided by Arkivum for the RDSS project.","fork":false,"url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud","forks_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/forks","keys_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/teams","hooks_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/hooks","issue_events_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/issues/events{/number}","events_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/events","assignees_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/assignees{/user}","branches_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/branches{/branch}","tags_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/tags","blobs_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/statuses/{sha}","languages_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/languages","stargazers_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/stargazers","contributors_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/contributors","subscribers_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/subscribers","subscription_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/subscription","commits_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/contents/{+path}","compare_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/merges","archive_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/downloads","issues_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/issues{/number}","pulls_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/pulls{/number}","milestones_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/milestones{/number}","notifications_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/labels{/name}","releases_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/releases{/id}","deployments_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/deployments","created_at":"2017-08-03T12:24:15Z","updated_at":"2017-08-09T10:53:30Z","pushed_at":"2018-03-20T15:41:46Z","git_url":"git://github.com/JiscRDSS/rdss-arkivum-nextcloud.git","ssh_url":"git@github.com:JiscRDSS/rdss-arkivum-nextcloud.git","clone_url":"https://github.com/JiscRDSS/rdss-arkivum-nextcloud.git","svn_url":"https://github.com/JiscRDSS/rdss-arkivum-nextcloud","homepage":null,"size":46,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"JiscRDSS:master","ref":"master","sha":"83857b7bc8a1606a5eb0a35d3326777a882ba6a0","user":{"login":"JiscRDSS","id":22818449,"avatar_url":"https://avatars0.githubusercontent.com/u/22818449?v=4","gravatar_id":"","url":"https://api.github.com/users/JiscRDSS","html_url":"https://github.com/JiscRDSS","followers_url":"https://api.github.com/users/JiscRDSS/followers","following_url":"https://api.github.com/users/JiscRDSS/following{/other_user}","gists_url":"https://api.github.com/users/JiscRDSS/gists{/gist_id}","starred_url":"https://api.github.com/users/JiscRDSS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JiscRDSS/subscriptions","organizations_url":"https://api.github.com/users/JiscRDSS/orgs","repos_url":"https://api.github.com/users/JiscRDSS/repos","events_url":"https://api.github.com/users/JiscRDSS/events{/privacy}","received_events_url":"https://api.github.com/users/JiscRDSS/received_events","type":"Organization","site_admin":false},"repo":{"id":99229851,"name":"rdss-arkivum-nextcloud","full_name":"JiscRDSS/rdss-arkivum-nextcloud","owner":{"login":"JiscRDSS","id":22818449,"avatar_url":"https://avatars0.githubusercontent.com/u/22818449?v=4","gravatar_id":"","url":"https://api.github.com/users/JiscRDSS","html_url":"https://github.com/JiscRDSS","followers_url":"https://api.github.com/users/JiscRDSS/followers","following_url":"https://api.github.com/users/JiscRDSS/following{/other_user}","gists_url":"https://api.github.com/users/JiscRDSS/gists{/gist_id}","starred_url":"https://api.github.com/users/JiscRDSS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JiscRDSS/subscriptions","organizations_url":"https://api.github.com/users/JiscRDSS/orgs","repos_url":"https://api.github.com/users/JiscRDSS/repos","events_url":"https://api.github.com/users/JiscRDSS/events{/privacy}","received_events_url":"https://api.github.com/users/JiscRDSS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JiscRDSS/rdss-arkivum-nextcloud","description":"NextCloud as provided by Arkivum for the RDSS project.","fork":false,"url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud","forks_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/forks","keys_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/teams","hooks_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/hooks","issue_events_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/issues/events{/number}","events_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/events","assignees_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/assignees{/user}","branches_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/branches{/branch}","tags_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/tags","blobs_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/statuses/{sha}","languages_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/languages","stargazers_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/stargazers","contributors_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/contributors","subscribers_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/subscribers","subscription_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/subscription","commits_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/contents/{+path}","compare_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/merges","archive_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/downloads","issues_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/issues{/number}","pulls_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/pulls{/number}","milestones_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/milestones{/number}","notifications_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/labels{/name}","releases_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/releases{/id}","deployments_url":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/deployments","created_at":"2017-08-03T12:24:15Z","updated_at":"2017-08-09T10:53:30Z","pushed_at":"2018-03-20T15:41:46Z","git_url":"git://github.com/JiscRDSS/rdss-arkivum-nextcloud.git","ssh_url":"git@github.com:JiscRDSS/rdss-arkivum-nextcloud.git","clone_url":"https://github.com/JiscRDSS/rdss-arkivum-nextcloud.git","svn_url":"https://github.com/JiscRDSS/rdss-arkivum-nextcloud","homepage":null,"size":46,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/pulls/18"},"html":{"href":"https://github.com/JiscRDSS/rdss-arkivum-nextcloud/pull/18"},"issue":{"href":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/issues/18"},"comments":{"href":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/JiscRDSS/rdss-arkivum-nextcloud/statuses/79741fbd69ea107c566a867c9d6daaf6cff1f612"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"lower29"}}