{"action":"created","issue":{"url":"https://api.github.com/repos/foosel/OctoPrint/issues/2410","repository_url":"https://api.github.com/repos/foosel/OctoPrint","labels_url":"https://api.github.com/repos/foosel/OctoPrint/issues/2410/labels{/name}","comments_url":"https://api.github.com/repos/foosel/OctoPrint/issues/2410/comments","events_url":"https://api.github.com/repos/foosel/OctoPrint/issues/2410/events","html_url":"https://github.com/foosel/OctoPrint/pull/2410","id":295547059,"number":2410,"title":"[Brainstorming] Support both mpeg2 and h264 for timelapse rendering","user":{"login":"koenkooi","id":259525,"avatar_url":"https://avatars2.githubusercontent.com/u/259525?v=4","gravatar_id":"","url":"https://api.github.com/users/koenkooi","html_url":"https://github.com/koenkooi","followers_url":"https://api.github.com/users/koenkooi/followers","following_url":"https://api.github.com/users/koenkooi/following{/other_user}","gists_url":"https://api.github.com/users/koenkooi/gists{/gist_id}","starred_url":"https://api.github.com/users/koenkooi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koenkooi/subscriptions","organizations_url":"https://api.github.com/users/koenkooi/orgs","repos_url":"https://api.github.com/users/koenkooi/repos","events_url":"https://api.github.com/users/koenkooi/events{/privacy}","received_events_url":"https://api.github.com/users/koenkooi/received_events","type":"User","site_admin":false},"labels":[{"id":557039014,"url":"https://api.github.com/repos/foosel/OctoPrint/labels/pr:work%20in%20progress","name":"pr:work in progress","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-02-08T15:09:03Z","updated_at":"2018-03-19T13:15:28Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/foosel/OctoPrint/pulls/2410","html_url":"https://github.com/foosel/OctoPrint/pull/2410","diff_url":"https://github.com/foosel/OctoPrint/pull/2410.diff","patch_url":"https://github.com/foosel/OctoPrint/pull/2410.patch"},"body":"#### What does this PR do and why is it necessary?\r\n\r\nThis PR adds a setting to use h264 as videocodec for timelapse rendering. This should give a quality boost at the same bitrate setting or allow to drop the bitrate while keeping the same quality.\r\n\r\nI tagged it as 'RFC' because there are at least these issues still left:\r\n- [ ] Spurious whitespace changes\r\n- [x] ~~Missing translation strings~~\r\n- [ ] Commit ordering, settings are in before the code\r\n- [ ] Fix and extend related unit tests\r\n\r\nBefore I spend more time on this, is this the way to go, or should any extra changes to timelapse by done in an octopi style external script or as a module?\r\n\r\n#### How was it tested? How can it be tested by the reviewer?\r\n\r\nTested by setting _Settings → Webcam & Timelapse → Timelapse Recordings → Advanced settings → Videocodec_ to 'libx264' and starting a print.\r\nSee screenshot section for details on the resulting timelapse.\r\n\r\n#### Any background context you want to provide?\r\n\r\nSee above, h264 support for timelapses.\r\n\r\n#### What are the relevant tickets if any?\r\n\r\nhttps://github.com/foosel/OctoPrint/issues/2388\r\nhttps://github.com/foosel/OctoPrint/issues/2373\r\nhttps://github.com/foosel/OctoPrint/issues/1980\r\n\r\n#### Screenshots (if appropriate)\r\n\r\n<img width=\"983\" alt=\"schermafbeelding 2018-02-08 om 15 54 53\" src=\"https://user-images.githubusercontent.com/259525/35979360-76c8e0e2-0ce8-11e8-91c6-3f82dbb832a4.png\">\r\n<img width=\"616\" alt=\"schermafbeelding 2018-02-08 om 15 58 17\" src=\"https://user-images.githubusercontent.com/259525/35979546-e696bd90-0ce8-11e8-8264-c5b9d3723399.png\">\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/foosel/OctoPrint/issues/comments/374207359","html_url":"https://github.com/foosel/OctoPrint/pull/2410#issuecomment-374207359","issue_url":"https://api.github.com/repos/foosel/OctoPrint/issues/2410","id":374207359,"user":{"login":"funkycode","id":594204,"avatar_url":"https://avatars3.githubusercontent.com/u/594204?v=4","gravatar_id":"","url":"https://api.github.com/users/funkycode","html_url":"https://github.com/funkycode","followers_url":"https://api.github.com/users/funkycode/followers","following_url":"https://api.github.com/users/funkycode/following{/other_user}","gists_url":"https://api.github.com/users/funkycode/gists{/gist_id}","starred_url":"https://api.github.com/users/funkycode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/funkycode/subscriptions","organizations_url":"https://api.github.com/users/funkycode/orgs","repos_url":"https://api.github.com/users/funkycode/repos","events_url":"https://api.github.com/users/funkycode/events{/privacy}","received_events_url":"https://api.github.com/users/funkycode/received_events","type":"User","site_admin":false},"created_at":"2018-03-19T13:15:28Z","updated_at":"2018-03-19T13:15:28Z","author_association":"NONE","body":"What about container? to have matroska instead of mpeg?"}}
{"actor":{"display_login":"funkycode"}}