{"action":"created","comment":{"url":"https://api.github.com/repos/vaadin/flow-demo/pulls/comments/241657033","pull_request_review_id":184984431,"id":241657033,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTY1NzAzMw==","diff_hunk":"@@ -0,0 +1,132 @@\n+/*\n+ * Copyright 2000-2018 Vaadin Ltd.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not\n+ * use this file except in compliance with the License. You may obtain a copy of\n+ * the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT\n+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the\n+ * License for the specific language governing permissions and limitations under\n+ * the License.\n+ */\n+package com.vaadin.flow.demo;\n+\n+import javax.servlet.http.HttpServletRequest;\n+import java.util.Arrays;\n+\n+import com.vaadin.flow.component.ClickEvent;\n+import com.vaadin.flow.component.UI;\n+import com.vaadin.flow.component.button.Button;\n+import com.vaadin.flow.component.html.Span;\n+import com.vaadin.flow.component.orderedlayout.VerticalLayout;\n+import com.vaadin.flow.component.textfield.PasswordField;\n+import com.vaadin.flow.component.textfield.TextField;\n+import com.vaadin.flow.demo.dynamic.AdminView;\n+import com.vaadin.flow.demo.dynamic.TimeView;\n+import com.vaadin.flow.demo.dynamic.UserView;\n+import com.vaadin.flow.demo.dynamic.VersionView;\n+import com.vaadin.flow.router.Route;\n+import com.vaadin.flow.router.RouterLink;\n+import com.vaadin.flow.router.internal.RouteUtil;\n+import com.vaadin.flow.server.RouteRegistry;\n+import com.vaadin.flow.server.SessionRouteRegistry;\n+import com.vaadin.flow.server.VaadinRequest;\n+import com.vaadin.flow.server.VaadinServlet;\n+import com.vaadin.flow.server.VaadinSession;\n+import com.vaadin.flow.server.startup.ApplicationRouteRegistry;\n+\n+@Route(\"\")\n+public class Login extends VerticalLayout {","path":"demo-dynamic-routes/src/main/java/com/vaadin/flow/demo/Login.java","position":43,"original_position":43,"commit_id":"d28918e1f26392b6952800515c71b74ad1bd90c4","original_commit_id":"d28918e1f26392b6952800515c71b74ad1bd90c4","user":{"login":"vaadin-bot","id":20280877,"node_id":"MDQ6VXNlcjIwMjgwODc3","avatar_url":"https://avatars1.githubusercontent.com/u/20280877?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin-bot","html_url":"https://github.com/vaadin-bot","followers_url":"https://api.github.com/users/vaadin-bot/followers","following_url":"https://api.github.com/users/vaadin-bot/following{/other_user}","gists_url":"https://api.github.com/users/vaadin-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin-bot/subscriptions","organizations_url":"https://api.github.com/users/vaadin-bot/orgs","repos_url":"https://api.github.com/users/vaadin-bot/repos","events_url":"https://api.github.com/users/vaadin-bot/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin-bot/received_events","type":"User","site_admin":false},"body":"![MAJOR](https://sonarsource.github.io/sonar-github/severity-major.png 'Severity: MAJOR') Document this public class by adding an explicit description. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AUndocumentedApi)\n","created_at":"2018-12-14T06:47:39Z","updated_at":"2018-12-14T06:47:39Z","html_url":"https://github.com/vaadin/flow-demo/pull/463#discussion_r241657033","pull_request_url":"https://api.github.com/repos/vaadin/flow-demo/pulls/463","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/vaadin/flow-demo/pulls/comments/241657033"},"html":{"href":"https://github.com/vaadin/flow-demo/pull/463#discussion_r241657033"},"pull_request":{"href":"https://api.github.com/repos/vaadin/flow-demo/pulls/463"}}},"pull_request":{"url":"https://api.github.com/repos/vaadin/flow-demo/pulls/463","id":233517131,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNTE3MTMx","html_url":"https://github.com/vaadin/flow-demo/pull/463","diff_url":"https://github.com/vaadin/flow-demo/pull/463.diff","patch_url":"https://github.com/vaadin/flow-demo/pull/463.patch","issue_url":"https://api.github.com/repos/vaadin/flow-demo/issues/463","number":463,"state":"open","locked":false,"title":"Dynamic route demo.","user":{"login":"caalador","id":2726090,"node_id":"MDQ6VXNlcjI3MjYwOTA=","avatar_url":"https://avatars2.githubusercontent.com/u/2726090?v=4","gravatar_id":"","url":"https://api.github.com/users/caalador","html_url":"https://github.com/caalador","followers_url":"https://api.github.com/users/caalador/followers","following_url":"https://api.github.com/users/caalador/following{/other_user}","gists_url":"https://api.github.com/users/caalador/gists{/gist_id}","starred_url":"https://api.github.com/users/caalador/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caalador/subscriptions","organizations_url":"https://api.github.com/users/caalador/orgs","repos_url":"https://api.github.com/users/caalador/repos","events_url":"https://api.github.com/users/caalador/events{/privacy}","received_events_url":"https://api.github.com/users/caalador/received_events","type":"User","site_admin":false},"body":"Up for Usage/API review.\r\n\r\nDemo for vaadin/flow#4799\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/flow-demo/463)\r\n<!-- Reviewable:end -->\r\n","created_at":"2018-11-26T11:03:24Z","updated_at":"2018-12-14T06:47:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6f0db0a2d98cc68b492f0870b97b5a8e45a98fa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vaadin/flow-demo/pulls/463/commits","review_comments_url":"https://api.github.com/repos/vaadin/flow-demo/pulls/463/comments","review_comment_url":"https://api.github.com/repos/vaadin/flow-demo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vaadin/flow-demo/issues/463/comments","statuses_url":"https://api.github.com/repos/vaadin/flow-demo/statuses/d28918e1f26392b6952800515c71b74ad1bd90c4","head":{"label":"vaadin:issues/4799_dynamic_routes","ref":"issues/4799_dynamic_routes","sha":"d28918e1f26392b6952800515c71b74ad1bd90c4","user":{"login":"vaadin","id":1171922,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzE5MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"repo":{"id":40314679,"node_id":"MDEwOlJlcG9zaXRvcnk0MDMxNDY3OQ==","name":"flow-demo","full_name":"vaadin/flow-demo","private":false,"owner":{"login":"vaadin","id":1171922,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzE5MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vaadin/flow-demo","description":"Technical Demos and test applications for the Vaadin Flow","fork":false,"url":"https://api.github.com/repos/vaadin/flow-demo","forks_url":"https://api.github.com/repos/vaadin/flow-demo/forks","keys_url":"https://api.github.com/repos/vaadin/flow-demo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vaadin/flow-demo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vaadin/flow-demo/teams","hooks_url":"https://api.github.com/repos/vaadin/flow-demo/hooks","issue_events_url":"https://api.github.com/repos/vaadin/flow-demo/issues/events{/number}","events_url":"https://api.github.com/repos/vaadin/flow-demo/events","assignees_url":"https://api.github.com/repos/vaadin/flow-demo/assignees{/user}","branches_url":"https://api.github.com/repos/vaadin/flow-demo/branches{/branch}","tags_url":"https://api.github.com/repos/vaadin/flow-demo/tags","blobs_url":"https://api.github.com/repos/vaadin/flow-demo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vaadin/flow-demo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vaadin/flow-demo/git/refs{/sha}","trees_url":"https://api.github.com/repos/vaadin/flow-demo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vaadin/flow-demo/statuses/{sha}","languages_url":"https://api.github.com/repos/vaadin/flow-demo/languages","stargazers_url":"https://api.github.com/repos/vaadin/flow-demo/stargazers","contributors_url":"https://api.github.com/repos/vaadin/flow-demo/contributors","subscribers_url":"https://api.github.com/repos/vaadin/flow-demo/subscribers","subscription_url":"https://api.github.com/repos/vaadin/flow-demo/subscription","commits_url":"https://api.github.com/repos/vaadin/flow-demo/commits{/sha}","git_commits_url":"https://api.github.com/repos/vaadin/flow-demo/git/commits{/sha}","comments_url":"https://api.github.com/repos/vaadin/flow-demo/comments{/number}","issue_comment_url":"https://api.github.com/repos/vaadin/flow-demo/issues/comments{/number}","contents_url":"https://api.github.com/repos/vaadin/flow-demo/contents/{+path}","compare_url":"https://api.github.com/repos/vaadin/flow-demo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vaadin/flow-demo/merges","archive_url":"https://api.github.com/repos/vaadin/flow-demo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vaadin/flow-demo/downloads","issues_url":"https://api.github.com/repos/vaadin/flow-demo/issues{/number}","pulls_url":"https://api.github.com/repos/vaadin/flow-demo/pulls{/number}","milestones_url":"https://api.github.com/repos/vaadin/flow-demo/milestones{/number}","notifications_url":"https://api.github.com/repos/vaadin/flow-demo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vaadin/flow-demo/labels{/name}","releases_url":"https://api.github.com/repos/vaadin/flow-demo/releases{/id}","deployments_url":"https://api.github.com/repos/vaadin/flow-demo/deployments","created_at":"2015-08-06T16:12:06Z","updated_at":"2018-11-26T09:56:23Z","pushed_at":"2018-12-14T06:27:07Z","git_url":"git://github.com/vaadin/flow-demo.git","ssh_url":"git@github.com:vaadin/flow-demo.git","clone_url":"https://github.com/vaadin/flow-demo.git","svn_url":"https://github.com/vaadin/flow-demo","homepage":"https://vaadin.com/flow","size":7993,"stargazers_count":12,"watchers_count":12,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":5,"open_issues":8,"watchers":12,"default_branch":"master"}},"base":{"label":"vaadin:master","ref":"master","sha":"fc60126e86331c57c7611e2985efa920e16115f1","user":{"login":"vaadin","id":1171922,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzE5MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"repo":{"id":40314679,"node_id":"MDEwOlJlcG9zaXRvcnk0MDMxNDY3OQ==","name":"flow-demo","full_name":"vaadin/flow-demo","private":false,"owner":{"login":"vaadin","id":1171922,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzE5MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vaadin/flow-demo","description":"Technical Demos and test applications for the Vaadin Flow","fork":false,"url":"https://api.github.com/repos/vaadin/flow-demo","forks_url":"https://api.github.com/repos/vaadin/flow-demo/forks","keys_url":"https://api.github.com/repos/vaadin/flow-demo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vaadin/flow-demo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vaadin/flow-demo/teams","hooks_url":"https://api.github.com/repos/vaadin/flow-demo/hooks","issue_events_url":"https://api.github.com/repos/vaadin/flow-demo/issues/events{/number}","events_url":"https://api.github.com/repos/vaadin/flow-demo/events","assignees_url":"https://api.github.com/repos/vaadin/flow-demo/assignees{/user}","branches_url":"https://api.github.com/repos/vaadin/flow-demo/branches{/branch}","tags_url":"https://api.github.com/repos/vaadin/flow-demo/tags","blobs_url":"https://api.github.com/repos/vaadin/flow-demo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vaadin/flow-demo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vaadin/flow-demo/git/refs{/sha}","trees_url":"https://api.github.com/repos/vaadin/flow-demo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vaadin/flow-demo/statuses/{sha}","languages_url":"https://api.github.com/repos/vaadin/flow-demo/languages","stargazers_url":"https://api.github.com/repos/vaadin/flow-demo/stargazers","contributors_url":"https://api.github.com/repos/vaadin/flow-demo/contributors","subscribers_url":"https://api.github.com/repos/vaadin/flow-demo/subscribers","subscription_url":"https://api.github.com/repos/vaadin/flow-demo/subscription","commits_url":"https://api.github.com/repos/vaadin/flow-demo/commits{/sha}","git_commits_url":"https://api.github.com/repos/vaadin/flow-demo/git/commits{/sha}","comments_url":"https://api.github.com/repos/vaadin/flow-demo/comments{/number}","issue_comment_url":"https://api.github.com/repos/vaadin/flow-demo/issues/comments{/number}","contents_url":"https://api.github.com/repos/vaadin/flow-demo/contents/{+path}","compare_url":"https://api.github.com/repos/vaadin/flow-demo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vaadin/flow-demo/merges","archive_url":"https://api.github.com/repos/vaadin/flow-demo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vaadin/flow-demo/downloads","issues_url":"https://api.github.com/repos/vaadin/flow-demo/issues{/number}","pulls_url":"https://api.github.com/repos/vaadin/flow-demo/pulls{/number}","milestones_url":"https://api.github.com/repos/vaadin/flow-demo/milestones{/number}","notifications_url":"https://api.github.com/repos/vaadin/flow-demo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vaadin/flow-demo/labels{/name}","releases_url":"https://api.github.com/repos/vaadin/flow-demo/releases{/id}","deployments_url":"https://api.github.com/repos/vaadin/flow-demo/deployments","created_at":"2015-08-06T16:12:06Z","updated_at":"2018-11-26T09:56:23Z","pushed_at":"2018-12-14T06:27:07Z","git_url":"git://github.com/vaadin/flow-demo.git","ssh_url":"git@github.com:vaadin/flow-demo.git","clone_url":"https://github.com/vaadin/flow-demo.git","svn_url":"https://github.com/vaadin/flow-demo","homepage":"https://vaadin.com/flow","size":7993,"stargazers_count":12,"watchers_count":12,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":5,"open_issues":8,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vaadin/flow-demo/pulls/463"},"html":{"href":"https://github.com/vaadin/flow-demo/pull/463"},"issue":{"href":"https://api.github.com/repos/vaadin/flow-demo/issues/463"},"comments":{"href":"https://api.github.com/repos/vaadin/flow-demo/issues/463/comments"},"review_comments":{"href":"https://api.github.com/repos/vaadin/flow-demo/pulls/463/comments"},"review_comment":{"href":"https://api.github.com/repos/vaadin/flow-demo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vaadin/flow-demo/pulls/463/commits"},"statuses":{"href":"https://api.github.com/repos/vaadin/flow-demo/statuses/d28918e1f26392b6952800515c71b74ad1bd90c4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vaadin-bot"}}