{"action":"created","comment":{"url":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments/207916154","pull_request_review_id":143622844,"id":207916154,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzkxNjE1NA==","diff_hunk":"@@ -290,7 +290,7 @@ sub locate_local_assets {\n \n     for my $key (keys %$assetkeys) {\n         my $file = locate_asset($assetkeys->{$key}, $vars->{$key}, mustexist => 1);\n-        unless ($file) {\n+        unless ($file && $key != 'UEFI_PFLASH_VARS') {","path":"lib/OpenQA/Worker/Engines/isotovideo.pm","position":5,"original_position":5,"commit_id":"78e2d4705b090d9ced287234e0f36a4d256b88dd","original_commit_id":"78e2d4705b090d9ced287234e0f36a4d256b88dd","user":{"login":"Martchus","id":10248953,"node_id":"MDQ6VXNlcjEwMjQ4OTUz","avatar_url":"https://avatars3.githubusercontent.com/u/10248953?v=4","gravatar_id":"","url":"https://api.github.com/users/Martchus","html_url":"https://github.com/Martchus","followers_url":"https://api.github.com/users/Martchus/followers","following_url":"https://api.github.com/users/Martchus/following{/other_user}","gists_url":"https://api.github.com/users/Martchus/gists{/gist_id}","starred_url":"https://api.github.com/users/Martchus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Martchus/subscriptions","organizations_url":"https://api.github.com/users/Martchus/orgs","repos_url":"https://api.github.com/users/Martchus/repos","events_url":"https://api.github.com/users/Martchus/events{/privacy}","received_events_url":"https://api.github.com/users/Martchus/received_events","type":"User","site_admin":false},"body":"I think it must be `ne` in Perl when comparing strings (instead of `!=`). At least that's what we use everywhere.","created_at":"2018-08-06T14:41:51Z","updated_at":"2018-08-06T14:41:52Z","html_url":"https://github.com/os-autoinst/openQA/pull/1737#discussion_r207916154","pull_request_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/1737","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments/207916154"},"html":{"href":"https://github.com/os-autoinst/openQA/pull/1737#discussion_r207916154"},"pull_request":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/1737"}}},"pull_request":{"url":"https://api.github.com/repos/os-autoinst/openQA/pulls/1737","id":206403610,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NDAzNjEw","html_url":"https://github.com/os-autoinst/openQA/pull/1737","diff_url":"https://github.com/os-autoinst/openQA/pull/1737.diff","patch_url":"https://github.com/os-autoinst/openQA/pull/1737.patch","issue_url":"https://api.github.com/repos/os-autoinst/openQA/issues/1737","number":1737,"state":"open","locked":false,"title":"Fix full-stack.t","user":{"login":"foursixnine","id":229240,"node_id":"MDQ6VXNlcjIyOTI0MA==","avatar_url":"https://avatars0.githubusercontent.com/u/229240?v=4","gravatar_id":"","url":"https://api.github.com/users/foursixnine","html_url":"https://github.com/foursixnine","followers_url":"https://api.github.com/users/foursixnine/followers","following_url":"https://api.github.com/users/foursixnine/following{/other_user}","gists_url":"https://api.github.com/users/foursixnine/gists{/gist_id}","starred_url":"https://api.github.com/users/foursixnine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foursixnine/subscriptions","organizations_url":"https://api.github.com/users/foursixnine/orgs","repos_url":"https://api.github.com/users/foursixnine/repos","events_url":"https://api.github.com/users/foursixnine/events{/privacy}","received_events_url":"https://api.github.com/users/foursixnine/received_events","type":"User","site_admin":false},"body":"138294f0c61291b1bcfe713d7771314df6d765a2 broke the full stack tests","created_at":"2018-08-06T13:44:15Z","updated_at":"2018-08-06T14:41:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42cef8b12fa40a24f14b7a72938b1ebafa68be2c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/1737/commits","review_comments_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/1737/comments","review_comment_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/os-autoinst/openQA/issues/1737/comments","statuses_url":"https://api.github.com/repos/os-autoinst/openQA/statuses/78e2d4705b090d9ced287234e0f36a4d256b88dd","head":{"label":"foursixnine:fix-fullstack","ref":"fix-fullstack","sha":"78e2d4705b090d9ced287234e0f36a4d256b88dd","user":{"login":"foursixnine","id":229240,"node_id":"MDQ6VXNlcjIyOTI0MA==","avatar_url":"https://avatars0.githubusercontent.com/u/229240?v=4","gravatar_id":"","url":"https://api.github.com/users/foursixnine","html_url":"https://github.com/foursixnine","followers_url":"https://api.github.com/users/foursixnine/followers","following_url":"https://api.github.com/users/foursixnine/following{/other_user}","gists_url":"https://api.github.com/users/foursixnine/gists{/gist_id}","starred_url":"https://api.github.com/users/foursixnine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foursixnine/subscriptions","organizations_url":"https://api.github.com/users/foursixnine/orgs","repos_url":"https://api.github.com/users/foursixnine/repos","events_url":"https://api.github.com/users/foursixnine/events{/privacy}","received_events_url":"https://api.github.com/users/foursixnine/received_events","type":"User","site_admin":false},"repo":{"id":70133290,"node_id":"MDEwOlJlcG9zaXRvcnk3MDEzMzI5MA==","name":"openQA","full_name":"foursixnine/openQA","owner":{"login":"foursixnine","id":229240,"node_id":"MDQ6VXNlcjIyOTI0MA==","avatar_url":"https://avatars0.githubusercontent.com/u/229240?v=4","gravatar_id":"","url":"https://api.github.com/users/foursixnine","html_url":"https://github.com/foursixnine","followers_url":"https://api.github.com/users/foursixnine/followers","following_url":"https://api.github.com/users/foursixnine/following{/other_user}","gists_url":"https://api.github.com/users/foursixnine/gists{/gist_id}","starred_url":"https://api.github.com/users/foursixnine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foursixnine/subscriptions","organizations_url":"https://api.github.com/users/foursixnine/orgs","repos_url":"https://api.github.com/users/foursixnine/repos","events_url":"https://api.github.com/users/foursixnine/events{/privacy}","received_events_url":"https://api.github.com/users/foursixnine/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/foursixnine/openQA","description":"openQA web-frontend, scheduler and tools","fork":true,"url":"https://api.github.com/repos/foursixnine/openQA","forks_url":"https://api.github.com/repos/foursixnine/openQA/forks","keys_url":"https://api.github.com/repos/foursixnine/openQA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/foursixnine/openQA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/foursixnine/openQA/teams","hooks_url":"https://api.github.com/repos/foursixnine/openQA/hooks","issue_events_url":"https://api.github.com/repos/foursixnine/openQA/issues/events{/number}","events_url":"https://api.github.com/repos/foursixnine/openQA/events","assignees_url":"https://api.github.com/repos/foursixnine/openQA/assignees{/user}","branches_url":"https://api.github.com/repos/foursixnine/openQA/branches{/branch}","tags_url":"https://api.github.com/repos/foursixnine/openQA/tags","blobs_url":"https://api.github.com/repos/foursixnine/openQA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/foursixnine/openQA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/foursixnine/openQA/git/refs{/sha}","trees_url":"https://api.github.com/repos/foursixnine/openQA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/foursixnine/openQA/statuses/{sha}","languages_url":"https://api.github.com/repos/foursixnine/openQA/languages","stargazers_url":"https://api.github.com/repos/foursixnine/openQA/stargazers","contributors_url":"https://api.github.com/repos/foursixnine/openQA/contributors","subscribers_url":"https://api.github.com/repos/foursixnine/openQA/subscribers","subscription_url":"https://api.github.com/repos/foursixnine/openQA/subscription","commits_url":"https://api.github.com/repos/foursixnine/openQA/commits{/sha}","git_commits_url":"https://api.github.com/repos/foursixnine/openQA/git/commits{/sha}","comments_url":"https://api.github.com/repos/foursixnine/openQA/comments{/number}","issue_comment_url":"https://api.github.com/repos/foursixnine/openQA/issues/comments{/number}","contents_url":"https://api.github.com/repos/foursixnine/openQA/contents/{+path}","compare_url":"https://api.github.com/repos/foursixnine/openQA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/foursixnine/openQA/merges","archive_url":"https://api.github.com/repos/foursixnine/openQA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/foursixnine/openQA/downloads","issues_url":"https://api.github.com/repos/foursixnine/openQA/issues{/number}","pulls_url":"https://api.github.com/repos/foursixnine/openQA/pulls{/number}","milestones_url":"https://api.github.com/repos/foursixnine/openQA/milestones{/number}","notifications_url":"https://api.github.com/repos/foursixnine/openQA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/foursixnine/openQA/labels{/name}","releases_url":"https://api.github.com/repos/foursixnine/openQA/releases{/id}","deployments_url":"https://api.github.com/repos/foursixnine/openQA/deployments","created_at":"2016-10-06T07:43:14Z","updated_at":"2018-05-15T14:36:37Z","pushed_at":"2018-08-06T14:23:39Z","git_url":"git://github.com/foursixnine/openQA.git","ssh_url":"git@github.com:foursixnine/openQA.git","clone_url":"https://github.com/foursixnine/openQA.git","svn_url":"https://github.com/foursixnine/openQA","homepage":"http://openqa.opensuse.org/","size":23004,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"os-autoinst:master","ref":"master","sha":"dddbc46b5cca62ec0b0fcdafb7d935f49cc97ace","user":{"login":"os-autoinst","id":6918706,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTg3MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/6918706?v=4","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"repo":{"id":20883829,"node_id":"MDEwOlJlcG9zaXRvcnkyMDg4MzgyOQ==","name":"openQA","full_name":"os-autoinst/openQA","owner":{"login":"os-autoinst","id":6918706,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTg3MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/6918706?v=4","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/os-autoinst/openQA","description":"openQA web-frontend, scheduler and tools.","fork":false,"url":"https://api.github.com/repos/os-autoinst/openQA","forks_url":"https://api.github.com/repos/os-autoinst/openQA/forks","keys_url":"https://api.github.com/repos/os-autoinst/openQA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/os-autoinst/openQA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/os-autoinst/openQA/teams","hooks_url":"https://api.github.com/repos/os-autoinst/openQA/hooks","issue_events_url":"https://api.github.com/repos/os-autoinst/openQA/issues/events{/number}","events_url":"https://api.github.com/repos/os-autoinst/openQA/events","assignees_url":"https://api.github.com/repos/os-autoinst/openQA/assignees{/user}","branches_url":"https://api.github.com/repos/os-autoinst/openQA/branches{/branch}","tags_url":"https://api.github.com/repos/os-autoinst/openQA/tags","blobs_url":"https://api.github.com/repos/os-autoinst/openQA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/os-autoinst/openQA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/os-autoinst/openQA/git/refs{/sha}","trees_url":"https://api.github.com/repos/os-autoinst/openQA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/os-autoinst/openQA/statuses/{sha}","languages_url":"https://api.github.com/repos/os-autoinst/openQA/languages","stargazers_url":"https://api.github.com/repos/os-autoinst/openQA/stargazers","contributors_url":"https://api.github.com/repos/os-autoinst/openQA/contributors","subscribers_url":"https://api.github.com/repos/os-autoinst/openQA/subscribers","subscription_url":"https://api.github.com/repos/os-autoinst/openQA/subscription","commits_url":"https://api.github.com/repos/os-autoinst/openQA/commits{/sha}","git_commits_url":"https://api.github.com/repos/os-autoinst/openQA/git/commits{/sha}","comments_url":"https://api.github.com/repos/os-autoinst/openQA/comments{/number}","issue_comment_url":"https://api.github.com/repos/os-autoinst/openQA/issues/comments{/number}","contents_url":"https://api.github.com/repos/os-autoinst/openQA/contents/{+path}","compare_url":"https://api.github.com/repos/os-autoinst/openQA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/os-autoinst/openQA/merges","archive_url":"https://api.github.com/repos/os-autoinst/openQA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/os-autoinst/openQA/downloads","issues_url":"https://api.github.com/repos/os-autoinst/openQA/issues{/number}","pulls_url":"https://api.github.com/repos/os-autoinst/openQA/pulls{/number}","milestones_url":"https://api.github.com/repos/os-autoinst/openQA/milestones{/number}","notifications_url":"https://api.github.com/repos/os-autoinst/openQA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/os-autoinst/openQA/labels{/name}","releases_url":"https://api.github.com/repos/os-autoinst/openQA/releases{/id}","deployments_url":"https://api.github.com/repos/os-autoinst/openQA/deployments","created_at":"2014-06-16T12:23:22Z","updated_at":"2018-08-06T14:33:48Z","pushed_at":"2018-08-06T14:34:27Z","git_url":"git://github.com/os-autoinst/openQA.git","ssh_url":"git@github.com:os-autoinst/openQA.git","clone_url":"https://github.com/os-autoinst/openQA.git","svn_url":"https://github.com/os-autoinst/openQA","homepage":"http://openqa.opensuse.org/","size":24533,"stargazers_count":126,"watchers_count":126,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":100,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":100,"open_issues":16,"watchers":126,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/1737"},"html":{"href":"https://github.com/os-autoinst/openQA/pull/1737"},"issue":{"href":"https://api.github.com/repos/os-autoinst/openQA/issues/1737"},"comments":{"href":"https://api.github.com/repos/os-autoinst/openQA/issues/1737/comments"},"review_comments":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/1737/comments"},"review_comment":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/1737/commits"},"statuses":{"href":"https://api.github.com/repos/os-autoinst/openQA/statuses/78e2d4705b090d9ced287234e0f36a4d256b88dd"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Martchus"}}