{"action":"created","issue":{"url":"https://api.github.com/repos/grobian/carbon-c-relay/issues/334","repository_url":"https://api.github.com/repos/grobian/carbon-c-relay","labels_url":"https://api.github.com/repos/grobian/carbon-c-relay/issues/334/labels{/name}","comments_url":"https://api.github.com/repos/grobian/carbon-c-relay/issues/334/comments","events_url":"https://api.github.com/repos/grobian/carbon-c-relay/issues/334/events","html_url":"https://github.com/grobian/carbon-c-relay/pull/334","id":333522950,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NzE0NDY3","number":334,"title":"Fix checking for -lcrypto for OpenSSL 1.1","user":{"login":"hnakamur","id":19299,"node_id":"MDQ6VXNlcjE5Mjk5","avatar_url":"https://avatars2.githubusercontent.com/u/19299?v=4","gravatar_id":"","url":"https://api.github.com/users/hnakamur","html_url":"https://github.com/hnakamur","followers_url":"https://api.github.com/users/hnakamur/followers","following_url":"https://api.github.com/users/hnakamur/following{/other_user}","gists_url":"https://api.github.com/users/hnakamur/gists{/gist_id}","starred_url":"https://api.github.com/users/hnakamur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hnakamur/subscriptions","organizations_url":"https://api.github.com/users/hnakamur/orgs","repos_url":"https://api.github.com/users/hnakamur/repos","events_url":"https://api.github.com/users/hnakamur/events{/privacy}","received_events_url":"https://api.github.com/users/hnakamur/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-19T05:22:21Z","updated_at":"2018-06-19T10:46:10Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/grobian/carbon-c-relay/pulls/334","html_url":"https://github.com/grobian/carbon-c-relay/pull/334","diff_url":"https://github.com/grobian/carbon-c-relay/pull/334.diff","patch_url":"https://github.com/grobian/carbon-c-relay/pull/334.patch"},"body":"This pull request fixes https://github.com/grobian/carbon-c-relay/issues/332"},"comment":{"url":"https://api.github.com/repos/grobian/carbon-c-relay/issues/comments/398356370","html_url":"https://github.com/grobian/carbon-c-relay/pull/334#issuecomment-398356370","issue_url":"https://api.github.com/repos/grobian/carbon-c-relay/issues/334","id":398356370,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODM1NjM3MA==","user":{"login":"hnakamur","id":19299,"node_id":"MDQ6VXNlcjE5Mjk5","avatar_url":"https://avatars2.githubusercontent.com/u/19299?v=4","gravatar_id":"","url":"https://api.github.com/users/hnakamur","html_url":"https://github.com/hnakamur","followers_url":"https://api.github.com/users/hnakamur/followers","following_url":"https://api.github.com/users/hnakamur/following{/other_user}","gists_url":"https://api.github.com/users/hnakamur/gists{/gist_id}","starred_url":"https://api.github.com/users/hnakamur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hnakamur/subscriptions","organizations_url":"https://api.github.com/users/hnakamur/orgs","repos_url":"https://api.github.com/users/hnakamur/repos","events_url":"https://api.github.com/users/hnakamur/events{/privacy}","received_events_url":"https://api.github.com/users/hnakamur/received_events","type":"User","site_admin":false},"created_at":"2018-06-19T10:46:10Z","updated_at":"2018-06-19T10:46:10Z","author_association":"NONE","body":"`ERR_reason_error_string` is declared in `/usr/include/openssl/err.h`, so I don't think it is specific to `-lcrypto`.\r\n\r\nI read https://wiki.openssl.org/index.php/Compilation_and_Installation#Autoconf\r\nand noticed `OPENSSL_init_ssl` is used to detect `-lssl`.\r\nSo I chose `OPENSSL_init_crypto` to detect `-lcrypto`.\r\n\r\nHowever `OPENSSL_init_crypto` exists only OpenSSL 1.1.x.\r\nSo I kept `OPENSSL_add_all_algorithms_noconf` for OpenSSL 1.0.x\r\n\r\nMaybe `CRYPTO_mem_ctrl` or something that is declared in `/usr/include/openssl/crypto.h` of both OpenSSL 1.1.x and 1.0.x would do.\r\n"}}
{"actor":{"display_login":"hnakamur"}}