{"action":"created","comment":{"url":"https://api.github.com/repos/joukevandermaas/saule/pulls/comments/228047704","pull_request_review_id":168224307,"id":228047704,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODA0NzcwNA==","diff_hunk":"@@ -9,11 +13,34 @@ public class FilterProperty\n         /// Initializes a new instance of the <see cref=\"FilterProperty\"/> class.\n         /// </summary>\n         /// <param name=\"name\">property name</param>\n-        /// <param name=\"value\">property value</param>\n-        public FilterProperty(string name, string value)\n+        /// <param name=\"values\">property values in one string in csv notation</param>\n+        public FilterProperty(string name, string values)\n         {\n-            Value = value;\n             Name = name.ToPascalCase();\n+            Value = values;\n+\n+            // Spliting the string into multiple values with csv notation\n+            Values = new List<string>();\n+\n+            var match = new Regex(\"(?:,\\\"|^\\\")(\\\"\\\"|[\\\\w\\\\W]*?)(?=\\\",|\\\"$)|(?:,(?!\\\")|^(?!\\\"))([^,]*?)(?=$|,)\").Matches(values);","path":"Saule/Queries/Filtering/FilterProperty.cs","position":26,"original_position":26,"commit_id":"58d57d095ca8517ee63672d0b8598f481e7d8469","original_commit_id":"58d57d095ca8517ee63672d0b8598f481e7d8469","user":{"login":"joukevandermaas","id":1257578,"node_id":"MDQ6VXNlcjEyNTc1Nzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1257578?v=4","gravatar_id":"","url":"https://api.github.com/users/joukevandermaas","html_url":"https://github.com/joukevandermaas","followers_url":"https://api.github.com/users/joukevandermaas/followers","following_url":"https://api.github.com/users/joukevandermaas/following{/other_user}","gists_url":"https://api.github.com/users/joukevandermaas/gists{/gist_id}","starred_url":"https://api.github.com/users/joukevandermaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joukevandermaas/subscriptions","organizations_url":"https://api.github.com/users/joukevandermaas/orgs","repos_url":"https://api.github.com/users/joukevandermaas/repos","events_url":"https://api.github.com/users/joukevandermaas/events{/privacy}","received_events_url":"https://api.github.com/users/joukevandermaas/received_events","type":"User","site_admin":false},"body":"Can you maybe put a comment that explains this regex? Some time in the future we may want to remember how it works.","created_at":"2018-10-25T06:29:31Z","updated_at":"2018-10-25T06:35:45Z","html_url":"https://github.com/joukevandermaas/saule/pull/205#discussion_r228047704","pull_request_url":"https://api.github.com/repos/joukevandermaas/saule/pulls/205","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/joukevandermaas/saule/pulls/comments/228047704"},"html":{"href":"https://github.com/joukevandermaas/saule/pull/205#discussion_r228047704"},"pull_request":{"href":"https://api.github.com/repos/joukevandermaas/saule/pulls/205"}}},"pull_request":{"url":"https://api.github.com/repos/joukevandermaas/saule/pulls/205","id":221078682,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMDc4Njgy","html_url":"https://github.com/joukevandermaas/saule/pull/205","diff_url":"https://github.com/joukevandermaas/saule/pull/205.diff","patch_url":"https://github.com/joukevandermaas/saule/pull/205.patch","issue_url":"https://api.github.com/repos/joukevandermaas/saule/issues/205","number":205,"state":"open","locked":false,"title":"Added a new filter expression for multiple search on strings","user":{"login":"PhyberApex","id":1316500,"node_id":"MDQ6VXNlcjEzMTY1MDA=","avatar_url":"https://avatars3.githubusercontent.com/u/1316500?v=4","gravatar_id":"","url":"https://api.github.com/users/PhyberApex","html_url":"https://github.com/PhyberApex","followers_url":"https://api.github.com/users/PhyberApex/followers","following_url":"https://api.github.com/users/PhyberApex/following{/other_user}","gists_url":"https://api.github.com/users/PhyberApex/gists{/gist_id}","starred_url":"https://api.github.com/users/PhyberApex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhyberApex/subscriptions","organizations_url":"https://api.github.com/users/PhyberApex/orgs","repos_url":"https://api.github.com/users/PhyberApex/repos","events_url":"https://api.github.com/users/PhyberApex/events{/privacy}","received_events_url":"https://api.github.com/users/PhyberApex/received_events","type":"User","site_admin":false},"body":"Added tests for the new expression","created_at":"2018-10-08T11:10:17Z","updated_at":"2018-10-25T06:35:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"616e15f5e219b8a41bbdb2dec3f0925ef2bad981","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/joukevandermaas/saule/pulls/205/commits","review_comments_url":"https://api.github.com/repos/joukevandermaas/saule/pulls/205/comments","review_comment_url":"https://api.github.com/repos/joukevandermaas/saule/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joukevandermaas/saule/issues/205/comments","statuses_url":"https://api.github.com/repos/joukevandermaas/saule/statuses/58d57d095ca8517ee63672d0b8598f481e7d8469","head":{"label":"PhyberApex:feature/csvfilter","ref":"feature/csvfilter","sha":"58d57d095ca8517ee63672d0b8598f481e7d8469","user":{"login":"PhyberApex","id":1316500,"node_id":"MDQ6VXNlcjEzMTY1MDA=","avatar_url":"https://avatars3.githubusercontent.com/u/1316500?v=4","gravatar_id":"","url":"https://api.github.com/users/PhyberApex","html_url":"https://github.com/PhyberApex","followers_url":"https://api.github.com/users/PhyberApex/followers","following_url":"https://api.github.com/users/PhyberApex/following{/other_user}","gists_url":"https://api.github.com/users/PhyberApex/gists{/gist_id}","starred_url":"https://api.github.com/users/PhyberApex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhyberApex/subscriptions","organizations_url":"https://api.github.com/users/PhyberApex/orgs","repos_url":"https://api.github.com/users/PhyberApex/repos","events_url":"https://api.github.com/users/PhyberApex/events{/privacy}","received_events_url":"https://api.github.com/users/PhyberApex/received_events","type":"User","site_admin":false},"repo":{"id":151767742,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE3Njc3NDI=","name":"saule","full_name":"PhyberApex/saule","private":false,"owner":{"login":"PhyberApex","id":1316500,"node_id":"MDQ6VXNlcjEzMTY1MDA=","avatar_url":"https://avatars3.githubusercontent.com/u/1316500?v=4","gravatar_id":"","url":"https://api.github.com/users/PhyberApex","html_url":"https://github.com/PhyberApex","followers_url":"https://api.github.com/users/PhyberApex/followers","following_url":"https://api.github.com/users/PhyberApex/following{/other_user}","gists_url":"https://api.github.com/users/PhyberApex/gists{/gist_id}","starred_url":"https://api.github.com/users/PhyberApex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhyberApex/subscriptions","organizations_url":"https://api.github.com/users/PhyberApex/orgs","repos_url":"https://api.github.com/users/PhyberApex/repos","events_url":"https://api.github.com/users/PhyberApex/events{/privacy}","received_events_url":"https://api.github.com/users/PhyberApex/received_events","type":"User","site_admin":false},"html_url":"https://github.com/PhyberApex/saule","description":"JSON API library for ASP.Net Web API 2.","fork":true,"url":"https://api.github.com/repos/PhyberApex/saule","forks_url":"https://api.github.com/repos/PhyberApex/saule/forks","keys_url":"https://api.github.com/repos/PhyberApex/saule/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PhyberApex/saule/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PhyberApex/saule/teams","hooks_url":"https://api.github.com/repos/PhyberApex/saule/hooks","issue_events_url":"https://api.github.com/repos/PhyberApex/saule/issues/events{/number}","events_url":"https://api.github.com/repos/PhyberApex/saule/events","assignees_url":"https://api.github.com/repos/PhyberApex/saule/assignees{/user}","branches_url":"https://api.github.com/repos/PhyberApex/saule/branches{/branch}","tags_url":"https://api.github.com/repos/PhyberApex/saule/tags","blobs_url":"https://api.github.com/repos/PhyberApex/saule/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PhyberApex/saule/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PhyberApex/saule/git/refs{/sha}","trees_url":"https://api.github.com/repos/PhyberApex/saule/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PhyberApex/saule/statuses/{sha}","languages_url":"https://api.github.com/repos/PhyberApex/saule/languages","stargazers_url":"https://api.github.com/repos/PhyberApex/saule/stargazers","contributors_url":"https://api.github.com/repos/PhyberApex/saule/contributors","subscribers_url":"https://api.github.com/repos/PhyberApex/saule/subscribers","subscription_url":"https://api.github.com/repos/PhyberApex/saule/subscription","commits_url":"https://api.github.com/repos/PhyberApex/saule/commits{/sha}","git_commits_url":"https://api.github.com/repos/PhyberApex/saule/git/commits{/sha}","comments_url":"https://api.github.com/repos/PhyberApex/saule/comments{/number}","issue_comment_url":"https://api.github.com/repos/PhyberApex/saule/issues/comments{/number}","contents_url":"https://api.github.com/repos/PhyberApex/saule/contents/{+path}","compare_url":"https://api.github.com/repos/PhyberApex/saule/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PhyberApex/saule/merges","archive_url":"https://api.github.com/repos/PhyberApex/saule/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PhyberApex/saule/downloads","issues_url":"https://api.github.com/repos/PhyberApex/saule/issues{/number}","pulls_url":"https://api.github.com/repos/PhyberApex/saule/pulls{/number}","milestones_url":"https://api.github.com/repos/PhyberApex/saule/milestones{/number}","notifications_url":"https://api.github.com/repos/PhyberApex/saule/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PhyberApex/saule/labels{/name}","releases_url":"https://api.github.com/repos/PhyberApex/saule/releases{/id}","deployments_url":"https://api.github.com/repos/PhyberApex/saule/deployments","created_at":"2018-10-05T19:21:58Z","updated_at":"2018-10-25T06:16:08Z","pushed_at":"2018-10-25T06:16:07Z","git_url":"git://github.com/PhyberApex/saule.git","ssh_url":"git@github.com:PhyberApex/saule.git","clone_url":"https://github.com/PhyberApex/saule.git","svn_url":"https://github.com/PhyberApex/saule","homepage":"http://joukevandermaas.github.io/saule","size":672,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"joukevandermaas:master","ref":"master","sha":"0ddeaf4c21bf7d3ea13008c22ed657e00a73f557","user":{"login":"joukevandermaas","id":1257578,"node_id":"MDQ6VXNlcjEyNTc1Nzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1257578?v=4","gravatar_id":"","url":"https://api.github.com/users/joukevandermaas","html_url":"https://github.com/joukevandermaas","followers_url":"https://api.github.com/users/joukevandermaas/followers","following_url":"https://api.github.com/users/joukevandermaas/following{/other_user}","gists_url":"https://api.github.com/users/joukevandermaas/gists{/gist_id}","starred_url":"https://api.github.com/users/joukevandermaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joukevandermaas/subscriptions","organizations_url":"https://api.github.com/users/joukevandermaas/orgs","repos_url":"https://api.github.com/users/joukevandermaas/repos","events_url":"https://api.github.com/users/joukevandermaas/events{/privacy}","received_events_url":"https://api.github.com/users/joukevandermaas/received_events","type":"User","site_admin":false},"repo":{"id":42359114,"node_id":"MDEwOlJlcG9zaXRvcnk0MjM1OTExNA==","name":"saule","full_name":"joukevandermaas/saule","private":false,"owner":{"login":"joukevandermaas","id":1257578,"node_id":"MDQ6VXNlcjEyNTc1Nzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1257578?v=4","gravatar_id":"","url":"https://api.github.com/users/joukevandermaas","html_url":"https://github.com/joukevandermaas","followers_url":"https://api.github.com/users/joukevandermaas/followers","following_url":"https://api.github.com/users/joukevandermaas/following{/other_user}","gists_url":"https://api.github.com/users/joukevandermaas/gists{/gist_id}","starred_url":"https://api.github.com/users/joukevandermaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joukevandermaas/subscriptions","organizations_url":"https://api.github.com/users/joukevandermaas/orgs","repos_url":"https://api.github.com/users/joukevandermaas/repos","events_url":"https://api.github.com/users/joukevandermaas/events{/privacy}","received_events_url":"https://api.github.com/users/joukevandermaas/received_events","type":"User","site_admin":false},"html_url":"https://github.com/joukevandermaas/saule","description":"JSON API library for ASP.Net Web API 2.","fork":false,"url":"https://api.github.com/repos/joukevandermaas/saule","forks_url":"https://api.github.com/repos/joukevandermaas/saule/forks","keys_url":"https://api.github.com/repos/joukevandermaas/saule/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joukevandermaas/saule/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joukevandermaas/saule/teams","hooks_url":"https://api.github.com/repos/joukevandermaas/saule/hooks","issue_events_url":"https://api.github.com/repos/joukevandermaas/saule/issues/events{/number}","events_url":"https://api.github.com/repos/joukevandermaas/saule/events","assignees_url":"https://api.github.com/repos/joukevandermaas/saule/assignees{/user}","branches_url":"https://api.github.com/repos/joukevandermaas/saule/branches{/branch}","tags_url":"https://api.github.com/repos/joukevandermaas/saule/tags","blobs_url":"https://api.github.com/repos/joukevandermaas/saule/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joukevandermaas/saule/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joukevandermaas/saule/git/refs{/sha}","trees_url":"https://api.github.com/repos/joukevandermaas/saule/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joukevandermaas/saule/statuses/{sha}","languages_url":"https://api.github.com/repos/joukevandermaas/saule/languages","stargazers_url":"https://api.github.com/repos/joukevandermaas/saule/stargazers","contributors_url":"https://api.github.com/repos/joukevandermaas/saule/contributors","subscribers_url":"https://api.github.com/repos/joukevandermaas/saule/subscribers","subscription_url":"https://api.github.com/repos/joukevandermaas/saule/subscription","commits_url":"https://api.github.com/repos/joukevandermaas/saule/commits{/sha}","git_commits_url":"https://api.github.com/repos/joukevandermaas/saule/git/commits{/sha}","comments_url":"https://api.github.com/repos/joukevandermaas/saule/comments{/number}","issue_comment_url":"https://api.github.com/repos/joukevandermaas/saule/issues/comments{/number}","contents_url":"https://api.github.com/repos/joukevandermaas/saule/contents/{+path}","compare_url":"https://api.github.com/repos/joukevandermaas/saule/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joukevandermaas/saule/merges","archive_url":"https://api.github.com/repos/joukevandermaas/saule/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joukevandermaas/saule/downloads","issues_url":"https://api.github.com/repos/joukevandermaas/saule/issues{/number}","pulls_url":"https://api.github.com/repos/joukevandermaas/saule/pulls{/number}","milestones_url":"https://api.github.com/repos/joukevandermaas/saule/milestones{/number}","notifications_url":"https://api.github.com/repos/joukevandermaas/saule/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joukevandermaas/saule/labels{/name}","releases_url":"https://api.github.com/repos/joukevandermaas/saule/releases{/id}","deployments_url":"https://api.github.com/repos/joukevandermaas/saule/deployments","created_at":"2015-09-12T14:05:55Z","updated_at":"2018-10-23T16:17:51Z","pushed_at":"2018-10-25T06:12:57Z","git_url":"git://github.com/joukevandermaas/saule.git","ssh_url":"git@github.com:joukevandermaas/saule.git","clone_url":"https://github.com/joukevandermaas/saule.git","svn_url":"https://github.com/joukevandermaas/saule","homepage":"http://joukevandermaas.github.io/saule","size":641,"stargazers_count":64,"watchers_count":64,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":38,"open_issues":19,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joukevandermaas/saule/pulls/205"},"html":{"href":"https://github.com/joukevandermaas/saule/pull/205"},"issue":{"href":"https://api.github.com/repos/joukevandermaas/saule/issues/205"},"comments":{"href":"https://api.github.com/repos/joukevandermaas/saule/issues/205/comments"},"review_comments":{"href":"https://api.github.com/repos/joukevandermaas/saule/pulls/205/comments"},"review_comment":{"href":"https://api.github.com/repos/joukevandermaas/saule/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joukevandermaas/saule/pulls/205/commits"},"statuses":{"href":"https://api.github.com/repos/joukevandermaas/saule/statuses/58d57d095ca8517ee63672d0b8598f481e7d8469"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"joukevandermaas"}}