{"action":"created","comment":{"url":"https://api.github.com/repos/LiskHQ/lisk-js/pulls/comments/181747736","pull_request_review_id":112367033,"id":181747736,"diff_hunk":"@@ -46,6 +46,12 @@ describe('expect(transaction)s', () => {\n \t\t\t\t.and.be.a('function');\n \t\t});\n \n+\t\tit('to have the sign multisignature expect(transaction) function', () => {","path":"test/transactions/index.js","position":4,"original_position":4,"commit_id":"08909d35a3327bca356d3a921e9f763f55fcd2d8","original_commit_id":"08909d35a3327bca356d3a921e9f763f55fcd2d8","user":{"login":"willclarktech","id":11036220,"avatar_url":"https://avatars3.githubusercontent.com/u/11036220?v=4","gravatar_id":"","url":"https://api.github.com/users/willclarktech","html_url":"https://github.com/willclarktech","followers_url":"https://api.github.com/users/willclarktech/followers","following_url":"https://api.github.com/users/willclarktech/following{/other_user}","gists_url":"https://api.github.com/users/willclarktech/gists{/gist_id}","starred_url":"https://api.github.com/users/willclarktech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willclarktech/subscriptions","organizations_url":"https://api.github.com/users/willclarktech/orgs","repos_url":"https://api.github.com/users/willclarktech/repos","events_url":"https://api.github.com/users/willclarktech/events{/privacy}","received_events_url":"https://api.github.com/users/willclarktech/received_events","type":"User","site_admin":false},"body":"I think the text went a bit strange here (also the following existing test).","created_at":"2018-04-16T14:12:34Z","updated_at":"2018-04-16T14:26:03Z","html_url":"https://github.com/LiskHQ/lisk-js/pull/641#discussion_r181747736","pull_request_url":"https://api.github.com/repos/LiskHQ/lisk-js/pulls/641","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/LiskHQ/lisk-js/pulls/comments/181747736"},"html":{"href":"https://github.com/LiskHQ/lisk-js/pull/641#discussion_r181747736"},"pull_request":{"href":"https://api.github.com/repos/LiskHQ/lisk-js/pulls/641"}}},"pull_request":{"url":"https://api.github.com/repos/LiskHQ/lisk-js/pulls/641","id":180966620,"html_url":"https://github.com/LiskHQ/lisk-js/pull/641","diff_url":"https://github.com/LiskHQ/lisk-js/pull/641.diff","patch_url":"https://github.com/LiskHQ/lisk-js/pull/641.patch","issue_url":"https://api.github.com/repos/LiskHQ/lisk-js/issues/641","number":641,"state":"open","locked":false,"title":"Add a feature to sign transaction for multi-signature ","user":{"login":"shuse2","id":2367565,"avatar_url":"https://avatars0.githubusercontent.com/u/2367565?v=4","gravatar_id":"","url":"https://api.github.com/users/shuse2","html_url":"https://github.com/shuse2","followers_url":"https://api.github.com/users/shuse2/followers","following_url":"https://api.github.com/users/shuse2/following{/other_user}","gists_url":"https://api.github.com/users/shuse2/gists{/gist_id}","starred_url":"https://api.github.com/users/shuse2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuse2/subscriptions","organizations_url":"https://api.github.com/users/shuse2/orgs","repos_url":"https://api.github.com/users/shuse2/repos","events_url":"https://api.github.com/users/shuse2/events{/privacy}","received_events_url":"https://api.github.com/users/shuse2/received_events","type":"User","site_admin":false},"body":"### What was the problem?\r\nIn Lisk core, we have `/signature` endpoint, but there was no direct way to sign a transaction.\r\n\r\n### How did I fix it?\r\nAdd a `signMultisignature` function.\r\n\r\n### How to test it?\r\n```\r\nelements.transaction.signMultisignature(transaction, passphrase)\r\n```\r\n### Review checklist\r\n\r\n* The PR solves #640 \r\n* All new code is covered with unit tests\r\n* All new code was formatted with Prettier\r\n* Linting passes\r\n* Tests pass\r\n* Commit messages follow the\r\n\t[commit guidelines](CONTRIBUTING.md#git-commit-messages)\r\n* Documentation has been added/updated\r\n","created_at":"2018-04-11T16:53:46Z","updated_at":"2018-04-16T14:26:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6cee5e736363676d3236e0bdaf69bbdd2707a46e","assignee":{"login":"shuse2","id":2367565,"avatar_url":"https://avatars0.githubusercontent.com/u/2367565?v=4","gravatar_id":"","url":"https://api.github.com/users/shuse2","html_url":"https://github.com/shuse2","followers_url":"https://api.github.com/users/shuse2/followers","following_url":"https://api.github.com/users/shuse2/following{/other_user}","gists_url":"https://api.github.com/users/shuse2/gists{/gist_id}","starred_url":"https://api.github.com/users/shuse2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuse2/subscriptions","organizations_url":"https://api.github.com/users/shuse2/orgs","repos_url":"https://api.github.com/users/shuse2/repos","events_url":"https://api.github.com/users/shuse2/events{/privacy}","received_events_url":"https://api.github.com/users/shuse2/received_events","type":"User","site_admin":false},"assignees":[{"login":"shuse2","id":2367565,"avatar_url":"https://avatars0.githubusercontent.com/u/2367565?v=4","gravatar_id":"","url":"https://api.github.com/users/shuse2","html_url":"https://github.com/shuse2","followers_url":"https://api.github.com/users/shuse2/followers","following_url":"https://api.github.com/users/shuse2/following{/other_user}","gists_url":"https://api.github.com/users/shuse2/gists{/gist_id}","starred_url":"https://api.github.com/users/shuse2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuse2/subscriptions","organizations_url":"https://api.github.com/users/shuse2/orgs","repos_url":"https://api.github.com/users/shuse2/repos","events_url":"https://api.github.com/users/shuse2/events{/privacy}","received_events_url":"https://api.github.com/users/shuse2/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":655490233,"url":"https://api.github.com/repos/LiskHQ/lisk-js/labels/:eye:%20pending%20review","name":":eye: pending review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/LiskHQ/lisk-js/pulls/641/commits","review_comments_url":"https://api.github.com/repos/LiskHQ/lisk-js/pulls/641/comments","review_comment_url":"https://api.github.com/repos/LiskHQ/lisk-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LiskHQ/lisk-js/issues/641/comments","statuses_url":"https://api.github.com/repos/LiskHQ/lisk-js/statuses/08909d35a3327bca356d3a921e9f763f55fcd2d8","head":{"label":"LiskHQ:640-add_sign_multisig","ref":"640-add_sign_multisig","sha":"08909d35a3327bca356d3a921e9f763f55fcd2d8","user":{"login":"LiskHQ","id":16600915,"avatar_url":"https://avatars1.githubusercontent.com/u/16600915?v=4","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":49426311,"name":"lisk-js","full_name":"LiskHQ/lisk-js","owner":{"login":"LiskHQ","id":16600915,"avatar_url":"https://avatars1.githubusercontent.com/u/16600915?v=4","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LiskHQ/lisk-js","description":"⚙️ JavaScript library for sending Lisk transactions from the client or server","fork":false,"url":"https://api.github.com/repos/LiskHQ/lisk-js","forks_url":"https://api.github.com/repos/LiskHQ/lisk-js/forks","keys_url":"https://api.github.com/repos/LiskHQ/lisk-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LiskHQ/lisk-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LiskHQ/lisk-js/teams","hooks_url":"https://api.github.com/repos/LiskHQ/lisk-js/hooks","issue_events_url":"https://api.github.com/repos/LiskHQ/lisk-js/issues/events{/number}","events_url":"https://api.github.com/repos/LiskHQ/lisk-js/events","assignees_url":"https://api.github.com/repos/LiskHQ/lisk-js/assignees{/user}","branches_url":"https://api.github.com/repos/LiskHQ/lisk-js/branches{/branch}","tags_url":"https://api.github.com/repos/LiskHQ/lisk-js/tags","blobs_url":"https://api.github.com/repos/LiskHQ/lisk-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LiskHQ/lisk-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LiskHQ/lisk-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/LiskHQ/lisk-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LiskHQ/lisk-js/statuses/{sha}","languages_url":"https://api.github.com/repos/LiskHQ/lisk-js/languages","stargazers_url":"https://api.github.com/repos/LiskHQ/lisk-js/stargazers","contributors_url":"https://api.github.com/repos/LiskHQ/lisk-js/contributors","subscribers_url":"https://api.github.com/repos/LiskHQ/lisk-js/subscribers","subscription_url":"https://api.github.com/repos/LiskHQ/lisk-js/subscription","commits_url":"https://api.github.com/repos/LiskHQ/lisk-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/LiskHQ/lisk-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/LiskHQ/lisk-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/LiskHQ/lisk-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/LiskHQ/lisk-js/contents/{+path}","compare_url":"https://api.github.com/repos/LiskHQ/lisk-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LiskHQ/lisk-js/merges","archive_url":"https://api.github.com/repos/LiskHQ/lisk-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LiskHQ/lisk-js/downloads","issues_url":"https://api.github.com/repos/LiskHQ/lisk-js/issues{/number}","pulls_url":"https://api.github.com/repos/LiskHQ/lisk-js/pulls{/number}","milestones_url":"https://api.github.com/repos/LiskHQ/lisk-js/milestones{/number}","notifications_url":"https://api.github.com/repos/LiskHQ/lisk-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LiskHQ/lisk-js/labels{/name}","releases_url":"https://api.github.com/repos/LiskHQ/lisk-js/releases{/id}","deployments_url":"https://api.github.com/repos/LiskHQ/lisk-js/deployments","created_at":"2016-01-11T12:54:02Z","updated_at":"2018-04-11T17:33:28Z","pushed_at":"2018-04-11T16:53:47Z","git_url":"git://github.com/LiskHQ/lisk-js.git","ssh_url":"git@github.com:LiskHQ/lisk-js.git","clone_url":"https://github.com/LiskHQ/lisk-js.git","svn_url":"https://github.com/LiskHQ/lisk-js","homepage":"https://lisk.io/","size":9913,"stargazers_count":220,"watchers_count":220,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":65,"open_issues":17,"watchers":220,"default_branch":"development"}},"base":{"label":"LiskHQ:1.0.0","ref":"1.0.0","sha":"4656dc80ecf6af7197f340978155ff5113ac3ba8","user":{"login":"LiskHQ","id":16600915,"avatar_url":"https://avatars1.githubusercontent.com/u/16600915?v=4","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":49426311,"name":"lisk-js","full_name":"LiskHQ/lisk-js","owner":{"login":"LiskHQ","id":16600915,"avatar_url":"https://avatars1.githubusercontent.com/u/16600915?v=4","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LiskHQ/lisk-js","description":"⚙️ JavaScript library for sending Lisk transactions from the client or server","fork":false,"url":"https://api.github.com/repos/LiskHQ/lisk-js","forks_url":"https://api.github.com/repos/LiskHQ/lisk-js/forks","keys_url":"https://api.github.com/repos/LiskHQ/lisk-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LiskHQ/lisk-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LiskHQ/lisk-js/teams","hooks_url":"https://api.github.com/repos/LiskHQ/lisk-js/hooks","issue_events_url":"https://api.github.com/repos/LiskHQ/lisk-js/issues/events{/number}","events_url":"https://api.github.com/repos/LiskHQ/lisk-js/events","assignees_url":"https://api.github.com/repos/LiskHQ/lisk-js/assignees{/user}","branches_url":"https://api.github.com/repos/LiskHQ/lisk-js/branches{/branch}","tags_url":"https://api.github.com/repos/LiskHQ/lisk-js/tags","blobs_url":"https://api.github.com/repos/LiskHQ/lisk-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LiskHQ/lisk-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LiskHQ/lisk-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/LiskHQ/lisk-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LiskHQ/lisk-js/statuses/{sha}","languages_url":"https://api.github.com/repos/LiskHQ/lisk-js/languages","stargazers_url":"https://api.github.com/repos/LiskHQ/lisk-js/stargazers","contributors_url":"https://api.github.com/repos/LiskHQ/lisk-js/contributors","subscribers_url":"https://api.github.com/repos/LiskHQ/lisk-js/subscribers","subscription_url":"https://api.github.com/repos/LiskHQ/lisk-js/subscription","commits_url":"https://api.github.com/repos/LiskHQ/lisk-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/LiskHQ/lisk-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/LiskHQ/lisk-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/LiskHQ/lisk-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/LiskHQ/lisk-js/contents/{+path}","compare_url":"https://api.github.com/repos/LiskHQ/lisk-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LiskHQ/lisk-js/merges","archive_url":"https://api.github.com/repos/LiskHQ/lisk-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LiskHQ/lisk-js/downloads","issues_url":"https://api.github.com/repos/LiskHQ/lisk-js/issues{/number}","pulls_url":"https://api.github.com/repos/LiskHQ/lisk-js/pulls{/number}","milestones_url":"https://api.github.com/repos/LiskHQ/lisk-js/milestones{/number}","notifications_url":"https://api.github.com/repos/LiskHQ/lisk-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LiskHQ/lisk-js/labels{/name}","releases_url":"https://api.github.com/repos/LiskHQ/lisk-js/releases{/id}","deployments_url":"https://api.github.com/repos/LiskHQ/lisk-js/deployments","created_at":"2016-01-11T12:54:02Z","updated_at":"2018-04-11T17:33:28Z","pushed_at":"2018-04-11T16:53:47Z","git_url":"git://github.com/LiskHQ/lisk-js.git","ssh_url":"git@github.com:LiskHQ/lisk-js.git","clone_url":"https://github.com/LiskHQ/lisk-js.git","svn_url":"https://github.com/LiskHQ/lisk-js","homepage":"https://lisk.io/","size":9913,"stargazers_count":220,"watchers_count":220,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":65,"open_issues":17,"watchers":220,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/LiskHQ/lisk-js/pulls/641"},"html":{"href":"https://github.com/LiskHQ/lisk-js/pull/641"},"issue":{"href":"https://api.github.com/repos/LiskHQ/lisk-js/issues/641"},"comments":{"href":"https://api.github.com/repos/LiskHQ/lisk-js/issues/641/comments"},"review_comments":{"href":"https://api.github.com/repos/LiskHQ/lisk-js/pulls/641/comments"},"review_comment":{"href":"https://api.github.com/repos/LiskHQ/lisk-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LiskHQ/lisk-js/pulls/641/commits"},"statuses":{"href":"https://api.github.com/repos/LiskHQ/lisk-js/statuses/08909d35a3327bca356d3a921e9f763f55fcd2d8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"willclarktech"}}