{"action":"created","comment":{"url":"https://api.github.com/repos/istio/proxy/pulls/comments/210981416","pull_request_review_id":147316995,"id":210981416,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDk4MTQxNg==","diff_hunk":"@@ -25,51 +26,21 @@ namespace {\n // The JWT audience key name\n static const std::string kJwtAudienceKey = \"aud\";\n \n-// The JWT groups key name\n-static const std::string kJwtGroupsKey = \"groups\";\n-\n-// Extract JWT audience into the JwtPayload.\n-// This function should to be called after the claims are extracted.\n-void ExtractJwtAudience(\n-    const Envoy::Json::Object& obj,\n-    const ::google::protobuf::Map< ::std::string, ::std::string>& claims,\n-    istio::authn::JwtPayload* payload) {\n-  const std::string& key = kJwtAudienceKey;\n-  // \"aud\" can be either string array or string.\n+// Extract JWT claim as a string list\n+void ExtractStringList(const std::string& key, const Envoy::Json::Object& obj,\n+                       std::vector<std::string>& list) {","path":"src/envoy/http/authn/authn_utils.cc","position":null,"original_position":25,"commit_id":"5b5ad27eb1c6dac559aef27c4719d091a61c9692","original_commit_id":"9f34dcdcfd06068d5bde086276135e16c632a5f6","user":{"login":"lei-tang","id":32078630,"node_id":"MDQ6VXNlcjMyMDc4NjMw","avatar_url":"https://avatars1.githubusercontent.com/u/32078630?v=4","gravatar_id":"","url":"https://api.github.com/users/lei-tang","html_url":"https://github.com/lei-tang","followers_url":"https://api.github.com/users/lei-tang/followers","following_url":"https://api.github.com/users/lei-tang/following{/other_user}","gists_url":"https://api.github.com/users/lei-tang/gists{/gist_id}","starred_url":"https://api.github.com/users/lei-tang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lei-tang/subscriptions","organizations_url":"https://api.github.com/users/lei-tang/orgs","repos_url":"https://api.github.com/users/lei-tang/repos","events_url":"https://api.github.com/users/lei-tang/events{/privacy}","received_events_url":"https://api.github.com/users/lei-tang/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2018-08-17T17:36:04Z","updated_at":"2018-08-17T17:36:04Z","html_url":"https://github.com/istio/proxy/pull/1925#discussion_r210981416","pull_request_url":"https://api.github.com/repos/istio/proxy/pulls/1925","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/istio/proxy/pulls/comments/210981416"},"html":{"href":"https://github.com/istio/proxy/pull/1925#discussion_r210981416"},"pull_request":{"href":"https://api.github.com/repos/istio/proxy/pulls/1925"}},"in_reply_to_id":210860784},"pull_request":{"url":"https://api.github.com/repos/istio/proxy/pulls/1925","id":209053598,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MDUzNTk4","html_url":"https://github.com/istio/proxy/pull/1925","diff_url":"https://github.com/istio/proxy/pull/1925.diff","patch_url":"https://github.com/istio/proxy/pull/1925.patch","issue_url":"https://api.github.com/repos/istio/proxy/issues/1925","number":1925,"state":"open","locked":false,"title":"Authn uses protobuf.Struct to store claims and add list support for RBAC","user":{"login":"lei-tang","id":32078630,"node_id":"MDQ6VXNlcjMyMDc4NjMw","avatar_url":"https://avatars1.githubusercontent.com/u/32078630?v=4","gravatar_id":"","url":"https://api.github.com/users/lei-tang","html_url":"https://github.com/lei-tang","followers_url":"https://api.github.com/users/lei-tang/followers","following_url":"https://api.github.com/users/lei-tang/following{/other_user}","gists_url":"https://api.github.com/users/lei-tang/gists{/gist_id}","starred_url":"https://api.github.com/users/lei-tang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lei-tang/subscriptions","organizations_url":"https://api.github.com/users/lei-tang/orgs","repos_url":"https://api.github.com/users/lei-tang/repos","events_url":"https://api.github.com/users/lei-tang/events{/privacy}","received_events_url":"https://api.github.com/users/lei-tang/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\n1. Change authn to use protobuf.Struct to store claims\r\n2. Add list support for RBAC\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #1920 \r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\n```\r\n","created_at":"2018-08-17T06:07:58Z","updated_at":"2018-08-17T17:36:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"581eb96dc08b041930844aefdbda2d6b0d3be7be","assignee":null,"assignees":[],"requested_reviewers":[{"login":"yangminzhu","id":2189160,"node_id":"MDQ6VXNlcjIxODkxNjA=","avatar_url":"https://avatars2.githubusercontent.com/u/2189160?v=4","gravatar_id":"","url":"https://api.github.com/users/yangminzhu","html_url":"https://github.com/yangminzhu","followers_url":"https://api.github.com/users/yangminzhu/followers","following_url":"https://api.github.com/users/yangminzhu/following{/other_user}","gists_url":"https://api.github.com/users/yangminzhu/gists{/gist_id}","starred_url":"https://api.github.com/users/yangminzhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yangminzhu/subscriptions","organizations_url":"https://api.github.com/users/yangminzhu/orgs","repos_url":"https://api.github.com/users/yangminzhu/repos","events_url":"https://api.github.com/users/yangminzhu/events{/privacy}","received_events_url":"https://api.github.com/users/yangminzhu/received_events","type":"User","site_admin":false},{"login":"sebastienvas","id":17773671,"node_id":"MDQ6VXNlcjE3NzczNjcx","avatar_url":"https://avatars1.githubusercontent.com/u/17773671?v=4","gravatar_id":"","url":"https://api.github.com/users/sebastienvas","html_url":"https://github.com/sebastienvas","followers_url":"https://api.github.com/users/sebastienvas/followers","following_url":"https://api.github.com/users/sebastienvas/following{/other_user}","gists_url":"https://api.github.com/users/sebastienvas/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastienvas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastienvas/subscriptions","organizations_url":"https://api.github.com/users/sebastienvas/orgs","repos_url":"https://api.github.com/users/sebastienvas/repos","events_url":"https://api.github.com/users/sebastienvas/events{/privacy}","received_events_url":"https://api.github.com/users/sebastienvas/received_events","type":"User","site_admin":false},{"login":"liminw","id":20001914,"node_id":"MDQ6VXNlcjIwMDAxOTE0","avatar_url":"https://avatars3.githubusercontent.com/u/20001914?v=4","gravatar_id":"","url":"https://api.github.com/users/liminw","html_url":"https://github.com/liminw","followers_url":"https://api.github.com/users/liminw/followers","following_url":"https://api.github.com/users/liminw/following{/other_user}","gists_url":"https://api.github.com/users/liminw/gists{/gist_id}","starred_url":"https://api.github.com/users/liminw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liminw/subscriptions","organizations_url":"https://api.github.com/users/liminw/orgs","repos_url":"https://api.github.com/users/liminw/repos","events_url":"https://api.github.com/users/liminw/events{/privacy}","received_events_url":"https://api.github.com/users/liminw/received_events","type":"User","site_admin":false},{"login":"JimmyCYJ","id":28548492,"node_id":"MDQ6VXNlcjI4NTQ4NDky","avatar_url":"https://avatars0.githubusercontent.com/u/28548492?v=4","gravatar_id":"","url":"https://api.github.com/users/JimmyCYJ","html_url":"https://github.com/JimmyCYJ","followers_url":"https://api.github.com/users/JimmyCYJ/followers","following_url":"https://api.github.com/users/JimmyCYJ/following{/other_user}","gists_url":"https://api.github.com/users/JimmyCYJ/gists{/gist_id}","starred_url":"https://api.github.com/users/JimmyCYJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JimmyCYJ/subscriptions","organizations_url":"https://api.github.com/users/JimmyCYJ/orgs","repos_url":"https://api.github.com/users/JimmyCYJ/repos","events_url":"https://api.github.com/users/JimmyCYJ/events{/privacy}","received_events_url":"https://api.github.com/users/JimmyCYJ/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":712050392,"node_id":"MDU6TGFiZWw3MTIwNTAzOTI=","url":"https://api.github.com/repos/istio/proxy/labels/cla:%20yes","name":"cla: yes","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/proxy/pulls/1925/commits","review_comments_url":"https://api.github.com/repos/istio/proxy/pulls/1925/comments","review_comment_url":"https://api.github.com/repos/istio/proxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/proxy/issues/1925/comments","statuses_url":"https://api.github.com/repos/istio/proxy/statuses/5b5ad27eb1c6dac559aef27c4719d091a61c9692","head":{"label":"lei-tang:refactor_authn_filter","ref":"refactor_authn_filter","sha":"5b5ad27eb1c6dac559aef27c4719d091a61c9692","user":{"login":"lei-tang","id":32078630,"node_id":"MDQ6VXNlcjMyMDc4NjMw","avatar_url":"https://avatars1.githubusercontent.com/u/32078630?v=4","gravatar_id":"","url":"https://api.github.com/users/lei-tang","html_url":"https://github.com/lei-tang","followers_url":"https://api.github.com/users/lei-tang/followers","following_url":"https://api.github.com/users/lei-tang/following{/other_user}","gists_url":"https://api.github.com/users/lei-tang/gists{/gist_id}","starred_url":"https://api.github.com/users/lei-tang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lei-tang/subscriptions","organizations_url":"https://api.github.com/users/lei-tang/orgs","repos_url":"https://api.github.com/users/lei-tang/repos","events_url":"https://api.github.com/users/lei-tang/events{/privacy}","received_events_url":"https://api.github.com/users/lei-tang/received_events","type":"User","site_admin":false},"repo":{"id":117921130,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc5MjExMzA=","name":"proxy","full_name":"lei-tang/proxy","owner":{"login":"lei-tang","id":32078630,"node_id":"MDQ6VXNlcjMyMDc4NjMw","avatar_url":"https://avatars1.githubusercontent.com/u/32078630?v=4","gravatar_id":"","url":"https://api.github.com/users/lei-tang","html_url":"https://github.com/lei-tang","followers_url":"https://api.github.com/users/lei-tang/followers","following_url":"https://api.github.com/users/lei-tang/following{/other_user}","gists_url":"https://api.github.com/users/lei-tang/gists{/gist_id}","starred_url":"https://api.github.com/users/lei-tang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lei-tang/subscriptions","organizations_url":"https://api.github.com/users/lei-tang/orgs","repos_url":"https://api.github.com/users/lei-tang/repos","events_url":"https://api.github.com/users/lei-tang/events{/privacy}","received_events_url":"https://api.github.com/users/lei-tang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lei-tang/proxy","description":"The Istio proxy components.","fork":true,"url":"https://api.github.com/repos/lei-tang/proxy","forks_url":"https://api.github.com/repos/lei-tang/proxy/forks","keys_url":"https://api.github.com/repos/lei-tang/proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lei-tang/proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lei-tang/proxy/teams","hooks_url":"https://api.github.com/repos/lei-tang/proxy/hooks","issue_events_url":"https://api.github.com/repos/lei-tang/proxy/issues/events{/number}","events_url":"https://api.github.com/repos/lei-tang/proxy/events","assignees_url":"https://api.github.com/repos/lei-tang/proxy/assignees{/user}","branches_url":"https://api.github.com/repos/lei-tang/proxy/branches{/branch}","tags_url":"https://api.github.com/repos/lei-tang/proxy/tags","blobs_url":"https://api.github.com/repos/lei-tang/proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lei-tang/proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lei-tang/proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/lei-tang/proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lei-tang/proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/lei-tang/proxy/languages","stargazers_url":"https://api.github.com/repos/lei-tang/proxy/stargazers","contributors_url":"https://api.github.com/repos/lei-tang/proxy/contributors","subscribers_url":"https://api.github.com/repos/lei-tang/proxy/subscribers","subscription_url":"https://api.github.com/repos/lei-tang/proxy/subscription","commits_url":"https://api.github.com/repos/lei-tang/proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/lei-tang/proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/lei-tang/proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/lei-tang/proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/lei-tang/proxy/contents/{+path}","compare_url":"https://api.github.com/repos/lei-tang/proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lei-tang/proxy/merges","archive_url":"https://api.github.com/repos/lei-tang/proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lei-tang/proxy/downloads","issues_url":"https://api.github.com/repos/lei-tang/proxy/issues{/number}","pulls_url":"https://api.github.com/repos/lei-tang/proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/lei-tang/proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/lei-tang/proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lei-tang/proxy/labels{/name}","releases_url":"https://api.github.com/repos/lei-tang/proxy/releases{/id}","deployments_url":"https://api.github.com/repos/lei-tang/proxy/deployments","created_at":"2018-01-18T02:33:39Z","updated_at":"2018-04-03T22:29:55Z","pushed_at":"2018-08-17T17:35:48Z","git_url":"git://github.com/lei-tang/proxy.git","ssh_url":"git@github.com:lei-tang/proxy.git","clone_url":"https://github.com/lei-tang/proxy.git","svn_url":"https://github.com/lei-tang/proxy","homepage":"","size":2898,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"1fc6253f572fbef1ba1fd304fd81c79539824eb1","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":75322405,"node_id":"MDEwOlJlcG9zaXRvcnk3NTMyMjQwNQ==","name":"proxy","full_name":"istio/proxy","owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/proxy","description":"The Istio proxy components.","fork":false,"url":"https://api.github.com/repos/istio/proxy","forks_url":"https://api.github.com/repos/istio/proxy/forks","keys_url":"https://api.github.com/repos/istio/proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/proxy/teams","hooks_url":"https://api.github.com/repos/istio/proxy/hooks","issue_events_url":"https://api.github.com/repos/istio/proxy/issues/events{/number}","events_url":"https://api.github.com/repos/istio/proxy/events","assignees_url":"https://api.github.com/repos/istio/proxy/assignees{/user}","branches_url":"https://api.github.com/repos/istio/proxy/branches{/branch}","tags_url":"https://api.github.com/repos/istio/proxy/tags","blobs_url":"https://api.github.com/repos/istio/proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/proxy/languages","stargazers_url":"https://api.github.com/repos/istio/proxy/stargazers","contributors_url":"https://api.github.com/repos/istio/proxy/contributors","subscribers_url":"https://api.github.com/repos/istio/proxy/subscribers","subscription_url":"https://api.github.com/repos/istio/proxy/subscription","commits_url":"https://api.github.com/repos/istio/proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/proxy/contents/{+path}","compare_url":"https://api.github.com/repos/istio/proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/proxy/merges","archive_url":"https://api.github.com/repos/istio/proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/proxy/downloads","issues_url":"https://api.github.com/repos/istio/proxy/issues{/number}","pulls_url":"https://api.github.com/repos/istio/proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/proxy/labels{/name}","releases_url":"https://api.github.com/repos/istio/proxy/releases{/id}","deployments_url":"https://api.github.com/repos/istio/proxy/deployments","created_at":"2016-12-01T18:51:04Z","updated_at":"2018-08-15T20:41:24Z","pushed_at":"2018-08-17T17:35:49Z","git_url":"git://github.com/istio/proxy.git","ssh_url":"git@github.com:istio/proxy.git","clone_url":"https://github.com/istio/proxy.git","svn_url":"https://github.com/istio/proxy","homepage":"","size":2730,"stargazers_count":153,"watchers_count":153,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":114,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":114,"open_issues":45,"watchers":153,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/proxy/pulls/1925"},"html":{"href":"https://github.com/istio/proxy/pull/1925"},"issue":{"href":"https://api.github.com/repos/istio/proxy/issues/1925"},"comments":{"href":"https://api.github.com/repos/istio/proxy/issues/1925/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/proxy/pulls/1925/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/proxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/proxy/pulls/1925/commits"},"statuses":{"href":"https://api.github.com/repos/istio/proxy/statuses/5b5ad27eb1c6dac559aef27c4719d091a61c9692"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lei-tang"}}