{"action":"created","issue":{"url":"https://api.github.com/repos/aspnet/Mvc/issues/7413","repository_url":"https://api.github.com/repos/aspnet/Mvc","labels_url":"https://api.github.com/repos/aspnet/Mvc/issues/7413/labels{/name}","comments_url":"https://api.github.com/repos/aspnet/Mvc/issues/7413/comments","events_url":"https://api.github.com/repos/aspnet/Mvc/issues/7413/events","html_url":"https://github.com/aspnet/Mvc/issues/7413","id":300736831,"number":7413,"title":"Route Parameter ModelBind behaviour change in 2.1","user":{"login":"stevejgordon","id":3669103,"avatar_url":"https://avatars0.githubusercontent.com/u/3669103?v=4","gravatar_id":"","url":"https://api.github.com/users/stevejgordon","html_url":"https://github.com/stevejgordon","followers_url":"https://api.github.com/users/stevejgordon/followers","following_url":"https://api.github.com/users/stevejgordon/following{/other_user}","gists_url":"https://api.github.com/users/stevejgordon/gists{/gist_id}","starred_url":"https://api.github.com/users/stevejgordon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevejgordon/subscriptions","organizations_url":"https://api.github.com/users/stevejgordon/orgs","repos_url":"https://api.github.com/users/stevejgordon/repos","events_url":"https://api.github.com/users/stevejgordon/events{/privacy}","received_events_url":"https://api.github.com/users/stevejgordon/received_events","type":"User","site_admin":false},"labels":[{"id":93054383,"url":"https://api.github.com/repos/aspnet/Mvc/labels/2%20-%20Working","name":"2 - Working","color":"CCCCCC","default":false},{"id":853213888,"url":"https://api.github.com/repos/aspnet/Mvc/labels/Mapped%20to%20BigRock","name":"Mapped to BigRock","color":"000000","default":false},{"id":70264660,"url":"https://api.github.com/repos/aspnet/Mvc/labels/bug","name":"bug","color":"fc2929","default":true},{"id":852078611,"url":"https://api.github.com/repos/aspnet/Mvc/labels/cost:%20M","name":"cost: M","color":"ffcccc","default":false},{"id":96169357,"url":"https://api.github.com/repos/aspnet/Mvc/labels/needs%20design","name":"needs design","color":"006b75","default":false}],"state":"closed","locked":false,"assignee":{"login":"dougbu","id":6431421,"avatar_url":"https://avatars1.githubusercontent.com/u/6431421?v=4","gravatar_id":"","url":"https://api.github.com/users/dougbu","html_url":"https://github.com/dougbu","followers_url":"https://api.github.com/users/dougbu/followers","following_url":"https://api.github.com/users/dougbu/following{/other_user}","gists_url":"https://api.github.com/users/dougbu/gists{/gist_id}","starred_url":"https://api.github.com/users/dougbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dougbu/subscriptions","organizations_url":"https://api.github.com/users/dougbu/orgs","repos_url":"https://api.github.com/users/dougbu/repos","events_url":"https://api.github.com/users/dougbu/events{/privacy}","received_events_url":"https://api.github.com/users/dougbu/received_events","type":"User","site_admin":false},"assignees":[{"login":"dougbu","id":6431421,"avatar_url":"https://avatars1.githubusercontent.com/u/6431421?v=4","gravatar_id":"","url":"https://api.github.com/users/dougbu","html_url":"https://github.com/dougbu","followers_url":"https://api.github.com/users/dougbu/followers","following_url":"https://api.github.com/users/dougbu/following{/other_user}","gists_url":"https://api.github.com/users/dougbu/gists{/gist_id}","starred_url":"https://api.github.com/users/dougbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dougbu/subscriptions","organizations_url":"https://api.github.com/users/dougbu/orgs","repos_url":"https://api.github.com/users/dougbu/repos","events_url":"https://api.github.com/users/dougbu/events{/privacy}","received_events_url":"https://api.github.com/users/dougbu/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/aspnet/Mvc/milestones/41","html_url":"https://github.com/aspnet/Mvc/milestone/41","labels_url":"https://api.github.com/repos/aspnet/Mvc/milestones/41/labels","id":2944400,"number":41,"title":"2.1.0-preview2","description":null,"creator":{"login":"Eilon","id":202643,"avatar_url":"https://avatars3.githubusercontent.com/u/202643?v=4","gravatar_id":"","url":"https://api.github.com/users/Eilon","html_url":"https://github.com/Eilon","followers_url":"https://api.github.com/users/Eilon/followers","following_url":"https://api.github.com/users/Eilon/following{/other_user}","gists_url":"https://api.github.com/users/Eilon/gists{/gist_id}","starred_url":"https://api.github.com/users/Eilon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eilon/subscriptions","organizations_url":"https://api.github.com/users/Eilon/orgs","repos_url":"https://api.github.com/users/Eilon/repos","events_url":"https://api.github.com/users/Eilon/events{/privacy}","received_events_url":"https://api.github.com/users/Eilon/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":48,"state":"open","created_at":"2017-11-28T17:48:47Z","updated_at":"2018-03-29T15:27:00Z","due_on":null,"closed_at":null},"comments":8,"created_at":"2018-02-27T18:10:19Z","updated_at":"2018-03-29T15:27:00Z","closed_at":"2018-03-29T15:27:00Z","author_association":"CONTRIBUTOR","body":"I've attempted an upgrade of an ASP.NET Core 2.0 project to 2.1 using the preview1 packages now available on nuget.\r\n \r\nWe have a custom IModelBinderProvider in the app and I noticed an exception being thrown since the upgrade. I noticed this on a GET action which accepts a route parameter.\r\n\r\nIn 2.0 the route parameter is ignored by our IModelBinderProvider as the Metadata.PropertyName is null.\r\n \r\nIn 2.1 a PropertyName is now set for the incoming route paramter but the ContainerType is null. \r\n \r\nAt the moment this blows up in our code. Is this in intended behaviour change?\r\n \r\nI've thrown together a rough repro at https://github.com/stevejgordon/ModelBindRepro\r\n \r\nBasically, start the 2.0 app and hit /Home/1 - This works fine. If you debug line 15 of the AdjustToTimezoneModelBinderProvider you'll see that PropertyName is null.\r\n \r\nStart the 2.1 app and hit /Home/1 - An exception occurs at line 24 of AdjustToTimezoneModelBinderProvider because ContainerType is null. PropertyName is set to \"statusCode\". Also note that if you hover over Metadata there is a debugger null ref exception too since ModelMetadata.DebuggerToString() also tries to access the ContainerType.\r\n \r\nI've not had time to go any deeper at this point.\r\n\r\n//cc @rynowak, @mkArtakMSFT and @DamianEdwards "},"comment":{"url":"https://api.github.com/repos/aspnet/Mvc/issues/comments/377272842","html_url":"https://github.com/aspnet/Mvc/issues/7413#issuecomment-377272842","issue_url":"https://api.github.com/repos/aspnet/Mvc/issues/7413","id":377272842,"user":{"login":"dougbu","id":6431421,"avatar_url":"https://avatars1.githubusercontent.com/u/6431421?v=4","gravatar_id":"","url":"https://api.github.com/users/dougbu","html_url":"https://github.com/dougbu","followers_url":"https://api.github.com/users/dougbu/followers","following_url":"https://api.github.com/users/dougbu/following{/other_user}","gists_url":"https://api.github.com/users/dougbu/gists{/gist_id}","starred_url":"https://api.github.com/users/dougbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dougbu/subscriptions","organizations_url":"https://api.github.com/users/dougbu/orgs","repos_url":"https://api.github.com/users/dougbu/repos","events_url":"https://api.github.com/users/dougbu/events{/privacy}","received_events_url":"https://api.github.com/users/dougbu/received_events","type":"User","site_admin":false},"created_at":"2018-03-29T15:27:00Z","updated_at":"2018-03-29T15:27:00Z","author_association":"MEMBER","body":"fc3a815e57 in `release/2.1`\r\n24eaa740f5 merge to `dev`\r\n"}}
{"actor":{"display_login":"dougbu"}}