{"action":"closed","number":15602,"pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/15602","id":237042550,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MDQyNTUw","html_url":"https://github.com/sympy/sympy/pull/15602","diff_url":"https://github.com/sympy/sympy/pull/15602.diff","patch_url":"https://github.com/sympy/sympy/pull/15602.patch","issue_url":"https://api.github.com/repos/sympy/sympy/issues/15602","number":15602,"state":"closed","locked":false,"title":"Adjust the logic of Abs->Piecewise rewrite in integrate","user":{"login":"normalhuman","id":13082030,"node_id":"MDQ6VXNlcjEzMDgyMDMw","avatar_url":"https://avatars1.githubusercontent.com/u/13082030?v=4","gravatar_id":"","url":"https://api.github.com/users/normalhuman","html_url":"https://github.com/normalhuman","followers_url":"https://api.github.com/users/normalhuman/followers","following_url":"https://api.github.com/users/normalhuman/following{/other_user}","gists_url":"https://api.github.com/users/normalhuman/gists{/gist_id}","starred_url":"https://api.github.com/users/normalhuman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normalhuman/subscriptions","organizations_url":"https://api.github.com/users/normalhuman/orgs","repos_url":"https://api.github.com/users/normalhuman/repos","events_url":"https://api.github.com/users/normalhuman/events{/privacy}","received_events_url":"https://api.github.com/users/normalhuman/received_events","type":"User","site_admin":false},"body":"#### References to other Issues or PRs\r\n\r\nFixes #15457 \r\n\r\n#### Brief description of what is fixed or changed\r\n\r\nAccording to a comment in integrals.py, \"some improper integrals are better off with Abs\", that is, with Meijer G method rather than Piecewise logic. This motivated the condition `all(x.is_real and x.is_finite for x in xab[1:])` for automatic Abs->Piecewise rewrite. But this condition leaves Abs in when `x.is_finite` is None, which offers no advantage because the integral is not actually known to be improper. Instead it should be `all(x.is_real and not(x.is_infinite) for x in xab[1:])`.\r\n\r\n#### Release Notes\r\n\r\n<!-- BEGIN RELEASE NOTES -->\r\n* integrals\r\n  * adjusted the logic of Abs->Piecewise rewrite for definite integrals\r\n<!-- END RELEASE NOTES -->\r\n","created_at":"2018-12-08T03:42:37Z","updated_at":"2018-12-08T17:35:57Z","closed_at":"2018-12-08T17:35:57Z","merged_at":"2018-12-08T17:35:57Z","merge_commit_sha":"fd926407af83f65e054a97d03e3366d8d4e6caa4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sympy/sympy/pulls/15602/commits","review_comments_url":"https://api.github.com/repos/sympy/sympy/pulls/15602/comments","review_comment_url":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/15602/comments","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/b56a3d64bfc08290886c00ed408ccdabcc26ffec","head":{"label":"normalhuman:15457_integral_abs","ref":"15457_integral_abs","sha":"b56a3d64bfc08290886c00ed408ccdabcc26ffec","user":{"login":"normalhuman","id":13082030,"node_id":"MDQ6VXNlcjEzMDgyMDMw","avatar_url":"https://avatars1.githubusercontent.com/u/13082030?v=4","gravatar_id":"","url":"https://api.github.com/users/normalhuman","html_url":"https://github.com/normalhuman","followers_url":"https://api.github.com/users/normalhuman/followers","following_url":"https://api.github.com/users/normalhuman/following{/other_user}","gists_url":"https://api.github.com/users/normalhuman/gists{/gist_id}","starred_url":"https://api.github.com/users/normalhuman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normalhuman/subscriptions","organizations_url":"https://api.github.com/users/normalhuman/orgs","repos_url":"https://api.github.com/users/normalhuman/repos","events_url":"https://api.github.com/users/normalhuman/events{/privacy}","received_events_url":"https://api.github.com/users/normalhuman/received_events","type":"User","site_admin":false},"repo":{"id":143551517,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM1NTE1MTc=","name":"sympy","full_name":"normalhuman/sympy","private":false,"owner":{"login":"normalhuman","id":13082030,"node_id":"MDQ6VXNlcjEzMDgyMDMw","avatar_url":"https://avatars1.githubusercontent.com/u/13082030?v=4","gravatar_id":"","url":"https://api.github.com/users/normalhuman","html_url":"https://github.com/normalhuman","followers_url":"https://api.github.com/users/normalhuman/followers","following_url":"https://api.github.com/users/normalhuman/following{/other_user}","gists_url":"https://api.github.com/users/normalhuman/gists{/gist_id}","starred_url":"https://api.github.com/users/normalhuman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normalhuman/subscriptions","organizations_url":"https://api.github.com/users/normalhuman/orgs","repos_url":"https://api.github.com/users/normalhuman/repos","events_url":"https://api.github.com/users/normalhuman/events{/privacy}","received_events_url":"https://api.github.com/users/normalhuman/received_events","type":"User","site_admin":false},"html_url":"https://github.com/normalhuman/sympy","description":"A computer algebra system written in pure Python","fork":true,"url":"https://api.github.com/repos/normalhuman/sympy","forks_url":"https://api.github.com/repos/normalhuman/sympy/forks","keys_url":"https://api.github.com/repos/normalhuman/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/normalhuman/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/normalhuman/sympy/teams","hooks_url":"https://api.github.com/repos/normalhuman/sympy/hooks","issue_events_url":"https://api.github.com/repos/normalhuman/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/normalhuman/sympy/events","assignees_url":"https://api.github.com/repos/normalhuman/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/normalhuman/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/normalhuman/sympy/tags","blobs_url":"https://api.github.com/repos/normalhuman/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/normalhuman/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/normalhuman/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/normalhuman/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/normalhuman/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/normalhuman/sympy/languages","stargazers_url":"https://api.github.com/repos/normalhuman/sympy/stargazers","contributors_url":"https://api.github.com/repos/normalhuman/sympy/contributors","subscribers_url":"https://api.github.com/repos/normalhuman/sympy/subscribers","subscription_url":"https://api.github.com/repos/normalhuman/sympy/subscription","commits_url":"https://api.github.com/repos/normalhuman/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/normalhuman/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/normalhuman/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/normalhuman/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/normalhuman/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/normalhuman/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/normalhuman/sympy/merges","archive_url":"https://api.github.com/repos/normalhuman/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/normalhuman/sympy/downloads","issues_url":"https://api.github.com/repos/normalhuman/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/normalhuman/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/normalhuman/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/normalhuman/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/normalhuman/sympy/labels{/name}","releases_url":"https://api.github.com/repos/normalhuman/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/normalhuman/sympy/deployments","created_at":"2018-08-04T18:07:26Z","updated_at":"2018-08-04T18:07:34Z","pushed_at":"2018-12-08T15:27:57Z","git_url":"git://github.com/normalhuman/sympy.git","ssh_url":"git@github.com:normalhuman/sympy.git","clone_url":"https://github.com/normalhuman/sympy.git","svn_url":"https://github.com/normalhuman/sympy","homepage":"http://sympy.org/","size":96694,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"5e17a90c19f7eecfa10c1ab872648ae7e2131323","user":{"login":"sympy","id":260832,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDgzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/260832?v=4","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":640534,"node_id":"MDEwOlJlcG9zaXRvcnk2NDA1MzQ=","name":"sympy","full_name":"sympy/sympy","private":false,"owner":{"login":"sympy","id":260832,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDgzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/260832?v=4","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sympy/sympy","description":"A computer algebra system written in pure Python","fork":false,"url":"https://api.github.com/repos/sympy/sympy","forks_url":"https://api.github.com/repos/sympy/sympy/forks","keys_url":"https://api.github.com/repos/sympy/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/sympy/teams","hooks_url":"https://api.github.com/repos/sympy/sympy/hooks","issue_events_url":"https://api.github.com/repos/sympy/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/sympy/events","assignees_url":"https://api.github.com/repos/sympy/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/sympy/tags","blobs_url":"https://api.github.com/repos/sympy/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/sympy/languages","stargazers_url":"https://api.github.com/repos/sympy/sympy/stargazers","contributors_url":"https://api.github.com/repos/sympy/sympy/contributors","subscribers_url":"https://api.github.com/repos/sympy/sympy/subscribers","subscription_url":"https://api.github.com/repos/sympy/sympy/subscription","commits_url":"https://api.github.com/repos/sympy/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sympy/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/sympy/merges","archive_url":"https://api.github.com/repos/sympy/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/sympy/downloads","issues_url":"https://api.github.com/repos/sympy/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/sympy/labels{/name}","releases_url":"https://api.github.com/repos/sympy/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/sympy/sympy/deployments","created_at":"2010-04-30T20:37:14Z","updated_at":"2018-12-08T12:25:29Z","pushed_at":"2018-12-08T17:35:57Z","git_url":"git://github.com/sympy/sympy.git","ssh_url":"git@github.com:sympy/sympy.git","clone_url":"https://github.com/sympy/sympy.git","svn_url":"https://github.com/sympy/sympy","homepage":"https://sympy.org/","size":96659,"stargazers_count":5371,"watchers_count":5371,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2428,"mirror_url":null,"archived":false,"open_issues_count":3485,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2428,"open_issues":3485,"watchers":5371,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/15602"},"html":{"href":"https://github.com/sympy/sympy/pull/15602"},"issue":{"href":"https://api.github.com/repos/sympy/sympy/issues/15602"},"comments":{"href":"https://api.github.com/repos/sympy/sympy/issues/15602/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/sympy/pulls/15602/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sympy/sympy/pulls/15602/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/sympy/statuses/b56a3d64bfc08290886c00ed408ccdabcc26ffec"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jksuom","id":6929119,"node_id":"MDQ6VXNlcjY5MjkxMTk=","avatar_url":"https://avatars3.githubusercontent.com/u/6929119?v=4","gravatar_id":"","url":"https://api.github.com/users/jksuom","html_url":"https://github.com/jksuom","followers_url":"https://api.github.com/users/jksuom/followers","following_url":"https://api.github.com/users/jksuom/following{/other_user}","gists_url":"https://api.github.com/users/jksuom/gists{/gist_id}","starred_url":"https://api.github.com/users/jksuom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jksuom/subscriptions","organizations_url":"https://api.github.com/users/jksuom/orgs","repos_url":"https://api.github.com/users/jksuom/repos","events_url":"https://api.github.com/users/jksuom/events{/privacy}","received_events_url":"https://api.github.com/users/jksuom/received_events","type":"User","site_admin":false},"comments":2,"review_comments":1,"maintainer_can_modify":false,"commits":2,"additions":11,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"jksuom"}}