{"action":"created","comment":{"url":"https://api.github.com/repos/SAP/ui5-builder/pulls/comments/240269272","pull_request_review_id":183259725,"id":240269272,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDI2OTI3Mg==","diff_hunk":"@@ -32,10 +32,10 @@ They are responsible for collecting resources which can be modified by a process\n Available tasks are listed [here](lib/tasks).\n \n ### Processors\n-Processors work with provided resources. They contain the actual build step logic to apply specific modifications to supplied resources or to make use of the resources' content to create new resources out of that.\n+Processors work with provided resources. They contain the actual build step logic to apply specific modifications to supplied resources, or to make use of the resources' content to create new resources out of that.\n \n Processors can be implemented generically. The string replacer is an example for that.\n-Since string replacement is a common build step, it can be useful in different contexts, e.g. code, version, date and copyright replacement. A concrete replacement operation could be achieved by passing a custom configuration to the processor. This way multiple tasks can make use of the same processor to achive their build step.\n+Since string replacement is a common build step, it can be useful in different contexts, e.g. code, version, date, and copyright replacement. A concrete replacement operation could be achieved by passing a custom configuration to the processor. By this, multiple tasks can make use of the same processor to achieve their build step.","path":"README.md","position":null,"original_position":18,"commit_id":"822416365dac53c4b7c7af5b49c6598f94f3e950","original_commit_id":"26d2e3096b918a8d1b5404657426a065ec507b4d","user":{"login":"RandomByte","id":1589939,"node_id":"MDQ6VXNlcjE1ODk5Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/1589939?v=4","gravatar_id":"","url":"https://api.github.com/users/RandomByte","html_url":"https://github.com/RandomByte","followers_url":"https://api.github.com/users/RandomByte/followers","following_url":"https://api.github.com/users/RandomByte/following{/other_user}","gists_url":"https://api.github.com/users/RandomByte/gists{/gist_id}","starred_url":"https://api.github.com/users/RandomByte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RandomByte/subscriptions","organizations_url":"https://api.github.com/users/RandomByte/orgs","repos_url":"https://api.github.com/users/RandomByte/repos","events_url":"https://api.github.com/users/RandomByte/events{/privacy}","received_events_url":"https://api.github.com/users/RandomByte/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-12-10T15:58:43Z","updated_at":"2018-12-10T15:58:43Z","html_url":"https://github.com/SAP/ui5-builder/pull/117#discussion_r240269272","pull_request_url":"https://api.github.com/repos/SAP/ui5-builder/pulls/117","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/SAP/ui5-builder/pulls/comments/240269272"},"html":{"href":"https://github.com/SAP/ui5-builder/pull/117#discussion_r240269272"},"pull_request":{"href":"https://api.github.com/repos/SAP/ui5-builder/pulls/117"}},"in_reply_to_id":240208717},"pull_request":{"url":"https://api.github.com/repos/SAP/ui5-builder/pulls/117","id":237318692,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MzE4Njky","html_url":"https://github.com/SAP/ui5-builder/pull/117","diff_url":"https://github.com/SAP/ui5-builder/pull/117.diff","patch_url":"https://github.com/SAP/ui5-builder/pull/117.patch","issue_url":"https://api.github.com/repos/SAP/ui5-builder/issues/117","number":117,"state":"open","locked":false,"title":"UA review readme.md","user":{"login":"SabineLoss","id":44154356,"node_id":"MDQ6VXNlcjQ0MTU0MzU2","avatar_url":"https://avatars0.githubusercontent.com/u/44154356?v=4","gravatar_id":"","url":"https://api.github.com/users/SabineLoss","html_url":"https://github.com/SabineLoss","followers_url":"https://api.github.com/users/SabineLoss/followers","following_url":"https://api.github.com/users/SabineLoss/following{/other_user}","gists_url":"https://api.github.com/users/SabineLoss/gists{/gist_id}","starred_url":"https://api.github.com/users/SabineLoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SabineLoss/subscriptions","organizations_url":"https://api.github.com/users/SabineLoss/orgs","repos_url":"https://api.github.com/users/SabineLoss/repos","events_url":"https://api.github.com/users/SabineLoss/events{/privacy}","received_events_url":"https://api.github.com/users/SabineLoss/received_events","type":"User","site_admin":false},"body":"**Thank you for your contribution!** 🙌\r\n\r\nTo get it merged faster, kindly review the checklist below:\r\n\r\n## Pull Request Checklist\r\n- [x] Reviewed the [Contributing Guidelines](https://github.com/SAP/ui5-tooling/blob/master/CONTRIBUTING.md#-contributing-code)\r\n    + Especially the [How to Contribute](https://github.com/SAP/ui5-tooling/blob/master/CONTRIBUTING.md#how-to-contribute) section \r\n- [ ] [No merge commits](https://github.com/SAP/ui5-tooling/blob/master/docs/Guidelines.md#no-merge-commits)\r\n- [ ] [Correct commit message style](https://github.com/SAP/ui5-tooling/blob/master/docs/Guidelines.md#commit-message-style)\r\n","created_at":"2018-12-10T13:24:29Z","updated_at":"2018-12-10T15:58:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2e2ebfaa55fd5681a3d0d3c4bf017db2cde95fc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":888451453,"node_id":"MDU6TGFiZWw4ODg0NTE0NTM=","url":"https://api.github.com/repos/SAP/ui5-builder/labels/documentation","name":"documentation","color":"bfd4f2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/SAP/ui5-builder/pulls/117/commits","review_comments_url":"https://api.github.com/repos/SAP/ui5-builder/pulls/117/comments","review_comment_url":"https://api.github.com/repos/SAP/ui5-builder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SAP/ui5-builder/issues/117/comments","statuses_url":"https://api.github.com/repos/SAP/ui5-builder/statuses/822416365dac53c4b7c7af5b49c6598f94f3e950","head":{"label":"SAP:UA-Review","ref":"UA-Review","sha":"822416365dac53c4b7c7af5b49c6598f94f3e950","user":{"login":"SAP","id":2531208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzEyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2531208?v=4","gravatar_id":"","url":"https://api.github.com/users/SAP","html_url":"https://github.com/SAP","followers_url":"https://api.github.com/users/SAP/followers","following_url":"https://api.github.com/users/SAP/following{/other_user}","gists_url":"https://api.github.com/users/SAP/gists{/gist_id}","starred_url":"https://api.github.com/users/SAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAP/subscriptions","organizations_url":"https://api.github.com/users/SAP/orgs","repos_url":"https://api.github.com/users/SAP/repos","events_url":"https://api.github.com/users/SAP/events{/privacy}","received_events_url":"https://api.github.com/users/SAP/received_events","type":"Organization","site_admin":false},"repo":{"id":126843838,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY4NDM4Mzg=","name":"ui5-builder","full_name":"SAP/ui5-builder","private":false,"owner":{"login":"SAP","id":2531208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzEyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2531208?v=4","gravatar_id":"","url":"https://api.github.com/users/SAP","html_url":"https://github.com/SAP","followers_url":"https://api.github.com/users/SAP/followers","following_url":"https://api.github.com/users/SAP/following{/other_user}","gists_url":"https://api.github.com/users/SAP/gists{/gist_id}","starred_url":"https://api.github.com/users/SAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAP/subscriptions","organizations_url":"https://api.github.com/users/SAP/orgs","repos_url":"https://api.github.com/users/SAP/repos","events_url":"https://api.github.com/users/SAP/events{/privacy}","received_events_url":"https://api.github.com/users/SAP/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SAP/ui5-builder","description":"UI5 Build and Development Tooling: Builder","fork":false,"url":"https://api.github.com/repos/SAP/ui5-builder","forks_url":"https://api.github.com/repos/SAP/ui5-builder/forks","keys_url":"https://api.github.com/repos/SAP/ui5-builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SAP/ui5-builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SAP/ui5-builder/teams","hooks_url":"https://api.github.com/repos/SAP/ui5-builder/hooks","issue_events_url":"https://api.github.com/repos/SAP/ui5-builder/issues/events{/number}","events_url":"https://api.github.com/repos/SAP/ui5-builder/events","assignees_url":"https://api.github.com/repos/SAP/ui5-builder/assignees{/user}","branches_url":"https://api.github.com/repos/SAP/ui5-builder/branches{/branch}","tags_url":"https://api.github.com/repos/SAP/ui5-builder/tags","blobs_url":"https://api.github.com/repos/SAP/ui5-builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SAP/ui5-builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SAP/ui5-builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/SAP/ui5-builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SAP/ui5-builder/statuses/{sha}","languages_url":"https://api.github.com/repos/SAP/ui5-builder/languages","stargazers_url":"https://api.github.com/repos/SAP/ui5-builder/stargazers","contributors_url":"https://api.github.com/repos/SAP/ui5-builder/contributors","subscribers_url":"https://api.github.com/repos/SAP/ui5-builder/subscribers","subscription_url":"https://api.github.com/repos/SAP/ui5-builder/subscription","commits_url":"https://api.github.com/repos/SAP/ui5-builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/SAP/ui5-builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/SAP/ui5-builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/SAP/ui5-builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/SAP/ui5-builder/contents/{+path}","compare_url":"https://api.github.com/repos/SAP/ui5-builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SAP/ui5-builder/merges","archive_url":"https://api.github.com/repos/SAP/ui5-builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SAP/ui5-builder/downloads","issues_url":"https://api.github.com/repos/SAP/ui5-builder/issues{/number}","pulls_url":"https://api.github.com/repos/SAP/ui5-builder/pulls{/number}","milestones_url":"https://api.github.com/repos/SAP/ui5-builder/milestones{/number}","notifications_url":"https://api.github.com/repos/SAP/ui5-builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SAP/ui5-builder/labels{/name}","releases_url":"https://api.github.com/repos/SAP/ui5-builder/releases{/id}","deployments_url":"https://api.github.com/repos/SAP/ui5-builder/deployments","created_at":"2018-03-26T14:45:39Z","updated_at":"2018-12-10T10:00:28Z","pushed_at":"2018-12-10T15:58:42Z","git_url":"git://github.com/SAP/ui5-builder.git","ssh_url":"git@github.com:SAP/ui5-builder.git","clone_url":"https://github.com/SAP/ui5-builder.git","svn_url":"https://github.com/SAP/ui5-builder","homepage":"","size":975,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":27,"watchers":16,"default_branch":"master"}},"base":{"label":"SAP:master","ref":"master","sha":"fc11cbe31a90c5f68b8088b0319fdaf26310173c","user":{"login":"SAP","id":2531208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzEyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2531208?v=4","gravatar_id":"","url":"https://api.github.com/users/SAP","html_url":"https://github.com/SAP","followers_url":"https://api.github.com/users/SAP/followers","following_url":"https://api.github.com/users/SAP/following{/other_user}","gists_url":"https://api.github.com/users/SAP/gists{/gist_id}","starred_url":"https://api.github.com/users/SAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAP/subscriptions","organizations_url":"https://api.github.com/users/SAP/orgs","repos_url":"https://api.github.com/users/SAP/repos","events_url":"https://api.github.com/users/SAP/events{/privacy}","received_events_url":"https://api.github.com/users/SAP/received_events","type":"Organization","site_admin":false},"repo":{"id":126843838,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY4NDM4Mzg=","name":"ui5-builder","full_name":"SAP/ui5-builder","private":false,"owner":{"login":"SAP","id":2531208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzEyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2531208?v=4","gravatar_id":"","url":"https://api.github.com/users/SAP","html_url":"https://github.com/SAP","followers_url":"https://api.github.com/users/SAP/followers","following_url":"https://api.github.com/users/SAP/following{/other_user}","gists_url":"https://api.github.com/users/SAP/gists{/gist_id}","starred_url":"https://api.github.com/users/SAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAP/subscriptions","organizations_url":"https://api.github.com/users/SAP/orgs","repos_url":"https://api.github.com/users/SAP/repos","events_url":"https://api.github.com/users/SAP/events{/privacy}","received_events_url":"https://api.github.com/users/SAP/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SAP/ui5-builder","description":"UI5 Build and Development Tooling: Builder","fork":false,"url":"https://api.github.com/repos/SAP/ui5-builder","forks_url":"https://api.github.com/repos/SAP/ui5-builder/forks","keys_url":"https://api.github.com/repos/SAP/ui5-builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SAP/ui5-builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SAP/ui5-builder/teams","hooks_url":"https://api.github.com/repos/SAP/ui5-builder/hooks","issue_events_url":"https://api.github.com/repos/SAP/ui5-builder/issues/events{/number}","events_url":"https://api.github.com/repos/SAP/ui5-builder/events","assignees_url":"https://api.github.com/repos/SAP/ui5-builder/assignees{/user}","branches_url":"https://api.github.com/repos/SAP/ui5-builder/branches{/branch}","tags_url":"https://api.github.com/repos/SAP/ui5-builder/tags","blobs_url":"https://api.github.com/repos/SAP/ui5-builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SAP/ui5-builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SAP/ui5-builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/SAP/ui5-builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SAP/ui5-builder/statuses/{sha}","languages_url":"https://api.github.com/repos/SAP/ui5-builder/languages","stargazers_url":"https://api.github.com/repos/SAP/ui5-builder/stargazers","contributors_url":"https://api.github.com/repos/SAP/ui5-builder/contributors","subscribers_url":"https://api.github.com/repos/SAP/ui5-builder/subscribers","subscription_url":"https://api.github.com/repos/SAP/ui5-builder/subscription","commits_url":"https://api.github.com/repos/SAP/ui5-builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/SAP/ui5-builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/SAP/ui5-builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/SAP/ui5-builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/SAP/ui5-builder/contents/{+path}","compare_url":"https://api.github.com/repos/SAP/ui5-builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SAP/ui5-builder/merges","archive_url":"https://api.github.com/repos/SAP/ui5-builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SAP/ui5-builder/downloads","issues_url":"https://api.github.com/repos/SAP/ui5-builder/issues{/number}","pulls_url":"https://api.github.com/repos/SAP/ui5-builder/pulls{/number}","milestones_url":"https://api.github.com/repos/SAP/ui5-builder/milestones{/number}","notifications_url":"https://api.github.com/repos/SAP/ui5-builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SAP/ui5-builder/labels{/name}","releases_url":"https://api.github.com/repos/SAP/ui5-builder/releases{/id}","deployments_url":"https://api.github.com/repos/SAP/ui5-builder/deployments","created_at":"2018-03-26T14:45:39Z","updated_at":"2018-12-10T10:00:28Z","pushed_at":"2018-12-10T15:58:42Z","git_url":"git://github.com/SAP/ui5-builder.git","ssh_url":"git@github.com:SAP/ui5-builder.git","clone_url":"https://github.com/SAP/ui5-builder.git","svn_url":"https://github.com/SAP/ui5-builder","homepage":"","size":975,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":27,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SAP/ui5-builder/pulls/117"},"html":{"href":"https://github.com/SAP/ui5-builder/pull/117"},"issue":{"href":"https://api.github.com/repos/SAP/ui5-builder/issues/117"},"comments":{"href":"https://api.github.com/repos/SAP/ui5-builder/issues/117/comments"},"review_comments":{"href":"https://api.github.com/repos/SAP/ui5-builder/pulls/117/comments"},"review_comment":{"href":"https://api.github.com/repos/SAP/ui5-builder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SAP/ui5-builder/pulls/117/commits"},"statuses":{"href":"https://api.github.com/repos/SAP/ui5-builder/statuses/822416365dac53c4b7c7af5b49c6598f94f3e950"}},"author_association":"NONE"}}
{"actor":{"display_login":"RandomByte"}}