{"action":"created","issue":{"url":"https://api.github.com/repos/compuphase/minIni/issues/9","repository_url":"https://api.github.com/repos/compuphase/minIni","labels_url":"https://api.github.com/repos/compuphase/minIni/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/compuphase/minIni/issues/9/comments","events_url":"https://api.github.com/repos/compuphase/minIni/issues/9/events","html_url":"https://github.com/compuphase/minIni/issues/9","id":329540577,"node_id":"MDU6SXNzdWUzMjk1NDA1Nzc=","number":9,"title":"Glue for SPIFFS","user":{"login":"timothyjohncarney","id":5595763,"node_id":"MDQ6VXNlcjU1OTU3NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/5595763?v=4","gravatar_id":"","url":"https://api.github.com/users/timothyjohncarney","html_url":"https://github.com/timothyjohncarney","followers_url":"https://api.github.com/users/timothyjohncarney/followers","following_url":"https://api.github.com/users/timothyjohncarney/following{/other_user}","gists_url":"https://api.github.com/users/timothyjohncarney/gists{/gist_id}","starred_url":"https://api.github.com/users/timothyjohncarney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothyjohncarney/subscriptions","organizations_url":"https://api.github.com/users/timothyjohncarney/orgs","repos_url":"https://api.github.com/users/timothyjohncarney/repos","events_url":"https://api.github.com/users/timothyjohncarney/events{/privacy}","received_events_url":"https://api.github.com/users/timothyjohncarney/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-05T16:49:38Z","updated_at":"2018-06-08T13:48:08Z","closed_at":null,"author_association":"NONE","body":"I have adapted this project for use with SPIFFS.\r\n\r\nhttps://github.com/pellepl/spiffs\r\n\r\nIn order to do so, I needed to make a few changes.\r\n\r\n1. Statically allocate the LocalBuffers to reduce call stack usage.\r\n2. Remove case-insensitive search as it is not C99 compatible.\r\n3. Add a wrapper function to SPIFFS file read API to behave like fgets.\r\n\r\nI am willing to share my changes, but I am unsure if these changes are of interest. I believe the first change will break the reentrancy. Some locking mechanism is necessary to guarantee reentrancy after moving the buffers off of the call stack. Furthermore, removing support for case-insensitive search seems like a step in the wrong direction.\r\n\r\nPlease advise and thank you for your work.\r\n\r\n-Tim\r\n"},"comment":{"url":"https://api.github.com/repos/compuphase/minIni/issues/comments/395766090","html_url":"https://github.com/compuphase/minIni/issues/9#issuecomment-395766090","issue_url":"https://api.github.com/repos/compuphase/minIni/issues/9","id":395766090,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTc2NjA5MA==","user":{"login":"timothyjohncarney","id":5595763,"node_id":"MDQ6VXNlcjU1OTU3NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/5595763?v=4","gravatar_id":"","url":"https://api.github.com/users/timothyjohncarney","html_url":"https://github.com/timothyjohncarney","followers_url":"https://api.github.com/users/timothyjohncarney/followers","following_url":"https://api.github.com/users/timothyjohncarney/following{/other_user}","gists_url":"https://api.github.com/users/timothyjohncarney/gists{/gist_id}","starred_url":"https://api.github.com/users/timothyjohncarney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothyjohncarney/subscriptions","organizations_url":"https://api.github.com/users/timothyjohncarney/orgs","repos_url":"https://api.github.com/users/timothyjohncarney/repos","events_url":"https://api.github.com/users/timothyjohncarney/events{/privacy}","received_events_url":"https://api.github.com/users/timothyjohncarney/received_events","type":"User","site_admin":false},"created_at":"2018-06-08T13:48:08Z","updated_at":"2018-06-08T13:48:08Z","author_association":"NONE","body":"Thiadmer,\r\n\r\nI am happy to push the changes I made to a feature branch and create a pull request. Would you please grant me push access to the repository so that I may contribute those files?\r\n\r\nThanks,\r\nTim"}}
{"actor":{"display_login":"timothyjohncarney"}}