{"action":"created","comment":{"url":"https://api.github.com/repos/lsst/geom/pulls/comments/199931168","pull_request_review_id":134146669,"id":199931168,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTkzMTE2OA==","diff_hunk":"@@ -107,6 +107,10 @@ AngleUnit constexpr degrees = AngleUnit(PI / 180.0);              ///< constant\n AngleUnit constexpr hours = AngleUnit(PI * 15.0 / 180.0);         ///< constant with units of hours\n AngleUnit constexpr arcminutes = AngleUnit(PI / 60 / 180.0);      ///< constant with units of arcminutes\n AngleUnit constexpr arcseconds = AngleUnit(PI / 180.0 / 3600.0);  ///< constant with units of arcseconds\n+// Note: if we use PI / 180.0 / 3.6e6 then 60*60*180*1000*lsst.geom.milliarcseconds\n+// does not test exactly equal to 180*lsst.geom.degrees","path":"include/lsst/geom/Angle.h","position":5,"original_position":5,"commit_id":"7577b63ccc2d10884dbf662032dac6641d089954","original_commit_id":"7577b63ccc2d10884dbf662032dac6641d089954","user":{"login":"r-owen","id":874176,"node_id":"MDQ6VXNlcjg3NDE3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/874176?v=4","gravatar_id":"","url":"https://api.github.com/users/r-owen","html_url":"https://github.com/r-owen","followers_url":"https://api.github.com/users/r-owen/followers","following_url":"https://api.github.com/users/r-owen/following{/other_user}","gists_url":"https://api.github.com/users/r-owen/gists{/gist_id}","starred_url":"https://api.github.com/users/r-owen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r-owen/subscriptions","organizations_url":"https://api.github.com/users/r-owen/orgs","repos_url":"https://api.github.com/users/r-owen/repos","events_url":"https://api.github.com/users/r-owen/events{/privacy}","received_events_url":"https://api.github.com/users/r-owen/received_events","type":"User","site_admin":false},"body":"I am sure it is a roundoff error, but I am not sure why. The test seems less than ideal; I would have expected `assertAnglesAlmostEqual` in order to handle tiny roundoff errors. But I went with what matches the existing code.","created_at":"2018-07-03T19:49:57Z","updated_at":"2018-07-03T19:49:57Z","html_url":"https://github.com/lsst/geom/pull/7#discussion_r199931168","pull_request_url":"https://api.github.com/repos/lsst/geom/pulls/7","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/lsst/geom/pulls/comments/199931168"},"html":{"href":"https://github.com/lsst/geom/pull/7#discussion_r199931168"},"pull_request":{"href":"https://api.github.com/repos/lsst/geom/pulls/7"}},"in_reply_to_id":199919761},"pull_request":{"url":"https://api.github.com/repos/lsst/geom/pulls/7","id":199019533,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MDE5NTMz","html_url":"https://github.com/lsst/geom/pull/7","diff_url":"https://github.com/lsst/geom/pull/7.diff","patch_url":"https://github.com/lsst/geom/pull/7.patch","issue_url":"https://api.github.com/repos/lsst/geom/issues/7","number":7,"state":"open","locked":false,"title":"DM-15005: Add a new AngleUnit: milliarcseconds","user":{"login":"r-owen","id":874176,"node_id":"MDQ6VXNlcjg3NDE3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/874176?v=4","gravatar_id":"","url":"https://api.github.com/users/r-owen","html_url":"https://github.com/r-owen","followers_url":"https://api.github.com/users/r-owen/followers","following_url":"https://api.github.com/users/r-owen/following{/other_user}","gists_url":"https://api.github.com/users/r-owen/gists{/gist_id}","starred_url":"https://api.github.com/users/r-owen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r-owen/subscriptions","organizations_url":"https://api.github.com/users/r-owen/orgs","repos_url":"https://api.github.com/users/r-owen/repos","events_url":"https://api.github.com/users/r-owen/events{/privacy}","received_events_url":"https://api.github.com/users/r-owen/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-03T16:29:10Z","updated_at":"2018-07-03T19:49:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7602c8dcf085839bb930ed79fa86384fc5bb278c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lsst/geom/pulls/7/commits","review_comments_url":"https://api.github.com/repos/lsst/geom/pulls/7/comments","review_comment_url":"https://api.github.com/repos/lsst/geom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lsst/geom/issues/7/comments","statuses_url":"https://api.github.com/repos/lsst/geom/statuses/7577b63ccc2d10884dbf662032dac6641d089954","head":{"label":"lsst:tickets/DM-15005","ref":"tickets/DM-15005","sha":"7577b63ccc2d10884dbf662032dac6641d089954","user":{"login":"lsst","id":1134504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQ1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":23013315,"node_id":"MDEwOlJlcG9zaXRvcnkyMzAxMzMxNQ==","name":"geom","full_name":"lsst/geom","owner":{"login":"lsst","id":1134504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQ1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/geom","description":"Pure-Python spherical geometry for LSST Data Management (will be superseded by sphgeom)","fork":false,"url":"https://api.github.com/repos/lsst/geom","forks_url":"https://api.github.com/repos/lsst/geom/forks","keys_url":"https://api.github.com/repos/lsst/geom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/geom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/geom/teams","hooks_url":"https://api.github.com/repos/lsst/geom/hooks","issue_events_url":"https://api.github.com/repos/lsst/geom/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/geom/events","assignees_url":"https://api.github.com/repos/lsst/geom/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/geom/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/geom/tags","blobs_url":"https://api.github.com/repos/lsst/geom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/geom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/geom/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/geom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/geom/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/geom/languages","stargazers_url":"https://api.github.com/repos/lsst/geom/stargazers","contributors_url":"https://api.github.com/repos/lsst/geom/contributors","subscribers_url":"https://api.github.com/repos/lsst/geom/subscribers","subscription_url":"https://api.github.com/repos/lsst/geom/subscription","commits_url":"https://api.github.com/repos/lsst/geom/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/geom/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/geom/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/geom/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/geom/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/geom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/geom/merges","archive_url":"https://api.github.com/repos/lsst/geom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/geom/downloads","issues_url":"https://api.github.com/repos/lsst/geom/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/geom/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/geom/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/geom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/geom/labels{/name}","releases_url":"https://api.github.com/repos/lsst/geom/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/geom/deployments","created_at":"2014-08-16T07:43:54Z","updated_at":"2018-06-29T14:29:18Z","pushed_at":"2018-07-03T16:29:11Z","git_url":"git://github.com/lsst/geom.git","ssh_url":"git@github.com:lsst/geom.git","clone_url":"https://github.com/lsst/geom.git","svn_url":"https://github.com/lsst/geom","homepage":"http://dm.lsst.org","size":252,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"lsst:master","ref":"master","sha":"e920381bdcdcb0fb6ebb162e6dae7530c082a6ab","user":{"login":"lsst","id":1134504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQ1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":23013315,"node_id":"MDEwOlJlcG9zaXRvcnkyMzAxMzMxNQ==","name":"geom","full_name":"lsst/geom","owner":{"login":"lsst","id":1134504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQ1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/geom","description":"Pure-Python spherical geometry for LSST Data Management (will be superseded by sphgeom)","fork":false,"url":"https://api.github.com/repos/lsst/geom","forks_url":"https://api.github.com/repos/lsst/geom/forks","keys_url":"https://api.github.com/repos/lsst/geom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/geom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/geom/teams","hooks_url":"https://api.github.com/repos/lsst/geom/hooks","issue_events_url":"https://api.github.com/repos/lsst/geom/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/geom/events","assignees_url":"https://api.github.com/repos/lsst/geom/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/geom/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/geom/tags","blobs_url":"https://api.github.com/repos/lsst/geom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/geom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/geom/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/geom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/geom/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/geom/languages","stargazers_url":"https://api.github.com/repos/lsst/geom/stargazers","contributors_url":"https://api.github.com/repos/lsst/geom/contributors","subscribers_url":"https://api.github.com/repos/lsst/geom/subscribers","subscription_url":"https://api.github.com/repos/lsst/geom/subscription","commits_url":"https://api.github.com/repos/lsst/geom/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/geom/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/geom/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/geom/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/geom/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/geom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/geom/merges","archive_url":"https://api.github.com/repos/lsst/geom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/geom/downloads","issues_url":"https://api.github.com/repos/lsst/geom/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/geom/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/geom/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/geom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/geom/labels{/name}","releases_url":"https://api.github.com/repos/lsst/geom/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/geom/deployments","created_at":"2014-08-16T07:43:54Z","updated_at":"2018-06-29T14:29:18Z","pushed_at":"2018-07-03T16:29:11Z","git_url":"git://github.com/lsst/geom.git","ssh_url":"git@github.com:lsst/geom.git","clone_url":"https://github.com/lsst/geom.git","svn_url":"https://github.com/lsst/geom","homepage":"http://dm.lsst.org","size":252,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lsst/geom/pulls/7"},"html":{"href":"https://github.com/lsst/geom/pull/7"},"issue":{"href":"https://api.github.com/repos/lsst/geom/issues/7"},"comments":{"href":"https://api.github.com/repos/lsst/geom/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/lsst/geom/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/lsst/geom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lsst/geom/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/lsst/geom/statuses/7577b63ccc2d10884dbf662032dac6641d089954"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"r-owen"}}