{"action":"opened","number":26677,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/26677","id":230606461,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNjA2NDYx","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/26677","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/26677.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/26677.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/26677","number":26677,"state":"open","locked":false,"title":"Add crafting searches for primary skill and result description","user":{"login":"jbytheway","id":52664,"node_id":"MDQ6VXNlcjUyNjY0","avatar_url":"https://avatars3.githubusercontent.com/u/52664?v=4","gravatar_id":"","url":"https://api.github.com/users/jbytheway","html_url":"https://github.com/jbytheway","followers_url":"https://api.github.com/users/jbytheway/followers","following_url":"https://api.github.com/users/jbytheway/following{/other_user}","gists_url":"https://api.github.com/users/jbytheway/gists{/gist_id}","starred_url":"https://api.github.com/users/jbytheway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbytheway/subscriptions","organizations_url":"https://api.github.com/users/jbytheway/orgs","repos_url":"https://api.github.com/users/jbytheway/repos","events_url":"https://api.github.com/users/jbytheway/events{/privacy}","received_events_url":"https://api.github.com/users/jbytheway/received_events","type":"User","site_admin":false},"body":"#### Summary\r\nSUMMARY: Interface \"Crafting searches for primary skill and result description\"\r\n\r\n#### Details\r\nAdding two new searches in the crafting menu:\r\n![cata-crafting-search-3](https://user-images.githubusercontent.com/52664/48289753-71191100-e468-11e8-9315-b33c92362450.png)\r\n* `p` for primary skill.  Often people search by skill to find something to craft to teach them that skill.  For that one really wants to search for primary skill, not any skill.\r\n* `d` for description.  This searches the full item description.  There are a bunch of different features items can have, and we probably don't want to make search options for all of them.  Luckily, they are usually mentioned in the description.  This can be used e.g. to find weapons with particular techniques, containers that are watertight, etc.  The disadvantage is that it's slow (takes about 3 seconds to do the search for me on a debug build) but I think it's better to have the option than not.\r\n\r\nHere is me searching for `d:reach attack`:\r\n![cata-crafting-search-4](https://user-images.githubusercontent.com/52664/48290046-6f9c1880-e469-11e8-9f7f-c4b945da1fc9.png)\r\n\r\n","created_at":"2018-11-13T20:00:53Z","updated_at":"2018-11-13T20:00:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/26677/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/26677/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/26677/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/75ec39c1d7cc598c9b044502ac22b8f9ee3c47fd","head":{"label":"jbytheway:new_crafting_searches","ref":"new_crafting_searches","sha":"75ec39c1d7cc598c9b044502ac22b8f9ee3c47fd","user":{"login":"jbytheway","id":52664,"node_id":"MDQ6VXNlcjUyNjY0","avatar_url":"https://avatars3.githubusercontent.com/u/52664?v=4","gravatar_id":"","url":"https://api.github.com/users/jbytheway","html_url":"https://github.com/jbytheway","followers_url":"https://api.github.com/users/jbytheway/followers","following_url":"https://api.github.com/users/jbytheway/following{/other_user}","gists_url":"https://api.github.com/users/jbytheway/gists{/gist_id}","starred_url":"https://api.github.com/users/jbytheway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbytheway/subscriptions","organizations_url":"https://api.github.com/users/jbytheway/orgs","repos_url":"https://api.github.com/users/jbytheway/repos","events_url":"https://api.github.com/users/jbytheway/events{/privacy}","received_events_url":"https://api.github.com/users/jbytheway/received_events","type":"User","site_admin":false},"repo":{"id":149894154,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk4OTQxNTQ=","name":"Cataclysm-DDA","full_name":"jbytheway/Cataclysm-DDA","private":false,"owner":{"login":"jbytheway","id":52664,"node_id":"MDQ6VXNlcjUyNjY0","avatar_url":"https://avatars3.githubusercontent.com/u/52664?v=4","gravatar_id":"","url":"https://api.github.com/users/jbytheway","html_url":"https://github.com/jbytheway","followers_url":"https://api.github.com/users/jbytheway/followers","following_url":"https://api.github.com/users/jbytheway/following{/other_user}","gists_url":"https://api.github.com/users/jbytheway/gists{/gist_id}","starred_url":"https://api.github.com/users/jbytheway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbytheway/subscriptions","organizations_url":"https://api.github.com/users/jbytheway/orgs","repos_url":"https://api.github.com/users/jbytheway/repos","events_url":"https://api.github.com/users/jbytheway/events{/privacy}","received_events_url":"https://api.github.com/users/jbytheway/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jbytheway/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.","fork":true,"url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA","forks_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/jbytheway/Cataclysm-DDA/deployments","created_at":"2018-09-22T16:19:34Z","updated_at":"2018-11-13T19:04:36Z","pushed_at":"2018-11-13T20:00:41Z","git_url":"git://github.com/jbytheway/Cataclysm-DDA.git","ssh_url":"git@github.com:jbytheway/Cataclysm-DDA.git","clone_url":"https://github.com/jbytheway/Cataclysm-DDA.git","svn_url":"https://github.com/jbytheway/Cataclysm-DDA","homepage":"http://cataclysmdda.org","size":1386209,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"d84de378abe2bfd5a9f49d3eceeffbd3a43ecf0c","user":{"login":"CleverRaven","id":4367009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNjcwMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/4367009?v=4","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"node_id":"MDEwOlJlcG9zaXRvcnk1OTczODU1","name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","private":false,"owner":{"login":"CleverRaven","id":4367009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNjcwMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/4367009?v=4","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/deployments","created_at":"2012-09-26T22:57:43Z","updated_at":"2018-11-13T15:46:05Z","pushed_at":"2018-11-13T19:41:10Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://cataclysmdda.org","size":1386925,"stargazers_count":2244,"watchers_count":2244,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1498,"mirror_url":null,"archived":false,"open_issues_count":1045,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1498,"open_issues":1045,"watchers":2244,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/26677"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/26677"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/26677"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/26677/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/26677/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/26677/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/75ec39c1d7cc598c9b044502ac22b8f9ee3c47fd"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":3,"additions":25,"deletions":2,"changed_files":3}}
{"actor":{"display_login":"jbytheway"}}