{"action":"created","issue":{"url":"https://api.github.com/repos/kvendrik/sketchlint/issues/1","repository_url":"https://api.github.com/repos/kvendrik/sketchlint","labels_url":"https://api.github.com/repos/kvendrik/sketchlint/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/kvendrik/sketchlint/issues/1/comments","events_url":"https://api.github.com/repos/kvendrik/sketchlint/issues/1/events","html_url":"https://github.com/kvendrik/sketchlint/issues/1","id":344930420,"node_id":"MDU6SXNzdWUzNDQ5MzA0MjA=","number":1,"title":"Support for an `artboard` rule?","user":{"login":"bomberstudios","id":3832,"node_id":"MDQ6VXNlcjM4MzI=","avatar_url":"https://avatars3.githubusercontent.com/u/3832?v=4","gravatar_id":"","url":"https://api.github.com/users/bomberstudios","html_url":"https://github.com/bomberstudios","followers_url":"https://api.github.com/users/bomberstudios/followers","following_url":"https://api.github.com/users/bomberstudios/following{/other_user}","gists_url":"https://api.github.com/users/bomberstudios/gists{/gist_id}","starred_url":"https://api.github.com/users/bomberstudios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bomberstudios/subscriptions","organizations_url":"https://api.github.com/users/bomberstudios/orgs","repos_url":"https://api.github.com/users/bomberstudios/repos","events_url":"https://api.github.com/users/bomberstudios/events{/privacy}","received_events_url":"https://api.github.com/users/bomberstudios/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-26T17:11:46Z","updated_at":"2018-07-27T12:18:37Z","closed_at":null,"author_association":"NONE","body":"First of all: congratulations for the work here. The tool looks amazing.\r\n\r\nIt would be nice to have a rule for `artboard` (and maybe even `group`?) so that a check could be made for the layers in it (think \"contrast ratio check\", and stuff like that)\r\n\r\nCurrently this can be done by checking if `layer` is an Artboard, but I think it'd make the code in the config file a bit nicer : )"},"comment":{"url":"https://api.github.com/repos/kvendrik/sketchlint/issues/comments/408402555","html_url":"https://github.com/kvendrik/sketchlint/issues/1#issuecomment-408402555","issue_url":"https://api.github.com/repos/kvendrik/sketchlint/issues/1","id":408402555,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODQwMjU1NQ==","user":{"login":"kvendrik","id":4029894,"node_id":"MDQ6VXNlcjQwMjk4OTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4029894?v=4","gravatar_id":"","url":"https://api.github.com/users/kvendrik","html_url":"https://github.com/kvendrik","followers_url":"https://api.github.com/users/kvendrik/followers","following_url":"https://api.github.com/users/kvendrik/following{/other_user}","gists_url":"https://api.github.com/users/kvendrik/gists{/gist_id}","starred_url":"https://api.github.com/users/kvendrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kvendrik/subscriptions","organizations_url":"https://api.github.com/users/kvendrik/orgs","repos_url":"https://api.github.com/users/kvendrik/repos","events_url":"https://api.github.com/users/kvendrik/events{/privacy}","received_events_url":"https://api.github.com/users/kvendrik/received_events","type":"User","site_admin":false},"created_at":"2018-07-27T12:18:37Z","updated_at":"2018-07-27T12:18:37Z","author_association":"OWNER","body":"Hey @bomberstudios!\r\n\r\nFirst of all thank you! I'm glad you like it! About the issue: I agree, for the `alpha` this works as in Sketch's native's format an artboard is considered a layer which means you can check for it like this:\r\n\r\n```ts\r\n{\r\n  layers: {\r\n    someAwesomeRuleForArtboards({_class}) {\r\n      if (_class === 'artboard') {\r\n        ...\r\n      }\r\n    },\r\n  }\r\n}\r\n```\r\n\r\nI agree though that instinctively this doesn't make sense. If you don't know how the Sketch JSON file format works you would expect every \"group\" to be its own category so: page -> artboard -> group -> layer. I've started looking into how this would work [here](https://github.com/kvendrik/sketchlint/compare/feature/seperate-artboard-rules) but its still WIP and I have some other things that have higher priority for this project right now (e.g. a Sketch plugin 😄) but I'll leave this open so I can come back to this later.\r\n\r\nAlso if you like the project and wanna contribute help is always welcome. [You can find the contribution instructions here](https://github.com/kvendrik/sketchlint#-contributing)."}}
{"actor":{"display_login":"kvendrik"}}