{"action":"closed","number":218,"pull_request":{"url":"https://api.github.com/repos/uyuni-project/uyuni/pulls/218","id":223202124,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMjAyMTI0","html_url":"https://github.com/uyuni-project/uyuni/pull/218","diff_url":"https://github.com/uyuni-project/uyuni/pull/218.diff","patch_url":"https://github.com/uyuni-project/uyuni/pull/218.patch","issue_url":"https://api.github.com/repos/uyuni-project/uyuni/issues/218","number":218,"state":"closed","locked":false,"title":"Testsuite: Wait until no 'pending' minions to avoid failures on Remote Commands","user":{"login":"meaksh","id":7229203,"node_id":"MDQ6VXNlcjcyMjkyMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/7229203?v=4","gravatar_id":"","url":"https://api.github.com/users/meaksh","html_url":"https://github.com/meaksh","followers_url":"https://api.github.com/users/meaksh/followers","following_url":"https://api.github.com/users/meaksh/following{/other_user}","gists_url":"https://api.github.com/users/meaksh/gists{/gist_id}","starred_url":"https://api.github.com/users/meaksh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meaksh/subscriptions","organizations_url":"https://api.github.com/users/meaksh/orgs","repos_url":"https://api.github.com/users/meaksh/repos","events_url":"https://api.github.com/users/meaksh/events{/privacy}","received_events_url":"https://api.github.com/users/meaksh/received_events","type":"User","site_admin":false},"body":"## What does this PR change?\r\nThis PR fixes a testsuite scenario that sometimes fails because the testsuite is not explicitly waiting until there are no pending minions and the \"run\" button is shown:\r\n\r\n```\r\n10:19:06   Scenario: Run a remote command on normal SLES minion                                 # features/core_min_bootstrap.feature:101\r\n10:19:06       This scenario ran at: 2018-10-16 12:19:04 +0200\r\n10:19:06     Given I am authorized as \"testing\" with password \"testing\"                         # features/step_definitions/navigation_steps.rb:381\r\n10:19:06     When I follow \"Salt\"                                                               # features/step_definitions/navigation_steps.rb:203\r\n10:19:08     And I follow \"Remote Commands\"                                                     # features/step_definitions/navigation_steps.rb:203\r\n10:19:08     Then I should see a \"Remote Commands\" text                                         # features/step_definitions/navigation_steps.rb:467\r\n10:19:08     When I enter command \"file /tmp\"                                                   # features/step_definitions/salt_steps.rb:206\r\n10:19:08     And I click on preview                                                             # features/step_definitions/salt_steps.rb:170\r\n10:19:09     Then I should see \"sle-minion\" hostname                                            # features/step_definitions/salt_steps.rb:191\r\n10:23:19     When I click on run                                                                # features/step_definitions/salt_steps.rb:174\r\n10:23:19       Run button not found (RuntimeError)\r\n10:23:19       ./features/step_definitions/salt_steps.rb:187:in `rescue in block in <top (required)>'\r\n10:23:19       ./features/step_definitions/salt_steps.rb:175:in `/^I click on run$/'\r\n10:23:19       features/core_min_bootstrap.feature:109:in `When I click on run'\r\n10:23:19     And I wait for \"3\" seconds                                                         # features/step_definitions/common_steps.rb:12\r\n10:23:19     And I expand the results for \"sle-minion\"                                          # features/step_definitions/salt_steps.rb:201\r\n10:23:19     Then I should see \"/tmp: sticky, directory\" in the command output for \"sle-minion\" # features/step_definitions/salt_steps.rb:214\r\n```\r\n","created_at":"2018-10-16T10:49:24Z","updated_at":"2018-10-16T11:15:29Z","closed_at":"2018-10-16T11:15:29Z","merged_at":"2018-10-16T11:15:29Z","merge_commit_sha":"a453c3ecd6640f1a395dc313c4c45a4feda44d8b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/uyuni-project/uyuni/pulls/218/commits","review_comments_url":"https://api.github.com/repos/uyuni-project/uyuni/pulls/218/comments","review_comment_url":"https://api.github.com/repos/uyuni-project/uyuni/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uyuni-project/uyuni/issues/218/comments","statuses_url":"https://api.github.com/repos/uyuni-project/uyuni/statuses/e94e4be3abf7d8f793e16e6576b90423aa0577e5","head":{"label":"meaksh:master-fix-remote-cmd-testsuite-scenario","ref":"master-fix-remote-cmd-testsuite-scenario","sha":"e94e4be3abf7d8f793e16e6576b90423aa0577e5","user":{"login":"meaksh","id":7229203,"node_id":"MDQ6VXNlcjcyMjkyMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/7229203?v=4","gravatar_id":"","url":"https://api.github.com/users/meaksh","html_url":"https://github.com/meaksh","followers_url":"https://api.github.com/users/meaksh/followers","following_url":"https://api.github.com/users/meaksh/following{/other_user}","gists_url":"https://api.github.com/users/meaksh/gists{/gist_id}","starred_url":"https://api.github.com/users/meaksh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meaksh/subscriptions","organizations_url":"https://api.github.com/users/meaksh/orgs","repos_url":"https://api.github.com/users/meaksh/repos","events_url":"https://api.github.com/users/meaksh/events{/privacy}","received_events_url":"https://api.github.com/users/meaksh/received_events","type":"User","site_admin":false},"repo":{"id":145697670,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU2OTc2NzA=","name":"uyuni","full_name":"meaksh/uyuni","private":false,"owner":{"login":"meaksh","id":7229203,"node_id":"MDQ6VXNlcjcyMjkyMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/7229203?v=4","gravatar_id":"","url":"https://api.github.com/users/meaksh","html_url":"https://github.com/meaksh","followers_url":"https://api.github.com/users/meaksh/followers","following_url":"https://api.github.com/users/meaksh/following{/other_user}","gists_url":"https://api.github.com/users/meaksh/gists{/gist_id}","starred_url":"https://api.github.com/users/meaksh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meaksh/subscriptions","organizations_url":"https://api.github.com/users/meaksh/orgs","repos_url":"https://api.github.com/users/meaksh/repos","events_url":"https://api.github.com/users/meaksh/events{/privacy}","received_events_url":"https://api.github.com/users/meaksh/received_events","type":"User","site_admin":false},"html_url":"https://github.com/meaksh/uyuni","description":"Source code for Uyuni","fork":true,"url":"https://api.github.com/repos/meaksh/uyuni","forks_url":"https://api.github.com/repos/meaksh/uyuni/forks","keys_url":"https://api.github.com/repos/meaksh/uyuni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meaksh/uyuni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meaksh/uyuni/teams","hooks_url":"https://api.github.com/repos/meaksh/uyuni/hooks","issue_events_url":"https://api.github.com/repos/meaksh/uyuni/issues/events{/number}","events_url":"https://api.github.com/repos/meaksh/uyuni/events","assignees_url":"https://api.github.com/repos/meaksh/uyuni/assignees{/user}","branches_url":"https://api.github.com/repos/meaksh/uyuni/branches{/branch}","tags_url":"https://api.github.com/repos/meaksh/uyuni/tags","blobs_url":"https://api.github.com/repos/meaksh/uyuni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meaksh/uyuni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meaksh/uyuni/git/refs{/sha}","trees_url":"https://api.github.com/repos/meaksh/uyuni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meaksh/uyuni/statuses/{sha}","languages_url":"https://api.github.com/repos/meaksh/uyuni/languages","stargazers_url":"https://api.github.com/repos/meaksh/uyuni/stargazers","contributors_url":"https://api.github.com/repos/meaksh/uyuni/contributors","subscribers_url":"https://api.github.com/repos/meaksh/uyuni/subscribers","subscription_url":"https://api.github.com/repos/meaksh/uyuni/subscription","commits_url":"https://api.github.com/repos/meaksh/uyuni/commits{/sha}","git_commits_url":"https://api.github.com/repos/meaksh/uyuni/git/commits{/sha}","comments_url":"https://api.github.com/repos/meaksh/uyuni/comments{/number}","issue_comment_url":"https://api.github.com/repos/meaksh/uyuni/issues/comments{/number}","contents_url":"https://api.github.com/repos/meaksh/uyuni/contents/{+path}","compare_url":"https://api.github.com/repos/meaksh/uyuni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meaksh/uyuni/merges","archive_url":"https://api.github.com/repos/meaksh/uyuni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meaksh/uyuni/downloads","issues_url":"https://api.github.com/repos/meaksh/uyuni/issues{/number}","pulls_url":"https://api.github.com/repos/meaksh/uyuni/pulls{/number}","milestones_url":"https://api.github.com/repos/meaksh/uyuni/milestones{/number}","notifications_url":"https://api.github.com/repos/meaksh/uyuni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meaksh/uyuni/labels{/name}","releases_url":"https://api.github.com/repos/meaksh/uyuni/releases{/id}","deployments_url":"https://api.github.com/repos/meaksh/uyuni/deployments","created_at":"2018-08-22T11:08:44Z","updated_at":"2018-08-22T11:10:03Z","pushed_at":"2018-10-16T10:45:28Z","git_url":"git://github.com/meaksh/uyuni.git","ssh_url":"git@github.com:meaksh/uyuni.git","clone_url":"https://github.com/meaksh/uyuni.git","svn_url":"https://github.com/meaksh/uyuni","homepage":"https://www.uyuni-project.org/","size":789563,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"uyuni-project:master","ref":"master","sha":"3a95f328eb036e0c98e124f37532a455bfdda40e","user":{"login":"uyuni-project","id":39272261,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjcyMjYx","avatar_url":"https://avatars0.githubusercontent.com/u/39272261?v=4","gravatar_id":"","url":"https://api.github.com/users/uyuni-project","html_url":"https://github.com/uyuni-project","followers_url":"https://api.github.com/users/uyuni-project/followers","following_url":"https://api.github.com/users/uyuni-project/following{/other_user}","gists_url":"https://api.github.com/users/uyuni-project/gists{/gist_id}","starred_url":"https://api.github.com/users/uyuni-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uyuni-project/subscriptions","organizations_url":"https://api.github.com/users/uyuni-project/orgs","repos_url":"https://api.github.com/users/uyuni-project/repos","events_url":"https://api.github.com/users/uyuni-project/events{/privacy}","received_events_url":"https://api.github.com/users/uyuni-project/received_events","type":"Organization","site_admin":false},"repo":{"id":143291989,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMyOTE5ODk=","name":"uyuni","full_name":"uyuni-project/uyuni","private":false,"owner":{"login":"uyuni-project","id":39272261,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjcyMjYx","avatar_url":"https://avatars0.githubusercontent.com/u/39272261?v=4","gravatar_id":"","url":"https://api.github.com/users/uyuni-project","html_url":"https://github.com/uyuni-project","followers_url":"https://api.github.com/users/uyuni-project/followers","following_url":"https://api.github.com/users/uyuni-project/following{/other_user}","gists_url":"https://api.github.com/users/uyuni-project/gists{/gist_id}","starred_url":"https://api.github.com/users/uyuni-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uyuni-project/subscriptions","organizations_url":"https://api.github.com/users/uyuni-project/orgs","repos_url":"https://api.github.com/users/uyuni-project/repos","events_url":"https://api.github.com/users/uyuni-project/events{/privacy}","received_events_url":"https://api.github.com/users/uyuni-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/uyuni-project/uyuni","description":"Source code for Uyuni","fork":false,"url":"https://api.github.com/repos/uyuni-project/uyuni","forks_url":"https://api.github.com/repos/uyuni-project/uyuni/forks","keys_url":"https://api.github.com/repos/uyuni-project/uyuni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uyuni-project/uyuni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uyuni-project/uyuni/teams","hooks_url":"https://api.github.com/repos/uyuni-project/uyuni/hooks","issue_events_url":"https://api.github.com/repos/uyuni-project/uyuni/issues/events{/number}","events_url":"https://api.github.com/repos/uyuni-project/uyuni/events","assignees_url":"https://api.github.com/repos/uyuni-project/uyuni/assignees{/user}","branches_url":"https://api.github.com/repos/uyuni-project/uyuni/branches{/branch}","tags_url":"https://api.github.com/repos/uyuni-project/uyuni/tags","blobs_url":"https://api.github.com/repos/uyuni-project/uyuni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uyuni-project/uyuni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uyuni-project/uyuni/git/refs{/sha}","trees_url":"https://api.github.com/repos/uyuni-project/uyuni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uyuni-project/uyuni/statuses/{sha}","languages_url":"https://api.github.com/repos/uyuni-project/uyuni/languages","stargazers_url":"https://api.github.com/repos/uyuni-project/uyuni/stargazers","contributors_url":"https://api.github.com/repos/uyuni-project/uyuni/contributors","subscribers_url":"https://api.github.com/repos/uyuni-project/uyuni/subscribers","subscription_url":"https://api.github.com/repos/uyuni-project/uyuni/subscription","commits_url":"https://api.github.com/repos/uyuni-project/uyuni/commits{/sha}","git_commits_url":"https://api.github.com/repos/uyuni-project/uyuni/git/commits{/sha}","comments_url":"https://api.github.com/repos/uyuni-project/uyuni/comments{/number}","issue_comment_url":"https://api.github.com/repos/uyuni-project/uyuni/issues/comments{/number}","contents_url":"https://api.github.com/repos/uyuni-project/uyuni/contents/{+path}","compare_url":"https://api.github.com/repos/uyuni-project/uyuni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uyuni-project/uyuni/merges","archive_url":"https://api.github.com/repos/uyuni-project/uyuni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uyuni-project/uyuni/downloads","issues_url":"https://api.github.com/repos/uyuni-project/uyuni/issues{/number}","pulls_url":"https://api.github.com/repos/uyuni-project/uyuni/pulls{/number}","milestones_url":"https://api.github.com/repos/uyuni-project/uyuni/milestones{/number}","notifications_url":"https://api.github.com/repos/uyuni-project/uyuni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uyuni-project/uyuni/labels{/name}","releases_url":"https://api.github.com/repos/uyuni-project/uyuni/releases{/id}","deployments_url":"https://api.github.com/repos/uyuni-project/uyuni/deployments","created_at":"2018-08-02T12:31:20Z","updated_at":"2018-10-16T07:34:34Z","pushed_at":"2018-10-16T11:15:29Z","git_url":"git://github.com/uyuni-project/uyuni.git","ssh_url":"git@github.com:uyuni-project/uyuni.git","clone_url":"https://github.com/uyuni-project/uyuni.git","svn_url":"https://github.com/uyuni-project/uyuni","homepage":"https://www.uyuni-project.org/","size":789584,"stargazers_count":20,"watchers_count":20,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":22,"open_issues":18,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uyuni-project/uyuni/pulls/218"},"html":{"href":"https://github.com/uyuni-project/uyuni/pull/218"},"issue":{"href":"https://api.github.com/repos/uyuni-project/uyuni/issues/218"},"comments":{"href":"https://api.github.com/repos/uyuni-project/uyuni/issues/218/comments"},"review_comments":{"href":"https://api.github.com/repos/uyuni-project/uyuni/pulls/218/comments"},"review_comment":{"href":"https://api.github.com/repos/uyuni-project/uyuni/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uyuni-project/uyuni/pulls/218/commits"},"statuses":{"href":"https://api.github.com/repos/uyuni-project/uyuni/statuses/e94e4be3abf7d8f793e16e6576b90423aa0577e5"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"juliogonzalez","id":4226070,"node_id":"MDQ6VXNlcjQyMjYwNzA=","avatar_url":"https://avatars1.githubusercontent.com/u/4226070?v=4","gravatar_id":"","url":"https://api.github.com/users/juliogonzalez","html_url":"https://github.com/juliogonzalez","followers_url":"https://api.github.com/users/juliogonzalez/followers","following_url":"https://api.github.com/users/juliogonzalez/following{/other_user}","gists_url":"https://api.github.com/users/juliogonzalez/gists{/gist_id}","starred_url":"https://api.github.com/users/juliogonzalez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliogonzalez/subscriptions","organizations_url":"https://api.github.com/users/juliogonzalez/orgs","repos_url":"https://api.github.com/users/juliogonzalez/repos","events_url":"https://api.github.com/users/juliogonzalez/events{/privacy}","received_events_url":"https://api.github.com/users/juliogonzalez/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"juliogonzalez"}}