{"action":"created","comment":{"url":"https://api.github.com/repos/diffblue/cbmc/pulls/comments/192749804","pull_request_review_id":125584085,"id":192749804,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Mjc0OTgwNA==","diff_hunk":"@@ -210,6 +210,14 @@ bool ci_lazy_methodst::operator()(\n     }\n   }\n \n+  for(const auto &class_name : instantiated_classes)\n+  {\n+    const irep_idt cprover_validate =\n+      id2string(class_name) + \".cproverNondetInitialize:()V\";\n+    if(symbol_table.symbols.count(cprover_validate))\n+      methods_already_populated.insert(cprover_validate);","path":"jbmc/src/java_bytecode/ci_lazy_methods.cpp","position":12,"original_position":9,"commit_id":"500c3426e5156fd31017b4e081e1ae5263ead6f0","original_commit_id":"d0200d4d885a63f2f6a8de31f5f3f22c211dd894","user":{"login":"smowton","id":283483,"node_id":"MDQ6VXNlcjI4MzQ4Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/283483?v=4","gravatar_id":"","url":"https://api.github.com/users/smowton","html_url":"https://github.com/smowton","followers_url":"https://api.github.com/users/smowton/followers","following_url":"https://api.github.com/users/smowton/following{/other_user}","gists_url":"https://api.github.com/users/smowton/gists{/gist_id}","starred_url":"https://api.github.com/users/smowton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smowton/subscriptions","organizations_url":"https://api.github.com/users/smowton/orgs","repos_url":"https://api.github.com/users/smowton/repos","events_url":"https://api.github.com/users/smowton/events{/privacy}","received_events_url":"https://api.github.com/users/smowton/received_events","type":"User","site_admin":false},"body":"I meant, you should ensure the method actually is converted, not just put it in an \"already_populated\" set. Doing that will stop it being removed from the symbol table; putting it into the worklist will get the symbol's value (the method body) populated.","created_at":"2018-06-04T13:57:58Z","updated_at":"2018-06-04T13:57:58Z","html_url":"https://github.com/diffblue/cbmc/pull/2267#discussion_r192749804","pull_request_url":"https://api.github.com/repos/diffblue/cbmc/pulls/2267","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/comments/192749804"},"html":{"href":"https://github.com/diffblue/cbmc/pull/2267#discussion_r192749804"},"pull_request":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/2267"}},"in_reply_to_id":192426216},"pull_request":{"url":"https://api.github.com/repos/diffblue/cbmc/pulls/2267","id":191994793,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxOTk0Nzkz","html_url":"https://github.com/diffblue/cbmc/pull/2267","diff_url":"https://github.com/diffblue/cbmc/pull/2267.diff","patch_url":"https://github.com/diffblue/cbmc/pull/2267.patch","issue_url":"https://api.github.com/repos/diffblue/cbmc/issues/2267","number":2267,"state":"open","locked":false,"title":"[TG-3657] Always load CProver.nondetInitialize","user":{"login":"LAJW","id":11063742,"node_id":"MDQ6VXNlcjExMDYzNzQy","avatar_url":"https://avatars2.githubusercontent.com/u/11063742?v=4","gravatar_id":"","url":"https://api.github.com/users/LAJW","html_url":"https://github.com/LAJW","followers_url":"https://api.github.com/users/LAJW/followers","following_url":"https://api.github.com/users/LAJW/following{/other_user}","gists_url":"https://api.github.com/users/LAJW/gists{/gist_id}","starred_url":"https://api.github.com/users/LAJW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LAJW/subscriptions","organizations_url":"https://api.github.com/users/LAJW/orgs","repos_url":"https://api.github.com/users/LAJW/repos","events_url":"https://api.github.com/users/LAJW/events{/privacy}","received_events_url":"https://api.github.com/users/LAJW/received_events","type":"User","site_admin":false},"body":"This PR adds `CProver.nondetInitialize` to the white-list of the lazy loader.\r\n\r\nTG Bump and test: https://github.com/diffblue/test-gen/pull/1880","created_at":"2018-06-01T10:27:50Z","updated_at":"2018-06-04T13:57:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f040e6521b7659f8507cea5e01e41fca230089e8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cesaro","id":143977,"node_id":"MDQ6VXNlcjE0Mzk3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/143977?v=4","gravatar_id":"","url":"https://api.github.com/users/cesaro","html_url":"https://github.com/cesaro","followers_url":"https://api.github.com/users/cesaro/followers","following_url":"https://api.github.com/users/cesaro/following{/other_user}","gists_url":"https://api.github.com/users/cesaro/gists{/gist_id}","starred_url":"https://api.github.com/users/cesaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cesaro/subscriptions","organizations_url":"https://api.github.com/users/cesaro/orgs","repos_url":"https://api.github.com/users/cesaro/repos","events_url":"https://api.github.com/users/cesaro/events{/privacy}","received_events_url":"https://api.github.com/users/cesaro/received_events","type":"User","site_admin":false},{"login":"thk123","id":638608,"node_id":"MDQ6VXNlcjYzODYwOA==","avatar_url":"https://avatars3.githubusercontent.com/u/638608?v=4","gravatar_id":"","url":"https://api.github.com/users/thk123","html_url":"https://github.com/thk123","followers_url":"https://api.github.com/users/thk123/followers","following_url":"https://api.github.com/users/thk123/following{/other_user}","gists_url":"https://api.github.com/users/thk123/gists{/gist_id}","starred_url":"https://api.github.com/users/thk123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thk123/subscriptions","organizations_url":"https://api.github.com/users/thk123/orgs","repos_url":"https://api.github.com/users/thk123/repos","events_url":"https://api.github.com/users/thk123/events{/privacy}","received_events_url":"https://api.github.com/users/thk123/received_events","type":"User","site_admin":false},{"login":"mgudemann","id":2590540,"node_id":"MDQ6VXNlcjI1OTA1NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/2590540?v=4","gravatar_id":"","url":"https://api.github.com/users/mgudemann","html_url":"https://github.com/mgudemann","followers_url":"https://api.github.com/users/mgudemann/followers","following_url":"https://api.github.com/users/mgudemann/following{/other_user}","gists_url":"https://api.github.com/users/mgudemann/gists{/gist_id}","starred_url":"https://api.github.com/users/mgudemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgudemann/subscriptions","organizations_url":"https://api.github.com/users/mgudemann/orgs","repos_url":"https://api.github.com/users/mgudemann/repos","events_url":"https://api.github.com/users/mgudemann/events{/privacy}","received_events_url":"https://api.github.com/users/mgudemann/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/diffblue/cbmc/pulls/2267/commits","review_comments_url":"https://api.github.com/repos/diffblue/cbmc/pulls/2267/comments","review_comment_url":"https://api.github.com/repos/diffblue/cbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/diffblue/cbmc/issues/2267/comments","statuses_url":"https://api.github.com/repos/diffblue/cbmc/statuses/500c3426e5156fd31017b4e081e1ae5263ead6f0","head":{"label":"LAJW:lajw/always-load-cprover-nondet-initialize","ref":"lajw/always-load-cprover-nondet-initialize","sha":"500c3426e5156fd31017b4e081e1ae5263ead6f0","user":{"login":"LAJW","id":11063742,"node_id":"MDQ6VXNlcjExMDYzNzQy","avatar_url":"https://avatars2.githubusercontent.com/u/11063742?v=4","gravatar_id":"","url":"https://api.github.com/users/LAJW","html_url":"https://github.com/LAJW","followers_url":"https://api.github.com/users/LAJW/followers","following_url":"https://api.github.com/users/LAJW/following{/other_user}","gists_url":"https://api.github.com/users/LAJW/gists{/gist_id}","starred_url":"https://api.github.com/users/LAJW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LAJW/subscriptions","organizations_url":"https://api.github.com/users/LAJW/orgs","repos_url":"https://api.github.com/users/LAJW/repos","events_url":"https://api.github.com/users/LAJW/events{/privacy}","received_events_url":"https://api.github.com/users/LAJW/received_events","type":"User","site_admin":false},"repo":{"id":96877268,"node_id":"MDEwOlJlcG9zaXRvcnk5Njg3NzI2OA==","name":"cbmc","full_name":"LAJW/cbmc","owner":{"login":"LAJW","id":11063742,"node_id":"MDQ6VXNlcjExMDYzNzQy","avatar_url":"https://avatars2.githubusercontent.com/u/11063742?v=4","gravatar_id":"","url":"https://api.github.com/users/LAJW","html_url":"https://github.com/LAJW","followers_url":"https://api.github.com/users/LAJW/followers","following_url":"https://api.github.com/users/LAJW/following{/other_user}","gists_url":"https://api.github.com/users/LAJW/gists{/gist_id}","starred_url":"https://api.github.com/users/LAJW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LAJW/subscriptions","organizations_url":"https://api.github.com/users/LAJW/orgs","repos_url":"https://api.github.com/users/LAJW/repos","events_url":"https://api.github.com/users/LAJW/events{/privacy}","received_events_url":"https://api.github.com/users/LAJW/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LAJW/cbmc","description":"C Bounded Model Checker","fork":true,"url":"https://api.github.com/repos/LAJW/cbmc","forks_url":"https://api.github.com/repos/LAJW/cbmc/forks","keys_url":"https://api.github.com/repos/LAJW/cbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LAJW/cbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LAJW/cbmc/teams","hooks_url":"https://api.github.com/repos/LAJW/cbmc/hooks","issue_events_url":"https://api.github.com/repos/LAJW/cbmc/issues/events{/number}","events_url":"https://api.github.com/repos/LAJW/cbmc/events","assignees_url":"https://api.github.com/repos/LAJW/cbmc/assignees{/user}","branches_url":"https://api.github.com/repos/LAJW/cbmc/branches{/branch}","tags_url":"https://api.github.com/repos/LAJW/cbmc/tags","blobs_url":"https://api.github.com/repos/LAJW/cbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LAJW/cbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LAJW/cbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/LAJW/cbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LAJW/cbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/LAJW/cbmc/languages","stargazers_url":"https://api.github.com/repos/LAJW/cbmc/stargazers","contributors_url":"https://api.github.com/repos/LAJW/cbmc/contributors","subscribers_url":"https://api.github.com/repos/LAJW/cbmc/subscribers","subscription_url":"https://api.github.com/repos/LAJW/cbmc/subscription","commits_url":"https://api.github.com/repos/LAJW/cbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/LAJW/cbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/LAJW/cbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/LAJW/cbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/LAJW/cbmc/contents/{+path}","compare_url":"https://api.github.com/repos/LAJW/cbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LAJW/cbmc/merges","archive_url":"https://api.github.com/repos/LAJW/cbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LAJW/cbmc/downloads","issues_url":"https://api.github.com/repos/LAJW/cbmc/issues{/number}","pulls_url":"https://api.github.com/repos/LAJW/cbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/LAJW/cbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/LAJW/cbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LAJW/cbmc/labels{/name}","releases_url":"https://api.github.com/repos/LAJW/cbmc/releases{/id}","deployments_url":"https://api.github.com/repos/LAJW/cbmc/deployments","created_at":"2017-07-11T09:41:59Z","updated_at":"2017-07-11T09:42:07Z","pushed_at":"2018-06-04T12:19:59Z","git_url":"git://github.com/LAJW/cbmc.git","ssh_url":"git@github.com:LAJW/cbmc.git","clone_url":"https://github.com/LAJW/cbmc.git","svn_url":"https://github.com/LAJW/cbmc","homepage":"http://www.cprover.org/cbmc","size":30366,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"diffblue:develop","ref":"develop","sha":"f1d787b847a604afcae77ade1080d3301be4d9a9","user":{"login":"diffblue","id":17216098,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MjE2MDk4","avatar_url":"https://avatars0.githubusercontent.com/u/17216098?v=4","gravatar_id":"","url":"https://api.github.com/users/diffblue","html_url":"https://github.com/diffblue","followers_url":"https://api.github.com/users/diffblue/followers","following_url":"https://api.github.com/users/diffblue/following{/other_user}","gists_url":"https://api.github.com/users/diffblue/gists{/gist_id}","starred_url":"https://api.github.com/users/diffblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diffblue/subscriptions","organizations_url":"https://api.github.com/users/diffblue/orgs","repos_url":"https://api.github.com/users/diffblue/repos","events_url":"https://api.github.com/users/diffblue/events{/privacy}","received_events_url":"https://api.github.com/users/diffblue/received_events","type":"Organization","site_admin":false},"repo":{"id":51877056,"node_id":"MDEwOlJlcG9zaXRvcnk1MTg3NzA1Ng==","name":"cbmc","full_name":"diffblue/cbmc","owner":{"login":"diffblue","id":17216098,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MjE2MDk4","avatar_url":"https://avatars0.githubusercontent.com/u/17216098?v=4","gravatar_id":"","url":"https://api.github.com/users/diffblue","html_url":"https://github.com/diffblue","followers_url":"https://api.github.com/users/diffblue/followers","following_url":"https://api.github.com/users/diffblue/following{/other_user}","gists_url":"https://api.github.com/users/diffblue/gists{/gist_id}","starred_url":"https://api.github.com/users/diffblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diffblue/subscriptions","organizations_url":"https://api.github.com/users/diffblue/orgs","repos_url":"https://api.github.com/users/diffblue/repos","events_url":"https://api.github.com/users/diffblue/events{/privacy}","received_events_url":"https://api.github.com/users/diffblue/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/diffblue/cbmc","description":"C Bounded Model Checker","fork":false,"url":"https://api.github.com/repos/diffblue/cbmc","forks_url":"https://api.github.com/repos/diffblue/cbmc/forks","keys_url":"https://api.github.com/repos/diffblue/cbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diffblue/cbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diffblue/cbmc/teams","hooks_url":"https://api.github.com/repos/diffblue/cbmc/hooks","issue_events_url":"https://api.github.com/repos/diffblue/cbmc/issues/events{/number}","events_url":"https://api.github.com/repos/diffblue/cbmc/events","assignees_url":"https://api.github.com/repos/diffblue/cbmc/assignees{/user}","branches_url":"https://api.github.com/repos/diffblue/cbmc/branches{/branch}","tags_url":"https://api.github.com/repos/diffblue/cbmc/tags","blobs_url":"https://api.github.com/repos/diffblue/cbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diffblue/cbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diffblue/cbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/diffblue/cbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diffblue/cbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/diffblue/cbmc/languages","stargazers_url":"https://api.github.com/repos/diffblue/cbmc/stargazers","contributors_url":"https://api.github.com/repos/diffblue/cbmc/contributors","subscribers_url":"https://api.github.com/repos/diffblue/cbmc/subscribers","subscription_url":"https://api.github.com/repos/diffblue/cbmc/subscription","commits_url":"https://api.github.com/repos/diffblue/cbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/diffblue/cbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/diffblue/cbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/diffblue/cbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/diffblue/cbmc/contents/{+path}","compare_url":"https://api.github.com/repos/diffblue/cbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diffblue/cbmc/merges","archive_url":"https://api.github.com/repos/diffblue/cbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diffblue/cbmc/downloads","issues_url":"https://api.github.com/repos/diffblue/cbmc/issues{/number}","pulls_url":"https://api.github.com/repos/diffblue/cbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/diffblue/cbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/diffblue/cbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diffblue/cbmc/labels{/name}","releases_url":"https://api.github.com/repos/diffblue/cbmc/releases{/id}","deployments_url":"https://api.github.com/repos/diffblue/cbmc/deployments","created_at":"2016-02-16T23:03:52Z","updated_at":"2018-06-04T12:29:28Z","pushed_at":"2018-06-04T12:29:03Z","git_url":"git://github.com/diffblue/cbmc.git","ssh_url":"git@github.com:diffblue/cbmc.git","clone_url":"https://github.com/diffblue/cbmc.git","svn_url":"https://github.com/diffblue/cbmc","homepage":"http://www.cprover.org/cbmc","size":31585,"stargazers_count":115,"watchers_count":115,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":94,"mirror_url":null,"archived":false,"open_issues_count":379,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":94,"open_issues":379,"watchers":115,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/2267"},"html":{"href":"https://github.com/diffblue/cbmc/pull/2267"},"issue":{"href":"https://api.github.com/repos/diffblue/cbmc/issues/2267"},"comments":{"href":"https://api.github.com/repos/diffblue/cbmc/issues/2267/comments"},"review_comments":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/2267/comments"},"review_comment":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/2267/commits"},"statuses":{"href":"https://api.github.com/repos/diffblue/cbmc/statuses/500c3426e5156fd31017b4e081e1ae5263ead6f0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"smowton"}}