{"action":"created","comment":{"url":"https://api.github.com/repos/su2code/SU2/pulls/comments/173560043","pull_request_review_id":102765244,"id":173560043,"diff_hunk":"@@ -578,3 +578,1978 @@ void CHeatSolver::ImplicitEuler_Iteration(CGeometry *geometry, CSolver **solver_\n   SetResidual_RMS(geometry, config);\n   \n }\n+\n+CHeatSolverFVM::CHeatSolverFVM(void) : CSolver() {\n+\n+  ConjugateVar = NULL;\n+}\n+\n+CHeatSolverFVM::CHeatSolverFVM(CGeometry *geometry, CConfig *config, unsigned short iMesh) : CSolver() {\n+\n+  unsigned short iVar, iDim, nLineLets, iMarker;\n+  unsigned long iPoint, index, iVertex;\n+  su2double dull_val;\n+\n+  unsigned short iZone = config->GetiZone();\n+  unsigned short nZone = geometry->GetnZone();\n+  bool restart = (config->GetRestart() || config->GetRestart_Flow());\n+  bool adjoint = (config->GetContinuous_Adjoint()) || (config->GetDiscrete_Adjoint());\n+  bool dual_time = ((config->GetUnsteady_Simulation() == DT_STEPPING_1ST) ||\n+                    (config->GetUnsteady_Simulation() == DT_STEPPING_2ND));\n+  bool time_stepping = config->GetUnsteady_Simulation() == TIME_STEPPING;\n+\n+  int rank = MASTER_NODE;\n+\n+  bool flow = ((config->GetKind_Solver() == NAVIER_STOKES)\n+               || (config->GetKind_Solver() == RANS)\n+               || (config->GetKind_Solver() == DISC_ADJ_NAVIER_STOKES)\n+               || (config->GetKind_Solver() == DISC_ADJ_RANS));\n+  bool compressible = config->GetKind_Regime() == COMPRESSIBLE;\n+  bool heat_equation      = config->GetKind_Solver() == HEAT_EQUATION_FVM;\n+  unsigned short turbulent = config->GetKind_Turb_Model();\n+\n+#ifdef HAVE_MPI\n+  MPI_Comm_rank(MPI_COMM_WORLD, &rank);\n+#endif\n+\n+  /*--- Dimension of the problem --> temperature is the only conservative variable ---*/\n+\n+  nVar = 1;\n+  nPoint = geometry->GetnPoint();\n+  nPointDomain = geometry->GetnPointDomain();\n+\n+  /*--- Initialize nVarGrad for deallocation ---*/\n+\n+  nVarGrad = nVar;\n+\n+  /*--- Define geometry constants in the solver structure ---*/\n+\n+  nDim = geometry->GetnDim();\n+  node = new CVariable*[nPoint];\n+  nMarker = config->GetnMarker_All();\n+\n+  CurrentMesh = iMesh;","path":"SU2_CFD/src/solver_direct_heat.cpp","position":54,"original_position":54,"commit_id":"98b783434e8ece689f5daa0993ecd1cc0d449aa5","original_commit_id":"98b783434e8ece689f5daa0993ecd1cc0d449aa5","user":{"login":"economon","id":4896083,"avatar_url":"https://avatars0.githubusercontent.com/u/4896083?v=4","gravatar_id":"","url":"https://api.github.com/users/economon","html_url":"https://github.com/economon","followers_url":"https://api.github.com/users/economon/followers","following_url":"https://api.github.com/users/economon/following{/other_user}","gists_url":"https://api.github.com/users/economon/gists{/gist_id}","starred_url":"https://api.github.com/users/economon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/economon/subscriptions","organizations_url":"https://api.github.com/users/economon/orgs","repos_url":"https://api.github.com/users/economon/repos","events_url":"https://api.github.com/users/economon/events{/privacy}","received_events_url":"https://api.github.com/users/economon/received_events","type":"User","site_admin":false},"body":"Is multigrid working well for the new FVM heat solver?","created_at":"2018-03-09T20:31:17Z","updated_at":"2018-03-09T20:55:00Z","html_url":"https://github.com/su2code/SU2/pull/505#discussion_r173560043","pull_request_url":"https://api.github.com/repos/su2code/SU2/pulls/505","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/su2code/SU2/pulls/comments/173560043"},"html":{"href":"https://github.com/su2code/SU2/pull/505#discussion_r173560043"},"pull_request":{"href":"https://api.github.com/repos/su2code/SU2/pulls/505"}}},"pull_request":{"url":"https://api.github.com/repos/su2code/SU2/pulls/505","id":167649501,"html_url":"https://github.com/su2code/SU2/pull/505","diff_url":"https://github.com/su2code/SU2/pull/505.diff","patch_url":"https://github.com/su2code/SU2/pull/505.patch","issue_url":"https://api.github.com/repos/su2code/SU2/issues/505","number":505,"state":"open","locked":false,"title":"Native CHT functionality","user":{"login":"oleburghardt","id":22639394,"avatar_url":"https://avatars2.githubusercontent.com/u/22639394?v=4","gravatar_id":"","url":"https://api.github.com/users/oleburghardt","html_url":"https://github.com/oleburghardt","followers_url":"https://api.github.com/users/oleburghardt/followers","following_url":"https://api.github.com/users/oleburghardt/following{/other_user}","gists_url":"https://api.github.com/users/oleburghardt/gists{/gist_id}","starred_url":"https://api.github.com/users/oleburghardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleburghardt/subscriptions","organizations_url":"https://api.github.com/users/oleburghardt/orgs","repos_url":"https://api.github.com/users/oleburghardt/repos","events_url":"https://api.github.com/users/oleburghardt/events{/privacy}","received_events_url":"https://api.github.com/users/oleburghardt/received_events","type":"User","site_admin":false},"body":"This branch adds a native CHT functionality to SU2.\r\n\r\nMain contents are:\r\n\r\n1. A new driver (CMultiPhysicalZonesDriver) to specify the physics (e.g. which zones are fluids, which are solids) without a bunch of a priori or 'hard coded' assumptions. I intend to develop it further in near future which basically means to incorporate the existing sorts of interfaces (mixing plane, FSI, .. maybe it works out).\r\n1. A new finite-volume-based heat solver (CHeatSolverFVM). It can be run stand-alone in solids for pure heat conduction or weakly coupled to the incompressible mean flow solver.\r\n1. A new CTransfer child class (CTransfer_ConjugateHeatVars) to exchange CHT-related interface information.\r\n\r\nMost of these commits do not touch existing code but just use it. Exceptions are:\r\n1. Quite a few config options.\r\n1. A small new data structure in CDriver to store types of interfaces that is used by CMultiPhysicalZonesDriver. Some additions in **Interface_Preprocessing**.\r\n1. A change of **SetCFL_Number** so that the CFL adaption works for multiple zones. @salvovitale : One of your test cases is a multi-zones one that uses CFL adaption (the Jones one). This commit of course changes the solver behaviour in that case. I saw that you are averaging CFL numbers - maybe these problems are connected? Could you check if the test case is still alright? For now, I had to change the regression test values.\r\n1. Some more else if(...)-cases in output_structure.cpp...\r\n\r\nAs this is my first pull request, it's very likely that I missed some good-practices. I would like to point out that many of the commits contain _purely copied code_.\r\nThere was always some reason when it could not re-use it, but please be a bit indulgent if I missed to reference the credits. I just don't know where to.. if something attracts your attention, I will change it asap :-) Furthermore I should mention that\r\n1. This branch contains are very **naive couling procedure**. I will add Robin-like BC's and conservative energy correction routines when I feel comfortable about them.\r\n1. The **discrete adjoint version** of all this works fine. I will add it, too, if you like these additions.","created_at":"2018-02-07T10:15:43Z","updated_at":"2018-03-09T20:55:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d9841e8ec764f89fbc7dc0e7da0a71b5e1276b5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/su2code/SU2/pulls/505/commits","review_comments_url":"https://api.github.com/repos/su2code/SU2/pulls/505/comments","review_comment_url":"https://api.github.com/repos/su2code/SU2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/su2code/SU2/issues/505/comments","statuses_url":"https://api.github.com/repos/su2code/SU2/statuses/98b783434e8ece689f5daa0993ecd1cc0d449aa5","head":{"label":"su2code:feature_cht","ref":"feature_cht","sha":"98b783434e8ece689f5daa0993ecd1cc0d449aa5","user":{"login":"su2code","id":4796189,"avatar_url":"https://avatars0.githubusercontent.com/u/4796189?v=4","gravatar_id":"","url":"https://api.github.com/users/su2code","html_url":"https://github.com/su2code","followers_url":"https://api.github.com/users/su2code/followers","following_url":"https://api.github.com/users/su2code/following{/other_user}","gists_url":"https://api.github.com/users/su2code/gists{/gist_id}","starred_url":"https://api.github.com/users/su2code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/su2code/subscriptions","organizations_url":"https://api.github.com/users/su2code/orgs","repos_url":"https://api.github.com/users/su2code/repos","events_url":"https://api.github.com/users/su2code/events{/privacy}","received_events_url":"https://api.github.com/users/su2code/received_events","type":"Organization","site_admin":false},"repo":{"id":11036316,"name":"SU2","full_name":"su2code/SU2","owner":{"login":"su2code","id":4796189,"avatar_url":"https://avatars0.githubusercontent.com/u/4796189?v=4","gravatar_id":"","url":"https://api.github.com/users/su2code","html_url":"https://github.com/su2code","followers_url":"https://api.github.com/users/su2code/followers","following_url":"https://api.github.com/users/su2code/following{/other_user}","gists_url":"https://api.github.com/users/su2code/gists{/gist_id}","starred_url":"https://api.github.com/users/su2code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/su2code/subscriptions","organizations_url":"https://api.github.com/users/su2code/orgs","repos_url":"https://api.github.com/users/su2code/repos","events_url":"https://api.github.com/users/su2code/events{/privacy}","received_events_url":"https://api.github.com/users/su2code/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/su2code/SU2","description":"SU2 Suite","fork":false,"url":"https://api.github.com/repos/su2code/SU2","forks_url":"https://api.github.com/repos/su2code/SU2/forks","keys_url":"https://api.github.com/repos/su2code/SU2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/su2code/SU2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/su2code/SU2/teams","hooks_url":"https://api.github.com/repos/su2code/SU2/hooks","issue_events_url":"https://api.github.com/repos/su2code/SU2/issues/events{/number}","events_url":"https://api.github.com/repos/su2code/SU2/events","assignees_url":"https://api.github.com/repos/su2code/SU2/assignees{/user}","branches_url":"https://api.github.com/repos/su2code/SU2/branches{/branch}","tags_url":"https://api.github.com/repos/su2code/SU2/tags","blobs_url":"https://api.github.com/repos/su2code/SU2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/su2code/SU2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/su2code/SU2/git/refs{/sha}","trees_url":"https://api.github.com/repos/su2code/SU2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/su2code/SU2/statuses/{sha}","languages_url":"https://api.github.com/repos/su2code/SU2/languages","stargazers_url":"https://api.github.com/repos/su2code/SU2/stargazers","contributors_url":"https://api.github.com/repos/su2code/SU2/contributors","subscribers_url":"https://api.github.com/repos/su2code/SU2/subscribers","subscription_url":"https://api.github.com/repos/su2code/SU2/subscription","commits_url":"https://api.github.com/repos/su2code/SU2/commits{/sha}","git_commits_url":"https://api.github.com/repos/su2code/SU2/git/commits{/sha}","comments_url":"https://api.github.com/repos/su2code/SU2/comments{/number}","issue_comment_url":"https://api.github.com/repos/su2code/SU2/issues/comments{/number}","contents_url":"https://api.github.com/repos/su2code/SU2/contents/{+path}","compare_url":"https://api.github.com/repos/su2code/SU2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/su2code/SU2/merges","archive_url":"https://api.github.com/repos/su2code/SU2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/su2code/SU2/downloads","issues_url":"https://api.github.com/repos/su2code/SU2/issues{/number}","pulls_url":"https://api.github.com/repos/su2code/SU2/pulls{/number}","milestones_url":"https://api.github.com/repos/su2code/SU2/milestones{/number}","notifications_url":"https://api.github.com/repos/su2code/SU2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/su2code/SU2/labels{/name}","releases_url":"https://api.github.com/repos/su2code/SU2/releases{/id}","deployments_url":"https://api.github.com/repos/su2code/SU2/deployments","created_at":"2013-06-28T19:52:40Z","updated_at":"2018-03-05T21:45:38Z","pushed_at":"2018-03-09T05:04:15Z","git_url":"git://github.com/su2code/SU2.git","ssh_url":"git@github.com:su2code/SU2.git","clone_url":"https://github.com/su2code/SU2.git","svn_url":"https://github.com/su2code/SU2","homepage":"https://su2code.github.io","size":376487,"stargazers_count":332,"watchers_count":332,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":332,"mirror_url":null,"archived":false,"open_issues_count":91,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":332,"open_issues":91,"watchers":332,"default_branch":"master"}},"base":{"label":"su2code:develop","ref":"develop","sha":"446d20f2a8d96144f1497fabd39bab3335ac5317","user":{"login":"su2code","id":4796189,"avatar_url":"https://avatars0.githubusercontent.com/u/4796189?v=4","gravatar_id":"","url":"https://api.github.com/users/su2code","html_url":"https://github.com/su2code","followers_url":"https://api.github.com/users/su2code/followers","following_url":"https://api.github.com/users/su2code/following{/other_user}","gists_url":"https://api.github.com/users/su2code/gists{/gist_id}","starred_url":"https://api.github.com/users/su2code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/su2code/subscriptions","organizations_url":"https://api.github.com/users/su2code/orgs","repos_url":"https://api.github.com/users/su2code/repos","events_url":"https://api.github.com/users/su2code/events{/privacy}","received_events_url":"https://api.github.com/users/su2code/received_events","type":"Organization","site_admin":false},"repo":{"id":11036316,"name":"SU2","full_name":"su2code/SU2","owner":{"login":"su2code","id":4796189,"avatar_url":"https://avatars0.githubusercontent.com/u/4796189?v=4","gravatar_id":"","url":"https://api.github.com/users/su2code","html_url":"https://github.com/su2code","followers_url":"https://api.github.com/users/su2code/followers","following_url":"https://api.github.com/users/su2code/following{/other_user}","gists_url":"https://api.github.com/users/su2code/gists{/gist_id}","starred_url":"https://api.github.com/users/su2code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/su2code/subscriptions","organizations_url":"https://api.github.com/users/su2code/orgs","repos_url":"https://api.github.com/users/su2code/repos","events_url":"https://api.github.com/users/su2code/events{/privacy}","received_events_url":"https://api.github.com/users/su2code/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/su2code/SU2","description":"SU2 Suite","fork":false,"url":"https://api.github.com/repos/su2code/SU2","forks_url":"https://api.github.com/repos/su2code/SU2/forks","keys_url":"https://api.github.com/repos/su2code/SU2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/su2code/SU2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/su2code/SU2/teams","hooks_url":"https://api.github.com/repos/su2code/SU2/hooks","issue_events_url":"https://api.github.com/repos/su2code/SU2/issues/events{/number}","events_url":"https://api.github.com/repos/su2code/SU2/events","assignees_url":"https://api.github.com/repos/su2code/SU2/assignees{/user}","branches_url":"https://api.github.com/repos/su2code/SU2/branches{/branch}","tags_url":"https://api.github.com/repos/su2code/SU2/tags","blobs_url":"https://api.github.com/repos/su2code/SU2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/su2code/SU2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/su2code/SU2/git/refs{/sha}","trees_url":"https://api.github.com/repos/su2code/SU2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/su2code/SU2/statuses/{sha}","languages_url":"https://api.github.com/repos/su2code/SU2/languages","stargazers_url":"https://api.github.com/repos/su2code/SU2/stargazers","contributors_url":"https://api.github.com/repos/su2code/SU2/contributors","subscribers_url":"https://api.github.com/repos/su2code/SU2/subscribers","subscription_url":"https://api.github.com/repos/su2code/SU2/subscription","commits_url":"https://api.github.com/repos/su2code/SU2/commits{/sha}","git_commits_url":"https://api.github.com/repos/su2code/SU2/git/commits{/sha}","comments_url":"https://api.github.com/repos/su2code/SU2/comments{/number}","issue_comment_url":"https://api.github.com/repos/su2code/SU2/issues/comments{/number}","contents_url":"https://api.github.com/repos/su2code/SU2/contents/{+path}","compare_url":"https://api.github.com/repos/su2code/SU2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/su2code/SU2/merges","archive_url":"https://api.github.com/repos/su2code/SU2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/su2code/SU2/downloads","issues_url":"https://api.github.com/repos/su2code/SU2/issues{/number}","pulls_url":"https://api.github.com/repos/su2code/SU2/pulls{/number}","milestones_url":"https://api.github.com/repos/su2code/SU2/milestones{/number}","notifications_url":"https://api.github.com/repos/su2code/SU2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/su2code/SU2/labels{/name}","releases_url":"https://api.github.com/repos/su2code/SU2/releases{/id}","deployments_url":"https://api.github.com/repos/su2code/SU2/deployments","created_at":"2013-06-28T19:52:40Z","updated_at":"2018-03-05T21:45:38Z","pushed_at":"2018-03-09T05:04:15Z","git_url":"git://github.com/su2code/SU2.git","ssh_url":"git@github.com:su2code/SU2.git","clone_url":"https://github.com/su2code/SU2.git","svn_url":"https://github.com/su2code/SU2","homepage":"https://su2code.github.io","size":376487,"stargazers_count":332,"watchers_count":332,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":332,"mirror_url":null,"archived":false,"open_issues_count":91,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":332,"open_issues":91,"watchers":332,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/su2code/SU2/pulls/505"},"html":{"href":"https://github.com/su2code/SU2/pull/505"},"issue":{"href":"https://api.github.com/repos/su2code/SU2/issues/505"},"comments":{"href":"https://api.github.com/repos/su2code/SU2/issues/505/comments"},"review_comments":{"href":"https://api.github.com/repos/su2code/SU2/pulls/505/comments"},"review_comment":{"href":"https://api.github.com/repos/su2code/SU2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/su2code/SU2/pulls/505/commits"},"statuses":{"href":"https://api.github.com/repos/su2code/SU2/statuses/98b783434e8ece689f5daa0993ecd1cc0d449aa5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"economon"}}