{"action":"closed","issue":{"url":"https://api.github.com/repos/SCons/scons/issues/2787","repository_url":"https://api.github.com/repos/SCons/scons","labels_url":"https://api.github.com/repos/SCons/scons/issues/2787/labels{/name}","comments_url":"https://api.github.com/repos/SCons/scons/issues/2787/comments","events_url":"https://api.github.com/repos/SCons/scons/issues/2787/events","html_url":"https://github.com/SCons/scons/issues/2787","id":285447624,"number":2787,"title":"MkdirFunc fails the build if something else create the directory underneath it","user":{"login":"bdbaddog","id":82228,"avatar_url":"https://avatars0.githubusercontent.com/u/82228?v=4","gravatar_id":"","url":"https://api.github.com/users/bdbaddog","html_url":"https://github.com/bdbaddog","followers_url":"https://api.github.com/users/bdbaddog/followers","following_url":"https://api.github.com/users/bdbaddog/following{/other_user}","gists_url":"https://api.github.com/users/bdbaddog/gists{/gist_id}","starred_url":"https://api.github.com/users/bdbaddog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdbaddog/subscriptions","organizations_url":"https://api.github.com/users/bdbaddog/orgs","repos_url":"https://api.github.com/users/bdbaddog/repos","events_url":"https://api.github.com/users/bdbaddog/events{/privacy}","received_events_url":"https://api.github.com/users/bdbaddog/received_events","type":"User","site_admin":false},"labels":[{"id":792696616,"url":"https://api.github.com/repos/SCons/scons/labels/Op%20Sys:%20Windows","name":"Op Sys: Windows","color":"ededed","default":false},{"id":792660062,"url":"https://api.github.com/repos/SCons/scons/labels/P4","name":"P4","color":"ededed","default":false},{"id":792909006,"url":"https://api.github.com/repos/SCons/scons/labels/Version:%20github","name":"Version: github","color":"ededed","default":false},{"id":701576758,"url":"https://api.github.com/repos/SCons/scons/labels/wontfix","name":"wontfix","color":"ffffff","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-01-02T14:49:46Z","updated_at":"2018-03-02T19:39:58Z","closed_at":"2018-03-02T19:39:58Z","author_association":"CONTRIBUTOR","body":"This issue was originally created at: 2011-09-02 09:45:41.\r\nThis issue was reported by: `estanchev`.\r\nestanchev said at 2011-09-02 09:45:41\r\n>When scons tries to create a component of a path, it fails with \"File Exists\"\r\n>error, if another process creates the directory in the meantime.\r\n> \r\n>In SCons/Node/FS.py, in the _create method:\r\n>\t1) SCons.Node.Node.build(dirnode) calls MkdirFunc.\r\n>\t2) If MkdirFunc raises an OSError, it is catched by scons, packed as a\r\n>BuildError and then that is raised, to fail the build.\r\n>\t3) Thus, the try: except: code around that code is useless.\r\n\r\nestanchev said at 2011-09-02 09:46:11\r\n>Created an attachment (id=868)\r\n>This is the proposed patch.\r\n\r\nthosrtanner said at 2013-12-11 09:21:23\r\n>Just a thought - this could still throw an error if some other process creates\r\n>the directory between the 'if not exists' test you added and the following mkdir.\r\n\r\n\r\nVotes for this issue: 1.\r\n\r\nestanchev attached [MkdirFunc-existing-directory-bug.patch](https://github.com/SCons/tigris-issue-attachments/blob/master/2787/868/MkdirFunc-existing-directory-bug.patch) at 2011-09-02 09:46:11.\r\n>This is the proposed patch.\r\n"}}
{"actor":{"display_login":"bdbaddog"}}