{"action":"created","comment":{"url":"https://api.github.com/repos/apache/storm/pulls/comments/183402104","pull_request_review_id":114384906,"id":183402104,"diff_hunk":"@@ -192,10 +191,12 @@ void writeHeader(PrintWriter writer) {\n             header.add(SPOUT_MAX_COMPLETE_LATENCY);\n         }\n \n-        writer.println(\"\\n------------------------------------------------------------------------------------------------------------------\");\n+        writer.println(\n+            \"\\n------------------------------------------------------------------------------------------------------------------\");\n         String str = Utils.join(header, \",\");\n         writer.println(str);\n-        writer.println(\"------------------------------------------------------------------------------------------------------------------\");\n+        writer\n+            .println(\"------------------------------------------------------------------------------------------------------------------\");","path":"examples/storm-perf/src/main/java/org/apache/storm/perf/utils/BasicMetricsCollector.java","position":31,"original_position":31,"commit_id":"e8ffac458baf6cc7a90dd0ced78cc01f0ffb4229","original_commit_id":"e8ffac458baf6cc7a90dd0ced78cc01f0ffb4229","user":{"login":"Ethanlm","id":14900612,"avatar_url":"https://avatars0.githubusercontent.com/u/14900612?v=4","gravatar_id":"","url":"https://api.github.com/users/Ethanlm","html_url":"https://github.com/Ethanlm","followers_url":"https://api.github.com/users/Ethanlm/followers","following_url":"https://api.github.com/users/Ethanlm/following{/other_user}","gists_url":"https://api.github.com/users/Ethanlm/gists{/gist_id}","starred_url":"https://api.github.com/users/Ethanlm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ethanlm/subscriptions","organizations_url":"https://api.github.com/users/Ethanlm/orgs","repos_url":"https://api.github.com/users/Ethanlm/repos","events_url":"https://api.github.com/users/Ethanlm/events{/privacy}","received_events_url":"https://api.github.com/users/Ethanlm/received_events","type":"User","site_admin":false},"body":"Would it be good to be consistent about this `writer.println()`? Here we have \r\n```\r\nwriter.println(\r\n            \"\\n---...\r\n```\r\nand\r\n```\r\n writer\r\n            .println(\"---\r\n```","created_at":"2018-04-23T13:52:25Z","updated_at":"2018-04-23T13:58:01Z","html_url":"https://github.com/apache/storm/pull/2641#discussion_r183402104","pull_request_url":"https://api.github.com/repos/apache/storm/pulls/2641","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/comments/183402104"},"html":{"href":"https://github.com/apache/storm/pull/2641#discussion_r183402104"},"pull_request":{"href":"https://api.github.com/repos/apache/storm/pulls/2641"}}},"pull_request":{"url":"https://api.github.com/repos/apache/storm/pulls/2641","id":183339212,"html_url":"https://github.com/apache/storm/pull/2641","diff_url":"https://github.com/apache/storm/pull/2641.diff","patch_url":"https://github.com/apache/storm/pull/2641.patch","issue_url":"https://api.github.com/repos/apache/storm/issues/2641","number":2641,"state":"open","locked":false,"title":"[STORM-3037] Lowering CheckStyle Violations across all modules","user":{"login":"kishorvpatil","id":6090397,"avatar_url":"https://avatars2.githubusercontent.com/u/6090397?v=4","gravatar_id":"","url":"https://api.github.com/users/kishorvpatil","html_url":"https://github.com/kishorvpatil","followers_url":"https://api.github.com/users/kishorvpatil/followers","following_url":"https://api.github.com/users/kishorvpatil/following{/other_user}","gists_url":"https://api.github.com/users/kishorvpatil/gists{/gist_id}","starred_url":"https://api.github.com/users/kishorvpatil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kishorvpatil/subscriptions","organizations_url":"https://api.github.com/users/kishorvpatil/orgs","repos_url":"https://api.github.com/users/kishorvpatil/repos","events_url":"https://api.github.com/users/kishorvpatil/events{/privacy}","received_events_url":"https://api.github.com/users/kishorvpatil/received_events","type":"User","site_admin":false},"body":"Below is the list of modules affected by this patch. The max allowed violations are going down by 17000+.\r\n\r\n| Module Name | Max Allowed Exceptions Before | Max Allowed Exceptions After | \r\n| ----------- | ----------------------------- | ---------------------------- |\r\n| storm-client  | 10079 | 3298 | \r\n| storm-server  | 2585 | 783 | \r\n| storm-eventhubs  | 1765 | 45 | \r\n| storm-starter  | 1538 | 263 | \r\n| storm-hdfs  | 1406 | 189 | \r\n| storm-sql-core  | 1286 | 59 | \r\n| storm-redis  | 602 | 64 | \r\n| storm-cassandra  | 578 | 159 | \r\n| storm-kafka  | 557 | 180 | \r\n| storm-hbase | 371 | 100 | \r\n| storm-maven-plugins  | 269 | 11 | \r\n| storm-hive  | 259 | 58 | \r\n| storm-core  | 254 | 73 | \r\n| storm-jms  | 235 | 63 | \r\n| storm-hdfs-examples  | 224 | 29 | \r\n| storm-kafka-monitor  | 178 | 87 | \r\n| storm-mqtt  | 158 | 39 | \r\n| storm-jdbc  | 149 | 36 | \r\n| storm-solr  | 108 | 47 | \r\n| storm-perf  | 100 | 65 | \r\n| storm-hbase-examples | 55 | 16 | \r\n| maven-shade-clojure-transformer  | 16 | 0 | ","created_at":"2018-04-23T06:45:01Z","updated_at":"2018-04-23T13:58:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b569a930ac7c35edf71ddf48852de3abe811305","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/storm/pulls/2641/commits","review_comments_url":"https://api.github.com/repos/apache/storm/pulls/2641/comments","review_comment_url":"https://api.github.com/repos/apache/storm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/storm/issues/2641/comments","statuses_url":"https://api.github.com/repos/apache/storm/statuses/e8ffac458baf6cc7a90dd0ced78cc01f0ffb4229","head":{"label":"kishorvpatil:fix-style","ref":"fix-style","sha":"e8ffac458baf6cc7a90dd0ced78cc01f0ffb4229","user":{"login":"kishorvpatil","id":6090397,"avatar_url":"https://avatars2.githubusercontent.com/u/6090397?v=4","gravatar_id":"","url":"https://api.github.com/users/kishorvpatil","html_url":"https://github.com/kishorvpatil","followers_url":"https://api.github.com/users/kishorvpatil/followers","following_url":"https://api.github.com/users/kishorvpatil/following{/other_user}","gists_url":"https://api.github.com/users/kishorvpatil/gists{/gist_id}","starred_url":"https://api.github.com/users/kishorvpatil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kishorvpatil/subscriptions","organizations_url":"https://api.github.com/users/kishorvpatil/orgs","repos_url":"https://api.github.com/users/kishorvpatil/repos","events_url":"https://api.github.com/users/kishorvpatil/events{/privacy}","received_events_url":"https://api.github.com/users/kishorvpatil/received_events","type":"User","site_admin":false},"repo":{"id":15975579,"name":"incubator-storm","full_name":"kishorvpatil/incubator-storm","owner":{"login":"kishorvpatil","id":6090397,"avatar_url":"https://avatars2.githubusercontent.com/u/6090397?v=4","gravatar_id":"","url":"https://api.github.com/users/kishorvpatil","html_url":"https://github.com/kishorvpatil","followers_url":"https://api.github.com/users/kishorvpatil/followers","following_url":"https://api.github.com/users/kishorvpatil/following{/other_user}","gists_url":"https://api.github.com/users/kishorvpatil/gists{/gist_id}","starred_url":"https://api.github.com/users/kishorvpatil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kishorvpatil/subscriptions","organizations_url":"https://api.github.com/users/kishorvpatil/orgs","repos_url":"https://api.github.com/users/kishorvpatil/repos","events_url":"https://api.github.com/users/kishorvpatil/events{/privacy}","received_events_url":"https://api.github.com/users/kishorvpatil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kishorvpatil/incubator-storm","description":"Mirror of Apache Storm","fork":true,"url":"https://api.github.com/repos/kishorvpatil/incubator-storm","forks_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/forks","keys_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/teams","hooks_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/hooks","issue_events_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/issues/events{/number}","events_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/events","assignees_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/assignees{/user}","branches_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/branches{/branch}","tags_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/tags","blobs_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/statuses/{sha}","languages_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/languages","stargazers_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/stargazers","contributors_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/contributors","subscribers_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/subscribers","subscription_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/subscription","commits_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/contents/{+path}","compare_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/merges","archive_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/downloads","issues_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/issues{/number}","pulls_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/pulls{/number}","milestones_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/milestones{/number}","notifications_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/labels{/name}","releases_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/releases{/id}","deployments_url":"https://api.github.com/repos/kishorvpatil/incubator-storm/deployments","created_at":"2014-01-16T17:41:18Z","updated_at":"2018-03-22T22:57:14Z","pushed_at":"2018-04-23T06:42:31Z","git_url":"git://github.com/kishorvpatil/incubator-storm.git","ssh_url":"git@github.com:kishorvpatil/incubator-storm.git","clone_url":"https://github.com/kishorvpatil/incubator-storm.git","svn_url":"https://github.com/kishorvpatil/incubator-storm","homepage":null,"size":47648,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"b26a62fde8e903819e89d0addbd3ce53d59bf2d0","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":14135470,"name":"storm","full_name":"apache/storm","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/storm","description":"Mirror of Apache Storm","fork":false,"url":"https://api.github.com/repos/apache/storm","forks_url":"https://api.github.com/repos/apache/storm/forks","keys_url":"https://api.github.com/repos/apache/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/storm/teams","hooks_url":"https://api.github.com/repos/apache/storm/hooks","issue_events_url":"https://api.github.com/repos/apache/storm/issues/events{/number}","events_url":"https://api.github.com/repos/apache/storm/events","assignees_url":"https://api.github.com/repos/apache/storm/assignees{/user}","branches_url":"https://api.github.com/repos/apache/storm/branches{/branch}","tags_url":"https://api.github.com/repos/apache/storm/tags","blobs_url":"https://api.github.com/repos/apache/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/storm/languages","stargazers_url":"https://api.github.com/repos/apache/storm/stargazers","contributors_url":"https://api.github.com/repos/apache/storm/contributors","subscribers_url":"https://api.github.com/repos/apache/storm/subscribers","subscription_url":"https://api.github.com/repos/apache/storm/subscription","commits_url":"https://api.github.com/repos/apache/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/storm/contents/{+path}","compare_url":"https://api.github.com/repos/apache/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/storm/merges","archive_url":"https://api.github.com/repos/apache/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/storm/downloads","issues_url":"https://api.github.com/repos/apache/storm/issues{/number}","pulls_url":"https://api.github.com/repos/apache/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/storm/labels{/name}","releases_url":"https://api.github.com/repos/apache/storm/releases{/id}","deployments_url":"https://api.github.com/repos/apache/storm/deployments","created_at":"2013-11-05T08:00:14Z","updated_at":"2018-04-23T08:53:39Z","pushed_at":"2018-04-23T13:26:01Z","git_url":"git://github.com/apache/storm.git","ssh_url":"git@github.com:apache/storm.git","clone_url":"https://github.com/apache/storm.git","svn_url":"https://github.com/apache/storm","homepage":null,"size":173167,"stargazers_count":4990,"watchers_count":4990,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3575,"mirror_url":null,"archived":false,"open_issues_count":152,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3575,"open_issues":152,"watchers":4990,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/2641"},"html":{"href":"https://github.com/apache/storm/pull/2641"},"issue":{"href":"https://api.github.com/repos/apache/storm/issues/2641"},"comments":{"href":"https://api.github.com/repos/apache/storm/issues/2641/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/storm/pulls/2641/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/storm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/storm/pulls/2641/commits"},"statuses":{"href":"https://api.github.com/repos/apache/storm/statuses/e8ffac458baf6cc7a90dd0ced78cc01f0ffb4229"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Ethanlm"}}