{"action":"closed","number":22,"pull_request":{"url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/pulls/22","id":234771544,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NzcxNTQ0","html_url":"https://github.com/lifeomic/graphql-resolvers-xray-tracing/pull/22","diff_url":"https://github.com/lifeomic/graphql-resolvers-xray-tracing/pull/22.diff","patch_url":"https://github.com/lifeomic/graphql-resolvers-xray-tracing/pull/22.patch","issue_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/issues/22","number":22,"state":"closed","locked":false,"title":"Disable xray logs in integration tests","user":{"login":"IevgenRagulin","id":2522463,"node_id":"MDQ6VXNlcjI1MjI0NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/2522463?v=4","gravatar_id":"","url":"https://api.github.com/users/IevgenRagulin","html_url":"https://github.com/IevgenRagulin","followers_url":"https://api.github.com/users/IevgenRagulin/followers","following_url":"https://api.github.com/users/IevgenRagulin/following{/other_user}","gists_url":"https://api.github.com/users/IevgenRagulin/gists{/gist_id}","starred_url":"https://api.github.com/users/IevgenRagulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IevgenRagulin/subscriptions","organizations_url":"https://api.github.com/users/IevgenRagulin/orgs","repos_url":"https://api.github.com/users/IevgenRagulin/repos","events_url":"https://api.github.com/users/IevgenRagulin/events{/privacy}","received_events_url":"https://api.github.com/users/IevgenRagulin/received_events","type":"User","site_admin":false},"body":"I was also considering disabling xray logs based on process.env.ENVIRONMENT === ‘integration-test’, but I thought I would rather introduce a new variable in case some project uses a different name for their integration env, or in case some project actually wants to have x-ray logs enabled\r\n\r\nRelated review:\r\nhttps://bitbucket.org/lifeomic/koa/pull-requests/94/disable-xray-logs-in-integration-tests/diff\r\n\r\nAlso, I have accidentally pushed this to master directly, and then pushed a revert commit. Hopefully, this is not a big issue.","created_at":"2018-11-29T20:13:56Z","updated_at":"2018-11-30T21:15:32Z","closed_at":"2018-11-30T21:15:32Z","merged_at":null,"merge_commit_sha":"ec405b5452c4bf57afb09104e38674bc82d70e14","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jagoda","id":655686,"node_id":"MDQ6VXNlcjY1NTY4Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/655686?v=4","gravatar_id":"","url":"https://api.github.com/users/jagoda","html_url":"https://github.com/jagoda","followers_url":"https://api.github.com/users/jagoda/followers","following_url":"https://api.github.com/users/jagoda/following{/other_user}","gists_url":"https://api.github.com/users/jagoda/gists{/gist_id}","starred_url":"https://api.github.com/users/jagoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagoda/subscriptions","organizations_url":"https://api.github.com/users/jagoda/orgs","repos_url":"https://api.github.com/users/jagoda/repos","events_url":"https://api.github.com/users/jagoda/events{/privacy}","received_events_url":"https://api.github.com/users/jagoda/received_events","type":"User","site_admin":false},{"login":"Druotic","id":1551522,"node_id":"MDQ6VXNlcjE1NTE1MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1551522?v=4","gravatar_id":"","url":"https://api.github.com/users/Druotic","html_url":"https://github.com/Druotic","followers_url":"https://api.github.com/users/Druotic/followers","following_url":"https://api.github.com/users/Druotic/following{/other_user}","gists_url":"https://api.github.com/users/Druotic/gists{/gist_id}","starred_url":"https://api.github.com/users/Druotic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Druotic/subscriptions","organizations_url":"https://api.github.com/users/Druotic/orgs","repos_url":"https://api.github.com/users/Druotic/repos","events_url":"https://api.github.com/users/Druotic/events{/privacy}","received_events_url":"https://api.github.com/users/Druotic/received_events","type":"User","site_admin":false},{"login":"austinkelleher","id":3771924,"node_id":"MDQ6VXNlcjM3NzE5MjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3771924?v=4","gravatar_id":"","url":"https://api.github.com/users/austinkelleher","html_url":"https://github.com/austinkelleher","followers_url":"https://api.github.com/users/austinkelleher/followers","following_url":"https://api.github.com/users/austinkelleher/following{/other_user}","gists_url":"https://api.github.com/users/austinkelleher/gists{/gist_id}","starred_url":"https://api.github.com/users/austinkelleher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austinkelleher/subscriptions","organizations_url":"https://api.github.com/users/austinkelleher/orgs","repos_url":"https://api.github.com/users/austinkelleher/repos","events_url":"https://api.github.com/users/austinkelleher/events{/privacy}","received_events_url":"https://api.github.com/users/austinkelleher/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/pulls/22/commits","review_comments_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/pulls/22/comments","review_comment_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/issues/22/comments","statuses_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/statuses/d9f873b8ae7327325b711252c165b0884bbf9724","head":{"label":"lifeomic:DisableXrayLogsInIntegrationTests","ref":"DisableXrayLogsInIntegrationTests","sha":"d9f873b8ae7327325b711252c165b0884bbf9724","user":{"login":"lifeomic","id":29172293,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTcyMjkz","avatar_url":"https://avatars1.githubusercontent.com/u/29172293?v=4","gravatar_id":"","url":"https://api.github.com/users/lifeomic","html_url":"https://github.com/lifeomic","followers_url":"https://api.github.com/users/lifeomic/followers","following_url":"https://api.github.com/users/lifeomic/following{/other_user}","gists_url":"https://api.github.com/users/lifeomic/gists{/gist_id}","starred_url":"https://api.github.com/users/lifeomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lifeomic/subscriptions","organizations_url":"https://api.github.com/users/lifeomic/orgs","repos_url":"https://api.github.com/users/lifeomic/repos","events_url":"https://api.github.com/users/lifeomic/events{/privacy}","received_events_url":"https://api.github.com/users/lifeomic/received_events","type":"Organization","site_admin":false},"repo":{"id":135372439,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUzNzI0Mzk=","name":"graphql-resolvers-xray-tracing","full_name":"lifeomic/graphql-resolvers-xray-tracing","private":false,"owner":{"login":"lifeomic","id":29172293,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTcyMjkz","avatar_url":"https://avatars1.githubusercontent.com/u/29172293?v=4","gravatar_id":"","url":"https://api.github.com/users/lifeomic","html_url":"https://github.com/lifeomic","followers_url":"https://api.github.com/users/lifeomic/followers","following_url":"https://api.github.com/users/lifeomic/following{/other_user}","gists_url":"https://api.github.com/users/lifeomic/gists{/gist_id}","starred_url":"https://api.github.com/users/lifeomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lifeomic/subscriptions","organizations_url":"https://api.github.com/users/lifeomic/orgs","repos_url":"https://api.github.com/users/lifeomic/repos","events_url":"https://api.github.com/users/lifeomic/events{/privacy}","received_events_url":"https://api.github.com/users/lifeomic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lifeomic/graphql-resolvers-xray-tracing","description":"A GraphQL middleware to enable X-Ray tracing subsegments for GraphQL resolvers","fork":false,"url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing","forks_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/forks","keys_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/teams","hooks_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/hooks","issue_events_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/issues/events{/number}","events_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/events","assignees_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/assignees{/user}","branches_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/branches{/branch}","tags_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/tags","blobs_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/git/refs{/sha}","trees_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/statuses/{sha}","languages_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/languages","stargazers_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/stargazers","contributors_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/contributors","subscribers_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/subscribers","subscription_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/subscription","commits_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/commits{/sha}","git_commits_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/git/commits{/sha}","comments_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/comments{/number}","issue_comment_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/issues/comments{/number}","contents_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/contents/{+path}","compare_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/merges","archive_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/downloads","issues_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/issues{/number}","pulls_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/pulls{/number}","milestones_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/milestones{/number}","notifications_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/labels{/name}","releases_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/releases{/id}","deployments_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/deployments","created_at":"2018-05-30T01:40:07Z","updated_at":"2018-11-29T20:09:45Z","pushed_at":"2018-11-30T17:48:24Z","git_url":"git://github.com/lifeomic/graphql-resolvers-xray-tracing.git","ssh_url":"git@github.com:lifeomic/graphql-resolvers-xray-tracing.git","clone_url":"https://github.com/lifeomic/graphql-resolvers-xray-tracing.git","svn_url":"https://github.com/lifeomic/graphql-resolvers-xray-tracing","homepage":null,"size":583,"stargazers_count":15,"watchers_count":15,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":0,"watchers":15,"default_branch":"master"}},"base":{"label":"lifeomic:master","ref":"master","sha":"0f2d5ff78a105ed8953176fa82976ffcefbcc79b","user":{"login":"lifeomic","id":29172293,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTcyMjkz","avatar_url":"https://avatars1.githubusercontent.com/u/29172293?v=4","gravatar_id":"","url":"https://api.github.com/users/lifeomic","html_url":"https://github.com/lifeomic","followers_url":"https://api.github.com/users/lifeomic/followers","following_url":"https://api.github.com/users/lifeomic/following{/other_user}","gists_url":"https://api.github.com/users/lifeomic/gists{/gist_id}","starred_url":"https://api.github.com/users/lifeomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lifeomic/subscriptions","organizations_url":"https://api.github.com/users/lifeomic/orgs","repos_url":"https://api.github.com/users/lifeomic/repos","events_url":"https://api.github.com/users/lifeomic/events{/privacy}","received_events_url":"https://api.github.com/users/lifeomic/received_events","type":"Organization","site_admin":false},"repo":{"id":135372439,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUzNzI0Mzk=","name":"graphql-resolvers-xray-tracing","full_name":"lifeomic/graphql-resolvers-xray-tracing","private":false,"owner":{"login":"lifeomic","id":29172293,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTcyMjkz","avatar_url":"https://avatars1.githubusercontent.com/u/29172293?v=4","gravatar_id":"","url":"https://api.github.com/users/lifeomic","html_url":"https://github.com/lifeomic","followers_url":"https://api.github.com/users/lifeomic/followers","following_url":"https://api.github.com/users/lifeomic/following{/other_user}","gists_url":"https://api.github.com/users/lifeomic/gists{/gist_id}","starred_url":"https://api.github.com/users/lifeomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lifeomic/subscriptions","organizations_url":"https://api.github.com/users/lifeomic/orgs","repos_url":"https://api.github.com/users/lifeomic/repos","events_url":"https://api.github.com/users/lifeomic/events{/privacy}","received_events_url":"https://api.github.com/users/lifeomic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lifeomic/graphql-resolvers-xray-tracing","description":"A GraphQL middleware to enable X-Ray tracing subsegments for GraphQL resolvers","fork":false,"url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing","forks_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/forks","keys_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/teams","hooks_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/hooks","issue_events_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/issues/events{/number}","events_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/events","assignees_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/assignees{/user}","branches_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/branches{/branch}","tags_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/tags","blobs_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/git/refs{/sha}","trees_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/statuses/{sha}","languages_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/languages","stargazers_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/stargazers","contributors_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/contributors","subscribers_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/subscribers","subscription_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/subscription","commits_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/commits{/sha}","git_commits_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/git/commits{/sha}","comments_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/comments{/number}","issue_comment_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/issues/comments{/number}","contents_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/contents/{+path}","compare_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/merges","archive_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/downloads","issues_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/issues{/number}","pulls_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/pulls{/number}","milestones_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/milestones{/number}","notifications_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/labels{/name}","releases_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/releases{/id}","deployments_url":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/deployments","created_at":"2018-05-30T01:40:07Z","updated_at":"2018-11-29T20:09:45Z","pushed_at":"2018-11-30T17:48:24Z","git_url":"git://github.com/lifeomic/graphql-resolvers-xray-tracing.git","ssh_url":"git@github.com:lifeomic/graphql-resolvers-xray-tracing.git","clone_url":"https://github.com/lifeomic/graphql-resolvers-xray-tracing.git","svn_url":"https://github.com/lifeomic/graphql-resolvers-xray-tracing","homepage":null,"size":583,"stargazers_count":15,"watchers_count":15,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":0,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/pulls/22"},"html":{"href":"https://github.com/lifeomic/graphql-resolvers-xray-tracing/pull/22"},"issue":{"href":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/issues/22"},"comments":{"href":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/lifeomic/graphql-resolvers-xray-tracing/statuses/d9f873b8ae7327325b711252c165b0884bbf9724"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":4,"maintainer_can_modify":false,"commits":7,"additions":26,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"IevgenRagulin"}}