{"action":"closed","number":1689,"pull_request":{"url":"https://api.github.com/repos/dpkp/kafka-python/pulls/1689","id":242423666,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyNDIzNjY2","html_url":"https://github.com/dpkp/kafka-python/pull/1689","diff_url":"https://github.com/dpkp/kafka-python/pull/1689.diff","patch_url":"https://github.com/dpkp/kafka-python/pull/1689.patch","issue_url":"https://api.github.com/repos/dpkp/kafka-python/issues/1689","number":1689,"state":"closed","locked":false,"title":"Use Popen.communicate() instead of Popen.wait()","user":{"login":"Baisang","id":6789626,"node_id":"MDQ6VXNlcjY3ODk2MjY=","avatar_url":"https://avatars3.githubusercontent.com/u/6789626?v=4","gravatar_id":"","url":"https://api.github.com/users/Baisang","html_url":"https://github.com/Baisang","followers_url":"https://api.github.com/users/Baisang/followers","following_url":"https://api.github.com/users/Baisang/following{/other_user}","gists_url":"https://api.github.com/users/Baisang/gists{/gist_id}","starred_url":"https://api.github.com/users/Baisang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baisang/subscriptions","organizations_url":"https://api.github.com/users/Baisang/orgs","repos_url":"https://api.github.com/users/Baisang/repos","events_url":"https://api.github.com/users/Baisang/events{/privacy}","received_events_url":"https://api.github.com/users/Baisang/received_events","type":"User","site_admin":false},"body":"Popen objects may deadlock when using stdout=PIPE or stderr=PIPE\r\nwith Popen.wait(). Using Popen.communicate() avoids the issue.\r\n\r\nI ran into this issue in a fork. This code should behave the same but avoids the possibility of deadlock described here: https://docs.python.org/2/library/subprocess.html#subprocess.Popen.wait\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/dpkp/kafka-python/1689)\n<!-- Reviewable:end -->\n","created_at":"2019-01-05T06:21:13Z","updated_at":"2019-01-05T22:38:54Z","closed_at":"2019-01-05T22:38:54Z","merged_at":"2019-01-05T22:38:54Z","merge_commit_sha":"d2f9413b0311e6ec4d782cf9983f61c9f258cc7b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dpkp/kafka-python/pulls/1689/commits","review_comments_url":"https://api.github.com/repos/dpkp/kafka-python/pulls/1689/comments","review_comment_url":"https://api.github.com/repos/dpkp/kafka-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dpkp/kafka-python/issues/1689/comments","statuses_url":"https://api.github.com/repos/dpkp/kafka-python/statuses/202565d1287d4df96f6e7b4211702a1c2fc02e53","head":{"label":"Baisang:use_popen_communicate","ref":"use_popen_communicate","sha":"202565d1287d4df96f6e7b4211702a1c2fc02e53","user":{"login":"Baisang","id":6789626,"node_id":"MDQ6VXNlcjY3ODk2MjY=","avatar_url":"https://avatars3.githubusercontent.com/u/6789626?v=4","gravatar_id":"","url":"https://api.github.com/users/Baisang","html_url":"https://github.com/Baisang","followers_url":"https://api.github.com/users/Baisang/followers","following_url":"https://api.github.com/users/Baisang/following{/other_user}","gists_url":"https://api.github.com/users/Baisang/gists{/gist_id}","starred_url":"https://api.github.com/users/Baisang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baisang/subscriptions","organizations_url":"https://api.github.com/users/Baisang/orgs","repos_url":"https://api.github.com/users/Baisang/repos","events_url":"https://api.github.com/users/Baisang/events{/privacy}","received_events_url":"https://api.github.com/users/Baisang/received_events","type":"User","site_admin":false},"repo":{"id":164183719,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQxODM3MTk=","name":"kafka-python","full_name":"Baisang/kafka-python","private":false,"owner":{"login":"Baisang","id":6789626,"node_id":"MDQ6VXNlcjY3ODk2MjY=","avatar_url":"https://avatars3.githubusercontent.com/u/6789626?v=4","gravatar_id":"","url":"https://api.github.com/users/Baisang","html_url":"https://github.com/Baisang","followers_url":"https://api.github.com/users/Baisang/followers","following_url":"https://api.github.com/users/Baisang/following{/other_user}","gists_url":"https://api.github.com/users/Baisang/gists{/gist_id}","starred_url":"https://api.github.com/users/Baisang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baisang/subscriptions","organizations_url":"https://api.github.com/users/Baisang/orgs","repos_url":"https://api.github.com/users/Baisang/repos","events_url":"https://api.github.com/users/Baisang/events{/privacy}","received_events_url":"https://api.github.com/users/Baisang/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Baisang/kafka-python","description":"Python client for Apache Kafka","fork":true,"url":"https://api.github.com/repos/Baisang/kafka-python","forks_url":"https://api.github.com/repos/Baisang/kafka-python/forks","keys_url":"https://api.github.com/repos/Baisang/kafka-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Baisang/kafka-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Baisang/kafka-python/teams","hooks_url":"https://api.github.com/repos/Baisang/kafka-python/hooks","issue_events_url":"https://api.github.com/repos/Baisang/kafka-python/issues/events{/number}","events_url":"https://api.github.com/repos/Baisang/kafka-python/events","assignees_url":"https://api.github.com/repos/Baisang/kafka-python/assignees{/user}","branches_url":"https://api.github.com/repos/Baisang/kafka-python/branches{/branch}","tags_url":"https://api.github.com/repos/Baisang/kafka-python/tags","blobs_url":"https://api.github.com/repos/Baisang/kafka-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Baisang/kafka-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Baisang/kafka-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/Baisang/kafka-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Baisang/kafka-python/statuses/{sha}","languages_url":"https://api.github.com/repos/Baisang/kafka-python/languages","stargazers_url":"https://api.github.com/repos/Baisang/kafka-python/stargazers","contributors_url":"https://api.github.com/repos/Baisang/kafka-python/contributors","subscribers_url":"https://api.github.com/repos/Baisang/kafka-python/subscribers","subscription_url":"https://api.github.com/repos/Baisang/kafka-python/subscription","commits_url":"https://api.github.com/repos/Baisang/kafka-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/Baisang/kafka-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/Baisang/kafka-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/Baisang/kafka-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/Baisang/kafka-python/contents/{+path}","compare_url":"https://api.github.com/repos/Baisang/kafka-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Baisang/kafka-python/merges","archive_url":"https://api.github.com/repos/Baisang/kafka-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Baisang/kafka-python/downloads","issues_url":"https://api.github.com/repos/Baisang/kafka-python/issues{/number}","pulls_url":"https://api.github.com/repos/Baisang/kafka-python/pulls{/number}","milestones_url":"https://api.github.com/repos/Baisang/kafka-python/milestones{/number}","notifications_url":"https://api.github.com/repos/Baisang/kafka-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Baisang/kafka-python/labels{/name}","releases_url":"https://api.github.com/repos/Baisang/kafka-python/releases{/id}","deployments_url":"https://api.github.com/repos/Baisang/kafka-python/deployments","created_at":"2019-01-05T05:04:58Z","updated_at":"2019-01-05T05:05:01Z","pushed_at":"2019-01-05T06:18:04Z","git_url":"git://github.com/Baisang/kafka-python.git","ssh_url":"git@github.com:Baisang/kafka-python.git","clone_url":"https://github.com/Baisang/kafka-python.git","svn_url":"https://github.com/Baisang/kafka-python","homepage":"http://kafka-python.readthedocs.io/","size":3718,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dpkp:master","ref":"master","sha":"70ea4c1e94a0ace46d3418fb0ee503bbf8a5b91b","user":{"login":"dpkp","id":843444,"node_id":"MDQ6VXNlcjg0MzQ0NA==","avatar_url":"https://avatars1.githubusercontent.com/u/843444?v=4","gravatar_id":"","url":"https://api.github.com/users/dpkp","html_url":"https://github.com/dpkp","followers_url":"https://api.github.com/users/dpkp/followers","following_url":"https://api.github.com/users/dpkp/following{/other_user}","gists_url":"https://api.github.com/users/dpkp/gists{/gist_id}","starred_url":"https://api.github.com/users/dpkp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpkp/subscriptions","organizations_url":"https://api.github.com/users/dpkp/orgs","repos_url":"https://api.github.com/users/dpkp/repos","events_url":"https://api.github.com/users/dpkp/events{/privacy}","received_events_url":"https://api.github.com/users/dpkp/received_events","type":"User","site_admin":false},"repo":{"id":5934517,"node_id":"MDEwOlJlcG9zaXRvcnk1OTM0NTE3","name":"kafka-python","full_name":"dpkp/kafka-python","private":false,"owner":{"login":"dpkp","id":843444,"node_id":"MDQ6VXNlcjg0MzQ0NA==","avatar_url":"https://avatars1.githubusercontent.com/u/843444?v=4","gravatar_id":"","url":"https://api.github.com/users/dpkp","html_url":"https://github.com/dpkp","followers_url":"https://api.github.com/users/dpkp/followers","following_url":"https://api.github.com/users/dpkp/following{/other_user}","gists_url":"https://api.github.com/users/dpkp/gists{/gist_id}","starred_url":"https://api.github.com/users/dpkp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpkp/subscriptions","organizations_url":"https://api.github.com/users/dpkp/orgs","repos_url":"https://api.github.com/users/dpkp/repos","events_url":"https://api.github.com/users/dpkp/events{/privacy}","received_events_url":"https://api.github.com/users/dpkp/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dpkp/kafka-python","description":"Python client for Apache Kafka","fork":false,"url":"https://api.github.com/repos/dpkp/kafka-python","forks_url":"https://api.github.com/repos/dpkp/kafka-python/forks","keys_url":"https://api.github.com/repos/dpkp/kafka-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dpkp/kafka-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dpkp/kafka-python/teams","hooks_url":"https://api.github.com/repos/dpkp/kafka-python/hooks","issue_events_url":"https://api.github.com/repos/dpkp/kafka-python/issues/events{/number}","events_url":"https://api.github.com/repos/dpkp/kafka-python/events","assignees_url":"https://api.github.com/repos/dpkp/kafka-python/assignees{/user}","branches_url":"https://api.github.com/repos/dpkp/kafka-python/branches{/branch}","tags_url":"https://api.github.com/repos/dpkp/kafka-python/tags","blobs_url":"https://api.github.com/repos/dpkp/kafka-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dpkp/kafka-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dpkp/kafka-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/dpkp/kafka-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dpkp/kafka-python/statuses/{sha}","languages_url":"https://api.github.com/repos/dpkp/kafka-python/languages","stargazers_url":"https://api.github.com/repos/dpkp/kafka-python/stargazers","contributors_url":"https://api.github.com/repos/dpkp/kafka-python/contributors","subscribers_url":"https://api.github.com/repos/dpkp/kafka-python/subscribers","subscription_url":"https://api.github.com/repos/dpkp/kafka-python/subscription","commits_url":"https://api.github.com/repos/dpkp/kafka-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/dpkp/kafka-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/dpkp/kafka-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/dpkp/kafka-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/dpkp/kafka-python/contents/{+path}","compare_url":"https://api.github.com/repos/dpkp/kafka-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dpkp/kafka-python/merges","archive_url":"https://api.github.com/repos/dpkp/kafka-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dpkp/kafka-python/downloads","issues_url":"https://api.github.com/repos/dpkp/kafka-python/issues{/number}","pulls_url":"https://api.github.com/repos/dpkp/kafka-python/pulls{/number}","milestones_url":"https://api.github.com/repos/dpkp/kafka-python/milestones{/number}","notifications_url":"https://api.github.com/repos/dpkp/kafka-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dpkp/kafka-python/labels{/name}","releases_url":"https://api.github.com/repos/dpkp/kafka-python/releases{/id}","deployments_url":"https://api.github.com/repos/dpkp/kafka-python/deployments","created_at":"2012-09-24T13:00:26Z","updated_at":"2019-01-05T09:43:00Z","pushed_at":"2019-01-05T22:38:54Z","git_url":"git://github.com/dpkp/kafka-python.git","ssh_url":"git@github.com:dpkp/kafka-python.git","clone_url":"https://github.com/dpkp/kafka-python.git","svn_url":"https://github.com/dpkp/kafka-python","homepage":"http://kafka-python.readthedocs.io/","size":3868,"stargazers_count":2708,"watchers_count":2708,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":819,"mirror_url":null,"archived":false,"open_issues_count":144,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":819,"open_issues":144,"watchers":2708,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dpkp/kafka-python/pulls/1689"},"html":{"href":"https://github.com/dpkp/kafka-python/pull/1689"},"issue":{"href":"https://api.github.com/repos/dpkp/kafka-python/issues/1689"},"comments":{"href":"https://api.github.com/repos/dpkp/kafka-python/issues/1689/comments"},"review_comments":{"href":"https://api.github.com/repos/dpkp/kafka-python/pulls/1689/comments"},"review_comment":{"href":"https://api.github.com/repos/dpkp/kafka-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dpkp/kafka-python/pulls/1689/commits"},"statuses":{"href":"https://api.github.com/repos/dpkp/kafka-python/statuses/202565d1287d4df96f6e7b4211702a1c2fc02e53"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jeffwidman","id":483314,"node_id":"MDQ6VXNlcjQ4MzMxNA==","avatar_url":"https://avatars2.githubusercontent.com/u/483314?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffwidman","html_url":"https://github.com/jeffwidman","followers_url":"https://api.github.com/users/jeffwidman/followers","following_url":"https://api.github.com/users/jeffwidman/following{/other_user}","gists_url":"https://api.github.com/users/jeffwidman/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffwidman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffwidman/subscriptions","organizations_url":"https://api.github.com/users/jeffwidman/orgs","repos_url":"https://api.github.com/users/jeffwidman/repos","events_url":"https://api.github.com/users/jeffwidman/events{/privacy}","received_events_url":"https://api.github.com/users/jeffwidman/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":10,"deletions":9,"changed_files":1}}
{"actor":{"display_login":"jeffwidman"}}