{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59861","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59861/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59861/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59861/events","html_url":"https://github.com/kubernetes/kubernetes/pull/59861","id":297019731,"number":59861,"title":"avoid race condition in device manager startup/shutdown","user":{"login":"pohly","id":22076,"avatar_url":"https://avatars1.githubusercontent.com/u/22076?v=4","gravatar_id":"","url":"https://api.github.com/users/pohly","html_url":"https://github.com/pohly","followers_url":"https://api.github.com/users/pohly/followers","following_url":"https://api.github.com/users/pohly/following{/other_user}","gists_url":"https://api.github.com/users/pohly/gists{/gist_id}","starred_url":"https://api.github.com/users/pohly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pohly/subscriptions","organizations_url":"https://api.github.com/users/pohly/orgs","repos_url":"https://api.github.com/users/pohly/repos","events_url":"https://api.github.com/users/pohly/events{/privacy}","received_events_url":"https://api.github.com/users/pohly/received_events","type":"User","site_admin":false},"labels":[{"id":644163893,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/hw-accelerators","name":"area/hw-accelerators","color":"0052cc","default":false},{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":173493665,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/node","name":"sig/node","color":"d2b48c","default":false},{"id":253450895,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/S","name":"size/S","color":"77bb00","default":false}],"state":"open","locked":false,"assignee":{"login":"vikaschoudhary16","id":11936386,"avatar_url":"https://avatars3.githubusercontent.com/u/11936386?v=4","gravatar_id":"","url":"https://api.github.com/users/vikaschoudhary16","html_url":"https://github.com/vikaschoudhary16","followers_url":"https://api.github.com/users/vikaschoudhary16/followers","following_url":"https://api.github.com/users/vikaschoudhary16/following{/other_user}","gists_url":"https://api.github.com/users/vikaschoudhary16/gists{/gist_id}","starred_url":"https://api.github.com/users/vikaschoudhary16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikaschoudhary16/subscriptions","organizations_url":"https://api.github.com/users/vikaschoudhary16/orgs","repos_url":"https://api.github.com/users/vikaschoudhary16/repos","events_url":"https://api.github.com/users/vikaschoudhary16/events{/privacy}","received_events_url":"https://api.github.com/users/vikaschoudhary16/received_events","type":"User","site_admin":false},"assignees":[{"login":"vikaschoudhary16","id":11936386,"avatar_url":"https://avatars3.githubusercontent.com/u/11936386?v=4","gravatar_id":"","url":"https://api.github.com/users/vikaschoudhary16","html_url":"https://github.com/vikaschoudhary16","followers_url":"https://api.github.com/users/vikaschoudhary16/followers","following_url":"https://api.github.com/users/vikaschoudhary16/following{/other_user}","gists_url":"https://api.github.com/users/vikaschoudhary16/gists{/gist_id}","starred_url":"https://api.github.com/users/vikaschoudhary16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikaschoudhary16/subscriptions","organizations_url":"https://api.github.com/users/vikaschoudhary16/orgs","repos_url":"https://api.github.com/users/vikaschoudhary16/repos","events_url":"https://api.github.com/users/vikaschoudhary16/events{/privacy}","received_events_url":"https://api.github.com/users/vikaschoudhary16/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2018-02-14T09:04:17Z","updated_at":"2018-02-15T10:25:36Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59861","html_url":"https://github.com/kubernetes/kubernetes/pull/59861","diff_url":"https://github.com/kubernetes/kubernetes/pull/59861.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/59861.patch"},"body":"A flaky test exposed a race condition where shutting down one server\r\ninstance broke the startup of the next instance when using the same\r\nsocket path. Commit 1325c2f8bec removed the reuse of the same socket\r\npath and thus avoided the issue.\r\n\r\nBut the real fix is to ensure that the listening socket is really\r\nclosed once ManagerImpl.Stop returns. Two solutions were proposed in\r\nhttps://github.com/grpc/grpc-go/issues/1861:\r\n- waiting for the goroutine to complete\r\n- closing the socket\r\n\r\nThe latter is used because it is easier to implement and less\r\nintrusive. That leaves the goroutine running, but because\r\nserver.Stop() was called it should terminate soon and now without side\r\neffects.\r\n\r\nProperly fixes https://github.com/kubernetes/kubernetes/issues/59488\r\n\r\n/sig node\r\n/area hw-accelerators\r\n/release-note-none\r\n/assign vikaschoudhary16\r\n\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/365885133","html_url":"https://github.com/kubernetes/kubernetes/pull/59861#issuecomment-365885133","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59861","id":365885133,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-02-15T10:25:36Z","updated_at":"2018-02-15T10:25:36Z","author_association":"COLLABORATOR","body":"[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/59861#\" title=\"Author self-approved\">pohly</a>*\nTo fully approve this pull request, please assign additional approvers.\nWe suggest the following additional approver: **jiayingz**\n\nAssign the PR to them by writing `/assign @jiayingz` in a comment when ready.\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/kubelet/cm/devicemanager/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/cm/devicemanager/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"jiayingz\"]} -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}