{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/solidity/pulls/comments/172622173","pull_request_review_id":101671155,"id":172622173,"diff_hunk":"@@ -682,6 +682,116 @@ BOOST_AUTO_TEST_CASE(dev_documenting_no_param_description)\n \texpectNatspecError(sourceCode);\n }\n \n+BOOST_AUTO_TEST_CASE(user_constructor)\n+{\n+\tchar const *sourceCode = R\"(\n+\t\tcontract test {\n+\t\t\t/// @notice this is a really nice constructor\n+\t\t\tfunction test(uint a, uint second) { }\n+\t\t}\n+\t)\";\n+\n+\tchar const *natspec = R\"ABCDEF({","path":"test/libsolidity/SolidityNatspecJSON.cpp","position":13,"original_position":13,"commit_id":"f80b5559c33b577500a6438429d01369fb502fe4","original_commit_id":"f80b5559c33b577500a6438429d01369fb502fe4","user":{"login":"axic","id":20340,"avatar_url":"https://avatars3.githubusercontent.com/u/20340?v=4","gravatar_id":"","url":"https://api.github.com/users/axic","html_url":"https://github.com/axic","followers_url":"https://api.github.com/users/axic/followers","following_url":"https://api.github.com/users/axic/following{/other_user}","gists_url":"https://api.github.com/users/axic/gists{/gist_id}","starred_url":"https://api.github.com/users/axic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axic/subscriptions","organizations_url":"https://api.github.com/users/axic/orgs","repos_url":"https://api.github.com/users/axic/repos","events_url":"https://api.github.com/users/axic/events{/privacy}","received_events_url":"https://api.github.com/users/axic/received_events","type":"User","site_admin":false},"body":"What is the `ABCDEF` doing here?","created_at":"2018-03-06T18:54:24Z","updated_at":"2018-03-06T18:54:24Z","html_url":"https://github.com/ethereum/solidity/pull/3666#discussion_r172622173","pull_request_url":"https://api.github.com/repos/ethereum/solidity/pulls/3666","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/comments/172622173"},"html":{"href":"https://github.com/ethereum/solidity/pull/3666#discussion_r172622173"},"pull_request":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/3666"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/solidity/pulls/3666","id":173243423,"html_url":"https://github.com/ethereum/solidity/pull/3666","diff_url":"https://github.com/ethereum/solidity/pull/3666.diff","patch_url":"https://github.com/ethereum/solidity/pull/3666.patch","issue_url":"https://api.github.com/repos/ethereum/solidity/issues/3666","number":3666,"state":"open","locked":false,"title":"Fix: natspec annotations on constructors","user":{"login":"aarlt","id":5008794,"avatar_url":"https://avatars2.githubusercontent.com/u/5008794?v=4","gravatar_id":"","url":"https://api.github.com/users/aarlt","html_url":"https://github.com/aarlt","followers_url":"https://api.github.com/users/aarlt/followers","following_url":"https://api.github.com/users/aarlt/following{/other_user}","gists_url":"https://api.github.com/users/aarlt/gists{/gist_id}","starred_url":"https://api.github.com/users/aarlt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aarlt/subscriptions","organizations_url":"https://api.github.com/users/aarlt/orgs","repos_url":"https://api.github.com/users/aarlt/repos","events_url":"https://api.github.com/users/aarlt/events{/privacy}","received_events_url":"https://api.github.com/users/aarlt/received_events","type":"User","site_admin":false},"body":"- natspec annotations on constructore where ignored.","created_at":"2018-03-06T18:30:24Z","updated_at":"2018-03-06T18:54:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"783e0fa2a63c25a29942fe79460c565acddae6c2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/solidity/pulls/3666/commits","review_comments_url":"https://api.github.com/repos/ethereum/solidity/pulls/3666/comments","review_comment_url":"https://api.github.com/repos/ethereum/solidity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/solidity/issues/3666/comments","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/f80b5559c33b577500a6438429d01369fb502fe4","head":{"label":"aarlt:constructor_natspec","ref":"constructor_natspec","sha":"f80b5559c33b577500a6438429d01369fb502fe4","user":{"login":"aarlt","id":5008794,"avatar_url":"https://avatars2.githubusercontent.com/u/5008794?v=4","gravatar_id":"","url":"https://api.github.com/users/aarlt","html_url":"https://github.com/aarlt","followers_url":"https://api.github.com/users/aarlt/followers","following_url":"https://api.github.com/users/aarlt/following{/other_user}","gists_url":"https://api.github.com/users/aarlt/gists{/gist_id}","starred_url":"https://api.github.com/users/aarlt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aarlt/subscriptions","organizations_url":"https://api.github.com/users/aarlt/orgs","repos_url":"https://api.github.com/users/aarlt/repos","events_url":"https://api.github.com/users/aarlt/events{/privacy}","received_events_url":"https://api.github.com/users/aarlt/received_events","type":"User","site_admin":false},"repo":{"id":120362575,"name":"solidity","full_name":"aarlt/solidity","owner":{"login":"aarlt","id":5008794,"avatar_url":"https://avatars2.githubusercontent.com/u/5008794?v=4","gravatar_id":"","url":"https://api.github.com/users/aarlt","html_url":"https://github.com/aarlt","followers_url":"https://api.github.com/users/aarlt/followers","following_url":"https://api.github.com/users/aarlt/following{/other_user}","gists_url":"https://api.github.com/users/aarlt/gists{/gist_id}","starred_url":"https://api.github.com/users/aarlt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aarlt/subscriptions","organizations_url":"https://api.github.com/users/aarlt/orgs","repos_url":"https://api.github.com/users/aarlt/repos","events_url":"https://api.github.com/users/aarlt/events{/privacy}","received_events_url":"https://api.github.com/users/aarlt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aarlt/solidity","description":"The Solidity Contract-Oriented Programming Language","fork":true,"url":"https://api.github.com/repos/aarlt/solidity","forks_url":"https://api.github.com/repos/aarlt/solidity/forks","keys_url":"https://api.github.com/repos/aarlt/solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aarlt/solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aarlt/solidity/teams","hooks_url":"https://api.github.com/repos/aarlt/solidity/hooks","issue_events_url":"https://api.github.com/repos/aarlt/solidity/issues/events{/number}","events_url":"https://api.github.com/repos/aarlt/solidity/events","assignees_url":"https://api.github.com/repos/aarlt/solidity/assignees{/user}","branches_url":"https://api.github.com/repos/aarlt/solidity/branches{/branch}","tags_url":"https://api.github.com/repos/aarlt/solidity/tags","blobs_url":"https://api.github.com/repos/aarlt/solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aarlt/solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aarlt/solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/aarlt/solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aarlt/solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/aarlt/solidity/languages","stargazers_url":"https://api.github.com/repos/aarlt/solidity/stargazers","contributors_url":"https://api.github.com/repos/aarlt/solidity/contributors","subscribers_url":"https://api.github.com/repos/aarlt/solidity/subscribers","subscription_url":"https://api.github.com/repos/aarlt/solidity/subscription","commits_url":"https://api.github.com/repos/aarlt/solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/aarlt/solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/aarlt/solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/aarlt/solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/aarlt/solidity/contents/{+path}","compare_url":"https://api.github.com/repos/aarlt/solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aarlt/solidity/merges","archive_url":"https://api.github.com/repos/aarlt/solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aarlt/solidity/downloads","issues_url":"https://api.github.com/repos/aarlt/solidity/issues{/number}","pulls_url":"https://api.github.com/repos/aarlt/solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/aarlt/solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/aarlt/solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aarlt/solidity/labels{/name}","releases_url":"https://api.github.com/repos/aarlt/solidity/releases{/id}","deployments_url":"https://api.github.com/repos/aarlt/solidity/deployments","created_at":"2018-02-05T21:12:47Z","updated_at":"2018-02-05T21:12:50Z","pushed_at":"2018-03-06T18:29:09Z","git_url":"git://github.com/aarlt/solidity.git","ssh_url":"git@github.com:aarlt/solidity.git","clone_url":"https://github.com/aarlt/solidity.git","svn_url":"https://github.com/aarlt/solidity","homepage":"","size":17858,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"ba8819542fa2e4f0079323e6fefd0ba6ee9ea916","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":40892817,"name":"solidity","full_name":"ethereum/solidity","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/solidity","description":"The Solidity Contract-Oriented Programming Language","fork":false,"url":"https://api.github.com/repos/ethereum/solidity","forks_url":"https://api.github.com/repos/ethereum/solidity/forks","keys_url":"https://api.github.com/repos/ethereum/solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/solidity/teams","hooks_url":"https://api.github.com/repos/ethereum/solidity/hooks","issue_events_url":"https://api.github.com/repos/ethereum/solidity/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/solidity/events","assignees_url":"https://api.github.com/repos/ethereum/solidity/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/solidity/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/solidity/tags","blobs_url":"https://api.github.com/repos/ethereum/solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/solidity/languages","stargazers_url":"https://api.github.com/repos/ethereum/solidity/stargazers","contributors_url":"https://api.github.com/repos/ethereum/solidity/contributors","subscribers_url":"https://api.github.com/repos/ethereum/solidity/subscribers","subscription_url":"https://api.github.com/repos/ethereum/solidity/subscription","commits_url":"https://api.github.com/repos/ethereum/solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/solidity/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/solidity/merges","archive_url":"https://api.github.com/repos/ethereum/solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/solidity/downloads","issues_url":"https://api.github.com/repos/ethereum/solidity/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/solidity/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/solidity/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/solidity/deployments","created_at":"2015-08-17T12:27:26Z","updated_at":"2018-03-06T17:04:37Z","pushed_at":"2018-03-06T18:39:54Z","git_url":"git://github.com/ethereum/solidity.git","ssh_url":"git@github.com:ethereum/solidity.git","clone_url":"https://github.com/ethereum/solidity.git","svn_url":"https://github.com/ethereum/solidity","homepage":"","size":17861,"stargazers_count":3879,"watchers_count":3879,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1041,"mirror_url":null,"archived":false,"open_issues_count":521,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":1041,"open_issues":521,"watchers":3879,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/3666"},"html":{"href":"https://github.com/ethereum/solidity/pull/3666"},"issue":{"href":"https://api.github.com/repos/ethereum/solidity/issues/3666"},"comments":{"href":"https://api.github.com/repos/ethereum/solidity/issues/3666/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/3666/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/3666/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/solidity/statuses/f80b5559c33b577500a6438429d01369fb502fe4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"axic"}}