{"action":"created","comment":{"url":"https://api.github.com/repos/payara/cargotracker/pulls/comments/168154370","pull_request_review_id":96473515,"id":168154370,"diff_hunk":"@@ -111,19 +111,19 @@\n         <dependency>\r\n             <groupId>org.seleniumhq.selenium</groupId>\r\n             <artifactId>selenium-server</artifactId>\r\n-            <version>3.4.0</version>\r\n+            <version>3.9.1</version>\r","path":"pom.xml","position":5,"original_position":5,"commit_id":"ae9b25f8121a4419d55f3009ad77b77c0ab8c97e","original_commit_id":"ae9b25f8121a4419d55f3009ad77b77c0ab8c97e","user":{"login":"MattGill98","id":12214116,"avatar_url":"https://avatars3.githubusercontent.com/u/12214116?v=4","gravatar_id":"","url":"https://api.github.com/users/MattGill98","html_url":"https://github.com/MattGill98","followers_url":"https://api.github.com/users/MattGill98/followers","following_url":"https://api.github.com/users/MattGill98/following{/other_user}","gists_url":"https://api.github.com/users/MattGill98/gists{/gist_id}","starred_url":"https://api.github.com/users/MattGill98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattGill98/subscriptions","organizations_url":"https://api.github.com/users/MattGill98/orgs","repos_url":"https://api.github.com/users/MattGill98/repos","events_url":"https://api.github.com/users/MattGill98/events{/privacy}","received_events_url":"https://api.github.com/users/MattGill98/received_events","type":"User","site_admin":false},"body":"I can switch the JDK version back to JDK 7, but annoyingly the maven dependency updates are necessary since they were causing failures","created_at":"2018-02-14T12:05:27Z","updated_at":"2018-02-14T12:05:27Z","html_url":"https://github.com/payara/cargotracker/pull/5#discussion_r168154370","pull_request_url":"https://api.github.com/repos/payara/cargotracker/pulls/5","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/payara/cargotracker/pulls/comments/168154370"},"html":{"href":"https://github.com/payara/cargotracker/pull/5#discussion_r168154370"},"pull_request":{"href":"https://api.github.com/repos/payara/cargotracker/pulls/5"}},"in_reply_to_id":168152479},"pull_request":{"url":"https://api.github.com/repos/payara/cargotracker/pulls/5","id":169086739,"html_url":"https://github.com/payara/cargotracker/pull/5","diff_url":"https://github.com/payara/cargotracker/pull/5.diff","patch_url":"https://github.com/payara/cargotracker/pull/5.patch","issue_url":"https://api.github.com/repos/payara/cargotracker/issues/5","number":5,"state":"open","locked":false,"title":"PAYARA-2185 Embedded Tests Dont Test Embedded","user":{"login":"MattGill98","id":12214116,"avatar_url":"https://avatars3.githubusercontent.com/u/12214116?v=4","gravatar_id":"","url":"https://api.github.com/users/MattGill98","html_url":"https://github.com/MattGill98","followers_url":"https://api.github.com/users/MattGill98/followers","following_url":"https://api.github.com/users/MattGill98/following{/other_user}","gists_url":"https://api.github.com/users/MattGill98/gists{/gist_id}","starred_url":"https://api.github.com/users/MattGill98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattGill98/subscriptions","organizations_url":"https://api.github.com/users/MattGill98/orgs","repos_url":"https://api.github.com/users/MattGill98/repos","events_url":"https://api.github.com/users/MattGill98/events{/privacy}","received_events_url":"https://api.github.com/users/MattGill98/received_events","type":"User","site_admin":false},"body":"- Updated gitignore.\r\n- Updated test dependencies.\r\n- Made embedded profile test Payara Embedded.\r\n- Made embedded web profile test Payara Web Profile Embedded.\r\n- Fixed classloading issues in profile.\r\n- Made consistently failing test more flexible.\r\n- Updated source to Java 8.\r\n- Removed weblogic and glassfish related profiles.\r\n- Fixed JSF bug in embedded test.\r\n\r\nI've attached logs for both of the new builds. Note that the embedded web profile fails, but I think it's an actual web profile embedded bug, and therefore unrelated to this PR. Also note that for some reason updating the payara arquillian container from `org.omnifaces` causes the main profile to spew errors out, although the test still passes. Again I think this is due to an unrelated issue.\r\n[cargo-tracker-payara-embedded-web.log](https://github.com/payara/cargotracker/files/1723763/cargo-tracker-payara-embedded-web.log)\r\n[cargo-tracker-payara-embedded.log](https://github.com/payara/cargotracker/files/1723764/cargo-tracker-payara-embedded.log)\r\n\r\n","created_at":"2018-02-14T11:36:49Z","updated_at":"2018-02-14T12:05:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb7f1d5736498136523169f98edd690dd1845df2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/payara/cargotracker/pulls/5/commits","review_comments_url":"https://api.github.com/repos/payara/cargotracker/pulls/5/comments","review_comment_url":"https://api.github.com/repos/payara/cargotracker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/payara/cargotracker/issues/5/comments","statuses_url":"https://api.github.com/repos/payara/cargotracker/statuses/ae9b25f8121a4419d55f3009ad77b77c0ab8c97e","head":{"label":"MattGill98:PAYARA-2185-Embedded-Tests-Dont-Test-Embedded","ref":"PAYARA-2185-Embedded-Tests-Dont-Test-Embedded","sha":"ae9b25f8121a4419d55f3009ad77b77c0ab8c97e","user":{"login":"MattGill98","id":12214116,"avatar_url":"https://avatars3.githubusercontent.com/u/12214116?v=4","gravatar_id":"","url":"https://api.github.com/users/MattGill98","html_url":"https://github.com/MattGill98","followers_url":"https://api.github.com/users/MattGill98/followers","following_url":"https://api.github.com/users/MattGill98/following{/other_user}","gists_url":"https://api.github.com/users/MattGill98/gists{/gist_id}","starred_url":"https://api.github.com/users/MattGill98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattGill98/subscriptions","organizations_url":"https://api.github.com/users/MattGill98/orgs","repos_url":"https://api.github.com/users/MattGill98/repos","events_url":"https://api.github.com/users/MattGill98/events{/privacy}","received_events_url":"https://api.github.com/users/MattGill98/received_events","type":"User","site_admin":false},"repo":{"id":121503316,"name":"cargotracker","full_name":"MattGill98/cargotracker","owner":{"login":"MattGill98","id":12214116,"avatar_url":"https://avatars3.githubusercontent.com/u/12214116?v=4","gravatar_id":"","url":"https://api.github.com/users/MattGill98","html_url":"https://github.com/MattGill98","followers_url":"https://api.github.com/users/MattGill98/followers","following_url":"https://api.github.com/users/MattGill98/following{/other_user}","gists_url":"https://api.github.com/users/MattGill98/gists{/gist_id}","starred_url":"https://api.github.com/users/MattGill98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattGill98/subscriptions","organizations_url":"https://api.github.com/users/MattGill98/orgs","repos_url":"https://api.github.com/users/MattGill98/repos","events_url":"https://api.github.com/users/MattGill98/events{/privacy}","received_events_url":"https://api.github.com/users/MattGill98/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MattGill98/cargotracker","description":"Applied domain-driven design blueprints for Java EE","fork":true,"url":"https://api.github.com/repos/MattGill98/cargotracker","forks_url":"https://api.github.com/repos/MattGill98/cargotracker/forks","keys_url":"https://api.github.com/repos/MattGill98/cargotracker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MattGill98/cargotracker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MattGill98/cargotracker/teams","hooks_url":"https://api.github.com/repos/MattGill98/cargotracker/hooks","issue_events_url":"https://api.github.com/repos/MattGill98/cargotracker/issues/events{/number}","events_url":"https://api.github.com/repos/MattGill98/cargotracker/events","assignees_url":"https://api.github.com/repos/MattGill98/cargotracker/assignees{/user}","branches_url":"https://api.github.com/repos/MattGill98/cargotracker/branches{/branch}","tags_url":"https://api.github.com/repos/MattGill98/cargotracker/tags","blobs_url":"https://api.github.com/repos/MattGill98/cargotracker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MattGill98/cargotracker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MattGill98/cargotracker/git/refs{/sha}","trees_url":"https://api.github.com/repos/MattGill98/cargotracker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MattGill98/cargotracker/statuses/{sha}","languages_url":"https://api.github.com/repos/MattGill98/cargotracker/languages","stargazers_url":"https://api.github.com/repos/MattGill98/cargotracker/stargazers","contributors_url":"https://api.github.com/repos/MattGill98/cargotracker/contributors","subscribers_url":"https://api.github.com/repos/MattGill98/cargotracker/subscribers","subscription_url":"https://api.github.com/repos/MattGill98/cargotracker/subscription","commits_url":"https://api.github.com/repos/MattGill98/cargotracker/commits{/sha}","git_commits_url":"https://api.github.com/repos/MattGill98/cargotracker/git/commits{/sha}","comments_url":"https://api.github.com/repos/MattGill98/cargotracker/comments{/number}","issue_comment_url":"https://api.github.com/repos/MattGill98/cargotracker/issues/comments{/number}","contents_url":"https://api.github.com/repos/MattGill98/cargotracker/contents/{+path}","compare_url":"https://api.github.com/repos/MattGill98/cargotracker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MattGill98/cargotracker/merges","archive_url":"https://api.github.com/repos/MattGill98/cargotracker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MattGill98/cargotracker/downloads","issues_url":"https://api.github.com/repos/MattGill98/cargotracker/issues{/number}","pulls_url":"https://api.github.com/repos/MattGill98/cargotracker/pulls{/number}","milestones_url":"https://api.github.com/repos/MattGill98/cargotracker/milestones{/number}","notifications_url":"https://api.github.com/repos/MattGill98/cargotracker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MattGill98/cargotracker/labels{/name}","releases_url":"https://api.github.com/repos/MattGill98/cargotracker/releases{/id}","deployments_url":"https://api.github.com/repos/MattGill98/cargotracker/deployments","created_at":"2018-02-14T11:29:45Z","updated_at":"2018-02-14T11:29:47Z","pushed_at":"2018-02-14T11:31:24Z","git_url":"git://github.com/MattGill98/cargotracker.git","ssh_url":"git@github.com:MattGill98/cargotracker.git","clone_url":"https://github.com/MattGill98/cargotracker.git","svn_url":"https://github.com/MattGill98/cargotracker","homepage":"","size":8799,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"payara:master","ref":"master","sha":"46509072b2695967a921d1af579a686c7b35b52d","user":{"login":"payara","id":7817189,"avatar_url":"https://avatars2.githubusercontent.com/u/7817189?v=4","gravatar_id":"","url":"https://api.github.com/users/payara","html_url":"https://github.com/payara","followers_url":"https://api.github.com/users/payara/followers","following_url":"https://api.github.com/users/payara/following{/other_user}","gists_url":"https://api.github.com/users/payara/gists{/gist_id}","starred_url":"https://api.github.com/users/payara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/payara/subscriptions","organizations_url":"https://api.github.com/users/payara/orgs","repos_url":"https://api.github.com/users/payara/repos","events_url":"https://api.github.com/users/payara/events{/privacy}","received_events_url":"https://api.github.com/users/payara/received_events","type":"Organization","site_admin":false},"repo":{"id":95234129,"name":"cargotracker","full_name":"payara/cargotracker","owner":{"login":"payara","id":7817189,"avatar_url":"https://avatars2.githubusercontent.com/u/7817189?v=4","gravatar_id":"","url":"https://api.github.com/users/payara","html_url":"https://github.com/payara","followers_url":"https://api.github.com/users/payara/followers","following_url":"https://api.github.com/users/payara/following{/other_user}","gists_url":"https://api.github.com/users/payara/gists{/gist_id}","starred_url":"https://api.github.com/users/payara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/payara/subscriptions","organizations_url":"https://api.github.com/users/payara/orgs","repos_url":"https://api.github.com/users/payara/repos","events_url":"https://api.github.com/users/payara/events{/privacy}","received_events_url":"https://api.github.com/users/payara/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/payara/cargotracker","description":"Applied domain-driven design blueprints for Java EE","fork":true,"url":"https://api.github.com/repos/payara/cargotracker","forks_url":"https://api.github.com/repos/payara/cargotracker/forks","keys_url":"https://api.github.com/repos/payara/cargotracker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/payara/cargotracker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/payara/cargotracker/teams","hooks_url":"https://api.github.com/repos/payara/cargotracker/hooks","issue_events_url":"https://api.github.com/repos/payara/cargotracker/issues/events{/number}","events_url":"https://api.github.com/repos/payara/cargotracker/events","assignees_url":"https://api.github.com/repos/payara/cargotracker/assignees{/user}","branches_url":"https://api.github.com/repos/payara/cargotracker/branches{/branch}","tags_url":"https://api.github.com/repos/payara/cargotracker/tags","blobs_url":"https://api.github.com/repos/payara/cargotracker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/payara/cargotracker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/payara/cargotracker/git/refs{/sha}","trees_url":"https://api.github.com/repos/payara/cargotracker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/payara/cargotracker/statuses/{sha}","languages_url":"https://api.github.com/repos/payara/cargotracker/languages","stargazers_url":"https://api.github.com/repos/payara/cargotracker/stargazers","contributors_url":"https://api.github.com/repos/payara/cargotracker/contributors","subscribers_url":"https://api.github.com/repos/payara/cargotracker/subscribers","subscription_url":"https://api.github.com/repos/payara/cargotracker/subscription","commits_url":"https://api.github.com/repos/payara/cargotracker/commits{/sha}","git_commits_url":"https://api.github.com/repos/payara/cargotracker/git/commits{/sha}","comments_url":"https://api.github.com/repos/payara/cargotracker/comments{/number}","issue_comment_url":"https://api.github.com/repos/payara/cargotracker/issues/comments{/number}","contents_url":"https://api.github.com/repos/payara/cargotracker/contents/{+path}","compare_url":"https://api.github.com/repos/payara/cargotracker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/payara/cargotracker/merges","archive_url":"https://api.github.com/repos/payara/cargotracker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/payara/cargotracker/downloads","issues_url":"https://api.github.com/repos/payara/cargotracker/issues{/number}","pulls_url":"https://api.github.com/repos/payara/cargotracker/pulls{/number}","milestones_url":"https://api.github.com/repos/payara/cargotracker/milestones{/number}","notifications_url":"https://api.github.com/repos/payara/cargotracker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/payara/cargotracker/labels{/name}","releases_url":"https://api.github.com/repos/payara/cargotracker/releases{/id}","deployments_url":"https://api.github.com/repos/payara/cargotracker/deployments","created_at":"2017-06-23T15:47:00Z","updated_at":"2017-06-29T15:59:37Z","pushed_at":"2018-02-14T11:36:50Z","git_url":"git://github.com/payara/cargotracker.git","ssh_url":"git@github.com:payara/cargotracker.git","clone_url":"https://github.com/payara/cargotracker.git","svn_url":"https://github.com/payara/cargotracker","homepage":"","size":8799,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/payara/cargotracker/pulls/5"},"html":{"href":"https://github.com/payara/cargotracker/pull/5"},"issue":{"href":"https://api.github.com/repos/payara/cargotracker/issues/5"},"comments":{"href":"https://api.github.com/repos/payara/cargotracker/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/payara/cargotracker/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/payara/cargotracker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/payara/cargotracker/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/payara/cargotracker/statuses/ae9b25f8121a4419d55f3009ad77b77c0ab8c97e"}},"author_association":"NONE"}}
{"actor":{"display_login":"MattGill98"}}