{"action":"created","comment":{"url":"https://api.github.com/repos/mckern/puppet-agent/pulls/comments/173264246","pull_request_review_id":102419184,"id":173264246,"diff_hunk":"@@ -45,13 +45,26 @@\n   elsif platform.name =~ /solaris-10/\n     pkg.build_requires \"http://pl-build-tools.delivery.puppetlabs.net/solaris/10/pl-yaml-cpp-0.5.1.#{platform.architecture}.pkg.gz\"\n   elsif platform.is_cross_compiled_linux? || platform.name =~ /solaris-11/\n-    pkg.build_requires \"pl-yaml-cpp-#{platform.architecture}\"\n+    if platform.name =~ /debian-9-armhf/\n+      pkg.build_requires \"libyaml-cpp-dev:#{platform.architecture}\"\n+      pkg.requires \"libyaml-cpp0.5v5\"\n+      pkg.requires \"libboost-date-time1.62.0\"\n+      pkg.requires \"libboost-thread1.62.0\"\n+      pkg.requires \"libboost-chrono1.62.0\"\n+      pkg.requires \"libboost-atomic1.62.0\"\n+      pkg.requires \"libboost-log1.62.0\"\n+      pkg.requires \"libboost-locale1.62.0\"","path":"configs/components/facter.rb","position":22,"original_position":22,"commit_id":"f9779b413befe67967b6058d2f8d62d69a87a1e1","original_commit_id":"f9779b413befe67967b6058d2f8d62d69a87a1e1","user":{"login":"mckern","id":344926,"avatar_url":"https://avatars2.githubusercontent.com/u/344926?v=4","gravatar_id":"","url":"https://api.github.com/users/mckern","html_url":"https://github.com/mckern","followers_url":"https://api.github.com/users/mckern/followers","following_url":"https://api.github.com/users/mckern/following{/other_user}","gists_url":"https://api.github.com/users/mckern/gists{/gist_id}","starred_url":"https://api.github.com/users/mckern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mckern/subscriptions","organizations_url":"https://api.github.com/users/mckern/orgs","repos_url":"https://api.github.com/users/mckern/repos","events_url":"https://api.github.com/users/mckern/events{/privacy}","received_events_url":"https://api.github.com/users/mckern/received_events","type":"User","site_admin":false},"body":"Relevant commentary: we're sure that these are the only Boost libs needed here?","created_at":"2018-03-08T19:24:53Z","updated_at":"2018-03-08T19:55:14Z","html_url":"https://github.com/mckern/puppet-agent/pull/1#discussion_r173264246","pull_request_url":"https://api.github.com/repos/mckern/puppet-agent/pulls/1","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/mckern/puppet-agent/pulls/comments/173264246"},"html":{"href":"https://github.com/mckern/puppet-agent/pull/1#discussion_r173264246"},"pull_request":{"href":"https://api.github.com/repos/mckern/puppet-agent/pulls/1"}},"in_reply_to_id":173263041},"pull_request":{"url":"https://api.github.com/repos/mckern/puppet-agent/pulls/1","id":173043130,"html_url":"https://github.com/mckern/puppet-agent/pull/1","diff_url":"https://github.com/mckern/puppet-agent/pull/1.diff","patch_url":"https://github.com/mckern/puppet-agent/pull/1.patch","issue_url":"https://api.github.com/repos/mckern/puppet-agent/issues/1","number":1,"state":"open","locked":false,"title":"Add raspian stretch - WIP","user":{"login":"stahnma","id":6961,"avatar_url":"https://avatars0.githubusercontent.com/u/6961?v=4","gravatar_id":"","url":"https://api.github.com/users/stahnma","html_url":"https://github.com/stahnma","followers_url":"https://api.github.com/users/stahnma/followers","following_url":"https://api.github.com/users/stahnma/following{/other_user}","gists_url":"https://api.github.com/users/stahnma/gists{/gist_id}","starred_url":"https://api.github.com/users/stahnma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stahnma/subscriptions","organizations_url":"https://api.github.com/users/stahnma/orgs","repos_url":"https://api.github.com/users/stahnma/repos","events_url":"https://api.github.com/users/stahnma/events{/privacy}","received_events_url":"https://api.github.com/users/stahnma/received_events","type":"User","site_admin":false},"body":"# todos\r\n\r\n- [x] Squash/clean up commits\r\n- [x] Fix deb repo addition in platform definition\r\n- [x] Refactor `platform.use_native_tools?` into something PA specific.\r\n- [x] Not use my fork of leatherman (https://github.com/puppetlabs/leatherman/pull/206 needs to be merged) \r\n- [x] Ensure I didn't break amd64/i386 \r\n- [ ] Consider switching amd64/i386 to use the same compile framework\r\n- [x] Discuss the new runtime deps on icu, boost, yaml-cpp from the system.\r\n- [ ] Locales, seriously, what's up with them? \r\n- [x] Add ruby as a BR for ruby, because that's real. ","created_at":"2018-03-06T02:38:12Z","updated_at":"2018-03-08T19:55:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa76ed382ce628201e944183356909a486591b17","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mckern/puppet-agent/pulls/1/commits","review_comments_url":"https://api.github.com/repos/mckern/puppet-agent/pulls/1/comments","review_comment_url":"https://api.github.com/repos/mckern/puppet-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mckern/puppet-agent/issues/1/comments","statuses_url":"https://api.github.com/repos/mckern/puppet-agent/statuses/f9779b413befe67967b6058d2f8d62d69a87a1e1","head":{"label":"stahnma:add_raspian_stretch","ref":"add_raspian_stretch","sha":"f9779b413befe67967b6058d2f8d62d69a87a1e1","user":{"login":"stahnma","id":6961,"avatar_url":"https://avatars0.githubusercontent.com/u/6961?v=4","gravatar_id":"","url":"https://api.github.com/users/stahnma","html_url":"https://github.com/stahnma","followers_url":"https://api.github.com/users/stahnma/followers","following_url":"https://api.github.com/users/stahnma/following{/other_user}","gists_url":"https://api.github.com/users/stahnma/gists{/gist_id}","starred_url":"https://api.github.com/users/stahnma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stahnma/subscriptions","organizations_url":"https://api.github.com/users/stahnma/orgs","repos_url":"https://api.github.com/users/stahnma/repos","events_url":"https://api.github.com/users/stahnma/events{/privacy}","received_events_url":"https://api.github.com/users/stahnma/received_events","type":"User","site_admin":false},"repo":{"id":48137356,"name":"puppet-agent","full_name":"stahnma/puppet-agent","owner":{"login":"stahnma","id":6961,"avatar_url":"https://avatars0.githubusercontent.com/u/6961?v=4","gravatar_id":"","url":"https://api.github.com/users/stahnma","html_url":"https://github.com/stahnma","followers_url":"https://api.github.com/users/stahnma/followers","following_url":"https://api.github.com/users/stahnma/following{/other_user}","gists_url":"https://api.github.com/users/stahnma/gists{/gist_id}","starred_url":"https://api.github.com/users/stahnma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stahnma/subscriptions","organizations_url":"https://api.github.com/users/stahnma/orgs","repos_url":"https://api.github.com/users/stahnma/repos","events_url":"https://api.github.com/users/stahnma/events{/privacy}","received_events_url":"https://api.github.com/users/stahnma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stahnma/puppet-agent","description":"All of the directions for building a puppet agent package.","fork":true,"url":"https://api.github.com/repos/stahnma/puppet-agent","forks_url":"https://api.github.com/repos/stahnma/puppet-agent/forks","keys_url":"https://api.github.com/repos/stahnma/puppet-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stahnma/puppet-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stahnma/puppet-agent/teams","hooks_url":"https://api.github.com/repos/stahnma/puppet-agent/hooks","issue_events_url":"https://api.github.com/repos/stahnma/puppet-agent/issues/events{/number}","events_url":"https://api.github.com/repos/stahnma/puppet-agent/events","assignees_url":"https://api.github.com/repos/stahnma/puppet-agent/assignees{/user}","branches_url":"https://api.github.com/repos/stahnma/puppet-agent/branches{/branch}","tags_url":"https://api.github.com/repos/stahnma/puppet-agent/tags","blobs_url":"https://api.github.com/repos/stahnma/puppet-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stahnma/puppet-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stahnma/puppet-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/stahnma/puppet-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stahnma/puppet-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/stahnma/puppet-agent/languages","stargazers_url":"https://api.github.com/repos/stahnma/puppet-agent/stargazers","contributors_url":"https://api.github.com/repos/stahnma/puppet-agent/contributors","subscribers_url":"https://api.github.com/repos/stahnma/puppet-agent/subscribers","subscription_url":"https://api.github.com/repos/stahnma/puppet-agent/subscription","commits_url":"https://api.github.com/repos/stahnma/puppet-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/stahnma/puppet-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/stahnma/puppet-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/stahnma/puppet-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/stahnma/puppet-agent/contents/{+path}","compare_url":"https://api.github.com/repos/stahnma/puppet-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stahnma/puppet-agent/merges","archive_url":"https://api.github.com/repos/stahnma/puppet-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stahnma/puppet-agent/downloads","issues_url":"https://api.github.com/repos/stahnma/puppet-agent/issues{/number}","pulls_url":"https://api.github.com/repos/stahnma/puppet-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/stahnma/puppet-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/stahnma/puppet-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stahnma/puppet-agent/labels{/name}","releases_url":"https://api.github.com/repos/stahnma/puppet-agent/releases{/id}","deployments_url":"https://api.github.com/repos/stahnma/puppet-agent/deployments","created_at":"2015-12-16T21:54:02Z","updated_at":"2015-12-16T21:54:03Z","pushed_at":"2018-03-08T05:36:39Z","git_url":"git://github.com/stahnma/puppet-agent.git","ssh_url":"git@github.com:stahnma/puppet-agent.git","clone_url":"https://github.com/stahnma/puppet-agent.git","svn_url":"https://github.com/stahnma/puppet-agent","homepage":null,"size":20144,"stargazers_count":0,"watchers_count":0,"language":"Groff","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mckern:master","ref":"master","sha":"256b0a2a6b989a4cda0c857211b53a98eaee2c0b","user":{"login":"mckern","id":344926,"avatar_url":"https://avatars2.githubusercontent.com/u/344926?v=4","gravatar_id":"","url":"https://api.github.com/users/mckern","html_url":"https://github.com/mckern","followers_url":"https://api.github.com/users/mckern/followers","following_url":"https://api.github.com/users/mckern/following{/other_user}","gists_url":"https://api.github.com/users/mckern/gists{/gist_id}","starred_url":"https://api.github.com/users/mckern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mckern/subscriptions","organizations_url":"https://api.github.com/users/mckern/orgs","repos_url":"https://api.github.com/users/mckern/repos","events_url":"https://api.github.com/users/mckern/events{/privacy}","received_events_url":"https://api.github.com/users/mckern/received_events","type":"User","site_admin":false},"repo":{"id":124003018,"name":"puppet-agent","full_name":"mckern/puppet-agent","owner":{"login":"mckern","id":344926,"avatar_url":"https://avatars2.githubusercontent.com/u/344926?v=4","gravatar_id":"","url":"https://api.github.com/users/mckern","html_url":"https://github.com/mckern","followers_url":"https://api.github.com/users/mckern/followers","following_url":"https://api.github.com/users/mckern/following{/other_user}","gists_url":"https://api.github.com/users/mckern/gists{/gist_id}","starred_url":"https://api.github.com/users/mckern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mckern/subscriptions","organizations_url":"https://api.github.com/users/mckern/orgs","repos_url":"https://api.github.com/users/mckern/repos","events_url":"https://api.github.com/users/mckern/events{/privacy}","received_events_url":"https://api.github.com/users/mckern/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mckern/puppet-agent","description":"All of the directions for building a puppet agent package.","fork":true,"url":"https://api.github.com/repos/mckern/puppet-agent","forks_url":"https://api.github.com/repos/mckern/puppet-agent/forks","keys_url":"https://api.github.com/repos/mckern/puppet-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mckern/puppet-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mckern/puppet-agent/teams","hooks_url":"https://api.github.com/repos/mckern/puppet-agent/hooks","issue_events_url":"https://api.github.com/repos/mckern/puppet-agent/issues/events{/number}","events_url":"https://api.github.com/repos/mckern/puppet-agent/events","assignees_url":"https://api.github.com/repos/mckern/puppet-agent/assignees{/user}","branches_url":"https://api.github.com/repos/mckern/puppet-agent/branches{/branch}","tags_url":"https://api.github.com/repos/mckern/puppet-agent/tags","blobs_url":"https://api.github.com/repos/mckern/puppet-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mckern/puppet-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mckern/puppet-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/mckern/puppet-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mckern/puppet-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/mckern/puppet-agent/languages","stargazers_url":"https://api.github.com/repos/mckern/puppet-agent/stargazers","contributors_url":"https://api.github.com/repos/mckern/puppet-agent/contributors","subscribers_url":"https://api.github.com/repos/mckern/puppet-agent/subscribers","subscription_url":"https://api.github.com/repos/mckern/puppet-agent/subscription","commits_url":"https://api.github.com/repos/mckern/puppet-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/mckern/puppet-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/mckern/puppet-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/mckern/puppet-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/mckern/puppet-agent/contents/{+path}","compare_url":"https://api.github.com/repos/mckern/puppet-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mckern/puppet-agent/merges","archive_url":"https://api.github.com/repos/mckern/puppet-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mckern/puppet-agent/downloads","issues_url":"https://api.github.com/repos/mckern/puppet-agent/issues{/number}","pulls_url":"https://api.github.com/repos/mckern/puppet-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/mckern/puppet-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/mckern/puppet-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mckern/puppet-agent/labels{/name}","releases_url":"https://api.github.com/repos/mckern/puppet-agent/releases{/id}","deployments_url":"https://api.github.com/repos/mckern/puppet-agent/deployments","created_at":"2018-03-06T01:37:05Z","updated_at":"2018-03-06T01:37:07Z","pushed_at":"2018-03-08T05:36:40Z","git_url":"git://github.com/mckern/puppet-agent.git","ssh_url":"git@github.com:mckern/puppet-agent.git","clone_url":"https://github.com/mckern/puppet-agent.git","svn_url":"https://github.com/mckern/puppet-agent","homepage":null,"size":20066,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mckern/puppet-agent/pulls/1"},"html":{"href":"https://github.com/mckern/puppet-agent/pull/1"},"issue":{"href":"https://api.github.com/repos/mckern/puppet-agent/issues/1"},"comments":{"href":"https://api.github.com/repos/mckern/puppet-agent/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/mckern/puppet-agent/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/mckern/puppet-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mckern/puppet-agent/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/mckern/puppet-agent/statuses/f9779b413befe67967b6058d2f8d62d69a87a1e1"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mckern"}}