{"action":"created","comment":{"url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/pulls/comments/244532658","pull_request_review_id":188437470,"id":244532658,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDUzMjY1OA==","diff_hunk":"@@ -0,0 +1,38 @@\n+from typing import List, Dict, Tuple\n+\n+from modules.controller.commands.classify_command import ClassifyCommand\n+from modules.controller.commands.command import Command\n+\n+\n+##  Class for parsing strings to a command\n+from modules.controller.commands.collector_command import CollectorCommand\n+from modules.controller.commands.label_command import LabelCommand\n+from modules.controller.commands.quit_command import QuitCommand\n+from modules.controller.commands.train_command import TrainCommand\n+from modules.exception.excpetions import IllegalArgumentException\n+\n+\n+class CommandParser:\n+\n+    _valid_commands: Dict[str, Command.__class__] = {\n+        \"collect\": CollectorCommand,","path":"modules/controller/command_parser.py","position":18,"original_position":18,"commit_id":"3eb5172c6d038b76cc8acc7af7be1243d9a9e5f5","original_commit_id":"3eb5172c6d038b76cc8acc7af7be1243d9a9e5f5","user":{"login":"annaric","id":38177714,"node_id":"MDQ6VXNlcjM4MTc3NzE0","avatar_url":"https://avatars0.githubusercontent.com/u/38177714?v=4","gravatar_id":"","url":"https://api.github.com/users/annaric","html_url":"https://github.com/annaric","followers_url":"https://api.github.com/users/annaric/followers","following_url":"https://api.github.com/users/annaric/following{/other_user}","gists_url":"https://api.github.com/users/annaric/gists{/gist_id}","starred_url":"https://api.github.com/users/annaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annaric/subscriptions","organizations_url":"https://api.github.com/users/annaric/orgs","repos_url":"https://api.github.com/users/annaric/repos","events_url":"https://api.github.com/users/annaric/events{/privacy}","received_events_url":"https://api.github.com/users/annaric/received_events","type":"User","site_admin":false},"body":"why is the naming for the command at the one hand a substantive (labeler) but on the other hand a verb (collect)?\r\nIsn't that inconsistent?","created_at":"2018-12-30T12:22:50Z","updated_at":"2018-12-30T12:31:59Z","html_url":"https://github.com/TheSlimvReal/PSE---LA-meets-ML/pull/123#discussion_r244532658","pull_request_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/pulls/123","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/pulls/comments/244532658"},"html":{"href":"https://github.com/TheSlimvReal/PSE---LA-meets-ML/pull/123#discussion_r244532658"},"pull_request":{"href":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/pulls/123"}}},"pull_request":{"url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/pulls/123","id":240682012,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNjgyMDEy","html_url":"https://github.com/TheSlimvReal/PSE---LA-meets-ML/pull/123","diff_url":"https://github.com/TheSlimvReal/PSE---LA-meets-ML/pull/123.diff","patch_url":"https://github.com/TheSlimvReal/PSE---LA-meets-ML/pull/123.patch","issue_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/issues/123","number":123,"state":"open","locked":false,"title":"Controller view implementation","user":{"login":"TheSlimvReal","id":33730997,"node_id":"MDQ6VXNlcjMzNzMwOTk3","avatar_url":"https://avatars2.githubusercontent.com/u/33730997?v=4","gravatar_id":"","url":"https://api.github.com/users/TheSlimvReal","html_url":"https://github.com/TheSlimvReal","followers_url":"https://api.github.com/users/TheSlimvReal/followers","following_url":"https://api.github.com/users/TheSlimvReal/following{/other_user}","gists_url":"https://api.github.com/users/TheSlimvReal/gists{/gist_id}","starred_url":"https://api.github.com/users/TheSlimvReal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheSlimvReal/subscriptions","organizations_url":"https://api.github.com/users/TheSlimvReal/orgs","repos_url":"https://api.github.com/users/TheSlimvReal/repos","events_url":"https://api.github.com/users/TheSlimvReal/events{/privacy}","received_events_url":"https://api.github.com/users/TheSlimvReal/received_events","type":"User","site_admin":false},"body":"I implemented most of the logic for the view and controller.\r\n\r\nIf the models are finished, you need to implement the execute and validate mehtod for the specific command subclass.","created_at":"2018-12-23T13:27:23Z","updated_at":"2018-12-30T12:31:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"502c74d9261f2dc8a1ee04e73100cd35bb5a6a4e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/pulls/123/commits","review_comments_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/pulls/123/comments","review_comment_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/issues/123/comments","statuses_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/statuses/3eb5172c6d038b76cc8acc7af7be1243d9a9e5f5","head":{"label":"TheSlimvReal:controller_view_implementation","ref":"controller_view_implementation","sha":"3eb5172c6d038b76cc8acc7af7be1243d9a9e5f5","user":{"login":"TheSlimvReal","id":33730997,"node_id":"MDQ6VXNlcjMzNzMwOTk3","avatar_url":"https://avatars2.githubusercontent.com/u/33730997?v=4","gravatar_id":"","url":"https://api.github.com/users/TheSlimvReal","html_url":"https://github.com/TheSlimvReal","followers_url":"https://api.github.com/users/TheSlimvReal/followers","following_url":"https://api.github.com/users/TheSlimvReal/following{/other_user}","gists_url":"https://api.github.com/users/TheSlimvReal/gists{/gist_id}","starred_url":"https://api.github.com/users/TheSlimvReal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheSlimvReal/subscriptions","organizations_url":"https://api.github.com/users/TheSlimvReal/orgs","repos_url":"https://api.github.com/users/TheSlimvReal/repos","events_url":"https://api.github.com/users/TheSlimvReal/events{/privacy}","received_events_url":"https://api.github.com/users/TheSlimvReal/received_events","type":"User","site_admin":false},"repo":{"id":155573488,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU1NzM0ODg=","name":"PSE---LA-meets-ML","full_name":"TheSlimvReal/PSE---LA-meets-ML","private":false,"owner":{"login":"TheSlimvReal","id":33730997,"node_id":"MDQ6VXNlcjMzNzMwOTk3","avatar_url":"https://avatars2.githubusercontent.com/u/33730997?v=4","gravatar_id":"","url":"https://api.github.com/users/TheSlimvReal","html_url":"https://github.com/TheSlimvReal","followers_url":"https://api.github.com/users/TheSlimvReal/followers","following_url":"https://api.github.com/users/TheSlimvReal/following{/other_user}","gists_url":"https://api.github.com/users/TheSlimvReal/gists{/gist_id}","starred_url":"https://api.github.com/users/TheSlimvReal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheSlimvReal/subscriptions","organizations_url":"https://api.github.com/users/TheSlimvReal/orgs","repos_url":"https://api.github.com/users/TheSlimvReal/repos","events_url":"https://api.github.com/users/TheSlimvReal/events{/privacy}","received_events_url":"https://api.github.com/users/TheSlimvReal/received_events","type":"User","site_admin":false},"html_url":"https://github.com/TheSlimvReal/PSE---LA-meets-ML","description":"Numerical Linear Algebra meets Machine Learning - PSE Project","fork":false,"url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML","forks_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/forks","keys_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/teams","hooks_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/hooks","issue_events_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/issues/events{/number}","events_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/events","assignees_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/assignees{/user}","branches_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/branches{/branch}","tags_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/tags","blobs_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/statuses/{sha}","languages_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/languages","stargazers_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/stargazers","contributors_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/contributors","subscribers_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/subscribers","subscription_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/subscription","commits_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/contents/{+path}","compare_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/merges","archive_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/downloads","issues_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/issues{/number}","pulls_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/pulls{/number}","milestones_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/milestones{/number}","notifications_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/labels{/name}","releases_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/releases{/id}","deployments_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/deployments","created_at":"2018-10-31T14:43:40Z","updated_at":"2018-12-21T23:01:26Z","pushed_at":"2018-12-25T14:09:12Z","git_url":"git://github.com/TheSlimvReal/PSE---LA-meets-ML.git","ssh_url":"git@github.com:TheSlimvReal/PSE---LA-meets-ML.git","clone_url":"https://github.com/TheSlimvReal/PSE---LA-meets-ML.git","svn_url":"https://github.com/TheSlimvReal/PSE---LA-meets-ML","homepage":null,"size":14470,"stargazers_count":0,"watchers_count":0,"language":"TeX","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"TheSlimvReal:master","ref":"master","sha":"2f4dce3602fe18aaa7ab6b47ef5fbf97cbcc1b29","user":{"login":"TheSlimvReal","id":33730997,"node_id":"MDQ6VXNlcjMzNzMwOTk3","avatar_url":"https://avatars2.githubusercontent.com/u/33730997?v=4","gravatar_id":"","url":"https://api.github.com/users/TheSlimvReal","html_url":"https://github.com/TheSlimvReal","followers_url":"https://api.github.com/users/TheSlimvReal/followers","following_url":"https://api.github.com/users/TheSlimvReal/following{/other_user}","gists_url":"https://api.github.com/users/TheSlimvReal/gists{/gist_id}","starred_url":"https://api.github.com/users/TheSlimvReal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheSlimvReal/subscriptions","organizations_url":"https://api.github.com/users/TheSlimvReal/orgs","repos_url":"https://api.github.com/users/TheSlimvReal/repos","events_url":"https://api.github.com/users/TheSlimvReal/events{/privacy}","received_events_url":"https://api.github.com/users/TheSlimvReal/received_events","type":"User","site_admin":false},"repo":{"id":155573488,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU1NzM0ODg=","name":"PSE---LA-meets-ML","full_name":"TheSlimvReal/PSE---LA-meets-ML","private":false,"owner":{"login":"TheSlimvReal","id":33730997,"node_id":"MDQ6VXNlcjMzNzMwOTk3","avatar_url":"https://avatars2.githubusercontent.com/u/33730997?v=4","gravatar_id":"","url":"https://api.github.com/users/TheSlimvReal","html_url":"https://github.com/TheSlimvReal","followers_url":"https://api.github.com/users/TheSlimvReal/followers","following_url":"https://api.github.com/users/TheSlimvReal/following{/other_user}","gists_url":"https://api.github.com/users/TheSlimvReal/gists{/gist_id}","starred_url":"https://api.github.com/users/TheSlimvReal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheSlimvReal/subscriptions","organizations_url":"https://api.github.com/users/TheSlimvReal/orgs","repos_url":"https://api.github.com/users/TheSlimvReal/repos","events_url":"https://api.github.com/users/TheSlimvReal/events{/privacy}","received_events_url":"https://api.github.com/users/TheSlimvReal/received_events","type":"User","site_admin":false},"html_url":"https://github.com/TheSlimvReal/PSE---LA-meets-ML","description":"Numerical Linear Algebra meets Machine Learning - PSE Project","fork":false,"url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML","forks_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/forks","keys_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/teams","hooks_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/hooks","issue_events_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/issues/events{/number}","events_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/events","assignees_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/assignees{/user}","branches_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/branches{/branch}","tags_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/tags","blobs_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/statuses/{sha}","languages_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/languages","stargazers_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/stargazers","contributors_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/contributors","subscribers_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/subscribers","subscription_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/subscription","commits_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/contents/{+path}","compare_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/merges","archive_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/downloads","issues_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/issues{/number}","pulls_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/pulls{/number}","milestones_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/milestones{/number}","notifications_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/labels{/name}","releases_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/releases{/id}","deployments_url":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/deployments","created_at":"2018-10-31T14:43:40Z","updated_at":"2018-12-21T23:01:26Z","pushed_at":"2018-12-25T14:09:12Z","git_url":"git://github.com/TheSlimvReal/PSE---LA-meets-ML.git","ssh_url":"git@github.com:TheSlimvReal/PSE---LA-meets-ML.git","clone_url":"https://github.com/TheSlimvReal/PSE---LA-meets-ML.git","svn_url":"https://github.com/TheSlimvReal/PSE---LA-meets-ML","homepage":null,"size":14470,"stargazers_count":0,"watchers_count":0,"language":"TeX","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/pulls/123"},"html":{"href":"https://github.com/TheSlimvReal/PSE---LA-meets-ML/pull/123"},"issue":{"href":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/issues/123"},"comments":{"href":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/TheSlimvReal/PSE---LA-meets-ML/statuses/3eb5172c6d038b76cc8acc7af7be1243d9a9e5f5"}},"author_association":"OWNER"}}
{"actor":{"display_login":"annaric"}}