{"action":"created","comment":{"url":"https://api.github.com/repos/pharo-project/pharo/pulls/comments/226309406","pull_request_review_id":166099287,"id":226309406,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjMwOTQwNg==","diff_hunk":"@@ -369,6 +369,13 @@ Interval >> size [\n \t\t\t\tifFalse: [^ stop - start // step + 1]]\n ]\n \n+{ #category : #accessing }\n+Interval >> sort: aBlock [\n+\t\"What sorting an Interval means is not clear.\"\n+\n+\tself error: 'you can not sort an interval'","path":"src/Collections-Sequenceable/Interval.class.st","position":8,"original_position":8,"commit_id":"06c6743dcdaab1c707255b3a5399805434cfec42","original_commit_id":"06c6743dcdaab1c707255b3a5399805434cfec42","user":{"login":"dupriezt","id":32486709,"node_id":"MDQ6VXNlcjMyNDg2NzA5","avatar_url":"https://avatars3.githubusercontent.com/u/32486709?v=4","gravatar_id":"","url":"https://api.github.com/users/dupriezt","html_url":"https://github.com/dupriezt","followers_url":"https://api.github.com/users/dupriezt/followers","following_url":"https://api.github.com/users/dupriezt/following{/other_user}","gists_url":"https://api.github.com/users/dupriezt/gists{/gist_id}","starred_url":"https://api.github.com/users/dupriezt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dupriezt/subscriptions","organizations_url":"https://api.github.com/users/dupriezt/orgs","repos_url":"https://api.github.com/users/dupriezt/repos","events_url":"https://api.github.com/users/dupriezt/events{/privacy}","received_events_url":"https://api.github.com/users/dupriezt/received_events","type":"User","site_admin":false},"body":"But sure, why not.","created_at":"2018-10-18T13:43:24Z","updated_at":"2018-10-18T13:43:24Z","html_url":"https://github.com/pharo-project/pharo/pull/1922#discussion_r226309406","pull_request_url":"https://api.github.com/repos/pharo-project/pharo/pulls/1922","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pharo-project/pharo/pulls/comments/226309406"},"html":{"href":"https://github.com/pharo-project/pharo/pull/1922#discussion_r226309406"},"pull_request":{"href":"https://api.github.com/repos/pharo-project/pharo/pulls/1922"}},"in_reply_to_id":226236383},"pull_request":{"url":"https://api.github.com/repos/pharo-project/pharo/pulls/1922","id":223601613,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNjAxNjEz","html_url":"https://github.com/pharo-project/pharo/pull/1922","diff_url":"https://github.com/pharo-project/pharo/pull/1922.diff","patch_url":"https://github.com/pharo-project/pharo/pull/1922.patch","issue_url":"https://api.github.com/repos/pharo-project/pharo/issues/1922","number":1922,"state":"open","locked":false,"title":"Added Interval>>sort: method that raises a \"you can not sort an inter…","user":{"login":"dupriezt","id":32486709,"node_id":"MDQ6VXNlcjMyNDg2NzA5","avatar_url":"https://avatars3.githubusercontent.com/u/32486709?v=4","gravatar_id":"","url":"https://api.github.com/users/dupriezt","html_url":"https://github.com/dupriezt","followers_url":"https://api.github.com/users/dupriezt/followers","following_url":"https://api.github.com/users/dupriezt/following{/other_user}","gists_url":"https://api.github.com/users/dupriezt/gists{/gist_id}","starred_url":"https://api.github.com/users/dupriezt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dupriezt/subscriptions","organizations_url":"https://api.github.com/users/dupriezt/orgs","repos_url":"https://api.github.com/users/dupriezt/repos","events_url":"https://api.github.com/users/dupriezt/events{/privacy}","received_events_url":"https://api.github.com/users/dupriezt/received_events","type":"User","site_admin":false},"body":"…val\" error\r\n\r\nFrom fogbuz issue:\r\nInterval new sort raises an \"#< was sent to nil\" exception\r\n(1 to: 5)  sort raises an \"you can not store into an interval\" exception\r\n\r\nThe Interval class inherits the default #sort: method of SequenceableCollection, which does not work for intervals. I am not sure the concept of sorting an Interval makes sense in the general case. I suggest implementing Interval>>sort: so that it raises an explicit exception: \"you can not sort an interval\" akin to what Interval>>at:put: does (it raises \"you can not store into an interval\"). Unless someone has an idea for what \"sorting an Interval\" could mean. ","created_at":"2018-10-17T13:22:44Z","updated_at":"2018-10-18T13:43:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7405e38c26d1aff2ae7406ec6ed9c170ad1710ce","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pharo-project/pharo/pulls/1922/commits","review_comments_url":"https://api.github.com/repos/pharo-project/pharo/pulls/1922/comments","review_comment_url":"https://api.github.com/repos/pharo-project/pharo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pharo-project/pharo/issues/1922/comments","statuses_url":"https://api.github.com/repos/pharo-project/pharo/statuses/06c6743dcdaab1c707255b3a5399805434cfec42","head":{"label":"dupriezt:22588-Sorting-an-Interval-raises-an-exception","ref":"22588-Sorting-an-Interval-raises-an-exception","sha":"06c6743dcdaab1c707255b3a5399805434cfec42","user":{"login":"dupriezt","id":32486709,"node_id":"MDQ6VXNlcjMyNDg2NzA5","avatar_url":"https://avatars3.githubusercontent.com/u/32486709?v=4","gravatar_id":"","url":"https://api.github.com/users/dupriezt","html_url":"https://github.com/dupriezt","followers_url":"https://api.github.com/users/dupriezt/followers","following_url":"https://api.github.com/users/dupriezt/following{/other_user}","gists_url":"https://api.github.com/users/dupriezt/gists{/gist_id}","starred_url":"https://api.github.com/users/dupriezt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dupriezt/subscriptions","organizations_url":"https://api.github.com/users/dupriezt/orgs","repos_url":"https://api.github.com/users/dupriezt/repos","events_url":"https://api.github.com/users/dupriezt/events{/privacy}","received_events_url":"https://api.github.com/users/dupriezt/received_events","type":"User","site_admin":false},"repo":{"id":108520205,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg1MjAyMDU=","name":"pharo","full_name":"dupriezt/pharo","private":false,"owner":{"login":"dupriezt","id":32486709,"node_id":"MDQ6VXNlcjMyNDg2NzA5","avatar_url":"https://avatars3.githubusercontent.com/u/32486709?v=4","gravatar_id":"","url":"https://api.github.com/users/dupriezt","html_url":"https://github.com/dupriezt","followers_url":"https://api.github.com/users/dupriezt/followers","following_url":"https://api.github.com/users/dupriezt/following{/other_user}","gists_url":"https://api.github.com/users/dupriezt/gists{/gist_id}","starred_url":"https://api.github.com/users/dupriezt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dupriezt/subscriptions","organizations_url":"https://api.github.com/users/dupriezt/orgs","repos_url":"https://api.github.com/users/dupriezt/repos","events_url":"https://api.github.com/users/dupriezt/events{/privacy}","received_events_url":"https://api.github.com/users/dupriezt/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dupriezt/pharo","description":"The sources for Pharo","fork":true,"url":"https://api.github.com/repos/dupriezt/pharo","forks_url":"https://api.github.com/repos/dupriezt/pharo/forks","keys_url":"https://api.github.com/repos/dupriezt/pharo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dupriezt/pharo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dupriezt/pharo/teams","hooks_url":"https://api.github.com/repos/dupriezt/pharo/hooks","issue_events_url":"https://api.github.com/repos/dupriezt/pharo/issues/events{/number}","events_url":"https://api.github.com/repos/dupriezt/pharo/events","assignees_url":"https://api.github.com/repos/dupriezt/pharo/assignees{/user}","branches_url":"https://api.github.com/repos/dupriezt/pharo/branches{/branch}","tags_url":"https://api.github.com/repos/dupriezt/pharo/tags","blobs_url":"https://api.github.com/repos/dupriezt/pharo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dupriezt/pharo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dupriezt/pharo/git/refs{/sha}","trees_url":"https://api.github.com/repos/dupriezt/pharo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dupriezt/pharo/statuses/{sha}","languages_url":"https://api.github.com/repos/dupriezt/pharo/languages","stargazers_url":"https://api.github.com/repos/dupriezt/pharo/stargazers","contributors_url":"https://api.github.com/repos/dupriezt/pharo/contributors","subscribers_url":"https://api.github.com/repos/dupriezt/pharo/subscribers","subscription_url":"https://api.github.com/repos/dupriezt/pharo/subscription","commits_url":"https://api.github.com/repos/dupriezt/pharo/commits{/sha}","git_commits_url":"https://api.github.com/repos/dupriezt/pharo/git/commits{/sha}","comments_url":"https://api.github.com/repos/dupriezt/pharo/comments{/number}","issue_comment_url":"https://api.github.com/repos/dupriezt/pharo/issues/comments{/number}","contents_url":"https://api.github.com/repos/dupriezt/pharo/contents/{+path}","compare_url":"https://api.github.com/repos/dupriezt/pharo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dupriezt/pharo/merges","archive_url":"https://api.github.com/repos/dupriezt/pharo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dupriezt/pharo/downloads","issues_url":"https://api.github.com/repos/dupriezt/pharo/issues{/number}","pulls_url":"https://api.github.com/repos/dupriezt/pharo/pulls{/number}","milestones_url":"https://api.github.com/repos/dupriezt/pharo/milestones{/number}","notifications_url":"https://api.github.com/repos/dupriezt/pharo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dupriezt/pharo/labels{/name}","releases_url":"https://api.github.com/repos/dupriezt/pharo/releases{/id}","deployments_url":"https://api.github.com/repos/dupriezt/pharo/deployments","created_at":"2017-10-27T08:28:49Z","updated_at":"2018-10-16T16:50:28Z","pushed_at":"2018-10-17T13:21:34Z","git_url":"git://github.com/dupriezt/pharo.git","ssh_url":"git@github.com:dupriezt/pharo.git","clone_url":"https://github.com/dupriezt/pharo.git","svn_url":"https://github.com/dupriezt/pharo","homepage":"http://pharo.org","size":47220,"stargazers_count":0,"watchers_count":0,"language":"Smalltalk","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"pharo-project:development","ref":"development","sha":"d25686ea1679b7fc16788a719eca1b2c03cc5c67","user":{"login":"pharo-project","id":1838382,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MzgzODI=","avatar_url":"https://avatars3.githubusercontent.com/u/1838382?v=4","gravatar_id":"","url":"https://api.github.com/users/pharo-project","html_url":"https://github.com/pharo-project","followers_url":"https://api.github.com/users/pharo-project/followers","following_url":"https://api.github.com/users/pharo-project/following{/other_user}","gists_url":"https://api.github.com/users/pharo-project/gists{/gist_id}","starred_url":"https://api.github.com/users/pharo-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pharo-project/subscriptions","organizations_url":"https://api.github.com/users/pharo-project/orgs","repos_url":"https://api.github.com/users/pharo-project/repos","events_url":"https://api.github.com/users/pharo-project/events{/privacy}","received_events_url":"https://api.github.com/users/pharo-project/received_events","type":"Organization","site_admin":false},"repo":{"id":64123480,"node_id":"MDEwOlJlcG9zaXRvcnk2NDEyMzQ4MA==","name":"pharo","full_name":"pharo-project/pharo","private":false,"owner":{"login":"pharo-project","id":1838382,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MzgzODI=","avatar_url":"https://avatars3.githubusercontent.com/u/1838382?v=4","gravatar_id":"","url":"https://api.github.com/users/pharo-project","html_url":"https://github.com/pharo-project","followers_url":"https://api.github.com/users/pharo-project/followers","following_url":"https://api.github.com/users/pharo-project/following{/other_user}","gists_url":"https://api.github.com/users/pharo-project/gists{/gist_id}","starred_url":"https://api.github.com/users/pharo-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pharo-project/subscriptions","organizations_url":"https://api.github.com/users/pharo-project/orgs","repos_url":"https://api.github.com/users/pharo-project/repos","events_url":"https://api.github.com/users/pharo-project/events{/privacy}","received_events_url":"https://api.github.com/users/pharo-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pharo-project/pharo","description":"The Sources for Pharo","fork":false,"url":"https://api.github.com/repos/pharo-project/pharo","forks_url":"https://api.github.com/repos/pharo-project/pharo/forks","keys_url":"https://api.github.com/repos/pharo-project/pharo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pharo-project/pharo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pharo-project/pharo/teams","hooks_url":"https://api.github.com/repos/pharo-project/pharo/hooks","issue_events_url":"https://api.github.com/repos/pharo-project/pharo/issues/events{/number}","events_url":"https://api.github.com/repos/pharo-project/pharo/events","assignees_url":"https://api.github.com/repos/pharo-project/pharo/assignees{/user}","branches_url":"https://api.github.com/repos/pharo-project/pharo/branches{/branch}","tags_url":"https://api.github.com/repos/pharo-project/pharo/tags","blobs_url":"https://api.github.com/repos/pharo-project/pharo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pharo-project/pharo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pharo-project/pharo/git/refs{/sha}","trees_url":"https://api.github.com/repos/pharo-project/pharo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pharo-project/pharo/statuses/{sha}","languages_url":"https://api.github.com/repos/pharo-project/pharo/languages","stargazers_url":"https://api.github.com/repos/pharo-project/pharo/stargazers","contributors_url":"https://api.github.com/repos/pharo-project/pharo/contributors","subscribers_url":"https://api.github.com/repos/pharo-project/pharo/subscribers","subscription_url":"https://api.github.com/repos/pharo-project/pharo/subscription","commits_url":"https://api.github.com/repos/pharo-project/pharo/commits{/sha}","git_commits_url":"https://api.github.com/repos/pharo-project/pharo/git/commits{/sha}","comments_url":"https://api.github.com/repos/pharo-project/pharo/comments{/number}","issue_comment_url":"https://api.github.com/repos/pharo-project/pharo/issues/comments{/number}","contents_url":"https://api.github.com/repos/pharo-project/pharo/contents/{+path}","compare_url":"https://api.github.com/repos/pharo-project/pharo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pharo-project/pharo/merges","archive_url":"https://api.github.com/repos/pharo-project/pharo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pharo-project/pharo/downloads","issues_url":"https://api.github.com/repos/pharo-project/pharo/issues{/number}","pulls_url":"https://api.github.com/repos/pharo-project/pharo/pulls{/number}","milestones_url":"https://api.github.com/repos/pharo-project/pharo/milestones{/number}","notifications_url":"https://api.github.com/repos/pharo-project/pharo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pharo-project/pharo/labels{/name}","releases_url":"https://api.github.com/repos/pharo-project/pharo/releases{/id}","deployments_url":"https://api.github.com/repos/pharo-project/pharo/deployments","created_at":"2016-07-25T09:55:28Z","updated_at":"2018-10-18T11:55:38Z","pushed_at":"2018-10-18T11:55:32Z","git_url":"git://github.com/pharo-project/pharo.git","ssh_url":"git@github.com:pharo-project/pharo.git","clone_url":"https://github.com/pharo-project/pharo.git","svn_url":"https://github.com/pharo-project/pharo","homepage":"http://pharo.org","size":47216,"stargazers_count":182,"watchers_count":182,"language":"Smalltalk","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":118,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":118,"open_issues":28,"watchers":182,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/pharo-project/pharo/pulls/1922"},"html":{"href":"https://github.com/pharo-project/pharo/pull/1922"},"issue":{"href":"https://api.github.com/repos/pharo-project/pharo/issues/1922"},"comments":{"href":"https://api.github.com/repos/pharo-project/pharo/issues/1922/comments"},"review_comments":{"href":"https://api.github.com/repos/pharo-project/pharo/pulls/1922/comments"},"review_comment":{"href":"https://api.github.com/repos/pharo-project/pharo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pharo-project/pharo/pulls/1922/commits"},"statuses":{"href":"https://api.github.com/repos/pharo-project/pharo/statuses/06c6743dcdaab1c707255b3a5399805434cfec42"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dupriezt"}}