{"action":"opened","number":27375,"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/27375","id":202065004,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMDY1MDA0","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/27375","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/27375.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/27375.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/27375","number":27375,"state":"open","locked":false,"title":"[whatwg-streams] Fixes for readable byte streams","user":{"login":"MattiasBuelens","id":649348,"node_id":"MDQ6VXNlcjY0OTM0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/649348?v=4","gravatar_id":"","url":"https://api.github.com/users/MattiasBuelens","html_url":"https://github.com/MattiasBuelens","followers_url":"https://api.github.com/users/MattiasBuelens/followers","following_url":"https://api.github.com/users/MattiasBuelens/following{/other_user}","gists_url":"https://api.github.com/users/MattiasBuelens/gists{/gist_id}","starred_url":"https://api.github.com/users/MattiasBuelens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattiasBuelens/subscriptions","organizations_url":"https://api.github.com/users/MattiasBuelens/orgs","repos_url":"https://api.github.com/users/MattiasBuelens/repos","events_url":"https://api.github.com/users/MattiasBuelens/events{/privacy}","received_events_url":"https://api.github.com/users/MattiasBuelens/received_events","type":"User","site_admin":false},"body":"This PR makes the type definitions for readable byte streams match the spec more closely. An overview of the changes:\r\n* `ReadableByteStreamController.enqueue` accepts any `ArrayBufferView` (see [step 5 in the spec](https://streams.spec.whatwg.org/#rbs-controller-enqueue))\r\n* `ReadableStreamBYOBRequest.view` is always a `Uint8Array` (see [step 2b in the spec](https://streams.spec.whatwg.org/#rbs-controller-byob-request))\r\n* `ReadableByteStreamController.byobRequest` may be `undefined` (see [step 2 in the spec](https://streams.spec.whatwg.org/#rbs-controller-byob-request))\r\n* Remove unused type parameter on `ReadableByteStreamSource` and related classes. As demonstrated by the above changes, readable byte streams aren't generic according to the spec, so there's no use for the `R` type parameter.\r\n\r\n---\r\n\r\nPlease fill in this template.\r\n\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [x] Add or edit tests to reflect the change. (Run with `npm test`.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nSelect one of these and delete the others:\r\n\r\nIf changing an existing definition:\r\n- [x] Provide a URL to documentation or source code which provides context for the suggested changes: [https://streams.spec.whatwg.org]\r\n- [ ] Increase the version number in the header if appropriate.\r\n- [ ] If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"dtslint/dt.json\" }`.\r\n","created_at":"2018-07-17T20:47:37Z","updated_at":"2018-07-17T20:47:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/27375/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/27375/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/27375/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/f1ac56d2f106a4093f1a463cc111bdea8c2cc5f2","head":{"label":"MattiasBuelens:whatwg-streams-byte-fixes","ref":"whatwg-streams-byte-fixes","sha":"f1ac56d2f106a4093f1a463cc111bdea8c2cc5f2","user":{"login":"MattiasBuelens","id":649348,"node_id":"MDQ6VXNlcjY0OTM0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/649348?v=4","gravatar_id":"","url":"https://api.github.com/users/MattiasBuelens","html_url":"https://github.com/MattiasBuelens","followers_url":"https://api.github.com/users/MattiasBuelens/followers","following_url":"https://api.github.com/users/MattiasBuelens/following{/other_user}","gists_url":"https://api.github.com/users/MattiasBuelens/gists{/gist_id}","starred_url":"https://api.github.com/users/MattiasBuelens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattiasBuelens/subscriptions","organizations_url":"https://api.github.com/users/MattiasBuelens/orgs","repos_url":"https://api.github.com/users/MattiasBuelens/repos","events_url":"https://api.github.com/users/MattiasBuelens/events{/privacy}","received_events_url":"https://api.github.com/users/MattiasBuelens/received_events","type":"User","site_admin":false},"repo":{"id":117474626,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc0NzQ2MjY=","name":"DefinitelyTyped","full_name":"MattiasBuelens/DefinitelyTyped","owner":{"login":"MattiasBuelens","id":649348,"node_id":"MDQ6VXNlcjY0OTM0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/649348?v=4","gravatar_id":"","url":"https://api.github.com/users/MattiasBuelens","html_url":"https://github.com/MattiasBuelens","followers_url":"https://api.github.com/users/MattiasBuelens/followers","following_url":"https://api.github.com/users/MattiasBuelens/following{/other_user}","gists_url":"https://api.github.com/users/MattiasBuelens/gists{/gist_id}","starred_url":"https://api.github.com/users/MattiasBuelens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattiasBuelens/subscriptions","organizations_url":"https://api.github.com/users/MattiasBuelens/orgs","repos_url":"https://api.github.com/users/MattiasBuelens/repos","events_url":"https://api.github.com/users/MattiasBuelens/events{/privacy}","received_events_url":"https://api.github.com/users/MattiasBuelens/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MattiasBuelens/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped","forks_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/MattiasBuelens/DefinitelyTyped/deployments","created_at":"2018-01-14T23:08:11Z","updated_at":"2018-07-01T21:20:52Z","pushed_at":"2018-07-17T20:37:29Z","git_url":"git://github.com/MattiasBuelens/DefinitelyTyped.git","ssh_url":"git@github.com:MattiasBuelens/DefinitelyTyped.git","clone_url":"https://github.com/MattiasBuelens/DefinitelyTyped.git","svn_url":"https://github.com/MattiasBuelens/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":335371,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"91f8a6b7d1ef61cc543d0901dcc004b846283345","user":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"node_id":"MDEwOlJlcG9zaXRvcnk2MDkzMzE2","name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","owner":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2018-07-17T20:16:05Z","pushed_at":"2018-07-17T18:15:15Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":340222,"stargazers_count":16446,"watchers_count":16446,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13767,"mirror_url":null,"archived":false,"open_issues_count":2278,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":13767,"open_issues":2278,"watchers":16446,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/27375"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/27375"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/27375"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/27375/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/27375/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/27375/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/f1ac56d2f106a4093f1a463cc111bdea8c2cc5f2"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":5,"additions":11,"deletions":11,"changed_files":2}}
{"actor":{"display_login":"MattiasBuelens"}}