{"action":"created","issue":{"url":"https://api.github.com/repos/enonic/xp-distro/issues/48","repository_url":"https://api.github.com/repos/enonic/xp-distro","labels_url":"https://api.github.com/repos/enonic/xp-distro/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/enonic/xp-distro/issues/48/comments","events_url":"https://api.github.com/repos/enonic/xp-distro/issues/48/events","html_url":"https://github.com/enonic/xp-distro/issues/48","id":366298014,"node_id":"MDU6SXNzdWUzNjYyOTgwMTQ=","number":48,"title":"Embedding JDK 11","user":{"login":"aro","id":430739,"node_id":"MDQ6VXNlcjQzMDczOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/430739?v=4","gravatar_id":"","url":"https://api.github.com/users/aro","html_url":"https://github.com/aro","followers_url":"https://api.github.com/users/aro/followers","following_url":"https://api.github.com/users/aro/following{/other_user}","gists_url":"https://api.github.com/users/aro/gists{/gist_id}","starred_url":"https://api.github.com/users/aro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aro/subscriptions","organizations_url":"https://api.github.com/users/aro/orgs","repos_url":"https://api.github.com/users/aro/repos","events_url":"https://api.github.com/users/aro/events{/privacy}","received_events_url":"https://api.github.com/users/aro/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"aro","id":430739,"node_id":"MDQ6VXNlcjQzMDczOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/430739?v=4","gravatar_id":"","url":"https://api.github.com/users/aro","html_url":"https://github.com/aro","followers_url":"https://api.github.com/users/aro/followers","following_url":"https://api.github.com/users/aro/following{/other_user}","gists_url":"https://api.github.com/users/aro/gists{/gist_id}","starred_url":"https://api.github.com/users/aro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aro/subscriptions","organizations_url":"https://api.github.com/users/aro/orgs","repos_url":"https://api.github.com/users/aro/repos","events_url":"https://api.github.com/users/aro/events{/privacy}","received_events_url":"https://api.github.com/users/aro/received_events","type":"User","site_admin":false},"assignees":[{"login":"aro","id":430739,"node_id":"MDQ6VXNlcjQzMDczOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/430739?v=4","gravatar_id":"","url":"https://api.github.com/users/aro","html_url":"https://github.com/aro","followers_url":"https://api.github.com/users/aro/followers","following_url":"https://api.github.com/users/aro/following{/other_user}","gists_url":"https://api.github.com/users/aro/gists{/gist_id}","starred_url":"https://api.github.com/users/aro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aro/subscriptions","organizations_url":"https://api.github.com/users/aro/orgs","repos_url":"https://api.github.com/users/aro/repos","events_url":"https://api.github.com/users/aro/events{/privacy}","received_events_url":"https://api.github.com/users/aro/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-10-03T11:42:38Z","updated_at":"2018-10-04T07:35:08Z","closed_at":null,"author_association":"MEMBER","body":"Update the build to download and include JDK 11 in the distribution.\r\n\r\nThe JDK is platform specific (Windows, Linux, Mac), so the build will generate a distribution for a specific platform. \r\n\r\nThe target platform can be configured with a parameter, by default it will build the generic distro without JDK, as before.\r\n\r\n- Build the **generic** distro, without JDK: \r\n`gradlew build`\r\n\r\n- Build the distro for **Windows** with emebedded JDK: \r\n`gradlew build -Pplatform=windows`\r\n\r\n- Build the distro for **Mac** with emebedded JDK: \r\n`gradlew build -Pplatform=mac`\r\n\r\n- Build the distro for **Linux** with emebedded JDK: \r\n`gradlew build -Pplatform=linux`\r\n\r\n- Build the distro for the **current** running platform: \r\n`gradlew build -Pplatform=current`\r\n\r\n----\r\nWhen a JDK platform is specified, the following additional steps will be done:\r\n- Download the requested JDK, from http://jdk.java.net/11/\r\n- Unpack the JDK\r\n- Move the JDK files to ```/jdk``` inside XP distribution\r\n- Update setenv.sh and setenv.bat scripts to setup JAVA_HOME (they are called by server.sh, server.bat)\r\n"},"comment":{"url":"https://api.github.com/repos/enonic/xp-distro/issues/comments/426915380","html_url":"https://github.com/enonic/xp-distro/issues/48#issuecomment-426915380","issue_url":"https://api.github.com/repos/enonic/xp-distro/issues/48","id":426915380,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjkxNTM4MA==","user":{"login":"aro","id":430739,"node_id":"MDQ6VXNlcjQzMDczOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/430739?v=4","gravatar_id":"","url":"https://api.github.com/users/aro","html_url":"https://github.com/aro","followers_url":"https://api.github.com/users/aro/followers","following_url":"https://api.github.com/users/aro/following{/other_user}","gists_url":"https://api.github.com/users/aro/gists{/gist_id}","starred_url":"https://api.github.com/users/aro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aro/subscriptions","organizations_url":"https://api.github.com/users/aro/orgs","repos_url":"https://api.github.com/users/aro/repos","events_url":"https://api.github.com/users/aro/events{/privacy}","received_events_url":"https://api.github.com/users/aro/received_events","type":"User","site_admin":false},"created_at":"2018-10-04T07:35:08Z","updated_at":"2018-10-04T07:35:08Z","author_association":"MEMBER","body":"There is a site providing binaries for the different platforms:  https://adoptopenjdk.net\r\n\r\nThey even have a REST API to get the list of versions (release, nightly builds,..) with links to download:\r\n\r\n  https://api.adoptopenjdk.net/v2/info/releases/openjdk11\r\n\r\nConsider fetching the JDK distributions from [AdoptOpenJDK](https://adoptopenjdk.net/about.html)."}}
{"actor":{"display_login":"aro"}}