{"action":"closed","number":315,"pull_request":{"url":"https://api.github.com/repos/Datawheel/canon/pulls/315","id":234438528,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NDM4NTI4","html_url":"https://github.com/Datawheel/canon/pull/315","diff_url":"https://github.com/Datawheel/canon/pull/315.diff","patch_url":"https://github.com/Datawheel/canon/pull/315.patch","issue_url":"https://api.github.com/repos/Datawheel/canon/issues/315","number":315,"state":"closed","locked":false,"title":"[cms] changes formatter get from localjs to db","user":{"login":"jhmullen","id":1714292,"node_id":"MDQ6VXNlcjE3MTQyOTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1714292?v=4","gravatar_id":"","url":"https://api.github.com/users/jhmullen","html_url":"https://github.com/jhmullen","followers_url":"https://api.github.com/users/jhmullen/followers","following_url":"https://api.github.com/users/jhmullen/following{/other_user}","gists_url":"https://api.github.com/users/jhmullen/gists{/gist_id}","starred_url":"https://api.github.com/users/jhmullen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhmullen/subscriptions","organizations_url":"https://api.github.com/users/jhmullen/orgs","repos_url":"https://api.github.com/users/jhmullen/repos","events_url":"https://api.github.com/users/jhmullen/events{/privacy}","received_events_url":"https://api.github.com/users/jhmullen/received_events","type":"User","site_admin":false},"body":"The ability to \"seed\" a database via a model is not yet part of canon. The eventual plan will be for canon to fill the `formatter` table using `seed` content from the model, but this is not yet implemented.\r\n\r\nAs a stop-gap, it was temporarily decided that formatters in the CMS would load from a bundled js file. However, this means that when a current user of canon uses the CMS, adding new formatters to the db has no effect.\r\n\r\nThis PR changes it back to the original functionality: Load the formatters from the DB.  Note that this will cause NEW installations of the canon cms to have an empty array of formatters, and they will need to be added to the DB manually, until the `seed` functionality is added to canon. ","created_at":"2018-11-28T22:00:28Z","updated_at":"2018-11-28T22:10:38Z","closed_at":"2018-11-28T22:10:38Z","merged_at":"2018-11-28T22:10:38Z","merge_commit_sha":"f8b78c606110f8e7de54f9721ed1aede44bf1678","assignee":null,"assignees":[],"requested_reviewers":[{"login":"davelandry","id":1847581,"node_id":"MDQ6VXNlcjE4NDc1ODE=","avatar_url":"https://avatars0.githubusercontent.com/u/1847581?v=4","gravatar_id":"","url":"https://api.github.com/users/davelandry","html_url":"https://github.com/davelandry","followers_url":"https://api.github.com/users/davelandry/followers","following_url":"https://api.github.com/users/davelandry/following{/other_user}","gists_url":"https://api.github.com/users/davelandry/gists{/gist_id}","starred_url":"https://api.github.com/users/davelandry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davelandry/subscriptions","organizations_url":"https://api.github.com/users/davelandry/orgs","repos_url":"https://api.github.com/users/davelandry/repos","events_url":"https://api.github.com/users/davelandry/events{/privacy}","received_events_url":"https://api.github.com/users/davelandry/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Datawheel/canon/pulls/315/commits","review_comments_url":"https://api.github.com/repos/Datawheel/canon/pulls/315/comments","review_comment_url":"https://api.github.com/repos/Datawheel/canon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Datawheel/canon/issues/315/comments","statuses_url":"https://api.github.com/repos/Datawheel/canon/statuses/009e124abc038b41f08722b4f8902c5f28a1eb59","head":{"label":"Datawheel:fix-formatters-from-db","ref":"fix-formatters-from-db","sha":"009e124abc038b41f08722b4f8902c5f28a1eb59","user":{"login":"Datawheel","id":12820474,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODIwNDc0","avatar_url":"https://avatars3.githubusercontent.com/u/12820474?v=4","gravatar_id":"","url":"https://api.github.com/users/Datawheel","html_url":"https://github.com/Datawheel","followers_url":"https://api.github.com/users/Datawheel/followers","following_url":"https://api.github.com/users/Datawheel/following{/other_user}","gists_url":"https://api.github.com/users/Datawheel/gists{/gist_id}","starred_url":"https://api.github.com/users/Datawheel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Datawheel/subscriptions","organizations_url":"https://api.github.com/users/Datawheel/orgs","repos_url":"https://api.github.com/users/Datawheel/repos","events_url":"https://api.github.com/users/Datawheel/events{/privacy}","received_events_url":"https://api.github.com/users/Datawheel/received_events","type":"Organization","site_admin":false},"repo":{"id":81867207,"node_id":"MDEwOlJlcG9zaXRvcnk4MTg2NzIwNw==","name":"canon","full_name":"Datawheel/canon","private":false,"owner":{"login":"Datawheel","id":12820474,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODIwNDc0","avatar_url":"https://avatars3.githubusercontent.com/u/12820474?v=4","gravatar_id":"","url":"https://api.github.com/users/Datawheel","html_url":"https://github.com/Datawheel","followers_url":"https://api.github.com/users/Datawheel/followers","following_url":"https://api.github.com/users/Datawheel/following{/other_user}","gists_url":"https://api.github.com/users/Datawheel/gists{/gist_id}","starred_url":"https://api.github.com/users/Datawheel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Datawheel/subscriptions","organizations_url":"https://api.github.com/users/Datawheel/orgs","repos_url":"https://api.github.com/users/Datawheel/repos","events_url":"https://api.github.com/users/Datawheel/events{/privacy}","received_events_url":"https://api.github.com/users/Datawheel/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Datawheel/canon","description":"Reusable React environment and components for creating visualization engines.","fork":false,"url":"https://api.github.com/repos/Datawheel/canon","forks_url":"https://api.github.com/repos/Datawheel/canon/forks","keys_url":"https://api.github.com/repos/Datawheel/canon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Datawheel/canon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Datawheel/canon/teams","hooks_url":"https://api.github.com/repos/Datawheel/canon/hooks","issue_events_url":"https://api.github.com/repos/Datawheel/canon/issues/events{/number}","events_url":"https://api.github.com/repos/Datawheel/canon/events","assignees_url":"https://api.github.com/repos/Datawheel/canon/assignees{/user}","branches_url":"https://api.github.com/repos/Datawheel/canon/branches{/branch}","tags_url":"https://api.github.com/repos/Datawheel/canon/tags","blobs_url":"https://api.github.com/repos/Datawheel/canon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Datawheel/canon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Datawheel/canon/git/refs{/sha}","trees_url":"https://api.github.com/repos/Datawheel/canon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Datawheel/canon/statuses/{sha}","languages_url":"https://api.github.com/repos/Datawheel/canon/languages","stargazers_url":"https://api.github.com/repos/Datawheel/canon/stargazers","contributors_url":"https://api.github.com/repos/Datawheel/canon/contributors","subscribers_url":"https://api.github.com/repos/Datawheel/canon/subscribers","subscription_url":"https://api.github.com/repos/Datawheel/canon/subscription","commits_url":"https://api.github.com/repos/Datawheel/canon/commits{/sha}","git_commits_url":"https://api.github.com/repos/Datawheel/canon/git/commits{/sha}","comments_url":"https://api.github.com/repos/Datawheel/canon/comments{/number}","issue_comment_url":"https://api.github.com/repos/Datawheel/canon/issues/comments{/number}","contents_url":"https://api.github.com/repos/Datawheel/canon/contents/{+path}","compare_url":"https://api.github.com/repos/Datawheel/canon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Datawheel/canon/merges","archive_url":"https://api.github.com/repos/Datawheel/canon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Datawheel/canon/downloads","issues_url":"https://api.github.com/repos/Datawheel/canon/issues{/number}","pulls_url":"https://api.github.com/repos/Datawheel/canon/pulls{/number}","milestones_url":"https://api.github.com/repos/Datawheel/canon/milestones{/number}","notifications_url":"https://api.github.com/repos/Datawheel/canon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Datawheel/canon/labels{/name}","releases_url":"https://api.github.com/repos/Datawheel/canon/releases{/id}","deployments_url":"https://api.github.com/repos/Datawheel/canon/deployments","created_at":"2017-02-13T20:17:04Z","updated_at":"2018-11-28T19:21:38Z","pushed_at":"2018-11-28T22:10:38Z","git_url":"git://github.com/Datawheel/canon.git","ssh_url":"git@github.com:Datawheel/canon.git","clone_url":"https://github.com/Datawheel/canon.git","svn_url":"https://github.com/Datawheel/canon","homepage":null,"size":7417,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1,"open_issues":55,"watchers":10,"default_branch":"master"}},"base":{"label":"Datawheel:master","ref":"master","sha":"adfd0be011b41c0ac38a0ac0b76d349b046108f6","user":{"login":"Datawheel","id":12820474,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODIwNDc0","avatar_url":"https://avatars3.githubusercontent.com/u/12820474?v=4","gravatar_id":"","url":"https://api.github.com/users/Datawheel","html_url":"https://github.com/Datawheel","followers_url":"https://api.github.com/users/Datawheel/followers","following_url":"https://api.github.com/users/Datawheel/following{/other_user}","gists_url":"https://api.github.com/users/Datawheel/gists{/gist_id}","starred_url":"https://api.github.com/users/Datawheel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Datawheel/subscriptions","organizations_url":"https://api.github.com/users/Datawheel/orgs","repos_url":"https://api.github.com/users/Datawheel/repos","events_url":"https://api.github.com/users/Datawheel/events{/privacy}","received_events_url":"https://api.github.com/users/Datawheel/received_events","type":"Organization","site_admin":false},"repo":{"id":81867207,"node_id":"MDEwOlJlcG9zaXRvcnk4MTg2NzIwNw==","name":"canon","full_name":"Datawheel/canon","private":false,"owner":{"login":"Datawheel","id":12820474,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODIwNDc0","avatar_url":"https://avatars3.githubusercontent.com/u/12820474?v=4","gravatar_id":"","url":"https://api.github.com/users/Datawheel","html_url":"https://github.com/Datawheel","followers_url":"https://api.github.com/users/Datawheel/followers","following_url":"https://api.github.com/users/Datawheel/following{/other_user}","gists_url":"https://api.github.com/users/Datawheel/gists{/gist_id}","starred_url":"https://api.github.com/users/Datawheel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Datawheel/subscriptions","organizations_url":"https://api.github.com/users/Datawheel/orgs","repos_url":"https://api.github.com/users/Datawheel/repos","events_url":"https://api.github.com/users/Datawheel/events{/privacy}","received_events_url":"https://api.github.com/users/Datawheel/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Datawheel/canon","description":"Reusable React environment and components for creating visualization engines.","fork":false,"url":"https://api.github.com/repos/Datawheel/canon","forks_url":"https://api.github.com/repos/Datawheel/canon/forks","keys_url":"https://api.github.com/repos/Datawheel/canon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Datawheel/canon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Datawheel/canon/teams","hooks_url":"https://api.github.com/repos/Datawheel/canon/hooks","issue_events_url":"https://api.github.com/repos/Datawheel/canon/issues/events{/number}","events_url":"https://api.github.com/repos/Datawheel/canon/events","assignees_url":"https://api.github.com/repos/Datawheel/canon/assignees{/user}","branches_url":"https://api.github.com/repos/Datawheel/canon/branches{/branch}","tags_url":"https://api.github.com/repos/Datawheel/canon/tags","blobs_url":"https://api.github.com/repos/Datawheel/canon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Datawheel/canon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Datawheel/canon/git/refs{/sha}","trees_url":"https://api.github.com/repos/Datawheel/canon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Datawheel/canon/statuses/{sha}","languages_url":"https://api.github.com/repos/Datawheel/canon/languages","stargazers_url":"https://api.github.com/repos/Datawheel/canon/stargazers","contributors_url":"https://api.github.com/repos/Datawheel/canon/contributors","subscribers_url":"https://api.github.com/repos/Datawheel/canon/subscribers","subscription_url":"https://api.github.com/repos/Datawheel/canon/subscription","commits_url":"https://api.github.com/repos/Datawheel/canon/commits{/sha}","git_commits_url":"https://api.github.com/repos/Datawheel/canon/git/commits{/sha}","comments_url":"https://api.github.com/repos/Datawheel/canon/comments{/number}","issue_comment_url":"https://api.github.com/repos/Datawheel/canon/issues/comments{/number}","contents_url":"https://api.github.com/repos/Datawheel/canon/contents/{+path}","compare_url":"https://api.github.com/repos/Datawheel/canon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Datawheel/canon/merges","archive_url":"https://api.github.com/repos/Datawheel/canon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Datawheel/canon/downloads","issues_url":"https://api.github.com/repos/Datawheel/canon/issues{/number}","pulls_url":"https://api.github.com/repos/Datawheel/canon/pulls{/number}","milestones_url":"https://api.github.com/repos/Datawheel/canon/milestones{/number}","notifications_url":"https://api.github.com/repos/Datawheel/canon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Datawheel/canon/labels{/name}","releases_url":"https://api.github.com/repos/Datawheel/canon/releases{/id}","deployments_url":"https://api.github.com/repos/Datawheel/canon/deployments","created_at":"2017-02-13T20:17:04Z","updated_at":"2018-11-28T19:21:38Z","pushed_at":"2018-11-28T22:10:38Z","git_url":"git://github.com/Datawheel/canon.git","ssh_url":"git@github.com:Datawheel/canon.git","clone_url":"https://github.com/Datawheel/canon.git","svn_url":"https://github.com/Datawheel/canon","homepage":null,"size":7417,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1,"open_issues":55,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Datawheel/canon/pulls/315"},"html":{"href":"https://github.com/Datawheel/canon/pull/315"},"issue":{"href":"https://api.github.com/repos/Datawheel/canon/issues/315"},"comments":{"href":"https://api.github.com/repos/Datawheel/canon/issues/315/comments"},"review_comments":{"href":"https://api.github.com/repos/Datawheel/canon/pulls/315/comments"},"review_comment":{"href":"https://api.github.com/repos/Datawheel/canon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Datawheel/canon/pulls/315/commits"},"statuses":{"href":"https://api.github.com/repos/Datawheel/canon/statuses/009e124abc038b41f08722b4f8902c5f28a1eb59"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"davelandry","id":1847581,"node_id":"MDQ6VXNlcjE4NDc1ODE=","avatar_url":"https://avatars0.githubusercontent.com/u/1847581?v=4","gravatar_id":"","url":"https://api.github.com/users/davelandry","html_url":"https://github.com/davelandry","followers_url":"https://api.github.com/users/davelandry/followers","following_url":"https://api.github.com/users/davelandry/following{/other_user}","gists_url":"https://api.github.com/users/davelandry/gists{/gist_id}","starred_url":"https://api.github.com/users/davelandry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davelandry/subscriptions","organizations_url":"https://api.github.com/users/davelandry/orgs","repos_url":"https://api.github.com/users/davelandry/repos","events_url":"https://api.github.com/users/davelandry/events{/privacy}","received_events_url":"https://api.github.com/users/davelandry/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":6,"changed_files":1}}
{"actor":{"display_login":"davelandry"}}