{"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/presto/pulls/comments/237305667","pull_request_review_id":179571711,"id":237305667,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzMwNTY2Nw==","diff_hunk":"@@ -222,13 +218,9 @@ protected void setup(Binder binder)\n         // node monitor\n         binder.bind(ClusterSizeMonitor.class).in(Scopes.SINGLETON);\n \n-        // statistics calculator\n+        // stats and cost calculators\n         binder.install(new StatsCalculatorModule());\n-\n-        // cost calculator\n-        binder.bind(CostCalculator.class).to(CostCalculatorUsingExchanges.class).in(Scopes.SINGLETON);\n-        binder.bind(CostCalculator.class).annotatedWith(EstimatedExchanges.class).to(CostCalculatorWithEstimatedExchanges.class).in(Scopes.SINGLETON);\n-        binder.bind(CostComparator.class).in(Scopes.SINGLETON);\n+        binder.install(new CostCalculatorModule());","path":"presto-main/src/main/java/com/facebook/presto/server/CoordinatorModule.java","position":25,"original_position":25,"commit_id":"4170e4438c65a7790b709705fc8c7a264dcbd765","original_commit_id":"d3cf53244f50efc1ff5db58bb55a565de99e987f","user":{"login":"arhimondr","id":5570988,"node_id":"MDQ6VXNlcjU1NzA5ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/5570988?v=4","gravatar_id":"","url":"https://api.github.com/users/arhimondr","html_url":"https://github.com/arhimondr","followers_url":"https://api.github.com/users/arhimondr/followers","following_url":"https://api.github.com/users/arhimondr/following{/other_user}","gists_url":"https://api.github.com/users/arhimondr/gists{/gist_id}","starred_url":"https://api.github.com/users/arhimondr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arhimondr/subscriptions","organizations_url":"https://api.github.com/users/arhimondr/orgs","repos_url":"https://api.github.com/users/arhimondr/repos","events_url":"https://api.github.com/users/arhimondr/events{/privacy}","received_events_url":"https://api.github.com/users/arhimondr/received_events","type":"User","site_admin":false},"body":"I'm dropping this commit. It is not needed for what i'm doing now.","created_at":"2018-11-28T23:44:39Z","updated_at":"2018-11-28T23:44:39Z","html_url":"https://github.com/prestodb/presto/pull/11982#discussion_r237305667","pull_request_url":"https://api.github.com/repos/prestodb/presto/pulls/11982","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments/237305667"},"html":{"href":"https://github.com/prestodb/presto/pull/11982#discussion_r237305667"},"pull_request":{"href":"https://api.github.com/repos/prestodb/presto/pulls/11982"}},"in_reply_to_id":237279909},"pull_request":{"url":"https://api.github.com/repos/prestodb/presto/pulls/11982","id":233726599,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNzI2NTk5","html_url":"https://github.com/prestodb/presto/pull/11982","diff_url":"https://github.com/prestodb/presto/pull/11982.diff","patch_url":"https://github.com/prestodb/presto/pull/11982.patch","issue_url":"https://api.github.com/repos/prestodb/presto/issues/11982","number":11982,"state":"open","locked":false,"title":"Stats based join distribution type","user":{"login":"arhimondr","id":5570988,"node_id":"MDQ6VXNlcjU1NzA5ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/5570988?v=4","gravatar_id":"","url":"https://api.github.com/users/arhimondr","html_url":"https://github.com/arhimondr","followers_url":"https://api.github.com/users/arhimondr/followers","following_url":"https://api.github.com/users/arhimondr/following{/other_user}","gists_url":"https://api.github.com/users/arhimondr/gists{/gist_id}","starred_url":"https://api.github.com/users/arhimondr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arhimondr/subscriptions","organizations_url":"https://api.github.com/users/arhimondr/orgs","repos_url":"https://api.github.com/users/arhimondr/repos","events_url":"https://api.github.com/users/arhimondr/events{/privacy}","received_events_url":"https://api.github.com/users/arhimondr/received_events","type":"User","site_admin":false},"body":"Resolves: https://github.com/prestodb/presto/issues/11745","created_at":"2018-11-26T23:08:23Z","updated_at":"2018-11-28T23:44:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab158aec3ac0530670b41cdc343c28a634c8b51c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sopel39","id":5989165,"node_id":"MDQ6VXNlcjU5ODkxNjU=","avatar_url":"https://avatars1.githubusercontent.com/u/5989165?v=4","gravatar_id":"","url":"https://api.github.com/users/sopel39","html_url":"https://github.com/sopel39","followers_url":"https://api.github.com/users/sopel39/followers","following_url":"https://api.github.com/users/sopel39/following{/other_user}","gists_url":"https://api.github.com/users/sopel39/gists{/gist_id}","starred_url":"https://api.github.com/users/sopel39/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sopel39/subscriptions","organizations_url":"https://api.github.com/users/sopel39/orgs","repos_url":"https://api.github.com/users/sopel39/repos","events_url":"https://api.github.com/users/sopel39/events{/privacy}","received_events_url":"https://api.github.com/users/sopel39/received_events","type":"User","site_admin":false},{"login":"mbasmanova","id":27965151,"node_id":"MDQ6VXNlcjI3OTY1MTUx","avatar_url":"https://avatars3.githubusercontent.com/u/27965151?v=4","gravatar_id":"","url":"https://api.github.com/users/mbasmanova","html_url":"https://github.com/mbasmanova","followers_url":"https://api.github.com/users/mbasmanova/followers","following_url":"https://api.github.com/users/mbasmanova/following{/other_user}","gists_url":"https://api.github.com/users/mbasmanova/gists{/gist_id}","starred_url":"https://api.github.com/users/mbasmanova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbasmanova/subscriptions","organizations_url":"https://api.github.com/users/mbasmanova/orgs","repos_url":"https://api.github.com/users/mbasmanova/repos","events_url":"https://api.github.com/users/mbasmanova/events{/privacy}","received_events_url":"https://api.github.com/users/mbasmanova/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":196992743,"node_id":"MDU6TGFiZWwxOTY5OTI3NDM=","url":"https://api.github.com/repos/prestodb/presto/labels/CLA%20Signed","name":"CLA Signed","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/presto/pulls/11982/commits","review_comments_url":"https://api.github.com/repos/prestodb/presto/pulls/11982/comments","review_comment_url":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/presto/issues/11982/comments","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/4170e4438c65a7790b709705fc8c7a264dcbd765","head":{"label":"arhimondr:stats-based-join-distribution-type","ref":"stats-based-join-distribution-type","sha":"4170e4438c65a7790b709705fc8c7a264dcbd765","user":{"login":"arhimondr","id":5570988,"node_id":"MDQ6VXNlcjU1NzA5ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/5570988?v=4","gravatar_id":"","url":"https://api.github.com/users/arhimondr","html_url":"https://github.com/arhimondr","followers_url":"https://api.github.com/users/arhimondr/followers","following_url":"https://api.github.com/users/arhimondr/following{/other_user}","gists_url":"https://api.github.com/users/arhimondr/gists{/gist_id}","starred_url":"https://api.github.com/users/arhimondr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arhimondr/subscriptions","organizations_url":"https://api.github.com/users/arhimondr/orgs","repos_url":"https://api.github.com/users/arhimondr/repos","events_url":"https://api.github.com/users/arhimondr/events{/privacy}","received_events_url":"https://api.github.com/users/arhimondr/received_events","type":"User","site_admin":false},"repo":{"id":37681604,"node_id":"MDEwOlJlcG9zaXRvcnkzNzY4MTYwNA==","name":"presto","full_name":"arhimondr/presto","private":false,"owner":{"login":"arhimondr","id":5570988,"node_id":"MDQ6VXNlcjU1NzA5ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/5570988?v=4","gravatar_id":"","url":"https://api.github.com/users/arhimondr","html_url":"https://github.com/arhimondr","followers_url":"https://api.github.com/users/arhimondr/followers","following_url":"https://api.github.com/users/arhimondr/following{/other_user}","gists_url":"https://api.github.com/users/arhimondr/gists{/gist_id}","starred_url":"https://api.github.com/users/arhimondr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arhimondr/subscriptions","organizations_url":"https://api.github.com/users/arhimondr/orgs","repos_url":"https://api.github.com/users/arhimondr/repos","events_url":"https://api.github.com/users/arhimondr/events{/privacy}","received_events_url":"https://api.github.com/users/arhimondr/received_events","type":"User","site_admin":false},"html_url":"https://github.com/arhimondr/presto","description":"Distributed SQL query engine for running interactive analytic queries against big data sources.","fork":true,"url":"https://api.github.com/repos/arhimondr/presto","forks_url":"https://api.github.com/repos/arhimondr/presto/forks","keys_url":"https://api.github.com/repos/arhimondr/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arhimondr/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arhimondr/presto/teams","hooks_url":"https://api.github.com/repos/arhimondr/presto/hooks","issue_events_url":"https://api.github.com/repos/arhimondr/presto/issues/events{/number}","events_url":"https://api.github.com/repos/arhimondr/presto/events","assignees_url":"https://api.github.com/repos/arhimondr/presto/assignees{/user}","branches_url":"https://api.github.com/repos/arhimondr/presto/branches{/branch}","tags_url":"https://api.github.com/repos/arhimondr/presto/tags","blobs_url":"https://api.github.com/repos/arhimondr/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arhimondr/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arhimondr/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/arhimondr/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arhimondr/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/arhimondr/presto/languages","stargazers_url":"https://api.github.com/repos/arhimondr/presto/stargazers","contributors_url":"https://api.github.com/repos/arhimondr/presto/contributors","subscribers_url":"https://api.github.com/repos/arhimondr/presto/subscribers","subscription_url":"https://api.github.com/repos/arhimondr/presto/subscription","commits_url":"https://api.github.com/repos/arhimondr/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/arhimondr/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/arhimondr/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/arhimondr/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/arhimondr/presto/contents/{+path}","compare_url":"https://api.github.com/repos/arhimondr/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arhimondr/presto/merges","archive_url":"https://api.github.com/repos/arhimondr/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arhimondr/presto/downloads","issues_url":"https://api.github.com/repos/arhimondr/presto/issues{/number}","pulls_url":"https://api.github.com/repos/arhimondr/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/arhimondr/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/arhimondr/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arhimondr/presto/labels{/name}","releases_url":"https://api.github.com/repos/arhimondr/presto/releases{/id}","deployments_url":"https://api.github.com/repos/arhimondr/presto/deployments","created_at":"2015-06-18T19:57:44Z","updated_at":"2018-09-12T17:25:00Z","pushed_at":"2018-11-28T21:09:42Z","git_url":"git://github.com/arhimondr/presto.git","ssh_url":"git@github.com:arhimondr/presto.git","clone_url":"https://github.com/arhimondr/presto.git","svn_url":"https://github.com/arhimondr/presto","homepage":"https://prestodb.io","size":104406,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"49b3f74d13143412603cba14f196e0319c847ef1","user":{"login":"prestodb","id":6882181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4ODIxODE=","avatar_url":"https://avatars0.githubusercontent.com/u/6882181?v=4","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"node_id":"MDEwOlJlcG9zaXRvcnk1MzQ5NTY1","name":"presto","full_name":"prestodb/presto","private":false,"owner":{"login":"prestodb","id":6882181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4ODIxODE=","avatar_url":"https://avatars0.githubusercontent.com/u/6882181?v=4","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/prestodb/presto","description":"Distributed SQL query engine for big data","fork":false,"url":"https://api.github.com/repos/prestodb/presto","forks_url":"https://api.github.com/repos/prestodb/presto/forks","keys_url":"https://api.github.com/repos/prestodb/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto/teams","hooks_url":"https://api.github.com/repos/prestodb/presto/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto/events","assignees_url":"https://api.github.com/repos/prestodb/presto/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto/tags","blobs_url":"https://api.github.com/repos/prestodb/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto/subscription","commits_url":"https://api.github.com/repos/prestodb/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/presto/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto/merges","archive_url":"https://api.github.com/repos/prestodb/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto/downloads","issues_url":"https://api.github.com/repos/prestodb/presto/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/presto/deployments","created_at":"2012-08-09T01:03:37Z","updated_at":"2018-11-28T22:01:38Z","pushed_at":"2018-11-28T22:44:22Z","git_url":"git://github.com/prestodb/presto.git","ssh_url":"git@github.com:prestodb/presto.git","clone_url":"https://github.com/prestodb/presto.git","svn_url":"https://github.com/prestodb/presto","homepage":"https://prestodb.io","size":104777,"stargazers_count":8351,"watchers_count":8351,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2838,"mirror_url":null,"archived":false,"open_issues_count":1460,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2838,"open_issues":1460,"watchers":8351,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/11982"},"html":{"href":"https://github.com/prestodb/presto/pull/11982"},"issue":{"href":"https://api.github.com/repos/prestodb/presto/issues/11982"},"comments":{"href":"https://api.github.com/repos/prestodb/presto/issues/11982/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/presto/pulls/11982/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/presto/pulls/11982/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/presto/statuses/4170e4438c65a7790b709705fc8c7a264dcbd765"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"arhimondr"}}