{"action":"created","comment":{"url":"https://api.github.com/repos/artsy/positron/pulls/comments/176518372","pull_request_review_id":106236901,"id":176518372,"diff_hunk":"@@ -18,7 +19,12 @@ export class AutocompleteListMetaphysics extends Component {\n     model: PropTypes.string,\n     onChangeArticleAction: PropTypes.func,\n     placeholder: PropTypes.string,\n-    user: PropTypes.object\n+    user: PropTypes.object,\n+    type: PropTypes.string\n+  }","path":"client/apps/edit/components/admin/components/autocomplete_list_metaphysics.jsx","position":15,"original_position":15,"commit_id":"b89c66725dcd639dbe46ebc73366f15d950328aa","original_commit_id":"5afc923af745fe720c36c47b4727026e45245f18","user":{"login":"eessex","id":1497424,"avatar_url":"https://avatars3.githubusercontent.com/u/1497424?v=4","gravatar_id":"","url":"https://api.github.com/users/eessex","html_url":"https://github.com/eessex","followers_url":"https://api.github.com/users/eessex/followers","following_url":"https://api.github.com/users/eessex/following{/other_user}","gists_url":"https://api.github.com/users/eessex/gists{/gist_id}","starred_url":"https://api.github.com/users/eessex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eessex/subscriptions","organizations_url":"https://api.github.com/users/eessex/orgs","repos_url":"https://api.github.com/users/eessex/repos","events_url":"https://api.github.com/users/eessex/events{/privacy}","received_events_url":"https://api.github.com/users/eessex/received_events","type":"User","site_admin":false},"body":"I know this comes from the legacy code but I find 'select' versus list to be pretty vague, and wonder if it might make sense to use a boolean of `limitOne` to invoke the select component, rather than a type. ","created_at":"2018-03-22T18:01:51Z","updated_at":"2018-03-22T18:01:51Z","html_url":"https://github.com/artsy/positron/pull/1655#discussion_r176518372","pull_request_url":"https://api.github.com/repos/artsy/positron/pulls/1655","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/artsy/positron/pulls/comments/176518372"},"html":{"href":"https://github.com/artsy/positron/pull/1655#discussion_r176518372"},"pull_request":{"href":"https://api.github.com/repos/artsy/positron/pulls/1655"}}},"pull_request":{"url":"https://api.github.com/repos/artsy/positron/pulls/1655","id":176634625,"html_url":"https://github.com/artsy/positron/pull/1655","diff_url":"https://github.com/artsy/positron/pull/1655.diff","patch_url":"https://github.com/artsy/positron/pull/1655.patch","issue_url":"https://api.github.com/repos/artsy/positron/issues/1655","number":1655,"state":"open","locked":false,"title":"[WIP] Add AutocompleteSelect to limit artist bio field","user":{"login":"kanaabe","id":2236794,"avatar_url":"https://avatars3.githubusercontent.com/u/2236794?v=4","gravatar_id":"","url":"https://api.github.com/users/kanaabe","html_url":"https://github.com/kanaabe","followers_url":"https://api.github.com/users/kanaabe/followers","following_url":"https://api.github.com/users/kanaabe/following{/other_user}","gists_url":"https://api.github.com/users/kanaabe/gists{/gist_id}","starred_url":"https://api.github.com/users/kanaabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanaabe/subscriptions","organizations_url":"https://api.github.com/users/kanaabe/orgs","repos_url":"https://api.github.com/users/kanaabe/repos","events_url":"https://api.github.com/users/kanaabe/events{/privacy}","received_events_url":"https://api.github.com/users/kanaabe/received_events","type":"User","site_admin":false},"body":"Still WIP but the idea is that we should be able to select items that aren't saved array fields. It becomes too much hair splitting to hack this into AutocompleteList so this creates a new type which is functionally the same as the old AutocompleteSelect. Currently biography_for_artist_id is the only place that uses this, but this field is currently broken so we need to support it.\r\n\r\nTODO\r\n- [ ] Fix remaining bugs with save/add/remove\r\n- [ ] Fix bug with removing an item in inline-list\r\n- [ ] Rename AutocompleteListMetaphysics to be more generic\r\n- [ ] Move AutocompleteMetaphysics to /components\r\n- [ ] Tests\r\n","created_at":"2018-03-21T23:12:43Z","updated_at":"2018-03-22T18:01:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eea019e3cab8a8fa7e5fd943ecad94c966e58983","assignee":{"login":"kanaabe","id":2236794,"avatar_url":"https://avatars3.githubusercontent.com/u/2236794?v=4","gravatar_id":"","url":"https://api.github.com/users/kanaabe","html_url":"https://github.com/kanaabe","followers_url":"https://api.github.com/users/kanaabe/followers","following_url":"https://api.github.com/users/kanaabe/following{/other_user}","gists_url":"https://api.github.com/users/kanaabe/gists{/gist_id}","starred_url":"https://api.github.com/users/kanaabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanaabe/subscriptions","organizations_url":"https://api.github.com/users/kanaabe/orgs","repos_url":"https://api.github.com/users/kanaabe/repos","events_url":"https://api.github.com/users/kanaabe/events{/privacy}","received_events_url":"https://api.github.com/users/kanaabe/received_events","type":"User","site_admin":false},"assignees":[{"login":"kanaabe","id":2236794,"avatar_url":"https://avatars3.githubusercontent.com/u/2236794?v=4","gravatar_id":"","url":"https://api.github.com/users/kanaabe","html_url":"https://github.com/kanaabe","followers_url":"https://api.github.com/users/kanaabe/followers","following_url":"https://api.github.com/users/kanaabe/following{/other_user}","gists_url":"https://api.github.com/users/kanaabe/gists{/gist_id}","starred_url":"https://api.github.com/users/kanaabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanaabe/subscriptions","organizations_url":"https://api.github.com/users/kanaabe/orgs","repos_url":"https://api.github.com/users/kanaabe/repos","events_url":"https://api.github.com/users/kanaabe/events{/privacy}","received_events_url":"https://api.github.com/users/kanaabe/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":629993685,"url":"https://api.github.com/repos/artsy/positron/labels/In%20progress","name":"In progress","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/artsy/positron/pulls/1655/commits","review_comments_url":"https://api.github.com/repos/artsy/positron/pulls/1655/comments","review_comment_url":"https://api.github.com/repos/artsy/positron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/artsy/positron/issues/1655/comments","statuses_url":"https://api.github.com/repos/artsy/positron/statuses/b89c66725dcd639dbe46ebc73366f15d950328aa","head":{"label":"kanaabe:limit-bio","ref":"limit-bio","sha":"b89c66725dcd639dbe46ebc73366f15d950328aa","user":{"login":"kanaabe","id":2236794,"avatar_url":"https://avatars3.githubusercontent.com/u/2236794?v=4","gravatar_id":"","url":"https://api.github.com/users/kanaabe","html_url":"https://github.com/kanaabe","followers_url":"https://api.github.com/users/kanaabe/followers","following_url":"https://api.github.com/users/kanaabe/following{/other_user}","gists_url":"https://api.github.com/users/kanaabe/gists{/gist_id}","starred_url":"https://api.github.com/users/kanaabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanaabe/subscriptions","organizations_url":"https://api.github.com/users/kanaabe/orgs","repos_url":"https://api.github.com/users/kanaabe/repos","events_url":"https://api.github.com/users/kanaabe/events{/privacy}","received_events_url":"https://api.github.com/users/kanaabe/received_events","type":"User","site_admin":false},"repo":{"id":31676927,"name":"positron","full_name":"kanaabe/positron","owner":{"login":"kanaabe","id":2236794,"avatar_url":"https://avatars3.githubusercontent.com/u/2236794?v=4","gravatar_id":"","url":"https://api.github.com/users/kanaabe","html_url":"https://github.com/kanaabe","followers_url":"https://api.github.com/users/kanaabe/followers","following_url":"https://api.github.com/users/kanaabe/following{/other_user}","gists_url":"https://api.github.com/users/kanaabe/gists{/gist_id}","starred_url":"https://api.github.com/users/kanaabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanaabe/subscriptions","organizations_url":"https://api.github.com/users/kanaabe/orgs","repos_url":"https://api.github.com/users/kanaabe/repos","events_url":"https://api.github.com/users/kanaabe/events{/privacy}","received_events_url":"https://api.github.com/users/kanaabe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kanaabe/positron","description":"Otherwise known as Artsy Writer. The back-end posting tool for publishing articles on Artsy.","fork":true,"url":"https://api.github.com/repos/kanaabe/positron","forks_url":"https://api.github.com/repos/kanaabe/positron/forks","keys_url":"https://api.github.com/repos/kanaabe/positron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kanaabe/positron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kanaabe/positron/teams","hooks_url":"https://api.github.com/repos/kanaabe/positron/hooks","issue_events_url":"https://api.github.com/repos/kanaabe/positron/issues/events{/number}","events_url":"https://api.github.com/repos/kanaabe/positron/events","assignees_url":"https://api.github.com/repos/kanaabe/positron/assignees{/user}","branches_url":"https://api.github.com/repos/kanaabe/positron/branches{/branch}","tags_url":"https://api.github.com/repos/kanaabe/positron/tags","blobs_url":"https://api.github.com/repos/kanaabe/positron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kanaabe/positron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kanaabe/positron/git/refs{/sha}","trees_url":"https://api.github.com/repos/kanaabe/positron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kanaabe/positron/statuses/{sha}","languages_url":"https://api.github.com/repos/kanaabe/positron/languages","stargazers_url":"https://api.github.com/repos/kanaabe/positron/stargazers","contributors_url":"https://api.github.com/repos/kanaabe/positron/contributors","subscribers_url":"https://api.github.com/repos/kanaabe/positron/subscribers","subscription_url":"https://api.github.com/repos/kanaabe/positron/subscription","commits_url":"https://api.github.com/repos/kanaabe/positron/commits{/sha}","git_commits_url":"https://api.github.com/repos/kanaabe/positron/git/commits{/sha}","comments_url":"https://api.github.com/repos/kanaabe/positron/comments{/number}","issue_comment_url":"https://api.github.com/repos/kanaabe/positron/issues/comments{/number}","contents_url":"https://api.github.com/repos/kanaabe/positron/contents/{+path}","compare_url":"https://api.github.com/repos/kanaabe/positron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kanaabe/positron/merges","archive_url":"https://api.github.com/repos/kanaabe/positron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kanaabe/positron/downloads","issues_url":"https://api.github.com/repos/kanaabe/positron/issues{/number}","pulls_url":"https://api.github.com/repos/kanaabe/positron/pulls{/number}","milestones_url":"https://api.github.com/repos/kanaabe/positron/milestones{/number}","notifications_url":"https://api.github.com/repos/kanaabe/positron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kanaabe/positron/labels{/name}","releases_url":"https://api.github.com/repos/kanaabe/positron/releases{/id}","deployments_url":"https://api.github.com/repos/kanaabe/positron/deployments","created_at":"2015-03-04T19:57:46Z","updated_at":"2016-03-08T18:13:02Z","pushed_at":"2018-03-22T18:00:17Z","git_url":"git://github.com/kanaabe/positron.git","ssh_url":"git@github.com:kanaabe/positron.git","clone_url":"https://github.com/kanaabe/positron.git","svn_url":"https://github.com/kanaabe/positron","homepage":"","size":10088,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"artsy:master","ref":"master","sha":"04a161f64812013e781a892b8686aeb5ea7c1b25","user":{"login":"artsy","id":546231,"avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":23808195,"name":"positron","full_name":"artsy/positron","owner":{"login":"artsy","id":546231,"avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/positron","description":"Positron is Artsy Writer or the editorial tool for Artsy.","fork":false,"url":"https://api.github.com/repos/artsy/positron","forks_url":"https://api.github.com/repos/artsy/positron/forks","keys_url":"https://api.github.com/repos/artsy/positron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/positron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/positron/teams","hooks_url":"https://api.github.com/repos/artsy/positron/hooks","issue_events_url":"https://api.github.com/repos/artsy/positron/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/positron/events","assignees_url":"https://api.github.com/repos/artsy/positron/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/positron/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/positron/tags","blobs_url":"https://api.github.com/repos/artsy/positron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/positron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/positron/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/positron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/positron/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/positron/languages","stargazers_url":"https://api.github.com/repos/artsy/positron/stargazers","contributors_url":"https://api.github.com/repos/artsy/positron/contributors","subscribers_url":"https://api.github.com/repos/artsy/positron/subscribers","subscription_url":"https://api.github.com/repos/artsy/positron/subscription","commits_url":"https://api.github.com/repos/artsy/positron/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/positron/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/positron/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/positron/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/positron/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/positron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/positron/merges","archive_url":"https://api.github.com/repos/artsy/positron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/positron/downloads","issues_url":"https://api.github.com/repos/artsy/positron/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/positron/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/positron/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/positron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/positron/labels{/name}","releases_url":"https://api.github.com/repos/artsy/positron/releases{/id}","deployments_url":"https://api.github.com/repos/artsy/positron/deployments","created_at":"2014-09-08T21:02:13Z","updated_at":"2018-03-22T15:47:29Z","pushed_at":"2018-03-22T18:00:17Z","git_url":"git://github.com/artsy/positron.git","ssh_url":"git@github.com:artsy/positron.git","clone_url":"https://github.com/artsy/positron.git","svn_url":"https://github.com/artsy/positron","homepage":"","size":10033,"stargazers_count":36,"watchers_count":36,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":110,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":26,"open_issues":110,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/artsy/positron/pulls/1655"},"html":{"href":"https://github.com/artsy/positron/pull/1655"},"issue":{"href":"https://api.github.com/repos/artsy/positron/issues/1655"},"comments":{"href":"https://api.github.com/repos/artsy/positron/issues/1655/comments"},"review_comments":{"href":"https://api.github.com/repos/artsy/positron/pulls/1655/comments"},"review_comment":{"href":"https://api.github.com/repos/artsy/positron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/artsy/positron/pulls/1655/commits"},"statuses":{"href":"https://api.github.com/repos/artsy/positron/statuses/b89c66725dcd639dbe46ebc73366f15d950328aa"}},"author_association":"OWNER"}}
{"actor":{"display_login":"eessex"}}