{"action":"created","comment":{"url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/pulls/comments/228310761","pull_request_review_id":168555353,"id":228310761,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODMxMDc2MQ==","diff_hunk":"@@ -69,6 +69,6 @@ export class ModifyUpdater implements IModifyUpdater {\n             throw new Error('Invalid type assigned to the room.');\n         }\n \n-        return this.bridges.getRoomBridge().update(result, this.appId);\n+        return this.bridges.getRoomBridge().update(result, builder.getMembersToBeAddedUsernames(), this.appId);","path":"src/server/accessors/ModifyUpdater.ts","position":5,"original_position":5,"commit_id":"dd587ac8e0f79011cf71e9f92ebf19117191ef05","original_commit_id":"dd587ac8e0f79011cf71e9f92ebf19117191ef05","user":{"login":"graywolf336","id":850391,"node_id":"MDQ6VXNlcjg1MDM5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/850391?v=4","gravatar_id":"","url":"https://api.github.com/users/graywolf336","html_url":"https://github.com/graywolf336","followers_url":"https://api.github.com/users/graywolf336/followers","following_url":"https://api.github.com/users/graywolf336/following{/other_user}","gists_url":"https://api.github.com/users/graywolf336/gists{/gist_id}","starred_url":"https://api.github.com/users/graywolf336/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graywolf336/subscriptions","organizations_url":"https://api.github.com/users/graywolf336/orgs","repos_url":"https://api.github.com/users/graywolf336/repos","events_url":"https://api.github.com/users/graywolf336/events{/privacy}","received_events_url":"https://api.github.com/users/graywolf336/received_events","type":"User","site_admin":false},"body":"Doing this will actually add members to the room if they don't exist already? And will it check permissions? If so, how will that be checked? This gets into the complicated world...","created_at":"2018-10-25T19:47:44Z","updated_at":"2018-10-25T19:51:16Z","html_url":"https://github.com/RocketChat/Rocket.Chat.Apps-engine/pull/80#discussion_r228310761","pull_request_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/pulls/80","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/pulls/comments/228310761"},"html":{"href":"https://github.com/RocketChat/Rocket.Chat.Apps-engine/pull/80#discussion_r228310761"},"pull_request":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/pulls/80"}}},"pull_request":{"url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/pulls/80","id":225496479,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NDk2NDc5","html_url":"https://github.com/RocketChat/Rocket.Chat.Apps-engine/pull/80","diff_url":"https://github.com/RocketChat/Rocket.Chat.Apps-engine/pull/80.diff","patch_url":"https://github.com/RocketChat/Rocket.Chat.Apps-engine/pull/80.patch","issue_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/issues/80","number":80,"state":"open","locked":false,"title":"Create classes for Room and Messages to replace object access","user":{"login":"rodrigok","id":234261,"node_id":"MDQ6VXNlcjIzNDI2MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/234261?v=4","gravatar_id":"","url":"https://api.github.com/users/rodrigok","html_url":"https://github.com/rodrigok","followers_url":"https://api.github.com/users/rodrigok/followers","following_url":"https://api.github.com/users/rodrigok/following{/other_user}","gists_url":"https://api.github.com/users/rodrigok/gists{/gist_id}","starred_url":"https://api.github.com/users/rodrigok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rodrigok/subscriptions","organizations_url":"https://api.github.com/users/rodrigok/orgs","repos_url":"https://api.github.com/users/rodrigok/repos","events_url":"https://api.github.com/users/rodrigok/events{/privacy}","received_events_url":"https://api.github.com/users/rodrigok/received_events","type":"User","site_admin":false},"body":"RC PR: https://github.com/RocketChat/Rocket.Chat/pull/12409","created_at":"2018-10-24T17:58:32Z","updated_at":"2018-10-25T19:51:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc0ce604d18dd39476513d5ea7926c8c6b2a2d03","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/pulls/80/commits","review_comments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/pulls/80/comments","review_comment_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/issues/80/comments","statuses_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/statuses/dd587ac8e0f79011cf71e9f92ebf19117191ef05","head":{"label":"RocketChat:usernames-getter","ref":"usernames-getter","sha":"dd587ac8e0f79011cf71e9f92ebf19117191ef05","user":{"login":"RocketChat","id":12508788,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA4Nzg4","avatar_url":"https://avatars1.githubusercontent.com/u/12508788?v=4","gravatar_id":"","url":"https://api.github.com/users/RocketChat","html_url":"https://github.com/RocketChat","followers_url":"https://api.github.com/users/RocketChat/followers","following_url":"https://api.github.com/users/RocketChat/following{/other_user}","gists_url":"https://api.github.com/users/RocketChat/gists{/gist_id}","starred_url":"https://api.github.com/users/RocketChat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RocketChat/subscriptions","organizations_url":"https://api.github.com/users/RocketChat/orgs","repos_url":"https://api.github.com/users/RocketChat/repos","events_url":"https://api.github.com/users/RocketChat/events{/privacy}","received_events_url":"https://api.github.com/users/RocketChat/received_events","type":"Organization","site_admin":false},"repo":{"id":96138899,"node_id":"MDEwOlJlcG9zaXRvcnk5NjEzODg5OQ==","name":"Rocket.Chat.Apps-engine","full_name":"RocketChat/Rocket.Chat.Apps-engine","private":false,"owner":{"login":"RocketChat","id":12508788,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA4Nzg4","avatar_url":"https://avatars1.githubusercontent.com/u/12508788?v=4","gravatar_id":"","url":"https://api.github.com/users/RocketChat","html_url":"https://github.com/RocketChat","followers_url":"https://api.github.com/users/RocketChat/followers","following_url":"https://api.github.com/users/RocketChat/following{/other_user}","gists_url":"https://api.github.com/users/RocketChat/gists{/gist_id}","starred_url":"https://api.github.com/users/RocketChat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RocketChat/subscriptions","organizations_url":"https://api.github.com/users/RocketChat/orgs","repos_url":"https://api.github.com/users/RocketChat/repos","events_url":"https://api.github.com/users/RocketChat/events{/privacy}","received_events_url":"https://api.github.com/users/RocketChat/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/RocketChat/Rocket.Chat.Apps-engine","description":"The Rocket.Chat Apps engine and definitions.","fork":false,"url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine","forks_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/forks","keys_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/teams","hooks_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/hooks","issue_events_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/issues/events{/number}","events_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/events","assignees_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/assignees{/user}","branches_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/branches{/branch}","tags_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/tags","blobs_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/languages","stargazers_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/stargazers","contributors_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/contributors","subscribers_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/subscribers","subscription_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/subscription","commits_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/contents/{+path}","compare_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/merges","archive_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/downloads","issues_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/issues{/number}","pulls_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/labels{/name}","releases_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/releases{/id}","deployments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/deployments","created_at":"2017-07-03T18:23:47Z","updated_at":"2018-10-24T21:49:06Z","pushed_at":"2018-10-25T19:07:19Z","git_url":"git://github.com/RocketChat/Rocket.Chat.Apps-engine.git","ssh_url":"git@github.com:RocketChat/Rocket.Chat.Apps-engine.git","clone_url":"https://github.com/RocketChat/Rocket.Chat.Apps-engine.git","svn_url":"https://github.com/RocketChat/Rocket.Chat.Apps-engine","homepage":"","size":1132,"stargazers_count":10,"watchers_count":10,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":40,"watchers":10,"default_branch":"master"}},"base":{"label":"RocketChat:master","ref":"master","sha":"9519cae61bf6fc997826c69ecaf7fe51d4bbb204","user":{"login":"RocketChat","id":12508788,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA4Nzg4","avatar_url":"https://avatars1.githubusercontent.com/u/12508788?v=4","gravatar_id":"","url":"https://api.github.com/users/RocketChat","html_url":"https://github.com/RocketChat","followers_url":"https://api.github.com/users/RocketChat/followers","following_url":"https://api.github.com/users/RocketChat/following{/other_user}","gists_url":"https://api.github.com/users/RocketChat/gists{/gist_id}","starred_url":"https://api.github.com/users/RocketChat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RocketChat/subscriptions","organizations_url":"https://api.github.com/users/RocketChat/orgs","repos_url":"https://api.github.com/users/RocketChat/repos","events_url":"https://api.github.com/users/RocketChat/events{/privacy}","received_events_url":"https://api.github.com/users/RocketChat/received_events","type":"Organization","site_admin":false},"repo":{"id":96138899,"node_id":"MDEwOlJlcG9zaXRvcnk5NjEzODg5OQ==","name":"Rocket.Chat.Apps-engine","full_name":"RocketChat/Rocket.Chat.Apps-engine","private":false,"owner":{"login":"RocketChat","id":12508788,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA4Nzg4","avatar_url":"https://avatars1.githubusercontent.com/u/12508788?v=4","gravatar_id":"","url":"https://api.github.com/users/RocketChat","html_url":"https://github.com/RocketChat","followers_url":"https://api.github.com/users/RocketChat/followers","following_url":"https://api.github.com/users/RocketChat/following{/other_user}","gists_url":"https://api.github.com/users/RocketChat/gists{/gist_id}","starred_url":"https://api.github.com/users/RocketChat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RocketChat/subscriptions","organizations_url":"https://api.github.com/users/RocketChat/orgs","repos_url":"https://api.github.com/users/RocketChat/repos","events_url":"https://api.github.com/users/RocketChat/events{/privacy}","received_events_url":"https://api.github.com/users/RocketChat/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/RocketChat/Rocket.Chat.Apps-engine","description":"The Rocket.Chat Apps engine and definitions.","fork":false,"url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine","forks_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/forks","keys_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/teams","hooks_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/hooks","issue_events_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/issues/events{/number}","events_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/events","assignees_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/assignees{/user}","branches_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/branches{/branch}","tags_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/tags","blobs_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/languages","stargazers_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/stargazers","contributors_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/contributors","subscribers_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/subscribers","subscription_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/subscription","commits_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/contents/{+path}","compare_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/merges","archive_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/downloads","issues_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/issues{/number}","pulls_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/labels{/name}","releases_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/releases{/id}","deployments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/deployments","created_at":"2017-07-03T18:23:47Z","updated_at":"2018-10-24T21:49:06Z","pushed_at":"2018-10-25T19:07:19Z","git_url":"git://github.com/RocketChat/Rocket.Chat.Apps-engine.git","ssh_url":"git@github.com:RocketChat/Rocket.Chat.Apps-engine.git","clone_url":"https://github.com/RocketChat/Rocket.Chat.Apps-engine.git","svn_url":"https://github.com/RocketChat/Rocket.Chat.Apps-engine","homepage":"","size":1132,"stargazers_count":10,"watchers_count":10,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":40,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/pulls/80"},"html":{"href":"https://github.com/RocketChat/Rocket.Chat.Apps-engine/pull/80"},"issue":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/issues/80"},"comments":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/issues/80/comments"},"review_comments":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/pulls/80/comments"},"review_comment":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/pulls/80/commits"},"statuses":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat.Apps-engine/statuses/dd587ac8e0f79011cf71e9f92ebf19117191ef05"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"graywolf336"}}