{"action":"closed","number":4092,"pull_request":{"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/4092","id":171207986,"html_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/4092","diff_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/4092.diff","patch_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/4092.patch","issue_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/4092","number":4092,"state":"closed","locked":false,"title":"DatePicker: order of callbacks for onSelectDate and onAfterMenuDismiss","user":{"login":"drew-brough","id":137875,"avatar_url":"https://avatars2.githubusercontent.com/u/137875?v=4","gravatar_id":"","url":"https://api.github.com/users/drew-brough","html_url":"https://github.com/drew-brough","followers_url":"https://api.github.com/users/drew-brough/followers","following_url":"https://api.github.com/users/drew-brough/following{/other_user}","gists_url":"https://api.github.com/users/drew-brough/gists{/gist_id}","starred_url":"https://api.github.com/users/drew-brough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drew-brough/subscriptions","organizations_url":"https://api.github.com/users/drew-brough/orgs","repos_url":"https://api.github.com/users/drew-brough/repos","events_url":"https://api.github.com/users/drew-brough/events{/privacy}","received_events_url":"https://api.github.com/users/drew-brough/received_events","type":"User","site_admin":false},"body":"#### Pull request checklist\r\n\r\n- [ ] Addresses an existing issue: Fixes #0000\r\n- [X] Include a change request file using `$ npm run change`\r\n\r\n#### Description of changes\r\n\r\nWe recently added an \"onAfterMenuDismiss\" to datePicker, however the order in which it was getting called relative to the onSelectDate was opposite of the pattern established in BaseButton when a menu is used.  DatePicker was using the callback from setting the state to hide the menu to do the selection callback.\r\nWith this change, we'll set the component state with the new date, call the onSelectDate callbacks, then set the state to dismiss the Calendar menu.\r\nThe component was also over-writing the onSelectDate option that was available via the calendarProps prop, so we'll call that immediately should the caller provide it, then deal with local state and callbacks.\r\n","created_at":"2018-02-25T02:05:54Z","updated_at":"2018-02-26T22:29:12Z","closed_at":"2018-02-26T22:29:12Z","merged_at":"2018-02-26T22:29:12Z","merge_commit_sha":"9b2f25a818c7db0e98b4dd9ece25e8506c619d31","assignee":null,"assignees":[],"requested_reviewers":[{"login":"johannao76","id":11838969,"avatar_url":"https://avatars0.githubusercontent.com/u/11838969?v=4","gravatar_id":"","url":"https://api.github.com/users/johannao76","html_url":"https://github.com/johannao76","followers_url":"https://api.github.com/users/johannao76/followers","following_url":"https://api.github.com/users/johannao76/following{/other_user}","gists_url":"https://api.github.com/users/johannao76/gists{/gist_id}","starred_url":"https://api.github.com/users/johannao76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johannao76/subscriptions","organizations_url":"https://api.github.com/users/johannao76/orgs","repos_url":"https://api.github.com/users/johannao76/repos","events_url":"https://api.github.com/users/johannao76/events{/privacy}","received_events_url":"https://api.github.com/users/johannao76/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/4092/commits","review_comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/4092/comments","review_comment_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/4092/comments","statuses_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/6ad5743356880db034eb95bfab7120aaa5b3c40d","head":{"label":"drew-brough:dbrough/datePickerCallbackOrderFix","ref":"dbrough/datePickerCallbackOrderFix","sha":"6ad5743356880db034eb95bfab7120aaa5b3c40d","user":{"login":"drew-brough","id":137875,"avatar_url":"https://avatars2.githubusercontent.com/u/137875?v=4","gravatar_id":"","url":"https://api.github.com/users/drew-brough","html_url":"https://github.com/drew-brough","followers_url":"https://api.github.com/users/drew-brough/followers","following_url":"https://api.github.com/users/drew-brough/following{/other_user}","gists_url":"https://api.github.com/users/drew-brough/gists{/gist_id}","starred_url":"https://api.github.com/users/drew-brough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drew-brough/subscriptions","organizations_url":"https://api.github.com/users/drew-brough/orgs","repos_url":"https://api.github.com/users/drew-brough/repos","events_url":"https://api.github.com/users/drew-brough/events{/privacy}","received_events_url":"https://api.github.com/users/drew-brough/received_events","type":"User","site_admin":false},"repo":{"id":122792077,"name":"office-ui-fabric-react","full_name":"drew-brough/office-ui-fabric-react","owner":{"login":"drew-brough","id":137875,"avatar_url":"https://avatars2.githubusercontent.com/u/137875?v=4","gravatar_id":"","url":"https://api.github.com/users/drew-brough","html_url":"https://github.com/drew-brough","followers_url":"https://api.github.com/users/drew-brough/followers","following_url":"https://api.github.com/users/drew-brough/following{/other_user}","gists_url":"https://api.github.com/users/drew-brough/gists{/gist_id}","starred_url":"https://api.github.com/users/drew-brough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drew-brough/subscriptions","organizations_url":"https://api.github.com/users/drew-brough/orgs","repos_url":"https://api.github.com/users/drew-brough/repos","events_url":"https://api.github.com/users/drew-brough/events{/privacy}","received_events_url":"https://api.github.com/users/drew-brough/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drew-brough/office-ui-fabric-react","description":"React components for building experiences for Office and Office 365.","fork":true,"url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react","forks_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/forks","keys_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/teams","hooks_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/hooks","issue_events_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/issues/events{/number}","events_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/events","assignees_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/assignees{/user}","branches_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/branches{/branch}","tags_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/tags","blobs_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/statuses/{sha}","languages_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/languages","stargazers_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/stargazers","contributors_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/contributors","subscribers_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/subscribers","subscription_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/subscription","commits_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/contents/{+path}","compare_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/merges","archive_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/downloads","issues_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/issues{/number}","pulls_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/pulls{/number}","milestones_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/milestones{/number}","notifications_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/labels{/name}","releases_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/releases{/id}","deployments_url":"https://api.github.com/repos/drew-brough/office-ui-fabric-react/deployments","created_at":"2018-02-25T00:21:37Z","updated_at":"2018-02-25T00:21:43Z","pushed_at":"2018-02-25T01:51:14Z","git_url":"git://github.com/drew-brough/office-ui-fabric-react.git","ssh_url":"git@github.com:drew-brough/office-ui-fabric-react.git","clone_url":"https://github.com/drew-brough/office-ui-fabric-react.git","svn_url":"https://github.com/drew-brough/office-ui-fabric-react","homepage":"https://developer.microsoft.com/en-us/fabric#/components","size":23774,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OfficeDev:master","ref":"master","sha":"7c70a2479c59b9153c17a6ae75d433982c9819d5","user":{"login":"OfficeDev","id":6789362,"avatar_url":"https://avatars2.githubusercontent.com/u/6789362?v=4","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"repo":{"id":60537144,"name":"office-ui-fabric-react","full_name":"OfficeDev/office-ui-fabric-react","owner":{"login":"OfficeDev","id":6789362,"avatar_url":"https://avatars2.githubusercontent.com/u/6789362?v=4","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OfficeDev/office-ui-fabric-react","description":"React components for building experiences for Office and Office 365.","fork":false,"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react","forks_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/forks","keys_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/teams","hooks_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/hooks","issue_events_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/events{/number}","events_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/events","assignees_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/assignees{/user}","branches_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/branches{/branch}","tags_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/tags","blobs_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/{sha}","languages_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/languages","stargazers_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/stargazers","contributors_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/contributors","subscribers_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/subscribers","subscription_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/subscription","commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/contents/{+path}","compare_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/merges","archive_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/downloads","issues_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues{/number}","pulls_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls{/number}","milestones_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/milestones{/number}","notifications_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/labels{/name}","releases_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/releases{/id}","deployments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/deployments","created_at":"2016-06-06T15:03:44Z","updated_at":"2018-02-26T13:07:39Z","pushed_at":"2018-02-26T22:29:12Z","git_url":"git://github.com/OfficeDev/office-ui-fabric-react.git","ssh_url":"git@github.com:OfficeDev/office-ui-fabric-react.git","clone_url":"https://github.com/OfficeDev/office-ui-fabric-react.git","svn_url":"https://github.com/OfficeDev/office-ui-fabric-react","homepage":"https://developer.microsoft.com/en-us/fabric#/components","size":23783,"stargazers_count":2310,"watchers_count":2310,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":478,"mirror_url":null,"archived":false,"open_issues_count":487,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":478,"open_issues":487,"watchers":2310,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/4092"},"html":{"href":"https://github.com/OfficeDev/office-ui-fabric-react/pull/4092"},"issue":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/4092"},"comments":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/4092/comments"},"review_comments":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/4092/comments"},"review_comment":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/4092/commits"},"statuses":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/6ad5743356880db034eb95bfab7120aaa5b3c40d"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"lorejoh12","id":8549582,"avatar_url":"https://avatars3.githubusercontent.com/u/8549582?v=4","gravatar_id":"","url":"https://api.github.com/users/lorejoh12","html_url":"https://github.com/lorejoh12","followers_url":"https://api.github.com/users/lorejoh12/followers","following_url":"https://api.github.com/users/lorejoh12/following{/other_user}","gists_url":"https://api.github.com/users/lorejoh12/gists{/gist_id}","starred_url":"https://api.github.com/users/lorejoh12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorejoh12/subscriptions","organizations_url":"https://api.github.com/users/lorejoh12/orgs","repos_url":"https://api.github.com/users/lorejoh12/repos","events_url":"https://api.github.com/users/lorejoh12/events{/privacy}","received_events_url":"https://api.github.com/users/lorejoh12/received_events","type":"User","site_admin":false},"comments":0,"review_comments":3,"maintainer_can_modify":false,"commits":2,"additions":23,"deletions":5,"changed_files":2}}
{"actor":{"display_login":"lorejoh12"}}