{"action":"created","comment":{"url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/pulls/comments/243135535","pull_request_review_id":186823167,"id":243135535,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzEzNTUzNQ==","diff_hunk":"@@ -1,18 +1,30 @@\n package com.infoshareacademy.jbusters.data;\n \n-import org.junit.Assert;\n+//import org.junit.Assert;\n+\n+import org.junit.jupiter.api.Assertions;\n \n import java.math.BigDecimal;\n import java.math.RoundingMode;\n import java.time.LocalDate;\n import java.util.ArrayList;\n import java.util.List;\n \n-public class FilterTransactionsTest {\n \n-    private List<Transaction> tempTransactions = new ArrayList<>();\n+import org.junit.jupiter.api.Assertions;\n+import org.junit.jupiter.api.Test;\n+\n+import java.math.BigDecimal;\n+import java.math.RoundingMode;\n+import java.time.LocalDate;\n+import java.util.ArrayList;","path":"app/src/test/java/com/infoshareacademy/jbusters/data/FilterTransactionsTest.java","position":23,"original_position":23,"commit_id":"246a88cdcdaf248f2cd9af6955588667ea76967f","original_commit_id":"246a88cdcdaf248f2cd9af6955588667ea76967f","user":{"login":"isacademyci","id":15266968,"node_id":"MDQ6VXNlcjE1MjY2OTY4","avatar_url":"https://avatars2.githubusercontent.com/u/15266968?v=4","gravatar_id":"","url":"https://api.github.com/users/isacademyci","html_url":"https://github.com/isacademyci","followers_url":"https://api.github.com/users/isacademyci/followers","following_url":"https://api.github.com/users/isacademyci/following{/other_user}","gists_url":"https://api.github.com/users/isacademyci/gists{/gist_id}","starred_url":"https://api.github.com/users/isacademyci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isacademyci/subscriptions","organizations_url":"https://api.github.com/users/isacademyci/orgs","repos_url":"https://api.github.com/users/isacademyci/repos","events_url":"https://api.github.com/users/isacademyci/events{/privacy}","received_events_url":"https://api.github.com/users/isacademyci/received_events","type":"User","site_admin":false},"body":"![MINOR](https://sonarsource.github.io/sonar-github/severity-minor.png 'Severity: MINOR') Remove this duplicated import. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](http://localhost:9000/coding_rules#rule_key=squid%3AUselessImportCheck)\n","created_at":"2018-12-20T01:54:57Z","updated_at":"2018-12-20T01:54:57Z","html_url":"https://github.com/infoshareacademy/jjdd5-jbusters/pull/36#discussion_r243135535","pull_request_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/pulls/36","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/pulls/comments/243135535"},"html":{"href":"https://github.com/infoshareacademy/jjdd5-jbusters/pull/36#discussion_r243135535"},"pull_request":{"href":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/pulls/36","id":240028984,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMDI4OTg0","html_url":"https://github.com/infoshareacademy/jjdd5-jbusters/pull/36","diff_url":"https://github.com/infoshareacademy/jjdd5-jbusters/pull/36.diff","patch_url":"https://github.com/infoshareacademy/jjdd5-jbusters/pull/36.patch","issue_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/issues/36","number":36,"state":"open","locked":false,"title":"JD5JB 52/58 DecimalFormat unified, StaticFields class added","user":{"login":"Juan-IT-O","id":44127073,"node_id":"MDQ6VXNlcjQ0MTI3MDcz","avatar_url":"https://avatars0.githubusercontent.com/u/44127073?v=4","gravatar_id":"","url":"https://api.github.com/users/Juan-IT-O","html_url":"https://github.com/Juan-IT-O","followers_url":"https://api.github.com/users/Juan-IT-O/followers","following_url":"https://api.github.com/users/Juan-IT-O/following{/other_user}","gists_url":"https://api.github.com/users/Juan-IT-O/gists{/gist_id}","starred_url":"https://api.github.com/users/Juan-IT-O/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Juan-IT-O/subscriptions","organizations_url":"https://api.github.com/users/Juan-IT-O/orgs","repos_url":"https://api.github.com/users/Juan-IT-O/repos","events_url":"https://api.github.com/users/Juan-IT-O/events{/privacy}","received_events_url":"https://api.github.com/users/Juan-IT-O/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-20T01:53:32Z","updated_at":"2018-12-20T01:54:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c241b4c8855a1d939bc8eb225593ff11b1c7e507","assignee":null,"assignees":[],"requested_reviewers":[{"login":"karolbemka","id":44605719,"node_id":"MDQ6VXNlcjQ0NjA1NzE5","avatar_url":"https://avatars0.githubusercontent.com/u/44605719?v=4","gravatar_id":"","url":"https://api.github.com/users/karolbemka","html_url":"https://github.com/karolbemka","followers_url":"https://api.github.com/users/karolbemka/followers","following_url":"https://api.github.com/users/karolbemka/following{/other_user}","gists_url":"https://api.github.com/users/karolbemka/gists{/gist_id}","starred_url":"https://api.github.com/users/karolbemka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karolbemka/subscriptions","organizations_url":"https://api.github.com/users/karolbemka/orgs","repos_url":"https://api.github.com/users/karolbemka/repos","events_url":"https://api.github.com/users/karolbemka/events{/privacy}","received_events_url":"https://api.github.com/users/karolbemka/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/pulls/36/commits","review_comments_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/pulls/36/comments","review_comment_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/pulls/comments{/number}","comments_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/issues/36/comments","statuses_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/statuses/246a88cdcdaf248f2cd9af6955588667ea76967f","head":{"label":"infoshareacademy:JD5JB-52/58_df-stat-fix","ref":"JD5JB-52/58_df-stat-fix","sha":"246a88cdcdaf248f2cd9af6955588667ea76967f","user":{"login":"infoshareacademy","id":14171731,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTcxNzMx","avatar_url":"https://avatars0.githubusercontent.com/u/14171731?v=4","gravatar_id":"","url":"https://api.github.com/users/infoshareacademy","html_url":"https://github.com/infoshareacademy","followers_url":"https://api.github.com/users/infoshareacademy/followers","following_url":"https://api.github.com/users/infoshareacademy/following{/other_user}","gists_url":"https://api.github.com/users/infoshareacademy/gists{/gist_id}","starred_url":"https://api.github.com/users/infoshareacademy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infoshareacademy/subscriptions","organizations_url":"https://api.github.com/users/infoshareacademy/orgs","repos_url":"https://api.github.com/users/infoshareacademy/repos","events_url":"https://api.github.com/users/infoshareacademy/events{/privacy}","received_events_url":"https://api.github.com/users/infoshareacademy/received_events","type":"Organization","site_admin":false},"repo":{"id":157229150,"node_id":"MDEwOlJlcG9zaXRvcnkxNTcyMjkxNTA=","name":"jjdd5-jbusters","full_name":"infoshareacademy/jjdd5-jbusters","private":false,"owner":{"login":"infoshareacademy","id":14171731,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTcxNzMx","avatar_url":"https://avatars0.githubusercontent.com/u/14171731?v=4","gravatar_id":"","url":"https://api.github.com/users/infoshareacademy","html_url":"https://github.com/infoshareacademy","followers_url":"https://api.github.com/users/infoshareacademy/followers","following_url":"https://api.github.com/users/infoshareacademy/following{/other_user}","gists_url":"https://api.github.com/users/infoshareacademy/gists{/gist_id}","starred_url":"https://api.github.com/users/infoshareacademy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infoshareacademy/subscriptions","organizations_url":"https://api.github.com/users/infoshareacademy/orgs","repos_url":"https://api.github.com/users/infoshareacademy/repos","events_url":"https://api.github.com/users/infoshareacademy/events{/privacy}","received_events_url":"https://api.github.com/users/infoshareacademy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/infoshareacademy/jjdd5-jbusters","description":null,"fork":false,"url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters","forks_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/forks","keys_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/teams","hooks_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/hooks","issue_events_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/issues/events{/number}","events_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/events","assignees_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/assignees{/user}","branches_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/branches{/branch}","tags_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/tags","blobs_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/git/refs{/sha}","trees_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/statuses/{sha}","languages_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/languages","stargazers_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/stargazers","contributors_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/contributors","subscribers_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/subscribers","subscription_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/subscription","commits_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/commits{/sha}","git_commits_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/git/commits{/sha}","comments_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/comments{/number}","issue_comment_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/issues/comments{/number}","contents_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/contents/{+path}","compare_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/merges","archive_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/downloads","issues_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/issues{/number}","pulls_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/pulls{/number}","milestones_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/milestones{/number}","notifications_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/labels{/name}","releases_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/releases{/id}","deployments_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/deployments","created_at":"2018-11-12T14:50:29Z","updated_at":"2018-12-19T15:25:12Z","pushed_at":"2018-12-20T01:53:33Z","git_url":"git://github.com/infoshareacademy/jjdd5-jbusters.git","ssh_url":"git@github.com:infoshareacademy/jjdd5-jbusters.git","clone_url":"https://github.com/infoshareacademy/jjdd5-jbusters.git","svn_url":"https://github.com/infoshareacademy/jjdd5-jbusters","homepage":null,"size":1842,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":3,"default_branch":"develop"}},"base":{"label":"infoshareacademy:develop","ref":"develop","sha":"7d935cb0547099a589b540be4c4d58711cafb83a","user":{"login":"infoshareacademy","id":14171731,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTcxNzMx","avatar_url":"https://avatars0.githubusercontent.com/u/14171731?v=4","gravatar_id":"","url":"https://api.github.com/users/infoshareacademy","html_url":"https://github.com/infoshareacademy","followers_url":"https://api.github.com/users/infoshareacademy/followers","following_url":"https://api.github.com/users/infoshareacademy/following{/other_user}","gists_url":"https://api.github.com/users/infoshareacademy/gists{/gist_id}","starred_url":"https://api.github.com/users/infoshareacademy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infoshareacademy/subscriptions","organizations_url":"https://api.github.com/users/infoshareacademy/orgs","repos_url":"https://api.github.com/users/infoshareacademy/repos","events_url":"https://api.github.com/users/infoshareacademy/events{/privacy}","received_events_url":"https://api.github.com/users/infoshareacademy/received_events","type":"Organization","site_admin":false},"repo":{"id":157229150,"node_id":"MDEwOlJlcG9zaXRvcnkxNTcyMjkxNTA=","name":"jjdd5-jbusters","full_name":"infoshareacademy/jjdd5-jbusters","private":false,"owner":{"login":"infoshareacademy","id":14171731,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTcxNzMx","avatar_url":"https://avatars0.githubusercontent.com/u/14171731?v=4","gravatar_id":"","url":"https://api.github.com/users/infoshareacademy","html_url":"https://github.com/infoshareacademy","followers_url":"https://api.github.com/users/infoshareacademy/followers","following_url":"https://api.github.com/users/infoshareacademy/following{/other_user}","gists_url":"https://api.github.com/users/infoshareacademy/gists{/gist_id}","starred_url":"https://api.github.com/users/infoshareacademy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infoshareacademy/subscriptions","organizations_url":"https://api.github.com/users/infoshareacademy/orgs","repos_url":"https://api.github.com/users/infoshareacademy/repos","events_url":"https://api.github.com/users/infoshareacademy/events{/privacy}","received_events_url":"https://api.github.com/users/infoshareacademy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/infoshareacademy/jjdd5-jbusters","description":null,"fork":false,"url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters","forks_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/forks","keys_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/teams","hooks_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/hooks","issue_events_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/issues/events{/number}","events_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/events","assignees_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/assignees{/user}","branches_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/branches{/branch}","tags_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/tags","blobs_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/git/refs{/sha}","trees_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/statuses/{sha}","languages_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/languages","stargazers_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/stargazers","contributors_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/contributors","subscribers_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/subscribers","subscription_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/subscription","commits_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/commits{/sha}","git_commits_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/git/commits{/sha}","comments_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/comments{/number}","issue_comment_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/issues/comments{/number}","contents_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/contents/{+path}","compare_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/merges","archive_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/downloads","issues_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/issues{/number}","pulls_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/pulls{/number}","milestones_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/milestones{/number}","notifications_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/labels{/name}","releases_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/releases{/id}","deployments_url":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/deployments","created_at":"2018-11-12T14:50:29Z","updated_at":"2018-12-19T15:25:12Z","pushed_at":"2018-12-20T01:53:33Z","git_url":"git://github.com/infoshareacademy/jjdd5-jbusters.git","ssh_url":"git@github.com:infoshareacademy/jjdd5-jbusters.git","clone_url":"https://github.com/infoshareacademy/jjdd5-jbusters.git","svn_url":"https://github.com/infoshareacademy/jjdd5-jbusters","homepage":null,"size":1842,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/pulls/36"},"html":{"href":"https://github.com/infoshareacademy/jjdd5-jbusters/pull/36"},"issue":{"href":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/issues/36"},"comments":{"href":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/infoshareacademy/jjdd5-jbusters/statuses/246a88cdcdaf248f2cd9af6955588667ea76967f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"isacademyci"}}