{"action":"created","issue":{"url":"https://api.github.com/repos/dlemmermann/CalendarFX/issues/33","repository_url":"https://api.github.com/repos/dlemmermann/CalendarFX","labels_url":"https://api.github.com/repos/dlemmermann/CalendarFX/issues/33/labels{/name}","comments_url":"https://api.github.com/repos/dlemmermann/CalendarFX/issues/33/comments","events_url":"https://api.github.com/repos/dlemmermann/CalendarFX/issues/33/events","html_url":"https://github.com/dlemmermann/CalendarFX/pull/33","id":344613772,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzOTY4NTE3","number":33,"title":"Enhancement on GUI, user/development experience and bugfixing","user":{"login":"arias9306","id":6402598,"node_id":"MDQ6VXNlcjY0MDI1OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6402598?v=4","gravatar_id":"","url":"https://api.github.com/users/arias9306","html_url":"https://github.com/arias9306","followers_url":"https://api.github.com/users/arias9306/followers","following_url":"https://api.github.com/users/arias9306/following{/other_user}","gists_url":"https://api.github.com/users/arias9306/gists{/gist_id}","starred_url":"https://api.github.com/users/arias9306/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arias9306/subscriptions","organizations_url":"https://api.github.com/users/arias9306/orgs","repos_url":"https://api.github.com/users/arias9306/repos","events_url":"https://api.github.com/users/arias9306/events{/privacy}","received_events_url":"https://api.github.com/users/arias9306/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-07-25T21:27:44Z","updated_at":"2018-08-13T15:40:39Z","closed_at":"2018-08-08T11:09:11Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/dlemmermann/CalendarFX/pulls/33","html_url":"https://github.com/dlemmermann/CalendarFX/pull/33","diff_url":"https://github.com/dlemmermann/CalendarFX/pull/33.diff","patch_url":"https://github.com/dlemmermann/CalendarFX/pull/33.patch"},"body":"This pull request is part of a series of improvements and bug fixes made to the CalendarFx component, in order to give a better user experience and also help developers giving them the opportunity to customize the component according to their requirements without losing its original behavior. Another important feature included in this pull request is the addition of the Spanish language to the component.\r\n\r\nI hope these changes made could be useful and also included in the base of the component.\r\n\r\nAny comment or doubt please comment us.\r\n\r\n### **Improvements**\r\n\r\n- ScrollPane added in Year view for small screens.\r\n- Delete some dead code.\r\n- Prevent button (toggle) get un-selected by pressing it while that view is selected.\r\n- Make formatter properties accesible and make it free to change the default value of it.\r\n- It was made possible to Override the methods that create the day, week and month view to change the skins and change some default configs like `TrimTimeBounds`.\r\n- `TimeScaleView`: Removed final in `getDateTImeFomatter`, to be able to Override the formatter property on an extended class.\r\n- Added new property file `messages_es.properties` to support spanish languaje. \r\n- Improvements in print view. please check [cd481b0](https://github.com/dlemmermann/CalendarFX/commit/cd481b044576433d018b54e23e17cd54d3d0abab) and [a376ecd](https://github.com/dlemmermann/CalendarFX/commit/a376ecd212a70abcd7ac44b3fb8713e987f1c34e)\r\n\r\n\r\n\r\n### **Errors**\r\n\r\n- NPE solved while changing ViewType.\r\n- The visibility of the entries is updated after changing the views (calendar view and print view). It was a problem that happened when uncheck a calendar source and change the view.\r\n- Validate if the OS has not a default printer configured.\r\n- Improved the validation to show \"more\" text in month view when there are entries that can't be shown in the month view skin due to the month view is small."},"comment":{"url":"https://api.github.com/repos/dlemmermann/CalendarFX/issues/comments/412562835","html_url":"https://github.com/dlemmermann/CalendarFX/pull/33#issuecomment-412562835","issue_url":"https://api.github.com/repos/dlemmermann/CalendarFX/issues/33","id":412562835,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjU2MjgzNQ==","user":{"login":"arias9306","id":6402598,"node_id":"MDQ6VXNlcjY0MDI1OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6402598?v=4","gravatar_id":"","url":"https://api.github.com/users/arias9306","html_url":"https://github.com/arias9306","followers_url":"https://api.github.com/users/arias9306/followers","following_url":"https://api.github.com/users/arias9306/following{/other_user}","gists_url":"https://api.github.com/users/arias9306/gists{/gist_id}","starred_url":"https://api.github.com/users/arias9306/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arias9306/subscriptions","organizations_url":"https://api.github.com/users/arias9306/orgs","repos_url":"https://api.github.com/users/arias9306/repos","events_url":"https://api.github.com/users/arias9306/events{/privacy}","received_events_url":"https://api.github.com/users/arias9306/received_events","type":"User","site_admin":false},"created_at":"2018-08-13T15:40:39Z","updated_at":"2018-08-13T15:40:39Z","author_association":"CONTRIBUTOR","body":"Hello Dirk, thanks for your feedback and advices, we are going to take them into account for future improvements.\r\n\r\nWe are happy and grateful to see our contribution as part of the CalendarFx project and hopefully some other contributors and developers could benefit from this.\r\n\r\nGreetings from development team in Colombia."}}
{"actor":{"display_login":"arias9306"}}