{"action":"created","comment":{"url":"https://api.github.com/repos/mixer/cdk-std/pulls/comments/196525262","pull_request_review_id":130094797,"id":196525262,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjUyNTI2Mg==","diff_hunk":"@@ -530,6 +530,12 @@ export class Participant extends EventEmitter {\n   private handleWebsocketError(ev: Event) {\n     // tslint:disable-next-line\n     if (!this.websocket || !this.websocket.url) {\n+      this.emit('close', {\n+        code: -1,\n+        message: 'No websocket or websocket url',\n+        expected: this.state === State.Closing,\n+        ev,\n+      });","path":"src/participant.ts","position":9,"original_position":9,"commit_id":"7a6b93942a33fb7eeb58764de351a7c6d44985a2","original_commit_id":"7a6b93942a33fb7eeb58764de351a7c6d44985a2","user":{"login":"rogarMS","id":23484870,"node_id":"MDQ6VXNlcjIzNDg0ODcw","avatar_url":"https://avatars1.githubusercontent.com/u/23484870?v=4","gravatar_id":"","url":"https://api.github.com/users/rogarMS","html_url":"https://github.com/rogarMS","followers_url":"https://api.github.com/users/rogarMS/followers","following_url":"https://api.github.com/users/rogarMS/following{/other_user}","gists_url":"https://api.github.com/users/rogarMS/gists{/gist_id}","starred_url":"https://api.github.com/users/rogarMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogarMS/subscriptions","organizations_url":"https://api.github.com/users/rogarMS/orgs","repos_url":"https://api.github.com/users/rogarMS/repos","events_url":"https://api.github.com/users/rogarMS/events{/privacy}","received_events_url":"https://api.github.com/users/rogarMS/received_events","type":"User","site_admin":false},"body":"So the error we had on mobile was after disconnect was 'undefined is not an object (evaluating 'this.websock.url.replace') (On version 0.2.16)\r\n\r\n0.2.17 added the if check, but now won't emit close, so we never know when to reconnect.\r\n\r\nMaybe could be more granular, no websocket = no emit, websocket but no url = emit.\r\n","created_at":"2018-06-19T18:05:17Z","updated_at":"2018-06-19T18:05:17Z","html_url":"https://github.com/mixer/cdk-std/pull/23#discussion_r196525262","pull_request_url":"https://api.github.com/repos/mixer/cdk-std/pulls/23","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/mixer/cdk-std/pulls/comments/196525262"},"html":{"href":"https://github.com/mixer/cdk-std/pull/23#discussion_r196525262"},"pull_request":{"href":"https://api.github.com/repos/mixer/cdk-std/pulls/23"}},"in_reply_to_id":196271664},"pull_request":{"url":"https://api.github.com/repos/mixer/cdk-std/pulls/23","id":194751522,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NzUxNTIy","html_url":"https://github.com/mixer/cdk-std/pull/23","diff_url":"https://github.com/mixer/cdk-std/pull/23.diff","patch_url":"https://github.com/mixer/cdk-std/pull/23.patch","issue_url":"https://api.github.com/repos/mixer/cdk-std/issues/23","number":23,"state":"open","locked":false,"title":"fix(participant): emit close if the websocket doesn't exist","user":{"login":"DeekyJay","id":6782859,"node_id":"MDQ6VXNlcjY3ODI4NTk=","avatar_url":"https://avatars1.githubusercontent.com/u/6782859?v=4","gravatar_id":"","url":"https://api.github.com/users/DeekyJay","html_url":"https://github.com/DeekyJay","followers_url":"https://api.github.com/users/DeekyJay/followers","following_url":"https://api.github.com/users/DeekyJay/following{/other_user}","gists_url":"https://api.github.com/users/DeekyJay/gists{/gist_id}","starred_url":"https://api.github.com/users/DeekyJay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeekyJay/subscriptions","organizations_url":"https://api.github.com/users/DeekyJay/orgs","repos_url":"https://api.github.com/users/DeekyJay/repos","events_url":"https://api.github.com/users/DeekyJay/events{/privacy}","received_events_url":"https://api.github.com/users/DeekyJay/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-14T00:40:59Z","updated_at":"2018-06-19T18:05:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4accb2cb562a29ea4a030b873f1b036d3585fcb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mixer/cdk-std/pulls/23/commits","review_comments_url":"https://api.github.com/repos/mixer/cdk-std/pulls/23/comments","review_comment_url":"https://api.github.com/repos/mixer/cdk-std/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mixer/cdk-std/issues/23/comments","statuses_url":"https://api.github.com/repos/mixer/cdk-std/statuses/7a6b93942a33fb7eeb58764de351a7c6d44985a2","head":{"label":"mixer:fix/wserror","ref":"fix/wserror","sha":"7a6b93942a33fb7eeb58764de351a7c6d44985a2","user":{"login":"mixer","id":11798804,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzk4ODA0","avatar_url":"https://avatars3.githubusercontent.com/u/11798804?v=4","gravatar_id":"","url":"https://api.github.com/users/mixer","html_url":"https://github.com/mixer","followers_url":"https://api.github.com/users/mixer/followers","following_url":"https://api.github.com/users/mixer/following{/other_user}","gists_url":"https://api.github.com/users/mixer/gists{/gist_id}","starred_url":"https://api.github.com/users/mixer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixer/subscriptions","organizations_url":"https://api.github.com/users/mixer/orgs","repos_url":"https://api.github.com/users/mixer/repos","events_url":"https://api.github.com/users/mixer/events{/privacy}","received_events_url":"https://api.github.com/users/mixer/received_events","type":"Organization","site_admin":false},"repo":{"id":102497820,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI0OTc4MjA=","name":"cdk-std","full_name":"mixer/cdk-std","owner":{"login":"mixer","id":11798804,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzk4ODA0","avatar_url":"https://avatars3.githubusercontent.com/u/11798804?v=4","gravatar_id":"","url":"https://api.github.com/users/mixer","html_url":"https://github.com/mixer","followers_url":"https://api.github.com/users/mixer/followers","following_url":"https://api.github.com/users/mixer/following{/other_user}","gists_url":"https://api.github.com/users/mixer/gists{/gist_id}","starred_url":"https://api.github.com/users/mixer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixer/subscriptions","organizations_url":"https://api.github.com/users/mixer/orgs","repos_url":"https://api.github.com/users/mixer/repos","events_url":"https://api.github.com/users/mixer/events{/privacy}","received_events_url":"https://api.github.com/users/mixer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mixer/cdk-std","description":"Standard library for Mixer Interactive controls","fork":false,"url":"https://api.github.com/repos/mixer/cdk-std","forks_url":"https://api.github.com/repos/mixer/cdk-std/forks","keys_url":"https://api.github.com/repos/mixer/cdk-std/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixer/cdk-std/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixer/cdk-std/teams","hooks_url":"https://api.github.com/repos/mixer/cdk-std/hooks","issue_events_url":"https://api.github.com/repos/mixer/cdk-std/issues/events{/number}","events_url":"https://api.github.com/repos/mixer/cdk-std/events","assignees_url":"https://api.github.com/repos/mixer/cdk-std/assignees{/user}","branches_url":"https://api.github.com/repos/mixer/cdk-std/branches{/branch}","tags_url":"https://api.github.com/repos/mixer/cdk-std/tags","blobs_url":"https://api.github.com/repos/mixer/cdk-std/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixer/cdk-std/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixer/cdk-std/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixer/cdk-std/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixer/cdk-std/statuses/{sha}","languages_url":"https://api.github.com/repos/mixer/cdk-std/languages","stargazers_url":"https://api.github.com/repos/mixer/cdk-std/stargazers","contributors_url":"https://api.github.com/repos/mixer/cdk-std/contributors","subscribers_url":"https://api.github.com/repos/mixer/cdk-std/subscribers","subscription_url":"https://api.github.com/repos/mixer/cdk-std/subscription","commits_url":"https://api.github.com/repos/mixer/cdk-std/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixer/cdk-std/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixer/cdk-std/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixer/cdk-std/issues/comments{/number}","contents_url":"https://api.github.com/repos/mixer/cdk-std/contents/{+path}","compare_url":"https://api.github.com/repos/mixer/cdk-std/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixer/cdk-std/merges","archive_url":"https://api.github.com/repos/mixer/cdk-std/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixer/cdk-std/downloads","issues_url":"https://api.github.com/repos/mixer/cdk-std/issues{/number}","pulls_url":"https://api.github.com/repos/mixer/cdk-std/pulls{/number}","milestones_url":"https://api.github.com/repos/mixer/cdk-std/milestones{/number}","notifications_url":"https://api.github.com/repos/mixer/cdk-std/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixer/cdk-std/labels{/name}","releases_url":"https://api.github.com/repos/mixer/cdk-std/releases{/id}","deployments_url":"https://api.github.com/repos/mixer/cdk-std/deployments","created_at":"2017-09-05T15:22:15Z","updated_at":"2018-06-02T10:39:03Z","pushed_at":"2018-06-14T00:41:00Z","git_url":"git://github.com/mixer/cdk-std.git","ssh_url":"git@github.com:mixer/cdk-std.git","clone_url":"https://github.com/mixer/cdk-std.git","svn_url":"https://github.com/mixer/cdk-std","homepage":"https://mixer.github.io/cdk-std/","size":821,"stargazers_count":2,"watchers_count":2,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":5,"watchers":2,"default_branch":"master"}},"base":{"label":"mixer:master","ref":"master","sha":"9aedba6b72a8ca3ebaae91924161c621e5e2da5a","user":{"login":"mixer","id":11798804,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzk4ODA0","avatar_url":"https://avatars3.githubusercontent.com/u/11798804?v=4","gravatar_id":"","url":"https://api.github.com/users/mixer","html_url":"https://github.com/mixer","followers_url":"https://api.github.com/users/mixer/followers","following_url":"https://api.github.com/users/mixer/following{/other_user}","gists_url":"https://api.github.com/users/mixer/gists{/gist_id}","starred_url":"https://api.github.com/users/mixer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixer/subscriptions","organizations_url":"https://api.github.com/users/mixer/orgs","repos_url":"https://api.github.com/users/mixer/repos","events_url":"https://api.github.com/users/mixer/events{/privacy}","received_events_url":"https://api.github.com/users/mixer/received_events","type":"Organization","site_admin":false},"repo":{"id":102497820,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI0OTc4MjA=","name":"cdk-std","full_name":"mixer/cdk-std","owner":{"login":"mixer","id":11798804,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzk4ODA0","avatar_url":"https://avatars3.githubusercontent.com/u/11798804?v=4","gravatar_id":"","url":"https://api.github.com/users/mixer","html_url":"https://github.com/mixer","followers_url":"https://api.github.com/users/mixer/followers","following_url":"https://api.github.com/users/mixer/following{/other_user}","gists_url":"https://api.github.com/users/mixer/gists{/gist_id}","starred_url":"https://api.github.com/users/mixer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixer/subscriptions","organizations_url":"https://api.github.com/users/mixer/orgs","repos_url":"https://api.github.com/users/mixer/repos","events_url":"https://api.github.com/users/mixer/events{/privacy}","received_events_url":"https://api.github.com/users/mixer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mixer/cdk-std","description":"Standard library for Mixer Interactive controls","fork":false,"url":"https://api.github.com/repos/mixer/cdk-std","forks_url":"https://api.github.com/repos/mixer/cdk-std/forks","keys_url":"https://api.github.com/repos/mixer/cdk-std/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixer/cdk-std/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixer/cdk-std/teams","hooks_url":"https://api.github.com/repos/mixer/cdk-std/hooks","issue_events_url":"https://api.github.com/repos/mixer/cdk-std/issues/events{/number}","events_url":"https://api.github.com/repos/mixer/cdk-std/events","assignees_url":"https://api.github.com/repos/mixer/cdk-std/assignees{/user}","branches_url":"https://api.github.com/repos/mixer/cdk-std/branches{/branch}","tags_url":"https://api.github.com/repos/mixer/cdk-std/tags","blobs_url":"https://api.github.com/repos/mixer/cdk-std/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixer/cdk-std/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixer/cdk-std/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixer/cdk-std/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixer/cdk-std/statuses/{sha}","languages_url":"https://api.github.com/repos/mixer/cdk-std/languages","stargazers_url":"https://api.github.com/repos/mixer/cdk-std/stargazers","contributors_url":"https://api.github.com/repos/mixer/cdk-std/contributors","subscribers_url":"https://api.github.com/repos/mixer/cdk-std/subscribers","subscription_url":"https://api.github.com/repos/mixer/cdk-std/subscription","commits_url":"https://api.github.com/repos/mixer/cdk-std/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixer/cdk-std/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixer/cdk-std/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixer/cdk-std/issues/comments{/number}","contents_url":"https://api.github.com/repos/mixer/cdk-std/contents/{+path}","compare_url":"https://api.github.com/repos/mixer/cdk-std/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixer/cdk-std/merges","archive_url":"https://api.github.com/repos/mixer/cdk-std/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixer/cdk-std/downloads","issues_url":"https://api.github.com/repos/mixer/cdk-std/issues{/number}","pulls_url":"https://api.github.com/repos/mixer/cdk-std/pulls{/number}","milestones_url":"https://api.github.com/repos/mixer/cdk-std/milestones{/number}","notifications_url":"https://api.github.com/repos/mixer/cdk-std/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixer/cdk-std/labels{/name}","releases_url":"https://api.github.com/repos/mixer/cdk-std/releases{/id}","deployments_url":"https://api.github.com/repos/mixer/cdk-std/deployments","created_at":"2017-09-05T15:22:15Z","updated_at":"2018-06-02T10:39:03Z","pushed_at":"2018-06-14T00:41:00Z","git_url":"git://github.com/mixer/cdk-std.git","ssh_url":"git@github.com:mixer/cdk-std.git","clone_url":"https://github.com/mixer/cdk-std.git","svn_url":"https://github.com/mixer/cdk-std","homepage":"https://mixer.github.io/cdk-std/","size":821,"stargazers_count":2,"watchers_count":2,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":5,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mixer/cdk-std/pulls/23"},"html":{"href":"https://github.com/mixer/cdk-std/pull/23"},"issue":{"href":"https://api.github.com/repos/mixer/cdk-std/issues/23"},"comments":{"href":"https://api.github.com/repos/mixer/cdk-std/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/mixer/cdk-std/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/mixer/cdk-std/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mixer/cdk-std/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/mixer/cdk-std/statuses/7a6b93942a33fb7eeb58764de351a7c6d44985a2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rogarMS"}}