{"action":"created","issue":{"url":"https://api.github.com/repos/ssmulders/hashed-passport/issues/4","repository_url":"https://api.github.com/repos/ssmulders/hashed-passport","labels_url":"https://api.github.com/repos/ssmulders/hashed-passport/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/ssmulders/hashed-passport/issues/4/comments","events_url":"https://api.github.com/repos/ssmulders/hashed-passport/issues/4/events","html_url":"https://github.com/ssmulders/hashed-passport/issues/4","id":325624543,"number":4,"title":"salt encryption","user":{"login":"fgibaux","id":1101218,"avatar_url":"https://avatars2.githubusercontent.com/u/1101218?v=4","gravatar_id":"","url":"https://api.github.com/users/fgibaux","html_url":"https://github.com/fgibaux","followers_url":"https://api.github.com/users/fgibaux/followers","following_url":"https://api.github.com/users/fgibaux/following{/other_user}","gists_url":"https://api.github.com/users/fgibaux/gists{/gist_id}","starred_url":"https://api.github.com/users/fgibaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgibaux/subscriptions","organizations_url":"https://api.github.com/users/fgibaux/orgs","repos_url":"https://api.github.com/users/fgibaux/repos","events_url":"https://api.github.com/users/fgibaux/events{/privacy}","received_events_url":"https://api.github.com/users/fgibaux/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-05-23T09:33:38Z","updated_at":"2018-05-23T14:12:58Z","closed_at":"2018-05-23T13:30:51Z","author_association":"NONE","body":"Hi,\r\n\r\nI noticed that the latest change to the salt encryption 69f4fa4 breaks the package as the `encrypt` function doesn't seem to have a constant output (I guess there is some random salt involved in the encryption)."},"comment":{"url":"https://api.github.com/repos/ssmulders/hashed-passport/issues/comments/391362361","html_url":"https://github.com/ssmulders/hashed-passport/issues/4#issuecomment-391362361","issue_url":"https://api.github.com/repos/ssmulders/hashed-passport/issues/4","id":391362361,"user":{"login":"fgibaux","id":1101218,"avatar_url":"https://avatars2.githubusercontent.com/u/1101218?v=4","gravatar_id":"","url":"https://api.github.com/users/fgibaux","html_url":"https://github.com/fgibaux","followers_url":"https://api.github.com/users/fgibaux/followers","following_url":"https://api.github.com/users/fgibaux/following{/other_user}","gists_url":"https://api.github.com/users/fgibaux/gists{/gist_id}","starred_url":"https://api.github.com/users/fgibaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgibaux/subscriptions","organizations_url":"https://api.github.com/users/fgibaux/orgs","repos_url":"https://api.github.com/users/fgibaux/repos","events_url":"https://api.github.com/users/fgibaux/events{/privacy}","received_events_url":"https://api.github.com/users/fgibaux/received_events","type":"User","site_admin":false},"created_at":"2018-05-23T14:12:58Z","updated_at":"2018-05-23T14:12:58Z","author_association":"NONE","body":"Thanks for the reactivity ! Actually was not that urgent because the commit wasn't yet in the release.\r\n\r\nNow I'm wondering if APP_NAME is a good choice. Also I guess changing the origin of the salt breaks all the current implementation as the hashed id changed. :confused: \r\n\r\nMaybe a config value of some sort, with the default as APP_KEY to remain backward compatible, while still allowing people to use something more safe? "}}
{"actor":{"display_login":"fgibaux"}}