{"action":"created","comment":{"url":"https://api.github.com/repos/jruby/jruby/pulls/comments/242659215","pull_request_review_id":186224232,"id":242659215,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjY1OTIxNQ==","diff_hunk":"@@ -1,19 +1,21 @@\n package org.jruby.ir.runtime;\n \n import org.jruby.exceptions.Unrescuable;\n-import org.jruby.runtime.DynamicScope;\n+import org.jruby.ir.IRScope;\n \n public class IRReturnJump extends IRJump implements Unrescuable {\n-    public final DynamicScope methodToReturnFrom;\n+    public final IRScope returnScope;\n+    public final IRScope methodToReturnFrom;\n     public final Object returnValue;\n \n-    private IRReturnJump(DynamicScope scopeToReturnFrom, Object rv) {\n+    private IRReturnJump(IRScope returnScope, IRScope scopeToReturnFrom, Object rv) {","path":"core/src/main/java/org/jruby/ir/runtime/IRReturnJump.java","position":14,"original_position":14,"commit_id":"142d6255934b36f5659821b328e7edd660b85d37","original_commit_id":"142d6255934b36f5659821b328e7edd660b85d37","user":{"login":"enebo","id":19819,"node_id":"MDQ6VXNlcjE5ODE5","avatar_url":"https://avatars1.githubusercontent.com/u/19819?v=4","gravatar_id":"","url":"https://api.github.com/users/enebo","html_url":"https://github.com/enebo","followers_url":"https://api.github.com/users/enebo/followers","following_url":"https://api.github.com/users/enebo/following{/other_user}","gists_url":"https://api.github.com/users/enebo/gists{/gist_id}","starred_url":"https://api.github.com/users/enebo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enebo/subscriptions","organizations_url":"https://api.github.com/users/enebo/orgs","repos_url":"https://api.github.com/users/enebo/repos","events_url":"https://api.github.com/users/enebo/events{/privacy}","received_events_url":"https://api.github.com/users/enebo/received_events","type":"User","site_admin":false},"body":"returnScope is the scope where the return lives and scopeToReturnFrmo is where the return will exit from.  I am happy to change those though.","created_at":"2018-12-18T18:47:49Z","updated_at":"2018-12-18T18:47:49Z","html_url":"https://github.com/jruby/jruby/pull/5527#discussion_r242659215","pull_request_url":"https://api.github.com/repos/jruby/jruby/pulls/5527","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jruby/jruby/pulls/comments/242659215"},"html":{"href":"https://github.com/jruby/jruby/pull/5527#discussion_r242659215"},"pull_request":{"href":"https://api.github.com/repos/jruby/jruby/pulls/5527"}},"in_reply_to_id":242654970},"pull_request":{"url":"https://api.github.com/repos/jruby/jruby/pulls/5527","id":239310087,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MzEwMDg3","html_url":"https://github.com/jruby/jruby/pull/5527","diff_url":"https://github.com/jruby/jruby/pull/5527.diff","patch_url":"https://github.com/jruby/jruby/pull/5527.patch","issue_url":"https://api.github.com/repos/jruby/jruby/issues/5527","number":5527,"state":"open","locked":false,"title":"Fixes #5517 (returns in unexpected place)","user":{"login":"enebo","id":19819,"node_id":"MDQ6VXNlcjE5ODE5","avatar_url":"https://avatars1.githubusercontent.com/u/19819?v=4","gravatar_id":"","url":"https://api.github.com/users/enebo","html_url":"https://github.com/enebo","followers_url":"https://api.github.com/users/enebo/followers","following_url":"https://api.github.com/users/enebo/following{/other_user}","gists_url":"https://api.github.com/users/enebo/gists{/gist_id}","starred_url":"https://api.github.com/users/enebo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enebo/subscriptions","organizations_url":"https://api.github.com/users/enebo/orgs","repos_url":"https://api.github.com/users/enebo/repos","events_url":"https://api.github.com/users/enebo/events{/privacy}","received_events_url":"https://api.github.com/users/enebo/received_events","type":"User","site_admin":false},"body":"My main commit explains most of the details of what changed.  See #5517 for more on what was broken.","created_at":"2018-12-17T22:51:06Z","updated_at":"2018-12-18T18:47:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a95ae7e7bc4ea95e0407109bfac0fc828fda5c7c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/jruby/jruby/milestones/77","html_url":"https://github.com/jruby/jruby/milestone/77","labels_url":"https://api.github.com/repos/jruby/jruby/milestones/77/labels","id":3818976,"node_id":"MDk6TWlsZXN0b25lMzgxODk3Ng==","number":77,"title":"JRuby 9.2.6.0","description":"","creator":{"login":"enebo","id":19819,"node_id":"MDQ6VXNlcjE5ODE5","avatar_url":"https://avatars1.githubusercontent.com/u/19819?v=4","gravatar_id":"","url":"https://api.github.com/users/enebo","html_url":"https://github.com/enebo","followers_url":"https://api.github.com/users/enebo/followers","following_url":"https://api.github.com/users/enebo/following{/other_user}","gists_url":"https://api.github.com/users/enebo/gists{/gist_id}","starred_url":"https://api.github.com/users/enebo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enebo/subscriptions","organizations_url":"https://api.github.com/users/enebo/orgs","repos_url":"https://api.github.com/users/enebo/repos","events_url":"https://api.github.com/users/enebo/events{/privacy}","received_events_url":"https://api.github.com/users/enebo/received_events","type":"User","site_admin":false},"open_issues":54,"closed_issues":22,"state":"open","created_at":"2018-11-13T19:33:28Z","updated_at":"2018-12-18T18:44:55Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/jruby/jruby/pulls/5527/commits","review_comments_url":"https://api.github.com/repos/jruby/jruby/pulls/5527/comments","review_comment_url":"https://api.github.com/repos/jruby/jruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jruby/jruby/issues/5527/comments","statuses_url":"https://api.github.com/repos/jruby/jruby/statuses/142d6255934b36f5659821b328e7edd660b85d37","head":{"label":"jruby:gh5517","ref":"gh5517","sha":"142d6255934b36f5659821b328e7edd660b85d37","user":{"login":"jruby","id":55687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1Njg3","avatar_url":"https://avatars2.githubusercontent.com/u/55687?v=4","gravatar_id":"","url":"https://api.github.com/users/jruby","html_url":"https://github.com/jruby","followers_url":"https://api.github.com/users/jruby/followers","following_url":"https://api.github.com/users/jruby/following{/other_user}","gists_url":"https://api.github.com/users/jruby/gists{/gist_id}","starred_url":"https://api.github.com/users/jruby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jruby/subscriptions","organizations_url":"https://api.github.com/users/jruby/orgs","repos_url":"https://api.github.com/users/jruby/repos","events_url":"https://api.github.com/users/jruby/events{/privacy}","received_events_url":"https://api.github.com/users/jruby/received_events","type":"Organization","site_admin":false},"repo":{"id":168370,"node_id":"MDEwOlJlcG9zaXRvcnkxNjgzNzA=","name":"jruby","full_name":"jruby/jruby","private":false,"owner":{"login":"jruby","id":55687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1Njg3","avatar_url":"https://avatars2.githubusercontent.com/u/55687?v=4","gravatar_id":"","url":"https://api.github.com/users/jruby","html_url":"https://github.com/jruby","followers_url":"https://api.github.com/users/jruby/followers","following_url":"https://api.github.com/users/jruby/following{/other_user}","gists_url":"https://api.github.com/users/jruby/gists{/gist_id}","starred_url":"https://api.github.com/users/jruby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jruby/subscriptions","organizations_url":"https://api.github.com/users/jruby/orgs","repos_url":"https://api.github.com/users/jruby/repos","events_url":"https://api.github.com/users/jruby/events{/privacy}","received_events_url":"https://api.github.com/users/jruby/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jruby/jruby","description":"JRuby, an implementation of Ruby on the JVM","fork":false,"url":"https://api.github.com/repos/jruby/jruby","forks_url":"https://api.github.com/repos/jruby/jruby/forks","keys_url":"https://api.github.com/repos/jruby/jruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jruby/jruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jruby/jruby/teams","hooks_url":"https://api.github.com/repos/jruby/jruby/hooks","issue_events_url":"https://api.github.com/repos/jruby/jruby/issues/events{/number}","events_url":"https://api.github.com/repos/jruby/jruby/events","assignees_url":"https://api.github.com/repos/jruby/jruby/assignees{/user}","branches_url":"https://api.github.com/repos/jruby/jruby/branches{/branch}","tags_url":"https://api.github.com/repos/jruby/jruby/tags","blobs_url":"https://api.github.com/repos/jruby/jruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jruby/jruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jruby/jruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/jruby/jruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jruby/jruby/statuses/{sha}","languages_url":"https://api.github.com/repos/jruby/jruby/languages","stargazers_url":"https://api.github.com/repos/jruby/jruby/stargazers","contributors_url":"https://api.github.com/repos/jruby/jruby/contributors","subscribers_url":"https://api.github.com/repos/jruby/jruby/subscribers","subscription_url":"https://api.github.com/repos/jruby/jruby/subscription","commits_url":"https://api.github.com/repos/jruby/jruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/jruby/jruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/jruby/jruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/jruby/jruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/jruby/jruby/contents/{+path}","compare_url":"https://api.github.com/repos/jruby/jruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jruby/jruby/merges","archive_url":"https://api.github.com/repos/jruby/jruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jruby/jruby/downloads","issues_url":"https://api.github.com/repos/jruby/jruby/issues{/number}","pulls_url":"https://api.github.com/repos/jruby/jruby/pulls{/number}","milestones_url":"https://api.github.com/repos/jruby/jruby/milestones{/number}","notifications_url":"https://api.github.com/repos/jruby/jruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jruby/jruby/labels{/name}","releases_url":"https://api.github.com/repos/jruby/jruby/releases{/id}","deployments_url":"https://api.github.com/repos/jruby/jruby/deployments","created_at":"2009-04-05T03:54:35Z","updated_at":"2018-12-18T18:12:26Z","pushed_at":"2018-12-18T18:22:06Z","git_url":"git://github.com/jruby/jruby.git","ssh_url":"git@github.com:jruby/jruby.git","clone_url":"https://github.com/jruby/jruby.git","svn_url":"https://github.com/jruby/jruby","homepage":"http://www.jruby.org","size":228157,"stargazers_count":3232,"watchers_count":3232,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":812,"mirror_url":null,"archived":false,"open_issues_count":608,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":812,"open_issues":608,"watchers":3232,"default_branch":"master"}},"base":{"label":"jruby:master","ref":"master","sha":"7f44f305a5090892170ec77fccc74d63c77445d7","user":{"login":"jruby","id":55687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1Njg3","avatar_url":"https://avatars2.githubusercontent.com/u/55687?v=4","gravatar_id":"","url":"https://api.github.com/users/jruby","html_url":"https://github.com/jruby","followers_url":"https://api.github.com/users/jruby/followers","following_url":"https://api.github.com/users/jruby/following{/other_user}","gists_url":"https://api.github.com/users/jruby/gists{/gist_id}","starred_url":"https://api.github.com/users/jruby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jruby/subscriptions","organizations_url":"https://api.github.com/users/jruby/orgs","repos_url":"https://api.github.com/users/jruby/repos","events_url":"https://api.github.com/users/jruby/events{/privacy}","received_events_url":"https://api.github.com/users/jruby/received_events","type":"Organization","site_admin":false},"repo":{"id":168370,"node_id":"MDEwOlJlcG9zaXRvcnkxNjgzNzA=","name":"jruby","full_name":"jruby/jruby","private":false,"owner":{"login":"jruby","id":55687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1Njg3","avatar_url":"https://avatars2.githubusercontent.com/u/55687?v=4","gravatar_id":"","url":"https://api.github.com/users/jruby","html_url":"https://github.com/jruby","followers_url":"https://api.github.com/users/jruby/followers","following_url":"https://api.github.com/users/jruby/following{/other_user}","gists_url":"https://api.github.com/users/jruby/gists{/gist_id}","starred_url":"https://api.github.com/users/jruby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jruby/subscriptions","organizations_url":"https://api.github.com/users/jruby/orgs","repos_url":"https://api.github.com/users/jruby/repos","events_url":"https://api.github.com/users/jruby/events{/privacy}","received_events_url":"https://api.github.com/users/jruby/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jruby/jruby","description":"JRuby, an implementation of Ruby on the JVM","fork":false,"url":"https://api.github.com/repos/jruby/jruby","forks_url":"https://api.github.com/repos/jruby/jruby/forks","keys_url":"https://api.github.com/repos/jruby/jruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jruby/jruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jruby/jruby/teams","hooks_url":"https://api.github.com/repos/jruby/jruby/hooks","issue_events_url":"https://api.github.com/repos/jruby/jruby/issues/events{/number}","events_url":"https://api.github.com/repos/jruby/jruby/events","assignees_url":"https://api.github.com/repos/jruby/jruby/assignees{/user}","branches_url":"https://api.github.com/repos/jruby/jruby/branches{/branch}","tags_url":"https://api.github.com/repos/jruby/jruby/tags","blobs_url":"https://api.github.com/repos/jruby/jruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jruby/jruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jruby/jruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/jruby/jruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jruby/jruby/statuses/{sha}","languages_url":"https://api.github.com/repos/jruby/jruby/languages","stargazers_url":"https://api.github.com/repos/jruby/jruby/stargazers","contributors_url":"https://api.github.com/repos/jruby/jruby/contributors","subscribers_url":"https://api.github.com/repos/jruby/jruby/subscribers","subscription_url":"https://api.github.com/repos/jruby/jruby/subscription","commits_url":"https://api.github.com/repos/jruby/jruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/jruby/jruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/jruby/jruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/jruby/jruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/jruby/jruby/contents/{+path}","compare_url":"https://api.github.com/repos/jruby/jruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jruby/jruby/merges","archive_url":"https://api.github.com/repos/jruby/jruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jruby/jruby/downloads","issues_url":"https://api.github.com/repos/jruby/jruby/issues{/number}","pulls_url":"https://api.github.com/repos/jruby/jruby/pulls{/number}","milestones_url":"https://api.github.com/repos/jruby/jruby/milestones{/number}","notifications_url":"https://api.github.com/repos/jruby/jruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jruby/jruby/labels{/name}","releases_url":"https://api.github.com/repos/jruby/jruby/releases{/id}","deployments_url":"https://api.github.com/repos/jruby/jruby/deployments","created_at":"2009-04-05T03:54:35Z","updated_at":"2018-12-18T18:12:26Z","pushed_at":"2018-12-18T18:22:06Z","git_url":"git://github.com/jruby/jruby.git","ssh_url":"git@github.com:jruby/jruby.git","clone_url":"https://github.com/jruby/jruby.git","svn_url":"https://github.com/jruby/jruby","homepage":"http://www.jruby.org","size":228157,"stargazers_count":3232,"watchers_count":3232,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":812,"mirror_url":null,"archived":false,"open_issues_count":608,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":812,"open_issues":608,"watchers":3232,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jruby/jruby/pulls/5527"},"html":{"href":"https://github.com/jruby/jruby/pull/5527"},"issue":{"href":"https://api.github.com/repos/jruby/jruby/issues/5527"},"comments":{"href":"https://api.github.com/repos/jruby/jruby/issues/5527/comments"},"review_comments":{"href":"https://api.github.com/repos/jruby/jruby/pulls/5527/comments"},"review_comment":{"href":"https://api.github.com/repos/jruby/jruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jruby/jruby/pulls/5527/commits"},"statuses":{"href":"https://api.github.com/repos/jruby/jruby/statuses/142d6255934b36f5659821b328e7edd660b85d37"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"enebo"}}