{"action":"created","comment":{"url":"https://api.github.com/repos/SAP/fundamental/pulls/comments/238264195","pull_request_review_id":180759838,"id":238264195,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODI2NDE5NQ==","diff_hunk":"@@ -33,13 +33,14 @@ product_menu:\n   }}\n </div>\n {%- else %}\n-{{ product_menu_logo(logo=brand.logo, name=brand.name) }} <span class=\"fd-shellbar__title\">{{ product.title }}</span>\n+{# {{ product_menu_logo(logo=brand.logo, name=brand.name) }}  #}<span class=\"fd-shellbar__title\">{{ product.title }}</span>","path":"test/templates/product-menu/component.njk","position":null,"original_position":5,"commit_id":"8ab3654ce5b7d1021e558c9c6f83aac6bd1f0d0d","original_commit_id":"8565013f28ce0d45b46f3ba728daa76214ca0db2","user":{"login":"xak","id":424119,"node_id":"MDQ6VXNlcjQyNDExOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/424119?v=4","gravatar_id":"","url":"https://api.github.com/users/xak","html_url":"https://github.com/xak","followers_url":"https://api.github.com/users/xak/followers","following_url":"https://api.github.com/users/xak/following{/other_user}","gists_url":"https://api.github.com/users/xak/gists{/gist_id}","starred_url":"https://api.github.com/users/xak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xak/subscriptions","organizations_url":"https://api.github.com/users/xak/orgs","repos_url":"https://api.github.com/users/xak/repos","events_url":"https://api.github.com/users/xak/events{/privacy}","received_events_url":"https://api.github.com/users/xak/received_events","type":"User","site_admin":false},"body":"Done. I revisited the duplicate logo and opted to remove it.","created_at":"2018-12-03T13:19:02Z","updated_at":"2018-12-03T13:19:02Z","html_url":"https://github.com/SAP/fundamental/pull/1057#discussion_r238264195","pull_request_url":"https://api.github.com/repos/SAP/fundamental/pulls/1057","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SAP/fundamental/pulls/comments/238264195"},"html":{"href":"https://github.com/SAP/fundamental/pull/1057#discussion_r238264195"},"pull_request":{"href":"https://api.github.com/repos/SAP/fundamental/pulls/1057"}},"in_reply_to_id":238218377},"pull_request":{"url":"https://api.github.com/repos/SAP/fundamental/pulls/1057","id":235320959,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MzIwOTU5","html_url":"https://github.com/SAP/fundamental/pull/1057","diff_url":"https://github.com/SAP/fundamental/pull/1057.diff","patch_url":"https://github.com/SAP/fundamental/pull/1057.patch","issue_url":"https://api.github.com/repos/SAP/fundamental/issues/1057","number":1057,"state":"open","locked":false,"title":"Feature/1008 shell docs","user":{"login":"xak","id":424119,"node_id":"MDQ6VXNlcjQyNDExOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/424119?v=4","gravatar_id":"","url":"https://api.github.com/users/xak","html_url":"https://github.com/xak","followers_url":"https://api.github.com/users/xak/followers","following_url":"https://api.github.com/users/xak/following{/other_user}","gists_url":"https://api.github.com/users/xak/gists{/gist_id}","starred_url":"https://api.github.com/users/xak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xak/subscriptions","organizations_url":"https://api.github.com/users/xak/orgs","repos_url":"https://api.github.com/users/xak/repos","events_url":"https://api.github.com/users/xak/events{/privacy}","received_events_url":"https://api.github.com/users/xak/received_events","type":"User","site_admin":false},"body":"Closes sap/fundamental#1008\r\n\r\nImplements `shell` layout containers to replace `ui`; implements `shellbar` to replace `global-nav`. Also updates all demo pages to use the new shellbar and layout containers.\r\n\r\n> #1055 must be completed before release\r\n\r\n#### Test\r\n\r\n* https://deploy-preview-1057--fundamental.netlify.com/layouts/index.html\r\n* https://deploy-preview-1057--fundamental.netlify.com/layouts/application-layout.html\r\n* https://deploy-preview-1057--fundamental.netlify.com/components/shellbar.html\r\n* https://deploy-preview-1057--fundamental.netlify.com/demo-pages/index.html\r\nhttps://deploy-preview-1057--fundamental.netlify.com/demo-pages/full-width-app-demo.html\r\n\r\n\r\n#### Changelog\r\n\r\n**New**\r\n\r\n* Shellbar added conforming to Fiori 3 specifications\r\n\r\n**Changed**\r\n\r\n* High-level layout containers have been updated to use `shell`\r\n* App-level `app__sidebar` container is now `app__naviagtion` with `--horizontal` and `--vertical` orientations \r\n\r\n**Removed**\r\n\r\n* Layout `ui` and `global-nav` will be deprecated in a future release\r\n\r\n","created_at":"2018-12-03T04:07:33Z","updated_at":"2018-12-03T13:19:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b004199f110cc7d009dc5bfa8d19becc845fe90","assignee":null,"assignees":[],"requested_reviewers":[{"login":"eboyer","id":97936,"node_id":"MDQ6VXNlcjk3OTM2","avatar_url":"https://avatars1.githubusercontent.com/u/97936?v=4","gravatar_id":"","url":"https://api.github.com/users/eboyer","html_url":"https://github.com/eboyer","followers_url":"https://api.github.com/users/eboyer/followers","following_url":"https://api.github.com/users/eboyer/following{/other_user}","gists_url":"https://api.github.com/users/eboyer/gists{/gist_id}","starred_url":"https://api.github.com/users/eboyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eboyer/subscriptions","organizations_url":"https://api.github.com/users/eboyer/orgs","repos_url":"https://api.github.com/users/eboyer/repos","events_url":"https://api.github.com/users/eboyer/events{/privacy}","received_events_url":"https://api.github.com/users/eboyer/received_events","type":"User","site_admin":false},{"login":"saadmhybris","id":15215400,"node_id":"MDQ6VXNlcjE1MjE1NDAw","avatar_url":"https://avatars0.githubusercontent.com/u/15215400?v=4","gravatar_id":"","url":"https://api.github.com/users/saadmhybris","html_url":"https://github.com/saadmhybris","followers_url":"https://api.github.com/users/saadmhybris/followers","following_url":"https://api.github.com/users/saadmhybris/following{/other_user}","gists_url":"https://api.github.com/users/saadmhybris/gists{/gist_id}","starred_url":"https://api.github.com/users/saadmhybris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saadmhybris/subscriptions","organizations_url":"https://api.github.com/users/saadmhybris/orgs","repos_url":"https://api.github.com/users/saadmhybris/repos","events_url":"https://api.github.com/users/saadmhybris/events{/privacy}","received_events_url":"https://api.github.com/users/saadmhybris/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SAP/fundamental/pulls/1057/commits","review_comments_url":"https://api.github.com/repos/SAP/fundamental/pulls/1057/comments","review_comment_url":"https://api.github.com/repos/SAP/fundamental/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SAP/fundamental/issues/1057/comments","statuses_url":"https://api.github.com/repos/SAP/fundamental/statuses/8ab3654ce5b7d1021e558c9c6f83aac6bd1f0d0d","head":{"label":"SAP:feature/1008-shell-docs","ref":"feature/1008-shell-docs","sha":"8ab3654ce5b7d1021e558c9c6f83aac6bd1f0d0d","user":{"login":"SAP","id":2531208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzEyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2531208?v=4","gravatar_id":"","url":"https://api.github.com/users/SAP","html_url":"https://github.com/SAP","followers_url":"https://api.github.com/users/SAP/followers","following_url":"https://api.github.com/users/SAP/following{/other_user}","gists_url":"https://api.github.com/users/SAP/gists{/gist_id}","starred_url":"https://api.github.com/users/SAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAP/subscriptions","organizations_url":"https://api.github.com/users/SAP/orgs","repos_url":"https://api.github.com/users/SAP/repos","events_url":"https://api.github.com/users/SAP/events{/privacy}","received_events_url":"https://api.github.com/users/SAP/received_events","type":"Organization","site_admin":false},"repo":{"id":108157725,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgxNTc3MjU=","name":"fundamental","full_name":"SAP/fundamental","private":false,"owner":{"login":"SAP","id":2531208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzEyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2531208?v=4","gravatar_id":"","url":"https://api.github.com/users/SAP","html_url":"https://github.com/SAP","followers_url":"https://api.github.com/users/SAP/followers","following_url":"https://api.github.com/users/SAP/following{/other_user}","gists_url":"https://api.github.com/users/SAP/gists{/gist_id}","starred_url":"https://api.github.com/users/SAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAP/subscriptions","organizations_url":"https://api.github.com/users/SAP/orgs","repos_url":"https://api.github.com/users/SAP/repos","events_url":"https://api.github.com/users/SAP/events{/privacy}","received_events_url":"https://api.github.com/users/SAP/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SAP/fundamental","description":"SAP Fiori Fundamentals is a Fiori 3.0 component library and SASS toolkit for building SAP user interfaces with any technology.","fork":false,"url":"https://api.github.com/repos/SAP/fundamental","forks_url":"https://api.github.com/repos/SAP/fundamental/forks","keys_url":"https://api.github.com/repos/SAP/fundamental/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SAP/fundamental/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SAP/fundamental/teams","hooks_url":"https://api.github.com/repos/SAP/fundamental/hooks","issue_events_url":"https://api.github.com/repos/SAP/fundamental/issues/events{/number}","events_url":"https://api.github.com/repos/SAP/fundamental/events","assignees_url":"https://api.github.com/repos/SAP/fundamental/assignees{/user}","branches_url":"https://api.github.com/repos/SAP/fundamental/branches{/branch}","tags_url":"https://api.github.com/repos/SAP/fundamental/tags","blobs_url":"https://api.github.com/repos/SAP/fundamental/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SAP/fundamental/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SAP/fundamental/git/refs{/sha}","trees_url":"https://api.github.com/repos/SAP/fundamental/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SAP/fundamental/statuses/{sha}","languages_url":"https://api.github.com/repos/SAP/fundamental/languages","stargazers_url":"https://api.github.com/repos/SAP/fundamental/stargazers","contributors_url":"https://api.github.com/repos/SAP/fundamental/contributors","subscribers_url":"https://api.github.com/repos/SAP/fundamental/subscribers","subscription_url":"https://api.github.com/repos/SAP/fundamental/subscription","commits_url":"https://api.github.com/repos/SAP/fundamental/commits{/sha}","git_commits_url":"https://api.github.com/repos/SAP/fundamental/git/commits{/sha}","comments_url":"https://api.github.com/repos/SAP/fundamental/comments{/number}","issue_comment_url":"https://api.github.com/repos/SAP/fundamental/issues/comments{/number}","contents_url":"https://api.github.com/repos/SAP/fundamental/contents/{+path}","compare_url":"https://api.github.com/repos/SAP/fundamental/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SAP/fundamental/merges","archive_url":"https://api.github.com/repos/SAP/fundamental/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SAP/fundamental/downloads","issues_url":"https://api.github.com/repos/SAP/fundamental/issues{/number}","pulls_url":"https://api.github.com/repos/SAP/fundamental/pulls{/number}","milestones_url":"https://api.github.com/repos/SAP/fundamental/milestones{/number}","notifications_url":"https://api.github.com/repos/SAP/fundamental/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SAP/fundamental/labels{/name}","releases_url":"https://api.github.com/repos/SAP/fundamental/releases{/id}","deployments_url":"https://api.github.com/repos/SAP/fundamental/deployments","created_at":"2017-10-24T17:01:41Z","updated_at":"2018-12-03T09:20:41Z","pushed_at":"2018-12-03T13:15:44Z","git_url":"git://github.com/SAP/fundamental.git","ssh_url":"git@github.com:SAP/fundamental.git","clone_url":"https://github.com/SAP/fundamental.git","svn_url":"https://github.com/SAP/fundamental","homepage":"","size":66803,"stargazers_count":85,"watchers_count":85,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":185,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":15,"open_issues":185,"watchers":85,"default_branch":"develop"}},"base":{"label":"SAP:develop","ref":"develop","sha":"fc5ffe59dea104e59b078cfe3d7ee06782133f26","user":{"login":"SAP","id":2531208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzEyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2531208?v=4","gravatar_id":"","url":"https://api.github.com/users/SAP","html_url":"https://github.com/SAP","followers_url":"https://api.github.com/users/SAP/followers","following_url":"https://api.github.com/users/SAP/following{/other_user}","gists_url":"https://api.github.com/users/SAP/gists{/gist_id}","starred_url":"https://api.github.com/users/SAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAP/subscriptions","organizations_url":"https://api.github.com/users/SAP/orgs","repos_url":"https://api.github.com/users/SAP/repos","events_url":"https://api.github.com/users/SAP/events{/privacy}","received_events_url":"https://api.github.com/users/SAP/received_events","type":"Organization","site_admin":false},"repo":{"id":108157725,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgxNTc3MjU=","name":"fundamental","full_name":"SAP/fundamental","private":false,"owner":{"login":"SAP","id":2531208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzEyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2531208?v=4","gravatar_id":"","url":"https://api.github.com/users/SAP","html_url":"https://github.com/SAP","followers_url":"https://api.github.com/users/SAP/followers","following_url":"https://api.github.com/users/SAP/following{/other_user}","gists_url":"https://api.github.com/users/SAP/gists{/gist_id}","starred_url":"https://api.github.com/users/SAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAP/subscriptions","organizations_url":"https://api.github.com/users/SAP/orgs","repos_url":"https://api.github.com/users/SAP/repos","events_url":"https://api.github.com/users/SAP/events{/privacy}","received_events_url":"https://api.github.com/users/SAP/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SAP/fundamental","description":"SAP Fiori Fundamentals is a Fiori 3.0 component library and SASS toolkit for building SAP user interfaces with any technology.","fork":false,"url":"https://api.github.com/repos/SAP/fundamental","forks_url":"https://api.github.com/repos/SAP/fundamental/forks","keys_url":"https://api.github.com/repos/SAP/fundamental/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SAP/fundamental/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SAP/fundamental/teams","hooks_url":"https://api.github.com/repos/SAP/fundamental/hooks","issue_events_url":"https://api.github.com/repos/SAP/fundamental/issues/events{/number}","events_url":"https://api.github.com/repos/SAP/fundamental/events","assignees_url":"https://api.github.com/repos/SAP/fundamental/assignees{/user}","branches_url":"https://api.github.com/repos/SAP/fundamental/branches{/branch}","tags_url":"https://api.github.com/repos/SAP/fundamental/tags","blobs_url":"https://api.github.com/repos/SAP/fundamental/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SAP/fundamental/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SAP/fundamental/git/refs{/sha}","trees_url":"https://api.github.com/repos/SAP/fundamental/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SAP/fundamental/statuses/{sha}","languages_url":"https://api.github.com/repos/SAP/fundamental/languages","stargazers_url":"https://api.github.com/repos/SAP/fundamental/stargazers","contributors_url":"https://api.github.com/repos/SAP/fundamental/contributors","subscribers_url":"https://api.github.com/repos/SAP/fundamental/subscribers","subscription_url":"https://api.github.com/repos/SAP/fundamental/subscription","commits_url":"https://api.github.com/repos/SAP/fundamental/commits{/sha}","git_commits_url":"https://api.github.com/repos/SAP/fundamental/git/commits{/sha}","comments_url":"https://api.github.com/repos/SAP/fundamental/comments{/number}","issue_comment_url":"https://api.github.com/repos/SAP/fundamental/issues/comments{/number}","contents_url":"https://api.github.com/repos/SAP/fundamental/contents/{+path}","compare_url":"https://api.github.com/repos/SAP/fundamental/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SAP/fundamental/merges","archive_url":"https://api.github.com/repos/SAP/fundamental/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SAP/fundamental/downloads","issues_url":"https://api.github.com/repos/SAP/fundamental/issues{/number}","pulls_url":"https://api.github.com/repos/SAP/fundamental/pulls{/number}","milestones_url":"https://api.github.com/repos/SAP/fundamental/milestones{/number}","notifications_url":"https://api.github.com/repos/SAP/fundamental/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SAP/fundamental/labels{/name}","releases_url":"https://api.github.com/repos/SAP/fundamental/releases{/id}","deployments_url":"https://api.github.com/repos/SAP/fundamental/deployments","created_at":"2017-10-24T17:01:41Z","updated_at":"2018-12-03T09:20:41Z","pushed_at":"2018-12-03T13:15:44Z","git_url":"git://github.com/SAP/fundamental.git","ssh_url":"git@github.com:SAP/fundamental.git","clone_url":"https://github.com/SAP/fundamental.git","svn_url":"https://github.com/SAP/fundamental","homepage":"","size":66803,"stargazers_count":85,"watchers_count":85,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":185,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":15,"open_issues":185,"watchers":85,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/SAP/fundamental/pulls/1057"},"html":{"href":"https://github.com/SAP/fundamental/pull/1057"},"issue":{"href":"https://api.github.com/repos/SAP/fundamental/issues/1057"},"comments":{"href":"https://api.github.com/repos/SAP/fundamental/issues/1057/comments"},"review_comments":{"href":"https://api.github.com/repos/SAP/fundamental/pulls/1057/comments"},"review_comment":{"href":"https://api.github.com/repos/SAP/fundamental/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SAP/fundamental/pulls/1057/commits"},"statuses":{"href":"https://api.github.com/repos/SAP/fundamental/statuses/8ab3654ce5b7d1021e558c9c6f83aac6bd1f0d0d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"xak"}}