{"action":"created","comment":{"url":"https://api.github.com/repos/kbase/KBaseSearchEngine/pulls/comments/191969407","pull_request_review_id":124647761,"id":191969407,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MTk2OTQwNw==","diff_hunk":"@@ -128,21 +152,54 @@ public GUID(String textGUID) {\n             this.subObjectId = subObjectPart.substring(slashPos + 1);\n         }\n     }\n-    \n-    //TODO NOW if the version or accessGroupID is missing, how do you know which is which? Need to know storage code -> has access group mapping or have a placeholder (-1) for missing access group\n+\n+    /**\n+     * Returns the URL-encoded version of this GUID.\n+     *\n+     * For the sake of readability the URL-encoded format of the GUID is,\n+     *\n+     *   {storageCode}___[{AccessGroupID}_]{accessGroupObjectId}[_{version}][___{subObjectType}_{subObjectId}],\n+     *\n+     *  where special characters in the individual tokens will get URL-encoded.\n+     *\n+     * @return URL-encoded version of this GUID\n+     */\n+    public String getURLEncoded() throws IOException {\n+\n+        String encodedGUID = toString(\"___\", \"_\");","path":"lib/src/kbasesearchengine/common/GUID.java","position":78,"original_position":78,"commit_id":"2073159fbe892e6a8cce576eac16baba54f06544","original_commit_id":"6a4a8d5fe344b2ad1bebf76a3c81ff547aa1f15f","user":{"login":"MrCreosote","id":1686141,"node_id":"MDQ6VXNlcjE2ODYxNDE=","avatar_url":"https://avatars1.githubusercontent.com/u/1686141?v=4","gravatar_id":"","url":"https://api.github.com/users/MrCreosote","html_url":"https://github.com/MrCreosote","followers_url":"https://api.github.com/users/MrCreosote/followers","following_url":"https://api.github.com/users/MrCreosote/following{/other_user}","gists_url":"https://api.github.com/users/MrCreosote/gists{/gist_id}","starred_url":"https://api.github.com/users/MrCreosote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrCreosote/subscriptions","organizations_url":"https://api.github.com/users/MrCreosote/orgs","repos_url":"https://api.github.com/users/MrCreosote/repos","events_url":"https://api.github.com/users/MrCreosote/events{/privacy}","received_events_url":"https://api.github.com/users/MrCreosote/received_events","type":"User","site_admin":false},"body":"But why do you need to encode it at all? It should work fine without encoding even with curl:\r\n```\r\ncrusherofheads@icrushdeheads:~$ curl \"http://homology.kbase.us/namespace/KBase:Refseq\" | python -m json.tool\r\n  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current\r\n                                 Dload  Upload   Total   Spent    Left  Speed\r\n100   248  100   248    0     0   1578      0 --:--:-- --:--:-- --:--:--  1579\r\n{\r\n    \"error\": {\r\n        \"appcode\": 30001,\r\n        \"apperror\": \"Illegal input parameter\",\r\n        \"callid\": \"4105873853039241\",\r\n        \"httpcode\": 400,\r\n        \"httpstatus\": \"Bad Request\",\r\n        \"message\": \"30001 Illegal input parameter: Illegal character in namespace id KBase:Refseq: :\",\r\n        \"time\": 1527730889932\r\n    }\r\n}\r\n```","created_at":"2018-05-31T01:42:30Z","updated_at":"2018-05-31T01:42:30Z","html_url":"https://github.com/kbase/KBaseSearchEngine/pull/241#discussion_r191969407","pull_request_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/pulls/241","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kbase/KBaseSearchEngine/pulls/comments/191969407"},"html":{"href":"https://github.com/kbase/KBaseSearchEngine/pull/241#discussion_r191969407"},"pull_request":{"href":"https://api.github.com/repos/kbase/KBaseSearchEngine/pulls/241"}},"in_reply_to_id":190772759},"pull_request":{"url":"https://api.github.com/repos/kbase/KBaseSearchEngine/pulls/241","id":185021387,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg1MDIxMzg3","html_url":"https://github.com/kbase/KBaseSearchEngine/pull/241","diff_url":"https://github.com/kbase/KBaseSearchEngine/pull/241.diff","patch_url":"https://github.com/kbase/KBaseSearchEngine/pull/241.patch","issue_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/issues/241","number":241,"state":"open","locked":false,"title":"SCT-653  Added _id field to indexer","user":{"login":"arfathpasha","id":13394200,"node_id":"MDQ6VXNlcjEzMzk0MjAw","avatar_url":"https://avatars1.githubusercontent.com/u/13394200?v=4","gravatar_id":"","url":"https://api.github.com/users/arfathpasha","html_url":"https://github.com/arfathpasha","followers_url":"https://api.github.com/users/arfathpasha/followers","following_url":"https://api.github.com/users/arfathpasha/following{/other_user}","gists_url":"https://api.github.com/users/arfathpasha/gists{/gist_id}","starred_url":"https://api.github.com/users/arfathpasha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arfathpasha/subscriptions","organizations_url":"https://api.github.com/users/arfathpasha/orgs","repos_url":"https://api.github.com/users/arfathpasha/repos","events_url":"https://api.github.com/users/arfathpasha/events{/privacy}","received_events_url":"https://api.github.com/users/arfathpasha/received_events","type":"User","site_admin":false},"body":"- used RFC 4122 compliant UUID for ES _id. This can be produced with any programming language as libs are widely available. \r\n- ES _id field is always going to be 16 bytes long\r\n- No information is lost as GUID can be indexed sperately\r\n\r\nAdditional PRs are required for, \r\n1. Refactoring ElasticSearchIndexingStorage.java to use the _id for lookups\r\n2. Cleaning up GUID.java\r\n","created_at":"2018-04-30T17:54:07Z","updated_at":"2018-05-31T01:42:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"742c03e9e3a6f6623ecaee78ea570086c2eebc7e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/pulls/241/commits","review_comments_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/pulls/241/comments","review_comment_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/issues/241/comments","statuses_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/statuses/2073159fbe892e6a8cce576eac16baba54f06544","head":{"label":"arfathpasha:dev-add-guid-to-es-id","ref":"dev-add-guid-to-es-id","sha":"2073159fbe892e6a8cce576eac16baba54f06544","user":{"login":"arfathpasha","id":13394200,"node_id":"MDQ6VXNlcjEzMzk0MjAw","avatar_url":"https://avatars1.githubusercontent.com/u/13394200?v=4","gravatar_id":"","url":"https://api.github.com/users/arfathpasha","html_url":"https://github.com/arfathpasha","followers_url":"https://api.github.com/users/arfathpasha/followers","following_url":"https://api.github.com/users/arfathpasha/following{/other_user}","gists_url":"https://api.github.com/users/arfathpasha/gists{/gist_id}","starred_url":"https://api.github.com/users/arfathpasha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arfathpasha/subscriptions","organizations_url":"https://api.github.com/users/arfathpasha/orgs","repos_url":"https://api.github.com/users/arfathpasha/repos","events_url":"https://api.github.com/users/arfathpasha/events{/privacy}","received_events_url":"https://api.github.com/users/arfathpasha/received_events","type":"User","site_admin":false},"repo":{"id":113391788,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMzOTE3ODg=","name":"KBaseSearchEngine","full_name":"arfathpasha/KBaseSearchEngine","owner":{"login":"arfathpasha","id":13394200,"node_id":"MDQ6VXNlcjEzMzk0MjAw","avatar_url":"https://avatars1.githubusercontent.com/u/13394200?v=4","gravatar_id":"","url":"https://api.github.com/users/arfathpasha","html_url":"https://github.com/arfathpasha","followers_url":"https://api.github.com/users/arfathpasha/followers","following_url":"https://api.github.com/users/arfathpasha/following{/other_user}","gists_url":"https://api.github.com/users/arfathpasha/gists{/gist_id}","starred_url":"https://api.github.com/users/arfathpasha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arfathpasha/subscriptions","organizations_url":"https://api.github.com/users/arfathpasha/orgs","repos_url":"https://api.github.com/users/arfathpasha/repos","events_url":"https://api.github.com/users/arfathpasha/events{/privacy}","received_events_url":"https://api.github.com/users/arfathpasha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arfathpasha/KBaseSearchEngine","description":null,"fork":true,"url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine","forks_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/forks","keys_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/teams","hooks_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/hooks","issue_events_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/issues/events{/number}","events_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/events","assignees_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/assignees{/user}","branches_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/branches{/branch}","tags_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/tags","blobs_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/git/refs{/sha}","trees_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/statuses/{sha}","languages_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/languages","stargazers_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/stargazers","contributors_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/contributors","subscribers_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/subscribers","subscription_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/subscription","commits_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/commits{/sha}","git_commits_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/git/commits{/sha}","comments_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/comments{/number}","issue_comment_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/issues/comments{/number}","contents_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/contents/{+path}","compare_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/merges","archive_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/downloads","issues_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/issues{/number}","pulls_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/pulls{/number}","milestones_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/milestones{/number}","notifications_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/labels{/name}","releases_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/releases{/id}","deployments_url":"https://api.github.com/repos/arfathpasha/KBaseSearchEngine/deployments","created_at":"2017-12-07T02:23:23Z","updated_at":"2018-04-26T22:08:07Z","pushed_at":"2018-05-30T23:31:48Z","git_url":"git://github.com/arfathpasha/KBaseSearchEngine.git","ssh_url":"git@github.com:arfathpasha/KBaseSearchEngine.git","clone_url":"https://github.com/arfathpasha/KBaseSearchEngine.git","svn_url":"https://github.com/arfathpasha/KBaseSearchEngine","homepage":null,"size":7105,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kbase:develop","ref":"develop","sha":"da56aaf594088a985757f8cd26a778d53807e506","user":{"login":"kbase","id":1263946,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjM5NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1263946?v=4","gravatar_id":"","url":"https://api.github.com/users/kbase","html_url":"https://github.com/kbase","followers_url":"https://api.github.com/users/kbase/followers","following_url":"https://api.github.com/users/kbase/following{/other_user}","gists_url":"https://api.github.com/users/kbase/gists{/gist_id}","starred_url":"https://api.github.com/users/kbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbase/subscriptions","organizations_url":"https://api.github.com/users/kbase/orgs","repos_url":"https://api.github.com/users/kbase/repos","events_url":"https://api.github.com/users/kbase/events{/privacy}","received_events_url":"https://api.github.com/users/kbase/received_events","type":"Organization","site_admin":false},"repo":{"id":87230036,"node_id":"MDEwOlJlcG9zaXRvcnk4NzIzMDAzNg==","name":"KBaseSearchEngine","full_name":"kbase/KBaseSearchEngine","owner":{"login":"kbase","id":1263946,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjM5NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1263946?v=4","gravatar_id":"","url":"https://api.github.com/users/kbase","html_url":"https://github.com/kbase","followers_url":"https://api.github.com/users/kbase/followers","following_url":"https://api.github.com/users/kbase/following{/other_user}","gists_url":"https://api.github.com/users/kbase/gists{/gist_id}","starred_url":"https://api.github.com/users/kbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbase/subscriptions","organizations_url":"https://api.github.com/users/kbase/orgs","repos_url":"https://api.github.com/users/kbase/repos","events_url":"https://api.github.com/users/kbase/events{/privacy}","received_events_url":"https://api.github.com/users/kbase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kbase/KBaseSearchEngine","description":null,"fork":false,"url":"https://api.github.com/repos/kbase/KBaseSearchEngine","forks_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/forks","keys_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/teams","hooks_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/hooks","issue_events_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/issues/events{/number}","events_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/events","assignees_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/assignees{/user}","branches_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/branches{/branch}","tags_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/tags","blobs_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/git/refs{/sha}","trees_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/statuses/{sha}","languages_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/languages","stargazers_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/stargazers","contributors_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/contributors","subscribers_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/subscribers","subscription_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/subscription","commits_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/commits{/sha}","git_commits_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/git/commits{/sha}","comments_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/comments{/number}","issue_comment_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/issues/comments{/number}","contents_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/contents/{+path}","compare_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/merges","archive_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/downloads","issues_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/issues{/number}","pulls_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/pulls{/number}","milestones_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/milestones{/number}","notifications_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/labels{/name}","releases_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/releases{/id}","deployments_url":"https://api.github.com/repos/kbase/KBaseSearchEngine/deployments","created_at":"2017-04-04T20:07:10Z","updated_at":"2018-03-16T18:25:22Z","pushed_at":"2018-05-30T23:31:51Z","git_url":"git://github.com/kbase/KBaseSearchEngine.git","ssh_url":"git@github.com:kbase/KBaseSearchEngine.git","clone_url":"https://github.com/kbase/KBaseSearchEngine.git","svn_url":"https://github.com/kbase/KBaseSearchEngine","homepage":null,"size":6675,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":9,"open_issues":10,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kbase/KBaseSearchEngine/pulls/241"},"html":{"href":"https://github.com/kbase/KBaseSearchEngine/pull/241"},"issue":{"href":"https://api.github.com/repos/kbase/KBaseSearchEngine/issues/241"},"comments":{"href":"https://api.github.com/repos/kbase/KBaseSearchEngine/issues/241/comments"},"review_comments":{"href":"https://api.github.com/repos/kbase/KBaseSearchEngine/pulls/241/comments"},"review_comment":{"href":"https://api.github.com/repos/kbase/KBaseSearchEngine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kbase/KBaseSearchEngine/pulls/241/commits"},"statuses":{"href":"https://api.github.com/repos/kbase/KBaseSearchEngine/statuses/2073159fbe892e6a8cce576eac16baba54f06544"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"MrCreosote"}}