{"action":"created","issue":{"url":"https://api.github.com/repos/Shopify/polaris/issues/387","repository_url":"https://api.github.com/repos/Shopify/polaris","labels_url":"https://api.github.com/repos/Shopify/polaris/issues/387/labels{/name}","comments_url":"https://api.github.com/repos/Shopify/polaris/issues/387/comments","events_url":"https://api.github.com/repos/Shopify/polaris/issues/387/events","html_url":"https://github.com/Shopify/polaris/issues/387","id":346206708,"node_id":"MDU6SXNzdWUzNDYyMDY3MDg=","number":387,"title":"DataTable row heights do not recalculate when row content changes","user":{"login":"andrewpye","id":5737342,"node_id":"MDQ6VXNlcjU3MzczNDI=","avatar_url":"https://avatars3.githubusercontent.com/u/5737342?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewpye","html_url":"https://github.com/andrewpye","followers_url":"https://api.github.com/users/andrewpye/followers","following_url":"https://api.github.com/users/andrewpye/following{/other_user}","gists_url":"https://api.github.com/users/andrewpye/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewpye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewpye/subscriptions","organizations_url":"https://api.github.com/users/andrewpye/orgs","repos_url":"https://api.github.com/users/andrewpye/repos","events_url":"https://api.github.com/users/andrewpye/events{/privacy}","received_events_url":"https://api.github.com/users/andrewpye/received_events","type":"User","site_admin":false},"labels":[{"id":588288143,"node_id":"MDU6TGFiZWw1ODgyODgxNDM=","url":"https://api.github.com/repos/Shopify/polaris/labels/Bug","name":"Bug","color":"ee0701","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-07-31T14:13:37Z","updated_at":"2018-09-11T17:32:45Z","closed_at":null,"author_association":"NONE","body":"# Issue summary\r\nIf the data backing a `DataTable` changes, the table updates to display the new content, but the row heights don't recalculate resulting in issues like this:\r\n\r\n![data-table-row-height](https://user-images.githubusercontent.com/5737342/43464714-76b4ee00-94e4-11e8-8c1c-878d097317fd.gif)\r\n\r\nThe code for the above GIF is [here](https://codesandbox.io/s/189y72pl2j) - when the button is pressed, the first row's title is made significantly longer, the third row's title is made shorter, and a new row is pushed into the table.\r\n\r\n## Expected behavior\r\nRow heights update when table content changes.\r\n\r\n## Actual behavior\r\nRow heights do not update when table content changes, potentially leaving rows too tall/short for their content.\r\n\r\n## Steps to reproduce the problem\r\nUpdate the `rows` array backing the `DataTable`.\r\n\r\n## Specifications\r\n\r\n- Are you using the React components? (Y/N): Y\r\n- Polaris version number: 2.5.0\r\n- Browser: Chrome Version 67.0.3396.99 (Official Build) (64-bit)\r\n- Device: MacBook Pro\r\n- Operating System: macOS Sierra Version 10.12.6 (16G29)\r\n\r\n---\r\n\r\n⚓️ We’re not accepting pull requests at this time<br />\r\n🗒 We _are_ accepting issue reports and feature requests<br />\r\n🌟 Feature requests that we can’t get to right away will be closed. However, we track all requests and will use it to set priorities. See the [contribution guidelines](https://github.com/Shopify/polaris/blob/master/.github/CONTRIBUTING.md) for more information.\r\n"},"comment":{"url":"https://api.github.com/repos/Shopify/polaris/issues/comments/420355824","html_url":"https://github.com/Shopify/polaris/issues/387#issuecomment-420355824","issue_url":"https://api.github.com/repos/Shopify/polaris/issues/387","id":420355824,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDM1NTgyNA==","user":{"login":"Nisthar","id":11994157,"node_id":"MDQ6VXNlcjExOTk0MTU3","avatar_url":"https://avatars3.githubusercontent.com/u/11994157?v=4","gravatar_id":"","url":"https://api.github.com/users/Nisthar","html_url":"https://github.com/Nisthar","followers_url":"https://api.github.com/users/Nisthar/followers","following_url":"https://api.github.com/users/Nisthar/following{/other_user}","gists_url":"https://api.github.com/users/Nisthar/gists{/gist_id}","starred_url":"https://api.github.com/users/Nisthar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nisthar/subscriptions","organizations_url":"https://api.github.com/users/Nisthar/orgs","repos_url":"https://api.github.com/users/Nisthar/repos","events_url":"https://api.github.com/users/Nisthar/events{/privacy}","received_events_url":"https://api.github.com/users/Nisthar/received_events","type":"User","site_admin":false},"created_at":"2018-09-11T17:32:45Z","updated_at":"2018-09-11T17:32:45Z","author_association":"NONE","body":"@ry5n are there any workaround for this? \r\n\r\nI am building a shopify app and it really needed this feature. Don't want to to use a custom table component."}}
{"actor":{"display_login":"Nisthar"}}