{"action":"created","comment":{"url":"https://api.github.com/repos/bitshares/bitshares-ui/pulls/comments/205367426","pull_request_review_id":140621154,"id":205367426,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTM2NzQyNg==","diff_hunk":"@@ -257,7 +257,7 @@ class SettingsStore {\n         //       set if not present on loading\n         let support_v3_until = new Date(\"2018-10-20T00:00:00Z\");\n \n-        if (!ss.get(\"settings_v4\") && new Date() < support_v3_until) {\n+        if (!ss.has(\"settings_v4\") && new Date() < support_v3_until) {","path":"app/stores/SettingsStore.js","position":null,"original_position":5,"commit_id":"dfc37da272115a89169a0b89d4b1e36b590cc077","original_commit_id":"a191937ee8a2e4ddf3b15fd4afd86583aa9cf120","user":{"login":"sschiessl-bcp","id":33128181,"node_id":"MDQ6VXNlcjMzMTI4MTgx","avatar_url":"https://avatars1.githubusercontent.com/u/33128181?v=4","gravatar_id":"","url":"https://api.github.com/users/sschiessl-bcp","html_url":"https://github.com/sschiessl-bcp","followers_url":"https://api.github.com/users/sschiessl-bcp/followers","following_url":"https://api.github.com/users/sschiessl-bcp/following{/other_user}","gists_url":"https://api.github.com/users/sschiessl-bcp/gists{/gist_id}","starred_url":"https://api.github.com/users/sschiessl-bcp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sschiessl-bcp/subscriptions","organizations_url":"https://api.github.com/users/sschiessl-bcp/orgs","repos_url":"https://api.github.com/users/sschiessl-bcp/repos","events_url":"https://api.github.com/users/sschiessl-bcp/events{/privacy}","received_events_url":"https://api.github.com/users/sschiessl-bcp/received_events","type":"User","site_admin":false},"body":"Interesting, did not know that method. Will try that out to see the difference, thanks","created_at":"2018-07-26T08:16:04Z","updated_at":"2018-07-26T08:16:04Z","html_url":"https://github.com/bitshares/bitshares-ui/pull/1726#discussion_r205367426","pull_request_url":"https://api.github.com/repos/bitshares/bitshares-ui/pulls/1726","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bitshares/bitshares-ui/pulls/comments/205367426"},"html":{"href":"https://github.com/bitshares/bitshares-ui/pull/1726#discussion_r205367426"},"pull_request":{"href":"https://api.github.com/repos/bitshares/bitshares-ui/pulls/1726"}}},"pull_request":{"url":"https://api.github.com/repos/bitshares/bitshares-ui/pulls/1726","id":203538074,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNTM4MDc0","html_url":"https://github.com/bitshares/bitshares-ui/pull/1726","diff_url":"https://github.com/bitshares/bitshares-ui/pull/1726.diff","patch_url":"https://github.com/bitshares/bitshares-ui/pull/1726.patch","issue_url":"https://api.github.com/repos/bitshares/bitshares-ui/issues/1726","number":1726,"state":"closed","locked":false,"title":"Better Node Management, Orders Api and Refactoring","user":{"login":"sschiessl-bcp","id":33128181,"node_id":"MDQ6VXNlcjMzMTI4MTgx","avatar_url":"https://avatars1.githubusercontent.com/u/33128181?v=4","gravatar_id":"","url":"https://api.github.com/users/sschiessl-bcp","html_url":"https://github.com/sschiessl-bcp","followers_url":"https://api.github.com/users/sschiessl-bcp/followers","following_url":"https://api.github.com/users/sschiessl-bcp/following{/other_user}","gists_url":"https://api.github.com/users/sschiessl-bcp/gists{/gist_id}","starred_url":"https://api.github.com/users/sschiessl-bcp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sschiessl-bcp/subscriptions","organizations_url":"https://api.github.com/users/sschiessl-bcp/orgs","repos_url":"https://api.github.com/users/sschiessl-bcp/repos","events_url":"https://api.github.com/users/sschiessl-bcp/events{/privacy}","received_events_url":"https://api.github.com/users/sschiessl-bcp/received_events","type":"User","site_admin":false},"body":"Well, this escalated quickly..\r\n\r\nI tried solving #1521 and add a feature for #1672 and I ended up refactoring SettingsStore and AccessSettings. Which took a massive amount of time, but was not agreed upon so its mostly my own fault. \r\n\r\nAnyways I need to make a cut now and would implement actual filtering options for the user in a separate feature branch in which I also complete updating the apiConfig.\r\n\r\nThis happened:\r\n- refactoring of SettingsStore, also\r\n    - remove settings default bug that defaults are not overwritten (settings_v4 now) and another loading bug\r\n    - activeNode doesnt need to be in local storage\r\n- Faucet is not editable anymore\r\n- User can now Ping all nodes when his node is out of sync\r\n- refactoring of AccessSettings, also\r\n    - moved all logic into ApiNode and seperated where necessary\r\n- more sophisticated node object with default, hidden etc.\r\n- Introduce new component: ChoiceModal that allows to present the user different choices how to proceed\r\n\r\nMy actual hours were roughly spent on (roughly):\r\n- Refactoring SettingsStore and AccessSettings 14\r\n- OrdersApi analysis and finding of invalid nodes 4\r\n- Fixing the default settings bug 5\r\n- Better node management 4\r\n\r\nHow do I translate that into points? I do not expect payment on my refactoring efforts as this was not agreed.","created_at":"2018-07-24T14:02:21Z","updated_at":"2018-07-26T08:16:04Z","closed_at":"2018-07-26T08:05:14Z","merged_at":"2018-07-26T08:05:14Z","merge_commit_sha":"9dfe05738145f4335700c38e401202e08b4531cd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitshares/bitshares-ui/pulls/1726/commits","review_comments_url":"https://api.github.com/repos/bitshares/bitshares-ui/pulls/1726/comments","review_comment_url":"https://api.github.com/repos/bitshares/bitshares-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitshares/bitshares-ui/issues/1726/comments","statuses_url":"https://api.github.com/repos/bitshares/bitshares-ui/statuses/dfc37da272115a89169a0b89d4b1e36b590cc077","head":{"label":"bitshares:1672_ManualNodeCheck","ref":"1672_ManualNodeCheck","sha":"dfc37da272115a89169a0b89d4b1e36b590cc077","user":{"login":"bitshares","id":6914094,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTQwOTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6914094?v=4","gravatar_id":"","url":"https://api.github.com/users/bitshares","html_url":"https://github.com/bitshares","followers_url":"https://api.github.com/users/bitshares/followers","following_url":"https://api.github.com/users/bitshares/following{/other_user}","gists_url":"https://api.github.com/users/bitshares/gists{/gist_id}","starred_url":"https://api.github.com/users/bitshares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitshares/subscriptions","organizations_url":"https://api.github.com/users/bitshares/orgs","repos_url":"https://api.github.com/users/bitshares/repos","events_url":"https://api.github.com/users/bitshares/events{/privacy}","received_events_url":"https://api.github.com/users/bitshares/received_events","type":"Organization","site_admin":false},"repo":{"id":44123296,"node_id":"MDEwOlJlcG9zaXRvcnk0NDEyMzI5Ng==","name":"bitshares-ui","full_name":"bitshares/bitshares-ui","owner":{"login":"bitshares","id":6914094,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTQwOTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6914094?v=4","gravatar_id":"","url":"https://api.github.com/users/bitshares","html_url":"https://github.com/bitshares","followers_url":"https://api.github.com/users/bitshares/followers","following_url":"https://api.github.com/users/bitshares/following{/other_user}","gists_url":"https://api.github.com/users/bitshares/gists{/gist_id}","starred_url":"https://api.github.com/users/bitshares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitshares/subscriptions","organizations_url":"https://api.github.com/users/bitshares/orgs","repos_url":"https://api.github.com/users/bitshares/repos","events_url":"https://api.github.com/users/bitshares/events{/privacy}","received_events_url":"https://api.github.com/users/bitshares/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitshares/bitshares-ui","description":"Fully featured Graphical User Interface / Reference Wallet for the BitShares Blockchain","fork":false,"url":"https://api.github.com/repos/bitshares/bitshares-ui","forks_url":"https://api.github.com/repos/bitshares/bitshares-ui/forks","keys_url":"https://api.github.com/repos/bitshares/bitshares-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitshares/bitshares-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitshares/bitshares-ui/teams","hooks_url":"https://api.github.com/repos/bitshares/bitshares-ui/hooks","issue_events_url":"https://api.github.com/repos/bitshares/bitshares-ui/issues/events{/number}","events_url":"https://api.github.com/repos/bitshares/bitshares-ui/events","assignees_url":"https://api.github.com/repos/bitshares/bitshares-ui/assignees{/user}","branches_url":"https://api.github.com/repos/bitshares/bitshares-ui/branches{/branch}","tags_url":"https://api.github.com/repos/bitshares/bitshares-ui/tags","blobs_url":"https://api.github.com/repos/bitshares/bitshares-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitshares/bitshares-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitshares/bitshares-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitshares/bitshares-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitshares/bitshares-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/bitshares/bitshares-ui/languages","stargazers_url":"https://api.github.com/repos/bitshares/bitshares-ui/stargazers","contributors_url":"https://api.github.com/repos/bitshares/bitshares-ui/contributors","subscribers_url":"https://api.github.com/repos/bitshares/bitshares-ui/subscribers","subscription_url":"https://api.github.com/repos/bitshares/bitshares-ui/subscription","commits_url":"https://api.github.com/repos/bitshares/bitshares-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitshares/bitshares-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitshares/bitshares-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitshares/bitshares-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitshares/bitshares-ui/contents/{+path}","compare_url":"https://api.github.com/repos/bitshares/bitshares-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitshares/bitshares-ui/merges","archive_url":"https://api.github.com/repos/bitshares/bitshares-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitshares/bitshares-ui/downloads","issues_url":"https://api.github.com/repos/bitshares/bitshares-ui/issues{/number}","pulls_url":"https://api.github.com/repos/bitshares/bitshares-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/bitshares/bitshares-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/bitshares/bitshares-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitshares/bitshares-ui/labels{/name}","releases_url":"https://api.github.com/repos/bitshares/bitshares-ui/releases{/id}","deployments_url":"https://api.github.com/repos/bitshares/bitshares-ui/deployments","created_at":"2015-10-12T17:36:50Z","updated_at":"2018-07-26T08:05:17Z","pushed_at":"2018-07-26T08:05:14Z","git_url":"git://github.com/bitshares/bitshares-ui.git","ssh_url":"git@github.com:bitshares/bitshares-ui.git","clone_url":"https://github.com/bitshares/bitshares-ui.git","svn_url":"https://github.com/bitshares/bitshares-ui","homepage":"https://wallet.bitshares.org","size":31221,"stargazers_count":381,"watchers_count":381,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":382,"mirror_url":null,"archived":false,"open_issues_count":176,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":382,"open_issues":176,"watchers":381,"default_branch":"develop"}},"base":{"label":"bitshares:develop","ref":"develop","sha":"d5e648136543a466a1b254d60530aeec3faada1d","user":{"login":"bitshares","id":6914094,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTQwOTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6914094?v=4","gravatar_id":"","url":"https://api.github.com/users/bitshares","html_url":"https://github.com/bitshares","followers_url":"https://api.github.com/users/bitshares/followers","following_url":"https://api.github.com/users/bitshares/following{/other_user}","gists_url":"https://api.github.com/users/bitshares/gists{/gist_id}","starred_url":"https://api.github.com/users/bitshares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitshares/subscriptions","organizations_url":"https://api.github.com/users/bitshares/orgs","repos_url":"https://api.github.com/users/bitshares/repos","events_url":"https://api.github.com/users/bitshares/events{/privacy}","received_events_url":"https://api.github.com/users/bitshares/received_events","type":"Organization","site_admin":false},"repo":{"id":44123296,"node_id":"MDEwOlJlcG9zaXRvcnk0NDEyMzI5Ng==","name":"bitshares-ui","full_name":"bitshares/bitshares-ui","owner":{"login":"bitshares","id":6914094,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTQwOTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6914094?v=4","gravatar_id":"","url":"https://api.github.com/users/bitshares","html_url":"https://github.com/bitshares","followers_url":"https://api.github.com/users/bitshares/followers","following_url":"https://api.github.com/users/bitshares/following{/other_user}","gists_url":"https://api.github.com/users/bitshares/gists{/gist_id}","starred_url":"https://api.github.com/users/bitshares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitshares/subscriptions","organizations_url":"https://api.github.com/users/bitshares/orgs","repos_url":"https://api.github.com/users/bitshares/repos","events_url":"https://api.github.com/users/bitshares/events{/privacy}","received_events_url":"https://api.github.com/users/bitshares/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitshares/bitshares-ui","description":"Fully featured Graphical User Interface / Reference Wallet for the BitShares Blockchain","fork":false,"url":"https://api.github.com/repos/bitshares/bitshares-ui","forks_url":"https://api.github.com/repos/bitshares/bitshares-ui/forks","keys_url":"https://api.github.com/repos/bitshares/bitshares-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitshares/bitshares-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitshares/bitshares-ui/teams","hooks_url":"https://api.github.com/repos/bitshares/bitshares-ui/hooks","issue_events_url":"https://api.github.com/repos/bitshares/bitshares-ui/issues/events{/number}","events_url":"https://api.github.com/repos/bitshares/bitshares-ui/events","assignees_url":"https://api.github.com/repos/bitshares/bitshares-ui/assignees{/user}","branches_url":"https://api.github.com/repos/bitshares/bitshares-ui/branches{/branch}","tags_url":"https://api.github.com/repos/bitshares/bitshares-ui/tags","blobs_url":"https://api.github.com/repos/bitshares/bitshares-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitshares/bitshares-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitshares/bitshares-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitshares/bitshares-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitshares/bitshares-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/bitshares/bitshares-ui/languages","stargazers_url":"https://api.github.com/repos/bitshares/bitshares-ui/stargazers","contributors_url":"https://api.github.com/repos/bitshares/bitshares-ui/contributors","subscribers_url":"https://api.github.com/repos/bitshares/bitshares-ui/subscribers","subscription_url":"https://api.github.com/repos/bitshares/bitshares-ui/subscription","commits_url":"https://api.github.com/repos/bitshares/bitshares-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitshares/bitshares-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitshares/bitshares-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitshares/bitshares-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitshares/bitshares-ui/contents/{+path}","compare_url":"https://api.github.com/repos/bitshares/bitshares-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitshares/bitshares-ui/merges","archive_url":"https://api.github.com/repos/bitshares/bitshares-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitshares/bitshares-ui/downloads","issues_url":"https://api.github.com/repos/bitshares/bitshares-ui/issues{/number}","pulls_url":"https://api.github.com/repos/bitshares/bitshares-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/bitshares/bitshares-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/bitshares/bitshares-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitshares/bitshares-ui/labels{/name}","releases_url":"https://api.github.com/repos/bitshares/bitshares-ui/releases{/id}","deployments_url":"https://api.github.com/repos/bitshares/bitshares-ui/deployments","created_at":"2015-10-12T17:36:50Z","updated_at":"2018-07-26T08:05:17Z","pushed_at":"2018-07-26T08:05:14Z","git_url":"git://github.com/bitshares/bitshares-ui.git","ssh_url":"git@github.com:bitshares/bitshares-ui.git","clone_url":"https://github.com/bitshares/bitshares-ui.git","svn_url":"https://github.com/bitshares/bitshares-ui","homepage":"https://wallet.bitshares.org","size":31221,"stargazers_count":381,"watchers_count":381,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":382,"mirror_url":null,"archived":false,"open_issues_count":176,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":382,"open_issues":176,"watchers":381,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/bitshares/bitshares-ui/pulls/1726"},"html":{"href":"https://github.com/bitshares/bitshares-ui/pull/1726"},"issue":{"href":"https://api.github.com/repos/bitshares/bitshares-ui/issues/1726"},"comments":{"href":"https://api.github.com/repos/bitshares/bitshares-ui/issues/1726/comments"},"review_comments":{"href":"https://api.github.com/repos/bitshares/bitshares-ui/pulls/1726/comments"},"review_comment":{"href":"https://api.github.com/repos/bitshares/bitshares-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitshares/bitshares-ui/pulls/1726/commits"},"statuses":{"href":"https://api.github.com/repos/bitshares/bitshares-ui/statuses/dfc37da272115a89169a0b89d4b1e36b590cc077"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sschiessl-bcp"}}