{"action":"closed","number":7089,"pull_request":{"url":"https://api.github.com/repos/concrete5/concrete5/pulls/7089","id":217338658,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MzM4NjU4","html_url":"https://github.com/concrete5/concrete5/pull/7089","diff_url":"https://github.com/concrete5/concrete5/pull/7089.diff","patch_url":"https://github.com/concrete5/concrete5/pull/7089.patch","issue_url":"https://api.github.com/repos/concrete5/concrete5/issues/7089","number":7089,"state":"closed","locked":false,"title":"Simplify Page::populatePage","user":{"login":"mlocati","id":928116,"node_id":"MDQ6VXNlcjkyODExNg==","avatar_url":"https://avatars3.githubusercontent.com/u/928116?v=4","gravatar_id":"","url":"https://api.github.com/users/mlocati","html_url":"https://github.com/mlocati","followers_url":"https://api.github.com/users/mlocati/followers","following_url":"https://api.github.com/users/mlocati/following{/other_user}","gists_url":"https://api.github.com/users/mlocati/gists{/gist_id}","starred_url":"https://api.github.com/users/mlocati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlocati/subscriptions","organizations_url":"https://api.github.com/users/mlocati/orgs","repos_url":"https://api.github.com/users/mlocati/repos","events_url":"https://api.github.com/users/mlocati/events{/privacy}","received_events_url":"https://api.github.com/users/mlocati/received_events","type":"User","site_admin":false},"body":"- (5a57d38762b036d25f396a7919938049d7552f5b) in case of page aliases, let's just use the `$row` variable containing the alias data, there's no need to extract the wanted fields one by one\r\n- (e5016043ac089a67ca187c96f45670abd2f61203) the result of `executeQuery` for select queries is always a `Statement` object, there's no need to check if it's not falsy (in case of errors, Doctrine throws exceptions, doesn't return falsy values)\r\n- (e5016043ac089a67ca187c96f45670abd2f61203) we can use `fetchAssoc` instead of `executeQuery` + `fetchRow`, which returns `false` if no row is found","created_at":"2018-09-21T16:32:44Z","updated_at":"2018-09-26T20:40:23Z","closed_at":"2018-09-26T20:40:23Z","merged_at":"2018-09-26T20:40:23Z","merge_commit_sha":"233acc708e93906d229429bd841a7b62ab925f04","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/concrete5/concrete5/pulls/7089/commits","review_comments_url":"https://api.github.com/repos/concrete5/concrete5/pulls/7089/comments","review_comment_url":"https://api.github.com/repos/concrete5/concrete5/pulls/comments{/number}","comments_url":"https://api.github.com/repos/concrete5/concrete5/issues/7089/comments","statuses_url":"https://api.github.com/repos/concrete5/concrete5/statuses/e6cdea1f1c4f43de22cd7972abb8aba600552d46","head":{"label":"mlocati:simplify-page-populatepage","ref":"simplify-page-populatepage","sha":"e6cdea1f1c4f43de22cd7972abb8aba600552d46","user":{"login":"mlocati","id":928116,"node_id":"MDQ6VXNlcjkyODExNg==","avatar_url":"https://avatars3.githubusercontent.com/u/928116?v=4","gravatar_id":"","url":"https://api.github.com/users/mlocati","html_url":"https://github.com/mlocati","followers_url":"https://api.github.com/users/mlocati/followers","following_url":"https://api.github.com/users/mlocati/following{/other_user}","gists_url":"https://api.github.com/users/mlocati/gists{/gist_id}","starred_url":"https://api.github.com/users/mlocati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlocati/subscriptions","organizations_url":"https://api.github.com/users/mlocati/orgs","repos_url":"https://api.github.com/users/mlocati/repos","events_url":"https://api.github.com/users/mlocati/events{/privacy}","received_events_url":"https://api.github.com/users/mlocati/received_events","type":"User","site_admin":false},"repo":{"id":19068220,"node_id":"MDEwOlJlcG9zaXRvcnkxOTA2ODIyMA==","name":"concrete5","full_name":"mlocati/concrete5","private":false,"owner":{"login":"mlocati","id":928116,"node_id":"MDQ6VXNlcjkyODExNg==","avatar_url":"https://avatars3.githubusercontent.com/u/928116?v=4","gravatar_id":"","url":"https://api.github.com/users/mlocati","html_url":"https://github.com/mlocati","followers_url":"https://api.github.com/users/mlocati/followers","following_url":"https://api.github.com/users/mlocati/following{/other_user}","gists_url":"https://api.github.com/users/mlocati/gists{/gist_id}","starred_url":"https://api.github.com/users/mlocati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlocati/subscriptions","organizations_url":"https://api.github.com/users/mlocati/orgs","repos_url":"https://api.github.com/users/mlocati/repos","events_url":"https://api.github.com/users/mlocati/events{/privacy}","received_events_url":"https://api.github.com/users/mlocati/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mlocati/concrete5","description":"My development fork of concrete5","fork":true,"url":"https://api.github.com/repos/mlocati/concrete5","forks_url":"https://api.github.com/repos/mlocati/concrete5/forks","keys_url":"https://api.github.com/repos/mlocati/concrete5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlocati/concrete5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlocati/concrete5/teams","hooks_url":"https://api.github.com/repos/mlocati/concrete5/hooks","issue_events_url":"https://api.github.com/repos/mlocati/concrete5/issues/events{/number}","events_url":"https://api.github.com/repos/mlocati/concrete5/events","assignees_url":"https://api.github.com/repos/mlocati/concrete5/assignees{/user}","branches_url":"https://api.github.com/repos/mlocati/concrete5/branches{/branch}","tags_url":"https://api.github.com/repos/mlocati/concrete5/tags","blobs_url":"https://api.github.com/repos/mlocati/concrete5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlocati/concrete5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlocati/concrete5/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlocati/concrete5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlocati/concrete5/statuses/{sha}","languages_url":"https://api.github.com/repos/mlocati/concrete5/languages","stargazers_url":"https://api.github.com/repos/mlocati/concrete5/stargazers","contributors_url":"https://api.github.com/repos/mlocati/concrete5/contributors","subscribers_url":"https://api.github.com/repos/mlocati/concrete5/subscribers","subscription_url":"https://api.github.com/repos/mlocati/concrete5/subscription","commits_url":"https://api.github.com/repos/mlocati/concrete5/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlocati/concrete5/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlocati/concrete5/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlocati/concrete5/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlocati/concrete5/contents/{+path}","compare_url":"https://api.github.com/repos/mlocati/concrete5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlocati/concrete5/merges","archive_url":"https://api.github.com/repos/mlocati/concrete5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlocati/concrete5/downloads","issues_url":"https://api.github.com/repos/mlocati/concrete5/issues{/number}","pulls_url":"https://api.github.com/repos/mlocati/concrete5/pulls{/number}","milestones_url":"https://api.github.com/repos/mlocati/concrete5/milestones{/number}","notifications_url":"https://api.github.com/repos/mlocati/concrete5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlocati/concrete5/labels{/name}","releases_url":"https://api.github.com/repos/mlocati/concrete5/releases{/id}","deployments_url":"https://api.github.com/repos/mlocati/concrete5/deployments","created_at":"2014-04-23T12:09:20Z","updated_at":"2018-09-26T14:42:28Z","pushed_at":"2018-09-26T15:54:44Z","git_url":"git://github.com/mlocati/concrete5.git","ssh_url":"git@github.com:mlocati/concrete5.git","clone_url":"https://github.com/mlocati/concrete5.git","svn_url":"https://github.com/mlocati/concrete5","homepage":"https://github.com/concrete5/concrete5","size":109842,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"concrete5:develop","ref":"develop","sha":"149c236921d6e80bbe819e3d9320bbb546d29759","user":{"login":"concrete5","id":657929,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1NzkyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/657929?v=4","gravatar_id":"","url":"https://api.github.com/users/concrete5","html_url":"https://github.com/concrete5","followers_url":"https://api.github.com/users/concrete5/followers","following_url":"https://api.github.com/users/concrete5/following{/other_user}","gists_url":"https://api.github.com/users/concrete5/gists{/gist_id}","starred_url":"https://api.github.com/users/concrete5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concrete5/subscriptions","organizations_url":"https://api.github.com/users/concrete5/orgs","repos_url":"https://api.github.com/users/concrete5/repos","events_url":"https://api.github.com/users/concrete5/events{/privacy}","received_events_url":"https://api.github.com/users/concrete5/received_events","type":"Organization","site_admin":false},"repo":{"id":19040482,"node_id":"MDEwOlJlcG9zaXRvcnkxOTA0MDQ4Mg==","name":"concrete5","full_name":"concrete5/concrete5","private":false,"owner":{"login":"concrete5","id":657929,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1NzkyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/657929?v=4","gravatar_id":"","url":"https://api.github.com/users/concrete5","html_url":"https://github.com/concrete5","followers_url":"https://api.github.com/users/concrete5/followers","following_url":"https://api.github.com/users/concrete5/following{/other_user}","gists_url":"https://api.github.com/users/concrete5/gists{/gist_id}","starred_url":"https://api.github.com/users/concrete5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concrete5/subscriptions","organizations_url":"https://api.github.com/users/concrete5/orgs","repos_url":"https://api.github.com/users/concrete5/repos","events_url":"https://api.github.com/users/concrete5/events{/privacy}","received_events_url":"https://api.github.com/users/concrete5/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/concrete5/concrete5","description":"Official repository for concrete5 development","fork":false,"url":"https://api.github.com/repos/concrete5/concrete5","forks_url":"https://api.github.com/repos/concrete5/concrete5/forks","keys_url":"https://api.github.com/repos/concrete5/concrete5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/concrete5/concrete5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/concrete5/concrete5/teams","hooks_url":"https://api.github.com/repos/concrete5/concrete5/hooks","issue_events_url":"https://api.github.com/repos/concrete5/concrete5/issues/events{/number}","events_url":"https://api.github.com/repos/concrete5/concrete5/events","assignees_url":"https://api.github.com/repos/concrete5/concrete5/assignees{/user}","branches_url":"https://api.github.com/repos/concrete5/concrete5/branches{/branch}","tags_url":"https://api.github.com/repos/concrete5/concrete5/tags","blobs_url":"https://api.github.com/repos/concrete5/concrete5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/concrete5/concrete5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/concrete5/concrete5/git/refs{/sha}","trees_url":"https://api.github.com/repos/concrete5/concrete5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/concrete5/concrete5/statuses/{sha}","languages_url":"https://api.github.com/repos/concrete5/concrete5/languages","stargazers_url":"https://api.github.com/repos/concrete5/concrete5/stargazers","contributors_url":"https://api.github.com/repos/concrete5/concrete5/contributors","subscribers_url":"https://api.github.com/repos/concrete5/concrete5/subscribers","subscription_url":"https://api.github.com/repos/concrete5/concrete5/subscription","commits_url":"https://api.github.com/repos/concrete5/concrete5/commits{/sha}","git_commits_url":"https://api.github.com/repos/concrete5/concrete5/git/commits{/sha}","comments_url":"https://api.github.com/repos/concrete5/concrete5/comments{/number}","issue_comment_url":"https://api.github.com/repos/concrete5/concrete5/issues/comments{/number}","contents_url":"https://api.github.com/repos/concrete5/concrete5/contents/{+path}","compare_url":"https://api.github.com/repos/concrete5/concrete5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/concrete5/concrete5/merges","archive_url":"https://api.github.com/repos/concrete5/concrete5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/concrete5/concrete5/downloads","issues_url":"https://api.github.com/repos/concrete5/concrete5/issues{/number}","pulls_url":"https://api.github.com/repos/concrete5/concrete5/pulls{/number}","milestones_url":"https://api.github.com/repos/concrete5/concrete5/milestones{/number}","notifications_url":"https://api.github.com/repos/concrete5/concrete5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/concrete5/concrete5/labels{/name}","releases_url":"https://api.github.com/repos/concrete5/concrete5/releases{/id}","deployments_url":"https://api.github.com/repos/concrete5/concrete5/deployments","created_at":"2014-04-22T18:12:28Z","updated_at":"2018-09-26T20:37:54Z","pushed_at":"2018-09-26T20:40:23Z","git_url":"git://github.com/concrete5/concrete5.git","ssh_url":"git@github.com:concrete5/concrete5.git","clone_url":"https://github.com/concrete5/concrete5.git","svn_url":"https://github.com/concrete5/concrete5","homepage":"https://www.concrete5.org","size":101967,"stargazers_count":514,"watchers_count":514,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":358,"mirror_url":null,"archived":false,"open_issues_count":685,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":358,"open_issues":685,"watchers":514,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/concrete5/concrete5/pulls/7089"},"html":{"href":"https://github.com/concrete5/concrete5/pull/7089"},"issue":{"href":"https://api.github.com/repos/concrete5/concrete5/issues/7089"},"comments":{"href":"https://api.github.com/repos/concrete5/concrete5/issues/7089/comments"},"review_comments":{"href":"https://api.github.com/repos/concrete5/concrete5/pulls/7089/comments"},"review_comment":{"href":"https://api.github.com/repos/concrete5/concrete5/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/concrete5/concrete5/pulls/7089/commits"},"statuses":{"href":"https://api.github.com/repos/concrete5/concrete5/statuses/e6cdea1f1c4f43de22cd7972abb8aba600552d46"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"aembler","id":527809,"node_id":"MDQ6VXNlcjUyNzgwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/527809?v=4","gravatar_id":"","url":"https://api.github.com/users/aembler","html_url":"https://github.com/aembler","followers_url":"https://api.github.com/users/aembler/followers","following_url":"https://api.github.com/users/aembler/following{/other_user}","gists_url":"https://api.github.com/users/aembler/gists{/gist_id}","starred_url":"https://api.github.com/users/aembler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aembler/subscriptions","organizations_url":"https://api.github.com/users/aembler/orgs","repos_url":"https://api.github.com/users/aembler/repos","events_url":"https://api.github.com/users/aembler/events{/privacy}","received_events_url":"https://api.github.com/users/aembler/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":23,"deletions":40,"changed_files":1}}
{"actor":{"display_login":"aembler"}}