{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter-intellij/pulls/comments/185698891","pull_request_review_id":117139278,"id":185698891,"diff_hunk":"@@ -0,0 +1,102 @@\n+/*\n+ * Copyright 2018 The Chromium Authors. All rights reserved.\n+ * Use of this source code is governed by a BSD-style license that can be\n+ * found in the LICENSE file.\n+ */\n+package io.flutter.logging;\n+\n+import com.intellij.execution.process.ProcessAdapter;\n+import com.intellij.execution.process.ProcessEvent;\n+import com.intellij.execution.process.ProcessHandler;\n+import com.intellij.openapi.Disposable;\n+import com.intellij.openapi.util.Disposer;\n+import com.intellij.openapi.util.Key;\n+import com.jetbrains.lang.dart.ide.runner.server.vmService.VmServiceConsumers;\n+import io.flutter.utils.VmServiceListenerAdapter;\n+import org.dartlang.vm.service.VmService;\n+import org.dartlang.vm.service.element.Event;\n+import org.jetbrains.annotations.NotNull;\n+import org.jetbrains.annotations.Nullable;\n+\n+import java.util.ArrayList;\n+import java.util.List;\n+\n+public class FlutterLog {\n+\n+  // (Temporary) flag to enable logging support.\n+  public static final boolean LOGGING_ENABLED = false;\n+  public static final String LOGGING_STREAM_ID = \"_Logging\";\n+\n+  private static final FlutterLog INSTANCE = new FlutterLog();","path":"src/io/flutter/logging/FlutterLog.java","position":30,"original_position":30,"commit_id":"a9687170143fe1229a3321da0813647ae2dfea81","original_commit_id":"a9687170143fe1229a3321da0813647ae2dfea81","user":{"login":"devoncarew","id":1269969,"avatar_url":"https://avatars0.githubusercontent.com/u/1269969?v=4","gravatar_id":"","url":"https://api.github.com/users/devoncarew","html_url":"https://github.com/devoncarew","followers_url":"https://api.github.com/users/devoncarew/followers","following_url":"https://api.github.com/users/devoncarew/following{/other_user}","gists_url":"https://api.github.com/users/devoncarew/gists{/gist_id}","starred_url":"https://api.github.com/users/devoncarew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devoncarew/subscriptions","organizations_url":"https://api.github.com/users/devoncarew/orgs","repos_url":"https://api.github.com/users/devoncarew/repos","events_url":"https://api.github.com/users/devoncarew/events{/privacy}","received_events_url":"https://api.github.com/users/devoncarew/received_events","type":"User","site_admin":false},"body":"I think instead of a global singleton, we should have a single instance per app session. The singelton could live off a `FlutterApp` or a `PerfService` instance.","created_at":"2018-05-03T05:20:57Z","updated_at":"2018-05-03T05:41:52Z","html_url":"https://github.com/flutter/flutter-intellij/pull/2187#discussion_r185698891","pull_request_url":"https://api.github.com/repos/flutter/flutter-intellij/pulls/2187","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter-intellij/pulls/comments/185698891"},"html":{"href":"https://github.com/flutter/flutter-intellij/pull/2187#discussion_r185698891"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter-intellij/pulls/2187"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter-intellij/pulls/2187","id":185516724,"html_url":"https://github.com/flutter/flutter-intellij/pull/2187","diff_url":"https://github.com/flutter/flutter-intellij/pull/2187.diff","patch_url":"https://github.com/flutter/flutter-intellij/pull/2187.patch","issue_url":"https://api.github.com/repos/flutter/flutter-intellij/issues/2187","number":2187,"state":"open","locked":false,"title":"Flutter Log View first steps.","user":{"login":"pq","id":67586,"avatar_url":"https://avatars3.githubusercontent.com/u/67586?v=4","gravatar_id":"","url":"https://api.github.com/users/pq","html_url":"https://github.com/pq","followers_url":"https://api.github.com/users/pq/followers","following_url":"https://api.github.com/users/pq/following{/other_user}","gists_url":"https://api.github.com/users/pq/gists{/gist_id}","starred_url":"https://api.github.com/users/pq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pq/subscriptions","organizations_url":"https://api.github.com/users/pq/orgs","repos_url":"https://api.github.com/users/pq/repos","events_url":"https://api.github.com/users/pq/events{/privacy}","received_events_url":"https://api.github.com/users/pq/received_events","type":"User","site_admin":false},"body":"First steps.\r\n\r\nOptionally swaps out the default console view for flutter runs w/ a super-charged logging one if `FlutterLog.LOGGING_ENABLED` is set to true.  (Obviously this will change after some iteration.)\r\n\r\nLots of `TODO`s in the source but this puts a stake in the ground.  From here we can experiment with UI/X refinements.\r\n\r\n![image](https://user-images.githubusercontent.com/67586/39540609-ff2ae980-4df7-11e8-9b77-58482ab951ea.png)\r\n\r\n\r\n/cc @devoncarew ","created_at":"2018-05-02T18:03:19Z","updated_at":"2018-05-03T05:41:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23ff9f41b277f1421fac6adce3cdbf4580bc573e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":487496526,"url":"https://api.github.com/repos/flutter/flutter-intellij/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter-intellij/pulls/2187/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter-intellij/pulls/2187/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter-intellij/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter-intellij/issues/2187/comments","statuses_url":"https://api.github.com/repos/flutter/flutter-intellij/statuses/a9687170143fe1229a3321da0813647ae2dfea81","head":{"label":"pq:log_view","ref":"log_view","sha":"a9687170143fe1229a3321da0813647ae2dfea81","user":{"login":"pq","id":67586,"avatar_url":"https://avatars3.githubusercontent.com/u/67586?v=4","gravatar_id":"","url":"https://api.github.com/users/pq","html_url":"https://github.com/pq","followers_url":"https://api.github.com/users/pq/followers","following_url":"https://api.github.com/users/pq/following{/other_user}","gists_url":"https://api.github.com/users/pq/gists{/gist_id}","starred_url":"https://api.github.com/users/pq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pq/subscriptions","organizations_url":"https://api.github.com/users/pq/orgs","repos_url":"https://api.github.com/users/pq/repos","events_url":"https://api.github.com/users/pq/events{/privacy}","received_events_url":"https://api.github.com/users/pq/received_events","type":"User","site_admin":false},"repo":{"id":67261255,"name":"flutter-intellij","full_name":"pq/flutter-intellij","owner":{"login":"pq","id":67586,"avatar_url":"https://avatars3.githubusercontent.com/u/67586?v=4","gravatar_id":"","url":"https://api.github.com/users/pq","html_url":"https://github.com/pq","followers_url":"https://api.github.com/users/pq/followers","following_url":"https://api.github.com/users/pq/following{/other_user}","gists_url":"https://api.github.com/users/pq/gists{/gist_id}","starred_url":"https://api.github.com/users/pq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pq/subscriptions","organizations_url":"https://api.github.com/users/pq/orgs","repos_url":"https://api.github.com/users/pq/repos","events_url":"https://api.github.com/users/pq/events{/privacy}","received_events_url":"https://api.github.com/users/pq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pq/flutter-intellij","description":"Flutter Plugin for IntelliJ","fork":true,"url":"https://api.github.com/repos/pq/flutter-intellij","forks_url":"https://api.github.com/repos/pq/flutter-intellij/forks","keys_url":"https://api.github.com/repos/pq/flutter-intellij/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pq/flutter-intellij/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pq/flutter-intellij/teams","hooks_url":"https://api.github.com/repos/pq/flutter-intellij/hooks","issue_events_url":"https://api.github.com/repos/pq/flutter-intellij/issues/events{/number}","events_url":"https://api.github.com/repos/pq/flutter-intellij/events","assignees_url":"https://api.github.com/repos/pq/flutter-intellij/assignees{/user}","branches_url":"https://api.github.com/repos/pq/flutter-intellij/branches{/branch}","tags_url":"https://api.github.com/repos/pq/flutter-intellij/tags","blobs_url":"https://api.github.com/repos/pq/flutter-intellij/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pq/flutter-intellij/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pq/flutter-intellij/git/refs{/sha}","trees_url":"https://api.github.com/repos/pq/flutter-intellij/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pq/flutter-intellij/statuses/{sha}","languages_url":"https://api.github.com/repos/pq/flutter-intellij/languages","stargazers_url":"https://api.github.com/repos/pq/flutter-intellij/stargazers","contributors_url":"https://api.github.com/repos/pq/flutter-intellij/contributors","subscribers_url":"https://api.github.com/repos/pq/flutter-intellij/subscribers","subscription_url":"https://api.github.com/repos/pq/flutter-intellij/subscription","commits_url":"https://api.github.com/repos/pq/flutter-intellij/commits{/sha}","git_commits_url":"https://api.github.com/repos/pq/flutter-intellij/git/commits{/sha}","comments_url":"https://api.github.com/repos/pq/flutter-intellij/comments{/number}","issue_comment_url":"https://api.github.com/repos/pq/flutter-intellij/issues/comments{/number}","contents_url":"https://api.github.com/repos/pq/flutter-intellij/contents/{+path}","compare_url":"https://api.github.com/repos/pq/flutter-intellij/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pq/flutter-intellij/merges","archive_url":"https://api.github.com/repos/pq/flutter-intellij/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pq/flutter-intellij/downloads","issues_url":"https://api.github.com/repos/pq/flutter-intellij/issues{/number}","pulls_url":"https://api.github.com/repos/pq/flutter-intellij/pulls{/number}","milestones_url":"https://api.github.com/repos/pq/flutter-intellij/milestones{/number}","notifications_url":"https://api.github.com/repos/pq/flutter-intellij/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pq/flutter-intellij/labels{/name}","releases_url":"https://api.github.com/repos/pq/flutter-intellij/releases{/id}","deployments_url":"https://api.github.com/repos/pq/flutter-intellij/deployments","created_at":"2016-09-02T23:37:27Z","updated_at":"2018-03-16T17:35:48Z","pushed_at":"2018-05-02T18:00:05Z","git_url":"git://github.com/pq/flutter-intellij.git","ssh_url":"git@github.com:pq/flutter-intellij.git","clone_url":"https://github.com/pq/flutter-intellij.git","svn_url":"https://github.com/pq/flutter-intellij","homepage":"","size":15708,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"50145178da100373c15bde91e8848caa4a7dd604","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":64172164,"name":"flutter-intellij","full_name":"flutter/flutter-intellij","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/flutter-intellij","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter-intellij","forks_url":"https://api.github.com/repos/flutter/flutter-intellij/forks","keys_url":"https://api.github.com/repos/flutter/flutter-intellij/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter-intellij/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter-intellij/teams","hooks_url":"https://api.github.com/repos/flutter/flutter-intellij/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter-intellij/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter-intellij/events","assignees_url":"https://api.github.com/repos/flutter/flutter-intellij/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter-intellij/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter-intellij/tags","blobs_url":"https://api.github.com/repos/flutter/flutter-intellij/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter-intellij/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter-intellij/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter-intellij/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter-intellij/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter-intellij/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter-intellij/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter-intellij/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter-intellij/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter-intellij/subscription","commits_url":"https://api.github.com/repos/flutter/flutter-intellij/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter-intellij/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter-intellij/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter-intellij/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter-intellij/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter-intellij/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter-intellij/merges","archive_url":"https://api.github.com/repos/flutter/flutter-intellij/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter-intellij/downloads","issues_url":"https://api.github.com/repos/flutter/flutter-intellij/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter-intellij/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter-intellij/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter-intellij/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter-intellij/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter-intellij/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter-intellij/deployments","created_at":"2016-07-25T22:31:03Z","updated_at":"2018-05-02T19:47:16Z","pushed_at":"2018-05-03T03:42:30Z","git_url":"git://github.com/flutter/flutter-intellij.git","ssh_url":"git@github.com:flutter/flutter-intellij.git","clone_url":"https://github.com/flutter/flutter-intellij.git","svn_url":"https://github.com/flutter/flutter-intellij","homepage":"https://flutter.io/using-ide/","size":15731,"stargazers_count":246,"watchers_count":246,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":161,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":37,"open_issues":161,"watchers":246,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter-intellij/pulls/2187"},"html":{"href":"https://github.com/flutter/flutter-intellij/pull/2187"},"issue":{"href":"https://api.github.com/repos/flutter/flutter-intellij/issues/2187"},"comments":{"href":"https://api.github.com/repos/flutter/flutter-intellij/issues/2187/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter-intellij/pulls/2187/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter-intellij/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter-intellij/pulls/2187/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter-intellij/statuses/a9687170143fe1229a3321da0813647ae2dfea81"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"devoncarew"}}