{"action":"created","comment":{"url":"https://api.github.com/repos/pantsbuild/pants/pulls/comments/223778731","pull_request_review_id":162989332,"id":223778731,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzc3ODczMQ==","diff_hunk":"@@ -237,16 +256,24 @@ def _iso_timestamp_for_now(cls):\n   # NB: This includes a trailing newline, but no leading newline.\n   _EXCEPTION_LOG_FORMAT = \"\"\"\\\n timestamp: {timestamp}\n-args: {args}\n+process title: {process_title}\n+sys.argv: {args}\n+bootstrap options: {bootstrap_options}\n pid: {pid}\n {message}\n \"\"\"\n \n   @classmethod\n   def _format_exception_message(cls, msg, pid):\n+    if cls._bootstrap_option_values:","path":"src/python/pants/base/exception_sink.py","position":54,"original_position":54,"commit_id":"62762622c908792f2e8298dacdfb5c12cbde4752","original_commit_id":"62762622c908792f2e8298dacdfb5c12cbde4752","user":{"login":"cosmicexplorer","id":1305167,"node_id":"MDQ6VXNlcjEzMDUxNjc=","avatar_url":"https://avatars1.githubusercontent.com/u/1305167?v=4","gravatar_id":"","url":"https://api.github.com/users/cosmicexplorer","html_url":"https://github.com/cosmicexplorer","followers_url":"https://api.github.com/users/cosmicexplorer/followers","following_url":"https://api.github.com/users/cosmicexplorer/following{/other_user}","gists_url":"https://api.github.com/users/cosmicexplorer/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmicexplorer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmicexplorer/subscriptions","organizations_url":"https://api.github.com/users/cosmicexplorer/orgs","repos_url":"https://api.github.com/users/cosmicexplorer/repos","events_url":"https://api.github.com/users/cosmicexplorer/events{/privacy}","received_events_url":"https://api.github.com/users/cosmicexplorer/received_events","type":"User","site_admin":false},"body":"Truly fantastic idea. Will do.","created_at":"2018-10-09T16:44:21Z","updated_at":"2018-10-09T16:44:21Z","html_url":"https://github.com/pantsbuild/pants/pull/6610#discussion_r223778731","pull_request_url":"https://api.github.com/repos/pantsbuild/pants/pulls/6610","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/comments/223778731"},"html":{"href":"https://github.com/pantsbuild/pants/pull/6610#discussion_r223778731"},"pull_request":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/6610"}},"in_reply_to_id":223702386},"pull_request":{"url":"https://api.github.com/repos/pantsbuild/pants/pulls/6610","id":221340033,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMzQwMDMz","html_url":"https://github.com/pantsbuild/pants/pull/6610","diff_url":"https://github.com/pantsbuild/pants/pull/6610.diff","patch_url":"https://github.com/pantsbuild/pants/pull/6610.patch","issue_url":"https://api.github.com/repos/pantsbuild/pants/issues/6610","number":6610,"state":"open","locked":false,"title":"Fatal error logging followup fixes","user":{"login":"cosmicexplorer","id":1305167,"node_id":"MDQ6VXNlcjEzMDUxNjc=","avatar_url":"https://avatars1.githubusercontent.com/u/1305167?v=4","gravatar_id":"","url":"https://api.github.com/users/cosmicexplorer","html_url":"https://github.com/cosmicexplorer","followers_url":"https://api.github.com/users/cosmicexplorer/followers","following_url":"https://api.github.com/users/cosmicexplorer/following{/other_user}","gists_url":"https://api.github.com/users/cosmicexplorer/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmicexplorer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmicexplorer/subscriptions","organizations_url":"https://api.github.com/users/cosmicexplorer/orgs","repos_url":"https://api.github.com/users/cosmicexplorer/repos","events_url":"https://api.github.com/users/cosmicexplorer/events{/privacy}","received_events_url":"https://api.github.com/users/cosmicexplorer/received_events","type":"User","site_admin":false},"body":"### Problem\r\n\r\nThis PR contains several deemed-necessary-by-me-personally fixes to fatal error logging which weren't put into #6552 because that diff was already massive. This should be considered the same PR as that one.\r\n\r\n### Solution\r\n\r\n- Default the `logs/` directory to be `.pants.d/logs` so we don't litter the buildroot with a top-level `logs/` directory.\r\n- Add a timestamp to any fatal errors printed to the terminal to more easily debug race conditions.\r\n- Add the process title (from `setproctitle`) to the fatal error log message (this makes it more clear when the process is pantsd, compared to the `sys.argv`, which are arbitrary).\r\n- Remove any mention of exception stacktraces from Exiter. \r\n- Add `ExceptionSink.reset_bootstrap_options()` to set bootstrap options, which are then used in the fatal error log and to determine whether to print stacktraces to the terminal on exit.\r\n- Testing for all of the above.","created_at":"2018-10-09T07:54:28Z","updated_at":"2018-10-09T16:44:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a9324f1a18ee9e5116bee55ade19cca92cf2c9c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ity","id":1278541,"node_id":"MDQ6VXNlcjEyNzg1NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1278541?v=4","gravatar_id":"","url":"https://api.github.com/users/ity","html_url":"https://github.com/ity","followers_url":"https://api.github.com/users/ity/followers","following_url":"https://api.github.com/users/ity/following{/other_user}","gists_url":"https://api.github.com/users/ity/gists{/gist_id}","starred_url":"https://api.github.com/users/ity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ity/subscriptions","organizations_url":"https://api.github.com/users/ity/orgs","repos_url":"https://api.github.com/users/ity/repos","events_url":"https://api.github.com/users/ity/events{/privacy}","received_events_url":"https://api.github.com/users/ity/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pantsbuild/pants/pulls/6610/commits","review_comments_url":"https://api.github.com/repos/pantsbuild/pants/pulls/6610/comments","review_comment_url":"https://api.github.com/repos/pantsbuild/pants/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pantsbuild/pants/issues/6610/comments","statuses_url":"https://api.github.com/repos/pantsbuild/pants/statuses/62762622c908792f2e8298dacdfb5c12cbde4752","head":{"label":"cosmicexplorer:logging-followup-fixes","ref":"logging-followup-fixes","sha":"62762622c908792f2e8298dacdfb5c12cbde4752","user":{"login":"cosmicexplorer","id":1305167,"node_id":"MDQ6VXNlcjEzMDUxNjc=","avatar_url":"https://avatars1.githubusercontent.com/u/1305167?v=4","gravatar_id":"","url":"https://api.github.com/users/cosmicexplorer","html_url":"https://github.com/cosmicexplorer","followers_url":"https://api.github.com/users/cosmicexplorer/followers","following_url":"https://api.github.com/users/cosmicexplorer/following{/other_user}","gists_url":"https://api.github.com/users/cosmicexplorer/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmicexplorer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmicexplorer/subscriptions","organizations_url":"https://api.github.com/users/cosmicexplorer/orgs","repos_url":"https://api.github.com/users/cosmicexplorer/repos","events_url":"https://api.github.com/users/cosmicexplorer/events{/privacy}","received_events_url":"https://api.github.com/users/cosmicexplorer/received_events","type":"User","site_admin":false},"repo":{"id":59165183,"node_id":"MDEwOlJlcG9zaXRvcnk1OTE2NTE4Mw==","name":"pants","full_name":"cosmicexplorer/pants","private":false,"owner":{"login":"cosmicexplorer","id":1305167,"node_id":"MDQ6VXNlcjEzMDUxNjc=","avatar_url":"https://avatars1.githubusercontent.com/u/1305167?v=4","gravatar_id":"","url":"https://api.github.com/users/cosmicexplorer","html_url":"https://github.com/cosmicexplorer","followers_url":"https://api.github.com/users/cosmicexplorer/followers","following_url":"https://api.github.com/users/cosmicexplorer/following{/other_user}","gists_url":"https://api.github.com/users/cosmicexplorer/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmicexplorer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmicexplorer/subscriptions","organizations_url":"https://api.github.com/users/cosmicexplorer/orgs","repos_url":"https://api.github.com/users/cosmicexplorer/repos","events_url":"https://api.github.com/users/cosmicexplorer/events{/privacy}","received_events_url":"https://api.github.com/users/cosmicexplorer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cosmicexplorer/pants","description":"Pants Build System","fork":true,"url":"https://api.github.com/repos/cosmicexplorer/pants","forks_url":"https://api.github.com/repos/cosmicexplorer/pants/forks","keys_url":"https://api.github.com/repos/cosmicexplorer/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cosmicexplorer/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cosmicexplorer/pants/teams","hooks_url":"https://api.github.com/repos/cosmicexplorer/pants/hooks","issue_events_url":"https://api.github.com/repos/cosmicexplorer/pants/issues/events{/number}","events_url":"https://api.github.com/repos/cosmicexplorer/pants/events","assignees_url":"https://api.github.com/repos/cosmicexplorer/pants/assignees{/user}","branches_url":"https://api.github.com/repos/cosmicexplorer/pants/branches{/branch}","tags_url":"https://api.github.com/repos/cosmicexplorer/pants/tags","blobs_url":"https://api.github.com/repos/cosmicexplorer/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cosmicexplorer/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cosmicexplorer/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/cosmicexplorer/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cosmicexplorer/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/cosmicexplorer/pants/languages","stargazers_url":"https://api.github.com/repos/cosmicexplorer/pants/stargazers","contributors_url":"https://api.github.com/repos/cosmicexplorer/pants/contributors","subscribers_url":"https://api.github.com/repos/cosmicexplorer/pants/subscribers","subscription_url":"https://api.github.com/repos/cosmicexplorer/pants/subscription","commits_url":"https://api.github.com/repos/cosmicexplorer/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/cosmicexplorer/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/cosmicexplorer/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/cosmicexplorer/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/cosmicexplorer/pants/contents/{+path}","compare_url":"https://api.github.com/repos/cosmicexplorer/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cosmicexplorer/pants/merges","archive_url":"https://api.github.com/repos/cosmicexplorer/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cosmicexplorer/pants/downloads","issues_url":"https://api.github.com/repos/cosmicexplorer/pants/issues{/number}","pulls_url":"https://api.github.com/repos/cosmicexplorer/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/cosmicexplorer/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/cosmicexplorer/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cosmicexplorer/pants/labels{/name}","releases_url":"https://api.github.com/repos/cosmicexplorer/pants/releases{/id}","deployments_url":"https://api.github.com/repos/cosmicexplorer/pants/deployments","created_at":"2016-05-19T01:53:21Z","updated_at":"2018-10-09T05:19:35Z","pushed_at":"2018-10-09T07:56:38Z","git_url":"git://github.com/cosmicexplorer/pants.git","ssh_url":"git@github.com:cosmicexplorer/pants.git","clone_url":"https://github.com/cosmicexplorer/pants.git","svn_url":"https://github.com/cosmicexplorer/pants","homepage":"http://pantsbuild.github.io/","size":90366,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pantsbuild:master","ref":"master","sha":"295ea609c6267ed2a6b0521000a266e3962f6289","user":{"login":"pantsbuild","id":3065172,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjUxNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/3065172?v=4","gravatar_id":"","url":"https://api.github.com/users/pantsbuild","html_url":"https://github.com/pantsbuild","followers_url":"https://api.github.com/users/pantsbuild/followers","following_url":"https://api.github.com/users/pantsbuild/following{/other_user}","gists_url":"https://api.github.com/users/pantsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/pantsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantsbuild/subscriptions","organizations_url":"https://api.github.com/users/pantsbuild/orgs","repos_url":"https://api.github.com/users/pantsbuild/repos","events_url":"https://api.github.com/users/pantsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/pantsbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":7209075,"node_id":"MDEwOlJlcG9zaXRvcnk3MjA5MDc1","name":"pants","full_name":"pantsbuild/pants","private":false,"owner":{"login":"pantsbuild","id":3065172,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjUxNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/3065172?v=4","gravatar_id":"","url":"https://api.github.com/users/pantsbuild","html_url":"https://github.com/pantsbuild","followers_url":"https://api.github.com/users/pantsbuild/followers","following_url":"https://api.github.com/users/pantsbuild/following{/other_user}","gists_url":"https://api.github.com/users/pantsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/pantsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantsbuild/subscriptions","organizations_url":"https://api.github.com/users/pantsbuild/orgs","repos_url":"https://api.github.com/users/pantsbuild/repos","events_url":"https://api.github.com/users/pantsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/pantsbuild/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pantsbuild/pants","description":"The Pants Build System","fork":false,"url":"https://api.github.com/repos/pantsbuild/pants","forks_url":"https://api.github.com/repos/pantsbuild/pants/forks","keys_url":"https://api.github.com/repos/pantsbuild/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pantsbuild/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pantsbuild/pants/teams","hooks_url":"https://api.github.com/repos/pantsbuild/pants/hooks","issue_events_url":"https://api.github.com/repos/pantsbuild/pants/issues/events{/number}","events_url":"https://api.github.com/repos/pantsbuild/pants/events","assignees_url":"https://api.github.com/repos/pantsbuild/pants/assignees{/user}","branches_url":"https://api.github.com/repos/pantsbuild/pants/branches{/branch}","tags_url":"https://api.github.com/repos/pantsbuild/pants/tags","blobs_url":"https://api.github.com/repos/pantsbuild/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pantsbuild/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pantsbuild/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/pantsbuild/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pantsbuild/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/pantsbuild/pants/languages","stargazers_url":"https://api.github.com/repos/pantsbuild/pants/stargazers","contributors_url":"https://api.github.com/repos/pantsbuild/pants/contributors","subscribers_url":"https://api.github.com/repos/pantsbuild/pants/subscribers","subscription_url":"https://api.github.com/repos/pantsbuild/pants/subscription","commits_url":"https://api.github.com/repos/pantsbuild/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/pantsbuild/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/pantsbuild/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/pantsbuild/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/pantsbuild/pants/contents/{+path}","compare_url":"https://api.github.com/repos/pantsbuild/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pantsbuild/pants/merges","archive_url":"https://api.github.com/repos/pantsbuild/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pantsbuild/pants/downloads","issues_url":"https://api.github.com/repos/pantsbuild/pants/issues{/number}","pulls_url":"https://api.github.com/repos/pantsbuild/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/pantsbuild/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/pantsbuild/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pantsbuild/pants/labels{/name}","releases_url":"https://api.github.com/repos/pantsbuild/pants/releases{/id}","deployments_url":"https://api.github.com/repos/pantsbuild/pants/deployments","created_at":"2012-12-17T17:39:04Z","updated_at":"2018-10-09T15:50:34Z","pushed_at":"2018-10-09T15:50:23Z","git_url":"git://github.com/pantsbuild/pants.git","ssh_url":"git@github.com:pantsbuild/pants.git","clone_url":"https://github.com/pantsbuild/pants.git","svn_url":"https://github.com/pantsbuild/pants","homepage":"http://pantsbuild.org/","size":88295,"stargazers_count":1029,"watchers_count":1029,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":298,"mirror_url":null,"archived":false,"open_issues_count":724,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":298,"open_issues":724,"watchers":1029,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/6610"},"html":{"href":"https://github.com/pantsbuild/pants/pull/6610"},"issue":{"href":"https://api.github.com/repos/pantsbuild/pants/issues/6610"},"comments":{"href":"https://api.github.com/repos/pantsbuild/pants/issues/6610/comments"},"review_comments":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/6610/comments"},"review_comment":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/6610/commits"},"statuses":{"href":"https://api.github.com/repos/pantsbuild/pants/statuses/62762622c908792f2e8298dacdfb5c12cbde4752"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cosmicexplorer"}}