{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/addons-frontend/issues/4976","repository_url":"https://api.github.com/repos/mozilla/addons-frontend","labels_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/4976/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/4976/comments","events_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/4976/events","html_url":"https://github.com/mozilla/addons-frontend/pull/4976","id":322058952,"number":4976,"title":"Css fix for add ons (extensions) detail page","user":{"login":"biskit1","id":26360553,"avatar_url":"https://avatars1.githubusercontent.com/u/26360553?v=4","gravatar_id":"","url":"https://api.github.com/users/biskit1","html_url":"https://github.com/biskit1","followers_url":"https://api.github.com/users/biskit1/followers","following_url":"https://api.github.com/users/biskit1/following{/other_user}","gists_url":"https://api.github.com/users/biskit1/gists{/gist_id}","starred_url":"https://api.github.com/users/biskit1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biskit1/subscriptions","organizations_url":"https://api.github.com/users/biskit1/orgs","repos_url":"https://api.github.com/users/biskit1/repos","events_url":"https://api.github.com/users/biskit1/events{/privacy}","received_events_url":"https://api.github.com/users/biskit1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"rebmullin","id":1986001,"avatar_url":"https://avatars2.githubusercontent.com/u/1986001?v=4","gravatar_id":"","url":"https://api.github.com/users/rebmullin","html_url":"https://github.com/rebmullin","followers_url":"https://api.github.com/users/rebmullin/followers","following_url":"https://api.github.com/users/rebmullin/following{/other_user}","gists_url":"https://api.github.com/users/rebmullin/gists{/gist_id}","starred_url":"https://api.github.com/users/rebmullin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rebmullin/subscriptions","organizations_url":"https://api.github.com/users/rebmullin/orgs","repos_url":"https://api.github.com/users/rebmullin/repos","events_url":"https://api.github.com/users/rebmullin/events{/privacy}","received_events_url":"https://api.github.com/users/rebmullin/received_events","type":"User","site_admin":false},"assignees":[{"login":"rebmullin","id":1986001,"avatar_url":"https://avatars2.githubusercontent.com/u/1986001?v=4","gravatar_id":"","url":"https://api.github.com/users/rebmullin","html_url":"https://github.com/rebmullin","followers_url":"https://api.github.com/users/rebmullin/followers","following_url":"https://api.github.com/users/rebmullin/following{/other_user}","gists_url":"https://api.github.com/users/rebmullin/gists{/gist_id}","starred_url":"https://api.github.com/users/rebmullin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rebmullin/subscriptions","organizations_url":"https://api.github.com/users/rebmullin/orgs","repos_url":"https://api.github.com/users/rebmullin/repos","events_url":"https://api.github.com/users/rebmullin/events{/privacy}","received_events_url":"https://api.github.com/users/rebmullin/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-05-10T19:45:20Z","updated_at":"2018-05-14T15:31:09Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mozilla/addons-frontend/pulls/4976","html_url":"https://github.com/mozilla/addons-frontend/pull/4976","diff_url":"https://github.com/mozilla/addons-frontend/pull/4976.diff","patch_url":"https://github.com/mozilla/addons-frontend/pull/4976.patch"},"body":"Fixes #4878 \r\n\r\nThis PR introduces css changes to the details page of individual add ons. \r\n\r\nThe original issue was opened to fix the line containing the author, which at times would overlap with the title (depending on the letters contained in the title, such as `g, y, p, q` and the size of screen) like so: \r\n<p align=\"center\">\r\n  <img src=\"https://user-images.githubusercontent.com/26360553/39890090-b7d34368-5467-11e8-82b7-0737954bad77.png\">\r\n</p><br/>\r\n\r\nTo fix this problem, I just added a `line-height` of `1.5` to the `Addon-author` class:\r\n<p align=\"center\">\r\n  <img src=\"https://user-images.githubusercontent.com/26360553/39890120-d7cbc7d0-5467-11e8-95c1-29c1bf353c58.png\">\r\n</p><br/>\r\n\r\nWhile implementing this change and testing the results, I also noticed that at times the title itself ran into the same problem: \r\n<p align=\"center\">\r\n  <img src = \"https://user-images.githubusercontent.com/26360553/39889283-7a37113a-5465-11e8-819f-00eeac5e0818.png\">\r\n</p>\r\nand another example: \r\n<p align=\"center\">\r\n  <img src=\"https://user-images.githubusercontent.com/26360553/39889317-8a16719a-5465-11e8-9e5d-00e4f5b2b8fe.png\">\r\n</p><br/>\r\n\r\nSo I added a `line-height` property to the `Addon-title` class as well, with a value of `normal` (1.5 was too much for the title): \r\n<p align=\"center\">\r\n  <img src=\"https://user-images.githubusercontent.com/26360553/39889463-f3fa90c8-5465-11e8-9671-0125a16d97eb.png\">\r\n</p><br/>\r\n\r\nThere were no tests found for the files I modified, so I ran `yarn lint` and corrected any formatting errors. "},"comment":{"url":"https://api.github.com/repos/mozilla/addons-frontend/issues/comments/388859960","html_url":"https://github.com/mozilla/addons-frontend/pull/4976#issuecomment-388859960","issue_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/4976","id":388859960,"user":{"login":"rebmullin","id":1986001,"avatar_url":"https://avatars2.githubusercontent.com/u/1986001?v=4","gravatar_id":"","url":"https://api.github.com/users/rebmullin","html_url":"https://github.com/rebmullin","followers_url":"https://api.github.com/users/rebmullin/followers","following_url":"https://api.github.com/users/rebmullin/following{/other_user}","gists_url":"https://api.github.com/users/rebmullin/gists{/gist_id}","starred_url":"https://api.github.com/users/rebmullin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rebmullin/subscriptions","organizations_url":"https://api.github.com/users/rebmullin/orgs","repos_url":"https://api.github.com/users/rebmullin/repos","events_url":"https://api.github.com/users/rebmullin/events{/privacy}","received_events_url":"https://api.github.com/users/rebmullin/received_events","type":"User","site_admin":false},"created_at":"2018-05-14T15:31:08Z","updated_at":"2018-05-14T15:31:08Z","author_association":"COLLABORATOR","body":"that’s a really good point @biskit1 - that we need to consider longer usernames. I am not sure how common those are but it still might be a (edge) case to consider.  Regarding the padding…I think that might be a good solution to try out..we did increase the parent line height to 1.1 and since `Addon-author` will inherit that maybe this will look okay with just the extra padding. Do you want to try that and see it how looks at the different breakpoints?"}}
{"actor":{"display_login":"rebmullin"}}