{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/236316272","pull_request_review_id":178247796,"id":236316272,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjMxNjI3Mg==","diff_hunk":"@@ -160,6 +160,95 @@ class TopicCommandTest extends ZooKeeperTestHarness with Logging with RackAwareT\n     TopicCommand.createTopic(zkClient, createNotExistsOpts)\n   }\n \n+  @Test\n+  def testCreateWithAllAvailableBrokersReplicaAssignment() {","path":"core/src/test/scala/unit/kafka/admin/TopicCommandTest.scala","position":34,"original_position":34,"commit_id":"7c31b96ae8464a1335a5e43249ff646770286697","original_commit_id":"7c31b96ae8464a1335a5e43249ff646770286697","user":{"login":"omkreddy","id":8134545,"node_id":"MDQ6VXNlcjgxMzQ1NDU=","avatar_url":"https://avatars2.githubusercontent.com/u/8134545?v=4","gravatar_id":"","url":"https://api.github.com/users/omkreddy","html_url":"https://github.com/omkreddy","followers_url":"https://api.github.com/users/omkreddy/followers","following_url":"https://api.github.com/users/omkreddy/following{/other_user}","gists_url":"https://api.github.com/users/omkreddy/gists{/gist_id}","starred_url":"https://api.github.com/users/omkreddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omkreddy/subscriptions","organizations_url":"https://api.github.com/users/omkreddy/orgs","repos_url":"https://api.github.com/users/omkreddy/repos","events_url":"https://api.github.com/users/omkreddy/events{/privacy}","received_events_url":"https://api.github.com/users/omkreddy/received_events","type":"User","site_admin":false},"body":"Can we also add any missing tests/scenarios to [AdminClientIntegrationTest ](https://github.com/apache/kafka/blob/trunk/core/src/test/scala/integration/kafka/api/AdminClientIntegrationTest.scala#L149)","created_at":"2018-11-26T16:05:55Z","updated_at":"2018-11-26T16:38:13Z","html_url":"https://github.com/apache/kafka/pull/5822#discussion_r236316272","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/5822","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/236316272"},"html":{"href":"https://github.com/apache/kafka/pull/5822#discussion_r236316272"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/5822"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/5822","id":224552902,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NTUyOTAy","html_url":"https://github.com/apache/kafka/pull/5822","diff_url":"https://github.com/apache/kafka/pull/5822.diff","patch_url":"https://github.com/apache/kafka/pull/5822.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/5822","number":5822,"state":"open","locked":false,"title":"Fixed KAFKA-7382 - guarantee atleast one replica of partition to be alive during topic creation.","user":{"login":"sumannewton","id":13970228,"node_id":"MDQ6VXNlcjEzOTcwMjI4","avatar_url":"https://avatars2.githubusercontent.com/u/13970228?v=4","gravatar_id":"","url":"https://api.github.com/users/sumannewton","html_url":"https://github.com/sumannewton","followers_url":"https://api.github.com/users/sumannewton/followers","following_url":"https://api.github.com/users/sumannewton/following{/other_user}","gists_url":"https://api.github.com/users/sumannewton/gists{/gist_id}","starred_url":"https://api.github.com/users/sumannewton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumannewton/subscriptions","organizations_url":"https://api.github.com/users/sumannewton/orgs","repos_url":"https://api.github.com/users/sumannewton/repos","events_url":"https://api.github.com/users/sumannewton/events{/privacy}","received_events_url":"https://api.github.com/users/sumannewton/received_events","type":"User","site_admin":false},"body":"Validate that the replica assignment provided during topic creation contains at least one alive broker in the kafka cluster.\r\n\r\nReuse the method AdminZkClient.validateReplicaAssignment(). \r\n\r\n- Test for creating a topic with replica assignment with valid brokers.\r\n- Test for creating a topic with replica assignment with invalid brokers.","created_at":"2018-10-21T16:30:57Z","updated_at":"2018-11-26T16:38:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40979d73b01e5eb5b367672b6449901fe5c8f8b4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/5822/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/5822/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/5822/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/7c31b96ae8464a1335a5e43249ff646770286697","head":{"label":"sumannewton:atleast-one-replica-topic-creation","ref":"atleast-one-replica-topic-creation","sha":"7c31b96ae8464a1335a5e43249ff646770286697","user":{"login":"sumannewton","id":13970228,"node_id":"MDQ6VXNlcjEzOTcwMjI4","avatar_url":"https://avatars2.githubusercontent.com/u/13970228?v=4","gravatar_id":"","url":"https://api.github.com/users/sumannewton","html_url":"https://github.com/sumannewton","followers_url":"https://api.github.com/users/sumannewton/followers","following_url":"https://api.github.com/users/sumannewton/following{/other_user}","gists_url":"https://api.github.com/users/sumannewton/gists{/gist_id}","starred_url":"https://api.github.com/users/sumannewton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumannewton/subscriptions","organizations_url":"https://api.github.com/users/sumannewton/orgs","repos_url":"https://api.github.com/users/sumannewton/repos","events_url":"https://api.github.com/users/sumannewton/events{/privacy}","received_events_url":"https://api.github.com/users/sumannewton/received_events","type":"User","site_admin":false},"repo":{"id":146892719,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY4OTI3MTk=","name":"kafka","full_name":"sumannewton/kafka","private":false,"owner":{"login":"sumannewton","id":13970228,"node_id":"MDQ6VXNlcjEzOTcwMjI4","avatar_url":"https://avatars2.githubusercontent.com/u/13970228?v=4","gravatar_id":"","url":"https://api.github.com/users/sumannewton","html_url":"https://github.com/sumannewton","followers_url":"https://api.github.com/users/sumannewton/followers","following_url":"https://api.github.com/users/sumannewton/following{/other_user}","gists_url":"https://api.github.com/users/sumannewton/gists{/gist_id}","starred_url":"https://api.github.com/users/sumannewton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumannewton/subscriptions","organizations_url":"https://api.github.com/users/sumannewton/orgs","repos_url":"https://api.github.com/users/sumannewton/repos","events_url":"https://api.github.com/users/sumannewton/events{/privacy}","received_events_url":"https://api.github.com/users/sumannewton/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sumannewton/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/sumannewton/kafka","forks_url":"https://api.github.com/repos/sumannewton/kafka/forks","keys_url":"https://api.github.com/repos/sumannewton/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sumannewton/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sumannewton/kafka/teams","hooks_url":"https://api.github.com/repos/sumannewton/kafka/hooks","issue_events_url":"https://api.github.com/repos/sumannewton/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/sumannewton/kafka/events","assignees_url":"https://api.github.com/repos/sumannewton/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/sumannewton/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/sumannewton/kafka/tags","blobs_url":"https://api.github.com/repos/sumannewton/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sumannewton/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sumannewton/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/sumannewton/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sumannewton/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/sumannewton/kafka/languages","stargazers_url":"https://api.github.com/repos/sumannewton/kafka/stargazers","contributors_url":"https://api.github.com/repos/sumannewton/kafka/contributors","subscribers_url":"https://api.github.com/repos/sumannewton/kafka/subscribers","subscription_url":"https://api.github.com/repos/sumannewton/kafka/subscription","commits_url":"https://api.github.com/repos/sumannewton/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/sumannewton/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/sumannewton/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/sumannewton/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/sumannewton/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/sumannewton/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sumannewton/kafka/merges","archive_url":"https://api.github.com/repos/sumannewton/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sumannewton/kafka/downloads","issues_url":"https://api.github.com/repos/sumannewton/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/sumannewton/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/sumannewton/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/sumannewton/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sumannewton/kafka/labels{/name}","releases_url":"https://api.github.com/repos/sumannewton/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/sumannewton/kafka/deployments","created_at":"2018-08-31T13:02:27Z","updated_at":"2018-10-13T05:20:20Z","pushed_at":"2018-10-21T16:26:09Z","git_url":"git://github.com/sumannewton/kafka.git","ssh_url":"git@github.com:sumannewton/kafka.git","clone_url":"https://github.com/sumannewton/kafka.git","svn_url":"https://github.com/sumannewton/kafka","homepage":null,"size":75049,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"83e98334a94ce2071a3294a8b310f1d646127f1c","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"node_id":"MDEwOlJlcG9zaXRvcnkyMjExMjQz","name":"kafka","full_name":"apache/kafka","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2018-11-26T14:14:24Z","pushed_at":"2018-11-26T16:33:34Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":76531,"stargazers_count":10258,"watchers_count":10258,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5733,"mirror_url":null,"archived":false,"open_issues_count":535,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5733,"open_issues":535,"watchers":10258,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/5822"},"html":{"href":"https://github.com/apache/kafka/pull/5822"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/5822"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/5822/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/5822/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/5822/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/7c31b96ae8464a1335a5e43249ff646770286697"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"omkreddy"}}