{"action":"created","issue":{"url":"https://api.github.com/repos/ExpeditionRPG/expedition/issues/235","repository_url":"https://api.github.com/repos/ExpeditionRPG/expedition","labels_url":"https://api.github.com/repos/ExpeditionRPG/expedition/issues/235/labels{/name}","comments_url":"https://api.github.com/repos/ExpeditionRPG/expedition/issues/235/comments","events_url":"https://api.github.com/repos/ExpeditionRPG/expedition/issues/235/events","html_url":"https://github.com/ExpeditionRPG/expedition/issues/235","id":337300876,"node_id":"MDU6SXNzdWUzMzczMDA4NzY=","number":235,"title":"Improve remote play reliability","user":{"login":"toddmedema","id":775657,"node_id":"MDQ6VXNlcjc3NTY1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/775657?v=4","gravatar_id":"","url":"https://api.github.com/users/toddmedema","html_url":"https://github.com/toddmedema","followers_url":"https://api.github.com/users/toddmedema/followers","following_url":"https://api.github.com/users/toddmedema/following{/other_user}","gists_url":"https://api.github.com/users/toddmedema/gists{/gist_id}","starred_url":"https://api.github.com/users/toddmedema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toddmedema/subscriptions","organizations_url":"https://api.github.com/users/toddmedema/orgs","repos_url":"https://api.github.com/users/toddmedema/repos","events_url":"https://api.github.com/users/toddmedema/events{/privacy}","received_events_url":"https://api.github.com/users/toddmedema/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-01T15:46:12Z","updated_at":"2018-07-01T15:46:14Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"<a href=\"https://github.com/smartin015\"><img src=\"https://avatars2.githubusercontent.com/u/607666?v=4\" align=\"left\" width=\"96\" height=\"96\" hspace=\"10\"></img></a> **Issue by [smartin015](https://github.com/smartin015)**\n_Sunday Mar 18, 2018 at 22:46 GMT_\n_Originally opened as https://github.com/ExpeditionRPG/expedition-app/issues/616 (1 comment(s))_\n\n----\n\n- [ ] Server should recognize when both clients are on same event ID, but different quest line numbers\r\n- [ ] >50% unit tests complete\n"},"comment":{"url":"https://api.github.com/repos/ExpeditionRPG/expedition/issues/comments/401614964","html_url":"https://github.com/ExpeditionRPG/expedition/issues/235#issuecomment-401614964","issue_url":"https://api.github.com/repos/ExpeditionRPG/expedition/issues/235","id":401614964,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTYxNDk2NA==","user":{"login":"toddmedema","id":775657,"node_id":"MDQ6VXNlcjc3NTY1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/775657?v=4","gravatar_id":"","url":"https://api.github.com/users/toddmedema","html_url":"https://github.com/toddmedema","followers_url":"https://api.github.com/users/toddmedema/followers","following_url":"https://api.github.com/users/toddmedema/following{/other_user}","gists_url":"https://api.github.com/users/toddmedema/gists{/gist_id}","starred_url":"https://api.github.com/users/toddmedema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toddmedema/subscriptions","organizations_url":"https://api.github.com/users/toddmedema/orgs","repos_url":"https://api.github.com/users/toddmedema/repos","events_url":"https://api.github.com/users/toddmedema/events{/privacy}","received_events_url":"https://api.github.com/users/toddmedema/received_events","type":"User","site_admin":false},"created_at":"2018-07-01T15:46:14Z","updated_at":"2018-07-01T15:46:14Z","author_association":"CONTRIBUTOR","body":"<a href=\"https://github.com/toddmedema\"><img src=\"https://avatars2.githubusercontent.com/u/775657?v=4\" align=\"left\" width=\"48\" height=\"48\" hspace=\"10\"></img></a> **Comment by [toddmedema](https://github.com/toddmedema)**\n_Monday Mar 19, 2018 at 04:07 GMT_\n\n----\n\nSome random notes I have lying around about JS testing techniques: (probably from the last time we did a testing sprint)\r\n\r\nReducer tests should test state changes via actions, specifically when there's logic involved / they aren't just glue\r\n\r\nUse jasmine.objectContaining for more robust tests\r\n\r\nComponents: test branches for key content, i.e. if search results empty, make sure that resulting string contains \"No results found\"\r\n\r\nComponents: make sure that key interactivity works, i.e. that clicking the button calls the expected function\r\n- see app/AdvancedPlay tests / enzyme / using spies\r\n\r\nContainers: test when doing logic in mapping state or dispatch (i.e. not just glue) & test the logic\r\n- i.e. the combat container\r\n- see app/AdvancedPlayContainer, create a mock store, dispatch function, check that actions are dispatched with correct parameters.... this one goes too far and actually also tests the action\r\n\r\n\r\nActions: test actions with logic / not just glue\r\n- ie Quest load node\r\n- see app/actions/card - mock store, spy on outputs, expect the action with parameters to return an object containing\r\n- if plain function, call directly. If dispatch-wrapped action, call store.dispatch(action)\n"}}
{"actor":{"display_login":"toddmedema"}}