{"action":"closed","issue":{"url":"https://api.github.com/repos/SuperTux/supertux/issues/672","repository_url":"https://api.github.com/repos/SuperTux/supertux","labels_url":"https://api.github.com/repos/SuperTux/supertux/issues/672/labels{/name}","comments_url":"https://api.github.com/repos/SuperTux/supertux/issues/672/comments","events_url":"https://api.github.com/repos/SuperTux/supertux/issues/672/events","html_url":"https://github.com/SuperTux/supertux/issues/672","id":197508087,"node_id":"MDU6SXNzdWUxOTc1MDgwODc=","number":672,"title":"use after free in downloader","user":{"login":"matthiaskrgr","id":476013,"node_id":"MDQ6VXNlcjQ3NjAxMw==","avatar_url":"https://avatars2.githubusercontent.com/u/476013?v=4","gravatar_id":"","url":"https://api.github.com/users/matthiaskrgr","html_url":"https://github.com/matthiaskrgr","followers_url":"https://api.github.com/users/matthiaskrgr/followers","following_url":"https://api.github.com/users/matthiaskrgr/following{/other_user}","gists_url":"https://api.github.com/users/matthiaskrgr/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiaskrgr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiaskrgr/subscriptions","organizations_url":"https://api.github.com/users/matthiaskrgr/orgs","repos_url":"https://api.github.com/users/matthiaskrgr/repos","events_url":"https://api.github.com/users/matthiaskrgr/events{/privacy}","received_events_url":"https://api.github.com/users/matthiaskrgr/received_events","type":"User","site_admin":false},"labels":[{"id":271224716,"node_id":"MDU6TGFiZWwyNzEyMjQ3MTY=","url":"https://api.github.com/repos/SuperTux/supertux/labels/category:code","name":"category:code","color":"d4c5f9","default":false},{"id":707716746,"node_id":"MDU6TGFiZWw3MDc3MTY3NDY=","url":"https://api.github.com/repos/SuperTux/supertux/labels/hacktoberfest","name":"hacktoberfest","color":"fe9600","default":false},{"id":737688951,"node_id":"MDU6TGFiZWw3Mzc2ODg5NTE=","url":"https://api.github.com/repos/SuperTux/supertux/labels/help%20wanted","name":"help wanted","color":"128a0c","default":true},{"id":190538419,"node_id":"MDU6TGFiZWwxOTA1Mzg0MTk=","url":"https://api.github.com/repos/SuperTux/supertux/labels/priority:high","name":"priority:high","color":"eb6420","default":false},{"id":283570338,"node_id":"MDU6TGFiZWwyODM1NzAzMzg=","url":"https://api.github.com/repos/SuperTux/supertux/labels/status:needs-work","name":"status:needs-work","color":"800000","default":false},{"id":190538418,"node_id":"MDU6TGFiZWwxOTA1Mzg0MTg=","url":"https://api.github.com/repos/SuperTux/supertux/labels/type:bug","name":"type:bug","color":"eb6420","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/SuperTux/supertux/milestones/8","html_url":"https://github.com/SuperTux/supertux/milestone/8","labels_url":"https://api.github.com/repos/SuperTux/supertux/milestones/8/labels","id":1969545,"node_id":"MDk6TWlsZXN0b25lMTk2OTU0NQ==","number":8,"title":"0.6.0","description":"","creator":{"login":"maxteufel","id":6442985,"node_id":"MDQ6VXNlcjY0NDI5ODU=","avatar_url":"https://avatars1.githubusercontent.com/u/6442985?v=4","gravatar_id":"","url":"https://api.github.com/users/maxteufel","html_url":"https://github.com/maxteufel","followers_url":"https://api.github.com/users/maxteufel/followers","following_url":"https://api.github.com/users/maxteufel/following{/other_user}","gists_url":"https://api.github.com/users/maxteufel/gists{/gist_id}","starred_url":"https://api.github.com/users/maxteufel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxteufel/subscriptions","organizations_url":"https://api.github.com/users/maxteufel/orgs","repos_url":"https://api.github.com/users/maxteufel/repos","events_url":"https://api.github.com/users/maxteufel/events{/privacy}","received_events_url":"https://api.github.com/users/maxteufel/received_events","type":"User","site_admin":false},"open_issues":34,"closed_issues":64,"state":"open","created_at":"2016-08-29T13:05:24Z","updated_at":"2018-07-03T19:39:12Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2016-12-25T16:49:01Z","updated_at":"2018-07-03T19:39:12Z","closed_at":"2018-07-03T19:39:12Z","author_association":"NONE","body":"compile with address sanitizer\r\n\r\nAdd-ons -> Check online -> *download starts* -> *crash*\r\n\r\nstacktrace:\r\n````\r\n=================================================================\r\n==29146==ERROR: AddressSanitizer: heap-use-after-free on address 0x62d000b7c430 at pc 0x00000090735a bp 0x7fff4adebe00 sp 0x7fff4adebdf0\r\nREAD of size 4 at 0x62d000b7c430 thread T0\r\n    #0 0x907359 in Downloader::update() /home/matthias/vcs/github/supertux/src/addon/downloader.cpp:327\r\n    #1 0x904be9 in TransferStatus::update() /home/matthias/vcs/github/supertux/src/addon/downloader.cpp:66\r\n    #2 0x107ffc9 in DownloadDialog::update() /home/matthias/vcs/github/supertux/src/supertux/menu/download_dialog.cpp:55\r\n    #3 0xa13064 in MenuManager::draw(DrawingContext&) /home/matthias/vcs/github/supertux/src/gui/menu_manager.cpp:218\r\n    #4 0x7d8a36 in ScreenManager::draw(DrawingContext&) /home/matthias/vcs/github/supertux/src/supertux/screen_manager.cpp:169\r\n    #5 0x7dc9da in ScreenManager::run(DrawingContext&) /home/matthias/vcs/github/supertux/src/supertux/screen_manager.cpp:422\r\n    #6 0x7ae3d3 in Main::launch_game() /home/matthias/vcs/github/supertux/src/supertux/main.cpp:448\r\n    #7 0x7af727 in Main::run(int, char**) /home/matthias/vcs/github/supertux/src/supertux/main.cpp:504\r\n    #8 0x7aa1b9 in main /home/matthias/vcs/github/supertux/src/main.cpp:23\r\n    #9 0x7fa8d1245400 in __libc_start_main (/lib64/libc.so.6+0x20400)\r\n    #10 0x7aa0c9 in _start (/home/matthias/vcs/github/supertux/build/supertux2+0x7aa0c9)\r\n\r\n0x62d000b7c430 is located 48 bytes inside of 36160-byte region [0x62d000b7c400,0x62d000b85140)\r\nfreed by thread T0 here:\r\n    #0 0x7fa8d446aaf0 in free (/lib64/libasan.so.3+0xc6af0)\r\n    #1 0x7fa8d2bca694  (/lib64/libcurl.so.4+0x1f694)\r\n\r\npreviously allocated by thread T0 here:\r\n    #0 0x7fa8d446b010 in calloc (/lib64/libasan.so.3+0xc7010)\r\n    #1 0x7fa8d2bca95b  (/lib64/libcurl.so.4+0x1f95b)\r\n    #2 0x509313a86cd4cfff  (<unknown module>)\r\n\r\nSUMMARY: AddressSanitizer: heap-use-after-free /home/matthias/vcs/github/supertux/src/addon/downloader.cpp:327 in Downloader::update()\r\nShadow bytes around the buggy address:\r\n  0x0c5a80167830: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa\r\n  0x0c5a80167840: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa\r\n  0x0c5a80167850: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa\r\n  0x0c5a80167860: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa\r\n  0x0c5a80167870: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa\r\n=>0x0c5a80167880: fd fd fd fd fd fd[fd]fd fd fd fd fd fd fd fd fd\r\n  0x0c5a80167890: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd\r\n  0x0c5a801678a0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd\r\n  0x0c5a801678b0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd\r\n  0x0c5a801678c0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd\r\n  0x0c5a801678d0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd\r\nShadow byte legend (one shadow byte represents 8 application bytes):\r\n  Addressable:           00\r\n  Partially addressable: 01 02 03 04 05 06 07 \r\n  Heap left redzone:       fa\r\n  Heap right redzone:      fb\r\n  Freed heap region:       fd\r\n  Stack left redzone:      f1\r\n  Stack mid redzone:       f2\r\n  Stack right redzone:     f3\r\n  Stack partial redzone:   f4\r\n  Stack after return:      f5\r\n  Stack use after scope:   f8\r\n  Global redzone:          f9\r\n  Global init order:       f6\r\n  Poisoned by user:        f7\r\n  Container overflow:      fc\r\n  Array cookie:            ac\r\n  Intra object redzone:    bb\r\n  ASan internal:           fe\r\n  Left alloca redzone:     ca\r\n  Right alloca redzone:    cb\r\n==29146==ABORTING\r\n````\r\n"}}
{"actor":{"display_login":"tobbi"}}