{"action":"created","comment":{"url":"https://api.github.com/repos/rozza/mongo-spark/pulls/comments/215923555","pull_request_review_id":153296272,"id":215923555,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTkyMzU1NQ==","diff_hunk":"@@ -36,27 +36,23 @@ import org.scalatest._\n \n trait RequiresMongoDB extends FlatSpec with Matchers with BeforeAndAfterAll with BeforeAndAfterEach with LoggingTrait {\n \n-  private val mongoDBDefaults: MongoDBDefaults = MongoDBDefaults()\n+  private val testHelper: TestHelper = TestHelper()\n   private var _currentTestName: Option[String] = None\n   private var mongoDBOnline: Boolean = false\n \n-  private var requestedSparkContext: Boolean = false\n-  private def sparkContext: SparkContext = _sparkContext\n-  private lazy val _sparkContext: SparkContext = {\n-    requestedSparkContext = true\n-    _currentTestName = Some(suiteName)\n-    new SparkContext(sparkConf)\n-  }\n+  def sparkContext: SparkContext = TestHelper.getOrCreateSparkContext(sparkConf, requiredCustomConf = false)","path":"src/test/scala/com/mongodb/spark/RequiresMongoDB.scala","position":16,"original_position":16,"commit_id":"90eff3d7043e6df48888e549e83efa252259223c","original_commit_id":"ef4a717513a08697dc02ba337d8c5815f6841fb5","user":{"login":"rozza","id":420,"node_id":"MDQ6VXNlcjQyMA==","avatar_url":"https://avatars0.githubusercontent.com/u/420?v=4","gravatar_id":"","url":"https://api.github.com/users/rozza","html_url":"https://github.com/rozza","followers_url":"https://api.github.com/users/rozza/followers","following_url":"https://api.github.com/users/rozza/following{/other_user}","gists_url":"https://api.github.com/users/rozza/gists{/gist_id}","starred_url":"https://api.github.com/users/rozza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rozza/subscriptions","organizations_url":"https://api.github.com/users/rozza/orgs","repos_url":"https://api.github.com/users/rozza/repos","events_url":"https://api.github.com/users/rozza/events{/privacy}","received_events_url":"https://api.github.com/users/rozza/received_events","type":"User","site_admin":false},"body":"Spark Context now handled but the TestHelper","created_at":"2018-09-07T11:01:28Z","updated_at":"2018-09-07T11:06:54Z","html_url":"https://github.com/rozza/mongo-spark/pull/33#discussion_r215923555","pull_request_url":"https://api.github.com/repos/rozza/mongo-spark/pulls/33","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/rozza/mongo-spark/pulls/comments/215923555"},"html":{"href":"https://github.com/rozza/mongo-spark/pull/33#discussion_r215923555"},"pull_request":{"href":"https://api.github.com/repos/rozza/mongo-spark/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/rozza/mongo-spark/pulls/33","id":213891509,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzODkxNTA5","html_url":"https://github.com/rozza/mongo-spark/pull/33","diff_url":"https://github.com/rozza/mongo-spark/pull/33.diff","patch_url":"https://github.com/rozza/mongo-spark/pull/33.patch","issue_url":"https://api.github.com/repos/rozza/mongo-spark/issues/33","number":33,"state":"open","locked":false,"title":"S206","user":{"login":"rozza","id":420,"node_id":"MDQ6VXNlcjQyMA==","avatar_url":"https://avatars0.githubusercontent.com/u/420?v=4","gravatar_id":"","url":"https://api.github.com/users/rozza","html_url":"https://github.com/rozza","followers_url":"https://api.github.com/users/rozza/followers","following_url":"https://api.github.com/users/rozza/following{/other_user}","gists_url":"https://api.github.com/users/rozza/gists{/gist_id}","starred_url":"https://api.github.com/users/rozza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rozza/subscriptions","organizations_url":"https://api.github.com/users/rozza/orgs","repos_url":"https://api.github.com/users/rozza/repos","events_url":"https://api.github.com/users/rozza/events{/privacy}","received_events_url":"https://api.github.com/users/rozza/received_events","type":"User","site_admin":false},"body":"This is the base commit - that contains the test refactorings required to make updating Spark to 2.3.1 successful.","created_at":"2018-09-07T10:56:18Z","updated_at":"2018-09-07T11:06:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3fb5ceb9277f573dca1a17b67ad827d93433bcf3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jyemin","id":1111546,"node_id":"MDQ6VXNlcjExMTE1NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1111546?v=4","gravatar_id":"","url":"https://api.github.com/users/jyemin","html_url":"https://github.com/jyemin","followers_url":"https://api.github.com/users/jyemin/followers","following_url":"https://api.github.com/users/jyemin/following{/other_user}","gists_url":"https://api.github.com/users/jyemin/gists{/gist_id}","starred_url":"https://api.github.com/users/jyemin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jyemin/subscriptions","organizations_url":"https://api.github.com/users/jyemin/orgs","repos_url":"https://api.github.com/users/jyemin/repos","events_url":"https://api.github.com/users/jyemin/events{/privacy}","received_events_url":"https://api.github.com/users/jyemin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rozza/mongo-spark/pulls/33/commits","review_comments_url":"https://api.github.com/repos/rozza/mongo-spark/pulls/33/comments","review_comment_url":"https://api.github.com/repos/rozza/mongo-spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rozza/mongo-spark/issues/33/comments","statuses_url":"https://api.github.com/repos/rozza/mongo-spark/statuses/90eff3d7043e6df48888e549e83efa252259223c","head":{"label":"rozza:s206","ref":"s206","sha":"90eff3d7043e6df48888e549e83efa252259223c","user":{"login":"rozza","id":420,"node_id":"MDQ6VXNlcjQyMA==","avatar_url":"https://avatars0.githubusercontent.com/u/420?v=4","gravatar_id":"","url":"https://api.github.com/users/rozza","html_url":"https://github.com/rozza","followers_url":"https://api.github.com/users/rozza/followers","following_url":"https://api.github.com/users/rozza/following{/other_user}","gists_url":"https://api.github.com/users/rozza/gists{/gist_id}","starred_url":"https://api.github.com/users/rozza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rozza/subscriptions","organizations_url":"https://api.github.com/users/rozza/orgs","repos_url":"https://api.github.com/users/rozza/repos","events_url":"https://api.github.com/users/rozza/events{/privacy}","received_events_url":"https://api.github.com/users/rozza/received_events","type":"User","site_admin":false},"repo":{"id":46629106,"node_id":"MDEwOlJlcG9zaXRvcnk0NjYyOTEwNg==","name":"mongo-spark","full_name":"rozza/mongo-spark","owner":{"login":"rozza","id":420,"node_id":"MDQ6VXNlcjQyMA==","avatar_url":"https://avatars0.githubusercontent.com/u/420?v=4","gravatar_id":"","url":"https://api.github.com/users/rozza","html_url":"https://github.com/rozza","followers_url":"https://api.github.com/users/rozza/followers","following_url":"https://api.github.com/users/rozza/following{/other_user}","gists_url":"https://api.github.com/users/rozza/gists{/gist_id}","starred_url":"https://api.github.com/users/rozza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rozza/subscriptions","organizations_url":"https://api.github.com/users/rozza/orgs","repos_url":"https://api.github.com/users/rozza/repos","events_url":"https://api.github.com/users/rozza/events{/privacy}","received_events_url":"https://api.github.com/users/rozza/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rozza/mongo-spark","description":null,"fork":true,"url":"https://api.github.com/repos/rozza/mongo-spark","forks_url":"https://api.github.com/repos/rozza/mongo-spark/forks","keys_url":"https://api.github.com/repos/rozza/mongo-spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rozza/mongo-spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rozza/mongo-spark/teams","hooks_url":"https://api.github.com/repos/rozza/mongo-spark/hooks","issue_events_url":"https://api.github.com/repos/rozza/mongo-spark/issues/events{/number}","events_url":"https://api.github.com/repos/rozza/mongo-spark/events","assignees_url":"https://api.github.com/repos/rozza/mongo-spark/assignees{/user}","branches_url":"https://api.github.com/repos/rozza/mongo-spark/branches{/branch}","tags_url":"https://api.github.com/repos/rozza/mongo-spark/tags","blobs_url":"https://api.github.com/repos/rozza/mongo-spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rozza/mongo-spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rozza/mongo-spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/rozza/mongo-spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rozza/mongo-spark/statuses/{sha}","languages_url":"https://api.github.com/repos/rozza/mongo-spark/languages","stargazers_url":"https://api.github.com/repos/rozza/mongo-spark/stargazers","contributors_url":"https://api.github.com/repos/rozza/mongo-spark/contributors","subscribers_url":"https://api.github.com/repos/rozza/mongo-spark/subscribers","subscription_url":"https://api.github.com/repos/rozza/mongo-spark/subscription","commits_url":"https://api.github.com/repos/rozza/mongo-spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/rozza/mongo-spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/rozza/mongo-spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/rozza/mongo-spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/rozza/mongo-spark/contents/{+path}","compare_url":"https://api.github.com/repos/rozza/mongo-spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rozza/mongo-spark/merges","archive_url":"https://api.github.com/repos/rozza/mongo-spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rozza/mongo-spark/downloads","issues_url":"https://api.github.com/repos/rozza/mongo-spark/issues{/number}","pulls_url":"https://api.github.com/repos/rozza/mongo-spark/pulls{/number}","milestones_url":"https://api.github.com/repos/rozza/mongo-spark/milestones{/number}","notifications_url":"https://api.github.com/repos/rozza/mongo-spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rozza/mongo-spark/labels{/name}","releases_url":"https://api.github.com/repos/rozza/mongo-spark/releases{/id}","deployments_url":"https://api.github.com/repos/rozza/mongo-spark/deployments","created_at":"2015-11-21T18:59:05Z","updated_at":"2018-08-15T14:05:45Z","pushed_at":"2018-09-07T10:56:18Z","git_url":"git://github.com/rozza/mongo-spark.git","ssh_url":"git@github.com:rozza/mongo-spark.git","clone_url":"https://github.com/rozza/mongo-spark.git","svn_url":"https://github.com/rozza/mongo-spark","homepage":null,"size":1956,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"rozza:master","ref":"master","sha":"0b2089335624324389f0e481cf15e65b9082a554","user":{"login":"rozza","id":420,"node_id":"MDQ6VXNlcjQyMA==","avatar_url":"https://avatars0.githubusercontent.com/u/420?v=4","gravatar_id":"","url":"https://api.github.com/users/rozza","html_url":"https://github.com/rozza","followers_url":"https://api.github.com/users/rozza/followers","following_url":"https://api.github.com/users/rozza/following{/other_user}","gists_url":"https://api.github.com/users/rozza/gists{/gist_id}","starred_url":"https://api.github.com/users/rozza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rozza/subscriptions","organizations_url":"https://api.github.com/users/rozza/orgs","repos_url":"https://api.github.com/users/rozza/repos","events_url":"https://api.github.com/users/rozza/events{/privacy}","received_events_url":"https://api.github.com/users/rozza/received_events","type":"User","site_admin":false},"repo":{"id":46629106,"node_id":"MDEwOlJlcG9zaXRvcnk0NjYyOTEwNg==","name":"mongo-spark","full_name":"rozza/mongo-spark","owner":{"login":"rozza","id":420,"node_id":"MDQ6VXNlcjQyMA==","avatar_url":"https://avatars0.githubusercontent.com/u/420?v=4","gravatar_id":"","url":"https://api.github.com/users/rozza","html_url":"https://github.com/rozza","followers_url":"https://api.github.com/users/rozza/followers","following_url":"https://api.github.com/users/rozza/following{/other_user}","gists_url":"https://api.github.com/users/rozza/gists{/gist_id}","starred_url":"https://api.github.com/users/rozza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rozza/subscriptions","organizations_url":"https://api.github.com/users/rozza/orgs","repos_url":"https://api.github.com/users/rozza/repos","events_url":"https://api.github.com/users/rozza/events{/privacy}","received_events_url":"https://api.github.com/users/rozza/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rozza/mongo-spark","description":null,"fork":true,"url":"https://api.github.com/repos/rozza/mongo-spark","forks_url":"https://api.github.com/repos/rozza/mongo-spark/forks","keys_url":"https://api.github.com/repos/rozza/mongo-spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rozza/mongo-spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rozza/mongo-spark/teams","hooks_url":"https://api.github.com/repos/rozza/mongo-spark/hooks","issue_events_url":"https://api.github.com/repos/rozza/mongo-spark/issues/events{/number}","events_url":"https://api.github.com/repos/rozza/mongo-spark/events","assignees_url":"https://api.github.com/repos/rozza/mongo-spark/assignees{/user}","branches_url":"https://api.github.com/repos/rozza/mongo-spark/branches{/branch}","tags_url":"https://api.github.com/repos/rozza/mongo-spark/tags","blobs_url":"https://api.github.com/repos/rozza/mongo-spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rozza/mongo-spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rozza/mongo-spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/rozza/mongo-spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rozza/mongo-spark/statuses/{sha}","languages_url":"https://api.github.com/repos/rozza/mongo-spark/languages","stargazers_url":"https://api.github.com/repos/rozza/mongo-spark/stargazers","contributors_url":"https://api.github.com/repos/rozza/mongo-spark/contributors","subscribers_url":"https://api.github.com/repos/rozza/mongo-spark/subscribers","subscription_url":"https://api.github.com/repos/rozza/mongo-spark/subscription","commits_url":"https://api.github.com/repos/rozza/mongo-spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/rozza/mongo-spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/rozza/mongo-spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/rozza/mongo-spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/rozza/mongo-spark/contents/{+path}","compare_url":"https://api.github.com/repos/rozza/mongo-spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rozza/mongo-spark/merges","archive_url":"https://api.github.com/repos/rozza/mongo-spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rozza/mongo-spark/downloads","issues_url":"https://api.github.com/repos/rozza/mongo-spark/issues{/number}","pulls_url":"https://api.github.com/repos/rozza/mongo-spark/pulls{/number}","milestones_url":"https://api.github.com/repos/rozza/mongo-spark/milestones{/number}","notifications_url":"https://api.github.com/repos/rozza/mongo-spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rozza/mongo-spark/labels{/name}","releases_url":"https://api.github.com/repos/rozza/mongo-spark/releases{/id}","deployments_url":"https://api.github.com/repos/rozza/mongo-spark/deployments","created_at":"2015-11-21T18:59:05Z","updated_at":"2018-08-15T14:05:45Z","pushed_at":"2018-09-07T10:56:18Z","git_url":"git://github.com/rozza/mongo-spark.git","ssh_url":"git@github.com:rozza/mongo-spark.git","clone_url":"https://github.com/rozza/mongo-spark.git","svn_url":"https://github.com/rozza/mongo-spark","homepage":null,"size":1956,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rozza/mongo-spark/pulls/33"},"html":{"href":"https://github.com/rozza/mongo-spark/pull/33"},"issue":{"href":"https://api.github.com/repos/rozza/mongo-spark/issues/33"},"comments":{"href":"https://api.github.com/repos/rozza/mongo-spark/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/rozza/mongo-spark/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/rozza/mongo-spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rozza/mongo-spark/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/rozza/mongo-spark/statuses/90eff3d7043e6df48888e549e83efa252259223c"}},"author_association":"OWNER"}}
{"actor":{"display_login":"rozza"}}