{"action":"opened","issue":{"url":"https://api.github.com/repos/Netcentric/accesscontroltool/issues/275","repository_url":"https://api.github.com/repos/Netcentric/accesscontroltool","labels_url":"https://api.github.com/repos/Netcentric/accesscontroltool/issues/275/labels{/name}","comments_url":"https://api.github.com/repos/Netcentric/accesscontroltool/issues/275/comments","events_url":"https://api.github.com/repos/Netcentric/accesscontroltool/issues/275/events","html_url":"https://github.com/Netcentric/accesscontroltool/issues/275","id":313287948,"number":275,"title":"Check return value of Group.addMember and Group.removeMember and log error accordingly","user":{"login":"kwin","id":185025,"avatar_url":"https://avatars2.githubusercontent.com/u/185025?v=4","gravatar_id":"","url":"https://api.github.com/users/kwin","html_url":"https://github.com/kwin","followers_url":"https://api.github.com/users/kwin/followers","following_url":"https://api.github.com/users/kwin/following{/other_user}","gists_url":"https://api.github.com/users/kwin/gists{/gist_id}","starred_url":"https://api.github.com/users/kwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwin/subscriptions","organizations_url":"https://api.github.com/users/kwin/orgs","repos_url":"https://api.github.com/users/kwin/repos","events_url":"https://api.github.com/users/kwin/events{/privacy}","received_events_url":"https://api.github.com/users/kwin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-11T11:43:12Z","updated_at":"2018-04-11T11:43:12Z","closed_at":null,"author_association":"OWNER","body":"Currently a failure to add an authorizable as member to an existing group is not properly checked in code. The return value of https://github.com/Netcentric/accesscontroltool/blob/5dd1e91f668457d111f87780362ce49d8b36a3bc/accesscontroltool-bundle/src/main/java/biz/netcentric/cq/tools/actool/authorizableinstaller/impl/AuthorizableInstallerServiceImpl.java#L184 and https://github.com/Netcentric/accesscontroltool/blob/5dd1e91f668457d111f87780362ce49d8b36a3bc/accesscontroltool-bundle/src/main/java/biz/netcentric/cq/tools/actool/authorizableinstaller/impl/AuthorizableInstallerServiceImpl.java#L196 must be properly checked for the return value {{true}}. Otherwise at least a warning should be issued. \r\n\r\nThis is especially useful if someone is trying to add members to group \"everyone\" which is not supported (compare with https://issues.apache.org/jira/browse/OAK-7323)."}}
{"actor":{"display_login":"kwin"}}