{"action":"created","issue":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/12064","repository_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr","labels_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/12064/labels{/name}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/12064/comments","events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/12064/events","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/12064","id":390606946,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MzMyMzk5","number":12064,"title":"soc: nrf52: move DCDC enable option out of board options","user":{"login":"chris-makaio","id":26594889,"node_id":"MDQ6VXNlcjI2NTk0ODg5","avatar_url":"https://avatars2.githubusercontent.com/u/26594889?v=4","gravatar_id":"","url":"https://api.github.com/users/chris-makaio","html_url":"https://github.com/chris-makaio","followers_url":"https://api.github.com/users/chris-makaio/followers","following_url":"https://api.github.com/users/chris-makaio/following{/other_user}","gists_url":"https://api.github.com/users/chris-makaio/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-makaio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-makaio/subscriptions","organizations_url":"https://api.github.com/users/chris-makaio/orgs","repos_url":"https://api.github.com/users/chris-makaio/repos","events_url":"https://api.github.com/users/chris-makaio/events{/privacy}","received_events_url":"https://api.github.com/users/chris-makaio/received_events","type":"User","site_admin":false},"labels":[{"id":725894905,"node_id":"MDU6TGFiZWw3MjU4OTQ5MDU=","url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels/nRF","name":"nRF","color":"39a9db","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-12-13T10:12:37Z","updated_at":"2018-12-17T13:32:20Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/12064","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/12064","diff_url":"https://github.com/zephyrproject-rtos/zephyr/pull/12064.diff","patch_url":"https://github.com/zephyrproject-rtos/zephyr/pull/12064.patch"},"body":"Because enabling/disabling the DCDC regulator depends on nRF52 series SoC instead on any specific board, I suggest moving the option to Hardware Configuration instead.\r\nMakes some board files obsolete."},"comment":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/comments/447846387","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/12064#issuecomment-447846387","issue_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/12064","id":447846387,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Nzg0NjM4Nw==","user":{"login":"chris-makaio","id":26594889,"node_id":"MDQ6VXNlcjI2NTk0ODg5","avatar_url":"https://avatars2.githubusercontent.com/u/26594889?v=4","gravatar_id":"","url":"https://api.github.com/users/chris-makaio","html_url":"https://github.com/chris-makaio","followers_url":"https://api.github.com/users/chris-makaio/followers","following_url":"https://api.github.com/users/chris-makaio/following{/other_user}","gists_url":"https://api.github.com/users/chris-makaio/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-makaio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-makaio/subscriptions","organizations_url":"https://api.github.com/users/chris-makaio/orgs","repos_url":"https://api.github.com/users/chris-makaio/repos","events_url":"https://api.github.com/users/chris-makaio/events{/privacy}","received_events_url":"https://api.github.com/users/chris-makaio/received_events","type":"User","site_admin":false},"created_at":"2018-12-17T13:32:20Z","updated_at":"2018-12-17T13:32:20Z","author_association":"CONTRIBUTOR","body":"> And after moving the option to the SoC level, I don't see a point in keeping this hidden `SOC_DCDC_NRF52X` option and selecting it by this new one added. The new one should simply replace it.\r\n\r\nI don't know if it is less confusing now. \r\n```\r\nconfig SOC_NRF52X_HAS_DCDC_SUPPORT\r\n    default y\r\n```\r\n\r\nlooks strange in board's Kconfig.defconfig. Maybe use SOC_NRF52X_BOARD_HAS_DCDC_SUPPORT instead?"}}
{"actor":{"display_login":"chris-makaio"}}