{"action":"closed","issue":{"url":"https://api.github.com/repos/Vermonster/fhir-kit-client/issues/62","repository_url":"https://api.github.com/repos/Vermonster/fhir-kit-client","labels_url":"https://api.github.com/repos/Vermonster/fhir-kit-client/issues/62/labels{/name}","comments_url":"https://api.github.com/repos/Vermonster/fhir-kit-client/issues/62/comments","events_url":"https://api.github.com/repos/Vermonster/fhir-kit-client/issues/62/events","html_url":"https://github.com/Vermonster/fhir-kit-client/issues/62","id":344852381,"node_id":"MDU6SXNzdWUzNDQ4NTIzODE=","number":62,"title":"Documentation for the transaction feature","user":{"login":"davidballester","id":1730892,"node_id":"MDQ6VXNlcjE3MzA4OTI=","avatar_url":"https://avatars0.githubusercontent.com/u/1730892?v=4","gravatar_id":"","url":"https://api.github.com/users/davidballester","html_url":"https://github.com/davidballester","followers_url":"https://api.github.com/users/davidballester/followers","following_url":"https://api.github.com/users/davidballester/following{/other_user}","gists_url":"https://api.github.com/users/davidballester/gists{/gist_id}","starred_url":"https://api.github.com/users/davidballester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidballester/subscriptions","organizations_url":"https://api.github.com/users/davidballester/orgs","repos_url":"https://api.github.com/users/davidballester/repos","events_url":"https://api.github.com/users/davidballester/events{/privacy}","received_events_url":"https://api.github.com/users/davidballester/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-07-26T13:49:14Z","updated_at":"2018-07-31T12:08:03Z","closed_at":"2018-07-31T12:08:03Z","author_association":"CONTRIBUTOR","body":"## Expected Behavior\r\nThe [documentation examples for the transaction function](https://vermonster.github.io/fhir-kit-client/fhir-kit-client/0.3.1/module-fhir-kit-client-Client.html#transaction) should wrap the `requestBundle` into an object with a `body` property. Or even better, remove the need for such wrapping.\r\n\r\n```javascript\r\nconst requestBundle = {\r\n    ...\r\n};\r\n\r\nfhirClient.transaction({\r\n    body: requestBundle,\r\n});\r\n```\r\n\r\nAlso, the `params` argument states the `body` is of type `String`, but an object is accepted.\r\n\r\n## Actual Behavior\r\nThe transaction function requires an argument with a `body` property containing the transaction resource. However, the [documentation examples](https://vermonster.github.io/fhir-kit-client/fhir-kit-client/0.3.1/module-fhir-kit-client-Client.html#transaction) shows a `requestBundle` used directly as an argument.\r\n\r\n## Steps to Reproduce the Problem\r\n\r\n  1. [Documentation issue](https://vermonster.github.io/fhir-kit-client/fhir-kit-client/0.3.1/module-fhir-kit-client-Client.html#transaction)\r\n\r\n## Specifications\r\n\r\n  - Version: `0.3.1`\r\n  - Platform:\r\n  - Subsystem:\r\n"}}
{"actor":{"display_login":"Jammjammjamm"}}