{"push_id":2853146147,"size":3,"distinct_size":3,"ref":"refs/heads/master","head":"76365c6a090e157c9e3b046c55d9617eb9a153ec","before":"29a4a684af2525d78a1090fba2d3dea2b6a59fc7","commits":[{"sha":"469dd659a517eac9b5691140b1dfa400e6dd269b","author":{"name":"Greg Daniel","email":"39df0a804564ccb6cf75f18db79653821f37c1c5@google.com"},"message":"On GrAHardwareBufferImageGenerator store the owned texture as a GrGpuResource instead of GrTexture.\n\nDisassembly before change (crash on deref at  861310)\n_ZN31GrAHardwareBufferImageGenerator17releaseTextureRefEv():\n 861297 external/skia/src/gpu/GrAHardwareBufferImageGenerator.cpp:112\n 861298   1eb738:       91010280        add     x0, x20, #0x40\n 861299   1eb73c:       aa1f03e1        mov     x1, xzr\n 861300   1eb740:       97fc287c        bl      f5930 <_ZN5sk_spI14GrTextureProxyE5resetEPS0_>\n 861301 external/skia/src/gpu/GrAHardwareBufferImageGenerator.cpp:113\n 861302   1eb744:       f9401a88        ldr     x8, [x20,#48]\n 861303   1eb748:       b4000168        cbz     x8, 1eb774 <_ZN31GrAHardwareBufferImageGenerator17onGenerateTextureEP9GrContextRK11SkImageInfoRK8SkIPointb+0xac>\n 861304 external/skia/src/gpu/GrAHardwareBufferImageGenerator.cpp:117\n 861305   1eb74c:       f9400109        ldr     x9, [x8]\n 861306 external/skia/src/gpu/GrAHardwareBufferImageGenerator.cpp:118\n 861307   1eb750:       9101c3e0        add     x0, sp, #0x70\n 861308 external/skia/src/gpu/GrAHardwareBufferImageGenerator.cpp:117\n 861309   1eb754:       b9403a8a        ldr     w10, [x20,#56]\n 861310   1eb758:       f85e8129        ldur    x9, [x9,#-24]\n 861311   1eb75c:       b9007bea        str     w10, [sp,#120]\n 861312   1eb760:       8b090108        add     x8, x8, x9\n 861313   1eb764:       f9003be8        str     x8, [sp,#112]\n 861314 external/skia/src/gpu/GrAHardwareBufferImageGenerator.cpp:118\n 861315   1eb768:       97fffef6        bl      1eb340 <_ZN12SkMessageBusI25GrGpuResourceFreedMessageE4PostERKS0_>\n 861316 external/skia/src/gpu/GrAHardwareBufferImageGenerator.cpp:119\n 861317   1eb76c:       f9001a9f        str     xzr, [x20,#48]\n 861318 external/skia/src/gpu/GrAHardwareBufferImageGenerator.cpp:120\n 861319   1eb770:       b9003a9f        str     wzr, [x20,#56]\n\nDisassembly with change (no more derefs):\n 768904 _ZN31GrAHardwareBufferImageGenerator17releaseTextureRefEv():\n 768905 external/skia/src/gpu/GrAHardwareBufferImageGenerator.cpp:105\n 768906   1b0c94:       91010260        add     x0, x19, #0x40\n 768907   1b0c98:       aa1f03e1        mov     x1, xzr\n 768908   1b0c9c:       97fcb2a9        bl      dd740 <_ZN5sk_spI14GrTextureProxyE5resetEPS0_>\n 768909 external/skia/src/gpu/GrAHardwareBufferImageGenerator.cpp:106\n 768910   1b0ca0:       f9401a68        ldr     x8, [x19,#48]\n 768911   1b0ca4:       b4000108        cbz     x8, 1b0cc4 <_ZN31GrAHardwareBufferImageGenerator9makeProxyEP9GrContext+0x84>\n 768912 external/skia/src/gpu/GrAHardwareBufferImageGenerator.cpp:110\n 768913   1b0ca8:       b9403a69        ldr     w9, [x19,#56]\n 768914 external/skia/src/gpu/GrAHardwareBufferImageGenerator.cpp:111\n 768915   1b0cac:       9100c3e0        add     x0, sp, #0x30\n 768916 external/skia/src/gpu/GrAHardwareBufferImageGenerator.cpp:110\n 768917   1b0cb0:       f9001be8        str     x8, [sp,#48]\n 768918   1b0cb4:       b9003be9        str     w9, [sp,#56]\n\nBug: b/112859199\nChange-Id: I5afab9b2bc6a3c13d2606ac9e09fb55929a14426\nReviewed-on: https://skia-review.googlesource.com/151822\nCommit-Queue: Greg Daniel <egdaniel@google.com>\nReviewed-by: Mike Klein <mtklein@google.com>","distinct":true,"url":"https://api.github.com/repos/google/skia/commits/469dd659a517eac9b5691140b1dfa400e6dd269b"},{"sha":"a24712e4dc5bf1bf676d997ef7405891cbddffb0","author":{"name":"Cary Clark","email":"52792aa984ff6c4e9c802c7fa3093ed6a52a791f@google.com"},"message":"Revert \"makeSurface defaults to raster\"\n\nThis reverts commit 29a4a684af2525d78a1090fba2d3dea2b6a59fc7.\n\nReason for revert: some configs fail\n\nOriginal change's description:\n> makeSurface defaults to raster\n> \n> Rather that returning nullptr for a recording\n> canvas, return a raster canvas instead.\n> \n> R=​reed@google.com,robertphillips@google.com\n> \n> Bug: skia:\n> Change-Id: I211d8ef368b9aec6d14cc72d1652ac6a03f3fa7b\n> Reviewed-on: https://skia-review.googlesource.com/151666\n> Commit-Queue: Cary Clark <caryclark@skia.org>\n> Reviewed-by: Robert Phillips <robertphillips@google.com>\n\nTBR=robertphillips@google.com,reed@google.com,caryclark@skia.org\n\nChange-Id: I82d2c3e4589a2ca8523bbf86884ed68b1431631d\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nBug: skia:\nReviewed-on: https://skia-review.googlesource.com/151824\nReviewed-by: Cary Clark <caryclark@google.com>\nCommit-Queue: Cary Clark <caryclark@google.com>","distinct":true,"url":"https://api.github.com/repos/google/skia/commits/a24712e4dc5bf1bf676d997ef7405891cbddffb0"},{"sha":"76365c6a090e157c9e3b046c55d9617eb9a153ec","author":{"name":"skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","email":"c65d8a490512a5928f46d287763ad97df6d3a1b8@skia-buildbots.google.com.iam.gserviceaccount.com"},"message":"Roll skia/third_party/skcms 8a251fa55434..da4870efd7b7 (1 commits)\n\nhttps://skia.googlesource.com/skcms.git/+log/8a251fa55434..da4870efd7b7\n\n2018-09-05 mtklein@chromium.org another profile that reproduces this bug\n\n\nThe AutoRoll server is located here: https://autoroll.skia.org/r/skcms-skia-autoroll\n\nDocumentation for the AutoRoller is here:\nhttps://skia.googlesource.com/buildbot/+/master/autoroll/README.md\n\nIf the roll is causing failures, please contact the current sheriff, who should\nbe CC'd on the roll, and stop the roller if necessary.\n\n\n\nCQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel\nTBR=jvanverth@google.com\n\nChange-Id: Ie76e46dd5afa54724a4d8ccf297e03cb14b5402c\nReviewed-on: https://skia-review.googlesource.com/151920\nCommit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>\nReviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>","distinct":true,"url":"https://api.github.com/repos/google/skia/commits/76365c6a090e157c9e3b046c55d9617eb9a153ec"}]}
{"actor":{"display_login":"hubot"}}