{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-superset/pulls/comments/223769142","pull_request_review_id":162970469,"id":223769142,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzc2OTE0Mg==","diff_hunk":"@@ -29,20 +31,22 @@ services:\n       POSTGRES_PORT: 5432\n       REDIS_HOST: redis\n       REDIS_PORT: 6379\n-      SUPERSET_ENV: local\n+      # If using production, comment development volume below\n+      SUPERSET_ENV: development\n     ports:\n       - 8088:8088\n-    command: \"tail -f /dev/null\"\n     depends_on:\n       - postgres\n       - redis\n     volumes:\n-      - .:/home/work/incubator-superset\n-      - superset-node-modules:/home/work/incubator-superset/superset/assets/node_modules\n+      # this is needed to communicate with the postgres and redis services\n+      - ./superset_config.py:/home/work/incubator-superset/superset/superset_config.py\n+      # this is needed for development, remove with SUPERSET_ENV=production\n+      - ../../superset:/home/work/incubator-superset/superset\n volumes:\n   postgres:\n     external: false\n   redis:\n     external: false\n-  superset-node-modules:\n+  frontend-dist:","path":"contrib/docker/docker-compose.yml","position":56,"original_position":56,"commit_id":"8ac8229eab6004fbcd761a087f41bdbf42b23597","original_commit_id":"8ac8229eab6004fbcd761a087f41bdbf42b23597","user":{"login":"xiaohanyu","id":1164623,"node_id":"MDQ6VXNlcjExNjQ2MjM=","avatar_url":"https://avatars0.githubusercontent.com/u/1164623?v=4","gravatar_id":"","url":"https://api.github.com/users/xiaohanyu","html_url":"https://github.com/xiaohanyu","followers_url":"https://api.github.com/users/xiaohanyu/followers","following_url":"https://api.github.com/users/xiaohanyu/following{/other_user}","gists_url":"https://api.github.com/users/xiaohanyu/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaohanyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaohanyu/subscriptions","organizations_url":"https://api.github.com/users/xiaohanyu/orgs","repos_url":"https://api.github.com/users/xiaohanyu/repos","events_url":"https://api.github.com/users/xiaohanyu/events{/privacy}","received_events_url":"https://api.github.com/users/xiaohanyu/received_events","type":"User","site_admin":false},"body":"So after you rename to `frontend-dist`, where's `frontend-dist` volume? it will be empty?","created_at":"2018-10-09T16:15:36Z","updated_at":"2018-10-09T16:17:24Z","html_url":"https://github.com/apache/incubator-superset/pull/5966#discussion_r223769142","pull_request_url":"https://api.github.com/repos/apache/incubator-superset/pulls/5966","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-superset/pulls/comments/223769142"},"html":{"href":"https://github.com/apache/incubator-superset/pull/5966#discussion_r223769142"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-superset/pulls/5966"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-superset/pulls/5966","id":217634856,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NjM0ODU2","html_url":"https://github.com/apache/incubator-superset/pull/5966","diff_url":"https://github.com/apache/incubator-superset/pull/5966.diff","patch_url":"https://github.com/apache/incubator-superset/pull/5966.patch","issue_url":"https://api.github.com/repos/apache/incubator-superset/issues/5966","number":5966,"state":"open","locked":false,"title":"Improve development experience with Docker","user":{"login":"victornoel","id":160975,"node_id":"MDQ6VXNlcjE2MDk3NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/160975?v=4","gravatar_id":"","url":"https://api.github.com/users/victornoel","html_url":"https://github.com/victornoel","followers_url":"https://api.github.com/users/victornoel/followers","following_url":"https://api.github.com/users/victornoel/following{/other_user}","gists_url":"https://api.github.com/users/victornoel/gists{/gist_id}","starred_url":"https://api.github.com/users/victornoel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victornoel/subscriptions","organizations_url":"https://api.github.com/users/victornoel/orgs","repos_url":"https://api.github.com/users/victornoel/repos","events_url":"https://api.github.com/users/victornoel/events{/privacy}","received_events_url":"https://api.github.com/users/victornoel/received_events","type":"User","site_admin":false},"body":"- Improve Docker image\r\n  - smaller\r\n  - faster to build\r\n  - deterministic dependencies (see #5958)\r\n- Rework process to simplify setting things up\r\n  - updated documentation\r\n  - less commands to type\r\n  - no files to move and modify\r\n  - optional loading of samples\r\n- Still working in standalone mode (without volumes for superset)\r\n\r\nThis should close #5987 too","created_at":"2018-09-24T12:09:48Z","updated_at":"2018-10-09T16:17:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fac15af1dba81fcc464f5eb1f53a7120d0f9a3cf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-superset/pulls/5966/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-superset/pulls/5966/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-superset/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-superset/issues/5966/comments","statuses_url":"https://api.github.com/repos/apache/incubator-superset/statuses/8ac8229eab6004fbcd761a087f41bdbf42b23597","head":{"label":"victornoel:improve-docker-experience","ref":"improve-docker-experience","sha":"8ac8229eab6004fbcd761a087f41bdbf42b23597","user":{"login":"victornoel","id":160975,"node_id":"MDQ6VXNlcjE2MDk3NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/160975?v=4","gravatar_id":"","url":"https://api.github.com/users/victornoel","html_url":"https://github.com/victornoel","followers_url":"https://api.github.com/users/victornoel/followers","following_url":"https://api.github.com/users/victornoel/following{/other_user}","gists_url":"https://api.github.com/users/victornoel/gists{/gist_id}","starred_url":"https://api.github.com/users/victornoel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victornoel/subscriptions","organizations_url":"https://api.github.com/users/victornoel/orgs","repos_url":"https://api.github.com/users/victornoel/repos","events_url":"https://api.github.com/users/victornoel/events{/privacy}","received_events_url":"https://api.github.com/users/victornoel/received_events","type":"User","site_admin":false},"repo":{"id":150075878,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAwNzU4Nzg=","name":"incubator-superset","full_name":"victornoel/incubator-superset","private":false,"owner":{"login":"victornoel","id":160975,"node_id":"MDQ6VXNlcjE2MDk3NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/160975?v=4","gravatar_id":"","url":"https://api.github.com/users/victornoel","html_url":"https://github.com/victornoel","followers_url":"https://api.github.com/users/victornoel/followers","following_url":"https://api.github.com/users/victornoel/following{/other_user}","gists_url":"https://api.github.com/users/victornoel/gists{/gist_id}","starred_url":"https://api.github.com/users/victornoel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victornoel/subscriptions","organizations_url":"https://api.github.com/users/victornoel/orgs","repos_url":"https://api.github.com/users/victornoel/repos","events_url":"https://api.github.com/users/victornoel/events{/privacy}","received_events_url":"https://api.github.com/users/victornoel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/victornoel/incubator-superset","description":"Apache Superset (incubating) is a modern, enterprise-ready business intelligence web application","fork":true,"url":"https://api.github.com/repos/victornoel/incubator-superset","forks_url":"https://api.github.com/repos/victornoel/incubator-superset/forks","keys_url":"https://api.github.com/repos/victornoel/incubator-superset/keys{/key_id}","collaborators_url":"https://api.github.com/repos/victornoel/incubator-superset/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/victornoel/incubator-superset/teams","hooks_url":"https://api.github.com/repos/victornoel/incubator-superset/hooks","issue_events_url":"https://api.github.com/repos/victornoel/incubator-superset/issues/events{/number}","events_url":"https://api.github.com/repos/victornoel/incubator-superset/events","assignees_url":"https://api.github.com/repos/victornoel/incubator-superset/assignees{/user}","branches_url":"https://api.github.com/repos/victornoel/incubator-superset/branches{/branch}","tags_url":"https://api.github.com/repos/victornoel/incubator-superset/tags","blobs_url":"https://api.github.com/repos/victornoel/incubator-superset/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/victornoel/incubator-superset/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/victornoel/incubator-superset/git/refs{/sha}","trees_url":"https://api.github.com/repos/victornoel/incubator-superset/git/trees{/sha}","statuses_url":"https://api.github.com/repos/victornoel/incubator-superset/statuses/{sha}","languages_url":"https://api.github.com/repos/victornoel/incubator-superset/languages","stargazers_url":"https://api.github.com/repos/victornoel/incubator-superset/stargazers","contributors_url":"https://api.github.com/repos/victornoel/incubator-superset/contributors","subscribers_url":"https://api.github.com/repos/victornoel/incubator-superset/subscribers","subscription_url":"https://api.github.com/repos/victornoel/incubator-superset/subscription","commits_url":"https://api.github.com/repos/victornoel/incubator-superset/commits{/sha}","git_commits_url":"https://api.github.com/repos/victornoel/incubator-superset/git/commits{/sha}","comments_url":"https://api.github.com/repos/victornoel/incubator-superset/comments{/number}","issue_comment_url":"https://api.github.com/repos/victornoel/incubator-superset/issues/comments{/number}","contents_url":"https://api.github.com/repos/victornoel/incubator-superset/contents/{+path}","compare_url":"https://api.github.com/repos/victornoel/incubator-superset/compare/{base}...{head}","merges_url":"https://api.github.com/repos/victornoel/incubator-superset/merges","archive_url":"https://api.github.com/repos/victornoel/incubator-superset/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/victornoel/incubator-superset/downloads","issues_url":"https://api.github.com/repos/victornoel/incubator-superset/issues{/number}","pulls_url":"https://api.github.com/repos/victornoel/incubator-superset/pulls{/number}","milestones_url":"https://api.github.com/repos/victornoel/incubator-superset/milestones{/number}","notifications_url":"https://api.github.com/repos/victornoel/incubator-superset/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/victornoel/incubator-superset/labels{/name}","releases_url":"https://api.github.com/repos/victornoel/incubator-superset/releases{/id}","deployments_url":"https://api.github.com/repos/victornoel/incubator-superset/deployments","created_at":"2018-09-24T08:48:53Z","updated_at":"2018-09-24T08:48:59Z","pushed_at":"2018-10-09T07:20:20Z","git_url":"git://github.com/victornoel/incubator-superset.git","ssh_url":"git@github.com:victornoel/incubator-superset.git","clone_url":"https://github.com/victornoel/incubator-superset.git","svn_url":"https://github.com/victornoel/incubator-superset","homepage":"","size":93620,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"361f588b71c67c0482b07b70ca745d9ef274291f","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":39464018,"node_id":"MDEwOlJlcG9zaXRvcnkzOTQ2NDAxOA==","name":"incubator-superset","full_name":"apache/incubator-superset","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/incubator-superset","description":"Apache Superset (incubating) is a modern, enterprise-ready business intelligence web application","fork":false,"url":"https://api.github.com/repos/apache/incubator-superset","forks_url":"https://api.github.com/repos/apache/incubator-superset/forks","keys_url":"https://api.github.com/repos/apache/incubator-superset/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-superset/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-superset/teams","hooks_url":"https://api.github.com/repos/apache/incubator-superset/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-superset/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-superset/events","assignees_url":"https://api.github.com/repos/apache/incubator-superset/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-superset/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-superset/tags","blobs_url":"https://api.github.com/repos/apache/incubator-superset/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-superset/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-superset/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-superset/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-superset/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-superset/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-superset/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-superset/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-superset/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-superset/subscription","commits_url":"https://api.github.com/repos/apache/incubator-superset/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-superset/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-superset/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-superset/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-superset/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-superset/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-superset/merges","archive_url":"https://api.github.com/repos/apache/incubator-superset/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-superset/downloads","issues_url":"https://api.github.com/repos/apache/incubator-superset/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-superset/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-superset/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-superset/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-superset/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-superset/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-superset/deployments","created_at":"2015-07-21T18:55:34Z","updated_at":"2018-10-09T15:07:37Z","pushed_at":"2018-10-09T08:11:35Z","git_url":"git://github.com/apache/incubator-superset.git","ssh_url":"git@github.com:apache/incubator-superset.git","clone_url":"https://github.com/apache/incubator-superset.git","svn_url":"https://github.com/apache/incubator-superset","homepage":"","size":93637,"stargazers_count":20999,"watchers_count":20999,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3747,"mirror_url":null,"archived":false,"open_issues_count":1001,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3747,"open_issues":1001,"watchers":20999,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-superset/pulls/5966"},"html":{"href":"https://github.com/apache/incubator-superset/pull/5966"},"issue":{"href":"https://api.github.com/repos/apache/incubator-superset/issues/5966"},"comments":{"href":"https://api.github.com/repos/apache/incubator-superset/issues/5966/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-superset/pulls/5966/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-superset/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-superset/pulls/5966/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-superset/statuses/8ac8229eab6004fbcd761a087f41bdbf42b23597"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"xiaohanyu"}}