{"push_id":2918258992,"size":17,"distinct_size":7,"ref":"refs/heads/prefix-pull-secret-error","head":"3ab0f7df6a09cd02e9aeb7950e5f2c54fa0517c0","before":"13dfc10b40f49c03500879c883081719917bbc12","commits":[{"sha":"af38d82f3daab607d8aa520b985536834c2431cc","author":{"name":"W. Trevor King","email":"f75897670c17327c42ab201733fb8a81ff9f4c34@tremily.us"},"message":"pkg/asset: Switch from github.com -> gopkg.in for survey\n\nThis is the recommended import URI [1].  And survey's internal imports\nuse the gopkg.in form, so we're already vendoring it; this change will\nlet us drop the redundant github.com copies.\n\nThe explicit package name is not strictly necessary, but I like to set\nit when the final segment of the import URL does not match the package\nname declared within the imported package.\n\n[1]: https://github.com/AlecAivazis/survey/tree/v1.6.2#versioning","distinct":false,"url":"https://api.github.com/repos/wking/openshift-installer/commits/af38d82f3daab607d8aa520b985536834c2431cc"},{"sha":"101007712953e576bd919800bb56b8a4d29e670a","author":{"name":"W. Trevor King","email":"f75897670c17327c42ab201733fb8a81ff9f4c34@tremily.us"},"message":"vendor: Drop github.com/AlecAivazis/survey\n\nGenerated with:\n\n  $ glide remove github.com/AlecAivazis/survey\n  $ glide get --strip-vendor gopkg.in/AlecAivazis/survey\n  [INFO]Preparing to install 1 package.\n  [INFO]Attempting to get package gopkg.in/AlecAivazis/survey.v1\n  [INFO]--> Gathering release information for gopkg.in/AlecAivazis/survey.v1\n  [INFO]The package gopkg.in/AlecAivazis/survey.v1 appears to have Semantic Version releases (http://semver.org).\n  [INFO]The latest release is v1.6.2. You are currently not using a release. Would you like\n  [INFO]to use this release? Yes (Y) or No (N)\n  y\n  [INFO]The package gopkg.in/AlecAivazis/survey.v1 appears to use semantic versions (http://semver.org).\n  [INFO]Would you like to track the latest minor or patch releases (major.minor.patch)?\n  [INFO]The choices are:\n  [INFO] - Tracking minor version releases would use '>= 1.6.2, < 2.0.0' ('^1.6.2')\n  [INFO] - Tracking patch version releases would use '>= 1.6.2, < 1.7.0' ('~1.6.2')\n  [INFO] - Skip using ranges\n  [INFO]For more information on Glide versions and ranges see https://glide.sh/docs/versions\n  [INFO]Minor (M), Patch (P), or Skip Ranges (S)?\n  m\n  [INFO]--> Adding gopkg.in/AlecAivazis/survey.v1 to your configuration with the version ^1.6.2\n  ...\n  $ glide-vc --use-lock-file --no-tests --only-code\n  $ git checkout HEAD -- vendor/github.com/shurcooL/httpfs\n\nusing:\n\n  $ glide --version\n  glide version 0.13.2-dev\n  $ (cd $GOPATH/src/github.com/Masterminds/glide && git describe)\n  v0.13.1-7-g3e13fd1\n  $ (cd $GOPATH/src/github.com/sgotti/glide-vc && git describe)\n  v0.1.0-2-g6ddf6ee\n\nThe httpfs works around our busted vfsutil vendor, see\na8cce08b (vendor: Add shurcooL/httpfs/vfsutil, 2018-09-26, #340).\n\nThe formatting change unwinds ff9e5479 (*: format all yaml files,\n2018-09-27, #342), but it doesn't seem to be worth fighting Glide on\nthis front.","distinct":false,"url":"https://api.github.com/repos/wking/openshift-installer/commits/101007712953e576bd919800bb56b8a4d29e670a"},{"sha":"e761ad593dc632d04b73876224e0f8bb87776dd9","author":{"name":"W. Trevor King","email":"f75897670c17327c42ab201733fb8a81ff9f4c34@tremily.us"},"message":".bazelrc: Drop this orphaned file\n\nCatching up with 0c6d53b7 (*: remove bazel, 2018-09-24, #342).","distinct":false,"url":"https://api.github.com/repos/wking/openshift-installer/commits/e761ad593dc632d04b73876224e0f8bb87776dd9"},{"sha":"8ff1cee1ce799d1e8ae149a93aa615d31427059b","author":{"name":"W. Trevor King","email":"f75897670c17327c42ab201733fb8a81ff9f4c34@tremily.us"},"message":"hack/yaml-lint: No-op this script\n\nTemporarily make the script a no-op while we work out whether we want\nto keep this.  It's currently complaining about the YAML output from\nGlide in the previous commit [1]:\n\n  ./glide.yaml\n    1:1       warning  missing document start \"---\"  (document-start)\n    3:1       error    wrong indentation: expected 2 but found 0  (indentation)\n    5:1       error    wrong indentation: expected 2 but found 0  (indentation)\n    38:1      error    wrong indentation: expected 2 but found 0  (indentation)\n\nDropping the script entirely would break CI [2].  Alex is ok dropping\nyamllint entirely, but I'm half-interested in keeping it around in\ncase we decide to move any static YAML assets\n(e.g. pkg/asset/manifests/content/tectonic/rbac/role-user.go) over\ninto data/data.\n\n[1]: https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_installer/370/pull-ci-openshift-installer-yaml-lint/636/build-log.txt\n[2]: https://github.com/openshift/release/blob/d7ea5b36da63140fbb99c293aadde3bb279a24f9/ci-operator/jobs/openshift/installer/openshift-installer-master-presubmits.yaml#L354","distinct":false,"url":"https://api.github.com/repos/wking/openshift-installer/commits/8ff1cee1ce799d1e8ae149a93aa615d31427059b"},{"sha":"d91003130d3c2d0af6a3818652270e3803fdca73","author":{"name":"W. Trevor King","email":"f75897670c17327c42ab201733fb8a81ff9f4c34@tremily.us"},"message":"data/data/*/inputs: Drop terraform_remote_state\n\nWe used to use this for passing asset state from the assets step to\nthe infra step.  But the new installer performs all asset generation\nin Go with a single Terraform step (e.g. see df14588e, *: Drop\nTerraform steps, 2018-09-27, #362).  So we'll alwayshave\nvar.ignition_bootstrap set and we can just use it directly.","distinct":false,"url":"https://api.github.com/repos/wking/openshift-installer/commits/d91003130d3c2d0af6a3818652270e3803fdca73"},{"sha":"742032460ae43264af6b9acd7721dab1bc5bbe11","author":{"name":"Abhinav Dahiya","email":"ad54ca27e8b944513678e39e73d2961e1500272d@redhat.com"},"message":"installconfig: libvirt image prompt\n\nAdd prompt for libvirt image, no change in default.","distinct":false,"url":"https://api.github.com/repos/wking/openshift-installer/commits/742032460ae43264af6b9acd7721dab1bc5bbe11"},{"sha":"7668f9062db6fe9fcfd45e18b153ee3df368d910","author":{"name":"Abhinav Dahiya","email":"ad54ca27e8b944513678e39e73d2961e1500272d@redhat.com"},"message":"docs/user: add 'OPENSHIFT_INSTALL_LIBVIRT_IMAGE' env for libvirt","distinct":false,"url":"https://api.github.com/repos/wking/openshift-installer/commits/7668f9062db6fe9fcfd45e18b153ee3df368d910"},{"sha":"0284d4e9a099dd131b2730c61cc0ac3876907290","author":{"name":"OpenShift Merge Robot","email":"dd8cc73a9fcbc4f2f987fe818c87bd17f8347a2c@users.noreply.github.com"},"message":"Merge pull request #372 from abhinavdahiya/libvirt_image\n\ninstallconfig: libvirt image prompt","distinct":false,"url":"https://api.github.com/repos/wking/openshift-installer/commits/0284d4e9a099dd131b2730c61cc0ac3876907290"},{"sha":"f47c5955250b6d295ec573e110038c22d0c38cef","author":{"name":"Abhinav Dahiya","email":"ad54ca27e8b944513678e39e73d2961e1500272d@redhat.com"},"message":"fixes missed in PR #372","distinct":true,"url":"https://api.github.com/repos/wking/openshift-installer/commits/f47c5955250b6d295ec573e110038c22d0c38cef"},{"sha":"0a177f887ab8a4873598a93eba57bcdf14045d64","author":{"name":"Abhinav Dahiya","email":"ad54ca27e8b944513678e39e73d2961e1500272d@redhat.com"},"message":"userprovided: change AskOne to Ask as it doesn't run Transform\n\nhttps://github.com/AlecAivazis/survey/blob/f30c5d1830c892f533140f29a1de89141dc217f5/survey.go#L88-L95\n```go\nfunc AskOne(p Prompt, response interface{}, v Validator, opts ...AskOpt) error {\n\terr := Ask([]*Question{{Prompt: p, Validate: v}}, response, opts...)\n\tif err != nil {\n\t\treturn err\n\t}\n\n\treturn nil\n}\n```\nAskOne was not passing Transform. This would cause error reading region for aws\n```console\nFATA[0023] failed to generate asset: failed to generate asset \"Machine API Operator\": failed to lookup\n           RHCOS AMI: InvalidEndpointURL: invalid endpoint uri\ncaused by: parse https://ec2.us-east-1 (N. Virginia).amazonaws.com/: invalid character \" \" in host name\n```","distinct":true,"url":"https://api.github.com/repos/wking/openshift-installer/commits/0a177f887ab8a4873598a93eba57bcdf14045d64"},{"sha":"b562fa3c665897f77aa5b6a00f096ab134e9d73d","author":{"name":"W. Trevor King","email":"f75897670c17327c42ab201733fb8a81ff9f4c34@tremily.us"},"message":"vendor: Bump hive to a050d77562a1ae37fc2358e047edef10623fc6f7\n\nI updated the import path to keep up with\nopenshift/hive@ae569e39 (Add make verify target, 2018-09-24,\nopenshift/hive#13).  Then I bumped vendor/ with:\n\n  $ rm -rf ~/.glide/cache/info/https-github.com-openshift-hive.json ~/.glide/cache/src/https-github.com-openshift-hive/\n  $ glide remove github.com/openshift/hive\n  $ glide get --strip-vendor github.com/openshift/hive\n  $ glide-vc --use-lock-file --no-tests --only-code\n  $ git checkout HEAD -- vendor/github.com/shurcooL/httpfs\n\nusing:\n\n  $ glide --version\n  glide version 0.13.2-dev\n  $ (cd $GOPATH/src/github.com/Masterminds/glide && git describe)\n  v0.13.1-7-g3e13fd1\n  $ (cd $GOPATH/src/github.com/sgotti/glide-vc && git describe)\n  v0.1.0-2-g6ddf6ee\n\nI don't\tknow why I needed to clear my cache, but without that\nline the remaining commands didn't bump\nvendor/github.com/openshift/hive to its current master.\n\nBumping to openshift/hive@a050d775 (Merge pull request\nopenshift/hive#28 from wking/tag-20-load-balancers-per-request,\n2018-09-28) gives us more reliable load-balancer deletion.","distinct":false,"url":"https://api.github.com/repos/wking/openshift-installer/commits/b562fa3c665897f77aa5b6a00f096ab134e9d73d"},{"sha":"80ab28da390e069430f7de94f25aa7f280230ac2","author":{"name":"OpenShift Merge Robot","email":"dd8cc73a9fcbc4f2f987fe818c87bd17f8347a2c@users.noreply.github.com"},"message":"Merge pull request #379 from wking/hive-bump\n\nvendor: Bump hive to a050d77562a1ae37fc2358e047edef10623fc6f7","distinct":false,"url":"https://api.github.com/repos/wking/openshift-installer/commits/80ab28da390e069430f7de94f25aa7f280230ac2"},{"sha":"b6ade2b7dda314c9511a152c798a6fe1de1bc028","author":{"name":"OpenShift Merge Robot","email":"dd8cc73a9fcbc4f2f987fe818c87bd17f8347a2c@users.noreply.github.com"},"message":"Merge pull request #373 from wking/drop-terraform-remote-state\n\ndata/data/*/inputs: Drop terraform_remote_state","distinct":true,"url":"https://api.github.com/repos/wking/openshift-installer/commits/b6ade2b7dda314c9511a152c798a6fe1de1bc028"},{"sha":"877227491f6c1ed8f97bb5d91b98ceae44eef83a","author":{"name":"OpenShift Merge Robot","email":"dd8cc73a9fcbc4f2f987fe818c87bd17f8347a2c@users.noreply.github.com"},"message":"Merge pull request #378 from abhinavdahiya/fix_transform\n\nuserprovided: change AskOne to Ask as it doesn't run Transform","distinct":true,"url":"https://api.github.com/repos/wking/openshift-installer/commits/877227491f6c1ed8f97bb5d91b98ceae44eef83a"},{"sha":"3b68ffb7861e5b7de6527112596c2e22b56bab1a","author":{"name":"OpenShift Merge Robot","email":"dd8cc73a9fcbc4f2f987fe818c87bd17f8347a2c@users.noreply.github.com"},"message":"Merge pull request #376 from abhinavdahiya/libvirt_image\n\nfixes missed in PR #372","distinct":true,"url":"https://api.github.com/repos/wking/openshift-installer/commits/3b68ffb7861e5b7de6527112596c2e22b56bab1a"},{"sha":"d601e94b91d74549537536657cc3e406888538eb","author":{"name":"OpenShift Merge Robot","email":"dd8cc73a9fcbc4f2f987fe818c87bd17f8347a2c@users.noreply.github.com"},"message":"Merge pull request #371 from wking/drop-.bazelrc\n\n.bazelrc: Drop this orphaned file","distinct":true,"url":"https://api.github.com/repos/wking/openshift-installer/commits/d601e94b91d74549537536657cc3e406888538eb"},{"sha":"3ab0f7df6a09cd02e9aeb7950e5f2c54fa0517c0","author":{"name":"W. Trevor King","email":"f75897670c17327c42ab201733fb8a81ff9f4c34@tremily.us"},"message":"pkg/types/config: Prefix \"pull secret\" in validatePullSecret\n\nTo match a lot of other error handling in this package and give more\nuseful error messages (if we somehow get past the input validation in\npkg/asset/installconfig).","distinct":true,"url":"https://api.github.com/repos/wking/openshift-installer/commits/3ab0f7df6a09cd02e9aeb7950e5f2c54fa0517c0"}]}
{"actor":{"display_login":"wking"}}