{"action":"closed","number":10,"pull_request":{"url":"https://api.github.com/repos/discourse/prometheus_exporter/pulls/10","id":172831942,"html_url":"https://github.com/discourse/prometheus_exporter/pull/10","diff_url":"https://github.com/discourse/prometheus_exporter/pull/10.diff","patch_url":"https://github.com/discourse/prometheus_exporter/pull/10.patch","issue_url":"https://api.github.com/repos/discourse/prometheus_exporter/issues/10","number":10,"state":"closed","locked":false,"title":"Instrument http_queue_duration_seconds by looking at X-Request-Start headers","user":{"login":"siebertm","id":2021,"avatar_url":"https://avatars3.githubusercontent.com/u/2021?v=4","gravatar_id":"","url":"https://api.github.com/users/siebertm","html_url":"https://github.com/siebertm","followers_url":"https://api.github.com/users/siebertm/followers","following_url":"https://api.github.com/users/siebertm/following{/other_user}","gists_url":"https://api.github.com/users/siebertm/gists{/gist_id}","starred_url":"https://api.github.com/users/siebertm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siebertm/subscriptions","organizations_url":"https://api.github.com/users/siebertm/orgs","repos_url":"https://api.github.com/users/siebertm/repos","events_url":"https://api.github.com/users/siebertm/events{/privacy}","received_events_url":"https://api.github.com/users/siebertm/received_events","type":"User","site_admin":false},"body":"This MR adds the possibility to instrument http queuing time when the upstream http server is configured to provide the `X-Request-Start` header.\r\n\r\nI tried testing as far as I could, but had no idea on how to properly test the middleware part, as there weren't any existing tests yet... Any hints?","created_at":"2018-03-05T10:47:16Z","updated_at":"2018-03-09T00:19:45Z","closed_at":"2018-03-09T00:19:45Z","merged_at":"2018-03-09T00:19:45Z","merge_commit_sha":"ec92e628defed008d0a211588f004349cb00f008","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/discourse/prometheus_exporter/pulls/10/commits","review_comments_url":"https://api.github.com/repos/discourse/prometheus_exporter/pulls/10/comments","review_comment_url":"https://api.github.com/repos/discourse/prometheus_exporter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/discourse/prometheus_exporter/issues/10/comments","statuses_url":"https://api.github.com/repos/discourse/prometheus_exporter/statuses/60a048621c86989e4d3b00982106a50de6a6a9b0","head":{"label":"siebertm:expose-queue-time","ref":"expose-queue-time","sha":"60a048621c86989e4d3b00982106a50de6a6a9b0","user":{"login":"siebertm","id":2021,"avatar_url":"https://avatars3.githubusercontent.com/u/2021?v=4","gravatar_id":"","url":"https://api.github.com/users/siebertm","html_url":"https://github.com/siebertm","followers_url":"https://api.github.com/users/siebertm/followers","following_url":"https://api.github.com/users/siebertm/following{/other_user}","gists_url":"https://api.github.com/users/siebertm/gists{/gist_id}","starred_url":"https://api.github.com/users/siebertm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siebertm/subscriptions","organizations_url":"https://api.github.com/users/siebertm/orgs","repos_url":"https://api.github.com/users/siebertm/repos","events_url":"https://api.github.com/users/siebertm/events{/privacy}","received_events_url":"https://api.github.com/users/siebertm/received_events","type":"User","site_admin":false},"repo":{"id":123894103,"name":"prometheus_exporter","full_name":"siebertm/prometheus_exporter","owner":{"login":"siebertm","id":2021,"avatar_url":"https://avatars3.githubusercontent.com/u/2021?v=4","gravatar_id":"","url":"https://api.github.com/users/siebertm","html_url":"https://github.com/siebertm","followers_url":"https://api.github.com/users/siebertm/followers","following_url":"https://api.github.com/users/siebertm/following{/other_user}","gists_url":"https://api.github.com/users/siebertm/gists{/gist_id}","starred_url":"https://api.github.com/users/siebertm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siebertm/subscriptions","organizations_url":"https://api.github.com/users/siebertm/orgs","repos_url":"https://api.github.com/users/siebertm/repos","events_url":"https://api.github.com/users/siebertm/events{/privacy}","received_events_url":"https://api.github.com/users/siebertm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/siebertm/prometheus_exporter","description":"A framework for collecting and aggregating prometheus metrics","fork":true,"url":"https://api.github.com/repos/siebertm/prometheus_exporter","forks_url":"https://api.github.com/repos/siebertm/prometheus_exporter/forks","keys_url":"https://api.github.com/repos/siebertm/prometheus_exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/siebertm/prometheus_exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/siebertm/prometheus_exporter/teams","hooks_url":"https://api.github.com/repos/siebertm/prometheus_exporter/hooks","issue_events_url":"https://api.github.com/repos/siebertm/prometheus_exporter/issues/events{/number}","events_url":"https://api.github.com/repos/siebertm/prometheus_exporter/events","assignees_url":"https://api.github.com/repos/siebertm/prometheus_exporter/assignees{/user}","branches_url":"https://api.github.com/repos/siebertm/prometheus_exporter/branches{/branch}","tags_url":"https://api.github.com/repos/siebertm/prometheus_exporter/tags","blobs_url":"https://api.github.com/repos/siebertm/prometheus_exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/siebertm/prometheus_exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/siebertm/prometheus_exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/siebertm/prometheus_exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/siebertm/prometheus_exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/siebertm/prometheus_exporter/languages","stargazers_url":"https://api.github.com/repos/siebertm/prometheus_exporter/stargazers","contributors_url":"https://api.github.com/repos/siebertm/prometheus_exporter/contributors","subscribers_url":"https://api.github.com/repos/siebertm/prometheus_exporter/subscribers","subscription_url":"https://api.github.com/repos/siebertm/prometheus_exporter/subscription","commits_url":"https://api.github.com/repos/siebertm/prometheus_exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/siebertm/prometheus_exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/siebertm/prometheus_exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/siebertm/prometheus_exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/siebertm/prometheus_exporter/contents/{+path}","compare_url":"https://api.github.com/repos/siebertm/prometheus_exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/siebertm/prometheus_exporter/merges","archive_url":"https://api.github.com/repos/siebertm/prometheus_exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/siebertm/prometheus_exporter/downloads","issues_url":"https://api.github.com/repos/siebertm/prometheus_exporter/issues{/number}","pulls_url":"https://api.github.com/repos/siebertm/prometheus_exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/siebertm/prometheus_exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/siebertm/prometheus_exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/siebertm/prometheus_exporter/labels{/name}","releases_url":"https://api.github.com/repos/siebertm/prometheus_exporter/releases{/id}","deployments_url":"https://api.github.com/repos/siebertm/prometheus_exporter/deployments","created_at":"2018-03-05T09:13:30Z","updated_at":"2018-03-05T09:13:31Z","pushed_at":"2018-03-06T07:27:17Z","git_url":"git://github.com/siebertm/prometheus_exporter.git","ssh_url":"git@github.com:siebertm/prometheus_exporter.git","clone_url":"https://github.com/siebertm/prometheus_exporter.git","svn_url":"https://github.com/siebertm/prometheus_exporter","homepage":null,"size":71,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"discourse:master","ref":"master","sha":"829bc35e0ccbdbcdab0ebd05706c75b89e55e21c","user":{"login":"discourse","id":3220138,"avatar_url":"https://avatars2.githubusercontent.com/u/3220138?v=4","gravatar_id":"","url":"https://api.github.com/users/discourse","html_url":"https://github.com/discourse","followers_url":"https://api.github.com/users/discourse/followers","following_url":"https://api.github.com/users/discourse/following{/other_user}","gists_url":"https://api.github.com/users/discourse/gists{/gist_id}","starred_url":"https://api.github.com/users/discourse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discourse/subscriptions","organizations_url":"https://api.github.com/users/discourse/orgs","repos_url":"https://api.github.com/users/discourse/repos","events_url":"https://api.github.com/users/discourse/events{/privacy}","received_events_url":"https://api.github.com/users/discourse/received_events","type":"Organization","site_admin":false},"repo":{"id":116633535,"name":"prometheus_exporter","full_name":"discourse/prometheus_exporter","owner":{"login":"discourse","id":3220138,"avatar_url":"https://avatars2.githubusercontent.com/u/3220138?v=4","gravatar_id":"","url":"https://api.github.com/users/discourse","html_url":"https://github.com/discourse","followers_url":"https://api.github.com/users/discourse/followers","following_url":"https://api.github.com/users/discourse/following{/other_user}","gists_url":"https://api.github.com/users/discourse/gists{/gist_id}","starred_url":"https://api.github.com/users/discourse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discourse/subscriptions","organizations_url":"https://api.github.com/users/discourse/orgs","repos_url":"https://api.github.com/users/discourse/repos","events_url":"https://api.github.com/users/discourse/events{/privacy}","received_events_url":"https://api.github.com/users/discourse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/discourse/prometheus_exporter","description":"A framework for collecting and aggregating prometheus metrics","fork":false,"url":"https://api.github.com/repos/discourse/prometheus_exporter","forks_url":"https://api.github.com/repos/discourse/prometheus_exporter/forks","keys_url":"https://api.github.com/repos/discourse/prometheus_exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/discourse/prometheus_exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/discourse/prometheus_exporter/teams","hooks_url":"https://api.github.com/repos/discourse/prometheus_exporter/hooks","issue_events_url":"https://api.github.com/repos/discourse/prometheus_exporter/issues/events{/number}","events_url":"https://api.github.com/repos/discourse/prometheus_exporter/events","assignees_url":"https://api.github.com/repos/discourse/prometheus_exporter/assignees{/user}","branches_url":"https://api.github.com/repos/discourse/prometheus_exporter/branches{/branch}","tags_url":"https://api.github.com/repos/discourse/prometheus_exporter/tags","blobs_url":"https://api.github.com/repos/discourse/prometheus_exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/discourse/prometheus_exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/discourse/prometheus_exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/discourse/prometheus_exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/discourse/prometheus_exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/discourse/prometheus_exporter/languages","stargazers_url":"https://api.github.com/repos/discourse/prometheus_exporter/stargazers","contributors_url":"https://api.github.com/repos/discourse/prometheus_exporter/contributors","subscribers_url":"https://api.github.com/repos/discourse/prometheus_exporter/subscribers","subscription_url":"https://api.github.com/repos/discourse/prometheus_exporter/subscription","commits_url":"https://api.github.com/repos/discourse/prometheus_exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/discourse/prometheus_exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/discourse/prometheus_exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/discourse/prometheus_exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/discourse/prometheus_exporter/contents/{+path}","compare_url":"https://api.github.com/repos/discourse/prometheus_exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/discourse/prometheus_exporter/merges","archive_url":"https://api.github.com/repos/discourse/prometheus_exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/discourse/prometheus_exporter/downloads","issues_url":"https://api.github.com/repos/discourse/prometheus_exporter/issues{/number}","pulls_url":"https://api.github.com/repos/discourse/prometheus_exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/discourse/prometheus_exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/discourse/prometheus_exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/discourse/prometheus_exporter/labels{/name}","releases_url":"https://api.github.com/repos/discourse/prometheus_exporter/releases{/id}","deployments_url":"https://api.github.com/repos/discourse/prometheus_exporter/deployments","created_at":"2018-01-08T05:23:27Z","updated_at":"2018-03-08T21:25:36Z","pushed_at":"2018-03-09T00:19:44Z","git_url":"git://github.com/discourse/prometheus_exporter.git","ssh_url":"git@github.com:discourse/prometheus_exporter.git","clone_url":"https://github.com/discourse/prometheus_exporter.git","svn_url":"https://github.com/discourse/prometheus_exporter","homepage":null,"size":78,"stargazers_count":62,"watchers_count":62,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":5,"open_issues":1,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/discourse/prometheus_exporter/pulls/10"},"html":{"href":"https://github.com/discourse/prometheus_exporter/pull/10"},"issue":{"href":"https://api.github.com/repos/discourse/prometheus_exporter/issues/10"},"comments":{"href":"https://api.github.com/repos/discourse/prometheus_exporter/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/discourse/prometheus_exporter/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/discourse/prometheus_exporter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/discourse/prometheus_exporter/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/discourse/prometheus_exporter/statuses/60a048621c86989e4d3b00982106a50de6a6a9b0"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"SamSaffron","id":5213,"avatar_url":"https://avatars1.githubusercontent.com/u/5213?v=4","gravatar_id":"","url":"https://api.github.com/users/SamSaffron","html_url":"https://github.com/SamSaffron","followers_url":"https://api.github.com/users/SamSaffron/followers","following_url":"https://api.github.com/users/SamSaffron/following{/other_user}","gists_url":"https://api.github.com/users/SamSaffron/gists{/gist_id}","starred_url":"https://api.github.com/users/SamSaffron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamSaffron/subscriptions","organizations_url":"https://api.github.com/users/SamSaffron/orgs","repos_url":"https://api.github.com/users/SamSaffron/repos","events_url":"https://api.github.com/users/SamSaffron/events{/privacy}","received_events_url":"https://api.github.com/users/SamSaffron/received_events","type":"User","site_admin":false},"comments":4,"review_comments":4,"maintainer_can_modify":false,"commits":1,"additions":181,"deletions":5,"changed_files":6}}
{"actor":{"display_login":"SamSaffron"}}