{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/frontend/pulls/comments/231565971","pull_request_review_id":172564221,"id":231565971,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTU2NTk3MQ==","diff_hunk":"@@ -516,4 +516,13 @@ trait FeatureSwitches {\n     exposeClientSide = true\n   )\n \n+  val NewNavEnabled = Switch(\n+    SwitchGroup.Feature,\n+    \"new-nav-enabled\",\n+    \"If this is switched on then the new navigation will be enabled\",\n+    owners = Seq(Owner.withGithub(\"GHaberis\")),\n+    safeState = Off,\n+    sellByDate = never,","path":"common/app/conf/switches/FeatureSwitches.scala","position":10,"original_position":10,"commit_id":"2eff8043583ad286f0e1b0961207aa0b94487454","original_commit_id":"675dddeb16c91265e6bbda0e703752badcf4738a","user":{"login":"NataliaLKB","id":8774970,"node_id":"MDQ6VXNlcjg3NzQ5NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/8774970?v=4","gravatar_id":"","url":"https://api.github.com/users/NataliaLKB","html_url":"https://github.com/NataliaLKB","followers_url":"https://api.github.com/users/NataliaLKB/followers","following_url":"https://api.github.com/users/NataliaLKB/following{/other_user}","gists_url":"https://api.github.com/users/NataliaLKB/gists{/gist_id}","starred_url":"https://api.github.com/users/NataliaLKB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NataliaLKB/subscriptions","organizations_url":"https://api.github.com/users/NataliaLKB/orgs","repos_url":"https://api.github.com/users/NataliaLKB/repos","events_url":"https://api.github.com/users/NataliaLKB/events{/privacy}","received_events_url":"https://api.github.com/users/NataliaLKB/received_events","type":"User","site_admin":false},"body":"Yes definitely! I would probably have it expire a week from Monday?","created_at":"2018-11-07T16:02:33Z","updated_at":"2018-11-07T16:02:33Z","html_url":"https://github.com/guardian/frontend/pull/20646#discussion_r231565971","pull_request_url":"https://api.github.com/repos/guardian/frontend/pulls/20646","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/231565971"},"html":{"href":"https://github.com/guardian/frontend/pull/20646#discussion_r231565971"},"pull_request":{"href":"https://api.github.com/repos/guardian/frontend/pulls/20646"}},"in_reply_to_id":231203578},"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/20646","id":228657442,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NjU3NDQy","html_url":"https://github.com/guardian/frontend/pull/20646","diff_url":"https://github.com/guardian/frontend/pull/20646.diff","patch_url":"https://github.com/guardian/frontend/pull/20646.patch","issue_url":"https://api.github.com/repos/guardian/frontend/issues/20646","number":20646,"state":"open","locked":false,"title":"Header and footer variants behind a switch","user":{"login":"zeftilldeath","id":14570016,"node_id":"MDQ6VXNlcjE0NTcwMDE2","avatar_url":"https://avatars1.githubusercontent.com/u/14570016?v=4","gravatar_id":"","url":"https://api.github.com/users/zeftilldeath","html_url":"https://github.com/zeftilldeath","followers_url":"https://api.github.com/users/zeftilldeath/followers","following_url":"https://api.github.com/users/zeftilldeath/following{/other_user}","gists_url":"https://api.github.com/users/zeftilldeath/gists{/gist_id}","starred_url":"https://api.github.com/users/zeftilldeath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeftilldeath/subscriptions","organizations_url":"https://api.github.com/users/zeftilldeath/orgs","repos_url":"https://api.github.com/users/zeftilldeath/repos","events_url":"https://api.github.com/users/zeftilldeath/events{/privacy}","received_events_url":"https://api.github.com/users/zeftilldeath/received_events","type":"User","site_admin":false},"body":"## What does this change?\r\nNew version of the header and footer behind a switch.\r\nPredominantly layout and design changes to the header and footer, and a visual change to the side margins. \r\n\r\nFeaturing:\r\n- Some colour changes 😉 \r\n- More prominent supporter messaging in the header and footer\r\n- Increased prominence of supporter messaging in expanded mobile menu\r\n- Slim nav at mobile breakpoints now contains supporter messaging (See the theme here?)\r\n- Increased visual differentiation of Search and Account areas, including iconography\r\n- Account more consistent across breakpoints\r\n- Slim nav/roundel no longer overlaps page content\r\n- Footer content has been re-ordered across editions for increased clarity\r\n- Secondary menus carry pillar colour in footer and header\r\n- Dated search form overrides have been updated \r\n- Discount codes links added to header and footer in UK edition\r\n\r\n## Screenshots\r\nNope\r\n\r\n### Does this affect other platforms?\r\nAMP to be looked at separately\r\n\r\n### Does this affect GLabs Paid Content Pages? Should it have support for Paid Content?\r\nPaid content is catered for in the changes.\r\n\r\nThere are some more visual changes I wish to make but I will do these in subsequent PRs. \r\n","created_at":"2018-11-06T11:21:57Z","updated_at":"2018-11-07T16:02:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3250454c33090a867c6ad5bdc58ec694c398fbf","assignee":null,"assignees":[],"requested_reviewers":[{"login":"GHaberis","id":1590704,"node_id":"MDQ6VXNlcjE1OTA3MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1590704?v=4","gravatar_id":"","url":"https://api.github.com/users/GHaberis","html_url":"https://github.com/GHaberis","followers_url":"https://api.github.com/users/GHaberis/followers","following_url":"https://api.github.com/users/GHaberis/following{/other_user}","gists_url":"https://api.github.com/users/GHaberis/gists{/gist_id}","starred_url":"https://api.github.com/users/GHaberis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GHaberis/subscriptions","organizations_url":"https://api.github.com/users/GHaberis/orgs","repos_url":"https://api.github.com/users/GHaberis/repos","events_url":"https://api.github.com/users/GHaberis/events{/privacy}","received_events_url":"https://api.github.com/users/GHaberis/received_events","type":"User","site_admin":false},{"login":"NataliaLKB","id":8774970,"node_id":"MDQ6VXNlcjg3NzQ5NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/8774970?v=4","gravatar_id":"","url":"https://api.github.com/users/NataliaLKB","html_url":"https://github.com/NataliaLKB","followers_url":"https://api.github.com/users/NataliaLKB/followers","following_url":"https://api.github.com/users/NataliaLKB/following{/other_user}","gists_url":"https://api.github.com/users/NataliaLKB/gists{/gist_id}","starred_url":"https://api.github.com/users/NataliaLKB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NataliaLKB/subscriptions","organizations_url":"https://api.github.com/users/NataliaLKB/orgs","repos_url":"https://api.github.com/users/NataliaLKB/repos","events_url":"https://api.github.com/users/NataliaLKB/events{/privacy}","received_events_url":"https://api.github.com/users/NataliaLKB/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/guardian/frontend/pulls/20646/commits","review_comments_url":"https://api.github.com/repos/guardian/frontend/pulls/20646/comments","review_comment_url":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/20646/comments","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/2eff8043583ad286f0e1b0961207aa0b94487454","head":{"label":"guardian:eiffel-65","ref":"eiffel-65","sha":"2eff8043583ad286f0e1b0961207aa0b94487454","user":{"login":"guardian","id":164318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"node_id":"MDEwOlJlcG9zaXRvcnk0MzcwNzU1","name":"frontend","full_name":"guardian/frontend","private":false,"owner":{"login":"guardian","id":164318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/guardian/frontend","description":"frontend","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2018-11-07T13:51:55Z","pushed_at":"2018-11-07T15:58:29Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"https://www.theguardian.com","size":609288,"stargazers_count":5188,"watchers_count":5188,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":520,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":520,"open_issues":40,"watchers":5188,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"073fc81142e22c7457b35ef03f7596f9142fb6b7","user":{"login":"guardian","id":164318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"node_id":"MDEwOlJlcG9zaXRvcnk0MzcwNzU1","name":"frontend","full_name":"guardian/frontend","private":false,"owner":{"login":"guardian","id":164318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/guardian/frontend","description":"frontend","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2018-11-07T13:51:55Z","pushed_at":"2018-11-07T15:58:29Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"https://www.theguardian.com","size":609288,"stargazers_count":5188,"watchers_count":5188,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":520,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":520,"open_issues":40,"watchers":5188,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/20646"},"html":{"href":"https://github.com/guardian/frontend/pull/20646"},"issue":{"href":"https://api.github.com/repos/guardian/frontend/issues/20646"},"comments":{"href":"https://api.github.com/repos/guardian/frontend/issues/20646/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/frontend/pulls/20646/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/frontend/pulls/20646/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/frontend/statuses/2eff8043583ad286f0e1b0961207aa0b94487454"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"NataliaLKB"}}