{"action":"closed","number":59239,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59239","id":166715194,"html_url":"https://github.com/kubernetes/kubernetes/pull/59239","diff_url":"https://github.com/kubernetes/kubernetes/pull/59239.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/59239.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59239","number":59239,"state":"closed","locked":false,"title":"Move the readinessCheck to framework/util","user":{"login":"lcfang","id":30678878,"avatar_url":"https://avatars1.githubusercontent.com/u/30678878?v=4","gravatar_id":"","url":"https://api.github.com/users/lcfang","html_url":"https://github.com/lcfang","followers_url":"https://api.github.com/users/lcfang/followers","following_url":"https://api.github.com/users/lcfang/following{/other_user}","gists_url":"https://api.github.com/users/lcfang/gists{/gist_id}","starred_url":"https://api.github.com/users/lcfang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcfang/subscriptions","organizations_url":"https://api.github.com/users/lcfang/orgs","repos_url":"https://api.github.com/users/lcfang/repos","events_url":"https://api.github.com/users/lcfang/events{/privacy}","received_events_url":"https://api.github.com/users/lcfang/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n4. If the PR is unfinished, see how to mark it: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n```\r\n// readinessCheck checks whether services are ready via the supplied health\r\n// check URLs. Once there is an error in errCh, the function will stop waiting\r\n// and return the error.\r\n// TODO(random-liu): Move this to util\r\n```\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\n\r\n```\r\n","created_at":"2018-02-02T04:22:51Z","updated_at":"2018-03-06T02:33:54Z","closed_at":"2018-03-06T02:33:54Z","merged_at":null,"merge_commit_sha":"5de5e17cebf6aee9a7055419ae1b8ebc2a18becd","assignee":{"login":"krousey","id":157083,"avatar_url":"https://avatars2.githubusercontent.com/u/157083?v=4","gravatar_id":"","url":"https://api.github.com/users/krousey","html_url":"https://github.com/krousey","followers_url":"https://api.github.com/users/krousey/followers","following_url":"https://api.github.com/users/krousey/following{/other_user}","gists_url":"https://api.github.com/users/krousey/gists{/gist_id}","starred_url":"https://api.github.com/users/krousey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krousey/subscriptions","organizations_url":"https://api.github.com/users/krousey/orgs","repos_url":"https://api.github.com/users/krousey/repos","events_url":"https://api.github.com/users/krousey/events{/privacy}","received_events_url":"https://api.github.com/users/krousey/received_events","type":"User","site_admin":false},"assignees":[{"login":"krousey","id":157083,"avatar_url":"https://avatars2.githubusercontent.com/u/157083?v=4","gravatar_id":"","url":"https://api.github.com/users/krousey","html_url":"https://github.com/krousey","followers_url":"https://api.github.com/users/krousey/followers","following_url":"https://api.github.com/users/krousey/following{/other_user}","gists_url":"https://api.github.com/users/krousey/gists{/gist_id}","starred_url":"https://api.github.com/users/krousey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krousey/subscriptions","organizations_url":"https://api.github.com/users/krousey/orgs","repos_url":"https://api.github.com/users/krousey/repos","events_url":"https://api.github.com/users/krousey/events{/privacy}","received_events_url":"https://api.github.com/users/krousey/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"dims","id":23304,"avatar_url":"https://avatars2.githubusercontent.com/u/23304?v=4","gravatar_id":"","url":"https://api.github.com/users/dims","html_url":"https://github.com/dims","followers_url":"https://api.github.com/users/dims/followers","following_url":"https://api.github.com/users/dims/following{/other_user}","gists_url":"https://api.github.com/users/dims/gists{/gist_id}","starred_url":"https://api.github.com/users/dims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dims/subscriptions","organizations_url":"https://api.github.com/users/dims/orgs","repos_url":"https://api.github.com/users/dims/repos","events_url":"https://api.github.com/users/dims/events{/privacy}","received_events_url":"https://api.github.com/users/dims/received_events","type":"User","site_admin":false},{"login":"pwittrock","id":7882754,"avatar_url":"https://avatars0.githubusercontent.com/u/7882754?v=4","gravatar_id":"","url":"https://api.github.com/users/pwittrock","html_url":"https://github.com/pwittrock","followers_url":"https://api.github.com/users/pwittrock/followers","following_url":"https://api.github.com/users/pwittrock/following{/other_user}","gists_url":"https://api.github.com/users/pwittrock/gists{/gist_id}","starred_url":"https://api.github.com/users/pwittrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwittrock/subscriptions","organizations_url":"https://api.github.com/users/pwittrock/orgs","repos_url":"https://api.github.com/users/pwittrock/repos","events_url":"https://api.github.com/users/pwittrock/events{/privacy}","received_events_url":"https://api.github.com/users/pwittrock/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":680152113,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/release-note-label-needed","name":"do-not-merge/release-note-label-needed","color":"e11d21","default":false},{"id":253450978,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59239/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59239/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59239/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/0a39cbfbe7b9b3ba1ad18cf0c5d676a785550a53","head":{"label":"lcfang:test-0202","ref":"test-0202","sha":"0a39cbfbe7b9b3ba1ad18cf0c5d676a785550a53","user":{"login":"lcfang","id":30678878,"avatar_url":"https://avatars1.githubusercontent.com/u/30678878?v=4","gravatar_id":"","url":"https://api.github.com/users/lcfang","html_url":"https://github.com/lcfang","followers_url":"https://api.github.com/users/lcfang/followers","following_url":"https://api.github.com/users/lcfang/following{/other_user}","gists_url":"https://api.github.com/users/lcfang/gists{/gist_id}","starred_url":"https://api.github.com/users/lcfang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcfang/subscriptions","organizations_url":"https://api.github.com/users/lcfang/orgs","repos_url":"https://api.github.com/users/lcfang/repos","events_url":"https://api.github.com/users/lcfang/events{/privacy}","received_events_url":"https://api.github.com/users/lcfang/received_events","type":"User","site_admin":false},"repo":{"id":99748922,"name":"kubernetes","full_name":"lcfang/kubernetes","owner":{"login":"lcfang","id":30678878,"avatar_url":"https://avatars1.githubusercontent.com/u/30678878?v=4","gravatar_id":"","url":"https://api.github.com/users/lcfang","html_url":"https://github.com/lcfang","followers_url":"https://api.github.com/users/lcfang/followers","following_url":"https://api.github.com/users/lcfang/following{/other_user}","gists_url":"https://api.github.com/users/lcfang/gists{/gist_id}","starred_url":"https://api.github.com/users/lcfang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcfang/subscriptions","organizations_url":"https://api.github.com/users/lcfang/orgs","repos_url":"https://api.github.com/users/lcfang/repos","events_url":"https://api.github.com/users/lcfang/events{/privacy}","received_events_url":"https://api.github.com/users/lcfang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lcfang/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/lcfang/kubernetes","forks_url":"https://api.github.com/repos/lcfang/kubernetes/forks","keys_url":"https://api.github.com/repos/lcfang/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lcfang/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lcfang/kubernetes/teams","hooks_url":"https://api.github.com/repos/lcfang/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/lcfang/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/lcfang/kubernetes/events","assignees_url":"https://api.github.com/repos/lcfang/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/lcfang/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/lcfang/kubernetes/tags","blobs_url":"https://api.github.com/repos/lcfang/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lcfang/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lcfang/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/lcfang/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lcfang/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/lcfang/kubernetes/languages","stargazers_url":"https://api.github.com/repos/lcfang/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/lcfang/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/lcfang/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/lcfang/kubernetes/subscription","commits_url":"https://api.github.com/repos/lcfang/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/lcfang/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/lcfang/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/lcfang/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/lcfang/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/lcfang/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lcfang/kubernetes/merges","archive_url":"https://api.github.com/repos/lcfang/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lcfang/kubernetes/downloads","issues_url":"https://api.github.com/repos/lcfang/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/lcfang/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/lcfang/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/lcfang/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lcfang/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/lcfang/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/lcfang/kubernetes/deployments","created_at":"2017-08-09T00:42:42Z","updated_at":"2017-08-09T00:43:24Z","pushed_at":"2018-03-06T01:59:49Z","git_url":"git://github.com/lcfang/kubernetes.git","ssh_url":"git@github.com:lcfang/kubernetes.git","clone_url":"https://github.com/lcfang/kubernetes.git","svn_url":"https://github.com/lcfang/kubernetes","homepage":"http://kubernetes.io","size":541902,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"d3b783d5ec1739e43344299d67a1b7ac4079458d","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-03-06T02:27:25Z","pushed_at":"2018-03-06T02:33:29Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":762642,"stargazers_count":33325,"watchers_count":33325,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11812,"mirror_url":null,"archived":false,"open_issues_count":3762,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":11812,"open_issues":3762,"watchers":33325,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59239"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/59239"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/59239"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/59239/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59239/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59239/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/0a39cbfbe7b9b3ba1ad18cf0c5d676a785550a53"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":8,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":53,"deletions":52,"changed_files":4}}
{"actor":{"display_login":"k8s-ci-robot"}}