{"action":"created","comment":{"url":"https://api.github.com/repos/apache/carbondata/pulls/comments/191323610","pull_request_review_id":123871133,"id":191323610,"diff_hunk":"@@ -101,6 +111,59 @@ public static CarbonReaderBuilder builder(String tablePath, String tableName) {\n     return reader.readSchema();\n   }\n \n+  /**\n+   * Read carbonindex file and return the schema\n+   *\n+   * @param indexFilePath complete path including index file name\n+   * @return null, if the index file is not present in the path.\n+   * List<ColumnSchema> from the index file.\n+   * @throws IOException\n+   */\n+  public static List<ColumnSchema> readSchemaInIndexFile(String indexFilePath) throws IOException {","path":"store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java","position":43,"original_position":43,"commit_id":"f4870077fcf438ea39365364172e4cdc9b22f241","original_commit_id":"f4870077fcf438ea39365364172e4cdc9b22f241","user":{"login":"jackylk","id":6500698,"avatar_url":"https://avatars3.githubusercontent.com/u/6500698?v=4","gravatar_id":"","url":"https://api.github.com/users/jackylk","html_url":"https://github.com/jackylk","followers_url":"https://api.github.com/users/jackylk/followers","following_url":"https://api.github.com/users/jackylk/following{/other_user}","gists_url":"https://api.github.com/users/jackylk/gists{/gist_id}","starred_url":"https://api.github.com/users/jackylk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackylk/subscriptions","organizations_url":"https://api.github.com/users/jackylk/orgs","repos_url":"https://api.github.com/users/jackylk/repos","events_url":"https://api.github.com/users/jackylk/events{/privacy}","received_events_url":"https://api.github.com/users/jackylk/received_events","type":"User","site_admin":false},"body":"Create a `CarbonSchemaReader` and put `readSchemaInIndexFile`, `readUserSchema`, `readSchemaInDataFile` into it","created_at":"2018-05-29T07:18:30Z","updated_at":"2018-05-29T07:18:30Z","html_url":"https://github.com/apache/carbondata/pull/2341#discussion_r191323610","pull_request_url":"https://api.github.com/repos/apache/carbondata/pulls/2341","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/carbondata/pulls/comments/191323610"},"html":{"href":"https://github.com/apache/carbondata/pull/2341#discussion_r191323610"},"pull_request":{"href":"https://api.github.com/repos/apache/carbondata/pulls/2341"}}},"pull_request":{"url":"https://api.github.com/repos/apache/carbondata/pulls/2341","id":190513973,"html_url":"https://github.com/apache/carbondata/pull/2341","diff_url":"https://github.com/apache/carbondata/pull/2341.diff","patch_url":"https://github.com/apache/carbondata/pull/2341.patch","issue_url":"https://api.github.com/repos/apache/carbondata/issues/2341","number":2341,"state":"open","locked":false,"title":"[CARBONDATA-2500]  Create are API to read user's schema in SDK","user":{"login":"xubo245","id":8759816,"avatar_url":"https://avatars1.githubusercontent.com/u/8759816?v=4","gravatar_id":"","url":"https://api.github.com/users/xubo245","html_url":"https://github.com/xubo245","followers_url":"https://api.github.com/users/xubo245/followers","following_url":"https://api.github.com/users/xubo245/following{/other_user}","gists_url":"https://api.github.com/users/xubo245/gists{/gist_id}","starred_url":"https://api.github.com/users/xubo245/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xubo245/subscriptions","organizations_url":"https://api.github.com/users/xubo245/orgs","repos_url":"https://api.github.com/users/xubo245/repos","events_url":"https://api.github.com/users/xubo245/events{/privacy}","received_events_url":"https://api.github.com/users/xubo245/received_events","type":"User","site_admin":false},"body":"The order is different between write and read data type of schema in SDK\r\n1. Create are API to read user's schema in SDK:\r\norg.apache.carbondata.sdk.file.CarbonReader#readUserSchema\r\n`  /**\r\n   * Read CarbonData file and return the user schema\r\n   */\r\n  public static List<ColumnSchema> readUserSchema(String dataFilePath) ;`\r\n2.write some test case to sort list of columnSchema.  \r\norg.apache.carbondata.sdk.file.CarbonReaderTest\r\n3. Fix some spell error in CarbonData\r\n\r\nBe sure to do all of the following checklist to help us incorporate \r\nyour contribution quickly and easily:\r\n\r\n - [x] Any interfaces changed?\r\n No, but add one new interface\r\n - [x] Any backward compatibility impacted?\r\n No\r\n - [ ] Document update required?\r\nYes\r\n - [x] Testing done\r\n        Please provide details on \r\n        - Whether new unit test cases have been added or why no new tests are required?\r\n        - How it is tested? Please attach test report.\r\n        - Is it a performance related change? Please attach the performance test report.\r\n        - Any additional information to help reviewers in testing this change.\r\n      add some test case in org.apache.carbondata.sdk.file.CarbonReaderTest\r\n - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. \r\nNo","created_at":"2018-05-25T08:22:34Z","updated_at":"2018-05-29T07:18:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2b03db504f3a262fb3f2ccca6dc1bcba1c41793","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/carbondata/pulls/2341/commits","review_comments_url":"https://api.github.com/repos/apache/carbondata/pulls/2341/comments","review_comment_url":"https://api.github.com/repos/apache/carbondata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/carbondata/issues/2341/comments","statuses_url":"https://api.github.com/repos/apache/carbondata/statuses/f4870077fcf438ea39365364172e4cdc9b22f241","head":{"label":"xubo245:CARBONDATA-2500-orderDifferent","ref":"CARBONDATA-2500-orderDifferent","sha":"f4870077fcf438ea39365364172e4cdc9b22f241","user":{"login":"xubo245","id":8759816,"avatar_url":"https://avatars1.githubusercontent.com/u/8759816?v=4","gravatar_id":"","url":"https://api.github.com/users/xubo245","html_url":"https://github.com/xubo245","followers_url":"https://api.github.com/users/xubo245/followers","following_url":"https://api.github.com/users/xubo245/following{/other_user}","gists_url":"https://api.github.com/users/xubo245/gists{/gist_id}","starred_url":"https://api.github.com/users/xubo245/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xubo245/subscriptions","organizations_url":"https://api.github.com/users/xubo245/orgs","repos_url":"https://api.github.com/users/xubo245/repos","events_url":"https://api.github.com/users/xubo245/events{/privacy}","received_events_url":"https://api.github.com/users/xubo245/received_events","type":"User","site_admin":false},"repo":{"id":99896462,"name":"carbondata","full_name":"xubo245/carbondata","owner":{"login":"xubo245","id":8759816,"avatar_url":"https://avatars1.githubusercontent.com/u/8759816?v=4","gravatar_id":"","url":"https://api.github.com/users/xubo245","html_url":"https://github.com/xubo245","followers_url":"https://api.github.com/users/xubo245/followers","following_url":"https://api.github.com/users/xubo245/following{/other_user}","gists_url":"https://api.github.com/users/xubo245/gists{/gist_id}","starred_url":"https://api.github.com/users/xubo245/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xubo245/subscriptions","organizations_url":"https://api.github.com/users/xubo245/orgs","repos_url":"https://api.github.com/users/xubo245/repos","events_url":"https://api.github.com/users/xubo245/events{/privacy}","received_events_url":"https://api.github.com/users/xubo245/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xubo245/carbondata","description":"Mirror of Apache CarbonData","fork":true,"url":"https://api.github.com/repos/xubo245/carbondata","forks_url":"https://api.github.com/repos/xubo245/carbondata/forks","keys_url":"https://api.github.com/repos/xubo245/carbondata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xubo245/carbondata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xubo245/carbondata/teams","hooks_url":"https://api.github.com/repos/xubo245/carbondata/hooks","issue_events_url":"https://api.github.com/repos/xubo245/carbondata/issues/events{/number}","events_url":"https://api.github.com/repos/xubo245/carbondata/events","assignees_url":"https://api.github.com/repos/xubo245/carbondata/assignees{/user}","branches_url":"https://api.github.com/repos/xubo245/carbondata/branches{/branch}","tags_url":"https://api.github.com/repos/xubo245/carbondata/tags","blobs_url":"https://api.github.com/repos/xubo245/carbondata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xubo245/carbondata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xubo245/carbondata/git/refs{/sha}","trees_url":"https://api.github.com/repos/xubo245/carbondata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xubo245/carbondata/statuses/{sha}","languages_url":"https://api.github.com/repos/xubo245/carbondata/languages","stargazers_url":"https://api.github.com/repos/xubo245/carbondata/stargazers","contributors_url":"https://api.github.com/repos/xubo245/carbondata/contributors","subscribers_url":"https://api.github.com/repos/xubo245/carbondata/subscribers","subscription_url":"https://api.github.com/repos/xubo245/carbondata/subscription","commits_url":"https://api.github.com/repos/xubo245/carbondata/commits{/sha}","git_commits_url":"https://api.github.com/repos/xubo245/carbondata/git/commits{/sha}","comments_url":"https://api.github.com/repos/xubo245/carbondata/comments{/number}","issue_comment_url":"https://api.github.com/repos/xubo245/carbondata/issues/comments{/number}","contents_url":"https://api.github.com/repos/xubo245/carbondata/contents/{+path}","compare_url":"https://api.github.com/repos/xubo245/carbondata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xubo245/carbondata/merges","archive_url":"https://api.github.com/repos/xubo245/carbondata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xubo245/carbondata/downloads","issues_url":"https://api.github.com/repos/xubo245/carbondata/issues{/number}","pulls_url":"https://api.github.com/repos/xubo245/carbondata/pulls{/number}","milestones_url":"https://api.github.com/repos/xubo245/carbondata/milestones{/number}","notifications_url":"https://api.github.com/repos/xubo245/carbondata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xubo245/carbondata/labels{/name}","releases_url":"https://api.github.com/repos/xubo245/carbondata/releases{/id}","deployments_url":"https://api.github.com/repos/xubo245/carbondata/deployments","created_at":"2017-08-10T07:50:07Z","updated_at":"2018-04-18T12:40:01Z","pushed_at":"2018-05-29T05:08:11Z","git_url":"git://github.com/xubo245/carbondata.git","ssh_url":"git@github.com:xubo245/carbondata.git","clone_url":"https://github.com/xubo245/carbondata.git","svn_url":"https://github.com/xubo245/carbondata","homepage":"","size":58466,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"8b80b12eca261016000f0ab132e8558a4e87fc95","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":62117818,"name":"carbondata","full_name":"apache/carbondata","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/carbondata","description":"Mirror of Apache CarbonData","fork":false,"url":"https://api.github.com/repos/apache/carbondata","forks_url":"https://api.github.com/repos/apache/carbondata/forks","keys_url":"https://api.github.com/repos/apache/carbondata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/carbondata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/carbondata/teams","hooks_url":"https://api.github.com/repos/apache/carbondata/hooks","issue_events_url":"https://api.github.com/repos/apache/carbondata/issues/events{/number}","events_url":"https://api.github.com/repos/apache/carbondata/events","assignees_url":"https://api.github.com/repos/apache/carbondata/assignees{/user}","branches_url":"https://api.github.com/repos/apache/carbondata/branches{/branch}","tags_url":"https://api.github.com/repos/apache/carbondata/tags","blobs_url":"https://api.github.com/repos/apache/carbondata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/carbondata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/carbondata/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/carbondata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/carbondata/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/carbondata/languages","stargazers_url":"https://api.github.com/repos/apache/carbondata/stargazers","contributors_url":"https://api.github.com/repos/apache/carbondata/contributors","subscribers_url":"https://api.github.com/repos/apache/carbondata/subscribers","subscription_url":"https://api.github.com/repos/apache/carbondata/subscription","commits_url":"https://api.github.com/repos/apache/carbondata/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/carbondata/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/carbondata/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/carbondata/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/carbondata/contents/{+path}","compare_url":"https://api.github.com/repos/apache/carbondata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/carbondata/merges","archive_url":"https://api.github.com/repos/apache/carbondata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/carbondata/downloads","issues_url":"https://api.github.com/repos/apache/carbondata/issues{/number}","pulls_url":"https://api.github.com/repos/apache/carbondata/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/carbondata/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/carbondata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/carbondata/labels{/name}","releases_url":"https://api.github.com/repos/apache/carbondata/releases{/id}","deployments_url":"https://api.github.com/repos/apache/carbondata/deployments","created_at":"2016-06-28T07:00:06Z","updated_at":"2018-05-29T05:28:01Z","pushed_at":"2018-05-29T06:37:33Z","git_url":"git://github.com/apache/carbondata.git","ssh_url":"git@github.com:apache/carbondata.git","clone_url":"https://github.com/apache/carbondata.git","svn_url":"https://github.com/apache/carbondata","homepage":"","size":58463,"stargazers_count":672,"watchers_count":672,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":419,"mirror_url":null,"archived":false,"open_issues_count":96,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":419,"open_issues":96,"watchers":672,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/carbondata/pulls/2341"},"html":{"href":"https://github.com/apache/carbondata/pull/2341"},"issue":{"href":"https://api.github.com/repos/apache/carbondata/issues/2341"},"comments":{"href":"https://api.github.com/repos/apache/carbondata/issues/2341/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/carbondata/pulls/2341/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/carbondata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/carbondata/pulls/2341/commits"},"statuses":{"href":"https://api.github.com/repos/apache/carbondata/statuses/f4870077fcf438ea39365364172e4cdc9b22f241"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jackylk"}}