{"action":"created","comment":{"url":"https://api.github.com/repos/wikimedia/InteractionTimeline/pulls/comments/167894658","pull_request_review_id":96166726,"id":167894658,"diff_hunk":"@@ -0,0 +1,42 @@\n+<?php\n+\n+namespace App\\Action;\n+\n+use Psr\\Container\\ContainerInterface;\n+use Psr\\Log\\LoggerInterface;\n+use Slim\\Http\\Request;\n+use Slim\\Http\\Response;\n+\n+class HelloAction {\n+\n+\t/**\n+\t * @var ContainerInterface\n+\t */\n+\tprivate $container;\n+\n+\t/**\n+\t * @var LoggerInterface\n+\t */\n+\tprivate $logger;\n+\n+\t/**\n+\t * HelloAction constructor.\n+\t * @param ContainerInterface $container\n+\t */\n+\tpublic function __construct( ContainerInterface $container ) {\n+\t\t$this->container = $container;\n+\t\t$this->logger = $this->container->get( 'logger' );\n+\t}","path":"server/src/Action/HelloAction.php","position":29,"original_position":29,"commit_id":"a0b739e719ce10fa1a4f07cd1508ed2a6da4ae21","original_commit_id":"a0b739e719ce10fa1a4f07cd1508ed2a6da4ae21","user":{"login":"davidbarratt","id":868364,"avatar_url":"https://avatars0.githubusercontent.com/u/868364?v=4","gravatar_id":"","url":"https://api.github.com/users/davidbarratt","html_url":"https://github.com/davidbarratt","followers_url":"https://api.github.com/users/davidbarratt/followers","following_url":"https://api.github.com/users/davidbarratt/following{/other_user}","gists_url":"https://api.github.com/users/davidbarratt/gists{/gist_id}","starred_url":"https://api.github.com/users/davidbarratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidbarratt/subscriptions","organizations_url":"https://api.github.com/users/davidbarratt/orgs","repos_url":"https://api.github.com/users/davidbarratt/repos","events_url":"https://api.github.com/users/davidbarratt/events{/privacy}","received_events_url":"https://api.github.com/users/davidbarratt/received_events","type":"User","site_admin":false},"body":"You should inject the dependency, not the container.\r\n\r\ni.e. inject a `$logger`\r\n\r\nOr is this the only way it can be done? Perhaps the action should be within the container as well? Then the route can just call something like `$container->get('hello_action')->helloAction()` (if necessary)","created_at":"2018-02-13T15:14:21Z","updated_at":"2018-02-13T15:27:04Z","html_url":"https://github.com/wikimedia/InteractionTimeline/pull/35#discussion_r167894658","pull_request_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/pulls/35","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/wikimedia/InteractionTimeline/pulls/comments/167894658"},"html":{"href":"https://github.com/wikimedia/InteractionTimeline/pull/35#discussion_r167894658"},"pull_request":{"href":"https://api.github.com/repos/wikimedia/InteractionTimeline/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/wikimedia/InteractionTimeline/pulls/35","id":168764767,"html_url":"https://github.com/wikimedia/InteractionTimeline/pull/35","diff_url":"https://github.com/wikimedia/InteractionTimeline/pull/35.diff","patch_url":"https://github.com/wikimedia/InteractionTimeline/pull/35.patch","issue_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/issues/35","number":35,"state":"closed","locked":false,"title":"T185460 - Setup API project skeleton and dependencies","user":{"login":"dayllanmaza","id":680583,"avatar_url":"https://avatars2.githubusercontent.com/u/680583?v=4","gravatar_id":"","url":"https://api.github.com/users/dayllanmaza","html_url":"https://github.com/dayllanmaza","followers_url":"https://api.github.com/users/dayllanmaza/followers","following_url":"https://api.github.com/users/dayllanmaza/following{/other_user}","gists_url":"https://api.github.com/users/dayllanmaza/gists{/gist_id}","starred_url":"https://api.github.com/users/dayllanmaza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dayllanmaza/subscriptions","organizations_url":"https://api.github.com/users/dayllanmaza/orgs","repos_url":"https://api.github.com/users/dayllanmaza/repos","events_url":"https://api.github.com/users/dayllanmaza/events{/privacy}","received_events_url":"https://api.github.com/users/dayllanmaza/received_events","type":"User","site_admin":false},"body":"I think this covers the basics. Keep in mind that things will change once we start doing work on the actual `interaction` endpoint. This is sort of a generic starting point.","created_at":"2018-02-13T06:34:34Z","updated_at":"2018-02-13T15:27:04Z","closed_at":"2018-02-13T06:59:19Z","merged_at":"2018-02-13T06:59:19Z","merge_commit_sha":"299ae987e76df6f1baac0594aa864ac99336975f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"MusikAnimal","id":366374,"avatar_url":"https://avatars0.githubusercontent.com/u/366374?v=4","gravatar_id":"","url":"https://api.github.com/users/MusikAnimal","html_url":"https://github.com/MusikAnimal","followers_url":"https://api.github.com/users/MusikAnimal/followers","following_url":"https://api.github.com/users/MusikAnimal/following{/other_user}","gists_url":"https://api.github.com/users/MusikAnimal/gists{/gist_id}","starred_url":"https://api.github.com/users/MusikAnimal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MusikAnimal/subscriptions","organizations_url":"https://api.github.com/users/MusikAnimal/orgs","repos_url":"https://api.github.com/users/MusikAnimal/repos","events_url":"https://api.github.com/users/MusikAnimal/events{/privacy}","received_events_url":"https://api.github.com/users/MusikAnimal/received_events","type":"User","site_admin":false},{"login":"MaxSem","id":1260606,"avatar_url":"https://avatars2.githubusercontent.com/u/1260606?v=4","gravatar_id":"","url":"https://api.github.com/users/MaxSem","html_url":"https://github.com/MaxSem","followers_url":"https://api.github.com/users/MaxSem/followers","following_url":"https://api.github.com/users/MaxSem/following{/other_user}","gists_url":"https://api.github.com/users/MaxSem/gists{/gist_id}","starred_url":"https://api.github.com/users/MaxSem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaxSem/subscriptions","organizations_url":"https://api.github.com/users/MaxSem/orgs","repos_url":"https://api.github.com/users/MaxSem/repos","events_url":"https://api.github.com/users/MaxSem/events{/privacy}","received_events_url":"https://api.github.com/users/MaxSem/received_events","type":"User","site_admin":false},{"login":"kaldari","id":1707155,"avatar_url":"https://avatars0.githubusercontent.com/u/1707155?v=4","gravatar_id":"","url":"https://api.github.com/users/kaldari","html_url":"https://github.com/kaldari","followers_url":"https://api.github.com/users/kaldari/followers","following_url":"https://api.github.com/users/kaldari/following{/other_user}","gists_url":"https://api.github.com/users/kaldari/gists{/gist_id}","starred_url":"https://api.github.com/users/kaldari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaldari/subscriptions","organizations_url":"https://api.github.com/users/kaldari/orgs","repos_url":"https://api.github.com/users/kaldari/repos","events_url":"https://api.github.com/users/kaldari/events{/privacy}","received_events_url":"https://api.github.com/users/kaldari/received_events","type":"User","site_admin":false},{"login":"Niharika29","id":5735280,"avatar_url":"https://avatars1.githubusercontent.com/u/5735280?v=4","gravatar_id":"","url":"https://api.github.com/users/Niharika29","html_url":"https://github.com/Niharika29","followers_url":"https://api.github.com/users/Niharika29/followers","following_url":"https://api.github.com/users/Niharika29/following{/other_user}","gists_url":"https://api.github.com/users/Niharika29/gists{/gist_id}","starred_url":"https://api.github.com/users/Niharika29/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Niharika29/subscriptions","organizations_url":"https://api.github.com/users/Niharika29/orgs","repos_url":"https://api.github.com/users/Niharika29/repos","events_url":"https://api.github.com/users/Niharika29/events{/privacy}","received_events_url":"https://api.github.com/users/Niharika29/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/pulls/35/commits","review_comments_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/pulls/35/comments","review_comment_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/issues/35/comments","statuses_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/statuses/a0b739e719ce10fa1a4f07cd1508ed2a6da4ae21","head":{"label":"wikimedia:T185460","ref":"T185460","sha":"a0b739e719ce10fa1a4f07cd1508ed2a6da4ae21","user":{"login":"wikimedia","id":56668,"avatar_url":"https://avatars0.githubusercontent.com/u/56668?v=4","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"repo":{"id":108321676,"name":"InteractionTimeline","full_name":"wikimedia/InteractionTimeline","owner":{"login":"wikimedia","id":56668,"avatar_url":"https://avatars0.githubusercontent.com/u/56668?v=4","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wikimedia/InteractionTimeline","description":"User Interaction Timeline","fork":false,"url":"https://api.github.com/repos/wikimedia/InteractionTimeline","forks_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/forks","keys_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/teams","hooks_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/hooks","issue_events_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/issues/events{/number}","events_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/events","assignees_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/assignees{/user}","branches_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/branches{/branch}","tags_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/tags","blobs_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/statuses/{sha}","languages_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/languages","stargazers_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/stargazers","contributors_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/contributors","subscribers_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/subscribers","subscription_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/subscription","commits_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/issues/comments{/number}","contents_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/contents/{+path}","compare_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/merges","archive_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/downloads","issues_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/issues{/number}","pulls_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/pulls{/number}","milestones_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/milestones{/number}","notifications_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/labels{/name}","releases_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/releases{/id}","deployments_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/deployments","created_at":"2017-10-25T20:20:40Z","updated_at":"2017-10-29T19:49:10Z","pushed_at":"2018-02-13T06:59:19Z","git_url":"git://github.com/wikimedia/InteractionTimeline.git","ssh_url":"git@github.com:wikimedia/InteractionTimeline.git","clone_url":"https://github.com/wikimedia/InteractionTimeline.git","svn_url":"https://github.com/wikimedia/InteractionTimeline","homepage":"https://meta.wikimedia.org/wiki/Community_health_initiative/Interaction_Timeline","size":267,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"wikimedia:master","ref":"master","sha":"4e7d9943b5fd8ee5b5e21ae73c59b483de3271b3","user":{"login":"wikimedia","id":56668,"avatar_url":"https://avatars0.githubusercontent.com/u/56668?v=4","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"repo":{"id":108321676,"name":"InteractionTimeline","full_name":"wikimedia/InteractionTimeline","owner":{"login":"wikimedia","id":56668,"avatar_url":"https://avatars0.githubusercontent.com/u/56668?v=4","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wikimedia/InteractionTimeline","description":"User Interaction Timeline","fork":false,"url":"https://api.github.com/repos/wikimedia/InteractionTimeline","forks_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/forks","keys_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/teams","hooks_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/hooks","issue_events_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/issues/events{/number}","events_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/events","assignees_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/assignees{/user}","branches_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/branches{/branch}","tags_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/tags","blobs_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/statuses/{sha}","languages_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/languages","stargazers_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/stargazers","contributors_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/contributors","subscribers_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/subscribers","subscription_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/subscription","commits_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/issues/comments{/number}","contents_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/contents/{+path}","compare_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/merges","archive_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/downloads","issues_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/issues{/number}","pulls_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/pulls{/number}","milestones_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/milestones{/number}","notifications_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/labels{/name}","releases_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/releases{/id}","deployments_url":"https://api.github.com/repos/wikimedia/InteractionTimeline/deployments","created_at":"2017-10-25T20:20:40Z","updated_at":"2017-10-29T19:49:10Z","pushed_at":"2018-02-13T06:59:19Z","git_url":"git://github.com/wikimedia/InteractionTimeline.git","ssh_url":"git@github.com:wikimedia/InteractionTimeline.git","clone_url":"https://github.com/wikimedia/InteractionTimeline.git","svn_url":"https://github.com/wikimedia/InteractionTimeline","homepage":"https://meta.wikimedia.org/wiki/Community_health_initiative/Interaction_Timeline","size":267,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wikimedia/InteractionTimeline/pulls/35"},"html":{"href":"https://github.com/wikimedia/InteractionTimeline/pull/35"},"issue":{"href":"https://api.github.com/repos/wikimedia/InteractionTimeline/issues/35"},"comments":{"href":"https://api.github.com/repos/wikimedia/InteractionTimeline/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/wikimedia/InteractionTimeline/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/wikimedia/InteractionTimeline/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wikimedia/InteractionTimeline/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/wikimedia/InteractionTimeline/statuses/a0b739e719ce10fa1a4f07cd1508ed2a6da4ae21"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"davidbarratt"}}