{"action":"created","comment":{"url":"https://api.github.com/repos/haskell/cabal/pulls/comments/191673091","pull_request_review_id":124286307,"id":191673091,"diff_hunk":"@@ -432,17 +432,17 @@ optionsFieldGrammar\n optionsFieldGrammar = combine\n     <$> monoidalFieldAla \"ghc-options\"   (alaList' NoCommaFSep Token') (extract GHC)\n     <*> monoidalFieldAla \"ghcjs-options\" (alaList' NoCommaFSep Token') (extract GHCJS)\n-    <*> monoidalFieldAla \"jhc-options\"   (alaList' NoCommaFSep Token') (extract JHC)\n     -- NOTE: Hugs and NHC are not supported anymore, but these fields are kept","path":"Cabal/Distribution/PackageDescription/FieldGrammar.hs","position":5,"original_position":5,"commit_id":"d4714d0c291b53b8762b9a9a4e6cff0f9a1d1951","original_commit_id":"d4714d0c291b53b8762b9a9a4e6cff0f9a1d1951","user":{"login":"23Skidoo","id":47439,"avatar_url":"https://avatars3.githubusercontent.com/u/47439?v=4","gravatar_id":"","url":"https://api.github.com/users/23Skidoo","html_url":"https://github.com/23Skidoo","followers_url":"https://api.github.com/users/23Skidoo/followers","following_url":"https://api.github.com/users/23Skidoo/following{/other_user}","gists_url":"https://api.github.com/users/23Skidoo/gists{/gist_id}","starred_url":"https://api.github.com/users/23Skidoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/23Skidoo/subscriptions","organizations_url":"https://api.github.com/users/23Skidoo/orgs","repos_url":"https://api.github.com/users/23Skidoo/repos","events_url":"https://api.github.com/users/23Skidoo/events{/privacy}","received_events_url":"https://api.github.com/users/23Skidoo/received_events","type":"User","site_admin":false},"body":"We should either remove `{hugs,nhc98}-options` from here as well, or keep `jhc-options`.","created_at":"2018-05-30T07:55:48Z","updated_at":"2018-05-30T07:55:48Z","html_url":"https://github.com/haskell/cabal/pull/5347#discussion_r191673091","pull_request_url":"https://api.github.com/repos/haskell/cabal/pulls/5347","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/haskell/cabal/pulls/comments/191673091"},"html":{"href":"https://github.com/haskell/cabal/pull/5347#discussion_r191673091"},"pull_request":{"href":"https://api.github.com/repos/haskell/cabal/pulls/5347"}}},"pull_request":{"url":"https://api.github.com/repos/haskell/cabal/pulls/5347","id":190745248,"html_url":"https://github.com/haskell/cabal/pull/5347","diff_url":"https://github.com/haskell/cabal/pull/5347.diff","patch_url":"https://github.com/haskell/cabal/pull/5347.patch","issue_url":"https://api.github.com/repos/haskell/cabal/issues/5347","number":5347,"state":"open","locked":false,"title":"Remove jhc and uhc","user":{"login":"BardurArantsson","id":459138,"avatar_url":"https://avatars2.githubusercontent.com/u/459138?v=4","gravatar_id":"","url":"https://api.github.com/users/BardurArantsson","html_url":"https://github.com/BardurArantsson","followers_url":"https://api.github.com/users/BardurArantsson/followers","following_url":"https://api.github.com/users/BardurArantsson/following{/other_user}","gists_url":"https://api.github.com/users/BardurArantsson/gists{/gist_id}","starred_url":"https://api.github.com/users/BardurArantsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BardurArantsson/subscriptions","organizations_url":"https://api.github.com/users/BardurArantsson/orgs","repos_url":"https://api.github.com/users/BardurArantsson/repos","events_url":"https://api.github.com/users/BardurArantsson/events{/privacy}","received_events_url":"https://api.github.com/users/BardurArantsson/received_events","type":"User","site_admin":false},"body":"OK, here are the commits for removing the JHC/UHC compiler flavours.\r\n\r\nThere are a couple of opportunities for removing some function parameters at this point because they've become unused, but I'm not sure we can do that per compatibility requirements...? It's mostly the `defaultInstallDirs` and `defaultInstallDirs'` functions I'm thinking of.","created_at":"2018-05-26T14:50:23Z","updated_at":"2018-05-30T07:55:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2bfbce32079995a3d1c64d148a019d7d58ab4a03","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/haskell/cabal/pulls/5347/commits","review_comments_url":"https://api.github.com/repos/haskell/cabal/pulls/5347/comments","review_comment_url":"https://api.github.com/repos/haskell/cabal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/haskell/cabal/issues/5347/comments","statuses_url":"https://api.github.com/repos/haskell/cabal/statuses/d4714d0c291b53b8762b9a9a4e6cff0f9a1d1951","head":{"label":"BardurArantsson:remove-jhc-and-uhc","ref":"remove-jhc-and-uhc","sha":"d4714d0c291b53b8762b9a9a4e6cff0f9a1d1951","user":{"login":"BardurArantsson","id":459138,"avatar_url":"https://avatars2.githubusercontent.com/u/459138?v=4","gravatar_id":"","url":"https://api.github.com/users/BardurArantsson","html_url":"https://github.com/BardurArantsson","followers_url":"https://api.github.com/users/BardurArantsson/followers","following_url":"https://api.github.com/users/BardurArantsson/following{/other_user}","gists_url":"https://api.github.com/users/BardurArantsson/gists{/gist_id}","starred_url":"https://api.github.com/users/BardurArantsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BardurArantsson/subscriptions","organizations_url":"https://api.github.com/users/BardurArantsson/orgs","repos_url":"https://api.github.com/users/BardurArantsson/repos","events_url":"https://api.github.com/users/BardurArantsson/events{/privacy}","received_events_url":"https://api.github.com/users/BardurArantsson/received_events","type":"User","site_admin":false},"repo":{"id":37976724,"name":"cabal","full_name":"BardurArantsson/cabal","owner":{"login":"BardurArantsson","id":459138,"avatar_url":"https://avatars2.githubusercontent.com/u/459138?v=4","gravatar_id":"","url":"https://api.github.com/users/BardurArantsson","html_url":"https://github.com/BardurArantsson","followers_url":"https://api.github.com/users/BardurArantsson/followers","following_url":"https://api.github.com/users/BardurArantsson/following{/other_user}","gists_url":"https://api.github.com/users/BardurArantsson/gists{/gist_id}","starred_url":"https://api.github.com/users/BardurArantsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BardurArantsson/subscriptions","organizations_url":"https://api.github.com/users/BardurArantsson/orgs","repos_url":"https://api.github.com/users/BardurArantsson/repos","events_url":"https://api.github.com/users/BardurArantsson/events{/privacy}","received_events_url":"https://api.github.com/users/BardurArantsson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BardurArantsson/cabal","description":"Official upstream development repository for Cabal and cabal-install","fork":true,"url":"https://api.github.com/repos/BardurArantsson/cabal","forks_url":"https://api.github.com/repos/BardurArantsson/cabal/forks","keys_url":"https://api.github.com/repos/BardurArantsson/cabal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BardurArantsson/cabal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BardurArantsson/cabal/teams","hooks_url":"https://api.github.com/repos/BardurArantsson/cabal/hooks","issue_events_url":"https://api.github.com/repos/BardurArantsson/cabal/issues/events{/number}","events_url":"https://api.github.com/repos/BardurArantsson/cabal/events","assignees_url":"https://api.github.com/repos/BardurArantsson/cabal/assignees{/user}","branches_url":"https://api.github.com/repos/BardurArantsson/cabal/branches{/branch}","tags_url":"https://api.github.com/repos/BardurArantsson/cabal/tags","blobs_url":"https://api.github.com/repos/BardurArantsson/cabal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BardurArantsson/cabal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BardurArantsson/cabal/git/refs{/sha}","trees_url":"https://api.github.com/repos/BardurArantsson/cabal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BardurArantsson/cabal/statuses/{sha}","languages_url":"https://api.github.com/repos/BardurArantsson/cabal/languages","stargazers_url":"https://api.github.com/repos/BardurArantsson/cabal/stargazers","contributors_url":"https://api.github.com/repos/BardurArantsson/cabal/contributors","subscribers_url":"https://api.github.com/repos/BardurArantsson/cabal/subscribers","subscription_url":"https://api.github.com/repos/BardurArantsson/cabal/subscription","commits_url":"https://api.github.com/repos/BardurArantsson/cabal/commits{/sha}","git_commits_url":"https://api.github.com/repos/BardurArantsson/cabal/git/commits{/sha}","comments_url":"https://api.github.com/repos/BardurArantsson/cabal/comments{/number}","issue_comment_url":"https://api.github.com/repos/BardurArantsson/cabal/issues/comments{/number}","contents_url":"https://api.github.com/repos/BardurArantsson/cabal/contents/{+path}","compare_url":"https://api.github.com/repos/BardurArantsson/cabal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BardurArantsson/cabal/merges","archive_url":"https://api.github.com/repos/BardurArantsson/cabal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BardurArantsson/cabal/downloads","issues_url":"https://api.github.com/repos/BardurArantsson/cabal/issues{/number}","pulls_url":"https://api.github.com/repos/BardurArantsson/cabal/pulls{/number}","milestones_url":"https://api.github.com/repos/BardurArantsson/cabal/milestones{/number}","notifications_url":"https://api.github.com/repos/BardurArantsson/cabal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BardurArantsson/cabal/labels{/name}","releases_url":"https://api.github.com/repos/BardurArantsson/cabal/releases{/id}","deployments_url":"https://api.github.com/repos/BardurArantsson/cabal/deployments","created_at":"2015-06-24T09:57:16Z","updated_at":"2016-01-17T08:29:05Z","pushed_at":"2018-05-26T16:18:34Z","git_url":"git://github.com/BardurArantsson/cabal.git","ssh_url":"git@github.com:BardurArantsson/cabal.git","clone_url":"https://github.com/BardurArantsson/cabal.git","svn_url":"https://github.com/BardurArantsson/cabal","homepage":"http://haskell.org/cabal","size":29325,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"haskell:master","ref":"master","sha":"7783ad1a6a3c8ba30757e2e329e891509f86b9bf","user":{"login":"haskell","id":450574,"avatar_url":"https://avatars1.githubusercontent.com/u/450574?v=4","gravatar_id":"","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"repo":{"id":3728161,"name":"cabal","full_name":"haskell/cabal","owner":{"login":"haskell","id":450574,"avatar_url":"https://avatars1.githubusercontent.com/u/450574?v=4","gravatar_id":"","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/haskell/cabal","description":"Official upstream development repository for Cabal and cabal-install","fork":false,"url":"https://api.github.com/repos/haskell/cabal","forks_url":"https://api.github.com/repos/haskell/cabal/forks","keys_url":"https://api.github.com/repos/haskell/cabal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haskell/cabal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haskell/cabal/teams","hooks_url":"https://api.github.com/repos/haskell/cabal/hooks","issue_events_url":"https://api.github.com/repos/haskell/cabal/issues/events{/number}","events_url":"https://api.github.com/repos/haskell/cabal/events","assignees_url":"https://api.github.com/repos/haskell/cabal/assignees{/user}","branches_url":"https://api.github.com/repos/haskell/cabal/branches{/branch}","tags_url":"https://api.github.com/repos/haskell/cabal/tags","blobs_url":"https://api.github.com/repos/haskell/cabal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haskell/cabal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haskell/cabal/git/refs{/sha}","trees_url":"https://api.github.com/repos/haskell/cabal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haskell/cabal/statuses/{sha}","languages_url":"https://api.github.com/repos/haskell/cabal/languages","stargazers_url":"https://api.github.com/repos/haskell/cabal/stargazers","contributors_url":"https://api.github.com/repos/haskell/cabal/contributors","subscribers_url":"https://api.github.com/repos/haskell/cabal/subscribers","subscription_url":"https://api.github.com/repos/haskell/cabal/subscription","commits_url":"https://api.github.com/repos/haskell/cabal/commits{/sha}","git_commits_url":"https://api.github.com/repos/haskell/cabal/git/commits{/sha}","comments_url":"https://api.github.com/repos/haskell/cabal/comments{/number}","issue_comment_url":"https://api.github.com/repos/haskell/cabal/issues/comments{/number}","contents_url":"https://api.github.com/repos/haskell/cabal/contents/{+path}","compare_url":"https://api.github.com/repos/haskell/cabal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haskell/cabal/merges","archive_url":"https://api.github.com/repos/haskell/cabal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haskell/cabal/downloads","issues_url":"https://api.github.com/repos/haskell/cabal/issues{/number}","pulls_url":"https://api.github.com/repos/haskell/cabal/pulls{/number}","milestones_url":"https://api.github.com/repos/haskell/cabal/milestones{/number}","notifications_url":"https://api.github.com/repos/haskell/cabal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haskell/cabal/labels{/name}","releases_url":"https://api.github.com/repos/haskell/cabal/releases{/id}","deployments_url":"https://api.github.com/repos/haskell/cabal/deployments","created_at":"2012-03-15T12:53:38Z","updated_at":"2018-05-29T14:18:24Z","pushed_at":"2018-05-29T14:52:42Z","git_url":"git://github.com/haskell/cabal.git","ssh_url":"git@github.com:haskell/cabal.git","clone_url":"https://github.com/haskell/cabal.git","svn_url":"https://github.com/haskell/cabal","homepage":"http://haskell.org/cabal","size":31854,"stargazers_count":853,"watchers_count":853,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":435,"mirror_url":null,"archived":false,"open_issues_count":1042,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":435,"open_issues":1042,"watchers":853,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/haskell/cabal/pulls/5347"},"html":{"href":"https://github.com/haskell/cabal/pull/5347"},"issue":{"href":"https://api.github.com/repos/haskell/cabal/issues/5347"},"comments":{"href":"https://api.github.com/repos/haskell/cabal/issues/5347/comments"},"review_comments":{"href":"https://api.github.com/repos/haskell/cabal/pulls/5347/comments"},"review_comment":{"href":"https://api.github.com/repos/haskell/cabal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/haskell/cabal/pulls/5347/commits"},"statuses":{"href":"https://api.github.com/repos/haskell/cabal/statuses/d4714d0c291b53b8762b9a9a4e6cff0f9a1d1951"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"23Skidoo"}}