{"action":"created","comment":{"url":"https://api.github.com/repos/graphhopper/directions-api-clients/pulls/comments/183276950","pull_request_review_id":114243520,"id":183276950,"diff_hunk":"@@ -128,6 +128,16 @@\n                         \"description\": \"If `true` u-turns are avoided at via-points with regard to the `heading_penalty`.\",\n                         \"type\": \"boolean\"\n                     },\n+                    {\n+                        \"name\": \"details\",\n+                        \"in\": \"query\",\n+                        \"description\": \"List of additional trip attributes to be returned. Try some of the following: `average_speed`, `street_name`, `edge_id`, `time`\",","path":"swagger.json","position":null,"original_position":7,"commit_id":"bd9a3f92e24c9ac378841d6f794a4ac3a5a60e28","original_commit_id":"783d19643888c650280e74669417a44630538e88","user":{"login":"boldtrn","id":1553525,"avatar_url":"https://avatars3.githubusercontent.com/u/1553525?v=4","gravatar_id":"","url":"https://api.github.com/users/boldtrn","html_url":"https://github.com/boldtrn","followers_url":"https://api.github.com/users/boldtrn/followers","following_url":"https://api.github.com/users/boldtrn/following{/other_user}","gists_url":"https://api.github.com/users/boldtrn/gists{/gist_id}","starred_url":"https://api.github.com/users/boldtrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boldtrn/subscriptions","organizations_url":"https://api.github.com/users/boldtrn/orgs","repos_url":"https://api.github.com/users/boldtrn/repos","events_url":"https://api.github.com/users/boldtrn/events{/privacy}","received_events_url":"https://api.github.com/users/boldtrn/received_events","type":"User","site_admin":false},"body":"> Or is this a free-form parameter, like a \"hint\", and the server can change without the specification changing?\r\n\r\nIt's not like a hint, if you specify a PathDetail that is not known to the server, you will receive an error. We could add new ones, without changing the spec. But I think we should specify every existing PathDetail, otherwise clients have to guess what PathDetails are available or not. That's why I mentioned that it might make sense to link to the official doc.","created_at":"2018-04-23T04:59:42Z","updated_at":"2018-04-23T04:59:42Z","html_url":"https://github.com/graphhopper/directions-api-clients/pull/25#discussion_r183276950","pull_request_url":"https://api.github.com/repos/graphhopper/directions-api-clients/pulls/25","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/graphhopper/directions-api-clients/pulls/comments/183276950"},"html":{"href":"https://github.com/graphhopper/directions-api-clients/pull/25#discussion_r183276950"},"pull_request":{"href":"https://api.github.com/repos/graphhopper/directions-api-clients/pulls/25"}},"in_reply_to_id":183262656},"pull_request":{"url":"https://api.github.com/repos/graphhopper/directions-api-clients/pulls/25","id":183306875,"html_url":"https://github.com/graphhopper/directions-api-clients/pull/25","diff_url":"https://github.com/graphhopper/directions-api-clients/pull/25.diff","patch_url":"https://github.com/graphhopper/directions-api-clients/pull/25.patch","issue_url":"https://api.github.com/repos/graphhopper/directions-api-clients/issues/25","number":25,"state":"closed","locked":false,"title":"Path Details","user":{"login":"michaz","id":520916,"avatar_url":"https://avatars3.githubusercontent.com/u/520916?v=4","gravatar_id":"","url":"https://api.github.com/users/michaz","html_url":"https://github.com/michaz","followers_url":"https://api.github.com/users/michaz/followers","following_url":"https://api.github.com/users/michaz/following{/other_user}","gists_url":"https://api.github.com/users/michaz/gists{/gist_id}","starred_url":"https://api.github.com/users/michaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaz/subscriptions","organizations_url":"https://api.github.com/users/michaz/orgs","repos_url":"https://api.github.com/users/michaz/repos","events_url":"https://api.github.com/users/michaz/events{/privacy}","received_events_url":"https://api.github.com/users/michaz/received_events","type":"User","site_admin":false},"body":"My best effort at including path details.","created_at":"2018-04-23T01:26:03Z","updated_at":"2018-04-23T04:59:42Z","closed_at":"2018-04-23T02:11:07Z","merged_at":"2018-04-23T02:11:06Z","merge_commit_sha":"f4c031c5eba9fca2b4e3b411ca49c6c8f467f618","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/graphhopper/directions-api-clients/pulls/25/commits","review_comments_url":"https://api.github.com/repos/graphhopper/directions-api-clients/pulls/25/comments","review_comment_url":"https://api.github.com/repos/graphhopper/directions-api-clients/pulls/comments{/number}","comments_url":"https://api.github.com/repos/graphhopper/directions-api-clients/issues/25/comments","statuses_url":"https://api.github.com/repos/graphhopper/directions-api-clients/statuses/bd9a3f92e24c9ac378841d6f794a4ac3a5a60e28","head":{"label":"graphhopper:pathdetails","ref":"pathdetails","sha":"bd9a3f92e24c9ac378841d6f794a4ac3a5a60e28","user":{"login":"graphhopper","id":2264498,"avatar_url":"https://avatars1.githubusercontent.com/u/2264498?v=4","gravatar_id":"","url":"https://api.github.com/users/graphhopper","html_url":"https://github.com/graphhopper","followers_url":"https://api.github.com/users/graphhopper/followers","following_url":"https://api.github.com/users/graphhopper/following{/other_user}","gists_url":"https://api.github.com/users/graphhopper/gists{/gist_id}","starred_url":"https://api.github.com/users/graphhopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphhopper/subscriptions","organizations_url":"https://api.github.com/users/graphhopper/orgs","repos_url":"https://api.github.com/users/graphhopper/repos","events_url":"https://api.github.com/users/graphhopper/events{/privacy}","received_events_url":"https://api.github.com/users/graphhopper/received_events","type":"Organization","site_admin":false},"repo":{"id":78486123,"name":"directions-api-clients","full_name":"graphhopper/directions-api-clients","owner":{"login":"graphhopper","id":2264498,"avatar_url":"https://avatars1.githubusercontent.com/u/2264498?v=4","gravatar_id":"","url":"https://api.github.com/users/graphhopper","html_url":"https://github.com/graphhopper","followers_url":"https://api.github.com/users/graphhopper/followers","following_url":"https://api.github.com/users/graphhopper/following{/other_user}","gists_url":"https://api.github.com/users/graphhopper/gists{/gist_id}","starred_url":"https://api.github.com/users/graphhopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphhopper/subscriptions","organizations_url":"https://api.github.com/users/graphhopper/orgs","repos_url":"https://api.github.com/users/graphhopper/repos","events_url":"https://api.github.com/users/graphhopper/events{/privacy}","received_events_url":"https://api.github.com/users/graphhopper/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/graphhopper/directions-api-clients","description":"API clients for various languages for the GraphHopper Directions API","fork":false,"url":"https://api.github.com/repos/graphhopper/directions-api-clients","forks_url":"https://api.github.com/repos/graphhopper/directions-api-clients/forks","keys_url":"https://api.github.com/repos/graphhopper/directions-api-clients/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graphhopper/directions-api-clients/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graphhopper/directions-api-clients/teams","hooks_url":"https://api.github.com/repos/graphhopper/directions-api-clients/hooks","issue_events_url":"https://api.github.com/repos/graphhopper/directions-api-clients/issues/events{/number}","events_url":"https://api.github.com/repos/graphhopper/directions-api-clients/events","assignees_url":"https://api.github.com/repos/graphhopper/directions-api-clients/assignees{/user}","branches_url":"https://api.github.com/repos/graphhopper/directions-api-clients/branches{/branch}","tags_url":"https://api.github.com/repos/graphhopper/directions-api-clients/tags","blobs_url":"https://api.github.com/repos/graphhopper/directions-api-clients/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graphhopper/directions-api-clients/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graphhopper/directions-api-clients/git/refs{/sha}","trees_url":"https://api.github.com/repos/graphhopper/directions-api-clients/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graphhopper/directions-api-clients/statuses/{sha}","languages_url":"https://api.github.com/repos/graphhopper/directions-api-clients/languages","stargazers_url":"https://api.github.com/repos/graphhopper/directions-api-clients/stargazers","contributors_url":"https://api.github.com/repos/graphhopper/directions-api-clients/contributors","subscribers_url":"https://api.github.com/repos/graphhopper/directions-api-clients/subscribers","subscription_url":"https://api.github.com/repos/graphhopper/directions-api-clients/subscription","commits_url":"https://api.github.com/repos/graphhopper/directions-api-clients/commits{/sha}","git_commits_url":"https://api.github.com/repos/graphhopper/directions-api-clients/git/commits{/sha}","comments_url":"https://api.github.com/repos/graphhopper/directions-api-clients/comments{/number}","issue_comment_url":"https://api.github.com/repos/graphhopper/directions-api-clients/issues/comments{/number}","contents_url":"https://api.github.com/repos/graphhopper/directions-api-clients/contents/{+path}","compare_url":"https://api.github.com/repos/graphhopper/directions-api-clients/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graphhopper/directions-api-clients/merges","archive_url":"https://api.github.com/repos/graphhopper/directions-api-clients/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graphhopper/directions-api-clients/downloads","issues_url":"https://api.github.com/repos/graphhopper/directions-api-clients/issues{/number}","pulls_url":"https://api.github.com/repos/graphhopper/directions-api-clients/pulls{/number}","milestones_url":"https://api.github.com/repos/graphhopper/directions-api-clients/milestones{/number}","notifications_url":"https://api.github.com/repos/graphhopper/directions-api-clients/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graphhopper/directions-api-clients/labels{/name}","releases_url":"https://api.github.com/repos/graphhopper/directions-api-clients/releases{/id}","deployments_url":"https://api.github.com/repos/graphhopper/directions-api-clients/deployments","created_at":"2017-01-10T01:38:17Z","updated_at":"2018-04-23T02:11:08Z","pushed_at":"2018-04-23T02:42:24Z","git_url":"git://github.com/graphhopper/directions-api-clients.git","ssh_url":"git@github.com:graphhopper/directions-api-clients.git","clone_url":"https://github.com/graphhopper/directions-api-clients.git","svn_url":"https://github.com/graphhopper/directions-api-clients","homepage":"https://graphhopper.com/api/1/docs/","size":2363,"stargazers_count":11,"watchers_count":11,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":8,"open_issues":10,"watchers":11,"default_branch":"master"}},"base":{"label":"graphhopper:master","ref":"master","sha":"e192d2ea6b80bdbf5baefbadf23c6ac41ccb200d","user":{"login":"graphhopper","id":2264498,"avatar_url":"https://avatars1.githubusercontent.com/u/2264498?v=4","gravatar_id":"","url":"https://api.github.com/users/graphhopper","html_url":"https://github.com/graphhopper","followers_url":"https://api.github.com/users/graphhopper/followers","following_url":"https://api.github.com/users/graphhopper/following{/other_user}","gists_url":"https://api.github.com/users/graphhopper/gists{/gist_id}","starred_url":"https://api.github.com/users/graphhopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphhopper/subscriptions","organizations_url":"https://api.github.com/users/graphhopper/orgs","repos_url":"https://api.github.com/users/graphhopper/repos","events_url":"https://api.github.com/users/graphhopper/events{/privacy}","received_events_url":"https://api.github.com/users/graphhopper/received_events","type":"Organization","site_admin":false},"repo":{"id":78486123,"name":"directions-api-clients","full_name":"graphhopper/directions-api-clients","owner":{"login":"graphhopper","id":2264498,"avatar_url":"https://avatars1.githubusercontent.com/u/2264498?v=4","gravatar_id":"","url":"https://api.github.com/users/graphhopper","html_url":"https://github.com/graphhopper","followers_url":"https://api.github.com/users/graphhopper/followers","following_url":"https://api.github.com/users/graphhopper/following{/other_user}","gists_url":"https://api.github.com/users/graphhopper/gists{/gist_id}","starred_url":"https://api.github.com/users/graphhopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphhopper/subscriptions","organizations_url":"https://api.github.com/users/graphhopper/orgs","repos_url":"https://api.github.com/users/graphhopper/repos","events_url":"https://api.github.com/users/graphhopper/events{/privacy}","received_events_url":"https://api.github.com/users/graphhopper/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/graphhopper/directions-api-clients","description":"API clients for various languages for the GraphHopper Directions API","fork":false,"url":"https://api.github.com/repos/graphhopper/directions-api-clients","forks_url":"https://api.github.com/repos/graphhopper/directions-api-clients/forks","keys_url":"https://api.github.com/repos/graphhopper/directions-api-clients/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graphhopper/directions-api-clients/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graphhopper/directions-api-clients/teams","hooks_url":"https://api.github.com/repos/graphhopper/directions-api-clients/hooks","issue_events_url":"https://api.github.com/repos/graphhopper/directions-api-clients/issues/events{/number}","events_url":"https://api.github.com/repos/graphhopper/directions-api-clients/events","assignees_url":"https://api.github.com/repos/graphhopper/directions-api-clients/assignees{/user}","branches_url":"https://api.github.com/repos/graphhopper/directions-api-clients/branches{/branch}","tags_url":"https://api.github.com/repos/graphhopper/directions-api-clients/tags","blobs_url":"https://api.github.com/repos/graphhopper/directions-api-clients/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graphhopper/directions-api-clients/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graphhopper/directions-api-clients/git/refs{/sha}","trees_url":"https://api.github.com/repos/graphhopper/directions-api-clients/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graphhopper/directions-api-clients/statuses/{sha}","languages_url":"https://api.github.com/repos/graphhopper/directions-api-clients/languages","stargazers_url":"https://api.github.com/repos/graphhopper/directions-api-clients/stargazers","contributors_url":"https://api.github.com/repos/graphhopper/directions-api-clients/contributors","subscribers_url":"https://api.github.com/repos/graphhopper/directions-api-clients/subscribers","subscription_url":"https://api.github.com/repos/graphhopper/directions-api-clients/subscription","commits_url":"https://api.github.com/repos/graphhopper/directions-api-clients/commits{/sha}","git_commits_url":"https://api.github.com/repos/graphhopper/directions-api-clients/git/commits{/sha}","comments_url":"https://api.github.com/repos/graphhopper/directions-api-clients/comments{/number}","issue_comment_url":"https://api.github.com/repos/graphhopper/directions-api-clients/issues/comments{/number}","contents_url":"https://api.github.com/repos/graphhopper/directions-api-clients/contents/{+path}","compare_url":"https://api.github.com/repos/graphhopper/directions-api-clients/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graphhopper/directions-api-clients/merges","archive_url":"https://api.github.com/repos/graphhopper/directions-api-clients/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graphhopper/directions-api-clients/downloads","issues_url":"https://api.github.com/repos/graphhopper/directions-api-clients/issues{/number}","pulls_url":"https://api.github.com/repos/graphhopper/directions-api-clients/pulls{/number}","milestones_url":"https://api.github.com/repos/graphhopper/directions-api-clients/milestones{/number}","notifications_url":"https://api.github.com/repos/graphhopper/directions-api-clients/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graphhopper/directions-api-clients/labels{/name}","releases_url":"https://api.github.com/repos/graphhopper/directions-api-clients/releases{/id}","deployments_url":"https://api.github.com/repos/graphhopper/directions-api-clients/deployments","created_at":"2017-01-10T01:38:17Z","updated_at":"2018-04-23T02:11:08Z","pushed_at":"2018-04-23T02:42:24Z","git_url":"git://github.com/graphhopper/directions-api-clients.git","ssh_url":"git@github.com:graphhopper/directions-api-clients.git","clone_url":"https://github.com/graphhopper/directions-api-clients.git","svn_url":"https://github.com/graphhopper/directions-api-clients","homepage":"https://graphhopper.com/api/1/docs/","size":2363,"stargazers_count":11,"watchers_count":11,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":8,"open_issues":10,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/graphhopper/directions-api-clients/pulls/25"},"html":{"href":"https://github.com/graphhopper/directions-api-clients/pull/25"},"issue":{"href":"https://api.github.com/repos/graphhopper/directions-api-clients/issues/25"},"comments":{"href":"https://api.github.com/repos/graphhopper/directions-api-clients/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/graphhopper/directions-api-clients/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/graphhopper/directions-api-clients/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/graphhopper/directions-api-clients/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/graphhopper/directions-api-clients/statuses/bd9a3f92e24c9ac378841d6f794a4ac3a5a60e28"}},"author_association":"OWNER"}}
{"actor":{"display_login":"boldtrn"}}