{"action":"created","issue":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/11995","repository_url":"https://api.github.com/repos/PrestaShop/PrestaShop","labels_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/11995/labels{/name}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/11995/comments","events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/11995/events","html_url":"https://github.com/PrestaShop/PrestaShop/pull/11995","id":395101394,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNjQ0NjU0","number":11995,"title":"Fix undefined INTL_IDNA_VARIANT_UTS46 if intl ICU < 4.6","user":{"login":"rdy4ever","id":12268701,"node_id":"MDQ6VXNlcjEyMjY4NzAx","avatar_url":"https://avatars2.githubusercontent.com/u/12268701?v=4","gravatar_id":"","url":"https://api.github.com/users/rdy4ever","html_url":"https://github.com/rdy4ever","followers_url":"https://api.github.com/users/rdy4ever/followers","following_url":"https://api.github.com/users/rdy4ever/following{/other_user}","gists_url":"https://api.github.com/users/rdy4ever/gists{/gist_id}","starred_url":"https://api.github.com/users/rdy4ever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdy4ever/subscriptions","organizations_url":"https://api.github.com/users/rdy4ever/orgs","repos_url":"https://api.github.com/users/rdy4ever/repos","events_url":"https://api.github.com/users/rdy4ever/events{/privacy}","received_events_url":"https://api.github.com/users/rdy4ever/received_events","type":"User","site_admin":false},"labels":[{"id":940326432,"node_id":"MDU6TGFiZWw5NDAzMjY0MzI=","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/1.7.5.x","name":"1.7.5.x","color":"6270ea","default":false},{"id":19737369,"node_id":"MDU6TGFiZWwxOTczNzM2OQ==","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/Bug","name":"Bug","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2019-01-01T17:58:41Z","updated_at":"2019-01-02T09:10:10Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/11995","html_url":"https://github.com/PrestaShop/PrestaShop/pull/11995","diff_url":"https://github.com/PrestaShop/PrestaShop/pull/11995.diff","patch_url":"https://github.com/PrestaShop/PrestaShop/pull/11995.patch"},"body":"<!--\r\nThank you for contributing to the PrestaShop project! \r\n\r\nPlease take the time to edit the \"Answers\" rows with the necessary information.\r\n\r\nCheck out our contribution guidelines to find out how to complete it:\r\nhttps://devdocs.prestashop.com/1.7/contribute/contribution-guidelines/#pull-requests\r\n -->\r\n\r\n| Questions     | Answers\r\n| ------------- | -------------------------------------------------------\r\n| Branch?       | 1.7.5.x\r\n| Description?  | #11579 introduced `INTL_IDNA_VARIANT_UTS46`  in the `idn_to_ascii` function, in order to comply with PHP 7.2 standards.<br>However, this broke e-mail sending for servers running an outdated ICU version (< 4.6). Figures out, there are more shared hostings that run outdated ICU versions with new PHP versions than expected and we should expect to see more and more issues regarding mail sending as more people will upgrade to PS 1.7.5.0. <br>This PR aims to silently fix this issue. If `INTL_IDNA_VARIANT_UTS46` is defined, use it to comply with PHP 7.2 standards. If it's not defined, then use the old `INTL_IDNA_VARIANT_2003` as long as it is [still supported by PHP](https://wiki.php.net/rfc/deprecate-and-remove-intl_idna_variant_2003) (up to the next major release, which will be 8.0.0). In PHP 7.2.0 up to 7.4.0, using `INTL_IDNA_VARIANT_2003` will trigger `E_DEPRECATED` notices while still being the default for the `idn_to_ascii` function and still working. From PHP 7.4.0 up to next major release, the default will be `INTL_IDNA_VARIANT_UTS46` but `INTL_IDNA_VARIANT_2003` will still work with warnings. From PHP 8.0.0, we cannot longer use `INTL_IDNA_VARIANT_2003` so we'll use the current default. If a server will run the outdated ICU <4.6 and PHP >= 8.0.0, an Exception will be triggered, but untill PS will be compatible with PHP 8.0 there is enough time to for most hosts to upgrade their ICU version.\r\n| Type?         | bug fix\r\n| Category?     | CO\r\n| BC breaks?    | Does it break backward compatibility?no\r\n| Deprecations? | Does it deprecate an existing feature? no\r\n| Fixed ticket? | Fixes #11933, #11949\r\n| How to test?  | Try to send an email from the order page from a server running intl ICU < 4.6. With this fix, it will work. Without, you will get an error 500 both in BO and in FO when customer tries to register, reset password, etc.\r\n\r\n<!-- Click the form's \"Preview\" button to make sure the table is functional in GitHub. Thank you! -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/prestashop/prestashop/11995)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/comments/450814445","html_url":"https://github.com/PrestaShop/PrestaShop/pull/11995#issuecomment-450814445","issue_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/11995","id":450814445,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDgxNDQ0NQ==","user":{"login":"PierreRambaud","id":1462701,"node_id":"MDQ6VXNlcjE0NjI3MDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1462701?v=4","gravatar_id":"","url":"https://api.github.com/users/PierreRambaud","html_url":"https://github.com/PierreRambaud","followers_url":"https://api.github.com/users/PierreRambaud/followers","following_url":"https://api.github.com/users/PierreRambaud/following{/other_user}","gists_url":"https://api.github.com/users/PierreRambaud/gists{/gist_id}","starred_url":"https://api.github.com/users/PierreRambaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PierreRambaud/subscriptions","organizations_url":"https://api.github.com/users/PierreRambaud/orgs","repos_url":"https://api.github.com/users/PierreRambaud/repos","events_url":"https://api.github.com/users/PierreRambaud/events{/privacy}","received_events_url":"https://api.github.com/users/PierreRambaud/received_events","type":"User","site_admin":false},"created_at":"2019-01-02T09:10:10Z","updated_at":"2019-01-02T09:10:10Z","author_association":"CONTRIBUTOR","body":"I think we need to target 1.7.5.1. @eternoendless This one is important."}}
{"actor":{"display_login":"PierreRambaud"}}