{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/issues/511","repository_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv","labels_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/issues/511/labels{/name}","comments_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/issues/511/comments","events_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/issues/511/events","html_url":"https://github.com/mozilla-mobile/firefox-tv/issues/511","id":298820472,"number":511,"title":"Get titles for custom home tiles","user":{"login":"mcomella","id":759372,"avatar_url":"https://avatars3.githubusercontent.com/u/759372?v=4","gravatar_id":"","url":"https://api.github.com/users/mcomella","html_url":"https://github.com/mcomella","followers_url":"https://api.github.com/users/mcomella/followers","following_url":"https://api.github.com/users/mcomella/following{/other_user}","gists_url":"https://api.github.com/users/mcomella/gists{/gist_id}","starred_url":"https://api.github.com/users/mcomella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcomella/subscriptions","organizations_url":"https://api.github.com/users/mcomella/orgs","repos_url":"https://api.github.com/users/mcomella/repos","events_url":"https://api.github.com/users/mcomella/events{/privacy}","received_events_url":"https://api.github.com/users/mcomella/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"lime124","id":287322,"avatar_url":"https://avatars1.githubusercontent.com/u/287322?v=4","gravatar_id":"","url":"https://api.github.com/users/lime124","html_url":"https://github.com/lime124","followers_url":"https://api.github.com/users/lime124/followers","following_url":"https://api.github.com/users/lime124/following{/other_user}","gists_url":"https://api.github.com/users/lime124/gists{/gist_id}","starred_url":"https://api.github.com/users/lime124/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lime124/subscriptions","organizations_url":"https://api.github.com/users/lime124/orgs","repos_url":"https://api.github.com/users/lime124/repos","events_url":"https://api.github.com/users/lime124/events{/privacy}","received_events_url":"https://api.github.com/users/lime124/received_events","type":"User","site_admin":false},"assignees":[{"login":"lime124","id":287322,"avatar_url":"https://avatars1.githubusercontent.com/u/287322?v=4","gravatar_id":"","url":"https://api.github.com/users/lime124","html_url":"https://github.com/lime124","followers_url":"https://api.github.com/users/lime124/followers","following_url":"https://api.github.com/users/lime124/following{/other_user}","gists_url":"https://api.github.com/users/lime124/gists{/gist_id}","starred_url":"https://api.github.com/users/lime124/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lime124/subscriptions","organizations_url":"https://api.github.com/users/lime124/orgs","repos_url":"https://api.github.com/users/lime124/repos","events_url":"https://api.github.com/users/lime124/events{/privacy}","received_events_url":"https://api.github.com/users/lime124/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/milestones/8","html_url":"https://github.com/mozilla-mobile/firefox-tv/milestone/8","labels_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/milestones/8/labels","id":3012917,"number":8,"title":"v2.0","description":"For release on March 13.","creator":{"login":"bbinto","id":122897,"avatar_url":"https://avatars1.githubusercontent.com/u/122897?v=4","gravatar_id":"","url":"https://api.github.com/users/bbinto","html_url":"https://github.com/bbinto","followers_url":"https://api.github.com/users/bbinto/followers","following_url":"https://api.github.com/users/bbinto/following{/other_user}","gists_url":"https://api.github.com/users/bbinto/gists{/gist_id}","starred_url":"https://api.github.com/users/bbinto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbinto/subscriptions","organizations_url":"https://api.github.com/users/bbinto/orgs","repos_url":"https://api.github.com/users/bbinto/repos","events_url":"https://api.github.com/users/bbinto/events{/privacy}","received_events_url":"https://api.github.com/users/bbinto/received_events","type":"User","site_admin":false},"open_issues":23,"closed_issues":8,"state":"open","created_at":"2018-01-04T13:46:24Z","updated_at":"2018-02-21T18:45:16Z","due_on":"2018-03-07T08:00:00Z","closed_at":null},"comments":0,"created_at":"2018-02-21T02:26:29Z","updated_at":"2018-02-21T19:39:36Z","closed_at":null,"author_association":"OWNER","body":"In desktop AS, [titles appear to come from `link.label || link.hostname`](https://github.com/mozilla/activity-stream/blob/2456e6e386b54f6627422da85a895eeafc1fc379/system-addon/content-src/components/TopSites/TopSite.jsx#L163) where:\r\n- `link.label` appears to be [a user defined value](https://github.com/mozilla/activity-stream/blob/2456e6e386b54f6627422da85a895eeafc1fc379/system-addon/content-src/components/TopSites/TopSiteForm.jsx#L54)\r\n- `link.hostname`, from my memory with fennec AS and without digging into the code, is `subdomain.domain` e.g. `bugzilla.mozilla` for bugzilla.mozilla.org\r\n\r\nOne problem I see here: if a user pins two sites from the same \"subdomain.domain\", the titles will be identical as will the icons if a screenshot isn't used. Desktop gets around this by 1) not choosing two sites from the same \"subdomain.domain\" and, 2) if a user adds another one, allowing the user to customize the title.\r\n\r\n@lime124 How do we want to solve this (since we don't allow custom titles, afaik)? fwiw, in fennec, we had a more complicated title scheme that we can borrow (something like if there's a collision, we use the page titles instead, or display some of the page path).\r\n\r\nTODO:\r\n- Steal [\"subdomain.domain\" code from fennec](https://searchfox.org/mozilla-central/rev/47cb352984bac15c476dcd75f8360f902673cb98/mobile/android/base/java/org/mozilla/gecko/util/URIUtils.java#88) (since removing TLD is non-trivial otherwise).\r\n- Hook up subdomain.domain extraction to the overlay (blocked on #441)"},"comment":{"url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/issues/comments/367445729","html_url":"https://github.com/mozilla-mobile/firefox-tv/issues/511#issuecomment-367445729","issue_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/issues/511","id":367445729,"user":{"login":"lime124","id":287322,"avatar_url":"https://avatars1.githubusercontent.com/u/287322?v=4","gravatar_id":"","url":"https://api.github.com/users/lime124","html_url":"https://github.com/lime124","followers_url":"https://api.github.com/users/lime124/followers","following_url":"https://api.github.com/users/lime124/following{/other_user}","gists_url":"https://api.github.com/users/lime124/gists{/gist_id}","starred_url":"https://api.github.com/users/lime124/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lime124/subscriptions","organizations_url":"https://api.github.com/users/lime124/orgs","repos_url":"https://api.github.com/users/lime124/repos","events_url":"https://api.github.com/users/lime124/events{/privacy}","received_events_url":"https://api.github.com/users/lime124/received_events","type":"User","site_admin":false},"created_at":"2018-02-21T19:39:36Z","updated_at":"2018-02-21T19:39:36Z","author_association":"NONE","body":"@mcomella and I chatted in slack and settled on implementing what fennec does until we are able to implement the ability that let's people edit the name. "}}
{"actor":{"display_login":"lime124"}}