{"action":"created","issue":{"url":"https://api.github.com/repos/KiCad/kicad-symbols/issues/1197","repository_url":"https://api.github.com/repos/KiCad/kicad-symbols","labels_url":"https://api.github.com/repos/KiCad/kicad-symbols/issues/1197/labels{/name}","comments_url":"https://api.github.com/repos/KiCad/kicad-symbols/issues/1197/comments","events_url":"https://api.github.com/repos/KiCad/kicad-symbols/issues/1197/events","html_url":"https://github.com/KiCad/kicad-symbols/pull/1197","id":386573553,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MjY3OTU3","number":1197,"title":"Analog ADC: create ADS8684 and ADS8688","user":{"login":"myfreescalewebpage","id":16516760,"node_id":"MDQ6VXNlcjE2NTE2NzYw","avatar_url":"https://avatars3.githubusercontent.com/u/16516760?v=4","gravatar_id":"","url":"https://api.github.com/users/myfreescalewebpage","html_url":"https://github.com/myfreescalewebpage","followers_url":"https://api.github.com/users/myfreescalewebpage/followers","following_url":"https://api.github.com/users/myfreescalewebpage/following{/other_user}","gists_url":"https://api.github.com/users/myfreescalewebpage/gists{/gist_id}","starred_url":"https://api.github.com/users/myfreescalewebpage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myfreescalewebpage/subscriptions","organizations_url":"https://api.github.com/users/myfreescalewebpage/orgs","repos_url":"https://api.github.com/users/myfreescalewebpage/repos","events_url":"https://api.github.com/users/myfreescalewebpage/events{/privacy}","received_events_url":"https://api.github.com/users/myfreescalewebpage/received_events","type":"User","site_admin":false},"labels":[{"id":1079035528,"node_id":"MDU6TGFiZWwxMDc5MDM1NTI4","url":"https://api.github.com/repos/KiCad/kicad-symbols/labels/Addition","name":"Addition","color":"98e88d","default":false},{"id":1079030025,"node_id":"MDU6TGFiZWwxMDc5MDMwMDI1","url":"https://api.github.com/repos/KiCad/kicad-symbols/labels/Pending%20reviewer","name":"Pending reviewer","color":"c5def5","default":false}],"state":"open","locked":false,"assignee":{"login":"evanshultz","id":1936989,"node_id":"MDQ6VXNlcjE5MzY5ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/1936989?v=4","gravatar_id":"","url":"https://api.github.com/users/evanshultz","html_url":"https://github.com/evanshultz","followers_url":"https://api.github.com/users/evanshultz/followers","following_url":"https://api.github.com/users/evanshultz/following{/other_user}","gists_url":"https://api.github.com/users/evanshultz/gists{/gist_id}","starred_url":"https://api.github.com/users/evanshultz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanshultz/subscriptions","organizations_url":"https://api.github.com/users/evanshultz/orgs","repos_url":"https://api.github.com/users/evanshultz/repos","events_url":"https://api.github.com/users/evanshultz/events{/privacy}","received_events_url":"https://api.github.com/users/evanshultz/received_events","type":"User","site_admin":false},"assignees":[{"login":"evanshultz","id":1936989,"node_id":"MDQ6VXNlcjE5MzY5ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/1936989?v=4","gravatar_id":"","url":"https://api.github.com/users/evanshultz","html_url":"https://github.com/evanshultz","followers_url":"https://api.github.com/users/evanshultz/followers","following_url":"https://api.github.com/users/evanshultz/following{/other_user}","gists_url":"https://api.github.com/users/evanshultz/gists{/gist_id}","starred_url":"https://api.github.com/users/evanshultz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanshultz/subscriptions","organizations_url":"https://api.github.com/users/evanshultz/orgs","repos_url":"https://api.github.com/users/evanshultz/repos","events_url":"https://api.github.com/users/evanshultz/events{/privacy}","received_events_url":"https://api.github.com/users/evanshultz/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/KiCad/kicad-symbols/milestones/3","html_url":"https://github.com/KiCad/kicad-symbols/milestone/3","labels_url":"https://api.github.com/repos/KiCad/kicad-symbols/milestones/3/labels","id":3712977,"node_id":"MDk6TWlsZXN0b25lMzcxMjk3Nw==","number":3,"title":"Backlog","description":"Issues with no target to be released yet","creator":{"login":"antoniovazquezblanco","id":304193,"node_id":"MDQ6VXNlcjMwNDE5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/304193?v=4","gravatar_id":"","url":"https://api.github.com/users/antoniovazquezblanco","html_url":"https://github.com/antoniovazquezblanco","followers_url":"https://api.github.com/users/antoniovazquezblanco/followers","following_url":"https://api.github.com/users/antoniovazquezblanco/following{/other_user}","gists_url":"https://api.github.com/users/antoniovazquezblanco/gists{/gist_id}","starred_url":"https://api.github.com/users/antoniovazquezblanco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoniovazquezblanco/subscriptions","organizations_url":"https://api.github.com/users/antoniovazquezblanco/orgs","repos_url":"https://api.github.com/users/antoniovazquezblanco/repos","events_url":"https://api.github.com/users/antoniovazquezblanco/events{/privacy}","received_events_url":"https://api.github.com/users/antoniovazquezblanco/received_events","type":"User","site_admin":false},"open_issues":84,"closed_issues":16,"state":"open","created_at":"2018-10-04T18:04:11Z","updated_at":"2018-12-26T09:24:30Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2018-12-02T16:09:38Z","updated_at":"2018-12-26T17:07:21Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/KiCad/kicad-symbols/pulls/1197","html_url":"https://github.com/KiCad/kicad-symbols/pull/1197","diff_url":"https://github.com/KiCad/kicad-symbols/pull/1197.diff","patch_url":"https://github.com/KiCad/kicad-symbols/pull/1197.patch"},"body":"Creation of TI ADC ADS8688 and ADS8644.\r\n\r\nDatasheet : http://www.ti.com/lit/ds/symlink/ads8688.pdf\r\n\r\nScreenshot:\r\n\r\n![ads8688](https://user-images.githubusercontent.com/16516760/49341981-f4d3b100-f654-11e8-8d3f-6643ede01d75.PNG)\r\n\r\nNo error with checklib.py, using existing TSSOP38 footprint."},"comment":{"url":"https://api.github.com/repos/KiCad/kicad-symbols/issues/comments/449994829","html_url":"https://github.com/KiCad/kicad-symbols/pull/1197#issuecomment-449994829","issue_url":"https://api.github.com/repos/KiCad/kicad-symbols/issues/1197","id":449994829,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTk5NDgyOQ==","user":{"login":"myfreescalewebpage","id":16516760,"node_id":"MDQ6VXNlcjE2NTE2NzYw","avatar_url":"https://avatars3.githubusercontent.com/u/16516760?v=4","gravatar_id":"","url":"https://api.github.com/users/myfreescalewebpage","html_url":"https://github.com/myfreescalewebpage","followers_url":"https://api.github.com/users/myfreescalewebpage/followers","following_url":"https://api.github.com/users/myfreescalewebpage/following{/other_user}","gists_url":"https://api.github.com/users/myfreescalewebpage/gists{/gist_id}","starred_url":"https://api.github.com/users/myfreescalewebpage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myfreescalewebpage/subscriptions","organizations_url":"https://api.github.com/users/myfreescalewebpage/orgs","repos_url":"https://api.github.com/users/myfreescalewebpage/repos","events_url":"https://api.github.com/users/myfreescalewebpage/events{/privacy}","received_events_url":"https://api.github.com/users/myfreescalewebpage/received_events","type":"User","site_admin":false},"created_at":"2018-12-26T17:07:21Z","updated_at":"2018-12-26T17:07:21Z","author_association":"CONTRIBUTOR","body":"Comment by comment:\r\n\r\n> Since your symbols are individual, we need to make the datasheet description singular. Change ADCs with Bipolar Input Ranges to ADC with Bipolar Input Range.\r\n\r\nAgree. Was copy/paste from datasheet.\r\n\r\n> It might be nice to add , SPI Interface after that in the description, but you have spi in the keywords so it's not required.\r\n\r\nOK, no modification.\r\n\r\n> Add , TSSOP-38 to the end of the description.\r\n\r\nDone.\r\n\r\n> Use only Line style for the pins (no bubbles). Put an overbar on the letters instead.\r\n\r\nDone.\r\n\r\n> All pins should be 100mil long.\r\n\r\nDone.\r\n\r\n> I'd like to see SDO at the bottom of the SPI pins and DAISY at the top for easiest signal routing.\r\n\r\nAgree. New arrangement of the pins looking at datasheet page 35.\r\n\r\n> Maybe scoot pin 2 closer to the SPI pins since it will go the host. Same with pin 4.\r\n\r\nAgree. I keep an extra space because that's not the same block.\r\n\r\n> Pin 5 isn't logic so it doesn't matter what pin type it may be connected to, and it may only connect to a capacitor, thus we've used Passive in the past for this type of pin.\r\n\r\n> Pin 7 can be Passive type also.\r\n\r\nStill the same behavior and still my point of view, you can't do anything you want with this pin so it can't be Passive.\r\n\r\n> Pin 35 should be named DNC and push it in so the terminus is on the edge of the symbol body.\r\n\r\nAgree, done.\r\n\r\n> AGND pins 28, 29, and 32 can be stacked. I would argue that page 58 (and elsewhere) is clear enough to stack all AGND pins; the description giving pin numbers is actually just telling the user to keep the analog decoupling paths as ideal as possible.\r\n\r\nAgree for pins 8, 28, 29, 31, 32.\r\n\r\n> These 2 parts need unique symbols since the `84 version has NC pins for inputs 4-7.\r\n\r\nAgree, splitting in two devices.\r\n\r\nCheers,\r\nJoel\r\n\r\n"}}
{"actor":{"display_login":"myfreescalewebpage"}}