{"action":"created","comment":{"url":"https://api.github.com/repos/weaveworks/eksctl/pulls/comments/243871964","pull_request_review_id":187747417,"id":243871964,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mzg3MTk2NA==","diff_hunk":"@@ -23,6 +23,7 @@ func Command(g *cmdutils.Grouping) *cobra.Command {\n \t}\n \n \tcmd.AddCommand(deleteClusterCmd(g))\n+\tcmd.AddCommand(deleteNodeGroupCmd())","path":"pkg/ctl/delete/delete.go","position":null,"original_position":4,"commit_id":"44487d65fa0e94c398b100ad1219d4a4bdda94ef","original_commit_id":"867c73fe21b99307aff35d452f85524f6c2198d5","user":{"login":"mumoshu","id":22009,"node_id":"MDQ6VXNlcjIyMDA5","avatar_url":"https://avatars0.githubusercontent.com/u/22009?v=4","gravatar_id":"","url":"https://api.github.com/users/mumoshu","html_url":"https://github.com/mumoshu","followers_url":"https://api.github.com/users/mumoshu/followers","following_url":"https://api.github.com/users/mumoshu/following{/other_user}","gists_url":"https://api.github.com/users/mumoshu/gists{/gist_id}","starred_url":"https://api.github.com/users/mumoshu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mumoshu/subscriptions","organizations_url":"https://api.github.com/users/mumoshu/orgs","repos_url":"https://api.github.com/users/mumoshu/repos","events_url":"https://api.github.com/users/mumoshu/events{/privacy}","received_events_url":"https://api.github.com/users/mumoshu/received_events","type":"User","site_admin":false},"body":"Addressed in 2e0e02e 👍 ","created_at":"2018-12-25T03:52:52Z","updated_at":"2018-12-25T03:52:53Z","html_url":"https://github.com/weaveworks/eksctl/pull/369#discussion_r243871964","pull_request_url":"https://api.github.com/repos/weaveworks/eksctl/pulls/369","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/weaveworks/eksctl/pulls/comments/243871964"},"html":{"href":"https://github.com/weaveworks/eksctl/pull/369#discussion_r243871964"},"pull_request":{"href":"https://api.github.com/repos/weaveworks/eksctl/pulls/369"}},"in_reply_to_id":243823797},"pull_request":{"url":"https://api.github.com/repos/weaveworks/eksctl/pulls/369","id":240627433,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNjI3NDMz","html_url":"https://github.com/weaveworks/eksctl/pull/369","diff_url":"https://github.com/weaveworks/eksctl/pull/369.diff","patch_url":"https://github.com/weaveworks/eksctl/pull/369.patch","issue_url":"https://api.github.com/repos/weaveworks/eksctl/issues/369","number":369,"state":"open","locked":false,"title":"WIP: feat: Nodegroup as a resource","user":{"login":"mumoshu","id":22009,"node_id":"MDQ6VXNlcjIyMDA5","avatar_url":"https://avatars0.githubusercontent.com/u/22009?v=4","gravatar_id":"","url":"https://api.github.com/users/mumoshu","html_url":"https://github.com/mumoshu","followers_url":"https://api.github.com/users/mumoshu/followers","following_url":"https://api.github.com/users/mumoshu/following{/other_user}","gists_url":"https://api.github.com/users/mumoshu/gists{/gist_id}","starred_url":"https://api.github.com/users/mumoshu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mumoshu/subscriptions","organizations_url":"https://api.github.com/users/mumoshu/orgs","repos_url":"https://api.github.com/users/mumoshu/repos","events_url":"https://api.github.com/users/mumoshu/events{/privacy}","received_events_url":"https://api.github.com/users/mumoshu/received_events","type":"User","site_admin":false},"body":"`eksctl` now allows you to manage any number of nodegroups other than the initial nodegroup.\n\nChanges:\n\n- `eksctl create nodegroup --cluster CLUSTER_NAME [NODEGROUP_NAME]` is added\n\n  Creates an additional nodegroup.\n  The nodegroup name is randomly generated when omitted.\n\n- `eksctl get nodegroup --cluster CLUSTER_NAME` is added\n\n  Lists all the nodegroups including the initial one and the additional ones.\n\n- `eksctl delete nodegroup --cluster CLUSTER_NAME NODEGROUP_NAME` is added\n\n  Deletes a nodegroup by name.\n\n- `eksctl create cluster` has been changed to accept an optional `--nodegroup NODEGROUP_NAME` that specifies the nodegroup name.\n\n- `eksctl delete cluster CLUSTER_NAME` has been changed to recursively delete all the nodegroups including additional ones.\n\n- `eksctl scale nodegroup --cluster CLUSTER_NAME NODEGROUP_NAME` has been changed to accept the target nodegroup name as the second argument\n\nChecklist:\n\n- [x] Code compiles correctly (i.e `make build`)\n- [x] Added tests that cover your change (if possible)\n- [x] All tests passing (i.e. `make test`)\n- Added/modified documentation as required (such as the README)\n- Added yourself to the `humans.txt` file\n\nAcknowledgements:\n\nThis is a successor of #281 and #332.\n\nAll the original credits goes to Richard Case <richard.case@outlook.com> who has started #281. Thanks a lot, Richard!\n\nSigned-off-by: Yusuke Kuoka <ykuoka@gmail.com>","created_at":"2018-12-22T10:08:32Z","updated_at":"2018-12-25T03:52:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7e56dd5fcfada1f1da3c657cc977b197d0009ab","assignee":null,"assignees":[],"requested_reviewers":[{"login":"richardcase","id":198425,"node_id":"MDQ6VXNlcjE5ODQyNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/198425?v=4","gravatar_id":"","url":"https://api.github.com/users/richardcase","html_url":"https://github.com/richardcase","followers_url":"https://api.github.com/users/richardcase/followers","following_url":"https://api.github.com/users/richardcase/following{/other_user}","gists_url":"https://api.github.com/users/richardcase/gists{/gist_id}","starred_url":"https://api.github.com/users/richardcase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardcase/subscriptions","organizations_url":"https://api.github.com/users/richardcase/orgs","repos_url":"https://api.github.com/users/richardcase/repos","events_url":"https://api.github.com/users/richardcase/events{/privacy}","received_events_url":"https://api.github.com/users/richardcase/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/weaveworks/eksctl/pulls/369/commits","review_comments_url":"https://api.github.com/repos/weaveworks/eksctl/pulls/369/comments","review_comment_url":"https://api.github.com/repos/weaveworks/eksctl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/weaveworks/eksctl/issues/369/comments","statuses_url":"https://api.github.com/repos/weaveworks/eksctl/statuses/44487d65fa0e94c398b100ad1219d4a4bdda94ef","head":{"label":"mumoshu:nodegroup-as-resource","ref":"nodegroup-as-resource","sha":"44487d65fa0e94c398b100ad1219d4a4bdda94ef","user":{"login":"mumoshu","id":22009,"node_id":"MDQ6VXNlcjIyMDA5","avatar_url":"https://avatars0.githubusercontent.com/u/22009?v=4","gravatar_id":"","url":"https://api.github.com/users/mumoshu","html_url":"https://github.com/mumoshu","followers_url":"https://api.github.com/users/mumoshu/followers","following_url":"https://api.github.com/users/mumoshu/following{/other_user}","gists_url":"https://api.github.com/users/mumoshu/gists{/gist_id}","starred_url":"https://api.github.com/users/mumoshu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mumoshu/subscriptions","organizations_url":"https://api.github.com/users/mumoshu/orgs","repos_url":"https://api.github.com/users/mumoshu/repos","events_url":"https://api.github.com/users/mumoshu/events{/privacy}","received_events_url":"https://api.github.com/users/mumoshu/received_events","type":"User","site_admin":false},"repo":{"id":159755670,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk3NTU2NzA=","name":"eksctl","full_name":"mumoshu/eksctl","private":false,"owner":{"login":"mumoshu","id":22009,"node_id":"MDQ6VXNlcjIyMDA5","avatar_url":"https://avatars0.githubusercontent.com/u/22009?v=4","gravatar_id":"","url":"https://api.github.com/users/mumoshu","html_url":"https://github.com/mumoshu","followers_url":"https://api.github.com/users/mumoshu/followers","following_url":"https://api.github.com/users/mumoshu/following{/other_user}","gists_url":"https://api.github.com/users/mumoshu/gists{/gist_id}","starred_url":"https://api.github.com/users/mumoshu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mumoshu/subscriptions","organizations_url":"https://api.github.com/users/mumoshu/orgs","repos_url":"https://api.github.com/users/mumoshu/repos","events_url":"https://api.github.com/users/mumoshu/events{/privacy}","received_events_url":"https://api.github.com/users/mumoshu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mumoshu/eksctl","description":"a CLI for Amazon EKS","fork":true,"url":"https://api.github.com/repos/mumoshu/eksctl","forks_url":"https://api.github.com/repos/mumoshu/eksctl/forks","keys_url":"https://api.github.com/repos/mumoshu/eksctl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mumoshu/eksctl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mumoshu/eksctl/teams","hooks_url":"https://api.github.com/repos/mumoshu/eksctl/hooks","issue_events_url":"https://api.github.com/repos/mumoshu/eksctl/issues/events{/number}","events_url":"https://api.github.com/repos/mumoshu/eksctl/events","assignees_url":"https://api.github.com/repos/mumoshu/eksctl/assignees{/user}","branches_url":"https://api.github.com/repos/mumoshu/eksctl/branches{/branch}","tags_url":"https://api.github.com/repos/mumoshu/eksctl/tags","blobs_url":"https://api.github.com/repos/mumoshu/eksctl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mumoshu/eksctl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mumoshu/eksctl/git/refs{/sha}","trees_url":"https://api.github.com/repos/mumoshu/eksctl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mumoshu/eksctl/statuses/{sha}","languages_url":"https://api.github.com/repos/mumoshu/eksctl/languages","stargazers_url":"https://api.github.com/repos/mumoshu/eksctl/stargazers","contributors_url":"https://api.github.com/repos/mumoshu/eksctl/contributors","subscribers_url":"https://api.github.com/repos/mumoshu/eksctl/subscribers","subscription_url":"https://api.github.com/repos/mumoshu/eksctl/subscription","commits_url":"https://api.github.com/repos/mumoshu/eksctl/commits{/sha}","git_commits_url":"https://api.github.com/repos/mumoshu/eksctl/git/commits{/sha}","comments_url":"https://api.github.com/repos/mumoshu/eksctl/comments{/number}","issue_comment_url":"https://api.github.com/repos/mumoshu/eksctl/issues/comments{/number}","contents_url":"https://api.github.com/repos/mumoshu/eksctl/contents/{+path}","compare_url":"https://api.github.com/repos/mumoshu/eksctl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mumoshu/eksctl/merges","archive_url":"https://api.github.com/repos/mumoshu/eksctl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mumoshu/eksctl/downloads","issues_url":"https://api.github.com/repos/mumoshu/eksctl/issues{/number}","pulls_url":"https://api.github.com/repos/mumoshu/eksctl/pulls{/number}","milestones_url":"https://api.github.com/repos/mumoshu/eksctl/milestones{/number}","notifications_url":"https://api.github.com/repos/mumoshu/eksctl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mumoshu/eksctl/labels{/name}","releases_url":"https://api.github.com/repos/mumoshu/eksctl/releases{/id}","deployments_url":"https://api.github.com/repos/mumoshu/eksctl/deployments","created_at":"2018-11-30T02:16:02Z","updated_at":"2018-11-30T02:16:05Z","pushed_at":"2018-12-25T03:50:06Z","git_url":"git://github.com/mumoshu/eksctl.git","ssh_url":"git@github.com:mumoshu/eksctl.git","clone_url":"https://github.com/mumoshu/eksctl.git","svn_url":"https://github.com/mumoshu/eksctl","homepage":"https://eksctl.io","size":24322,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"weaveworks:master","ref":"master","sha":"e34a5ae380558094979399e32507a4fad60a80e3","user":{"login":"weaveworks","id":9976052,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NzYwNTI=","avatar_url":"https://avatars1.githubusercontent.com/u/9976052?v=4","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"repo":{"id":134539560,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ1Mzk1NjA=","name":"eksctl","full_name":"weaveworks/eksctl","private":false,"owner":{"login":"weaveworks","id":9976052,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NzYwNTI=","avatar_url":"https://avatars1.githubusercontent.com/u/9976052?v=4","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/weaveworks/eksctl","description":"a CLI for Amazon EKS","fork":false,"url":"https://api.github.com/repos/weaveworks/eksctl","forks_url":"https://api.github.com/repos/weaveworks/eksctl/forks","keys_url":"https://api.github.com/repos/weaveworks/eksctl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weaveworks/eksctl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weaveworks/eksctl/teams","hooks_url":"https://api.github.com/repos/weaveworks/eksctl/hooks","issue_events_url":"https://api.github.com/repos/weaveworks/eksctl/issues/events{/number}","events_url":"https://api.github.com/repos/weaveworks/eksctl/events","assignees_url":"https://api.github.com/repos/weaveworks/eksctl/assignees{/user}","branches_url":"https://api.github.com/repos/weaveworks/eksctl/branches{/branch}","tags_url":"https://api.github.com/repos/weaveworks/eksctl/tags","blobs_url":"https://api.github.com/repos/weaveworks/eksctl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weaveworks/eksctl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weaveworks/eksctl/git/refs{/sha}","trees_url":"https://api.github.com/repos/weaveworks/eksctl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weaveworks/eksctl/statuses/{sha}","languages_url":"https://api.github.com/repos/weaveworks/eksctl/languages","stargazers_url":"https://api.github.com/repos/weaveworks/eksctl/stargazers","contributors_url":"https://api.github.com/repos/weaveworks/eksctl/contributors","subscribers_url":"https://api.github.com/repos/weaveworks/eksctl/subscribers","subscription_url":"https://api.github.com/repos/weaveworks/eksctl/subscription","commits_url":"https://api.github.com/repos/weaveworks/eksctl/commits{/sha}","git_commits_url":"https://api.github.com/repos/weaveworks/eksctl/git/commits{/sha}","comments_url":"https://api.github.com/repos/weaveworks/eksctl/comments{/number}","issue_comment_url":"https://api.github.com/repos/weaveworks/eksctl/issues/comments{/number}","contents_url":"https://api.github.com/repos/weaveworks/eksctl/contents/{+path}","compare_url":"https://api.github.com/repos/weaveworks/eksctl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weaveworks/eksctl/merges","archive_url":"https://api.github.com/repos/weaveworks/eksctl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weaveworks/eksctl/downloads","issues_url":"https://api.github.com/repos/weaveworks/eksctl/issues{/number}","pulls_url":"https://api.github.com/repos/weaveworks/eksctl/pulls{/number}","milestones_url":"https://api.github.com/repos/weaveworks/eksctl/milestones{/number}","notifications_url":"https://api.github.com/repos/weaveworks/eksctl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weaveworks/eksctl/labels{/name}","releases_url":"https://api.github.com/repos/weaveworks/eksctl/releases{/id}","deployments_url":"https://api.github.com/repos/weaveworks/eksctl/deployments","created_at":"2018-05-23T08:41:03Z","updated_at":"2018-12-24T13:58:07Z","pushed_at":"2018-12-25T03:50:08Z","git_url":"git://github.com/weaveworks/eksctl.git","ssh_url":"git@github.com:weaveworks/eksctl.git","clone_url":"https://github.com/weaveworks/eksctl.git","svn_url":"https://github.com/weaveworks/eksctl","homepage":"https://eksctl.io","size":24247,"stargazers_count":739,"watchers_count":739,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":111,"mirror_url":null,"archived":false,"open_issues_count":90,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":111,"open_issues":90,"watchers":739,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/weaveworks/eksctl/pulls/369"},"html":{"href":"https://github.com/weaveworks/eksctl/pull/369"},"issue":{"href":"https://api.github.com/repos/weaveworks/eksctl/issues/369"},"comments":{"href":"https://api.github.com/repos/weaveworks/eksctl/issues/369/comments"},"review_comments":{"href":"https://api.github.com/repos/weaveworks/eksctl/pulls/369/comments"},"review_comment":{"href":"https://api.github.com/repos/weaveworks/eksctl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/weaveworks/eksctl/pulls/369/commits"},"statuses":{"href":"https://api.github.com/repos/weaveworks/eksctl/statuses/44487d65fa0e94c398b100ad1219d4a4bdda94ef"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mumoshu"}}