{"action":"closed","number":207,"pull_request":{"url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/pulls/207","id":218162084,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MTYyMDg0","html_url":"https://github.com/bitcoin-s/bitcoin-s-core/pull/207","diff_url":"https://github.com/bitcoin-s/bitcoin-s-core/pull/207.diff","patch_url":"https://github.com/bitcoin-s/bitcoin-s-core/pull/207.patch","issue_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/issues/207","number":207,"state":"closed","locked":false,"title":"implement p2sh(p2wpkh) inside of the interpreter and TxBuilder","user":{"login":"Christewart","id":3514957,"node_id":"MDQ6VXNlcjM1MTQ5NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/3514957?v=4","gravatar_id":"","url":"https://api.github.com/users/Christewart","html_url":"https://github.com/Christewart","followers_url":"https://api.github.com/users/Christewart/followers","following_url":"https://api.github.com/users/Christewart/following{/other_user}","gists_url":"https://api.github.com/users/Christewart/gists{/gist_id}","starred_url":"https://api.github.com/users/Christewart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Christewart/subscriptions","organizations_url":"https://api.github.com/users/Christewart/orgs","repos_url":"https://api.github.com/users/Christewart/repos","events_url":"https://api.github.com/users/Christewart/events{/privacy}","received_events_url":"https://api.github.com/users/Christewart/received_events","type":"User","site_admin":false},"body":"fix bug in P2SHScriptSignature.redeemScript\r\n\r\nThis pull request implements the P2SH(P2WPKH) script type in bitcoin-s. \r\n\r\nThis script type has unique semantics inside of the interpreter and in BIP143. You are required to reconstruct a full `P2PKHScriptPubKey` from the `P2WPKHWitnessSPKV0`\r\n\r\nThis adds the test vector for [BIP143](https://github.com/bitcoin/bips/blob/master/bip-0143.mediawiki#P2SHP2WPKH) to TransactionSignatureSerializerTest to make sure we are following the BIP correctly. \r\n\r\nThis PR also adds the generator for a P2SH(P2WPKH) tx to make sure we are adding this transaction type too our property based testing suite. ","created_at":"2018-09-26T01:10:59Z","updated_at":"2018-10-01T14:00:45Z","closed_at":"2018-10-01T14:00:45Z","merged_at":"2018-10-01T14:00:45Z","merge_commit_sha":"b211d3408df2cd2e5222e79a73ed6589c6ab8340","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/pulls/207/commits","review_comments_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/pulls/207/comments","review_comment_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/issues/207/comments","statuses_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/statuses/23c7504c82c5d49ece0ae1e15cb0e1eca0beec8a","head":{"label":"Christewart:p2sh_p2wpkh","ref":"p2sh_p2wpkh","sha":"23c7504c82c5d49ece0ae1e15cb0e1eca0beec8a","user":{"login":"Christewart","id":3514957,"node_id":"MDQ6VXNlcjM1MTQ5NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/3514957?v=4","gravatar_id":"","url":"https://api.github.com/users/Christewart","html_url":"https://github.com/Christewart","followers_url":"https://api.github.com/users/Christewart/followers","following_url":"https://api.github.com/users/Christewart/following{/other_user}","gists_url":"https://api.github.com/users/Christewart/gists{/gist_id}","starred_url":"https://api.github.com/users/Christewart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Christewart/subscriptions","organizations_url":"https://api.github.com/users/Christewart/orgs","repos_url":"https://api.github.com/users/Christewart/repos","events_url":"https://api.github.com/users/Christewart/events{/privacy}","received_events_url":"https://api.github.com/users/Christewart/received_events","type":"User","site_admin":false},"repo":{"id":57395068,"node_id":"MDEwOlJlcG9zaXRvcnk1NzM5NTA2OA==","name":"bitcoin-s-core","full_name":"Christewart/bitcoin-s-core","private":false,"owner":{"login":"Christewart","id":3514957,"node_id":"MDQ6VXNlcjM1MTQ5NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/3514957?v=4","gravatar_id":"","url":"https://api.github.com/users/Christewart","html_url":"https://github.com/Christewart","followers_url":"https://api.github.com/users/Christewart/followers","following_url":"https://api.github.com/users/Christewart/following{/other_user}","gists_url":"https://api.github.com/users/Christewart/gists{/gist_id}","starred_url":"https://api.github.com/users/Christewart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Christewart/subscriptions","organizations_url":"https://api.github.com/users/Christewart/orgs","repos_url":"https://api.github.com/users/Christewart/repos","events_url":"https://api.github.com/users/Christewart/events{/privacy}","received_events_url":"https://api.github.com/users/Christewart/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Christewart/bitcoin-s-core","description":"Bitcoin Implementation in Scala (core module)","fork":true,"url":"https://api.github.com/repos/Christewart/bitcoin-s-core","forks_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/forks","keys_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/teams","hooks_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/hooks","issue_events_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/issues/events{/number}","events_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/events","assignees_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/assignees{/user}","branches_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/branches{/branch}","tags_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/tags","blobs_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/languages","stargazers_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/stargazers","contributors_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/contributors","subscribers_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/subscribers","subscription_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/subscription","commits_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/contents/{+path}","compare_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/merges","archive_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/downloads","issues_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/issues{/number}","pulls_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/labels{/name}","releases_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/releases{/id}","deployments_url":"https://api.github.com/repos/Christewart/bitcoin-s-core/deployments","created_at":"2016-04-29T15:36:40Z","updated_at":"2018-03-28T15:23:22Z","pushed_at":"2018-09-28T00:42:08Z","git_url":"git://github.com/Christewart/bitcoin-s-core.git","ssh_url":"git@github.com:Christewart/bitcoin-s-core.git","clone_url":"https://github.com/Christewart/bitcoin-s-core.git","svn_url":"https://github.com/Christewart/bitcoin-s-core","homepage":null,"size":7283,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin-s:master","ref":"master","sha":"b3384c1f186fb213ae7e4534cbf6619d3bb6c95e","user":{"login":"bitcoin-s","id":16688471,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Njg4NDcx","avatar_url":"https://avatars1.githubusercontent.com/u/16688471?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin-s","html_url":"https://github.com/bitcoin-s","followers_url":"https://api.github.com/users/bitcoin-s/followers","following_url":"https://api.github.com/users/bitcoin-s/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin-s/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin-s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin-s/subscriptions","organizations_url":"https://api.github.com/users/bitcoin-s/orgs","repos_url":"https://api.github.com/users/bitcoin-s/repos","events_url":"https://api.github.com/users/bitcoin-s/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin-s/received_events","type":"Organization","site_admin":false},"repo":{"id":57332261,"node_id":"MDEwOlJlcG9zaXRvcnk1NzMzMjI2MQ==","name":"bitcoin-s-core","full_name":"bitcoin-s/bitcoin-s-core","private":false,"owner":{"login":"bitcoin-s","id":16688471,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Njg4NDcx","avatar_url":"https://avatars1.githubusercontent.com/u/16688471?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin-s","html_url":"https://github.com/bitcoin-s","followers_url":"https://api.github.com/users/bitcoin-s/followers","following_url":"https://api.github.com/users/bitcoin-s/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin-s/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin-s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin-s/subscriptions","organizations_url":"https://api.github.com/users/bitcoin-s/orgs","repos_url":"https://api.github.com/users/bitcoin-s/repos","events_url":"https://api.github.com/users/bitcoin-s/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin-s/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bitcoin-s/bitcoin-s-core","description":"Bitcoin Implementation in Scala (core module)","fork":false,"url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core","forks_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/forks","keys_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/teams","hooks_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/hooks","issue_events_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/events","assignees_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/tags","blobs_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/languages","stargazers_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/stargazers","contributors_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/contributors","subscribers_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/subscribers","subscription_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/subscription","commits_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/merges","archive_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/downloads","issues_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/deployments","created_at":"2016-04-28T20:38:56Z","updated_at":"2018-09-28T11:45:41Z","pushed_at":"2018-10-01T14:00:45Z","git_url":"git://github.com/bitcoin-s/bitcoin-s-core.git","ssh_url":"git@github.com:bitcoin-s/bitcoin-s-core.git","clone_url":"https://github.com/bitcoin-s/bitcoin-s-core.git","svn_url":"https://github.com/bitcoin-s/bitcoin-s-core","homepage":null,"size":6071,"stargazers_count":116,"watchers_count":116,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":29,"open_issues":32,"watchers":116,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/pulls/207"},"html":{"href":"https://github.com/bitcoin-s/bitcoin-s-core/pull/207"},"issue":{"href":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/issues/207"},"comments":{"href":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/issues/207/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/pulls/207/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/pulls/207/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/statuses/23c7504c82c5d49ece0ae1e15cb0e1eca0beec8a"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Christewart","id":3514957,"node_id":"MDQ6VXNlcjM1MTQ5NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/3514957?v=4","gravatar_id":"","url":"https://api.github.com/users/Christewart","html_url":"https://github.com/Christewart","followers_url":"https://api.github.com/users/Christewart/followers","following_url":"https://api.github.com/users/Christewart/following{/other_user}","gists_url":"https://api.github.com/users/Christewart/gists{/gist_id}","starred_url":"https://api.github.com/users/Christewart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Christewart/subscriptions","organizations_url":"https://api.github.com/users/Christewart/orgs","repos_url":"https://api.github.com/users/Christewart/repos","events_url":"https://api.github.com/users/Christewart/events{/privacy}","received_events_url":"https://api.github.com/users/Christewart/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":655,"deletions":110,"changed_files":22}}
{"actor":{"display_login":"Christewart"}}