{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/53434","repository_url":"https://api.github.com/repos/rust-lang/rust","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/53434/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/53434/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/53434/events","html_url":"https://github.com/rust-lang/rust/pull/53434","id":351296028,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4OTI4NDA0","number":53434,"title":"wasm: Remove --strip-debug argument to LLD","user":{"login":"alexcrichton","id":64996,"node_id":"MDQ6VXNlcjY0OTk2","avatar_url":"https://avatars1.githubusercontent.com/u/64996?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"labels":[{"id":583437191,"node_id":"MDU6TGFiZWw1ODM0MzcxOTE=","url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-bors","name":"S-waiting-on-bors","color":"d3dddd","default":false}],"state":"closed","locked":false,"assignee":{"login":"aturon","id":709807,"node_id":"MDQ6VXNlcjcwOTgwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/709807?v=4","gravatar_id":"","url":"https://api.github.com/users/aturon","html_url":"https://github.com/aturon","followers_url":"https://api.github.com/users/aturon/followers","following_url":"https://api.github.com/users/aturon/following{/other_user}","gists_url":"https://api.github.com/users/aturon/gists{/gist_id}","starred_url":"https://api.github.com/users/aturon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aturon/subscriptions","organizations_url":"https://api.github.com/users/aturon/orgs","repos_url":"https://api.github.com/users/aturon/repos","events_url":"https://api.github.com/users/aturon/events{/privacy}","received_events_url":"https://api.github.com/users/aturon/received_events","type":"User","site_admin":false},"assignees":[{"login":"aturon","id":709807,"node_id":"MDQ6VXNlcjcwOTgwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/709807?v=4","gravatar_id":"","url":"https://api.github.com/users/aturon","html_url":"https://github.com/aturon","followers_url":"https://api.github.com/users/aturon/followers","following_url":"https://api.github.com/users/aturon/following{/other_user}","gists_url":"https://api.github.com/users/aturon/gists{/gist_id}","starred_url":"https://api.github.com/users/aturon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aturon/subscriptions","organizations_url":"https://api.github.com/users/aturon/orgs","repos_url":"https://api.github.com/users/aturon/repos","events_url":"https://api.github.com/users/aturon/events{/privacy}","received_events_url":"https://api.github.com/users/aturon/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2018-08-16T17:19:55Z","updated_at":"2018-08-29T13:29:03Z","closed_at":"2018-08-17T19:10:56Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/53434","html_url":"https://github.com/rust-lang/rust/pull/53434","diff_url":"https://github.com/rust-lang/rust/pull/53434.diff","patch_url":"https://github.com/rust-lang/rust/pull/53434.patch"},"body":"Originally added in #52887 this commit disables passing `--strip-debug` to LLD\r\nwhen optimized. This bring back the original bug of emitting broken debuginfo\r\nbut currently it *also* strips the `name` section which makes it very difficult\r\nto inspect the final binary. A real fix is happening at\r\nhttps://reviews.llvm.org/D50729 and we can reevaluate once we've updated LLD to\r\nhave that commit."},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/416953463","html_url":"https://github.com/rust-lang/rust/pull/53434#issuecomment-416953463","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/53434","id":416953463,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjk1MzQ2Mw==","user":{"login":"Hywan","id":946104,"node_id":"MDQ6VXNlcjk0NjEwNA==","avatar_url":"https://avatars2.githubusercontent.com/u/946104?v=4","gravatar_id":"","url":"https://api.github.com/users/Hywan","html_url":"https://github.com/Hywan","followers_url":"https://api.github.com/users/Hywan/followers","following_url":"https://api.github.com/users/Hywan/following{/other_user}","gists_url":"https://api.github.com/users/Hywan/gists{/gist_id}","starred_url":"https://api.github.com/users/Hywan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hywan/subscriptions","organizations_url":"https://api.github.com/users/Hywan/orgs","repos_url":"https://api.github.com/users/Hywan/repos","events_url":"https://api.github.com/users/Hywan/events{/privacy}","received_events_url":"https://api.github.com/users/Hywan/received_events","type":"User","site_admin":false},"created_at":"2018-08-29T13:29:03Z","updated_at":"2018-08-29T13:29:03Z","author_association":"CONTRIBUTOR","body":":+1:"}}
{"actor":{"display_login":"Hywan"}}