{"action":"created","comment":{"url":"https://api.github.com/repos/angular/material2/pulls/comments/185260878","pull_request_review_id":116613452,"id":185260878,"diff_hunk":"@@ -147,8 +147,15 @@ export class CdkVirtualForOf<T> implements CollectionViewer, DoCheck, OnDestroy\n       private _differs: IterableDiffers,\n       /** The virtual scrolling viewport that these items are being rendered in. */\n       @SkipSelf() private _viewport: CdkVirtualScrollViewport) {\n-    this.dataStream.subscribe(data => this._data = data);\n-    this._viewport.renderedRangeStream.subscribe(range => this._onRenderedRangeChange(range));\n+    this.dataStream.subscribe(data => {\n+      this._data = data;","path":"src/cdk-experimental/scrolling/virtual-for-of.ts","position":7,"original_position":7,"commit_id":"d70863b267e7e41d8871caa90863d8376a501ce7","original_commit_id":"d70863b267e7e41d8871caa90863d8376a501ce7","user":{"login":"jelbourn","id":838736,"avatar_url":"https://avatars3.githubusercontent.com/u/838736?v=4","gravatar_id":"","url":"https://api.github.com/users/jelbourn","html_url":"https://github.com/jelbourn","followers_url":"https://api.github.com/users/jelbourn/followers","following_url":"https://api.github.com/users/jelbourn/following{/other_user}","gists_url":"https://api.github.com/users/jelbourn/gists{/gist_id}","starred_url":"https://api.github.com/users/jelbourn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelbourn/subscriptions","organizations_url":"https://api.github.com/users/jelbourn/orgs","repos_url":"https://api.github.com/users/jelbourn/repos","events_url":"https://api.github.com/users/jelbourn/events{/privacy}","received_events_url":"https://api.github.com/users/jelbourn/received_events","type":"User","site_admin":false},"body":"Ben's advice is that if you're creating a `BehaviorSubject`, there's probably a better way. In this case, wouldn't you want to `combineLatest`?","created_at":"2018-05-01T16:13:50Z","updated_at":"2018-05-01T16:13:50Z","html_url":"https://github.com/angular/material2/pull/11085#discussion_r185260878","pull_request_url":"https://api.github.com/repos/angular/material2/pulls/11085","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/angular/material2/pulls/comments/185260878"},"html":{"href":"https://github.com/angular/material2/pull/11085#discussion_r185260878"},"pull_request":{"href":"https://api.github.com/repos/angular/material2/pulls/11085"}},"in_reply_to_id":185246857},"pull_request":{"url":"https://api.github.com/repos/angular/material2/pulls/11085","id":185089502,"html_url":"https://github.com/angular/material2/pull/11085","diff_url":"https://github.com/angular/material2/pull/11085.diff","patch_url":"https://github.com/angular/material2/pull/11085.patch","issue_url":"https://api.github.com/repos/angular/material2/issues/11085","number":11085,"state":"open","locked":false,"title":"virtual-scroll: fix updating when data changes and add trackBy demos","user":{"login":"mmalerba","id":14793288,"avatar_url":"https://avatars1.githubusercontent.com/u/14793288?v=4","gravatar_id":"","url":"https://api.github.com/users/mmalerba","html_url":"https://github.com/mmalerba","followers_url":"https://api.github.com/users/mmalerba/followers","following_url":"https://api.github.com/users/mmalerba/following{/other_user}","gists_url":"https://api.github.com/users/mmalerba/gists{/gist_id}","starred_url":"https://api.github.com/users/mmalerba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmalerba/subscriptions","organizations_url":"https://api.github.com/users/mmalerba/orgs","repos_url":"https://api.github.com/users/mmalerba/repos","events_url":"https://api.github.com/users/mmalerba/events{/privacy}","received_events_url":"https://api.github.com/users/mmalerba/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-30T23:24:21Z","updated_at":"2018-05-01T16:13:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ebe8f61796de1a9088e8fccef23ab5e96fe36434","assignee":{"login":"amcdnl","id":227909,"avatar_url":"https://avatars3.githubusercontent.com/u/227909?v=4","gravatar_id":"","url":"https://api.github.com/users/amcdnl","html_url":"https://github.com/amcdnl","followers_url":"https://api.github.com/users/amcdnl/followers","following_url":"https://api.github.com/users/amcdnl/following{/other_user}","gists_url":"https://api.github.com/users/amcdnl/gists{/gist_id}","starred_url":"https://api.github.com/users/amcdnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amcdnl/subscriptions","organizations_url":"https://api.github.com/users/amcdnl/orgs","repos_url":"https://api.github.com/users/amcdnl/repos","events_url":"https://api.github.com/users/amcdnl/events{/privacy}","received_events_url":"https://api.github.com/users/amcdnl/received_events","type":"User","site_admin":false},"assignees":[{"login":"amcdnl","id":227909,"avatar_url":"https://avatars3.githubusercontent.com/u/227909?v=4","gravatar_id":"","url":"https://api.github.com/users/amcdnl","html_url":"https://github.com/amcdnl","followers_url":"https://api.github.com/users/amcdnl/followers","following_url":"https://api.github.com/users/amcdnl/following{/other_user}","gists_url":"https://api.github.com/users/amcdnl/gists{/gist_id}","starred_url":"https://api.github.com/users/amcdnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amcdnl/subscriptions","organizations_url":"https://api.github.com/users/amcdnl/orgs","repos_url":"https://api.github.com/users/amcdnl/repos","events_url":"https://api.github.com/users/amcdnl/events{/privacy}","received_events_url":"https://api.github.com/users/amcdnl/received_events","type":"User","site_admin":false},{"login":"jelbourn","id":838736,"avatar_url":"https://avatars3.githubusercontent.com/u/838736?v=4","gravatar_id":"","url":"https://api.github.com/users/jelbourn","html_url":"https://github.com/jelbourn","followers_url":"https://api.github.com/users/jelbourn/followers","following_url":"https://api.github.com/users/jelbourn/following{/other_user}","gists_url":"https://api.github.com/users/jelbourn/gists{/gist_id}","starred_url":"https://api.github.com/users/jelbourn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelbourn/subscriptions","organizations_url":"https://api.github.com/users/jelbourn/orgs","repos_url":"https://api.github.com/users/jelbourn/repos","events_url":"https://api.github.com/users/jelbourn/events{/privacy}","received_events_url":"https://api.github.com/users/jelbourn/received_events","type":"User","site_admin":false},{"login":"crisbeto","id":4450522,"avatar_url":"https://avatars0.githubusercontent.com/u/4450522?v=4","gravatar_id":"","url":"https://api.github.com/users/crisbeto","html_url":"https://github.com/crisbeto","followers_url":"https://api.github.com/users/crisbeto/followers","following_url":"https://api.github.com/users/crisbeto/following{/other_user}","gists_url":"https://api.github.com/users/crisbeto/gists{/gist_id}","starred_url":"https://api.github.com/users/crisbeto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crisbeto/subscriptions","organizations_url":"https://api.github.com/users/crisbeto/orgs","repos_url":"https://api.github.com/users/crisbeto/repos","events_url":"https://api.github.com/users/crisbeto/events{/privacy}","received_events_url":"https://api.github.com/users/crisbeto/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"amcdnl","id":227909,"avatar_url":"https://avatars3.githubusercontent.com/u/227909?v=4","gravatar_id":"","url":"https://api.github.com/users/amcdnl","html_url":"https://github.com/amcdnl","followers_url":"https://api.github.com/users/amcdnl/followers","following_url":"https://api.github.com/users/amcdnl/following{/other_user}","gists_url":"https://api.github.com/users/amcdnl/gists{/gist_id}","starred_url":"https://api.github.com/users/amcdnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amcdnl/subscriptions","organizations_url":"https://api.github.com/users/amcdnl/orgs","repos_url":"https://api.github.com/users/amcdnl/repos","events_url":"https://api.github.com/users/amcdnl/events{/privacy}","received_events_url":"https://api.github.com/users/amcdnl/received_events","type":"User","site_admin":false},{"login":"jelbourn","id":838736,"avatar_url":"https://avatars3.githubusercontent.com/u/838736?v=4","gravatar_id":"","url":"https://api.github.com/users/jelbourn","html_url":"https://github.com/jelbourn","followers_url":"https://api.github.com/users/jelbourn/followers","following_url":"https://api.github.com/users/jelbourn/following{/other_user}","gists_url":"https://api.github.com/users/jelbourn/gists{/gist_id}","starred_url":"https://api.github.com/users/jelbourn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelbourn/subscriptions","organizations_url":"https://api.github.com/users/jelbourn/orgs","repos_url":"https://api.github.com/users/jelbourn/repos","events_url":"https://api.github.com/users/jelbourn/events{/privacy}","received_events_url":"https://api.github.com/users/jelbourn/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":308798701,"url":"https://api.github.com/repos/angular/material2/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":311422524,"url":"https://api.github.com/repos/angular/material2/labels/pr:%20needs%20review","name":"pr: needs review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/material2/pulls/11085/commits","review_comments_url":"https://api.github.com/repos/angular/material2/pulls/11085/comments","review_comment_url":"https://api.github.com/repos/angular/material2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/material2/issues/11085/comments","statuses_url":"https://api.github.com/repos/angular/material2/statuses/d70863b267e7e41d8871caa90863d8376a501ce7","head":{"label":"mmalerba:vs2","ref":"vs2","sha":"d70863b267e7e41d8871caa90863d8376a501ce7","user":{"login":"mmalerba","id":14793288,"avatar_url":"https://avatars1.githubusercontent.com/u/14793288?v=4","gravatar_id":"","url":"https://api.github.com/users/mmalerba","html_url":"https://github.com/mmalerba","followers_url":"https://api.github.com/users/mmalerba/followers","following_url":"https://api.github.com/users/mmalerba/following{/other_user}","gists_url":"https://api.github.com/users/mmalerba/gists{/gist_id}","starred_url":"https://api.github.com/users/mmalerba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmalerba/subscriptions","organizations_url":"https://api.github.com/users/mmalerba/orgs","repos_url":"https://api.github.com/users/mmalerba/repos","events_url":"https://api.github.com/users/mmalerba/events{/privacy}","received_events_url":"https://api.github.com/users/mmalerba/received_events","type":"User","site_admin":false},"repo":{"id":71814136,"name":"material2","full_name":"mmalerba/material2","owner":{"login":"mmalerba","id":14793288,"avatar_url":"https://avatars1.githubusercontent.com/u/14793288?v=4","gravatar_id":"","url":"https://api.github.com/users/mmalerba","html_url":"https://github.com/mmalerba","followers_url":"https://api.github.com/users/mmalerba/followers","following_url":"https://api.github.com/users/mmalerba/following{/other_user}","gists_url":"https://api.github.com/users/mmalerba/gists{/gist_id}","starred_url":"https://api.github.com/users/mmalerba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmalerba/subscriptions","organizations_url":"https://api.github.com/users/mmalerba/orgs","repos_url":"https://api.github.com/users/mmalerba/repos","events_url":"https://api.github.com/users/mmalerba/events{/privacy}","received_events_url":"https://api.github.com/users/mmalerba/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmalerba/material2","description":"Material Design components for Angular 2","fork":true,"url":"https://api.github.com/repos/mmalerba/material2","forks_url":"https://api.github.com/repos/mmalerba/material2/forks","keys_url":"https://api.github.com/repos/mmalerba/material2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmalerba/material2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmalerba/material2/teams","hooks_url":"https://api.github.com/repos/mmalerba/material2/hooks","issue_events_url":"https://api.github.com/repos/mmalerba/material2/issues/events{/number}","events_url":"https://api.github.com/repos/mmalerba/material2/events","assignees_url":"https://api.github.com/repos/mmalerba/material2/assignees{/user}","branches_url":"https://api.github.com/repos/mmalerba/material2/branches{/branch}","tags_url":"https://api.github.com/repos/mmalerba/material2/tags","blobs_url":"https://api.github.com/repos/mmalerba/material2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmalerba/material2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmalerba/material2/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmalerba/material2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmalerba/material2/statuses/{sha}","languages_url":"https://api.github.com/repos/mmalerba/material2/languages","stargazers_url":"https://api.github.com/repos/mmalerba/material2/stargazers","contributors_url":"https://api.github.com/repos/mmalerba/material2/contributors","subscribers_url":"https://api.github.com/repos/mmalerba/material2/subscribers","subscription_url":"https://api.github.com/repos/mmalerba/material2/subscription","commits_url":"https://api.github.com/repos/mmalerba/material2/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmalerba/material2/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmalerba/material2/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmalerba/material2/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmalerba/material2/contents/{+path}","compare_url":"https://api.github.com/repos/mmalerba/material2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmalerba/material2/merges","archive_url":"https://api.github.com/repos/mmalerba/material2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmalerba/material2/downloads","issues_url":"https://api.github.com/repos/mmalerba/material2/issues{/number}","pulls_url":"https://api.github.com/repos/mmalerba/material2/pulls{/number}","milestones_url":"https://api.github.com/repos/mmalerba/material2/milestones{/number}","notifications_url":"https://api.github.com/repos/mmalerba/material2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmalerba/material2/labels{/name}","releases_url":"https://api.github.com/repos/mmalerba/material2/releases{/id}","deployments_url":"https://api.github.com/repos/mmalerba/material2/deployments","created_at":"2016-10-24T17:31:40Z","updated_at":"2016-10-24T17:31:42Z","pushed_at":"2018-05-01T16:09:55Z","git_url":"git://github.com/mmalerba/material2.git","ssh_url":"git@github.com:mmalerba/material2.git","clone_url":"https://github.com/mmalerba/material2.git","svn_url":"https://github.com/mmalerba/material2","homepage":"https://material.angular.io/","size":15098,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:virtual-scroll","ref":"virtual-scroll","sha":"285fe6c338660973a30132a82babcd734cd4653c","user":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":49016322,"name":"material2","full_name":"angular/material2","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/material2","description":"Material Design components for Angular","fork":false,"url":"https://api.github.com/repos/angular/material2","forks_url":"https://api.github.com/repos/angular/material2/forks","keys_url":"https://api.github.com/repos/angular/material2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/material2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/material2/teams","hooks_url":"https://api.github.com/repos/angular/material2/hooks","issue_events_url":"https://api.github.com/repos/angular/material2/issues/events{/number}","events_url":"https://api.github.com/repos/angular/material2/events","assignees_url":"https://api.github.com/repos/angular/material2/assignees{/user}","branches_url":"https://api.github.com/repos/angular/material2/branches{/branch}","tags_url":"https://api.github.com/repos/angular/material2/tags","blobs_url":"https://api.github.com/repos/angular/material2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/material2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/material2/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/material2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/material2/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/material2/languages","stargazers_url":"https://api.github.com/repos/angular/material2/stargazers","contributors_url":"https://api.github.com/repos/angular/material2/contributors","subscribers_url":"https://api.github.com/repos/angular/material2/subscribers","subscription_url":"https://api.github.com/repos/angular/material2/subscription","commits_url":"https://api.github.com/repos/angular/material2/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/material2/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/material2/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/material2/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/material2/contents/{+path}","compare_url":"https://api.github.com/repos/angular/material2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/material2/merges","archive_url":"https://api.github.com/repos/angular/material2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/material2/downloads","issues_url":"https://api.github.com/repos/angular/material2/issues{/number}","pulls_url":"https://api.github.com/repos/angular/material2/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/material2/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/material2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/material2/labels{/name}","releases_url":"https://api.github.com/repos/angular/material2/releases{/id}","deployments_url":"https://api.github.com/repos/angular/material2/deployments","created_at":"2016-01-04T18:50:02Z","updated_at":"2018-05-01T15:11:40Z","pushed_at":"2018-05-01T16:13:47Z","git_url":"git://github.com/angular/material2.git","ssh_url":"git@github.com:angular/material2.git","clone_url":"https://github.com/angular/material2.git","svn_url":"https://github.com/angular/material2","homepage":"https://material.angular.io","size":15138,"stargazers_count":14114,"watchers_count":14114,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3488,"mirror_url":null,"archived":false,"open_issues_count":957,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3488,"open_issues":957,"watchers":14114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/material2/pulls/11085"},"html":{"href":"https://github.com/angular/material2/pull/11085"},"issue":{"href":"https://api.github.com/repos/angular/material2/issues/11085"},"comments":{"href":"https://api.github.com/repos/angular/material2/issues/11085/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/material2/pulls/11085/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/material2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/material2/pulls/11085/commits"},"statuses":{"href":"https://api.github.com/repos/angular/material2/statuses/d70863b267e7e41d8871caa90863d8376a501ce7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jelbourn"}}