{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible/issues/36252","repository_url":"https://api.github.com/repos/ansible/ansible","labels_url":"https://api.github.com/repos/ansible/ansible/issues/36252/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/36252/comments","events_url":"https://api.github.com/repos/ansible/ansible/issues/36252/events","html_url":"https://github.com/ansible/ansible/pull/36252","id":297542877,"number":36252,"title":"aws_ssm_parameter_store - Make the module idempotent","user":{"login":"nathanwebsterdotme","id":14338821,"avatar_url":"https://avatars2.githubusercontent.com/u/14338821?v=4","gravatar_id":"","url":"https://api.github.com/users/nathanwebsterdotme","html_url":"https://github.com/nathanwebsterdotme","followers_url":"https://api.github.com/users/nathanwebsterdotme/followers","following_url":"https://api.github.com/users/nathanwebsterdotme/following{/other_user}","gists_url":"https://api.github.com/users/nathanwebsterdotme/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanwebsterdotme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanwebsterdotme/subscriptions","organizations_url":"https://api.github.com/users/nathanwebsterdotme/orgs","repos_url":"https://api.github.com/users/nathanwebsterdotme/repos","events_url":"https://api.github.com/users/nathanwebsterdotme/events{/privacy}","received_events_url":"https://api.github.com/users/nathanwebsterdotme/received_events","type":"User","site_admin":false},"labels":[{"id":379680333,"url":"https://api.github.com/repos/ansible/ansible/labels/aws","name":"aws","color":"c5def5","default":false},{"id":785271699,"url":"https://api.github.com/repos/ansible/ansible/labels/bug","name":"bug","color":"fbca04","default":true},{"id":61528803,"url":"https://api.github.com/repos/ansible/ansible/labels/cloud","name":"cloud","color":"c7def8","default":false},{"id":501518759,"url":"https://api.github.com/repos/ansible/ansible/labels/community_review","name":"community_review","color":"f9d0c4","default":false},{"id":496359346,"url":"https://api.github.com/repos/ansible/ansible/labels/module","name":"module","color":"1d76db","default":false},{"id":723150340,"url":"https://api.github.com/repos/ansible/ansible/labels/new_contributor","name":"new_contributor","color":"ededed","default":false},{"id":636327968,"url":"https://api.github.com/repos/ansible/ansible/labels/support:community","name":"support:community","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-02-15T18:05:52Z","updated_at":"2018-03-07T22:55:41Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/36252","html_url":"https://github.com/ansible/ansible/pull/36252","diff_url":"https://github.com/ansible/ansible/pull/36252.diff","patch_url":"https://github.com/ansible/ansible/pull/36252.patch"},"body":"##### SUMMARY\r\nChanges to make the module idempotent.  Currently, a new version of the parameter will be stored every time the playbook is ran, even if nothing has changed which isn't idempotent and causes unnecessary versions to be created.\r\n\r\n##### ISSUE TYPE\r\n - Bugfix Pull Request\r\n\r\n##### COMPONENT NAME\r\naws_ssm_parameter_store\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.5.0b1 (stable-2.5 a7a03bbf4a) last updated 2018/02/15 17:54:35 (GMT +100)\r\n```\r\n\r\n\r\n##### ADDITIONAL INFORMATION\r\n<!---\r\nInclude additional information to help people understand the change here.\r\nFor bugs that don't have a linked bug report, a step-by-step reproduction\r\nof the problem is helpful.\r\n  -->\r\n\r\nBefore:\r\n```\r\n⇒  ansible-playbook -vv current_module.yml\r\n\r\nPLAYBOOK: current_module.yml ***********************************************************************************************************************************************************************************\r\n1 plays in current_module.yml\r\n\r\nPLAY [Current Module] ******************************************************************************************************************************************************************************************\r\n\r\nTASK [Gathering Facts] *****************************************************************************************************************************************************************************************\r\nok: [localhost]\r\nMETA: ran handlers\r\n\r\nTASK [Manage keys in AWS Parameter store] **********************************************************************************************************************************************************************\r\nchanged: [localhost] => (item={'name': 'test_name', 'value': 'test_value', 'description': 'test_description', 'string_type': 'String', 'overwrite': 'true'}) => {\"changed\": true, \"item\": {\"description\": \"test_description\", \"name\": \"test_name\", \"overwrite\": \"true\", \"string_type\": \"String\", \"value\": \"test_value\"}, \"response\": {\"ResponseMetadata\": {\"HTTPHeaders\": {\"content-length\": \"13\", \"content-type\": \"application/x-amz-json-1.1\", \"date\": \"Thu, 15 Feb 2018 18:04:34 GMT\", \"x-amzn-requestid\": \"adbd1448-127a-11e8-b547-ff682365b6d1\"}, \"HTTPStatusCode\": 200, \"RequestId\": \"adbd1448-127a-11e8-b547-ff682365b6d1\", \"RetryAttempts\": 0}, \"Version\": 1}}\r\nMETA: ran handlers\r\nMETA: ran handlers\r\n\r\nPLAY RECAP *****************************************************************************************************************************************************************************************************\r\nlocalhost                  : ok=2    changed=1    unreachable=0    failed=0\r\n\r\n\r\n\r\n\r\n⇒  ansible-playbook -vv current_module.yml\r\n\r\nPLAYBOOK: current_module.yml ***********************************************************************************************************************************************************************************\r\n1 plays in current_module.yml\r\n\r\nPLAY [Current Module] ******************************************************************************************************************************************************************************************\r\n\r\nTASK [Gathering Facts] *****************************************************************************************************************************************************************************************\r\nok: [localhost]\r\nMETA: ran handlers\r\n\r\nTASK [Manage keys in AWS Parameter store] **********************************************************************************************************************************************************************\r\nchanged: [localhost] => (item={'name': 'test_name', 'value': 'test_value', 'description': 'test_description', 'string_type': 'String', 'overwrite': 'true'}) => {\"changed\": true, \"item\": {\"description\": \"test_description\", \"name\": \"test_name\", \"overwrite\": \"true\", \"string_type\": \"String\", \"value\": \"test_value\"}, \"response\": {\"ResponseMetadata\": {\"HTTPHeaders\": {\"content-length\": \"13\", \"content-type\": \"application/x-amz-json-1.1\", \"date\": \"Thu, 15 Feb 2018 18:04:39 GMT\", \"x-amzn-requestid\": \"b112f5cb-127a-11e8-bdee-8f7444e0535d\"}, \"HTTPStatusCode\": 200, \"RequestId\": \"b112f5cb-127a-11e8-bdee-8f7444e0535d\", \"RetryAttempts\": 0}, \"Version\": 2}}\r\nMETA: ran handlers\r\nMETA: ran handlers\r\n\r\nPLAY RECAP *****************************************************************************************************************************************************************************************************\r\nlocalhost                  : ok=2    changed=1    unreachable=0    failed=0\r\n```\r\n\r\n\r\nAfter:\r\n```\r\n⇒  ansible-playbook -vv working_idempotence.yml\r\n\r\nPLAYBOOK: working_idempotence.yml ******************************************************************************************************************************************************************************\r\n1 plays in working_idempotence.yml\r\n\r\nPLAY [Working SSM Idempotence] *********************************************************************************************************************************************************************************\r\n\r\nTASK [Gathering Facts] *****************************************************************************************************************************************************************************************\r\nok: [localhost]\r\nMETA: ran handlers\r\n\r\nTASK [Manage keys in AWS Parameter store] **********************************************************************************************************************************************************************\r\nchanged: [localhost] => (item={'name': 'test_name', 'value': 'test_value', 'description': 'test_description', 'string_type': 'String', 'overwrite': 'true'}) => {\"changed\": true, \"item\": {\"description\": \"test_description\", \"name\": \"test_name\", \"overwrite\": \"true\", \"string_type\": \"String\", \"value\": \"test_value\"}, \"response\": {\"ResponseMetadata\": {\"HTTPHeaders\": {\"content-length\": \"13\", \"content-type\": \"application/x-amz-json-1.1\", \"date\": \"Thu, 15 Feb 2018 18:00:09 GMT\", \"x-amzn-requestid\": \"105e5e50-127a-11e8-8efa-3745e3a9736d\"}, \"HTTPStatusCode\": 200, \"RequestId\": \"105e5e50-127a-11e8-8efa-3745e3a9736d\", \"RetryAttempts\": 0}, \"Version\": 1}}\r\nMETA: ran handlers\r\nMETA: ran handlers\r\n\r\nPLAY RECAP *****************************************************************************************************************************************************************************************************\r\nlocalhost                  : ok=2    changed=1    unreachable=0    failed=0\r\n\r\n\r\n\r\n⇒  ansible-playbook -vv working_idempotence.yml\r\n\r\nPLAYBOOK: working_idempotence.yml ******************************************************************************************************************************************************************************\r\n1 plays in working_idempotence.yml\r\n\r\nPLAY [Working SSM Idempotence] *********************************************************************************************************************************************************************************\r\n\r\nTASK [Gathering Facts] *****************************************************************************************************************************************************************************************\r\nok: [localhost]\r\nMETA: ran handlers\r\n\r\nTASK [Manage keys in AWS Parameter store] **********************************************************************************************************************************************************************\r\nok: [localhost] => (item={'name': 'test_name', 'value': 'test_value', 'description': 'test_description', 'string_type': 'String', 'overwrite': 'true'}) => {\"changed\": false, \"item\": {\"description\": \"test_description\", \"name\": \"test_name\", \"overwrite\": \"true\", \"string_type\": \"String\", \"value\": \"test_value\"}, \"response\": {}}\r\nMETA: ran handlers\r\nMETA: ran handlers\r\n\r\nPLAY RECAP *****************************************************************************************************************************************************************************************************\r\nlocalhost                  : ok=2    changed=0    unreachable=0    failed=0\r\n```"},"comment":{"url":"https://api.github.com/repos/ansible/ansible/issues/comments/371315115","html_url":"https://github.com/ansible/ansible/pull/36252#issuecomment-371315115","issue_url":"https://api.github.com/repos/ansible/ansible/issues/36252","id":371315115,"user":{"login":"nathanwebsterdotme","id":14338821,"avatar_url":"https://avatars2.githubusercontent.com/u/14338821?v=4","gravatar_id":"","url":"https://api.github.com/users/nathanwebsterdotme","html_url":"https://github.com/nathanwebsterdotme","followers_url":"https://api.github.com/users/nathanwebsterdotme/followers","following_url":"https://api.github.com/users/nathanwebsterdotme/following{/other_user}","gists_url":"https://api.github.com/users/nathanwebsterdotme/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanwebsterdotme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanwebsterdotme/subscriptions","organizations_url":"https://api.github.com/users/nathanwebsterdotme/orgs","repos_url":"https://api.github.com/users/nathanwebsterdotme/repos","events_url":"https://api.github.com/users/nathanwebsterdotme/events{/privacy}","received_events_url":"https://api.github.com/users/nathanwebsterdotme/received_events","type":"User","site_admin":false},"created_at":"2018-03-07T22:55:41Z","updated_at":"2018-03-07T22:55:41Z","author_association":"NONE","body":"@mikedlr changes done"}}
{"actor":{"display_login":"nathanwebsterdotme"}}