{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/pai/pulls/comments/176300511","pull_request_review_id":105977875,"id":176300511,"diff_hunk":"@@ -23,18 +23,22 @@ data:\n   prometheus.yml: |-\n     # Scrape config for cluster components.\n     scrape_configs: \n-    - job_name: \"node_exporter\"\n-      scrape_interval: \"15s\"","path":"service-deployment/bootstrap/prometheus/prometheus-configmap.yaml.template","position":5,"original_position":5,"commit_id":"4046cb81dfb6ba93c86a482c297058cccb668840","original_commit_id":"4046cb81dfb6ba93c86a482c297058cccb668840","user":{"login":"fanyangCS","id":5820832,"avatar_url":"https://avatars2.githubusercontent.com/u/5820832?v=4","gravatar_id":"","url":"https://api.github.com/users/fanyangCS","html_url":"https://github.com/fanyangCS","followers_url":"https://api.github.com/users/fanyangCS/followers","following_url":"https://api.github.com/users/fanyangCS/following{/other_user}","gists_url":"https://api.github.com/users/fanyangCS/gists{/gist_id}","starred_url":"https://api.github.com/users/fanyangCS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanyangCS/subscriptions","organizations_url":"https://api.github.com/users/fanyangCS/orgs","repos_url":"https://api.github.com/users/fanyangCS/repos","events_url":"https://api.github.com/users/fanyangCS/events{/privacy}","received_events_url":"https://api.github.com/users/fanyangCS/received_events","type":"User","site_admin":false},"body":"we need to control the scrape interval. please fix it.\r\n\r\n---\r\nIn reply to: [176297106](https://github.com/Microsoft/pai/pull/395#discussion_r176297106) [](ancestors = 176297106)","created_at":"2018-03-22T03:32:45Z","updated_at":"2018-03-22T03:32:45Z","html_url":"https://github.com/Microsoft/pai/pull/395#discussion_r176300511","pull_request_url":"https://api.github.com/repos/Microsoft/pai/pulls/395","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/pai/pulls/comments/176300511"},"html":{"href":"https://github.com/Microsoft/pai/pull/395#discussion_r176300511"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/pai/pulls/395"}},"in_reply_to_id":176042743},"pull_request":{"url":"https://api.github.com/repos/Microsoft/pai/pulls/395","id":176084566,"html_url":"https://github.com/Microsoft/pai/pull/395","diff_url":"https://github.com/Microsoft/pai/pull/395.diff","patch_url":"https://github.com/Microsoft/pai/pull/395.patch","issue_url":"https://api.github.com/repos/Microsoft/pai/issues/395","number":395,"state":"open","locked":false,"title":"prometheus node discovery ","user":{"login":"YanjieGao","id":5576848,"avatar_url":"https://avatars3.githubusercontent.com/u/5576848?v=4","gravatar_id":"","url":"https://api.github.com/users/YanjieGao","html_url":"https://github.com/YanjieGao","followers_url":"https://api.github.com/users/YanjieGao/followers","following_url":"https://api.github.com/users/YanjieGao/following{/other_user}","gists_url":"https://api.github.com/users/YanjieGao/gists{/gist_id}","starred_url":"https://api.github.com/users/YanjieGao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YanjieGao/subscriptions","organizations_url":"https://api.github.com/users/YanjieGao/orgs","repos_url":"https://api.github.com/users/YanjieGao/repos","events_url":"https://api.github.com/users/YanjieGao/events{/privacy}","received_events_url":"https://api.github.com/users/YanjieGao/received_events","type":"User","site_admin":false},"body":"\r\nFrom this PR prometheus will leverage kubernetes api server info to monitor node.\r\nWhen nodes add and leave, prometheus can dynamic detect the live nodes and profile them.\r\nTo solve this issue #348","created_at":"2018-03-20T04:08:24Z","updated_at":"2018-03-22T03:32:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e8994c5c81b1a56536354408982668e29b297d1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ydye","id":8675883,"avatar_url":"https://avatars2.githubusercontent.com/u/8675883?v=4","gravatar_id":"","url":"https://api.github.com/users/ydye","html_url":"https://github.com/ydye","followers_url":"https://api.github.com/users/ydye/followers","following_url":"https://api.github.com/users/ydye/following{/other_user}","gists_url":"https://api.github.com/users/ydye/gists{/gist_id}","starred_url":"https://api.github.com/users/ydye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ydye/subscriptions","organizations_url":"https://api.github.com/users/ydye/orgs","repos_url":"https://api.github.com/users/ydye/repos","events_url":"https://api.github.com/users/ydye/events{/privacy}","received_events_url":"https://api.github.com/users/ydye/received_events","type":"User","site_admin":false},{"login":"sterowang","id":11206612,"avatar_url":"https://avatars2.githubusercontent.com/u/11206612?v=4","gravatar_id":"","url":"https://api.github.com/users/sterowang","html_url":"https://github.com/sterowang","followers_url":"https://api.github.com/users/sterowang/followers","following_url":"https://api.github.com/users/sterowang/following{/other_user}","gists_url":"https://api.github.com/users/sterowang/gists{/gist_id}","starred_url":"https://api.github.com/users/sterowang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sterowang/subscriptions","organizations_url":"https://api.github.com/users/sterowang/orgs","repos_url":"https://api.github.com/users/sterowang/repos","events_url":"https://api.github.com/users/sterowang/events{/privacy}","received_events_url":"https://api.github.com/users/sterowang/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/pai/pulls/395/commits","review_comments_url":"https://api.github.com/repos/Microsoft/pai/pulls/395/comments","review_comment_url":"https://api.github.com/repos/Microsoft/pai/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/pai/issues/395/comments","statuses_url":"https://api.github.com/repos/Microsoft/pai/statuses/4046cb81dfb6ba93c86a482c297058cccb668840","head":{"label":"Microsoft:yanjga/sd","ref":"yanjga/sd","sha":"4046cb81dfb6ba93c86a482c297058cccb668840","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":104741169,"name":"pai","full_name":"Microsoft/pai","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/pai","description":"Resource scheduling and cluster management for AI","fork":false,"url":"https://api.github.com/repos/Microsoft/pai","forks_url":"https://api.github.com/repos/Microsoft/pai/forks","keys_url":"https://api.github.com/repos/Microsoft/pai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/pai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/pai/teams","hooks_url":"https://api.github.com/repos/Microsoft/pai/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/pai/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/pai/events","assignees_url":"https://api.github.com/repos/Microsoft/pai/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/pai/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/pai/tags","blobs_url":"https://api.github.com/repos/Microsoft/pai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/pai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/pai/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/pai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/pai/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/pai/languages","stargazers_url":"https://api.github.com/repos/Microsoft/pai/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/pai/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/pai/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/pai/subscription","commits_url":"https://api.github.com/repos/Microsoft/pai/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/pai/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/pai/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/pai/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/pai/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/pai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/pai/merges","archive_url":"https://api.github.com/repos/Microsoft/pai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/pai/downloads","issues_url":"https://api.github.com/repos/Microsoft/pai/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/pai/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/pai/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/pai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/pai/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/pai/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/pai/deployments","created_at":"2017-09-25T11:24:51Z","updated_at":"2018-03-22T01:55:06Z","pushed_at":"2018-03-22T03:19:13Z","git_url":"git://github.com/Microsoft/pai.git","ssh_url":"git@github.com:Microsoft/pai.git","clone_url":"https://github.com/Microsoft/pai.git","svn_url":"https://github.com/Microsoft/pai","homepage":"","size":2215,"stargazers_count":101,"watchers_count":101,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":23,"open_issues":52,"watchers":101,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"9a05c765fc7c6388bb70081a05edd0da0129f795","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":104741169,"name":"pai","full_name":"Microsoft/pai","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/pai","description":"Resource scheduling and cluster management for AI","fork":false,"url":"https://api.github.com/repos/Microsoft/pai","forks_url":"https://api.github.com/repos/Microsoft/pai/forks","keys_url":"https://api.github.com/repos/Microsoft/pai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/pai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/pai/teams","hooks_url":"https://api.github.com/repos/Microsoft/pai/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/pai/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/pai/events","assignees_url":"https://api.github.com/repos/Microsoft/pai/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/pai/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/pai/tags","blobs_url":"https://api.github.com/repos/Microsoft/pai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/pai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/pai/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/pai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/pai/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/pai/languages","stargazers_url":"https://api.github.com/repos/Microsoft/pai/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/pai/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/pai/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/pai/subscription","commits_url":"https://api.github.com/repos/Microsoft/pai/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/pai/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/pai/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/pai/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/pai/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/pai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/pai/merges","archive_url":"https://api.github.com/repos/Microsoft/pai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/pai/downloads","issues_url":"https://api.github.com/repos/Microsoft/pai/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/pai/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/pai/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/pai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/pai/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/pai/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/pai/deployments","created_at":"2017-09-25T11:24:51Z","updated_at":"2018-03-22T01:55:06Z","pushed_at":"2018-03-22T03:19:13Z","git_url":"git://github.com/Microsoft/pai.git","ssh_url":"git@github.com:Microsoft/pai.git","clone_url":"https://github.com/Microsoft/pai.git","svn_url":"https://github.com/Microsoft/pai","homepage":"","size":2215,"stargazers_count":101,"watchers_count":101,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":23,"open_issues":52,"watchers":101,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/pai/pulls/395"},"html":{"href":"https://github.com/Microsoft/pai/pull/395"},"issue":{"href":"https://api.github.com/repos/Microsoft/pai/issues/395"},"comments":{"href":"https://api.github.com/repos/Microsoft/pai/issues/395/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/pai/pulls/395/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/pai/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/pai/pulls/395/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/pai/statuses/4046cb81dfb6ba93c86a482c297058cccb668840"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fanyangCS"}}