{"action":"created","issue":{"url":"https://api.github.com/repos/Gernott/mask/issues/145","repository_url":"https://api.github.com/repos/Gernott/mask","labels_url":"https://api.github.com/repos/Gernott/mask/issues/145/labels{/name}","comments_url":"https://api.github.com/repos/Gernott/mask/issues/145/comments","events_url":"https://api.github.com/repos/Gernott/mask/issues/145/events","html_url":"https://github.com/Gernott/mask/pull/145","id":311888078,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc5ODgyOTEz","number":145,"title":"Use Doctrine DBAL instead of TYPO3_DB","user":{"login":"markuspoerschke","id":1222377,"node_id":"MDQ6VXNlcjEyMjIzNzc=","avatar_url":"https://avatars0.githubusercontent.com/u/1222377?v=4","gravatar_id":"","url":"https://api.github.com/users/markuspoerschke","html_url":"https://github.com/markuspoerschke","followers_url":"https://api.github.com/users/markuspoerschke/followers","following_url":"https://api.github.com/users/markuspoerschke/following{/other_user}","gists_url":"https://api.github.com/users/markuspoerschke/gists{/gist_id}","starred_url":"https://api.github.com/users/markuspoerschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markuspoerschke/subscriptions","organizations_url":"https://api.github.com/users/markuspoerschke/orgs","repos_url":"https://api.github.com/users/markuspoerschke/repos","events_url":"https://api.github.com/users/markuspoerschke/events{/privacy}","received_events_url":"https://api.github.com/users/markuspoerschke/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-06T08:24:21Z","updated_at":"2018-08-06T08:07:11Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Gernott/mask/pulls/145","html_url":"https://github.com/Gernott/mask/pull/145","diff_url":"https://github.com/Gernott/mask/pull/145.diff","patch_url":"https://github.com/Gernott/mask/pull/145.patch"},"body":"This is the first step of making this extension compatible with TYPO3 version 9.\r\nTYPO3_DB was deprecated in version 8 and is removed in version 9.\r\n\r\nI need somebody here who can help testing.\r\n\r\nI tested the SQLCodeGenerator sucessfully already but I am unsure how to test\r\n- `InlineHelper.php`\r\n- `PageLayoutViewDrawItem`\r\n- `ShuttleViewHelper`\r\n- `user_mask_contentType`\r\n- and `user_mask_beLayout`.\r\n\r\n**This is a breaking change since a protected method `SqlCodeGenerator::getDatabaseConnection` was removed!** I assume that master branch will become version 4 of mask? @Gernott can you check what branch we can use PR for when upgrading this extension to TYPO3 v9?"},"comment":{"url":"https://api.github.com/repos/Gernott/mask/issues/comments/410623713","html_url":"https://github.com/Gernott/mask/pull/145#issuecomment-410623713","issue_url":"https://api.github.com/repos/Gernott/mask/issues/145","id":410623713,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDYyMzcxMw==","user":{"login":"markuspoerschke","id":1222377,"node_id":"MDQ6VXNlcjEyMjIzNzc=","avatar_url":"https://avatars0.githubusercontent.com/u/1222377?v=4","gravatar_id":"","url":"https://api.github.com/users/markuspoerschke","html_url":"https://github.com/markuspoerschke","followers_url":"https://api.github.com/users/markuspoerschke/followers","following_url":"https://api.github.com/users/markuspoerschke/following{/other_user}","gists_url":"https://api.github.com/users/markuspoerschke/gists{/gist_id}","starred_url":"https://api.github.com/users/markuspoerschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markuspoerschke/subscriptions","organizations_url":"https://api.github.com/users/markuspoerschke/orgs","repos_url":"https://api.github.com/users/markuspoerschke/repos","events_url":"https://api.github.com/users/markuspoerschke/events{/privacy}","received_events_url":"https://api.github.com/users/markuspoerschke/received_events","type":"User","site_admin":false},"created_at":"2018-08-06T08:07:11Z","updated_at":"2018-08-06T08:07:11Z","author_association":"CONTRIBUTOR","body":"@Gernott Can you check this Pull Request? These changes are crucial for the update to TYPO3 Version 9."}}
{"actor":{"display_login":"markuspoerschke"}}