{"action":"created","comment":{"url":"https://api.github.com/repos/koreader/koreader/pulls/comments/210962012","pull_request_review_id":147292540,"id":210962012,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDk2MjAxMg==","diff_hunk":"@@ -454,6 +455,25 @@ function FileManager:tapPlus()\n                     UIManager:close(self.file_dialog)\n                 end\n             }\n+        },\n+        {\n+            {\n+                text = _(\"Favorite folders\"),\n+                callback = function()\n+                    local fm_bookmark =  FileManagerBookmark:new{\n+                        title = _(\"Favorite folders\"),","path":"frontend/apps/filemanager/filemanager.lua","position":18,"original_position":18,"commit_id":"4167585d9d67b0c4f814351431fc85fa282e9eb8","original_commit_id":"4167585d9d67b0c4f814351431fc85fa282e9eb8","user":{"login":"Frenzie","id":202757,"node_id":"MDQ6VXNlcjIwMjc1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/202757?v=4","gravatar_id":"","url":"https://api.github.com/users/Frenzie","html_url":"https://github.com/Frenzie","followers_url":"https://api.github.com/users/Frenzie/followers","following_url":"https://api.github.com/users/Frenzie/following{/other_user}","gists_url":"https://api.github.com/users/Frenzie/gists{/gist_id}","starred_url":"https://api.github.com/users/Frenzie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Frenzie/subscriptions","organizations_url":"https://api.github.com/users/Frenzie/orgs","repos_url":"https://api.github.com/users/Frenzie/repos","events_url":"https://api.github.com/users/Frenzie/events{/privacy}","received_events_url":"https://api.github.com/users/Frenzie/received_events","type":"User","site_admin":false},"body":"As an aside, I ever so slightly prefer \"bookmarks\" over \"favorites,\" not sure why. In this case I'm a bit torn as to whether it's clearer to be consistent in the naming or not. It might indeed be clearer to have bookmarks in the reader and favorites in the filemanager to prevent confusion.\r\n\r\nBut the main reason I'm commenting is that I think it's a bit weird to have a split between the code and the text here. It's not like this is older code in which we changed the display text to favorites instead of bookmarks, so why create a distinction? ;-)","created_at":"2018-08-17T16:19:26Z","updated_at":"2018-08-17T16:25:30Z","html_url":"https://github.com/koreader/koreader/pull/4165#discussion_r210962012","pull_request_url":"https://api.github.com/repos/koreader/koreader/pulls/4165","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/koreader/koreader/pulls/comments/210962012"},"html":{"href":"https://github.com/koreader/koreader/pull/4165#discussion_r210962012"},"pull_request":{"href":"https://api.github.com/repos/koreader/koreader/pulls/4165"}}},"pull_request":{"url":"https://api.github.com/repos/koreader/koreader/pulls/4165","id":209065130,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MDY1MTMw","html_url":"https://github.com/koreader/koreader/pull/4165","diff_url":"https://github.com/koreader/koreader/pull/4165.diff","patch_url":"https://github.com/koreader/koreader/pull/4165.patch","issue_url":"https://api.github.com/repos/koreader/koreader/issues/4165","number":4165,"state":"open","locked":false,"title":"Folder favorites","user":{"login":"robert00s","id":22982594,"node_id":"MDQ6VXNlcjIyOTgyNTk0","avatar_url":"https://avatars2.githubusercontent.com/u/22982594?v=4","gravatar_id":"","url":"https://api.github.com/users/robert00s","html_url":"https://github.com/robert00s","followers_url":"https://api.github.com/users/robert00s/followers","following_url":"https://api.github.com/users/robert00s/following{/other_user}","gists_url":"https://api.github.com/users/robert00s/gists{/gist_id}","starred_url":"https://api.github.com/users/robert00s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robert00s/subscriptions","organizations_url":"https://api.github.com/users/robert00s/orgs","repos_url":"https://api.github.com/users/robert00s/repos","events_url":"https://api.github.com/users/robert00s/events{/privacy}","received_events_url":"https://api.github.com/users/robert00s/received_events","type":"User","site_admin":false},"body":"Close: #1181\r\n\r\nScreenshots:\r\n\r\n![test - koreader_019](https://user-images.githubusercontent.com/22982594/44252975-55ea8c80-a1fe-11e8-81a1-7b773bf120ee.png)\r\n![test - koreader_020](https://user-images.githubusercontent.com/22982594/44252976-56832300-a1fe-11e8-86bf-8215250fdb72.png)\r\n![test - koreader_021](https://user-images.githubusercontent.com/22982594/44252977-56832300-a1fe-11e8-8e91-018d2a597a76.png)\r\n![test - koreader_022](https://user-images.githubusercontent.com/22982594/44252978-56832300-a1fe-11e8-9f9c-9e4ac31cde95.png)\r\n","created_at":"2018-08-17T07:19:41Z","updated_at":"2018-08-17T16:25:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a3eac0383a64115797369bd34179103866f1148","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/koreader/koreader/pulls/4165/commits","review_comments_url":"https://api.github.com/repos/koreader/koreader/pulls/4165/comments","review_comment_url":"https://api.github.com/repos/koreader/koreader/pulls/comments{/number}","comments_url":"https://api.github.com/repos/koreader/koreader/issues/4165/comments","statuses_url":"https://api.github.com/repos/koreader/koreader/statuses/4167585d9d67b0c4f814351431fc85fa282e9eb8","head":{"label":"robert00s:folder_favorites","ref":"folder_favorites","sha":"4167585d9d67b0c4f814351431fc85fa282e9eb8","user":{"login":"robert00s","id":22982594,"node_id":"MDQ6VXNlcjIyOTgyNTk0","avatar_url":"https://avatars2.githubusercontent.com/u/22982594?v=4","gravatar_id":"","url":"https://api.github.com/users/robert00s","html_url":"https://github.com/robert00s","followers_url":"https://api.github.com/users/robert00s/followers","following_url":"https://api.github.com/users/robert00s/following{/other_user}","gists_url":"https://api.github.com/users/robert00s/gists{/gist_id}","starred_url":"https://api.github.com/users/robert00s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robert00s/subscriptions","organizations_url":"https://api.github.com/users/robert00s/orgs","repos_url":"https://api.github.com/users/robert00s/repos","events_url":"https://api.github.com/users/robert00s/events{/privacy}","received_events_url":"https://api.github.com/users/robert00s/received_events","type":"User","site_admin":false},"repo":{"id":71635200,"node_id":"MDEwOlJlcG9zaXRvcnk3MTYzNTIwMA==","name":"koreader","full_name":"robert00s/koreader","owner":{"login":"robert00s","id":22982594,"node_id":"MDQ6VXNlcjIyOTgyNTk0","avatar_url":"https://avatars2.githubusercontent.com/u/22982594?v=4","gravatar_id":"","url":"https://api.github.com/users/robert00s","html_url":"https://github.com/robert00s","followers_url":"https://api.github.com/users/robert00s/followers","following_url":"https://api.github.com/users/robert00s/following{/other_user}","gists_url":"https://api.github.com/users/robert00s/gists{/gist_id}","starred_url":"https://api.github.com/users/robert00s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robert00s/subscriptions","organizations_url":"https://api.github.com/users/robert00s/orgs","repos_url":"https://api.github.com/users/robert00s/repos","events_url":"https://api.github.com/users/robert00s/events{/privacy}","received_events_url":"https://api.github.com/users/robert00s/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robert00s/koreader","description":"An ebook reader application supporting PDF, DjVu, EPUB, FB2 and many more formats, running on Kindle, Kobo, PocketBook, Ubuntu Touch and Android devices","fork":true,"url":"https://api.github.com/repos/robert00s/koreader","forks_url":"https://api.github.com/repos/robert00s/koreader/forks","keys_url":"https://api.github.com/repos/robert00s/koreader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robert00s/koreader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robert00s/koreader/teams","hooks_url":"https://api.github.com/repos/robert00s/koreader/hooks","issue_events_url":"https://api.github.com/repos/robert00s/koreader/issues/events{/number}","events_url":"https://api.github.com/repos/robert00s/koreader/events","assignees_url":"https://api.github.com/repos/robert00s/koreader/assignees{/user}","branches_url":"https://api.github.com/repos/robert00s/koreader/branches{/branch}","tags_url":"https://api.github.com/repos/robert00s/koreader/tags","blobs_url":"https://api.github.com/repos/robert00s/koreader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robert00s/koreader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robert00s/koreader/git/refs{/sha}","trees_url":"https://api.github.com/repos/robert00s/koreader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robert00s/koreader/statuses/{sha}","languages_url":"https://api.github.com/repos/robert00s/koreader/languages","stargazers_url":"https://api.github.com/repos/robert00s/koreader/stargazers","contributors_url":"https://api.github.com/repos/robert00s/koreader/contributors","subscribers_url":"https://api.github.com/repos/robert00s/koreader/subscribers","subscription_url":"https://api.github.com/repos/robert00s/koreader/subscription","commits_url":"https://api.github.com/repos/robert00s/koreader/commits{/sha}","git_commits_url":"https://api.github.com/repos/robert00s/koreader/git/commits{/sha}","comments_url":"https://api.github.com/repos/robert00s/koreader/comments{/number}","issue_comment_url":"https://api.github.com/repos/robert00s/koreader/issues/comments{/number}","contents_url":"https://api.github.com/repos/robert00s/koreader/contents/{+path}","compare_url":"https://api.github.com/repos/robert00s/koreader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robert00s/koreader/merges","archive_url":"https://api.github.com/repos/robert00s/koreader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robert00s/koreader/downloads","issues_url":"https://api.github.com/repos/robert00s/koreader/issues{/number}","pulls_url":"https://api.github.com/repos/robert00s/koreader/pulls{/number}","milestones_url":"https://api.github.com/repos/robert00s/koreader/milestones{/number}","notifications_url":"https://api.github.com/repos/robert00s/koreader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robert00s/koreader/labels{/name}","releases_url":"https://api.github.com/repos/robert00s/koreader/releases{/id}","deployments_url":"https://api.github.com/repos/robert00s/koreader/deployments","created_at":"2016-10-22T11:35:44Z","updated_at":"2017-08-04T14:20:53Z","pushed_at":"2018-08-17T08:15:56Z","git_url":"git://github.com/robert00s/koreader.git","ssh_url":"git@github.com:robert00s/koreader.git","clone_url":"https://github.com/robert00s/koreader.git","svn_url":"https://github.com/robert00s/koreader","homepage":"","size":38587,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"koreader:master","ref":"master","sha":"cd37535056ed571d111cf3a732a02e5f95cbc755","user":{"login":"koreader","id":3957564,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NTc1NjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3957564?v=4","gravatar_id":"","url":"https://api.github.com/users/koreader","html_url":"https://github.com/koreader","followers_url":"https://api.github.com/users/koreader/followers","following_url":"https://api.github.com/users/koreader/following{/other_user}","gists_url":"https://api.github.com/users/koreader/gists{/gist_id}","starred_url":"https://api.github.com/users/koreader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koreader/subscriptions","organizations_url":"https://api.github.com/users/koreader/orgs","repos_url":"https://api.github.com/users/koreader/repos","events_url":"https://api.github.com/users/koreader/events{/privacy}","received_events_url":"https://api.github.com/users/koreader/received_events","type":"Organization","site_admin":false},"repo":{"id":8986217,"node_id":"MDEwOlJlcG9zaXRvcnk4OTg2MjE3","name":"koreader","full_name":"koreader/koreader","owner":{"login":"koreader","id":3957564,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NTc1NjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3957564?v=4","gravatar_id":"","url":"https://api.github.com/users/koreader","html_url":"https://github.com/koreader","followers_url":"https://api.github.com/users/koreader/followers","following_url":"https://api.github.com/users/koreader/following{/other_user}","gists_url":"https://api.github.com/users/koreader/gists{/gist_id}","starred_url":"https://api.github.com/users/koreader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koreader/subscriptions","organizations_url":"https://api.github.com/users/koreader/orgs","repos_url":"https://api.github.com/users/koreader/repos","events_url":"https://api.github.com/users/koreader/events{/privacy}","received_events_url":"https://api.github.com/users/koreader/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/koreader/koreader","description":"An ebook reader application supporting PDF, DjVu, EPUB, FB2 and many more formats, running on Kindle, Kobo, PocketBook, Ubuntu Touch and Android devices","fork":false,"url":"https://api.github.com/repos/koreader/koreader","forks_url":"https://api.github.com/repos/koreader/koreader/forks","keys_url":"https://api.github.com/repos/koreader/koreader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/koreader/koreader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/koreader/koreader/teams","hooks_url":"https://api.github.com/repos/koreader/koreader/hooks","issue_events_url":"https://api.github.com/repos/koreader/koreader/issues/events{/number}","events_url":"https://api.github.com/repos/koreader/koreader/events","assignees_url":"https://api.github.com/repos/koreader/koreader/assignees{/user}","branches_url":"https://api.github.com/repos/koreader/koreader/branches{/branch}","tags_url":"https://api.github.com/repos/koreader/koreader/tags","blobs_url":"https://api.github.com/repos/koreader/koreader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/koreader/koreader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/koreader/koreader/git/refs{/sha}","trees_url":"https://api.github.com/repos/koreader/koreader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/koreader/koreader/statuses/{sha}","languages_url":"https://api.github.com/repos/koreader/koreader/languages","stargazers_url":"https://api.github.com/repos/koreader/koreader/stargazers","contributors_url":"https://api.github.com/repos/koreader/koreader/contributors","subscribers_url":"https://api.github.com/repos/koreader/koreader/subscribers","subscription_url":"https://api.github.com/repos/koreader/koreader/subscription","commits_url":"https://api.github.com/repos/koreader/koreader/commits{/sha}","git_commits_url":"https://api.github.com/repos/koreader/koreader/git/commits{/sha}","comments_url":"https://api.github.com/repos/koreader/koreader/comments{/number}","issue_comment_url":"https://api.github.com/repos/koreader/koreader/issues/comments{/number}","contents_url":"https://api.github.com/repos/koreader/koreader/contents/{+path}","compare_url":"https://api.github.com/repos/koreader/koreader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/koreader/koreader/merges","archive_url":"https://api.github.com/repos/koreader/koreader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/koreader/koreader/downloads","issues_url":"https://api.github.com/repos/koreader/koreader/issues{/number}","pulls_url":"https://api.github.com/repos/koreader/koreader/pulls{/number}","milestones_url":"https://api.github.com/repos/koreader/koreader/milestones{/number}","notifications_url":"https://api.github.com/repos/koreader/koreader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/koreader/koreader/labels{/name}","releases_url":"https://api.github.com/repos/koreader/koreader/releases{/id}","deployments_url":"https://api.github.com/repos/koreader/koreader/deployments","created_at":"2013-03-24T13:09:42Z","updated_at":"2018-08-17T12:45:19Z","pushed_at":"2018-08-17T12:52:25Z","git_url":"git://github.com/koreader/koreader.git","ssh_url":"git@github.com:koreader/koreader.git","clone_url":"https://github.com/koreader/koreader.git","svn_url":"https://github.com/koreader/koreader","homepage":"http://koreader.rocks/","size":38389,"stargazers_count":4061,"watchers_count":4061,"language":"Lua","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":562,"mirror_url":null,"archived":false,"open_issues_count":334,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":562,"open_issues":334,"watchers":4061,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/koreader/koreader/pulls/4165"},"html":{"href":"https://github.com/koreader/koreader/pull/4165"},"issue":{"href":"https://api.github.com/repos/koreader/koreader/issues/4165"},"comments":{"href":"https://api.github.com/repos/koreader/koreader/issues/4165/comments"},"review_comments":{"href":"https://api.github.com/repos/koreader/koreader/pulls/4165/comments"},"review_comment":{"href":"https://api.github.com/repos/koreader/koreader/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/koreader/koreader/pulls/4165/commits"},"statuses":{"href":"https://api.github.com/repos/koreader/koreader/statuses/4167585d9d67b0c4f814351431fc85fa282e9eb8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Frenzie"}}