{"action":"created","comment":{"url":"https://api.github.com/repos/tigercosmos/StellarSQL/pulls/comments/244575921","pull_request_review_id":188485861,"id":244575921,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDU3NTkyMQ==","diff_hunk":"@@ -1,9 +1,106 @@\n use crate::Response;\n+use crate::sql::worker::SQL;\n+use crate::sql::worker::SQLError;\n+use crate::sql::parser::Parser;\n+use crate::sql::parser::ParserError;\n+use std::fmt;\n+\n+\n+#[derive(Debug)]\n+pub struct Request {\n+}\n+\n+\n+#[derive(Debug)]\n+pub enum RequestMsg {","path":"src/connection/request.rs","position":15,"original_position":15,"commit_id":"53a61706fd9582a694a2efc09ab9619ee487c03b","original_commit_id":"53a61706fd9582a694a2efc09ab9619ee487c03b","user":{"login":"tigercosmos","id":18013815,"node_id":"MDQ6VXNlcjE4MDEzODE1","avatar_url":"https://avatars0.githubusercontent.com/u/18013815?v=4","gravatar_id":"","url":"https://api.github.com/users/tigercosmos","html_url":"https://github.com/tigercosmos","followers_url":"https://api.github.com/users/tigercosmos/followers","following_url":"https://api.github.com/users/tigercosmos/following{/other_user}","gists_url":"https://api.github.com/users/tigercosmos/gists{/gist_id}","starred_url":"https://api.github.com/users/tigercosmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tigercosmos/subscriptions","organizations_url":"https://api.github.com/users/tigercosmos/orgs","repos_url":"https://api.github.com/users/tigercosmos/repos","events_url":"https://api.github.com/users/tigercosmos/events{/privacy}","received_events_url":"https://api.github.com/users/tigercosmos/received_events","type":"User","site_admin":false},"body":"I mean this line \r\n```rust\r\npub fn parse(input: &str, mut sql: &mut SQL) -> Result<Response, String> \r\n```","created_at":"2018-12-31T11:18:21Z","updated_at":"2018-12-31T11:18:21Z","html_url":"https://github.com/tigercosmos/StellarSQL/pull/6#discussion_r244575921","pull_request_url":"https://api.github.com/repos/tigercosmos/StellarSQL/pulls/6","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/tigercosmos/StellarSQL/pulls/comments/244575921"},"html":{"href":"https://github.com/tigercosmos/StellarSQL/pull/6#discussion_r244575921"},"pull_request":{"href":"https://api.github.com/repos/tigercosmos/StellarSQL/pulls/6"}},"in_reply_to_id":244575552},"pull_request":{"url":"https://api.github.com/repos/tigercosmos/StellarSQL/pulls/6","id":241550729,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNTUwNzI5","html_url":"https://github.com/tigercosmos/StellarSQL/pull/6","diff_url":"https://github.com/tigercosmos/StellarSQL/pull/6.diff","patch_url":"https://github.com/tigercosmos/StellarSQL/pull/6.patch","issue_url":"https://api.github.com/repos/tigercosmos/StellarSQL/issues/6","number":6,"state":"open","locked":false,"title":"combine connection(request) with parser/worker","user":{"login":"Dong513","id":31978093,"node_id":"MDQ6VXNlcjMxOTc4MDkz","avatar_url":"https://avatars2.githubusercontent.com/u/31978093?v=4","gravatar_id":"","url":"https://api.github.com/users/Dong513","html_url":"https://github.com/Dong513","followers_url":"https://api.github.com/users/Dong513/followers","following_url":"https://api.github.com/users/Dong513/following{/other_user}","gists_url":"https://api.github.com/users/Dong513/gists{/gist_id}","starred_url":"https://api.github.com/users/Dong513/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dong513/subscriptions","organizations_url":"https://api.github.com/users/Dong513/orgs","repos_url":"https://api.github.com/users/Dong513/repos","events_url":"https://api.github.com/users/Dong513/events{/privacy}","received_events_url":"https://api.github.com/users/Dong513/received_events","type":"User","site_admin":false},"body":"connection protocol: `user||dbname||cmd;`\r\nrequest procedure:\r\n1. check `user` (verification)\r\n2. check `dbname`\r\n2-1. if `dbname` is null, check `cmd` if it is `create database dbname;`\r\n2-2. if `dbname` is not null, call worker loading `dbname`, call parser parsing `cmd`\r\n","created_at":"2018-12-31T10:50:46Z","updated_at":"2018-12-31T11:18:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3c68c672b1751e37d290ec299c44423f4e3d032","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tigercosmos/StellarSQL/pulls/6/commits","review_comments_url":"https://api.github.com/repos/tigercosmos/StellarSQL/pulls/6/comments","review_comment_url":"https://api.github.com/repos/tigercosmos/StellarSQL/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tigercosmos/StellarSQL/issues/6/comments","statuses_url":"https://api.github.com/repos/tigercosmos/StellarSQL/statuses/53a61706fd9582a694a2efc09ab9619ee487c03b","head":{"label":"Dong513:master","ref":"master","sha":"53a61706fd9582a694a2efc09ab9619ee487c03b","user":{"login":"Dong513","id":31978093,"node_id":"MDQ6VXNlcjMxOTc4MDkz","avatar_url":"https://avatars2.githubusercontent.com/u/31978093?v=4","gravatar_id":"","url":"https://api.github.com/users/Dong513","html_url":"https://github.com/Dong513","followers_url":"https://api.github.com/users/Dong513/followers","following_url":"https://api.github.com/users/Dong513/following{/other_user}","gists_url":"https://api.github.com/users/Dong513/gists{/gist_id}","starred_url":"https://api.github.com/users/Dong513/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dong513/subscriptions","organizations_url":"https://api.github.com/users/Dong513/orgs","repos_url":"https://api.github.com/users/Dong513/repos","events_url":"https://api.github.com/users/Dong513/events{/privacy}","received_events_url":"https://api.github.com/users/Dong513/received_events","type":"User","site_admin":false},"repo":{"id":163460290,"node_id":"MDEwOlJlcG9zaXRvcnkxNjM0NjAyOTA=","name":"StellarSQL","full_name":"Dong513/StellarSQL","private":false,"owner":{"login":"Dong513","id":31978093,"node_id":"MDQ6VXNlcjMxOTc4MDkz","avatar_url":"https://avatars2.githubusercontent.com/u/31978093?v=4","gravatar_id":"","url":"https://api.github.com/users/Dong513","html_url":"https://github.com/Dong513","followers_url":"https://api.github.com/users/Dong513/followers","following_url":"https://api.github.com/users/Dong513/following{/other_user}","gists_url":"https://api.github.com/users/Dong513/gists{/gist_id}","starred_url":"https://api.github.com/users/Dong513/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dong513/subscriptions","organizations_url":"https://api.github.com/users/Dong513/orgs","repos_url":"https://api.github.com/users/Dong513/repos","events_url":"https://api.github.com/users/Dong513/events{/privacy}","received_events_url":"https://api.github.com/users/Dong513/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Dong513/StellarSQL","description":"(WIP) StellarSQL: a minimal SQL DBMS written in Rust ","fork":true,"url":"https://api.github.com/repos/Dong513/StellarSQL","forks_url":"https://api.github.com/repos/Dong513/StellarSQL/forks","keys_url":"https://api.github.com/repos/Dong513/StellarSQL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dong513/StellarSQL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dong513/StellarSQL/teams","hooks_url":"https://api.github.com/repos/Dong513/StellarSQL/hooks","issue_events_url":"https://api.github.com/repos/Dong513/StellarSQL/issues/events{/number}","events_url":"https://api.github.com/repos/Dong513/StellarSQL/events","assignees_url":"https://api.github.com/repos/Dong513/StellarSQL/assignees{/user}","branches_url":"https://api.github.com/repos/Dong513/StellarSQL/branches{/branch}","tags_url":"https://api.github.com/repos/Dong513/StellarSQL/tags","blobs_url":"https://api.github.com/repos/Dong513/StellarSQL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dong513/StellarSQL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dong513/StellarSQL/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dong513/StellarSQL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dong513/StellarSQL/statuses/{sha}","languages_url":"https://api.github.com/repos/Dong513/StellarSQL/languages","stargazers_url":"https://api.github.com/repos/Dong513/StellarSQL/stargazers","contributors_url":"https://api.github.com/repos/Dong513/StellarSQL/contributors","subscribers_url":"https://api.github.com/repos/Dong513/StellarSQL/subscribers","subscription_url":"https://api.github.com/repos/Dong513/StellarSQL/subscription","commits_url":"https://api.github.com/repos/Dong513/StellarSQL/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dong513/StellarSQL/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dong513/StellarSQL/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dong513/StellarSQL/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dong513/StellarSQL/contents/{+path}","compare_url":"https://api.github.com/repos/Dong513/StellarSQL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dong513/StellarSQL/merges","archive_url":"https://api.github.com/repos/Dong513/StellarSQL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dong513/StellarSQL/downloads","issues_url":"https://api.github.com/repos/Dong513/StellarSQL/issues{/number}","pulls_url":"https://api.github.com/repos/Dong513/StellarSQL/pulls{/number}","milestones_url":"https://api.github.com/repos/Dong513/StellarSQL/milestones{/number}","notifications_url":"https://api.github.com/repos/Dong513/StellarSQL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dong513/StellarSQL/labels{/name}","releases_url":"https://api.github.com/repos/Dong513/StellarSQL/releases{/id}","deployments_url":"https://api.github.com/repos/Dong513/StellarSQL/deployments","created_at":"2018-12-29T00:22:44Z","updated_at":"2018-12-30T15:04:00Z","pushed_at":"2018-12-30T15:03:59Z","git_url":"git://github.com/Dong513/StellarSQL.git","ssh_url":"git@github.com:Dong513/StellarSQL.git","clone_url":"https://github.com/Dong513/StellarSQL.git","svn_url":"https://github.com/Dong513/StellarSQL","homepage":null,"size":183,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tigercosmos:master","ref":"master","sha":"0b917cc1fa0fc63b7e7c2ff92b74b8208841b9d0","user":{"login":"tigercosmos","id":18013815,"node_id":"MDQ6VXNlcjE4MDEzODE1","avatar_url":"https://avatars0.githubusercontent.com/u/18013815?v=4","gravatar_id":"","url":"https://api.github.com/users/tigercosmos","html_url":"https://github.com/tigercosmos","followers_url":"https://api.github.com/users/tigercosmos/followers","following_url":"https://api.github.com/users/tigercosmos/following{/other_user}","gists_url":"https://api.github.com/users/tigercosmos/gists{/gist_id}","starred_url":"https://api.github.com/users/tigercosmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tigercosmos/subscriptions","organizations_url":"https://api.github.com/users/tigercosmos/orgs","repos_url":"https://api.github.com/users/tigercosmos/repos","events_url":"https://api.github.com/users/tigercosmos/events{/privacy}","received_events_url":"https://api.github.com/users/tigercosmos/received_events","type":"User","site_admin":false},"repo":{"id":151367139,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEzNjcxMzk=","name":"StellarSQL","full_name":"tigercosmos/StellarSQL","private":false,"owner":{"login":"tigercosmos","id":18013815,"node_id":"MDQ6VXNlcjE4MDEzODE1","avatar_url":"https://avatars0.githubusercontent.com/u/18013815?v=4","gravatar_id":"","url":"https://api.github.com/users/tigercosmos","html_url":"https://github.com/tigercosmos","followers_url":"https://api.github.com/users/tigercosmos/followers","following_url":"https://api.github.com/users/tigercosmos/following{/other_user}","gists_url":"https://api.github.com/users/tigercosmos/gists{/gist_id}","starred_url":"https://api.github.com/users/tigercosmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tigercosmos/subscriptions","organizations_url":"https://api.github.com/users/tigercosmos/orgs","repos_url":"https://api.github.com/users/tigercosmos/repos","events_url":"https://api.github.com/users/tigercosmos/events{/privacy}","received_events_url":"https://api.github.com/users/tigercosmos/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tigercosmos/StellarSQL","description":"(WIP) StellarSQL: a minimal SQL DBMS written in Rust ","fork":false,"url":"https://api.github.com/repos/tigercosmos/StellarSQL","forks_url":"https://api.github.com/repos/tigercosmos/StellarSQL/forks","keys_url":"https://api.github.com/repos/tigercosmos/StellarSQL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tigercosmos/StellarSQL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tigercosmos/StellarSQL/teams","hooks_url":"https://api.github.com/repos/tigercosmos/StellarSQL/hooks","issue_events_url":"https://api.github.com/repos/tigercosmos/StellarSQL/issues/events{/number}","events_url":"https://api.github.com/repos/tigercosmos/StellarSQL/events","assignees_url":"https://api.github.com/repos/tigercosmos/StellarSQL/assignees{/user}","branches_url":"https://api.github.com/repos/tigercosmos/StellarSQL/branches{/branch}","tags_url":"https://api.github.com/repos/tigercosmos/StellarSQL/tags","blobs_url":"https://api.github.com/repos/tigercosmos/StellarSQL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tigercosmos/StellarSQL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tigercosmos/StellarSQL/git/refs{/sha}","trees_url":"https://api.github.com/repos/tigercosmos/StellarSQL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tigercosmos/StellarSQL/statuses/{sha}","languages_url":"https://api.github.com/repos/tigercosmos/StellarSQL/languages","stargazers_url":"https://api.github.com/repos/tigercosmos/StellarSQL/stargazers","contributors_url":"https://api.github.com/repos/tigercosmos/StellarSQL/contributors","subscribers_url":"https://api.github.com/repos/tigercosmos/StellarSQL/subscribers","subscription_url":"https://api.github.com/repos/tigercosmos/StellarSQL/subscription","commits_url":"https://api.github.com/repos/tigercosmos/StellarSQL/commits{/sha}","git_commits_url":"https://api.github.com/repos/tigercosmos/StellarSQL/git/commits{/sha}","comments_url":"https://api.github.com/repos/tigercosmos/StellarSQL/comments{/number}","issue_comment_url":"https://api.github.com/repos/tigercosmos/StellarSQL/issues/comments{/number}","contents_url":"https://api.github.com/repos/tigercosmos/StellarSQL/contents/{+path}","compare_url":"https://api.github.com/repos/tigercosmos/StellarSQL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tigercosmos/StellarSQL/merges","archive_url":"https://api.github.com/repos/tigercosmos/StellarSQL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tigercosmos/StellarSQL/downloads","issues_url":"https://api.github.com/repos/tigercosmos/StellarSQL/issues{/number}","pulls_url":"https://api.github.com/repos/tigercosmos/StellarSQL/pulls{/number}","milestones_url":"https://api.github.com/repos/tigercosmos/StellarSQL/milestones{/number}","notifications_url":"https://api.github.com/repos/tigercosmos/StellarSQL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tigercosmos/StellarSQL/labels{/name}","releases_url":"https://api.github.com/repos/tigercosmos/StellarSQL/releases{/id}","deployments_url":"https://api.github.com/repos/tigercosmos/StellarSQL/deployments","created_at":"2018-10-03T05:53:25Z","updated_at":"2018-12-31T11:16:21Z","pushed_at":"2018-12-31T11:16:19Z","git_url":"git://github.com/tigercosmos/StellarSQL.git","ssh_url":"git@github.com:tigercosmos/StellarSQL.git","clone_url":"https://github.com/tigercosmos/StellarSQL.git","svn_url":"https://github.com/tigercosmos/StellarSQL","homepage":null,"size":186,"stargazers_count":11,"watchers_count":11,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":2,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tigercosmos/StellarSQL/pulls/6"},"html":{"href":"https://github.com/tigercosmos/StellarSQL/pull/6"},"issue":{"href":"https://api.github.com/repos/tigercosmos/StellarSQL/issues/6"},"comments":{"href":"https://api.github.com/repos/tigercosmos/StellarSQL/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/tigercosmos/StellarSQL/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/tigercosmos/StellarSQL/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tigercosmos/StellarSQL/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/tigercosmos/StellarSQL/statuses/53a61706fd9582a694a2efc09ab9619ee487c03b"}},"author_association":"NONE"}}
{"actor":{"display_login":"tigercosmos"}}