{"action":"created","comment":{"url":"https://api.github.com/repos/OData/odata.net/pulls/comments/229458029","pull_request_review_id":169964810,"id":229458029,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTQ1ODAyOQ==","diff_hunk":"@@ -169,6 +169,16 @@ public ODataMessageReader(IODataResponseMessage responseMessage, ODataMessageRea\n             this.model = model ?? GetModel(this.container);\r\n             this.edmTypeResolver = new EdmTypeReaderResolver(this.model, this.settings.ClientCustomTypeResolver);\r\n \r\n+            // Whether null values were omitted in the response, false by default.\r\n+            this.settings.NullValuesOmitted = false;\r","path":"src/Microsoft.OData.Core/ODataMessageReader.cs","position":5,"original_position":5,"commit_id":"df084b6eb92bcc26940b549e7863d95b36fe9ecf","original_commit_id":"946f4ec27250f65aba3a6e101cf403685feb5696","user":{"login":"mikepizzo","id":8660830,"node_id":"MDQ6VXNlcjg2NjA4MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/8660830?v=4","gravatar_id":"","url":"https://api.github.com/users/mikepizzo","html_url":"https://github.com/mikepizzo","followers_url":"https://api.github.com/users/mikepizzo/followers","following_url":"https://api.github.com/users/mikepizzo/following{/other_user}","gists_url":"https://api.github.com/users/mikepizzo/gists{/gist_id}","starred_url":"https://api.github.com/users/mikepizzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikepizzo/subscriptions","organizations_url":"https://api.github.com/users/mikepizzo/orgs","repos_url":"https://api.github.com/users/mikepizzo/repos","events_url":"https://api.github.com/users/mikepizzo/events{/privacy}","received_events_url":"https://api.github.com/users/mikepizzo/received_events","type":"User","site_admin":false},"body":"I still prefer setting it once to twice as it feels cleaner, but I'm not going to force it.\r\n\r\n---\r\nIn reply to: [213861831](https://github.com/OData/odata.net/pull/1106#discussion_r213861831) [](ancestors = 213861831,213509847,209783953,198055075)","created_at":"2018-10-30T19:43:20Z","updated_at":"2018-10-30T19:43:20Z","html_url":"https://github.com/OData/odata.net/pull/1106#discussion_r229458029","pull_request_url":"https://api.github.com/repos/OData/odata.net/pulls/1106","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OData/odata.net/pulls/comments/229458029"},"html":{"href":"https://github.com/OData/odata.net/pull/1106#discussion_r229458029"},"pull_request":{"href":"https://api.github.com/repos/OData/odata.net/pulls/1106"}},"in_reply_to_id":198055075},"pull_request":{"url":"https://api.github.com/repos/OData/odata.net/pulls/1106","id":173233124,"node_id":"MDExOlB1bGxSZXF1ZXN0MTczMjMzMTI0","html_url":"https://github.com/OData/odata.net/pull/1106","diff_url":"https://github.com/OData/odata.net/pull/1106.diff","patch_url":"https://github.com/OData/odata.net/pull/1106.patch","issue_url":"https://api.github.com/repos/OData/odata.net/issues/1106","number":1106,"state":"open","locked":false,"title":"Omit null property value in JSON response ","user":{"login":"biaol-odata","id":24885233,"node_id":"MDQ6VXNlcjI0ODg1MjMz","avatar_url":"https://avatars2.githubusercontent.com/u/24885233?v=4","gravatar_id":"","url":"https://api.github.com/users/biaol-odata","html_url":"https://github.com/biaol-odata","followers_url":"https://api.github.com/users/biaol-odata/followers","following_url":"https://api.github.com/users/biaol-odata/following{/other_user}","gists_url":"https://api.github.com/users/biaol-odata/gists{/gist_id}","starred_url":"https://api.github.com/users/biaol-odata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biaol-odata/subscriptions","organizations_url":"https://api.github.com/users/biaol-odata/orgs","repos_url":"https://api.github.com/users/biaol-odata/repos","events_url":"https://api.github.com/users/biaol-odata/events{/privacy}","received_events_url":"https://api.github.com/users/biaol-odata/received_events","type":"User","site_admin":false},"body":"<!-- markdownlint-disable MD002 MD041 -->\r\n\r\n### Issues\r\n\r\n*This pull request introduces omitNullValues controlled by omit-values=nulls Preference header per OData v4.01.*\r\n\r\n### Description\r\n\r\n* Current changes include the following areas: *\r\n- serialize JSON object to response with omit null values option according to Preference-Applied header's parameter value.\r\n- de-serialize JSON object from response with omitted null values restored per the option used according to the Preference-Applied header's parameter value.\r\n- has no effects on request payload and delta payload.\r\n\r\nBased on PR #944 from kosinsky.\r\n\r\n### Checklist (Uncheck if it is not completed)\r\n\r\n- [x] *Test cases added*\r\n- [x] *Build and test with one-click build and test script passed*\r\n\r\n### Additional work necessary\r\n\r\n*If documentation update is needed, please add \"Docs Needed\" label to the issue and provide details about the required document change in the issue.*\r\n","created_at":"2018-03-06T17:48:08Z","updated_at":"2018-10-30T19:43:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f94ed5f373b6d8d6fd841041b77390aced3cc6c","assignee":{"login":"biaol-odata","id":24885233,"node_id":"MDQ6VXNlcjI0ODg1MjMz","avatar_url":"https://avatars2.githubusercontent.com/u/24885233?v=4","gravatar_id":"","url":"https://api.github.com/users/biaol-odata","html_url":"https://github.com/biaol-odata","followers_url":"https://api.github.com/users/biaol-odata/followers","following_url":"https://api.github.com/users/biaol-odata/following{/other_user}","gists_url":"https://api.github.com/users/biaol-odata/gists{/gist_id}","starred_url":"https://api.github.com/users/biaol-odata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biaol-odata/subscriptions","organizations_url":"https://api.github.com/users/biaol-odata/orgs","repos_url":"https://api.github.com/users/biaol-odata/repos","events_url":"https://api.github.com/users/biaol-odata/events{/privacy}","received_events_url":"https://api.github.com/users/biaol-odata/received_events","type":"User","site_admin":false},"assignees":[{"login":"biaol-odata","id":24885233,"node_id":"MDQ6VXNlcjI0ODg1MjMz","avatar_url":"https://avatars2.githubusercontent.com/u/24885233?v=4","gravatar_id":"","url":"https://api.github.com/users/biaol-odata","html_url":"https://github.com/biaol-odata","followers_url":"https://api.github.com/users/biaol-odata/followers","following_url":"https://api.github.com/users/biaol-odata/following{/other_user}","gists_url":"https://api.github.com/users/biaol-odata/gists{/gist_id}","starred_url":"https://api.github.com/users/biaol-odata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biaol-odata/subscriptions","organizations_url":"https://api.github.com/users/biaol-odata/orgs","repos_url":"https://api.github.com/users/biaol-odata/repos","events_url":"https://api.github.com/users/biaol-odata/events{/privacy}","received_events_url":"https://api.github.com/users/biaol-odata/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":903863566,"node_id":"MDU6TGFiZWw5MDM4NjM1NjY=","url":"https://api.github.com/repos/OData/odata.net/labels/under-review","name":"under-review","color":"c5def5","default":false}],"milestone":{"url":"https://api.github.com/repos/OData/odata.net/milestones/24","html_url":"https://github.com/OData/odata.net/milestone/24","labels_url":"https://api.github.com/repos/OData/odata.net/milestones/24/labels","id":3710483,"node_id":"MDk6TWlsZXN0b25lMzcxMDQ4Mw==","number":24,"title":"7.6","description":"Release the next version of ODL.","creator":{"login":"xuzhg","id":9426627,"node_id":"MDQ6VXNlcjk0MjY2Mjc=","avatar_url":"https://avatars0.githubusercontent.com/u/9426627?v=4","gravatar_id":"","url":"https://api.github.com/users/xuzhg","html_url":"https://github.com/xuzhg","followers_url":"https://api.github.com/users/xuzhg/followers","following_url":"https://api.github.com/users/xuzhg/following{/other_user}","gists_url":"https://api.github.com/users/xuzhg/gists{/gist_id}","starred_url":"https://api.github.com/users/xuzhg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuzhg/subscriptions","organizations_url":"https://api.github.com/users/xuzhg/orgs","repos_url":"https://api.github.com/users/xuzhg/repos","events_url":"https://api.github.com/users/xuzhg/events{/privacy}","received_events_url":"https://api.github.com/users/xuzhg/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":12,"state":"open","created_at":"2018-10-03T20:32:57Z","updated_at":"2018-10-25T23:26:56Z","due_on":"2018-11-19T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/OData/odata.net/pulls/1106/commits","review_comments_url":"https://api.github.com/repos/OData/odata.net/pulls/1106/comments","review_comment_url":"https://api.github.com/repos/OData/odata.net/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OData/odata.net/issues/1106/comments","statuses_url":"https://api.github.com/repos/OData/odata.net/statuses/df084b6eb92bcc26940b549e7863d95b36fe9ecf","head":{"label":"biaol-odata:pr-omitValuesNull","ref":"pr-omitValuesNull","sha":"df084b6eb92bcc26940b549e7863d95b36fe9ecf","user":{"login":"biaol-odata","id":24885233,"node_id":"MDQ6VXNlcjI0ODg1MjMz","avatar_url":"https://avatars2.githubusercontent.com/u/24885233?v=4","gravatar_id":"","url":"https://api.github.com/users/biaol-odata","html_url":"https://github.com/biaol-odata","followers_url":"https://api.github.com/users/biaol-odata/followers","following_url":"https://api.github.com/users/biaol-odata/following{/other_user}","gists_url":"https://api.github.com/users/biaol-odata/gists{/gist_id}","starred_url":"https://api.github.com/users/biaol-odata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biaol-odata/subscriptions","organizations_url":"https://api.github.com/users/biaol-odata/orgs","repos_url":"https://api.github.com/users/biaol-odata/repos","events_url":"https://api.github.com/users/biaol-odata/events{/privacy}","received_events_url":"https://api.github.com/users/biaol-odata/received_events","type":"User","site_admin":false},"repo":{"id":78298453,"node_id":"MDEwOlJlcG9zaXRvcnk3ODI5ODQ1Mw==","name":"odata.net","full_name":"biaol-odata/odata.net","private":false,"owner":{"login":"biaol-odata","id":24885233,"node_id":"MDQ6VXNlcjI0ODg1MjMz","avatar_url":"https://avatars2.githubusercontent.com/u/24885233?v=4","gravatar_id":"","url":"https://api.github.com/users/biaol-odata","html_url":"https://github.com/biaol-odata","followers_url":"https://api.github.com/users/biaol-odata/followers","following_url":"https://api.github.com/users/biaol-odata/following{/other_user}","gists_url":"https://api.github.com/users/biaol-odata/gists{/gist_id}","starred_url":"https://api.github.com/users/biaol-odata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biaol-odata/subscriptions","organizations_url":"https://api.github.com/users/biaol-odata/orgs","repos_url":"https://api.github.com/users/biaol-odata/repos","events_url":"https://api.github.com/users/biaol-odata/events{/privacy}","received_events_url":"https://api.github.com/users/biaol-odata/received_events","type":"User","site_admin":false},"html_url":"https://github.com/biaol-odata/odata.net","description":"ODataLib: Open Data Protocol - .NET/Silverlight/WP8.1 Libraries and Frameworks","fork":true,"url":"https://api.github.com/repos/biaol-odata/odata.net","forks_url":"https://api.github.com/repos/biaol-odata/odata.net/forks","keys_url":"https://api.github.com/repos/biaol-odata/odata.net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biaol-odata/odata.net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biaol-odata/odata.net/teams","hooks_url":"https://api.github.com/repos/biaol-odata/odata.net/hooks","issue_events_url":"https://api.github.com/repos/biaol-odata/odata.net/issues/events{/number}","events_url":"https://api.github.com/repos/biaol-odata/odata.net/events","assignees_url":"https://api.github.com/repos/biaol-odata/odata.net/assignees{/user}","branches_url":"https://api.github.com/repos/biaol-odata/odata.net/branches{/branch}","tags_url":"https://api.github.com/repos/biaol-odata/odata.net/tags","blobs_url":"https://api.github.com/repos/biaol-odata/odata.net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biaol-odata/odata.net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biaol-odata/odata.net/git/refs{/sha}","trees_url":"https://api.github.com/repos/biaol-odata/odata.net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biaol-odata/odata.net/statuses/{sha}","languages_url":"https://api.github.com/repos/biaol-odata/odata.net/languages","stargazers_url":"https://api.github.com/repos/biaol-odata/odata.net/stargazers","contributors_url":"https://api.github.com/repos/biaol-odata/odata.net/contributors","subscribers_url":"https://api.github.com/repos/biaol-odata/odata.net/subscribers","subscription_url":"https://api.github.com/repos/biaol-odata/odata.net/subscription","commits_url":"https://api.github.com/repos/biaol-odata/odata.net/commits{/sha}","git_commits_url":"https://api.github.com/repos/biaol-odata/odata.net/git/commits{/sha}","comments_url":"https://api.github.com/repos/biaol-odata/odata.net/comments{/number}","issue_comment_url":"https://api.github.com/repos/biaol-odata/odata.net/issues/comments{/number}","contents_url":"https://api.github.com/repos/biaol-odata/odata.net/contents/{+path}","compare_url":"https://api.github.com/repos/biaol-odata/odata.net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biaol-odata/odata.net/merges","archive_url":"https://api.github.com/repos/biaol-odata/odata.net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biaol-odata/odata.net/downloads","issues_url":"https://api.github.com/repos/biaol-odata/odata.net/issues{/number}","pulls_url":"https://api.github.com/repos/biaol-odata/odata.net/pulls{/number}","milestones_url":"https://api.github.com/repos/biaol-odata/odata.net/milestones{/number}","notifications_url":"https://api.github.com/repos/biaol-odata/odata.net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biaol-odata/odata.net/labels{/name}","releases_url":"https://api.github.com/repos/biaol-odata/odata.net/releases{/id}","deployments_url":"https://api.github.com/repos/biaol-odata/odata.net/deployments","created_at":"2017-01-07T19:15:03Z","updated_at":"2018-01-12T00:27:56Z","pushed_at":"2018-10-30T18:33:21Z","git_url":"git://github.com/biaol-odata/odata.net.git","ssh_url":"git@github.com:biaol-odata/odata.net.git","clone_url":"https://github.com/biaol-odata/odata.net.git","svn_url":"https://github.com/biaol-odata/odata.net","homepage":"http://odata.github.io/odata.net","size":53133,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"000"}},"base":{"label":"OData:master","ref":"master","sha":"ec6fb338311aa2b407760f69e11b2f19670317b0","user":{"login":"OData","id":916520,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNjUyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/916520?v=4","gravatar_id":"","url":"https://api.github.com/users/OData","html_url":"https://github.com/OData","followers_url":"https://api.github.com/users/OData/followers","following_url":"https://api.github.com/users/OData/following{/other_user}","gists_url":"https://api.github.com/users/OData/gists{/gist_id}","starred_url":"https://api.github.com/users/OData/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OData/subscriptions","organizations_url":"https://api.github.com/users/OData/orgs","repos_url":"https://api.github.com/users/OData/repos","events_url":"https://api.github.com/users/OData/events{/privacy}","received_events_url":"https://api.github.com/users/OData/received_events","type":"Organization","site_admin":false},"repo":{"id":23308338,"node_id":"MDEwOlJlcG9zaXRvcnkyMzMwODMzOA==","name":"odata.net","full_name":"OData/odata.net","private":false,"owner":{"login":"OData","id":916520,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNjUyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/916520?v=4","gravatar_id":"","url":"https://api.github.com/users/OData","html_url":"https://github.com/OData","followers_url":"https://api.github.com/users/OData/followers","following_url":"https://api.github.com/users/OData/following{/other_user}","gists_url":"https://api.github.com/users/OData/gists{/gist_id}","starred_url":"https://api.github.com/users/OData/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OData/subscriptions","organizations_url":"https://api.github.com/users/OData/orgs","repos_url":"https://api.github.com/users/OData/repos","events_url":"https://api.github.com/users/OData/events{/privacy}","received_events_url":"https://api.github.com/users/OData/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OData/odata.net","description":"ODataLib: Open Data Protocol - .NET Libraries and Frameworks","fork":false,"url":"https://api.github.com/repos/OData/odata.net","forks_url":"https://api.github.com/repos/OData/odata.net/forks","keys_url":"https://api.github.com/repos/OData/odata.net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OData/odata.net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OData/odata.net/teams","hooks_url":"https://api.github.com/repos/OData/odata.net/hooks","issue_events_url":"https://api.github.com/repos/OData/odata.net/issues/events{/number}","events_url":"https://api.github.com/repos/OData/odata.net/events","assignees_url":"https://api.github.com/repos/OData/odata.net/assignees{/user}","branches_url":"https://api.github.com/repos/OData/odata.net/branches{/branch}","tags_url":"https://api.github.com/repos/OData/odata.net/tags","blobs_url":"https://api.github.com/repos/OData/odata.net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OData/odata.net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OData/odata.net/git/refs{/sha}","trees_url":"https://api.github.com/repos/OData/odata.net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OData/odata.net/statuses/{sha}","languages_url":"https://api.github.com/repos/OData/odata.net/languages","stargazers_url":"https://api.github.com/repos/OData/odata.net/stargazers","contributors_url":"https://api.github.com/repos/OData/odata.net/contributors","subscribers_url":"https://api.github.com/repos/OData/odata.net/subscribers","subscription_url":"https://api.github.com/repos/OData/odata.net/subscription","commits_url":"https://api.github.com/repos/OData/odata.net/commits{/sha}","git_commits_url":"https://api.github.com/repos/OData/odata.net/git/commits{/sha}","comments_url":"https://api.github.com/repos/OData/odata.net/comments{/number}","issue_comment_url":"https://api.github.com/repos/OData/odata.net/issues/comments{/number}","contents_url":"https://api.github.com/repos/OData/odata.net/contents/{+path}","compare_url":"https://api.github.com/repos/OData/odata.net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OData/odata.net/merges","archive_url":"https://api.github.com/repos/OData/odata.net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OData/odata.net/downloads","issues_url":"https://api.github.com/repos/OData/odata.net/issues{/number}","pulls_url":"https://api.github.com/repos/OData/odata.net/pulls{/number}","milestones_url":"https://api.github.com/repos/OData/odata.net/milestones{/number}","notifications_url":"https://api.github.com/repos/OData/odata.net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OData/odata.net/labels{/name}","releases_url":"https://api.github.com/repos/OData/odata.net/releases{/id}","deployments_url":"https://api.github.com/repos/OData/odata.net/deployments","created_at":"2014-08-25T09:15:23Z","updated_at":"2018-10-29T18:07:07Z","pushed_at":"2018-10-30T18:34:49Z","git_url":"git://github.com/OData/odata.net.git","ssh_url":"git@github.com:OData/odata.net.git","clone_url":"https://github.com/OData/odata.net.git","svn_url":"https://github.com/OData/odata.net","homepage":"http://odata.github.io/odata.net","size":53046,"stargazers_count":358,"watchers_count":358,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":205,"mirror_url":null,"archived":false,"open_issues_count":281,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":205,"open_issues":281,"watchers":358,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OData/odata.net/pulls/1106"},"html":{"href":"https://github.com/OData/odata.net/pull/1106"},"issue":{"href":"https://api.github.com/repos/OData/odata.net/issues/1106"},"comments":{"href":"https://api.github.com/repos/OData/odata.net/issues/1106/comments"},"review_comments":{"href":"https://api.github.com/repos/OData/odata.net/pulls/1106/comments"},"review_comment":{"href":"https://api.github.com/repos/OData/odata.net/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OData/odata.net/pulls/1106/commits"},"statuses":{"href":"https://api.github.com/repos/OData/odata.net/statuses/df084b6eb92bcc26940b549e7863d95b36fe9ecf"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mikepizzo"}}