{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/issues/467","repository_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api","labels_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/issues/467/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/issues/467/comments","events_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/issues/467/events","html_url":"https://github.com/kubernetes-sigs/cluster-api/pull/467","id":347086783,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NzkzMzk2","number":467,"title":"APIEndpoint to ClusterNetworkingConfig cluster-types","user":{"login":"alejandroEsc","id":20777618,"node_id":"MDQ6VXNlcjIwNzc3NjE4","avatar_url":"https://avatars0.githubusercontent.com/u/20777618?v=4","gravatar_id":"","url":"https://api.github.com/users/alejandroEsc","html_url":"https://github.com/alejandroEsc","followers_url":"https://api.github.com/users/alejandroEsc/followers","following_url":"https://api.github.com/users/alejandroEsc/following{/other_user}","gists_url":"https://api.github.com/users/alejandroEsc/gists{/gist_id}","starred_url":"https://api.github.com/users/alejandroEsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alejandroEsc/subscriptions","organizations_url":"https://api.github.com/users/alejandroEsc/orgs","repos_url":"https://api.github.com/users/alejandroEsc/repos","events_url":"https://api.github.com/users/alejandroEsc/events{/privacy}","received_events_url":"https://api.github.com/users/alejandroEsc/received_events","type":"User","site_admin":false},"labels":[{"id":875323571,"node_id":"MDU6TGFiZWw4NzUzMjM1NzE=","url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":914072495,"node_id":"MDU6TGFiZWw5MTQwNzI0OTU=","url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"e11d21","default":false},{"id":904030780,"node_id":"MDU6TGFiZWw5MDQwMzA3ODA=","url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2018-08-02T16:31:25Z","updated_at":"2018-08-17T17:15:15Z","closed_at":"2018-08-17T17:15:15Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/pulls/467","html_url":"https://github.com/kubernetes-sigs/cluster-api/pull/467","diff_url":"https://github.com/kubernetes-sigs/cluster-api/pull/467.diff","patch_url":"https://github.com/kubernetes-sigs/cluster-api/pull/467.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n4. If the PR is unfinished, see how to mark it: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#marking-unfinished-pull-requests\r\n5. If this PR changes image versions, please title this PR \"Bump <image name> from x.x.x to y.y.y.\"\r\n-->\r\n\r\n**What this PR does / why we need it**: clusterclient.go assumes that the port to be used to contact apiserver is 443, meanwhile the default value for kubeadm is 6443. Meaning that a user would have to manually configure on their script the 443 value, which may not be what they want. Here we allow the cluster-type to contain and APIEndpoint object under the clusternetwork configuration so that it can be passed to kubeadm or whatever provisioning tool of choice. \r\n\r\nThe change will also keep us from making breaking changes to cluster-client, though It suspect that in the many clusters case some additional changes may be required (as of yet unknown). Currently without this change, most users who are unaware of the need to set kubeadm to bindPort 443 may not be able to have nodes join their cluster.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n_Please confirm that if this PR changes any image versions, then that's the sole change this PR makes._\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\ncluster-type change to allow APIEndpoint object under clusternetworkconfig. Should allow one to define what port to use and pass that to the kubernetes provisioning tool or fall back to the default 443.\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/issues/comments/413931474","html_url":"https://github.com/kubernetes-sigs/cluster-api/pull/467#issuecomment-413931474","issue_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/issues/467","id":413931474,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzkzMTQ3NA==","user":{"login":"roberthbailey","id":7751204,"node_id":"MDQ6VXNlcjc3NTEyMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7751204?v=4","gravatar_id":"","url":"https://api.github.com/users/roberthbailey","html_url":"https://github.com/roberthbailey","followers_url":"https://api.github.com/users/roberthbailey/followers","following_url":"https://api.github.com/users/roberthbailey/following{/other_user}","gists_url":"https://api.github.com/users/roberthbailey/gists{/gist_id}","starred_url":"https://api.github.com/users/roberthbailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roberthbailey/subscriptions","organizations_url":"https://api.github.com/users/roberthbailey/orgs","repos_url":"https://api.github.com/users/roberthbailey/repos","events_url":"https://api.github.com/users/roberthbailey/events{/privacy}","received_events_url":"https://api.github.com/users/roberthbailey/received_events","type":"User","site_admin":false},"created_at":"2018-08-17T17:15:15Z","updated_at":"2018-08-17T17:15:15Z","author_association":"COLLABORATOR","body":"I don't think we want to put APIEnpoints into the ClusterNetworkingConfig (at least not yet), so I'm going to close this PR to keep the backlog in check. Let's re-assess after we address #158."}}
{"actor":{"display_login":"roberthbailey"}}