{"push_id":2898199923,"size":17,"distinct_size":17,"ref":"refs/heads/release-2.1","head":"7048f0ed75fd2dc42779cc98af2b94cafe9a6ec5","before":"d0544772e83786a12a824b7e380ec4f95700e5f9","commits":[{"sha":"ef1f5b05bebe6fde4adcfb277fb9c71e13192e4b","author":{"name":"Tobias Schottdorf","email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com"},"message":"storage: add env var for aggressive consistency checks\n\nWe saw a consistency failure in #29252 that would've been much more\nuseful had it occurred close to the time around which the inconsistency\nmust have been introduced. Instead of leaving it to chance, add a switch\nthat runs aggressive checks in (roach) tests that want them such as the\nclearrange test.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/ef1f5b05bebe6fde4adcfb277fb9c71e13192e4b"},{"sha":"d7e8c8b971a7061653f4790d8554c8d942f6bc4f","author":{"name":"Tobias Schottdorf","email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com"},"message":"roachtest: better merge testing in clearrange\n\nUnfortunately, the method to determine the range count is quite slow\nsince crdb_internal.ranges internally sends an RPC for each range to\ndetermine the leaseholder.\n\nAnecdotally, I've seen ~25% of the merges completed after less than 15\nminutes. I know that it's slowing down over time, but @benesch will fix\nthat.\n\nAlso throws in aggressive consistency checks so that when something goes\nout of sync, we find out right there.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/d7e8c8b971a7061653f4790d8554c8d942f6bc4f"},{"sha":"09c5df7383af9bf5bcfb9e2ec4348bfc96ec09b7","author":{"name":"Tobias Schottdorf","email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com"},"message":"issues: truncate more eagerly\n\nNobody likes scrolling for minutes at a time.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/09c5df7383af9bf5bcfb9e2ec4348bfc96ec09b7"},{"sha":"b7b7a947a5805ffa3a250fa757abe3db5a7f592d","author":{"name":"Tobias Schottdorf","email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com"},"message":"issues: use same message for new and existing issues\n\nPreviously, the message for existing issues didn't contain the output.\nThis was annoying as you care about the most recent failures first and\nforemost, typically.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/b7b7a947a5805ffa3a250fa757abe3db5a7f592d"},{"sha":"9d7c3d99ef65742afed863d0d2379d38e70b673c","author":{"name":"Tobias Schottdorf","email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com"},"message":"roachtest: don't disambiguate issue title by branch\n\nThis tends to create duplicate issues for a similar root cause. I think\nit's better to collect failures from different branches in an umbrella\nissue, even though it implies that we need to be more careful about\nclosing them.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/9d7c3d99ef65742afed863d0d2379d38e70b673c"},{"sha":"cf35b277a17a0325bca9b1dab62f393b1fd67b86","author":{"name":"Tobias Schottdorf","email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com"},"message":"roachtest: mark acceptance as stable\n\nall of its subtests are already stable, but in running a test locally I\nnoticed that the top-level test was marked as passing as unstable. I'm\nnot sure, but this might mean that the top-level test would actually not\nfail? Either way, better to mark it as stable explicitly.\n\nWe should also spend some thought on how diverging notions of Stable in\nsub vs top level test are treated, not sure that this is well-defined.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/cf35b277a17a0325bca9b1dab62f393b1fd67b86"},{"sha":"9670204dd24b96b6ab66f35aaabd0e61806f2549","author":{"name":"Tobias Schottdorf","email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com"},"message":"roachtest: remove now-unnecessary hack\n\nCloses #27717.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/9670204dd24b96b6ab66f35aaabd0e61806f2549"},{"sha":"15da15662ffebd81e6a1b5312c256a12ad8ea012","author":{"name":"Tobias Schottdorf","email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com"},"message":"storage: give TestReplicateRemovedNodeDisruptiveElection more time\n\nPerhaps:\n\nFixes #27253.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/15da15662ffebd81e6a1b5312c256a12ad8ea012"},{"sha":"b2b17a1b323f787cdc16d893d54e315aca2dd8d5","author":{"name":"Tobias Schottdorf","email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com"},"message":"storage: de-flake TestReplicaIDChangePending\n\nsetReplicaID refreshes the proposal and was thus synchronously writing\nto the commandProposed chan. This channel could have filled up due to\nan earlier reproposal already, deadlocking the test.\n\nFixes #28132.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/b2b17a1b323f787cdc16d893d54e315aca2dd8d5"},{"sha":"f68fa47b68cfbb118b25849d3b73dfcf374740c7","author":{"name":"Tobias Schottdorf","email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com"},"message":"testcluster: improve AddReplicas check\n\nAddReplicas was verifying that a replica had indeed been added, but\nthere's no guarantee that the replicate queue wouldn't have removed\nit in the meantime. Attempt to work around this somewhat. The real\nsolution is not to provide that guarantee, but some tests likely\nrely on it (and the failure is extremely rare, i.e. the new for\nloop basically never runs).\n\nObserved in #28368.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/f68fa47b68cfbb118b25849d3b73dfcf374740c7"},{"sha":"7fb33e42de3d60ff087b5e64c6f608a893a04053","author":{"name":"Tobias Schottdorf","email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com"},"message":"storage: unskip TestClosedTimestampCanServe for non-race\n\nFixes #28607.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/7fb33e42de3d60ff087b5e64c6f608a893a04053"},{"sha":"d2bcfb47add273efc5c0b87860591a0091655465","author":{"name":"Tobias Schottdorf","email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com"},"message":"roachtest: pass missing parameter\n\nFixes #29665.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/d2bcfb47add273efc5c0b87860591a0091655465"},{"sha":"e5a8b38fcd45ca937398fa642a9cc3a9d8dcb03d","author":{"name":"Tobias Schottdorf","email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com"},"message":"storage: de-hang TestGossipFirstRange\n\nThe test could deadlock if the callback fired during shutdown due to a\nsend on an unbuffered channel. Haven't been able to get this to fail\nafter this commit.\n\nFixes #29982.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/e5a8b38fcd45ca937398fa642a9cc3a9d8dcb03d"},{"sha":"805fb113642bfd000e1fce06eb205db882d77116","author":{"name":"Tobias Schottdorf","email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com"},"message":"roachtest: squirrel away pre-teamcity logs\n\nThe teamcity output is so much less pleasant to read. Better to just\nopen the artifact sometimes.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/805fb113642bfd000e1fce06eb205db882d77116"},{"sha":"f581d78f317589f5f3cc5b723cb5c9d389ef1d9f","author":{"name":"Tobias Schottdorf","email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com"},"message":"roachtest: de-flake acceptance/rapid-restart\n\nThe kill signal was sometimes a noop (when issued before the process\nto be killed started). Prior to this patch, that would leave the test\nstuck.\n\nFixes #30475.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/f581d78f317589f5f3cc5b723cb5c9d389ef1d9f"},{"sha":"7f75981eb8390336be8ec85ec2885a5c0f2f03ed","author":{"name":"Tobias Schottdorf","email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com"},"message":"roachtest: wait for teardown if local test times out\n\nI suspect not doing so previously can cause issues like #30397.\nLocal roachtests are simply not set up to run concurrently, but once a\ntest times out we're doing that (though we attempt to teardown the\ncluster, tests can apparently still \"do stuff\" with it, for example\nthe rapid restarts test was running one-off invocations of CockroachDB\nvia Exec; also note the comment near the added lines suggesting that\nin local clusters we may not actually be destroying them).\n\nWe can revisit this when we allow multiple local clusters in parallel,\nas we can then use a different one.\n\nOptimistically:\n\nFixes #30397.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/7f75981eb8390336be8ec85ec2885a5c0f2f03ed"},{"sha":"7048f0ed75fd2dc42779cc98af2b94cafe9a6ec5","author":{"name":"Tobias Schottdorf","email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com"},"message":"Merge pull request #30503 from tschottdorf/backport2.1-29646-30420-30419-30405-30450-30451-30452-30455-30456-30373-30479-30496-30497\n\nbackport-2.1: assorted testing-related backports","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/7048f0ed75fd2dc42779cc98af2b94cafe9a6ec5"}]}
{"actor":{"display_login":"tschottdorf"}}