{"action":"created","issue":{"url":"https://api.github.com/repos/MARKETProtocol/dApp/issues/283","repository_url":"https://api.github.com/repos/MARKETProtocol/dApp","labels_url":"https://api.github.com/repos/MARKETProtocol/dApp/issues/283/labels{/name}","comments_url":"https://api.github.com/repos/MARKETProtocol/dApp/issues/283/comments","events_url":"https://api.github.com/repos/MARKETProtocol/dApp/issues/283/events","html_url":"https://github.com/MARKETProtocol/dApp/issues/283","id":346882571,"node_id":"MDU6SXNzdWUzNDY4ODI1NzE=","number":283,"title":"[Dockerfile] Module not found error after containers are up","user":{"login":"tungsheng","id":1232684,"node_id":"MDQ6VXNlcjEyMzI2ODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1232684?v=4","gravatar_id":"","url":"https://api.github.com/users/tungsheng","html_url":"https://github.com/tungsheng","followers_url":"https://api.github.com/users/tungsheng/followers","following_url":"https://api.github.com/users/tungsheng/following{/other_user}","gists_url":"https://api.github.com/users/tungsheng/gists{/gist_id}","starred_url":"https://api.github.com/users/tungsheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tungsheng/subscriptions","organizations_url":"https://api.github.com/users/tungsheng/orgs","repos_url":"https://api.github.com/users/tungsheng/repos","events_url":"https://api.github.com/users/tungsheng/events{/privacy}","received_events_url":"https://api.github.com/users/tungsheng/received_events","type":"User","site_admin":false},"labels":[{"id":811047651,"node_id":"MDU6TGFiZWw4MTEwNDc2NTE=","url":"https://api.github.com/repos/MARKETProtocol/dApp/labels/Bounty%20Attached","name":"Bounty Attached","color":"87edaa","default":false},{"id":808102936,"node_id":"MDU6TGFiZWw4MDgxMDI5MzY=","url":"https://api.github.com/repos/MARKETProtocol/dApp/labels/Type:%20Bug","name":"Type: Bug","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/MARKETProtocol/dApp/milestones/12","html_url":"https://github.com/MARKETProtocol/dApp/milestone/12","labels_url":"https://api.github.com/repos/MARKETProtocol/dApp/milestones/12/labels","id":3550291,"node_id":"MDk6TWlsZXN0b25lMzU1MDI5MQ==","number":12,"title":"Week 34 Iteration","description":"Weekly iteration #34, starts 20180820, ends 20180827","creator":{"login":"rojosnow","id":778262,"node_id":"MDQ6VXNlcjc3ODI2Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/778262?v=4","gravatar_id":"","url":"https://api.github.com/users/rojosnow","html_url":"https://github.com/rojosnow","followers_url":"https://api.github.com/users/rojosnow/followers","following_url":"https://api.github.com/users/rojosnow/following{/other_user}","gists_url":"https://api.github.com/users/rojosnow/gists{/gist_id}","starred_url":"https://api.github.com/users/rojosnow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rojosnow/subscriptions","organizations_url":"https://api.github.com/users/rojosnow/orgs","repos_url":"https://api.github.com/users/rojosnow/repos","events_url":"https://api.github.com/users/rojosnow/events{/privacy}","received_events_url":"https://api.github.com/users/rojosnow/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":0,"state":"open","created_at":"2018-08-06T19:20:43Z","updated_at":"2018-08-20T19:00:23Z","due_on":"2018-08-27T07:00:00Z","closed_at":null},"comments":34,"created_at":"2018-08-02T06:55:50Z","updated_at":"2018-08-20T19:01:24Z","closed_at":null,"author_association":"NONE","body":"<!--\r\nHello!\r\n\r\nPlease use the template below for issue ideas or bugs found within MARKET Protocol.\r\nIf it is general support you need, reach out to us at\r\nhttps://marketprotocol.io/discord\r\n\r\nProvide a general summary of the issue in the title above and use relevant fields below to define the problem.\r\n-->\r\n\r\n<!--\r\n## Before you `start work`\r\n\r\nPlease read our contribution [guidelines](https://docs.marketprotocol.io/#contributing) and if there is a bounty involved  please also see [here](https://docs.marketprotocol.io/#gitcoin-and-bounties)\r\n\r\nIf you have ongoing work from other bounties with us where funding has not been released, please do not pick up a new issue.  We would like to involve as many contributors as possible and parallelize the workflow as much as possible.\r\n\r\nPlease make sure to comment in the issue here immediately after starting work so we know your plans for implementation and a timeline.\r\n\r\nPlease also note that in order for work to be accepted, all code must be accompanied by test cases as well.\r\n\r\n-->\r\n\r\n### User Story\r\n\r\n[comment]: # (As a <user type>, I want to <task> so that <goal>.)\r\nAs a developer, I want to develop dApp in docker environment so that I can have isolate dev environment on my local machine.\r\n\r\n### Why Is this Needed?\r\n\r\n[comment]: # (Describe the problem and why this task is needed. Provide the description of the current state, what you would like to happen, and what actually happen)\r\n*Summary*: An Isolated dev environment will keep the local machine clean for multiple projects. Also, docker-compose makes developers easy to start running dApp.\r\n\r\n### Description\r\n\r\n[comment]: # (Feature or Bug? i.e Type: Bug)\r\n*Type*: Bug\r\n\r\n\r\n### Current Behavior\r\n[comment]: # (Describe what actually happened.)\r\nAfter running up cmd:\r\n\r\n```\r\n❯ docker-compose up -d\r\n```\r\n\r\nwill successfully start containers\r\n\r\n```\r\n❯ docker-compose ps\r\n      Name                     Command               State                Ports\r\n---------------------------------------------------------------------------------------------\r\ndapp_app_1          /bin/sh -c npm start             Up      0.0.0.0:3000->3000/tcp\r\ndapp_eth-bridge_1   node bridge -H truffle:954 ...   Up\r\ndapp_truffle_1      truffle develop                  Up      3000/tcp, 0.0.0.0:9545->9545/tcp\r\n\r\n```\r\n\r\nBut when going to \r\n\r\n```\r\nhttp://localhost:3000\r\n```\r\n\r\nThere are 'Module not found' errors in the browser:\r\n\r\n```\r\n./src/Contracts.js\r\nModule not found: Can't resolve '../build/contracts/InitialAllocationCollateralToken' in '/app/src'\r\n```\r\n\r\nSeems some files need to be copied into `/build` folder.\r\n\r\n\r\n### Expected Behavior\r\n[comment]: # (Describe what you expected to happen.)\r\nModule links should be resolved.\r\n\r\n### Reproduction\r\n[comment]: # (Describe how we can replicate the bug step by step.)\r\n1. Run up cmd:\r\n```\r\ndocker-compose up -d\r\n```\r\n\r\n2. go to\r\n\r\n```\r\nhttp://localhost:3000\r\n```\r\n\r\n### Solution\r\n[comment]: # (Provide a summary of the solution and a task list on what needs to be fixed.)\r\n*Summary*: Might need to update and have separate Dockerfile for dApp and truffle.\r\n\r\n### Definition of Done\r\n[comment]: # (Any other information that would be useful, bullets are helpful.)\r\n- [ ] Developer should be able to run up cmd and just work \r\n\r\n### Additional Information\r\n[comment]: # (Any other information that would be useful, content, screenshots, etc.)\r\nI am currently debugging this issue. Any suggestions or hints are appreciated!"},"comment":{"url":"https://api.github.com/repos/MARKETProtocol/dApp/issues/comments/414426530","html_url":"https://github.com/MARKETProtocol/dApp/issues/283#issuecomment-414426530","issue_url":"https://api.github.com/repos/MARKETProtocol/dApp/issues/283","id":414426530,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDQyNjUzMA==","user":{"login":"perfectmak","id":3120013,"node_id":"MDQ6VXNlcjMxMjAwMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/3120013?v=4","gravatar_id":"","url":"https://api.github.com/users/perfectmak","html_url":"https://github.com/perfectmak","followers_url":"https://api.github.com/users/perfectmak/followers","following_url":"https://api.github.com/users/perfectmak/following{/other_user}","gists_url":"https://api.github.com/users/perfectmak/gists{/gist_id}","starred_url":"https://api.github.com/users/perfectmak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perfectmak/subscriptions","organizations_url":"https://api.github.com/users/perfectmak/orgs","repos_url":"https://api.github.com/users/perfectmak/repos","events_url":"https://api.github.com/users/perfectmak/events{/privacy}","received_events_url":"https://api.github.com/users/perfectmak/received_events","type":"User","site_admin":false},"created_at":"2018-08-20T19:01:24Z","updated_at":"2018-08-20T19:01:24Z","author_association":"MEMBER","body":"Yeah, @cryptomental's solution should work, but it wouldn't be tricky having it in the docker-compose file as a service because we need to run `exec eth-bridge scripts/wait_for_oraclize_connector.sh` so it would block till it is ready after which truffle migrate can be run too.\r\n\r\nSo it would be easier if we had everything in a script to be executed sequentially. Or the next best thing would be just provide each of the commands to run in a readme (or we do both :) ).\r\n\r\nRegards"}}
{"actor":{"display_login":"perfectmak"}}