{"action":"created","issue":{"url":"https://api.github.com/repos/nextcloud/server/issues/9723","repository_url":"https://api.github.com/repos/nextcloud/server","labels_url":"https://api.github.com/repos/nextcloud/server/issues/9723/labels{/name}","comments_url":"https://api.github.com/repos/nextcloud/server/issues/9723/comments","events_url":"https://api.github.com/repos/nextcloud/server/issues/9723/events","html_url":"https://github.com/nextcloud/server/pull/9723","id":328813819,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMjM4NTc3","number":9723,"title":"Css4 variables migration","user":{"login":"skjnldsv","id":14975046,"node_id":"MDQ6VXNlcjE0OTc1MDQ2","avatar_url":"https://avatars0.githubusercontent.com/u/14975046?v=4","gravatar_id":"","url":"https://api.github.com/users/skjnldsv","html_url":"https://github.com/skjnldsv","followers_url":"https://api.github.com/users/skjnldsv/followers","following_url":"https://api.github.com/users/skjnldsv/following{/other_user}","gists_url":"https://api.github.com/users/skjnldsv/gists{/gist_id}","starred_url":"https://api.github.com/users/skjnldsv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skjnldsv/subscriptions","organizations_url":"https://api.github.com/users/skjnldsv/orgs","repos_url":"https://api.github.com/users/skjnldsv/repos","events_url":"https://api.github.com/users/skjnldsv/events{/privacy}","received_events_url":"https://api.github.com/users/skjnldsv/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"skjnldsv","id":14975046,"node_id":"MDQ6VXNlcjE0OTc1MDQ2","avatar_url":"https://avatars0.githubusercontent.com/u/14975046?v=4","gravatar_id":"","url":"https://api.github.com/users/skjnldsv","html_url":"https://github.com/skjnldsv","followers_url":"https://api.github.com/users/skjnldsv/followers","following_url":"https://api.github.com/users/skjnldsv/following{/other_user}","gists_url":"https://api.github.com/users/skjnldsv/gists{/gist_id}","starred_url":"https://api.github.com/users/skjnldsv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skjnldsv/subscriptions","organizations_url":"https://api.github.com/users/skjnldsv/orgs","repos_url":"https://api.github.com/users/skjnldsv/repos","events_url":"https://api.github.com/users/skjnldsv/events{/privacy}","received_events_url":"https://api.github.com/users/skjnldsv/received_events","type":"User","site_admin":false},"assignees":[{"login":"skjnldsv","id":14975046,"node_id":"MDQ6VXNlcjE0OTc1MDQ2","avatar_url":"https://avatars0.githubusercontent.com/u/14975046?v=4","gravatar_id":"","url":"https://api.github.com/users/skjnldsv","html_url":"https://github.com/skjnldsv","followers_url":"https://api.github.com/users/skjnldsv/followers","following_url":"https://api.github.com/users/skjnldsv/following{/other_user}","gists_url":"https://api.github.com/users/skjnldsv/gists{/gist_id}","starred_url":"https://api.github.com/users/skjnldsv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skjnldsv/subscriptions","organizations_url":"https://api.github.com/users/skjnldsv/orgs","repos_url":"https://api.github.com/users/skjnldsv/repos","events_url":"https://api.github.com/users/skjnldsv/events{/privacy}","received_events_url":"https://api.github.com/users/skjnldsv/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-06-03T09:30:31Z","updated_at":"2018-06-03T19:51:26Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nextcloud/server/pulls/9723","html_url":"https://github.com/nextcloud/server/pull/9723","diff_url":"https://github.com/nextcloud/server/pull/9723.diff","patch_url":"https://github.com/nextcloud/server/pull/9723.patch"},"body":"## Why?\r\n- **Reactivity**: css4 variables can be changed on-the-fly and provide a theming possibility preview far easier and smooth\r\n- **External css**: others apps/modules can use our variables without scss\r\n- **Vue components**: we can't process our scoped scss from the vue components and exclude the variables compilation from the process. If we want to allow the use of variables, this is the only way.\r\n\r\n## How\r\n- [x] Convert our scss vars to css4\r\n- [x] Cleanup our multiple darken/lighten functions (who are incompatible with css4 vars)\r\n- [ ] rgba fixes\r\n- [ ] Implement [IE11 ponyfill](https://github.com/jhildenbiddle/css-vars-ponyfill) (which works perfectly) \r\n"},"comment":{"url":"https://api.github.com/repos/nextcloud/server/issues/comments/394186646","html_url":"https://github.com/nextcloud/server/pull/9723#issuecomment-394186646","issue_url":"https://api.github.com/repos/nextcloud/server/issues/9723","id":394186646,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDE4NjY0Ng==","user":{"login":"rullzer","id":45821,"node_id":"MDQ6VXNlcjQ1ODIx","avatar_url":"https://avatars2.githubusercontent.com/u/45821?v=4","gravatar_id":"","url":"https://api.github.com/users/rullzer","html_url":"https://github.com/rullzer","followers_url":"https://api.github.com/users/rullzer/followers","following_url":"https://api.github.com/users/rullzer/following{/other_user}","gists_url":"https://api.github.com/users/rullzer/gists{/gist_id}","starred_url":"https://api.github.com/users/rullzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rullzer/subscriptions","organizations_url":"https://api.github.com/users/rullzer/orgs","repos_url":"https://api.github.com/users/rullzer/repos","events_url":"https://api.github.com/users/rullzer/events{/privacy}","received_events_url":"https://api.github.com/users/rullzer/received_events","type":"User","site_admin":false},"created_at":"2018-06-03T19:51:26Z","updated_at":"2018-06-03T19:51:26Z","author_association":"MEMBER","body":"> No because scss also add more stuff like the colour manipulation functions, calculation and most importantly, our nesting css properties :)\r\n\r\nI wasn't suggesting killing SCSS. More like if we could do it only once when creating tarballs basically. But I guess not if we need colour manipulating functions etc."}}
{"actor":{"display_login":"rullzer"}}