{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/pulls/2","id":236717940,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NzE3OTQw","html_url":"https://github.com/themillhousegroup/openhab2-addons/pull/2","diff_url":"https://github.com/themillhousegroup/openhab2-addons/pull/2.diff","patch_url":"https://github.com/themillhousegroup/openhab2-addons/pull/2.patch","issue_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/issues/2","number":2,"state":"closed","locked":false,"title":"Feature/sp3 nightlight","user":{"login":"FreddyFox","id":4908406,"node_id":"MDQ6VXNlcjQ5MDg0MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/4908406?v=4","gravatar_id":"","url":"https://api.github.com/users/FreddyFox","html_url":"https://github.com/FreddyFox","followers_url":"https://api.github.com/users/FreddyFox/followers","following_url":"https://api.github.com/users/FreddyFox/following{/other_user}","gists_url":"https://api.github.com/users/FreddyFox/gists{/gist_id}","starred_url":"https://api.github.com/users/FreddyFox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreddyFox/subscriptions","organizations_url":"https://api.github.com/users/FreddyFox/orgs","repos_url":"https://api.github.com/users/FreddyFox/repos","events_url":"https://api.github.com/users/FreddyFox/events{/privacy}","received_events_url":"https://api.github.com/users/FreddyFox/received_events","type":"User","site_admin":false},"body":"This PR adds support for toggling the night light on SP3 devices.\r\n\r\nTo not make a mess I had to refactor the BroadlinkSocketModel2Handler quite a bit. You should read over and see if it makes sense. I will gladly change some stuff if it looks a bit awkward with all the helper functions and long function names :)\r\n\r\nEDIT: I realize I didn't remove the power consumption code before committing, but the code that makes it run is commented out. I will make a new PR with only the night light code if you think the code is ready to be merged.\r\n\r\nTested, not very thoroughly, but verified to work on Ubuntu 16.04 running OpenHAB 2.2 in docker.\r\n\r\nPlease let me know if you would like me to supply the .JAR","created_at":"2018-12-07T00:28:20Z","updated_at":"2018-12-07T16:37:33Z","closed_at":"2018-12-07T16:37:33Z","merged_at":null,"merge_commit_sha":"78bd614480a0f3439710f59b7fc14b2f11117548","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/pulls/2/commits","review_comments_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/pulls/2/comments","review_comment_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/issues/2/comments","statuses_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/statuses/8480435cfa860d5c6795057f486ee24863416f0d","head":{"label":"FreddyFox:feature/SP3_nightlight","ref":"feature/SP3_nightlight","sha":"8480435cfa860d5c6795057f486ee24863416f0d","user":{"login":"FreddyFox","id":4908406,"node_id":"MDQ6VXNlcjQ5MDg0MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/4908406?v=4","gravatar_id":"","url":"https://api.github.com/users/FreddyFox","html_url":"https://github.com/FreddyFox","followers_url":"https://api.github.com/users/FreddyFox/followers","following_url":"https://api.github.com/users/FreddyFox/following{/other_user}","gists_url":"https://api.github.com/users/FreddyFox/gists{/gist_id}","starred_url":"https://api.github.com/users/FreddyFox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreddyFox/subscriptions","organizations_url":"https://api.github.com/users/FreddyFox/orgs","repos_url":"https://api.github.com/users/FreddyFox/repos","events_url":"https://api.github.com/users/FreddyFox/events{/privacy}","received_events_url":"https://api.github.com/users/FreddyFox/received_events","type":"User","site_admin":false},"repo":{"id":160106417,"node_id":"MDEwOlJlcG9zaXRvcnkxNjAxMDY0MTc=","name":"openhab2-addons","full_name":"FreddyFox/openhab2-addons","private":false,"owner":{"login":"FreddyFox","id":4908406,"node_id":"MDQ6VXNlcjQ5MDg0MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/4908406?v=4","gravatar_id":"","url":"https://api.github.com/users/FreddyFox","html_url":"https://github.com/FreddyFox","followers_url":"https://api.github.com/users/FreddyFox/followers","following_url":"https://api.github.com/users/FreddyFox/following{/other_user}","gists_url":"https://api.github.com/users/FreddyFox/gists{/gist_id}","starred_url":"https://api.github.com/users/FreddyFox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreddyFox/subscriptions","organizations_url":"https://api.github.com/users/FreddyFox/orgs","repos_url":"https://api.github.com/users/FreddyFox/repos","events_url":"https://api.github.com/users/FreddyFox/events{/privacy}","received_events_url":"https://api.github.com/users/FreddyFox/received_events","type":"User","site_admin":false},"html_url":"https://github.com/FreddyFox/openhab2-addons","description":"Add-ons for openHAB 2.x","fork":true,"url":"https://api.github.com/repos/FreddyFox/openhab2-addons","forks_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/forks","keys_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/teams","hooks_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/hooks","issue_events_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/issues/events{/number}","events_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/events","assignees_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/assignees{/user}","branches_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/branches{/branch}","tags_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/tags","blobs_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/git/refs{/sha}","trees_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/statuses/{sha}","languages_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/languages","stargazers_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/stargazers","contributors_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/contributors","subscribers_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/subscribers","subscription_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/subscription","commits_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/commits{/sha}","git_commits_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/git/commits{/sha}","comments_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/comments{/number}","issue_comment_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/issues/comments{/number}","contents_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/contents/{+path}","compare_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/merges","archive_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/downloads","issues_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/issues{/number}","pulls_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/pulls{/number}","milestones_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/milestones{/number}","notifications_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/labels{/name}","releases_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/releases{/id}","deployments_url":"https://api.github.com/repos/FreddyFox/openhab2-addons/deployments","created_at":"2018-12-02T23:24:30Z","updated_at":"2018-12-02T23:24:43Z","pushed_at":"2018-12-07T16:26:37Z","git_url":"git://github.com/FreddyFox/openhab2-addons.git","ssh_url":"git@github.com:FreddyFox/openhab2-addons.git","clone_url":"https://github.com/FreddyFox/openhab2-addons.git","svn_url":"https://github.com/FreddyFox/openhab2-addons","homepage":"","size":292700,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"themillhousegroup:master","ref":"master","sha":"d7062f16764902143d669dfea0961e0edb892a21","user":{"login":"themillhousegroup","id":1307907,"node_id":"MDQ6VXNlcjEzMDc5MDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1307907?v=4","gravatar_id":"","url":"https://api.github.com/users/themillhousegroup","html_url":"https://github.com/themillhousegroup","followers_url":"https://api.github.com/users/themillhousegroup/followers","following_url":"https://api.github.com/users/themillhousegroup/following{/other_user}","gists_url":"https://api.github.com/users/themillhousegroup/gists{/gist_id}","starred_url":"https://api.github.com/users/themillhousegroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/themillhousegroup/subscriptions","organizations_url":"https://api.github.com/users/themillhousegroup/orgs","repos_url":"https://api.github.com/users/themillhousegroup/repos","events_url":"https://api.github.com/users/themillhousegroup/events{/privacy}","received_events_url":"https://api.github.com/users/themillhousegroup/received_events","type":"User","site_admin":false},"repo":{"id":126566903,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY1NjY5MDM=","name":"openhab2-addons","full_name":"themillhousegroup/openhab2-addons","private":false,"owner":{"login":"themillhousegroup","id":1307907,"node_id":"MDQ6VXNlcjEzMDc5MDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1307907?v=4","gravatar_id":"","url":"https://api.github.com/users/themillhousegroup","html_url":"https://github.com/themillhousegroup","followers_url":"https://api.github.com/users/themillhousegroup/followers","following_url":"https://api.github.com/users/themillhousegroup/following{/other_user}","gists_url":"https://api.github.com/users/themillhousegroup/gists{/gist_id}","starred_url":"https://api.github.com/users/themillhousegroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/themillhousegroup/subscriptions","organizations_url":"https://api.github.com/users/themillhousegroup/orgs","repos_url":"https://api.github.com/users/themillhousegroup/repos","events_url":"https://api.github.com/users/themillhousegroup/events{/privacy}","received_events_url":"https://api.github.com/users/themillhousegroup/received_events","type":"User","site_admin":false},"html_url":"https://github.com/themillhousegroup/openhab2-addons","description":"Add-ons for openHAB 2.x","fork":true,"url":"https://api.github.com/repos/themillhousegroup/openhab2-addons","forks_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/forks","keys_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/teams","hooks_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/hooks","issue_events_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/issues/events{/number}","events_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/events","assignees_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/assignees{/user}","branches_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/branches{/branch}","tags_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/tags","blobs_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/git/refs{/sha}","trees_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/statuses/{sha}","languages_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/languages","stargazers_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/stargazers","contributors_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/contributors","subscribers_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/subscribers","subscription_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/subscription","commits_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/commits{/sha}","git_commits_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/git/commits{/sha}","comments_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/comments{/number}","issue_comment_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/issues/comments{/number}","contents_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/contents/{+path}","compare_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/merges","archive_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/downloads","issues_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/issues{/number}","pulls_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/pulls{/number}","milestones_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/milestones{/number}","notifications_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/labels{/name}","releases_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/releases{/id}","deployments_url":"https://api.github.com/repos/themillhousegroup/openhab2-addons/deployments","created_at":"2018-03-24T04:51:43Z","updated_at":"2018-12-06T06:08:35Z","pushed_at":"2018-12-07T16:37:02Z","git_url":"git://github.com/themillhousegroup/openhab2-addons.git","ssh_url":"git@github.com:themillhousegroup/openhab2-addons.git","clone_url":"https://github.com/themillhousegroup/openhab2-addons.git","svn_url":"https://github.com/themillhousegroup/openhab2-addons","homepage":"","size":292696,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":4,"open_issues":1,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/themillhousegroup/openhab2-addons/pulls/2"},"html":{"href":"https://github.com/themillhousegroup/openhab2-addons/pull/2"},"issue":{"href":"https://api.github.com/repos/themillhousegroup/openhab2-addons/issues/2"},"comments":{"href":"https://api.github.com/repos/themillhousegroup/openhab2-addons/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/themillhousegroup/openhab2-addons/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/themillhousegroup/openhab2-addons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/themillhousegroup/openhab2-addons/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/themillhousegroup/openhab2-addons/statuses/8480435cfa860d5c6795057f486ee24863416f0d"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":159,"deletions":20,"changed_files":4}}
{"actor":{"display_login":"FreddyFox"}}