{"action":"created","issue":{"url":"https://api.github.com/repos/bundler/bundler/issues/6558","repository_url":"https://api.github.com/repos/bundler/bundler","labels_url":"https://api.github.com/repos/bundler/bundler/issues/6558/labels{/name}","comments_url":"https://api.github.com/repos/bundler/bundler/issues/6558/comments","events_url":"https://api.github.com/repos/bundler/bundler/issues/6558/events","html_url":"https://github.com/bundler/bundler/pull/6558","id":328328208,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxODk3MDI1","number":6558,"title":"No need to setup BUNDLE_BIN in using DynamicCommand with --path","user":{"login":"ta1kt0me","id":1412864,"node_id":"MDQ6VXNlcjE0MTI4NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1412864?v=4","gravatar_id":"","url":"https://api.github.com/users/ta1kt0me","html_url":"https://github.com/ta1kt0me","followers_url":"https://api.github.com/users/ta1kt0me/followers","following_url":"https://api.github.com/users/ta1kt0me/following{/other_user}","gists_url":"https://api.github.com/users/ta1kt0me/gists{/gist_id}","starred_url":"https://api.github.com/users/ta1kt0me/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ta1kt0me/subscriptions","organizations_url":"https://api.github.com/users/ta1kt0me/orgs","repos_url":"https://api.github.com/users/ta1kt0me/repos","events_url":"https://api.github.com/users/ta1kt0me/events{/privacy}","received_events_url":"https://api.github.com/users/ta1kt0me/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-05-31T23:13:27Z","updated_at":"2018-06-05T14:12:33Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/bundler/bundler/pulls/6558","html_url":"https://github.com/bundler/bundler/pull/6558","diff_url":"https://github.com/bundler/bundler/pull/6558.diff","patch_url":"https://github.com/bundler/bundler/pull/6558.patch"},"body":"### What was the end-user problem that led to this PR?\r\n\r\nWhen we use a bundler's custom sub command provided by gem with `--path` option, we must use BUNDLE_BIN or bundle config bin to add it to PATH.\r\n\r\n### What was your diagnosis of the problem?\r\n\r\nWe can use BUNDLE_BIN as workaround, but I think it's easy for user to use the custom sub command with no option like as normal command installed by gem just after `bundle install`.\r\n\r\n### What is your fix for the problem, implemented in this PR?\r\n\r\nI've changed to use a new `CustomSubCommand` class rather than Thor's `DynamicCommand` class directly in custom sub command.\r\n\r\n### Why did you choose this fix out of the possible options?\r\n\r\nIt is the responsibility of Bundler to setup for its environment.\r\n"},"comment":{"url":"https://api.github.com/repos/bundler/bundler/issues/comments/394724464","html_url":"https://github.com/bundler/bundler/pull/6558#issuecomment-394724464","issue_url":"https://api.github.com/repos/bundler/bundler/issues/6558","id":394724464,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDcyNDQ2NA==","user":{"login":"colby-swandale","id":996377,"node_id":"MDQ6VXNlcjk5NjM3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/996377?v=4","gravatar_id":"","url":"https://api.github.com/users/colby-swandale","html_url":"https://github.com/colby-swandale","followers_url":"https://api.github.com/users/colby-swandale/followers","following_url":"https://api.github.com/users/colby-swandale/following{/other_user}","gists_url":"https://api.github.com/users/colby-swandale/gists{/gist_id}","starred_url":"https://api.github.com/users/colby-swandale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colby-swandale/subscriptions","organizations_url":"https://api.github.com/users/colby-swandale/orgs","repos_url":"https://api.github.com/users/colby-swandale/repos","events_url":"https://api.github.com/users/colby-swandale/events{/privacy}","received_events_url":"https://api.github.com/users/colby-swandale/received_events","type":"User","site_admin":false},"created_at":"2018-06-05T14:12:33Z","updated_at":"2018-06-05T14:12:33Z","author_association":"MEMBER","body":"I don't agree with this change in principle. We shouldn't be adding support for code to modify Bundler when we have a Plugin API."}}
{"actor":{"display_login":"colby-swandale"}}