{"action":"created","comment":{"url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/pulls/comments/166031603","pull_request_review_id":94057580,"id":166031603,"diff_hunk":"@@ -42,15 +43,51 @@ public void should_return_letter_if_message_contains_valid_json() {\n         assertThat(letter).isNotNull();\n         assertThat(letter.template).isEqualTo(\"whatever\");\n         assertThat(letter.type).isEqualTo(\"some_type\");\n+        assertThat(letter.service).isEqualTo(\"some_service\");\n     }\n \n-\n     @Test\n     public void should_throw_an_exception_if_message_contains_invalid_json() {\n         given(message.getBody())\n             .willReturn(\"{\\\"a\\\" : \\\"b\\\"}\".getBytes());\n \n         assertThatThrownBy(() -> letterMapper.from(message))\n-            .isInstanceOf(InvalidMessageException.class);\n+            .isInstanceOf(InvalidMessageException.class)\n+            .hasMessageStartingWith(\"Unable to deserialize message\");\n+    }\n+\n+    @Test\n+    public void should_throw_an_exception_if_message_contains_null_fields() {","path":"src/test/java/uk/gov/hmcts/reform/slc/services/steps/maptoletter/LetterMapperTest.java","position":30,"original_position":30,"commit_id":"5d3985f4615c9d80c4db607057493ed7e446a1e1","original_commit_id":"5d3985f4615c9d80c4db607057493ed7e446a1e1","user":{"login":"doncem","id":1420191,"avatar_url":"https://avatars3.githubusercontent.com/u/1420191?v=4","gravatar_id":"","url":"https://api.github.com/users/doncem","html_url":"https://github.com/doncem","followers_url":"https://api.github.com/users/doncem/followers","following_url":"https://api.github.com/users/doncem/following{/other_user}","gists_url":"https://api.github.com/users/doncem/gists{/gist_id}","starred_url":"https://api.github.com/users/doncem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doncem/subscriptions","organizations_url":"https://api.github.com/users/doncem/orgs","repos_url":"https://api.github.com/users/doncem/repos","events_url":"https://api.github.com/users/doncem/events{/privacy}","received_events_url":"https://api.github.com/users/doncem/received_events","type":"User","site_admin":false},"body":"All fields unmarshall as null. Don't want to prove the case with `4!` attempts for 3 scenarios just to make point code branch works","created_at":"2018-02-05T16:41:57Z","updated_at":"2018-02-05T16:41:57Z","html_url":"https://github.com/hmcts/send-letter-consumer-service/pull/16#discussion_r166031603","pull_request_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/pulls/16","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/hmcts/send-letter-consumer-service/pulls/comments/166031603"},"html":{"href":"https://github.com/hmcts/send-letter-consumer-service/pull/16#discussion_r166031603"},"pull_request":{"href":"https://api.github.com/repos/hmcts/send-letter-consumer-service/pulls/16"}},"in_reply_to_id":166026030},"pull_request":{"url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/pulls/16","id":167133430,"html_url":"https://github.com/hmcts/send-letter-consumer-service/pull/16","diff_url":"https://github.com/hmcts/send-letter-consumer-service/pull/16.diff","patch_url":"https://github.com/hmcts/send-letter-consumer-service/pull/16.patch","issue_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/issues/16","number":16,"state":"open","locked":false,"title":"RPE-210: Prepare metrics feature","user":{"login":"doncem","id":1420191,"avatar_url":"https://avatars3.githubusercontent.com/u/1420191?v=4","gravatar_id":"","url":"https://api.github.com/users/doncem","html_url":"https://github.com/doncem","followers_url":"https://api.github.com/users/doncem/followers","following_url":"https://api.github.com/users/doncem/following{/other_user}","gists_url":"https://api.github.com/users/doncem/gists{/gist_id}","starred_url":"https://api.github.com/users/doncem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doncem/subscriptions","organizations_url":"https://api.github.com/users/doncem/orgs","repos_url":"https://api.github.com/users/doncem/repos","events_url":"https://api.github.com/users/doncem/events{/privacy}","received_events_url":"https://api.github.com/users/doncem/received_events","type":"User","site_admin":false},"body":"### Change description ###\r\n\r\nMinor code review to ease up metrics integration:\r\n\r\n- letter validation\r\n- ftp uploader\r\n\r\nAdditional code review:\r\n\r\n- line breaks\r\n- gradle dependency order (OCD or w/e)\r\n\r\n**Does this PR introduce a breaking change?** (check one with \"x\")\r\n\r\n```\r\n[ ] Yes\r\n[x] No\r\n```\r\n","created_at":"2018-02-05T12:38:13Z","updated_at":"2018-02-05T16:41:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa5a14368110658f19a87e598c2ccd2c7dea96ed","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/pulls/16/commits","review_comments_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/pulls/16/comments","review_comment_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/issues/16/comments","statuses_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/statuses/5d3985f4615c9d80c4db607057493ed7e446a1e1","head":{"label":"hmcts:REP-210/prepare-feature","ref":"REP-210/prepare-feature","sha":"5d3985f4615c9d80c4db607057493ed7e446a1e1","user":{"login":"hmcts","id":22817111,"avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"repo":{"id":118617070,"name":"send-letter-consumer-service","full_name":"hmcts/send-letter-consumer-service","owner":{"login":"hmcts","id":22817111,"avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmcts/send-letter-consumer-service","description":null,"fork":false,"url":"https://api.github.com/repos/hmcts/send-letter-consumer-service","forks_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/forks","keys_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/teams","hooks_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/hooks","issue_events_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/issues/events{/number}","events_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/events","assignees_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/assignees{/user}","branches_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/branches{/branch}","tags_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/tags","blobs_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/statuses/{sha}","languages_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/languages","stargazers_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/stargazers","contributors_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/contributors","subscribers_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/subscribers","subscription_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/subscription","commits_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/contents/{+path}","compare_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/merges","archive_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/downloads","issues_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/issues{/number}","pulls_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/pulls{/number}","milestones_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/milestones{/number}","notifications_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/labels{/name}","releases_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/releases{/id}","deployments_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/deployments","created_at":"2018-01-23T13:52:51Z","updated_at":"2018-02-02T19:12:56Z","pushed_at":"2018-02-05T16:39:49Z","git_url":"git://github.com/hmcts/send-letter-consumer-service.git","ssh_url":"git@github.com:hmcts/send-letter-consumer-service.git","clone_url":"https://github.com/hmcts/send-letter-consumer-service.git","svn_url":"https://github.com/hmcts/send-letter-consumer-service","homepage":null,"size":153,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"hmcts:master","ref":"master","sha":"8b13ecbce0a55862ae32bda8ced0bfb173316d7e","user":{"login":"hmcts","id":22817111,"avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"repo":{"id":118617070,"name":"send-letter-consumer-service","full_name":"hmcts/send-letter-consumer-service","owner":{"login":"hmcts","id":22817111,"avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmcts/send-letter-consumer-service","description":null,"fork":false,"url":"https://api.github.com/repos/hmcts/send-letter-consumer-service","forks_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/forks","keys_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/teams","hooks_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/hooks","issue_events_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/issues/events{/number}","events_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/events","assignees_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/assignees{/user}","branches_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/branches{/branch}","tags_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/tags","blobs_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/statuses/{sha}","languages_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/languages","stargazers_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/stargazers","contributors_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/contributors","subscribers_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/subscribers","subscription_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/subscription","commits_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/contents/{+path}","compare_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/merges","archive_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/downloads","issues_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/issues{/number}","pulls_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/pulls{/number}","milestones_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/milestones{/number}","notifications_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/labels{/name}","releases_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/releases{/id}","deployments_url":"https://api.github.com/repos/hmcts/send-letter-consumer-service/deployments","created_at":"2018-01-23T13:52:51Z","updated_at":"2018-02-02T19:12:56Z","pushed_at":"2018-02-05T16:39:49Z","git_url":"git://github.com/hmcts/send-letter-consumer-service.git","ssh_url":"git@github.com:hmcts/send-letter-consumer-service.git","clone_url":"https://github.com/hmcts/send-letter-consumer-service.git","svn_url":"https://github.com/hmcts/send-letter-consumer-service","homepage":null,"size":153,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmcts/send-letter-consumer-service/pulls/16"},"html":{"href":"https://github.com/hmcts/send-letter-consumer-service/pull/16"},"issue":{"href":"https://api.github.com/repos/hmcts/send-letter-consumer-service/issues/16"},"comments":{"href":"https://api.github.com/repos/hmcts/send-letter-consumer-service/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/hmcts/send-letter-consumer-service/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/hmcts/send-letter-consumer-service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmcts/send-letter-consumer-service/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/hmcts/send-letter-consumer-service/statuses/5d3985f4615c9d80c4db607057493ed7e446a1e1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"doncem"}}