{"action":"created","comment":{"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments/188915878","pull_request_review_id":120988110,"id":188915878,"diff_hunk":"@@ -199,6 +199,39 @@ if (get_var('DEV_IMAGE')) {\n     }\n }\n \n+#This setting is used to enable all extensions/modules for upgrading tests, generate corresponding extensions/modules list for all addons, all extensions, all modules cases.\n+if (check_var('SCC_REGISTER', 'installation') && get_var('ALL_ADDONS')) {\n+    my $version = get_required_var(\"HDDVERSION\");\n+    #Below $common* store the extensions/modules list in common.\n+    my $common_addons_12SP3     = 'sdk,pcm,tcm,wsm';\n+    my $common_modules_12SP3    = 'pcm,tcm,wsm';\n+    my $common_extensions_12SP3 = 'sdk';\n+    my $common_addons_11SP4     = 'ha,geo,sdk';","path":"products/sle/main.pm","position":11,"original_position":11,"commit_id":"6c5ad0ba6f232143c5dcf0c6ae1bf21420cd188b","original_commit_id":"6c5ad0ba6f232143c5dcf0c6ae1bf21420cd188b","user":{"login":"rwx788","id":28305643,"avatar_url":"https://avatars1.githubusercontent.com/u/28305643?v=4","gravatar_id":"","url":"https://api.github.com/users/rwx788","html_url":"https://github.com/rwx788","followers_url":"https://api.github.com/users/rwx788/followers","following_url":"https://api.github.com/users/rwx788/following{/other_user}","gists_url":"https://api.github.com/users/rwx788/gists{/gist_id}","starred_url":"https://api.github.com/users/rwx788/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwx788/subscriptions","organizations_url":"https://api.github.com/users/rwx788/orgs","repos_url":"https://api.github.com/users/rwx788/repos","events_url":"https://api.github.com/users/rwx788/events{/privacy}","received_events_url":"https://api.github.com/users/rwx788/received_events","type":"User","site_admin":false},"body":"We got pretty complicated structure here,  which is hard to read if you see it for the first time. What's about putting those in the hashes which are initialized below depending on version? So that hash contains all addons/modules/extensions and we don't have to complement it later in the code.","created_at":"2018-05-17T10:49:23Z","updated_at":"2018-05-17T10:55:51Z","html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/5073#discussion_r188915878","pull_request_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/5073","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments/188915878"},"html":{"href":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/5073#discussion_r188915878"},"pull_request":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/5073"}}},"pull_request":{"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/5073","id":188683481,"html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/5073","diff_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/5073.diff","patch_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/5073.patch","issue_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/5073","number":5073,"state":"open","locked":false,"title":"Use simple variable to enable all extensions/modules for upgrading tests","user":{"login":"lemon-suse","id":34636462,"avatar_url":"https://avatars1.githubusercontent.com/u/34636462?v=4","gravatar_id":"","url":"https://api.github.com/users/lemon-suse","html_url":"https://github.com/lemon-suse","followers_url":"https://api.github.com/users/lemon-suse/followers","following_url":"https://api.github.com/users/lemon-suse/following{/other_user}","gists_url":"https://api.github.com/users/lemon-suse/gists{/gist_id}","starred_url":"https://api.github.com/users/lemon-suse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lemon-suse/subscriptions","organizations_url":"https://api.github.com/users/lemon-suse/orgs","repos_url":"https://api.github.com/users/lemon-suse/repos","events_url":"https://api.github.com/users/lemon-suse/events{/privacy}","received_events_url":"https://api.github.com/users/lemon-suse/received_events","type":"User","site_admin":false},"body":"Add variable ALL_ADDONS (1 for all extensions+modules, 2 for all extensions, 3 for all modules), then create different module list for different architecture in main.pm. This will help to reduce the number of test suite.\r\n\r\n- Related ticket: https://progress.opensuse.org/issues/30062\r\n- Needles: https://gitlab.suse.de/openqa/os-autoinst-needles-sles/merge_requests/847\r\n- Verification run:  1. all addons: http://openqa-apac1.suse.de/tests/1006\r\n                             2. all extensions: http://openqa-apac1.suse.de/tests/993\r\n                             3. all modules: http://openqa-apac1.suse.de/tests/995","created_at":"2018-05-17T09:58:58Z","updated_at":"2018-05-17T10:55:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39dd671e88fb48c88f77bb6052fe95b240c6d43e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/5073/commits","review_comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/5073/comments","review_comment_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/5073/comments","statuses_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/statuses/6c5ad0ba6f232143c5dcf0c6ae1bf21420cd188b","head":{"label":"lemon-suse:add_variable_all_addons","ref":"add_variable_all_addons","sha":"6c5ad0ba6f232143c5dcf0c6ae1bf21420cd188b","user":{"login":"lemon-suse","id":34636462,"avatar_url":"https://avatars1.githubusercontent.com/u/34636462?v=4","gravatar_id":"","url":"https://api.github.com/users/lemon-suse","html_url":"https://github.com/lemon-suse","followers_url":"https://api.github.com/users/lemon-suse/followers","following_url":"https://api.github.com/users/lemon-suse/following{/other_user}","gists_url":"https://api.github.com/users/lemon-suse/gists{/gist_id}","starred_url":"https://api.github.com/users/lemon-suse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lemon-suse/subscriptions","organizations_url":"https://api.github.com/users/lemon-suse/orgs","repos_url":"https://api.github.com/users/lemon-suse/repos","events_url":"https://api.github.com/users/lemon-suse/events{/privacy}","received_events_url":"https://api.github.com/users/lemon-suse/received_events","type":"User","site_admin":false},"repo":{"id":115696511,"name":"os-autoinst-distri-opensuse","full_name":"lemon-suse/os-autoinst-distri-opensuse","owner":{"login":"lemon-suse","id":34636462,"avatar_url":"https://avatars1.githubusercontent.com/u/34636462?v=4","gravatar_id":"","url":"https://api.github.com/users/lemon-suse","html_url":"https://github.com/lemon-suse","followers_url":"https://api.github.com/users/lemon-suse/followers","following_url":"https://api.github.com/users/lemon-suse/following{/other_user}","gists_url":"https://api.github.com/users/lemon-suse/gists{/gist_id}","starred_url":"https://api.github.com/users/lemon-suse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lemon-suse/subscriptions","organizations_url":"https://api.github.com/users/lemon-suse/orgs","repos_url":"https://api.github.com/users/lemon-suse/repos","events_url":"https://api.github.com/users/lemon-suse/events{/privacy}","received_events_url":"https://api.github.com/users/lemon-suse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lemon-suse/os-autoinst-distri-opensuse","description":"os-autoinst test cases for openSUSE","fork":true,"url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse","forks_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/forks","keys_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/teams","hooks_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/hooks","issue_events_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/issues/events{/number}","events_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/events","assignees_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/assignees{/user}","branches_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/branches{/branch}","tags_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/tags","blobs_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/git/refs{/sha}","trees_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/statuses/{sha}","languages_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/languages","stargazers_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/stargazers","contributors_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/contributors","subscribers_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/subscribers","subscription_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/subscription","commits_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/commits{/sha}","git_commits_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/git/commits{/sha}","comments_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/comments{/number}","issue_comment_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/issues/comments{/number}","contents_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/contents/{+path}","compare_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/merges","archive_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/downloads","issues_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/issues{/number}","pulls_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/pulls{/number}","milestones_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/milestones{/number}","notifications_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/labels{/name}","releases_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/releases{/id}","deployments_url":"https://api.github.com/repos/lemon-suse/os-autoinst-distri-opensuse/deployments","created_at":"2017-12-29T07:00:26Z","updated_at":"2018-05-17T06:11:23Z","pushed_at":"2018-05-17T09:50:27Z","git_url":"git://github.com/lemon-suse/os-autoinst-distri-opensuse.git","ssh_url":"git@github.com:lemon-suse/os-autoinst-distri-opensuse.git","clone_url":"https://github.com/lemon-suse/os-autoinst-distri-opensuse.git","svn_url":"https://github.com/lemon-suse/os-autoinst-distri-opensuse","homepage":"https://progress.opensuse.org/projects/openqatests/issues","size":90072,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"os-autoinst:master","ref":"master","sha":"61d997708f4dda3e40227df76d0ad9f4a1cae879","user":{"login":"os-autoinst","id":6918706,"avatar_url":"https://avatars2.githubusercontent.com/u/6918706?v=4","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"repo":{"id":17630288,"name":"os-autoinst-distri-opensuse","full_name":"os-autoinst/os-autoinst-distri-opensuse","owner":{"login":"os-autoinst","id":6918706,"avatar_url":"https://avatars2.githubusercontent.com/u/6918706?v=4","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse","description":"os-autoinst test cases for openSUSE","fork":false,"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse","forks_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/forks","keys_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/teams","hooks_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/hooks","issue_events_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/events{/number}","events_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/events","assignees_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/assignees{/user}","branches_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/branches{/branch}","tags_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/tags","blobs_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/refs{/sha}","trees_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/statuses/{sha}","languages_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/languages","stargazers_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/stargazers","contributors_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/contributors","subscribers_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/subscribers","subscription_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/subscription","commits_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/commits{/sha}","git_commits_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/commits{/sha}","comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/comments{/number}","issue_comment_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/comments{/number}","contents_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/contents/{+path}","compare_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/merges","archive_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/downloads","issues_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues{/number}","pulls_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls{/number}","milestones_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/milestones{/number}","notifications_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/labels{/name}","releases_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/releases{/id}","deployments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/deployments","created_at":"2014-03-11T12:54:42Z","updated_at":"2018-05-17T10:02:28Z","pushed_at":"2018-05-17T10:55:04Z","git_url":"git://github.com/os-autoinst/os-autoinst-distri-opensuse.git","ssh_url":"git@github.com:os-autoinst/os-autoinst-distri-opensuse.git","clone_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse.git","svn_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse","homepage":"https://progress.opensuse.org/projects/openqatests/issues","size":90105,"stargazers_count":30,"watchers_count":30,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":127,"mirror_url":null,"archived":false,"open_issues_count":41,"license":null,"forks":127,"open_issues":41,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/5073"},"html":{"href":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/5073"},"issue":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/5073"},"comments":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/5073/comments"},"review_comments":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/5073/comments"},"review_comment":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/5073/commits"},"statuses":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/statuses/6c5ad0ba6f232143c5dcf0c6ae1bf21420cd188b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rwx788"}}