{"action":"created","comment":{"url":"https://api.github.com/repos/sempr-tk/sempr/pulls/comments/207191267","pull_request_review_id":142750379,"id":207191267,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzE5MTI2Nw==","diff_hunk":"@@ -49,36 +60,46 @@ class Geometry : public Entity {\n     */\n     void transformToCS(SpatialReference::Ptr cs);\n \n-    /** Exception that may be thrown during transformToCS. */\n-    class TransformException : public std::exception {\n-    private:\n-        std::string message_;\n-    public:\n-        explicit TransformException(const std::string& m) : message_(m) {}\n-        virtual const char* what() const throw() {\n-            return message_.c_str();\n-        }\n-    };\n+    // apply a read only filter to find the min and max values of the geometry in his local coordinate system in 3d.\n+    void findEnvelope(geom::Coordinate& min, geom::Coordinate& max);\n \n     /**\n         Get a new entity with the same geometry (copy) referring to the same instance of\n         SpatialReference. (implemented by raw_clone)\n     */\n     Geometry::Ptr clone() const;\n \n-private:\n+    static geom::Geometry* importFromWKB(const std::basic_string<char> &buffer);\n+    static std::basic_string<char> exportToWKB(const geom::Geometry *geom);\n+\n+    static geom::Geometry* importFromWKT(const std::string &text);\n+    static std::string exportToWKT(const geom::Geometry *geom);\n+\n+  protected:\n+    static const geom::GeometryFactory* factory_;\n+\n+    /**\n+     * @brief Get the GEOS GEOM Geometry object as mutable (non-const) pointer.\n+     */\n+    virtual geom::Geometry* getGeometryMut() const;","path":"include/sempr/entity/spatial/Geometry.hpp","position":null,"original_position":84,"commit_id":"b592d1b8d82f928243794dfc865afae4017728ab","original_commit_id":"71ebd4a86a58f1e7b72c1087a7887e554b553493","user":{"login":"niniemann","id":27948366,"node_id":"MDQ6VXNlcjI3OTQ4MzY2","avatar_url":"https://avatars3.githubusercontent.com/u/27948366?v=4","gravatar_id":"","url":"https://api.github.com/users/niniemann","html_url":"https://github.com/niniemann","followers_url":"https://api.github.com/users/niniemann/followers","following_url":"https://api.github.com/users/niniemann/following{/other_user}","gists_url":"https://api.github.com/users/niniemann/gists{/gist_id}","starred_url":"https://api.github.com/users/niniemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niniemann/subscriptions","organizations_url":"https://api.github.com/users/niniemann/orgs","repos_url":"https://api.github.com/users/niniemann/repos","events_url":"https://api.github.com/users/niniemann/events{/privacy}","received_events_url":"https://api.github.com/users/niniemann/received_events","type":"User","site_admin":false},"body":"Yeah, maybe that's just not totally straight-forward... IMHO if I'm not allowed to modify a `entity::Geometry` (i.e., I've only got a `const entity::Geometry` to work with), I should not be able to get access to the non-const `geos::geom::Geometry`, as changing that would in fact modify `entity::Geometry` as it only acts as a wrapper.\r\n\r\nBut since you already changed that I'm fine. :)","created_at":"2018-08-02T11:27:07Z","updated_at":"2018-08-02T11:27:07Z","html_url":"https://github.com/sempr-tk/sempr/pull/40#discussion_r207191267","pull_request_url":"https://api.github.com/repos/sempr-tk/sempr/pulls/40","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/sempr-tk/sempr/pulls/comments/207191267"},"html":{"href":"https://github.com/sempr-tk/sempr/pull/40#discussion_r207191267"},"pull_request":{"href":"https://api.github.com/repos/sempr-tk/sempr/pulls/40"}},"in_reply_to_id":207149453},"pull_request":{"url":"https://api.github.com/repos/sempr-tk/sempr/pulls/40","id":203824636,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzODI0NjM2","html_url":"https://github.com/sempr-tk/sempr/pull/40","diff_url":"https://github.com/sempr-tk/sempr/pull/40.diff","patch_url":"https://github.com/sempr-tk/sempr/pull/40.patch","issue_url":"https://api.github.com/repos/sempr-tk/sempr/issues/40","number":40,"state":"open","locked":false,"title":"Remove gdal","user":{"login":"ctieben","id":40820904,"node_id":"MDQ6VXNlcjQwODIwOTA0","avatar_url":"https://avatars2.githubusercontent.com/u/40820904?v=4","gravatar_id":"","url":"https://api.github.com/users/ctieben","html_url":"https://github.com/ctieben","followers_url":"https://api.github.com/users/ctieben/followers","following_url":"https://api.github.com/users/ctieben/following{/other_user}","gists_url":"https://api.github.com/users/ctieben/gists{/gist_id}","starred_url":"https://api.github.com/users/ctieben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctieben/subscriptions","organizations_url":"https://api.github.com/users/ctieben/orgs","repos_url":"https://api.github.com/users/ctieben/repos","events_url":"https://api.github.com/users/ctieben/events{/privacy}","received_events_url":"https://api.github.com/users/ctieben/received_events","type":"User","site_admin":false},"body":"So, after more than two weeks the GDAL dependency finally is removed from sempr.\r\n\r\nThe major changes are:\r\n- All spatial types are changed from GDAL OSG to GEOS GEOM geometries.\r\n- Traits are updated to store the changed types\r\n- Global transformation and projection are changed to the GeographicLib\r\n- Support for WGS84, ECEF, LTG, UTM, UPS, MGRS added\r\n- Exclusive support of WGS84 as base reference system (no GRH80 or ...)\r\n- Update and add unit tests for geometry and transformations\r\n- Update CMake and CI and ReadMe based of the dependency changes\r\n- Add CTest support.\r\n\r\nThis pull will close #23 and #19.","created_at":"2018-07-25T12:44:03Z","updated_at":"2018-08-02T11:27:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a776f814bab603bf10718dc9d5375298254cfc8c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sempr-tk/sempr/pulls/40/commits","review_comments_url":"https://api.github.com/repos/sempr-tk/sempr/pulls/40/comments","review_comment_url":"https://api.github.com/repos/sempr-tk/sempr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sempr-tk/sempr/issues/40/comments","statuses_url":"https://api.github.com/repos/sempr-tk/sempr/statuses/b592d1b8d82f928243794dfc865afae4017728ab","head":{"label":"sempr-tk:remove_gdal","ref":"remove_gdal","sha":"b592d1b8d82f928243794dfc865afae4017728ab","user":{"login":"sempr-tk","id":34568269,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTY4MjY5","avatar_url":"https://avatars0.githubusercontent.com/u/34568269?v=4","gravatar_id":"","url":"https://api.github.com/users/sempr-tk","html_url":"https://github.com/sempr-tk","followers_url":"https://api.github.com/users/sempr-tk/followers","following_url":"https://api.github.com/users/sempr-tk/following{/other_user}","gists_url":"https://api.github.com/users/sempr-tk/gists{/gist_id}","starred_url":"https://api.github.com/users/sempr-tk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sempr-tk/subscriptions","organizations_url":"https://api.github.com/users/sempr-tk/orgs","repos_url":"https://api.github.com/users/sempr-tk/repos","events_url":"https://api.github.com/users/sempr-tk/events{/privacy}","received_events_url":"https://api.github.com/users/sempr-tk/received_events","type":"Organization","site_admin":false},"repo":{"id":114119870,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQxMTk4NzA=","name":"sempr","full_name":"sempr-tk/sempr","owner":{"login":"sempr-tk","id":34568269,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTY4MjY5","avatar_url":"https://avatars0.githubusercontent.com/u/34568269?v=4","gravatar_id":"","url":"https://api.github.com/users/sempr-tk","html_url":"https://github.com/sempr-tk","followers_url":"https://api.github.com/users/sempr-tk/followers","following_url":"https://api.github.com/users/sempr-tk/following{/other_user}","gists_url":"https://api.github.com/users/sempr-tk/gists{/gist_id}","starred_url":"https://api.github.com/users/sempr-tk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sempr-tk/subscriptions","organizations_url":"https://api.github.com/users/sempr-tk/orgs","repos_url":"https://api.github.com/users/sempr-tk/repos","events_url":"https://api.github.com/users/sempr-tk/events{/privacy}","received_events_url":"https://api.github.com/users/sempr-tk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sempr-tk/sempr","description":"SEMPR - Semantic Environment Mapping, Processing and Reasoning","fork":false,"url":"https://api.github.com/repos/sempr-tk/sempr","forks_url":"https://api.github.com/repos/sempr-tk/sempr/forks","keys_url":"https://api.github.com/repos/sempr-tk/sempr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sempr-tk/sempr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sempr-tk/sempr/teams","hooks_url":"https://api.github.com/repos/sempr-tk/sempr/hooks","issue_events_url":"https://api.github.com/repos/sempr-tk/sempr/issues/events{/number}","events_url":"https://api.github.com/repos/sempr-tk/sempr/events","assignees_url":"https://api.github.com/repos/sempr-tk/sempr/assignees{/user}","branches_url":"https://api.github.com/repos/sempr-tk/sempr/branches{/branch}","tags_url":"https://api.github.com/repos/sempr-tk/sempr/tags","blobs_url":"https://api.github.com/repos/sempr-tk/sempr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sempr-tk/sempr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sempr-tk/sempr/git/refs{/sha}","trees_url":"https://api.github.com/repos/sempr-tk/sempr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sempr-tk/sempr/statuses/{sha}","languages_url":"https://api.github.com/repos/sempr-tk/sempr/languages","stargazers_url":"https://api.github.com/repos/sempr-tk/sempr/stargazers","contributors_url":"https://api.github.com/repos/sempr-tk/sempr/contributors","subscribers_url":"https://api.github.com/repos/sempr-tk/sempr/subscribers","subscription_url":"https://api.github.com/repos/sempr-tk/sempr/subscription","commits_url":"https://api.github.com/repos/sempr-tk/sempr/commits{/sha}","git_commits_url":"https://api.github.com/repos/sempr-tk/sempr/git/commits{/sha}","comments_url":"https://api.github.com/repos/sempr-tk/sempr/comments{/number}","issue_comment_url":"https://api.github.com/repos/sempr-tk/sempr/issues/comments{/number}","contents_url":"https://api.github.com/repos/sempr-tk/sempr/contents/{+path}","compare_url":"https://api.github.com/repos/sempr-tk/sempr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sempr-tk/sempr/merges","archive_url":"https://api.github.com/repos/sempr-tk/sempr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sempr-tk/sempr/downloads","issues_url":"https://api.github.com/repos/sempr-tk/sempr/issues{/number}","pulls_url":"https://api.github.com/repos/sempr-tk/sempr/pulls{/number}","milestones_url":"https://api.github.com/repos/sempr-tk/sempr/milestones{/number}","notifications_url":"https://api.github.com/repos/sempr-tk/sempr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sempr-tk/sempr/labels{/name}","releases_url":"https://api.github.com/repos/sempr-tk/sempr/releases{/id}","deployments_url":"https://api.github.com/repos/sempr-tk/sempr/deployments","created_at":"2017-12-13T12:46:44Z","updated_at":"2018-07-06T09:47:18Z","pushed_at":"2018-08-02T09:49:44Z","git_url":"git://github.com/sempr-tk/sempr.git","ssh_url":"git@github.com:sempr-tk/sempr.git","clone_url":"https://github.com/sempr-tk/sempr.git","svn_url":"https://github.com/sempr-tk/sempr","homepage":null,"size":674,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":19,"watchers":3,"default_branch":"master"}},"base":{"label":"sempr-tk:master","ref":"master","sha":"0e645614247790169ece0b18c2d16c2e1a8c5e49","user":{"login":"sempr-tk","id":34568269,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTY4MjY5","avatar_url":"https://avatars0.githubusercontent.com/u/34568269?v=4","gravatar_id":"","url":"https://api.github.com/users/sempr-tk","html_url":"https://github.com/sempr-tk","followers_url":"https://api.github.com/users/sempr-tk/followers","following_url":"https://api.github.com/users/sempr-tk/following{/other_user}","gists_url":"https://api.github.com/users/sempr-tk/gists{/gist_id}","starred_url":"https://api.github.com/users/sempr-tk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sempr-tk/subscriptions","organizations_url":"https://api.github.com/users/sempr-tk/orgs","repos_url":"https://api.github.com/users/sempr-tk/repos","events_url":"https://api.github.com/users/sempr-tk/events{/privacy}","received_events_url":"https://api.github.com/users/sempr-tk/received_events","type":"Organization","site_admin":false},"repo":{"id":114119870,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQxMTk4NzA=","name":"sempr","full_name":"sempr-tk/sempr","owner":{"login":"sempr-tk","id":34568269,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTY4MjY5","avatar_url":"https://avatars0.githubusercontent.com/u/34568269?v=4","gravatar_id":"","url":"https://api.github.com/users/sempr-tk","html_url":"https://github.com/sempr-tk","followers_url":"https://api.github.com/users/sempr-tk/followers","following_url":"https://api.github.com/users/sempr-tk/following{/other_user}","gists_url":"https://api.github.com/users/sempr-tk/gists{/gist_id}","starred_url":"https://api.github.com/users/sempr-tk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sempr-tk/subscriptions","organizations_url":"https://api.github.com/users/sempr-tk/orgs","repos_url":"https://api.github.com/users/sempr-tk/repos","events_url":"https://api.github.com/users/sempr-tk/events{/privacy}","received_events_url":"https://api.github.com/users/sempr-tk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sempr-tk/sempr","description":"SEMPR - Semantic Environment Mapping, Processing and Reasoning","fork":false,"url":"https://api.github.com/repos/sempr-tk/sempr","forks_url":"https://api.github.com/repos/sempr-tk/sempr/forks","keys_url":"https://api.github.com/repos/sempr-tk/sempr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sempr-tk/sempr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sempr-tk/sempr/teams","hooks_url":"https://api.github.com/repos/sempr-tk/sempr/hooks","issue_events_url":"https://api.github.com/repos/sempr-tk/sempr/issues/events{/number}","events_url":"https://api.github.com/repos/sempr-tk/sempr/events","assignees_url":"https://api.github.com/repos/sempr-tk/sempr/assignees{/user}","branches_url":"https://api.github.com/repos/sempr-tk/sempr/branches{/branch}","tags_url":"https://api.github.com/repos/sempr-tk/sempr/tags","blobs_url":"https://api.github.com/repos/sempr-tk/sempr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sempr-tk/sempr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sempr-tk/sempr/git/refs{/sha}","trees_url":"https://api.github.com/repos/sempr-tk/sempr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sempr-tk/sempr/statuses/{sha}","languages_url":"https://api.github.com/repos/sempr-tk/sempr/languages","stargazers_url":"https://api.github.com/repos/sempr-tk/sempr/stargazers","contributors_url":"https://api.github.com/repos/sempr-tk/sempr/contributors","subscribers_url":"https://api.github.com/repos/sempr-tk/sempr/subscribers","subscription_url":"https://api.github.com/repos/sempr-tk/sempr/subscription","commits_url":"https://api.github.com/repos/sempr-tk/sempr/commits{/sha}","git_commits_url":"https://api.github.com/repos/sempr-tk/sempr/git/commits{/sha}","comments_url":"https://api.github.com/repos/sempr-tk/sempr/comments{/number}","issue_comment_url":"https://api.github.com/repos/sempr-tk/sempr/issues/comments{/number}","contents_url":"https://api.github.com/repos/sempr-tk/sempr/contents/{+path}","compare_url":"https://api.github.com/repos/sempr-tk/sempr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sempr-tk/sempr/merges","archive_url":"https://api.github.com/repos/sempr-tk/sempr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sempr-tk/sempr/downloads","issues_url":"https://api.github.com/repos/sempr-tk/sempr/issues{/number}","pulls_url":"https://api.github.com/repos/sempr-tk/sempr/pulls{/number}","milestones_url":"https://api.github.com/repos/sempr-tk/sempr/milestones{/number}","notifications_url":"https://api.github.com/repos/sempr-tk/sempr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sempr-tk/sempr/labels{/name}","releases_url":"https://api.github.com/repos/sempr-tk/sempr/releases{/id}","deployments_url":"https://api.github.com/repos/sempr-tk/sempr/deployments","created_at":"2017-12-13T12:46:44Z","updated_at":"2018-07-06T09:47:18Z","pushed_at":"2018-08-02T09:49:44Z","git_url":"git://github.com/sempr-tk/sempr.git","ssh_url":"git@github.com:sempr-tk/sempr.git","clone_url":"https://github.com/sempr-tk/sempr.git","svn_url":"https://github.com/sempr-tk/sempr","homepage":null,"size":674,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":19,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sempr-tk/sempr/pulls/40"},"html":{"href":"https://github.com/sempr-tk/sempr/pull/40"},"issue":{"href":"https://api.github.com/repos/sempr-tk/sempr/issues/40"},"comments":{"href":"https://api.github.com/repos/sempr-tk/sempr/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/sempr-tk/sempr/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/sempr-tk/sempr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sempr-tk/sempr/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/sempr-tk/sempr/statuses/b592d1b8d82f928243794dfc865afae4017728ab"}},"author_association":"NONE"}}
{"actor":{"display_login":"niniemann"}}