{"action":"created","issue":{"url":"https://api.github.com/repos/phenopackets/phenopacket-schema/issues/10","repository_url":"https://api.github.com/repos/phenopackets/phenopacket-schema","labels_url":"https://api.github.com/repos/phenopackets/phenopacket-schema/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/phenopackets/phenopacket-schema/issues/10/comments","events_url":"https://api.github.com/repos/phenopackets/phenopacket-schema/issues/10/events","html_url":"https://github.com/phenopackets/phenopacket-schema/issues/10","id":346229977,"node_id":"MDU6SXNzdWUzNDYyMjk5Nzc=","number":10,"title":"Time definitions","user":{"login":"mbaudis","id":675030,"node_id":"MDQ6VXNlcjY3NTAzMA==","avatar_url":"https://avatars3.githubusercontent.com/u/675030?v=4","gravatar_id":"","url":"https://api.github.com/users/mbaudis","html_url":"https://github.com/mbaudis","followers_url":"https://api.github.com/users/mbaudis/followers","following_url":"https://api.github.com/users/mbaudis/following{/other_user}","gists_url":"https://api.github.com/users/mbaudis/gists{/gist_id}","starred_url":"https://api.github.com/users/mbaudis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbaudis/subscriptions","organizations_url":"https://api.github.com/users/mbaudis/orgs","repos_url":"https://api.github.com/users/mbaudis/repos","events_url":"https://api.github.com/users/mbaudis/events{/privacy}","received_events_url":"https://api.github.com/users/mbaudis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-07-31T15:05:44Z","updated_at":"2018-08-03T13:38:22Z","closed_at":null,"author_association":"NONE","body":"IMO for some attributes it is dangerous to have them defined with strong dependency on the specific serialisation.\r\n\r\nThe typical case here are the time definitions, which refer to the internally handled timestamp:\r\n\r\nhttps://github.com/phenopackets/phenopacket-schema/blob/2626158aaab70689dd5a46271a6321c2d49b0200/src/main/proto/org/phenopackets/schema/v1/core/base.proto#L12\r\n\r\nThis does not give any indication to the user of how to I/O time.\r\n\r\nTime formats are something [where a single, clean definition exists](https://www.iso.org/iso-8601-date-and-time-format.html), and which has been [well documented](https://ga4gh-metadata.github.io/formats.html) in the metadata schema. I am __strongly__ for defining time (poits, spans e.g. ages ...) as string/ISO8601, and leave the deparsing to the I/O handlers.\r\n\r\nThis is just one example where we _easy implementation_ NE _clear definition_."},"comment":{"url":"https://api.github.com/repos/phenopackets/phenopacket-schema/issues/comments/410256865","html_url":"https://github.com/phenopackets/phenopacket-schema/issues/10#issuecomment-410256865","issue_url":"https://api.github.com/repos/phenopackets/phenopacket-schema/issues/10","id":410256865,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDI1Njg2NQ==","user":{"login":"julesjacobsen","id":1576670,"node_id":"MDQ6VXNlcjE1NzY2NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1576670?v=4","gravatar_id":"","url":"https://api.github.com/users/julesjacobsen","html_url":"https://github.com/julesjacobsen","followers_url":"https://api.github.com/users/julesjacobsen/followers","following_url":"https://api.github.com/users/julesjacobsen/following{/other_user}","gists_url":"https://api.github.com/users/julesjacobsen/gists{/gist_id}","starred_url":"https://api.github.com/users/julesjacobsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julesjacobsen/subscriptions","organizations_url":"https://api.github.com/users/julesjacobsen/orgs","repos_url":"https://api.github.com/users/julesjacobsen/repos","events_url":"https://api.github.com/users/julesjacobsen/events{/privacy}","received_events_url":"https://api.github.com/users/julesjacobsen/received_events","type":"User","site_admin":false},"created_at":"2018-08-03T13:38:22Z","updated_at":"2018-08-03T13:38:22Z","author_association":"COLLABORATOR","body":"I've updated the documentation to make it clear what is expected as input for a timestamp field. e.g.\r\n\r\n```\r\n    // ISO8601 UTC timestamp at which this Biosample record was updated, in\r\n    // the format YYYY-MM-DDTHH:MM:SS.SSSZ e.g 2007-12-03T10:15:30.00Z\r\n```\r\n\r\nI hope this clears up any ambiguity. I've also update individual to have both data_of_birth and age_at_collection fields as the DOB wasn't always made available."}}
{"actor":{"display_login":"julesjacobsen"}}