{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/240562489","pull_request_review_id":183617243,"id":240562489,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDU2MjQ4OQ==","diff_hunk":"@@ -0,0 +1,87 @@\n+/*\n+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one\n+ * or more contributor license agreements. Licensed under the Elastic License;\n+ * you may not use this file except in compliance with the Elastic License.\n+ */\n+\n+// The Annotation interface is based on annotation documents stored in the\n+// `.ml-annotations-6` index, accessed via the `.ml-annotations` alias.\n+\n+// Annotation document mapping:\n+// PUT .ml-annotations-6\n+// {\n+//   \"mappings\": {\n+//     \"annotation\": {\n+//       \"properties\": {\n+//         \"annotation\": {\n+//           \"type\": \"text\"\n+//         },\n+//         \"create_time\": {\n+//           \"type\": \"date\"\n+//         },\n+//         \"create_username\": {\n+//           \"type\": \"keyword\"\n+//         },\n+//         \"timestamp\": {\n+//           \"type\": \"date\"\n+//         },\n+//         \"end_timestamp\": {\n+//           \"type\": \"date\"\n+//         },\n+//         \"job_id\": {\n+//           \"type\": \"keyword\"\n+//         },\n+//         \"modified_time\": {\n+//           \"type\": \"date\"\n+//         },\n+//         \"modified_username\": {\n+//           \"type\": \"keyword\"\n+//         },\n+//         \"result_type\": {","path":"x-pack/plugins/ml/common/types/annotations.ts","position":null,"original_position":40,"commit_id":"2278c272b7a3f07fdf3841c44bfd0198653a55a9","original_commit_id":"0566416b8b04093ba03420fabeadc796cab1a26b","user":{"login":"walterra","id":230104,"node_id":"MDQ6VXNlcjIzMDEwNA==","avatar_url":"https://avatars3.githubusercontent.com/u/230104?v=4","gravatar_id":"","url":"https://api.github.com/users/walterra","html_url":"https://github.com/walterra","followers_url":"https://api.github.com/users/walterra/followers","following_url":"https://api.github.com/users/walterra/following{/other_user}","gists_url":"https://api.github.com/users/walterra/gists{/gist_id}","starred_url":"https://api.github.com/users/walterra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walterra/subscriptions","organizations_url":"https://api.github.com/users/walterra/orgs","repos_url":"https://api.github.com/users/walterra/repos","events_url":"https://api.github.com/users/walterra/events{/privacy}","received_events_url":"https://api.github.com/users/walterra/received_events","type":"User","site_admin":false},"body":"Agreed! Changed in https://github.com/elastic/kibana/pull/26034/commits/a985d52f328a7de16a90396d1550491408272428#diff-c5c6ac3dbb0e7c91b6d127aa06121b2cR44","created_at":"2018-12-11T10:58:01Z","updated_at":"2018-12-11T10:58:02Z","html_url":"https://github.com/elastic/kibana/pull/26034#discussion_r240562489","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/26034","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/240562489"},"html":{"href":"https://github.com/elastic/kibana/pull/26034#discussion_r240562489"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/26034"}},"in_reply_to_id":240299528},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/26034","id":232741096,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNzQxMDk2","html_url":"https://github.com/elastic/kibana/pull/26034","diff_url":"https://github.com/elastic/kibana/pull/26034.diff","patch_url":"https://github.com/elastic/kibana/pull/26034.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/26034","number":26034,"state":"open","locked":false,"title":"[WIP] [ML] User Annotations","user":{"login":"walterra","id":230104,"node_id":"MDQ6VXNlcjIzMDEwNA==","avatar_url":"https://avatars3.githubusercontent.com/u/230104?v=4","gravatar_id":"","url":"https://api.github.com/users/walterra","html_url":"https://github.com/walterra","followers_url":"https://api.github.com/users/walterra/followers","following_url":"https://api.github.com/users/walterra/following{/other_user}","gists_url":"https://api.github.com/users/walterra/gists{/gist_id}","starred_url":"https://api.github.com/users/walterra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walterra/subscriptions","organizations_url":"https://api.github.com/users/walterra/orgs","repos_url":"https://api.github.com/users/walterra/repos","events_url":"https://api.github.com/users/walterra/events{/privacy}","received_events_url":"https://api.github.com/users/walterra/received_events","type":"User","site_admin":false},"body":"WORK IN PROGRESS\r\n\r\n## Summary\r\n\r\nAllows users to add/edit/delete annotations in the Single Series Viewer.\r\n\r\n![2018-11-21_annotations-simple-workflow](https://user-images.githubusercontent.com/230104/48849187-19eb3880-eda6-11e8-86b5-1f1c78369b78.gif)\r\n\r\n### Checklist\r\n\r\nUse ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.\r\n\r\n- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)\r\n- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)\r\n- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials\r\n- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios\r\n- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)\r\n- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)\r\n\r\n----\r\n\r\nPart of https://github.com/elastic/elasticsearch/issues/33376 and https://github.com/elastic/kibana/issues/25856.\r\n\r\n","created_at":"2018-11-21T17:12:02Z","updated_at":"2018-12-11T10:58:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a601be92001ac66141f4ebe420f768449b20f9f","assignee":{"login":"walterra","id":230104,"node_id":"MDQ6VXNlcjIzMDEwNA==","avatar_url":"https://avatars3.githubusercontent.com/u/230104?v=4","gravatar_id":"","url":"https://api.github.com/users/walterra","html_url":"https://github.com/walterra","followers_url":"https://api.github.com/users/walterra/followers","following_url":"https://api.github.com/users/walterra/following{/other_user}","gists_url":"https://api.github.com/users/walterra/gists{/gist_id}","starred_url":"https://api.github.com/users/walterra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walterra/subscriptions","organizations_url":"https://api.github.com/users/walterra/orgs","repos_url":"https://api.github.com/users/walterra/repos","events_url":"https://api.github.com/users/walterra/events{/privacy}","received_events_url":"https://api.github.com/users/walterra/received_events","type":"User","site_admin":false},"assignees":[{"login":"walterra","id":230104,"node_id":"MDQ6VXNlcjIzMDEwNA==","avatar_url":"https://avatars3.githubusercontent.com/u/230104?v=4","gravatar_id":"","url":"https://api.github.com/users/walterra","html_url":"https://github.com/walterra","followers_url":"https://api.github.com/users/walterra/followers","following_url":"https://api.github.com/users/walterra/following{/other_user}","gists_url":"https://api.github.com/users/walterra/gists{/gist_id}","starred_url":"https://api.github.com/users/walterra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walterra/subscriptions","organizations_url":"https://api.github.com/users/walterra/orgs","repos_url":"https://api.github.com/users/walterra/repos","events_url":"https://api.github.com/users/walterra/events{/privacy}","received_events_url":"https://api.github.com/users/walterra/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":912943303,"node_id":"MDU6TGFiZWw5MTI5NDMzMDM=","url":"https://api.github.com/repos/elastic/kibana/labels/:ml","name":":ml","color":"0e8a16","default":false},{"id":912944483,"node_id":"MDU6TGFiZWw5MTI5NDQ0ODM=","url":"https://api.github.com/repos/elastic/kibana/labels/:ml-results","name":":ml-results","color":"0e8a16","default":false},{"id":409457688,"node_id":"MDU6TGFiZWw0MDk0NTc2ODg=","url":"https://api.github.com/repos/elastic/kibana/labels/WIP","name":"WIP","color":"fef2c0","default":false},{"id":1062169267,"node_id":"MDU6TGFiZWwxMDYyMTY5MjY3","url":"https://api.github.com/repos/elastic/kibana/labels/v6.6.0","name":"v6.6.0","color":"ffffff","default":false},{"id":654061976,"node_id":"MDU6TGFiZWw2NTQwNjE5NzY=","url":"https://api.github.com/repos/elastic/kibana/labels/v7.0.0","name":"v7.0.0","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/26034/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/26034/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/26034/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/2278c272b7a3f07fdf3841c44bfd0198653a55a9","head":{"label":"walterra:ml-annotations","ref":"ml-annotations","sha":"2278c272b7a3f07fdf3841c44bfd0198653a55a9","user":{"login":"walterra","id":230104,"node_id":"MDQ6VXNlcjIzMDEwNA==","avatar_url":"https://avatars3.githubusercontent.com/u/230104?v=4","gravatar_id":"","url":"https://api.github.com/users/walterra","html_url":"https://github.com/walterra","followers_url":"https://api.github.com/users/walterra/followers","following_url":"https://api.github.com/users/walterra/following{/other_user}","gists_url":"https://api.github.com/users/walterra/gists{/gist_id}","starred_url":"https://api.github.com/users/walterra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walterra/subscriptions","organizations_url":"https://api.github.com/users/walterra/orgs","repos_url":"https://api.github.com/users/walterra/repos","events_url":"https://api.github.com/users/walterra/events{/privacy}","received_events_url":"https://api.github.com/users/walterra/received_events","type":"User","site_admin":false},"repo":{"id":99786588,"node_id":"MDEwOlJlcG9zaXRvcnk5OTc4NjU4OA==","name":"kibana","full_name":"walterra/kibana","private":false,"owner":{"login":"walterra","id":230104,"node_id":"MDQ6VXNlcjIzMDEwNA==","avatar_url":"https://avatars3.githubusercontent.com/u/230104?v=4","gravatar_id":"","url":"https://api.github.com/users/walterra","html_url":"https://github.com/walterra","followers_url":"https://api.github.com/users/walterra/followers","following_url":"https://api.github.com/users/walterra/following{/other_user}","gists_url":"https://api.github.com/users/walterra/gists{/gist_id}","starred_url":"https://api.github.com/users/walterra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walterra/subscriptions","organizations_url":"https://api.github.com/users/walterra/orgs","repos_url":"https://api.github.com/users/walterra/repos","events_url":"https://api.github.com/users/walterra/events{/privacy}","received_events_url":"https://api.github.com/users/walterra/received_events","type":"User","site_admin":false},"html_url":"https://github.com/walterra/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":true,"url":"https://api.github.com/repos/walterra/kibana","forks_url":"https://api.github.com/repos/walterra/kibana/forks","keys_url":"https://api.github.com/repos/walterra/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/walterra/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/walterra/kibana/teams","hooks_url":"https://api.github.com/repos/walterra/kibana/hooks","issue_events_url":"https://api.github.com/repos/walterra/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/walterra/kibana/events","assignees_url":"https://api.github.com/repos/walterra/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/walterra/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/walterra/kibana/tags","blobs_url":"https://api.github.com/repos/walterra/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/walterra/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/walterra/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/walterra/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/walterra/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/walterra/kibana/languages","stargazers_url":"https://api.github.com/repos/walterra/kibana/stargazers","contributors_url":"https://api.github.com/repos/walterra/kibana/contributors","subscribers_url":"https://api.github.com/repos/walterra/kibana/subscribers","subscription_url":"https://api.github.com/repos/walterra/kibana/subscription","commits_url":"https://api.github.com/repos/walterra/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/walterra/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/walterra/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/walterra/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/walterra/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/walterra/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/walterra/kibana/merges","archive_url":"https://api.github.com/repos/walterra/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/walterra/kibana/downloads","issues_url":"https://api.github.com/repos/walterra/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/walterra/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/walterra/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/walterra/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/walterra/kibana/labels{/name}","releases_url":"https://api.github.com/repos/walterra/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/walterra/kibana/deployments","created_at":"2017-08-09T08:54:30Z","updated_at":"2018-12-05T18:27:41Z","pushed_at":"2018-12-11T10:56:11Z","git_url":"git://github.com/walterra/kibana.git","ssh_url":"git@github.com:walterra/kibana.git","clone_url":"https://github.com/walterra/kibana.git","svn_url":"https://github.com/walterra/kibana","homepage":"https://www.elastic.co/products/kibana","size":503932,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"303d16a169dd95ef1fe59070539d0b4531c8a105","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"node_id":"MDEwOlJlcG9zaXRvcnk3ODMzMTY4","name":"kibana","full_name":"elastic/kibana","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2018-12-11T10:43:42Z","pushed_at":"2018-12-11T10:56:14Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":528691,"stargazers_count":10633,"watchers_count":10633,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4147,"mirror_url":null,"archived":false,"open_issues_count":3839,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4147,"open_issues":3839,"watchers":10633,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/26034"},"html":{"href":"https://github.com/elastic/kibana/pull/26034"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/26034"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/26034/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/26034/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/26034/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/2278c272b7a3f07fdf3841c44bfd0198653a55a9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"walterra"}}