{"action":"created","comment":{"url":"https://api.github.com/repos/hyrise/hyrise/pulls/comments/223221007","pull_request_review_id":162297618,"id":223221007,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzIyMTAwNw==","diff_hunk":"@@ -191,21 +196,31 @@ TpchDbGenerator::TpchDbGenerator(float scale_factor, uint32_t chunk_size)\n     : _scale_factor(scale_factor), _chunk_size(chunk_size) {}\n \n std::unordered_map<TpchTable, std::shared_ptr<Table>> TpchDbGenerator::generate() {\n-  TableBuilder customer_builder{_chunk_size, customer_column_types, customer_column_names, UseMvcc::Yes};\n-  TableBuilder order_builder{_chunk_size, order_column_types, order_column_names, UseMvcc::Yes};\n-  TableBuilder lineitem_builder{_chunk_size, lineitem_column_types, lineitem_column_names, UseMvcc::Yes};\n-  TableBuilder part_builder{_chunk_size, part_column_types, part_column_names, UseMvcc::Yes};\n-  TableBuilder partsupp_builder{_chunk_size, partsupp_column_types, partsupp_column_names, UseMvcc::Yes};\n-  TableBuilder supplier_builder{_chunk_size, supplier_column_types, supplier_column_names, UseMvcc::Yes};\n-  TableBuilder nation_builder{_chunk_size, nation_column_types, nation_column_names, UseMvcc::Yes};\n-  TableBuilder region_builder{_chunk_size, region_column_types, region_column_names, UseMvcc::Yes};\n+  const auto customer_count = static_cast<size_t>(tdefs[CUST].base * _scale_factor);\n+  const auto order_count = static_cast<size_t>(tdefs[ORDER].base * _scale_factor);\n+  const auto part_count = static_cast<size_t>(tdefs[PART].base * _scale_factor);\n+  const auto supplier_count = static_cast<size_t>(tdefs[SUPP].base * _scale_factor);\n+  const auto nation_count = static_cast<size_t>(tdefs[NATION].base);\n+  const auto region_count = static_cast<size_t>(tdefs[REGION].base);\n+\n+  TableBuilder customer_builder{_chunk_size, customer_column_types, customer_column_names, UseMvcc::Yes,\n+                                customer_count};\n+  TableBuilder order_builder{_chunk_size, order_column_types, order_column_names, UseMvcc::Yes, order_count};\n+  TableBuilder lineitem_builder{_chunk_size, lineitem_column_types, lineitem_column_names, UseMvcc::Yes,\n+                                order_count * 4};","path":"src/benchmarklib/tpch/tpch_db_generator.cpp","position":61,"original_position":60,"commit_id":"acf2d23751949465166c1cd50fe5a85f64b384d6","original_commit_id":"fd04fb7a6790c4924c6f923a00d107dab9ca2df9","user":{"login":"mrks","id":575106,"node_id":"MDQ6VXNlcjU3NTEwNg==","avatar_url":"https://avatars2.githubusercontent.com/u/575106?v=4","gravatar_id":"","url":"https://api.github.com/users/mrks","html_url":"https://github.com/mrks","followers_url":"https://api.github.com/users/mrks/followers","following_url":"https://api.github.com/users/mrks/following{/other_user}","gists_url":"https://api.github.com/users/mrks/gists{/gist_id}","starred_url":"https://api.github.com/users/mrks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrks/subscriptions","organizations_url":"https://api.github.com/users/mrks/orgs","repos_url":"https://api.github.com/users/mrks/repos","events_url":"https://api.github.com/users/mrks/events{/privacy}","received_events_url":"https://api.github.com/users/mrks/received_events","type":"User","site_admin":false},"body":"Not sure how to call that constant. It is a number by which the row count is multiplied and is defined as such in the TPC-H. I added a comment explaining that.","created_at":"2018-10-07T17:15:58Z","updated_at":"2018-10-07T17:15:58Z","html_url":"https://github.com/hyrise/hyrise/pull/1163#discussion_r223221007","pull_request_url":"https://api.github.com/repos/hyrise/hyrise/pulls/1163","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/hyrise/hyrise/pulls/comments/223221007"},"html":{"href":"https://github.com/hyrise/hyrise/pull/1163#discussion_r223221007"},"pull_request":{"href":"https://api.github.com/repos/hyrise/hyrise/pulls/1163"}},"in_reply_to_id":223220336},"pull_request":{"url":"https://api.github.com/repos/hyrise/hyrise/pulls/1163","id":220430398,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNDMwMzk4","html_url":"https://github.com/hyrise/hyrise/pull/1163","diff_url":"https://github.com/hyrise/hyrise/pull/1163.diff","patch_url":"https://github.com/hyrise/hyrise/pull/1163.patch","issue_url":"https://api.github.com/repos/hyrise/hyrise/issues/1163","number":1163,"state":"open","locked":false,"title":"Small performance improvements","user":{"login":"mrks","id":575106,"node_id":"MDQ6VXNlcjU3NTEwNg==","avatar_url":"https://avatars2.githubusercontent.com/u/575106?v=4","gravatar_id":"","url":"https://api.github.com/users/mrks","html_url":"https://github.com/mrks","followers_url":"https://api.github.com/users/mrks/followers","following_url":"https://api.github.com/users/mrks/following{/other_user}","gists_url":"https://api.github.com/users/mrks/gists{/gist_id}","starred_url":"https://api.github.com/users/mrks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrks/subscriptions","organizations_url":"https://api.github.com/users/mrks/orgs","repos_url":"https://api.github.com/users/mrks/repos","events_url":"https://api.github.com/users/mrks/events{/privacy}","received_events_url":"https://api.github.com/users/mrks/received_events","type":"User","site_admin":false},"body":"... couple of things I found in the profiler:\r\n\r\nSort: Reserve vector\r\nTPC-H generator: reserve space\r\nAggregate: reserve space before writing vector\r\nChunkOffsetMapping: Replace map by vector\r\nreplace murmur hash with std::hash after discussion with @Bouncner and finding that it does not improve the performance or the hash quality. Less code is always a good thing.\r\n\r\n```\r\n Benchmark | prev. iter/s | new iter/s | change\r\n-----------+--------------+------------+---------------\r\n TPC-H 1   | 3.808        | 3.821      | +0%\r\n TPC-H 2   | 89.732       | 92.27      | +3%\r\n TPC-H 3   | 39.409       | 40.101     | +2%\r\n TPC-H 4   | 16.387       | 16.897     | +3%\r\n TPC-H 5   | 26.012       | 27.707     | +7%\r\n TPC-H 6   | 60.353       | 81.409     | +35%\r\n TPC-H 7   | 7.564        | 9.184      | +21%\r\n TPC-H 8   | 33.835       | 36.258     | +7%\r\n TPC-H 9   | 16.567       | 16.24      | -2%\r\n TPC-H 10  | 21.306       | 21.832     | +2%\r\n TPC-H 11  | 118.809      | 123.5      | +4%\r\n TPC-H 12  | 35.046       | 40.904     | +17%\r\n TPC-H 13  | 24.746       | 24.445     | -1%\r\n TPC-H 14  | 86.308       | 111.459    | +29%\r\n TPC-H 15  | 40.739       | 59.588     | +46%\r\n TPC-H 16  | 17.256       | 17.511     | +1%\r\n TPC-H 17  | 4.384        | 4.322      | -1%\r\n TPC-H 18  | 3.351        | 3.842      | +15%\r\n TPC-H 19  | 2.426        | 2.463      | +2%\r\n TPC-H 20  | 0.031        | 0.031      | +0%\r\n TPC-H 21  | 0.293        | 0.39       | +33%\r\n TPC-H 22  | 49.897       | 50.574     | +1%\r\n average   |              |            | +10%\r\n\r\n```","created_at":"2018-10-04T15:55:11Z","updated_at":"2018-10-07T17:15:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26440ead485b2b2f619249174345a2ef1469d8cb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":978421305,"node_id":"MDU6TGFiZWw5Nzg0MjEzMDU=","url":"https://api.github.com/repos/hyrise/hyrise/labels/FullCI","name":"FullCI","color":"02ef0e","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hyrise/hyrise/pulls/1163/commits","review_comments_url":"https://api.github.com/repos/hyrise/hyrise/pulls/1163/comments","review_comment_url":"https://api.github.com/repos/hyrise/hyrise/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyrise/hyrise/issues/1163/comments","statuses_url":"https://api.github.com/repos/hyrise/hyrise/statuses/acf2d23751949465166c1cd50fe5a85f64b384d6","head":{"label":"hyrise:mrks/abitofspeed","ref":"mrks/abitofspeed","sha":"acf2d23751949465166c1cd50fe5a85f64b384d6","user":{"login":"hyrise","id":3465095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NjUwOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/3465095?v=4","gravatar_id":"","url":"https://api.github.com/users/hyrise","html_url":"https://github.com/hyrise","followers_url":"https://api.github.com/users/hyrise/followers","following_url":"https://api.github.com/users/hyrise/following{/other_user}","gists_url":"https://api.github.com/users/hyrise/gists{/gist_id}","starred_url":"https://api.github.com/users/hyrise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyrise/subscriptions","organizations_url":"https://api.github.com/users/hyrise/orgs","repos_url":"https://api.github.com/users/hyrise/repos","events_url":"https://api.github.com/users/hyrise/events{/privacy}","received_events_url":"https://api.github.com/users/hyrise/received_events","type":"Organization","site_admin":false},"repo":{"id":87414843,"node_id":"MDEwOlJlcG9zaXRvcnk4NzQxNDg0Mw==","name":"hyrise","full_name":"hyrise/hyrise","private":false,"owner":{"login":"hyrise","id":3465095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NjUwOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/3465095?v=4","gravatar_id":"","url":"https://api.github.com/users/hyrise","html_url":"https://github.com/hyrise","followers_url":"https://api.github.com/users/hyrise/followers","following_url":"https://api.github.com/users/hyrise/following{/other_user}","gists_url":"https://api.github.com/users/hyrise/gists{/gist_id}","starred_url":"https://api.github.com/users/hyrise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyrise/subscriptions","organizations_url":"https://api.github.com/users/hyrise/orgs","repos_url":"https://api.github.com/users/hyrise/repos","events_url":"https://api.github.com/users/hyrise/events{/privacy}","received_events_url":"https://api.github.com/users/hyrise/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hyrise/hyrise","description":"Hyrise is a research in-memory database.","fork":false,"url":"https://api.github.com/repos/hyrise/hyrise","forks_url":"https://api.github.com/repos/hyrise/hyrise/forks","keys_url":"https://api.github.com/repos/hyrise/hyrise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyrise/hyrise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyrise/hyrise/teams","hooks_url":"https://api.github.com/repos/hyrise/hyrise/hooks","issue_events_url":"https://api.github.com/repos/hyrise/hyrise/issues/events{/number}","events_url":"https://api.github.com/repos/hyrise/hyrise/events","assignees_url":"https://api.github.com/repos/hyrise/hyrise/assignees{/user}","branches_url":"https://api.github.com/repos/hyrise/hyrise/branches{/branch}","tags_url":"https://api.github.com/repos/hyrise/hyrise/tags","blobs_url":"https://api.github.com/repos/hyrise/hyrise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyrise/hyrise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyrise/hyrise/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyrise/hyrise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyrise/hyrise/statuses/{sha}","languages_url":"https://api.github.com/repos/hyrise/hyrise/languages","stargazers_url":"https://api.github.com/repos/hyrise/hyrise/stargazers","contributors_url":"https://api.github.com/repos/hyrise/hyrise/contributors","subscribers_url":"https://api.github.com/repos/hyrise/hyrise/subscribers","subscription_url":"https://api.github.com/repos/hyrise/hyrise/subscription","commits_url":"https://api.github.com/repos/hyrise/hyrise/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyrise/hyrise/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyrise/hyrise/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyrise/hyrise/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyrise/hyrise/contents/{+path}","compare_url":"https://api.github.com/repos/hyrise/hyrise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyrise/hyrise/merges","archive_url":"https://api.github.com/repos/hyrise/hyrise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyrise/hyrise/downloads","issues_url":"https://api.github.com/repos/hyrise/hyrise/issues{/number}","pulls_url":"https://api.github.com/repos/hyrise/hyrise/pulls{/number}","milestones_url":"https://api.github.com/repos/hyrise/hyrise/milestones{/number}","notifications_url":"https://api.github.com/repos/hyrise/hyrise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyrise/hyrise/labels{/name}","releases_url":"https://api.github.com/repos/hyrise/hyrise/releases{/id}","deployments_url":"https://api.github.com/repos/hyrise/hyrise/deployments","created_at":"2017-04-06T10:03:31Z","updated_at":"2018-10-07T01:25:00Z","pushed_at":"2018-10-07T17:15:26Z","git_url":"git://github.com/hyrise/hyrise.git","ssh_url":"git@github.com:hyrise/hyrise.git","clone_url":"https://github.com/hyrise/hyrise.git","svn_url":"https://github.com/hyrise/hyrise","homepage":"https://hpi.de/plattner/projects/hyrise.html","size":29812,"stargazers_count":114,"watchers_count":114,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":30,"open_issues":76,"watchers":114,"default_branch":"master"}},"base":{"label":"hyrise:master","ref":"master","sha":"9d0ba702ba9dd9e2da4f0409fe33190d17d21341","user":{"login":"hyrise","id":3465095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NjUwOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/3465095?v=4","gravatar_id":"","url":"https://api.github.com/users/hyrise","html_url":"https://github.com/hyrise","followers_url":"https://api.github.com/users/hyrise/followers","following_url":"https://api.github.com/users/hyrise/following{/other_user}","gists_url":"https://api.github.com/users/hyrise/gists{/gist_id}","starred_url":"https://api.github.com/users/hyrise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyrise/subscriptions","organizations_url":"https://api.github.com/users/hyrise/orgs","repos_url":"https://api.github.com/users/hyrise/repos","events_url":"https://api.github.com/users/hyrise/events{/privacy}","received_events_url":"https://api.github.com/users/hyrise/received_events","type":"Organization","site_admin":false},"repo":{"id":87414843,"node_id":"MDEwOlJlcG9zaXRvcnk4NzQxNDg0Mw==","name":"hyrise","full_name":"hyrise/hyrise","private":false,"owner":{"login":"hyrise","id":3465095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NjUwOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/3465095?v=4","gravatar_id":"","url":"https://api.github.com/users/hyrise","html_url":"https://github.com/hyrise","followers_url":"https://api.github.com/users/hyrise/followers","following_url":"https://api.github.com/users/hyrise/following{/other_user}","gists_url":"https://api.github.com/users/hyrise/gists{/gist_id}","starred_url":"https://api.github.com/users/hyrise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyrise/subscriptions","organizations_url":"https://api.github.com/users/hyrise/orgs","repos_url":"https://api.github.com/users/hyrise/repos","events_url":"https://api.github.com/users/hyrise/events{/privacy}","received_events_url":"https://api.github.com/users/hyrise/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hyrise/hyrise","description":"Hyrise is a research in-memory database.","fork":false,"url":"https://api.github.com/repos/hyrise/hyrise","forks_url":"https://api.github.com/repos/hyrise/hyrise/forks","keys_url":"https://api.github.com/repos/hyrise/hyrise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyrise/hyrise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyrise/hyrise/teams","hooks_url":"https://api.github.com/repos/hyrise/hyrise/hooks","issue_events_url":"https://api.github.com/repos/hyrise/hyrise/issues/events{/number}","events_url":"https://api.github.com/repos/hyrise/hyrise/events","assignees_url":"https://api.github.com/repos/hyrise/hyrise/assignees{/user}","branches_url":"https://api.github.com/repos/hyrise/hyrise/branches{/branch}","tags_url":"https://api.github.com/repos/hyrise/hyrise/tags","blobs_url":"https://api.github.com/repos/hyrise/hyrise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyrise/hyrise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyrise/hyrise/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyrise/hyrise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyrise/hyrise/statuses/{sha}","languages_url":"https://api.github.com/repos/hyrise/hyrise/languages","stargazers_url":"https://api.github.com/repos/hyrise/hyrise/stargazers","contributors_url":"https://api.github.com/repos/hyrise/hyrise/contributors","subscribers_url":"https://api.github.com/repos/hyrise/hyrise/subscribers","subscription_url":"https://api.github.com/repos/hyrise/hyrise/subscription","commits_url":"https://api.github.com/repos/hyrise/hyrise/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyrise/hyrise/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyrise/hyrise/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyrise/hyrise/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyrise/hyrise/contents/{+path}","compare_url":"https://api.github.com/repos/hyrise/hyrise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyrise/hyrise/merges","archive_url":"https://api.github.com/repos/hyrise/hyrise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyrise/hyrise/downloads","issues_url":"https://api.github.com/repos/hyrise/hyrise/issues{/number}","pulls_url":"https://api.github.com/repos/hyrise/hyrise/pulls{/number}","milestones_url":"https://api.github.com/repos/hyrise/hyrise/milestones{/number}","notifications_url":"https://api.github.com/repos/hyrise/hyrise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyrise/hyrise/labels{/name}","releases_url":"https://api.github.com/repos/hyrise/hyrise/releases{/id}","deployments_url":"https://api.github.com/repos/hyrise/hyrise/deployments","created_at":"2017-04-06T10:03:31Z","updated_at":"2018-10-07T01:25:00Z","pushed_at":"2018-10-07T17:15:26Z","git_url":"git://github.com/hyrise/hyrise.git","ssh_url":"git@github.com:hyrise/hyrise.git","clone_url":"https://github.com/hyrise/hyrise.git","svn_url":"https://github.com/hyrise/hyrise","homepage":"https://hpi.de/plattner/projects/hyrise.html","size":29812,"stargazers_count":114,"watchers_count":114,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":30,"open_issues":76,"watchers":114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyrise/hyrise/pulls/1163"},"html":{"href":"https://github.com/hyrise/hyrise/pull/1163"},"issue":{"href":"https://api.github.com/repos/hyrise/hyrise/issues/1163"},"comments":{"href":"https://api.github.com/repos/hyrise/hyrise/issues/1163/comments"},"review_comments":{"href":"https://api.github.com/repos/hyrise/hyrise/pulls/1163/comments"},"review_comment":{"href":"https://api.github.com/repos/hyrise/hyrise/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyrise/hyrise/pulls/1163/commits"},"statuses":{"href":"https://api.github.com/repos/hyrise/hyrise/statuses/acf2d23751949465166c1cd50fe5a85f64b384d6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mrks"}}