{"action":"created","issue":{"url":"https://api.github.com/repos/pact-foundation/pact-js/issues/147","repository_url":"https://api.github.com/repos/pact-foundation/pact-js","labels_url":"https://api.github.com/repos/pact-foundation/pact-js/issues/147/labels{/name}","comments_url":"https://api.github.com/repos/pact-foundation/pact-js/issues/147/comments","events_url":"https://api.github.com/repos/pact-foundation/pact-js/issues/147/events","html_url":"https://github.com/pact-foundation/pact-js/pull/147","id":293050101,"number":147,"title":"using Popsicle for cross node/browser requests","user":{"login":"mboudreau","id":573668,"avatar_url":"https://avatars3.githubusercontent.com/u/573668?v=4","gravatar_id":"","url":"https://api.github.com/users/mboudreau","html_url":"https://github.com/mboudreau","followers_url":"https://api.github.com/users/mboudreau/followers","following_url":"https://api.github.com/users/mboudreau/following{/other_user}","gists_url":"https://api.github.com/users/mboudreau/gists{/gist_id}","starred_url":"https://api.github.com/users/mboudreau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mboudreau/subscriptions","organizations_url":"https://api.github.com/users/mboudreau/orgs","repos_url":"https://api.github.com/users/mboudreau/repos","events_url":"https://api.github.com/users/mboudreau/events{/privacy}","received_events_url":"https://api.github.com/users/mboudreau/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-01-31T06:56:03Z","updated_at":"2018-02-04T22:48:17Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/pact-foundation/pact-js/pulls/147","html_url":"https://github.com/pact-foundation/pact-js/pull/147","diff_url":"https://github.com/pact-foundation/pact-js/pull/147.diff","patch_url":"https://github.com/pact-foundation/pact-js/pull/147.patch"},"body":"seems to work fine, need to refactor tests, but frankly, not sure if we actually need tests for the requests since they are already tested from the library.  Might need more integration like tests with pact though."},"comment":{"url":"https://api.github.com/repos/pact-foundation/pact-js/issues/comments/362947037","html_url":"https://github.com/pact-foundation/pact-js/pull/147#issuecomment-362947037","issue_url":"https://api.github.com/repos/pact-foundation/pact-js/issues/147","id":362947037,"user":{"login":"mefellows","id":53900,"avatar_url":"https://avatars1.githubusercontent.com/u/53900?v=4","gravatar_id":"","url":"https://api.github.com/users/mefellows","html_url":"https://github.com/mefellows","followers_url":"https://api.github.com/users/mefellows/followers","following_url":"https://api.github.com/users/mefellows/following{/other_user}","gists_url":"https://api.github.com/users/mefellows/gists{/gist_id}","starred_url":"https://api.github.com/users/mefellows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mefellows/subscriptions","organizations_url":"https://api.github.com/users/mefellows/orgs","repos_url":"https://api.github.com/users/mefellows/repos","events_url":"https://api.github.com/users/mefellows/events{/privacy}","received_events_url":"https://api.github.com/users/mefellows/received_events","type":"User","site_admin":false},"created_at":"2018-02-04T22:48:17Z","updated_at":"2018-02-04T22:48:17Z","author_association":"OWNER","body":"It's a very good point. I'm not sure how we dealt with it using `XMLHttpRequest`, if at all.\r\n\r\nBecause it would have been running in a browser, presumably it would require user input/overriding in session, something that I can't see being allowed in code, because that would mean any in-browser security attacks could privilege escalate.\r\n\r\nMy guess is that some flag (e.g. `--ignore-ssl-errors`) would need to be provided to the running browser via a configuration (e.g. karma config)."}}
{"actor":{"display_login":"mefellows"}}