{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66617","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66617/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66617/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66617/events","html_url":"https://github.com/kubernetes/kubernetes/pull/66617","id":344534519,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzOTA3MjUy","number":66617,"title":"Do not set cgroup parent when --cgroups-per-qos is disabled","user":{"login":"pravisankar","id":1258630,"node_id":"MDQ6VXNlcjEyNTg2MzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1258630?v=4","gravatar_id":"","url":"https://api.github.com/users/pravisankar","html_url":"https://github.com/pravisankar","followers_url":"https://api.github.com/users/pravisankar/followers","following_url":"https://api.github.com/users/pravisankar/following{/other_user}","gists_url":"https://api.github.com/users/pravisankar/gists{/gist_id}","starred_url":"https://api.github.com/users/pravisankar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pravisankar/subscriptions","organizations_url":"https://api.github.com/users/pravisankar/orgs","repos_url":"https://api.github.com/users/pravisankar/repos","events_url":"https://api.github.com/users/pravisankar/events{/privacy}","received_events_url":"https://api.github.com/users/pravisankar/received_events","type":"User","site_admin":false},"labels":[{"id":477397085,"node_id":"MDU6TGFiZWw0NzczOTcwODU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20no","name":"cncf-cla: no","color":"e11d21","default":false},{"id":680152113,"node_id":"MDU6TGFiZWw2ODAxNTIxMTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/release-note-label-needed","name":"do-not-merge/release-note-label-needed","color":"e11d21","default":false},{"id":573014062,"node_id":"MDU6TGFiZWw1NzMwMTQwNjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":253450793,"node_id":"MDU6TGFiZWwyNTM0NTA3OTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-07-25T17:21:14Z","updated_at":"2018-07-25T18:21:30Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/66617","html_url":"https://github.com/kubernetes/kubernetes/pull/66617","diff_url":"https://github.com/kubernetes/kubernetes/pull/66617.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/66617.patch"},"body":"When --cgroups-per-qos=false (default is true), kubelet sets pod\r\ncontainer management to podContainerManagerNoop implementation and\r\nGetPodContainerName() returns '/' as cgroup parent (default cgroup root).\r\n\r\n(1) In case of 'systemd' cgroup driver, '/' is invalid parent as\r\ndocker daemon expects '.slice' suffix and throws this error:\r\n'cgroup-parent for systemd cgroup should be a valid slice named as \\\"xxx.slice\\\"'\r\n(https://github.com/moby/moby/blob/5fc12449d830ae9005138fb3d3782728fa8d137a/daemon/daemon_unix.go#L618)\r\n'/' corresponds to '-.slice' (root slice) in systemd but I don't think\r\nwe want to assign root slice instead of runtime specific default value.\r\nIn case of docker runtime, this will be 'system.slice'\r\n(https://github.com/moby/moby/blob/e2593239d949eee454935daea7a5fe025477322f/daemon/oci_linux.go#L698)\r\n\r\n(2) In case of 'cgroupfs' cgroup driver, '/' is valid parent but I don't\r\nthink we want to assign root instead of runtime specific default value.\r\nIn case of docker runtime, this will be '/docker'\r\n(https://github.com/moby/moby/blob/e2593239d949eee454935daea7a5fe025477322f/daemon/oci_linux.go#L695)\r\n\r\nCurrent fix will not set the cgroup parent when --cgroups-per-qos is disabled."},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/407849244","html_url":"https://github.com/kubernetes/kubernetes/pull/66617#issuecomment-407849244","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66617","id":407849244,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzg0OTI0NA==","user":{"login":"pravisankar","id":1258630,"node_id":"MDQ6VXNlcjEyNTg2MzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1258630?v=4","gravatar_id":"","url":"https://api.github.com/users/pravisankar","html_url":"https://github.com/pravisankar","followers_url":"https://api.github.com/users/pravisankar/followers","following_url":"https://api.github.com/users/pravisankar/following{/other_user}","gists_url":"https://api.github.com/users/pravisankar/gists{/gist_id}","starred_url":"https://api.github.com/users/pravisankar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pravisankar/subscriptions","organizations_url":"https://api.github.com/users/pravisankar/orgs","repos_url":"https://api.github.com/users/pravisankar/repos","events_url":"https://api.github.com/users/pravisankar/events{/privacy}","received_events_url":"https://api.github.com/users/pravisankar/received_events","type":"User","site_admin":false},"created_at":"2018-07-25T18:21:29Z","updated_at":"2018-07-25T18:21:29Z","author_association":"CONTRIBUTOR","body":"@dcbw @knobunc @imcsk8 @derekwaynecarr @dubstack PTAL"}}
{"actor":{"display_login":"pravisankar"}}