{"action":"closed","issue":{"url":"https://api.github.com/repos/intel/nemu/issues/129","repository_url":"https://api.github.com/repos/intel/nemu","labels_url":"https://api.github.com/repos/intel/nemu/issues/129/labels{/name}","comments_url":"https://api.github.com/repos/intel/nemu/issues/129/comments","events_url":"https://api.github.com/repos/intel/nemu/issues/129/events","html_url":"https://github.com/intel/nemu/issues/129","id":368095514,"node_id":"MDU6SXNzdWUzNjgwOTU1MTQ=","number":129,"title":"SMBIOS for virt ","user":{"login":"liujing2","id":39684649,"node_id":"MDQ6VXNlcjM5Njg0NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/39684649?v=4","gravatar_id":"","url":"https://api.github.com/users/liujing2","html_url":"https://github.com/liujing2","followers_url":"https://api.github.com/users/liujing2/followers","following_url":"https://api.github.com/users/liujing2/following{/other_user}","gists_url":"https://api.github.com/users/liujing2/gists{/gist_id}","starred_url":"https://api.github.com/users/liujing2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liujing2/subscriptions","organizations_url":"https://api.github.com/users/liujing2/orgs","repos_url":"https://api.github.com/users/liujing2/repos","events_url":"https://api.github.com/users/liujing2/events{/privacy}","received_events_url":"https://api.github.com/users/liujing2/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-10-09T08:28:34Z","updated_at":"2018-10-12T13:15:12Z","closed_at":"2018-10-12T13:15:12Z","author_association":"COLLABORATOR","body":"@sameo @rbradford @yangzhon @mcastelino \r\nTwo key points in conclustion.\r\n1. Do we need open CONFIG_SMBIOS for virt platform in order to use DMI?\r\n1. If yes, there're 2 sub issues.\r\n    1. CONFIG_SMBIOS=y is set in default-configs/x86_64-softmmu.mak, but actually when hw/i386/fw.c fw_build_smbios() check it, it doesn't show as expect. So Nemu doesn't build smbios tables for guest and dmesg shows [    0.000000] DMI not present or invalid.\r\n    1. After fixing i by workaround, only q35 guest can show correct DMI dmesg, virt still shows [    0.000000] DMI not present or invalid. \r\n\r\n\r\n\r\n"}}
{"actor":{"display_login":"rbradford"}}