{"action":"created","issue":{"url":"https://api.github.com/repos/wcm-io-caravan/caravan-hal/issues/1","repository_url":"https://api.github.com/repos/wcm-io-caravan/caravan-hal","labels_url":"https://api.github.com/repos/wcm-io-caravan/caravan-hal/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/wcm-io-caravan/caravan-hal/issues/1/comments","events_url":"https://api.github.com/repos/wcm-io-caravan/caravan-hal/issues/1/events","html_url":"https://github.com/wcm-io-caravan/caravan-hal/pull/1","id":355712462,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMTc4MTYx","number":1,"title":"Introduce new bundle for recursive comparison of HalResources","user":{"login":"feffef","id":854328,"node_id":"MDQ6VXNlcjg1NDMyOA==","avatar_url":"https://avatars1.githubusercontent.com/u/854328?v=4","gravatar_id":"","url":"https://api.github.com/users/feffef","html_url":"https://github.com/feffef","followers_url":"https://api.github.com/users/feffef/followers","following_url":"https://api.github.com/users/feffef/following{/other_user}","gists_url":"https://api.github.com/users/feffef/gists{/gist_id}","starred_url":"https://api.github.com/users/feffef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feffef/subscriptions","organizations_url":"https://api.github.com/users/feffef/orgs","repos_url":"https://api.github.com/users/feffef/repos","events_url":"https://api.github.com/users/feffef/events{/privacy}","received_events_url":"https://api.github.com/users/feffef/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-30T18:57:11Z","updated_at":"2018-08-31T07:17:32Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/wcm-io-caravan/caravan-hal/pulls/1","html_url":"https://github.com/wcm-io-caravan/caravan-hal/pull/1","diff_url":"https://github.com/wcm-io-caravan/caravan-hal/pull/1.diff","patch_url":"https://github.com/wcm-io-caravan/caravan-hal/pull/1.patch"},"body":"Anyone wants to do a quick review of the API interfaces for a new HalComparison service?\r\n\r\nhttps://github.com/wcm-io-caravan/caravan-hal/tree/feature/hal-comparison/comparison/src/main/java/io/wcm/caravan/hal/comparison\r\n\r\nAnd maybe a critical look at the pom.xml:\r\nhttps://github.com/wcm-io-caravan/caravan-hal/blob/feature/hal-comparison/comparison/pom.xml\r\nI just copied it over from the hal.resource bundle and changed the dependencies where required (but I might have missed something or that file is outdated)"},"comment":{"url":"https://api.github.com/repos/wcm-io-caravan/caravan-hal/issues/comments/417575356","html_url":"https://github.com/wcm-io-caravan/caravan-hal/pull/1#issuecomment-417575356","issue_url":"https://api.github.com/repos/wcm-io-caravan/caravan-hal/issues/1","id":417575356,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzU3NTM1Ng==","user":{"login":"stefanseifert","id":5614031,"node_id":"MDQ6VXNlcjU2MTQwMzE=","avatar_url":"https://avatars1.githubusercontent.com/u/5614031?v=4","gravatar_id":"","url":"https://api.github.com/users/stefanseifert","html_url":"https://github.com/stefanseifert","followers_url":"https://api.github.com/users/stefanseifert/followers","following_url":"https://api.github.com/users/stefanseifert/following{/other_user}","gists_url":"https://api.github.com/users/stefanseifert/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanseifert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanseifert/subscriptions","organizations_url":"https://api.github.com/users/stefanseifert/orgs","repos_url":"https://api.github.com/users/stefanseifert/repos","events_url":"https://api.github.com/users/stefanseifert/events{/privacy}","received_events_url":"https://api.github.com/users/stefanseifert/received_events","type":"User","site_admin":false},"created_at":"2018-08-31T07:17:32Z","updated_at":"2018-08-31T07:17:32Z","author_association":"MEMBER","body":"i've had a format look on the POMs and API - feedback:\r\n* i recommend to start right-away with version 1.0.0 for bundle + exported packages\r\n* poms looks ok, i've included the new module in the HAL site index as well\r\n* i'm wondering why HalComparisonConfig is an interface with default methods - wouldn't it be clearer to use a real class e.g. with builder pattern for this? are there expected to be different implementations of this by the users of this module?"}}
{"actor":{"display_login":"stefanseifert"}}