{"action":"created","comment":{"url":"https://api.github.com/repos/telstra/open-kilda/pulls/comments/242896382","pull_request_review_id":186518870,"id":242896382,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mjg5NjM4Mg==","diff_hunk":"@@ -51,4 +52,20 @@ public RerouteService(RepositoryFactory repositoryFactory) {\n         log.info(\"Get inactive flow ids\");\n         return flowRepository.findDownFlowIds();\n     }\n+\n+    /**\n+     * Get all flow ids for a particular isl.\n+     *\n+     * @param srcSwitchId source switch id.\n+     * @param srcPort     source port.\n+     * @param dstSwitchId destination switch id.\n+     * @param dstPort     destination port.\n+     */\n+    public Collection<String> getAllFlowIdsForIsl(SwitchId srcSwitchId, int srcPort,\n+                                               SwitchId dstSwitchId, int dstPort) {\n+        log.info(\"Get inactive flow ids\");\n+        return flowRepository.findAllFlowPairsWithSegment(srcSwitchId, srcPort, dstSwitchId, dstPort).stream()","path":"services/wfm/src/main/java/org/openkilda/wfm/topology/reroute/service/RerouteService.java","position":24,"original_position":24,"commit_id":"6827dc64c90ded5f4add16b8229ce864b1d568a1","original_commit_id":"6827dc64c90ded5f4add16b8229ce864b1d568a1","user":{"login":"dpoltavets","id":40604500,"node_id":"MDQ6VXNlcjQwNjA0NTAw","avatar_url":"https://avatars1.githubusercontent.com/u/40604500?v=4","gravatar_id":"","url":"https://api.github.com/users/dpoltavets","html_url":"https://github.com/dpoltavets","followers_url":"https://api.github.com/users/dpoltavets/followers","following_url":"https://api.github.com/users/dpoltavets/following{/other_user}","gists_url":"https://api.github.com/users/dpoltavets/gists{/gist_id}","starred_url":"https://api.github.com/users/dpoltavets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpoltavets/subscriptions","organizations_url":"https://api.github.com/users/dpoltavets/orgs","repos_url":"https://api.github.com/users/dpoltavets/repos","events_url":"https://api.github.com/users/dpoltavets/events{/privacy}","received_events_url":"https://api.github.com/users/dpoltavets/received_events","type":"User","site_admin":false},"body":"I just used an existing method to search for a flow ids by ISL. And by code, we are searching flow ids over flow segments.","created_at":"2018-12-19T12:22:43Z","updated_at":"2018-12-19T12:22:43Z","html_url":"https://github.com/telstra/open-kilda/pull/1754#discussion_r242896382","pull_request_url":"https://api.github.com/repos/telstra/open-kilda/pulls/1754","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/telstra/open-kilda/pulls/comments/242896382"},"html":{"href":"https://github.com/telstra/open-kilda/pull/1754#discussion_r242896382"},"pull_request":{"href":"https://api.github.com/repos/telstra/open-kilda/pulls/1754"}},"in_reply_to_id":242846545},"pull_request":{"url":"https://api.github.com/repos/telstra/open-kilda/pulls/1754","id":238289767,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4Mjg5NzY3","html_url":"https://github.com/telstra/open-kilda/pull/1754","diff_url":"https://github.com/telstra/open-kilda/pull/1754.diff","patch_url":"https://github.com/telstra/open-kilda/pull/1754.patch","issue_url":"https://api.github.com/repos/telstra/open-kilda/issues/1754","number":1754,"state":"open","locked":false,"title":"#1548 Update logic for ISL with \"Under maintenance\" flag.","user":{"login":"dpoltavets","id":40604500,"node_id":"MDQ6VXNlcjQwNjA0NTAw","avatar_url":"https://avatars1.githubusercontent.com/u/40604500?v=4","gravatar_id":"","url":"https://api.github.com/users/dpoltavets","html_url":"https://github.com/dpoltavets","followers_url":"https://api.github.com/users/dpoltavets/followers","following_url":"https://api.github.com/users/dpoltavets/following{/other_user}","gists_url":"https://api.github.com/users/dpoltavets/gists{/gist_id}","starred_url":"https://api.github.com/users/dpoltavets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpoltavets/subscriptions","organizations_url":"https://api.github.com/users/dpoltavets/orgs","repos_url":"https://api.github.com/users/dpoltavets/repos","events_url":"https://api.github.com/users/dpoltavets/events{/privacy}","received_events_url":"https://api.github.com/users/dpoltavets/received_events","type":"User","site_admin":false},"body":"Part of issue: #1548.\r\n\r\nDepends on: #1742.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/telstra/open-kilda/1754)\r\n<!-- Reviewable:end -->\r\n","created_at":"2018-12-13T07:29:14Z","updated_at":"2018-12-19T12:22:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"078f39157a74a44812a78e52a08b5b9e15ac0984","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nikitacherevko","id":6116378,"node_id":"MDQ6VXNlcjYxMTYzNzg=","avatar_url":"https://avatars2.githubusercontent.com/u/6116378?v=4","gravatar_id":"","url":"https://api.github.com/users/nikitacherevko","html_url":"https://github.com/nikitacherevko","followers_url":"https://api.github.com/users/nikitacherevko/followers","following_url":"https://api.github.com/users/nikitacherevko/following{/other_user}","gists_url":"https://api.github.com/users/nikitacherevko/gists{/gist_id}","starred_url":"https://api.github.com/users/nikitacherevko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikitacherevko/subscriptions","organizations_url":"https://api.github.com/users/nikitacherevko/orgs","repos_url":"https://api.github.com/users/nikitacherevko/repos","events_url":"https://api.github.com/users/nikitacherevko/events{/privacy}","received_events_url":"https://api.github.com/users/nikitacherevko/received_events","type":"User","site_admin":false},{"login":"sergii-iakovenko","id":7511304,"node_id":"MDQ6VXNlcjc1MTEzMDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7511304?v=4","gravatar_id":"","url":"https://api.github.com/users/sergii-iakovenko","html_url":"https://github.com/sergii-iakovenko","followers_url":"https://api.github.com/users/sergii-iakovenko/followers","following_url":"https://api.github.com/users/sergii-iakovenko/following{/other_user}","gists_url":"https://api.github.com/users/sergii-iakovenko/gists{/gist_id}","starred_url":"https://api.github.com/users/sergii-iakovenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergii-iakovenko/subscriptions","organizations_url":"https://api.github.com/users/sergii-iakovenko/orgs","repos_url":"https://api.github.com/users/sergii-iakovenko/repos","events_url":"https://api.github.com/users/sergii-iakovenko/events{/privacy}","received_events_url":"https://api.github.com/users/sergii-iakovenko/received_events","type":"User","site_admin":false},{"login":"IlyaMoiseev","id":13030795,"node_id":"MDQ6VXNlcjEzMDMwNzk1","avatar_url":"https://avatars1.githubusercontent.com/u/13030795?v=4","gravatar_id":"","url":"https://api.github.com/users/IlyaMoiseev","html_url":"https://github.com/IlyaMoiseev","followers_url":"https://api.github.com/users/IlyaMoiseev/followers","following_url":"https://api.github.com/users/IlyaMoiseev/following{/other_user}","gists_url":"https://api.github.com/users/IlyaMoiseev/gists{/gist_id}","starred_url":"https://api.github.com/users/IlyaMoiseev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IlyaMoiseev/subscriptions","organizations_url":"https://api.github.com/users/IlyaMoiseev/orgs","repos_url":"https://api.github.com/users/IlyaMoiseev/repos","events_url":"https://api.github.com/users/IlyaMoiseev/events{/privacy}","received_events_url":"https://api.github.com/users/IlyaMoiseev/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1135337137,"node_id":"MDU6TGFiZWwxMTM1MzM3MTM3","url":"https://api.github.com/repos/telstra/open-kilda/labels/On%20Review","name":"On Review","color":"fad201","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/telstra/open-kilda/pulls/1754/commits","review_comments_url":"https://api.github.com/repos/telstra/open-kilda/pulls/1754/comments","review_comment_url":"https://api.github.com/repos/telstra/open-kilda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/telstra/open-kilda/issues/1754/comments","statuses_url":"https://api.github.com/repos/telstra/open-kilda/statuses/6827dc64c90ded5f4add16b8229ce864b1d568a1","head":{"label":"telstra:issue-1548-update-logic-with-under-maintenance-isl","ref":"issue-1548-update-logic-with-under-maintenance-isl","sha":"6827dc64c90ded5f4add16b8229ce864b1d568a1","user":{"login":"telstra","id":3914896,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTQ4OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/3914896?v=4","gravatar_id":"","url":"https://api.github.com/users/telstra","html_url":"https://github.com/telstra","followers_url":"https://api.github.com/users/telstra/followers","following_url":"https://api.github.com/users/telstra/following{/other_user}","gists_url":"https://api.github.com/users/telstra/gists{/gist_id}","starred_url":"https://api.github.com/users/telstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telstra/subscriptions","organizations_url":"https://api.github.com/users/telstra/orgs","repos_url":"https://api.github.com/users/telstra/repos","events_url":"https://api.github.com/users/telstra/events{/privacy}","received_events_url":"https://api.github.com/users/telstra/received_events","type":"Organization","site_admin":false},"repo":{"id":104974693,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ5NzQ2OTM=","name":"open-kilda","full_name":"telstra/open-kilda","private":false,"owner":{"login":"telstra","id":3914896,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTQ4OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/3914896?v=4","gravatar_id":"","url":"https://api.github.com/users/telstra","html_url":"https://github.com/telstra","followers_url":"https://api.github.com/users/telstra/followers","following_url":"https://api.github.com/users/telstra/following{/other_user}","gists_url":"https://api.github.com/users/telstra/gists{/gist_id}","starred_url":"https://api.github.com/users/telstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telstra/subscriptions","organizations_url":"https://api.github.com/users/telstra/orgs","repos_url":"https://api.github.com/users/telstra/repos","events_url":"https://api.github.com/users/telstra/events{/privacy}","received_events_url":"https://api.github.com/users/telstra/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/telstra/open-kilda","description":"OpenKilda is an open-source OpenFlow controller initially designed for use in a global network with high control-plane latency and a heavy emphasis on latency-centric data path optimisation.","fork":false,"url":"https://api.github.com/repos/telstra/open-kilda","forks_url":"https://api.github.com/repos/telstra/open-kilda/forks","keys_url":"https://api.github.com/repos/telstra/open-kilda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/telstra/open-kilda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/telstra/open-kilda/teams","hooks_url":"https://api.github.com/repos/telstra/open-kilda/hooks","issue_events_url":"https://api.github.com/repos/telstra/open-kilda/issues/events{/number}","events_url":"https://api.github.com/repos/telstra/open-kilda/events","assignees_url":"https://api.github.com/repos/telstra/open-kilda/assignees{/user}","branches_url":"https://api.github.com/repos/telstra/open-kilda/branches{/branch}","tags_url":"https://api.github.com/repos/telstra/open-kilda/tags","blobs_url":"https://api.github.com/repos/telstra/open-kilda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/telstra/open-kilda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/telstra/open-kilda/git/refs{/sha}","trees_url":"https://api.github.com/repos/telstra/open-kilda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/telstra/open-kilda/statuses/{sha}","languages_url":"https://api.github.com/repos/telstra/open-kilda/languages","stargazers_url":"https://api.github.com/repos/telstra/open-kilda/stargazers","contributors_url":"https://api.github.com/repos/telstra/open-kilda/contributors","subscribers_url":"https://api.github.com/repos/telstra/open-kilda/subscribers","subscription_url":"https://api.github.com/repos/telstra/open-kilda/subscription","commits_url":"https://api.github.com/repos/telstra/open-kilda/commits{/sha}","git_commits_url":"https://api.github.com/repos/telstra/open-kilda/git/commits{/sha}","comments_url":"https://api.github.com/repos/telstra/open-kilda/comments{/number}","issue_comment_url":"https://api.github.com/repos/telstra/open-kilda/issues/comments{/number}","contents_url":"https://api.github.com/repos/telstra/open-kilda/contents/{+path}","compare_url":"https://api.github.com/repos/telstra/open-kilda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/telstra/open-kilda/merges","archive_url":"https://api.github.com/repos/telstra/open-kilda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/telstra/open-kilda/downloads","issues_url":"https://api.github.com/repos/telstra/open-kilda/issues{/number}","pulls_url":"https://api.github.com/repos/telstra/open-kilda/pulls{/number}","milestones_url":"https://api.github.com/repos/telstra/open-kilda/milestones{/number}","notifications_url":"https://api.github.com/repos/telstra/open-kilda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/telstra/open-kilda/labels{/name}","releases_url":"https://api.github.com/repos/telstra/open-kilda/releases{/id}","deployments_url":"https://api.github.com/repos/telstra/open-kilda/deployments","created_at":"2017-09-27T05:13:18Z","updated_at":"2018-12-18T14:21:16Z","pushed_at":"2018-12-19T11:44:47Z","git_url":"git://github.com/telstra/open-kilda.git","ssh_url":"git@github.com:telstra/open-kilda.git","clone_url":"https://github.com/telstra/open-kilda.git","svn_url":"https://github.com/telstra/open-kilda","homepage":"","size":214136,"stargazers_count":36,"watchers_count":36,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":308,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":32,"open_issues":308,"watchers":36,"default_branch":"develop"}},"base":{"label":"telstra:issue-1548-api-for-set-clear-under-maintenance-flag","ref":"issue-1548-api-for-set-clear-under-maintenance-flag","sha":"67aa9f6fc8e7f242adca1936829c95fb011f52b2","user":{"login":"telstra","id":3914896,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTQ4OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/3914896?v=4","gravatar_id":"","url":"https://api.github.com/users/telstra","html_url":"https://github.com/telstra","followers_url":"https://api.github.com/users/telstra/followers","following_url":"https://api.github.com/users/telstra/following{/other_user}","gists_url":"https://api.github.com/users/telstra/gists{/gist_id}","starred_url":"https://api.github.com/users/telstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telstra/subscriptions","organizations_url":"https://api.github.com/users/telstra/orgs","repos_url":"https://api.github.com/users/telstra/repos","events_url":"https://api.github.com/users/telstra/events{/privacy}","received_events_url":"https://api.github.com/users/telstra/received_events","type":"Organization","site_admin":false},"repo":{"id":104974693,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ5NzQ2OTM=","name":"open-kilda","full_name":"telstra/open-kilda","private":false,"owner":{"login":"telstra","id":3914896,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTQ4OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/3914896?v=4","gravatar_id":"","url":"https://api.github.com/users/telstra","html_url":"https://github.com/telstra","followers_url":"https://api.github.com/users/telstra/followers","following_url":"https://api.github.com/users/telstra/following{/other_user}","gists_url":"https://api.github.com/users/telstra/gists{/gist_id}","starred_url":"https://api.github.com/users/telstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telstra/subscriptions","organizations_url":"https://api.github.com/users/telstra/orgs","repos_url":"https://api.github.com/users/telstra/repos","events_url":"https://api.github.com/users/telstra/events{/privacy}","received_events_url":"https://api.github.com/users/telstra/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/telstra/open-kilda","description":"OpenKilda is an open-source OpenFlow controller initially designed for use in a global network with high control-plane latency and a heavy emphasis on latency-centric data path optimisation.","fork":false,"url":"https://api.github.com/repos/telstra/open-kilda","forks_url":"https://api.github.com/repos/telstra/open-kilda/forks","keys_url":"https://api.github.com/repos/telstra/open-kilda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/telstra/open-kilda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/telstra/open-kilda/teams","hooks_url":"https://api.github.com/repos/telstra/open-kilda/hooks","issue_events_url":"https://api.github.com/repos/telstra/open-kilda/issues/events{/number}","events_url":"https://api.github.com/repos/telstra/open-kilda/events","assignees_url":"https://api.github.com/repos/telstra/open-kilda/assignees{/user}","branches_url":"https://api.github.com/repos/telstra/open-kilda/branches{/branch}","tags_url":"https://api.github.com/repos/telstra/open-kilda/tags","blobs_url":"https://api.github.com/repos/telstra/open-kilda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/telstra/open-kilda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/telstra/open-kilda/git/refs{/sha}","trees_url":"https://api.github.com/repos/telstra/open-kilda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/telstra/open-kilda/statuses/{sha}","languages_url":"https://api.github.com/repos/telstra/open-kilda/languages","stargazers_url":"https://api.github.com/repos/telstra/open-kilda/stargazers","contributors_url":"https://api.github.com/repos/telstra/open-kilda/contributors","subscribers_url":"https://api.github.com/repos/telstra/open-kilda/subscribers","subscription_url":"https://api.github.com/repos/telstra/open-kilda/subscription","commits_url":"https://api.github.com/repos/telstra/open-kilda/commits{/sha}","git_commits_url":"https://api.github.com/repos/telstra/open-kilda/git/commits{/sha}","comments_url":"https://api.github.com/repos/telstra/open-kilda/comments{/number}","issue_comment_url":"https://api.github.com/repos/telstra/open-kilda/issues/comments{/number}","contents_url":"https://api.github.com/repos/telstra/open-kilda/contents/{+path}","compare_url":"https://api.github.com/repos/telstra/open-kilda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/telstra/open-kilda/merges","archive_url":"https://api.github.com/repos/telstra/open-kilda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/telstra/open-kilda/downloads","issues_url":"https://api.github.com/repos/telstra/open-kilda/issues{/number}","pulls_url":"https://api.github.com/repos/telstra/open-kilda/pulls{/number}","milestones_url":"https://api.github.com/repos/telstra/open-kilda/milestones{/number}","notifications_url":"https://api.github.com/repos/telstra/open-kilda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/telstra/open-kilda/labels{/name}","releases_url":"https://api.github.com/repos/telstra/open-kilda/releases{/id}","deployments_url":"https://api.github.com/repos/telstra/open-kilda/deployments","created_at":"2017-09-27T05:13:18Z","updated_at":"2018-12-18T14:21:16Z","pushed_at":"2018-12-19T11:44:47Z","git_url":"git://github.com/telstra/open-kilda.git","ssh_url":"git@github.com:telstra/open-kilda.git","clone_url":"https://github.com/telstra/open-kilda.git","svn_url":"https://github.com/telstra/open-kilda","homepage":"","size":214136,"stargazers_count":36,"watchers_count":36,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":308,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":32,"open_issues":308,"watchers":36,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/telstra/open-kilda/pulls/1754"},"html":{"href":"https://github.com/telstra/open-kilda/pull/1754"},"issue":{"href":"https://api.github.com/repos/telstra/open-kilda/issues/1754"},"comments":{"href":"https://api.github.com/repos/telstra/open-kilda/issues/1754/comments"},"review_comments":{"href":"https://api.github.com/repos/telstra/open-kilda/pulls/1754/comments"},"review_comment":{"href":"https://api.github.com/repos/telstra/open-kilda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/telstra/open-kilda/pulls/1754/commits"},"statuses":{"href":"https://api.github.com/repos/telstra/open-kilda/statuses/6827dc64c90ded5f4add16b8229ce864b1d568a1"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"dpoltavets"}}