{"action":"created","issue":{"url":"https://api.github.com/repos/Azolo/websockex/issues/63","repository_url":"https://api.github.com/repos/Azolo/websockex","labels_url":"https://api.github.com/repos/Azolo/websockex/issues/63/labels{/name}","comments_url":"https://api.github.com/repos/Azolo/websockex/issues/63/comments","events_url":"https://api.github.com/repos/Azolo/websockex/issues/63/events","html_url":"https://github.com/Azolo/websockex/pull/63","id":378941596,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NTI3NzE4","number":63,"title":"Updated dependencies, formatting, dialyzer, credo","user":{"login":"InoMurko","id":2582555,"node_id":"MDQ6VXNlcjI1ODI1NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/2582555?v=4","gravatar_id":"","url":"https://api.github.com/users/InoMurko","html_url":"https://github.com/InoMurko","followers_url":"https://api.github.com/users/InoMurko/followers","following_url":"https://api.github.com/users/InoMurko/following{/other_user}","gists_url":"https://api.github.com/users/InoMurko/gists{/gist_id}","starred_url":"https://api.github.com/users/InoMurko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/InoMurko/subscriptions","organizations_url":"https://api.github.com/users/InoMurko/orgs","repos_url":"https://api.github.com/users/InoMurko/repos","events_url":"https://api.github.com/users/InoMurko/events{/privacy}","received_events_url":"https://api.github.com/users/InoMurko/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-08T22:20:49Z","updated_at":"2018-11-16T17:31:49Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Azolo/websockex/pulls/63","html_url":"https://github.com/Azolo/websockex/pull/63","diff_url":"https://github.com/Azolo/websockex/pull/63.diff","patch_url":"https://github.com/Azolo/websockex/pull/63.patch"},"body":"Removed all associations to the request object since it's been deprecated in latest cowboy."},"comment":{"url":"https://api.github.com/repos/Azolo/websockex/issues/comments/439467821","html_url":"https://github.com/Azolo/websockex/pull/63#issuecomment-439467821","issue_url":"https://api.github.com/repos/Azolo/websockex/issues/63","id":439467821,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTQ2NzgyMQ==","user":{"login":"mmartinson","id":6256333,"node_id":"MDQ6VXNlcjYyNTYzMzM=","avatar_url":"https://avatars2.githubusercontent.com/u/6256333?v=4","gravatar_id":"","url":"https://api.github.com/users/mmartinson","html_url":"https://github.com/mmartinson","followers_url":"https://api.github.com/users/mmartinson/followers","following_url":"https://api.github.com/users/mmartinson/following{/other_user}","gists_url":"https://api.github.com/users/mmartinson/gists{/gist_id}","starred_url":"https://api.github.com/users/mmartinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmartinson/subscriptions","organizations_url":"https://api.github.com/users/mmartinson/orgs","repos_url":"https://api.github.com/users/mmartinson/repos","events_url":"https://api.github.com/users/mmartinson/events{/privacy}","received_events_url":"https://api.github.com/users/mmartinson/received_events","type":"User","site_admin":false},"created_at":"2018-11-16T17:31:49Z","updated_at":"2018-11-16T17:31:49Z","author_association":"NONE","body":"@InoMurko a bit of feedback to help make PRs easier to review (I general, I am not a maintainer of this project). It's best, if you intend to run the code formatter as part of your patch, to do it in a separate commit from something like updating dependencies. It ends up making a large and noisy diff for review, and also looks confusing when looking at git history. Additionally, it creates a larger surface area for unnecessary merge conflicts.\r\n\r\nI'm not sure if this would be an issue getting this particular patch in, but taking the code formatting out and making a different PR for it could help move it through more quickly."}}
{"actor":{"display_login":"mmartinson"}}