{"action":"created","comment":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/200724187","pull_request_review_id":135100644,"id":200724187,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDcyNDE4Nw==","diff_hunk":"@@ -261,6 +261,18 @@ static ssize_t mrail_recv(struct fid_ep *ep_fid, void *buf, size_t len,\n \t\t\t\t mrail_ep->util_ep.rx_op_flags, FI_MSG);\n }\n \n+static ssize_t mrail_recvmsg(struct fid_ep *ep_fid, const struct fi_msg *msg,\n+\t\tuint64_t flags)\n+{\n+\tstruct mrail_ep *mrail_ep = container_of(ep_fid, struct mrail_ep,\n+\t\t\t\t\t     util_ep.ep_fid.fid);\n+\n+\treturn mrail_recv_common(mrail_ep, &mrail_ep->recv_queue,\n+\t\t\t\t (struct iovec *)msg->msg_iov, msg->iov_count,\n+\t\t\t\t msg->context, msg->addr, 0, 0,\n+\t\t\t\t mrail_ep->util_ep.rx_op_flags | flags, FI_MSG);","path":"prov/mrail/src/mrail_ep.c","position":13,"original_position":13,"commit_id":"f25e2413eb7e81914e5e858a2e136de74973796d","original_commit_id":"f25e2413eb7e81914e5e858a2e136de74973796d","user":{"login":"a-ilango","id":8547674,"node_id":"MDQ6VXNlcjg1NDc2NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/8547674?v=4","gravatar_id":"","url":"https://api.github.com/users/a-ilango","html_url":"https://github.com/a-ilango","followers_url":"https://api.github.com/users/a-ilango/followers","following_url":"https://api.github.com/users/a-ilango/following{/other_user}","gists_url":"https://api.github.com/users/a-ilango/gists{/gist_id}","starred_url":"https://api.github.com/users/a-ilango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-ilango/subscriptions","organizations_url":"https://api.github.com/users/a-ilango/orgs","repos_url":"https://api.github.com/users/a-ilango/repos","events_url":"https://api.github.com/users/a-ilango/events{/privacy}","received_events_url":"https://api.github.com/users/a-ilango/received_events","type":"User","site_admin":false},"body":"Shouldn't the flags be always a combination of the default + any flags specific to the current operation? The only exception is FI_COMPLETION which would depend on FI_SELECTIVE_COMPLETION but that's handled separately.","created_at":"2018-07-06T17:42:18Z","updated_at":"2018-07-06T17:42:19Z","html_url":"https://github.com/ofiwg/libfabric/pull/4253#discussion_r200724187","pull_request_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/4253","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/200724187"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/4253#discussion_r200724187"},"pull_request":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/4253"}},"in_reply_to_id":200720278},"pull_request":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/4253","id":199591250,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NTkxMjUw","html_url":"https://github.com/ofiwg/libfabric/pull/4253","diff_url":"https://github.com/ofiwg/libfabric/pull/4253.diff","patch_url":"https://github.com/ofiwg/libfabric/pull/4253.patch","issue_url":"https://api.github.com/repos/ofiwg/libfabric/issues/4253","number":4253,"state":"open","locked":false,"title":"prov/mrail: Add fi_recvmsg() call.","user":{"login":"yburette","id":8826543,"node_id":"MDQ6VXNlcjg4MjY1NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/8826543?v=4","gravatar_id":"","url":"https://api.github.com/users/yburette","html_url":"https://github.com/yburette","followers_url":"https://api.github.com/users/yburette/followers","following_url":"https://api.github.com/users/yburette/following{/other_user}","gists_url":"https://api.github.com/users/yburette/gists{/gist_id}","starred_url":"https://api.github.com/users/yburette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yburette/subscriptions","organizations_url":"https://api.github.com/users/yburette/orgs","repos_url":"https://api.github.com/users/yburette/repos","events_url":"https://api.github.com/users/yburette/events{/privacy}","received_events_url":"https://api.github.com/users/yburette/received_events","type":"User","site_admin":false},"body":"Signed-off-by: yohann <yohann.burette@intel.com>","created_at":"2018-07-05T21:24:55Z","updated_at":"2018-07-06T17:42:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8176c9355591bebf472c1cc64ff338a36c61fb49","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/4253/commits","review_comments_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/4253/comments","review_comment_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/issues/4253/comments","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/f25e2413eb7e81914e5e858a2e136de74973796d","head":{"label":"yburette:topic/add_recvmsg","ref":"topic/add_recvmsg","sha":"f25e2413eb7e81914e5e858a2e136de74973796d","user":{"login":"yburette","id":8826543,"node_id":"MDQ6VXNlcjg4MjY1NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/8826543?v=4","gravatar_id":"","url":"https://api.github.com/users/yburette","html_url":"https://github.com/yburette","followers_url":"https://api.github.com/users/yburette/followers","following_url":"https://api.github.com/users/yburette/following{/other_user}","gists_url":"https://api.github.com/users/yburette/gists{/gist_id}","starred_url":"https://api.github.com/users/yburette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yburette/subscriptions","organizations_url":"https://api.github.com/users/yburette/orgs","repos_url":"https://api.github.com/users/yburette/repos","events_url":"https://api.github.com/users/yburette/events{/privacy}","received_events_url":"https://api.github.com/users/yburette/received_events","type":"User","site_admin":false},"repo":{"id":27616236,"node_id":"MDEwOlJlcG9zaXRvcnkyNzYxNjIzNg==","name":"libfabric","full_name":"yburette/libfabric","owner":{"login":"yburette","id":8826543,"node_id":"MDQ6VXNlcjg4MjY1NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/8826543?v=4","gravatar_id":"","url":"https://api.github.com/users/yburette","html_url":"https://github.com/yburette","followers_url":"https://api.github.com/users/yburette/followers","following_url":"https://api.github.com/users/yburette/following{/other_user}","gists_url":"https://api.github.com/users/yburette/gists{/gist_id}","starred_url":"https://api.github.com/users/yburette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yburette/subscriptions","organizations_url":"https://api.github.com/users/yburette/orgs","repos_url":"https://api.github.com/users/yburette/repos","events_url":"https://api.github.com/users/yburette/events{/privacy}","received_events_url":"https://api.github.com/users/yburette/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yburette/libfabric","description":"Open Fabric Interfaces","fork":true,"url":"https://api.github.com/repos/yburette/libfabric","forks_url":"https://api.github.com/repos/yburette/libfabric/forks","keys_url":"https://api.github.com/repos/yburette/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yburette/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yburette/libfabric/teams","hooks_url":"https://api.github.com/repos/yburette/libfabric/hooks","issue_events_url":"https://api.github.com/repos/yburette/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/yburette/libfabric/events","assignees_url":"https://api.github.com/repos/yburette/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/yburette/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/yburette/libfabric/tags","blobs_url":"https://api.github.com/repos/yburette/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yburette/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yburette/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/yburette/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yburette/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/yburette/libfabric/languages","stargazers_url":"https://api.github.com/repos/yburette/libfabric/stargazers","contributors_url":"https://api.github.com/repos/yburette/libfabric/contributors","subscribers_url":"https://api.github.com/repos/yburette/libfabric/subscribers","subscription_url":"https://api.github.com/repos/yburette/libfabric/subscription","commits_url":"https://api.github.com/repos/yburette/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/yburette/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/yburette/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/yburette/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/yburette/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/yburette/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yburette/libfabric/merges","archive_url":"https://api.github.com/repos/yburette/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yburette/libfabric/downloads","issues_url":"https://api.github.com/repos/yburette/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/yburette/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/yburette/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/yburette/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yburette/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/yburette/libfabric/releases{/id}","deployments_url":"https://api.github.com/repos/yburette/libfabric/deployments","created_at":"2014-12-06T00:27:41Z","updated_at":"2016-04-21T20:38:25Z","pushed_at":"2018-07-05T23:16:50Z","git_url":"git://github.com/yburette/libfabric.git","ssh_url":"git@github.com:yburette/libfabric.git","clone_url":"https://github.com/yburette/libfabric.git","svn_url":"https://github.com/yburette/libfabric","homepage":null,"size":17933,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ofiwg:master","ref":"master","sha":"d876032305500c9669e22d78ab64e0c768a29f17","user":{"login":"ofiwg","id":8459445,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0NTk0NDU=","avatar_url":"https://avatars1.githubusercontent.com/u/8459445?v=4","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"repo":{"id":22996097,"node_id":"MDEwOlJlcG9zaXRvcnkyMjk5NjA5Nw==","name":"libfabric","full_name":"ofiwg/libfabric","owner":{"login":"ofiwg","id":8459445,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0NTk0NDU=","avatar_url":"https://avatars1.githubusercontent.com/u/8459445?v=4","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ofiwg/libfabric","description":"Open Fabric Interfaces","fork":false,"url":"https://api.github.com/repos/ofiwg/libfabric","forks_url":"https://api.github.com/repos/ofiwg/libfabric/forks","keys_url":"https://api.github.com/repos/ofiwg/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofiwg/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofiwg/libfabric/teams","hooks_url":"https://api.github.com/repos/ofiwg/libfabric/hooks","issue_events_url":"https://api.github.com/repos/ofiwg/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/ofiwg/libfabric/events","assignees_url":"https://api.github.com/repos/ofiwg/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/ofiwg/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/ofiwg/libfabric/tags","blobs_url":"https://api.github.com/repos/ofiwg/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofiwg/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofiwg/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofiwg/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/ofiwg/libfabric/languages","stargazers_url":"https://api.github.com/repos/ofiwg/libfabric/stargazers","contributors_url":"https://api.github.com/repos/ofiwg/libfabric/contributors","subscribers_url":"https://api.github.com/repos/ofiwg/libfabric/subscribers","subscription_url":"https://api.github.com/repos/ofiwg/libfabric/subscription","commits_url":"https://api.github.com/repos/ofiwg/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofiwg/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofiwg/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofiwg/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/ofiwg/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofiwg/libfabric/merges","archive_url":"https://api.github.com/repos/ofiwg/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofiwg/libfabric/downloads","issues_url":"https://api.github.com/repos/ofiwg/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/ofiwg/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/ofiwg/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/ofiwg/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofiwg/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/ofiwg/libfabric/releases{/id}","deployments_url":"https://api.github.com/repos/ofiwg/libfabric/deployments","created_at":"2014-08-15T16:45:53Z","updated_at":"2018-07-06T11:25:18Z","pushed_at":"2018-07-06T11:25:14Z","git_url":"git://github.com/ofiwg/libfabric.git","ssh_url":"git@github.com:ofiwg/libfabric.git","clone_url":"https://github.com/ofiwg/libfabric.git","svn_url":"https://github.com/ofiwg/libfabric","homepage":"http://libfabric.org/","size":18770,"stargazers_count":151,"watchers_count":151,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":139,"mirror_url":null,"archived":false,"open_issues_count":126,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":139,"open_issues":126,"watchers":151,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/4253"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/4253"},"issue":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/4253"},"comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/4253/comments"},"review_comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/4253/comments"},"review_comment":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/4253/commits"},"statuses":{"href":"https://api.github.com/repos/ofiwg/libfabric/statuses/f25e2413eb7e81914e5e858a2e136de74973796d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"a-ilango"}}