{"action":"closed","number":8,"pull_request":{"url":"https://api.github.com/repos/axic/openzeppelin-solidity/pulls/8","id":199963190,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5OTYzMTkw","html_url":"https://github.com/axic/openzeppelin-solidity/pull/8","diff_url":"https://github.com/axic/openzeppelin-solidity/pull/8.diff","patch_url":"https://github.com/axic/openzeppelin-solidity/pull/8.patch","issue_url":"https://api.github.com/repos/axic/openzeppelin-solidity/issues/8","number":8,"state":"closed","locked":false,"title":"Added explicit data locations for a few parameters that were missed.","user":{"login":"chase1745","id":17399486,"node_id":"MDQ6VXNlcjE3Mzk5NDg2","avatar_url":"https://avatars1.githubusercontent.com/u/17399486?v=4","gravatar_id":"","url":"https://api.github.com/users/chase1745","html_url":"https://github.com/chase1745","followers_url":"https://api.github.com/users/chase1745/followers","following_url":"https://api.github.com/users/chase1745/following{/other_user}","gists_url":"https://api.github.com/users/chase1745/gists{/gist_id}","starred_url":"https://api.github.com/users/chase1745/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chase1745/subscriptions","organizations_url":"https://api.github.com/users/chase1745/orgs","repos_url":"https://api.github.com/users/chase1745/repos","events_url":"https://api.github.com/users/chase1745/events{/privacy}","received_events_url":"https://api.github.com/users/chase1745/received_events","type":"User","site_admin":false},"body":"\r\n<!-- 0. 🎉 Thank you for submitting a PR! -->\r\n\r\n<!-- 1. **Does this close any open issues?** If so, list them here. If not, remove the `Fixes #` line. -->\r\n\r\n# 🚀 Description\r\n\r\nMissed these 2 parameters in my previous PR (#5). If you'd rather me add these to other PR and rebase or something like that let me know.\r\n\r\n<!-- 2. Describe the changes introduced in this pull request -->\r\n<!--    Include any context necessary for understanding the PR's purpose. -->\r\n\r\n<!-- 3. Before submitting, please review the following checklist: -->\r\n\r\n\r\n","created_at":"2018-07-08T22:05:34Z","updated_at":"2018-07-09T11:40:02Z","closed_at":"2018-07-09T11:40:02Z","merged_at":"2018-07-09T11:40:02Z","merge_commit_sha":"668ae79628bfc142f98dc3d071f9d91c4d61a3ec","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/axic/openzeppelin-solidity/pulls/8/commits","review_comments_url":"https://api.github.com/repos/axic/openzeppelin-solidity/pulls/8/comments","review_comment_url":"https://api.github.com/repos/axic/openzeppelin-solidity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/axic/openzeppelin-solidity/issues/8/comments","statuses_url":"https://api.github.com/repos/axic/openzeppelin-solidity/statuses/7a09f971d18339420561ba12f933765b65fed8dc","head":{"label":"chase1745:use-explicit-data-locations-missed","ref":"use-explicit-data-locations-missed","sha":"7a09f971d18339420561ba12f933765b65fed8dc","user":{"login":"chase1745","id":17399486,"node_id":"MDQ6VXNlcjE3Mzk5NDg2","avatar_url":"https://avatars1.githubusercontent.com/u/17399486?v=4","gravatar_id":"","url":"https://api.github.com/users/chase1745","html_url":"https://github.com/chase1745","followers_url":"https://api.github.com/users/chase1745/followers","following_url":"https://api.github.com/users/chase1745/following{/other_user}","gists_url":"https://api.github.com/users/chase1745/gists{/gist_id}","starred_url":"https://api.github.com/users/chase1745/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chase1745/subscriptions","organizations_url":"https://api.github.com/users/chase1745/orgs","repos_url":"https://api.github.com/users/chase1745/repos","events_url":"https://api.github.com/users/chase1745/events{/privacy}","received_events_url":"https://api.github.com/users/chase1745/received_events","type":"User","site_admin":false},"repo":{"id":138116235,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgxMTYyMzU=","name":"openzeppelin-solidity","full_name":"chase1745/openzeppelin-solidity","owner":{"login":"chase1745","id":17399486,"node_id":"MDQ6VXNlcjE3Mzk5NDg2","avatar_url":"https://avatars1.githubusercontent.com/u/17399486?v=4","gravatar_id":"","url":"https://api.github.com/users/chase1745","html_url":"https://github.com/chase1745","followers_url":"https://api.github.com/users/chase1745/followers","following_url":"https://api.github.com/users/chase1745/following{/other_user}","gists_url":"https://api.github.com/users/chase1745/gists{/gist_id}","starred_url":"https://api.github.com/users/chase1745/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chase1745/subscriptions","organizations_url":"https://api.github.com/users/chase1745/orgs","repos_url":"https://api.github.com/users/chase1745/repos","events_url":"https://api.github.com/users/chase1745/events{/privacy}","received_events_url":"https://api.github.com/users/chase1745/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chase1745/openzeppelin-solidity","description":"OpenZeppelin, a framework to build secure smart contracts on Ethereum","fork":true,"url":"https://api.github.com/repos/chase1745/openzeppelin-solidity","forks_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/forks","keys_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/teams","hooks_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/hooks","issue_events_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/issues/events{/number}","events_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/events","assignees_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/assignees{/user}","branches_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/branches{/branch}","tags_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/tags","blobs_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/languages","stargazers_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/stargazers","contributors_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/contributors","subscribers_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/subscribers","subscription_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/subscription","commits_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/contents/{+path}","compare_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/merges","archive_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/downloads","issues_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/issues{/number}","pulls_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/labels{/name}","releases_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/releases{/id}","deployments_url":"https://api.github.com/repos/chase1745/openzeppelin-solidity/deployments","created_at":"2018-06-21T03:46:25Z","updated_at":"2018-07-08T21:35:29Z","pushed_at":"2018-07-08T22:04:17Z","git_url":"git://github.com/chase1745/openzeppelin-solidity.git","ssh_url":"git@github.com:chase1745/openzeppelin-solidity.git","clone_url":"https://github.com/chase1745/openzeppelin-solidity.git","svn_url":"https://github.com/chase1745/openzeppelin-solidity","homepage":"https://openzeppelin.org","size":1586,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"solidity-050"}},"base":{"label":"axic:solidity-050","ref":"solidity-050","sha":"a90ce0d4d1a4f2dd8dbee23fc7b2bed49c9246df","user":{"login":"axic","id":20340,"node_id":"MDQ6VXNlcjIwMzQw","avatar_url":"https://avatars3.githubusercontent.com/u/20340?v=4","gravatar_id":"","url":"https://api.github.com/users/axic","html_url":"https://github.com/axic","followers_url":"https://api.github.com/users/axic/followers","following_url":"https://api.github.com/users/axic/following{/other_user}","gists_url":"https://api.github.com/users/axic/gists{/gist_id}","starred_url":"https://api.github.com/users/axic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axic/subscriptions","organizations_url":"https://api.github.com/users/axic/orgs","repos_url":"https://api.github.com/users/axic/repos","events_url":"https://api.github.com/users/axic/events{/privacy}","received_events_url":"https://api.github.com/users/axic/received_events","type":"User","site_admin":false},"repo":{"id":135463148,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU0NjMxNDg=","name":"openzeppelin-solidity","full_name":"axic/openzeppelin-solidity","owner":{"login":"axic","id":20340,"node_id":"MDQ6VXNlcjIwMzQw","avatar_url":"https://avatars3.githubusercontent.com/u/20340?v=4","gravatar_id":"","url":"https://api.github.com/users/axic","html_url":"https://github.com/axic","followers_url":"https://api.github.com/users/axic/followers","following_url":"https://api.github.com/users/axic/following{/other_user}","gists_url":"https://api.github.com/users/axic/gists{/gist_id}","starred_url":"https://api.github.com/users/axic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axic/subscriptions","organizations_url":"https://api.github.com/users/axic/orgs","repos_url":"https://api.github.com/users/axic/repos","events_url":"https://api.github.com/users/axic/events{/privacy}","received_events_url":"https://api.github.com/users/axic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/axic/openzeppelin-solidity","description":"OpenZeppelin, a framework to build secure smart contracts on Ethereum","fork":true,"url":"https://api.github.com/repos/axic/openzeppelin-solidity","forks_url":"https://api.github.com/repos/axic/openzeppelin-solidity/forks","keys_url":"https://api.github.com/repos/axic/openzeppelin-solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/axic/openzeppelin-solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/axic/openzeppelin-solidity/teams","hooks_url":"https://api.github.com/repos/axic/openzeppelin-solidity/hooks","issue_events_url":"https://api.github.com/repos/axic/openzeppelin-solidity/issues/events{/number}","events_url":"https://api.github.com/repos/axic/openzeppelin-solidity/events","assignees_url":"https://api.github.com/repos/axic/openzeppelin-solidity/assignees{/user}","branches_url":"https://api.github.com/repos/axic/openzeppelin-solidity/branches{/branch}","tags_url":"https://api.github.com/repos/axic/openzeppelin-solidity/tags","blobs_url":"https://api.github.com/repos/axic/openzeppelin-solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/axic/openzeppelin-solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/axic/openzeppelin-solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/axic/openzeppelin-solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/axic/openzeppelin-solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/axic/openzeppelin-solidity/languages","stargazers_url":"https://api.github.com/repos/axic/openzeppelin-solidity/stargazers","contributors_url":"https://api.github.com/repos/axic/openzeppelin-solidity/contributors","subscribers_url":"https://api.github.com/repos/axic/openzeppelin-solidity/subscribers","subscription_url":"https://api.github.com/repos/axic/openzeppelin-solidity/subscription","commits_url":"https://api.github.com/repos/axic/openzeppelin-solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/axic/openzeppelin-solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/axic/openzeppelin-solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/axic/openzeppelin-solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/axic/openzeppelin-solidity/contents/{+path}","compare_url":"https://api.github.com/repos/axic/openzeppelin-solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/axic/openzeppelin-solidity/merges","archive_url":"https://api.github.com/repos/axic/openzeppelin-solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/axic/openzeppelin-solidity/downloads","issues_url":"https://api.github.com/repos/axic/openzeppelin-solidity/issues{/number}","pulls_url":"https://api.github.com/repos/axic/openzeppelin-solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/axic/openzeppelin-solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/axic/openzeppelin-solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/axic/openzeppelin-solidity/labels{/name}","releases_url":"https://api.github.com/repos/axic/openzeppelin-solidity/releases{/id}","deployments_url":"https://api.github.com/repos/axic/openzeppelin-solidity/deployments","created_at":"2018-05-30T15:30:59Z","updated_at":"2018-06-29T10:42:03Z","pushed_at":"2018-07-09T11:40:02Z","git_url":"git://github.com/axic/openzeppelin-solidity.git","ssh_url":"git@github.com:axic/openzeppelin-solidity.git","clone_url":"https://github.com/axic/openzeppelin-solidity.git","svn_url":"https://github.com/axic/openzeppelin-solidity","homepage":"https://openzeppelin.org","size":1586,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":0,"watchers":0,"default_branch":"solidity-050"}},"_links":{"self":{"href":"https://api.github.com/repos/axic/openzeppelin-solidity/pulls/8"},"html":{"href":"https://github.com/axic/openzeppelin-solidity/pull/8"},"issue":{"href":"https://api.github.com/repos/axic/openzeppelin-solidity/issues/8"},"comments":{"href":"https://api.github.com/repos/axic/openzeppelin-solidity/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/axic/openzeppelin-solidity/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/axic/openzeppelin-solidity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/axic/openzeppelin-solidity/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/axic/openzeppelin-solidity/statuses/7a09f971d18339420561ba12f933765b65fed8dc"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"axic","id":20340,"node_id":"MDQ6VXNlcjIwMzQw","avatar_url":"https://avatars3.githubusercontent.com/u/20340?v=4","gravatar_id":"","url":"https://api.github.com/users/axic","html_url":"https://github.com/axic","followers_url":"https://api.github.com/users/axic/followers","following_url":"https://api.github.com/users/axic/following{/other_user}","gists_url":"https://api.github.com/users/axic/gists{/gist_id}","starred_url":"https://api.github.com/users/axic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axic/subscriptions","organizations_url":"https://api.github.com/users/axic/orgs","repos_url":"https://api.github.com/users/axic/repos","events_url":"https://api.github.com/users/axic/events{/privacy}","received_events_url":"https://api.github.com/users/axic/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"axic"}}