{"action":"created","issue":{"url":"https://api.github.com/repos/docker-library/postgres/issues/362","repository_url":"https://api.github.com/repos/docker-library/postgres","labels_url":"https://api.github.com/repos/docker-library/postgres/issues/362/labels{/name}","comments_url":"https://api.github.com/repos/docker-library/postgres/issues/362/comments","events_url":"https://api.github.com/repos/docker-library/postgres/issues/362/events","html_url":"https://github.com/docker-library/postgres/issues/362","id":268666590,"node_id":"MDU6SXNzdWUyNjg2NjY1OTA=","number":362,"title":"Fail-fast setting for psql-client prevents automatic import on startup of full db dumps","user":{"login":"rgielen","id":64990,"node_id":"MDQ6VXNlcjY0OTkw","avatar_url":"https://avatars1.githubusercontent.com/u/64990?v=4","gravatar_id":"","url":"https://api.github.com/users/rgielen","html_url":"https://github.com/rgielen","followers_url":"https://api.github.com/users/rgielen/followers","following_url":"https://api.github.com/users/rgielen/following{/other_user}","gists_url":"https://api.github.com/users/rgielen/gists{/gist_id}","starred_url":"https://api.github.com/users/rgielen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgielen/subscriptions","organizations_url":"https://api.github.com/users/rgielen/orgs","repos_url":"https://api.github.com/users/rgielen/repos","events_url":"https://api.github.com/users/rgielen/events{/privacy}","received_events_url":"https://api.github.com/users/rgielen/received_events","type":"User","site_admin":false},"labels":[{"id":912819651,"node_id":"MDU6TGFiZWw5MTI4MTk2NTE=","url":"https://api.github.com/repos/docker-library/postgres/labels/Request","name":"Request","color":"92fc88","default":false},{"id":101614646,"node_id":"MDU6TGFiZWwxMDE2MTQ2NDY=","url":"https://api.github.com/repos/docker-library/postgres/labels/question","name":"question","color":"cc317c","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-10-26T08:13:57Z","updated_at":"2018-10-09T20:53:11Z","closed_at":null,"author_association":"NONE","body":"https://github.com/docker-library/postgres/blob/f7dc5727b1d6b6a636350e11648845ae33477579/9.6/docker-entrypoint.sh#L104\r\n\r\nIn this line psql is advised to fail fast on errors. This is a problem for importing any dump created by pg_dumpall, since there is a 99% chance it will include a ```CREATE ROLE postgres;``` statement, causing an error. In default mode psql keeps on executing the following statements, which is perfectly fine to restore a cluster.\r\n\r\nMy expectation would be that a pg_dumpall dump can be imported smoothly when mounted at ```/docker-entrypoint-initdb.d```.\r\n\r\nI suggest to remove the fail-on-error setting or at least make it configurable through an environment variable (IMHO with defaulting to standard psql behaviour)"},"comment":{"url":"https://api.github.com/repos/docker-library/postgres/issues/comments/428347622","html_url":"https://github.com/docker-library/postgres/issues/362#issuecomment-428347622","issue_url":"https://api.github.com/repos/docker-library/postgres/issues/362","id":428347622,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODM0NzYyMg==","user":{"login":"tianon","id":161631,"node_id":"MDQ6VXNlcjE2MTYzMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/161631?v=4","gravatar_id":"","url":"https://api.github.com/users/tianon","html_url":"https://github.com/tianon","followers_url":"https://api.github.com/users/tianon/followers","following_url":"https://api.github.com/users/tianon/following{/other_user}","gists_url":"https://api.github.com/users/tianon/gists{/gist_id}","starred_url":"https://api.github.com/users/tianon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tianon/subscriptions","organizations_url":"https://api.github.com/users/tianon/orgs","repos_url":"https://api.github.com/users/tianon/repos","events_url":"https://api.github.com/users/tianon/events{/privacy}","received_events_url":"https://api.github.com/users/tianon/received_events","type":"User","site_admin":false},"created_at":"2018-10-09T20:53:11Z","updated_at":"2018-10-09T20:53:11Z","author_association":"MEMBER","body":"(To be clear, we do the same thing with shell scripts too -- `set -e` is enabled for the very same set of reasons.)"}}
{"actor":{"display_login":"tianon"}}