{"action":"created","issue":{"url":"https://api.github.com/repos/archivesunleashed/aut/issues/181","repository_url":"https://api.github.com/repos/archivesunleashed/aut","labels_url":"https://api.github.com/repos/archivesunleashed/aut/issues/181/labels{/name}","comments_url":"https://api.github.com/repos/archivesunleashed/aut/issues/181/comments","events_url":"https://api.github.com/repos/archivesunleashed/aut/issues/181/events","html_url":"https://github.com/archivesunleashed/aut/pull/181","id":306554626,"number":181,"title":"Revert \"make ArchiveRecord a trait (#175)\"","user":{"login":"ruebot","id":218561,"avatar_url":"https://avatars2.githubusercontent.com/u/218561?v=4","gravatar_id":"","url":"https://api.github.com/users/ruebot","html_url":"https://github.com/ruebot","followers_url":"https://api.github.com/users/ruebot/followers","following_url":"https://api.github.com/users/ruebot/following{/other_user}","gists_url":"https://api.github.com/users/ruebot/gists{/gist_id}","starred_url":"https://api.github.com/users/ruebot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruebot/subscriptions","organizations_url":"https://api.github.com/users/ruebot/orgs","repos_url":"https://api.github.com/users/ruebot/repos","events_url":"https://api.github.com/users/ruebot/events{/privacy}","received_events_url":"https://api.github.com/users/ruebot/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-03-19T17:16:09Z","updated_at":"2018-03-19T17:23:39Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/archivesunleashed/aut/pulls/181","html_url":"https://github.com/archivesunleashed/aut/pull/181","diff_url":"https://github.com/archivesunleashed/aut/pull/181.diff","patch_url":"https://github.com/archivesunleashed/aut/pull/181.patch"},"body":"This reverts commit cd0d7b03854db80dc67f8076aff44f1b4c2364b2.\r\n\r\n# What does this Pull Request do?\r\n\r\nReverts @helgeho's trait work.\r\n\r\nI was under the impression that #175 was tested in a way that it was not tested by @greebie before I merged it. Unfortunately this breaks in a number of ways that can be seen [here](https://gist.github.com/ruebot/97040d25cdc7f110869be9529b332a61#file-0-13-0).\r\n\r\n# How should this be tested?\r\n\r\nThis is just rolling back to basically 0.12.2, and it should be working fine. @ianmilligan1 would you mind testing this on one of our small WALK datasets? I was using Ransom Myers. So, anything you have laying around should be great. No drop everything super rush here. Sometime this week if you have time.\r\n\r\n# Additional Notes:\r\n\r\nI'll be putting a note on the [0.13.0 release](https://github.com/archivesunleashed/aut/releases/tag/aut-0.13.0) mentioning that is broken, and not to use it. We can't remove releases from Maven Central, so I'll just have to cut a new release once this is merged.\r\n\r\nMoving forward, I think we need to come up with a set of tests, or extend the existing tests that that can catch how we failed here. I think it would be better to have our unit tests capture potential traps that happened here rather than a battery of testing on various datasets.\r\n\r\n@helgeho moving forward, let me know how you want to proceed with the work done in https://github.com/archivesunleashed/aut/pull/175. I think it is a good idea, and really great that our projects can be connected. So, hopefully we can get something going again :smile:"},"comment":{"url":"https://api.github.com/repos/archivesunleashed/aut/issues/comments/374295806","html_url":"https://github.com/archivesunleashed/aut/pull/181#issuecomment-374295806","issue_url":"https://api.github.com/repos/archivesunleashed/aut/issues/181","id":374295806,"user":{"login":"greebie","id":111091,"avatar_url":"https://avatars0.githubusercontent.com/u/111091?v=4","gravatar_id":"","url":"https://api.github.com/users/greebie","html_url":"https://github.com/greebie","followers_url":"https://api.github.com/users/greebie/followers","following_url":"https://api.github.com/users/greebie/following{/other_user}","gists_url":"https://api.github.com/users/greebie/gists{/gist_id}","starred_url":"https://api.github.com/users/greebie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greebie/subscriptions","organizations_url":"https://api.github.com/users/greebie/orgs","repos_url":"https://api.github.com/users/greebie/repos","events_url":"https://api.github.com/users/greebie/events{/privacy}","received_events_url":"https://api.github.com/users/greebie/received_events","type":"User","site_admin":false},"created_at":"2018-03-19T17:23:39Z","updated_at":"2018-03-19T17:23:39Z","author_association":"CONTRIBUTOR","body":"Agreed about the unit testing.  I can take a look at that this week.  Looks like a problem with making a DateFormat on an empty string."}}
{"actor":{"display_login":"greebie"}}