{"action":"created","comment":{"url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/pulls/comments/195732763","pull_request_review_id":129162111,"id":195732763,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTczMjc2Mw==","diff_hunk":"@@ -39,6 +39,7 @@ def verify_read(aws, bucket_name, cloud_account_id):\n         return ResourceAccess.NOT_OK, 'Bucket name was not supplied'\n \n     try:\n+        aws.service = 's3'","path":"reactor/features/accounts/facades/cloudtrail_bucket.py","position":4,"original_position":4,"commit_id":"c61dd601236b9bb25ac0bc897676cad4c7b6f389","original_commit_id":"c61dd601236b9bb25ac0bc897676cad4c7b6f389","user":{"login":"Tankanow","id":2100107,"node_id":"MDQ6VXNlcjIxMDAxMDc=","avatar_url":"https://avatars0.githubusercontent.com/u/2100107?v=4","gravatar_id":"","url":"https://api.github.com/users/Tankanow","html_url":"https://github.com/Tankanow","followers_url":"https://api.github.com/users/Tankanow/followers","following_url":"https://api.github.com/users/Tankanow/following{/other_user}","gists_url":"https://api.github.com/users/Tankanow/gists{/gist_id}","starred_url":"https://api.github.com/users/Tankanow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tankanow/subscriptions","organizations_url":"https://api.github.com/users/Tankanow/orgs","repos_url":"https://api.github.com/users/Tankanow/repos","events_url":"https://api.github.com/users/Tankanow/events{/privacy}","received_events_url":"https://api.github.com/users/Tankanow/received_events","type":"User","site_admin":false},"body":"I'm confused how this fixes the issue. The first thing that happens in `_get_cloudtrail_config` is it sets `aws.service = 'cloudtrail'`.","created_at":"2018-06-15T13:30:55Z","updated_at":"2018-06-15T13:30:58Z","html_url":"https://github.com/Cloudzero/cloudzero-reactor-aws/pull/119#discussion_r195732763","pull_request_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/pulls/119","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/pulls/comments/195732763"},"html":{"href":"https://github.com/Cloudzero/cloudzero-reactor-aws/pull/119#discussion_r195732763"},"pull_request":{"href":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/pulls/119"}},"in_reply_to_id":195731607},"pull_request":{"url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/pulls/119","id":195172138,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MTcyMTM4","html_url":"https://github.com/Cloudzero/cloudzero-reactor-aws/pull/119","diff_url":"https://github.com/Cloudzero/cloudzero-reactor-aws/pull/119.diff","patch_url":"https://github.com/Cloudzero/cloudzero-reactor-aws/pull/119.patch","issue_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/issues/119","number":119,"state":"open","locked":false,"title":"Ensure that cloudtrail check always uses S3 boto service","user":{"login":"killthrush","id":6638896,"node_id":"MDQ6VXNlcjY2Mzg4OTY=","avatar_url":"https://avatars0.githubusercontent.com/u/6638896?v=4","gravatar_id":"","url":"https://api.github.com/users/killthrush","html_url":"https://github.com/killthrush","followers_url":"https://api.github.com/users/killthrush/followers","following_url":"https://api.github.com/users/killthrush/following{/other_user}","gists_url":"https://api.github.com/users/killthrush/gists{/gist_id}","starred_url":"https://api.github.com/users/killthrush/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/killthrush/subscriptions","organizations_url":"https://api.github.com/users/killthrush/orgs","repos_url":"https://api.github.com/users/killthrush/repos","events_url":"https://api.github.com/users/killthrush/events{/privacy}","received_events_url":"https://api.github.com/users/killthrush/received_events","type":"User","site_admin":false},"body":"### Description\r\n<!--- Provide a brief description of the PR and issue it addresses. -->\r\n\r\n\r\n- [ ] Existing GitHub Issue? Please provide #: \r\n\r\n### Acceptance checklist\r\n<!--- Here we make sure all criteria for merge has been satisfied. -->\r\n- [ ] Feedback addressed\r\n- [ ] Tests added or modified appropriately\r\n- [ ] All tests passed\r\n\r\n","created_at":"2018-06-15T13:23:06Z","updated_at":"2018-06-15T13:30:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3aba9b095856e82a69a1c5669d842dbaa1d63661","assignee":null,"assignees":[],"requested_reviewers":[{"login":"imcgaunn","id":8900989,"node_id":"MDQ6VXNlcjg5MDA5ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/8900989?v=4","gravatar_id":"","url":"https://api.github.com/users/imcgaunn","html_url":"https://github.com/imcgaunn","followers_url":"https://api.github.com/users/imcgaunn/followers","following_url":"https://api.github.com/users/imcgaunn/following{/other_user}","gists_url":"https://api.github.com/users/imcgaunn/gists{/gist_id}","starred_url":"https://api.github.com/users/imcgaunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imcgaunn/subscriptions","organizations_url":"https://api.github.com/users/imcgaunn/orgs","repos_url":"https://api.github.com/users/imcgaunn/repos","events_url":"https://api.github.com/users/imcgaunn/events{/privacy}","received_events_url":"https://api.github.com/users/imcgaunn/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/pulls/119/commits","review_comments_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/pulls/119/comments","review_comment_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/issues/119/comments","statuses_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/statuses/c61dd601236b9bb25ac0bc897676cad4c7b6f389","head":{"label":"Cloudzero:hotfix/boto-unknown-service","ref":"hotfix/boto-unknown-service","sha":"c61dd601236b9bb25ac0bc897676cad4c7b6f389","user":{"login":"Cloudzero","id":22050846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDUwODQ2","avatar_url":"https://avatars0.githubusercontent.com/u/22050846?v=4","gravatar_id":"","url":"https://api.github.com/users/Cloudzero","html_url":"https://github.com/Cloudzero","followers_url":"https://api.github.com/users/Cloudzero/followers","following_url":"https://api.github.com/users/Cloudzero/following{/other_user}","gists_url":"https://api.github.com/users/Cloudzero/gists{/gist_id}","starred_url":"https://api.github.com/users/Cloudzero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cloudzero/subscriptions","organizations_url":"https://api.github.com/users/Cloudzero/orgs","repos_url":"https://api.github.com/users/Cloudzero/repos","events_url":"https://api.github.com/users/Cloudzero/events{/privacy}","received_events_url":"https://api.github.com/users/Cloudzero/received_events","type":"Organization","site_admin":false},"repo":{"id":104886482,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ4ODY0ODI=","name":"cloudzero-reactor-aws","full_name":"Cloudzero/cloudzero-reactor-aws","owner":{"login":"Cloudzero","id":22050846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDUwODQ2","avatar_url":"https://avatars0.githubusercontent.com/u/22050846?v=4","gravatar_id":"","url":"https://api.github.com/users/Cloudzero","html_url":"https://github.com/Cloudzero","followers_url":"https://api.github.com/users/Cloudzero/followers","following_url":"https://api.github.com/users/Cloudzero/following{/other_user}","gists_url":"https://api.github.com/users/Cloudzero/gists{/gist_id}","starred_url":"https://api.github.com/users/Cloudzero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cloudzero/subscriptions","organizations_url":"https://api.github.com/users/Cloudzero/orgs","repos_url":"https://api.github.com/users/Cloudzero/repos","events_url":"https://api.github.com/users/Cloudzero/events{/privacy}","received_events_url":"https://api.github.com/users/Cloudzero/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Cloudzero/cloudzero-reactor-aws","description":"CloudZero Reactor for AWS","fork":false,"url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws","forks_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/forks","keys_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/teams","hooks_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/hooks","issue_events_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/issues/events{/number}","events_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/events","assignees_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/assignees{/user}","branches_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/branches{/branch}","tags_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/tags","blobs_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/languages","stargazers_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/stargazers","contributors_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/contributors","subscribers_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/subscribers","subscription_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/subscription","commits_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/contents/{+path}","compare_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/merges","archive_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/downloads","issues_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/issues{/number}","pulls_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/labels{/name}","releases_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/releases{/id}","deployments_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/deployments","created_at":"2017-09-26T13:13:15Z","updated_at":"2018-06-15T12:51:30Z","pushed_at":"2018-06-15T13:23:07Z","git_url":"git://github.com/Cloudzero/cloudzero-reactor-aws.git","ssh_url":"git@github.com:Cloudzero/cloudzero-reactor-aws.git","clone_url":"https://github.com/Cloudzero/cloudzero-reactor-aws.git","svn_url":"https://github.com/Cloudzero/cloudzero-reactor-aws","homepage":"https://www.cloudzero.com/","size":6809,"stargazers_count":21,"watchers_count":21,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":11,"watchers":21,"default_branch":"develop"}},"base":{"label":"Cloudzero:develop","ref":"develop","sha":"57b590235504c9bab81bed7d804325ddcbccc887","user":{"login":"Cloudzero","id":22050846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDUwODQ2","avatar_url":"https://avatars0.githubusercontent.com/u/22050846?v=4","gravatar_id":"","url":"https://api.github.com/users/Cloudzero","html_url":"https://github.com/Cloudzero","followers_url":"https://api.github.com/users/Cloudzero/followers","following_url":"https://api.github.com/users/Cloudzero/following{/other_user}","gists_url":"https://api.github.com/users/Cloudzero/gists{/gist_id}","starred_url":"https://api.github.com/users/Cloudzero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cloudzero/subscriptions","organizations_url":"https://api.github.com/users/Cloudzero/orgs","repos_url":"https://api.github.com/users/Cloudzero/repos","events_url":"https://api.github.com/users/Cloudzero/events{/privacy}","received_events_url":"https://api.github.com/users/Cloudzero/received_events","type":"Organization","site_admin":false},"repo":{"id":104886482,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ4ODY0ODI=","name":"cloudzero-reactor-aws","full_name":"Cloudzero/cloudzero-reactor-aws","owner":{"login":"Cloudzero","id":22050846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDUwODQ2","avatar_url":"https://avatars0.githubusercontent.com/u/22050846?v=4","gravatar_id":"","url":"https://api.github.com/users/Cloudzero","html_url":"https://github.com/Cloudzero","followers_url":"https://api.github.com/users/Cloudzero/followers","following_url":"https://api.github.com/users/Cloudzero/following{/other_user}","gists_url":"https://api.github.com/users/Cloudzero/gists{/gist_id}","starred_url":"https://api.github.com/users/Cloudzero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cloudzero/subscriptions","organizations_url":"https://api.github.com/users/Cloudzero/orgs","repos_url":"https://api.github.com/users/Cloudzero/repos","events_url":"https://api.github.com/users/Cloudzero/events{/privacy}","received_events_url":"https://api.github.com/users/Cloudzero/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Cloudzero/cloudzero-reactor-aws","description":"CloudZero Reactor for AWS","fork":false,"url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws","forks_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/forks","keys_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/teams","hooks_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/hooks","issue_events_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/issues/events{/number}","events_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/events","assignees_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/assignees{/user}","branches_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/branches{/branch}","tags_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/tags","blobs_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/languages","stargazers_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/stargazers","contributors_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/contributors","subscribers_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/subscribers","subscription_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/subscription","commits_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/contents/{+path}","compare_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/merges","archive_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/downloads","issues_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/issues{/number}","pulls_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/labels{/name}","releases_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/releases{/id}","deployments_url":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/deployments","created_at":"2017-09-26T13:13:15Z","updated_at":"2018-06-15T12:51:30Z","pushed_at":"2018-06-15T13:23:07Z","git_url":"git://github.com/Cloudzero/cloudzero-reactor-aws.git","ssh_url":"git@github.com:Cloudzero/cloudzero-reactor-aws.git","clone_url":"https://github.com/Cloudzero/cloudzero-reactor-aws.git","svn_url":"https://github.com/Cloudzero/cloudzero-reactor-aws","homepage":"https://www.cloudzero.com/","size":6809,"stargazers_count":21,"watchers_count":21,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":11,"watchers":21,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/pulls/119"},"html":{"href":"https://github.com/Cloudzero/cloudzero-reactor-aws/pull/119"},"issue":{"href":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/issues/119"},"comments":{"href":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/issues/119/comments"},"review_comments":{"href":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/pulls/119/comments"},"review_comment":{"href":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/pulls/119/commits"},"statuses":{"href":"https://api.github.com/repos/Cloudzero/cloudzero-reactor-aws/statuses/c61dd601236b9bb25ac0bc897676cad4c7b6f389"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Tankanow"}}