{"action":"created","comment":{"url":"https://api.github.com/repos/metoppv/improver/pulls/comments/227787125","pull_request_review_id":167890341,"id":227787125,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzc4NzEyNQ==","diff_hunk":"@@ -0,0 +1,135 @@\n+# -*- coding: utf-8 -*-\n+# -----------------------------------------------------------------------------\n+# (C) British Crown Copyright 2017-2018 Met Office.\n+# All rights reserved.\n+#\n+# Redistribution and use in source and binary forms, with or without\n+# modification, are permitted provided that the following conditions are met:\n+#\n+# * Redistributions of source code must retain the above copyright notice, this\n+#   list of conditions and the following disclaimer.\n+#\n+# * Redistributions in binary form must reproduce the above copyright notice,\n+#   this list of conditions and the following disclaimer in the documentation\n+#   and/or other materials provided with the distribution.\n+#\n+# * Neither the name of the copyright holder nor the names of its\n+#   contributors may be used to endorse or promote products derived from\n+#   this software without specific prior written permission.\n+#\n+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS \"AS IS\"\n+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE\n+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE\n+# ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE\n+# LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR\n+# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF\n+# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS\n+# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN\n+# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)\n+# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE\n+# POSSIBILITY OF SUCH DAMAGE.\n+\"\"\"Module to test the unify_forecast_reference_times function.\"\"\"\n+\n+import unittest\n+\n+import datetime\n+import numpy as np\n+import iris\n+from iris.tests import IrisTest\n+\n+from improver.tests.blending.weights.helper_functions import (\n+    set_up_temperature_cube, add_model_id_and_model_configuration)\n+from improver.tests.ensemble_calibration.ensemble_calibration.helper_functions\\\n+    import add_forecast_reference_time_and_forecast_period\n+from improver.blending.weighted_blend import unify_forecast_reference_time\n+\n+\n+class Test_unify_forecast_reference_time(IrisTest):","path":"lib/improver/tests/blending/weighted_blend/test_unify_forecast_reference_time.py","position":47,"original_position":47,"commit_id":"86585c08cf2ff1b7627b46490d2451b0397b89e5","original_commit_id":"86585c08cf2ff1b7627b46490d2451b0397b89e5","user":{"login":"fionaRust","id":16209648,"node_id":"MDQ6VXNlcjE2MjA5NjQ4","avatar_url":"https://avatars3.githubusercontent.com/u/16209648?v=4","gravatar_id":"","url":"https://api.github.com/users/fionaRust","html_url":"https://github.com/fionaRust","followers_url":"https://api.github.com/users/fionaRust/followers","following_url":"https://api.github.com/users/fionaRust/following{/other_user}","gists_url":"https://api.github.com/users/fionaRust/gists{/gist_id}","starred_url":"https://api.github.com/users/fionaRust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fionaRust/subscriptions","organizations_url":"https://api.github.com/users/fionaRust/orgs","repos_url":"https://api.github.com/users/fionaRust/repos","events_url":"https://api.github.com/users/fionaRust/events{/privacy}","received_events_url":"https://api.github.com/users/fionaRust/received_events","type":"User","site_admin":false},"body":"Moved from  lib/improver/tests/utilities/test_temporal.py unchanged","created_at":"2018-10-24T13:27:35Z","updated_at":"2018-10-24T13:49:16Z","html_url":"https://github.com/metoppv/improver/pull/698#discussion_r227787125","pull_request_url":"https://api.github.com/repos/metoppv/improver/pulls/698","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/metoppv/improver/pulls/comments/227787125"},"html":{"href":"https://github.com/metoppv/improver/pull/698#discussion_r227787125"},"pull_request":{"href":"https://api.github.com/repos/metoppv/improver/pulls/698"}}},"pull_request":{"url":"https://api.github.com/repos/metoppv/improver/pulls/698","id":223568430,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNTY4NDMw","html_url":"https://github.com/metoppv/improver/pull/698","diff_url":"https://github.com/metoppv/improver/pull/698.diff","patch_url":"https://github.com/metoppv/improver/pull/698.patch","issue_url":"https://api.github.com/repos/metoppv/improver/issues/698","number":698,"state":"open","locked":false,"title":"Changes to improver-weighted-blending CLI to use new weights functionality","user":{"login":"cgsandford","id":35029690,"node_id":"MDQ6VXNlcjM1MDI5Njkw","avatar_url":"https://avatars1.githubusercontent.com/u/35029690?v=4","gravatar_id":"","url":"https://api.github.com/users/cgsandford","html_url":"https://github.com/cgsandford","followers_url":"https://api.github.com/users/cgsandford/followers","following_url":"https://api.github.com/users/cgsandford/following{/other_user}","gists_url":"https://api.github.com/users/cgsandford/gists{/gist_id}","starred_url":"https://api.github.com/users/cgsandford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgsandford/subscriptions","organizations_url":"https://api.github.com/users/cgsandford/orgs","repos_url":"https://api.github.com/users/cgsandford/repos","events_url":"https://api.github.com/users/cgsandford/events{/privacy}","received_events_url":"https://api.github.com/users/cgsandford/received_events","type":"User","site_admin":false},"body":"Addresses #658 \r\n\r\nDescription: this change includes the following:\r\n- Changes to improver-weighted-blending CLI arguments and functionality, including wrapper for weights creation plugins\r\n- Changes to CLI tests (removed some, added one for \"dict\" option)\r\n- Updates to unify_forecast_reference_time (also moved) and new rationalise_blend_time_coordinates function\r\n- Migration of metadata updates to the improver.blending.weighted_blending.cube_metadata function, and added new unit tests\r\n- Updates to ChooseWeightsLinear to output weights with the required dimensionality from a dictionary\r\n- Updates to WeightedBlendAcrossWholeDimension function to throw an error if blending over a scalar coordinate, plus updated unit test\r\n- Moved constant dictionary to improver.constants\r\n\r\nTesting:\r\n - [x] Ran tests and they passed OK\r\n - [x] Added new tests for the new feature(s)\r\n","created_at":"2018-10-17T11:36:43Z","updated_at":"2018-10-24T13:49:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dedba7b3865b2ac6410e8f769c69c89fe72cca47","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/metoppv/improver/pulls/698/commits","review_comments_url":"https://api.github.com/repos/metoppv/improver/pulls/698/comments","review_comment_url":"https://api.github.com/repos/metoppv/improver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/metoppv/improver/issues/698/comments","statuses_url":"https://api.github.com/repos/metoppv/improver/statuses/86585c08cf2ff1b7627b46490d2451b0397b89e5","head":{"label":"cgsandford:IMPRO-857","ref":"IMPRO-857","sha":"86585c08cf2ff1b7627b46490d2451b0397b89e5","user":{"login":"cgsandford","id":35029690,"node_id":"MDQ6VXNlcjM1MDI5Njkw","avatar_url":"https://avatars1.githubusercontent.com/u/35029690?v=4","gravatar_id":"","url":"https://api.github.com/users/cgsandford","html_url":"https://github.com/cgsandford","followers_url":"https://api.github.com/users/cgsandford/followers","following_url":"https://api.github.com/users/cgsandford/following{/other_user}","gists_url":"https://api.github.com/users/cgsandford/gists{/gist_id}","starred_url":"https://api.github.com/users/cgsandford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgsandford/subscriptions","organizations_url":"https://api.github.com/users/cgsandford/orgs","repos_url":"https://api.github.com/users/cgsandford/repos","events_url":"https://api.github.com/users/cgsandford/events{/privacy}","received_events_url":"https://api.github.com/users/cgsandford/received_events","type":"User","site_admin":false},"repo":{"id":116007441,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYwMDc0NDE=","name":"improver","full_name":"cgsandford/improver","private":false,"owner":{"login":"cgsandford","id":35029690,"node_id":"MDQ6VXNlcjM1MDI5Njkw","avatar_url":"https://avatars1.githubusercontent.com/u/35029690?v=4","gravatar_id":"","url":"https://api.github.com/users/cgsandford","html_url":"https://github.com/cgsandford","followers_url":"https://api.github.com/users/cgsandford/followers","following_url":"https://api.github.com/users/cgsandford/following{/other_user}","gists_url":"https://api.github.com/users/cgsandford/gists{/gist_id}","starred_url":"https://api.github.com/users/cgsandford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgsandford/subscriptions","organizations_url":"https://api.github.com/users/cgsandford/orgs","repos_url":"https://api.github.com/users/cgsandford/repos","events_url":"https://api.github.com/users/cgsandford/events{/privacy}","received_events_url":"https://api.github.com/users/cgsandford/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cgsandford/improver","description":"IMPROVER is a library of algorithms for meteorological post-processing and verification.","fork":true,"url":"https://api.github.com/repos/cgsandford/improver","forks_url":"https://api.github.com/repos/cgsandford/improver/forks","keys_url":"https://api.github.com/repos/cgsandford/improver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cgsandford/improver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cgsandford/improver/teams","hooks_url":"https://api.github.com/repos/cgsandford/improver/hooks","issue_events_url":"https://api.github.com/repos/cgsandford/improver/issues/events{/number}","events_url":"https://api.github.com/repos/cgsandford/improver/events","assignees_url":"https://api.github.com/repos/cgsandford/improver/assignees{/user}","branches_url":"https://api.github.com/repos/cgsandford/improver/branches{/branch}","tags_url":"https://api.github.com/repos/cgsandford/improver/tags","blobs_url":"https://api.github.com/repos/cgsandford/improver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cgsandford/improver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cgsandford/improver/git/refs{/sha}","trees_url":"https://api.github.com/repos/cgsandford/improver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cgsandford/improver/statuses/{sha}","languages_url":"https://api.github.com/repos/cgsandford/improver/languages","stargazers_url":"https://api.github.com/repos/cgsandford/improver/stargazers","contributors_url":"https://api.github.com/repos/cgsandford/improver/contributors","subscribers_url":"https://api.github.com/repos/cgsandford/improver/subscribers","subscription_url":"https://api.github.com/repos/cgsandford/improver/subscription","commits_url":"https://api.github.com/repos/cgsandford/improver/commits{/sha}","git_commits_url":"https://api.github.com/repos/cgsandford/improver/git/commits{/sha}","comments_url":"https://api.github.com/repos/cgsandford/improver/comments{/number}","issue_comment_url":"https://api.github.com/repos/cgsandford/improver/issues/comments{/number}","contents_url":"https://api.github.com/repos/cgsandford/improver/contents/{+path}","compare_url":"https://api.github.com/repos/cgsandford/improver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cgsandford/improver/merges","archive_url":"https://api.github.com/repos/cgsandford/improver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cgsandford/improver/downloads","issues_url":"https://api.github.com/repos/cgsandford/improver/issues{/number}","pulls_url":"https://api.github.com/repos/cgsandford/improver/pulls{/number}","milestones_url":"https://api.github.com/repos/cgsandford/improver/milestones{/number}","notifications_url":"https://api.github.com/repos/cgsandford/improver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cgsandford/improver/labels{/name}","releases_url":"https://api.github.com/repos/cgsandford/improver/releases{/id}","deployments_url":"https://api.github.com/repos/cgsandford/improver/deployments","created_at":"2018-01-02T11:18:00Z","updated_at":"2018-10-22T13:08:28Z","pushed_at":"2018-10-24T10:32:47Z","git_url":"git://github.com/cgsandford/improver.git","ssh_url":"git@github.com:cgsandford/improver.git","clone_url":"https://github.com/cgsandford/improver.git","svn_url":"https://github.com/cgsandford/improver","homepage":"","size":4000,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"metoppv:feature_branch_331_grid_blending","ref":"feature_branch_331_grid_blending","sha":"82d59aba89a7044b6db551cbf3388ea9b34ad69a","user":{"login":"metoppv","id":26465485,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NDY1NDg1","avatar_url":"https://avatars2.githubusercontent.com/u/26465485?v=4","gravatar_id":"","url":"https://api.github.com/users/metoppv","html_url":"https://github.com/metoppv","followers_url":"https://api.github.com/users/metoppv/followers","following_url":"https://api.github.com/users/metoppv/following{/other_user}","gists_url":"https://api.github.com/users/metoppv/gists{/gist_id}","starred_url":"https://api.github.com/users/metoppv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metoppv/subscriptions","organizations_url":"https://api.github.com/users/metoppv/orgs","repos_url":"https://api.github.com/users/metoppv/repos","events_url":"https://api.github.com/users/metoppv/events{/privacy}","received_events_url":"https://api.github.com/users/metoppv/received_events","type":"Organization","site_admin":false},"repo":{"id":85334761,"node_id":"MDEwOlJlcG9zaXRvcnk4NTMzNDc2MQ==","name":"improver","full_name":"metoppv/improver","private":false,"owner":{"login":"metoppv","id":26465485,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NDY1NDg1","avatar_url":"https://avatars2.githubusercontent.com/u/26465485?v=4","gravatar_id":"","url":"https://api.github.com/users/metoppv","html_url":"https://github.com/metoppv","followers_url":"https://api.github.com/users/metoppv/followers","following_url":"https://api.github.com/users/metoppv/following{/other_user}","gists_url":"https://api.github.com/users/metoppv/gists{/gist_id}","starred_url":"https://api.github.com/users/metoppv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metoppv/subscriptions","organizations_url":"https://api.github.com/users/metoppv/orgs","repos_url":"https://api.github.com/users/metoppv/repos","events_url":"https://api.github.com/users/metoppv/events{/privacy}","received_events_url":"https://api.github.com/users/metoppv/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/metoppv/improver","description":"IMPROVER is a library of algorithms for meteorological post-processing and verification.","fork":false,"url":"https://api.github.com/repos/metoppv/improver","forks_url":"https://api.github.com/repos/metoppv/improver/forks","keys_url":"https://api.github.com/repos/metoppv/improver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metoppv/improver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metoppv/improver/teams","hooks_url":"https://api.github.com/repos/metoppv/improver/hooks","issue_events_url":"https://api.github.com/repos/metoppv/improver/issues/events{/number}","events_url":"https://api.github.com/repos/metoppv/improver/events","assignees_url":"https://api.github.com/repos/metoppv/improver/assignees{/user}","branches_url":"https://api.github.com/repos/metoppv/improver/branches{/branch}","tags_url":"https://api.github.com/repos/metoppv/improver/tags","blobs_url":"https://api.github.com/repos/metoppv/improver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metoppv/improver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metoppv/improver/git/refs{/sha}","trees_url":"https://api.github.com/repos/metoppv/improver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metoppv/improver/statuses/{sha}","languages_url":"https://api.github.com/repos/metoppv/improver/languages","stargazers_url":"https://api.github.com/repos/metoppv/improver/stargazers","contributors_url":"https://api.github.com/repos/metoppv/improver/contributors","subscribers_url":"https://api.github.com/repos/metoppv/improver/subscribers","subscription_url":"https://api.github.com/repos/metoppv/improver/subscription","commits_url":"https://api.github.com/repos/metoppv/improver/commits{/sha}","git_commits_url":"https://api.github.com/repos/metoppv/improver/git/commits{/sha}","comments_url":"https://api.github.com/repos/metoppv/improver/comments{/number}","issue_comment_url":"https://api.github.com/repos/metoppv/improver/issues/comments{/number}","contents_url":"https://api.github.com/repos/metoppv/improver/contents/{+path}","compare_url":"https://api.github.com/repos/metoppv/improver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metoppv/improver/merges","archive_url":"https://api.github.com/repos/metoppv/improver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metoppv/improver/downloads","issues_url":"https://api.github.com/repos/metoppv/improver/issues{/number}","pulls_url":"https://api.github.com/repos/metoppv/improver/pulls{/number}","milestones_url":"https://api.github.com/repos/metoppv/improver/milestones{/number}","notifications_url":"https://api.github.com/repos/metoppv/improver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metoppv/improver/labels{/name}","releases_url":"https://api.github.com/repos/metoppv/improver/releases{/id}","deployments_url":"https://api.github.com/repos/metoppv/improver/deployments","created_at":"2017-03-17T16:51:29Z","updated_at":"2018-10-24T07:20:51Z","pushed_at":"2018-10-24T10:32:49Z","git_url":"git://github.com/metoppv/improver.git","ssh_url":"git@github.com:metoppv/improver.git","clone_url":"https://github.com/metoppv/improver.git","svn_url":"https://github.com/metoppv/improver","homepage":"http://improver.readthedocs.io/en/latest/","size":3940,"stargazers_count":19,"watchers_count":19,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":87,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":29,"open_issues":87,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/metoppv/improver/pulls/698"},"html":{"href":"https://github.com/metoppv/improver/pull/698"},"issue":{"href":"https://api.github.com/repos/metoppv/improver/issues/698"},"comments":{"href":"https://api.github.com/repos/metoppv/improver/issues/698/comments"},"review_comments":{"href":"https://api.github.com/repos/metoppv/improver/pulls/698/comments"},"review_comment":{"href":"https://api.github.com/repos/metoppv/improver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/metoppv/improver/pulls/698/commits"},"statuses":{"href":"https://api.github.com/repos/metoppv/improver/statuses/86585c08cf2ff1b7627b46490d2451b0397b89e5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fionaRust"}}