{"action":"created","comment":{"url":"https://api.github.com/repos/FuelRats/pipsqueak3/pulls/comments/202127647","pull_request_review_id":136765344,"id":202127647,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjEyNzY0Nw==","diff_hunk":"@@ -784,22 +787,33 @@ def rats(self, value):\n                      await RatCache().get_rat_by_name(name))\n             if found[0]:\n                 self.rats.append(found[0])\n-                return\n+                assigned_rat = found[0]\n             elif found[1]:\n                 # a generic match (not platform specific) was found\n                 # TODO throw a warning so the invoking method can handle this condition\n                 log.warning(\"A match was found, but it was not the right platform!\")\n                 self.rats.append(found[1])\n-                return\n+                assigned_rat = found[1]\n \n             else:\n                 # lets make a new Rat!\n-                if self.rat_board:  # PRAGMA: NOCOVER\n-                    raise NotImplementedError  # TODO fetch rat from API\n+                # if self.rat_board:  # PRAGMA: NOCOVER\n+                #    pass  # TODO fetch rat from API\n                 # TODO: fetch rats from API handler, use that data to make a new Rat instance\n \n                 rat = Rat(name=name, uuid=guid)\n                 self.rats.append(rat)\n+                assigned_rat = rat\n+\n+        if isinstance(guid, UUID):\n+            # lets check if we already have this rat in the cache\n+            found = await RatCache().get_rat_by_uuid(guid)","path":"Modules/rat_rescue.py","position":64,"original_position":62,"commit_id":"b5a82e8cc7dd66d43f50b99d1395e38d6bf7f73b","original_commit_id":"360c801f2025dc0bbcf246f674458f2a0ec826fa","user":{"login":"theunkn0wn1","id":3110986,"node_id":"MDQ6VXNlcjMxMTA5ODY=","avatar_url":"https://avatars1.githubusercontent.com/u/3110986?v=4","gravatar_id":"","url":"https://api.github.com/users/theunkn0wn1","html_url":"https://github.com/theunkn0wn1","followers_url":"https://api.github.com/users/theunkn0wn1/followers","following_url":"https://api.github.com/users/theunkn0wn1/following{/other_user}","gists_url":"https://api.github.com/users/theunkn0wn1/gists{/gist_id}","starred_url":"https://api.github.com/users/theunkn0wn1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theunkn0wn1/subscriptions","organizations_url":"https://api.github.com/users/theunkn0wn1/orgs","repos_url":"https://api.github.com/users/theunkn0wn1/repos","events_url":"https://api.github.com/users/theunkn0wn1/events{/privacy}","received_events_url":"https://api.github.com/users/theunkn0wn1/received_events","type":"User","site_admin":false},"body":"If the rat is not in the cache, we may need to query the API to see if the Rat exists. at the very least this branch should be accounted for, but unused as that depends on a feature that is not currently merged","created_at":"2018-07-12T18:03:39Z","updated_at":"2018-07-12T18:05:38Z","html_url":"https://github.com/FuelRats/pipsqueak3/pull/55#discussion_r202127647","pull_request_url":"https://api.github.com/repos/FuelRats/pipsqueak3/pulls/55","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/FuelRats/pipsqueak3/pulls/comments/202127647"},"html":{"href":"https://github.com/FuelRats/pipsqueak3/pull/55#discussion_r202127647"},"pull_request":{"href":"https://api.github.com/repos/FuelRats/pipsqueak3/pulls/55"}},"in_reply_to_id":200801445},"pull_request":{"url":"https://api.github.com/repos/FuelRats/pipsqueak3/pulls/55","id":199303590,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MzAzNTkw","html_url":"https://github.com/FuelRats/pipsqueak3/pull/55","diff_url":"https://github.com/FuelRats/pipsqueak3/pull/55.diff","patch_url":"https://github.com/FuelRats/pipsqueak3/pull/55.patch","issue_url":"https://api.github.com/repos/FuelRats/pipsqueak3/issues/55","number":55,"state":"open","locked":false,"title":"feature/spark-58","user":{"login":"nathanctech","id":39100023,"node_id":"MDQ6VXNlcjM5MTAwMDIz","avatar_url":"https://avatars0.githubusercontent.com/u/39100023?v=4","gravatar_id":"","url":"https://api.github.com/users/nathanctech","html_url":"https://github.com/nathanctech","followers_url":"https://api.github.com/users/nathanctech/followers","following_url":"https://api.github.com/users/nathanctech/following{/other_user}","gists_url":"https://api.github.com/users/nathanctech/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanctech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanctech/subscriptions","organizations_url":"https://api.github.com/users/nathanctech/orgs","repos_url":"https://api.github.com/users/nathanctech/repos","events_url":"https://api.github.com/users/nathanctech/events{/privacy}","received_events_url":"https://api.github.com/users/nathanctech/received_events","type":"User","site_admin":false},"body":"This PR modified add_rat() to return a Rat object of the rat added to the rescue. This is to ensure !assign works correctly and could be used for others.\r\n\r\nThis resolves SPARK-58. SPARK-52 may need to be merged first before this one is.","created_at":"2018-07-04T17:50:38Z","updated_at":"2018-07-12T18:05:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc1b2515b1e415470c12e10ead682ad5086a2c93","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FuelRats/pipsqueak3/pulls/55/commits","review_comments_url":"https://api.github.com/repos/FuelRats/pipsqueak3/pulls/55/comments","review_comment_url":"https://api.github.com/repos/FuelRats/pipsqueak3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FuelRats/pipsqueak3/issues/55/comments","statuses_url":"https://api.github.com/repos/FuelRats/pipsqueak3/statuses/b5a82e8cc7dd66d43f50b99d1395e38d6bf7f73b","head":{"label":"nathanctech:improvement/SPARK-58","ref":"improvement/SPARK-58","sha":"b5a82e8cc7dd66d43f50b99d1395e38d6bf7f73b","user":{"login":"nathanctech","id":39100023,"node_id":"MDQ6VXNlcjM5MTAwMDIz","avatar_url":"https://avatars0.githubusercontent.com/u/39100023?v=4","gravatar_id":"","url":"https://api.github.com/users/nathanctech","html_url":"https://github.com/nathanctech","followers_url":"https://api.github.com/users/nathanctech/followers","following_url":"https://api.github.com/users/nathanctech/following{/other_user}","gists_url":"https://api.github.com/users/nathanctech/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanctech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanctech/subscriptions","organizations_url":"https://api.github.com/users/nathanctech/orgs","repos_url":"https://api.github.com/users/nathanctech/repos","events_url":"https://api.github.com/users/nathanctech/events{/privacy}","received_events_url":"https://api.github.com/users/nathanctech/received_events","type":"User","site_admin":false},"repo":{"id":134032806,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQwMzI4MDY=","name":"pipsqueak3","full_name":"nathanctech/pipsqueak3","owner":{"login":"nathanctech","id":39100023,"node_id":"MDQ6VXNlcjM5MTAwMDIz","avatar_url":"https://avatars0.githubusercontent.com/u/39100023?v=4","gravatar_id":"","url":"https://api.github.com/users/nathanctech","html_url":"https://github.com/nathanctech","followers_url":"https://api.github.com/users/nathanctech/followers","following_url":"https://api.github.com/users/nathanctech/following{/other_user}","gists_url":"https://api.github.com/users/nathanctech/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanctech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanctech/subscriptions","organizations_url":"https://api.github.com/users/nathanctech/orgs","repos_url":"https://api.github.com/users/nathanctech/repos","events_url":"https://api.github.com/users/nathanctech/events{/privacy}","received_events_url":"https://api.github.com/users/nathanctech/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nathanctech/pipsqueak3","description":"Repo for the upcoming overhaul of pipsqueak ","fork":true,"url":"https://api.github.com/repos/nathanctech/pipsqueak3","forks_url":"https://api.github.com/repos/nathanctech/pipsqueak3/forks","keys_url":"https://api.github.com/repos/nathanctech/pipsqueak3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nathanctech/pipsqueak3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nathanctech/pipsqueak3/teams","hooks_url":"https://api.github.com/repos/nathanctech/pipsqueak3/hooks","issue_events_url":"https://api.github.com/repos/nathanctech/pipsqueak3/issues/events{/number}","events_url":"https://api.github.com/repos/nathanctech/pipsqueak3/events","assignees_url":"https://api.github.com/repos/nathanctech/pipsqueak3/assignees{/user}","branches_url":"https://api.github.com/repos/nathanctech/pipsqueak3/branches{/branch}","tags_url":"https://api.github.com/repos/nathanctech/pipsqueak3/tags","blobs_url":"https://api.github.com/repos/nathanctech/pipsqueak3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nathanctech/pipsqueak3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nathanctech/pipsqueak3/git/refs{/sha}","trees_url":"https://api.github.com/repos/nathanctech/pipsqueak3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nathanctech/pipsqueak3/statuses/{sha}","languages_url":"https://api.github.com/repos/nathanctech/pipsqueak3/languages","stargazers_url":"https://api.github.com/repos/nathanctech/pipsqueak3/stargazers","contributors_url":"https://api.github.com/repos/nathanctech/pipsqueak3/contributors","subscribers_url":"https://api.github.com/repos/nathanctech/pipsqueak3/subscribers","subscription_url":"https://api.github.com/repos/nathanctech/pipsqueak3/subscription","commits_url":"https://api.github.com/repos/nathanctech/pipsqueak3/commits{/sha}","git_commits_url":"https://api.github.com/repos/nathanctech/pipsqueak3/git/commits{/sha}","comments_url":"https://api.github.com/repos/nathanctech/pipsqueak3/comments{/number}","issue_comment_url":"https://api.github.com/repos/nathanctech/pipsqueak3/issues/comments{/number}","contents_url":"https://api.github.com/repos/nathanctech/pipsqueak3/contents/{+path}","compare_url":"https://api.github.com/repos/nathanctech/pipsqueak3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nathanctech/pipsqueak3/merges","archive_url":"https://api.github.com/repos/nathanctech/pipsqueak3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nathanctech/pipsqueak3/downloads","issues_url":"https://api.github.com/repos/nathanctech/pipsqueak3/issues{/number}","pulls_url":"https://api.github.com/repos/nathanctech/pipsqueak3/pulls{/number}","milestones_url":"https://api.github.com/repos/nathanctech/pipsqueak3/milestones{/number}","notifications_url":"https://api.github.com/repos/nathanctech/pipsqueak3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nathanctech/pipsqueak3/labels{/name}","releases_url":"https://api.github.com/repos/nathanctech/pipsqueak3/releases{/id}","deployments_url":"https://api.github.com/repos/nathanctech/pipsqueak3/deployments","created_at":"2018-05-19T05:32:23Z","updated_at":"2018-05-19T05:32:25Z","pushed_at":"2018-07-07T04:16:32Z","git_url":"git://github.com/nathanctech/pipsqueak3.git","ssh_url":"git@github.com:nathanctech/pipsqueak3.git","clone_url":"https://github.com/nathanctech/pipsqueak3.git","svn_url":"https://github.com/nathanctech/pipsqueak3","homepage":null,"size":722,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FuelRats:develop","ref":"develop","sha":"5dd9f9558a78aea660dd849c110d584bc00b3939","user":{"login":"FuelRats","id":15741722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NzQxNzIy","avatar_url":"https://avatars3.githubusercontent.com/u/15741722?v=4","gravatar_id":"","url":"https://api.github.com/users/FuelRats","html_url":"https://github.com/FuelRats","followers_url":"https://api.github.com/users/FuelRats/followers","following_url":"https://api.github.com/users/FuelRats/following{/other_user}","gists_url":"https://api.github.com/users/FuelRats/gists{/gist_id}","starred_url":"https://api.github.com/users/FuelRats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FuelRats/subscriptions","organizations_url":"https://api.github.com/users/FuelRats/orgs","repos_url":"https://api.github.com/users/FuelRats/repos","events_url":"https://api.github.com/users/FuelRats/events{/privacy}","received_events_url":"https://api.github.com/users/FuelRats/received_events","type":"Organization","site_admin":false},"repo":{"id":124962472,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ5NjI0NzI=","name":"pipsqueak3","full_name":"FuelRats/pipsqueak3","owner":{"login":"FuelRats","id":15741722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NzQxNzIy","avatar_url":"https://avatars3.githubusercontent.com/u/15741722?v=4","gravatar_id":"","url":"https://api.github.com/users/FuelRats","html_url":"https://github.com/FuelRats","followers_url":"https://api.github.com/users/FuelRats/followers","following_url":"https://api.github.com/users/FuelRats/following{/other_user}","gists_url":"https://api.github.com/users/FuelRats/gists{/gist_id}","starred_url":"https://api.github.com/users/FuelRats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FuelRats/subscriptions","organizations_url":"https://api.github.com/users/FuelRats/orgs","repos_url":"https://api.github.com/users/FuelRats/repos","events_url":"https://api.github.com/users/FuelRats/events{/privacy}","received_events_url":"https://api.github.com/users/FuelRats/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FuelRats/pipsqueak3","description":"Pipsqueak3, aka Spark aka Mechasqueak ","fork":false,"url":"https://api.github.com/repos/FuelRats/pipsqueak3","forks_url":"https://api.github.com/repos/FuelRats/pipsqueak3/forks","keys_url":"https://api.github.com/repos/FuelRats/pipsqueak3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FuelRats/pipsqueak3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FuelRats/pipsqueak3/teams","hooks_url":"https://api.github.com/repos/FuelRats/pipsqueak3/hooks","issue_events_url":"https://api.github.com/repos/FuelRats/pipsqueak3/issues/events{/number}","events_url":"https://api.github.com/repos/FuelRats/pipsqueak3/events","assignees_url":"https://api.github.com/repos/FuelRats/pipsqueak3/assignees{/user}","branches_url":"https://api.github.com/repos/FuelRats/pipsqueak3/branches{/branch}","tags_url":"https://api.github.com/repos/FuelRats/pipsqueak3/tags","blobs_url":"https://api.github.com/repos/FuelRats/pipsqueak3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FuelRats/pipsqueak3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FuelRats/pipsqueak3/git/refs{/sha}","trees_url":"https://api.github.com/repos/FuelRats/pipsqueak3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FuelRats/pipsqueak3/statuses/{sha}","languages_url":"https://api.github.com/repos/FuelRats/pipsqueak3/languages","stargazers_url":"https://api.github.com/repos/FuelRats/pipsqueak3/stargazers","contributors_url":"https://api.github.com/repos/FuelRats/pipsqueak3/contributors","subscribers_url":"https://api.github.com/repos/FuelRats/pipsqueak3/subscribers","subscription_url":"https://api.github.com/repos/FuelRats/pipsqueak3/subscription","commits_url":"https://api.github.com/repos/FuelRats/pipsqueak3/commits{/sha}","git_commits_url":"https://api.github.com/repos/FuelRats/pipsqueak3/git/commits{/sha}","comments_url":"https://api.github.com/repos/FuelRats/pipsqueak3/comments{/number}","issue_comment_url":"https://api.github.com/repos/FuelRats/pipsqueak3/issues/comments{/number}","contents_url":"https://api.github.com/repos/FuelRats/pipsqueak3/contents/{+path}","compare_url":"https://api.github.com/repos/FuelRats/pipsqueak3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FuelRats/pipsqueak3/merges","archive_url":"https://api.github.com/repos/FuelRats/pipsqueak3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FuelRats/pipsqueak3/downloads","issues_url":"https://api.github.com/repos/FuelRats/pipsqueak3/issues{/number}","pulls_url":"https://api.github.com/repos/FuelRats/pipsqueak3/pulls{/number}","milestones_url":"https://api.github.com/repos/FuelRats/pipsqueak3/milestones{/number}","notifications_url":"https://api.github.com/repos/FuelRats/pipsqueak3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FuelRats/pipsqueak3/labels{/name}","releases_url":"https://api.github.com/repos/FuelRats/pipsqueak3/releases{/id}","deployments_url":"https://api.github.com/repos/FuelRats/pipsqueak3/deployments","created_at":"2018-03-12T23:07:06Z","updated_at":"2018-07-12T17:42:42Z","pushed_at":"2018-07-12T17:49:12Z","git_url":"git://github.com/FuelRats/pipsqueak3.git","ssh_url":"git@github.com:FuelRats/pipsqueak3.git","clone_url":"https://github.com/FuelRats/pipsqueak3.git","svn_url":"https://github.com/FuelRats/pipsqueak3","homepage":"","size":680,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":5,"open_issues":5,"watchers":5,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/FuelRats/pipsqueak3/pulls/55"},"html":{"href":"https://github.com/FuelRats/pipsqueak3/pull/55"},"issue":{"href":"https://api.github.com/repos/FuelRats/pipsqueak3/issues/55"},"comments":{"href":"https://api.github.com/repos/FuelRats/pipsqueak3/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/FuelRats/pipsqueak3/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/FuelRats/pipsqueak3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FuelRats/pipsqueak3/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/FuelRats/pipsqueak3/statuses/b5a82e8cc7dd66d43f50b99d1395e38d6bf7f73b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"theunkn0wn1"}}