{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71945","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71945/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71945/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71945/events","html_url":"https://github.com/kubernetes/kubernetes/pull/71945","id":389656330,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NTk2MjA1","number":71945,"title":"kubeadm: fixed etcd sync endpoints","user":{"login":"pytimer","id":17105586,"node_id":"MDQ6VXNlcjE3MTA1NTg2","avatar_url":"https://avatars0.githubusercontent.com/u/17105586?v=4","gravatar_id":"","url":"https://api.github.com/users/pytimer","html_url":"https://github.com/pytimer","followers_url":"https://api.github.com/users/pytimer/followers","following_url":"https://api.github.com/users/pytimer/following{/other_user}","gists_url":"https://api.github.com/users/pytimer/gists{/gist_id}","starred_url":"https://api.github.com/users/pytimer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytimer/subscriptions","organizations_url":"https://api.github.com/users/pytimer/orgs","repos_url":"https://api.github.com/users/pytimer/repos","events_url":"https://api.github.com/users/pytimer/events{/privacy}","received_events_url":"https://api.github.com/users/pytimer/received_events","type":"User","site_admin":false},"labels":[{"id":414883982,"node_id":"MDU6TGFiZWw0MTQ4ODM5ODI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":451459590,"node_id":"MDU6TGFiZWw0NTE0NTk1OTA=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/kubeadm","name":"area/kubeadm","color":"0052cc","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":687565804,"node_id":"MDU6TGFiZWw2ODc1NjU4MDQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"e11d21","default":false},{"id":105146071,"node_id":"MDU6TGFiZWwxMDUxNDYwNzE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":1086787260,"node_id":"MDU6TGFiZWwxMDg2Nzg3MjYw","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/ok-to-test","name":"ok-to-test","color":"15dd18","default":false},{"id":114528223,"node_id":"MDU6TGFiZWwxMTQ1MjgyMjM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/important-soon","name":"priority/important-soon","color":"eb6420","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":173494222,"node_id":"MDU6TGFiZWwxNzM0OTQyMjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/cluster-lifecycle","name":"sig/cluster-lifecycle","color":"d2b48c","default":false},{"id":253450895,"node_id":"MDU6TGFiZWwyNTM0NTA4OTU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/S","name":"size/S","color":"77bb00","default":false}],"state":"open","locked":false,"assignee":{"login":"rosti","id":1117321,"node_id":"MDQ6VXNlcjExMTczMjE=","avatar_url":"https://avatars1.githubusercontent.com/u/1117321?v=4","gravatar_id":"","url":"https://api.github.com/users/rosti","html_url":"https://github.com/rosti","followers_url":"https://api.github.com/users/rosti/followers","following_url":"https://api.github.com/users/rosti/following{/other_user}","gists_url":"https://api.github.com/users/rosti/gists{/gist_id}","starred_url":"https://api.github.com/users/rosti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosti/subscriptions","organizations_url":"https://api.github.com/users/rosti/orgs","repos_url":"https://api.github.com/users/rosti/repos","events_url":"https://api.github.com/users/rosti/events{/privacy}","received_events_url":"https://api.github.com/users/rosti/received_events","type":"User","site_admin":false},"assignees":[{"login":"neolit123","id":331852,"node_id":"MDQ6VXNlcjMzMTg1Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/331852?v=4","gravatar_id":"","url":"https://api.github.com/users/neolit123","html_url":"https://github.com/neolit123","followers_url":"https://api.github.com/users/neolit123/followers","following_url":"https://api.github.com/users/neolit123/following{/other_user}","gists_url":"https://api.github.com/users/neolit123/gists{/gist_id}","starred_url":"https://api.github.com/users/neolit123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neolit123/subscriptions","organizations_url":"https://api.github.com/users/neolit123/orgs","repos_url":"https://api.github.com/users/neolit123/repos","events_url":"https://api.github.com/users/neolit123/events{/privacy}","received_events_url":"https://api.github.com/users/neolit123/received_events","type":"User","site_admin":false},{"login":"rosti","id":1117321,"node_id":"MDQ6VXNlcjExMTczMjE=","avatar_url":"https://avatars1.githubusercontent.com/u/1117321?v=4","gravatar_id":"","url":"https://api.github.com/users/rosti","html_url":"https://github.com/rosti","followers_url":"https://api.github.com/users/rosti/followers","following_url":"https://api.github.com/users/rosti/following{/other_user}","gists_url":"https://api.github.com/users/rosti/gists{/gist_id}","starred_url":"https://api.github.com/users/rosti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosti/subscriptions","organizations_url":"https://api.github.com/users/rosti/orgs","repos_url":"https://api.github.com/users/rosti/repos","events_url":"https://api.github.com/users/rosti/events{/privacy}","received_events_url":"https://api.github.com/users/rosti/received_events","type":"User","site_admin":false},{"login":"fabriziopandini","id":5013060,"node_id":"MDQ6VXNlcjUwMTMwNjA=","avatar_url":"https://avatars0.githubusercontent.com/u/5013060?v=4","gravatar_id":"","url":"https://api.github.com/users/fabriziopandini","html_url":"https://github.com/fabriziopandini","followers_url":"https://api.github.com/users/fabriziopandini/followers","following_url":"https://api.github.com/users/fabriziopandini/following{/other_user}","gists_url":"https://api.github.com/users/fabriziopandini/gists{/gist_id}","starred_url":"https://api.github.com/users/fabriziopandini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabriziopandini/subscriptions","organizations_url":"https://api.github.com/users/fabriziopandini/orgs","repos_url":"https://api.github.com/users/fabriziopandini/repos","events_url":"https://api.github.com/users/fabriziopandini/events{/privacy}","received_events_url":"https://api.github.com/users/fabriziopandini/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2018-12-11T08:57:57Z","updated_at":"2018-12-12T11:15:42Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/71945","html_url":"https://github.com/kubernetes/kubernetes/pull/71945","diff_url":"https://github.com/kubernetes/kubernetes/pull/71945.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/71945.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n\r\n1. If this is your first time, please read our contributor guidelines: https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. For reference on required PR/issue labels, read here:\r\nhttps://git.k8s.io/community/contributors/devel/release.md#issue-kind-label\r\n3. Ensure you have added or ran the appropriate tests for your PR: https://git.k8s.io/community/contributors/devel/testing.md\r\n4. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n5. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n6. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What type of PR is this?**\r\n> Uncomment only one, leave it on its own line:\r\n>\r\n> /kind bug\r\n\r\n**What this PR does / why we need it**:\r\n\r\nThis PR fix kubeadm sync etcd endpoints problem.\r\n\r\n**Which issue(s) this PR fixes**:\r\n<!-- \r\n*Automatically closes linked issue when PR is merged.\r\nUsage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.\r\n_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*\r\n-->\r\nFixes https://github.com/kubernetes/kubeadm/issues/1300\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Does this PR introduce a user-facing change?**:\r\n<!--  \r\nIf no, just write \"NONE\".\r\nIf yes, a release note is required:\r\nEnter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/446551857","html_url":"https://github.com/kubernetes/kubernetes/pull/71945#issuecomment-446551857","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71945","id":446551857,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjU1MTg1Nw==","user":{"login":"fabriziopandini","id":5013060,"node_id":"MDQ6VXNlcjUwMTMwNjA=","avatar_url":"https://avatars0.githubusercontent.com/u/5013060?v=4","gravatar_id":"","url":"https://api.github.com/users/fabriziopandini","html_url":"https://github.com/fabriziopandini","followers_url":"https://api.github.com/users/fabriziopandini/followers","following_url":"https://api.github.com/users/fabriziopandini/following{/other_user}","gists_url":"https://api.github.com/users/fabriziopandini/gists{/gist_id}","starred_url":"https://api.github.com/users/fabriziopandini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabriziopandini/subscriptions","organizations_url":"https://api.github.com/users/fabriziopandini/orgs","repos_url":"https://api.github.com/users/fabriziopandini/repos","events_url":"https://api.github.com/users/fabriziopandini/events{/privacy}","received_events_url":"https://api.github.com/users/fabriziopandini/received_events","type":"User","site_admin":false},"created_at":"2018-12-12T11:15:42Z","updated_at":"2018-12-12T11:15:42Z","author_association":"CONTRIBUTOR","body":"@pytimer thanks for pointing me to @rosti latest comment!\r\n\r\nI kindly ask you to have a little be more of patience while we agree on what is the best solution that allows a small and focused fix that can be safely cherry-picked and also preserve code quality.\r\nAs soon as @neolit123 shows up later today I will try to move this discussion on zoom/slack to get this moving asap.\r\n\r\nIn the meantime, thanks again for your availability and responsiveness. Really appreciated!\r\n\r\n"}}
{"actor":{"display_login":"fabriziopandini"}}