{"action":"created","comment":{"url":"https://api.github.com/repos/cilium/cilium/pulls/comments/179611837","pull_request_review_id":109889853,"id":179611837,"diff_hunk":"@@ -0,0 +1,58 @@\n+Kubernetes Deployment\n+=====================\n+\n+This directory contains all Cilium deployment files that can be used in\n+Kubernetes.\n+\n+Each directory represents a Kubernetes version, from :code:`1.7` to :code:`1.11`,\n+and inside each version there is a list of files to deploy Cilium.\n+\n+The structure directory will be :code:`${k8s_major_version}.${k8s_minor_version}/*.yaml`.\n+\n+To generate those files simply run :code:`make`, which will pick up the Cilium\n+version from the :code:`VERSION` file at the root of the repo, or if you want to\n+specify the Cilium version yourself use :code:`make CILIUM_VERSION=X.Y.Z`.\n+\n+If you want to clean up a specific version, run :code:`make clean` which will\n+delete all generated files.\n+","path":"examples/kubernetes/README.rst","position":18,"original_position":18,"commit_id":"a077cbb59aed2cc3f4d9adad797c85d0fbfc8153","original_commit_id":"5ed16c60dd830de0de594d5cc9818a72d009a784","user":{"login":"manalibhutiyani","id":31253464,"avatar_url":"https://avatars3.githubusercontent.com/u/31253464?v=4","gravatar_id":"","url":"https://api.github.com/users/manalibhutiyani","html_url":"https://github.com/manalibhutiyani","followers_url":"https://api.github.com/users/manalibhutiyani/followers","following_url":"https://api.github.com/users/manalibhutiyani/following{/other_user}","gists_url":"https://api.github.com/users/manalibhutiyani/gists{/gist_id}","starred_url":"https://api.github.com/users/manalibhutiyani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manalibhutiyani/subscriptions","organizations_url":"https://api.github.com/users/manalibhutiyani/orgs","repos_url":"https://api.github.com/users/manalibhutiyani/repos","events_url":"https://api.github.com/users/manalibhutiyani/events{/privacy}","received_events_url":"https://api.github.com/users/manalibhutiyani/received_events","type":"User","site_admin":false},"body":"If you decide to go ahead with `cleanall` or `veryclean` add comment about all directories being cleanup/removed up as well.","created_at":"2018-04-05T21:54:19Z","updated_at":"2018-04-05T21:58:13Z","html_url":"https://github.com/cilium/cilium/pull/3125#discussion_r179611837","pull_request_url":"https://api.github.com/repos/cilium/cilium/pulls/3125","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments/179611837"},"html":{"href":"https://github.com/cilium/cilium/pull/3125#discussion_r179611837"},"pull_request":{"href":"https://api.github.com/repos/cilium/cilium/pulls/3125"}}},"pull_request":{"url":"https://api.github.com/repos/cilium/cilium/pulls/3125","id":174809159,"html_url":"https://github.com/cilium/cilium/pull/3125","diff_url":"https://github.com/cilium/cilium/pull/3125.diff","patch_url":"https://github.com/cilium/cilium/pull/3125.patch","issue_url":"https://api.github.com/repos/cilium/cilium/issues/3125","number":3125,"state":"open","locked":false,"title":"Introducing Kubernetes spec files auto-generator","user":{"login":"aanm","id":5714066,"avatar_url":"https://avatars0.githubusercontent.com/u/5714066?v=4","gravatar_id":"","url":"https://api.github.com/users/aanm","html_url":"https://github.com/aanm","followers_url":"https://api.github.com/users/aanm/followers","following_url":"https://api.github.com/users/aanm/following{/other_user}","gists_url":"https://api.github.com/users/aanm/gists{/gist_id}","starred_url":"https://api.github.com/users/aanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aanm/subscriptions","organizations_url":"https://api.github.com/users/aanm/orgs","repos_url":"https://api.github.com/users/aanm/repos","events_url":"https://api.github.com/users/aanm/events{/privacy}","received_events_url":"https://api.github.com/users/aanm/received_events","type":"User","site_admin":false},"body":"Introduced the Kubernetes spec files auto-generator.\r\n\r\nThe explanation can be found in `examples/kubernetes/README.rst` in this PR.\r\n\r\nSome questions:\r\n- Should we remove `examples/cilium.yaml`?\r\n- How can we make use of directory structure in the documentation? (Example tabs like these ones maybe? http://cilium.readthedocs.io/en/latest/policy/language/?highlight=l7%20policy#simple-ingress-allow)\r\n- How can we guarantee the generated files are being tested? cc @cilium/ci  ","created_at":"2018-03-13T22:37:04Z","updated_at":"2018-04-05T21:58:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"034751a4fb44187b984f937d138de26feae43bca","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tgraf","id":1417913,"avatar_url":"https://avatars1.githubusercontent.com/u/1417913?v=4","gravatar_id":"","url":"https://api.github.com/users/tgraf","html_url":"https://github.com/tgraf","followers_url":"https://api.github.com/users/tgraf/followers","following_url":"https://api.github.com/users/tgraf/following{/other_user}","gists_url":"https://api.github.com/users/tgraf/gists{/gist_id}","starred_url":"https://api.github.com/users/tgraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgraf/subscriptions","organizations_url":"https://api.github.com/users/tgraf/orgs","repos_url":"https://api.github.com/users/tgraf/repos","events_url":"https://api.github.com/users/tgraf/events{/privacy}","received_events_url":"https://api.github.com/users/tgraf/received_events","type":"User","site_admin":false}],"requested_teams":[{"name":"ci","id":2519781,"slug":"ci","description":"CI integration","privacy":"closed","url":"https://api.github.com/teams/2519781","members_url":"https://api.github.com/teams/2519781/members{/member}","repositories_url":"https://api.github.com/teams/2519781/repos","permission":"pull"}],"labels":[{"id":665378286,"url":"https://api.github.com/repos/cilium/cilium/labels/area/documentation","name":"area/documentation","color":"1d76db","default":false},{"id":721366651,"url":"https://api.github.com/repos/cilium/cilium/labels/area/k8s","name":"area/k8s","color":"2c3aa0","default":false},{"id":403149902,"url":"https://api.github.com/repos/cilium/cilium/labels/pending-review","name":"pending-review","color":"fbca04","default":false},{"id":809259668,"url":"https://api.github.com/repos/cilium/cilium/labels/priority/1.0-blocker","name":"priority/1.0-blocker","color":"b60205","default":false},{"id":755967519,"url":"https://api.github.com/repos/cilium/cilium/labels/ready-to-merge","name":"ready-to-merge","color":"0e8a16","default":false},{"id":573463687,"url":"https://api.github.com/repos/cilium/cilium/labels/stable/needs-backport","name":"stable/needs-backport","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cilium/cilium/pulls/3125/commits","review_comments_url":"https://api.github.com/repos/cilium/cilium/pulls/3125/comments","review_comment_url":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cilium/cilium/issues/3125/comments","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/a077cbb59aed2cc3f4d9adad797c85d0fbfc8153","head":{"label":"cilium:creating-k8s-spec-files","ref":"creating-k8s-spec-files","sha":"a077cbb59aed2cc3f4d9adad797c85d0fbfc8153","user":{"login":"cilium","id":21054566,"avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"name":"cilium","full_name":"cilium/cilium","owner":{"login":"cilium","id":21054566,"avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cilium/cilium","description":"HTTP, gRPC, and Kafka Aware Security and Networking for Containers with BPF and XDP","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2018-04-05T21:55:56Z","pushed_at":"2018-04-05T21:55:48Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"git@github.com:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":44114,"stargazers_count":1723,"watchers_count":1723,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":165,"mirror_url":null,"archived":false,"open_issues_count":470,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":165,"open_issues":470,"watchers":1723,"default_branch":"master"}},"base":{"label":"cilium:master","ref":"master","sha":"e50a830ce6c6c797b6c189199ce539870afa3f8f","user":{"login":"cilium","id":21054566,"avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"name":"cilium","full_name":"cilium/cilium","owner":{"login":"cilium","id":21054566,"avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cilium/cilium","description":"HTTP, gRPC, and Kafka Aware Security and Networking for Containers with BPF and XDP","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2018-04-05T21:55:56Z","pushed_at":"2018-04-05T21:55:48Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"git@github.com:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":44114,"stargazers_count":1723,"watchers_count":1723,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":165,"mirror_url":null,"archived":false,"open_issues_count":470,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":165,"open_issues":470,"watchers":1723,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/3125"},"html":{"href":"https://github.com/cilium/cilium/pull/3125"},"issue":{"href":"https://api.github.com/repos/cilium/cilium/issues/3125"},"comments":{"href":"https://api.github.com/repos/cilium/cilium/issues/3125/comments"},"review_comments":{"href":"https://api.github.com/repos/cilium/cilium/pulls/3125/comments"},"review_comment":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cilium/cilium/pulls/3125/commits"},"statuses":{"href":"https://api.github.com/repos/cilium/cilium/statuses/a077cbb59aed2cc3f4d9adad797c85d0fbfc8153"}},"author_association":"OWNER"}}
{"actor":{"display_login":"manalibhutiyani"}}