{"action":"opened","number":180,"pull_request":{"url":"https://api.github.com/repos/PragTob/benchee/pulls/180","id":170281529,"html_url":"https://github.com/PragTob/benchee/pull/180","diff_url":"https://github.com/PragTob/benchee/pull/180.diff","patch_url":"https://github.com/PragTob/benchee/pull/180.patch","issue_url":"https://api.github.com/repos/PragTob/benchee/issues/180","number":180,"state":"open","locked":false,"title":"Calculate memory stats","user":{"login":"devonestes","id":8422484,"avatar_url":"https://avatars1.githubusercontent.com/u/8422484?v=4","gravatar_id":"","url":"https://api.github.com/users/devonestes","html_url":"https://github.com/devonestes","followers_url":"https://api.github.com/users/devonestes/followers","following_url":"https://api.github.com/users/devonestes/following{/other_user}","gists_url":"https://api.github.com/users/devonestes/gists{/gist_id}","starred_url":"https://api.github.com/users/devonestes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devonestes/subscriptions","organizations_url":"https://api.github.com/users/devonestes/orgs","repos_url":"https://api.github.com/users/devonestes/repos","events_url":"https://api.github.com/users/devonestes/events{/privacy}","received_events_url":"https://api.github.com/users/devonestes/received_events","type":"User","site_admin":false},"body":"Ok, at this point a lot is going on here. Right now there are _minimal_ tests on the new behavior, which I've used to refactor the initial messy implementation into something not too bad. At this point, things I still have left to do are:\r\n\r\n* rename some functions that still imply relationship to run time measurements\r\n* add a bunch more tests for new behavior\r\n* document this fully\r\n* add extended output for memory usage stats if requested\r\n\r\nThe major things I've done in this PR so far are:\r\n\r\n* add @michalmuskala's new memory measurement module\r\n* add memory measurement to the console formatter\r\n* split the console formatter into three modules - one for run times, one for memory, and one for shared functions between the two of them\r\n\r\nSo, right now just about everything is working (except the extended statistics for memory), and if y'all wanted to you could play with it. It'll take some time to fully test and document everything, which is why I wanted to put this up now to get feedback while I'm starting on that stuff.","created_at":"2018-02-20T19:08:43Z","updated_at":"2018-02-20T19:08:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PragTob/benchee/pulls/180/commits","review_comments_url":"https://api.github.com/repos/PragTob/benchee/pulls/180/comments","review_comment_url":"https://api.github.com/repos/PragTob/benchee/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PragTob/benchee/issues/180/comments","statuses_url":"https://api.github.com/repos/PragTob/benchee/statuses/7f78bd4fdfe1214dba9d242c2192d9a68764f4c7","head":{"label":"PragTob:calculate-memory-stats","ref":"calculate-memory-stats","sha":"7f78bd4fdfe1214dba9d242c2192d9a68764f4c7","user":{"login":"PragTob","id":606517,"avatar_url":"https://avatars1.githubusercontent.com/u/606517?v=4","gravatar_id":"","url":"https://api.github.com/users/PragTob","html_url":"https://github.com/PragTob","followers_url":"https://api.github.com/users/PragTob/followers","following_url":"https://api.github.com/users/PragTob/following{/other_user}","gists_url":"https://api.github.com/users/PragTob/gists{/gist_id}","starred_url":"https://api.github.com/users/PragTob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PragTob/subscriptions","organizations_url":"https://api.github.com/users/PragTob/orgs","repos_url":"https://api.github.com/users/PragTob/repos","events_url":"https://api.github.com/users/PragTob/events{/privacy}","received_events_url":"https://api.github.com/users/PragTob/received_events","type":"User","site_admin":false},"repo":{"id":59428665,"name":"benchee","full_name":"PragTob/benchee","owner":{"login":"PragTob","id":606517,"avatar_url":"https://avatars1.githubusercontent.com/u/606517?v=4","gravatar_id":"","url":"https://api.github.com/users/PragTob","html_url":"https://github.com/PragTob","followers_url":"https://api.github.com/users/PragTob/followers","following_url":"https://api.github.com/users/PragTob/following{/other_user}","gists_url":"https://api.github.com/users/PragTob/gists{/gist_id}","starred_url":"https://api.github.com/users/PragTob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PragTob/subscriptions","organizations_url":"https://api.github.com/users/PragTob/orgs","repos_url":"https://api.github.com/users/PragTob/repos","events_url":"https://api.github.com/users/PragTob/events{/privacy}","received_events_url":"https://api.github.com/users/PragTob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PragTob/benchee","description":"Easy and extensible benchmarking in Elixir providing you with lots of statistics!","fork":false,"url":"https://api.github.com/repos/PragTob/benchee","forks_url":"https://api.github.com/repos/PragTob/benchee/forks","keys_url":"https://api.github.com/repos/PragTob/benchee/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PragTob/benchee/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PragTob/benchee/teams","hooks_url":"https://api.github.com/repos/PragTob/benchee/hooks","issue_events_url":"https://api.github.com/repos/PragTob/benchee/issues/events{/number}","events_url":"https://api.github.com/repos/PragTob/benchee/events","assignees_url":"https://api.github.com/repos/PragTob/benchee/assignees{/user}","branches_url":"https://api.github.com/repos/PragTob/benchee/branches{/branch}","tags_url":"https://api.github.com/repos/PragTob/benchee/tags","blobs_url":"https://api.github.com/repos/PragTob/benchee/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PragTob/benchee/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PragTob/benchee/git/refs{/sha}","trees_url":"https://api.github.com/repos/PragTob/benchee/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PragTob/benchee/statuses/{sha}","languages_url":"https://api.github.com/repos/PragTob/benchee/languages","stargazers_url":"https://api.github.com/repos/PragTob/benchee/stargazers","contributors_url":"https://api.github.com/repos/PragTob/benchee/contributors","subscribers_url":"https://api.github.com/repos/PragTob/benchee/subscribers","subscription_url":"https://api.github.com/repos/PragTob/benchee/subscription","commits_url":"https://api.github.com/repos/PragTob/benchee/commits{/sha}","git_commits_url":"https://api.github.com/repos/PragTob/benchee/git/commits{/sha}","comments_url":"https://api.github.com/repos/PragTob/benchee/comments{/number}","issue_comment_url":"https://api.github.com/repos/PragTob/benchee/issues/comments{/number}","contents_url":"https://api.github.com/repos/PragTob/benchee/contents/{+path}","compare_url":"https://api.github.com/repos/PragTob/benchee/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PragTob/benchee/merges","archive_url":"https://api.github.com/repos/PragTob/benchee/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PragTob/benchee/downloads","issues_url":"https://api.github.com/repos/PragTob/benchee/issues{/number}","pulls_url":"https://api.github.com/repos/PragTob/benchee/pulls{/number}","milestones_url":"https://api.github.com/repos/PragTob/benchee/milestones{/number}","notifications_url":"https://api.github.com/repos/PragTob/benchee/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PragTob/benchee/labels{/name}","releases_url":"https://api.github.com/repos/PragTob/benchee/releases{/id}","deployments_url":"https://api.github.com/repos/PragTob/benchee/deployments","created_at":"2016-05-22T18:48:43Z","updated_at":"2018-02-14T01:51:22Z","pushed_at":"2018-02-20T14:54:52Z","git_url":"git://github.com/PragTob/benchee.git","ssh_url":"git@github.com:PragTob/benchee.git","clone_url":"https://github.com/PragTob/benchee.git","svn_url":"https://github.com/PragTob/benchee","homepage":"","size":871,"stargazers_count":352,"watchers_count":352,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":24,"open_issues":22,"watchers":352,"default_branch":"master"}},"base":{"label":"PragTob:master","ref":"master","sha":"3b60c17b067a7e7503cb0fb6e40bdc92ffde3fbd","user":{"login":"PragTob","id":606517,"avatar_url":"https://avatars1.githubusercontent.com/u/606517?v=4","gravatar_id":"","url":"https://api.github.com/users/PragTob","html_url":"https://github.com/PragTob","followers_url":"https://api.github.com/users/PragTob/followers","following_url":"https://api.github.com/users/PragTob/following{/other_user}","gists_url":"https://api.github.com/users/PragTob/gists{/gist_id}","starred_url":"https://api.github.com/users/PragTob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PragTob/subscriptions","organizations_url":"https://api.github.com/users/PragTob/orgs","repos_url":"https://api.github.com/users/PragTob/repos","events_url":"https://api.github.com/users/PragTob/events{/privacy}","received_events_url":"https://api.github.com/users/PragTob/received_events","type":"User","site_admin":false},"repo":{"id":59428665,"name":"benchee","full_name":"PragTob/benchee","owner":{"login":"PragTob","id":606517,"avatar_url":"https://avatars1.githubusercontent.com/u/606517?v=4","gravatar_id":"","url":"https://api.github.com/users/PragTob","html_url":"https://github.com/PragTob","followers_url":"https://api.github.com/users/PragTob/followers","following_url":"https://api.github.com/users/PragTob/following{/other_user}","gists_url":"https://api.github.com/users/PragTob/gists{/gist_id}","starred_url":"https://api.github.com/users/PragTob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PragTob/subscriptions","organizations_url":"https://api.github.com/users/PragTob/orgs","repos_url":"https://api.github.com/users/PragTob/repos","events_url":"https://api.github.com/users/PragTob/events{/privacy}","received_events_url":"https://api.github.com/users/PragTob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PragTob/benchee","description":"Easy and extensible benchmarking in Elixir providing you with lots of statistics!","fork":false,"url":"https://api.github.com/repos/PragTob/benchee","forks_url":"https://api.github.com/repos/PragTob/benchee/forks","keys_url":"https://api.github.com/repos/PragTob/benchee/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PragTob/benchee/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PragTob/benchee/teams","hooks_url":"https://api.github.com/repos/PragTob/benchee/hooks","issue_events_url":"https://api.github.com/repos/PragTob/benchee/issues/events{/number}","events_url":"https://api.github.com/repos/PragTob/benchee/events","assignees_url":"https://api.github.com/repos/PragTob/benchee/assignees{/user}","branches_url":"https://api.github.com/repos/PragTob/benchee/branches{/branch}","tags_url":"https://api.github.com/repos/PragTob/benchee/tags","blobs_url":"https://api.github.com/repos/PragTob/benchee/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PragTob/benchee/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PragTob/benchee/git/refs{/sha}","trees_url":"https://api.github.com/repos/PragTob/benchee/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PragTob/benchee/statuses/{sha}","languages_url":"https://api.github.com/repos/PragTob/benchee/languages","stargazers_url":"https://api.github.com/repos/PragTob/benchee/stargazers","contributors_url":"https://api.github.com/repos/PragTob/benchee/contributors","subscribers_url":"https://api.github.com/repos/PragTob/benchee/subscribers","subscription_url":"https://api.github.com/repos/PragTob/benchee/subscription","commits_url":"https://api.github.com/repos/PragTob/benchee/commits{/sha}","git_commits_url":"https://api.github.com/repos/PragTob/benchee/git/commits{/sha}","comments_url":"https://api.github.com/repos/PragTob/benchee/comments{/number}","issue_comment_url":"https://api.github.com/repos/PragTob/benchee/issues/comments{/number}","contents_url":"https://api.github.com/repos/PragTob/benchee/contents/{+path}","compare_url":"https://api.github.com/repos/PragTob/benchee/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PragTob/benchee/merges","archive_url":"https://api.github.com/repos/PragTob/benchee/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PragTob/benchee/downloads","issues_url":"https://api.github.com/repos/PragTob/benchee/issues{/number}","pulls_url":"https://api.github.com/repos/PragTob/benchee/pulls{/number}","milestones_url":"https://api.github.com/repos/PragTob/benchee/milestones{/number}","notifications_url":"https://api.github.com/repos/PragTob/benchee/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PragTob/benchee/labels{/name}","releases_url":"https://api.github.com/repos/PragTob/benchee/releases{/id}","deployments_url":"https://api.github.com/repos/PragTob/benchee/deployments","created_at":"2016-05-22T18:48:43Z","updated_at":"2018-02-14T01:51:22Z","pushed_at":"2018-02-20T14:54:52Z","git_url":"git://github.com/PragTob/benchee.git","ssh_url":"git@github.com:PragTob/benchee.git","clone_url":"https://github.com/PragTob/benchee.git","svn_url":"https://github.com/PragTob/benchee","homepage":"","size":871,"stargazers_count":352,"watchers_count":352,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":24,"open_issues":22,"watchers":352,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PragTob/benchee/pulls/180"},"html":{"href":"https://github.com/PragTob/benchee/pull/180"},"issue":{"href":"https://api.github.com/repos/PragTob/benchee/issues/180"},"comments":{"href":"https://api.github.com/repos/PragTob/benchee/issues/180/comments"},"review_comments":{"href":"https://api.github.com/repos/PragTob/benchee/pulls/180/comments"},"review_comment":{"href":"https://api.github.com/repos/PragTob/benchee/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PragTob/benchee/pulls/180/commits"},"statuses":{"href":"https://api.github.com/repos/PragTob/benchee/statuses/7f78bd4fdfe1214dba9d242c2192d9a68764f4c7"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":11,"additions":1225,"deletions":758,"changed_files":17}}
{"actor":{"display_login":"devonestes"}}