{"action":"opened","number":487,"pull_request":{"url":"https://api.github.com/repos/prebid/prebid-server/pulls/487","id":185003287,"html_url":"https://github.com/prebid/prebid-server/pull/487","diff_url":"https://github.com/prebid/prebid-server/pull/487.diff","patch_url":"https://github.com/prebid/prebid-server/pull/487.patch","issue_url":"https://api.github.com/repos/prebid/prebid-server/issues/487","number":487,"state":"open","locked":false,"title":"Make end-to-end tests documentation-friendly","user":{"login":"dbemiller","id":27972385,"avatar_url":"https://avatars2.githubusercontent.com/u/27972385?v=4","gravatar_id":"","url":"https://api.github.com/users/dbemiller","html_url":"https://github.com/dbemiller","followers_url":"https://api.github.com/users/dbemiller/followers","following_url":"https://api.github.com/users/dbemiller/following{/other_user}","gists_url":"https://api.github.com/users/dbemiller/gists{/gist_id}","starred_url":"https://api.github.com/users/dbemiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbemiller/subscriptions","organizations_url":"https://api.github.com/users/dbemiller/orgs","repos_url":"https://api.github.com/users/dbemiller/repos","events_url":"https://api.github.com/users/dbemiller/events{/privacy}","received_events_url":"https://api.github.com/users/dbemiller/received_events","type":"User","site_admin":false},"body":"The end-to-end tests on `/openrtb2/auction` today mocked out the params validator.\r\n\r\nThis seemed like a good idea at the time, to test code in isolation, but... we've been getting tons of requests for better examples. When asked \"where can I find an example request?\" my answer has been \"look at this file... but you'll need to replace the bidder params with real ones. Bidder params can be found {elsewhere}.... yada yada.\"\r\n\r\nTo someone unfamiliar with the project, it's not even really clear where \"bidder params\" go, in the request payloads... so the user experience is pretty painful.\r\n\r\nThis PR replaces the mock params validator with the real one, and replaces the requests with the prebid sample ad param.\r\n\r\nIt also splits the files up into `exemplary` and `supplementary`, similar to how the Bidders do today. The `exemplary` tests are allowed a description field which can be used to explain how they work.\r\n\r\nIn the future, I plan to:\r\n\r\n1. Poke @mjacobsonny to see which examples he thinks are valuable\r\n2. Move all the JSON samples from `auction.md` into these files and replace them with links, so the CI tests run against them.","created_at":"2018-04-30T16:32:29Z","updated_at":"2018-04-30T16:32:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/prebid/prebid-server/pulls/487/commits","review_comments_url":"https://api.github.com/repos/prebid/prebid-server/pulls/487/comments","review_comment_url":"https://api.github.com/repos/prebid/prebid-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prebid/prebid-server/issues/487/comments","statuses_url":"https://api.github.com/repos/prebid/prebid-server/statuses/1384e339b6031f89d20e254f38047244dc879922","head":{"label":"prebid:set-example-tests","ref":"set-example-tests","sha":"1384e339b6031f89d20e254f38047244dc879922","user":{"login":"prebid","id":13242760,"avatar_url":"https://avatars1.githubusercontent.com/u/13242760?v=4","gravatar_id":"","url":"https://api.github.com/users/prebid","html_url":"https://github.com/prebid","followers_url":"https://api.github.com/users/prebid/followers","following_url":"https://api.github.com/users/prebid/following{/other_user}","gists_url":"https://api.github.com/users/prebid/gists{/gist_id}","starred_url":"https://api.github.com/users/prebid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prebid/subscriptions","organizations_url":"https://api.github.com/users/prebid/orgs","repos_url":"https://api.github.com/users/prebid/repos","events_url":"https://api.github.com/users/prebid/events{/privacy}","received_events_url":"https://api.github.com/users/prebid/received_events","type":"Organization","site_admin":false},"repo":{"id":88511474,"name":"prebid-server","full_name":"prebid/prebid-server","owner":{"login":"prebid","id":13242760,"avatar_url":"https://avatars1.githubusercontent.com/u/13242760?v=4","gravatar_id":"","url":"https://api.github.com/users/prebid","html_url":"https://github.com/prebid","followers_url":"https://api.github.com/users/prebid/followers","following_url":"https://api.github.com/users/prebid/following{/other_user}","gists_url":"https://api.github.com/users/prebid/gists{/gist_id}","starred_url":"https://api.github.com/users/prebid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prebid/subscriptions","organizations_url":"https://api.github.com/users/prebid/orgs","repos_url":"https://api.github.com/users/prebid/repos","events_url":"https://api.github.com/users/prebid/events{/privacy}","received_events_url":"https://api.github.com/users/prebid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prebid/prebid-server","description":"Server side component to offload prebid processing to the cloud","fork":false,"url":"https://api.github.com/repos/prebid/prebid-server","forks_url":"https://api.github.com/repos/prebid/prebid-server/forks","keys_url":"https://api.github.com/repos/prebid/prebid-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prebid/prebid-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prebid/prebid-server/teams","hooks_url":"https://api.github.com/repos/prebid/prebid-server/hooks","issue_events_url":"https://api.github.com/repos/prebid/prebid-server/issues/events{/number}","events_url":"https://api.github.com/repos/prebid/prebid-server/events","assignees_url":"https://api.github.com/repos/prebid/prebid-server/assignees{/user}","branches_url":"https://api.github.com/repos/prebid/prebid-server/branches{/branch}","tags_url":"https://api.github.com/repos/prebid/prebid-server/tags","blobs_url":"https://api.github.com/repos/prebid/prebid-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prebid/prebid-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prebid/prebid-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/prebid/prebid-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prebid/prebid-server/statuses/{sha}","languages_url":"https://api.github.com/repos/prebid/prebid-server/languages","stargazers_url":"https://api.github.com/repos/prebid/prebid-server/stargazers","contributors_url":"https://api.github.com/repos/prebid/prebid-server/contributors","subscribers_url":"https://api.github.com/repos/prebid/prebid-server/subscribers","subscription_url":"https://api.github.com/repos/prebid/prebid-server/subscription","commits_url":"https://api.github.com/repos/prebid/prebid-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/prebid/prebid-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/prebid/prebid-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/prebid/prebid-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/prebid/prebid-server/contents/{+path}","compare_url":"https://api.github.com/repos/prebid/prebid-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prebid/prebid-server/merges","archive_url":"https://api.github.com/repos/prebid/prebid-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prebid/prebid-server/downloads","issues_url":"https://api.github.com/repos/prebid/prebid-server/issues{/number}","pulls_url":"https://api.github.com/repos/prebid/prebid-server/pulls{/number}","milestones_url":"https://api.github.com/repos/prebid/prebid-server/milestones{/number}","notifications_url":"https://api.github.com/repos/prebid/prebid-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prebid/prebid-server/labels{/name}","releases_url":"https://api.github.com/repos/prebid/prebid-server/releases{/id}","deployments_url":"https://api.github.com/repos/prebid/prebid-server/deployments","created_at":"2017-04-17T13:38:32Z","updated_at":"2018-04-30T13:56:30Z","pushed_at":"2018-04-30T16:29:59Z","git_url":"git://github.com/prebid/prebid-server.git","ssh_url":"git@github.com:prebid/prebid-server.git","clone_url":"https://github.com/prebid/prebid-server.git","svn_url":"https://github.com/prebid/prebid-server","homepage":null,"size":7431,"stargazers_count":66,"watchers_count":66,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":74,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":74,"open_issues":43,"watchers":66,"default_branch":"master"}},"base":{"label":"prebid:master","ref":"master","sha":"1f1d17d7be9c6b298bf44011eb2dca7e72e27bc5","user":{"login":"prebid","id":13242760,"avatar_url":"https://avatars1.githubusercontent.com/u/13242760?v=4","gravatar_id":"","url":"https://api.github.com/users/prebid","html_url":"https://github.com/prebid","followers_url":"https://api.github.com/users/prebid/followers","following_url":"https://api.github.com/users/prebid/following{/other_user}","gists_url":"https://api.github.com/users/prebid/gists{/gist_id}","starred_url":"https://api.github.com/users/prebid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prebid/subscriptions","organizations_url":"https://api.github.com/users/prebid/orgs","repos_url":"https://api.github.com/users/prebid/repos","events_url":"https://api.github.com/users/prebid/events{/privacy}","received_events_url":"https://api.github.com/users/prebid/received_events","type":"Organization","site_admin":false},"repo":{"id":88511474,"name":"prebid-server","full_name":"prebid/prebid-server","owner":{"login":"prebid","id":13242760,"avatar_url":"https://avatars1.githubusercontent.com/u/13242760?v=4","gravatar_id":"","url":"https://api.github.com/users/prebid","html_url":"https://github.com/prebid","followers_url":"https://api.github.com/users/prebid/followers","following_url":"https://api.github.com/users/prebid/following{/other_user}","gists_url":"https://api.github.com/users/prebid/gists{/gist_id}","starred_url":"https://api.github.com/users/prebid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prebid/subscriptions","organizations_url":"https://api.github.com/users/prebid/orgs","repos_url":"https://api.github.com/users/prebid/repos","events_url":"https://api.github.com/users/prebid/events{/privacy}","received_events_url":"https://api.github.com/users/prebid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prebid/prebid-server","description":"Server side component to offload prebid processing to the cloud","fork":false,"url":"https://api.github.com/repos/prebid/prebid-server","forks_url":"https://api.github.com/repos/prebid/prebid-server/forks","keys_url":"https://api.github.com/repos/prebid/prebid-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prebid/prebid-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prebid/prebid-server/teams","hooks_url":"https://api.github.com/repos/prebid/prebid-server/hooks","issue_events_url":"https://api.github.com/repos/prebid/prebid-server/issues/events{/number}","events_url":"https://api.github.com/repos/prebid/prebid-server/events","assignees_url":"https://api.github.com/repos/prebid/prebid-server/assignees{/user}","branches_url":"https://api.github.com/repos/prebid/prebid-server/branches{/branch}","tags_url":"https://api.github.com/repos/prebid/prebid-server/tags","blobs_url":"https://api.github.com/repos/prebid/prebid-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prebid/prebid-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prebid/prebid-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/prebid/prebid-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prebid/prebid-server/statuses/{sha}","languages_url":"https://api.github.com/repos/prebid/prebid-server/languages","stargazers_url":"https://api.github.com/repos/prebid/prebid-server/stargazers","contributors_url":"https://api.github.com/repos/prebid/prebid-server/contributors","subscribers_url":"https://api.github.com/repos/prebid/prebid-server/subscribers","subscription_url":"https://api.github.com/repos/prebid/prebid-server/subscription","commits_url":"https://api.github.com/repos/prebid/prebid-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/prebid/prebid-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/prebid/prebid-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/prebid/prebid-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/prebid/prebid-server/contents/{+path}","compare_url":"https://api.github.com/repos/prebid/prebid-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prebid/prebid-server/merges","archive_url":"https://api.github.com/repos/prebid/prebid-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prebid/prebid-server/downloads","issues_url":"https://api.github.com/repos/prebid/prebid-server/issues{/number}","pulls_url":"https://api.github.com/repos/prebid/prebid-server/pulls{/number}","milestones_url":"https://api.github.com/repos/prebid/prebid-server/milestones{/number}","notifications_url":"https://api.github.com/repos/prebid/prebid-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prebid/prebid-server/labels{/name}","releases_url":"https://api.github.com/repos/prebid/prebid-server/releases{/id}","deployments_url":"https://api.github.com/repos/prebid/prebid-server/deployments","created_at":"2017-04-17T13:38:32Z","updated_at":"2018-04-30T13:56:30Z","pushed_at":"2018-04-30T16:29:59Z","git_url":"git://github.com/prebid/prebid-server.git","ssh_url":"git@github.com:prebid/prebid-server.git","clone_url":"https://github.com/prebid/prebid-server.git","svn_url":"https://github.com/prebid/prebid-server","homepage":null,"size":7431,"stargazers_count":66,"watchers_count":66,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":74,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":74,"open_issues":43,"watchers":66,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prebid/prebid-server/pulls/487"},"html":{"href":"https://github.com/prebid/prebid-server/pull/487"},"issue":{"href":"https://api.github.com/repos/prebid/prebid-server/issues/487"},"comments":{"href":"https://api.github.com/repos/prebid/prebid-server/issues/487/comments"},"review_comments":{"href":"https://api.github.com/repos/prebid/prebid-server/pulls/487/comments"},"review_comment":{"href":"https://api.github.com/repos/prebid/prebid-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prebid/prebid-server/pulls/487/commits"},"statuses":{"href":"https://api.github.com/repos/prebid/prebid-server/statuses/1384e339b6031f89d20e254f38047244dc879922"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":8,"additions":437,"deletions":303,"changed_files":23}}
{"actor":{"display_login":"dbemiller"}}