{"action":"created","issue":{"url":"https://api.github.com/repos/root-project/root/issues/3150","repository_url":"https://api.github.com/repos/root-project/root","labels_url":"https://api.github.com/repos/root-project/root/issues/3150/labels{/name}","comments_url":"https://api.github.com/repos/root-project/root/issues/3150/comments","events_url":"https://api.github.com/repos/root-project/root/issues/3150/events","html_url":"https://github.com/root-project/root/pull/3150","id":389648602,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NTkwMjM4","number":3150,"title":"THistPainter fixes, ROOT-9655","user":{"login":"dajiaonao","id":17641689,"node_id":"MDQ6VXNlcjE3NjQxNjg5","avatar_url":"https://avatars3.githubusercontent.com/u/17641689?v=4","gravatar_id":"","url":"https://api.github.com/users/dajiaonao","html_url":"https://github.com/dajiaonao","followers_url":"https://api.github.com/users/dajiaonao/followers","following_url":"https://api.github.com/users/dajiaonao/following{/other_user}","gists_url":"https://api.github.com/users/dajiaonao/gists{/gist_id}","starred_url":"https://api.github.com/users/dajiaonao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dajiaonao/subscriptions","organizations_url":"https://api.github.com/users/dajiaonao/orgs","repos_url":"https://api.github.com/users/dajiaonao/repos","events_url":"https://api.github.com/users/dajiaonao/events{/privacy}","received_events_url":"https://api.github.com/users/dajiaonao/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"couet","id":4697738,"node_id":"MDQ6VXNlcjQ2OTc3Mzg=","avatar_url":"https://avatars1.githubusercontent.com/u/4697738?v=4","gravatar_id":"","url":"https://api.github.com/users/couet","html_url":"https://github.com/couet","followers_url":"https://api.github.com/users/couet/followers","following_url":"https://api.github.com/users/couet/following{/other_user}","gists_url":"https://api.github.com/users/couet/gists{/gist_id}","starred_url":"https://api.github.com/users/couet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/couet/subscriptions","organizations_url":"https://api.github.com/users/couet/orgs","repos_url":"https://api.github.com/users/couet/repos","events_url":"https://api.github.com/users/couet/events{/privacy}","received_events_url":"https://api.github.com/users/couet/received_events","type":"User","site_admin":false},"assignees":[{"login":"couet","id":4697738,"node_id":"MDQ6VXNlcjQ2OTc3Mzg=","avatar_url":"https://avatars1.githubusercontent.com/u/4697738?v=4","gravatar_id":"","url":"https://api.github.com/users/couet","html_url":"https://github.com/couet","followers_url":"https://api.github.com/users/couet/followers","following_url":"https://api.github.com/users/couet/following{/other_user}","gists_url":"https://api.github.com/users/couet/gists{/gist_id}","starred_url":"https://api.github.com/users/couet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/couet/subscriptions","organizations_url":"https://api.github.com/users/couet/orgs","repos_url":"https://api.github.com/users/couet/repos","events_url":"https://api.github.com/users/couet/events{/privacy}","received_events_url":"https://api.github.com/users/couet/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2018-12-11T08:35:11Z","updated_at":"2018-12-17T14:18:28Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/root-project/root/pulls/3150","html_url":"https://github.com/root-project/root/pull/3150","diff_url":"https://github.com/root-project/root/pull/3150.diff","patch_url":"https://github.com/root-project/root/pull/3150.patch"},"body":"Hi,\r\nI'm trying to add a patch to address the issue here: https://sft.its.cern.ch/jira/browse/ROOT-9655.\r\nThere are two features:\r\n1) using the default option, TPaletteAxis will have the same range as the early histogram that the current histogram is normalized to, and thus the correct palette;\r\n2) New options \"SAME0\" and \"SAMES0\" to allow opting out of the default normalization."},"comment":{"url":"https://api.github.com/repos/root-project/root/issues/comments/447861372","html_url":"https://github.com/root-project/root/pull/3150#issuecomment-447861372","issue_url":"https://api.github.com/repos/root-project/root/issues/3150","id":447861372,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Nzg2MTM3Mg==","user":{"login":"dajiaonao","id":17641689,"node_id":"MDQ6VXNlcjE3NjQxNjg5","avatar_url":"https://avatars3.githubusercontent.com/u/17641689?v=4","gravatar_id":"","url":"https://api.github.com/users/dajiaonao","html_url":"https://github.com/dajiaonao","followers_url":"https://api.github.com/users/dajiaonao/followers","following_url":"https://api.github.com/users/dajiaonao/following{/other_user}","gists_url":"https://api.github.com/users/dajiaonao/gists{/gist_id}","starred_url":"https://api.github.com/users/dajiaonao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dajiaonao/subscriptions","organizations_url":"https://api.github.com/users/dajiaonao/orgs","repos_url":"https://api.github.com/users/dajiaonao/repos","events_url":"https://api.github.com/users/dajiaonao/events{/privacy}","received_events_url":"https://api.github.com/users/dajiaonao/received_events","type":"User","site_admin":false},"created_at":"2018-12-17T14:18:28Z","updated_at":"2018-12-17T14:18:28Z","author_association":"NONE","body":"> Thanks for the update. I have still one question/worry. How the '0' of your new option SAME0 will work when combined with some other options allowing also 0 (like colz0)? Imagine the following option \"SAME COLZ0\"... COLZ0 is valid. That may be misunderstood with your new code ?\r\n\r\nI actually just followed the COL1 example in the existing code. If I understand correctly, the code will find the \"SAME\" first, and then check if there is a 0 immediately after it. The similar thing is done for the \"COLZ\" option. So it can distinguish \"SAME0 COLZ\" and \"SAME COLZ0\". This is also confirmed by a quick test of the code."}}
{"actor":{"display_login":"dajiaonao"}}