{"action":"created","issue":{"url":"https://api.github.com/repos/electron/electron/issues/13519","repository_url":"https://api.github.com/repos/electron/electron","labels_url":"https://api.github.com/repos/electron/electron/issues/13519/labels{/name}","comments_url":"https://api.github.com/repos/electron/electron/issues/13519/comments","events_url":"https://api.github.com/repos/electron/electron/issues/13519/events","html_url":"https://github.com/electron/electron/issues/13519","id":337223491,"node_id":"MDU6SXNzdWUzMzcyMjM0OTE=","number":13519,"title":"Registering and intercepting stream protocols fails (interceptStreamProtocol)","user":{"login":"burtonator","id":45447,"node_id":"MDQ6VXNlcjQ1NDQ3","avatar_url":"https://avatars3.githubusercontent.com/u/45447?v=4","gravatar_id":"","url":"https://api.github.com/users/burtonator","html_url":"https://github.com/burtonator","followers_url":"https://api.github.com/users/burtonator/followers","following_url":"https://api.github.com/users/burtonator/following{/other_user}","gists_url":"https://api.github.com/users/burtonator/gists{/gist_id}","starred_url":"https://api.github.com/users/burtonator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burtonator/subscriptions","organizations_url":"https://api.github.com/users/burtonator/orgs","repos_url":"https://api.github.com/users/burtonator/repos","events_url":"https://api.github.com/users/burtonator/events{/privacy}","received_events_url":"https://api.github.com/users/burtonator/received_events","type":"User","site_admin":false},"labels":[{"id":839475038,"node_id":"MDU6TGFiZWw4Mzk0NzUwMzg=","url":"https://api.github.com/repos/electron/electron/labels/2-0-x","name":"2-0-x","color":"8d9ee8","default":false},{"id":520323169,"node_id":"MDU6TGFiZWw1MjAzMjMxNjk=","url":"https://api.github.com/repos/electron/electron/labels/bug%20:beetle:","name":"bug :beetle:","color":"fbca04","default":false},{"id":551738582,"node_id":"MDU6TGFiZWw1NTE3Mzg1ODI=","url":"https://api.github.com/repos/electron/electron/labels/platform/linux/ubuntu","name":"platform/linux/ubuntu","color":"c5def5","default":false},{"id":97403606,"node_id":"MDU6TGFiZWw5NzQwMzYwNg==","url":"https://api.github.com/repos/electron/electron/labels/platform/macOS","name":"platform/macOS","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2018-06-30T15:43:48Z","updated_at":"2018-11-06T15:29:21Z","closed_at":null,"author_association":"NONE","body":"* 2.0.2 and 2.0.3:\r\n\r\n* Operating System (Platform and Version):\r\n\r\nUbuntu 18.04 and MacOS (latest)\r\n\r\n* Last known working Electron version: \r\n\r\nNone\r\n\r\n**Expected Behavior**\r\n\r\nRegistering or intercepting a stream protocol should work and the browser should show the proper content. \r\n\r\n**Actual behavior**\r\n\r\nThe browser actually shows an empty document with no content. No errors present.\r\n\r\nI've verified that the same code works fine with 'string' protocols. Just not 'stream' protocols.\r\n\r\nI created a repository here:\r\n\r\nhttps://github.com/burtonator/electron-protocol-examples\r\n\r\nWith all my examples.\r\n\r\nThe key ones are:\r\n\r\nintercept-stream-protocol-http.js :  FAILS\r\nintercept-string-protocol-http.js: WORKS\r\n\r\nI simplified the code greatly and I use the examples in the documentation. I've read the protocol documentation 2-3x to see if I was missing something.  Does't seem to be the case.\r\n\r\nAdditionally there is this case:\r\n\r\nintercept-stream-protocol-with-default-protocol.js\r\n\r\n... I'd like to have a way to revert to the default protocol handler if possible. A comment on my previous issue stated that this was possible but it still doesn't appear to work.  Doesn't work with string protocols either.\r\n\r\n**To Reproduce**\r\n\r\nJust clone my repository and run the examples.  \r\n\r\nhttps://github.com/burtonator/electron-protocol-examples\r\n\r\n```sh\r\ngit clone https://github.com/burtonator/electron-protocol-examples.git\r\ncd electron-protocol-examples\r\nnpm install\r\n\r\n## this will work and the content will be shown in the browser.\r\n./node_modules/.bin/electron intercept-string-protocol-http.js\r\n\r\n## this will NOT work and no content will be shown to the browser\r\n./node_modules/.bin/electron intercept-stream-protocol-http.js\r\n\r\n```\r\n**Screenshots**\r\n\r\n## with sting protocol (working)\r\n\r\n![image](https://user-images.githubusercontent.com/45447/42126763-b0cb095a-7c41-11e8-973b-7c38b0ddf387.png)\r\n\r\n## with stream protocol (not working)\r\n\r\n![image](https://user-images.githubusercontent.com/45447/42126756-a19d4290-7c41-11e8-973c-388b1ca27028.png)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/electron/electron/issues/comments/436293476","html_url":"https://github.com/electron/electron/issues/13519#issuecomment-436293476","issue_url":"https://api.github.com/repos/electron/electron/issues/13519","id":436293476,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjI5MzQ3Ng==","user":{"login":"burtonator","id":45447,"node_id":"MDQ6VXNlcjQ1NDQ3","avatar_url":"https://avatars3.githubusercontent.com/u/45447?v=4","gravatar_id":"","url":"https://api.github.com/users/burtonator","html_url":"https://github.com/burtonator","followers_url":"https://api.github.com/users/burtonator/followers","following_url":"https://api.github.com/users/burtonator/following{/other_user}","gists_url":"https://api.github.com/users/burtonator/gists{/gist_id}","starred_url":"https://api.github.com/users/burtonator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burtonator/subscriptions","organizations_url":"https://api.github.com/users/burtonator/orgs","repos_url":"https://api.github.com/users/burtonator/repos","events_url":"https://api.github.com/users/burtonator/events{/privacy}","received_events_url":"https://api.github.com/users/burtonator/received_events","type":"User","site_admin":false},"created_at":"2018-11-06T15:29:21Z","updated_at":"2018-11-06T15:29:21Z","author_association":"NONE","body":"This is madness.. I wonder if we need to make this code into a PR and get it as a standard unit test in Electron."}}
{"actor":{"display_login":"burtonator"}}