{"action":"created","comment":{"url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/pulls/comments/185162483","pull_request_review_id":116497444,"id":185162483,"diff_hunk":"@@ -1125,6 +1125,14 @@ hipError_t hipMemcpy(void* dst, const void* src, size_t sizeBytes, hipMemcpyKind\n \n     hipError_t e = hipSuccess;\n \n+    if(dst==NULL || dst==0 || src==NULL || src==0)","path":"src/hip_memory.cpp","position":4,"original_position":4,"commit_id":"9f0c7711a58a1e23ebdd6572c08fe7df37edd83e","original_commit_id":"9f0c7711a58a1e23ebdd6572c08fe7df37edd83e","user":{"login":"mangupta","id":14296582,"avatar_url":"https://avatars2.githubusercontent.com/u/14296582?v=4","gravatar_id":"","url":"https://api.github.com/users/mangupta","html_url":"https://github.com/mangupta","followers_url":"https://api.github.com/users/mangupta/followers","following_url":"https://api.github.com/users/mangupta/following{/other_user}","gists_url":"https://api.github.com/users/mangupta/gists{/gist_id}","starred_url":"https://api.github.com/users/mangupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mangupta/subscriptions","organizations_url":"https://api.github.com/users/mangupta/orgs","repos_url":"https://api.github.com/users/mangupta/repos","events_url":"https://api.github.com/users/mangupta/events{/privacy}","received_events_url":"https://api.github.com/users/mangupta/received_events","type":"User","site_admin":false},"body":"HIP runtime is compiled using a C++ compiler. So comparison to both NULL as well as 0 does not make sense. Just comparing to NULL is sufficient.","created_at":"2018-05-01T03:50:59Z","updated_at":"2018-05-01T03:51:06Z","html_url":"https://github.com/ROCm-Developer-Tools/HIP/pull/408#discussion_r185162483","pull_request_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/pulls/408","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/pulls/comments/185162483"},"html":{"href":"https://github.com/ROCm-Developer-Tools/HIP/pull/408#discussion_r185162483"},"pull_request":{"href":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/pulls/408"}}},"pull_request":{"url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/pulls/408","id":182970541,"html_url":"https://github.com/ROCm-Developer-Tools/HIP/pull/408","diff_url":"https://github.com/ROCm-Developer-Tools/HIP/pull/408.diff","patch_url":"https://github.com/ROCm-Developer-Tools/HIP/pull/408.patch","issue_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/issues/408","number":408,"state":"open","locked":false,"title":"SWDEV-141661","user":{"login":"luckynikki","id":28004935,"avatar_url":"https://avatars1.githubusercontent.com/u/28004935?v=4","gravatar_id":"","url":"https://api.github.com/users/luckynikki","html_url":"https://github.com/luckynikki","followers_url":"https://api.github.com/users/luckynikki/followers","following_url":"https://api.github.com/users/luckynikki/following{/other_user}","gists_url":"https://api.github.com/users/luckynikki/gists{/gist_id}","starred_url":"https://api.github.com/users/luckynikki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luckynikki/subscriptions","organizations_url":"https://api.github.com/users/luckynikki/orgs","repos_url":"https://api.github.com/users/luckynikki/repos","events_url":"https://api.github.com/users/luckynikki/events{/privacy}","received_events_url":"https://api.github.com/users/luckynikki/received_events","type":"User","site_admin":false},"body":"Added a fix for the issue ::hipMemcpy() gives seg. fault when the first or second parameter is passed as NULL or zero. Verified in the local machine the fail scenario and also ran the directed tests. Things are fine.","created_at":"2018-04-20T06:27:47Z","updated_at":"2018-05-01T03:51:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b6e0c7563d824f77e548096f5488b17ce533a77","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/pulls/408/commits","review_comments_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/pulls/408/comments","review_comment_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/issues/408/comments","statuses_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/statuses/9f0c7711a58a1e23ebdd6572c08fe7df37edd83e","head":{"label":"luckynikki:SWDEV-141661","ref":"SWDEV-141661","sha":"9f0c7711a58a1e23ebdd6572c08fe7df37edd83e","user":{"login":"luckynikki","id":28004935,"avatar_url":"https://avatars1.githubusercontent.com/u/28004935?v=4","gravatar_id":"","url":"https://api.github.com/users/luckynikki","html_url":"https://github.com/luckynikki","followers_url":"https://api.github.com/users/luckynikki/followers","following_url":"https://api.github.com/users/luckynikki/following{/other_user}","gists_url":"https://api.github.com/users/luckynikki/gists{/gist_id}","starred_url":"https://api.github.com/users/luckynikki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luckynikki/subscriptions","organizations_url":"https://api.github.com/users/luckynikki/orgs","repos_url":"https://api.github.com/users/luckynikki/repos","events_url":"https://api.github.com/users/luckynikki/events{/privacy}","received_events_url":"https://api.github.com/users/luckynikki/received_events","type":"User","site_admin":false},"repo":{"id":130011975,"name":"HIP","full_name":"luckynikki/HIP","owner":{"login":"luckynikki","id":28004935,"avatar_url":"https://avatars1.githubusercontent.com/u/28004935?v=4","gravatar_id":"","url":"https://api.github.com/users/luckynikki","html_url":"https://github.com/luckynikki","followers_url":"https://api.github.com/users/luckynikki/followers","following_url":"https://api.github.com/users/luckynikki/following{/other_user}","gists_url":"https://api.github.com/users/luckynikki/gists{/gist_id}","starred_url":"https://api.github.com/users/luckynikki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luckynikki/subscriptions","organizations_url":"https://api.github.com/users/luckynikki/orgs","repos_url":"https://api.github.com/users/luckynikki/repos","events_url":"https://api.github.com/users/luckynikki/events{/privacy}","received_events_url":"https://api.github.com/users/luckynikki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/luckynikki/HIP","description":"HIP : Convert CUDA to Portable C++ Code","fork":true,"url":"https://api.github.com/repos/luckynikki/HIP","forks_url":"https://api.github.com/repos/luckynikki/HIP/forks","keys_url":"https://api.github.com/repos/luckynikki/HIP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luckynikki/HIP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luckynikki/HIP/teams","hooks_url":"https://api.github.com/repos/luckynikki/HIP/hooks","issue_events_url":"https://api.github.com/repos/luckynikki/HIP/issues/events{/number}","events_url":"https://api.github.com/repos/luckynikki/HIP/events","assignees_url":"https://api.github.com/repos/luckynikki/HIP/assignees{/user}","branches_url":"https://api.github.com/repos/luckynikki/HIP/branches{/branch}","tags_url":"https://api.github.com/repos/luckynikki/HIP/tags","blobs_url":"https://api.github.com/repos/luckynikki/HIP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luckynikki/HIP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luckynikki/HIP/git/refs{/sha}","trees_url":"https://api.github.com/repos/luckynikki/HIP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luckynikki/HIP/statuses/{sha}","languages_url":"https://api.github.com/repos/luckynikki/HIP/languages","stargazers_url":"https://api.github.com/repos/luckynikki/HIP/stargazers","contributors_url":"https://api.github.com/repos/luckynikki/HIP/contributors","subscribers_url":"https://api.github.com/repos/luckynikki/HIP/subscribers","subscription_url":"https://api.github.com/repos/luckynikki/HIP/subscription","commits_url":"https://api.github.com/repos/luckynikki/HIP/commits{/sha}","git_commits_url":"https://api.github.com/repos/luckynikki/HIP/git/commits{/sha}","comments_url":"https://api.github.com/repos/luckynikki/HIP/comments{/number}","issue_comment_url":"https://api.github.com/repos/luckynikki/HIP/issues/comments{/number}","contents_url":"https://api.github.com/repos/luckynikki/HIP/contents/{+path}","compare_url":"https://api.github.com/repos/luckynikki/HIP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luckynikki/HIP/merges","archive_url":"https://api.github.com/repos/luckynikki/HIP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luckynikki/HIP/downloads","issues_url":"https://api.github.com/repos/luckynikki/HIP/issues{/number}","pulls_url":"https://api.github.com/repos/luckynikki/HIP/pulls{/number}","milestones_url":"https://api.github.com/repos/luckynikki/HIP/milestones{/number}","notifications_url":"https://api.github.com/repos/luckynikki/HIP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luckynikki/HIP/labels{/name}","releases_url":"https://api.github.com/repos/luckynikki/HIP/releases{/id}","deployments_url":"https://api.github.com/repos/luckynikki/HIP/deployments","created_at":"2018-04-18T06:05:41Z","updated_at":"2018-04-18T06:05:43Z","pushed_at":"2018-04-20T12:10:45Z","git_url":"git://github.com/luckynikki/HIP.git","ssh_url":"git@github.com:luckynikki/HIP.git","clone_url":"https://github.com/luckynikki/HIP.git","svn_url":"https://github.com/luckynikki/HIP","homepage":null,"size":6834,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ROCm-Developer-Tools:master","ref":"master","sha":"35a8deec00677570090afdbc3d94fb19746c49e3","user":{"login":"ROCm-Developer-Tools","id":16688128,"avatar_url":"https://avatars0.githubusercontent.com/u/16688128?v=4","gravatar_id":"","url":"https://api.github.com/users/ROCm-Developer-Tools","html_url":"https://github.com/ROCm-Developer-Tools","followers_url":"https://api.github.com/users/ROCm-Developer-Tools/followers","following_url":"https://api.github.com/users/ROCm-Developer-Tools/following{/other_user}","gists_url":"https://api.github.com/users/ROCm-Developer-Tools/gists{/gist_id}","starred_url":"https://api.github.com/users/ROCm-Developer-Tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ROCm-Developer-Tools/subscriptions","organizations_url":"https://api.github.com/users/ROCm-Developer-Tools/orgs","repos_url":"https://api.github.com/users/ROCm-Developer-Tools/repos","events_url":"https://api.github.com/users/ROCm-Developer-Tools/events{/privacy}","received_events_url":"https://api.github.com/users/ROCm-Developer-Tools/received_events","type":"Organization","site_admin":false},"repo":{"id":49220157,"name":"HIP","full_name":"ROCm-Developer-Tools/HIP","owner":{"login":"ROCm-Developer-Tools","id":16688128,"avatar_url":"https://avatars0.githubusercontent.com/u/16688128?v=4","gravatar_id":"","url":"https://api.github.com/users/ROCm-Developer-Tools","html_url":"https://github.com/ROCm-Developer-Tools","followers_url":"https://api.github.com/users/ROCm-Developer-Tools/followers","following_url":"https://api.github.com/users/ROCm-Developer-Tools/following{/other_user}","gists_url":"https://api.github.com/users/ROCm-Developer-Tools/gists{/gist_id}","starred_url":"https://api.github.com/users/ROCm-Developer-Tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ROCm-Developer-Tools/subscriptions","organizations_url":"https://api.github.com/users/ROCm-Developer-Tools/orgs","repos_url":"https://api.github.com/users/ROCm-Developer-Tools/repos","events_url":"https://api.github.com/users/ROCm-Developer-Tools/events{/privacy}","received_events_url":"https://api.github.com/users/ROCm-Developer-Tools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ROCm-Developer-Tools/HIP","description":"HIP : Convert CUDA to Portable C++ Code","fork":false,"url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP","forks_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/forks","keys_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/teams","hooks_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/hooks","issue_events_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/issues/events{/number}","events_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/events","assignees_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/assignees{/user}","branches_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/branches{/branch}","tags_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/tags","blobs_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/git/refs{/sha}","trees_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/statuses/{sha}","languages_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/languages","stargazers_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/stargazers","contributors_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/contributors","subscribers_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/subscribers","subscription_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/subscription","commits_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/commits{/sha}","git_commits_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/git/commits{/sha}","comments_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/comments{/number}","issue_comment_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/issues/comments{/number}","contents_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/contents/{+path}","compare_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/merges","archive_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/downloads","issues_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/issues{/number}","pulls_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/pulls{/number}","milestones_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/milestones{/number}","notifications_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/labels{/name}","releases_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/releases{/id}","deployments_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/deployments","created_at":"2016-01-07T17:41:56Z","updated_at":"2018-05-01T03:48:17Z","pushed_at":"2018-05-01T03:48:12Z","git_url":"git://github.com/ROCm-Developer-Tools/HIP.git","ssh_url":"git@github.com:ROCm-Developer-Tools/HIP.git","clone_url":"https://github.com/ROCm-Developer-Tools/HIP.git","svn_url":"https://github.com/ROCm-Developer-Tools/HIP","homepage":null,"size":6840,"stargazers_count":1362,"watchers_count":1362,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":155,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":155,"open_issues":46,"watchers":1362,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/pulls/408"},"html":{"href":"https://github.com/ROCm-Developer-Tools/HIP/pull/408"},"issue":{"href":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/issues/408"},"comments":{"href":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/issues/408/comments"},"review_comments":{"href":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/pulls/408/comments"},"review_comment":{"href":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/pulls/408/commits"},"statuses":{"href":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/statuses/9f0c7711a58a1e23ebdd6572c08fe7df37edd83e"}},"author_association":"NONE"}}
{"actor":{"display_login":"mangupta"}}