{"action":"closed","number":1907,"pull_request":{"url":"https://api.github.com/repos/google/googletest/pulls/1907","id":222528617,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNTI4NjE3","html_url":"https://github.com/google/googletest/pull/1907","diff_url":"https://github.com/google/googletest/pull/1907.diff","patch_url":"https://github.com/google/googletest/pull/1907.patch","issue_url":"https://api.github.com/repos/google/googletest/issues/1907","number":1907,"state":"closed","locked":false,"title":"Change types to remove cast warnings","user":{"login":"rwoldberg","id":2048887,"node_id":"MDQ6VXNlcjIwNDg4ODc=","avatar_url":"https://avatars1.githubusercontent.com/u/2048887?v=4","gravatar_id":"","url":"https://api.github.com/users/rwoldberg","html_url":"https://github.com/rwoldberg","followers_url":"https://api.github.com/users/rwoldberg/followers","following_url":"https://api.github.com/users/rwoldberg/following{/other_user}","gists_url":"https://api.github.com/users/rwoldberg/gists{/gist_id}","starred_url":"https://api.github.com/users/rwoldberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwoldberg/subscriptions","organizations_url":"https://api.github.com/users/rwoldberg/orgs","repos_url":"https://api.github.com/users/rwoldberg/repos","events_url":"https://api.github.com/users/rwoldberg/events{/privacy}","received_events_url":"https://api.github.com/users/rwoldberg/received_events","type":"User","site_admin":false},"body":"We compile with all warnings as errors, and these changes fix the implicit casting that generate warnings in our unit tests.  With these changes we will get no warnings and thus will be able to turn on warnings as errors in our unit tests.","created_at":"2018-10-12T17:00:27Z","updated_at":"2018-10-12T17:06:54Z","closed_at":"2018-10-12T17:06:54Z","merged_at":null,"merge_commit_sha":"04fd5f7212780759519f0be082213fe599115f9d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1007160271,"node_id":"MDU6TGFiZWwxMDA3MTYwMjcx","url":"https://api.github.com/repos/google/googletest/labels/cla:%20no","name":"cla: no","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/googletest/pulls/1907/commits","review_comments_url":"https://api.github.com/repos/google/googletest/pulls/1907/comments","review_comment_url":"https://api.github.com/repos/google/googletest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/googletest/issues/1907/comments","statuses_url":"https://api.github.com/repos/google/googletest/statuses/23f69723e8da4ef2d6d953664b1e70ff60238653","head":{"label":"rwoldberg:master","ref":"master","sha":"23f69723e8da4ef2d6d953664b1e70ff60238653","user":{"login":"rwoldberg","id":2048887,"node_id":"MDQ6VXNlcjIwNDg4ODc=","avatar_url":"https://avatars1.githubusercontent.com/u/2048887?v=4","gravatar_id":"","url":"https://api.github.com/users/rwoldberg","html_url":"https://github.com/rwoldberg","followers_url":"https://api.github.com/users/rwoldberg/followers","following_url":"https://api.github.com/users/rwoldberg/following{/other_user}","gists_url":"https://api.github.com/users/rwoldberg/gists{/gist_id}","starred_url":"https://api.github.com/users/rwoldberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwoldberg/subscriptions","organizations_url":"https://api.github.com/users/rwoldberg/orgs","repos_url":"https://api.github.com/users/rwoldberg/repos","events_url":"https://api.github.com/users/rwoldberg/events{/privacy}","received_events_url":"https://api.github.com/users/rwoldberg/received_events","type":"User","site_admin":false},"repo":{"id":152781892,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI3ODE4OTI=","name":"googletest","full_name":"rwoldberg/googletest","private":false,"owner":{"login":"rwoldberg","id":2048887,"node_id":"MDQ6VXNlcjIwNDg4ODc=","avatar_url":"https://avatars1.githubusercontent.com/u/2048887?v=4","gravatar_id":"","url":"https://api.github.com/users/rwoldberg","html_url":"https://github.com/rwoldberg","followers_url":"https://api.github.com/users/rwoldberg/followers","following_url":"https://api.github.com/users/rwoldberg/following{/other_user}","gists_url":"https://api.github.com/users/rwoldberg/gists{/gist_id}","starred_url":"https://api.github.com/users/rwoldberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwoldberg/subscriptions","organizations_url":"https://api.github.com/users/rwoldberg/orgs","repos_url":"https://api.github.com/users/rwoldberg/repos","events_url":"https://api.github.com/users/rwoldberg/events{/privacy}","received_events_url":"https://api.github.com/users/rwoldberg/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rwoldberg/googletest","description":"Google Test","fork":true,"url":"https://api.github.com/repos/rwoldberg/googletest","forks_url":"https://api.github.com/repos/rwoldberg/googletest/forks","keys_url":"https://api.github.com/repos/rwoldberg/googletest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rwoldberg/googletest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rwoldberg/googletest/teams","hooks_url":"https://api.github.com/repos/rwoldberg/googletest/hooks","issue_events_url":"https://api.github.com/repos/rwoldberg/googletest/issues/events{/number}","events_url":"https://api.github.com/repos/rwoldberg/googletest/events","assignees_url":"https://api.github.com/repos/rwoldberg/googletest/assignees{/user}","branches_url":"https://api.github.com/repos/rwoldberg/googletest/branches{/branch}","tags_url":"https://api.github.com/repos/rwoldberg/googletest/tags","blobs_url":"https://api.github.com/repos/rwoldberg/googletest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rwoldberg/googletest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rwoldberg/googletest/git/refs{/sha}","trees_url":"https://api.github.com/repos/rwoldberg/googletest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rwoldberg/googletest/statuses/{sha}","languages_url":"https://api.github.com/repos/rwoldberg/googletest/languages","stargazers_url":"https://api.github.com/repos/rwoldberg/googletest/stargazers","contributors_url":"https://api.github.com/repos/rwoldberg/googletest/contributors","subscribers_url":"https://api.github.com/repos/rwoldberg/googletest/subscribers","subscription_url":"https://api.github.com/repos/rwoldberg/googletest/subscription","commits_url":"https://api.github.com/repos/rwoldberg/googletest/commits{/sha}","git_commits_url":"https://api.github.com/repos/rwoldberg/googletest/git/commits{/sha}","comments_url":"https://api.github.com/repos/rwoldberg/googletest/comments{/number}","issue_comment_url":"https://api.github.com/repos/rwoldberg/googletest/issues/comments{/number}","contents_url":"https://api.github.com/repos/rwoldberg/googletest/contents/{+path}","compare_url":"https://api.github.com/repos/rwoldberg/googletest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rwoldberg/googletest/merges","archive_url":"https://api.github.com/repos/rwoldberg/googletest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rwoldberg/googletest/downloads","issues_url":"https://api.github.com/repos/rwoldberg/googletest/issues{/number}","pulls_url":"https://api.github.com/repos/rwoldberg/googletest/pulls{/number}","milestones_url":"https://api.github.com/repos/rwoldberg/googletest/milestones{/number}","notifications_url":"https://api.github.com/repos/rwoldberg/googletest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rwoldberg/googletest/labels{/name}","releases_url":"https://api.github.com/repos/rwoldberg/googletest/releases{/id}","deployments_url":"https://api.github.com/repos/rwoldberg/googletest/deployments","created_at":"2018-10-12T16:54:11Z","updated_at":"2018-10-12T16:56:40Z","pushed_at":"2018-10-12T16:56:38Z","git_url":"git://github.com/rwoldberg/googletest.git","ssh_url":"git@github.com:rwoldberg/googletest.git","clone_url":"https://github.com/rwoldberg/googletest.git","svn_url":"https://github.com/rwoldberg/googletest","homepage":"","size":5359,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"864b6c2d35db5c2c8ca4a4bad66e295a64f47011","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":39840932,"node_id":"MDEwOlJlcG9zaXRvcnkzOTg0MDkzMg==","name":"googletest","full_name":"google/googletest","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/googletest","description":"Google Test","fork":false,"url":"https://api.github.com/repos/google/googletest","forks_url":"https://api.github.com/repos/google/googletest/forks","keys_url":"https://api.github.com/repos/google/googletest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/googletest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/googletest/teams","hooks_url":"https://api.github.com/repos/google/googletest/hooks","issue_events_url":"https://api.github.com/repos/google/googletest/issues/events{/number}","events_url":"https://api.github.com/repos/google/googletest/events","assignees_url":"https://api.github.com/repos/google/googletest/assignees{/user}","branches_url":"https://api.github.com/repos/google/googletest/branches{/branch}","tags_url":"https://api.github.com/repos/google/googletest/tags","blobs_url":"https://api.github.com/repos/google/googletest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/googletest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/googletest/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/googletest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/googletest/statuses/{sha}","languages_url":"https://api.github.com/repos/google/googletest/languages","stargazers_url":"https://api.github.com/repos/google/googletest/stargazers","contributors_url":"https://api.github.com/repos/google/googletest/contributors","subscribers_url":"https://api.github.com/repos/google/googletest/subscribers","subscription_url":"https://api.github.com/repos/google/googletest/subscription","commits_url":"https://api.github.com/repos/google/googletest/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/googletest/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/googletest/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/googletest/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/googletest/contents/{+path}","compare_url":"https://api.github.com/repos/google/googletest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/googletest/merges","archive_url":"https://api.github.com/repos/google/googletest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/googletest/downloads","issues_url":"https://api.github.com/repos/google/googletest/issues{/number}","pulls_url":"https://api.github.com/repos/google/googletest/pulls{/number}","milestones_url":"https://api.github.com/repos/google/googletest/milestones{/number}","notifications_url":"https://api.github.com/repos/google/googletest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/googletest/labels{/name}","releases_url":"https://api.github.com/repos/google/googletest/releases{/id}","deployments_url":"https://api.github.com/repos/google/googletest/deployments","created_at":"2015-07-28T15:07:53Z","updated_at":"2018-10-12T09:16:11Z","pushed_at":"2018-10-12T17:00:27Z","git_url":"git://github.com/google/googletest.git","ssh_url":"git@github.com:google/googletest.git","clone_url":"https://github.com/google/googletest.git","svn_url":"https://github.com/google/googletest","homepage":"","size":5359,"stargazers_count":9481,"watchers_count":9481,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4011,"mirror_url":null,"archived":false,"open_issues_count":213,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":4011,"open_issues":213,"watchers":9481,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/googletest/pulls/1907"},"html":{"href":"https://github.com/google/googletest/pull/1907"},"issue":{"href":"https://api.github.com/repos/google/googletest/issues/1907"},"comments":{"href":"https://api.github.com/repos/google/googletest/issues/1907/comments"},"review_comments":{"href":"https://api.github.com/repos/google/googletest/pulls/1907/comments"},"review_comment":{"href":"https://api.github.com/repos/google/googletest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/googletest/pulls/1907/commits"},"statuses":{"href":"https://api.github.com/repos/google/googletest/statuses/23f69723e8da4ef2d6d953664b1e70ff60238653"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"rwoldberg"}}