{"action":"created","comment":{"url":"https://api.github.com/repos/omise/omise-magento/pulls/comments/200025180","pull_request_review_id":134257403,"id":200025180,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDAyNTE4MA==","diff_hunk":"@@ -8,9 +8,13 @@\n                value: getCode(),\n                checked: isChecked,\n                click: selectPaymentMethod,\n-               visible: isRadioButtonVisible()\" />\n+               visible: isRadioButtonVisible(),\n+               enable: isActive()\" />\n         <label data-bind=\"attr: {'for': getCode()}\" class=\"label\">\n             <span data-bind=\"text: getTitle()\"></span>\n+            <span \n+                data-bind=\"i18n: '(option available only for orders in Thai baht)',","path":"view/frontend/web/template/payment/offsite-alipay-form.html","position":10,"original_position":10,"commit_id":"78cf5bde005a16393740e6e0331f28545934707c","original_commit_id":"78cf5bde005a16393740e6e0331f28545934707c","user":{"login":"jacekstan","id":10651523,"node_id":"MDQ6VXNlcjEwNjUxNTIz","avatar_url":"https://avatars1.githubusercontent.com/u/10651523?v=4","gravatar_id":"","url":"https://api.github.com/users/jacekstan","html_url":"https://github.com/jacekstan","followers_url":"https://api.github.com/users/jacekstan/followers","following_url":"https://api.github.com/users/jacekstan/following{/other_user}","gists_url":"https://api.github.com/users/jacekstan/gists{/gist_id}","starred_url":"https://api.github.com/users/jacekstan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacekstan/subscriptions","organizations_url":"https://api.github.com/users/jacekstan/orgs","repos_url":"https://api.github.com/users/jacekstan/repos","events_url":"https://api.github.com/users/jacekstan/events{/privacy}","received_events_url":"https://api.github.com/users/jacekstan/received_events","type":"User","site_admin":false},"body":"I agree but I also think that would be good question to PM ?","created_at":"2018-07-04T07:03:26Z","updated_at":"2018-07-04T07:03:26Z","html_url":"https://github.com/omise/omise-magento/pull/127#discussion_r200025180","pull_request_url":"https://api.github.com/repos/omise/omise-magento/pulls/127","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/omise/omise-magento/pulls/comments/200025180"},"html":{"href":"https://github.com/omise/omise-magento/pull/127#discussion_r200025180"},"pull_request":{"href":"https://api.github.com/repos/omise/omise-magento/pulls/127"}},"in_reply_to_id":199709271},"pull_request":{"url":"https://api.github.com/repos/omise/omise-magento/pulls/127","id":197151767,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MTUxNzY3","html_url":"https://github.com/omise/omise-magento/pull/127","diff_url":"https://github.com/omise/omise-magento/pull/127.diff","patch_url":"https://github.com/omise/omise-magento/pull/127.patch","issue_url":"https://api.github.com/repos/omise/omise-magento/issues/127","number":127,"state":"open","locked":false,"title":"restrict alipay for thb transactions only","user":{"login":"jacekstan","id":10651523,"node_id":"MDQ6VXNlcjEwNjUxNTIz","avatar_url":"https://avatars1.githubusercontent.com/u/10651523?v=4","gravatar_id":"","url":"https://api.github.com/users/jacekstan","html_url":"https://github.com/jacekstan","followers_url":"https://api.github.com/users/jacekstan/followers","following_url":"https://api.github.com/users/jacekstan/following{/other_user}","gists_url":"https://api.github.com/users/jacekstan/gists{/gist_id}","starred_url":"https://api.github.com/users/jacekstan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacekstan/subscriptions","organizations_url":"https://api.github.com/users/jacekstan/orgs","repos_url":"https://api.github.com/users/jacekstan/repos","events_url":"https://api.github.com/users/jacekstan/events{/privacy}","received_events_url":"https://api.github.com/users/jacekstan/received_events","type":"User","site_admin":false},"body":"#### 1. Objective\r\n\r\nAlipay is available only for Thai Baht orders.\r\nThe purpose of this PR is to disable possibility of make Alipay payments for orders in other currencies.\r\n\r\n#### 2. Description of change\r\n\r\nChanged in JavaScript rendering files and HTML Alipay Checkout payment view.\r\n\r\nTo resolve issue there is checking if order is done in THB (Thai Baht) if yes, than Alipay payment method is displayed normally, otherwise option is _readonly_ and it is displayed message \r\n_Option available only for Thai Baht currency orders_\r\n\r\n![screen shot 2018-06-25 at 22 16 08](https://user-images.githubusercontent.com/10651523/41859081-9525c7f0-78c5-11e8-8161-a71d45ef8a66.png)\r\n\r\n\r\n#### 3. Quality assurance\r\n**🔧 Environments:**\r\n\r\n- **Platform version**: Magento CE 2.4.\r\n- **Omise plugin version**: Omise-Magento 2.3.\r\n- **PHP version**: 7.0.29.\r\n\r\n**✏️ Details:**\r\n\r\nStep 1. Open magento admin, make sure that Thai Baht is main store currency.\r\nMake order, and do payment with Alipay.\r\nStep 2. Open magento admin, change Thai Baht store currency to other currency,\r\nTry to make payment with Alipay. Payment should not be available.\r\n\r\n#### 4. Impact of the change\r\n\r\nN/A\r\n\r\n#### 5. Priority of change\r\n\r\nNormal\r\n\r\n#### 6. Additional Notes\r\n\r\nN/A","created_at":"2018-06-25T15:29:31Z","updated_at":"2018-07-04T07:03:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ef8995ac3c3be294dcbe611f43149000e5576d9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jonrandy","id":1510194,"node_id":"MDQ6VXNlcjE1MTAxOTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1510194?v=4","gravatar_id":"","url":"https://api.github.com/users/jonrandy","html_url":"https://github.com/jonrandy","followers_url":"https://api.github.com/users/jonrandy/followers","following_url":"https://api.github.com/users/jonrandy/following{/other_user}","gists_url":"https://api.github.com/users/jonrandy/gists{/gist_id}","starred_url":"https://api.github.com/users/jonrandy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonrandy/subscriptions","organizations_url":"https://api.github.com/users/jonrandy/orgs","repos_url":"https://api.github.com/users/jonrandy/repos","events_url":"https://api.github.com/users/jonrandy/events{/privacy}","received_events_url":"https://api.github.com/users/jonrandy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":529491802,"node_id":"MDU6TGFiZWw1Mjk0OTE4MDI=","url":"https://api.github.com/repos/omise/omise-magento/labels/project:%202.x","name":"project: 2.x","color":"333333","default":false},{"id":500933514,"node_id":"MDU6TGFiZWw1MDA5MzM1MTQ=","url":"https://api.github.com/repos/omise/omise-magento/labels/status:%20Review%20needed","name":"status: Review needed","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/omise/omise-magento/pulls/127/commits","review_comments_url":"https://api.github.com/repos/omise/omise-magento/pulls/127/comments","review_comment_url":"https://api.github.com/repos/omise/omise-magento/pulls/comments{/number}","comments_url":"https://api.github.com/repos/omise/omise-magento/issues/127/comments","statuses_url":"https://api.github.com/repos/omise/omise-magento/statuses/78cf5bde005a16393740e6e0331f28545934707c","head":{"label":"omise:alipay-only-for-thb-stores","ref":"alipay-only-for-thb-stores","sha":"78cf5bde005a16393740e6e0331f28545934707c","user":{"login":"omise","id":4662729,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NjI3Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/4662729?v=4","gravatar_id":"","url":"https://api.github.com/users/omise","html_url":"https://github.com/omise","followers_url":"https://api.github.com/users/omise/followers","following_url":"https://api.github.com/users/omise/following{/other_user}","gists_url":"https://api.github.com/users/omise/gists{/gist_id}","starred_url":"https://api.github.com/users/omise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omise/subscriptions","organizations_url":"https://api.github.com/users/omise/orgs","repos_url":"https://api.github.com/users/omise/repos","events_url":"https://api.github.com/users/omise/events{/privacy}","received_events_url":"https://api.github.com/users/omise/received_events","type":"Organization","site_admin":false},"repo":{"id":34387213,"node_id":"MDEwOlJlcG9zaXRvcnkzNDM4NzIxMw==","name":"omise-magento","full_name":"omise/omise-magento","owner":{"login":"omise","id":4662729,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NjI3Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/4662729?v=4","gravatar_id":"","url":"https://api.github.com/users/omise","html_url":"https://github.com/omise","followers_url":"https://api.github.com/users/omise/followers","following_url":"https://api.github.com/users/omise/following{/other_user}","gists_url":"https://api.github.com/users/omise/gists{/gist_id}","starred_url":"https://api.github.com/users/omise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omise/subscriptions","organizations_url":"https://api.github.com/users/omise/orgs","repos_url":"https://api.github.com/users/omise/repos","events_url":"https://api.github.com/users/omise/events{/privacy}","received_events_url":"https://api.github.com/users/omise/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/omise/omise-magento","description":"Omise Magento Integration","fork":false,"url":"https://api.github.com/repos/omise/omise-magento","forks_url":"https://api.github.com/repos/omise/omise-magento/forks","keys_url":"https://api.github.com/repos/omise/omise-magento/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omise/omise-magento/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omise/omise-magento/teams","hooks_url":"https://api.github.com/repos/omise/omise-magento/hooks","issue_events_url":"https://api.github.com/repos/omise/omise-magento/issues/events{/number}","events_url":"https://api.github.com/repos/omise/omise-magento/events","assignees_url":"https://api.github.com/repos/omise/omise-magento/assignees{/user}","branches_url":"https://api.github.com/repos/omise/omise-magento/branches{/branch}","tags_url":"https://api.github.com/repos/omise/omise-magento/tags","blobs_url":"https://api.github.com/repos/omise/omise-magento/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omise/omise-magento/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omise/omise-magento/git/refs{/sha}","trees_url":"https://api.github.com/repos/omise/omise-magento/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omise/omise-magento/statuses/{sha}","languages_url":"https://api.github.com/repos/omise/omise-magento/languages","stargazers_url":"https://api.github.com/repos/omise/omise-magento/stargazers","contributors_url":"https://api.github.com/repos/omise/omise-magento/contributors","subscribers_url":"https://api.github.com/repos/omise/omise-magento/subscribers","subscription_url":"https://api.github.com/repos/omise/omise-magento/subscription","commits_url":"https://api.github.com/repos/omise/omise-magento/commits{/sha}","git_commits_url":"https://api.github.com/repos/omise/omise-magento/git/commits{/sha}","comments_url":"https://api.github.com/repos/omise/omise-magento/comments{/number}","issue_comment_url":"https://api.github.com/repos/omise/omise-magento/issues/comments{/number}","contents_url":"https://api.github.com/repos/omise/omise-magento/contents/{+path}","compare_url":"https://api.github.com/repos/omise/omise-magento/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omise/omise-magento/merges","archive_url":"https://api.github.com/repos/omise/omise-magento/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omise/omise-magento/downloads","issues_url":"https://api.github.com/repos/omise/omise-magento/issues{/number}","pulls_url":"https://api.github.com/repos/omise/omise-magento/pulls{/number}","milestones_url":"https://api.github.com/repos/omise/omise-magento/milestones{/number}","notifications_url":"https://api.github.com/repos/omise/omise-magento/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omise/omise-magento/labels{/name}","releases_url":"https://api.github.com/repos/omise/omise-magento/releases{/id}","deployments_url":"https://api.github.com/repos/omise/omise-magento/deployments","created_at":"2015-04-22T11:45:56Z","updated_at":"2018-07-03T06:27:41Z","pushed_at":"2018-07-04T06:48:52Z","git_url":"git://github.com/omise/omise-magento.git","ssh_url":"git@github.com:omise/omise-magento.git","clone_url":"https://github.com/omise/omise-magento.git","svn_url":"https://github.com/omise/omise-magento","homepage":"https://www.omise.co/","size":1650,"stargazers_count":19,"watchers_count":19,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":9,"watchers":19,"default_branch":"master"}},"base":{"label":"omise:master","ref":"master","sha":"b795975b6301698a45f8f19a7837cb2a69a31975","user":{"login":"omise","id":4662729,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NjI3Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/4662729?v=4","gravatar_id":"","url":"https://api.github.com/users/omise","html_url":"https://github.com/omise","followers_url":"https://api.github.com/users/omise/followers","following_url":"https://api.github.com/users/omise/following{/other_user}","gists_url":"https://api.github.com/users/omise/gists{/gist_id}","starred_url":"https://api.github.com/users/omise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omise/subscriptions","organizations_url":"https://api.github.com/users/omise/orgs","repos_url":"https://api.github.com/users/omise/repos","events_url":"https://api.github.com/users/omise/events{/privacy}","received_events_url":"https://api.github.com/users/omise/received_events","type":"Organization","site_admin":false},"repo":{"id":34387213,"node_id":"MDEwOlJlcG9zaXRvcnkzNDM4NzIxMw==","name":"omise-magento","full_name":"omise/omise-magento","owner":{"login":"omise","id":4662729,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NjI3Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/4662729?v=4","gravatar_id":"","url":"https://api.github.com/users/omise","html_url":"https://github.com/omise","followers_url":"https://api.github.com/users/omise/followers","following_url":"https://api.github.com/users/omise/following{/other_user}","gists_url":"https://api.github.com/users/omise/gists{/gist_id}","starred_url":"https://api.github.com/users/omise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omise/subscriptions","organizations_url":"https://api.github.com/users/omise/orgs","repos_url":"https://api.github.com/users/omise/repos","events_url":"https://api.github.com/users/omise/events{/privacy}","received_events_url":"https://api.github.com/users/omise/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/omise/omise-magento","description":"Omise Magento Integration","fork":false,"url":"https://api.github.com/repos/omise/omise-magento","forks_url":"https://api.github.com/repos/omise/omise-magento/forks","keys_url":"https://api.github.com/repos/omise/omise-magento/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omise/omise-magento/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omise/omise-magento/teams","hooks_url":"https://api.github.com/repos/omise/omise-magento/hooks","issue_events_url":"https://api.github.com/repos/omise/omise-magento/issues/events{/number}","events_url":"https://api.github.com/repos/omise/omise-magento/events","assignees_url":"https://api.github.com/repos/omise/omise-magento/assignees{/user}","branches_url":"https://api.github.com/repos/omise/omise-magento/branches{/branch}","tags_url":"https://api.github.com/repos/omise/omise-magento/tags","blobs_url":"https://api.github.com/repos/omise/omise-magento/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omise/omise-magento/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omise/omise-magento/git/refs{/sha}","trees_url":"https://api.github.com/repos/omise/omise-magento/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omise/omise-magento/statuses/{sha}","languages_url":"https://api.github.com/repos/omise/omise-magento/languages","stargazers_url":"https://api.github.com/repos/omise/omise-magento/stargazers","contributors_url":"https://api.github.com/repos/omise/omise-magento/contributors","subscribers_url":"https://api.github.com/repos/omise/omise-magento/subscribers","subscription_url":"https://api.github.com/repos/omise/omise-magento/subscription","commits_url":"https://api.github.com/repos/omise/omise-magento/commits{/sha}","git_commits_url":"https://api.github.com/repos/omise/omise-magento/git/commits{/sha}","comments_url":"https://api.github.com/repos/omise/omise-magento/comments{/number}","issue_comment_url":"https://api.github.com/repos/omise/omise-magento/issues/comments{/number}","contents_url":"https://api.github.com/repos/omise/omise-magento/contents/{+path}","compare_url":"https://api.github.com/repos/omise/omise-magento/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omise/omise-magento/merges","archive_url":"https://api.github.com/repos/omise/omise-magento/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omise/omise-magento/downloads","issues_url":"https://api.github.com/repos/omise/omise-magento/issues{/number}","pulls_url":"https://api.github.com/repos/omise/omise-magento/pulls{/number}","milestones_url":"https://api.github.com/repos/omise/omise-magento/milestones{/number}","notifications_url":"https://api.github.com/repos/omise/omise-magento/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omise/omise-magento/labels{/name}","releases_url":"https://api.github.com/repos/omise/omise-magento/releases{/id}","deployments_url":"https://api.github.com/repos/omise/omise-magento/deployments","created_at":"2015-04-22T11:45:56Z","updated_at":"2018-07-03T06:27:41Z","pushed_at":"2018-07-04T06:48:52Z","git_url":"git://github.com/omise/omise-magento.git","ssh_url":"git@github.com:omise/omise-magento.git","clone_url":"https://github.com/omise/omise-magento.git","svn_url":"https://github.com/omise/omise-magento","homepage":"https://www.omise.co/","size":1650,"stargazers_count":19,"watchers_count":19,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":9,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/omise/omise-magento/pulls/127"},"html":{"href":"https://github.com/omise/omise-magento/pull/127"},"issue":{"href":"https://api.github.com/repos/omise/omise-magento/issues/127"},"comments":{"href":"https://api.github.com/repos/omise/omise-magento/issues/127/comments"},"review_comments":{"href":"https://api.github.com/repos/omise/omise-magento/pulls/127/comments"},"review_comment":{"href":"https://api.github.com/repos/omise/omise-magento/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/omise/omise-magento/pulls/127/commits"},"statuses":{"href":"https://api.github.com/repos/omise/omise-magento/statuses/78cf5bde005a16393740e6e0331f28545934707c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jacekstan"}}