{"action":"opened","number":302,"pull_request":{"url":"https://api.github.com/repos/kode54/vgmstream/pulls/302","id":219221486,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MjIxNDg2","html_url":"https://github.com/kode54/vgmstream/pull/302","diff_url":"https://github.com/kode54/vgmstream/pull/302.diff","patch_url":"https://github.com/kode54/vgmstream/pull/302.patch","issue_url":"https://api.github.com/repos/kode54/vgmstream/issues/302","number":302,"state":"open","locked":false,"title":"g7221","user":{"login":"bnnm","id":22844311,"node_id":"MDQ6VXNlcjIyODQ0MzEx","avatar_url":"https://avatars0.githubusercontent.com/u/22844311?v=4","gravatar_id":"","url":"https://api.github.com/users/bnnm","html_url":"https://github.com/bnnm","followers_url":"https://api.github.com/users/bnnm/followers","following_url":"https://api.github.com/users/bnnm/following{/other_user}","gists_url":"https://api.github.com/users/bnnm/gists{/gist_id}","starred_url":"https://api.github.com/users/bnnm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnnm/subscriptions","organizations_url":"https://api.github.com/users/bnnm/orgs","repos_url":"https://api.github.com/users/bnnm/repos","events_url":"https://api.github.com/users/bnnm/events{/privacy}","received_events_url":"https://api.github.com/users/bnnm/received_events","type":"User","site_admin":false},"body":"- Update G.722.1C (Siren14) decoder DLL to fix volume and others\r\n  - Note: must re-add .asc file\r\n\r\n***\r\n\r\nI wasn't satisfied with the current libsiren DLL output so I did a wrapper for the float ref.decoder (see here for the code: https://github.com/bnnm/vgmstream-g7221).\r\n\r\nMain libsiren problems that this DLL fixes:\r\n- Siren14 volume was quieter vs reference int decoder\r\n- output could change slightly when re-decoding the same file (threading?)\r\n- had some bugs and edge cases fixed in later versions of the ref.code\r\n- even though it mostly repurposed the ~2000 v1 ref.code, libsiren removed all Polycom credit and comments (not cool)\r\n\r\nThe DLL uses the float ref.code (like libsiren), performance is very similar (slightly faster, perhaps).\r\nI did try to optimize int decoder, got around ~25% faster but it was still about 4 times slower.\r\n\r\nI decided to leave the ref.code almost untouched (after some fixes), ugly as it is, since I'd rather make a new decoder from scratch for vgmstream than having some trimmed franken-code (may be necessary later, as some games use an updated version of Siren14, could remove encoder/Siren7 part and fix BE reading). Shouldn't affect compiled DLL anyway.\r\n\r\nRef.decoder didn't do float Siren14 originally but I patched it along thread safeness and stuff (see commit history).\r\n","created_at":"2018-09-30T19:08:37Z","updated_at":"2018-09-30T19:08:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kode54/vgmstream/pulls/302/commits","review_comments_url":"https://api.github.com/repos/kode54/vgmstream/pulls/302/comments","review_comment_url":"https://api.github.com/repos/kode54/vgmstream/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kode54/vgmstream/issues/302/comments","statuses_url":"https://api.github.com/repos/kode54/vgmstream/statuses/259c3b7d7e05e8046f28038106e6e3ee94853555","head":{"label":"bnnm:g7221","ref":"g7221","sha":"259c3b7d7e05e8046f28038106e6e3ee94853555","user":{"login":"bnnm","id":22844311,"node_id":"MDQ6VXNlcjIyODQ0MzEx","avatar_url":"https://avatars0.githubusercontent.com/u/22844311?v=4","gravatar_id":"","url":"https://api.github.com/users/bnnm","html_url":"https://github.com/bnnm","followers_url":"https://api.github.com/users/bnnm/followers","following_url":"https://api.github.com/users/bnnm/following{/other_user}","gists_url":"https://api.github.com/users/bnnm/gists{/gist_id}","starred_url":"https://api.github.com/users/bnnm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnnm/subscriptions","organizations_url":"https://api.github.com/users/bnnm/orgs","repos_url":"https://api.github.com/users/bnnm/repos","events_url":"https://api.github.com/users/bnnm/events{/privacy}","received_events_url":"https://api.github.com/users/bnnm/received_events","type":"User","site_admin":false},"repo":{"id":72032881,"node_id":"MDEwOlJlcG9zaXRvcnk3MjAzMjg4MQ==","name":"vgmstream","full_name":"bnnm/vgmstream","private":false,"owner":{"login":"bnnm","id":22844311,"node_id":"MDQ6VXNlcjIyODQ0MzEx","avatar_url":"https://avatars0.githubusercontent.com/u/22844311?v=4","gravatar_id":"","url":"https://api.github.com/users/bnnm","html_url":"https://github.com/bnnm","followers_url":"https://api.github.com/users/bnnm/followers","following_url":"https://api.github.com/users/bnnm/following{/other_user}","gists_url":"https://api.github.com/users/bnnm/gists{/gist_id}","starred_url":"https://api.github.com/users/bnnm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnnm/subscriptions","organizations_url":"https://api.github.com/users/bnnm/orgs","repos_url":"https://api.github.com/users/bnnm/repos","events_url":"https://api.github.com/users/bnnm/events{/privacy}","received_events_url":"https://api.github.com/users/bnnm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bnnm/vgmstream","description":"Git clone of the vgmstream - A library for playback of various streamed audio formats used in video games.","fork":true,"url":"https://api.github.com/repos/bnnm/vgmstream","forks_url":"https://api.github.com/repos/bnnm/vgmstream/forks","keys_url":"https://api.github.com/repos/bnnm/vgmstream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bnnm/vgmstream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bnnm/vgmstream/teams","hooks_url":"https://api.github.com/repos/bnnm/vgmstream/hooks","issue_events_url":"https://api.github.com/repos/bnnm/vgmstream/issues/events{/number}","events_url":"https://api.github.com/repos/bnnm/vgmstream/events","assignees_url":"https://api.github.com/repos/bnnm/vgmstream/assignees{/user}","branches_url":"https://api.github.com/repos/bnnm/vgmstream/branches{/branch}","tags_url":"https://api.github.com/repos/bnnm/vgmstream/tags","blobs_url":"https://api.github.com/repos/bnnm/vgmstream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bnnm/vgmstream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bnnm/vgmstream/git/refs{/sha}","trees_url":"https://api.github.com/repos/bnnm/vgmstream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bnnm/vgmstream/statuses/{sha}","languages_url":"https://api.github.com/repos/bnnm/vgmstream/languages","stargazers_url":"https://api.github.com/repos/bnnm/vgmstream/stargazers","contributors_url":"https://api.github.com/repos/bnnm/vgmstream/contributors","subscribers_url":"https://api.github.com/repos/bnnm/vgmstream/subscribers","subscription_url":"https://api.github.com/repos/bnnm/vgmstream/subscription","commits_url":"https://api.github.com/repos/bnnm/vgmstream/commits{/sha}","git_commits_url":"https://api.github.com/repos/bnnm/vgmstream/git/commits{/sha}","comments_url":"https://api.github.com/repos/bnnm/vgmstream/comments{/number}","issue_comment_url":"https://api.github.com/repos/bnnm/vgmstream/issues/comments{/number}","contents_url":"https://api.github.com/repos/bnnm/vgmstream/contents/{+path}","compare_url":"https://api.github.com/repos/bnnm/vgmstream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bnnm/vgmstream/merges","archive_url":"https://api.github.com/repos/bnnm/vgmstream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bnnm/vgmstream/downloads","issues_url":"https://api.github.com/repos/bnnm/vgmstream/issues{/number}","pulls_url":"https://api.github.com/repos/bnnm/vgmstream/pulls{/number}","milestones_url":"https://api.github.com/repos/bnnm/vgmstream/milestones{/number}","notifications_url":"https://api.github.com/repos/bnnm/vgmstream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bnnm/vgmstream/labels{/name}","releases_url":"https://api.github.com/repos/bnnm/vgmstream/releases{/id}","deployments_url":"https://api.github.com/repos/bnnm/vgmstream/deployments","created_at":"2016-10-26T18:33:16Z","updated_at":"2018-09-29T16:05:10Z","pushed_at":"2018-09-30T19:00:20Z","git_url":"git://github.com/bnnm/vgmstream.git","ssh_url":"git@github.com:bnnm/vgmstream.git","clone_url":"https://github.com/bnnm/vgmstream.git","svn_url":"https://github.com/bnnm/vgmstream","homepage":null,"size":20025,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"kode54:master","ref":"master","sha":"2723008fc1190eddb9eb57a23c50b54bf7243fb1","user":{"login":"kode54","id":796316,"node_id":"MDQ6VXNlcjc5NjMxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/796316?v=4","gravatar_id":"","url":"https://api.github.com/users/kode54","html_url":"https://github.com/kode54","followers_url":"https://api.github.com/users/kode54/followers","following_url":"https://api.github.com/users/kode54/following{/other_user}","gists_url":"https://api.github.com/users/kode54/gists{/gist_id}","starred_url":"https://api.github.com/users/kode54/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kode54/subscriptions","organizations_url":"https://api.github.com/users/kode54/orgs","repos_url":"https://api.github.com/users/kode54/repos","events_url":"https://api.github.com/users/kode54/events{/privacy}","received_events_url":"https://api.github.com/users/kode54/received_events","type":"User","site_admin":false},"repo":{"id":5591410,"node_id":"MDEwOlJlcG9zaXRvcnk1NTkxNDEw","name":"vgmstream","full_name":"kode54/vgmstream","private":false,"owner":{"login":"kode54","id":796316,"node_id":"MDQ6VXNlcjc5NjMxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/796316?v=4","gravatar_id":"","url":"https://api.github.com/users/kode54","html_url":"https://github.com/kode54","followers_url":"https://api.github.com/users/kode54/followers","following_url":"https://api.github.com/users/kode54/following{/other_user}","gists_url":"https://api.github.com/users/kode54/gists{/gist_id}","starred_url":"https://api.github.com/users/kode54/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kode54/subscriptions","organizations_url":"https://api.github.com/users/kode54/orgs","repos_url":"https://api.github.com/users/kode54/repos","events_url":"https://api.github.com/users/kode54/events{/privacy}","received_events_url":"https://api.github.com/users/kode54/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kode54/vgmstream","description":"Git clone of the vgmstream - A library for playback of various streamed audio formats used in video games.","fork":false,"url":"https://api.github.com/repos/kode54/vgmstream","forks_url":"https://api.github.com/repos/kode54/vgmstream/forks","keys_url":"https://api.github.com/repos/kode54/vgmstream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kode54/vgmstream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kode54/vgmstream/teams","hooks_url":"https://api.github.com/repos/kode54/vgmstream/hooks","issue_events_url":"https://api.github.com/repos/kode54/vgmstream/issues/events{/number}","events_url":"https://api.github.com/repos/kode54/vgmstream/events","assignees_url":"https://api.github.com/repos/kode54/vgmstream/assignees{/user}","branches_url":"https://api.github.com/repos/kode54/vgmstream/branches{/branch}","tags_url":"https://api.github.com/repos/kode54/vgmstream/tags","blobs_url":"https://api.github.com/repos/kode54/vgmstream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kode54/vgmstream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kode54/vgmstream/git/refs{/sha}","trees_url":"https://api.github.com/repos/kode54/vgmstream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kode54/vgmstream/statuses/{sha}","languages_url":"https://api.github.com/repos/kode54/vgmstream/languages","stargazers_url":"https://api.github.com/repos/kode54/vgmstream/stargazers","contributors_url":"https://api.github.com/repos/kode54/vgmstream/contributors","subscribers_url":"https://api.github.com/repos/kode54/vgmstream/subscribers","subscription_url":"https://api.github.com/repos/kode54/vgmstream/subscription","commits_url":"https://api.github.com/repos/kode54/vgmstream/commits{/sha}","git_commits_url":"https://api.github.com/repos/kode54/vgmstream/git/commits{/sha}","comments_url":"https://api.github.com/repos/kode54/vgmstream/comments{/number}","issue_comment_url":"https://api.github.com/repos/kode54/vgmstream/issues/comments{/number}","contents_url":"https://api.github.com/repos/kode54/vgmstream/contents/{+path}","compare_url":"https://api.github.com/repos/kode54/vgmstream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kode54/vgmstream/merges","archive_url":"https://api.github.com/repos/kode54/vgmstream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kode54/vgmstream/downloads","issues_url":"https://api.github.com/repos/kode54/vgmstream/issues{/number}","pulls_url":"https://api.github.com/repos/kode54/vgmstream/pulls{/number}","milestones_url":"https://api.github.com/repos/kode54/vgmstream/milestones{/number}","notifications_url":"https://api.github.com/repos/kode54/vgmstream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kode54/vgmstream/labels{/name}","releases_url":"https://api.github.com/repos/kode54/vgmstream/releases{/id}","deployments_url":"https://api.github.com/repos/kode54/vgmstream/deployments","created_at":"2012-08-28T20:08:24Z","updated_at":"2018-09-28T21:40:21Z","pushed_at":"2018-09-28T21:40:19Z","git_url":"git://github.com/kode54/vgmstream.git","ssh_url":"git@github.com:kode54/vgmstream.git","clone_url":"https://github.com/kode54/vgmstream.git","svn_url":"https://github.com/kode54/vgmstream","homepage":null,"size":20025,"stargazers_count":155,"watchers_count":155,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":43,"open_issues":21,"watchers":155,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kode54/vgmstream/pulls/302"},"html":{"href":"https://github.com/kode54/vgmstream/pull/302"},"issue":{"href":"https://api.github.com/repos/kode54/vgmstream/issues/302"},"comments":{"href":"https://api.github.com/repos/kode54/vgmstream/issues/302/comments"},"review_comments":{"href":"https://api.github.com/repos/kode54/vgmstream/pulls/302/comments"},"review_comment":{"href":"https://api.github.com/repos/kode54/vgmstream/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kode54/vgmstream/pulls/302/commits"},"statuses":{"href":"https://api.github.com/repos/kode54/vgmstream/statuses/259c3b7d7e05e8046f28038106e6e3ee94853555"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":0,"deletions":17,"changed_files":2}}
{"actor":{"display_login":"bnnm"}}