{"action":"closed","number":193,"pull_request":{"url":"https://api.github.com/repos/nmstate/nmstate/pulls/193","id":239048116,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MDQ4MTE2","html_url":"https://github.com/nmstate/nmstate/pull/193","diff_url":"https://github.com/nmstate/nmstate/pull/193.diff","patch_url":"https://github.com/nmstate/nmstate/pull/193.patch","issue_url":"https://api.github.com/repos/nmstate/nmstate/issues/193","number":193,"state":"closed","locked":false,"title":"netapplier: Ignore `down` state (for virt iface) in verification step","user":{"login":"EdDev","id":9546119,"node_id":"MDQ6VXNlcjk1NDYxMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/9546119?v=4","gravatar_id":"","url":"https://api.github.com/users/EdDev","html_url":"https://github.com/EdDev","followers_url":"https://api.github.com/users/EdDev/followers","following_url":"https://api.github.com/users/EdDev/following{/other_user}","gists_url":"https://api.github.com/users/EdDev/gists{/gist_id}","starred_url":"https://api.github.com/users/EdDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdDev/subscriptions","organizations_url":"https://api.github.com/users/EdDev/orgs","repos_url":"https://api.github.com/users/EdDev/repos","events_url":"https://api.github.com/users/EdDev/events{/privacy}","received_events_url":"https://api.github.com/users/EdDev/received_events","type":"User","site_admin":false},"body":"Currently, when in the desired state a virtual interface is set as\r\n`down`, it is removed (treated as `absent`).\r\nWhen the verification step occurs, checking that the desired state is\r\nincluded in the current state, these virtual interfaces should be\r\ntreated like the `absent` ones.","created_at":"2018-12-17T07:20:08Z","updated_at":"2018-12-18T18:19:30Z","closed_at":"2018-12-18T18:19:30Z","merged_at":"2018-12-18T18:19:30Z","merge_commit_sha":"39784d2e4593fc685f9d7752d3a92cc2aeeb307f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cathay4t","id":934948,"node_id":"MDQ6VXNlcjkzNDk0OA==","avatar_url":"https://avatars2.githubusercontent.com/u/934948?v=4","gravatar_id":"","url":"https://api.github.com/users/cathay4t","html_url":"https://github.com/cathay4t","followers_url":"https://api.github.com/users/cathay4t/followers","following_url":"https://api.github.com/users/cathay4t/following{/other_user}","gists_url":"https://api.github.com/users/cathay4t/gists{/gist_id}","starred_url":"https://api.github.com/users/cathay4t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cathay4t/subscriptions","organizations_url":"https://api.github.com/users/cathay4t/orgs","repos_url":"https://api.github.com/users/cathay4t/repos","events_url":"https://api.github.com/users/cathay4t/events{/privacy}","received_events_url":"https://api.github.com/users/cathay4t/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nmstate/nmstate/pulls/193/commits","review_comments_url":"https://api.github.com/repos/nmstate/nmstate/pulls/193/comments","review_comment_url":"https://api.github.com/repos/nmstate/nmstate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nmstate/nmstate/issues/193/comments","statuses_url":"https://api.github.com/repos/nmstate/nmstate/statuses/20f3e4711eed57ddcc03e86d5a9157e62f709b08","head":{"label":"EdDev:virt-iface-down","ref":"virt-iface-down","sha":"20f3e4711eed57ddcc03e86d5a9157e62f709b08","user":{"login":"EdDev","id":9546119,"node_id":"MDQ6VXNlcjk1NDYxMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/9546119?v=4","gravatar_id":"","url":"https://api.github.com/users/EdDev","html_url":"https://github.com/EdDev","followers_url":"https://api.github.com/users/EdDev/followers","following_url":"https://api.github.com/users/EdDev/following{/other_user}","gists_url":"https://api.github.com/users/EdDev/gists{/gist_id}","starred_url":"https://api.github.com/users/EdDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdDev/subscriptions","organizations_url":"https://api.github.com/users/EdDev/orgs","repos_url":"https://api.github.com/users/EdDev/repos","events_url":"https://api.github.com/users/EdDev/events{/privacy}","received_events_url":"https://api.github.com/users/EdDev/received_events","type":"User","site_admin":false},"repo":{"id":133216954,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMyMTY5NTQ=","name":"nmstate","full_name":"EdDev/nmstate","private":false,"owner":{"login":"EdDev","id":9546119,"node_id":"MDQ6VXNlcjk1NDYxMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/9546119?v=4","gravatar_id":"","url":"https://api.github.com/users/EdDev","html_url":"https://github.com/EdDev","followers_url":"https://api.github.com/users/EdDev/followers","following_url":"https://api.github.com/users/EdDev/following{/other_user}","gists_url":"https://api.github.com/users/EdDev/gists{/gist_id}","starred_url":"https://api.github.com/users/EdDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdDev/subscriptions","organizations_url":"https://api.github.com/users/EdDev/orgs","repos_url":"https://api.github.com/users/EdDev/repos","events_url":"https://api.github.com/users/EdDev/events{/privacy}","received_events_url":"https://api.github.com/users/EdDev/received_events","type":"User","site_admin":false},"html_url":"https://github.com/EdDev/nmstate","description":null,"fork":true,"url":"https://api.github.com/repos/EdDev/nmstate","forks_url":"https://api.github.com/repos/EdDev/nmstate/forks","keys_url":"https://api.github.com/repos/EdDev/nmstate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EdDev/nmstate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EdDev/nmstate/teams","hooks_url":"https://api.github.com/repos/EdDev/nmstate/hooks","issue_events_url":"https://api.github.com/repos/EdDev/nmstate/issues/events{/number}","events_url":"https://api.github.com/repos/EdDev/nmstate/events","assignees_url":"https://api.github.com/repos/EdDev/nmstate/assignees{/user}","branches_url":"https://api.github.com/repos/EdDev/nmstate/branches{/branch}","tags_url":"https://api.github.com/repos/EdDev/nmstate/tags","blobs_url":"https://api.github.com/repos/EdDev/nmstate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EdDev/nmstate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EdDev/nmstate/git/refs{/sha}","trees_url":"https://api.github.com/repos/EdDev/nmstate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EdDev/nmstate/statuses/{sha}","languages_url":"https://api.github.com/repos/EdDev/nmstate/languages","stargazers_url":"https://api.github.com/repos/EdDev/nmstate/stargazers","contributors_url":"https://api.github.com/repos/EdDev/nmstate/contributors","subscribers_url":"https://api.github.com/repos/EdDev/nmstate/subscribers","subscription_url":"https://api.github.com/repos/EdDev/nmstate/subscription","commits_url":"https://api.github.com/repos/EdDev/nmstate/commits{/sha}","git_commits_url":"https://api.github.com/repos/EdDev/nmstate/git/commits{/sha}","comments_url":"https://api.github.com/repos/EdDev/nmstate/comments{/number}","issue_comment_url":"https://api.github.com/repos/EdDev/nmstate/issues/comments{/number}","contents_url":"https://api.github.com/repos/EdDev/nmstate/contents/{+path}","compare_url":"https://api.github.com/repos/EdDev/nmstate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EdDev/nmstate/merges","archive_url":"https://api.github.com/repos/EdDev/nmstate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EdDev/nmstate/downloads","issues_url":"https://api.github.com/repos/EdDev/nmstate/issues{/number}","pulls_url":"https://api.github.com/repos/EdDev/nmstate/pulls{/number}","milestones_url":"https://api.github.com/repos/EdDev/nmstate/milestones{/number}","notifications_url":"https://api.github.com/repos/EdDev/nmstate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EdDev/nmstate/labels{/name}","releases_url":"https://api.github.com/repos/EdDev/nmstate/releases{/id}","deployments_url":"https://api.github.com/repos/EdDev/nmstate/deployments","created_at":"2018-05-13T07:58:22Z","updated_at":"2018-07-25T13:49:31Z","pushed_at":"2018-12-18T17:06:52Z","git_url":"git://github.com/EdDev/nmstate.git","ssh_url":"git@github.com:EdDev/nmstate.git","clone_url":"https://github.com/EdDev/nmstate.git","svn_url":"https://github.com/EdDev/nmstate","homepage":null,"size":346,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nmstate:master","ref":"master","sha":"dd2b4f600062bf849a045539ed4bc17bc18d539a","user":{"login":"nmstate","id":39068239,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MDY4MjM5","avatar_url":"https://avatars0.githubusercontent.com/u/39068239?v=4","gravatar_id":"","url":"https://api.github.com/users/nmstate","html_url":"https://github.com/nmstate","followers_url":"https://api.github.com/users/nmstate/followers","following_url":"https://api.github.com/users/nmstate/following{/other_user}","gists_url":"https://api.github.com/users/nmstate/gists{/gist_id}","starred_url":"https://api.github.com/users/nmstate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmstate/subscriptions","organizations_url":"https://api.github.com/users/nmstate/orgs","repos_url":"https://api.github.com/users/nmstate/repos","events_url":"https://api.github.com/users/nmstate/events{/privacy}","received_events_url":"https://api.github.com/users/nmstate/received_events","type":"Organization","site_admin":false},"repo":{"id":132556280,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI1NTYyODA=","name":"nmstate","full_name":"nmstate/nmstate","private":false,"owner":{"login":"nmstate","id":39068239,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MDY4MjM5","avatar_url":"https://avatars0.githubusercontent.com/u/39068239?v=4","gravatar_id":"","url":"https://api.github.com/users/nmstate","html_url":"https://github.com/nmstate","followers_url":"https://api.github.com/users/nmstate/followers","following_url":"https://api.github.com/users/nmstate/following{/other_user}","gists_url":"https://api.github.com/users/nmstate/gists{/gist_id}","starred_url":"https://api.github.com/users/nmstate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmstate/subscriptions","organizations_url":"https://api.github.com/users/nmstate/orgs","repos_url":"https://api.github.com/users/nmstate/repos","events_url":"https://api.github.com/users/nmstate/events{/privacy}","received_events_url":"https://api.github.com/users/nmstate/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nmstate/nmstate","description":"A declarative network manager API for hosts","fork":false,"url":"https://api.github.com/repos/nmstate/nmstate","forks_url":"https://api.github.com/repos/nmstate/nmstate/forks","keys_url":"https://api.github.com/repos/nmstate/nmstate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nmstate/nmstate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nmstate/nmstate/teams","hooks_url":"https://api.github.com/repos/nmstate/nmstate/hooks","issue_events_url":"https://api.github.com/repos/nmstate/nmstate/issues/events{/number}","events_url":"https://api.github.com/repos/nmstate/nmstate/events","assignees_url":"https://api.github.com/repos/nmstate/nmstate/assignees{/user}","branches_url":"https://api.github.com/repos/nmstate/nmstate/branches{/branch}","tags_url":"https://api.github.com/repos/nmstate/nmstate/tags","blobs_url":"https://api.github.com/repos/nmstate/nmstate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nmstate/nmstate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nmstate/nmstate/git/refs{/sha}","trees_url":"https://api.github.com/repos/nmstate/nmstate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nmstate/nmstate/statuses/{sha}","languages_url":"https://api.github.com/repos/nmstate/nmstate/languages","stargazers_url":"https://api.github.com/repos/nmstate/nmstate/stargazers","contributors_url":"https://api.github.com/repos/nmstate/nmstate/contributors","subscribers_url":"https://api.github.com/repos/nmstate/nmstate/subscribers","subscription_url":"https://api.github.com/repos/nmstate/nmstate/subscription","commits_url":"https://api.github.com/repos/nmstate/nmstate/commits{/sha}","git_commits_url":"https://api.github.com/repos/nmstate/nmstate/git/commits{/sha}","comments_url":"https://api.github.com/repos/nmstate/nmstate/comments{/number}","issue_comment_url":"https://api.github.com/repos/nmstate/nmstate/issues/comments{/number}","contents_url":"https://api.github.com/repos/nmstate/nmstate/contents/{+path}","compare_url":"https://api.github.com/repos/nmstate/nmstate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nmstate/nmstate/merges","archive_url":"https://api.github.com/repos/nmstate/nmstate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nmstate/nmstate/downloads","issues_url":"https://api.github.com/repos/nmstate/nmstate/issues{/number}","pulls_url":"https://api.github.com/repos/nmstate/nmstate/pulls{/number}","milestones_url":"https://api.github.com/repos/nmstate/nmstate/milestones{/number}","notifications_url":"https://api.github.com/repos/nmstate/nmstate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nmstate/nmstate/labels{/name}","releases_url":"https://api.github.com/repos/nmstate/nmstate/releases{/id}","deployments_url":"https://api.github.com/repos/nmstate/nmstate/deployments","created_at":"2018-05-08T05:02:22Z","updated_at":"2018-12-18T17:06:23Z","pushed_at":"2018-12-18T18:19:30Z","git_url":"git://github.com/nmstate/nmstate.git","ssh_url":"git@github.com:nmstate/nmstate.git","clone_url":"https://github.com/nmstate/nmstate.git","svn_url":"https://github.com/nmstate/nmstate","homepage":"https://nmstate.github.io","size":305,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":6,"open_issues":22,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nmstate/nmstate/pulls/193"},"html":{"href":"https://github.com/nmstate/nmstate/pull/193"},"issue":{"href":"https://api.github.com/repos/nmstate/nmstate/issues/193"},"comments":{"href":"https://api.github.com/repos/nmstate/nmstate/issues/193/comments"},"review_comments":{"href":"https://api.github.com/repos/nmstate/nmstate/pulls/193/comments"},"review_comment":{"href":"https://api.github.com/repos/nmstate/nmstate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nmstate/nmstate/pulls/193/commits"},"statuses":{"href":"https://api.github.com/repos/nmstate/nmstate/statuses/20f3e4711eed57ddcc03e86d5a9157e62f709b08"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"EdDev","id":9546119,"node_id":"MDQ6VXNlcjk1NDYxMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/9546119?v=4","gravatar_id":"","url":"https://api.github.com/users/EdDev","html_url":"https://github.com/EdDev","followers_url":"https://api.github.com/users/EdDev/followers","following_url":"https://api.github.com/users/EdDev/following{/other_user}","gists_url":"https://api.github.com/users/EdDev/gists{/gist_id}","starred_url":"https://api.github.com/users/EdDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdDev/subscriptions","organizations_url":"https://api.github.com/users/EdDev/orgs","repos_url":"https://api.github.com/users/EdDev/repos","events_url":"https://api.github.com/users/EdDev/events{/privacy}","received_events_url":"https://api.github.com/users/EdDev/received_events","type":"User","site_admin":false},"comments":4,"review_comments":6,"maintainer_can_modify":false,"commits":1,"additions":56,"deletions":10,"changed_files":3}}
{"actor":{"display_login":"EdDev"}}