{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/23703","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/23703/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/23703/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/23703/events","html_url":"https://github.com/cms-sw/cmssw/pull/23703","id":336419609,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3ODc4MDMz","number":23703,"title":"Simplify digi types for HGCal, add dummy unpacker and aliases","user":{"login":"kpedro88","id":4672808,"node_id":"MDQ6VXNlcjQ2NzI4MDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4672808?v=4","gravatar_id":"","url":"https://api.github.com/users/kpedro88","html_url":"https://github.com/kpedro88","followers_url":"https://api.github.com/users/kpedro88/followers","following_url":"https://api.github.com/users/kpedro88/following{/other_user}","gists_url":"https://api.github.com/users/kpedro88/gists{/gist_id}","starred_url":"https://api.github.com/users/kpedro88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpedro88/subscriptions","organizations_url":"https://api.github.com/users/kpedro88/orgs","repos_url":"https://api.github.com/users/kpedro88/repos","events_url":"https://api.github.com/users/kpedro88/events{/privacy}","received_events_url":"https://api.github.com/users/kpedro88/received_events","type":"User","site_admin":false},"labels":[{"id":673935056,"node_id":"MDU6TGFiZWw2NzM5MzUwNTY=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-pending","name":"code-checks-pending","color":"fbca04","default":false},{"id":88653795,"node_id":"MDU6TGFiZWw4ODY1Mzc5NQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":52820549,"node_id":"MDU6TGFiZWw1MjgyMDU0OQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/dqm-pending","name":"dqm-pending","color":"fbca04","default":false},{"id":52820587,"node_id":"MDU6TGFiZWw1MjgyMDU4Nw==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/l1-pending","name":"l1-pending","color":"fbca04","default":false},{"id":52881747,"node_id":"MDU6TGFiZWw1Mjg4MTc0Nw==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/operations-pending","name":"operations-pending","color":"fbca04","default":false},{"id":56953091,"node_id":"MDU6TGFiZWw1Njk1MzA5MQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"node_id":"MDU6TGFiZWw1MzE2Nzc3MA==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"ff8000","default":false},{"id":52820010,"node_id":"MDU6TGFiZWw1MjgyMDAxMA==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false},{"id":52820523,"node_id":"MDU6TGFiZWw1MjgyMDUyMw==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/simulation-pending","name":"simulation-pending","color":"fbca04","default":false},{"id":56131152,"node_id":"MDU6TGFiZWw1NjEzMTE1Mg==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-pending","name":"tests-pending","color":"fbca04","default":false},{"id":530655448,"node_id":"MDU6TGFiZWw1MzA2NTU0NDg=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/upgrade-pending","name":"upgrade-pending","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/76","html_url":"https://github.com/cms-sw/cmssw/milestone/76","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/76/labels","id":3227631,"node_id":"MDk6TWlsZXN0b25lMzIyNzYzMQ==","number":76,"title":"CMSSW_10_2_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"node_id":"MDQ6VXNlcjQxMTUxMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":48,"closed_issues":692,"state":"open","created_at":"2018-03-29T07:57:10Z","updated_at":"2018-07-04T14:36:29Z","due_on":null,"closed_at":null},"comments":32,"created_at":"2018-06-27T23:15:31Z","updated_at":"2018-07-04T16:40:25Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/23703","html_url":"https://github.com/cms-sw/cmssw/pull/23703","diff_url":"https://github.com/cms-sw/cmssw/pull/23703.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/23703.patch"},"body":"Followup to #23690.\r\n\r\nWhile we will keep the old digi collection types in order to be able to read previously produced files, from now on all HGCal digis will just store a generic DetId. This is far preferable to adding switches throughout the code to handle the DetId type changes in the new geometry.\r\n\r\nattn:\r\n@bsunanda - I propagated this change to the testbeam code, is it acceptable?\r\n@jbsauvan - I propagated this change to the L1T code, let me know if it interferes with anything (hopefully not, just a straightforward changing of types).\r\n\r\nFollowup:\r\nIn order to facilitate reading the old digi types from existing samples to rerun reco/validation sequences, a \"dummy\" unpacker was added for HGCal, with output type `hgcalDigis`. The unpacker module can be swapped out with a converter that changes the digi types, using the process modifier `convertHGCalDigisReco`.\r\n\r\nSimilarly, to rerun digi/L1 sequences, an `EDAlias` was added for the simulated digis, `simHGCalUnsuppressedDigis`. This `EDAlias` can be swapped out with the same converter module using the process modifier `convertHGCalDigisSim`."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/402524079","html_url":"https://github.com/cms-sw/cmssw/pull/23703#issuecomment-402524079","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/23703","id":402524079,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjUyNDA3OQ==","user":{"login":"cmsbuild","id":4170616,"node_id":"MDQ6VXNlcjQxNzA2MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/4170616?v=4","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2018-07-04T16:40:25Z","updated_at":"2018-07-04T16:40:25Z","author_association":"CONTRIBUTOR","body":"The code-checks are being triggered in jenkins."}}
{"actor":{"display_login":"cmsbuild"}}