{"action":"created","comment":{"url":"https://api.github.com/repos/thoughtbot/factory_bot/pulls/comments/221989718","pull_request_review_id":160770328,"id":221989718,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTk4OTcxOA==","diff_hunk":"@@ -48,7 +48,7 @@ def with_options(options)\n     def failure_message\n       [\n         \"expected declarations to include declaration of type #{@declaration_type}\",\n-        @options ? \"with options #{options}\" : nil\n+        @options ? \"with options #{options}\" : nil,","path":"spec/support/matchers/declaration.rb","position":5,"original_position":5,"commit_id":"f39e93011c5bdb8bd4e97eec25e6df09e62ab92f","original_commit_id":"f39e93011c5bdb8bd4e97eec25e6df09e62ab92f","user":{"login":"mikegee","id":14068,"node_id":"MDQ6VXNlcjE0MDY4","avatar_url":"https://avatars3.githubusercontent.com/u/14068?v=4","gravatar_id":"","url":"https://api.github.com/users/mikegee","html_url":"https://github.com/mikegee","followers_url":"https://api.github.com/users/mikegee/followers","following_url":"https://api.github.com/users/mikegee/following{/other_user}","gists_url":"https://api.github.com/users/mikegee/gists{/gist_id}","starred_url":"https://api.github.com/users/mikegee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikegee/subscriptions","organizations_url":"https://api.github.com/users/mikegee/orgs","repos_url":"https://api.github.com/users/mikegee/repos","events_url":"https://api.github.com/users/mikegee/events{/privacy}","received_events_url":"https://api.github.com/users/mikegee/received_events","type":"User","site_admin":false},"body":"Perhaps out of scope for this PR, but I'd prefer if this ternary were replaced with \r\n```ruby\r\n@options && \"with options #{options}\"\r\n```","created_at":"2018-10-02T15:05:29Z","updated_at":"2018-10-02T15:05:29Z","html_url":"https://github.com/thoughtbot/factory_bot/pull/1208#discussion_r221989718","pull_request_url":"https://api.github.com/repos/thoughtbot/factory_bot/pulls/1208","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/factory_bot/pulls/comments/221989718"},"html":{"href":"https://github.com/thoughtbot/factory_bot/pull/1208#discussion_r221989718"},"pull_request":{"href":"https://api.github.com/repos/thoughtbot/factory_bot/pulls/1208"}}},"pull_request":{"url":"https://api.github.com/repos/thoughtbot/factory_bot/pulls/1208","id":219579761,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NTc5NzYx","html_url":"https://github.com/thoughtbot/factory_bot/pull/1208","diff_url":"https://github.com/thoughtbot/factory_bot/pull/1208.diff","patch_url":"https://github.com/thoughtbot/factory_bot/pull/1208.patch","issue_url":"https://api.github.com/repos/thoughtbot/factory_bot/issues/1208","number":1208,"state":"open","locked":false,"title":"[Rubocop] Style Cop Offenses","user":{"login":"goronfreeman","id":5210483,"node_id":"MDQ6VXNlcjUyMTA0ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/5210483?v=4","gravatar_id":"","url":"https://api.github.com/users/goronfreeman","html_url":"https://github.com/goronfreeman","followers_url":"https://api.github.com/users/goronfreeman/followers","following_url":"https://api.github.com/users/goronfreeman/following{/other_user}","gists_url":"https://api.github.com/users/goronfreeman/gists{/gist_id}","starred_url":"https://api.github.com/users/goronfreeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goronfreeman/subscriptions","organizations_url":"https://api.github.com/users/goronfreeman/orgs","repos_url":"https://api.github.com/users/goronfreeman/repos","events_url":"https://api.github.com/users/goronfreeman/events{/privacy}","received_events_url":"https://api.github.com/users/goronfreeman/received_events","type":"User","site_admin":false},"body":"Continue addressing #1202 \r\n\r\nAddresses most of the 'Style' cops. I opted to skip a couple cops, because I don't have enough knowledge about them to know how to correctly fix them. The first is the `Style/MethodMissing` cop. I saw [this thread](https://github.com/rubocop-hq/rubocop/issues/3760) and thought that that same issue may apply. If anyone has a suggestion on what route to go on this, I can make the change if requested.\r\n\r\nThe other is the `Style/StringLiterals` cop. There is a big split on strings that use single and double quotes, so I'm not sure if we want to settle on one and use it. If someone tells me the preference, I can easily fix this as well.\r\n\r\nI also had to omit fixing the `Style/RedundantBegin` cop because after making the change, Hound complained about invalid syntax. I'm guessing Hound must be checking for an older Ruby syntax before method blocks counted as an implicit `begin`. This could be fixed by setting a [`TargetRubyVersion`](https://github.com/rubocop-hq/rubocop/blob/master/manual/configuration.md#setting-the-target-ruby-version) in the Rubocop config file.\r\n\r\nLast thing I want to point out is that I made a change to the Rubocop config based on the current style in the code. In spec files, curly braces are used for multi-line chained blocks with some `expect` blocks:\r\n\r\n```ruby\r\nexpect {\r\n  2.times { subject.define_attribute(attribute) }\r\n}.to raise_error(...)\r\n```\r\n\r\nI omitted spec files for the `Style/BlockDelimiters` cop because this was used in a few different places in the specs. If a reviewer decides this isn't the desired fix, I can either use `do/end` blocks instead, or convert these to single-lines instead.","created_at":"2018-10-02T04:03:38Z","updated_at":"2018-10-02T15:05:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74a6ad9bac1cbc0cf6ddbb6a44dccde60045820c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/thoughtbot/factory_bot/pulls/1208/commits","review_comments_url":"https://api.github.com/repos/thoughtbot/factory_bot/pulls/1208/comments","review_comment_url":"https://api.github.com/repos/thoughtbot/factory_bot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thoughtbot/factory_bot/issues/1208/comments","statuses_url":"https://api.github.com/repos/thoughtbot/factory_bot/statuses/f39e93011c5bdb8bd4e97eec25e6df09e62ab92f","head":{"label":"goronfreeman:rubocop-misc-style-cop-offenses","ref":"rubocop-misc-style-cop-offenses","sha":"f39e93011c5bdb8bd4e97eec25e6df09e62ab92f","user":{"login":"goronfreeman","id":5210483,"node_id":"MDQ6VXNlcjUyMTA0ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/5210483?v=4","gravatar_id":"","url":"https://api.github.com/users/goronfreeman","html_url":"https://github.com/goronfreeman","followers_url":"https://api.github.com/users/goronfreeman/followers","following_url":"https://api.github.com/users/goronfreeman/following{/other_user}","gists_url":"https://api.github.com/users/goronfreeman/gists{/gist_id}","starred_url":"https://api.github.com/users/goronfreeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goronfreeman/subscriptions","organizations_url":"https://api.github.com/users/goronfreeman/orgs","repos_url":"https://api.github.com/users/goronfreeman/repos","events_url":"https://api.github.com/users/goronfreeman/events{/privacy}","received_events_url":"https://api.github.com/users/goronfreeman/received_events","type":"User","site_admin":false},"repo":{"id":151183583,"node_id":"MDEwOlJlcG9zaXRvcnkxNTExODM1ODM=","name":"factory_bot","full_name":"goronfreeman/factory_bot","private":false,"owner":{"login":"goronfreeman","id":5210483,"node_id":"MDQ6VXNlcjUyMTA0ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/5210483?v=4","gravatar_id":"","url":"https://api.github.com/users/goronfreeman","html_url":"https://github.com/goronfreeman","followers_url":"https://api.github.com/users/goronfreeman/followers","following_url":"https://api.github.com/users/goronfreeman/following{/other_user}","gists_url":"https://api.github.com/users/goronfreeman/gists{/gist_id}","starred_url":"https://api.github.com/users/goronfreeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goronfreeman/subscriptions","organizations_url":"https://api.github.com/users/goronfreeman/orgs","repos_url":"https://api.github.com/users/goronfreeman/repos","events_url":"https://api.github.com/users/goronfreeman/events{/privacy}","received_events_url":"https://api.github.com/users/goronfreeman/received_events","type":"User","site_admin":false},"html_url":"https://github.com/goronfreeman/factory_bot","description":"A library for setting up Ruby objects as test data.","fork":true,"url":"https://api.github.com/repos/goronfreeman/factory_bot","forks_url":"https://api.github.com/repos/goronfreeman/factory_bot/forks","keys_url":"https://api.github.com/repos/goronfreeman/factory_bot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/goronfreeman/factory_bot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/goronfreeman/factory_bot/teams","hooks_url":"https://api.github.com/repos/goronfreeman/factory_bot/hooks","issue_events_url":"https://api.github.com/repos/goronfreeman/factory_bot/issues/events{/number}","events_url":"https://api.github.com/repos/goronfreeman/factory_bot/events","assignees_url":"https://api.github.com/repos/goronfreeman/factory_bot/assignees{/user}","branches_url":"https://api.github.com/repos/goronfreeman/factory_bot/branches{/branch}","tags_url":"https://api.github.com/repos/goronfreeman/factory_bot/tags","blobs_url":"https://api.github.com/repos/goronfreeman/factory_bot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/goronfreeman/factory_bot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/goronfreeman/factory_bot/git/refs{/sha}","trees_url":"https://api.github.com/repos/goronfreeman/factory_bot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/goronfreeman/factory_bot/statuses/{sha}","languages_url":"https://api.github.com/repos/goronfreeman/factory_bot/languages","stargazers_url":"https://api.github.com/repos/goronfreeman/factory_bot/stargazers","contributors_url":"https://api.github.com/repos/goronfreeman/factory_bot/contributors","subscribers_url":"https://api.github.com/repos/goronfreeman/factory_bot/subscribers","subscription_url":"https://api.github.com/repos/goronfreeman/factory_bot/subscription","commits_url":"https://api.github.com/repos/goronfreeman/factory_bot/commits{/sha}","git_commits_url":"https://api.github.com/repos/goronfreeman/factory_bot/git/commits{/sha}","comments_url":"https://api.github.com/repos/goronfreeman/factory_bot/comments{/number}","issue_comment_url":"https://api.github.com/repos/goronfreeman/factory_bot/issues/comments{/number}","contents_url":"https://api.github.com/repos/goronfreeman/factory_bot/contents/{+path}","compare_url":"https://api.github.com/repos/goronfreeman/factory_bot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/goronfreeman/factory_bot/merges","archive_url":"https://api.github.com/repos/goronfreeman/factory_bot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/goronfreeman/factory_bot/downloads","issues_url":"https://api.github.com/repos/goronfreeman/factory_bot/issues{/number}","pulls_url":"https://api.github.com/repos/goronfreeman/factory_bot/pulls{/number}","milestones_url":"https://api.github.com/repos/goronfreeman/factory_bot/milestones{/number}","notifications_url":"https://api.github.com/repos/goronfreeman/factory_bot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/goronfreeman/factory_bot/labels{/name}","releases_url":"https://api.github.com/repos/goronfreeman/factory_bot/releases{/id}","deployments_url":"https://api.github.com/repos/goronfreeman/factory_bot/deployments","created_at":"2018-10-02T01:16:56Z","updated_at":"2018-10-02T01:16:59Z","pushed_at":"2018-10-02T04:31:10Z","git_url":"git://github.com/goronfreeman/factory_bot.git","ssh_url":"git@github.com:goronfreeman/factory_bot.git","clone_url":"https://github.com/goronfreeman/factory_bot.git","svn_url":"https://github.com/goronfreeman/factory_bot","homepage":"https://thoughtbot.com/open-source","size":2086,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thoughtbot:master","ref":"master","sha":"cbe242c9427161c16d45bde560421a0445ecb579","user":{"login":"thoughtbot","id":6183,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxODM=","avatar_url":"https://avatars3.githubusercontent.com/u/6183?v=4","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"repo":{"id":21829,"node_id":"MDEwOlJlcG9zaXRvcnkyMTgyOQ==","name":"factory_bot","full_name":"thoughtbot/factory_bot","private":false,"owner":{"login":"thoughtbot","id":6183,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxODM=","avatar_url":"https://avatars3.githubusercontent.com/u/6183?v=4","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/thoughtbot/factory_bot","description":"A library for setting up Ruby objects as test data.","fork":false,"url":"https://api.github.com/repos/thoughtbot/factory_bot","forks_url":"https://api.github.com/repos/thoughtbot/factory_bot/forks","keys_url":"https://api.github.com/repos/thoughtbot/factory_bot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtbot/factory_bot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtbot/factory_bot/teams","hooks_url":"https://api.github.com/repos/thoughtbot/factory_bot/hooks","issue_events_url":"https://api.github.com/repos/thoughtbot/factory_bot/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtbot/factory_bot/events","assignees_url":"https://api.github.com/repos/thoughtbot/factory_bot/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtbot/factory_bot/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtbot/factory_bot/tags","blobs_url":"https://api.github.com/repos/thoughtbot/factory_bot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtbot/factory_bot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtbot/factory_bot/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtbot/factory_bot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtbot/factory_bot/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtbot/factory_bot/languages","stargazers_url":"https://api.github.com/repos/thoughtbot/factory_bot/stargazers","contributors_url":"https://api.github.com/repos/thoughtbot/factory_bot/contributors","subscribers_url":"https://api.github.com/repos/thoughtbot/factory_bot/subscribers","subscription_url":"https://api.github.com/repos/thoughtbot/factory_bot/subscription","commits_url":"https://api.github.com/repos/thoughtbot/factory_bot/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtbot/factory_bot/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtbot/factory_bot/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtbot/factory_bot/issues/comments{/number}","contents_url":"https://api.github.com/repos/thoughtbot/factory_bot/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtbot/factory_bot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtbot/factory_bot/merges","archive_url":"https://api.github.com/repos/thoughtbot/factory_bot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtbot/factory_bot/downloads","issues_url":"https://api.github.com/repos/thoughtbot/factory_bot/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtbot/factory_bot/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtbot/factory_bot/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtbot/factory_bot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtbot/factory_bot/labels{/name}","releases_url":"https://api.github.com/repos/thoughtbot/factory_bot/releases{/id}","deployments_url":"https://api.github.com/repos/thoughtbot/factory_bot/deployments","created_at":"2008-06-03T13:55:37Z","updated_at":"2018-10-02T11:54:43Z","pushed_at":"2018-10-02T04:34:26Z","git_url":"git://github.com/thoughtbot/factory_bot.git","ssh_url":"git@github.com:thoughtbot/factory_bot.git","clone_url":"https://github.com/thoughtbot/factory_bot.git","svn_url":"https://github.com/thoughtbot/factory_bot","homepage":"https://thoughtbot.com/open-source","size":2058,"stargazers_count":6147,"watchers_count":6147,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1629,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1629,"open_issues":45,"watchers":6147,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/factory_bot/pulls/1208"},"html":{"href":"https://github.com/thoughtbot/factory_bot/pull/1208"},"issue":{"href":"https://api.github.com/repos/thoughtbot/factory_bot/issues/1208"},"comments":{"href":"https://api.github.com/repos/thoughtbot/factory_bot/issues/1208/comments"},"review_comments":{"href":"https://api.github.com/repos/thoughtbot/factory_bot/pulls/1208/comments"},"review_comment":{"href":"https://api.github.com/repos/thoughtbot/factory_bot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thoughtbot/factory_bot/pulls/1208/commits"},"statuses":{"href":"https://api.github.com/repos/thoughtbot/factory_bot/statuses/f39e93011c5bdb8bd4e97eec25e6df09e62ab92f"}},"author_association":"NONE"}}
{"actor":{"display_login":"mikegee"}}