{"action":"created","issue":{"url":"https://api.github.com/repos/helpscout/hsds-react/issues/405","repository_url":"https://api.github.com/repos/helpscout/hsds-react","labels_url":"https://api.github.com/repos/helpscout/hsds-react/issues/405/labels{/name}","comments_url":"https://api.github.com/repos/helpscout/hsds-react/issues/405/comments","events_url":"https://api.github.com/repos/helpscout/hsds-react/issues/405/events","html_url":"https://github.com/helpscout/hsds-react/pull/405","id":384373572,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNTkxMDgx","number":405,"title":"Update Page component","user":{"login":"tinkertrain","id":1414086,"node_id":"MDQ6VXNlcjE0MTQwODY=","avatar_url":"https://avatars1.githubusercontent.com/u/1414086?v=4","gravatar_id":"","url":"https://api.github.com/users/tinkertrain","html_url":"https://github.com/tinkertrain","followers_url":"https://api.github.com/users/tinkertrain/followers","following_url":"https://api.github.com/users/tinkertrain/following{/other_user}","gists_url":"https://api.github.com/users/tinkertrain/gists{/gist_id}","starred_url":"https://api.github.com/users/tinkertrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinkertrain/subscriptions","organizations_url":"https://api.github.com/users/tinkertrain/orgs","repos_url":"https://api.github.com/users/tinkertrain/repos","events_url":"https://api.github.com/users/tinkertrain/events{/privacy}","received_events_url":"https://api.github.com/users/tinkertrain/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-26T15:10:25Z","updated_at":"2018-11-26T15:16:44Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/helpscout/hsds-react/pulls/405","html_url":"https://github.com/helpscout/hsds-react/pull/405","diff_url":"https://github.com/helpscout/hsds-react/pull/405.diff","patch_url":"https://github.com/helpscout/hsds-react/pull/405.patch"},"body":"## Page Component\r\n- Updates styles to match latest designs\r\n- Improves html semantics and accessibility:\r\n  a. Page header using `<header>`\r\n  b. Headings Using `<h1>` and `<h2>`\r\n  c. Cards use `<section>`\r\n- Moves to TypeScript\r\n- Fixes import in `<Accordion>`\r\n\r\n## <Page.Heading> Component\r\nPages generally have a main heading and multiple secondary ones, this component adds the ability to use <Page.Heading> with the correct styles for pages\r\n\r\n`<Page.Header>` leverages this component in `primary` mode\r\n\r\nUpdated Page.Card.stories to see the changes\r\n\r\n## Adds fsevents to optional dependencies\r\n\r\nWebpack has an issue where on a mac, the CPU usage spikes to more than a 100%\r\n\r\nReference:\r\n- https://github.com/storybooks/storybook/issues/752\r\n- https://github.com/webpack/webpack/issues/701\r\n\r\nAdding fsevents as a dependency fixes this issue, putting as optional means it won't break non-mac installations\r\n\r\n## TODO\r\n\r\nTests"},"comment":{"url":"https://api.github.com/repos/helpscout/hsds-react/issues/comments/441674623","html_url":"https://github.com/helpscout/hsds-react/pull/405#issuecomment-441674623","issue_url":"https://api.github.com/repos/helpscout/hsds-react/issues/405","id":441674623,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTY3NDYyMw==","user":{"login":"coveralls","id":2354108,"node_id":"MDQ6VXNlcjIzNTQxMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2354108?v=4","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2018-11-26T15:16:44Z","updated_at":"2018-11-26T15:16:44Z","author_association":"NONE","body":"## Pull Request Test Coverage Report for [Build 1316](https://coveralls.io/builds/20292167)\n\n* **32** of **32**   **(100.0%)**  changed or added relevant lines in **8** files are covered.\n* No unchanged relevant lines lost coverage.\n* Overall coverage decreased (**-0.01%**) to **99.988%**\n\n---\n\n\n\n|  Totals | [![Coverage Status](https://coveralls.io/builds/20292167/badge)](https://coveralls.io/builds/20292167) |\n| :-- | --: |\n| Change from base [Build 1315](https://coveralls.io/builds/20251660): |  -0.01% |\n| Covered Lines: | 5035 |\n| Relevant Lines: | 5035 |\n\n---\n##### 💛  - [Coveralls](https://coveralls.io)\n"}}
{"actor":{"display_login":"coveralls"}}