{"action":"created","comment":{"url":"https://api.github.com/repos/meteor/meteor/pulls/comments/245489778","pull_request_review_id":189609818,"id":245489778,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTQ4OTc3OA==","diff_hunk":"@@ -72,11 +72,13 @@ export default class Matcher {\n \n     let timer = null;\n     if (timeout) {\n+      const failure = new TestFailure('match-timeout', {\n+        run: this.run,\n+        pattern: this.matchPattern,\n+      });","path":"tools/tool-testing/matcher.js","position":7,"original_position":7,"commit_id":"5d88d9a1a4e97c8097fba1ddbcac1027b394bbb3","original_commit_id":"5d88d9a1a4e97c8097fba1ddbcac1027b394bbb3","user":{"login":"benjamn","id":5750,"node_id":"MDQ6VXNlcjU3NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/5750?v=4","gravatar_id":"","url":"https://api.github.com/users/benjamn","html_url":"https://github.com/benjamn","followers_url":"https://api.github.com/users/benjamn/followers","following_url":"https://api.github.com/users/benjamn/following{/other_user}","gists_url":"https://api.github.com/users/benjamn/gists{/gist_id}","starred_url":"https://api.github.com/users/benjamn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjamn/subscriptions","organizations_url":"https://api.github.com/users/benjamn/orgs","repos_url":"https://api.github.com/users/benjamn/repos","events_url":"https://api.github.com/users/benjamn/events{/privacy}","received_events_url":"https://api.github.com/users/benjamn/received_events","type":"User","site_admin":false},"body":"Creating the `TestFailure` outside the `setTimeout` callback is important here (and elsewhere) so that the correct stack trace is captured.","created_at":"2019-01-05T21:55:58Z","updated_at":"2019-01-05T21:55:58Z","html_url":"https://github.com/meteor/meteor/pull/10248#discussion_r245489778","pull_request_url":"https://api.github.com/repos/meteor/meteor/pulls/10248","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/meteor/meteor/pulls/comments/245489778"},"html":{"href":"https://github.com/meteor/meteor/pull/10248#discussion_r245489778"},"pull_request":{"href":"https://api.github.com/repos/meteor/meteor/pulls/10248"}}},"pull_request":{"url":"https://api.github.com/repos/meteor/meteor/pulls/10248","id":220909812,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwOTA5ODEy","html_url":"https://github.com/meteor/meteor/pull/10248","diff_url":"https://github.com/meteor/meteor/pull/10248.diff","patch_url":"https://github.com/meteor/meteor/pull/10248.patch","issue_url":"https://api.github.com/repos/meteor/meteor/issues/10248","number":10248,"state":"open","locked":false,"title":"Release 1.8.1","user":{"login":"benjamn","id":5750,"node_id":"MDQ6VXNlcjU3NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/5750?v=4","gravatar_id":"","url":"https://api.github.com/users/benjamn","html_url":"https://github.com/benjamn","followers_url":"https://api.github.com/users/benjamn/followers","following_url":"https://api.github.com/users/benjamn/following{/other_user}","gists_url":"https://api.github.com/users/benjamn/gists{/gist_id}","starred_url":"https://api.github.com/users/benjamn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjamn/subscriptions","organizations_url":"https://api.github.com/users/benjamn/orgs","repos_url":"https://api.github.com/users/benjamn/repos","events_url":"https://api.github.com/users/benjamn/events{/privacy}","received_events_url":"https://api.github.com/users/benjamn/received_events","type":"User","site_admin":false},"body":"As I explained in https://github.com/meteor/meteor/pull/9942#issuecomment-426817206, Meteor 1.8.1 will be a quick follow-up to Meteor 1.8 that upgrades Node to version 8.12.0, so that Galaxy customers can easily deploy their apps with that version of Node, even though there have been [some reports](https://github.com/meteor/meteor/issues/10216) that Node 8.12.0 has performance problems in production, due to excessive garbage collection.\r\n\r\nWe will not officially \"recommend\" the Meteor 1.8.1 release until we have resolved these concerns, but you can begin using it by running\r\n```bash\r\nmeteor update --release 1.8.1-beta.n\r\n```\r\nwhere `-beta.n` refers to the most recent prerelease version of Meteor 1.8.1.","created_at":"2018-10-06T20:29:41Z","updated_at":"2019-01-05T21:55:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28a0dadec991212108471248eea170c397ffe64f","assignee":{"login":"benjamn","id":5750,"node_id":"MDQ6VXNlcjU3NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/5750?v=4","gravatar_id":"","url":"https://api.github.com/users/benjamn","html_url":"https://github.com/benjamn","followers_url":"https://api.github.com/users/benjamn/followers","following_url":"https://api.github.com/users/benjamn/following{/other_user}","gists_url":"https://api.github.com/users/benjamn/gists{/gist_id}","starred_url":"https://api.github.com/users/benjamn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjamn/subscriptions","organizations_url":"https://api.github.com/users/benjamn/orgs","repos_url":"https://api.github.com/users/benjamn/repos","events_url":"https://api.github.com/users/benjamn/events{/privacy}","received_events_url":"https://api.github.com/users/benjamn/received_events","type":"User","site_admin":false},"assignees":[{"login":"benjamn","id":5750,"node_id":"MDQ6VXNlcjU3NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/5750?v=4","gravatar_id":"","url":"https://api.github.com/users/benjamn","html_url":"https://github.com/benjamn","followers_url":"https://api.github.com/users/benjamn/followers","following_url":"https://api.github.com/users/benjamn/following{/other_user}","gists_url":"https://api.github.com/users/benjamn/gists{/gist_id}","starred_url":"https://api.github.com/users/benjamn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjamn/subscriptions","organizations_url":"https://api.github.com/users/benjamn/orgs","repos_url":"https://api.github.com/users/benjamn/repos","events_url":"https://api.github.com/users/benjamn/events{/privacy}","received_events_url":"https://api.github.com/users/benjamn/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"abernix","id":841294,"node_id":"MDQ6VXNlcjg0MTI5NA==","avatar_url":"https://avatars0.githubusercontent.com/u/841294?v=4","gravatar_id":"","url":"https://api.github.com/users/abernix","html_url":"https://github.com/abernix","followers_url":"https://api.github.com/users/abernix/followers","following_url":"https://api.github.com/users/abernix/following{/other_user}","gists_url":"https://api.github.com/users/abernix/gists{/gist_id}","starred_url":"https://api.github.com/users/abernix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abernix/subscriptions","organizations_url":"https://api.github.com/users/abernix/orgs","repos_url":"https://api.github.com/users/abernix/repos","events_url":"https://api.github.com/users/abernix/events{/privacy}","received_events_url":"https://api.github.com/users/abernix/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/meteor/meteor/milestones/61","html_url":"https://github.com/meteor/meteor/milestone/61","labels_url":"https://api.github.com/repos/meteor/meteor/milestones/61/labels","id":3690268,"node_id":"MDk6TWlsZXN0b25lMzY5MDI2OA==","number":61,"title":"Release 1.8.1","description":null,"creator":{"login":"benjamn","id":5750,"node_id":"MDQ6VXNlcjU3NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/5750?v=4","gravatar_id":"","url":"https://api.github.com/users/benjamn","html_url":"https://github.com/benjamn","followers_url":"https://api.github.com/users/benjamn/followers","following_url":"https://api.github.com/users/benjamn/following{/other_user}","gists_url":"https://api.github.com/users/benjamn/gists{/gist_id}","starred_url":"https://api.github.com/users/benjamn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjamn/subscriptions","organizations_url":"https://api.github.com/users/benjamn/orgs","repos_url":"https://api.github.com/users/benjamn/repos","events_url":"https://api.github.com/users/benjamn/events{/privacy}","received_events_url":"https://api.github.com/users/benjamn/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":7,"state":"open","created_at":"2018-09-26T13:14:33Z","updated_at":"2019-01-04T18:36:08Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/meteor/meteor/pulls/10248/commits","review_comments_url":"https://api.github.com/repos/meteor/meteor/pulls/10248/comments","review_comment_url":"https://api.github.com/repos/meteor/meteor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/meteor/meteor/issues/10248/comments","statuses_url":"https://api.github.com/repos/meteor/meteor/statuses/5d88d9a1a4e97c8097fba1ddbcac1027b394bbb3","head":{"label":"meteor:release-1.8.1","ref":"release-1.8.1","sha":"5d88d9a1a4e97c8097fba1ddbcac1027b394bbb3","user":{"login":"meteor","id":789528,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4OTUyOA==","avatar_url":"https://avatars0.githubusercontent.com/u/789528?v=4","gravatar_id":"","url":"https://api.github.com/users/meteor","html_url":"https://github.com/meteor","followers_url":"https://api.github.com/users/meteor/followers","following_url":"https://api.github.com/users/meteor/following{/other_user}","gists_url":"https://api.github.com/users/meteor/gists{/gist_id}","starred_url":"https://api.github.com/users/meteor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meteor/subscriptions","organizations_url":"https://api.github.com/users/meteor/orgs","repos_url":"https://api.github.com/users/meteor/repos","events_url":"https://api.github.com/users/meteor/events{/privacy}","received_events_url":"https://api.github.com/users/meteor/received_events","type":"Organization","site_admin":false},"repo":{"id":3214406,"node_id":"MDEwOlJlcG9zaXRvcnkzMjE0NDA2","name":"meteor","full_name":"meteor/meteor","private":false,"owner":{"login":"meteor","id":789528,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4OTUyOA==","avatar_url":"https://avatars0.githubusercontent.com/u/789528?v=4","gravatar_id":"","url":"https://api.github.com/users/meteor","html_url":"https://github.com/meteor","followers_url":"https://api.github.com/users/meteor/followers","following_url":"https://api.github.com/users/meteor/following{/other_user}","gists_url":"https://api.github.com/users/meteor/gists{/gist_id}","starred_url":"https://api.github.com/users/meteor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meteor/subscriptions","organizations_url":"https://api.github.com/users/meteor/orgs","repos_url":"https://api.github.com/users/meteor/repos","events_url":"https://api.github.com/users/meteor/events{/privacy}","received_events_url":"https://api.github.com/users/meteor/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/meteor/meteor","description":"Meteor, the JavaScript App Platform","fork":false,"url":"https://api.github.com/repos/meteor/meteor","forks_url":"https://api.github.com/repos/meteor/meteor/forks","keys_url":"https://api.github.com/repos/meteor/meteor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meteor/meteor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meteor/meteor/teams","hooks_url":"https://api.github.com/repos/meteor/meteor/hooks","issue_events_url":"https://api.github.com/repos/meteor/meteor/issues/events{/number}","events_url":"https://api.github.com/repos/meteor/meteor/events","assignees_url":"https://api.github.com/repos/meteor/meteor/assignees{/user}","branches_url":"https://api.github.com/repos/meteor/meteor/branches{/branch}","tags_url":"https://api.github.com/repos/meteor/meteor/tags","blobs_url":"https://api.github.com/repos/meteor/meteor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meteor/meteor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meteor/meteor/git/refs{/sha}","trees_url":"https://api.github.com/repos/meteor/meteor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meteor/meteor/statuses/{sha}","languages_url":"https://api.github.com/repos/meteor/meteor/languages","stargazers_url":"https://api.github.com/repos/meteor/meteor/stargazers","contributors_url":"https://api.github.com/repos/meteor/meteor/contributors","subscribers_url":"https://api.github.com/repos/meteor/meteor/subscribers","subscription_url":"https://api.github.com/repos/meteor/meteor/subscription","commits_url":"https://api.github.com/repos/meteor/meteor/commits{/sha}","git_commits_url":"https://api.github.com/repos/meteor/meteor/git/commits{/sha}","comments_url":"https://api.github.com/repos/meteor/meteor/comments{/number}","issue_comment_url":"https://api.github.com/repos/meteor/meteor/issues/comments{/number}","contents_url":"https://api.github.com/repos/meteor/meteor/contents/{+path}","compare_url":"https://api.github.com/repos/meteor/meteor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meteor/meteor/merges","archive_url":"https://api.github.com/repos/meteor/meteor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meteor/meteor/downloads","issues_url":"https://api.github.com/repos/meteor/meteor/issues{/number}","pulls_url":"https://api.github.com/repos/meteor/meteor/pulls{/number}","milestones_url":"https://api.github.com/repos/meteor/meteor/milestones{/number}","notifications_url":"https://api.github.com/repos/meteor/meteor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meteor/meteor/labels{/name}","releases_url":"https://api.github.com/repos/meteor/meteor/releases{/id}","deployments_url":"https://api.github.com/repos/meteor/meteor/deployments","created_at":"2012-01-19T01:58:17Z","updated_at":"2019-01-05T20:38:57Z","pushed_at":"2019-01-05T21:55:17Z","git_url":"git://github.com/meteor/meteor.git","ssh_url":"git@github.com:meteor/meteor.git","clone_url":"https://github.com/meteor/meteor.git","svn_url":"https://github.com/meteor/meteor","homepage":"https://www.meteor.com","size":77242,"stargazers_count":40675,"watchers_count":40675,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5028,"mirror_url":null,"archived":false,"open_issues_count":266,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5028,"open_issues":266,"watchers":40675,"default_branch":"devel"}},"base":{"label":"meteor:master","ref":"master","sha":"5e8434ea42362ffecbac0cd0c19957d3ed318db2","user":{"login":"meteor","id":789528,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4OTUyOA==","avatar_url":"https://avatars0.githubusercontent.com/u/789528?v=4","gravatar_id":"","url":"https://api.github.com/users/meteor","html_url":"https://github.com/meteor","followers_url":"https://api.github.com/users/meteor/followers","following_url":"https://api.github.com/users/meteor/following{/other_user}","gists_url":"https://api.github.com/users/meteor/gists{/gist_id}","starred_url":"https://api.github.com/users/meteor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meteor/subscriptions","organizations_url":"https://api.github.com/users/meteor/orgs","repos_url":"https://api.github.com/users/meteor/repos","events_url":"https://api.github.com/users/meteor/events{/privacy}","received_events_url":"https://api.github.com/users/meteor/received_events","type":"Organization","site_admin":false},"repo":{"id":3214406,"node_id":"MDEwOlJlcG9zaXRvcnkzMjE0NDA2","name":"meteor","full_name":"meteor/meteor","private":false,"owner":{"login":"meteor","id":789528,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4OTUyOA==","avatar_url":"https://avatars0.githubusercontent.com/u/789528?v=4","gravatar_id":"","url":"https://api.github.com/users/meteor","html_url":"https://github.com/meteor","followers_url":"https://api.github.com/users/meteor/followers","following_url":"https://api.github.com/users/meteor/following{/other_user}","gists_url":"https://api.github.com/users/meteor/gists{/gist_id}","starred_url":"https://api.github.com/users/meteor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meteor/subscriptions","organizations_url":"https://api.github.com/users/meteor/orgs","repos_url":"https://api.github.com/users/meteor/repos","events_url":"https://api.github.com/users/meteor/events{/privacy}","received_events_url":"https://api.github.com/users/meteor/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/meteor/meteor","description":"Meteor, the JavaScript App Platform","fork":false,"url":"https://api.github.com/repos/meteor/meteor","forks_url":"https://api.github.com/repos/meteor/meteor/forks","keys_url":"https://api.github.com/repos/meteor/meteor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meteor/meteor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meteor/meteor/teams","hooks_url":"https://api.github.com/repos/meteor/meteor/hooks","issue_events_url":"https://api.github.com/repos/meteor/meteor/issues/events{/number}","events_url":"https://api.github.com/repos/meteor/meteor/events","assignees_url":"https://api.github.com/repos/meteor/meteor/assignees{/user}","branches_url":"https://api.github.com/repos/meteor/meteor/branches{/branch}","tags_url":"https://api.github.com/repos/meteor/meteor/tags","blobs_url":"https://api.github.com/repos/meteor/meteor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meteor/meteor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meteor/meteor/git/refs{/sha}","trees_url":"https://api.github.com/repos/meteor/meteor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meteor/meteor/statuses/{sha}","languages_url":"https://api.github.com/repos/meteor/meteor/languages","stargazers_url":"https://api.github.com/repos/meteor/meteor/stargazers","contributors_url":"https://api.github.com/repos/meteor/meteor/contributors","subscribers_url":"https://api.github.com/repos/meteor/meteor/subscribers","subscription_url":"https://api.github.com/repos/meteor/meteor/subscription","commits_url":"https://api.github.com/repos/meteor/meteor/commits{/sha}","git_commits_url":"https://api.github.com/repos/meteor/meteor/git/commits{/sha}","comments_url":"https://api.github.com/repos/meteor/meteor/comments{/number}","issue_comment_url":"https://api.github.com/repos/meteor/meteor/issues/comments{/number}","contents_url":"https://api.github.com/repos/meteor/meteor/contents/{+path}","compare_url":"https://api.github.com/repos/meteor/meteor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meteor/meteor/merges","archive_url":"https://api.github.com/repos/meteor/meteor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meteor/meteor/downloads","issues_url":"https://api.github.com/repos/meteor/meteor/issues{/number}","pulls_url":"https://api.github.com/repos/meteor/meteor/pulls{/number}","milestones_url":"https://api.github.com/repos/meteor/meteor/milestones{/number}","notifications_url":"https://api.github.com/repos/meteor/meteor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meteor/meteor/labels{/name}","releases_url":"https://api.github.com/repos/meteor/meteor/releases{/id}","deployments_url":"https://api.github.com/repos/meteor/meteor/deployments","created_at":"2012-01-19T01:58:17Z","updated_at":"2019-01-05T20:38:57Z","pushed_at":"2019-01-05T21:55:17Z","git_url":"git://github.com/meteor/meteor.git","ssh_url":"git@github.com:meteor/meteor.git","clone_url":"https://github.com/meteor/meteor.git","svn_url":"https://github.com/meteor/meteor","homepage":"https://www.meteor.com","size":77242,"stargazers_count":40675,"watchers_count":40675,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5028,"mirror_url":null,"archived":false,"open_issues_count":266,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5028,"open_issues":266,"watchers":40675,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/meteor/meteor/pulls/10248"},"html":{"href":"https://github.com/meteor/meteor/pull/10248"},"issue":{"href":"https://api.github.com/repos/meteor/meteor/issues/10248"},"comments":{"href":"https://api.github.com/repos/meteor/meteor/issues/10248/comments"},"review_comments":{"href":"https://api.github.com/repos/meteor/meteor/pulls/10248/comments"},"review_comment":{"href":"https://api.github.com/repos/meteor/meteor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/meteor/meteor/pulls/10248/commits"},"statuses":{"href":"https://api.github.com/repos/meteor/meteor/statuses/5d88d9a1a4e97c8097fba1ddbcac1027b394bbb3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"benjamn"}}