{"action":"created","issue":{"url":"https://api.github.com/repos/ipfs/go-mfs/issues/49","repository_url":"https://api.github.com/repos/ipfs/go-mfs","labels_url":"https://api.github.com/repos/ipfs/go-mfs/issues/49/labels{/name}","comments_url":"https://api.github.com/repos/ipfs/go-mfs/issues/49/comments","events_url":"https://api.github.com/repos/ipfs/go-mfs/issues/49/events","html_url":"https://github.com/ipfs/go-mfs/pull/49","id":394036061,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwODg0ODQ5","number":49,"title":"Fix/32/pr ports from go-ipfs to go-mfs","user":{"login":"nitishm","id":1494003,"node_id":"MDQ6VXNlcjE0OTQwMDM=","avatar_url":"https://avatars0.githubusercontent.com/u/1494003?v=4","gravatar_id":"","url":"https://api.github.com/users/nitishm","html_url":"https://github.com/nitishm","followers_url":"https://api.github.com/users/nitishm/followers","following_url":"https://api.github.com/users/nitishm/following{/other_user}","gists_url":"https://api.github.com/users/nitishm/gists{/gist_id}","starred_url":"https://api.github.com/users/nitishm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitishm/subscriptions","organizations_url":"https://api.github.com/users/nitishm/orgs","repos_url":"https://api.github.com/users/nitishm/repos","events_url":"https://api.github.com/users/nitishm/events{/privacy}","received_events_url":"https://api.github.com/users/nitishm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"nitishm","id":1494003,"node_id":"MDQ6VXNlcjE0OTQwMDM=","avatar_url":"https://avatars0.githubusercontent.com/u/1494003?v=4","gravatar_id":"","url":"https://api.github.com/users/nitishm","html_url":"https://github.com/nitishm","followers_url":"https://api.github.com/users/nitishm/followers","following_url":"https://api.github.com/users/nitishm/following{/other_user}","gists_url":"https://api.github.com/users/nitishm/gists{/gist_id}","starred_url":"https://api.github.com/users/nitishm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitishm/subscriptions","organizations_url":"https://api.github.com/users/nitishm/orgs","repos_url":"https://api.github.com/users/nitishm/repos","events_url":"https://api.github.com/users/nitishm/events{/privacy}","received_events_url":"https://api.github.com/users/nitishm/received_events","type":"User","site_admin":false},"assignees":[{"login":"nitishm","id":1494003,"node_id":"MDQ6VXNlcjE0OTQwMDM=","avatar_url":"https://avatars0.githubusercontent.com/u/1494003?v=4","gravatar_id":"","url":"https://api.github.com/users/nitishm","html_url":"https://github.com/nitishm","followers_url":"https://api.github.com/users/nitishm/followers","following_url":"https://api.github.com/users/nitishm/following{/other_user}","gists_url":"https://api.github.com/users/nitishm/gists{/gist_id}","starred_url":"https://api.github.com/users/nitishm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitishm/subscriptions","organizations_url":"https://api.github.com/users/nitishm/orgs","repos_url":"https://api.github.com/users/nitishm/repos","events_url":"https://api.github.com/users/nitishm/events{/privacy}","received_events_url":"https://api.github.com/users/nitishm/received_events","type":"User","site_admin":false}],"milestone":null,"comments":18,"created_at":"2018-12-25T16:32:44Z","updated_at":"2018-12-30T23:31:34Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ipfs/go-mfs/pulls/49","html_url":"https://github.com/ipfs/go-mfs/pull/49","diff_url":"https://github.com/ipfs/go-mfs/pull/49.diff","patch_url":"https://github.com/ipfs/go-mfs/pull/49.patch"},"body":"https://github.com/ipfs/go-mfs/issues/32 is partially completed by this PR.\r\n\r\nPersonally this doesn't seem like the best way to do things, by forcing `updateChildEntry` even on `stateFlushed` but currently that is the only way to unblock `waitPub` which is blocking in the `FlushPath` call.\r\n\r\nA better solution will be based on the completion of https://github.com/ipfs/go-mfs/pull/47 which should eliminate `waitPub`\r\n\r\nFixes https://github.com/ipfs/go-mfs/issues/50."},"comment":{"url":"https://api.github.com/repos/ipfs/go-mfs/issues/comments/450594182","html_url":"https://github.com/ipfs/go-mfs/pull/49#issuecomment-450594182","issue_url":"https://api.github.com/repos/ipfs/go-mfs/issues/49","id":450594182,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDU5NDE4Mg==","user":{"login":"nitishm","id":1494003,"node_id":"MDQ6VXNlcjE0OTQwMDM=","avatar_url":"https://avatars0.githubusercontent.com/u/1494003?v=4","gravatar_id":"","url":"https://api.github.com/users/nitishm","html_url":"https://github.com/nitishm","followers_url":"https://api.github.com/users/nitishm/followers","following_url":"https://api.github.com/users/nitishm/following{/other_user}","gists_url":"https://api.github.com/users/nitishm/gists{/gist_id}","starred_url":"https://api.github.com/users/nitishm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitishm/subscriptions","organizations_url":"https://api.github.com/users/nitishm/orgs","repos_url":"https://api.github.com/users/nitishm/repos","events_url":"https://api.github.com/users/nitishm/events{/privacy}","received_events_url":"https://api.github.com/users/nitishm/received_events","type":"User","site_admin":false},"created_at":"2018-12-30T23:31:34Z","updated_at":"2018-12-30T23:31:34Z","author_association":"NONE","body":"> @nitishm Not very important, but could you try rebasing this PR onto the current `master` when you get a chance, I think that will help with the review, commit `1bbc52d` has already been merged but it's still showing up in this PR (I guess because there are other commits after that not included here), getting everything in sync should clear the diff.\r\n\r\n@schomatis I did something. I don't know if I did the right thing, to do the rebase.\r\n\r\nDoes this sound right ? From nitishm/go-mfs repo I did - \r\n```\r\n1. git remote add go-mfs https://github.com/ipfs/go-mfs.git\r\n2. git fetch go-mfs\r\n3. git rebase go-mfs/master\r\n4. git pull\r\n5. git push\r\n```\r\n\r\nDoes that sound right ? I dont have too much experience with dealing with forks and keeping them up to date."}}
{"actor":{"display_login":"nitishm"}}