{"action":"created","issue":{"url":"https://api.github.com/repos/gabime/spdlog/issues/759","repository_url":"https://api.github.com/repos/gabime/spdlog","labels_url":"https://api.github.com/repos/gabime/spdlog/issues/759/labels{/name}","comments_url":"https://api.github.com/repos/gabime/spdlog/issues/759/comments","events_url":"https://api.github.com/repos/gabime/spdlog/issues/759/events","html_url":"https://github.com/gabime/spdlog/issues/759","id":342768817,"node_id":"MDU6SXNzdWUzNDI3Njg4MTc=","number":759,"title":"gcc 4.8.5 compilation failure","user":{"login":"rafiw","id":3034707,"node_id":"MDQ6VXNlcjMwMzQ3MDc=","avatar_url":"https://avatars3.githubusercontent.com/u/3034707?v=4","gravatar_id":"","url":"https://api.github.com/users/rafiw","html_url":"https://github.com/rafiw","followers_url":"https://api.github.com/users/rafiw/followers","following_url":"https://api.github.com/users/rafiw/following{/other_user}","gists_url":"https://api.github.com/users/rafiw/gists{/gist_id}","starred_url":"https://api.github.com/users/rafiw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafiw/subscriptions","organizations_url":"https://api.github.com/users/rafiw/orgs","repos_url":"https://api.github.com/users/rafiw/repos","events_url":"https://api.github.com/users/rafiw/events{/privacy}","received_events_url":"https://api.github.com/users/rafiw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-19T15:04:08Z","updated_at":"2018-07-22T19:37:41Z","closed_at":null,"author_association":"NONE","body":"```\r\n\r\nIn file included from ../../../src/utils/logger/spdlog/details/../details/../details/async_logger_impl.h:12:0,\r\n                 from ../../../src/utils/logger/spdlog/details/../details/../async_logger.h:72,\r\n                 from ../../../src/utils/logger/spdlog/details/../details/registry.h:13,\r\n                 from ../../../src/utils/logger/spdlog/details/spdlog_impl.h:11,\r\n                 from ../../../src/utils/logger/spdlog/spdlog.h:204,\r\n                 from ../../../src/utils/logger/logger_wrapper.h:17,\r\n                 from XXXXX:16:\r\n../../../src/utils/logger/spdlog/details/../details/../details/../details/async_log_helper.h: In instantiation of ‘bool spdlog::details::mpmc_bounded_queue<T>::dequeue_for(T&, std::chrono::milliseconds) [with T = spdlog::details::async_log_helper::async_msg; std::chrono::milliseconds = std::chrono::duration<long int, std::ratio<1l, 1000l> >]’:\r\n../../../src/utils/logger/spdlog/details/../details/../details/../details/async_log_helper.h:256:79:   required from here\r\n../../../src/utils/logger/spdlog/details/../details/../details/../details/async_log_helper.h:46:12: error: unused parameter ‘other’ [-Werror=unused-parameter]\r\n     struct async_msg\r\n            ^\r\nIn file included from ../../../src/utils/logger/spdlog/details/../details/../details/../details/async_log_helper.h:17:0,\r\n                 from ../../../src/utils/logger/spdlog/details/../details/../details/async_logger_impl.h:12,\r\n                 from ../../../src/utils/logger/spdlog/details/../details/../async_logger.h:72,\r\n                 from ../../../src/utils/logger/spdlog/details/../details/registry.h:13,\r\n                 from ../../../src/utils/logger/spdlog/details/spdlog_impl.h:11,\r\n                 from ../../../src/utils/logger/spdlog/spdlog.h:204,\r\n                 from ../../../src/utils/logger/logger_wrapper.h:17,\r\n                 from XXXX.cpp:16:\r\n../../../src/utils/logger/spdlog/details/../details/../details/../details/../details/mpmc_blocking_q.h:68:25: note: synthesized method ‘spdlog::details::async_log_helper::async_msg& spdlog::details::async_log_helper::async_msg::operator=(spdlog::details::async_log_helper::async_msg&&)’ first required here\r\n             popped_item = std::move(q_.front());\r\n                         ^\r\nIn file included from ../../../src/utils/logger/spdlog/details/../details/../details/async_logger_impl.h:12:0,\r\n                 from ../../../src/utils/logger/spdlog/details/../details/../async_logger.h:72,\r\n                 from ../../../src/utils/logger/spdlog/details/../details/registry.h:13,\r\n                 from ../../../src/utils/logger/spdlog/details/spdlog_impl.h:11,\r\n                 from ../../../src/utils/logger/spdlog/spdlog.h:204,\r\n                 from ../../../src/utils/logger/logger_wrapper.h:17,\r\n                 from XXXXX.cpp:16:\r\n../../../src/utils/logger/spdlog/details/../details/../details/../details/async_log_helper.h: In instantiation of ‘void __gnu_cxx::new_allocator<_Tp>::construct(_Up*, _Args&& ...) [with _Up = spdlog::details::async_log_helper::async_msg; _Args = {spdlog::details::async_log_helper::async_msg}; _Tp = spdlog::details::async_log_helper::async_msg]’:\r\n/usr/include/c++/4.8.2/bits/deque.tcc:137:6:   required from ‘void std::deque<_Tp, _Alloc>::emplace_back(_Args&& ...) [with _Args = {spdlog::details::async_log_helper::async_msg}; _Tp = spdlog::details::async_log_helper::async_msg; _Alloc = std::allocator<spdlog::details::async_log_helper::async_msg>]’\r\n/usr/include/c++/4.8.2/bits/stl_deque.h:1405:36:   required from ‘void std::deque<_Tp, _Alloc>::push_back(std::deque<_Tp, _Alloc>::value_type&&) [with _Tp = spdlog::details::async_log_helper::async_msg; _Alloc = std::allocator<spdlog::details::async_log_helper::async_msg>; std::deque<_Tp, _Alloc>::value_type = spdlog::details::async_log_helper::async_msg]’\r\n/usr/include/c++/4.8.2/bits/stl_queue.h:218:9:   required from ‘void std::queue<_Tp, _Sequence>::push(std::queue<_Tp, _Sequence>::value_type&&) [with _Tp = spdlog::details::async_log_helper::async_msg; _Sequence = std::deque<spdlog::details::async_log_helper::async_msg, std::allocator<spdlog::details::async_log_helper::async_msg> >; std::queue<_Tp, _Sequence>::value_type = spdlog::details::async_log_helper::async_msg]’\r\n../../../src/utils/logger/spdlog/details/../details/../details/../details/../details/mpmc_blocking_q.h:37:13:   required from ‘void spdlog::details::mpmc_bounded_queue<T>::enqueue(T&&) [with T = spdlog::details::async_log_helper::async_msg]’\r\n../../../src/utils/logger/spdlog/details/../details/../details/../details/async_log_helper.h:216:38:   required from here\r\n../../../src/utils/logger/spdlog/details/../details/../details/../details/async_log_helper.h:66:9: error: unused parameter ‘other’ [-Werror=unused-parameter]\r\n         async_msg(async_msg &&other) = default;\r\n         ^\r\nIn file included from /usr/include/c++/4.8.2/x86_64-redhat-linux/bits/c++allocator.h:33:0,\r\n                 from /usr/include/c++/4.8.2/bits/allocator.h:46,\r\n                 from /usr/include/c++/4.8.2/vector:61,\r\n                 from XXXXX.cpp:16:\r\n/usr/include/c++/4.8.2/ext/new_allocator.h:120:4: note: synthesized method ‘spdlog::details::async_log_helper::async_msg::async_msg(spdlog::details::async_log_helper::async_msg&&)’ first required here\r\n  { ::new((void *)__p) _Up(std::forward<_Args>(__args)...); }\r\n    ^\r\n\r\n```\r\n\r\ni know it's a compiler issue since it compiles well with clang.\r\n"},"comment":{"url":"https://api.github.com/repos/gabime/spdlog/issues/comments/406891109","html_url":"https://github.com/gabime/spdlog/issues/759#issuecomment-406891109","issue_url":"https://api.github.com/repos/gabime/spdlog/issues/759","id":406891109,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjg5MTEwOQ==","user":{"login":"rafiw","id":3034707,"node_id":"MDQ6VXNlcjMwMzQ3MDc=","avatar_url":"https://avatars3.githubusercontent.com/u/3034707?v=4","gravatar_id":"","url":"https://api.github.com/users/rafiw","html_url":"https://github.com/rafiw","followers_url":"https://api.github.com/users/rafiw/followers","following_url":"https://api.github.com/users/rafiw/following{/other_user}","gists_url":"https://api.github.com/users/rafiw/gists{/gist_id}","starred_url":"https://api.github.com/users/rafiw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafiw/subscriptions","organizations_url":"https://api.github.com/users/rafiw/orgs","repos_url":"https://api.github.com/users/rafiw/repos","events_url":"https://api.github.com/users/rafiw/events{/privacy}","received_events_url":"https://api.github.com/users/rafiw/received_events","type":"User","site_admin":false},"created_at":"2018-07-22T19:37:41Z","updated_at":"2018-07-22T19:37:41Z","author_association":"NONE","body":"still get an error\r\n`[  9%] Building CXX object tests/CMakeFiles/spdlog-utests.dir/errors.cpp.o\r\nIn file included from /git/spdlog/include/spdlog/async.h:21:0,\r\n                 from /git/spdlog/tests/includes.h:15,\r\n                 from /git/spdlog/tests/errors.cpp:4:\r\n/git/spdlog/include/spdlog/details/registry.h: In instantiation of ‘static spdlog::details::registry_t<Mutex>& spdlog::details::registry_t<Mutex>::instance() [with Mutex = std::mutex]’:\r\n/git/spdlog/include/spdlog/async.h:79:15:   required from here\r\n/git/spdlog/include/spdlog/details/registry.h:172:5: error: converting to ‘std::unique_ptr<spdlog::formatter>’ from initializer list would use explicit constructor ‘std::unique_ptr<_Tp, _Dp>::unique_ptr(std::unique_ptr<_Tp, _Dp>::pointer) [with _Tp = spdlog::formatter; _Dp = std::default_delete<spdlog::formatter>; std::unique_ptr<_Tp, _Dp>::pointer = spdlog::formatter*]’\r\n     registry_t<Mutex>() = default;\r\n     ^\r\n/git/spdlog/include/spdlog/details/registry.h:167:34: note: synthesized method ‘spdlog::details::registry_t<Mutex>::registry_t() [with Mutex = std::mutex]’ first required here\r\n         static registry_t<Mutex> s_instance;\r\n                                  ^\r\nmake[2]: *** [tests/CMakeFiles/spdlog-utests.dir/errors.cpp.o] Error 1\r\nmake[1]: *** [tests/CMakeFiles/spdlog-utests.dir/all] Error 2\r\nmake: *** [all] Error 2\r\n`"}}
{"actor":{"display_login":"rafiw"}}