{"action":"created","issue":{"url":"https://api.github.com/repos/progit/progit2/issues/1042","repository_url":"https://api.github.com/repos/progit/progit2","labels_url":"https://api.github.com/repos/progit/progit2/issues/1042/labels{/name}","comments_url":"https://api.github.com/repos/progit/progit2/issues/1042/comments","events_url":"https://api.github.com/repos/progit/progit2/issues/1042/events","html_url":"https://github.com/progit/progit2/issues/1042","id":317235778,"number":1042,"title":"2f6b50d146016205047834165a81810d7849efce removed contributors","user":{"login":"sampablokuper","id":85394,"avatar_url":"https://avatars3.githubusercontent.com/u/85394?v=4","gravatar_id":"","url":"https://api.github.com/users/sampablokuper","html_url":"https://github.com/sampablokuper","followers_url":"https://api.github.com/users/sampablokuper/followers","following_url":"https://api.github.com/users/sampablokuper/following{/other_user}","gists_url":"https://api.github.com/users/sampablokuper/gists{/gist_id}","starred_url":"https://api.github.com/users/sampablokuper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sampablokuper/subscriptions","organizations_url":"https://api.github.com/users/sampablokuper/orgs","repos_url":"https://api.github.com/users/sampablokuper/repos","events_url":"https://api.github.com/users/sampablokuper/events{/privacy}","received_events_url":"https://api.github.com/users/sampablokuper/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-24T13:49:43Z","updated_at":"2018-04-24T18:10:49Z","closed_at":null,"author_association":"NONE","body":"@schacon created this repository, https://github.com/progit/progit2, as a separate one from https://github.com/progit/progit (i.e. *manually copied* the contents across, which is a Git antipattern IMO).\r\n\r\nAs such, people who contributed to https://github.com/progit/progit, and whose contributions were *manually copied* to https://github.com/progit/progit2 as part of the latter's initial commit, do not necessarily show up in `git shortlog` when it is run on this repository. It was presumably for this reason that @schacon credited them manually by adding `book/contributors.asc` in 7270a692ab7ef88db5a3d7955bfe12d4e5f95250. (I expect that file was generated by running `git shortlog` on https://github.com/progit/progit .)\r\n\r\nHowever, 2f6b50d146016205047834165a81810d7849efce deleted `book/contributors.asc`, thus erasing that credit from subsequent versions of _Pro Git 2_ (aside from people who were also present in the _Pro Git 2_ shortlog).\r\n\r\nI see at least three possible ways to fix this:\r\n\r\n1. Restore `book/contributors.asc` and add a (post-receive?) hook to expand it each time a new contributor's commit is merged.\r\n1. Restore `book/contributors.asc` and merge its contents with the `git shortlog` output automatically during the build process.\r\n1. Instead of populating the contributors section of the book by running `git shortlog` solely on https://github.com/progit/progit2, the build process should also run it on https://github.com/progit/progit and merge the output from the two invocations."},"comment":{"url":"https://api.github.com/repos/progit/progit2/issues/comments/384028429","html_url":"https://github.com/progit/progit2/issues/1042#issuecomment-384028429","issue_url":"https://api.github.com/repos/progit/progit2/issues/1042","id":384028429,"user":{"login":"ben","id":39902,"avatar_url":"https://avatars3.githubusercontent.com/u/39902?v=4","gravatar_id":"","url":"https://api.github.com/users/ben","html_url":"https://github.com/ben","followers_url":"https://api.github.com/users/ben/followers","following_url":"https://api.github.com/users/ben/following{/other_user}","gists_url":"https://api.github.com/users/ben/gists{/gist_id}","starred_url":"https://api.github.com/users/ben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ben/subscriptions","organizations_url":"https://api.github.com/users/ben/orgs","repos_url":"https://api.github.com/users/ben/repos","events_url":"https://api.github.com/users/ben/events{/privacy}","received_events_url":"https://api.github.com/users/ben/received_events","type":"User","site_admin":false},"created_at":"2018-04-24T18:10:49Z","updated_at":"2018-04-24T18:10:49Z","author_association":"CONTRIBUTOR","body":"I want to pop in to clarify a bit of history. I agree that it's an anti-pattern to take a snapshot of one git repo and use that as the initial commit of a separate repo, but it was done for good reasons.\r\n\r\nThe people who contributed to the 1st edition never licensed their changes to Scott for the purposes of making a print edition. When the time came to start working on 2e (with the intent of selling a dead-tree version), we couldn't in good conscience use all of their work without permission, so we had to start from a snapshot where Scott owned all of the IP. We still wanted to thank them in the print edition, and that's how `contributors.asc` came to be.\r\n\r\nAnd yes, when the contributors list became generated at build time, we lost the list of contributors to the 1st edition. However, at this point the second edition consists of original work by myself and Scott, and work by the authors that appear in the shortlog of this repo. So that change seemed like a move to a more accurate representation at the time.\r\n\r\nI'd accept a PR that includes both lists, whether merged together or separate. I'm still grateful to the people who helped out with 1e, and it'd be nice to give them credit in 2e."}}
{"actor":{"display_login":"ben"}}