{"action":"created","issue":{"url":"https://api.github.com/repos/loic-sharma/BaGet/issues/114","repository_url":"https://api.github.com/repos/loic-sharma/BaGet","labels_url":"https://api.github.com/repos/loic-sharma/BaGet/issues/114/labels{/name}","comments_url":"https://api.github.com/repos/loic-sharma/BaGet/issues/114/comments","events_url":"https://api.github.com/repos/loic-sharma/BaGet/issues/114/events","html_url":"https://github.com/loic-sharma/BaGet/pull/114","id":376888950,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3OTk3OTU4","number":114,"title":"Add configuration option for application root URL","user":{"login":"daniel-lerch","id":36048059,"node_id":"MDQ6VXNlcjM2MDQ4MDU5","avatar_url":"https://avatars0.githubusercontent.com/u/36048059?v=4","gravatar_id":"","url":"https://api.github.com/users/daniel-lerch","html_url":"https://github.com/daniel-lerch","followers_url":"https://api.github.com/users/daniel-lerch/followers","following_url":"https://api.github.com/users/daniel-lerch/following{/other_user}","gists_url":"https://api.github.com/users/daniel-lerch/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-lerch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-lerch/subscriptions","organizations_url":"https://api.github.com/users/daniel-lerch/orgs","repos_url":"https://api.github.com/users/daniel-lerch/repos","events_url":"https://api.github.com/users/daniel-lerch/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-lerch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-11-02T16:50:54Z","updated_at":"2018-11-10T05:19:11Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/loic-sharma/BaGet/pulls/114","html_url":"https://github.com/loic-sharma/BaGet/pull/114","diff_url":"https://github.com/loic-sharma/BaGet/pull/114.diff","patch_url":"https://github.com/loic-sharma/BaGet/pull/114.patch"},"body":"<!--\r\nPLEASE READ THIS MESSAGE.\r\n\r\nHOW TO WRITE A GOOD PULL REQUEST?\r\n\r\n- Read the contributing guide: https://github.com/loic-sharma/BaGet/blob/master/CONTRIBUTING.md.\r\n- Make it small.\r\n- Do only one thing.\r\n- Avoid re-formatting.\r\n- Make sure the code builds.\r\n- Add tests.\r\n- Write useful descriptions and titles.\r\n- Address review comments in terms of additional commits.\r\n- Once approved, please squash your commits to avoid polluting the commit history.\r\n-->\r\n\r\n### What does this PR do?\r\n\r\n<!-- A brief description of the change being made with this pull request. -->\r\nThis pull request adds the setting `PathBase` to the BaGet configuration and applies this setting on startup. The `PathBase` option allows an ASP.NET Core application to run under a different root URL than it was designed for.\r\n\r\n### Motivation\r\n\r\n<!-- What inspired you to submit this pull request? -->\r\nI want to operate a BaGet server with a URL like https://example.com/baget and reach the API index at https://example.com/baget/v3/index.json. With this change I don't have to write complex rewrite rules for this scenario which might not work at all.\r\n\r\n### Additional Notes\r\n\r\n<!-- Anything else we should know when reviewing? -->\r\n[Deal with path base and proxies that change the request path](https://docs.microsoft.com/en-us/aspnet/core/host-and-deploy/proxy-load-balancer?view=aspnetcore-2.1#deal-with-path-base-and-proxies-that-change-the-request-path) on Microsoft Docs"},"comment":{"url":"https://api.github.com/repos/loic-sharma/BaGet/issues/comments/437559438","html_url":"https://github.com/loic-sharma/BaGet/pull/114#issuecomment-437559438","issue_url":"https://api.github.com/repos/loic-sharma/BaGet/issues/114","id":437559438,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzU1OTQzOA==","user":{"login":"loic-sharma","id":737941,"node_id":"MDQ6VXNlcjczNzk0MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/737941?v=4","gravatar_id":"","url":"https://api.github.com/users/loic-sharma","html_url":"https://github.com/loic-sharma","followers_url":"https://api.github.com/users/loic-sharma/followers","following_url":"https://api.github.com/users/loic-sharma/following{/other_user}","gists_url":"https://api.github.com/users/loic-sharma/gists{/gist_id}","starred_url":"https://api.github.com/users/loic-sharma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loic-sharma/subscriptions","organizations_url":"https://api.github.com/users/loic-sharma/orgs","repos_url":"https://api.github.com/users/loic-sharma/repos","events_url":"https://api.github.com/users/loic-sharma/events{/privacy}","received_events_url":"https://api.github.com/users/loic-sharma/received_events","type":"User","site_admin":false},"created_at":"2018-11-10T05:19:11Z","updated_at":"2018-11-10T05:19:11Z","author_association":"OWNER","body":"Your changes look good. I moved some things around after you opened this pull request - would you mind applying your changes on the latest master? I'll go ahead and merge after :)"}}
{"actor":{"display_login":"loic-sharma"}}