{"action":"created","issue":{"url":"https://api.github.com/repos/minio/minio/issues/5560","repository_url":"https://api.github.com/repos/minio/minio","labels_url":"https://api.github.com/repos/minio/minio/issues/5560/labels{/name}","comments_url":"https://api.github.com/repos/minio/minio/issues/5560/comments","events_url":"https://api.github.com/repos/minio/minio/issues/5560/events","html_url":"https://github.com/minio/minio/pull/5560","id":298733082,"number":5560,"title":"For MakeBucket error should be quorum based on multiple sets","user":{"login":"harshavardhana","id":622699,"avatar_url":"https://avatars0.githubusercontent.com/u/622699?v=4","gravatar_id":"","url":"https://api.github.com/users/harshavardhana","html_url":"https://github.com/harshavardhana","followers_url":"https://api.github.com/users/harshavardhana/followers","following_url":"https://api.github.com/users/harshavardhana/following{/other_user}","gists_url":"https://api.github.com/users/harshavardhana/gists{/gist_id}","starred_url":"https://api.github.com/users/harshavardhana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshavardhana/subscriptions","organizations_url":"https://api.github.com/users/harshavardhana/orgs","repos_url":"https://api.github.com/users/harshavardhana/repos","events_url":"https://api.github.com/users/harshavardhana/events{/privacy}","received_events_url":"https://api.github.com/users/harshavardhana/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-20T20:14:45Z","updated_at":"2018-02-21T09:13:43Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/minio/minio/pulls/5560","html_url":"https://github.com/minio/minio/pull/5560","diff_url":"https://github.com/minio/minio/pull/5560.diff","patch_url":"https://github.com/minio/minio/pull/5560.patch"},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\nFor MakeBucket error should be quorum based on multiple sets\r\n<!--- Describe your changes in detail -->\r\n\r\n## Motivation and Context\r\nFixes #5533\r\n\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\n\r\n## How Has This Been Tested?\r\nManually\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [ ] I have added unit tests to cover my changes.\r\n- [ ] I have added/updated functional tests in [mint](https://github.com/minio/mint). (If yes, add `mint` PR # here: )\r\n- [x] All new and existing tests passed."},"comment":{"url":"https://api.github.com/repos/minio/minio/issues/comments/367259988","html_url":"https://github.com/minio/minio/pull/5560#issuecomment-367259988","issue_url":"https://api.github.com/repos/minio/minio/issues/5560","id":367259988,"user":{"login":"codecov[bot]","id":22429695,"avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-02-21T09:13:43Z","updated_at":"2018-02-21T09:13:43Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/minio/minio/pull/5560?src=pr&el=h1) Report\n> Merging [#5560](https://codecov.io/gh/minio/minio/pull/5560?src=pr&el=desc) into [master](https://codecov.io/gh/minio/minio/commit/a00e052606b7646fece9935e239728508d44c0f9?src=pr&el=desc) will **increase** coverage by `1.17%`.\n> The diff coverage is `50%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/minio/minio/pull/5560/graphs/tree.svg?height=150&width=650&src=pr&token=4wG3Jysopw)](https://codecov.io/gh/minio/minio/pull/5560?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master    #5560      +/-   ##\n==========================================\n+ Coverage    63.5%   64.68%   +1.17%     \n==========================================\n  Files         195      195              \n  Lines       28237    28899     +662     \n==========================================\n+ Hits        17931    18692     +761     \n+ Misses       8886     8789      -97     \n+ Partials     1420     1418       -2\n```\n\n\n| [Impacted Files](https://codecov.io/gh/minio/minio/pull/5560?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [cmd/xl-sets.go](https://codecov.io/gh/minio/minio/pull/5560/diff?src=pr&el=tree#diff-Y21kL3hsLXNldHMuZ28=) | `63.83% <50%> (+6.72%)` | :arrow_up: |\n| [cmd/object-handlers.go](https://codecov.io/gh/minio/minio/pull/5560/diff?src=pr&el=tree#diff-Y21kL29iamVjdC1oYW5kbGVycy5nbw==) | `82.05% <0%> (+2.17%)` | :arrow_up: |\n| [cmd/fs-v1.go](https://codecov.io/gh/minio/minio/pull/5560/diff?src=pr&el=tree#diff-Y21kL2ZzLXYxLmdv) | `80.17% <0%> (+7.02%)` | :arrow_up: |\n| [cmd/xl-v1-object.go](https://codecov.io/gh/minio/minio/pull/5560/diff?src=pr&el=tree#diff-Y21kL3hsLXYxLW9iamVjdC5nbw==) | `88.31% <0%> (+7.37%)` | :arrow_up: |\n| [cmd/xl-v1-multipart.go](https://codecov.io/gh/minio/minio/pull/5560/diff?src=pr&el=tree#diff-Y21kL3hsLXYxLW11bHRpcGFydC5nbw==) | `78.67% <0%> (+7.57%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/minio/minio/pull/5560?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/minio/minio/pull/5560?src=pr&el=footer). Last update [a00e052...dff1257](https://codecov.io/gh/minio/minio/pull/5560?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}