{"action":"created","issue":{"url":"https://api.github.com/repos/LimaInc/SustainableCraft/issues/22","repository_url":"https://api.github.com/repos/LimaInc/SustainableCraft","labels_url":"https://api.github.com/repos/LimaInc/SustainableCraft/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/LimaInc/SustainableCraft/issues/22/comments","events_url":"https://api.github.com/repos/LimaInc/SustainableCraft/issues/22/events","html_url":"https://github.com/LimaInc/SustainableCraft/issues/22","id":293510612,"number":22,"title":"[DISCUSSION] Block type","user":{"login":"JamesHinshelwood","id":11905377,"avatar_url":"https://avatars0.githubusercontent.com/u/11905377?v=4","gravatar_id":"","url":"https://api.github.com/users/JamesHinshelwood","html_url":"https://github.com/JamesHinshelwood","followers_url":"https://api.github.com/users/JamesHinshelwood/followers","following_url":"https://api.github.com/users/JamesHinshelwood/following{/other_user}","gists_url":"https://api.github.com/users/JamesHinshelwood/gists{/gist_id}","starred_url":"https://api.github.com/users/JamesHinshelwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JamesHinshelwood/subscriptions","organizations_url":"https://api.github.com/users/JamesHinshelwood/orgs","repos_url":"https://api.github.com/users/JamesHinshelwood/repos","events_url":"https://api.github.com/users/JamesHinshelwood/events{/privacy}","received_events_url":"https://api.github.com/users/JamesHinshelwood/received_events","type":"User","site_admin":false},"labels":[{"id":821516723,"url":"https://api.github.com/repos/LimaInc/SustainableCraft/labels/help%20wanted","name":"help wanted","color":"008672","default":true}],"state":"open","locked":false,"assignee":{"login":"DazKins","id":3652981,"avatar_url":"https://avatars1.githubusercontent.com/u/3652981?v=4","gravatar_id":"","url":"https://api.github.com/users/DazKins","html_url":"https://github.com/DazKins","followers_url":"https://api.github.com/users/DazKins/followers","following_url":"https://api.github.com/users/DazKins/following{/other_user}","gists_url":"https://api.github.com/users/DazKins/gists{/gist_id}","starred_url":"https://api.github.com/users/DazKins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DazKins/subscriptions","organizations_url":"https://api.github.com/users/DazKins/orgs","repos_url":"https://api.github.com/users/DazKins/repos","events_url":"https://api.github.com/users/DazKins/events{/privacy}","received_events_url":"https://api.github.com/users/DazKins/received_events","type":"User","site_admin":false},"assignees":[{"login":"DazKins","id":3652981,"avatar_url":"https://avatars1.githubusercontent.com/u/3652981?v=4","gravatar_id":"","url":"https://api.github.com/users/DazKins","html_url":"https://github.com/DazKins","followers_url":"https://api.github.com/users/DazKins/followers","following_url":"https://api.github.com/users/DazKins/following{/other_user}","gists_url":"https://api.github.com/users/DazKins/gists{/gist_id}","starred_url":"https://api.github.com/users/DazKins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DazKins/subscriptions","organizations_url":"https://api.github.com/users/DazKins/orgs","repos_url":"https://api.github.com/users/DazKins/repos","events_url":"https://api.github.com/users/DazKins/events{/privacy}","received_events_url":"https://api.github.com/users/DazKins/received_events","type":"User","site_admin":false},{"login":"JamesHinshelwood","id":11905377,"avatar_url":"https://avatars0.githubusercontent.com/u/11905377?v=4","gravatar_id":"","url":"https://api.github.com/users/JamesHinshelwood","html_url":"https://github.com/JamesHinshelwood","followers_url":"https://api.github.com/users/JamesHinshelwood/followers","following_url":"https://api.github.com/users/JamesHinshelwood/following{/other_user}","gists_url":"https://api.github.com/users/JamesHinshelwood/gists{/gist_id}","starred_url":"https://api.github.com/users/JamesHinshelwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JamesHinshelwood/subscriptions","organizations_url":"https://api.github.com/users/JamesHinshelwood/orgs","repos_url":"https://api.github.com/users/JamesHinshelwood/repos","events_url":"https://api.github.com/users/JamesHinshelwood/events{/privacy}","received_events_url":"https://api.github.com/users/JamesHinshelwood/received_events","type":"User","site_admin":false},{"login":"Acalc79","id":17096872,"avatar_url":"https://avatars3.githubusercontent.com/u/17096872?v=4","gravatar_id":"","url":"https://api.github.com/users/Acalc79","html_url":"https://github.com/Acalc79","followers_url":"https://api.github.com/users/Acalc79/followers","following_url":"https://api.github.com/users/Acalc79/following{/other_user}","gists_url":"https://api.github.com/users/Acalc79/gists{/gist_id}","starred_url":"https://api.github.com/users/Acalc79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Acalc79/subscriptions","organizations_url":"https://api.github.com/users/Acalc79/orgs","repos_url":"https://api.github.com/users/Acalc79/repos","events_url":"https://api.github.com/users/Acalc79/events{/privacy}","received_events_url":"https://api.github.com/users/Acalc79/received_events","type":"User","site_admin":false},{"login":"JoeMcGuchan","id":23016606,"avatar_url":"https://avatars0.githubusercontent.com/u/23016606?v=4","gravatar_id":"","url":"https://api.github.com/users/JoeMcGuchan","html_url":"https://github.com/JoeMcGuchan","followers_url":"https://api.github.com/users/JoeMcGuchan/followers","following_url":"https://api.github.com/users/JoeMcGuchan/following{/other_user}","gists_url":"https://api.github.com/users/JoeMcGuchan/gists{/gist_id}","starred_url":"https://api.github.com/users/JoeMcGuchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoeMcGuchan/subscriptions","organizations_url":"https://api.github.com/users/JoeMcGuchan/orgs","repos_url":"https://api.github.com/users/JoeMcGuchan/repos","events_url":"https://api.github.com/users/JoeMcGuchan/events{/privacy}","received_events_url":"https://api.github.com/users/JoeMcGuchan/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-02-01T12:21:45Z","updated_at":"2018-02-01T12:35:18Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Struggling to think about how to implement a neat method of having an abstract block type or if it is even needed.\r\n\r\nAt the moment, we just use an array of bytes, which is obviously bad. We should have an array of Block objects maybe?, and we can inherit different types of block from Block, eg. class Grass : Block. However, don't we want Blocks to be a struct, since they should be a value type? Or shouldn't they? C# lets you define structs which implement interfaces meaning we could do struct Grass : IBlock, but here boxing occurs (they turn into reference types basically), so we lose the point of having structs anyway??? \r\n\r\nAm I too fixated on the idea that Blocks should be a value type. Should they just be objects, and Chunk stores an array of references (bad cache locality)? Maybe they should be objects, so each block can define its own behaviour??\r\n\r\n@DazKins @Acalc79 @JoeMcGuchan \r\nhelp me"},"comment":{"url":"https://api.github.com/repos/LimaInc/SustainableCraft/issues/comments/362253004","html_url":"https://github.com/LimaInc/SustainableCraft/issues/22#issuecomment-362253004","issue_url":"https://api.github.com/repos/LimaInc/SustainableCraft/issues/22","id":362253004,"user":{"login":"Acalc79","id":17096872,"avatar_url":"https://avatars3.githubusercontent.com/u/17096872?v=4","gravatar_id":"","url":"https://api.github.com/users/Acalc79","html_url":"https://github.com/Acalc79","followers_url":"https://api.github.com/users/Acalc79/followers","following_url":"https://api.github.com/users/Acalc79/following{/other_user}","gists_url":"https://api.github.com/users/Acalc79/gists{/gist_id}","starred_url":"https://api.github.com/users/Acalc79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Acalc79/subscriptions","organizations_url":"https://api.github.com/users/Acalc79/orgs","repos_url":"https://api.github.com/users/Acalc79/repos","events_url":"https://api.github.com/users/Acalc79/events{/privacy}","received_events_url":"https://api.github.com/users/Acalc79/received_events","type":"User","site_admin":false},"created_at":"2018-02-01T12:35:18Z","updated_at":"2018-02-01T12:35:18Z","author_association":"NONE","body":"I'd just use an array of references and worry about cache locality and performance once it actually comes up as a bottleneck later. Keep in mind though that I have very little practical experience with those things."}}
{"actor":{"display_login":"Acalc79"}}