{"action":"opened","number":475,"pull_request":{"url":"https://api.github.com/repos/FluxNotes/flux/pulls/475","id":220441683,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNDQxNjgz","html_url":"https://github.com/FluxNotes/flux/pull/475","diff_url":"https://github.com/FluxNotes/flux/pull/475.diff","patch_url":"https://github.com/FluxNotes/flux/pull/475.patch","issue_url":"https://api.github.com/repos/FluxNotes/flux/issues/475","number":475,"state":"open","locked":false,"title":"Correctly resize line charts","user":{"login":"nicoleng12","id":26877672,"node_id":"MDQ6VXNlcjI2ODc3Njcy","avatar_url":"https://avatars2.githubusercontent.com/u/26877672?v=4","gravatar_id":"","url":"https://api.github.com/users/nicoleng12","html_url":"https://github.com/nicoleng12","followers_url":"https://api.github.com/users/nicoleng12/followers","following_url":"https://api.github.com/users/nicoleng12/following{/other_user}","gists_url":"https://api.github.com/users/nicoleng12/gists{/gist_id}","starred_url":"https://api.github.com/users/nicoleng12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicoleng12/subscriptions","organizations_url":"https://api.github.com/users/nicoleng12/orgs","repos_url":"https://api.github.com/users/nicoleng12/repos","events_url":"https://api.github.com/users/nicoleng12/events{/privacy}","received_events_url":"https://api.github.com/users/nicoleng12/received_events","type":"User","site_admin":false},"body":"This PR addresses issue 877.\r\n\r\nAdded responsive container around line chart to handle resizing correctly. Implemented same fix that was used to fix the resizing issue for the progression line chart.\r\n\r\n_Pull requests into Flux require the following. Submitter and reviewer should :white_check_mark: when done. For items that are not-applicable, note it's not-applicable (**N/A**) and :white_check_mark:._\r\n\r\n\r\n## Submitter:\r\n\r\n**Running the Application**\r\n\r\n- [x] Manually tested in Chrome\r\n- [x] Manually tested in IE\r\n\r\n**Documentation**\r\n\r\n- [x] This pull request describes why these changes were made\r\n- [x] Recognizes any potential shortcomings/bugs in the description \r\n- N/A Cheat sheet is updated\r\n- N/A Demo script is updated \r\n- N/A Documentation on Wiki has been updated \r\n- N/A Additional technical components and libraries are documented and added to wiki as needed\r\n\r\n**NoteParser**\r\n\r\n- N/A Note parser has been updated if structured phrases change\r\n\r\n**Code Quality**\r\n\r\n- [x] 4-space indents - convert any tabs to spaces\r\n- [x] Use public class field syntax for binding functions - ex. handleChange = () => { ... };\r\n- [x] Code is commented\r\n\r\n**Tests**\r\n\r\n- [x] Existing tests passed\r\n- N/A Added Enzyme-UI tests for slim mode \r\n- N/A Added Enzyme-UI tests for full mode\r\n- N/A Added backend tests for new functionality added\r\n- N/A Added note parser examples to test new functionality\r\n\r\n\r\n## Reviewer 1: Name\r\n\r\n- [ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose\r\n- [ ] The tests appropriately test the new code, including edge cases\r\n- [ ] You have tried to break the code\r\n\r\n\r\n## Reviewer 2: Name\r\n\r\n- [ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose\r\n- [ ] The tests appropriately test the new code, including edge cases\r\n- [ ] You have tried to break the code\r\n","created_at":"2018-10-04T16:31:03Z","updated_at":"2018-10-04T16:31:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FluxNotes/flux/pulls/475/commits","review_comments_url":"https://api.github.com/repos/FluxNotes/flux/pulls/475/comments","review_comment_url":"https://api.github.com/repos/FluxNotes/flux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FluxNotes/flux/issues/475/comments","statuses_url":"https://api.github.com/repos/FluxNotes/flux/statuses/00f4c7007b96d725a6b75b8f0d5b52f65ee97039","head":{"label":"FluxNotes:resize-line-charts-correctly","ref":"resize-line-charts-correctly","sha":"00f4c7007b96d725a6b75b8f0d5b52f65ee97039","user":{"login":"FluxNotes","id":37755753,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzU1NzUz","avatar_url":"https://avatars0.githubusercontent.com/u/37755753?v=4","gravatar_id":"","url":"https://api.github.com/users/FluxNotes","html_url":"https://github.com/FluxNotes","followers_url":"https://api.github.com/users/FluxNotes/followers","following_url":"https://api.github.com/users/FluxNotes/following{/other_user}","gists_url":"https://api.github.com/users/FluxNotes/gists{/gist_id}","starred_url":"https://api.github.com/users/FluxNotes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FluxNotes/subscriptions","organizations_url":"https://api.github.com/users/FluxNotes/orgs","repos_url":"https://api.github.com/users/FluxNotes/repos","events_url":"https://api.github.com/users/FluxNotes/events{/privacy}","received_events_url":"https://api.github.com/users/FluxNotes/received_events","type":"Organization","site_admin":false},"repo":{"id":90062848,"node_id":"MDEwOlJlcG9zaXRvcnk5MDA2Mjg0OA==","name":"flux","full_name":"FluxNotes/flux","private":false,"owner":{"login":"FluxNotes","id":37755753,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzU1NzUz","avatar_url":"https://avatars0.githubusercontent.com/u/37755753?v=4","gravatar_id":"","url":"https://api.github.com/users/FluxNotes","html_url":"https://github.com/FluxNotes","followers_url":"https://api.github.com/users/FluxNotes/followers","following_url":"https://api.github.com/users/FluxNotes/following{/other_user}","gists_url":"https://api.github.com/users/FluxNotes/gists{/gist_id}","starred_url":"https://api.github.com/users/FluxNotes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FluxNotes/subscriptions","organizations_url":"https://api.github.com/users/FluxNotes/orgs","repos_url":"https://api.github.com/users/FluxNotes/repos","events_url":"https://api.github.com/users/FluxNotes/events{/privacy}","received_events_url":"https://api.github.com/users/FluxNotes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/FluxNotes/flux","description":"Flux: Data Capture Prototype for Clinical Oncology ","fork":false,"url":"https://api.github.com/repos/FluxNotes/flux","forks_url":"https://api.github.com/repos/FluxNotes/flux/forks","keys_url":"https://api.github.com/repos/FluxNotes/flux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FluxNotes/flux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FluxNotes/flux/teams","hooks_url":"https://api.github.com/repos/FluxNotes/flux/hooks","issue_events_url":"https://api.github.com/repos/FluxNotes/flux/issues/events{/number}","events_url":"https://api.github.com/repos/FluxNotes/flux/events","assignees_url":"https://api.github.com/repos/FluxNotes/flux/assignees{/user}","branches_url":"https://api.github.com/repos/FluxNotes/flux/branches{/branch}","tags_url":"https://api.github.com/repos/FluxNotes/flux/tags","blobs_url":"https://api.github.com/repos/FluxNotes/flux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FluxNotes/flux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FluxNotes/flux/git/refs{/sha}","trees_url":"https://api.github.com/repos/FluxNotes/flux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FluxNotes/flux/statuses/{sha}","languages_url":"https://api.github.com/repos/FluxNotes/flux/languages","stargazers_url":"https://api.github.com/repos/FluxNotes/flux/stargazers","contributors_url":"https://api.github.com/repos/FluxNotes/flux/contributors","subscribers_url":"https://api.github.com/repos/FluxNotes/flux/subscribers","subscription_url":"https://api.github.com/repos/FluxNotes/flux/subscription","commits_url":"https://api.github.com/repos/FluxNotes/flux/commits{/sha}","git_commits_url":"https://api.github.com/repos/FluxNotes/flux/git/commits{/sha}","comments_url":"https://api.github.com/repos/FluxNotes/flux/comments{/number}","issue_comment_url":"https://api.github.com/repos/FluxNotes/flux/issues/comments{/number}","contents_url":"https://api.github.com/repos/FluxNotes/flux/contents/{+path}","compare_url":"https://api.github.com/repos/FluxNotes/flux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FluxNotes/flux/merges","archive_url":"https://api.github.com/repos/FluxNotes/flux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FluxNotes/flux/downloads","issues_url":"https://api.github.com/repos/FluxNotes/flux/issues{/number}","pulls_url":"https://api.github.com/repos/FluxNotes/flux/pulls{/number}","milestones_url":"https://api.github.com/repos/FluxNotes/flux/milestones{/number}","notifications_url":"https://api.github.com/repos/FluxNotes/flux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FluxNotes/flux/labels{/name}","releases_url":"https://api.github.com/repos/FluxNotes/flux/releases{/id}","deployments_url":"https://api.github.com/repos/FluxNotes/flux/deployments","created_at":"2017-05-02T18:02:07Z","updated_at":"2018-10-04T12:43:17Z","pushed_at":"2018-10-04T16:27:35Z","git_url":"git://github.com/FluxNotes/flux.git","ssh_url":"git@github.com:FluxNotes/flux.git","clone_url":"https://github.com/FluxNotes/flux.git","svn_url":"https://github.com/FluxNotes/flux","homepage":"","size":25265,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":6,"watchers":7,"default_branch":"master"}},"base":{"label":"FluxNotes:master","ref":"master","sha":"bd6384b9bf0c5a8fd36ffb63626be002f7edd1f1","user":{"login":"FluxNotes","id":37755753,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzU1NzUz","avatar_url":"https://avatars0.githubusercontent.com/u/37755753?v=4","gravatar_id":"","url":"https://api.github.com/users/FluxNotes","html_url":"https://github.com/FluxNotes","followers_url":"https://api.github.com/users/FluxNotes/followers","following_url":"https://api.github.com/users/FluxNotes/following{/other_user}","gists_url":"https://api.github.com/users/FluxNotes/gists{/gist_id}","starred_url":"https://api.github.com/users/FluxNotes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FluxNotes/subscriptions","organizations_url":"https://api.github.com/users/FluxNotes/orgs","repos_url":"https://api.github.com/users/FluxNotes/repos","events_url":"https://api.github.com/users/FluxNotes/events{/privacy}","received_events_url":"https://api.github.com/users/FluxNotes/received_events","type":"Organization","site_admin":false},"repo":{"id":90062848,"node_id":"MDEwOlJlcG9zaXRvcnk5MDA2Mjg0OA==","name":"flux","full_name":"FluxNotes/flux","private":false,"owner":{"login":"FluxNotes","id":37755753,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzU1NzUz","avatar_url":"https://avatars0.githubusercontent.com/u/37755753?v=4","gravatar_id":"","url":"https://api.github.com/users/FluxNotes","html_url":"https://github.com/FluxNotes","followers_url":"https://api.github.com/users/FluxNotes/followers","following_url":"https://api.github.com/users/FluxNotes/following{/other_user}","gists_url":"https://api.github.com/users/FluxNotes/gists{/gist_id}","starred_url":"https://api.github.com/users/FluxNotes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FluxNotes/subscriptions","organizations_url":"https://api.github.com/users/FluxNotes/orgs","repos_url":"https://api.github.com/users/FluxNotes/repos","events_url":"https://api.github.com/users/FluxNotes/events{/privacy}","received_events_url":"https://api.github.com/users/FluxNotes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/FluxNotes/flux","description":"Flux: Data Capture Prototype for Clinical Oncology ","fork":false,"url":"https://api.github.com/repos/FluxNotes/flux","forks_url":"https://api.github.com/repos/FluxNotes/flux/forks","keys_url":"https://api.github.com/repos/FluxNotes/flux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FluxNotes/flux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FluxNotes/flux/teams","hooks_url":"https://api.github.com/repos/FluxNotes/flux/hooks","issue_events_url":"https://api.github.com/repos/FluxNotes/flux/issues/events{/number}","events_url":"https://api.github.com/repos/FluxNotes/flux/events","assignees_url":"https://api.github.com/repos/FluxNotes/flux/assignees{/user}","branches_url":"https://api.github.com/repos/FluxNotes/flux/branches{/branch}","tags_url":"https://api.github.com/repos/FluxNotes/flux/tags","blobs_url":"https://api.github.com/repos/FluxNotes/flux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FluxNotes/flux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FluxNotes/flux/git/refs{/sha}","trees_url":"https://api.github.com/repos/FluxNotes/flux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FluxNotes/flux/statuses/{sha}","languages_url":"https://api.github.com/repos/FluxNotes/flux/languages","stargazers_url":"https://api.github.com/repos/FluxNotes/flux/stargazers","contributors_url":"https://api.github.com/repos/FluxNotes/flux/contributors","subscribers_url":"https://api.github.com/repos/FluxNotes/flux/subscribers","subscription_url":"https://api.github.com/repos/FluxNotes/flux/subscription","commits_url":"https://api.github.com/repos/FluxNotes/flux/commits{/sha}","git_commits_url":"https://api.github.com/repos/FluxNotes/flux/git/commits{/sha}","comments_url":"https://api.github.com/repos/FluxNotes/flux/comments{/number}","issue_comment_url":"https://api.github.com/repos/FluxNotes/flux/issues/comments{/number}","contents_url":"https://api.github.com/repos/FluxNotes/flux/contents/{+path}","compare_url":"https://api.github.com/repos/FluxNotes/flux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FluxNotes/flux/merges","archive_url":"https://api.github.com/repos/FluxNotes/flux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FluxNotes/flux/downloads","issues_url":"https://api.github.com/repos/FluxNotes/flux/issues{/number}","pulls_url":"https://api.github.com/repos/FluxNotes/flux/pulls{/number}","milestones_url":"https://api.github.com/repos/FluxNotes/flux/milestones{/number}","notifications_url":"https://api.github.com/repos/FluxNotes/flux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FluxNotes/flux/labels{/name}","releases_url":"https://api.github.com/repos/FluxNotes/flux/releases{/id}","deployments_url":"https://api.github.com/repos/FluxNotes/flux/deployments","created_at":"2017-05-02T18:02:07Z","updated_at":"2018-10-04T12:43:17Z","pushed_at":"2018-10-04T16:27:35Z","git_url":"git://github.com/FluxNotes/flux.git","ssh_url":"git@github.com:FluxNotes/flux.git","clone_url":"https://github.com/FluxNotes/flux.git","svn_url":"https://github.com/FluxNotes/flux","homepage":"","size":25265,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":6,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FluxNotes/flux/pulls/475"},"html":{"href":"https://github.com/FluxNotes/flux/pull/475"},"issue":{"href":"https://api.github.com/repos/FluxNotes/flux/issues/475"},"comments":{"href":"https://api.github.com/repos/FluxNotes/flux/issues/475/comments"},"review_comments":{"href":"https://api.github.com/repos/FluxNotes/flux/pulls/475/comments"},"review_comment":{"href":"https://api.github.com/repos/FluxNotes/flux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FluxNotes/flux/pulls/475/commits"},"statuses":{"href":"https://api.github.com/repos/FluxNotes/flux/statuses/00f4c7007b96d725a6b75b8f0d5b52f65ee97039"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":27,"deletions":25,"changed_files":1}}
{"actor":{"display_login":"nicoleng12"}}