{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69445","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69445/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69445/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69445/events","html_url":"https://github.com/kubernetes/kubernetes/issues/69445","id":367000494,"node_id":"MDU6SXNzdWUzNjcwMDA0OTQ=","number":69445,"title":"New field in Pod spec cause issues with DaemonSet","user":{"login":"mortent","id":8463,"node_id":"MDQ6VXNlcjg0NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/8463?v=4","gravatar_id":"","url":"https://api.github.com/users/mortent","html_url":"https://github.com/mortent","followers_url":"https://api.github.com/users/mortent/followers","following_url":"https://api.github.com/users/mortent/following{/other_user}","gists_url":"https://api.github.com/users/mortent/gists{/gist_id}","starred_url":"https://api.github.com/users/mortent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mortent/subscriptions","organizations_url":"https://api.github.com/users/mortent/orgs","repos_url":"https://api.github.com/users/mortent/repos","events_url":"https://api.github.com/users/mortent/events{/privacy}","received_events_url":"https://api.github.com/users/mortent/received_events","type":"User","site_admin":false},"labels":[{"id":105146071,"node_id":"MDU6TGFiZWwxMDUxNDYwNzE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":404091735,"node_id":"MDU6TGFiZWw0MDQwOTE3MzU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/apps","name":"sig/apps","color":"d2b48c","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-10-04T22:56:48Z","updated_at":"2018-10-18T02:55:46Z","closed_at":null,"author_association":"MEMBER","body":"<!-- This form is for bug reports and feature requests ONLY!\r\n\r\nIf you're looking for help check [Stack Overflow](https://stackoverflow.com/questions/tagged/kubernetes) and the [troubleshooting guide](https://kubernetes.io/docs/tasks/debug-application-cluster/troubleshooting/).\r\n\r\nIf the matter is security related, please disclose it privately via https://kubernetes.io/security/.\r\n-->\r\n\r\n**Is this a BUG REPORT or FEATURE REQUEST?**:\r\n\r\n/kind bug\r\n\r\nThe change in #68754 added a new field (`enableServiceLinks`) to the Pod spec that is set to true by default. This is causing problems for DaemonSets in some situations. \r\n\r\nDaemonSets are using ControllerRevisions to keep track of previous configurations and each revision will contain among other things the Pod spec for the DaemonSet. If a DaemonSet is created with the enableServiceLinks property is set to true, the ControllerRevision will also contain this field. If the cluster is rolled back to a previous version of kubernetes, the DeamonSet struct does not have this field and so the ControllerRevision and the DaemonSet will no longer match. This leads to a new ControllerRevision being created and a rolling update of all pods in the DaemonSet.\r\n\r\nWould it be a better solution to rename the field to `disableServiceLinks` and enable service links whenever the field is not set? This would fix the problem with the DaemonSets unless the field is explicitly set before the rollback.\r\n\r\nThis is causing the master upgrade tests to fail as reported in #69356\r\n\r\n/sig apps\r\n/cc @kow3ns\r\n/cc @dchen1107\r\n/cc @thockin\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/430858194","html_url":"https://github.com/kubernetes/kubernetes/issues/69445#issuecomment-430858194","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69445","id":430858194,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDg1ODE5NA==","user":{"login":"AishSundar","id":20229685,"node_id":"MDQ6VXNlcjIwMjI5Njg1","avatar_url":"https://avatars0.githubusercontent.com/u/20229685?v=4","gravatar_id":"","url":"https://api.github.com/users/AishSundar","html_url":"https://github.com/AishSundar","followers_url":"https://api.github.com/users/AishSundar/followers","following_url":"https://api.github.com/users/AishSundar/following{/other_user}","gists_url":"https://api.github.com/users/AishSundar/gists{/gist_id}","starred_url":"https://api.github.com/users/AishSundar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AishSundar/subscriptions","organizations_url":"https://api.github.com/users/AishSundar/orgs","repos_url":"https://api.github.com/users/AishSundar/repos","events_url":"https://api.github.com/users/AishSundar/events{/privacy}","received_events_url":"https://api.github.com/users/AishSundar/received_events","type":"User","site_admin":false},"created_at":"2018-10-18T02:55:46Z","updated_at":"2018-10-18T02:55:46Z","author_association":"CONTRIBUTOR","body":"/milestone v1.13"}}
{"actor":{"display_login":"AishSundar"}}