{"action":"created","comment":{"url":"https://api.github.com/repos/thesofproject/sof/pulls/comments/241832241","pull_request_review_id":185210293,"id":241832241,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTgzMjI0MQ==","diff_hunk":"@@ -496,7 +496,7 @@ static int ipc_dai_config(uint32_t header)\n \t}\n \n \t/* configure DAI */\n-\tret = dai_set_config(dai, &config);\n+\tret = dai_set_config(dai, _ipc->comp_data);","path":"src/ipc/handler.c","position":5,"original_position":5,"commit_id":"a844db7d87cae8f47a860d02495e3e90182dba98","original_commit_id":"4beac781bdd6f1ba7dc056d96b495ed2fa03428e","user":{"login":"dabekjakub","id":41289715,"node_id":"MDQ6VXNlcjQxMjg5NzE1","avatar_url":"https://avatars2.githubusercontent.com/u/41289715?v=4","gravatar_id":"","url":"https://api.github.com/users/dabekjakub","html_url":"https://github.com/dabekjakub","followers_url":"https://api.github.com/users/dabekjakub/followers","following_url":"https://api.github.com/users/dabekjakub/following{/other_user}","gists_url":"https://api.github.com/users/dabekjakub/gists{/gist_id}","starred_url":"https://api.github.com/users/dabekjakub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dabekjakub/subscriptions","organizations_url":"https://api.github.com/users/dabekjakub/orgs","repos_url":"https://api.github.com/users/dabekjakub/repos","events_url":"https://api.github.com/users/dabekjakub/events{/privacy}","received_events_url":"https://api.github.com/users/dabekjakub/received_events","type":"User","site_admin":false},"body":"Yes that is a recurring theme. This is the same issue with flex arrays. Maybe we should just allocate data from runtime heap with size of ipc itself for the config and then use ipc size for memcopy. We will have flex arrays and won't cut off the message itself since it won't be allocated on the stack.\r\n\r\n```suggestion\r\n\tstruct ipc_comp_dev *comp_dev;\r\n\tstruct sof_ipc_ctrl_data *data = rmalock(RZONE_RUNTIME,SOF_MEM_CAPS_RAM, \r\n\t((struct sof_ipc_cmd_hdr *)_ipc->comp_data)->size);\r\n```","created_at":"2018-12-14T17:31:48Z","updated_at":"2018-12-14T17:31:48Z","html_url":"https://github.com/thesofproject/sof/pull/721#discussion_r241832241","pull_request_url":"https://api.github.com/repos/thesofproject/sof/pulls/721","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/comments/241832241"},"html":{"href":"https://github.com/thesofproject/sof/pull/721#discussion_r241832241"},"pull_request":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/721"}},"in_reply_to_id":241827869},"pull_request":{"url":"https://api.github.com/repos/thesofproject/sof/pulls/721","id":238716240,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NzE2MjQw","html_url":"https://github.com/thesofproject/sof/pull/721","diff_url":"https://github.com/thesofproject/sof/pull/721.diff","patch_url":"https://github.com/thesofproject/sof/pull/721.patch","issue_url":"https://api.github.com/repos/thesofproject/sof/issues/721","number":721,"state":"open","locked":false,"title":"dmic: fix dmic and volume configuration icp","user":{"login":"dabekjakub","id":41289715,"node_id":"MDQ6VXNlcjQxMjg5NzE1","avatar_url":"https://avatars2.githubusercontent.com/u/41289715?v=4","gravatar_id":"","url":"https://api.github.com/users/dabekjakub","html_url":"https://github.com/dabekjakub","followers_url":"https://api.github.com/users/dabekjakub/followers","following_url":"https://api.github.com/users/dabekjakub/following{/other_user}","gists_url":"https://api.github.com/users/dabekjakub/gists{/gist_id}","starred_url":"https://api.github.com/users/dabekjakub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dabekjakub/subscriptions","organizations_url":"https://api.github.com/users/dabekjakub/orgs","repos_url":"https://api.github.com/users/dabekjakub/repos","events_url":"https://api.github.com/users/dabekjakub/events{/privacy}","received_events_url":"https://api.github.com/users/dabekjakub/received_events","type":"User","site_admin":false},"body":"Fixed ipc data size not beeing corectly passed to dmic and volume.\r\n\r\nSigned-off-by: Jakub Dabek <jakub.dabek@linux.intel.com>","created_at":"2018-12-14T13:08:10Z","updated_at":"2018-12-14T17:31:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77068dcd573c15ca1bff60c0ff6779dae99532b8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"plbossart","id":1149035,"node_id":"MDQ6VXNlcjExNDkwMzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1149035?v=4","gravatar_id":"","url":"https://api.github.com/users/plbossart","html_url":"https://github.com/plbossart","followers_url":"https://api.github.com/users/plbossart/followers","following_url":"https://api.github.com/users/plbossart/following{/other_user}","gists_url":"https://api.github.com/users/plbossart/gists{/gist_id}","starred_url":"https://api.github.com/users/plbossart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plbossart/subscriptions","organizations_url":"https://api.github.com/users/plbossart/orgs","repos_url":"https://api.github.com/users/plbossart/repos","events_url":"https://api.github.com/users/plbossart/events{/privacy}","received_events_url":"https://api.github.com/users/plbossart/received_events","type":"User","site_admin":false},{"login":"bardliao","id":8856808,"node_id":"MDQ6VXNlcjg4NTY4MDg=","avatar_url":"https://avatars0.githubusercontent.com/u/8856808?v=4","gravatar_id":"","url":"https://api.github.com/users/bardliao","html_url":"https://github.com/bardliao","followers_url":"https://api.github.com/users/bardliao/followers","following_url":"https://api.github.com/users/bardliao/following{/other_user}","gists_url":"https://api.github.com/users/bardliao/gists{/gist_id}","starred_url":"https://api.github.com/users/bardliao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bardliao/subscriptions","organizations_url":"https://api.github.com/users/bardliao/orgs","repos_url":"https://api.github.com/users/bardliao/repos","events_url":"https://api.github.com/users/bardliao/events{/privacy}","received_events_url":"https://api.github.com/users/bardliao/received_events","type":"User","site_admin":false},{"login":"xiulipan","id":37825714,"node_id":"MDQ6VXNlcjM3ODI1NzE0","avatar_url":"https://avatars2.githubusercontent.com/u/37825714?v=4","gravatar_id":"","url":"https://api.github.com/users/xiulipan","html_url":"https://github.com/xiulipan","followers_url":"https://api.github.com/users/xiulipan/followers","following_url":"https://api.github.com/users/xiulipan/following{/other_user}","gists_url":"https://api.github.com/users/xiulipan/gists{/gist_id}","starred_url":"https://api.github.com/users/xiulipan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiulipan/subscriptions","organizations_url":"https://api.github.com/users/xiulipan/orgs","repos_url":"https://api.github.com/users/xiulipan/repos","events_url":"https://api.github.com/users/xiulipan/events{/privacy}","received_events_url":"https://api.github.com/users/xiulipan/received_events","type":"User","site_admin":false},{"login":"lbetlej","id":39951716,"node_id":"MDQ6VXNlcjM5OTUxNzE2","avatar_url":"https://avatars1.githubusercontent.com/u/39951716?v=4","gravatar_id":"","url":"https://api.github.com/users/lbetlej","html_url":"https://github.com/lbetlej","followers_url":"https://api.github.com/users/lbetlej/followers","following_url":"https://api.github.com/users/lbetlej/following{/other_user}","gists_url":"https://api.github.com/users/lbetlej/gists{/gist_id}","starred_url":"https://api.github.com/users/lbetlej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbetlej/subscriptions","organizations_url":"https://api.github.com/users/lbetlej/orgs","repos_url":"https://api.github.com/users/lbetlej/repos","events_url":"https://api.github.com/users/lbetlej/events{/privacy}","received_events_url":"https://api.github.com/users/lbetlej/received_events","type":"User","site_admin":false},{"login":"mmaka1","id":40028148,"node_id":"MDQ6VXNlcjQwMDI4MTQ4","avatar_url":"https://avatars3.githubusercontent.com/u/40028148?v=4","gravatar_id":"","url":"https://api.github.com/users/mmaka1","html_url":"https://github.com/mmaka1","followers_url":"https://api.github.com/users/mmaka1/followers","following_url":"https://api.github.com/users/mmaka1/following{/other_user}","gists_url":"https://api.github.com/users/mmaka1/gists{/gist_id}","starred_url":"https://api.github.com/users/mmaka1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmaka1/subscriptions","organizations_url":"https://api.github.com/users/mmaka1/orgs","repos_url":"https://api.github.com/users/mmaka1/repos","events_url":"https://api.github.com/users/mmaka1/events{/privacy}","received_events_url":"https://api.github.com/users/mmaka1/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/thesofproject/sof/pulls/721/commits","review_comments_url":"https://api.github.com/repos/thesofproject/sof/pulls/721/comments","review_comment_url":"https://api.github.com/repos/thesofproject/sof/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thesofproject/sof/issues/721/comments","statuses_url":"https://api.github.com/repos/thesofproject/sof/statuses/a844db7d87cae8f47a860d02495e3e90182dba98","head":{"label":"dabekjakub:dmic_ipc_fix","ref":"dmic_ipc_fix","sha":"a844db7d87cae8f47a860d02495e3e90182dba98","user":{"login":"dabekjakub","id":41289715,"node_id":"MDQ6VXNlcjQxMjg5NzE1","avatar_url":"https://avatars2.githubusercontent.com/u/41289715?v=4","gravatar_id":"","url":"https://api.github.com/users/dabekjakub","html_url":"https://github.com/dabekjakub","followers_url":"https://api.github.com/users/dabekjakub/followers","following_url":"https://api.github.com/users/dabekjakub/following{/other_user}","gists_url":"https://api.github.com/users/dabekjakub/gists{/gist_id}","starred_url":"https://api.github.com/users/dabekjakub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dabekjakub/subscriptions","organizations_url":"https://api.github.com/users/dabekjakub/orgs","repos_url":"https://api.github.com/users/dabekjakub/repos","events_url":"https://api.github.com/users/dabekjakub/events{/privacy}","received_events_url":"https://api.github.com/users/dabekjakub/received_events","type":"User","site_admin":false},"repo":{"id":142555687,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI1NTU2ODc=","name":"sof","full_name":"dabekjakub/sof","private":false,"owner":{"login":"dabekjakub","id":41289715,"node_id":"MDQ6VXNlcjQxMjg5NzE1","avatar_url":"https://avatars2.githubusercontent.com/u/41289715?v=4","gravatar_id":"","url":"https://api.github.com/users/dabekjakub","html_url":"https://github.com/dabekjakub","followers_url":"https://api.github.com/users/dabekjakub/followers","following_url":"https://api.github.com/users/dabekjakub/following{/other_user}","gists_url":"https://api.github.com/users/dabekjakub/gists{/gist_id}","starred_url":"https://api.github.com/users/dabekjakub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dabekjakub/subscriptions","organizations_url":"https://api.github.com/users/dabekjakub/orgs","repos_url":"https://api.github.com/users/dabekjakub/repos","events_url":"https://api.github.com/users/dabekjakub/events{/privacy}","received_events_url":"https://api.github.com/users/dabekjakub/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dabekjakub/sof","description":"Sound Open Firmware","fork":true,"url":"https://api.github.com/repos/dabekjakub/sof","forks_url":"https://api.github.com/repos/dabekjakub/sof/forks","keys_url":"https://api.github.com/repos/dabekjakub/sof/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dabekjakub/sof/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dabekjakub/sof/teams","hooks_url":"https://api.github.com/repos/dabekjakub/sof/hooks","issue_events_url":"https://api.github.com/repos/dabekjakub/sof/issues/events{/number}","events_url":"https://api.github.com/repos/dabekjakub/sof/events","assignees_url":"https://api.github.com/repos/dabekjakub/sof/assignees{/user}","branches_url":"https://api.github.com/repos/dabekjakub/sof/branches{/branch}","tags_url":"https://api.github.com/repos/dabekjakub/sof/tags","blobs_url":"https://api.github.com/repos/dabekjakub/sof/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dabekjakub/sof/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dabekjakub/sof/git/refs{/sha}","trees_url":"https://api.github.com/repos/dabekjakub/sof/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dabekjakub/sof/statuses/{sha}","languages_url":"https://api.github.com/repos/dabekjakub/sof/languages","stargazers_url":"https://api.github.com/repos/dabekjakub/sof/stargazers","contributors_url":"https://api.github.com/repos/dabekjakub/sof/contributors","subscribers_url":"https://api.github.com/repos/dabekjakub/sof/subscribers","subscription_url":"https://api.github.com/repos/dabekjakub/sof/subscription","commits_url":"https://api.github.com/repos/dabekjakub/sof/commits{/sha}","git_commits_url":"https://api.github.com/repos/dabekjakub/sof/git/commits{/sha}","comments_url":"https://api.github.com/repos/dabekjakub/sof/comments{/number}","issue_comment_url":"https://api.github.com/repos/dabekjakub/sof/issues/comments{/number}","contents_url":"https://api.github.com/repos/dabekjakub/sof/contents/{+path}","compare_url":"https://api.github.com/repos/dabekjakub/sof/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dabekjakub/sof/merges","archive_url":"https://api.github.com/repos/dabekjakub/sof/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dabekjakub/sof/downloads","issues_url":"https://api.github.com/repos/dabekjakub/sof/issues{/number}","pulls_url":"https://api.github.com/repos/dabekjakub/sof/pulls{/number}","milestones_url":"https://api.github.com/repos/dabekjakub/sof/milestones{/number}","notifications_url":"https://api.github.com/repos/dabekjakub/sof/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dabekjakub/sof/labels{/name}","releases_url":"https://api.github.com/repos/dabekjakub/sof/releases{/id}","deployments_url":"https://api.github.com/repos/dabekjakub/sof/deployments","created_at":"2018-07-27T09:17:06Z","updated_at":"2018-11-27T10:16:13Z","pushed_at":"2018-12-14T17:20:34Z","git_url":"git://github.com/dabekjakub/sof.git","ssh_url":"git@github.com:dabekjakub/sof.git","clone_url":"https://github.com/dabekjakub/sof.git","svn_url":"https://github.com/dabekjakub/sof","homepage":null,"size":4913,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thesofproject:master","ref":"master","sha":"0dad013067b4c180d9082fc107d79208e527944c","user":{"login":"thesofproject","id":39773507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzczNTA3","avatar_url":"https://avatars1.githubusercontent.com/u/39773507?v=4","gravatar_id":"","url":"https://api.github.com/users/thesofproject","html_url":"https://github.com/thesofproject","followers_url":"https://api.github.com/users/thesofproject/followers","following_url":"https://api.github.com/users/thesofproject/following{/other_user}","gists_url":"https://api.github.com/users/thesofproject/gists{/gist_id}","starred_url":"https://api.github.com/users/thesofproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thesofproject/subscriptions","organizations_url":"https://api.github.com/users/thesofproject/orgs","repos_url":"https://api.github.com/users/thesofproject/repos","events_url":"https://api.github.com/users/thesofproject/events{/privacy}","received_events_url":"https://api.github.com/users/thesofproject/received_events","type":"Organization","site_admin":false},"repo":{"id":135623245,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU2MjMyNDU=","name":"sof","full_name":"thesofproject/sof","private":false,"owner":{"login":"thesofproject","id":39773507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzczNTA3","avatar_url":"https://avatars1.githubusercontent.com/u/39773507?v=4","gravatar_id":"","url":"https://api.github.com/users/thesofproject","html_url":"https://github.com/thesofproject","followers_url":"https://api.github.com/users/thesofproject/followers","following_url":"https://api.github.com/users/thesofproject/following{/other_user}","gists_url":"https://api.github.com/users/thesofproject/gists{/gist_id}","starred_url":"https://api.github.com/users/thesofproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thesofproject/subscriptions","organizations_url":"https://api.github.com/users/thesofproject/orgs","repos_url":"https://api.github.com/users/thesofproject/repos","events_url":"https://api.github.com/users/thesofproject/events{/privacy}","received_events_url":"https://api.github.com/users/thesofproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/thesofproject/sof","description":"Sound Open Firmware","fork":false,"url":"https://api.github.com/repos/thesofproject/sof","forks_url":"https://api.github.com/repos/thesofproject/sof/forks","keys_url":"https://api.github.com/repos/thesofproject/sof/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thesofproject/sof/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thesofproject/sof/teams","hooks_url":"https://api.github.com/repos/thesofproject/sof/hooks","issue_events_url":"https://api.github.com/repos/thesofproject/sof/issues/events{/number}","events_url":"https://api.github.com/repos/thesofproject/sof/events","assignees_url":"https://api.github.com/repos/thesofproject/sof/assignees{/user}","branches_url":"https://api.github.com/repos/thesofproject/sof/branches{/branch}","tags_url":"https://api.github.com/repos/thesofproject/sof/tags","blobs_url":"https://api.github.com/repos/thesofproject/sof/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thesofproject/sof/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thesofproject/sof/git/refs{/sha}","trees_url":"https://api.github.com/repos/thesofproject/sof/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thesofproject/sof/statuses/{sha}","languages_url":"https://api.github.com/repos/thesofproject/sof/languages","stargazers_url":"https://api.github.com/repos/thesofproject/sof/stargazers","contributors_url":"https://api.github.com/repos/thesofproject/sof/contributors","subscribers_url":"https://api.github.com/repos/thesofproject/sof/subscribers","subscription_url":"https://api.github.com/repos/thesofproject/sof/subscription","commits_url":"https://api.github.com/repos/thesofproject/sof/commits{/sha}","git_commits_url":"https://api.github.com/repos/thesofproject/sof/git/commits{/sha}","comments_url":"https://api.github.com/repos/thesofproject/sof/comments{/number}","issue_comment_url":"https://api.github.com/repos/thesofproject/sof/issues/comments{/number}","contents_url":"https://api.github.com/repos/thesofproject/sof/contents/{+path}","compare_url":"https://api.github.com/repos/thesofproject/sof/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thesofproject/sof/merges","archive_url":"https://api.github.com/repos/thesofproject/sof/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thesofproject/sof/downloads","issues_url":"https://api.github.com/repos/thesofproject/sof/issues{/number}","pulls_url":"https://api.github.com/repos/thesofproject/sof/pulls{/number}","milestones_url":"https://api.github.com/repos/thesofproject/sof/milestones{/number}","notifications_url":"https://api.github.com/repos/thesofproject/sof/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thesofproject/sof/labels{/name}","releases_url":"https://api.github.com/repos/thesofproject/sof/releases{/id}","deployments_url":"https://api.github.com/repos/thesofproject/sof/deployments","created_at":"2018-05-31T18:51:03Z","updated_at":"2018-12-14T17:06:27Z","pushed_at":"2018-12-14T17:20:35Z","git_url":"git://github.com/thesofproject/sof.git","ssh_url":"git@github.com:thesofproject/sof.git","clone_url":"https://github.com/thesofproject/sof.git","svn_url":"https://github.com/thesofproject/sof","homepage":null,"size":4957,"stargazers_count":26,"watchers_count":26,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":48,"open_issues":76,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/721"},"html":{"href":"https://github.com/thesofproject/sof/pull/721"},"issue":{"href":"https://api.github.com/repos/thesofproject/sof/issues/721"},"comments":{"href":"https://api.github.com/repos/thesofproject/sof/issues/721/comments"},"review_comments":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/721/comments"},"review_comment":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/721/commits"},"statuses":{"href":"https://api.github.com/repos/thesofproject/sof/statuses/a844db7d87cae8f47a860d02495e3e90182dba98"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dabekjakub"}}