{"action":"created","comment":{"url":"https://api.github.com/repos/sweetalert2/sweetalert2/pulls/comments/171822714","pull_request_review_id":100744166,"id":171822714,"diff_hunk":"@@ -19,9 +19,13 @@\n     \"detect-browser\": \"^2.1.0\",\n     \"event-stream\": \"^3.3.4\",\n     \"execa\": \"^0.9.0\",\n-    \"gulp\": \"^3.9.1\",\n+    \"gulp\": \"github:gulpjs/gulp#4.0\",","path":"package.json","position":5,"original_position":5,"commit_id":"2105695fcf6ad77ef48f09733fb3b0ce9b275289","original_commit_id":"2105695fcf6ad77ef48f09733fb3b0ce9b275289","user":{"login":"zenflow","id":3198597,"avatar_url":"https://avatars1.githubusercontent.com/u/3198597?v=4","gravatar_id":"","url":"https://api.github.com/users/zenflow","html_url":"https://github.com/zenflow","followers_url":"https://api.github.com/users/zenflow/followers","following_url":"https://api.github.com/users/zenflow/following{/other_user}","gists_url":"https://api.github.com/users/zenflow/gists{/gist_id}","starred_url":"https://api.github.com/users/zenflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenflow/subscriptions","organizations_url":"https://api.github.com/users/zenflow/orgs","repos_url":"https://api.github.com/users/zenflow/repos","events_url":"https://api.github.com/users/zenflow/events{/privacy}","received_events_url":"https://api.github.com/users/zenflow/received_events","type":"User","site_admin":false},"body":"Ok. Why do you need to use your globally installed gulp?","created_at":"2018-03-02T11:18:06Z","updated_at":"2018-03-02T11:18:06Z","html_url":"https://github.com/sweetalert2/sweetalert2/pull/973#discussion_r171822714","pull_request_url":"https://api.github.com/repos/sweetalert2/sweetalert2/pulls/973","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/sweetalert2/sweetalert2/pulls/comments/171822714"},"html":{"href":"https://github.com/sweetalert2/sweetalert2/pull/973#discussion_r171822714"},"pull_request":{"href":"https://api.github.com/repos/sweetalert2/sweetalert2/pulls/973"}},"in_reply_to_id":171821106},"pull_request":{"url":"https://api.github.com/repos/sweetalert2/sweetalert2/pulls/973","id":172263549,"html_url":"https://github.com/sweetalert2/sweetalert2/pull/973","diff_url":"https://github.com/sweetalert2/sweetalert2/pull/973.diff","patch_url":"https://github.com/sweetalert2/sweetalert2/pull/973.patch","issue_url":"https://api.github.com/repos/sweetalert2/sweetalert2/issues/973","number":973,"state":"open","locked":false,"title":"Optimize gulpfile.js","user":{"login":"zenflow","id":3198597,"avatar_url":"https://avatars1.githubusercontent.com/u/3198597?v=4","gravatar_id":"","url":"https://api.github.com/users/zenflow","html_url":"https://github.com/zenflow","followers_url":"https://api.github.com/users/zenflow/followers","following_url":"https://api.github.com/users/zenflow/following{/other_user}","gists_url":"https://api.github.com/users/zenflow/gists{/gist_id}","starred_url":"https://api.github.com/users/zenflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenflow/subscriptions","organizations_url":"https://api.github.com/users/zenflow/orgs","repos_url":"https://api.github.com/users/zenflow/repos","events_url":"https://api.github.com/users/zenflow/events{/privacy}","received_events_url":"https://api.github.com/users/zenflow/received_events","type":"User","site_admin":false},"body":"Changes\r\n- Naming and organization\r\n- Watches lintable files for linting, and buildable files for building (separate)\r\n- In active development mode, doesn't wait for linting results before starting build.\r\n- Doesn't repeat work, i.e. sources are compiled once, minified once, concatenated twice (.all.js & .all.min.js)\r\n- Doesn't have two separate entry-points to _(edit) test_. We can remove the terrible hack in `.travis.yml`\r\n- Uses minified css in sweetalert2.all.min.js  (see bundlesize report for byte savings) _(edit) and pretty css (as js) in sweetalert2.all.jss_\r\n- Exposes direct control over when minification happens, with --skip-minification\r\n- Exposes direct control over when the build includes .all.js files, with --skip-standalone","created_at":"2018-03-01T15:11:11Z","updated_at":"2018-03-02T11:18:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1085c97fb2c35962303a7714b88836cb7b80d3a3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":588866924,"url":"https://api.github.com/repos/sweetalert2/sweetalert2/labels/build%20&%20workflow","name":"build & workflow","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sweetalert2/sweetalert2/pulls/973/commits","review_comments_url":"https://api.github.com/repos/sweetalert2/sweetalert2/pulls/973/comments","review_comment_url":"https://api.github.com/repos/sweetalert2/sweetalert2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sweetalert2/sweetalert2/issues/973/comments","statuses_url":"https://api.github.com/repos/sweetalert2/sweetalert2/statuses/2105695fcf6ad77ef48f09733fb3b0ce9b275289","head":{"label":"sweetalert2:dev/optimize-gulpfile","ref":"dev/optimize-gulpfile","sha":"2105695fcf6ad77ef48f09733fb3b0ce9b275289","user":{"login":"sweetalert2","id":35137722,"avatar_url":"https://avatars1.githubusercontent.com/u/35137722?v=4","gravatar_id":"","url":"https://api.github.com/users/sweetalert2","html_url":"https://github.com/sweetalert2","followers_url":"https://api.github.com/users/sweetalert2/followers","following_url":"https://api.github.com/users/sweetalert2/following{/other_user}","gists_url":"https://api.github.com/users/sweetalert2/gists{/gist_id}","starred_url":"https://api.github.com/users/sweetalert2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sweetalert2/subscriptions","organizations_url":"https://api.github.com/users/sweetalert2/orgs","repos_url":"https://api.github.com/users/sweetalert2/repos","events_url":"https://api.github.com/users/sweetalert2/events{/privacy}","received_events_url":"https://api.github.com/users/sweetalert2/received_events","type":"Organization","site_admin":false},"repo":{"id":28748255,"name":"sweetalert2","full_name":"sweetalert2/sweetalert2","owner":{"login":"sweetalert2","id":35137722,"avatar_url":"https://avatars1.githubusercontent.com/u/35137722?v=4","gravatar_id":"","url":"https://api.github.com/users/sweetalert2","html_url":"https://github.com/sweetalert2","followers_url":"https://api.github.com/users/sweetalert2/followers","following_url":"https://api.github.com/users/sweetalert2/following{/other_user}","gists_url":"https://api.github.com/users/sweetalert2/gists{/gist_id}","starred_url":"https://api.github.com/users/sweetalert2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sweetalert2/subscriptions","organizations_url":"https://api.github.com/users/sweetalert2/orgs","repos_url":"https://api.github.com/users/sweetalert2/repos","events_url":"https://api.github.com/users/sweetalert2/events{/privacy}","received_events_url":"https://api.github.com/users/sweetalert2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sweetalert2/sweetalert2","description":"A beautiful, responsive, highly customizable and accessible (WAI-ARIA) replacement for JavaScript's popup boxes. Zero dependencies.","fork":false,"url":"https://api.github.com/repos/sweetalert2/sweetalert2","forks_url":"https://api.github.com/repos/sweetalert2/sweetalert2/forks","keys_url":"https://api.github.com/repos/sweetalert2/sweetalert2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sweetalert2/sweetalert2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sweetalert2/sweetalert2/teams","hooks_url":"https://api.github.com/repos/sweetalert2/sweetalert2/hooks","issue_events_url":"https://api.github.com/repos/sweetalert2/sweetalert2/issues/events{/number}","events_url":"https://api.github.com/repos/sweetalert2/sweetalert2/events","assignees_url":"https://api.github.com/repos/sweetalert2/sweetalert2/assignees{/user}","branches_url":"https://api.github.com/repos/sweetalert2/sweetalert2/branches{/branch}","tags_url":"https://api.github.com/repos/sweetalert2/sweetalert2/tags","blobs_url":"https://api.github.com/repos/sweetalert2/sweetalert2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sweetalert2/sweetalert2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sweetalert2/sweetalert2/git/refs{/sha}","trees_url":"https://api.github.com/repos/sweetalert2/sweetalert2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sweetalert2/sweetalert2/statuses/{sha}","languages_url":"https://api.github.com/repos/sweetalert2/sweetalert2/languages","stargazers_url":"https://api.github.com/repos/sweetalert2/sweetalert2/stargazers","contributors_url":"https://api.github.com/repos/sweetalert2/sweetalert2/contributors","subscribers_url":"https://api.github.com/repos/sweetalert2/sweetalert2/subscribers","subscription_url":"https://api.github.com/repos/sweetalert2/sweetalert2/subscription","commits_url":"https://api.github.com/repos/sweetalert2/sweetalert2/commits{/sha}","git_commits_url":"https://api.github.com/repos/sweetalert2/sweetalert2/git/commits{/sha}","comments_url":"https://api.github.com/repos/sweetalert2/sweetalert2/comments{/number}","issue_comment_url":"https://api.github.com/repos/sweetalert2/sweetalert2/issues/comments{/number}","contents_url":"https://api.github.com/repos/sweetalert2/sweetalert2/contents/{+path}","compare_url":"https://api.github.com/repos/sweetalert2/sweetalert2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sweetalert2/sweetalert2/merges","archive_url":"https://api.github.com/repos/sweetalert2/sweetalert2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sweetalert2/sweetalert2/downloads","issues_url":"https://api.github.com/repos/sweetalert2/sweetalert2/issues{/number}","pulls_url":"https://api.github.com/repos/sweetalert2/sweetalert2/pulls{/number}","milestones_url":"https://api.github.com/repos/sweetalert2/sweetalert2/milestones{/number}","notifications_url":"https://api.github.com/repos/sweetalert2/sweetalert2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sweetalert2/sweetalert2/labels{/name}","releases_url":"https://api.github.com/repos/sweetalert2/sweetalert2/releases{/id}","deployments_url":"https://api.github.com/repos/sweetalert2/sweetalert2/deployments","created_at":"2015-01-03T16:15:52Z","updated_at":"2018-03-02T09:56:46Z","pushed_at":"2018-03-02T11:14:14Z","git_url":"git://github.com/sweetalert2/sweetalert2.git","ssh_url":"git@github.com:sweetalert2/sweetalert2.git","clone_url":"https://github.com/sweetalert2/sweetalert2.git","svn_url":"https://github.com/sweetalert2/sweetalert2","homepage":"https://sweetalert2.github.io/","size":9547,"stargazers_count":6024,"watchers_count":6024,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":746,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":746,"open_issues":37,"watchers":6024,"default_branch":"master"}},"base":{"label":"sweetalert2:master","ref":"master","sha":"ef503baf1d85aefcfaebac5489d2ca3a560e66f8","user":{"login":"sweetalert2","id":35137722,"avatar_url":"https://avatars1.githubusercontent.com/u/35137722?v=4","gravatar_id":"","url":"https://api.github.com/users/sweetalert2","html_url":"https://github.com/sweetalert2","followers_url":"https://api.github.com/users/sweetalert2/followers","following_url":"https://api.github.com/users/sweetalert2/following{/other_user}","gists_url":"https://api.github.com/users/sweetalert2/gists{/gist_id}","starred_url":"https://api.github.com/users/sweetalert2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sweetalert2/subscriptions","organizations_url":"https://api.github.com/users/sweetalert2/orgs","repos_url":"https://api.github.com/users/sweetalert2/repos","events_url":"https://api.github.com/users/sweetalert2/events{/privacy}","received_events_url":"https://api.github.com/users/sweetalert2/received_events","type":"Organization","site_admin":false},"repo":{"id":28748255,"name":"sweetalert2","full_name":"sweetalert2/sweetalert2","owner":{"login":"sweetalert2","id":35137722,"avatar_url":"https://avatars1.githubusercontent.com/u/35137722?v=4","gravatar_id":"","url":"https://api.github.com/users/sweetalert2","html_url":"https://github.com/sweetalert2","followers_url":"https://api.github.com/users/sweetalert2/followers","following_url":"https://api.github.com/users/sweetalert2/following{/other_user}","gists_url":"https://api.github.com/users/sweetalert2/gists{/gist_id}","starred_url":"https://api.github.com/users/sweetalert2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sweetalert2/subscriptions","organizations_url":"https://api.github.com/users/sweetalert2/orgs","repos_url":"https://api.github.com/users/sweetalert2/repos","events_url":"https://api.github.com/users/sweetalert2/events{/privacy}","received_events_url":"https://api.github.com/users/sweetalert2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sweetalert2/sweetalert2","description":"A beautiful, responsive, highly customizable and accessible (WAI-ARIA) replacement for JavaScript's popup boxes. Zero dependencies.","fork":false,"url":"https://api.github.com/repos/sweetalert2/sweetalert2","forks_url":"https://api.github.com/repos/sweetalert2/sweetalert2/forks","keys_url":"https://api.github.com/repos/sweetalert2/sweetalert2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sweetalert2/sweetalert2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sweetalert2/sweetalert2/teams","hooks_url":"https://api.github.com/repos/sweetalert2/sweetalert2/hooks","issue_events_url":"https://api.github.com/repos/sweetalert2/sweetalert2/issues/events{/number}","events_url":"https://api.github.com/repos/sweetalert2/sweetalert2/events","assignees_url":"https://api.github.com/repos/sweetalert2/sweetalert2/assignees{/user}","branches_url":"https://api.github.com/repos/sweetalert2/sweetalert2/branches{/branch}","tags_url":"https://api.github.com/repos/sweetalert2/sweetalert2/tags","blobs_url":"https://api.github.com/repos/sweetalert2/sweetalert2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sweetalert2/sweetalert2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sweetalert2/sweetalert2/git/refs{/sha}","trees_url":"https://api.github.com/repos/sweetalert2/sweetalert2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sweetalert2/sweetalert2/statuses/{sha}","languages_url":"https://api.github.com/repos/sweetalert2/sweetalert2/languages","stargazers_url":"https://api.github.com/repos/sweetalert2/sweetalert2/stargazers","contributors_url":"https://api.github.com/repos/sweetalert2/sweetalert2/contributors","subscribers_url":"https://api.github.com/repos/sweetalert2/sweetalert2/subscribers","subscription_url":"https://api.github.com/repos/sweetalert2/sweetalert2/subscription","commits_url":"https://api.github.com/repos/sweetalert2/sweetalert2/commits{/sha}","git_commits_url":"https://api.github.com/repos/sweetalert2/sweetalert2/git/commits{/sha}","comments_url":"https://api.github.com/repos/sweetalert2/sweetalert2/comments{/number}","issue_comment_url":"https://api.github.com/repos/sweetalert2/sweetalert2/issues/comments{/number}","contents_url":"https://api.github.com/repos/sweetalert2/sweetalert2/contents/{+path}","compare_url":"https://api.github.com/repos/sweetalert2/sweetalert2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sweetalert2/sweetalert2/merges","archive_url":"https://api.github.com/repos/sweetalert2/sweetalert2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sweetalert2/sweetalert2/downloads","issues_url":"https://api.github.com/repos/sweetalert2/sweetalert2/issues{/number}","pulls_url":"https://api.github.com/repos/sweetalert2/sweetalert2/pulls{/number}","milestones_url":"https://api.github.com/repos/sweetalert2/sweetalert2/milestones{/number}","notifications_url":"https://api.github.com/repos/sweetalert2/sweetalert2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sweetalert2/sweetalert2/labels{/name}","releases_url":"https://api.github.com/repos/sweetalert2/sweetalert2/releases{/id}","deployments_url":"https://api.github.com/repos/sweetalert2/sweetalert2/deployments","created_at":"2015-01-03T16:15:52Z","updated_at":"2018-03-02T09:56:46Z","pushed_at":"2018-03-02T11:14:14Z","git_url":"git://github.com/sweetalert2/sweetalert2.git","ssh_url":"git@github.com:sweetalert2/sweetalert2.git","clone_url":"https://github.com/sweetalert2/sweetalert2.git","svn_url":"https://github.com/sweetalert2/sweetalert2","homepage":"https://sweetalert2.github.io/","size":9547,"stargazers_count":6024,"watchers_count":6024,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":746,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":746,"open_issues":37,"watchers":6024,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sweetalert2/sweetalert2/pulls/973"},"html":{"href":"https://github.com/sweetalert2/sweetalert2/pull/973"},"issue":{"href":"https://api.github.com/repos/sweetalert2/sweetalert2/issues/973"},"comments":{"href":"https://api.github.com/repos/sweetalert2/sweetalert2/issues/973/comments"},"review_comments":{"href":"https://api.github.com/repos/sweetalert2/sweetalert2/pulls/973/comments"},"review_comment":{"href":"https://api.github.com/repos/sweetalert2/sweetalert2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sweetalert2/sweetalert2/pulls/973/commits"},"statuses":{"href":"https://api.github.com/repos/sweetalert2/sweetalert2/statuses/2105695fcf6ad77ef48f09733fb3b0ce9b275289"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"zenflow"}}