{"action":"created","issue":{"url":"https://api.github.com/repos/neomutt/neomutt/issues/1187","repository_url":"https://api.github.com/repos/neomutt/neomutt","labels_url":"https://api.github.com/repos/neomutt/neomutt/issues/1187/labels{/name}","comments_url":"https://api.github.com/repos/neomutt/neomutt/issues/1187/comments","events_url":"https://api.github.com/repos/neomutt/neomutt/issues/1187/events","html_url":"https://github.com/neomutt/neomutt/pull/1187","id":320233830,"number":1187,"title":"Convert GroupContext to use STAILQ","user":{"login":"yuzibo","id":7083056,"avatar_url":"https://avatars0.githubusercontent.com/u/7083056?v=4","gravatar_id":"","url":"https://api.github.com/users/yuzibo","html_url":"https://github.com/yuzibo","followers_url":"https://api.github.com/users/yuzibo/followers","following_url":"https://api.github.com/users/yuzibo/following{/other_user}","gists_url":"https://api.github.com/users/yuzibo/gists{/gist_id}","starred_url":"https://api.github.com/users/yuzibo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuzibo/subscriptions","organizations_url":"https://api.github.com/users/yuzibo/orgs","repos_url":"https://api.github.com/users/yuzibo/repos","events_url":"https://api.github.com/users/yuzibo/events{/privacy}","received_events_url":"https://api.github.com/users/yuzibo/received_events","type":"User","site_admin":false},"labels":[{"id":903544454,"url":"https://api.github.com/repos/neomutt/neomutt/labels/good%20first%20issue","name":"good first issue","color":"b0581d","default":true},{"id":903540996,"url":"https://api.github.com/repos/neomutt/neomutt/labels/help%20wanted","name":"help wanted","color":"b0581d","default":true},{"id":903545371,"url":"https://api.github.com/repos/neomutt/neomutt/labels/mentor","name":"mentor","color":"000000","default":false},{"id":523386465,"url":"https://api.github.com/repos/neomutt/neomutt/labels/status:in-progress","name":"status:in-progress","color":"1d76db","default":false}],"state":"open","locked":false,"assignee":{"login":"gahr","id":959474,"avatar_url":"https://avatars2.githubusercontent.com/u/959474?v=4","gravatar_id":"","url":"https://api.github.com/users/gahr","html_url":"https://github.com/gahr","followers_url":"https://api.github.com/users/gahr/followers","following_url":"https://api.github.com/users/gahr/following{/other_user}","gists_url":"https://api.github.com/users/gahr/gists{/gist_id}","starred_url":"https://api.github.com/users/gahr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gahr/subscriptions","organizations_url":"https://api.github.com/users/gahr/orgs","repos_url":"https://api.github.com/users/gahr/repos","events_url":"https://api.github.com/users/gahr/events{/privacy}","received_events_url":"https://api.github.com/users/gahr/received_events","type":"User","site_admin":false},"assignees":[{"login":"gahr","id":959474,"avatar_url":"https://avatars2.githubusercontent.com/u/959474?v=4","gravatar_id":"","url":"https://api.github.com/users/gahr","html_url":"https://github.com/gahr","followers_url":"https://api.github.com/users/gahr/followers","following_url":"https://api.github.com/users/gahr/following{/other_user}","gists_url":"https://api.github.com/users/gahr/gists{/gist_id}","starred_url":"https://api.github.com/users/gahr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gahr/subscriptions","organizations_url":"https://api.github.com/users/gahr/orgs","repos_url":"https://api.github.com/users/gahr/repos","events_url":"https://api.github.com/users/gahr/events{/privacy}","received_events_url":"https://api.github.com/users/gahr/received_events","type":"User","site_admin":false},{"login":"yuzibo","id":7083056,"avatar_url":"https://avatars0.githubusercontent.com/u/7083056?v=4","gravatar_id":"","url":"https://api.github.com/users/yuzibo","html_url":"https://github.com/yuzibo","followers_url":"https://api.github.com/users/yuzibo/followers","following_url":"https://api.github.com/users/yuzibo/following{/other_user}","gists_url":"https://api.github.com/users/yuzibo/gists{/gist_id}","starred_url":"https://api.github.com/users/yuzibo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuzibo/subscriptions","organizations_url":"https://api.github.com/users/yuzibo/orgs","repos_url":"https://api.github.com/users/yuzibo/repos","events_url":"https://api.github.com/users/yuzibo/events{/privacy}","received_events_url":"https://api.github.com/users/yuzibo/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2018-05-04T11:01:02Z","updated_at":"2018-05-08T14:26:46Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/neomutt/neomutt/pulls/1187","html_url":"https://github.com/neomutt/neomutt/pull/1187","diff_url":"https://github.com/neomutt/neomutt/pull/1187.diff","patch_url":"https://github.com/neomutt/neomutt/pull/1187.patch"},"body":"*JUST* be compiled.If run, it reports \"segment error\" :(\r\n\r\n* **What does this PR do?**\r\nConvert GroupContext to use STAILQ\r\n* **Are there points in the code the reviewer needs to double check?**\r\nYES. The code is very bad\r\n* **Screenshots (if relevant)**\r\n\r\n* **Does this PR meet the acceptance criteria?** (This is just a reminder for you,\r\n  this section can be removed if you fulfill it.)\r\n\r\n   - Documentation created/updated (you have to edit\r\n     [doc/manual.xml.head](https://www.github.com/neomutt/neomutt/blob/master/doc/manual.xml.head)\r\n     for that)\r\n\r\n   - All builds are passing\r\n\r\n   - Added [doxygen code documentation](https://neomutt.org/dev/doxygen)\r\n     [syntax](http://www.stack.nl/~dimitri/doxygen/manual/docblocks.html)\r\n\r\n   - Code follows the [style guide](https://neomutt.org/dev/coding-style)\r\n\r\n* **What are the relevant issue numbers?**\r\n"},"comment":{"url":"https://api.github.com/repos/neomutt/neomutt/issues/comments/387421016","html_url":"https://github.com/neomutt/neomutt/pull/1187#issuecomment-387421016","issue_url":"https://api.github.com/repos/neomutt/neomutt/issues/1187","id":387421016,"user":{"login":"yuzibo","id":7083056,"avatar_url":"https://avatars0.githubusercontent.com/u/7083056?v=4","gravatar_id":"","url":"https://api.github.com/users/yuzibo","html_url":"https://github.com/yuzibo","followers_url":"https://api.github.com/users/yuzibo/followers","following_url":"https://api.github.com/users/yuzibo/following{/other_user}","gists_url":"https://api.github.com/users/yuzibo/gists{/gist_id}","starred_url":"https://api.github.com/users/yuzibo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuzibo/subscriptions","organizations_url":"https://api.github.com/users/yuzibo/orgs","repos_url":"https://api.github.com/users/yuzibo/repos","events_url":"https://api.github.com/users/yuzibo/events{/privacy}","received_events_url":"https://api.github.com/users/yuzibo/received_events","type":"User","site_admin":false},"created_at":"2018-05-08T14:26:46Z","updated_at":"2018-05-08T14:26:46Z","author_association":"MEMBER","body":"Hello,\r\nThank your help. I help my terrible questions not enrage you :)\r\n```c\r\nvoid mutt_group_context_add(struct GroupContextHead *head, struct Group *group)\r\n{\r\n  struct GroupContext *np = NULL;\r\n  STAILQ_FOREACH(np, head, entries)\r\n  {\r\n    if (np->g == group)\r\n      return;\r\n  }\r\n  np = mutt_mem_calloc(1, sizeof(struct GroupContext));\r\n  np->g = group;\r\n  STAILQ_INSERT_TAIL(head, np, entries);\r\n}\r\n```\r\nThe functions's goal is put group into (GroupContext)head.First, making match,if found,over the func.\r\nelse put group into head.As i know.\r\nIs it(functions) ok?I suspect  it is not ok\r\n.I think that i  only deal with the function well,then can process \r\n *mutt_group_context_add_regex*.\r\nThanks"}}
{"actor":{"display_login":"yuzibo"}}