{"action":"created","issue":{"url":"https://api.github.com/repos/oppia/oppia/issues/5948","repository_url":"https://api.github.com/repos/oppia/oppia","labels_url":"https://api.github.com/repos/oppia/oppia/issues/5948/labels{/name}","comments_url":"https://api.github.com/repos/oppia/oppia/issues/5948/comments","events_url":"https://api.github.com/repos/oppia/oppia/issues/5948/events","html_url":"https://github.com/oppia/oppia/pull/5948","id":388102506,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NDQyODgw","number":5948,"title":"Fix #5701: Alert user to save changes before publishing","user":{"login":"ankita240796","id":15226041,"node_id":"MDQ6VXNlcjE1MjI2MDQx","avatar_url":"https://avatars3.githubusercontent.com/u/15226041?v=4","gravatar_id":"","url":"https://api.github.com/users/ankita240796","html_url":"https://github.com/ankita240796","followers_url":"https://api.github.com/users/ankita240796/followers","following_url":"https://api.github.com/users/ankita240796/following{/other_user}","gists_url":"https://api.github.com/users/ankita240796/gists{/gist_id}","starred_url":"https://api.github.com/users/ankita240796/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankita240796/subscriptions","organizations_url":"https://api.github.com/users/ankita240796/orgs","repos_url":"https://api.github.com/users/ankita240796/repos","events_url":"https://api.github.com/users/ankita240796/events{/privacy}","received_events_url":"https://api.github.com/users/ankita240796/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"nithusha21","id":11898234,"node_id":"MDQ6VXNlcjExODk4MjM0","avatar_url":"https://avatars2.githubusercontent.com/u/11898234?v=4","gravatar_id":"","url":"https://api.github.com/users/nithusha21","html_url":"https://github.com/nithusha21","followers_url":"https://api.github.com/users/nithusha21/followers","following_url":"https://api.github.com/users/nithusha21/following{/other_user}","gists_url":"https://api.github.com/users/nithusha21/gists{/gist_id}","starred_url":"https://api.github.com/users/nithusha21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nithusha21/subscriptions","organizations_url":"https://api.github.com/users/nithusha21/orgs","repos_url":"https://api.github.com/users/nithusha21/repos","events_url":"https://api.github.com/users/nithusha21/events{/privacy}","received_events_url":"https://api.github.com/users/nithusha21/received_events","type":"User","site_admin":false},"assignees":[{"login":"nithusha21","id":11898234,"node_id":"MDQ6VXNlcjExODk4MjM0","avatar_url":"https://avatars2.githubusercontent.com/u/11898234?v=4","gravatar_id":"","url":"https://api.github.com/users/nithusha21","html_url":"https://github.com/nithusha21","followers_url":"https://api.github.com/users/nithusha21/followers","following_url":"https://api.github.com/users/nithusha21/following{/other_user}","gists_url":"https://api.github.com/users/nithusha21/gists{/gist_id}","starred_url":"https://api.github.com/users/nithusha21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nithusha21/subscriptions","organizations_url":"https://api.github.com/users/nithusha21/orgs","repos_url":"https://api.github.com/users/nithusha21/repos","events_url":"https://api.github.com/users/nithusha21/events{/privacy}","received_events_url":"https://api.github.com/users/nithusha21/received_events","type":"User","site_admin":false}],"milestone":null,"comments":15,"created_at":"2018-12-06T08:19:54Z","updated_at":"2018-12-08T04:14:05Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/oppia/oppia/pulls/5948","html_url":"https://github.com/oppia/oppia/pull/5948","diff_url":"https://github.com/oppia/oppia/pull/5948.diff","patch_url":"https://github.com/oppia/oppia/pull/5948.patch"},"body":"## Explanation\r\nFixes #5701 \r\nAdded mechanism to alert user if user clicks on publish button without saving draft.\r\n\r\nHere is a screenshot for the same:\r\n![image](https://user-images.githubusercontent.com/15226041/49570864-c22ffe00-f95d-11e8-9ab3-6782ad02d679.png)\r\n\r\n## Checklist\r\n- [x] The PR title starts with \"Fix #bugnum: \", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with \"Fix part of #bugnum: ...\".)\r\n- [x] The PR explanation includes the words \"Fixes #bugnum: ...\" (or \"Fixes part of #bugnum\" if the PR only partially fixes an issue).\r\n- [x] The linter/Karma presubmit checks have passed.\r\n  - These should run automatically, but if not, you can manually trigger them locally using `python scripts/pre_commit_linter.py` and `bash scripts/run_frontend_tests.sh`.\r\n- [x] The PR is made from a branch that's **not** called \"develop\".\r\n- [x] The PR follows the [style guide](https://github.com/oppia/oppia/wiki/Coding-style-guide).\r\n- [x] The PR is assigned to an appropriate reviewer.\r\n"},"comment":{"url":"https://api.github.com/repos/oppia/oppia/issues/comments/445429022","html_url":"https://github.com/oppia/oppia/pull/5948#issuecomment-445429022","issue_url":"https://api.github.com/repos/oppia/oppia/issues/5948","id":445429022,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTQyOTAyMg==","user":{"login":"ankita240796","id":15226041,"node_id":"MDQ6VXNlcjE1MjI2MDQx","avatar_url":"https://avatars3.githubusercontent.com/u/15226041?v=4","gravatar_id":"","url":"https://api.github.com/users/ankita240796","html_url":"https://github.com/ankita240796","followers_url":"https://api.github.com/users/ankita240796/followers","following_url":"https://api.github.com/users/ankita240796/following{/other_user}","gists_url":"https://api.github.com/users/ankita240796/gists{/gist_id}","starred_url":"https://api.github.com/users/ankita240796/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankita240796/subscriptions","organizations_url":"https://api.github.com/users/ankita240796/orgs","repos_url":"https://api.github.com/users/ankita240796/repos","events_url":"https://api.github.com/users/ankita240796/events{/privacy}","received_events_url":"https://api.github.com/users/ankita240796/received_events","type":"User","site_admin":false},"created_at":"2018-12-08T04:14:05Z","updated_at":"2018-12-08T04:14:05Z","author_association":"CONTRIBUTOR","body":"I think I agree with @bansalnitish that a modal here would be too complex. It would be better to use a tooltip. \r\nAlso, if we are using modal for a Publish button, then we need to provide the same consistent behaviour for Save Draft button"}}
{"actor":{"display_login":"ankita240796"}}