{"action":"created","comment":{"url":"https://api.github.com/repos/uisautomation/mws-panel/pulls/comments/172359645","pull_request_review_id":101362398,"id":172359645,"diff_hunk":"@@ -18,15 +18,14 @@ def check_main_domain_name(instance, **kwargs):\n @receiver(pre_delete, sender=SiteKey)\n def delete_sshfp_from_dns(instance, **kwargs):\n     '''Delete SSHFP records from the DNS using the DNS API when a SiteKey is deleted from the database'''\n-    if instance.type != \"ED25519\":\n-        for service in instance.site.services.all():\n+    for service in instance.site.services.all():\n+        for fptype in SiteKey.FP_TYPES:\n+            delete_sshfp(service.network_configuration.name, SiteKey.ALGORITHMS[instance.type],","path":"mws/sitesmanagement/signals.py","position":8,"original_position":8,"commit_id":"161e70b70ed67fe9a0598fe2743c76358cf0c1ff","original_commit_id":"161e70b70ed67fe9a0598fe2743c76358cf0c1ff","user":{"login":"abrahammartin","id":1429691,"avatar_url":"https://avatars2.githubusercontent.com/u/1429691?v=4","gravatar_id":"","url":"https://api.github.com/users/abrahammartin","html_url":"https://github.com/abrahammartin","followers_url":"https://api.github.com/users/abrahammartin/followers","following_url":"https://api.github.com/users/abrahammartin/following{/other_user}","gists_url":"https://api.github.com/users/abrahammartin/gists{/gist_id}","starred_url":"https://api.github.com/users/abrahammartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abrahammartin/subscriptions","organizations_url":"https://api.github.com/users/abrahammartin/orgs","repos_url":"https://api.github.com/users/abrahammartin/repos","events_url":"https://api.github.com/users/abrahammartin/events{/privacy}","received_events_url":"https://api.github.com/users/abrahammartin/received_events","type":"User","site_admin":false},"body":"this will break trying to delete SHA1 entries that no longer exists in the DNS","created_at":"2018-03-05T23:05:18Z","updated_at":"2018-03-05T23:06:12Z","html_url":"https://github.com/uisautomation/mws-panel/pull/17#discussion_r172359645","pull_request_url":"https://api.github.com/repos/uisautomation/mws-panel/pulls/17","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/uisautomation/mws-panel/pulls/comments/172359645"},"html":{"href":"https://github.com/uisautomation/mws-panel/pull/17#discussion_r172359645"},"pull_request":{"href":"https://api.github.com/repos/uisautomation/mws-panel/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/uisautomation/mws-panel/pulls/17","id":172479723,"html_url":"https://github.com/uisautomation/mws-panel/pull/17","diff_url":"https://github.com/uisautomation/mws-panel/pull/17.diff","patch_url":"https://github.com/uisautomation/mws-panel/pull/17.patch","issue_url":"https://api.github.com/repos/uisautomation/mws-panel/issues/17","number":17,"state":"open","locked":false,"title":"(review only) SSHFP for 2018","user":{"login":"ph448","id":11572806,"avatar_url":"https://avatars0.githubusercontent.com/u/11572806?v=4","gravatar_id":"","url":"https://api.github.com/users/ph448","html_url":"https://github.com/ph448","followers_url":"https://api.github.com/users/ph448/followers","following_url":"https://api.github.com/users/ph448/following{/other_user}","gists_url":"https://api.github.com/users/ph448/gists{/gist_id}","starred_url":"https://api.github.com/users/ph448/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ph448/subscriptions","organizations_url":"https://api.github.com/users/ph448/orgs","repos_url":"https://api.github.com/users/ph448/repos","events_url":"https://api.github.com/users/ph448/events{/privacy}","received_events_url":"https://api.github.com/users/ph448/received_events","type":"User","site_admin":false},"body":"This PR intends to add sending Ed25519 host keys and remove sending SHA1 hashes to Jackdaw.\r\nTests could have been updated to test for these, but as we mock them and not use the full suite of host keys anyway I saw little value.\r\nWhile madly grepping the source tree I also came accross a typo where Ed25516 was used instead.\r\nFixes uisautomation/mws-panel#18.\r\nThe PR code has not yet been tested, so please only review, do not merge.","created_at":"2018-03-02T11:22:04Z","updated_at":"2018-03-05T23:06:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93c283a8e8e1099d4fa1edf18f466b23ff0500ae","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/uisautomation/mws-panel/pulls/17/commits","review_comments_url":"https://api.github.com/repos/uisautomation/mws-panel/pulls/17/comments","review_comment_url":"https://api.github.com/repos/uisautomation/mws-panel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uisautomation/mws-panel/issues/17/comments","statuses_url":"https://api.github.com/repos/uisautomation/mws-panel/statuses/161e70b70ed67fe9a0598fe2743c76358cf0c1ff","head":{"label":"ph448:sshfp-for-2018","ref":"sshfp-for-2018","sha":"161e70b70ed67fe9a0598fe2743c76358cf0c1ff","user":{"login":"ph448","id":11572806,"avatar_url":"https://avatars0.githubusercontent.com/u/11572806?v=4","gravatar_id":"","url":"https://api.github.com/users/ph448","html_url":"https://github.com/ph448","followers_url":"https://api.github.com/users/ph448/followers","following_url":"https://api.github.com/users/ph448/following{/other_user}","gists_url":"https://api.github.com/users/ph448/gists{/gist_id}","starred_url":"https://api.github.com/users/ph448/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ph448/subscriptions","organizations_url":"https://api.github.com/users/ph448/orgs","repos_url":"https://api.github.com/users/ph448/repos","events_url":"https://api.github.com/users/ph448/events{/privacy}","received_events_url":"https://api.github.com/users/ph448/received_events","type":"User","site_admin":false},"repo":{"id":118785487,"name":"mws-panel","full_name":"ph448/mws-panel","owner":{"login":"ph448","id":11572806,"avatar_url":"https://avatars0.githubusercontent.com/u/11572806?v=4","gravatar_id":"","url":"https://api.github.com/users/ph448","html_url":"https://github.com/ph448","followers_url":"https://api.github.com/users/ph448/followers","following_url":"https://api.github.com/users/ph448/following{/other_user}","gists_url":"https://api.github.com/users/ph448/gists{/gist_id}","starred_url":"https://api.github.com/users/ph448/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ph448/subscriptions","organizations_url":"https://api.github.com/users/ph448/orgs","repos_url":"https://api.github.com/users/ph448/repos","events_url":"https://api.github.com/users/ph448/events{/privacy}","received_events_url":"https://api.github.com/users/ph448/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ph448/mws-panel","description":"MWSv3 Control Panel Webapp","fork":true,"url":"https://api.github.com/repos/ph448/mws-panel","forks_url":"https://api.github.com/repos/ph448/mws-panel/forks","keys_url":"https://api.github.com/repos/ph448/mws-panel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ph448/mws-panel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ph448/mws-panel/teams","hooks_url":"https://api.github.com/repos/ph448/mws-panel/hooks","issue_events_url":"https://api.github.com/repos/ph448/mws-panel/issues/events{/number}","events_url":"https://api.github.com/repos/ph448/mws-panel/events","assignees_url":"https://api.github.com/repos/ph448/mws-panel/assignees{/user}","branches_url":"https://api.github.com/repos/ph448/mws-panel/branches{/branch}","tags_url":"https://api.github.com/repos/ph448/mws-panel/tags","blobs_url":"https://api.github.com/repos/ph448/mws-panel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ph448/mws-panel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ph448/mws-panel/git/refs{/sha}","trees_url":"https://api.github.com/repos/ph448/mws-panel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ph448/mws-panel/statuses/{sha}","languages_url":"https://api.github.com/repos/ph448/mws-panel/languages","stargazers_url":"https://api.github.com/repos/ph448/mws-panel/stargazers","contributors_url":"https://api.github.com/repos/ph448/mws-panel/contributors","subscribers_url":"https://api.github.com/repos/ph448/mws-panel/subscribers","subscription_url":"https://api.github.com/repos/ph448/mws-panel/subscription","commits_url":"https://api.github.com/repos/ph448/mws-panel/commits{/sha}","git_commits_url":"https://api.github.com/repos/ph448/mws-panel/git/commits{/sha}","comments_url":"https://api.github.com/repos/ph448/mws-panel/comments{/number}","issue_comment_url":"https://api.github.com/repos/ph448/mws-panel/issues/comments{/number}","contents_url":"https://api.github.com/repos/ph448/mws-panel/contents/{+path}","compare_url":"https://api.github.com/repos/ph448/mws-panel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ph448/mws-panel/merges","archive_url":"https://api.github.com/repos/ph448/mws-panel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ph448/mws-panel/downloads","issues_url":"https://api.github.com/repos/ph448/mws-panel/issues{/number}","pulls_url":"https://api.github.com/repos/ph448/mws-panel/pulls{/number}","milestones_url":"https://api.github.com/repos/ph448/mws-panel/milestones{/number}","notifications_url":"https://api.github.com/repos/ph448/mws-panel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ph448/mws-panel/labels{/name}","releases_url":"https://api.github.com/repos/ph448/mws-panel/releases{/id}","deployments_url":"https://api.github.com/repos/ph448/mws-panel/deployments","created_at":"2018-01-24T15:41:36Z","updated_at":"2018-01-24T15:41:38Z","pushed_at":"2018-03-02T11:09:41Z","git_url":"git://github.com/ph448/mws-panel.git","ssh_url":"git@github.com:ph448/mws-panel.git","clone_url":"https://github.com/ph448/mws-panel.git","svn_url":"https://github.com/ph448/mws-panel","homepage":null,"size":5110,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"uisautomation:master","ref":"master","sha":"ca095d0ef7be20b4adb5a14f254aaed94567dd3a","user":{"login":"uisautomation","id":34515307,"avatar_url":"https://avatars0.githubusercontent.com/u/34515307?v=4","gravatar_id":"","url":"https://api.github.com/users/uisautomation","html_url":"https://github.com/uisautomation","followers_url":"https://api.github.com/users/uisautomation/followers","following_url":"https://api.github.com/users/uisautomation/following{/other_user}","gists_url":"https://api.github.com/users/uisautomation/gists{/gist_id}","starred_url":"https://api.github.com/users/uisautomation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uisautomation/subscriptions","organizations_url":"https://api.github.com/users/uisautomation/orgs","repos_url":"https://api.github.com/users/uisautomation/repos","events_url":"https://api.github.com/users/uisautomation/events{/privacy}","received_events_url":"https://api.github.com/users/uisautomation/received_events","type":"Organization","site_admin":false},"repo":{"id":116119160,"name":"mws-panel","full_name":"uisautomation/mws-panel","owner":{"login":"uisautomation","id":34515307,"avatar_url":"https://avatars0.githubusercontent.com/u/34515307?v=4","gravatar_id":"","url":"https://api.github.com/users/uisautomation","html_url":"https://github.com/uisautomation","followers_url":"https://api.github.com/users/uisautomation/followers","following_url":"https://api.github.com/users/uisautomation/following{/other_user}","gists_url":"https://api.github.com/users/uisautomation/gists{/gist_id}","starred_url":"https://api.github.com/users/uisautomation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uisautomation/subscriptions","organizations_url":"https://api.github.com/users/uisautomation/orgs","repos_url":"https://api.github.com/users/uisautomation/repos","events_url":"https://api.github.com/users/uisautomation/events{/privacy}","received_events_url":"https://api.github.com/users/uisautomation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uisautomation/mws-panel","description":"MWSv3 Control Panel Webapp","fork":false,"url":"https://api.github.com/repos/uisautomation/mws-panel","forks_url":"https://api.github.com/repos/uisautomation/mws-panel/forks","keys_url":"https://api.github.com/repos/uisautomation/mws-panel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uisautomation/mws-panel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uisautomation/mws-panel/teams","hooks_url":"https://api.github.com/repos/uisautomation/mws-panel/hooks","issue_events_url":"https://api.github.com/repos/uisautomation/mws-panel/issues/events{/number}","events_url":"https://api.github.com/repos/uisautomation/mws-panel/events","assignees_url":"https://api.github.com/repos/uisautomation/mws-panel/assignees{/user}","branches_url":"https://api.github.com/repos/uisautomation/mws-panel/branches{/branch}","tags_url":"https://api.github.com/repos/uisautomation/mws-panel/tags","blobs_url":"https://api.github.com/repos/uisautomation/mws-panel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uisautomation/mws-panel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uisautomation/mws-panel/git/refs{/sha}","trees_url":"https://api.github.com/repos/uisautomation/mws-panel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uisautomation/mws-panel/statuses/{sha}","languages_url":"https://api.github.com/repos/uisautomation/mws-panel/languages","stargazers_url":"https://api.github.com/repos/uisautomation/mws-panel/stargazers","contributors_url":"https://api.github.com/repos/uisautomation/mws-panel/contributors","subscribers_url":"https://api.github.com/repos/uisautomation/mws-panel/subscribers","subscription_url":"https://api.github.com/repos/uisautomation/mws-panel/subscription","commits_url":"https://api.github.com/repos/uisautomation/mws-panel/commits{/sha}","git_commits_url":"https://api.github.com/repos/uisautomation/mws-panel/git/commits{/sha}","comments_url":"https://api.github.com/repos/uisautomation/mws-panel/comments{/number}","issue_comment_url":"https://api.github.com/repos/uisautomation/mws-panel/issues/comments{/number}","contents_url":"https://api.github.com/repos/uisautomation/mws-panel/contents/{+path}","compare_url":"https://api.github.com/repos/uisautomation/mws-panel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uisautomation/mws-panel/merges","archive_url":"https://api.github.com/repos/uisautomation/mws-panel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uisautomation/mws-panel/downloads","issues_url":"https://api.github.com/repos/uisautomation/mws-panel/issues{/number}","pulls_url":"https://api.github.com/repos/uisautomation/mws-panel/pulls{/number}","milestones_url":"https://api.github.com/repos/uisautomation/mws-panel/milestones{/number}","notifications_url":"https://api.github.com/repos/uisautomation/mws-panel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uisautomation/mws-panel/labels{/name}","releases_url":"https://api.github.com/repos/uisautomation/mws-panel/releases{/id}","deployments_url":"https://api.github.com/repos/uisautomation/mws-panel/deployments","created_at":"2018-01-03T09:36:57Z","updated_at":"2018-01-03T16:54:25Z","pushed_at":"2018-03-02T11:22:05Z","git_url":"git://github.com/uisautomation/mws-panel.git","ssh_url":"git@github.com:uisautomation/mws-panel.git","clone_url":"https://github.com/uisautomation/mws-panel.git","svn_url":"https://github.com/uisautomation/mws-panel","homepage":null,"size":5109,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":4,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uisautomation/mws-panel/pulls/17"},"html":{"href":"https://github.com/uisautomation/mws-panel/pull/17"},"issue":{"href":"https://api.github.com/repos/uisautomation/mws-panel/issues/17"},"comments":{"href":"https://api.github.com/repos/uisautomation/mws-panel/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/uisautomation/mws-panel/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/uisautomation/mws-panel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uisautomation/mws-panel/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/uisautomation/mws-panel/statuses/161e70b70ed67fe9a0598fe2743c76358cf0c1ff"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"abrahammartin"}}