{"action":"created","comment":{"url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/pulls/comments/174740764","pull_request_review_id":104150382,"id":174740764,"diff_hunk":"@@ -135,9 +135,13 @@ var PanelWidget = new Lang.Class({\n \n         // refresh the widget every 60 secs\n         this.timeout = GLib.timeout_add_seconds(0, 60, Lang.bind(this, this.refresh));\n+        this.connect('destroy', Lang.bind(this, this._onDestroy));","path":"extension/widgets/panelWidget.js","position":4,"original_position":4,"commit_id":"2432a9c1be56c4bb9559f05cc4a3317c3cba10b6","original_commit_id":"2432a9c1be56c4bb9559f05cc4a3317c3cba10b6","user":{"login":"elbenfreund","id":332483,"avatar_url":"https://avatars2.githubusercontent.com/u/332483?v=4","gravatar_id":"","url":"https://api.github.com/users/elbenfreund","html_url":"https://github.com/elbenfreund","followers_url":"https://api.github.com/users/elbenfreund/followers","following_url":"https://api.github.com/users/elbenfreund/following{/other_user}","gists_url":"https://api.github.com/users/elbenfreund/gists{/gist_id}","starred_url":"https://api.github.com/users/elbenfreund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elbenfreund/subscriptions","organizations_url":"https://api.github.com/users/elbenfreund/orgs","repos_url":"https://api.github.com/users/elbenfreund/repos","events_url":"https://api.github.com/users/elbenfreund/events{/privacy}","received_events_url":"https://api.github.com/users/elbenfreund/received_events","type":"User","site_admin":false},"body":"Maybe having this with the rest of the (signal registrations](https://github.com/projecthamster/hamster-shell-extension/pull/242/files#diff-b3bda5daa9ff5a7db39094648ace1a1bR72) would be better? \r\nEither way, we probably should avoid giving the impression it is related to the refreshing every 60s.","created_at":"2018-03-15T10:44:00Z","updated_at":"2018-03-15T10:46:43Z","html_url":"https://github.com/projecthamster/hamster-shell-extension/pull/242#discussion_r174740764","pull_request_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/pulls/242","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/projecthamster/hamster-shell-extension/pulls/comments/174740764"},"html":{"href":"https://github.com/projecthamster/hamster-shell-extension/pull/242#discussion_r174740764"},"pull_request":{"href":"https://api.github.com/repos/projecthamster/hamster-shell-extension/pulls/242"}}},"pull_request":{"url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/pulls/242","id":175189086,"html_url":"https://github.com/projecthamster/hamster-shell-extension/pull/242","diff_url":"https://github.com/projecthamster/hamster-shell-extension/pull/242.diff","patch_url":"https://github.com/projecthamster/hamster-shell-extension/pull/242.patch","issue_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/issues/242","number":242,"state":"open","locked":false,"title":"Fix more \"user after destroy\" problems","user":{"login":"rhertzog","id":1013915,"avatar_url":"https://avatars1.githubusercontent.com/u/1013915?v=4","gravatar_id":"","url":"https://api.github.com/users/rhertzog","html_url":"https://github.com/rhertzog","followers_url":"https://api.github.com/users/rhertzog/followers","following_url":"https://api.github.com/users/rhertzog/following{/other_user}","gists_url":"https://api.github.com/users/rhertzog/gists{/gist_id}","starred_url":"https://api.github.com/users/rhertzog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhertzog/subscriptions","organizations_url":"https://api.github.com/users/rhertzog/orgs","repos_url":"https://api.github.com/users/rhertzog/repos","events_url":"https://api.github.com/users/rhertzog/events{/privacy}","received_events_url":"https://api.github.com/users/rhertzog/received_events","type":"User","site_admin":false},"body":"Explicitly drop our widget from the panel before destroying it\r\nto ensure that nobody is using it when we are calling ``destroy()``\r\non it.\r\n\r\nDrop the calls to ``Main.panel.menuManager.removeMenu()`` and\r\n``this.panelWidget.actor.destroy`` as they both happen already\r\nautomatically when we destroy our panelWidget. And since we did\r\nnot reset ``this.panelWidget.actor`` to null, it would try to\r\naccess it to call ``destroy()`` on it.\r\n\r\nMove the ``GLib.source_remove()`` call in the same file as\r\nits counterparts ``GLib.timeout_add_seconds()`` call for better\r\nencapsulation of the logic.","created_at":"2018-03-15T09:21:54Z","updated_at":"2018-03-15T10:46:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ed241eb90e40ac025a5e8fe5e13c139eec17f6a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/pulls/242/commits","review_comments_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/pulls/242/comments","review_comment_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/issues/242/comments","statuses_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/statuses/2432a9c1be56c4bb9559f05cc4a3317c3cba10b6","head":{"label":"rhertzog:my-fixes","ref":"my-fixes","sha":"2432a9c1be56c4bb9559f05cc4a3317c3cba10b6","user":{"login":"rhertzog","id":1013915,"avatar_url":"https://avatars1.githubusercontent.com/u/1013915?v=4","gravatar_id":"","url":"https://api.github.com/users/rhertzog","html_url":"https://github.com/rhertzog","followers_url":"https://api.github.com/users/rhertzog/followers","following_url":"https://api.github.com/users/rhertzog/following{/other_user}","gists_url":"https://api.github.com/users/rhertzog/gists{/gist_id}","starred_url":"https://api.github.com/users/rhertzog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhertzog/subscriptions","organizations_url":"https://api.github.com/users/rhertzog/orgs","repos_url":"https://api.github.com/users/rhertzog/repos","events_url":"https://api.github.com/users/rhertzog/events{/privacy}","received_events_url":"https://api.github.com/users/rhertzog/received_events","type":"User","site_admin":false},"repo":{"id":124451596,"name":"hamster-shell-extension","full_name":"rhertzog/hamster-shell-extension","owner":{"login":"rhertzog","id":1013915,"avatar_url":"https://avatars1.githubusercontent.com/u/1013915?v=4","gravatar_id":"","url":"https://api.github.com/users/rhertzog","html_url":"https://github.com/rhertzog","followers_url":"https://api.github.com/users/rhertzog/followers","following_url":"https://api.github.com/users/rhertzog/following{/other_user}","gists_url":"https://api.github.com/users/rhertzog/gists{/gist_id}","starred_url":"https://api.github.com/users/rhertzog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhertzog/subscriptions","organizations_url":"https://api.github.com/users/rhertzog/orgs","repos_url":"https://api.github.com/users/rhertzog/repos","events_url":"https://api.github.com/users/rhertzog/events{/privacy}","received_events_url":"https://api.github.com/users/rhertzog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rhertzog/hamster-shell-extension","description":"Shell extension for hamster","fork":true,"url":"https://api.github.com/repos/rhertzog/hamster-shell-extension","forks_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/forks","keys_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/teams","hooks_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/hooks","issue_events_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/issues/events{/number}","events_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/events","assignees_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/assignees{/user}","branches_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/branches{/branch}","tags_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/tags","blobs_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/statuses/{sha}","languages_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/languages","stargazers_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/stargazers","contributors_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/contributors","subscribers_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/subscribers","subscription_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/subscription","commits_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/contents/{+path}","compare_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/merges","archive_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/downloads","issues_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/issues{/number}","pulls_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/pulls{/number}","milestones_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/milestones{/number}","notifications_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/labels{/name}","releases_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/releases{/id}","deployments_url":"https://api.github.com/repos/rhertzog/hamster-shell-extension/deployments","created_at":"2018-03-08T21:43:50Z","updated_at":"2018-03-08T21:43:53Z","pushed_at":"2018-03-15T09:20:29Z","git_url":"git://github.com/rhertzog/hamster-shell-extension.git","ssh_url":"git@github.com:rhertzog/hamster-shell-extension.git","clone_url":"https://github.com/rhertzog/hamster-shell-extension.git","svn_url":"https://github.com/rhertzog/hamster-shell-extension","homepage":"http://projecthamster.org","size":433,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"projecthamster:develop","ref":"develop","sha":"eb45703f5f5b169acc5c6a04fcb7fd6bb26c8fbf","user":{"login":"projecthamster","id":2337710,"avatar_url":"https://avatars2.githubusercontent.com/u/2337710?v=4","gravatar_id":"","url":"https://api.github.com/users/projecthamster","html_url":"https://github.com/projecthamster","followers_url":"https://api.github.com/users/projecthamster/followers","following_url":"https://api.github.com/users/projecthamster/following{/other_user}","gists_url":"https://api.github.com/users/projecthamster/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthamster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthamster/subscriptions","organizations_url":"https://api.github.com/users/projecthamster/orgs","repos_url":"https://api.github.com/users/projecthamster/repos","events_url":"https://api.github.com/users/projecthamster/events{/privacy}","received_events_url":"https://api.github.com/users/projecthamster/received_events","type":"Organization","site_admin":false},"repo":{"id":2049065,"name":"hamster-shell-extension","full_name":"projecthamster/hamster-shell-extension","owner":{"login":"projecthamster","id":2337710,"avatar_url":"https://avatars2.githubusercontent.com/u/2337710?v=4","gravatar_id":"","url":"https://api.github.com/users/projecthamster","html_url":"https://github.com/projecthamster","followers_url":"https://api.github.com/users/projecthamster/followers","following_url":"https://api.github.com/users/projecthamster/following{/other_user}","gists_url":"https://api.github.com/users/projecthamster/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthamster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthamster/subscriptions","organizations_url":"https://api.github.com/users/projecthamster/orgs","repos_url":"https://api.github.com/users/projecthamster/repos","events_url":"https://api.github.com/users/projecthamster/events{/privacy}","received_events_url":"https://api.github.com/users/projecthamster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projecthamster/hamster-shell-extension","description":"Shell extension for hamster","fork":false,"url":"https://api.github.com/repos/projecthamster/hamster-shell-extension","forks_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/forks","keys_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/teams","hooks_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/hooks","issue_events_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/issues/events{/number}","events_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/events","assignees_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/assignees{/user}","branches_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/branches{/branch}","tags_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/tags","blobs_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/git/refs{/sha}","trees_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/statuses/{sha}","languages_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/languages","stargazers_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/stargazers","contributors_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/contributors","subscribers_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/subscribers","subscription_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/subscription","commits_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/commits{/sha}","git_commits_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/git/commits{/sha}","comments_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/comments{/number}","issue_comment_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/issues/comments{/number}","contents_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/contents/{+path}","compare_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/merges","archive_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/downloads","issues_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/issues{/number}","pulls_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/pulls{/number}","milestones_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/milestones{/number}","notifications_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/labels{/name}","releases_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/releases{/id}","deployments_url":"https://api.github.com/repos/projecthamster/hamster-shell-extension/deployments","created_at":"2011-07-14T18:51:32Z","updated_at":"2018-03-14T14:43:32Z","pushed_at":"2018-03-15T09:21:55Z","git_url":"git://github.com/projecthamster/hamster-shell-extension.git","ssh_url":"git@github.com:projecthamster/hamster-shell-extension.git","clone_url":"https://github.com/projecthamster/hamster-shell-extension.git","svn_url":"https://github.com/projecthamster/hamster-shell-extension","homepage":"http://projecthamster.org","size":448,"stargazers_count":155,"watchers_count":155,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":62,"open_issues":31,"watchers":155,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/projecthamster/hamster-shell-extension/pulls/242"},"html":{"href":"https://github.com/projecthamster/hamster-shell-extension/pull/242"},"issue":{"href":"https://api.github.com/repos/projecthamster/hamster-shell-extension/issues/242"},"comments":{"href":"https://api.github.com/repos/projecthamster/hamster-shell-extension/issues/242/comments"},"review_comments":{"href":"https://api.github.com/repos/projecthamster/hamster-shell-extension/pulls/242/comments"},"review_comment":{"href":"https://api.github.com/repos/projecthamster/hamster-shell-extension/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projecthamster/hamster-shell-extension/pulls/242/commits"},"statuses":{"href":"https://api.github.com/repos/projecthamster/hamster-shell-extension/statuses/2432a9c1be56c4bb9559f05cc4a3317c3cba10b6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"elbenfreund"}}