{"action":"created","comment":{"url":"https://api.github.com/repos/nipy/heudiconv/pulls/comments/177777944","pull_request_review_id":107713044,"id":177777944,"diff_hunk":"@@ -390,12 +390,13 @@ def nipype_convert(item_dicoms, prefix, with_prov, bids, tmpdir):\n \n     item_dicoms = list(map(op.abspath, item_dicoms)) # absolute paths\n \n+    dicom_dir = op.dirname(item_dicoms[0]) if item_dicoms else None\n+\n     convertnode = Node(Dcm2niix(), name='convert')\n     convertnode.base_dir = tmpdir\n-    convertnode.inputs.source_names = item_dicoms\n+    convertnode.inputs.source_dir = dicom_dir","path":"heudiconv/convert.py","position":9,"original_position":9,"commit_id":"1be1c15eebdc6ba73279da96c8357aa214a2b7cd","original_commit_id":"1be1c15eebdc6ba73279da96c8357aa214a2b7cd","user":{"login":"yarikoptic","id":39889,"avatar_url":"https://avatars3.githubusercontent.com/u/39889?v=4","gravatar_id":"","url":"https://api.github.com/users/yarikoptic","html_url":"https://github.com/yarikoptic","followers_url":"https://api.github.com/users/yarikoptic/followers","following_url":"https://api.github.com/users/yarikoptic/following{/other_user}","gists_url":"https://api.github.com/users/yarikoptic/gists{/gist_id}","starred_url":"https://api.github.com/users/yarikoptic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarikoptic/subscriptions","organizations_url":"https://api.github.com/users/yarikoptic/orgs","repos_url":"https://api.github.com/users/yarikoptic/repos","events_url":"https://api.github.com/users/yarikoptic/events{/privacy}","received_events_url":"https://api.github.com/users/yarikoptic/received_events","type":"User","site_admin":false},"body":"would it work with older nipype?","created_at":"2018-03-28T14:51:59Z","updated_at":"2018-03-28T14:51:59Z","html_url":"https://github.com/nipy/heudiconv/pull/185#discussion_r177777944","pull_request_url":"https://api.github.com/repos/nipy/heudiconv/pulls/185","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/nipy/heudiconv/pulls/comments/177777944"},"html":{"href":"https://github.com/nipy/heudiconv/pull/185#discussion_r177777944"},"pull_request":{"href":"https://api.github.com/repos/nipy/heudiconv/pulls/185"}}},"pull_request":{"url":"https://api.github.com/repos/nipy/heudiconv/pulls/185","id":178064191,"html_url":"https://github.com/nipy/heudiconv/pull/185","diff_url":"https://github.com/nipy/heudiconv/pull/185.diff","patch_url":"https://github.com/nipy/heudiconv/pull/185.patch","issue_url":"https://api.github.com/repos/nipy/heudiconv/issues/185","number":185,"state":"open","locked":false,"title":"fix: use source_dir instead","user":{"login":"mgxd","id":14110164,"avatar_url":"https://avatars1.githubusercontent.com/u/14110164?v=4","gravatar_id":"","url":"https://api.github.com/users/mgxd","html_url":"https://github.com/mgxd","followers_url":"https://api.github.com/users/mgxd/followers","following_url":"https://api.github.com/users/mgxd/following{/other_user}","gists_url":"https://api.github.com/users/mgxd/gists{/gist_id}","starred_url":"https://api.github.com/users/mgxd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgxd/subscriptions","organizations_url":"https://api.github.com/users/mgxd/orgs","repos_url":"https://api.github.com/users/mgxd/repos","events_url":"https://api.github.com/users/mgxd/events{/privacy}","received_events_url":"https://api.github.com/users/mgxd/received_events","type":"User","site_admin":false},"body":"The call to `Dcm2niix` was passing in `source_names`, which was essentially being treated as `source_dir` anyways under the hood.","created_at":"2018-03-28T14:48:30Z","updated_at":"2018-03-28T14:51:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae25f45eee8244f82f74edeef2229d2cd43268b6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nipy/heudiconv/pulls/185/commits","review_comments_url":"https://api.github.com/repos/nipy/heudiconv/pulls/185/comments","review_comment_url":"https://api.github.com/repos/nipy/heudiconv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nipy/heudiconv/issues/185/comments","statuses_url":"https://api.github.com/repos/nipy/heudiconv/statuses/1be1c15eebdc6ba73279da96c8357aa214a2b7cd","head":{"label":"mgxd:fix/nipype-1.0.2","ref":"fix/nipype-1.0.2","sha":"1be1c15eebdc6ba73279da96c8357aa214a2b7cd","user":{"login":"mgxd","id":14110164,"avatar_url":"https://avatars1.githubusercontent.com/u/14110164?v=4","gravatar_id":"","url":"https://api.github.com/users/mgxd","html_url":"https://github.com/mgxd","followers_url":"https://api.github.com/users/mgxd/followers","following_url":"https://api.github.com/users/mgxd/following{/other_user}","gists_url":"https://api.github.com/users/mgxd/gists{/gist_id}","starred_url":"https://api.github.com/users/mgxd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgxd/subscriptions","organizations_url":"https://api.github.com/users/mgxd/orgs","repos_url":"https://api.github.com/users/mgxd/repos","events_url":"https://api.github.com/users/mgxd/events{/privacy}","received_events_url":"https://api.github.com/users/mgxd/received_events","type":"User","site_admin":false},"repo":{"id":45866240,"name":"heudiconv","full_name":"mgxd/heudiconv","owner":{"login":"mgxd","id":14110164,"avatar_url":"https://avatars1.githubusercontent.com/u/14110164?v=4","gravatar_id":"","url":"https://api.github.com/users/mgxd","html_url":"https://github.com/mgxd","followers_url":"https://api.github.com/users/mgxd/followers","following_url":"https://api.github.com/users/mgxd/following{/other_user}","gists_url":"https://api.github.com/users/mgxd/gists{/gist_id}","starred_url":"https://api.github.com/users/mgxd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgxd/subscriptions","organizations_url":"https://api.github.com/users/mgxd/orgs","repos_url":"https://api.github.com/users/mgxd/repos","events_url":"https://api.github.com/users/mgxd/events{/privacy}","received_events_url":"https://api.github.com/users/mgxd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mgxd/heudiconv","description":"little helper to ease DICOM conversion to ready-to-share folder with heuristics","fork":true,"url":"https://api.github.com/repos/mgxd/heudiconv","forks_url":"https://api.github.com/repos/mgxd/heudiconv/forks","keys_url":"https://api.github.com/repos/mgxd/heudiconv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mgxd/heudiconv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mgxd/heudiconv/teams","hooks_url":"https://api.github.com/repos/mgxd/heudiconv/hooks","issue_events_url":"https://api.github.com/repos/mgxd/heudiconv/issues/events{/number}","events_url":"https://api.github.com/repos/mgxd/heudiconv/events","assignees_url":"https://api.github.com/repos/mgxd/heudiconv/assignees{/user}","branches_url":"https://api.github.com/repos/mgxd/heudiconv/branches{/branch}","tags_url":"https://api.github.com/repos/mgxd/heudiconv/tags","blobs_url":"https://api.github.com/repos/mgxd/heudiconv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mgxd/heudiconv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mgxd/heudiconv/git/refs{/sha}","trees_url":"https://api.github.com/repos/mgxd/heudiconv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mgxd/heudiconv/statuses/{sha}","languages_url":"https://api.github.com/repos/mgxd/heudiconv/languages","stargazers_url":"https://api.github.com/repos/mgxd/heudiconv/stargazers","contributors_url":"https://api.github.com/repos/mgxd/heudiconv/contributors","subscribers_url":"https://api.github.com/repos/mgxd/heudiconv/subscribers","subscription_url":"https://api.github.com/repos/mgxd/heudiconv/subscription","commits_url":"https://api.github.com/repos/mgxd/heudiconv/commits{/sha}","git_commits_url":"https://api.github.com/repos/mgxd/heudiconv/git/commits{/sha}","comments_url":"https://api.github.com/repos/mgxd/heudiconv/comments{/number}","issue_comment_url":"https://api.github.com/repos/mgxd/heudiconv/issues/comments{/number}","contents_url":"https://api.github.com/repos/mgxd/heudiconv/contents/{+path}","compare_url":"https://api.github.com/repos/mgxd/heudiconv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mgxd/heudiconv/merges","archive_url":"https://api.github.com/repos/mgxd/heudiconv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mgxd/heudiconv/downloads","issues_url":"https://api.github.com/repos/mgxd/heudiconv/issues{/number}","pulls_url":"https://api.github.com/repos/mgxd/heudiconv/pulls{/number}","milestones_url":"https://api.github.com/repos/mgxd/heudiconv/milestones{/number}","notifications_url":"https://api.github.com/repos/mgxd/heudiconv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mgxd/heudiconv/labels{/name}","releases_url":"https://api.github.com/repos/mgxd/heudiconv/releases{/id}","deployments_url":"https://api.github.com/repos/mgxd/heudiconv/deployments","created_at":"2015-11-09T20:56:06Z","updated_at":"2016-05-05T15:16:29Z","pushed_at":"2018-03-28T14:46:13Z","git_url":"git://github.com/mgxd/heudiconv.git","ssh_url":"git@github.com:mgxd/heudiconv.git","clone_url":"https://github.com/mgxd/heudiconv.git","svn_url":"https://github.com/mgxd/heudiconv","homepage":null,"size":828,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nipy:master","ref":"master","sha":"0808afff1e643196ef5069cbf41644c9ee28ebd8","user":{"login":"nipy","id":233707,"avatar_url":"https://avatars2.githubusercontent.com/u/233707?v=4","gravatar_id":"","url":"https://api.github.com/users/nipy","html_url":"https://github.com/nipy","followers_url":"https://api.github.com/users/nipy/followers","following_url":"https://api.github.com/users/nipy/following{/other_user}","gists_url":"https://api.github.com/users/nipy/gists{/gist_id}","starred_url":"https://api.github.com/users/nipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nipy/subscriptions","organizations_url":"https://api.github.com/users/nipy/orgs","repos_url":"https://api.github.com/users/nipy/repos","events_url":"https://api.github.com/users/nipy/events{/privacy}","received_events_url":"https://api.github.com/users/nipy/received_events","type":"Organization","site_admin":false},"repo":{"id":42650211,"name":"heudiconv","full_name":"nipy/heudiconv","owner":{"login":"nipy","id":233707,"avatar_url":"https://avatars2.githubusercontent.com/u/233707?v=4","gravatar_id":"","url":"https://api.github.com/users/nipy","html_url":"https://github.com/nipy","followers_url":"https://api.github.com/users/nipy/followers","following_url":"https://api.github.com/users/nipy/following{/other_user}","gists_url":"https://api.github.com/users/nipy/gists{/gist_id}","starred_url":"https://api.github.com/users/nipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nipy/subscriptions","organizations_url":"https://api.github.com/users/nipy/orgs","repos_url":"https://api.github.com/users/nipy/repos","events_url":"https://api.github.com/users/nipy/events{/privacy}","received_events_url":"https://api.github.com/users/nipy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nipy/heudiconv","description":"A flexible DICOM converter for organizing brain imaging data into structured directory layouts","fork":false,"url":"https://api.github.com/repos/nipy/heudiconv","forks_url":"https://api.github.com/repos/nipy/heudiconv/forks","keys_url":"https://api.github.com/repos/nipy/heudiconv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nipy/heudiconv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nipy/heudiconv/teams","hooks_url":"https://api.github.com/repos/nipy/heudiconv/hooks","issue_events_url":"https://api.github.com/repos/nipy/heudiconv/issues/events{/number}","events_url":"https://api.github.com/repos/nipy/heudiconv/events","assignees_url":"https://api.github.com/repos/nipy/heudiconv/assignees{/user}","branches_url":"https://api.github.com/repos/nipy/heudiconv/branches{/branch}","tags_url":"https://api.github.com/repos/nipy/heudiconv/tags","blobs_url":"https://api.github.com/repos/nipy/heudiconv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nipy/heudiconv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nipy/heudiconv/git/refs{/sha}","trees_url":"https://api.github.com/repos/nipy/heudiconv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nipy/heudiconv/statuses/{sha}","languages_url":"https://api.github.com/repos/nipy/heudiconv/languages","stargazers_url":"https://api.github.com/repos/nipy/heudiconv/stargazers","contributors_url":"https://api.github.com/repos/nipy/heudiconv/contributors","subscribers_url":"https://api.github.com/repos/nipy/heudiconv/subscribers","subscription_url":"https://api.github.com/repos/nipy/heudiconv/subscription","commits_url":"https://api.github.com/repos/nipy/heudiconv/commits{/sha}","git_commits_url":"https://api.github.com/repos/nipy/heudiconv/git/commits{/sha}","comments_url":"https://api.github.com/repos/nipy/heudiconv/comments{/number}","issue_comment_url":"https://api.github.com/repos/nipy/heudiconv/issues/comments{/number}","contents_url":"https://api.github.com/repos/nipy/heudiconv/contents/{+path}","compare_url":"https://api.github.com/repos/nipy/heudiconv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nipy/heudiconv/merges","archive_url":"https://api.github.com/repos/nipy/heudiconv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nipy/heudiconv/downloads","issues_url":"https://api.github.com/repos/nipy/heudiconv/issues{/number}","pulls_url":"https://api.github.com/repos/nipy/heudiconv/pulls{/number}","milestones_url":"https://api.github.com/repos/nipy/heudiconv/milestones{/number}","notifications_url":"https://api.github.com/repos/nipy/heudiconv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nipy/heudiconv/labels{/name}","releases_url":"https://api.github.com/repos/nipy/heudiconv/releases{/id}","deployments_url":"https://api.github.com/repos/nipy/heudiconv/deployments","created_at":"2015-09-17T10:34:11Z","updated_at":"2018-03-27T17:08:44Z","pushed_at":"2018-03-28T14:48:31Z","git_url":"git://github.com/nipy/heudiconv.git","ssh_url":"git@github.com:nipy/heudiconv.git","clone_url":"https://github.com/nipy/heudiconv.git","svn_url":"https://github.com/nipy/heudiconv","homepage":"http://nipy.org/heudiconv","size":877,"stargazers_count":41,"watchers_count":41,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":51,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":37,"open_issues":51,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nipy/heudiconv/pulls/185"},"html":{"href":"https://github.com/nipy/heudiconv/pull/185"},"issue":{"href":"https://api.github.com/repos/nipy/heudiconv/issues/185"},"comments":{"href":"https://api.github.com/repos/nipy/heudiconv/issues/185/comments"},"review_comments":{"href":"https://api.github.com/repos/nipy/heudiconv/pulls/185/comments"},"review_comment":{"href":"https://api.github.com/repos/nipy/heudiconv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nipy/heudiconv/pulls/185/commits"},"statuses":{"href":"https://api.github.com/repos/nipy/heudiconv/statuses/1be1c15eebdc6ba73279da96c8357aa214a2b7cd"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"yarikoptic"}}