{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/vscode-react-native/pulls/comments/204439663","pull_request_review_id":139520654,"id":204439663,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDQzOTY2Mw==","diff_hunk":"@@ -3,8 +3,12 @@\n \n import * as Q from \"q\";\n \n-import {ChildProcess} from \"../../common/node/childProcess\";\n+import { ChildProcess, ISpawnResult } from \"../../common/node/childProcess\";\n import {CommandExecutor} from \"../../common/commandExecutor\";\n+import * as path from \"path\";\n+import { FileSystem } from \"../../common/node/fileSystem\";\n+import { ILogger } from \"../log/LogHelper\";\n+const fs = new FileSystem();","path":"src/extension/android/adb.ts","position":10,"original_position":10,"commit_id":"85c625d30da82ad693f52a9687be87615ca5154e","original_commit_id":"85c625d30da82ad693f52a9687be87615ca5154e","user":{"login":"ruslan-bikkinin","id":30265843,"node_id":"MDQ6VXNlcjMwMjY1ODQz","avatar_url":"https://avatars2.githubusercontent.com/u/30265843?v=4","gravatar_id":"","url":"https://api.github.com/users/ruslan-bikkinin","html_url":"https://github.com/ruslan-bikkinin","followers_url":"https://api.github.com/users/ruslan-bikkinin/followers","following_url":"https://api.github.com/users/ruslan-bikkinin/following{/other_user}","gists_url":"https://api.github.com/users/ruslan-bikkinin/gists{/gist_id}","starred_url":"https://api.github.com/users/ruslan-bikkinin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruslan-bikkinin/subscriptions","organizations_url":"https://api.github.com/users/ruslan-bikkinin/orgs","repos_url":"https://api.github.com/users/ruslan-bikkinin/repos","events_url":"https://api.github.com/users/ruslan-bikkinin/events{/privacy}","received_events_url":"https://api.github.com/users/ruslan-bikkinin/received_events","type":"User","site_admin":false},"body":"@iTOYS Because we need some methods not from core `fs` module, but from util module `fileSystem`.","created_at":"2018-07-23T15:12:39Z","updated_at":"2018-07-23T15:12:39Z","html_url":"https://github.com/Microsoft/vscode-react-native/pull/754#discussion_r204439663","pull_request_url":"https://api.github.com/repos/Microsoft/vscode-react-native/pulls/754","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-react-native/pulls/comments/204439663"},"html":{"href":"https://github.com/Microsoft/vscode-react-native/pull/754#discussion_r204439663"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/vscode-react-native/pulls/754"}},"in_reply_to_id":204397629},"pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode-react-native/pulls/754","id":203165560,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMTY1NTYw","html_url":"https://github.com/Microsoft/vscode-react-native/pull/754","diff_url":"https://github.com/Microsoft/vscode-react-native/pull/754.diff","patch_url":"https://github.com/Microsoft/vscode-react-native/pull/754.patch","issue_url":"https://api.github.com/repos/Microsoft/vscode-react-native/issues/754","number":754,"state":"open","locked":false,"title":"[Android] Add reading SDK location from local.properties","user":{"login":"ruslan-bikkinin","id":30265843,"node_id":"MDQ6VXNlcjMwMjY1ODQz","avatar_url":"https://avatars2.githubusercontent.com/u/30265843?v=4","gravatar_id":"","url":"https://api.github.com/users/ruslan-bikkinin","html_url":"https://github.com/ruslan-bikkinin","followers_url":"https://api.github.com/users/ruslan-bikkinin/followers","following_url":"https://api.github.com/users/ruslan-bikkinin/following{/other_user}","gists_url":"https://api.github.com/users/ruslan-bikkinin/gists{/gist_id}","starred_url":"https://api.github.com/users/ruslan-bikkinin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruslan-bikkinin/subscriptions","organizations_url":"https://api.github.com/users/ruslan-bikkinin/orgs","repos_url":"https://api.github.com/users/ruslan-bikkinin/repos","events_url":"https://api.github.com/users/ruslan-bikkinin/events{/privacy}","received_events_url":"https://api.github.com/users/ruslan-bikkinin/received_events","type":"User","site_admin":false},"body":"This PR add ability to use Android SDK location defined in `sdk.dir` at `android/local.properties` if exists.\r\n\r\nRelates to #688.","created_at":"2018-07-23T09:51:43Z","updated_at":"2018-07-23T15:12:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e453b2166bd8a853a2db0fd238ca06fbd0988e12","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":831015511,"node_id":"MDU6TGFiZWw4MzEwMTU1MTE=","url":"https://api.github.com/repos/Microsoft/vscode-react-native/labels/android","name":"android","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vscode-react-native/pulls/754/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vscode-react-native/pulls/754/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vscode-react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vscode-react-native/issues/754/comments","statuses_url":"https://api.github.com/repos/Microsoft/vscode-react-native/statuses/85c625d30da82ad693f52a9687be87615ca5154e","head":{"label":"Microsoft:feature/local-properties","ref":"feature/local-properties","sha":"85c625d30da82ad693f52a9687be87615ca5154e","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":50060429,"node_id":"MDEwOlJlcG9zaXRvcnk1MDA2MDQyOQ==","name":"vscode-react-native","full_name":"Microsoft/vscode-react-native","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vscode-react-native","description":"VSCode extension for react native - supports syntax highlighting, debugging and editor integration","fork":false,"url":"https://api.github.com/repos/Microsoft/vscode-react-native","forks_url":"https://api.github.com/repos/Microsoft/vscode-react-native/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode-react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode-react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode-react-native/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode-react-native/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode-react-native/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode-react-native/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode-react-native/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode-react-native/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode-react-native/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode-react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode-react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode-react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode-react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode-react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode-react-native/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode-react-native/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode-react-native/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode-react-native/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode-react-native/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode-react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode-react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode-react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode-react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode-react-native/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode-react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode-react-native/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode-react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode-react-native/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode-react-native/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode-react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode-react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode-react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode-react-native/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode-react-native/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode-react-native/deployments","created_at":"2016-01-20T21:10:07Z","updated_at":"2018-07-23T09:40:07Z","pushed_at":"2018-07-23T10:02:42Z","git_url":"git://github.com/Microsoft/vscode-react-native.git","ssh_url":"git@github.com:Microsoft/vscode-react-native.git","clone_url":"https://github.com/Microsoft/vscode-react-native.git","svn_url":"https://github.com/Microsoft/vscode-react-native","homepage":"https://marketplace.visualstudio.com/items?itemName=vsmobile.vscode-react-native","size":5642,"stargazers_count":1590,"watchers_count":1590,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":133,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":133,"open_issues":5,"watchers":1590,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"77b86bfc8c4ae64d6ea90a1cc3ebe2f8cf492d68","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":50060429,"node_id":"MDEwOlJlcG9zaXRvcnk1MDA2MDQyOQ==","name":"vscode-react-native","full_name":"Microsoft/vscode-react-native","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vscode-react-native","description":"VSCode extension for react native - supports syntax highlighting, debugging and editor integration","fork":false,"url":"https://api.github.com/repos/Microsoft/vscode-react-native","forks_url":"https://api.github.com/repos/Microsoft/vscode-react-native/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode-react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode-react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode-react-native/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode-react-native/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode-react-native/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode-react-native/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode-react-native/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode-react-native/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode-react-native/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode-react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode-react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode-react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode-react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode-react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode-react-native/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode-react-native/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode-react-native/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode-react-native/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode-react-native/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode-react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode-react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode-react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode-react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode-react-native/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode-react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode-react-native/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode-react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode-react-native/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode-react-native/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode-react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode-react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode-react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode-react-native/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode-react-native/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode-react-native/deployments","created_at":"2016-01-20T21:10:07Z","updated_at":"2018-07-23T09:40:07Z","pushed_at":"2018-07-23T10:02:42Z","git_url":"git://github.com/Microsoft/vscode-react-native.git","ssh_url":"git@github.com:Microsoft/vscode-react-native.git","clone_url":"https://github.com/Microsoft/vscode-react-native.git","svn_url":"https://github.com/Microsoft/vscode-react-native","homepage":"https://marketplace.visualstudio.com/items?itemName=vsmobile.vscode-react-native","size":5642,"stargazers_count":1590,"watchers_count":1590,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":133,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":133,"open_issues":5,"watchers":1590,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-react-native/pulls/754"},"html":{"href":"https://github.com/Microsoft/vscode-react-native/pull/754"},"issue":{"href":"https://api.github.com/repos/Microsoft/vscode-react-native/issues/754"},"comments":{"href":"https://api.github.com/repos/Microsoft/vscode-react-native/issues/754/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vscode-react-native/pulls/754/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vscode-react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vscode-react-native/pulls/754/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vscode-react-native/statuses/85c625d30da82ad693f52a9687be87615ca5154e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ruslan-bikkinin"}}