{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/33728","repository_url":"https://api.github.com/repos/owncloud/core","labels_url":"https://api.github.com/repos/owncloud/core/issues/33728/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/33728/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/33728/events","html_url":"https://github.com/owncloud/core/pull/33728","id":386830503,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NDU2ODky","number":33728,"title":"Members of excluded groups should not get any information about sharees","user":{"login":"micbar","id":4378513,"node_id":"MDQ6VXNlcjQzNzg1MTM=","avatar_url":"https://avatars0.githubusercontent.com/u/4378513?v=4","gravatar_id":"","url":"https://api.github.com/users/micbar","html_url":"https://github.com/micbar","followers_url":"https://api.github.com/users/micbar/followers","following_url":"https://api.github.com/users/micbar/following{/other_user}","gists_url":"https://api.github.com/users/micbar/gists{/gist_id}","starred_url":"https://api.github.com/users/micbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micbar/subscriptions","organizations_url":"https://api.github.com/users/micbar/orgs","repos_url":"https://api.github.com/users/micbar/repos","events_url":"https://api.github.com/users/micbar/events{/privacy}","received_events_url":"https://api.github.com/users/micbar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-03T14:00:03Z","updated_at":"2018-12-03T14:45:06Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/33728","html_url":"https://github.com/owncloud/core/pull/33728","diff_url":"https://github.com/owncloud/core/pull/33728.diff","patch_url":"https://github.com/owncloud/core/pull/33728.patch"},"body":"\r\n## Description\r\nOriginal issue https://github.com/owncloud/enterprise/issues/3024\r\n\r\nMembers of excluded groups should not get any information about sharees. They cannot use the autocomplete field in the UI, but directly using the api works.\r\n\r\n## Related Issue\r\n\r\n\r\n## Motivation and Context\r\nMembers of excluded groups should not get any information about sharees. This is a privacy issue.\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\nLocal Test:\r\n- Create User 1:\r\n- Create Group \"restricted\":\r\n- Make User 1 member of group \"restricted\"\r\n- Try to call `http://localhost/ocs/v1.php/apps/files_sharing/api/v1/sharees?format=json&search=admin&perPage=400&itemType=file`\r\n- Result should return no users\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n- [x] Technical debt\r\n- [ ] Tests\r\n\r\n## Checklist:\r\n<!-- Tick the checkboxes when done. -->\r\n<!-- Raise documentation ticket in https://github.com/owncloud/documentation -->\r\n- [x] Code changes\r\n- [ ] Unit tests added\r\n- [ ] Acceptance tests added\r\n- [ ] Documentation ticket raised: <link> \r\n\r\n## Open tasks:\r\n<!-- In case of incomplete PR, please list the open tasks here -->\r\n- [ ] Backport (if applicable set \"backport-request\" label and remove when the backport was done)\r\n"},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/443734171","html_url":"https://github.com/owncloud/core/pull/33728#issuecomment-443734171","issue_url":"https://api.github.com/repos/owncloud/core/issues/33728","id":443734171,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzczNDE3MQ==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-12-03T14:45:06Z","updated_at":"2018-12-03T14:45:06Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/owncloud/core/pull/33728?src=pr&el=h1) Report\n> Merging [#33728](https://codecov.io/gh/owncloud/core/pull/33728?src=pr&el=desc) into [master](https://codecov.io/gh/owncloud/core/commit/1947c926dd803c413cb19b9b6af4f5786fc2dbf4?src=pr&el=desc) will **decrease** coverage by `15.87%`.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/owncloud/core/pull/33728/graphs/tree.svg?width=650&token=bvPvzqol8M&height=150&src=pr)](https://codecov.io/gh/owncloud/core/pull/33728?src=pr&el=tree)\n\n```diff\n@@              Coverage Diff              @@\n##             master   #33728       +/-   ##\n=============================================\n- Coverage     64.35%   48.47%   -15.88%     \n=============================================\n  Files          1195      109     -1086     \n  Lines         69240    10498    -58742     \n  Branches       1276     1276               \n=============================================\n- Hits          44560     5089    -39471     \n+ Misses        24308     5037    -19271     \n  Partials        372      372\n```\n\n| Flag | Coverage Δ | Complexity Δ | |\n|---|---|---|---|\n| #javascript | `52.98% <ø> (ø)` | `0 <ø> (ø)` | :arrow_down: |\n| #phpunit | `38.67% <ø> (-27%)` | `0 <ø> (-18307)` | |\n\n| [Impacted Files](https://codecov.io/gh/owncloud/core/pull/33728?src=pr&el=tree) | Coverage Δ | Complexity Δ | |\n|---|---|---|---|\n| [lib/private/Files/Storage/DAV.php](https://codecov.io/gh/owncloud/core/pull/33728/diff?src=pr&el=tree#diff-bGliL3ByaXZhdGUvRmlsZXMvU3RvcmFnZS9EQVYucGhw) | `59.45% <0%> (-21.64%)` | `0% <0%> (ø)` | |\n| [apps/updatenotification/templates/admin.php](https://codecov.io/gh/owncloud/core/pull/33728/diff?src=pr&el=tree#diff-YXBwcy91cGRhdGVub3RpZmljYXRpb24vdGVtcGxhdGVzL2FkbWluLnBocA==) | | | |\n| [lib/private/Encryption/Keys/Storage.php](https://codecov.io/gh/owncloud/core/pull/33728/diff?src=pr&el=tree#diff-bGliL3ByaXZhdGUvRW5jcnlwdGlvbi9LZXlzL1N0b3JhZ2UucGhw) | | | |\n| [lib/private/App/CodeChecker/NodeVisitor.php](https://codecov.io/gh/owncloud/core/pull/33728/diff?src=pr&el=tree#diff-bGliL3ByaXZhdGUvQXBwL0NvZGVDaGVja2VyL05vZGVWaXNpdG9yLnBocA==) | | | |\n| [lib/private/RedisFactory.php](https://codecov.io/gh/owncloud/core/pull/33728/diff?src=pr&el=tree#diff-bGliL3ByaXZhdGUvUmVkaXNGYWN0b3J5LnBocA==) | | | |\n| [apps/dav/lib/Avatars/AvatarNode.php](https://codecov.io/gh/owncloud/core/pull/33728/diff?src=pr&el=tree#diff-YXBwcy9kYXYvbGliL0F2YXRhcnMvQXZhdGFyTm9kZS5waHA=) | | | |\n| [...s/dav/appinfo/Migrations/Version20170202213905.php](https://codecov.io/gh/owncloud/core/pull/33728/diff?src=pr&el=tree#diff-YXBwcy9kYXYvYXBwaW5mby9NaWdyYXRpb25zL1ZlcnNpb24yMDE3MDIwMjIxMzkwNS5waHA=) | | | |\n| [apps/dav/lib/Upload/ChunkLocationProvider.php](https://codecov.io/gh/owncloud/core/pull/33728/diff?src=pr&el=tree#diff-YXBwcy9kYXYvbGliL1VwbG9hZC9DaHVua0xvY2F0aW9uUHJvdmlkZXIucGhw) | | | |\n| [apps/files/lib/AppInfo/Application.php](https://codecov.io/gh/owncloud/core/pull/33728/diff?src=pr&el=tree#diff-YXBwcy9maWxlcy9saWIvQXBwSW5mby9BcHBsaWNhdGlvbi5waHA=) | | | |\n| [apps/systemtags/list.php](https://codecov.io/gh/owncloud/core/pull/33728/diff?src=pr&el=tree#diff-YXBwcy9zeXN0ZW10YWdzL2xpc3QucGhw) | | | |\n| ... and [1077 more](https://codecov.io/gh/owncloud/core/pull/33728/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/owncloud/core/pull/33728?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/owncloud/core/pull/33728?src=pr&el=footer). Last update [1947c92...ffc9039](https://codecov.io/gh/owncloud/core/pull/33728?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}