{"action":"created","issue":{"url":"https://api.github.com/repos/Aktanusa/CookieMonster/issues/170","repository_url":"https://api.github.com/repos/Aktanusa/CookieMonster","labels_url":"https://api.github.com/repos/Aktanusa/CookieMonster/issues/170/labels{/name}","comments_url":"https://api.github.com/repos/Aktanusa/CookieMonster/issues/170/comments","events_url":"https://api.github.com/repos/Aktanusa/CookieMonster/issues/170/events","html_url":"https://github.com/Aktanusa/CookieMonster/issues/170","id":304189501,"number":170,"title":"CookieMonster doesn't accomodate customCPS and customCPSMult","user":{"login":"DJKorchinski","id":8547704,"avatar_url":"https://avatars1.githubusercontent.com/u/8547704?v=4","gravatar_id":"","url":"https://api.github.com/users/DJKorchinski","html_url":"https://github.com/DJKorchinski","followers_url":"https://api.github.com/users/DJKorchinski/followers","following_url":"https://api.github.com/users/DJKorchinski/following{/other_user}","gists_url":"https://api.github.com/users/DJKorchinski/gists{/gist_id}","starred_url":"https://api.github.com/users/DJKorchinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DJKorchinski/subscriptions","organizations_url":"https://api.github.com/users/DJKorchinski/orgs","repos_url":"https://api.github.com/users/DJKorchinski/repos","events_url":"https://api.github.com/users/DJKorchinski/events{/privacy}","received_events_url":"https://api.github.com/users/DJKorchinski/received_events","type":"User","site_admin":false},"labels":[{"id":100707319,"url":"https://api.github.com/repos/Aktanusa/CookieMonster/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"Aktanusa","id":7632881,"avatar_url":"https://avatars1.githubusercontent.com/u/7632881?v=4","gravatar_id":"","url":"https://api.github.com/users/Aktanusa","html_url":"https://github.com/Aktanusa","followers_url":"https://api.github.com/users/Aktanusa/followers","following_url":"https://api.github.com/users/Aktanusa/following{/other_user}","gists_url":"https://api.github.com/users/Aktanusa/gists{/gist_id}","starred_url":"https://api.github.com/users/Aktanusa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aktanusa/subscriptions","organizations_url":"https://api.github.com/users/Aktanusa/orgs","repos_url":"https://api.github.com/users/Aktanusa/repos","events_url":"https://api.github.com/users/Aktanusa/events{/privacy}","received_events_url":"https://api.github.com/users/Aktanusa/received_events","type":"User","site_admin":false},"assignees":[{"login":"Aktanusa","id":7632881,"avatar_url":"https://avatars1.githubusercontent.com/u/7632881?v=4","gravatar_id":"","url":"https://api.github.com/users/Aktanusa","html_url":"https://github.com/Aktanusa","followers_url":"https://api.github.com/users/Aktanusa/followers","following_url":"https://api.github.com/users/Aktanusa/following{/other_user}","gists_url":"https://api.github.com/users/Aktanusa/gists{/gist_id}","starred_url":"https://api.github.com/users/Aktanusa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aktanusa/subscriptions","organizations_url":"https://api.github.com/users/Aktanusa/orgs","repos_url":"https://api.github.com/users/Aktanusa/repos","events_url":"https://api.github.com/users/Aktanusa/events{/privacy}","received_events_url":"https://api.github.com/users/Aktanusa/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2018-03-11T20:11:32Z","updated_at":"2018-03-24T22:29:29Z","closed_at":null,"author_association":"NONE","body":"The CM.Sim.cookiesPs doesn't take into account Game.customCPS and Game.customCPSMult (see lines 3361 and 3462 respectively in main.js for version 2.0045). \r\n\r\nWhat this means in practice, is that if new kitten upgrades are added by a mod (and implemented by modifying Game.customCPSMult) cookie monster incorrectly assessing the kitten upgrades as not having any effect. "},"comment":{"url":"https://api.github.com/repos/Aktanusa/CookieMonster/issues/comments/375929561","html_url":"https://github.com/Aktanusa/CookieMonster/issues/170#issuecomment-375929561","issue_url":"https://api.github.com/repos/Aktanusa/CookieMonster/issues/170","id":375929561,"user":{"login":"Aktanusa","id":7632881,"avatar_url":"https://avatars1.githubusercontent.com/u/7632881?v=4","gravatar_id":"","url":"https://api.github.com/users/Aktanusa","html_url":"https://github.com/Aktanusa","followers_url":"https://api.github.com/users/Aktanusa/followers","following_url":"https://api.github.com/users/Aktanusa/following{/other_user}","gists_url":"https://api.github.com/users/Aktanusa/gists{/gist_id}","starred_url":"https://api.github.com/users/Aktanusa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aktanusa/subscriptions","organizations_url":"https://api.github.com/users/Aktanusa/orgs","repos_url":"https://api.github.com/users/Aktanusa/repos","events_url":"https://api.github.com/users/Aktanusa/events{/privacy}","received_events_url":"https://api.github.com/users/Aktanusa/received_events","type":"User","site_admin":false},"created_at":"2018-03-24T22:29:29Z","updated_at":"2018-03-24T22:29:29Z","author_association":"OWNER","body":"Hmm, I took a quick look.  Indeed the mod functions may use other functions which is not part of the simulated model, as noted in your comments but you only accounted for the ones your mod uses.  This is a hard solution as it's not a general solution.  It works for your mod since you know you'll be using those, but this may not work for future mods.  I don't have an answer as any mod can do anything (maybe).  I would need to look hard into this."}}
{"actor":{"display_login":"Aktanusa"}}