{"action":"created","issue":{"url":"https://api.github.com/repos/d3ledger/back-office/issues/25","repository_url":"https://api.github.com/repos/d3ledger/back-office","labels_url":"https://api.github.com/repos/d3ledger/back-office/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/d3ledger/back-office/issues/25/comments","events_url":"https://api.github.com/repos/d3ledger/back-office/issues/25/events","html_url":"https://github.com/d3ledger/back-office/pull/25","id":344933335,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MjExMjU5","number":25,"title":"[WIP] Replacing iroha-lib","user":{"login":"laSinteZ","id":10958990,"node_id":"MDQ6VXNlcjEwOTU4OTkw","avatar_url":"https://avatars0.githubusercontent.com/u/10958990?v=4","gravatar_id":"","url":"https://api.github.com/users/laSinteZ","html_url":"https://github.com/laSinteZ","followers_url":"https://api.github.com/users/laSinteZ/followers","following_url":"https://api.github.com/users/laSinteZ/following{/other_user}","gists_url":"https://api.github.com/users/laSinteZ/gists{/gist_id}","starred_url":"https://api.github.com/users/laSinteZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laSinteZ/subscriptions","organizations_url":"https://api.github.com/users/laSinteZ/orgs","repos_url":"https://api.github.com/users/laSinteZ/repos","events_url":"https://api.github.com/users/laSinteZ/events{/privacy}","received_events_url":"https://api.github.com/users/laSinteZ/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-07-26T17:20:53Z","updated_at":"2018-08-01T14:32:02Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/d3ledger/back-office/pulls/25","html_url":"https://github.com/d3ledger/back-office/pull/25","diff_url":"https://github.com/d3ledger/back-office/pull/25.diff","patch_url":"https://github.com/d3ledger/back-office/pull/25.patch"},"body":"## Ticket\r\nD3-141\r\n\r\n## Description\r\nSince iroha-lib is very large (~5-6MB bundled) and takes significant time to start, we are replacing it.\r\n\r\nI've created helper functions to build and sign Queries.\r\n\r\nPros:\r\n* Less bundle size\r\n* We will need to do this for batches anyway, since there are no builders\r\n\r\nCons:\r\n* No validation :) (although iroha will validate it)\r\n* (maybe) ugly interface\r\n\r\n@oimou please tell me what you think about it. \r\n\r\nTomorrow I will do the same for transactions and later on for Batches."},"comment":{"url":"https://api.github.com/repos/d3ledger/back-office/issues/comments/409595883","html_url":"https://github.com/d3ledger/back-office/pull/25#issuecomment-409595883","issue_url":"https://api.github.com/repos/d3ledger/back-office/issues/25","id":409595883,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTU5NTg4Mw==","user":{"login":"laSinteZ","id":10958990,"node_id":"MDQ6VXNlcjEwOTU4OTkw","avatar_url":"https://avatars0.githubusercontent.com/u/10958990?v=4","gravatar_id":"","url":"https://api.github.com/users/laSinteZ","html_url":"https://github.com/laSinteZ","followers_url":"https://api.github.com/users/laSinteZ/followers","following_url":"https://api.github.com/users/laSinteZ/following{/other_user}","gists_url":"https://api.github.com/users/laSinteZ/gists{/gist_id}","starred_url":"https://api.github.com/users/laSinteZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laSinteZ/subscriptions","organizations_url":"https://api.github.com/users/laSinteZ/orgs","repos_url":"https://api.github.com/users/laSinteZ/repos","events_url":"https://api.github.com/users/laSinteZ/events{/privacy}","received_events_url":"https://api.github.com/users/laSinteZ/received_events","type":"User","site_admin":false},"created_at":"2018-08-01T14:32:02Z","updated_at":"2018-08-01T14:32:02Z","author_association":"CONTRIBUTOR","body":"I've finalised this PR.\r\n\r\n## Benefits\r\n1. No dependency on Iroha lib\r\n2. Less bundle size (~4MB)\r\n3. Faster application start.\r\n\r\n## Drawbacks\r\n1. Iroha helpers are far from perfect: no validation, not all possible TXs are implemented (for example, addPeer won't work)\r\n\r\n## How to check\r\n1. `yarn` to install dependencies\r\n2. `yarn serve` and try some usual use cases. (registration, deposit, withdrawal). You can do it with `%secret-ip%` or start own server with `docker-compose -f deploy/docker-compose-full.yml up` in https://github.com/d3ledger/notary repo\r\n\r\n## Future considerations\r\n1. Implement ALL transactions in iroha helpers\r\n2. Work more on iroha helpers, maybe release them as separate library.\r\n3. Create transport-helper, so iroha-helpers would work in Node and in grpc-web."}}
{"actor":{"display_login":"laSinteZ"}}