{"action":"created","issue":{"url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/4512","repository_url":"https://api.github.com/repos/xamarin/xamarin-macios","labels_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/4512/labels{/name}","comments_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/4512/comments","events_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/4512/events","html_url":"https://github.com/xamarin/xamarin-macios/pull/4512","id":344932386,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MjEwNTI0","number":4512,"title":"[msbuild] Set 'CopyNuGetImplementations' to true for app extensions. Fixes #4235 and #4237.","user":{"login":"rolfbjarne","id":249268,"node_id":"MDQ6VXNlcjI0OTI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/249268?v=4","gravatar_id":"","url":"https://api.github.com/users/rolfbjarne","html_url":"https://github.com/rolfbjarne","followers_url":"https://api.github.com/users/rolfbjarne/followers","following_url":"https://api.github.com/users/rolfbjarne/following{/other_user}","gists_url":"https://api.github.com/users/rolfbjarne/gists{/gist_id}","starred_url":"https://api.github.com/users/rolfbjarne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolfbjarne/subscriptions","organizations_url":"https://api.github.com/users/rolfbjarne/orgs","repos_url":"https://api.github.com/users/rolfbjarne/repos","events_url":"https://api.github.com/users/rolfbjarne/events{/privacy}","received_events_url":"https://api.github.com/users/rolfbjarne/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":20,"created_at":"2018-07-26T17:17:52Z","updated_at":"2018-08-15T19:33:28Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/4512","html_url":"https://github.com/xamarin/xamarin-macios/pull/4512","diff_url":"https://github.com/xamarin/xamarin-macios/pull/4512.diff","patch_url":"https://github.com/xamarin/xamarin-macios/pull/4512.patch"},"body":"In Xamarin.iOS.Common.targets, just before the _CompileToNative target, we\nmodify the mtouch references to ensure that we get the lib assemblies for\nnugets, and not the ref references:\n\nhttps://github.com/xamarin/xamarin-macios/blob/9e31d07ecc08a64372dd562e843c3d8950d24985/msbuild/Xamarin.iOS.Tasks.Core/Xamarin.iOS.Common.targets#L784-L791\n\nThis logic removes nuget references, and then re-adds any copy-local dll\nreferences.\n\nThis works fine in executable projects, but not in library projects (aka\nextensions), because nugets aren't copied for library projects:\n\nhttps://github.com/NuGet/NuGet.BuildTasks/blob/cf4b0a12cf1f75e0654f28c2a9020251c41d126a/src/Microsoft.NuGet.Build.Tasks/Microsoft.NuGet.targets#L86\n\nSo we need to set the CopyNuGetImplementations variable to 'true' for our\nlibrary projects.\n\nFixes https://github.com/xamarin/xamarin-macios/issues/4235.\nFixes https://github.com/xamarin/xamarin-macios/issues/4237."},"comment":{"url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/comments/413309871","html_url":"https://github.com/xamarin/xamarin-macios/pull/4512#issuecomment-413309871","issue_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/4512","id":413309871,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzMwOTg3MQ==","user":{"login":"spouliot","id":260465,"node_id":"MDQ6VXNlcjI2MDQ2NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/260465?v=4","gravatar_id":"","url":"https://api.github.com/users/spouliot","html_url":"https://github.com/spouliot","followers_url":"https://api.github.com/users/spouliot/followers","following_url":"https://api.github.com/users/spouliot/following{/other_user}","gists_url":"https://api.github.com/users/spouliot/gists{/gist_id}","starred_url":"https://api.github.com/users/spouliot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spouliot/subscriptions","organizations_url":"https://api.github.com/users/spouliot/orgs","repos_url":"https://api.github.com/users/spouliot/repos","events_url":"https://api.github.com/users/spouliot/events{/privacy}","received_events_url":"https://api.github.com/users/spouliot/received_events","type":"User","site_admin":false},"created_at":"2018-08-15T19:33:28Z","updated_at":"2018-08-15T19:33:28Z","author_association":"CONTRIBUTOR","body":"failure due to disk space\r\n```\r\n18:20:26 System.IO.IOException: Disk full. Path /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/jenkins-results/tests/MSBuild tests_268/execute-20180815_140058.txt\r\n```"}}
{"actor":{"display_login":"spouliot"}}