{"action":"opened","issue":{"url":"https://api.github.com/repos/LN-Zap/zap-iOS/issues/51","repository_url":"https://api.github.com/repos/LN-Zap/zap-iOS","labels_url":"https://api.github.com/repos/LN-Zap/zap-iOS/issues/51/labels{/name}","comments_url":"https://api.github.com/repos/LN-Zap/zap-iOS/issues/51/comments","events_url":"https://api.github.com/repos/LN-Zap/zap-iOS/issues/51/events","html_url":"https://github.com/LN-Zap/zap-iOS/issues/51","id":386617330,"node_id":"MDU6SXNzdWUzODY2MTczMzA=","number":51,"title":"Invoice settlement does not get reflected in the UI","user":{"login":"alexbosworth","id":401953,"node_id":"MDQ6VXNlcjQwMTk1Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/401953?v=4","gravatar_id":"","url":"https://api.github.com/users/alexbosworth","html_url":"https://github.com/alexbosworth","followers_url":"https://api.github.com/users/alexbosworth/followers","following_url":"https://api.github.com/users/alexbosworth/following{/other_user}","gists_url":"https://api.github.com/users/alexbosworth/gists{/gist_id}","starred_url":"https://api.github.com/users/alexbosworth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexbosworth/subscriptions","organizations_url":"https://api.github.com/users/alexbosworth/orgs","repos_url":"https://api.github.com/users/alexbosworth/repos","events_url":"https://api.github.com/users/alexbosworth/events{/privacy}","received_events_url":"https://api.github.com/users/alexbosworth/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-03T00:11:19Z","updated_at":"2018-12-03T00:11:19Z","closed_at":null,"author_association":"NONE","body":"When an invoice is settled, it doesn't get reflected in the history UI\r\n\r\nI traced it back to here: https://github.com/LN-Zap/zap-iOS/blob/77266ae47ccdc8a2a8acce69209d6503b47c1cd2/Lightning/Services/HistoryService.swift#L171\r\n\r\nNothing really seems to happen, and I'm not sure why settled invoices are modeled as payments?\r\n\r\nThis happens when you receive a settlement to any invoice\r\n\r\nIn theory it should insert a new history event or mark the existing invoice as settled\r\n\r\nI tested this in xcode in a simulated environment and on my iphone 8 plus\r\n"}}
{"actor":{"display_login":"alexbosworth"}}