{"action":"closed","number":4137,"pull_request":{"url":"https://api.github.com/repos/apollographql/apollo-client/pulls/4137","id":230546945,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNTQ2OTQ1","html_url":"https://github.com/apollographql/apollo-client/pull/4137","diff_url":"https://github.com/apollographql/apollo-client/pull/4137.diff","patch_url":"https://github.com/apollographql/apollo-client/pull/4137.patch","issue_url":"https://api.github.com/repos/apollographql/apollo-client/issues/4137","number":4137,"state":"closed","locked":false,"title":"Added some `returns` to prevent errors with \"noImplicitReturns\" typescript rule","user":{"login":"dumaron","id":1549216,"node_id":"MDQ6VXNlcjE1NDkyMTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1549216?v=4","gravatar_id":"","url":"https://api.github.com/users/dumaron","html_url":"https://github.com/dumaron","followers_url":"https://api.github.com/users/dumaron/followers","following_url":"https://api.github.com/users/dumaron/following{/other_user}","gists_url":"https://api.github.com/users/dumaron/gists{/gist_id}","starred_url":"https://api.github.com/users/dumaron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dumaron/subscriptions","organizations_url":"https://api.github.com/users/dumaron/orgs","repos_url":"https://api.github.com/users/dumaron/repos","events_url":"https://api.github.com/users/dumaron/events{/privacy}","received_events_url":"https://api.github.com/users/dumaron/received_events","type":"User","site_admin":false},"body":"This PR prevent errors with `noImplicitReturns` typescript rule, like described in [this issue](https://github.com/apollographql/apollo-client/issues/4126) opened by me some days ago.","created_at":"2018-11-13T16:43:50Z","updated_at":"2018-11-16T19:02:20Z","closed_at":"2018-11-16T19:02:20Z","merged_at":"2018-11-16T19:02:20Z","merge_commit_sha":"cc2dca9824fe907b495bd6302677afc645f5d648","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apollographql/apollo-client/pulls/4137/commits","review_comments_url":"https://api.github.com/repos/apollographql/apollo-client/pulls/4137/comments","review_comment_url":"https://api.github.com/repos/apollographql/apollo-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apollographql/apollo-client/issues/4137/comments","statuses_url":"https://api.github.com/repos/apollographql/apollo-client/statuses/1f4d164a54207d61fb1505e118f00ddd2d2b749d","head":{"label":"dumaron:master","ref":"master","sha":"1f4d164a54207d61fb1505e118f00ddd2d2b749d","user":{"login":"dumaron","id":1549216,"node_id":"MDQ6VXNlcjE1NDkyMTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1549216?v=4","gravatar_id":"","url":"https://api.github.com/users/dumaron","html_url":"https://github.com/dumaron","followers_url":"https://api.github.com/users/dumaron/followers","following_url":"https://api.github.com/users/dumaron/following{/other_user}","gists_url":"https://api.github.com/users/dumaron/gists{/gist_id}","starred_url":"https://api.github.com/users/dumaron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dumaron/subscriptions","organizations_url":"https://api.github.com/users/dumaron/orgs","repos_url":"https://api.github.com/users/dumaron/repos","events_url":"https://api.github.com/users/dumaron/events{/privacy}","received_events_url":"https://api.github.com/users/dumaron/received_events","type":"User","site_admin":false},"repo":{"id":157408561,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc0MDg1NjE=","name":"apollo-client","full_name":"dumaron/apollo-client","private":false,"owner":{"login":"dumaron","id":1549216,"node_id":"MDQ6VXNlcjE1NDkyMTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1549216?v=4","gravatar_id":"","url":"https://api.github.com/users/dumaron","html_url":"https://github.com/dumaron","followers_url":"https://api.github.com/users/dumaron/followers","following_url":"https://api.github.com/users/dumaron/following{/other_user}","gists_url":"https://api.github.com/users/dumaron/gists{/gist_id}","starred_url":"https://api.github.com/users/dumaron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dumaron/subscriptions","organizations_url":"https://api.github.com/users/dumaron/orgs","repos_url":"https://api.github.com/users/dumaron/repos","events_url":"https://api.github.com/users/dumaron/events{/privacy}","received_events_url":"https://api.github.com/users/dumaron/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dumaron/apollo-client","description":":rocket: A fully-featured, production ready caching GraphQL client for every UI framework and GraphQL server","fork":true,"url":"https://api.github.com/repos/dumaron/apollo-client","forks_url":"https://api.github.com/repos/dumaron/apollo-client/forks","keys_url":"https://api.github.com/repos/dumaron/apollo-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dumaron/apollo-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dumaron/apollo-client/teams","hooks_url":"https://api.github.com/repos/dumaron/apollo-client/hooks","issue_events_url":"https://api.github.com/repos/dumaron/apollo-client/issues/events{/number}","events_url":"https://api.github.com/repos/dumaron/apollo-client/events","assignees_url":"https://api.github.com/repos/dumaron/apollo-client/assignees{/user}","branches_url":"https://api.github.com/repos/dumaron/apollo-client/branches{/branch}","tags_url":"https://api.github.com/repos/dumaron/apollo-client/tags","blobs_url":"https://api.github.com/repos/dumaron/apollo-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dumaron/apollo-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dumaron/apollo-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/dumaron/apollo-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dumaron/apollo-client/statuses/{sha}","languages_url":"https://api.github.com/repos/dumaron/apollo-client/languages","stargazers_url":"https://api.github.com/repos/dumaron/apollo-client/stargazers","contributors_url":"https://api.github.com/repos/dumaron/apollo-client/contributors","subscribers_url":"https://api.github.com/repos/dumaron/apollo-client/subscribers","subscription_url":"https://api.github.com/repos/dumaron/apollo-client/subscription","commits_url":"https://api.github.com/repos/dumaron/apollo-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/dumaron/apollo-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/dumaron/apollo-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/dumaron/apollo-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/dumaron/apollo-client/contents/{+path}","compare_url":"https://api.github.com/repos/dumaron/apollo-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dumaron/apollo-client/merges","archive_url":"https://api.github.com/repos/dumaron/apollo-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dumaron/apollo-client/downloads","issues_url":"https://api.github.com/repos/dumaron/apollo-client/issues{/number}","pulls_url":"https://api.github.com/repos/dumaron/apollo-client/pulls{/number}","milestones_url":"https://api.github.com/repos/dumaron/apollo-client/milestones{/number}","notifications_url":"https://api.github.com/repos/dumaron/apollo-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dumaron/apollo-client/labels{/name}","releases_url":"https://api.github.com/repos/dumaron/apollo-client/releases{/id}","deployments_url":"https://api.github.com/repos/dumaron/apollo-client/deployments","created_at":"2018-11-13T16:11:01Z","updated_at":"2018-11-16T15:05:59Z","pushed_at":"2018-11-16T15:05:56Z","git_url":"git://github.com/dumaron/apollo-client.git","ssh_url":"git@github.com:dumaron/apollo-client.git","clone_url":"https://github.com/dumaron/apollo-client.git","svn_url":"https://github.com/dumaron/apollo-client","homepage":"https://www.apollographql.com/client/","size":12488,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apollographql:master","ref":"master","sha":"32b67e92e5845d03d33c86ddf10f892a449c56c6","user":{"login":"apollographql","id":17189275,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTg5Mjc1","avatar_url":"https://avatars0.githubusercontent.com/u/17189275?v=4","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"repo":{"id":52630616,"node_id":"MDEwOlJlcG9zaXRvcnk1MjYzMDYxNg==","name":"apollo-client","full_name":"apollographql/apollo-client","private":false,"owner":{"login":"apollographql","id":17189275,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTg5Mjc1","avatar_url":"https://avatars0.githubusercontent.com/u/17189275?v=4","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apollographql/apollo-client","description":":rocket: A fully-featured, production ready caching GraphQL client for every UI framework and GraphQL server","fork":false,"url":"https://api.github.com/repos/apollographql/apollo-client","forks_url":"https://api.github.com/repos/apollographql/apollo-client/forks","keys_url":"https://api.github.com/repos/apollographql/apollo-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apollographql/apollo-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apollographql/apollo-client/teams","hooks_url":"https://api.github.com/repos/apollographql/apollo-client/hooks","issue_events_url":"https://api.github.com/repos/apollographql/apollo-client/issues/events{/number}","events_url":"https://api.github.com/repos/apollographql/apollo-client/events","assignees_url":"https://api.github.com/repos/apollographql/apollo-client/assignees{/user}","branches_url":"https://api.github.com/repos/apollographql/apollo-client/branches{/branch}","tags_url":"https://api.github.com/repos/apollographql/apollo-client/tags","blobs_url":"https://api.github.com/repos/apollographql/apollo-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apollographql/apollo-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apollographql/apollo-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/apollographql/apollo-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apollographql/apollo-client/statuses/{sha}","languages_url":"https://api.github.com/repos/apollographql/apollo-client/languages","stargazers_url":"https://api.github.com/repos/apollographql/apollo-client/stargazers","contributors_url":"https://api.github.com/repos/apollographql/apollo-client/contributors","subscribers_url":"https://api.github.com/repos/apollographql/apollo-client/subscribers","subscription_url":"https://api.github.com/repos/apollographql/apollo-client/subscription","commits_url":"https://api.github.com/repos/apollographql/apollo-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/apollographql/apollo-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/apollographql/apollo-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/apollographql/apollo-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/apollographql/apollo-client/contents/{+path}","compare_url":"https://api.github.com/repos/apollographql/apollo-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apollographql/apollo-client/merges","archive_url":"https://api.github.com/repos/apollographql/apollo-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apollographql/apollo-client/downloads","issues_url":"https://api.github.com/repos/apollographql/apollo-client/issues{/number}","pulls_url":"https://api.github.com/repos/apollographql/apollo-client/pulls{/number}","milestones_url":"https://api.github.com/repos/apollographql/apollo-client/milestones{/number}","notifications_url":"https://api.github.com/repos/apollographql/apollo-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apollographql/apollo-client/labels{/name}","releases_url":"https://api.github.com/repos/apollographql/apollo-client/releases{/id}","deployments_url":"https://api.github.com/repos/apollographql/apollo-client/deployments","created_at":"2016-02-26T20:25:00Z","updated_at":"2018-11-16T18:02:27Z","pushed_at":"2018-11-16T19:02:20Z","git_url":"git://github.com/apollographql/apollo-client.git","ssh_url":"git@github.com:apollographql/apollo-client.git","clone_url":"https://github.com/apollographql/apollo-client.git","svn_url":"https://github.com/apollographql/apollo-client","homepage":"https://www.apollographql.com/client/","size":12488,"stargazers_count":9131,"watchers_count":9131,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1036,"mirror_url":null,"archived":false,"open_issues_count":222,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1036,"open_issues":222,"watchers":9131,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apollographql/apollo-client/pulls/4137"},"html":{"href":"https://github.com/apollographql/apollo-client/pull/4137"},"issue":{"href":"https://api.github.com/repos/apollographql/apollo-client/issues/4137"},"comments":{"href":"https://api.github.com/repos/apollographql/apollo-client/issues/4137/comments"},"review_comments":{"href":"https://api.github.com/repos/apollographql/apollo-client/pulls/4137/comments"},"review_comment":{"href":"https://api.github.com/repos/apollographql/apollo-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apollographql/apollo-client/pulls/4137/commits"},"statuses":{"href":"https://api.github.com/repos/apollographql/apollo-client/statuses/1f4d164a54207d61fb1505e118f00ddd2d2b749d"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"benjamn","id":5750,"node_id":"MDQ6VXNlcjU3NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/5750?v=4","gravatar_id":"","url":"https://api.github.com/users/benjamn","html_url":"https://github.com/benjamn","followers_url":"https://api.github.com/users/benjamn/followers","following_url":"https://api.github.com/users/benjamn/following{/other_user}","gists_url":"https://api.github.com/users/benjamn/gists{/gist_id}","starred_url":"https://api.github.com/users/benjamn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjamn/subscriptions","organizations_url":"https://api.github.com/users/benjamn/orgs","repos_url":"https://api.github.com/users/benjamn/repos","events_url":"https://api.github.com/users/benjamn/events{/privacy}","received_events_url":"https://api.github.com/users/benjamn/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"maintainer_can_modify":false,"commits":6,"additions":3,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"benjamn"}}