{"action":"created","comment":{"url":"https://api.github.com/repos/voxpupuli/puppet-php/pulls/comments/179946581","pull_request_review_id":110286170,"id":179946581,"diff_hunk":"@@ -17,85 +17,25 @@\n # [*key*]\n #   Public key in apt::key format\n #\n-# [*dotdeb*]\n-#   Enable special dotdeb handling\n-#\n-# [*sury*]\n-#   Enable special sury handling\n-#\n class php::repo::debian(\n-  $location     = 'http://packages.dotdeb.org',\n-  $release      = 'wheezy-php56',\n-  $repos        = 'all',\n-  $include_src  = false,\n-  $key          = {\n-    'id'     => '6572BBEF1B5FF28B28B706837E3F070089DF5277',\n-    'source' => 'http://www.dotdeb.org/dotdeb.gpg',\n-  },\n-  $dotdeb       = true,\n-  $sury         = true,\n+  String           $location     = 'https://packages.sury.org/php',\n+  Optional[String] $release      = undef,\n+  String           $repos        = 'main',\n+  Boolean          $include_src  = false,\n+  Hash             $key          = {\n+    'id'     => 'DF3D585DB8F0EB658690A554AC0E47584A7A714D',\n+    'source' => 'https://packages.sury.org/php/apt.gpg',\n+  }\n ) {\n-\n   if $caller_module_name != $module_name {\n     warning('php::repo::debian is private')\n   }\n \n-  include '::apt'\n-\n-  create_resources(::apt::key, { 'php::repo::debian' => {\n-    id     => $key['id'],\n-    source => $key['source'],\n-  }})\n-\n-  ::apt::source { \"source_php_${release}\":\n+  apt::source { 'php':","path":"manifests/repo/debian.pp","position":43,"original_position":43,"commit_id":"96055b436c93cc19c4ea2e89dd244a86df993838","original_commit_id":"96055b436c93cc19c4ea2e89dd244a86df993838","user":{"login":"c33s","id":649209,"avatar_url":"https://avatars3.githubusercontent.com/u/649209?v=4","gravatar_id":"","url":"https://api.github.com/users/c33s","html_url":"https://github.com/c33s","followers_url":"https://api.github.com/users/c33s/followers","following_url":"https://api.github.com/users/c33s/following{/other_user}","gists_url":"https://api.github.com/users/c33s/gists{/gist_id}","starred_url":"https://api.github.com/users/c33s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c33s/subscriptions","organizations_url":"https://api.github.com/users/c33s/orgs","repos_url":"https://api.github.com/users/c33s/repos","events_url":"https://api.github.com/users/c33s/events{/privacy}","received_events_url":"https://api.github.com/users/c33s/received_events","type":"User","site_admin":false},"body":"should be named `sury` and should be configurable","created_at":"2018-04-08T12:47:23Z","updated_at":"2018-04-08T13:01:31Z","html_url":"https://github.com/voxpupuli/puppet-php/pull/430#discussion_r179946581","pull_request_url":"https://api.github.com/repos/voxpupuli/puppet-php/pulls/430","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-php/pulls/comments/179946581"},"html":{"href":"https://github.com/voxpupuli/puppet-php/pull/430#discussion_r179946581"},"pull_request":{"href":"https://api.github.com/repos/voxpupuli/puppet-php/pulls/430"}}},"pull_request":{"url":"https://api.github.com/repos/voxpupuli/puppet-php/pulls/430","id":174905779,"html_url":"https://github.com/voxpupuli/puppet-php/pull/430","diff_url":"https://github.com/voxpupuli/puppet-php/pull/430.diff","patch_url":"https://github.com/voxpupuli/puppet-php/pull/430.patch","issue_url":"https://api.github.com/repos/voxpupuli/puppet-php/issues/430","number":430,"state":"open","locked":false,"title":"Do not use a a hardcoded default for php::repo::debian","user":{"login":"jkroepke","id":1560587,"avatar_url":"https://avatars3.githubusercontent.com/u/1560587?v=4","gravatar_id":"","url":"https://api.github.com/users/jkroepke","html_url":"https://github.com/jkroepke","followers_url":"https://api.github.com/users/jkroepke/followers","following_url":"https://api.github.com/users/jkroepke/following{/other_user}","gists_url":"https://api.github.com/users/jkroepke/gists{/gist_id}","starred_url":"https://api.github.com/users/jkroepke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkroepke/subscriptions","organizations_url":"https://api.github.com/users/jkroepke/orgs","repos_url":"https://api.github.com/users/jkroepke/repos","events_url":"https://api.github.com/users/jkroepke/events{/privacy}","received_events_url":"https://api.github.com/users/jkroepke/received_events","type":"User","site_admin":false},"body":"On Debian 8 and 9 systems, the dotdeb debian 7 repo will be used by default. This shouldn't be.\r\n\r\nSome breaking changes here since all location special handling removed for now.","created_at":"2018-03-14T10:07:04Z","updated_at":"2018-04-08T13:01:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ba5960bc22fac5eb45db8d96ff6edddb0a85e5c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":81287026,"url":"https://api.github.com/repos/voxpupuli/puppet-php/labels/bug","name":"bug","color":"0e8a16","default":true},{"id":575381649,"url":"https://api.github.com/repos/voxpupuli/puppet-php/labels/needs-tests","name":"needs-tests","color":"f7c6c7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/voxpupuli/puppet-php/pulls/430/commits","review_comments_url":"https://api.github.com/repos/voxpupuli/puppet-php/pulls/430/comments","review_comment_url":"https://api.github.com/repos/voxpupuli/puppet-php/pulls/comments{/number}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-php/issues/430/comments","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-php/statuses/96055b436c93cc19c4ea2e89dd244a86df993838","head":{"label":"jkroepke:patch-5","ref":"patch-5","sha":"96055b436c93cc19c4ea2e89dd244a86df993838","user":{"login":"jkroepke","id":1560587,"avatar_url":"https://avatars3.githubusercontent.com/u/1560587?v=4","gravatar_id":"","url":"https://api.github.com/users/jkroepke","html_url":"https://github.com/jkroepke","followers_url":"https://api.github.com/users/jkroepke/followers","following_url":"https://api.github.com/users/jkroepke/following{/other_user}","gists_url":"https://api.github.com/users/jkroepke/gists{/gist_id}","starred_url":"https://api.github.com/users/jkroepke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkroepke/subscriptions","organizations_url":"https://api.github.com/users/jkroepke/orgs","repos_url":"https://api.github.com/users/jkroepke/repos","events_url":"https://api.github.com/users/jkroepke/events{/privacy}","received_events_url":"https://api.github.com/users/jkroepke/received_events","type":"User","site_admin":false},"repo":{"id":60925794,"name":"puppet-php","full_name":"jkroepke/puppet-php","owner":{"login":"jkroepke","id":1560587,"avatar_url":"https://avatars3.githubusercontent.com/u/1560587?v=4","gravatar_id":"","url":"https://api.github.com/users/jkroepke","html_url":"https://github.com/jkroepke","followers_url":"https://api.github.com/users/jkroepke/followers","following_url":"https://api.github.com/users/jkroepke/following{/other_user}","gists_url":"https://api.github.com/users/jkroepke/gists{/gist_id}","starred_url":"https://api.github.com/users/jkroepke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkroepke/subscriptions","organizations_url":"https://api.github.com/users/jkroepke/orgs","repos_url":"https://api.github.com/users/jkroepke/repos","events_url":"https://api.github.com/users/jkroepke/events{/privacy}","received_events_url":"https://api.github.com/users/jkroepke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jkroepke/puppet-php","description":"Generic Puppet module to manage PHP on many platforms","fork":true,"url":"https://api.github.com/repos/jkroepke/puppet-php","forks_url":"https://api.github.com/repos/jkroepke/puppet-php/forks","keys_url":"https://api.github.com/repos/jkroepke/puppet-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jkroepke/puppet-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jkroepke/puppet-php/teams","hooks_url":"https://api.github.com/repos/jkroepke/puppet-php/hooks","issue_events_url":"https://api.github.com/repos/jkroepke/puppet-php/issues/events{/number}","events_url":"https://api.github.com/repos/jkroepke/puppet-php/events","assignees_url":"https://api.github.com/repos/jkroepke/puppet-php/assignees{/user}","branches_url":"https://api.github.com/repos/jkroepke/puppet-php/branches{/branch}","tags_url":"https://api.github.com/repos/jkroepke/puppet-php/tags","blobs_url":"https://api.github.com/repos/jkroepke/puppet-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jkroepke/puppet-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jkroepke/puppet-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/jkroepke/puppet-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jkroepke/puppet-php/statuses/{sha}","languages_url":"https://api.github.com/repos/jkroepke/puppet-php/languages","stargazers_url":"https://api.github.com/repos/jkroepke/puppet-php/stargazers","contributors_url":"https://api.github.com/repos/jkroepke/puppet-php/contributors","subscribers_url":"https://api.github.com/repos/jkroepke/puppet-php/subscribers","subscription_url":"https://api.github.com/repos/jkroepke/puppet-php/subscription","commits_url":"https://api.github.com/repos/jkroepke/puppet-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/jkroepke/puppet-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/jkroepke/puppet-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/jkroepke/puppet-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/jkroepke/puppet-php/contents/{+path}","compare_url":"https://api.github.com/repos/jkroepke/puppet-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jkroepke/puppet-php/merges","archive_url":"https://api.github.com/repos/jkroepke/puppet-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jkroepke/puppet-php/downloads","issues_url":"https://api.github.com/repos/jkroepke/puppet-php/issues{/number}","pulls_url":"https://api.github.com/repos/jkroepke/puppet-php/pulls{/number}","milestones_url":"https://api.github.com/repos/jkroepke/puppet-php/milestones{/number}","notifications_url":"https://api.github.com/repos/jkroepke/puppet-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jkroepke/puppet-php/labels{/name}","releases_url":"https://api.github.com/repos/jkroepke/puppet-php/releases{/id}","deployments_url":"https://api.github.com/repos/jkroepke/puppet-php/deployments","created_at":"2016-06-11T20:09:09Z","updated_at":"2018-03-14T09:28:16Z","pushed_at":"2018-04-08T12:10:57Z","git_url":"git://github.com/jkroepke/puppet-php.git","ssh_url":"git@github.com:jkroepke/puppet-php.git","clone_url":"https://github.com/jkroepke/puppet-php.git","svn_url":"https://github.com/jkroepke/puppet-php","homepage":"http://php.puppet.mayflower.de/","size":1181,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"voxpupuli:master","ref":"master","sha":"638976174ec5778e38c4605187988932bf10ca7c","user":{"login":"voxpupuli","id":8693967,"avatar_url":"https://avatars3.githubusercontent.com/u/8693967?v=4","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"repo":{"id":16954722,"name":"puppet-php","full_name":"voxpupuli/puppet-php","owner":{"login":"voxpupuli","id":8693967,"avatar_url":"https://avatars3.githubusercontent.com/u/8693967?v=4","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/voxpupuli/puppet-php","description":"Generic Puppet module to manage PHP on many platforms","fork":false,"url":"https://api.github.com/repos/voxpupuli/puppet-php","forks_url":"https://api.github.com/repos/voxpupuli/puppet-php/forks","keys_url":"https://api.github.com/repos/voxpupuli/puppet-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/voxpupuli/puppet-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/voxpupuli/puppet-php/teams","hooks_url":"https://api.github.com/repos/voxpupuli/puppet-php/hooks","issue_events_url":"https://api.github.com/repos/voxpupuli/puppet-php/issues/events{/number}","events_url":"https://api.github.com/repos/voxpupuli/puppet-php/events","assignees_url":"https://api.github.com/repos/voxpupuli/puppet-php/assignees{/user}","branches_url":"https://api.github.com/repos/voxpupuli/puppet-php/branches{/branch}","tags_url":"https://api.github.com/repos/voxpupuli/puppet-php/tags","blobs_url":"https://api.github.com/repos/voxpupuli/puppet-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/voxpupuli/puppet-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/voxpupuli/puppet-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/voxpupuli/puppet-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-php/statuses/{sha}","languages_url":"https://api.github.com/repos/voxpupuli/puppet-php/languages","stargazers_url":"https://api.github.com/repos/voxpupuli/puppet-php/stargazers","contributors_url":"https://api.github.com/repos/voxpupuli/puppet-php/contributors","subscribers_url":"https://api.github.com/repos/voxpupuli/puppet-php/subscribers","subscription_url":"https://api.github.com/repos/voxpupuli/puppet-php/subscription","commits_url":"https://api.github.com/repos/voxpupuli/puppet-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/voxpupuli/puppet-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/voxpupuli/puppet-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/voxpupuli/puppet-php/contents/{+path}","compare_url":"https://api.github.com/repos/voxpupuli/puppet-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/voxpupuli/puppet-php/merges","archive_url":"https://api.github.com/repos/voxpupuli/puppet-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/voxpupuli/puppet-php/downloads","issues_url":"https://api.github.com/repos/voxpupuli/puppet-php/issues{/number}","pulls_url":"https://api.github.com/repos/voxpupuli/puppet-php/pulls{/number}","milestones_url":"https://api.github.com/repos/voxpupuli/puppet-php/milestones{/number}","notifications_url":"https://api.github.com/repos/voxpupuli/puppet-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/voxpupuli/puppet-php/labels{/name}","releases_url":"https://api.github.com/repos/voxpupuli/puppet-php/releases{/id}","deployments_url":"https://api.github.com/repos/voxpupuli/puppet-php/deployments","created_at":"2014-02-18T16:06:24Z","updated_at":"2018-03-02T16:37:11Z","pushed_at":"2018-04-08T12:10:58Z","git_url":"git://github.com/voxpupuli/puppet-php.git","ssh_url":"git@github.com:voxpupuli/puppet-php.git","clone_url":"https://github.com/voxpupuli/puppet-php.git","svn_url":"https://github.com/voxpupuli/puppet-php","homepage":"http://php.puppet.mayflower.de/","size":1169,"stargazers_count":72,"watchers_count":72,"language":"Puppet","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":188,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":188,"open_issues":83,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-php/pulls/430"},"html":{"href":"https://github.com/voxpupuli/puppet-php/pull/430"},"issue":{"href":"https://api.github.com/repos/voxpupuli/puppet-php/issues/430"},"comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-php/issues/430/comments"},"review_comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-php/pulls/430/comments"},"review_comment":{"href":"https://api.github.com/repos/voxpupuli/puppet-php/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/voxpupuli/puppet-php/pulls/430/commits"},"statuses":{"href":"https://api.github.com/repos/voxpupuli/puppet-php/statuses/96055b436c93cc19c4ea2e89dd244a86df993838"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"c33s"}}