{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/pyre-check/pulls/comments/211777126","pull_request_review_id":148271979,"id":211777126,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTc3NzEyNg==","diff_hunk":"@@ -65,22 +65,33 @@ let create ~environment ~source =\n                   };\n                 _;\n               } ->\n-                add_call_edge call_graph caller callee\n+                Some callee\n             | _ ->\n-                call_graph\n+                None\n           in\n           Annotated.Access.create access\n-          |> Annotated.Access.fold ~resolution ~initial:call_graph ~f:add_call_edge\n+          |> Annotated.Access.fold ~resolution ~initial:None ~f:resolve_access","path":"analysis/callGraph.ml","position":48,"original_position":48,"commit_id":"126fc3e7baa2ff156eaa0636bb96fb9c860a658d","original_commit_id":"b3f9c827a7af11a606666d442b83d79360fa8798","user":{"login":"dkgi","id":270421,"node_id":"MDQ6VXNlcjI3MDQyMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/270421?v=4","gravatar_id":"","url":"https://api.github.com/users/dkgi","html_url":"https://github.com/dkgi","followers_url":"https://api.github.com/users/dkgi/followers","following_url":"https://api.github.com/users/dkgi/following{/other_user}","gists_url":"https://api.github.com/users/dkgi/gists{/gist_id}","starred_url":"https://api.github.com/users/dkgi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkgi/subscriptions","organizations_url":"https://api.github.com/users/dkgi/orgs","repos_url":"https://api.github.com/users/dkgi/repos","events_url":"https://api.github.com/users/dkgi/events{/privacy}","received_events_url":"https://api.github.com/users/dkgi/received_events","type":"User","site_admin":false},"body":"Not sure I see what you mean in the tests. Are we missing those just in conditional tests? If so, that sounds wrong.\r\n\r\nSounds like this should be fixed in the access fold. Let me know how you want to proceed. Fine with landing this and adding a TODO.","created_at":"2018-08-21T22:15:14Z","updated_at":"2018-08-21T22:15:14Z","html_url":"https://github.com/facebook/pyre-check/pull/86#discussion_r211777126","pull_request_url":"https://api.github.com/repos/facebook/pyre-check/pulls/86","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/facebook/pyre-check/pulls/comments/211777126"},"html":{"href":"https://github.com/facebook/pyre-check/pull/86#discussion_r211777126"},"pull_request":{"href":"https://api.github.com/repos/facebook/pyre-check/pulls/86"}},"in_reply_to_id":211415472},"pull_request":{"url":"https://api.github.com/repos/facebook/pyre-check/pulls/86","id":209648709,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NjQ4NzA5","html_url":"https://github.com/facebook/pyre-check/pull/86","diff_url":"https://github.com/facebook/pyre-check/pull/86.diff","patch_url":"https://github.com/facebook/pyre-check/pull/86.patch","issue_url":"https://api.github.com/repos/facebook/pyre-check/issues/86","number":86,"state":"open","locked":false,"title":"collect missing call edges","user":{"login":"rvantonder","id":888624,"node_id":"MDQ6VXNlcjg4ODYyNA==","avatar_url":"https://avatars3.githubusercontent.com/u/888624?v=4","gravatar_id":"","url":"https://api.github.com/users/rvantonder","html_url":"https://github.com/rvantonder","followers_url":"https://api.github.com/users/rvantonder/followers","following_url":"https://api.github.com/users/rvantonder/following{/other_user}","gists_url":"https://api.github.com/users/rvantonder/gists{/gist_id}","starred_url":"https://api.github.com/users/rvantonder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvantonder/subscriptions","organizations_url":"https://api.github.com/users/rvantonder/orgs","repos_url":"https://api.github.com/users/rvantonder/repos","events_url":"https://api.github.com/users/rvantonder/events{/privacy}","received_events_url":"https://api.github.com/users/rvantonder/received_events","type":"User","site_admin":false},"body":"A call signature (annotated access) is not created for some calls. When that is the case, record the call edge for a `Call` as revealed by the AST.","created_at":"2018-08-20T21:27:35Z","updated_at":"2018-08-21T22:15:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a83eeaaf9a56b204db62b2e12b670d5b5c0366e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":746717209,"node_id":"MDU6TGFiZWw3NDY3MTcyMDk=","url":"https://api.github.com/repos/facebook/pyre-check/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/pyre-check/pulls/86/commits","review_comments_url":"https://api.github.com/repos/facebook/pyre-check/pulls/86/comments","review_comment_url":"https://api.github.com/repos/facebook/pyre-check/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/pyre-check/issues/86/comments","statuses_url":"https://api.github.com/repos/facebook/pyre-check/statuses/126fc3e7baa2ff156eaa0636bb96fb9c860a658d","head":{"label":"rvantonder:aggressive-callgraph","ref":"aggressive-callgraph","sha":"126fc3e7baa2ff156eaa0636bb96fb9c860a658d","user":{"login":"rvantonder","id":888624,"node_id":"MDQ6VXNlcjg4ODYyNA==","avatar_url":"https://avatars3.githubusercontent.com/u/888624?v=4","gravatar_id":"","url":"https://api.github.com/users/rvantonder","html_url":"https://github.com/rvantonder","followers_url":"https://api.github.com/users/rvantonder/followers","following_url":"https://api.github.com/users/rvantonder/following{/other_user}","gists_url":"https://api.github.com/users/rvantonder/gists{/gist_id}","starred_url":"https://api.github.com/users/rvantonder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvantonder/subscriptions","organizations_url":"https://api.github.com/users/rvantonder/orgs","repos_url":"https://api.github.com/users/rvantonder/repos","events_url":"https://api.github.com/users/rvantonder/events{/privacy}","received_events_url":"https://api.github.com/users/rvantonder/received_events","type":"User","site_admin":false},"repo":{"id":133078728,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMwNzg3Mjg=","name":"pyre-check","full_name":"rvantonder/pyre-check","owner":{"login":"rvantonder","id":888624,"node_id":"MDQ6VXNlcjg4ODYyNA==","avatar_url":"https://avatars3.githubusercontent.com/u/888624?v=4","gravatar_id":"","url":"https://api.github.com/users/rvantonder","html_url":"https://github.com/rvantonder","followers_url":"https://api.github.com/users/rvantonder/followers","following_url":"https://api.github.com/users/rvantonder/following{/other_user}","gists_url":"https://api.github.com/users/rvantonder/gists{/gist_id}","starred_url":"https://api.github.com/users/rvantonder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvantonder/subscriptions","organizations_url":"https://api.github.com/users/rvantonder/orgs","repos_url":"https://api.github.com/users/rvantonder/repos","events_url":"https://api.github.com/users/rvantonder/events{/privacy}","received_events_url":"https://api.github.com/users/rvantonder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rvantonder/pyre-check","description":"Performant type-checking for python.","fork":true,"url":"https://api.github.com/repos/rvantonder/pyre-check","forks_url":"https://api.github.com/repos/rvantonder/pyre-check/forks","keys_url":"https://api.github.com/repos/rvantonder/pyre-check/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rvantonder/pyre-check/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rvantonder/pyre-check/teams","hooks_url":"https://api.github.com/repos/rvantonder/pyre-check/hooks","issue_events_url":"https://api.github.com/repos/rvantonder/pyre-check/issues/events{/number}","events_url":"https://api.github.com/repos/rvantonder/pyre-check/events","assignees_url":"https://api.github.com/repos/rvantonder/pyre-check/assignees{/user}","branches_url":"https://api.github.com/repos/rvantonder/pyre-check/branches{/branch}","tags_url":"https://api.github.com/repos/rvantonder/pyre-check/tags","blobs_url":"https://api.github.com/repos/rvantonder/pyre-check/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rvantonder/pyre-check/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rvantonder/pyre-check/git/refs{/sha}","trees_url":"https://api.github.com/repos/rvantonder/pyre-check/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rvantonder/pyre-check/statuses/{sha}","languages_url":"https://api.github.com/repos/rvantonder/pyre-check/languages","stargazers_url":"https://api.github.com/repos/rvantonder/pyre-check/stargazers","contributors_url":"https://api.github.com/repos/rvantonder/pyre-check/contributors","subscribers_url":"https://api.github.com/repos/rvantonder/pyre-check/subscribers","subscription_url":"https://api.github.com/repos/rvantonder/pyre-check/subscription","commits_url":"https://api.github.com/repos/rvantonder/pyre-check/commits{/sha}","git_commits_url":"https://api.github.com/repos/rvantonder/pyre-check/git/commits{/sha}","comments_url":"https://api.github.com/repos/rvantonder/pyre-check/comments{/number}","issue_comment_url":"https://api.github.com/repos/rvantonder/pyre-check/issues/comments{/number}","contents_url":"https://api.github.com/repos/rvantonder/pyre-check/contents/{+path}","compare_url":"https://api.github.com/repos/rvantonder/pyre-check/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rvantonder/pyre-check/merges","archive_url":"https://api.github.com/repos/rvantonder/pyre-check/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rvantonder/pyre-check/downloads","issues_url":"https://api.github.com/repos/rvantonder/pyre-check/issues{/number}","pulls_url":"https://api.github.com/repos/rvantonder/pyre-check/pulls{/number}","milestones_url":"https://api.github.com/repos/rvantonder/pyre-check/milestones{/number}","notifications_url":"https://api.github.com/repos/rvantonder/pyre-check/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rvantonder/pyre-check/labels{/name}","releases_url":"https://api.github.com/repos/rvantonder/pyre-check/releases{/id}","deployments_url":"https://api.github.com/repos/rvantonder/pyre-check/deployments","created_at":"2018-05-11T19:08:14Z","updated_at":"2018-08-18T02:59:09Z","pushed_at":"2018-08-21T03:00:49Z","git_url":"git://github.com/rvantonder/pyre-check.git","ssh_url":"git@github.com:rvantonder/pyre-check.git","clone_url":"https://github.com/rvantonder/pyre-check.git","svn_url":"https://github.com/rvantonder/pyre-check","homepage":null,"size":3363,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"9bb4a2550bfd094241f7bedccda0e2d4bcc91ab3","user":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":110274488,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAyNzQ0ODg=","name":"pyre-check","full_name":"facebook/pyre-check","owner":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/pyre-check","description":"Performant type-checking for python.","fork":false,"url":"https://api.github.com/repos/facebook/pyre-check","forks_url":"https://api.github.com/repos/facebook/pyre-check/forks","keys_url":"https://api.github.com/repos/facebook/pyre-check/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/pyre-check/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/pyre-check/teams","hooks_url":"https://api.github.com/repos/facebook/pyre-check/hooks","issue_events_url":"https://api.github.com/repos/facebook/pyre-check/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/pyre-check/events","assignees_url":"https://api.github.com/repos/facebook/pyre-check/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/pyre-check/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/pyre-check/tags","blobs_url":"https://api.github.com/repos/facebook/pyre-check/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/pyre-check/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/pyre-check/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/pyre-check/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/pyre-check/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/pyre-check/languages","stargazers_url":"https://api.github.com/repos/facebook/pyre-check/stargazers","contributors_url":"https://api.github.com/repos/facebook/pyre-check/contributors","subscribers_url":"https://api.github.com/repos/facebook/pyre-check/subscribers","subscription_url":"https://api.github.com/repos/facebook/pyre-check/subscription","commits_url":"https://api.github.com/repos/facebook/pyre-check/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/pyre-check/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/pyre-check/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/pyre-check/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/pyre-check/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/pyre-check/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/pyre-check/merges","archive_url":"https://api.github.com/repos/facebook/pyre-check/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/pyre-check/downloads","issues_url":"https://api.github.com/repos/facebook/pyre-check/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/pyre-check/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/pyre-check/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/pyre-check/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/pyre-check/labels{/name}","releases_url":"https://api.github.com/repos/facebook/pyre-check/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/pyre-check/deployments","created_at":"2017-11-10T17:31:36Z","updated_at":"2018-08-21T20:34:08Z","pushed_at":"2018-08-21T22:05:11Z","git_url":"git://github.com/facebook/pyre-check.git","ssh_url":"git@github.com:facebook/pyre-check.git","clone_url":"https://github.com/facebook/pyre-check.git","svn_url":"https://github.com/facebook/pyre-check","homepage":"https://pyre-check.org/","size":3551,"stargazers_count":1941,"watchers_count":1941,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":51,"open_issues":20,"watchers":1941,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/pyre-check/pulls/86"},"html":{"href":"https://github.com/facebook/pyre-check/pull/86"},"issue":{"href":"https://api.github.com/repos/facebook/pyre-check/issues/86"},"comments":{"href":"https://api.github.com/repos/facebook/pyre-check/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/pyre-check/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/pyre-check/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/pyre-check/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/pyre-check/statuses/126fc3e7baa2ff156eaa0636bb96fb9c860a658d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dkgi"}}