{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/atlasdb/pulls/comments/183372497","pull_request_review_id":114354663,"id":183372497,"diff_hunk":"@@ -85,13 +85,13 @@ private boolean shouldTraceQuery(Set<TableReference> tableRefs) {\n     }\n \n     private void logFailedCall(Set<TableReference> tableRefs) {\n-        log.error(\"A call to table(s) {} failed with an exception.\",\n+        log.warn(\"A call to table(s) {} failed with an exception.\",\n                 tableRefs.stream().map(TableReference::getQualifiedName).collect(Collectors.joining(\", \")));\n     }\n \n     private void logTraceResults(long duration, Set<TableReference> tableRefs, ByteBuffer recvTrace, boolean failed) {\n         if (failed || duration > tracingPrefs.getMinimumDurationToTraceMillis()) {\n-            log.error(\"Traced a call to {} that {}took {} ms. It will appear in system_traces with UUID={}\",\n+            log.warn(\"Traced a call to {} that {}took {} ms. It will appear in system_traces with UUID={}\",","path":"atlasdb-cassandra/src/main/java/com/palantir/atlasdb/keyvalue/cassandra/TracingQueryRunner.java","position":12,"original_position":12,"commit_id":"56df3e16e2d3383c79ad30eab3a63c366f7ba250","original_commit_id":"56df3e16e2d3383c79ad30eab3a63c366f7ba250","user":{"login":"gsheasby","id":15610492,"avatar_url":"https://avatars2.githubusercontent.com/u/15610492?v=4","gravatar_id":"","url":"https://api.github.com/users/gsheasby","html_url":"https://github.com/gsheasby","followers_url":"https://api.github.com/users/gsheasby/followers","following_url":"https://api.github.com/users/gsheasby/following{/other_user}","gists_url":"https://api.github.com/users/gsheasby/gists{/gist_id}","starred_url":"https://api.github.com/users/gsheasby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsheasby/subscriptions","organizations_url":"https://api.github.com/users/gsheasby/orgs","repos_url":"https://api.github.com/users/gsheasby/repos","events_url":"https://api.github.com/users/gsheasby/events{/privacy}","received_events_url":"https://api.github.com/users/gsheasby/received_events","type":"User","site_admin":false},"body":"This looks like it could even be an `info` message.","created_at":"2018-04-23T12:14:53Z","updated_at":"2018-04-23T12:31:40Z","html_url":"https://github.com/palantir/atlasdb/pull/3101#discussion_r183372497","pull_request_url":"https://api.github.com/repos/palantir/atlasdb/pulls/3101","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/comments/183372497"},"html":{"href":"https://github.com/palantir/atlasdb/pull/3101#discussion_r183372497"},"pull_request":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/3101"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/atlasdb/pulls/3101","id":182751818,"html_url":"https://github.com/palantir/atlasdb/pull/3101","diff_url":"https://github.com/palantir/atlasdb/pull/3101.diff","patch_url":"https://github.com/palantir/atlasdb/pull/3101.patch","issue_url":"https://api.github.com/repos/palantir/atlasdb/issues/3101","number":3101,"state":"open","locked":false,"title":"Reduce a number of error and warn messages to lower logging levels.","user":{"login":"tboam","id":24569178,"avatar_url":"https://avatars1.githubusercontent.com/u/24569178?v=4","gravatar_id":"","url":"https://api.github.com/users/tboam","html_url":"https://github.com/tboam","followers_url":"https://api.github.com/users/tboam/followers","following_url":"https://api.github.com/users/tboam/following{/other_user}","gists_url":"https://api.github.com/users/tboam/gists{/gist_id}","starred_url":"https://api.github.com/users/tboam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tboam/subscriptions","organizations_url":"https://api.github.com/users/tboam/orgs","repos_url":"https://api.github.com/users/tboam/repos","events_url":"https://api.github.com/users/tboam/events{/privacy}","received_events_url":"https://api.github.com/users/tboam/received_events","type":"User","site_admin":false},"body":"**Goals (and why)**: Reduce the number of messages we log at ERROR and WARN levels.  These have caused unnecessary alarm for users and often obscure their own error messages.\r\n\r\n**Implementation Description (bullets)**: I've reduced the logging level for a number of log lines.  In places by quite a lot.  I expect discussion and push back on some of the changes but I want to have the conversations rather than sitting on this.\r\n\r\n**Concerns (what feedback would you like?)**:  Where have I reduced the logging level too much.\r\n\r\n**Where should we start reviewing?**:  Each change is distinct so anywhere you want.\r\n\r\n**Priority (whenever / two weeks / yesterday)**: would be good to merge this next week\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/palantir/atlasdb/3101)\n<!-- Reviewable:end -->\n","created_at":"2018-04-19T11:53:15Z","updated_at":"2018-04-23T12:31:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"822aa270dade519ffcafdc3dff02ae8f41a60213","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sandorw","id":8271534,"avatar_url":"https://avatars1.githubusercontent.com/u/8271534?v=4","gravatar_id":"","url":"https://api.github.com/users/sandorw","html_url":"https://github.com/sandorw","followers_url":"https://api.github.com/users/sandorw/followers","following_url":"https://api.github.com/users/sandorw/following{/other_user}","gists_url":"https://api.github.com/users/sandorw/gists{/gist_id}","starred_url":"https://api.github.com/users/sandorw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandorw/subscriptions","organizations_url":"https://api.github.com/users/sandorw/orgs","repos_url":"https://api.github.com/users/sandorw/repos","events_url":"https://api.github.com/users/sandorw/events{/privacy}","received_events_url":"https://api.github.com/users/sandorw/received_events","type":"User","site_admin":false},{"login":"diogoholanda","id":11463487,"avatar_url":"https://avatars2.githubusercontent.com/u/11463487?v=4","gravatar_id":"","url":"https://api.github.com/users/diogoholanda","html_url":"https://github.com/diogoholanda","followers_url":"https://api.github.com/users/diogoholanda/followers","following_url":"https://api.github.com/users/diogoholanda/following{/other_user}","gists_url":"https://api.github.com/users/diogoholanda/gists{/gist_id}","starred_url":"https://api.github.com/users/diogoholanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diogoholanda/subscriptions","organizations_url":"https://api.github.com/users/diogoholanda/orgs","repos_url":"https://api.github.com/users/diogoholanda/repos","events_url":"https://api.github.com/users/diogoholanda/events{/privacy}","received_events_url":"https://api.github.com/users/diogoholanda/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/palantir/atlasdb/pulls/3101/commits","review_comments_url":"https://api.github.com/repos/palantir/atlasdb/pulls/3101/comments","review_comment_url":"https://api.github.com/repos/palantir/atlasdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/atlasdb/issues/3101/comments","statuses_url":"https://api.github.com/repos/palantir/atlasdb/statuses/56df3e16e2d3383c79ad30eab3a63c366f7ba250","head":{"label":"palantir:logging/reduce-high-logging-levels","ref":"logging/reduce-high-logging-levels","sha":"56df3e16e2d3383c79ad30eab3a63c366f7ba250","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":36960637,"name":"atlasdb","full_name":"palantir/atlasdb","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/atlasdb","description":"Transactional Distributed Database Layer","fork":false,"url":"https://api.github.com/repos/palantir/atlasdb","forks_url":"https://api.github.com/repos/palantir/atlasdb/forks","keys_url":"https://api.github.com/repos/palantir/atlasdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/atlasdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/atlasdb/teams","hooks_url":"https://api.github.com/repos/palantir/atlasdb/hooks","issue_events_url":"https://api.github.com/repos/palantir/atlasdb/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/atlasdb/events","assignees_url":"https://api.github.com/repos/palantir/atlasdb/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/atlasdb/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/atlasdb/tags","blobs_url":"https://api.github.com/repos/palantir/atlasdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/atlasdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/atlasdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/atlasdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/atlasdb/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/atlasdb/languages","stargazers_url":"https://api.github.com/repos/palantir/atlasdb/stargazers","contributors_url":"https://api.github.com/repos/palantir/atlasdb/contributors","subscribers_url":"https://api.github.com/repos/palantir/atlasdb/subscribers","subscription_url":"https://api.github.com/repos/palantir/atlasdb/subscription","commits_url":"https://api.github.com/repos/palantir/atlasdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/atlasdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/atlasdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/atlasdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/atlasdb/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/atlasdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/atlasdb/merges","archive_url":"https://api.github.com/repos/palantir/atlasdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/atlasdb/downloads","issues_url":"https://api.github.com/repos/palantir/atlasdb/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/atlasdb/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/atlasdb/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/atlasdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/atlasdb/labels{/name}","releases_url":"https://api.github.com/repos/palantir/atlasdb/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/atlasdb/deployments","created_at":"2015-06-05T23:42:44Z","updated_at":"2018-04-23T12:05:24Z","pushed_at":"2018-04-23T12:25:02Z","git_url":"git://github.com/palantir/atlasdb.git","ssh_url":"git@github.com:palantir/atlasdb.git","clone_url":"https://github.com/palantir/atlasdb.git","svn_url":"https://github.com/palantir/atlasdb","homepage":"http://palantir.github.io/atlasdb/","size":60565,"stargazers_count":580,"watchers_count":580,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":108,"mirror_url":null,"archived":false,"open_issues_count":289,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":108,"open_issues":289,"watchers":580,"default_branch":"develop"}},"base":{"label":"palantir:develop","ref":"develop","sha":"648e19afce6b176a385d5880ae293b8cc97150e0","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":36960637,"name":"atlasdb","full_name":"palantir/atlasdb","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/atlasdb","description":"Transactional Distributed Database Layer","fork":false,"url":"https://api.github.com/repos/palantir/atlasdb","forks_url":"https://api.github.com/repos/palantir/atlasdb/forks","keys_url":"https://api.github.com/repos/palantir/atlasdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/atlasdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/atlasdb/teams","hooks_url":"https://api.github.com/repos/palantir/atlasdb/hooks","issue_events_url":"https://api.github.com/repos/palantir/atlasdb/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/atlasdb/events","assignees_url":"https://api.github.com/repos/palantir/atlasdb/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/atlasdb/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/atlasdb/tags","blobs_url":"https://api.github.com/repos/palantir/atlasdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/atlasdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/atlasdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/atlasdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/atlasdb/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/atlasdb/languages","stargazers_url":"https://api.github.com/repos/palantir/atlasdb/stargazers","contributors_url":"https://api.github.com/repos/palantir/atlasdb/contributors","subscribers_url":"https://api.github.com/repos/palantir/atlasdb/subscribers","subscription_url":"https://api.github.com/repos/palantir/atlasdb/subscription","commits_url":"https://api.github.com/repos/palantir/atlasdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/atlasdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/atlasdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/atlasdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/atlasdb/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/atlasdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/atlasdb/merges","archive_url":"https://api.github.com/repos/palantir/atlasdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/atlasdb/downloads","issues_url":"https://api.github.com/repos/palantir/atlasdb/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/atlasdb/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/atlasdb/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/atlasdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/atlasdb/labels{/name}","releases_url":"https://api.github.com/repos/palantir/atlasdb/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/atlasdb/deployments","created_at":"2015-06-05T23:42:44Z","updated_at":"2018-04-23T12:05:24Z","pushed_at":"2018-04-23T12:25:02Z","git_url":"git://github.com/palantir/atlasdb.git","ssh_url":"git@github.com:palantir/atlasdb.git","clone_url":"https://github.com/palantir/atlasdb.git","svn_url":"https://github.com/palantir/atlasdb","homepage":"http://palantir.github.io/atlasdb/","size":60565,"stargazers_count":580,"watchers_count":580,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":108,"mirror_url":null,"archived":false,"open_issues_count":289,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":108,"open_issues":289,"watchers":580,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/3101"},"html":{"href":"https://github.com/palantir/atlasdb/pull/3101"},"issue":{"href":"https://api.github.com/repos/palantir/atlasdb/issues/3101"},"comments":{"href":"https://api.github.com/repos/palantir/atlasdb/issues/3101/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/3101/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/3101/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/atlasdb/statuses/56df3e16e2d3383c79ad30eab3a63c366f7ba250"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gsheasby"}}