{"action":"created","comment":{"url":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments/193361553","pull_request_review_id":126312830,"id":193361553,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzM2MTU1Mw==","diff_hunk":"@@ -335,7 +335,57 @@ variable +OPENQA_BASEDIR+. The default value is +/var/lib+.\n \n == Running tests of openQA itself\n \n-To execute the testsuite locally, use +make test+. It is also possible to run a\n+There's two ways of executing the testsuite locally:\n+\n+1. with docker\n+\n+  The goal of running the tests with docker is to have consistent tests results (as sometimes the tests have different outcomes because \n+  missing packages or different package versions amongst other reasons). This is the preferred way if the user wants to run a full test\n+  battery or if it needs to setup a test database","path":"docs/Contributing.asciidoc","position":11,"original_position":11,"commit_id":"db2488e961c9f63f25c211712b1733e7adda2f12","original_commit_id":"db2488e961c9f63f25c211712b1733e7adda2f12","user":{"login":"okurz","id":1693432,"node_id":"MDQ6VXNlcjE2OTM0MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/1693432?v=4","gravatar_id":"","url":"https://api.github.com/users/okurz","html_url":"https://github.com/okurz","followers_url":"https://api.github.com/users/okurz/followers","following_url":"https://api.github.com/users/okurz/following{/other_user}","gists_url":"https://api.github.com/users/okurz/gists{/gist_id}","starred_url":"https://api.github.com/users/okurz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okurz/subscriptions","organizations_url":"https://api.github.com/users/okurz/orgs","repos_url":"https://api.github.com/users/okurz/repos","events_url":"https://api.github.com/users/okurz/events{/privacy}","received_events_url":"https://api.github.com/users/okurz/received_events","type":"User","site_admin":false},"body":"Aren't you replacing the local `make test` run in travis with the docker way? This would mean we recommend to the new contributors a way to test locally in a way that is not tested anymore in a CI job? Also, for documentation purposes I would prefer if we can keep \"simple\" instructions first and mention a secondary way as \"advanced\".","created_at":"2018-06-06T10:12:37Z","updated_at":"2018-06-06T10:12:43Z","html_url":"https://github.com/os-autoinst/openQA/pull/1673#discussion_r193361553","pull_request_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/1673","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments/193361553"},"html":{"href":"https://github.com/os-autoinst/openQA/pull/1673#discussion_r193361553"},"pull_request":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/1673"}}},"pull_request":{"url":"https://api.github.com/repos/os-autoinst/openQA/pulls/1673","id":191485272,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNDg1Mjcy","html_url":"https://github.com/os-autoinst/openQA/pull/1673","diff_url":"https://github.com/os-autoinst/openQA/pull/1673.diff","patch_url":"https://github.com/os-autoinst/openQA/pull/1673.patch","issue_url":"https://api.github.com/repos/os-autoinst/openQA/issues/1673","number":1673,"state":"open","locked":false,"title":"Make the tests running in docker","user":{"login":"dasantiago","id":25428608,"node_id":"MDQ6VXNlcjI1NDI4NjA4","avatar_url":"https://avatars3.githubusercontent.com/u/25428608?v=4","gravatar_id":"","url":"https://api.github.com/users/dasantiago","html_url":"https://github.com/dasantiago","followers_url":"https://api.github.com/users/dasantiago/followers","following_url":"https://api.github.com/users/dasantiago/following{/other_user}","gists_url":"https://api.github.com/users/dasantiago/gists{/gist_id}","starred_url":"https://api.github.com/users/dasantiago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dasantiago/subscriptions","organizations_url":"https://api.github.com/users/dasantiago/orgs","repos_url":"https://api.github.com/users/dasantiago/repos","events_url":"https://api.github.com/users/dasantiago/events{/privacy}","received_events_url":"https://api.github.com/users/dasantiago/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-30T15:03:42Z","updated_at":"2018-06-06T10:12:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"732ba0e434cec834f33678310135d009ab01d231","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/1673/commits","review_comments_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/1673/comments","review_comment_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/os-autoinst/openQA/issues/1673/comments","statuses_url":"https://api.github.com/repos/os-autoinst/openQA/statuses/db2488e961c9f63f25c211712b1733e7adda2f12","head":{"label":"dasantiago:35383","ref":"35383","sha":"db2488e961c9f63f25c211712b1733e7adda2f12","user":{"login":"dasantiago","id":25428608,"node_id":"MDQ6VXNlcjI1NDI4NjA4","avatar_url":"https://avatars3.githubusercontent.com/u/25428608?v=4","gravatar_id":"","url":"https://api.github.com/users/dasantiago","html_url":"https://github.com/dasantiago","followers_url":"https://api.github.com/users/dasantiago/followers","following_url":"https://api.github.com/users/dasantiago/following{/other_user}","gists_url":"https://api.github.com/users/dasantiago/gists{/gist_id}","starred_url":"https://api.github.com/users/dasantiago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dasantiago/subscriptions","organizations_url":"https://api.github.com/users/dasantiago/orgs","repos_url":"https://api.github.com/users/dasantiago/repos","events_url":"https://api.github.com/users/dasantiago/events{/privacy}","received_events_url":"https://api.github.com/users/dasantiago/received_events","type":"User","site_admin":false},"repo":{"id":92173238,"node_id":"MDEwOlJlcG9zaXRvcnk5MjE3MzIzOA==","name":"openQA","full_name":"dasantiago/openQA","owner":{"login":"dasantiago","id":25428608,"node_id":"MDQ6VXNlcjI1NDI4NjA4","avatar_url":"https://avatars3.githubusercontent.com/u/25428608?v=4","gravatar_id":"","url":"https://api.github.com/users/dasantiago","html_url":"https://github.com/dasantiago","followers_url":"https://api.github.com/users/dasantiago/followers","following_url":"https://api.github.com/users/dasantiago/following{/other_user}","gists_url":"https://api.github.com/users/dasantiago/gists{/gist_id}","starred_url":"https://api.github.com/users/dasantiago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dasantiago/subscriptions","organizations_url":"https://api.github.com/users/dasantiago/orgs","repos_url":"https://api.github.com/users/dasantiago/repos","events_url":"https://api.github.com/users/dasantiago/events{/privacy}","received_events_url":"https://api.github.com/users/dasantiago/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dasantiago/openQA","description":"openQA web-frontend, scheduler and tools.","fork":true,"url":"https://api.github.com/repos/dasantiago/openQA","forks_url":"https://api.github.com/repos/dasantiago/openQA/forks","keys_url":"https://api.github.com/repos/dasantiago/openQA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dasantiago/openQA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dasantiago/openQA/teams","hooks_url":"https://api.github.com/repos/dasantiago/openQA/hooks","issue_events_url":"https://api.github.com/repos/dasantiago/openQA/issues/events{/number}","events_url":"https://api.github.com/repos/dasantiago/openQA/events","assignees_url":"https://api.github.com/repos/dasantiago/openQA/assignees{/user}","branches_url":"https://api.github.com/repos/dasantiago/openQA/branches{/branch}","tags_url":"https://api.github.com/repos/dasantiago/openQA/tags","blobs_url":"https://api.github.com/repos/dasantiago/openQA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dasantiago/openQA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dasantiago/openQA/git/refs{/sha}","trees_url":"https://api.github.com/repos/dasantiago/openQA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dasantiago/openQA/statuses/{sha}","languages_url":"https://api.github.com/repos/dasantiago/openQA/languages","stargazers_url":"https://api.github.com/repos/dasantiago/openQA/stargazers","contributors_url":"https://api.github.com/repos/dasantiago/openQA/contributors","subscribers_url":"https://api.github.com/repos/dasantiago/openQA/subscribers","subscription_url":"https://api.github.com/repos/dasantiago/openQA/subscription","commits_url":"https://api.github.com/repos/dasantiago/openQA/commits{/sha}","git_commits_url":"https://api.github.com/repos/dasantiago/openQA/git/commits{/sha}","comments_url":"https://api.github.com/repos/dasantiago/openQA/comments{/number}","issue_comment_url":"https://api.github.com/repos/dasantiago/openQA/issues/comments{/number}","contents_url":"https://api.github.com/repos/dasantiago/openQA/contents/{+path}","compare_url":"https://api.github.com/repos/dasantiago/openQA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dasantiago/openQA/merges","archive_url":"https://api.github.com/repos/dasantiago/openQA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dasantiago/openQA/downloads","issues_url":"https://api.github.com/repos/dasantiago/openQA/issues{/number}","pulls_url":"https://api.github.com/repos/dasantiago/openQA/pulls{/number}","milestones_url":"https://api.github.com/repos/dasantiago/openQA/milestones{/number}","notifications_url":"https://api.github.com/repos/dasantiago/openQA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dasantiago/openQA/labels{/name}","releases_url":"https://api.github.com/repos/dasantiago/openQA/releases{/id}","deployments_url":"https://api.github.com/repos/dasantiago/openQA/deployments","created_at":"2017-05-23T13:00:08Z","updated_at":"2018-06-05T11:12:44Z","pushed_at":"2018-06-05T13:25:00Z","git_url":"git://github.com/dasantiago/openQA.git","ssh_url":"git@github.com:dasantiago/openQA.git","clone_url":"https://github.com/dasantiago/openQA.git","svn_url":"https://github.com/dasantiago/openQA","homepage":"http://openqa.opensuse.org/","size":22087,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"os-autoinst:master","ref":"master","sha":"6c0f9c0e03c9e65d2bf8b1a5d1ae490aa990aa6b","user":{"login":"os-autoinst","id":6918706,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTg3MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/6918706?v=4","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"repo":{"id":20883829,"node_id":"MDEwOlJlcG9zaXRvcnkyMDg4MzgyOQ==","name":"openQA","full_name":"os-autoinst/openQA","owner":{"login":"os-autoinst","id":6918706,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTg3MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/6918706?v=4","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/os-autoinst/openQA","description":"openQA web-frontend, scheduler and tools.","fork":false,"url":"https://api.github.com/repos/os-autoinst/openQA","forks_url":"https://api.github.com/repos/os-autoinst/openQA/forks","keys_url":"https://api.github.com/repos/os-autoinst/openQA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/os-autoinst/openQA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/os-autoinst/openQA/teams","hooks_url":"https://api.github.com/repos/os-autoinst/openQA/hooks","issue_events_url":"https://api.github.com/repos/os-autoinst/openQA/issues/events{/number}","events_url":"https://api.github.com/repos/os-autoinst/openQA/events","assignees_url":"https://api.github.com/repos/os-autoinst/openQA/assignees{/user}","branches_url":"https://api.github.com/repos/os-autoinst/openQA/branches{/branch}","tags_url":"https://api.github.com/repos/os-autoinst/openQA/tags","blobs_url":"https://api.github.com/repos/os-autoinst/openQA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/os-autoinst/openQA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/os-autoinst/openQA/git/refs{/sha}","trees_url":"https://api.github.com/repos/os-autoinst/openQA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/os-autoinst/openQA/statuses/{sha}","languages_url":"https://api.github.com/repos/os-autoinst/openQA/languages","stargazers_url":"https://api.github.com/repos/os-autoinst/openQA/stargazers","contributors_url":"https://api.github.com/repos/os-autoinst/openQA/contributors","subscribers_url":"https://api.github.com/repos/os-autoinst/openQA/subscribers","subscription_url":"https://api.github.com/repos/os-autoinst/openQA/subscription","commits_url":"https://api.github.com/repos/os-autoinst/openQA/commits{/sha}","git_commits_url":"https://api.github.com/repos/os-autoinst/openQA/git/commits{/sha}","comments_url":"https://api.github.com/repos/os-autoinst/openQA/comments{/number}","issue_comment_url":"https://api.github.com/repos/os-autoinst/openQA/issues/comments{/number}","contents_url":"https://api.github.com/repos/os-autoinst/openQA/contents/{+path}","compare_url":"https://api.github.com/repos/os-autoinst/openQA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/os-autoinst/openQA/merges","archive_url":"https://api.github.com/repos/os-autoinst/openQA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/os-autoinst/openQA/downloads","issues_url":"https://api.github.com/repos/os-autoinst/openQA/issues{/number}","pulls_url":"https://api.github.com/repos/os-autoinst/openQA/pulls{/number}","milestones_url":"https://api.github.com/repos/os-autoinst/openQA/milestones{/number}","notifications_url":"https://api.github.com/repos/os-autoinst/openQA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/os-autoinst/openQA/labels{/name}","releases_url":"https://api.github.com/repos/os-autoinst/openQA/releases{/id}","deployments_url":"https://api.github.com/repos/os-autoinst/openQA/deployments","created_at":"2014-06-16T12:23:22Z","updated_at":"2018-06-04T18:01:06Z","pushed_at":"2018-06-06T08:33:13Z","git_url":"git://github.com/os-autoinst/openQA.git","ssh_url":"git@github.com:os-autoinst/openQA.git","clone_url":"https://github.com/os-autoinst/openQA.git","svn_url":"https://github.com/os-autoinst/openQA","homepage":"http://openqa.opensuse.org/","size":24121,"stargazers_count":122,"watchers_count":122,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":100,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":100,"open_issues":12,"watchers":122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/1673"},"html":{"href":"https://github.com/os-autoinst/openQA/pull/1673"},"issue":{"href":"https://api.github.com/repos/os-autoinst/openQA/issues/1673"},"comments":{"href":"https://api.github.com/repos/os-autoinst/openQA/issues/1673/comments"},"review_comments":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/1673/comments"},"review_comment":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/1673/commits"},"statuses":{"href":"https://api.github.com/repos/os-autoinst/openQA/statuses/db2488e961c9f63f25c211712b1733e7adda2f12"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"okurz"}}