{"action":"created","comment":{"url":"https://api.github.com/repos/nasa/mmt/pulls/comments/201685463","pull_request_review_id":136234049,"id":201685463,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTY4NTQ2Mw==","diff_hunk":"@@ -5,24 +5,28 @@ def initialize(app)\n \n   def call(env)\n     if env['PATH_INFO'.freeze] == '/status'.freeze\n-      response = [200, { 'Content-Type' => 'application/json' }]\n+      response = [503, { 'Content-Type' => 'application/json' }]\n \n       # checks the database health\n       begin\n         db_healthy = ActiveRecord::Migrator.current_version != 0\n-      rescue StandardError => e\n-        Rails.logger.info \"Database error: #{e}\"","path":"app/middleware/middleware_healthcheck.rb","position":null,"original_position":11,"commit_id":"cf7f61bc8d95bacbc370a631695b53640752dc58","original_commit_id":"cf7f61bc8d95bacbc370a631695b53640752dc58","user":{"login":"charleshuang80","id":1174907,"node_id":"MDQ6VXNlcjExNzQ5MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1174907?v=4","gravatar_id":"","url":"https://api.github.com/users/charleshuang80","html_url":"https://github.com/charleshuang80","followers_url":"https://api.github.com/users/charleshuang80/followers","following_url":"https://api.github.com/users/charleshuang80/following{/other_user}","gists_url":"https://api.github.com/users/charleshuang80/gists{/gist_id}","starred_url":"https://api.github.com/users/charleshuang80/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charleshuang80/subscriptions","organizations_url":"https://api.github.com/users/charleshuang80/orgs","repos_url":"https://api.github.com/users/charleshuang80/repos","events_url":"https://api.github.com/users/charleshuang80/events{/privacy}","received_events_url":"https://api.github.com/users/charleshuang80/received_events","type":"User","site_admin":false},"body":"was there a reason to remove this? seems like it would be helpful to log this error.","created_at":"2018-07-11T13:19:35Z","updated_at":"2018-07-11T13:19:35Z","html_url":"https://github.com/nasa/mmt/pull/268#discussion_r201685463","pull_request_url":"https://api.github.com/repos/nasa/mmt/pulls/268","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/nasa/mmt/pulls/comments/201685463"},"html":{"href":"https://github.com/nasa/mmt/pull/268#discussion_r201685463"},"pull_request":{"href":"https://api.github.com/repos/nasa/mmt/pulls/268"}}},"pull_request":{"url":"https://api.github.com/repos/nasa/mmt/pulls/268","id":198067195,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MDY3MTk1","html_url":"https://github.com/nasa/mmt/pull/268","diff_url":"https://github.com/nasa/mmt/pull/268.diff","patch_url":"https://github.com/nasa/mmt/pull/268.patch","issue_url":"https://api.github.com/repos/nasa/mmt/issues/268","number":268,"state":"open","locked":false,"title":"MMT-873 added a better health check for the status page","user":{"login":"zjam1","id":27049647,"node_id":"MDQ6VXNlcjI3MDQ5NjQ3","avatar_url":"https://avatars3.githubusercontent.com/u/27049647?v=4","gravatar_id":"","url":"https://api.github.com/users/zjam1","html_url":"https://github.com/zjam1","followers_url":"https://api.github.com/users/zjam1/followers","following_url":"https://api.github.com/users/zjam1/following{/other_user}","gists_url":"https://api.github.com/users/zjam1/gists{/gist_id}","starred_url":"https://api.github.com/users/zjam1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zjam1/subscriptions","organizations_url":"https://api.github.com/users/zjam1/orgs","repos_url":"https://api.github.com/users/zjam1/repos","events_url":"https://api.github.com/users/zjam1/events{/privacy}","received_events_url":"https://api.github.com/users/zjam1/received_events","type":"User","site_admin":false},"body":"Added a more in depth health check that looks to make sure a database connection exists and whether Launchpad is working or not. Changed the tests associated with the status page to work as well.","created_at":"2018-06-28T15:24:30Z","updated_at":"2018-07-11T13:19:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9754516af82d63a5ae1a59d93b4176acac113f95","assignee":null,"assignees":[],"requested_reviewers":[{"login":"macrouch","id":171388,"node_id":"MDQ6VXNlcjE3MTM4OA==","avatar_url":"https://avatars3.githubusercontent.com/u/171388?v=4","gravatar_id":"","url":"https://api.github.com/users/macrouch","html_url":"https://github.com/macrouch","followers_url":"https://api.github.com/users/macrouch/followers","following_url":"https://api.github.com/users/macrouch/following{/other_user}","gists_url":"https://api.github.com/users/macrouch/gists{/gist_id}","starred_url":"https://api.github.com/users/macrouch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macrouch/subscriptions","organizations_url":"https://api.github.com/users/macrouch/orgs","repos_url":"https://api.github.com/users/macrouch/repos","events_url":"https://api.github.com/users/macrouch/events{/privacy}","received_events_url":"https://api.github.com/users/macrouch/received_events","type":"User","site_admin":false},{"login":"cgokey","id":22039502,"node_id":"MDQ6VXNlcjIyMDM5NTAy","avatar_url":"https://avatars3.githubusercontent.com/u/22039502?v=4","gravatar_id":"","url":"https://api.github.com/users/cgokey","html_url":"https://github.com/cgokey","followers_url":"https://api.github.com/users/cgokey/followers","following_url":"https://api.github.com/users/cgokey/following{/other_user}","gists_url":"https://api.github.com/users/cgokey/gists{/gist_id}","starred_url":"https://api.github.com/users/cgokey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgokey/subscriptions","organizations_url":"https://api.github.com/users/cgokey/orgs","repos_url":"https://api.github.com/users/cgokey/repos","events_url":"https://api.github.com/users/cgokey/events{/privacy}","received_events_url":"https://api.github.com/users/cgokey/received_events","type":"User","site_admin":false},{"login":"htranho","id":34069728,"node_id":"MDQ6VXNlcjM0MDY5NzI4","avatar_url":"https://avatars3.githubusercontent.com/u/34069728?v=4","gravatar_id":"","url":"https://api.github.com/users/htranho","html_url":"https://github.com/htranho","followers_url":"https://api.github.com/users/htranho/followers","following_url":"https://api.github.com/users/htranho/following{/other_user}","gists_url":"https://api.github.com/users/htranho/gists{/gist_id}","starred_url":"https://api.github.com/users/htranho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htranho/subscriptions","organizations_url":"https://api.github.com/users/htranho/orgs","repos_url":"https://api.github.com/users/htranho/repos","events_url":"https://api.github.com/users/htranho/events{/privacy}","received_events_url":"https://api.github.com/users/htranho/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nasa/mmt/pulls/268/commits","review_comments_url":"https://api.github.com/repos/nasa/mmt/pulls/268/comments","review_comment_url":"https://api.github.com/repos/nasa/mmt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nasa/mmt/issues/268/comments","statuses_url":"https://api.github.com/repos/nasa/mmt/statuses/cf7f61bc8d95bacbc370a631695b53640752dc58","head":{"label":"nasa:MMT-873","ref":"MMT-873","sha":"cf7f61bc8d95bacbc370a631695b53640752dc58","user":{"login":"nasa","id":848102,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0ODEwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/848102?v=4","gravatar_id":"","url":"https://api.github.com/users/nasa","html_url":"https://github.com/nasa","followers_url":"https://api.github.com/users/nasa/followers","following_url":"https://api.github.com/users/nasa/following{/other_user}","gists_url":"https://api.github.com/users/nasa/gists{/gist_id}","starred_url":"https://api.github.com/users/nasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nasa/subscriptions","organizations_url":"https://api.github.com/users/nasa/orgs","repos_url":"https://api.github.com/users/nasa/repos","events_url":"https://api.github.com/users/nasa/events{/privacy}","received_events_url":"https://api.github.com/users/nasa/received_events","type":"Organization","site_admin":false},"repo":{"id":84230476,"node_id":"MDEwOlJlcG9zaXRvcnk4NDIzMDQ3Ng==","name":"mmt","full_name":"nasa/mmt","owner":{"login":"nasa","id":848102,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0ODEwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/848102?v=4","gravatar_id":"","url":"https://api.github.com/users/nasa","html_url":"https://github.com/nasa","followers_url":"https://api.github.com/users/nasa/followers","following_url":"https://api.github.com/users/nasa/following{/other_user}","gists_url":"https://api.github.com/users/nasa/gists{/gist_id}","starred_url":"https://api.github.com/users/nasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nasa/subscriptions","organizations_url":"https://api.github.com/users/nasa/orgs","repos_url":"https://api.github.com/users/nasa/repos","events_url":"https://api.github.com/users/nasa/events{/privacy}","received_events_url":"https://api.github.com/users/nasa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nasa/mmt","description":"NASA's Metadata Management Tool.","fork":false,"url":"https://api.github.com/repos/nasa/mmt","forks_url":"https://api.github.com/repos/nasa/mmt/forks","keys_url":"https://api.github.com/repos/nasa/mmt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nasa/mmt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nasa/mmt/teams","hooks_url":"https://api.github.com/repos/nasa/mmt/hooks","issue_events_url":"https://api.github.com/repos/nasa/mmt/issues/events{/number}","events_url":"https://api.github.com/repos/nasa/mmt/events","assignees_url":"https://api.github.com/repos/nasa/mmt/assignees{/user}","branches_url":"https://api.github.com/repos/nasa/mmt/branches{/branch}","tags_url":"https://api.github.com/repos/nasa/mmt/tags","blobs_url":"https://api.github.com/repos/nasa/mmt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nasa/mmt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nasa/mmt/git/refs{/sha}","trees_url":"https://api.github.com/repos/nasa/mmt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nasa/mmt/statuses/{sha}","languages_url":"https://api.github.com/repos/nasa/mmt/languages","stargazers_url":"https://api.github.com/repos/nasa/mmt/stargazers","contributors_url":"https://api.github.com/repos/nasa/mmt/contributors","subscribers_url":"https://api.github.com/repos/nasa/mmt/subscribers","subscription_url":"https://api.github.com/repos/nasa/mmt/subscription","commits_url":"https://api.github.com/repos/nasa/mmt/commits{/sha}","git_commits_url":"https://api.github.com/repos/nasa/mmt/git/commits{/sha}","comments_url":"https://api.github.com/repos/nasa/mmt/comments{/number}","issue_comment_url":"https://api.github.com/repos/nasa/mmt/issues/comments{/number}","contents_url":"https://api.github.com/repos/nasa/mmt/contents/{+path}","compare_url":"https://api.github.com/repos/nasa/mmt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nasa/mmt/merges","archive_url":"https://api.github.com/repos/nasa/mmt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nasa/mmt/downloads","issues_url":"https://api.github.com/repos/nasa/mmt/issues{/number}","pulls_url":"https://api.github.com/repos/nasa/mmt/pulls{/number}","milestones_url":"https://api.github.com/repos/nasa/mmt/milestones{/number}","notifications_url":"https://api.github.com/repos/nasa/mmt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nasa/mmt/labels{/name}","releases_url":"https://api.github.com/repos/nasa/mmt/releases{/id}","deployments_url":"https://api.github.com/repos/nasa/mmt/deployments","created_at":"2017-03-07T18:03:55Z","updated_at":"2018-07-10T17:13:47Z","pushed_at":"2018-07-11T12:56:42Z","git_url":"git://github.com/nasa/mmt.git","ssh_url":"git@github.com:nasa/mmt.git","clone_url":"https://github.com/nasa/mmt.git","svn_url":"https://github.com/nasa/mmt","homepage":null,"size":10421,"stargazers_count":26,"watchers_count":26,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":17,"open_issues":4,"watchers":26,"default_branch":"master"}},"base":{"label":"nasa:master","ref":"master","sha":"32bb8374e5f99821333d29672b6c5c2acab09870","user":{"login":"nasa","id":848102,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0ODEwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/848102?v=4","gravatar_id":"","url":"https://api.github.com/users/nasa","html_url":"https://github.com/nasa","followers_url":"https://api.github.com/users/nasa/followers","following_url":"https://api.github.com/users/nasa/following{/other_user}","gists_url":"https://api.github.com/users/nasa/gists{/gist_id}","starred_url":"https://api.github.com/users/nasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nasa/subscriptions","organizations_url":"https://api.github.com/users/nasa/orgs","repos_url":"https://api.github.com/users/nasa/repos","events_url":"https://api.github.com/users/nasa/events{/privacy}","received_events_url":"https://api.github.com/users/nasa/received_events","type":"Organization","site_admin":false},"repo":{"id":84230476,"node_id":"MDEwOlJlcG9zaXRvcnk4NDIzMDQ3Ng==","name":"mmt","full_name":"nasa/mmt","owner":{"login":"nasa","id":848102,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0ODEwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/848102?v=4","gravatar_id":"","url":"https://api.github.com/users/nasa","html_url":"https://github.com/nasa","followers_url":"https://api.github.com/users/nasa/followers","following_url":"https://api.github.com/users/nasa/following{/other_user}","gists_url":"https://api.github.com/users/nasa/gists{/gist_id}","starred_url":"https://api.github.com/users/nasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nasa/subscriptions","organizations_url":"https://api.github.com/users/nasa/orgs","repos_url":"https://api.github.com/users/nasa/repos","events_url":"https://api.github.com/users/nasa/events{/privacy}","received_events_url":"https://api.github.com/users/nasa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nasa/mmt","description":"NASA's Metadata Management Tool.","fork":false,"url":"https://api.github.com/repos/nasa/mmt","forks_url":"https://api.github.com/repos/nasa/mmt/forks","keys_url":"https://api.github.com/repos/nasa/mmt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nasa/mmt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nasa/mmt/teams","hooks_url":"https://api.github.com/repos/nasa/mmt/hooks","issue_events_url":"https://api.github.com/repos/nasa/mmt/issues/events{/number}","events_url":"https://api.github.com/repos/nasa/mmt/events","assignees_url":"https://api.github.com/repos/nasa/mmt/assignees{/user}","branches_url":"https://api.github.com/repos/nasa/mmt/branches{/branch}","tags_url":"https://api.github.com/repos/nasa/mmt/tags","blobs_url":"https://api.github.com/repos/nasa/mmt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nasa/mmt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nasa/mmt/git/refs{/sha}","trees_url":"https://api.github.com/repos/nasa/mmt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nasa/mmt/statuses/{sha}","languages_url":"https://api.github.com/repos/nasa/mmt/languages","stargazers_url":"https://api.github.com/repos/nasa/mmt/stargazers","contributors_url":"https://api.github.com/repos/nasa/mmt/contributors","subscribers_url":"https://api.github.com/repos/nasa/mmt/subscribers","subscription_url":"https://api.github.com/repos/nasa/mmt/subscription","commits_url":"https://api.github.com/repos/nasa/mmt/commits{/sha}","git_commits_url":"https://api.github.com/repos/nasa/mmt/git/commits{/sha}","comments_url":"https://api.github.com/repos/nasa/mmt/comments{/number}","issue_comment_url":"https://api.github.com/repos/nasa/mmt/issues/comments{/number}","contents_url":"https://api.github.com/repos/nasa/mmt/contents/{+path}","compare_url":"https://api.github.com/repos/nasa/mmt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nasa/mmt/merges","archive_url":"https://api.github.com/repos/nasa/mmt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nasa/mmt/downloads","issues_url":"https://api.github.com/repos/nasa/mmt/issues{/number}","pulls_url":"https://api.github.com/repos/nasa/mmt/pulls{/number}","milestones_url":"https://api.github.com/repos/nasa/mmt/milestones{/number}","notifications_url":"https://api.github.com/repos/nasa/mmt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nasa/mmt/labels{/name}","releases_url":"https://api.github.com/repos/nasa/mmt/releases{/id}","deployments_url":"https://api.github.com/repos/nasa/mmt/deployments","created_at":"2017-03-07T18:03:55Z","updated_at":"2018-07-10T17:13:47Z","pushed_at":"2018-07-11T12:56:42Z","git_url":"git://github.com/nasa/mmt.git","ssh_url":"git@github.com:nasa/mmt.git","clone_url":"https://github.com/nasa/mmt.git","svn_url":"https://github.com/nasa/mmt","homepage":null,"size":10421,"stargazers_count":26,"watchers_count":26,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":17,"open_issues":4,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nasa/mmt/pulls/268"},"html":{"href":"https://github.com/nasa/mmt/pull/268"},"issue":{"href":"https://api.github.com/repos/nasa/mmt/issues/268"},"comments":{"href":"https://api.github.com/repos/nasa/mmt/issues/268/comments"},"review_comments":{"href":"https://api.github.com/repos/nasa/mmt/pulls/268/comments"},"review_comment":{"href":"https://api.github.com/repos/nasa/mmt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nasa/mmt/pulls/268/commits"},"statuses":{"href":"https://api.github.com/repos/nasa/mmt/statuses/cf7f61bc8d95bacbc370a631695b53640752dc58"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"charleshuang80"}}