{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/213600517","pull_request_review_id":150468332,"id":213600517,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzYwMDUxNw==","diff_hunk":"@@ -39,11 +39,7 @@ impl PartialEq for ScheduledEvent {\n impl TimerScheduler {\n     pub fn start() -> IpcSender<TimerSchedulerMsg> {\n         let (req_ipc_sender, req_ipc_receiver) = ipc::channel().expect(\"Channel creation failed.\");\n-<<<<<<< HEAD\n-        let (req_sender, req_receiver) = mpsc::sync_channel(1);\n-=======\n         let (req_sender, req_receiver) = base_channel::bounded(1);\n->>>>>>> f88905f60a... channel","path":"components/constellation/timer_scheduler.rs","position":null,"original_position":19,"commit_id":"dd3ac1e04adfaf99c5642481d2efcfb835581208","original_commit_id":"c17307e23b9f2c1cd0ca8aacf13927c350104858","user":{"login":"gterzian","id":2792687,"node_id":"MDQ6VXNlcjI3OTI2ODc=","avatar_url":"https://avatars2.githubusercontent.com/u/2792687?v=4","gravatar_id":"","url":"https://api.github.com/users/gterzian","html_url":"https://github.com/gterzian","followers_url":"https://api.github.com/users/gterzian/followers","following_url":"https://api.github.com/users/gterzian/following{/other_user}","gists_url":"https://api.github.com/users/gterzian/gists{/gist_id}","starred_url":"https://api.github.com/users/gterzian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gterzian/subscriptions","organizations_url":"https://api.github.com/users/gterzian/orgs","repos_url":"https://api.github.com/users/gterzian/repos","events_url":"https://api.github.com/users/gterzian/events{/privacy}","received_events_url":"https://api.github.com/users/gterzian/received_events","type":"User","site_admin":false},"body":"oops, this one slipped through...","created_at":"2018-08-29T09:07:53Z","updated_at":"2018-08-29T09:07:53Z","html_url":"https://github.com/servo/servo/pull/21325#discussion_r213600517","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/21325","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/213600517"},"html":{"href":"https://github.com/servo/servo/pull/21325#discussion_r213600517"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/21325"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/21325","id":205787729,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1Nzg3NzI5","html_url":"https://github.com/servo/servo/pull/21325","diff_url":"https://github.com/servo/servo/pull/21325.diff","patch_url":"https://github.com/servo/servo/pull/21325.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/21325","number":21325,"state":"open","locked":false,"title":"Replace mpsc with crossbeam-channel","user":{"login":"gterzian","id":2792687,"node_id":"MDQ6VXNlcjI3OTI2ODc=","avatar_url":"https://avatars2.githubusercontent.com/u/2792687?v=4","gravatar_id":"","url":"https://api.github.com/users/gterzian","html_url":"https://github.com/gterzian","followers_url":"https://api.github.com/users/gterzian/followers","following_url":"https://api.github.com/users/gterzian/following{/other_user}","gists_url":"https://api.github.com/users/gterzian/gists{/gist_id}","starred_url":"https://api.github.com/users/gterzian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gterzian/subscriptions","organizations_url":"https://api.github.com/users/gterzian/orgs","repos_url":"https://api.github.com/users/gterzian/repos","events_url":"https://api.github.com/users/gterzian/events{/privacy}","received_events_url":"https://api.github.com/users/gterzian/received_events","type":"User","site_admin":false},"body":"Follow up on https://github.com/servo/servo/pull/19515\r\n\r\n---\r\n\r\nSelecting over multiple channels in `std::sync::mpsc` is not stable and likely never will be:\r\n\r\nhttps://github.com/rust-lang/rust/issues/27800#issuecomment-260136777\r\n> It seems the only thing keeping `mpsc_select` around is Servo.\r\n\r\ncrossbeam-channel is designed specifically to replace `std::sync::mpsc` and fix many of its shortcomings:\r\nhttps://github.com/stjepang/rfcs-crossbeam/blob/channel/text/2017-11-09-channel.md\r\n\r\nThis is to be landed together with https://github.com/servo/ipc-channel/pull/183.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/21325)\r\n<!-- Reviewable:end -->\r\n","created_at":"2018-08-02T16:10:32Z","updated_at":"2018-08-29T09:07:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2fb64a0ac451e260c0c19016670f75f8699d1aff","assignee":{"login":"gw3583","id":39062770,"node_id":"MDQ6VXNlcjM5MDYyNzcw","avatar_url":"https://avatars0.githubusercontent.com/u/39062770?v=4","gravatar_id":"","url":"https://api.github.com/users/gw3583","html_url":"https://github.com/gw3583","followers_url":"https://api.github.com/users/gw3583/followers","following_url":"https://api.github.com/users/gw3583/following{/other_user}","gists_url":"https://api.github.com/users/gw3583/gists{/gist_id}","starred_url":"https://api.github.com/users/gw3583/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gw3583/subscriptions","organizations_url":"https://api.github.com/users/gw3583/orgs","repos_url":"https://api.github.com/users/gw3583/repos","events_url":"https://api.github.com/users/gw3583/events{/privacy}","received_events_url":"https://api.github.com/users/gw3583/received_events","type":"User","site_admin":false},"assignees":[{"login":"gw3583","id":39062770,"node_id":"MDQ6VXNlcjM5MDYyNzcw","avatar_url":"https://avatars0.githubusercontent.com/u/39062770?v=4","gravatar_id":"","url":"https://api.github.com/users/gw3583","html_url":"https://github.com/gw3583","followers_url":"https://api.github.com/users/gw3583/followers","following_url":"https://api.github.com/users/gw3583/following{/other_user}","gists_url":"https://api.github.com/users/gw3583/gists{/gist_id}","starred_url":"https://api.github.com/users/gw3583/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gw3583/subscriptions","organizations_url":"https://api.github.com/users/gw3583/orgs","repos_url":"https://api.github.com/users/gw3583/repos","events_url":"https://api.github.com/users/gw3583/events{/privacy}","received_events_url":"https://api.github.com/users/gw3583/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":152310043,"node_id":"MDU6TGFiZWwxNTIzMTAwNDM=","url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-review","name":"S-awaiting-review","color":"d4c5f9","default":false},{"id":152311003,"node_id":"MDU6TGFiZWwxNTIzMTEwMDM=","url":"https://api.github.com/repos/servo/servo/labels/S-needs-rebase","name":"S-needs-rebase","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/21325/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/21325/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/21325/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/dd3ac1e04adfaf99c5642481d2efcfb835581208","head":{"label":"gterzian:crossbeam_integration","ref":"crossbeam_integration","sha":"dd3ac1e04adfaf99c5642481d2efcfb835581208","user":{"login":"gterzian","id":2792687,"node_id":"MDQ6VXNlcjI3OTI2ODc=","avatar_url":"https://avatars2.githubusercontent.com/u/2792687?v=4","gravatar_id":"","url":"https://api.github.com/users/gterzian","html_url":"https://github.com/gterzian","followers_url":"https://api.github.com/users/gterzian/followers","following_url":"https://api.github.com/users/gterzian/following{/other_user}","gists_url":"https://api.github.com/users/gterzian/gists{/gist_id}","starred_url":"https://api.github.com/users/gterzian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gterzian/subscriptions","organizations_url":"https://api.github.com/users/gterzian/orgs","repos_url":"https://api.github.com/users/gterzian/repos","events_url":"https://api.github.com/users/gterzian/events{/privacy}","received_events_url":"https://api.github.com/users/gterzian/received_events","type":"User","site_admin":false},"repo":{"id":69109740,"node_id":"MDEwOlJlcG9zaXRvcnk2OTEwOTc0MA==","name":"servo","full_name":"gterzian/servo","owner":{"login":"gterzian","id":2792687,"node_id":"MDQ6VXNlcjI3OTI2ODc=","avatar_url":"https://avatars2.githubusercontent.com/u/2792687?v=4","gravatar_id":"","url":"https://api.github.com/users/gterzian","html_url":"https://github.com/gterzian","followers_url":"https://api.github.com/users/gterzian/followers","following_url":"https://api.github.com/users/gterzian/following{/other_user}","gists_url":"https://api.github.com/users/gterzian/gists{/gist_id}","starred_url":"https://api.github.com/users/gterzian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gterzian/subscriptions","organizations_url":"https://api.github.com/users/gterzian/orgs","repos_url":"https://api.github.com/users/gterzian/repos","events_url":"https://api.github.com/users/gterzian/events{/privacy}","received_events_url":"https://api.github.com/users/gterzian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gterzian/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/gterzian/servo","forks_url":"https://api.github.com/repos/gterzian/servo/forks","keys_url":"https://api.github.com/repos/gterzian/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gterzian/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gterzian/servo/teams","hooks_url":"https://api.github.com/repos/gterzian/servo/hooks","issue_events_url":"https://api.github.com/repos/gterzian/servo/issues/events{/number}","events_url":"https://api.github.com/repos/gterzian/servo/events","assignees_url":"https://api.github.com/repos/gterzian/servo/assignees{/user}","branches_url":"https://api.github.com/repos/gterzian/servo/branches{/branch}","tags_url":"https://api.github.com/repos/gterzian/servo/tags","blobs_url":"https://api.github.com/repos/gterzian/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gterzian/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gterzian/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/gterzian/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gterzian/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/gterzian/servo/languages","stargazers_url":"https://api.github.com/repos/gterzian/servo/stargazers","contributors_url":"https://api.github.com/repos/gterzian/servo/contributors","subscribers_url":"https://api.github.com/repos/gterzian/servo/subscribers","subscription_url":"https://api.github.com/repos/gterzian/servo/subscription","commits_url":"https://api.github.com/repos/gterzian/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/gterzian/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/gterzian/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/gterzian/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/gterzian/servo/contents/{+path}","compare_url":"https://api.github.com/repos/gterzian/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gterzian/servo/merges","archive_url":"https://api.github.com/repos/gterzian/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gterzian/servo/downloads","issues_url":"https://api.github.com/repos/gterzian/servo/issues{/number}","pulls_url":"https://api.github.com/repos/gterzian/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/gterzian/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/gterzian/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gterzian/servo/labels{/name}","releases_url":"https://api.github.com/repos/gterzian/servo/releases{/id}","deployments_url":"https://api.github.com/repos/gterzian/servo/deployments","created_at":"2016-09-24T15:15:52Z","updated_at":"2018-08-24T18:34:33Z","pushed_at":"2018-08-29T08:01:57Z","git_url":"git://github.com/gterzian/servo.git","ssh_url":"git@github.com:gterzian/servo.git","clone_url":"https://github.com/gterzian/servo.git","svn_url":"https://github.com/gterzian/servo","homepage":"https://servo.org/","size":433856,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"9e1ec1d5bbc22842c10633ce51ff07fd9d06e9ad","user":{"login":"servo","id":2566135,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjYxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/2566135?v=4","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"node_id":"MDEwOlJlcG9zaXRvcnkzMzkwMjQz","name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjYxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/2566135?v=4","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","deployments_url":"https://api.github.com/repos/servo/servo/deployments","created_at":"2012-02-08T19:07:25Z","updated_at":"2018-08-29T07:38:14Z","pushed_at":"2018-08-29T09:05:52Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"https://servo.org/","size":571846,"stargazers_count":12269,"watchers_count":12269,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1950,"mirror_url":null,"archived":false,"open_issues_count":2377,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":1950,"open_issues":2377,"watchers":12269,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/21325"},"html":{"href":"https://github.com/servo/servo/pull/21325"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/21325"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/21325/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/21325/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/21325/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/dd3ac1e04adfaf99c5642481d2efcfb835581208"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gterzian"}}