{"action":"closed","number":21747,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/21747","id":200661217,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNjYxMjE3","html_url":"https://github.com/apache/spark/pull/21747","diff_url":"https://github.com/apache/spark/pull/21747.diff","patch_url":"https://github.com/apache/spark/pull/21747.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/21747","number":21747,"state":"closed","locked":false,"title":"[SPARK-24165][SQL][branch-2.3] Fixing conditional expressions to handle nullability of nested types","user":{"login":"mn-mikke","id":3674621,"node_id":"MDQ6VXNlcjM2NzQ2MjE=","avatar_url":"https://avatars3.githubusercontent.com/u/3674621?v=4","gravatar_id":"","url":"https://api.github.com/users/mn-mikke","html_url":"https://github.com/mn-mikke","followers_url":"https://api.github.com/users/mn-mikke/followers","following_url":"https://api.github.com/users/mn-mikke/following{/other_user}","gists_url":"https://api.github.com/users/mn-mikke/gists{/gist_id}","starred_url":"https://api.github.com/users/mn-mikke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mn-mikke/subscriptions","organizations_url":"https://api.github.com/users/mn-mikke/orgs","repos_url":"https://api.github.com/users/mn-mikke/repos","events_url":"https://api.github.com/users/mn-mikke/events{/privacy}","received_events_url":"https://api.github.com/users/mn-mikke/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\nThis PR is proposing a fix for the output data type of ```If``` and ```CaseWhen``` expression. Upon till now, the implementation of exprassions has ignored nullability of nested types from different execution branches and returned the type of the first branch.\r\n\r\nThis could lead to an unwanted ```NullPointerException``` from other expressions depending on a ```If```/```CaseWhen``` expression.\r\n\r\nExample:\r\n```\r\nval rows = new util.ArrayList[Row]()\r\nrows.add(Row(true, (\"a\", 1)))\r\nrows.add(Row(false, (null, 2)))\r\nval schema = StructType(Seq(\r\n  StructField(\"cond\", BooleanType, false),\r\n  StructField(\"s\", StructType(Seq(\r\n    StructField(\"val1\", StringType, true),\r\n    StructField(\"val2\", IntegerType, false)\r\n  )), false)\r\n))\r\n\r\nval df = spark.createDataFrame(rows, schema)\r\n\r\ndf\r\n  .select(when('cond, struct(lit(\"x\").as(\"val1\"), lit(10).as(\"val2\"))).otherwise('s) as \"res\")\r\n  .select('res.getField(\"val1\"))\r\n  .show()\r\n```\r\nException:\r\n```\r\nException in thread \"main\" java.lang.NullPointerException\r\n\tat org.apache.spark.sql.catalyst.expressions.codegen.UnsafeWriter.write(UnsafeWriter.java:109)\r\n\tat org.apache.spark.sql.catalyst.expressions.GeneratedClass$SpecificUnsafeProjection.apply(Unknown Source)\r\n\tat org.apache.spark.sql.execution.LocalTableScanExec$$anonfun$unsafeRows$1.apply(LocalTableScanExec.scala:44)\r\n\tat org.apache.spark.sql.execution.LocalTableScanExec$$anonfun$unsafeRows$1.apply(LocalTableScanExec.scala:44)\r\n...\r\n```\r\nOutput schema:\r\n```\r\nroot\r\n |-- res.val1: string (nullable = false)\r\n```\r\n\r\n## How was this patch tested?\r\nNew test cases added into\r\n- DataFrameSuite.scala\r\n- conditionalExpressions.scala","created_at":"2018-07-11T10:55:34Z","updated_at":"2018-09-24T13:49:01Z","closed_at":"2018-09-24T13:49:01Z","merged_at":null,"merge_commit_sha":"90ff83b99f59967956410d6623e3dd58a43d0dbb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/21747/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/21747/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/21747/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/4b42c7870df1447a3d8b8d5c94176e07f043ce06","head":{"label":"mn-mikke:SPARK-24165-branch-2.3","ref":"SPARK-24165-branch-2.3","sha":"4b42c7870df1447a3d8b8d5c94176e07f043ce06","user":{"login":"mn-mikke","id":3674621,"node_id":"MDQ6VXNlcjM2NzQ2MjE=","avatar_url":"https://avatars3.githubusercontent.com/u/3674621?v=4","gravatar_id":"","url":"https://api.github.com/users/mn-mikke","html_url":"https://github.com/mn-mikke","followers_url":"https://api.github.com/users/mn-mikke/followers","following_url":"https://api.github.com/users/mn-mikke/following{/other_user}","gists_url":"https://api.github.com/users/mn-mikke/gists{/gist_id}","starred_url":"https://api.github.com/users/mn-mikke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mn-mikke/subscriptions","organizations_url":"https://api.github.com/users/mn-mikke/orgs","repos_url":"https://api.github.com/users/mn-mikke/repos","events_url":"https://api.github.com/users/mn-mikke/events{/privacy}","received_events_url":"https://api.github.com/users/mn-mikke/received_events","type":"User","site_admin":false},"repo":{"id":116154315,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYxNTQzMTU=","name":"spark","full_name":"mn-mikke/spark","private":false,"owner":{"login":"mn-mikke","id":3674621,"node_id":"MDQ6VXNlcjM2NzQ2MjE=","avatar_url":"https://avatars3.githubusercontent.com/u/3674621?v=4","gravatar_id":"","url":"https://api.github.com/users/mn-mikke","html_url":"https://github.com/mn-mikke","followers_url":"https://api.github.com/users/mn-mikke/followers","following_url":"https://api.github.com/users/mn-mikke/following{/other_user}","gists_url":"https://api.github.com/users/mn-mikke/gists{/gist_id}","starred_url":"https://api.github.com/users/mn-mikke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mn-mikke/subscriptions","organizations_url":"https://api.github.com/users/mn-mikke/orgs","repos_url":"https://api.github.com/users/mn-mikke/repos","events_url":"https://api.github.com/users/mn-mikke/events{/privacy}","received_events_url":"https://api.github.com/users/mn-mikke/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mn-mikke/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/mn-mikke/spark","forks_url":"https://api.github.com/repos/mn-mikke/spark/forks","keys_url":"https://api.github.com/repos/mn-mikke/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mn-mikke/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mn-mikke/spark/teams","hooks_url":"https://api.github.com/repos/mn-mikke/spark/hooks","issue_events_url":"https://api.github.com/repos/mn-mikke/spark/issues/events{/number}","events_url":"https://api.github.com/repos/mn-mikke/spark/events","assignees_url":"https://api.github.com/repos/mn-mikke/spark/assignees{/user}","branches_url":"https://api.github.com/repos/mn-mikke/spark/branches{/branch}","tags_url":"https://api.github.com/repos/mn-mikke/spark/tags","blobs_url":"https://api.github.com/repos/mn-mikke/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mn-mikke/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mn-mikke/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/mn-mikke/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mn-mikke/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/mn-mikke/spark/languages","stargazers_url":"https://api.github.com/repos/mn-mikke/spark/stargazers","contributors_url":"https://api.github.com/repos/mn-mikke/spark/contributors","subscribers_url":"https://api.github.com/repos/mn-mikke/spark/subscribers","subscription_url":"https://api.github.com/repos/mn-mikke/spark/subscription","commits_url":"https://api.github.com/repos/mn-mikke/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/mn-mikke/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/mn-mikke/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/mn-mikke/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/mn-mikke/spark/contents/{+path}","compare_url":"https://api.github.com/repos/mn-mikke/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mn-mikke/spark/merges","archive_url":"https://api.github.com/repos/mn-mikke/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mn-mikke/spark/downloads","issues_url":"https://api.github.com/repos/mn-mikke/spark/issues{/number}","pulls_url":"https://api.github.com/repos/mn-mikke/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/mn-mikke/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/mn-mikke/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mn-mikke/spark/labels{/name}","releases_url":"https://api.github.com/repos/mn-mikke/spark/releases{/id}","deployments_url":"https://api.github.com/repos/mn-mikke/spark/deployments","created_at":"2018-01-03T15:48:07Z","updated_at":"2018-04-21T15:37:46Z","pushed_at":"2018-09-20T09:42:24Z","git_url":"git://github.com/mn-mikke/spark.git","ssh_url":"git@github.com:mn-mikke/spark.git","clone_url":"https://github.com/mn-mikke/spark.git","svn_url":"https://github.com/mn-mikke/spark","homepage":null,"size":281438,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:branch-2.3","ref":"branch-2.3","sha":"86457a16de20eb126d0569d12f51b2e427fd03c3","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE2NTY1OA==","name":"spark","full_name":"apache/spark","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2018-09-24T13:42:16Z","pushed_at":"2018-09-24T13:44:03Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":282721,"stargazers_count":18878,"watchers_count":18878,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16987,"mirror_url":null,"archived":false,"open_issues_count":514,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":16987,"open_issues":514,"watchers":18878,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/21747"},"html":{"href":"https://github.com/apache/spark/pull/21747"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/21747"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/21747/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/21747/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/21747/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/4b42c7870df1447a3d8b8d5c94176e07f043ce06"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":21,"review_comments":3,"maintainer_can_modify":false,"commits":3,"additions":197,"deletions":20,"changed_files":5}}
{"actor":{"display_login":"mn-mikke"}}