{"action":"created","comment":{"url":"https://api.github.com/repos/publiclab/plots2/pulls/comments/192795101","pull_request_review_id":125639718,"id":192795101,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Mjc5NTEwMQ==","diff_hunk":"@@ -303,4 +303,13 @@ def followers\n   def set_user\n     @user = User.find_by(username: params[:id])\n   end\n+  private\n+    def user_params\n+        params.require(:user).permit(:username, :email, :password, :password_confirmation, :openid_identifier, :key, :photo, :photo_file_name, :bio, :status)\n+    end\n+\tdef spamaway_params","path":"app/controllers/users_controller.rb","position":49,"original_position":49,"commit_id":"0231d62f452a27baf90bb2b53484ed8a2a1745e3","original_commit_id":"0231d62f452a27baf90bb2b53484ed8a2a1745e3","user":{"login":"siaw23","id":4806407,"node_id":"MDQ6VXNlcjQ4MDY0MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/4806407?v=4","gravatar_id":"","url":"https://api.github.com/users/siaw23","html_url":"https://github.com/siaw23","followers_url":"https://api.github.com/users/siaw23/followers","following_url":"https://api.github.com/users/siaw23/following{/other_user}","gists_url":"https://api.github.com/users/siaw23/gists{/gist_id}","starred_url":"https://api.github.com/users/siaw23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siaw23/subscriptions","organizations_url":"https://api.github.com/users/siaw23/orgs","repos_url":"https://api.github.com/users/siaw23/repos","events_url":"https://api.github.com/users/siaw23/events{/privacy}","received_events_url":"https://api.github.com/users/siaw23/received_events","type":"User","site_admin":false},"body":"One of the reasons I wanted us to have Rubocop on CI....","created_at":"2018-06-04T16:03:48Z","updated_at":"2018-06-04T16:03:48Z","html_url":"https://github.com/publiclab/plots2/pull/2726#discussion_r192795101","pull_request_url":"https://api.github.com/repos/publiclab/plots2/pulls/2726","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/publiclab/plots2/pulls/comments/192795101"},"html":{"href":"https://github.com/publiclab/plots2/pull/2726#discussion_r192795101"},"pull_request":{"href":"https://api.github.com/repos/publiclab/plots2/pulls/2726"}},"in_reply_to_id":192785443},"pull_request":{"url":"https://api.github.com/repos/publiclab/plots2/pulls/2726","id":187634791,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg3NjM0Nzkx","html_url":"https://github.com/publiclab/plots2/pull/2726","diff_url":"https://github.com/publiclab/plots2/pull/2726.diff","patch_url":"https://github.com/publiclab/plots2/pull/2726.patch","issue_url":"https://api.github.com/repos/publiclab/plots2/issues/2726","number":2726,"state":"open","locked":false,"title":"Rails 5.0 upgrade","user":{"login":"Souravirus","id":17192149,"node_id":"MDQ6VXNlcjE3MTkyMTQ5","avatar_url":"https://avatars3.githubusercontent.com/u/17192149?v=4","gravatar_id":"","url":"https://api.github.com/users/Souravirus","html_url":"https://github.com/Souravirus","followers_url":"https://api.github.com/users/Souravirus/followers","following_url":"https://api.github.com/users/Souravirus/following{/other_user}","gists_url":"https://api.github.com/users/Souravirus/gists{/gist_id}","starred_url":"https://api.github.com/users/Souravirus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Souravirus/subscriptions","organizations_url":"https://api.github.com/users/Souravirus/orgs","repos_url":"https://api.github.com/users/Souravirus/repos","events_url":"https://api.github.com/users/Souravirus/events{/privacy}","received_events_url":"https://api.github.com/users/Souravirus/received_events","type":"User","site_admin":false},"body":"Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. \r\nStarts #2714 \r\nThanks!\r\n\r\n* [x] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with `rake test`\r\n* [X] code is in uniquely-named feature branch and has no merge conflicts\r\n* [X] PR is descriptively titled\r\n* [X] PR body includes `fixes #0000`-style reference to original issue #\r\n* [x] ask `@publiclab/reviewers` for help, in a comment below\r\n\r\n> We're happy to help you get this ready -- don't be afraid to ask for help, and **don't be discouraged** if your tests fail at first!\r\n\r\nIf tests do fail, click on the red `X` to learn why by reading the logs.\r\n\r\nPlease be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software\r\n\r\nWe have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays. \r\n\r\nThanks!\r\n","created_at":"2018-05-12T18:46:57Z","updated_at":"2018-06-04T16:03:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2cb8ee1ba21188c92f6f55bf06364d07cab75e8","assignee":{"login":"Souravirus","id":17192149,"node_id":"MDQ6VXNlcjE3MTkyMTQ5","avatar_url":"https://avatars3.githubusercontent.com/u/17192149?v=4","gravatar_id":"","url":"https://api.github.com/users/Souravirus","html_url":"https://github.com/Souravirus","followers_url":"https://api.github.com/users/Souravirus/followers","following_url":"https://api.github.com/users/Souravirus/following{/other_user}","gists_url":"https://api.github.com/users/Souravirus/gists{/gist_id}","starred_url":"https://api.github.com/users/Souravirus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Souravirus/subscriptions","organizations_url":"https://api.github.com/users/Souravirus/orgs","repos_url":"https://api.github.com/users/Souravirus/repos","events_url":"https://api.github.com/users/Souravirus/events{/privacy}","received_events_url":"https://api.github.com/users/Souravirus/received_events","type":"User","site_admin":false},"assignees":[{"login":"siaw23","id":4806407,"node_id":"MDQ6VXNlcjQ4MDY0MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/4806407?v=4","gravatar_id":"","url":"https://api.github.com/users/siaw23","html_url":"https://github.com/siaw23","followers_url":"https://api.github.com/users/siaw23/followers","following_url":"https://api.github.com/users/siaw23/following{/other_user}","gists_url":"https://api.github.com/users/siaw23/gists{/gist_id}","starred_url":"https://api.github.com/users/siaw23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siaw23/subscriptions","organizations_url":"https://api.github.com/users/siaw23/orgs","repos_url":"https://api.github.com/users/siaw23/repos","events_url":"https://api.github.com/users/siaw23/events{/privacy}","received_events_url":"https://api.github.com/users/siaw23/received_events","type":"User","site_admin":false},{"login":"Souravirus","id":17192149,"node_id":"MDQ6VXNlcjE3MTkyMTQ5","avatar_url":"https://avatars3.githubusercontent.com/u/17192149?v=4","gravatar_id":"","url":"https://api.github.com/users/Souravirus","html_url":"https://github.com/Souravirus","followers_url":"https://api.github.com/users/Souravirus/followers","following_url":"https://api.github.com/users/Souravirus/following{/other_user}","gists_url":"https://api.github.com/users/Souravirus/gists{/gist_id}","starred_url":"https://api.github.com/users/Souravirus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Souravirus/subscriptions","organizations_url":"https://api.github.com/users/Souravirus/orgs","repos_url":"https://api.github.com/users/Souravirus/repos","events_url":"https://api.github.com/users/Souravirus/events{/privacy}","received_events_url":"https://api.github.com/users/Souravirus/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"icarito","id":199755,"node_id":"MDQ6VXNlcjE5OTc1NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/199755?v=4","gravatar_id":"","url":"https://api.github.com/users/icarito","html_url":"https://github.com/icarito","followers_url":"https://api.github.com/users/icarito/followers","following_url":"https://api.github.com/users/icarito/following{/other_user}","gists_url":"https://api.github.com/users/icarito/gists{/gist_id}","starred_url":"https://api.github.com/users/icarito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icarito/subscriptions","organizations_url":"https://api.github.com/users/icarito/orgs","repos_url":"https://api.github.com/users/icarito/repos","events_url":"https://api.github.com/users/icarito/events{/privacy}","received_events_url":"https://api.github.com/users/icarito/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":189388513,"node_id":"MDU6TGFiZWwxODkzODg1MTM=","url":"https://api.github.com/repos/publiclab/plots2/labels/ready","name":"ready","color":"0edd56","default":false},{"id":486046776,"node_id":"MDU6TGFiZWw0ODYwNDY3NzY=","url":"https://api.github.com/repos/publiclab/plots2/labels/summer-of-code","name":"summer-of-code","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/publiclab/plots2/pulls/2726/commits","review_comments_url":"https://api.github.com/repos/publiclab/plots2/pulls/2726/comments","review_comment_url":"https://api.github.com/repos/publiclab/plots2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/publiclab/plots2/issues/2726/comments","statuses_url":"https://api.github.com/repos/publiclab/plots2/statuses/0231d62f452a27baf90bb2b53484ed8a2a1745e3","head":{"label":"Souravirus:rails5.0_upgrade","ref":"rails5.0_upgrade","sha":"0231d62f452a27baf90bb2b53484ed8a2a1745e3","user":{"login":"Souravirus","id":17192149,"node_id":"MDQ6VXNlcjE3MTkyMTQ5","avatar_url":"https://avatars3.githubusercontent.com/u/17192149?v=4","gravatar_id":"","url":"https://api.github.com/users/Souravirus","html_url":"https://github.com/Souravirus","followers_url":"https://api.github.com/users/Souravirus/followers","following_url":"https://api.github.com/users/Souravirus/following{/other_user}","gists_url":"https://api.github.com/users/Souravirus/gists{/gist_id}","starred_url":"https://api.github.com/users/Souravirus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Souravirus/subscriptions","organizations_url":"https://api.github.com/users/Souravirus/orgs","repos_url":"https://api.github.com/users/Souravirus/repos","events_url":"https://api.github.com/users/Souravirus/events{/privacy}","received_events_url":"https://api.github.com/users/Souravirus/received_events","type":"User","site_admin":false},"repo":{"id":120066679,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAwNjY2Nzk=","name":"plots2","full_name":"Souravirus/plots2","owner":{"login":"Souravirus","id":17192149,"node_id":"MDQ6VXNlcjE3MTkyMTQ5","avatar_url":"https://avatars3.githubusercontent.com/u/17192149?v=4","gravatar_id":"","url":"https://api.github.com/users/Souravirus","html_url":"https://github.com/Souravirus","followers_url":"https://api.github.com/users/Souravirus/followers","following_url":"https://api.github.com/users/Souravirus/following{/other_user}","gists_url":"https://api.github.com/users/Souravirus/gists{/gist_id}","starred_url":"https://api.github.com/users/Souravirus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Souravirus/subscriptions","organizations_url":"https://api.github.com/users/Souravirus/orgs","repos_url":"https://api.github.com/users/Souravirus/repos","events_url":"https://api.github.com/users/Souravirus/events{/privacy}","received_events_url":"https://api.github.com/users/Souravirus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Souravirus/plots2","description":"PublicLab.org - a collaborative knowledge-exchange platform in Rails; we welcome first-time contributors! :balloon:","fork":true,"url":"https://api.github.com/repos/Souravirus/plots2","forks_url":"https://api.github.com/repos/Souravirus/plots2/forks","keys_url":"https://api.github.com/repos/Souravirus/plots2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Souravirus/plots2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Souravirus/plots2/teams","hooks_url":"https://api.github.com/repos/Souravirus/plots2/hooks","issue_events_url":"https://api.github.com/repos/Souravirus/plots2/issues/events{/number}","events_url":"https://api.github.com/repos/Souravirus/plots2/events","assignees_url":"https://api.github.com/repos/Souravirus/plots2/assignees{/user}","branches_url":"https://api.github.com/repos/Souravirus/plots2/branches{/branch}","tags_url":"https://api.github.com/repos/Souravirus/plots2/tags","blobs_url":"https://api.github.com/repos/Souravirus/plots2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Souravirus/plots2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Souravirus/plots2/git/refs{/sha}","trees_url":"https://api.github.com/repos/Souravirus/plots2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Souravirus/plots2/statuses/{sha}","languages_url":"https://api.github.com/repos/Souravirus/plots2/languages","stargazers_url":"https://api.github.com/repos/Souravirus/plots2/stargazers","contributors_url":"https://api.github.com/repos/Souravirus/plots2/contributors","subscribers_url":"https://api.github.com/repos/Souravirus/plots2/subscribers","subscription_url":"https://api.github.com/repos/Souravirus/plots2/subscription","commits_url":"https://api.github.com/repos/Souravirus/plots2/commits{/sha}","git_commits_url":"https://api.github.com/repos/Souravirus/plots2/git/commits{/sha}","comments_url":"https://api.github.com/repos/Souravirus/plots2/comments{/number}","issue_comment_url":"https://api.github.com/repos/Souravirus/plots2/issues/comments{/number}","contents_url":"https://api.github.com/repos/Souravirus/plots2/contents/{+path}","compare_url":"https://api.github.com/repos/Souravirus/plots2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Souravirus/plots2/merges","archive_url":"https://api.github.com/repos/Souravirus/plots2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Souravirus/plots2/downloads","issues_url":"https://api.github.com/repos/Souravirus/plots2/issues{/number}","pulls_url":"https://api.github.com/repos/Souravirus/plots2/pulls{/number}","milestones_url":"https://api.github.com/repos/Souravirus/plots2/milestones{/number}","notifications_url":"https://api.github.com/repos/Souravirus/plots2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Souravirus/plots2/labels{/name}","releases_url":"https://api.github.com/repos/Souravirus/plots2/releases{/id}","deployments_url":"https://api.github.com/repos/Souravirus/plots2/deployments","created_at":"2018-02-03T06:42:55Z","updated_at":"2018-03-28T08:30:35Z","pushed_at":"2018-06-03T18:35:10Z","git_url":"git://github.com/Souravirus/plots2.git","ssh_url":"git@github.com:Souravirus/plots2.git","clone_url":"https://github.com/Souravirus/plots2.git","svn_url":"https://github.com/Souravirus/plots2","homepage":"https://publiclab.org","size":14725,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"publiclab:rails5.0_upgrade","ref":"rails5.0_upgrade","sha":"1291ce1591422ce0d94c9a1b8cf4a0d1258370c3","user":{"login":"publiclab","id":4621650,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MjE2NTA=","avatar_url":"https://avatars3.githubusercontent.com/u/4621650?v=4","gravatar_id":"","url":"https://api.github.com/users/publiclab","html_url":"https://github.com/publiclab","followers_url":"https://api.github.com/users/publiclab/followers","following_url":"https://api.github.com/users/publiclab/following{/other_user}","gists_url":"https://api.github.com/users/publiclab/gists{/gist_id}","starred_url":"https://api.github.com/users/publiclab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/publiclab/subscriptions","organizations_url":"https://api.github.com/users/publiclab/orgs","repos_url":"https://api.github.com/users/publiclab/repos","events_url":"https://api.github.com/users/publiclab/events{/privacy}","received_events_url":"https://api.github.com/users/publiclab/received_events","type":"Organization","site_admin":false},"repo":{"id":10504669,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUwNDY2OQ==","name":"plots2","full_name":"publiclab/plots2","owner":{"login":"publiclab","id":4621650,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MjE2NTA=","avatar_url":"https://avatars3.githubusercontent.com/u/4621650?v=4","gravatar_id":"","url":"https://api.github.com/users/publiclab","html_url":"https://github.com/publiclab","followers_url":"https://api.github.com/users/publiclab/followers","following_url":"https://api.github.com/users/publiclab/following{/other_user}","gists_url":"https://api.github.com/users/publiclab/gists{/gist_id}","starred_url":"https://api.github.com/users/publiclab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/publiclab/subscriptions","organizations_url":"https://api.github.com/users/publiclab/orgs","repos_url":"https://api.github.com/users/publiclab/repos","events_url":"https://api.github.com/users/publiclab/events{/privacy}","received_events_url":"https://api.github.com/users/publiclab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/publiclab/plots2","description":"PublicLab.org - a collaborative knowledge-exchange platform in Rails; we welcome first-time contributors! :balloon:","fork":false,"url":"https://api.github.com/repos/publiclab/plots2","forks_url":"https://api.github.com/repos/publiclab/plots2/forks","keys_url":"https://api.github.com/repos/publiclab/plots2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/publiclab/plots2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/publiclab/plots2/teams","hooks_url":"https://api.github.com/repos/publiclab/plots2/hooks","issue_events_url":"https://api.github.com/repos/publiclab/plots2/issues/events{/number}","events_url":"https://api.github.com/repos/publiclab/plots2/events","assignees_url":"https://api.github.com/repos/publiclab/plots2/assignees{/user}","branches_url":"https://api.github.com/repos/publiclab/plots2/branches{/branch}","tags_url":"https://api.github.com/repos/publiclab/plots2/tags","blobs_url":"https://api.github.com/repos/publiclab/plots2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/publiclab/plots2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/publiclab/plots2/git/refs{/sha}","trees_url":"https://api.github.com/repos/publiclab/plots2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/publiclab/plots2/statuses/{sha}","languages_url":"https://api.github.com/repos/publiclab/plots2/languages","stargazers_url":"https://api.github.com/repos/publiclab/plots2/stargazers","contributors_url":"https://api.github.com/repos/publiclab/plots2/contributors","subscribers_url":"https://api.github.com/repos/publiclab/plots2/subscribers","subscription_url":"https://api.github.com/repos/publiclab/plots2/subscription","commits_url":"https://api.github.com/repos/publiclab/plots2/commits{/sha}","git_commits_url":"https://api.github.com/repos/publiclab/plots2/git/commits{/sha}","comments_url":"https://api.github.com/repos/publiclab/plots2/comments{/number}","issue_comment_url":"https://api.github.com/repos/publiclab/plots2/issues/comments{/number}","contents_url":"https://api.github.com/repos/publiclab/plots2/contents/{+path}","compare_url":"https://api.github.com/repos/publiclab/plots2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/publiclab/plots2/merges","archive_url":"https://api.github.com/repos/publiclab/plots2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/publiclab/plots2/downloads","issues_url":"https://api.github.com/repos/publiclab/plots2/issues{/number}","pulls_url":"https://api.github.com/repos/publiclab/plots2/pulls{/number}","milestones_url":"https://api.github.com/repos/publiclab/plots2/milestones{/number}","notifications_url":"https://api.github.com/repos/publiclab/plots2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/publiclab/plots2/labels{/name}","releases_url":"https://api.github.com/repos/publiclab/plots2/releases{/id}","deployments_url":"https://api.github.com/repos/publiclab/plots2/deployments","created_at":"2013-06-05T14:36:10Z","updated_at":"2018-06-04T15:52:34Z","pushed_at":"2018-06-04T15:56:29Z","git_url":"git://github.com/publiclab/plots2.git","ssh_url":"git@github.com:publiclab/plots2.git","clone_url":"https://github.com/publiclab/plots2.git","svn_url":"https://github.com/publiclab/plots2","homepage":"https://publiclab.org","size":14948,"stargazers_count":235,"watchers_count":235,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":331,"mirror_url":null,"archived":false,"open_issues_count":288,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":331,"open_issues":288,"watchers":235,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/publiclab/plots2/pulls/2726"},"html":{"href":"https://github.com/publiclab/plots2/pull/2726"},"issue":{"href":"https://api.github.com/repos/publiclab/plots2/issues/2726"},"comments":{"href":"https://api.github.com/repos/publiclab/plots2/issues/2726/comments"},"review_comments":{"href":"https://api.github.com/repos/publiclab/plots2/pulls/2726/comments"},"review_comment":{"href":"https://api.github.com/repos/publiclab/plots2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/publiclab/plots2/pulls/2726/commits"},"statuses":{"href":"https://api.github.com/repos/publiclab/plots2/statuses/0231d62f452a27baf90bb2b53484ed8a2a1745e3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"siaw23"}}