{"action":"created","issue":{"url":"https://api.github.com/repos/vega/vega-tooltip/issues/192","repository_url":"https://api.github.com/repos/vega/vega-tooltip","labels_url":"https://api.github.com/repos/vega/vega-tooltip/issues/192/labels{/name}","comments_url":"https://api.github.com/repos/vega/vega-tooltip/issues/192/comments","events_url":"https://api.github.com/repos/vega/vega-tooltip/issues/192/events","html_url":"https://github.com/vega/vega-tooltip/issues/192","id":316668448,"number":192,"title":"Tooltip registration method makes dangerous hover call.","user":{"login":"jheer","id":202799,"avatar_url":"https://avatars0.githubusercontent.com/u/202799?v=4","gravatar_id":"","url":"https://api.github.com/users/jheer","html_url":"https://github.com/jheer","followers_url":"https://api.github.com/users/jheer/followers","following_url":"https://api.github.com/users/jheer/following{/other_user}","gists_url":"https://api.github.com/users/jheer/gists{/gist_id}","starred_url":"https://api.github.com/users/jheer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jheer/subscriptions","organizations_url":"https://api.github.com/users/jheer/orgs","repos_url":"https://api.github.com/users/jheer/repos","events_url":"https://api.github.com/users/jheer/events{/privacy}","received_events_url":"https://api.github.com/users/jheer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-23T05:43:19Z","updated_at":"2018-04-23T06:08:16Z","closed_at":null,"author_association":"OWNER","body":"Why does the tooltip registration method call `view.hover`?\r\nhttps://github.com/vega/vega-tooltip/blob/master/src/index.ts#L257\r\n\r\nThis is (1) totally unnecessary for tooltip processing (Vega should trigger tooltip updates regardless), and (2) can have multiple unwanted side-effects. I  recommend removing it!\r\n\r\nAlso, why invoke `view.run()`? This again is totally unnecessary for tooltip processing. Changing the tooltip handler already forces a reset and reinitialization of View rendering (https://github.com/vega/vega-view/blob/master/src/View.js#L194)"},"comment":{"url":"https://api.github.com/repos/vega/vega-tooltip/issues/comments/383464693","html_url":"https://github.com/vega/vega-tooltip/issues/192#issuecomment-383464693","issue_url":"https://api.github.com/repos/vega/vega-tooltip/issues/192","id":383464693,"user":{"login":"jheer","id":202799,"avatar_url":"https://avatars0.githubusercontent.com/u/202799?v=4","gravatar_id":"","url":"https://api.github.com/users/jheer","html_url":"https://github.com/jheer","followers_url":"https://api.github.com/users/jheer/followers","following_url":"https://api.github.com/users/jheer/following{/other_user}","gists_url":"https://api.github.com/users/jheer/gists{/gist_id}","starred_url":"https://api.github.com/users/jheer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jheer/subscriptions","organizations_url":"https://api.github.com/users/jheer/orgs","repos_url":"https://api.github.com/users/jheer/repos","events_url":"https://api.github.com/users/jheer/events{/privacy}","received_events_url":"https://api.github.com/users/jheer/received_events","type":"User","site_admin":false},"created_at":"2018-04-23T06:08:16Z","updated_at":"2018-04-23T06:08:16Z","author_association":"OWNER","body":"What happens if you remove hover but keep run? (I jumped the gun in the last part of my comment, as changing the tooltip will indeed reset the renderer, but a run call is needed to trigger redraw!)\r\n\r\nAlso, if you provide a tooltip hander to the View constructor (instead of your current post-instantiation wrapper, which I advised be split up!) I don't think you'd have any issues at all..."}}
{"actor":{"display_login":"jheer"}}