{"action":"created","issue":{"url":"https://api.github.com/repos/sienori/Tab-Session-Manager/issues/303","repository_url":"https://api.github.com/repos/sienori/Tab-Session-Manager","labels_url":"https://api.github.com/repos/sienori/Tab-Session-Manager/issues/303/labels{/name}","comments_url":"https://api.github.com/repos/sienori/Tab-Session-Manager/issues/303/comments","events_url":"https://api.github.com/repos/sienori/Tab-Session-Manager/issues/303/events","html_url":"https://github.com/sienori/Tab-Session-Manager/issues/303","id":363356887,"node_id":"MDU6SXNzdWUzNjMzNTY4ODc=","number":303,"title":"'Save the session when window was closed' creates way too many sessions","user":{"login":"Sledge-Hammer","id":39492230,"node_id":"MDQ6VXNlcjM5NDkyMjMw","avatar_url":"https://avatars2.githubusercontent.com/u/39492230?v=4","gravatar_id":"","url":"https://api.github.com/users/Sledge-Hammer","html_url":"https://github.com/Sledge-Hammer","followers_url":"https://api.github.com/users/Sledge-Hammer/followers","following_url":"https://api.github.com/users/Sledge-Hammer/following{/other_user}","gists_url":"https://api.github.com/users/Sledge-Hammer/gists{/gist_id}","starred_url":"https://api.github.com/users/Sledge-Hammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sledge-Hammer/subscriptions","organizations_url":"https://api.github.com/users/Sledge-Hammer/orgs","repos_url":"https://api.github.com/users/Sledge-Hammer/repos","events_url":"https://api.github.com/users/Sledge-Hammer/events{/privacy}","received_events_url":"https://api.github.com/users/Sledge-Hammer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-24T23:30:24Z","updated_at":"2018-10-28T17:17:03Z","closed_at":null,"author_association":"NONE","body":"## Short description\r\nHello,\r\nFirst thanks for the great add-on, every browser is useless nowadays without such functionality.\r\n\r\nAlso this is both a bug report for probably an extreme usage case and a feature request at the same time.\r\nWhen I have the option \"Save the session when window was closed\" enabled and \"Maximum number Saved\" set to a very high number (100000 for example) my database gets extremely huge and I have to wait around a minute for the session list to load.\r\n\r\nThe problem is that this functionality auto-saves a new session on each window close (and with a few hundred open tabs at any moment the database grows quite fast - my exported JSON is around 250 megabytes right now with more than 650 000 lines). Instead there should be an option for autosave only on browser exit.\r\n\r\n\r\n## Steps to reproduce\r\n<!-- Detailed steps to reproduce the problem. -->\r\n1. Start Firefox with clean profile\r\n2. Install Tab Session Manager\r\n3. Set a high value for \"Maximum number Saved\" while \"Save the session when window was closed\" is enabled\r\n4. Have lots of open tabs, close a window or two every now and then, and wait until it grows to unmanageable size\r\n\r\n## Expected result\r\n<!-- If you have any screenshot or screencast, it will help me more. -->\r\nThere should be an option to save the session only on complete browser shutdown and not on a single window\r\n\r\n## Actual result\r\n<!-- If you have any screenshot or screencast, it will help me more. -->\r\nThe session is saved on every closed window\r\n\r\n## Platform information\r\n* Platform (OS): Windows\r\n* Version of Firefox: 62.0.2 (the same result on older)\r\n* Version of Tab Session Manager: Version 4.0.1 (also present in older versions)\r\n\r\n## Additional context\r\n<!-- Add any other context about the problem here. -->\r\nIn the 3 or 4 months I've been using the add-on I have restarted the browser around 7 times... for which I should have around 7 autosaved sessions for each browser exit... instead I have almost 1200...\r\nThis also renders the browser unusable when restoring a session - I takes up all the available RAM (about 24GB in my case (out of 32)) and Windows asks for an app to terminate in order to free some RAM..."},"comment":{"url":"https://api.github.com/repos/sienori/Tab-Session-Manager/issues/comments/433723795","html_url":"https://github.com/sienori/Tab-Session-Manager/issues/303#issuecomment-433723795","issue_url":"https://api.github.com/repos/sienori/Tab-Session-Manager/issues/303","id":433723795,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzcyMzc5NQ==","user":{"login":"sienori","id":29514424,"node_id":"MDQ6VXNlcjI5NTE0NDI0","avatar_url":"https://avatars3.githubusercontent.com/u/29514424?v=4","gravatar_id":"","url":"https://api.github.com/users/sienori","html_url":"https://github.com/sienori","followers_url":"https://api.github.com/users/sienori/followers","following_url":"https://api.github.com/users/sienori/following{/other_user}","gists_url":"https://api.github.com/users/sienori/gists{/gist_id}","starred_url":"https://api.github.com/users/sienori/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sienori/subscriptions","organizations_url":"https://api.github.com/users/sienori/orgs","repos_url":"https://api.github.com/users/sienori/repos","events_url":"https://api.github.com/users/sienori/events{/privacy}","received_events_url":"https://api.github.com/users/sienori/received_events","type":"User","site_admin":false},"created_at":"2018-10-28T17:17:03Z","updated_at":"2018-10-28T17:17:03Z","author_association":"OWNER","body":"I improved behavior of Auto save when window was closed. https://github.com/sienori/Tab-Session-Manager/commit/7fc9b90505739f89cbc720d352b091157124c3a1\r\nIt divided into **window closed** and **browser exited**.\r\nIn **window closed**, save the session that includes only one closed window.\r\nIn **browser exited**, Save the session that includes multiple windows that was closed in a row.\r\nI believe that this improvement will solve this issue."}}
{"actor":{"display_login":"sienori"}}