{"action":"closed","number":120,"pull_request":{"url":"https://api.github.com/repos/DigDes/SoapCore/pulls/120","id":208382143,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MzgyMTQz","html_url":"https://github.com/DigDes/SoapCore/pull/120","diff_url":"https://github.com/DigDes/SoapCore/pull/120.diff","patch_url":"https://github.com/DigDes/SoapCore/pull/120.patch","issue_url":"https://api.github.com/repos/DigDes/SoapCore/issues/120","number":120,"state":"closed","locked":false,"title":"restore compatibility and some fixes","user":{"login":"DmitryBryluk","id":40860014,"node_id":"MDQ6VXNlcjQwODYwMDE0","avatar_url":"https://avatars0.githubusercontent.com/u/40860014?v=4","gravatar_id":"","url":"https://api.github.com/users/DmitryBryluk","html_url":"https://github.com/DmitryBryluk","followers_url":"https://api.github.com/users/DmitryBryluk/followers","following_url":"https://api.github.com/users/DmitryBryluk/following{/other_user}","gists_url":"https://api.github.com/users/DmitryBryluk/gists{/gist_id}","starred_url":"https://api.github.com/users/DmitryBryluk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DmitryBryluk/subscriptions","organizations_url":"https://api.github.com/users/DmitryBryluk/orgs","repos_url":"https://api.github.com/users/DmitryBryluk/repos","events_url":"https://api.github.com/users/DmitryBryluk/events{/privacy}","received_events_url":"https://api.github.com/users/DmitryBryluk/received_events","type":"User","site_admin":false},"body":"done:\r\n- restored compatibility with original edition of SoapCore\r\n- restored original samples, to be simple and readable\r\n- moved all tests to root test folder (still using xunit, but it runs smoothly with other tests)\r\n- moved extended legacy samples into tests\r\n- removed reference to samples from tests\r\n- fixed [MessageContract] request/response handling\r\n\r\nsome notes:\r\n\r\nDataContractSerializer and XmlSerializer attributes markup seems not compatible together, and DataContractSerializer can't handle complex cases. not much time to explore why. but with these tests it will be easier to explore what is happening.\r\n\r\nall possible cases (including incompatibility) are shown in tests for both serializers","created_at":"2018-08-14T19:14:00Z","updated_at":"2018-08-15T08:16:22Z","closed_at":"2018-08-15T08:16:22Z","merged_at":"2018-08-15T08:16:22Z","merge_commit_sha":"f193f7cc07f8490869348f024390875cbdff12de","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DigDes/SoapCore/pulls/120/commits","review_comments_url":"https://api.github.com/repos/DigDes/SoapCore/pulls/120/comments","review_comment_url":"https://api.github.com/repos/DigDes/SoapCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DigDes/SoapCore/issues/120/comments","statuses_url":"https://api.github.com/repos/DigDes/SoapCore/statuses/9851f8ab2282ce2c1b968f935ff8694ae42aeb34","head":{"label":"DmitryBryluk:fix_datacontract_compatibility","ref":"fix_datacontract_compatibility","sha":"9851f8ab2282ce2c1b968f935ff8694ae42aeb34","user":{"login":"DmitryBryluk","id":40860014,"node_id":"MDQ6VXNlcjQwODYwMDE0","avatar_url":"https://avatars0.githubusercontent.com/u/40860014?v=4","gravatar_id":"","url":"https://api.github.com/users/DmitryBryluk","html_url":"https://github.com/DmitryBryluk","followers_url":"https://api.github.com/users/DmitryBryluk/followers","following_url":"https://api.github.com/users/DmitryBryluk/following{/other_user}","gists_url":"https://api.github.com/users/DmitryBryluk/gists{/gist_id}","starred_url":"https://api.github.com/users/DmitryBryluk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DmitryBryluk/subscriptions","organizations_url":"https://api.github.com/users/DmitryBryluk/orgs","repos_url":"https://api.github.com/users/DmitryBryluk/repos","events_url":"https://api.github.com/users/DmitryBryluk/events{/privacy}","received_events_url":"https://api.github.com/users/DmitryBryluk/received_events","type":"User","site_admin":false},"repo":{"id":143466239,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM0NjYyMzk=","name":"SoapCore","full_name":"DmitryBryluk/SoapCore","owner":{"login":"DmitryBryluk","id":40860014,"node_id":"MDQ6VXNlcjQwODYwMDE0","avatar_url":"https://avatars0.githubusercontent.com/u/40860014?v=4","gravatar_id":"","url":"https://api.github.com/users/DmitryBryluk","html_url":"https://github.com/DmitryBryluk","followers_url":"https://api.github.com/users/DmitryBryluk/followers","following_url":"https://api.github.com/users/DmitryBryluk/following{/other_user}","gists_url":"https://api.github.com/users/DmitryBryluk/gists{/gist_id}","starred_url":"https://api.github.com/users/DmitryBryluk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DmitryBryluk/subscriptions","organizations_url":"https://api.github.com/users/DmitryBryluk/orgs","repos_url":"https://api.github.com/users/DmitryBryluk/repos","events_url":"https://api.github.com/users/DmitryBryluk/events{/privacy}","received_events_url":"https://api.github.com/users/DmitryBryluk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DmitryBryluk/SoapCore","description":"SOAP extension for ASP.NET Core","fork":true,"url":"https://api.github.com/repos/DmitryBryluk/SoapCore","forks_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/forks","keys_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/teams","hooks_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/hooks","issue_events_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/issues/events{/number}","events_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/events","assignees_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/assignees{/user}","branches_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/branches{/branch}","tags_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/tags","blobs_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/statuses/{sha}","languages_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/languages","stargazers_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/stargazers","contributors_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/contributors","subscribers_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/subscribers","subscription_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/subscription","commits_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/contents/{+path}","compare_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/merges","archive_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/downloads","issues_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/issues{/number}","pulls_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/pulls{/number}","milestones_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/milestones{/number}","notifications_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/labels{/name}","releases_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/releases{/id}","deployments_url":"https://api.github.com/repos/DmitryBryluk/SoapCore/deployments","created_at":"2018-08-03T19:35:24Z","updated_at":"2018-08-03T19:35:26Z","pushed_at":"2018-08-14T19:06:20Z","git_url":"git://github.com/DmitryBryluk/SoapCore.git","ssh_url":"git@github.com:DmitryBryluk/SoapCore.git","clone_url":"https://github.com/DmitryBryluk/SoapCore.git","svn_url":"https://github.com/DmitryBryluk/SoapCore","homepage":null,"size":202,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DigDes:master","ref":"master","sha":"3364177feb7129c6bf298a1e0c8eecfb55b6fc13","user":{"login":"DigDes","id":20187474,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTg3NDc0","avatar_url":"https://avatars3.githubusercontent.com/u/20187474?v=4","gravatar_id":"","url":"https://api.github.com/users/DigDes","html_url":"https://github.com/DigDes","followers_url":"https://api.github.com/users/DigDes/followers","following_url":"https://api.github.com/users/DigDes/following{/other_user}","gists_url":"https://api.github.com/users/DigDes/gists{/gist_id}","starred_url":"https://api.github.com/users/DigDes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DigDes/subscriptions","organizations_url":"https://api.github.com/users/DigDes/orgs","repos_url":"https://api.github.com/users/DigDes/repos","events_url":"https://api.github.com/users/DigDes/events{/privacy}","received_events_url":"https://api.github.com/users/DigDes/received_events","type":"Organization","site_admin":false},"repo":{"id":77414336,"node_id":"MDEwOlJlcG9zaXRvcnk3NzQxNDMzNg==","name":"SoapCore","full_name":"DigDes/SoapCore","owner":{"login":"DigDes","id":20187474,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTg3NDc0","avatar_url":"https://avatars3.githubusercontent.com/u/20187474?v=4","gravatar_id":"","url":"https://api.github.com/users/DigDes","html_url":"https://github.com/DigDes","followers_url":"https://api.github.com/users/DigDes/followers","following_url":"https://api.github.com/users/DigDes/following{/other_user}","gists_url":"https://api.github.com/users/DigDes/gists{/gist_id}","starred_url":"https://api.github.com/users/DigDes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DigDes/subscriptions","organizations_url":"https://api.github.com/users/DigDes/orgs","repos_url":"https://api.github.com/users/DigDes/repos","events_url":"https://api.github.com/users/DigDes/events{/privacy}","received_events_url":"https://api.github.com/users/DigDes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DigDes/SoapCore","description":"SOAP extension for ASP.NET Core","fork":false,"url":"https://api.github.com/repos/DigDes/SoapCore","forks_url":"https://api.github.com/repos/DigDes/SoapCore/forks","keys_url":"https://api.github.com/repos/DigDes/SoapCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DigDes/SoapCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DigDes/SoapCore/teams","hooks_url":"https://api.github.com/repos/DigDes/SoapCore/hooks","issue_events_url":"https://api.github.com/repos/DigDes/SoapCore/issues/events{/number}","events_url":"https://api.github.com/repos/DigDes/SoapCore/events","assignees_url":"https://api.github.com/repos/DigDes/SoapCore/assignees{/user}","branches_url":"https://api.github.com/repos/DigDes/SoapCore/branches{/branch}","tags_url":"https://api.github.com/repos/DigDes/SoapCore/tags","blobs_url":"https://api.github.com/repos/DigDes/SoapCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DigDes/SoapCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DigDes/SoapCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/DigDes/SoapCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DigDes/SoapCore/statuses/{sha}","languages_url":"https://api.github.com/repos/DigDes/SoapCore/languages","stargazers_url":"https://api.github.com/repos/DigDes/SoapCore/stargazers","contributors_url":"https://api.github.com/repos/DigDes/SoapCore/contributors","subscribers_url":"https://api.github.com/repos/DigDes/SoapCore/subscribers","subscription_url":"https://api.github.com/repos/DigDes/SoapCore/subscription","commits_url":"https://api.github.com/repos/DigDes/SoapCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/DigDes/SoapCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/DigDes/SoapCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/DigDes/SoapCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/DigDes/SoapCore/contents/{+path}","compare_url":"https://api.github.com/repos/DigDes/SoapCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DigDes/SoapCore/merges","archive_url":"https://api.github.com/repos/DigDes/SoapCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DigDes/SoapCore/downloads","issues_url":"https://api.github.com/repos/DigDes/SoapCore/issues{/number}","pulls_url":"https://api.github.com/repos/DigDes/SoapCore/pulls{/number}","milestones_url":"https://api.github.com/repos/DigDes/SoapCore/milestones{/number}","notifications_url":"https://api.github.com/repos/DigDes/SoapCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DigDes/SoapCore/labels{/name}","releases_url":"https://api.github.com/repos/DigDes/SoapCore/releases{/id}","deployments_url":"https://api.github.com/repos/DigDes/SoapCore/deployments","created_at":"2016-12-27T00:39:44Z","updated_at":"2018-08-14T13:07:24Z","pushed_at":"2018-08-15T08:16:22Z","git_url":"git://github.com/DigDes/SoapCore.git","ssh_url":"git@github.com:DigDes/SoapCore.git","clone_url":"https://github.com/DigDes/SoapCore.git","svn_url":"https://github.com/DigDes/SoapCore","homepage":null,"size":201,"stargazers_count":133,"watchers_count":133,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":54,"open_issues":15,"watchers":133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DigDes/SoapCore/pulls/120"},"html":{"href":"https://github.com/DigDes/SoapCore/pull/120"},"issue":{"href":"https://api.github.com/repos/DigDes/SoapCore/issues/120"},"comments":{"href":"https://api.github.com/repos/DigDes/SoapCore/issues/120/comments"},"review_comments":{"href":"https://api.github.com/repos/DigDes/SoapCore/pulls/120/comments"},"review_comment":{"href":"https://api.github.com/repos/DigDes/SoapCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DigDes/SoapCore/pulls/120/commits"},"statuses":{"href":"https://api.github.com/repos/DigDes/SoapCore/statuses/9851f8ab2282ce2c1b968f935ff8694ae42aeb34"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kotovaleksandr","id":2936914,"node_id":"MDQ6VXNlcjI5MzY5MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2936914?v=4","gravatar_id":"","url":"https://api.github.com/users/kotovaleksandr","html_url":"https://github.com/kotovaleksandr","followers_url":"https://api.github.com/users/kotovaleksandr/followers","following_url":"https://api.github.com/users/kotovaleksandr/following{/other_user}","gists_url":"https://api.github.com/users/kotovaleksandr/gists{/gist_id}","starred_url":"https://api.github.com/users/kotovaleksandr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kotovaleksandr/subscriptions","organizations_url":"https://api.github.com/users/kotovaleksandr/orgs","repos_url":"https://api.github.com/users/kotovaleksandr/repos","events_url":"https://api.github.com/users/kotovaleksandr/events{/privacy}","received_events_url":"https://api.github.com/users/kotovaleksandr/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1329,"deletions":566,"changed_files":32}}
{"actor":{"display_login":"kotovaleksandr"}}