{"action":"created","comment":{"url":"https://api.github.com/repos/openPMD/openPMD-viewer/pulls/comments/190509809","pull_request_review_id":122898694,"id":190509809,"diff_hunk":"@@ -124,3 +124,34 @@ def get_shape(dset):\n         shape = dset.shape\n \n     return(shape)\n+\n+\n+def join(base_path, *paths):\n+    \"\"\"\n+    Join path components using '/' as separator.\n+    This method is defined as an alternative to os.path.join, which uses '\\\\'\n+    as separator in Windows environments and is therefore not valid to navigate\n+    within data files.\n+\n+    Parameters:\n+    -----------\n+    base_path: string cointaining the base path\n+\n+    *paths: all other strings with path components to join\n+\n+    Returns:\n+    --------\n+    A string with the complete path using '/' as separator.\n+    \"\"\"\n+    # Initialize path\n+    path = base_path\n+    # Join all path components adding a '/'\n+    try:\n+        for p in paths:\n+            path += '/' + p\n+    except:\n+        print(\"Error joining strings.\")","path":"opmd_viewer/openpmd_timeseries/data_reader/utilities.py","position":null,"original_position":30,"commit_id":"2659335ebb4ebca586d6c8b9d784d2ad40852215","original_commit_id":"2b994cda9faf822e555cc73c2e095ecef80c4be5","user":{"login":"AngelFP","id":20479420,"avatar_url":"https://avatars3.githubusercontent.com/u/20479420?v=4","gravatar_id":"","url":"https://api.github.com/users/AngelFP","html_url":"https://github.com/AngelFP","followers_url":"https://api.github.com/users/AngelFP/followers","following_url":"https://api.github.com/users/AngelFP/following{/other_user}","gists_url":"https://api.github.com/users/AngelFP/gists{/gist_id}","starred_url":"https://api.github.com/users/AngelFP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AngelFP/subscriptions","organizations_url":"https://api.github.com/users/AngelFP/orgs","repos_url":"https://api.github.com/users/AngelFP/repos","events_url":"https://api.github.com/users/AngelFP/events{/privacy}","received_events_url":"https://api.github.com/users/AngelFP/received_events","type":"User","site_admin":false},"body":"I like this last name. I just submitted a new commit including both changes.","created_at":"2018-05-24T08:52:14Z","updated_at":"2018-05-24T08:52:14Z","html_url":"https://github.com/openPMD/openPMD-viewer/pull/207#discussion_r190509809","pull_request_url":"https://api.github.com/repos/openPMD/openPMD-viewer/pulls/207","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openPMD/openPMD-viewer/pulls/comments/190509809"},"html":{"href":"https://github.com/openPMD/openPMD-viewer/pull/207#discussion_r190509809"},"pull_request":{"href":"https://api.github.com/repos/openPMD/openPMD-viewer/pulls/207"}},"in_reply_to_id":190285145},"pull_request":{"url":"https://api.github.com/repos/openPMD/openPMD-viewer/pulls/207","id":189905055,"html_url":"https://github.com/openPMD/openPMD-viewer/pull/207","diff_url":"https://github.com/openPMD/openPMD-viewer/pull/207.diff","patch_url":"https://github.com/openPMD/openPMD-viewer/pull/207.patch","issue_url":"https://api.github.com/repos/openPMD/openPMD-viewer/issues/207","number":207,"state":"open","locked":false,"title":"Fix Windows issues","user":{"login":"AngelFP","id":20479420,"avatar_url":"https://avatars3.githubusercontent.com/u/20479420?v=4","gravatar_id":"","url":"https://api.github.com/users/AngelFP","html_url":"https://github.com/AngelFP","followers_url":"https://api.github.com/users/AngelFP/followers","following_url":"https://api.github.com/users/AngelFP/following{/other_user}","gists_url":"https://api.github.com/users/AngelFP/gists{/gist_id}","starred_url":"https://api.github.com/users/AngelFP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AngelFP/subscriptions","organizations_url":"https://api.github.com/users/AngelFP/orgs","repos_url":"https://api.github.com/users/AngelFP/repos","events_url":"https://api.github.com/users/AngelFP/events{/privacy}","received_events_url":"https://api.github.com/users/AngelFP/received_events","type":"User","site_admin":false},"body":"Small fixes for Windows-specific bugs, all of them related to how Windows handles file paths.\r\n\r\nThe use of `os.path.join` for navigating within data files has been substituted by manually adding slashes. The issue is that this function uses a double backlash `\\\\` as separator in Windows, which is appropriate for file paths but not for navigating within data files, where a `/` is still required.\r\n","created_at":"2018-05-23T09:10:24Z","updated_at":"2018-05-24T08:52:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2836ff28530fdcd86dd7bec6007541a65524430","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openPMD/openPMD-viewer/pulls/207/commits","review_comments_url":"https://api.github.com/repos/openPMD/openPMD-viewer/pulls/207/comments","review_comment_url":"https://api.github.com/repos/openPMD/openPMD-viewer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openPMD/openPMD-viewer/issues/207/comments","statuses_url":"https://api.github.com/repos/openPMD/openPMD-viewer/statuses/2659335ebb4ebca586d6c8b9d784d2ad40852215","head":{"label":"AngelFP:fix-windows-issues","ref":"fix-windows-issues","sha":"2659335ebb4ebca586d6c8b9d784d2ad40852215","user":{"login":"AngelFP","id":20479420,"avatar_url":"https://avatars3.githubusercontent.com/u/20479420?v=4","gravatar_id":"","url":"https://api.github.com/users/AngelFP","html_url":"https://github.com/AngelFP","followers_url":"https://api.github.com/users/AngelFP/followers","following_url":"https://api.github.com/users/AngelFP/following{/other_user}","gists_url":"https://api.github.com/users/AngelFP/gists{/gist_id}","starred_url":"https://api.github.com/users/AngelFP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AngelFP/subscriptions","organizations_url":"https://api.github.com/users/AngelFP/orgs","repos_url":"https://api.github.com/users/AngelFP/repos","events_url":"https://api.github.com/users/AngelFP/events{/privacy}","received_events_url":"https://api.github.com/users/AngelFP/received_events","type":"User","site_admin":false},"repo":{"id":133956672,"name":"openPMD-viewer","full_name":"AngelFP/openPMD-viewer","owner":{"login":"AngelFP","id":20479420,"avatar_url":"https://avatars3.githubusercontent.com/u/20479420?v=4","gravatar_id":"","url":"https://api.github.com/users/AngelFP","html_url":"https://github.com/AngelFP","followers_url":"https://api.github.com/users/AngelFP/followers","following_url":"https://api.github.com/users/AngelFP/following{/other_user}","gists_url":"https://api.github.com/users/AngelFP/gists{/gist_id}","starred_url":"https://api.github.com/users/AngelFP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AngelFP/subscriptions","organizations_url":"https://api.github.com/users/AngelFP/orgs","repos_url":"https://api.github.com/users/AngelFP/repos","events_url":"https://api.github.com/users/AngelFP/events{/privacy}","received_events_url":"https://api.github.com/users/AngelFP/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AngelFP/openPMD-viewer","description":":snake: Python visualization tools for openPMD files","fork":true,"url":"https://api.github.com/repos/AngelFP/openPMD-viewer","forks_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/forks","keys_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/teams","hooks_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/hooks","issue_events_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/issues/events{/number}","events_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/events","assignees_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/assignees{/user}","branches_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/branches{/branch}","tags_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/tags","blobs_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/git/refs{/sha}","trees_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/statuses/{sha}","languages_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/languages","stargazers_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/stargazers","contributors_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/contributors","subscribers_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/subscribers","subscription_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/subscription","commits_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/commits{/sha}","git_commits_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/git/commits{/sha}","comments_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/comments{/number}","issue_comment_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/issues/comments{/number}","contents_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/contents/{+path}","compare_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/merges","archive_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/downloads","issues_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/issues{/number}","pulls_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/pulls{/number}","milestones_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/milestones{/number}","notifications_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/labels{/name}","releases_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/releases{/id}","deployments_url":"https://api.github.com/repos/AngelFP/openPMD-viewer/deployments","created_at":"2018-05-18T13:16:52Z","updated_at":"2018-05-18T13:16:54Z","pushed_at":"2018-05-24T08:48:00Z","git_url":"git://github.com/AngelFP/openPMD-viewer.git","ssh_url":"git@github.com:AngelFP/openPMD-viewer.git","clone_url":"https://github.com/AngelFP/openPMD-viewer.git","svn_url":"https://github.com/AngelFP/openPMD-viewer","homepage":"","size":2767,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openPMD:dev","ref":"dev","sha":"9bbbde8173d8708d7678eb1ac3b8351e418179a9","user":{"login":"openPMD","id":13621712,"avatar_url":"https://avatars2.githubusercontent.com/u/13621712?v=4","gravatar_id":"","url":"https://api.github.com/users/openPMD","html_url":"https://github.com/openPMD","followers_url":"https://api.github.com/users/openPMD/followers","following_url":"https://api.github.com/users/openPMD/following{/other_user}","gists_url":"https://api.github.com/users/openPMD/gists{/gist_id}","starred_url":"https://api.github.com/users/openPMD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openPMD/subscriptions","organizations_url":"https://api.github.com/users/openPMD/orgs","repos_url":"https://api.github.com/users/openPMD/repos","events_url":"https://api.github.com/users/openPMD/events{/privacy}","received_events_url":"https://api.github.com/users/openPMD/received_events","type":"Organization","site_admin":false},"repo":{"id":43901924,"name":"openPMD-viewer","full_name":"openPMD/openPMD-viewer","owner":{"login":"openPMD","id":13621712,"avatar_url":"https://avatars2.githubusercontent.com/u/13621712?v=4","gravatar_id":"","url":"https://api.github.com/users/openPMD","html_url":"https://github.com/openPMD","followers_url":"https://api.github.com/users/openPMD/followers","following_url":"https://api.github.com/users/openPMD/following{/other_user}","gists_url":"https://api.github.com/users/openPMD/gists{/gist_id}","starred_url":"https://api.github.com/users/openPMD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openPMD/subscriptions","organizations_url":"https://api.github.com/users/openPMD/orgs","repos_url":"https://api.github.com/users/openPMD/repos","events_url":"https://api.github.com/users/openPMD/events{/privacy}","received_events_url":"https://api.github.com/users/openPMD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openPMD/openPMD-viewer","description":":snake: Python visualization tools for openPMD files","fork":false,"url":"https://api.github.com/repos/openPMD/openPMD-viewer","forks_url":"https://api.github.com/repos/openPMD/openPMD-viewer/forks","keys_url":"https://api.github.com/repos/openPMD/openPMD-viewer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openPMD/openPMD-viewer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openPMD/openPMD-viewer/teams","hooks_url":"https://api.github.com/repos/openPMD/openPMD-viewer/hooks","issue_events_url":"https://api.github.com/repos/openPMD/openPMD-viewer/issues/events{/number}","events_url":"https://api.github.com/repos/openPMD/openPMD-viewer/events","assignees_url":"https://api.github.com/repos/openPMD/openPMD-viewer/assignees{/user}","branches_url":"https://api.github.com/repos/openPMD/openPMD-viewer/branches{/branch}","tags_url":"https://api.github.com/repos/openPMD/openPMD-viewer/tags","blobs_url":"https://api.github.com/repos/openPMD/openPMD-viewer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openPMD/openPMD-viewer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openPMD/openPMD-viewer/git/refs{/sha}","trees_url":"https://api.github.com/repos/openPMD/openPMD-viewer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openPMD/openPMD-viewer/statuses/{sha}","languages_url":"https://api.github.com/repos/openPMD/openPMD-viewer/languages","stargazers_url":"https://api.github.com/repos/openPMD/openPMD-viewer/stargazers","contributors_url":"https://api.github.com/repos/openPMD/openPMD-viewer/contributors","subscribers_url":"https://api.github.com/repos/openPMD/openPMD-viewer/subscribers","subscription_url":"https://api.github.com/repos/openPMD/openPMD-viewer/subscription","commits_url":"https://api.github.com/repos/openPMD/openPMD-viewer/commits{/sha}","git_commits_url":"https://api.github.com/repos/openPMD/openPMD-viewer/git/commits{/sha}","comments_url":"https://api.github.com/repos/openPMD/openPMD-viewer/comments{/number}","issue_comment_url":"https://api.github.com/repos/openPMD/openPMD-viewer/issues/comments{/number}","contents_url":"https://api.github.com/repos/openPMD/openPMD-viewer/contents/{+path}","compare_url":"https://api.github.com/repos/openPMD/openPMD-viewer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openPMD/openPMD-viewer/merges","archive_url":"https://api.github.com/repos/openPMD/openPMD-viewer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openPMD/openPMD-viewer/downloads","issues_url":"https://api.github.com/repos/openPMD/openPMD-viewer/issues{/number}","pulls_url":"https://api.github.com/repos/openPMD/openPMD-viewer/pulls{/number}","milestones_url":"https://api.github.com/repos/openPMD/openPMD-viewer/milestones{/number}","notifications_url":"https://api.github.com/repos/openPMD/openPMD-viewer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openPMD/openPMD-viewer/labels{/name}","releases_url":"https://api.github.com/repos/openPMD/openPMD-viewer/releases{/id}","deployments_url":"https://api.github.com/repos/openPMD/openPMD-viewer/deployments","created_at":"2015-10-08T16:22:47Z","updated_at":"2018-05-23T17:09:00Z","pushed_at":"2018-05-24T08:48:01Z","git_url":"git://github.com/openPMD/openPMD-viewer.git","ssh_url":"git@github.com:openPMD/openPMD-viewer.git","clone_url":"https://github.com/openPMD/openPMD-viewer.git","svn_url":"https://github.com/openPMD/openPMD-viewer","homepage":"","size":2773,"stargazers_count":17,"watchers_count":17,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":15,"open_issues":20,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openPMD/openPMD-viewer/pulls/207"},"html":{"href":"https://github.com/openPMD/openPMD-viewer/pull/207"},"issue":{"href":"https://api.github.com/repos/openPMD/openPMD-viewer/issues/207"},"comments":{"href":"https://api.github.com/repos/openPMD/openPMD-viewer/issues/207/comments"},"review_comments":{"href":"https://api.github.com/repos/openPMD/openPMD-viewer/pulls/207/comments"},"review_comment":{"href":"https://api.github.com/repos/openPMD/openPMD-viewer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openPMD/openPMD-viewer/pulls/207/commits"},"statuses":{"href":"https://api.github.com/repos/openPMD/openPMD-viewer/statuses/2659335ebb4ebca586d6c8b9d784d2ad40852215"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"AngelFP"}}