{"action":"created","comment":{"url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/comments/206933433","pull_request_review_id":142442481,"id":206933433,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjkzMzQzMw==","diff_hunk":"@@ -68,7 +76,64 @@\n \n \t\t\t\tdialog.hide();\n \t\t\t} );\n+\t\t},\n+\n+\t\t// (#1046).\n+\t\t'test adding two subsequent id changes': function() {\n+\t\t\tvar bot = this.editorBot;\n+\n+\t\t\tthis.editorBot.setHtmlWithSelection( '<p>[aaa] <strong>bbb</strong></p>' );\n+\n+\t\t\t// First add id to one of links.\n+\t\t\tbot.dialog( 'link', function( dialog ) {\n+\t\t\t\tvar editor = this.editor;\n+\n+\t\t\t\tdialog.setValueOf( 'info', 'url', 'a' );\n+\t\t\t\tdialog.setValueOf( 'advanced', 'advId', 'aa' );\n+\t\t\t\tdialog.getButton( 'ok' ).click();\n+\n+\t\t\t\tassert.beautified.html( '<p><a href=\"http://a\" id=\"aa\">aaa</a> <strong>bbb</strong></p>',\n+\t\t\t\t\tbot.getData( true ) );\n+\n+\t\t\t\teditor.getSelection().selectElement( editor.editable().findOne( 'strong' ) );\n+\n+\t\t\t\t// Now add the id to a second link.\n+\t\t\t\tbot.dialog( 'link', function( dialog ) {\n+\t\t\t\t\tdialog.setValueOf( 'info', 'url', 'b' );\n+\t\t\t\t\tdialog.setValueOf( 'advanced', 'advId', 'bb' );\n+\t\t\t\t\tdialog.getButton( 'ok' ).click();\n+\n+\t\t\t\t\tassert.beautified.html( '<p><a href=\"http://a\" id=\"aa\">aaa</a> <a href=\"http://b\" id=\"bb\"><strong>bbb</strong></a></p>',\n+\t\t\t\t\t\tbot.getData( true ) );\n+\t\t\t\t} );\n+\t\t\t} );\n+\t\t},\n+\n+\t\t'test editing two subsequent id changes': function() {","path":"tests/plugins/dialogadvtab/dialog.js","position":59,"original_position":59,"commit_id":"4f75d8c2736b4ed3b79d09bde4aef8d32f9b2944","original_commit_id":"4f75d8c2736b4ed3b79d09bde4aef8d32f9b2944","user":{"login":"mlewand","id":5353898,"node_id":"MDQ6VXNlcjUzNTM4OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/5353898?v=4","gravatar_id":"","url":"https://api.github.com/users/mlewand","html_url":"https://github.com/mlewand","followers_url":"https://api.github.com/users/mlewand/followers","following_url":"https://api.github.com/users/mlewand/following{/other_user}","gists_url":"https://api.github.com/users/mlewand/gists{/gist_id}","starred_url":"https://api.github.com/users/mlewand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlewand/subscriptions","organizations_url":"https://api.github.com/users/mlewand/orgs","repos_url":"https://api.github.com/users/mlewand/repos","events_url":"https://api.github.com/users/mlewand/events{/privacy}","received_events_url":"https://api.github.com/users/mlewand/received_events","type":"User","site_admin":false},"body":"This TC is not related to this issue, as this particular case was not buggy at all. I have added it only because I saw there was no coverage for such case, and this issue shows that it also should be covered. 🙂","created_at":"2018-08-01T15:45:20Z","updated_at":"2018-08-01T15:45:20Z","html_url":"https://github.com/ckeditor/ckeditor-dev/pull/2275#discussion_r206933433","pull_request_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/2275","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/comments/206933433"},"html":{"href":"https://github.com/ckeditor/ckeditor-dev/pull/2275#discussion_r206933433"},"pull_request":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/2275"}},"in_reply_to_id":206906763},"pull_request":{"url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/2275","id":205441623,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NDQxNjIz","html_url":"https://github.com/ckeditor/ckeditor-dev/pull/2275","diff_url":"https://github.com/ckeditor/ckeditor-dev/pull/2275.diff","patch_url":"https://github.com/ckeditor/ckeditor-dev/pull/2275.patch","issue_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/2275","number":2275,"state":"open","locked":false,"title":"Fixed id attribute for new subsequent links","user":{"login":"mlewand","id":5353898,"node_id":"MDQ6VXNlcjUzNTM4OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/5353898?v=4","gravatar_id":"","url":"https://api.github.com/users/mlewand","html_url":"https://github.com/mlewand","followers_url":"https://api.github.com/users/mlewand/followers","following_url":"https://api.github.com/users/mlewand/following{/other_user}","gists_url":"https://api.github.com/users/mlewand/gists{/gist_id}","starred_url":"https://api.github.com/users/mlewand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlewand/subscriptions","organizations_url":"https://api.github.com/users/mlewand/orgs","repos_url":"https://api.github.com/users/mlewand/repos","events_url":"https://api.github.com/users/mlewand/events{/privacy}","received_events_url":"https://api.github.com/users/mlewand/received_events","type":"User","site_admin":false},"body":"## What is the purpose of this pull request?\n\nBug fix\n\n## Does your PR contain necessary tests?\n\nAll patches which change the editor code must include tests. You can always read more\non [PR testing](https://docs.ckeditor.com/ckeditor4/docs/#!/guide/dev_contributing_code-section-tests),\n[how to set the testing environment](https://docs.ckeditor.com/ckeditor4/docs/#!/guide/dev_tests) and\n[how to create tests](https://docs.ckeditor.com/ckeditor4/docs/#!/guide/dev_tests-section-creating-your-own-test)\nin the official CKEditor documentation.\n\n### This PR contains\n\n- [x] Unit tests\n- [x] Manual tests\n\n## What changes did you make?\n\nI took the PR, added tests - however the initial fix was in a wrong place (see the comment linked below).\n\nMost of the issue has been described here: https://github.com/ckeditor/ckeditor-dev/pull/1914#discussion_r206872504\n\nThe code itself is not fancy, but it does not make sense to refactor it all around, just revert it to initial state where it did not contain the bug.\n\nFollow-up of a #1914.\n\nCloses #1046.","created_at":"2018-08-01T14:19:55Z","updated_at":"2018-08-01T15:45:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6cc5530aae00471bc2ea5ea74277fd0780b418d1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":690260520,"node_id":"MDU6TGFiZWw2OTAyNjA1MjA=","url":"https://api.github.com/repos/ckeditor/ckeditor-dev/labels/review:easy","name":"review:easy","color":"34d058","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/2275/commits","review_comments_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/2275/comments","review_comment_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/2275/comments","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/statuses/4f75d8c2736b4ed3b79d09bde4aef8d32f9b2944","head":{"label":"ckeditor:t/1046","ref":"t/1046","sha":"4f75d8c2736b4ed3b79d09bde4aef8d32f9b2944","user":{"login":"ckeditor","id":825710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTcxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":5482172,"node_id":"MDEwOlJlcG9zaXRvcnk1NDgyMTcy","name":"ckeditor-dev","full_name":"ckeditor/ckeditor-dev","owner":{"login":"ckeditor","id":825710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTcxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ckeditor/ckeditor-dev","description":"The development repository of CKEditor 4.","fork":false,"url":"https://api.github.com/repos/ckeditor/ckeditor-dev","forks_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/forks","keys_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/teams","hooks_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/hooks","issue_events_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/events{/number}","events_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/events","assignees_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/assignees{/user}","branches_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/branches{/branch}","tags_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/tags","blobs_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/languages","stargazers_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/stargazers","contributors_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/contributors","subscribers_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/subscribers","subscription_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/subscription","commits_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/contents/{+path}","compare_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/merges","archive_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/downloads","issues_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues{/number}","pulls_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/labels{/name}","releases_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/releases{/id}","deployments_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/deployments","created_at":"2012-08-20T14:21:13Z","updated_at":"2018-08-01T03:46:51Z","pushed_at":"2018-08-01T14:41:00Z","git_url":"git://github.com/ckeditor/ckeditor-dev.git","ssh_url":"git@github.com:ckeditor/ckeditor-dev.git","clone_url":"https://github.com/ckeditor/ckeditor-dev.git","svn_url":"https://github.com/ckeditor/ckeditor-dev","homepage":"https://ckeditor.com/ckeditor-4","size":62184,"stargazers_count":4121,"watchers_count":4121,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1856,"mirror_url":null,"archived":false,"open_issues_count":660,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1856,"open_issues":660,"watchers":4121,"default_branch":"master"}},"base":{"label":"ckeditor:master","ref":"master","sha":"4cd0a5e5fb6defd2f27578a1c4845b66d92a9d3c","user":{"login":"ckeditor","id":825710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTcxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":5482172,"node_id":"MDEwOlJlcG9zaXRvcnk1NDgyMTcy","name":"ckeditor-dev","full_name":"ckeditor/ckeditor-dev","owner":{"login":"ckeditor","id":825710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTcxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ckeditor/ckeditor-dev","description":"The development repository of CKEditor 4.","fork":false,"url":"https://api.github.com/repos/ckeditor/ckeditor-dev","forks_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/forks","keys_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/teams","hooks_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/hooks","issue_events_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/events{/number}","events_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/events","assignees_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/assignees{/user}","branches_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/branches{/branch}","tags_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/tags","blobs_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/languages","stargazers_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/stargazers","contributors_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/contributors","subscribers_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/subscribers","subscription_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/subscription","commits_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/contents/{+path}","compare_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/merges","archive_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/downloads","issues_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues{/number}","pulls_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/labels{/name}","releases_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/releases{/id}","deployments_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/deployments","created_at":"2012-08-20T14:21:13Z","updated_at":"2018-08-01T03:46:51Z","pushed_at":"2018-08-01T14:41:00Z","git_url":"git://github.com/ckeditor/ckeditor-dev.git","ssh_url":"git@github.com:ckeditor/ckeditor-dev.git","clone_url":"https://github.com/ckeditor/ckeditor-dev.git","svn_url":"https://github.com/ckeditor/ckeditor-dev","homepage":"https://ckeditor.com/ckeditor-4","size":62184,"stargazers_count":4121,"watchers_count":4121,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1856,"mirror_url":null,"archived":false,"open_issues_count":660,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1856,"open_issues":660,"watchers":4121,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/2275"},"html":{"href":"https://github.com/ckeditor/ckeditor-dev/pull/2275"},"issue":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/2275"},"comments":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/2275/comments"},"review_comments":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/2275/comments"},"review_comment":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/2275/commits"},"statuses":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/statuses/4f75d8c2736b4ed3b79d09bde4aef8d32f9b2944"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mlewand"}}