{"action":"created","comment":{"url":"https://api.github.com/repos/blevesearch/bleve/pulls/comments/173814998","pull_request_review_id":103064962,"id":173814998,"diff_hunk":"@@ -255,7 +253,19 @@ func getDocValueLocs(docNum uint64, metaHeader []zap.MetaData) (uint64, uint64)\n \t\treturn metaHeader[i].DocNum >= docNum\n \t})\n \tif i < len(metaHeader) && metaHeader[i].DocNum == docNum {\n-\t\treturn metaHeader[i].DocDvLoc, metaHeader[i].DocDvLen\n+\t\tvar start, end uint64\n+\t\tif i > 0 {\n+\t\t\tstart = metaHeader[i].DocDvOffset\n+\t\t}\n+\t\t// single element case","path":"cmd/bleve/cmd/zap/docvalue.go","position":20,"original_position":20,"commit_id":"aaccf59191dc5bc31fd2bb703e53d6dd4142a269","original_commit_id":"aaccf59191dc5bc31fd2bb703e53d6dd4142a269","user":{"login":"steveyen","id":30640,"avatar_url":"https://avatars3.githubusercontent.com/u/30640?v=4","gravatar_id":"","url":"https://api.github.com/users/steveyen","html_url":"https://github.com/steveyen","followers_url":"https://api.github.com/users/steveyen/followers","following_url":"https://api.github.com/users/steveyen/following{/other_user}","gists_url":"https://api.github.com/users/steveyen/gists{/gist_id}","starred_url":"https://api.github.com/users/steveyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveyen/subscriptions","organizations_url":"https://api.github.com/users/steveyen/orgs","repos_url":"https://api.github.com/users/steveyen/repos","events_url":"https://api.github.com/users/steveyen/events{/privacy}","received_events_url":"https://api.github.com/users/steveyen/received_events","type":"User","site_admin":false},"body":"not that this is incorrect, but it feels like this should be doable or simplify'able into two cases instead of three?  that is, we're at the end, or we're not at the end?","created_at":"2018-03-12T14:27:39Z","updated_at":"2018-03-12T14:29:48Z","html_url":"https://github.com/blevesearch/bleve/pull/821#discussion_r173814998","pull_request_url":"https://api.github.com/repos/blevesearch/bleve/pulls/821","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/blevesearch/bleve/pulls/comments/173814998"},"html":{"href":"https://github.com/blevesearch/bleve/pull/821#discussion_r173814998"},"pull_request":{"href":"https://api.github.com/repos/blevesearch/bleve/pulls/821"}}},"pull_request":{"url":"https://api.github.com/repos/blevesearch/bleve/pulls/821","id":174327494,"html_url":"https://github.com/blevesearch/bleve/pull/821","diff_url":"https://github.com/blevesearch/bleve/pull/821.diff","patch_url":"https://github.com/blevesearch/bleve/pull/821.patch","issue_url":"https://api.github.com/repos/blevesearch/bleve/issues/821","number":821,"state":"open","locked":false,"title":"docValue space savings","user":{"login":"sreekanth-cb","id":25240115,"avatar_url":"https://avatars1.githubusercontent.com/u/25240115?v=4","gravatar_id":"","url":"https://api.github.com/users/sreekanth-cb","html_url":"https://github.com/sreekanth-cb","followers_url":"https://api.github.com/users/sreekanth-cb/followers","following_url":"https://api.github.com/users/sreekanth-cb/following{/other_user}","gists_url":"https://api.github.com/users/sreekanth-cb/gists{/gist_id}","starred_url":"https://api.github.com/users/sreekanth-cb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sreekanth-cb/subscriptions","organizations_url":"https://api.github.com/users/sreekanth-cb/orgs","repos_url":"https://api.github.com/users/sreekanth-cb/repos","events_url":"https://api.github.com/users/sreekanth-cb/events{/privacy}","received_events_url":"https://api.github.com/users/sreekanth-cb/received_events","type":"User","site_admin":false},"body":"merging the meta doc value length and loc\r\nslices into a single offset slice  as that\r\nis enough to compute the starting offset and\r\nlength of the the doc values data for a given\r\ndocument inside a docValue chunk.","created_at":"2018-03-12T10:34:07Z","updated_at":"2018-03-12T14:29:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67d87fd5eba3371c0d08af8d065acd998203ee2b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mschoch","id":298143,"avatar_url":"https://avatars2.githubusercontent.com/u/298143?v=4","gravatar_id":"","url":"https://api.github.com/users/mschoch","html_url":"https://github.com/mschoch","followers_url":"https://api.github.com/users/mschoch/followers","following_url":"https://api.github.com/users/mschoch/following{/other_user}","gists_url":"https://api.github.com/users/mschoch/gists{/gist_id}","starred_url":"https://api.github.com/users/mschoch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mschoch/subscriptions","organizations_url":"https://api.github.com/users/mschoch/orgs","repos_url":"https://api.github.com/users/mschoch/repos","events_url":"https://api.github.com/users/mschoch/events{/privacy}","received_events_url":"https://api.github.com/users/mschoch/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/blevesearch/bleve/pulls/821/commits","review_comments_url":"https://api.github.com/repos/blevesearch/bleve/pulls/821/comments","review_comment_url":"https://api.github.com/repos/blevesearch/bleve/pulls/comments{/number}","comments_url":"https://api.github.com/repos/blevesearch/bleve/issues/821/comments","statuses_url":"https://api.github.com/repos/blevesearch/bleve/statuses/aaccf59191dc5bc31fd2bb703e53d6dd4142a269","head":{"label":"blevesearch:minor_docvalue_space_savings","ref":"minor_docvalue_space_savings","sha":"aaccf59191dc5bc31fd2bb703e53d6dd4142a269","user":{"login":"blevesearch","id":8562608,"avatar_url":"https://avatars2.githubusercontent.com/u/8562608?v=4","gravatar_id":"","url":"https://api.github.com/users/blevesearch","html_url":"https://github.com/blevesearch","followers_url":"https://api.github.com/users/blevesearch/followers","following_url":"https://api.github.com/users/blevesearch/following{/other_user}","gists_url":"https://api.github.com/users/blevesearch/gists{/gist_id}","starred_url":"https://api.github.com/users/blevesearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blevesearch/subscriptions","organizations_url":"https://api.github.com/users/blevesearch/orgs","repos_url":"https://api.github.com/users/blevesearch/repos","events_url":"https://api.github.com/users/blevesearch/events{/privacy}","received_events_url":"https://api.github.com/users/blevesearch/received_events","type":"Organization","site_admin":false},"repo":{"id":18893367,"name":"bleve","full_name":"blevesearch/bleve","owner":{"login":"blevesearch","id":8562608,"avatar_url":"https://avatars2.githubusercontent.com/u/8562608?v=4","gravatar_id":"","url":"https://api.github.com/users/blevesearch","html_url":"https://github.com/blevesearch","followers_url":"https://api.github.com/users/blevesearch/followers","following_url":"https://api.github.com/users/blevesearch/following{/other_user}","gists_url":"https://api.github.com/users/blevesearch/gists{/gist_id}","starred_url":"https://api.github.com/users/blevesearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blevesearch/subscriptions","organizations_url":"https://api.github.com/users/blevesearch/orgs","repos_url":"https://api.github.com/users/blevesearch/repos","events_url":"https://api.github.com/users/blevesearch/events{/privacy}","received_events_url":"https://api.github.com/users/blevesearch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/blevesearch/bleve","description":"A modern text indexing library for go","fork":false,"url":"https://api.github.com/repos/blevesearch/bleve","forks_url":"https://api.github.com/repos/blevesearch/bleve/forks","keys_url":"https://api.github.com/repos/blevesearch/bleve/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blevesearch/bleve/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blevesearch/bleve/teams","hooks_url":"https://api.github.com/repos/blevesearch/bleve/hooks","issue_events_url":"https://api.github.com/repos/blevesearch/bleve/issues/events{/number}","events_url":"https://api.github.com/repos/blevesearch/bleve/events","assignees_url":"https://api.github.com/repos/blevesearch/bleve/assignees{/user}","branches_url":"https://api.github.com/repos/blevesearch/bleve/branches{/branch}","tags_url":"https://api.github.com/repos/blevesearch/bleve/tags","blobs_url":"https://api.github.com/repos/blevesearch/bleve/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blevesearch/bleve/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blevesearch/bleve/git/refs{/sha}","trees_url":"https://api.github.com/repos/blevesearch/bleve/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blevesearch/bleve/statuses/{sha}","languages_url":"https://api.github.com/repos/blevesearch/bleve/languages","stargazers_url":"https://api.github.com/repos/blevesearch/bleve/stargazers","contributors_url":"https://api.github.com/repos/blevesearch/bleve/contributors","subscribers_url":"https://api.github.com/repos/blevesearch/bleve/subscribers","subscription_url":"https://api.github.com/repos/blevesearch/bleve/subscription","commits_url":"https://api.github.com/repos/blevesearch/bleve/commits{/sha}","git_commits_url":"https://api.github.com/repos/blevesearch/bleve/git/commits{/sha}","comments_url":"https://api.github.com/repos/blevesearch/bleve/comments{/number}","issue_comment_url":"https://api.github.com/repos/blevesearch/bleve/issues/comments{/number}","contents_url":"https://api.github.com/repos/blevesearch/bleve/contents/{+path}","compare_url":"https://api.github.com/repos/blevesearch/bleve/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blevesearch/bleve/merges","archive_url":"https://api.github.com/repos/blevesearch/bleve/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blevesearch/bleve/downloads","issues_url":"https://api.github.com/repos/blevesearch/bleve/issues{/number}","pulls_url":"https://api.github.com/repos/blevesearch/bleve/pulls{/number}","milestones_url":"https://api.github.com/repos/blevesearch/bleve/milestones{/number}","notifications_url":"https://api.github.com/repos/blevesearch/bleve/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blevesearch/bleve/labels{/name}","releases_url":"https://api.github.com/repos/blevesearch/bleve/releases{/id}","deployments_url":"https://api.github.com/repos/blevesearch/bleve/deployments","created_at":"2014-04-17T21:02:18Z","updated_at":"2018-03-12T14:13:27Z","pushed_at":"2018-03-12T10:34:08Z","git_url":"git://github.com/blevesearch/bleve.git","ssh_url":"git@github.com:blevesearch/bleve.git","clone_url":"https://github.com/blevesearch/bleve.git","svn_url":"https://github.com/blevesearch/bleve","homepage":null,"size":11886,"stargazers_count":4175,"watchers_count":4175,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":338,"mirror_url":null,"archived":false,"open_issues_count":114,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":338,"open_issues":114,"watchers":4175,"default_branch":"master"}},"base":{"label":"blevesearch:master","ref":"master","sha":"fa52ff856abfcf32a4f7b1e2d9ecc8a4182616cb","user":{"login":"blevesearch","id":8562608,"avatar_url":"https://avatars2.githubusercontent.com/u/8562608?v=4","gravatar_id":"","url":"https://api.github.com/users/blevesearch","html_url":"https://github.com/blevesearch","followers_url":"https://api.github.com/users/blevesearch/followers","following_url":"https://api.github.com/users/blevesearch/following{/other_user}","gists_url":"https://api.github.com/users/blevesearch/gists{/gist_id}","starred_url":"https://api.github.com/users/blevesearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blevesearch/subscriptions","organizations_url":"https://api.github.com/users/blevesearch/orgs","repos_url":"https://api.github.com/users/blevesearch/repos","events_url":"https://api.github.com/users/blevesearch/events{/privacy}","received_events_url":"https://api.github.com/users/blevesearch/received_events","type":"Organization","site_admin":false},"repo":{"id":18893367,"name":"bleve","full_name":"blevesearch/bleve","owner":{"login":"blevesearch","id":8562608,"avatar_url":"https://avatars2.githubusercontent.com/u/8562608?v=4","gravatar_id":"","url":"https://api.github.com/users/blevesearch","html_url":"https://github.com/blevesearch","followers_url":"https://api.github.com/users/blevesearch/followers","following_url":"https://api.github.com/users/blevesearch/following{/other_user}","gists_url":"https://api.github.com/users/blevesearch/gists{/gist_id}","starred_url":"https://api.github.com/users/blevesearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blevesearch/subscriptions","organizations_url":"https://api.github.com/users/blevesearch/orgs","repos_url":"https://api.github.com/users/blevesearch/repos","events_url":"https://api.github.com/users/blevesearch/events{/privacy}","received_events_url":"https://api.github.com/users/blevesearch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/blevesearch/bleve","description":"A modern text indexing library for go","fork":false,"url":"https://api.github.com/repos/blevesearch/bleve","forks_url":"https://api.github.com/repos/blevesearch/bleve/forks","keys_url":"https://api.github.com/repos/blevesearch/bleve/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blevesearch/bleve/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blevesearch/bleve/teams","hooks_url":"https://api.github.com/repos/blevesearch/bleve/hooks","issue_events_url":"https://api.github.com/repos/blevesearch/bleve/issues/events{/number}","events_url":"https://api.github.com/repos/blevesearch/bleve/events","assignees_url":"https://api.github.com/repos/blevesearch/bleve/assignees{/user}","branches_url":"https://api.github.com/repos/blevesearch/bleve/branches{/branch}","tags_url":"https://api.github.com/repos/blevesearch/bleve/tags","blobs_url":"https://api.github.com/repos/blevesearch/bleve/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blevesearch/bleve/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blevesearch/bleve/git/refs{/sha}","trees_url":"https://api.github.com/repos/blevesearch/bleve/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blevesearch/bleve/statuses/{sha}","languages_url":"https://api.github.com/repos/blevesearch/bleve/languages","stargazers_url":"https://api.github.com/repos/blevesearch/bleve/stargazers","contributors_url":"https://api.github.com/repos/blevesearch/bleve/contributors","subscribers_url":"https://api.github.com/repos/blevesearch/bleve/subscribers","subscription_url":"https://api.github.com/repos/blevesearch/bleve/subscription","commits_url":"https://api.github.com/repos/blevesearch/bleve/commits{/sha}","git_commits_url":"https://api.github.com/repos/blevesearch/bleve/git/commits{/sha}","comments_url":"https://api.github.com/repos/blevesearch/bleve/comments{/number}","issue_comment_url":"https://api.github.com/repos/blevesearch/bleve/issues/comments{/number}","contents_url":"https://api.github.com/repos/blevesearch/bleve/contents/{+path}","compare_url":"https://api.github.com/repos/blevesearch/bleve/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blevesearch/bleve/merges","archive_url":"https://api.github.com/repos/blevesearch/bleve/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blevesearch/bleve/downloads","issues_url":"https://api.github.com/repos/blevesearch/bleve/issues{/number}","pulls_url":"https://api.github.com/repos/blevesearch/bleve/pulls{/number}","milestones_url":"https://api.github.com/repos/blevesearch/bleve/milestones{/number}","notifications_url":"https://api.github.com/repos/blevesearch/bleve/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blevesearch/bleve/labels{/name}","releases_url":"https://api.github.com/repos/blevesearch/bleve/releases{/id}","deployments_url":"https://api.github.com/repos/blevesearch/bleve/deployments","created_at":"2014-04-17T21:02:18Z","updated_at":"2018-03-12T14:13:27Z","pushed_at":"2018-03-12T10:34:08Z","git_url":"git://github.com/blevesearch/bleve.git","ssh_url":"git@github.com:blevesearch/bleve.git","clone_url":"https://github.com/blevesearch/bleve.git","svn_url":"https://github.com/blevesearch/bleve","homepage":null,"size":11886,"stargazers_count":4175,"watchers_count":4175,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":338,"mirror_url":null,"archived":false,"open_issues_count":114,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":338,"open_issues":114,"watchers":4175,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/blevesearch/bleve/pulls/821"},"html":{"href":"https://github.com/blevesearch/bleve/pull/821"},"issue":{"href":"https://api.github.com/repos/blevesearch/bleve/issues/821"},"comments":{"href":"https://api.github.com/repos/blevesearch/bleve/issues/821/comments"},"review_comments":{"href":"https://api.github.com/repos/blevesearch/bleve/pulls/821/comments"},"review_comment":{"href":"https://api.github.com/repos/blevesearch/bleve/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/blevesearch/bleve/pulls/821/commits"},"statuses":{"href":"https://api.github.com/repos/blevesearch/bleve/statuses/aaccf59191dc5bc31fd2bb703e53d6dd4142a269"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"steveyen"}}