{"action":"created","issue":{"url":"https://api.github.com/repos/triplea-game/infrastructure/issues/151","repository_url":"https://api.github.com/repos/triplea-game/infrastructure","labels_url":"https://api.github.com/repos/triplea-game/infrastructure/issues/151/labels{/name}","comments_url":"https://api.github.com/repos/triplea-game/infrastructure/issues/151/comments","events_url":"https://api.github.com/repos/triplea-game/infrastructure/issues/151/events","html_url":"https://github.com/triplea-game/infrastructure/pull/151","id":368029360,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMjk5ODg2","number":151,"title":"Clean old builds on param value, fix shell check issues, default bot port","user":{"login":"DanVanAtta","id":12397753,"node_id":"MDQ6VXNlcjEyMzk3NzUz","avatar_url":"https://avatars2.githubusercontent.com/u/12397753?v=4","gravatar_id":"","url":"https://api.github.com/users/DanVanAtta","html_url":"https://github.com/DanVanAtta","followers_url":"https://api.github.com/users/DanVanAtta/followers","following_url":"https://api.github.com/users/DanVanAtta/following{/other_user}","gists_url":"https://api.github.com/users/DanVanAtta/gists{/gist_id}","starred_url":"https://api.github.com/users/DanVanAtta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanVanAtta/subscriptions","organizations_url":"https://api.github.com/users/DanVanAtta/orgs","repos_url":"https://api.github.com/users/DanVanAtta/repos","events_url":"https://api.github.com/users/DanVanAtta/events{/privacy}","received_events_url":"https://api.github.com/users/DanVanAtta/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-10-09T03:43:26Z","updated_at":"2018-11-25T17:45:38Z","closed_at":"2018-11-25T17:44:18Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/triplea-game/infrastructure/pulls/151","html_url":"https://github.com/triplea-game/infrastructure/pull/151","diff_url":"https://github.com/triplea-game/infrastructure/pull/151.diff","patch_url":"https://github.com/triplea-game/infrastructure/pull/151.patch"},"body":"- remove explicit bot param for port, set it to 8000 by default\r\n- add parameters for restarting and cleaning old installations when new\r\nsoftware is installed. Set to true for preprod.\r\n- in host_control, move single-use 'preprod-bot' variable to point of usage so that params can be defined in one spot.\r\n- couple shell checks here and there with double quotes\r\n\r\n\r\n---------\r\n\r\n## Testing:\r\n\r\nOf big note, the find and delete command is dangerous! Please have a second look around that to be sure execute that only on prerelease system. Below is some output from my testing of the find+delete:\r\n```\r\nadmin@PreRelease:~$ BASE_FOLDER=\"/home/triplea/lobby\"\r\nadmin@PreRelease:~$ export TAG=1.9.0.0.12378\r\nadmin@PreRelease:~$ find ${BASE_FOLDER} -mindepth 1 -maxdepth 1 -type d | grep -v $TAG\r\n/home/triplea/lobby/1.9.0.0.12375\r\n/home/triplea/lobby/1.9.0.0.12355\r\n\r\n\r\nadmin@PreRelease:~$ find ${BASE_FOLDER} -mindepth 1 -maxdepth 1 -type d \r\n/home/triplea/lobby/1.9.0.0.12375\r\n/home/triplea/lobby/1.9.0.0.12378\r\n/home/triplea/lobby/1.9.0.0.12355\r\n\r\n\r\n\r\nadmin@PreRelease:~$ find ${BASE_FOLDER} -mindepth 1 -maxdepth 1 -type d | grep -v $TAG | xargs rm -rf\r\nrm: cannot remove '/home/triplea/lobby/1.9.0.0.12375/run_lobby.sh': Permission denied\r\nrm: cannot remove '/home/triplea/lobby/1.9.0.0.12375/remove_lobby.sh': Permission denied\r\nrm: cannot remove '/home/triplea/lobby/1.9.0.0.12375/.install.success': Permission denied\r\nrm: cannot remove '/home/triplea/lobby/1.9.0.0.12375/config/lobby/lobby.properties': Permission denied\r\nrm: cannot remove '/home/triplea/lobby/1.9.0.0.12375/version': Permission denied\r\nrm: cannot remove '/home/triplea/lobby/1.9.0.0.12375/bin/triplea-lobby-1.9.0.0.12375-all.jar': Permission denied\r\nrm: cannot remove '/home/triplea/lobby/1.9.0.0.12355/run_lobby.sh': Permission denied\r\nrm: cannot remove '/home/triplea/lobby/1.9.0.0.12355/remove_lobby.sh': Permission denied\r\nrm: cannot remove '/home/triplea/lobby/1.9.0.0.12355/.install.success': Permission denied\r\nrm: cannot remove '/home/triplea/lobby/1.9.0.0.12355/config/lobby/lobby.properties': Permission denied\r\nrm: cannot remove '/home/triplea/lobby/1.9.0.0.12355/version': Permission denied\r\nrm: cannot remove '/home/triplea/lobby/1.9.0.0.12355/bin/triplea-lobby-1.9.0.0.12355-all.jar': Permission denied\r\n```\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/triplea-game/infrastructure/issues/comments/441458305","html_url":"https://github.com/triplea-game/infrastructure/pull/151#issuecomment-441458305","issue_url":"https://api.github.com/repos/triplea-game/infrastructure/issues/151","id":441458305,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTQ1ODMwNQ==","user":{"login":"DanVanAtta","id":12397753,"node_id":"MDQ6VXNlcjEyMzk3NzUz","avatar_url":"https://avatars2.githubusercontent.com/u/12397753?v=4","gravatar_id":"","url":"https://api.github.com/users/DanVanAtta","html_url":"https://github.com/DanVanAtta","followers_url":"https://api.github.com/users/DanVanAtta/followers","following_url":"https://api.github.com/users/DanVanAtta/following{/other_user}","gists_url":"https://api.github.com/users/DanVanAtta/gists{/gist_id}","starred_url":"https://api.github.com/users/DanVanAtta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanVanAtta/subscriptions","organizations_url":"https://api.github.com/users/DanVanAtta/orgs","repos_url":"https://api.github.com/users/DanVanAtta/repos","events_url":"https://api.github.com/users/DanVanAtta/events{/privacy}","received_events_url":"https://api.github.com/users/DanVanAtta/received_events","type":"User","site_admin":false},"created_at":"2018-11-25T17:45:38Z","updated_at":"2018-11-25T17:45:38Z","author_association":"MEMBER","body":"re: merge strategy, it looks like we need different merge strategies when merging to master vs when we are merging to 'environment' branches (eg: prod). Squash-rebase of all changes on master to prod seems to go on to cause conflicts, so a rebase-merge seems the way to go when merging to prod. Otherwise squash seems appropriate when merging to master."}}
{"actor":{"display_login":"DanVanAtta"}}