{"action":"created","issue":{"url":"https://api.github.com/repos/sofa-framework/sofa/issues/617","repository_url":"https://api.github.com/repos/sofa-framework/sofa","labels_url":"https://api.github.com/repos/sofa-framework/sofa/issues/617/labels{/name}","comments_url":"https://api.github.com/repos/sofa-framework/sofa/issues/617/comments","events_url":"https://api.github.com/repos/sofa-framework/sofa/issues/617/events","html_url":"https://github.com/sofa-framework/sofa/pull/617","id":308875777,"number":617,"title":"More robust method to test end of string","user":{"login":"alxbilger","id":10572752,"avatar_url":"https://avatars2.githubusercontent.com/u/10572752?v=4","gravatar_id":"","url":"https://api.github.com/users/alxbilger","html_url":"https://github.com/alxbilger","followers_url":"https://api.github.com/users/alxbilger/followers","following_url":"https://api.github.com/users/alxbilger/following{/other_user}","gists_url":"https://api.github.com/users/alxbilger/gists{/gist_id}","starred_url":"https://api.github.com/users/alxbilger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alxbilger/subscriptions","organizations_url":"https://api.github.com/users/alxbilger/orgs","repos_url":"https://api.github.com/users/alxbilger/repos","events_url":"https://api.github.com/users/alxbilger/events{/privacy}","received_events_url":"https://api.github.com/users/alxbilger/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-03-27T08:46:53Z","updated_at":"2018-03-27T13:52:43Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/sofa-framework/sofa/pulls/617","html_url":"https://github.com/sofa-framework/sofa/pull/617","diff_url":"https://github.com/sofa-framework/sofa/pull/617.diff","patch_url":"https://github.com/sofa-framework/sofa/pull/617.patch"},"body":"The case where plugin is smaller than dotExt is not handled by std::equal. See how it works: http://en.cppreference.com/w/cpp/algorithm/equal. An assert is called.\r\nI had the case when dotExt = \".dll\" and plugin = \"PSL\".\r\n\r\n\r\n\r\n\r\n\r\n\r\n______________________________________________________\r\n<!--- Please leave this at the end of your message -->\r\nThis PR: \r\n- [ ] builds with SUCCESS for all platforms on the CI.\r\n- [ ] does not generate new warnings.\r\n- [ ] does not generate new unit test failures.\r\n- [ ] does not generate new scene test failures.\r\n- [ ] does not break API compatibility.\r\n- [ ] is more than 1 week old (or has fast-merge label).\r\n\r\n**Reviewers will merge only if all these checks are true.**\r\n"},"comment":{"url":"https://api.github.com/repos/sofa-framework/sofa/issues/comments/376533098","html_url":"https://github.com/sofa-framework/sofa/pull/617#issuecomment-376533098","issue_url":"https://api.github.com/repos/sofa-framework/sofa/issues/617","id":376533098,"user":{"login":"guparan","id":1651667,"avatar_url":"https://avatars2.githubusercontent.com/u/1651667?v=4","gravatar_id":"","url":"https://api.github.com/users/guparan","html_url":"https://github.com/guparan","followers_url":"https://api.github.com/users/guparan/followers","following_url":"https://api.github.com/users/guparan/following{/other_user}","gists_url":"https://api.github.com/users/guparan/gists{/gist_id}","starred_url":"https://api.github.com/users/guparan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guparan/subscriptions","organizations_url":"https://api.github.com/users/guparan/orgs","repos_url":"https://api.github.com/users/guparan/repos","events_url":"https://api.github.com/users/guparan/events{/privacy}","received_events_url":"https://api.github.com/users/guparan/received_events","type":"User","site_admin":false},"created_at":"2018-03-27T13:52:43Z","updated_at":"2018-03-27T13:52:43Z","author_association":"OWNER","body":"You are right I answered too fast. Actually your fix is exactly what is needed.\r\nCould you propagate it to other `if (std::equal(dotExt.rbegin(), dotExt.rend(), plugin.rbegin()))` calls (there are others)?"}}
{"actor":{"display_login":"guparan"}}