{"action":"created","comment":{"url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/pulls/comments/237359235","pull_request_review_id":179635278,"id":237359235,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzM1OTIzNQ==","diff_hunk":"@@ -0,0 +1,9 @@\n+openjdk:\n+  - 8\n+  - 9\n+  - 10","path":"recipe/conda_build_config.yaml","position":4,"original_position":4,"commit_id":"0a04c3a97b2e16ec21d422264652c8fb3051daa6","original_commit_id":"0a04c3a97b2e16ec21d422264652c8fb3051daa6","user":{"login":"hadim","id":528003,"node_id":"MDQ6VXNlcjUyODAwMw==","avatar_url":"https://avatars0.githubusercontent.com/u/528003?v=4","gravatar_id":"","url":"https://api.github.com/users/hadim","html_url":"https://github.com/hadim","followers_url":"https://api.github.com/users/hadim/followers","following_url":"https://api.github.com/users/hadim/following{/other_user}","gists_url":"https://api.github.com/users/hadim/gists{/gist_id}","starred_url":"https://api.github.com/users/hadim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hadim/subscriptions","organizations_url":"https://api.github.com/users/hadim/orgs","repos_url":"https://api.github.com/users/hadim/repos","events_url":"https://api.github.com/users/hadim/events{/privacy}","received_events_url":"https://api.github.com/users/hadim/received_events","type":"User","site_admin":false},"body":"Projects such as Imagej does not support Java 11 yet while it supports Java 9 which has modern feature Java 8 does not have.\r\n\r\nConda OpenJDK builds are available so I don't see anything bad to support it. Moreover, by default with `conda install openjdk`, people will get the latest Java 11 version.","created_at":"2018-11-29T05:41:17Z","updated_at":"2018-11-29T05:41:17Z","html_url":"https://github.com/conda-forge/pyjnius-feedstock/pull/5#discussion_r237359235","pull_request_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/pulls/5","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/pulls/comments/237359235"},"html":{"href":"https://github.com/conda-forge/pyjnius-feedstock/pull/5#discussion_r237359235"},"pull_request":{"href":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/pulls/5"}},"in_reply_to_id":237358618},"pull_request":{"url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/pulls/5","id":233006870,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMDA2ODcw","html_url":"https://github.com/conda-forge/pyjnius-feedstock/pull/5","diff_url":"https://github.com/conda-forge/pyjnius-feedstock/pull/5.diff","patch_url":"https://github.com/conda-forge/pyjnius-feedstock/pull/5.patch","issue_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/issues/5","number":5,"state":"open","locked":false,"title":"Pin Java version + add support for Java 9, 10, 11","user":{"login":"hadim","id":528003,"node_id":"MDQ6VXNlcjUyODAwMw==","avatar_url":"https://avatars0.githubusercontent.com/u/528003?v=4","gravatar_id":"","url":"https://api.github.com/users/hadim","html_url":"https://github.com/hadim","followers_url":"https://api.github.com/users/hadim/followers","following_url":"https://api.github.com/users/hadim/following{/other_user}","gists_url":"https://api.github.com/users/hadim/gists{/gist_id}","starred_url":"https://api.github.com/users/hadim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hadim/subscriptions","organizations_url":"https://api.github.com/users/hadim/orgs","repos_url":"https://api.github.com/users/hadim/repos","events_url":"https://api.github.com/users/hadim/events{/privacy}","received_events_url":"https://api.github.com/users/hadim/received_events","type":"User","site_admin":false},"body":"@hanslovsky: Here is a first try to pin the Java version.","created_at":"2018-11-22T14:58:55Z","updated_at":"2018-11-29T05:41:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05ce057da4da83c091afa4d8f25262ded52354a3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/pulls/5/commits","review_comments_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/pulls/5/comments","review_comment_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/issues/5/comments","statuses_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/statuses/0a04c3a97b2e16ec21d422264652c8fb3051daa6","head":{"label":"hadim:pinjava","ref":"pinjava","sha":"0a04c3a97b2e16ec21d422264652c8fb3051daa6","user":{"login":"hadim","id":528003,"node_id":"MDQ6VXNlcjUyODAwMw==","avatar_url":"https://avatars0.githubusercontent.com/u/528003?v=4","gravatar_id":"","url":"https://api.github.com/users/hadim","html_url":"https://github.com/hadim","followers_url":"https://api.github.com/users/hadim/followers","following_url":"https://api.github.com/users/hadim/following{/other_user}","gists_url":"https://api.github.com/users/hadim/gists{/gist_id}","starred_url":"https://api.github.com/users/hadim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hadim/subscriptions","organizations_url":"https://api.github.com/users/hadim/orgs","repos_url":"https://api.github.com/users/hadim/repos","events_url":"https://api.github.com/users/hadim/events{/privacy}","received_events_url":"https://api.github.com/users/hadim/received_events","type":"User","site_admin":false},"repo":{"id":158112919,"node_id":"MDEwOlJlcG9zaXRvcnkxNTgxMTI5MTk=","name":"pyjnius-feedstock","full_name":"hadim/pyjnius-feedstock","private":false,"owner":{"login":"hadim","id":528003,"node_id":"MDQ6VXNlcjUyODAwMw==","avatar_url":"https://avatars0.githubusercontent.com/u/528003?v=4","gravatar_id":"","url":"https://api.github.com/users/hadim","html_url":"https://github.com/hadim","followers_url":"https://api.github.com/users/hadim/followers","following_url":"https://api.github.com/users/hadim/following{/other_user}","gists_url":"https://api.github.com/users/hadim/gists{/gist_id}","starred_url":"https://api.github.com/users/hadim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hadim/subscriptions","organizations_url":"https://api.github.com/users/hadim/orgs","repos_url":"https://api.github.com/users/hadim/repos","events_url":"https://api.github.com/users/hadim/events{/privacy}","received_events_url":"https://api.github.com/users/hadim/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hadim/pyjnius-feedstock","description":"A conda-smithy repository for pyjnius.","fork":true,"url":"https://api.github.com/repos/hadim/pyjnius-feedstock","forks_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/forks","keys_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/teams","hooks_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/hooks","issue_events_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/issues/events{/number}","events_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/events","assignees_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/assignees{/user}","branches_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/branches{/branch}","tags_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/tags","blobs_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/git/refs{/sha}","trees_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/statuses/{sha}","languages_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/languages","stargazers_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/stargazers","contributors_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/contributors","subscribers_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/subscribers","subscription_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/subscription","commits_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/commits{/sha}","git_commits_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/git/commits{/sha}","comments_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/comments{/number}","issue_comment_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/issues/comments{/number}","contents_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/contents/{+path}","compare_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/merges","archive_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/downloads","issues_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/issues{/number}","pulls_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/pulls{/number}","milestones_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/milestones{/number}","notifications_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/labels{/name}","releases_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/releases{/id}","deployments_url":"https://api.github.com/repos/hadim/pyjnius-feedstock/deployments","created_at":"2018-11-18T18:14:01Z","updated_at":"2018-11-18T18:14:04Z","pushed_at":"2018-11-29T04:47:17Z","git_url":"git://github.com/hadim/pyjnius-feedstock.git","ssh_url":"git@github.com:hadim/pyjnius-feedstock.git","clone_url":"https://github.com/hadim/pyjnius-feedstock.git","svn_url":"https://github.com/hadim/pyjnius-feedstock","homepage":null,"size":51,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"conda-forge:master","ref":"master","sha":"e3717e14ec732b923e92658756f2deba25e53645","user":{"login":"conda-forge","id":11897326,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODk3MzI2","avatar_url":"https://avatars3.githubusercontent.com/u/11897326?v=4","gravatar_id":"","url":"https://api.github.com/users/conda-forge","html_url":"https://github.com/conda-forge","followers_url":"https://api.github.com/users/conda-forge/followers","following_url":"https://api.github.com/users/conda-forge/following{/other_user}","gists_url":"https://api.github.com/users/conda-forge/gists{/gist_id}","starred_url":"https://api.github.com/users/conda-forge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conda-forge/subscriptions","organizations_url":"https://api.github.com/users/conda-forge/orgs","repos_url":"https://api.github.com/users/conda-forge/repos","events_url":"https://api.github.com/users/conda-forge/events{/privacy}","received_events_url":"https://api.github.com/users/conda-forge/received_events","type":"Organization","site_admin":false},"repo":{"id":141728663,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE3Mjg2NjM=","name":"pyjnius-feedstock","full_name":"conda-forge/pyjnius-feedstock","private":false,"owner":{"login":"conda-forge","id":11897326,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODk3MzI2","avatar_url":"https://avatars3.githubusercontent.com/u/11897326?v=4","gravatar_id":"","url":"https://api.github.com/users/conda-forge","html_url":"https://github.com/conda-forge","followers_url":"https://api.github.com/users/conda-forge/followers","following_url":"https://api.github.com/users/conda-forge/following{/other_user}","gists_url":"https://api.github.com/users/conda-forge/gists{/gist_id}","starred_url":"https://api.github.com/users/conda-forge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conda-forge/subscriptions","organizations_url":"https://api.github.com/users/conda-forge/orgs","repos_url":"https://api.github.com/users/conda-forge/repos","events_url":"https://api.github.com/users/conda-forge/events{/privacy}","received_events_url":"https://api.github.com/users/conda-forge/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/conda-forge/pyjnius-feedstock","description":"A conda-smithy repository for pyjnius.","fork":false,"url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock","forks_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/forks","keys_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/teams","hooks_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/hooks","issue_events_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/issues/events{/number}","events_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/events","assignees_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/assignees{/user}","branches_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/branches{/branch}","tags_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/tags","blobs_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/git/refs{/sha}","trees_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/statuses/{sha}","languages_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/languages","stargazers_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/stargazers","contributors_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/contributors","subscribers_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/subscribers","subscription_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/subscription","commits_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/commits{/sha}","git_commits_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/git/commits{/sha}","comments_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/comments{/number}","issue_comment_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/issues/comments{/number}","contents_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/contents/{+path}","compare_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/merges","archive_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/downloads","issues_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/issues{/number}","pulls_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/pulls{/number}","milestones_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/milestones{/number}","notifications_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/labels{/name}","releases_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/releases{/id}","deployments_url":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/deployments","created_at":"2018-07-20T15:27:48Z","updated_at":"2018-11-22T14:11:44Z","pushed_at":"2018-11-29T04:47:19Z","git_url":"git://github.com/conda-forge/pyjnius-feedstock.git","ssh_url":"git@github.com:conda-forge/pyjnius-feedstock.git","clone_url":"https://github.com/conda-forge/pyjnius-feedstock.git","svn_url":"https://github.com/conda-forge/pyjnius-feedstock","homepage":null,"size":20,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/pulls/5"},"html":{"href":"https://github.com/conda-forge/pyjnius-feedstock/pull/5"},"issue":{"href":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/issues/5"},"comments":{"href":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/conda-forge/pyjnius-feedstock/statuses/0a04c3a97b2e16ec21d422264652c8fb3051daa6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hadim"}}