{"action":"created","comment":{"url":"https://api.github.com/repos/m-labs/smoltcp/pulls/comments/165993908","pull_request_review_id":94015335,"id":165993908,"diff_hunk":"@@ -62,6 +67,13 @@ impl Instant {\n     pub fn total_millis(&self) -> i64 {\n         self.millis\n     }\n+\n+    /// Return the [Duration] between two [Instant's].\n+    ///\n+    /// [Duration] struct.Duration.html\n+    pub fn duration_since(&self, other: Instant) -> Duration {","path":"src/time.rs","position":31,"original_position":31,"commit_id":"f2fc25d8a16a61fc62977e8c4e55aec644ddde66","original_commit_id":"f2fc25d8a16a61fc62977e8c4e55aec644ddde66","user":{"login":"dlrobertson","id":7504153,"avatar_url":"https://avatars1.githubusercontent.com/u/7504153?v=4","gravatar_id":"","url":"https://api.github.com/users/dlrobertson","html_url":"https://github.com/dlrobertson","followers_url":"https://api.github.com/users/dlrobertson/followers","following_url":"https://api.github.com/users/dlrobertson/following{/other_user}","gists_url":"https://api.github.com/users/dlrobertson/gists{/gist_id}","starred_url":"https://api.github.com/users/dlrobertson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlrobertson/subscriptions","organizations_url":"https://api.github.com/users/dlrobertson/orgs","repos_url":"https://api.github.com/users/dlrobertson/repos","events_url":"https://api.github.com/users/dlrobertson/events{/privacy}","received_events_url":"https://api.github.com/users/dlrobertson/received_events","type":"User","site_admin":false},"body":"👍 ","created_at":"2018-02-05T14:52:59Z","updated_at":"2018-02-05T14:52:59Z","html_url":"https://github.com/m-labs/smoltcp/pull/141#discussion_r165993908","pull_request_url":"https://api.github.com/repos/m-labs/smoltcp/pulls/141","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/m-labs/smoltcp/pulls/comments/165993908"},"html":{"href":"https://github.com/m-labs/smoltcp/pull/141#discussion_r165993908"},"pull_request":{"href":"https://api.github.com/repos/m-labs/smoltcp/pulls/141"}},"in_reply_to_id":165989799},"pull_request":{"url":"https://api.github.com/repos/m-labs/smoltcp/pulls/141","id":166420007,"html_url":"https://github.com/m-labs/smoltcp/pull/141","diff_url":"https://github.com/m-labs/smoltcp/pull/141.diff","patch_url":"https://github.com/m-labs/smoltcp/pull/141.patch","issue_url":"https://api.github.com/repos/m-labs/smoltcp/issues/141","number":141,"state":"open","locked":false,"title":"[WIP] Use the time types instead of a u64","user":{"login":"dlrobertson","id":7504153,"avatar_url":"https://avatars1.githubusercontent.com/u/7504153?v=4","gravatar_id":"","url":"https://api.github.com/users/dlrobertson","html_url":"https://github.com/dlrobertson","followers_url":"https://api.github.com/users/dlrobertson/followers","following_url":"https://api.github.com/users/dlrobertson/following{/other_user}","gists_url":"https://api.github.com/users/dlrobertson/gists{/gist_id}","starred_url":"https://api.github.com/users/dlrobertson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlrobertson/subscriptions","organizations_url":"https://api.github.com/users/dlrobertson/orgs","repos_url":"https://api.github.com/users/dlrobertson/repos","events_url":"https://api.github.com/users/dlrobertson/events{/privacy}","received_events_url":"https://api.github.com/users/dlrobertson/received_events","type":"User","site_admin":false},"body":"Use the [Instant] and [Duration] types defined in #110\r\n\r\nThis isn't nearly done. I simply use `total_millis` where we should probably continue to pass the time type along. I'd like to get feedback and make sure I'm going the right direction before making all of the changes.\r\n\r\n[Instant]: https://github.com/m-labs/smoltcp/blob/master/src/time.rs#L29\r\n[Duration]: https://github.com/m-labs/smoltcp/blob/master/src/time.rs#L102","created_at":"2018-02-01T01:15:52Z","updated_at":"2018-02-05T14:52:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db9bca1a58b620c5d3c8c550ba23e1383654fc29","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/m-labs/smoltcp/pulls/141/commits","review_comments_url":"https://api.github.com/repos/m-labs/smoltcp/pulls/141/comments","review_comment_url":"https://api.github.com/repos/m-labs/smoltcp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/m-labs/smoltcp/issues/141/comments","statuses_url":"https://api.github.com/repos/m-labs/smoltcp/statuses/f2fc25d8a16a61fc62977e8c4e55aec644ddde66","head":{"label":"dlrobertson:add_timestamp","ref":"add_timestamp","sha":"f2fc25d8a16a61fc62977e8c4e55aec644ddde66","user":{"login":"dlrobertson","id":7504153,"avatar_url":"https://avatars1.githubusercontent.com/u/7504153?v=4","gravatar_id":"","url":"https://api.github.com/users/dlrobertson","html_url":"https://github.com/dlrobertson","followers_url":"https://api.github.com/users/dlrobertson/followers","following_url":"https://api.github.com/users/dlrobertson/following{/other_user}","gists_url":"https://api.github.com/users/dlrobertson/gists{/gist_id}","starred_url":"https://api.github.com/users/dlrobertson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlrobertson/subscriptions","organizations_url":"https://api.github.com/users/dlrobertson/orgs","repos_url":"https://api.github.com/users/dlrobertson/repos","events_url":"https://api.github.com/users/dlrobertson/events{/privacy}","received_events_url":"https://api.github.com/users/dlrobertson/received_events","type":"User","site_admin":false},"repo":{"id":106954222,"name":"smoltcp","full_name":"dlrobertson/smoltcp","owner":{"login":"dlrobertson","id":7504153,"avatar_url":"https://avatars1.githubusercontent.com/u/7504153?v=4","gravatar_id":"","url":"https://api.github.com/users/dlrobertson","html_url":"https://github.com/dlrobertson","followers_url":"https://api.github.com/users/dlrobertson/followers","following_url":"https://api.github.com/users/dlrobertson/following{/other_user}","gists_url":"https://api.github.com/users/dlrobertson/gists{/gist_id}","starred_url":"https://api.github.com/users/dlrobertson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlrobertson/subscriptions","organizations_url":"https://api.github.com/users/dlrobertson/orgs","repos_url":"https://api.github.com/users/dlrobertson/repos","events_url":"https://api.github.com/users/dlrobertson/events{/privacy}","received_events_url":"https://api.github.com/users/dlrobertson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dlrobertson/smoltcp","description":"a smol tcp/ip stack","fork":true,"url":"https://api.github.com/repos/dlrobertson/smoltcp","forks_url":"https://api.github.com/repos/dlrobertson/smoltcp/forks","keys_url":"https://api.github.com/repos/dlrobertson/smoltcp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlrobertson/smoltcp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlrobertson/smoltcp/teams","hooks_url":"https://api.github.com/repos/dlrobertson/smoltcp/hooks","issue_events_url":"https://api.github.com/repos/dlrobertson/smoltcp/issues/events{/number}","events_url":"https://api.github.com/repos/dlrobertson/smoltcp/events","assignees_url":"https://api.github.com/repos/dlrobertson/smoltcp/assignees{/user}","branches_url":"https://api.github.com/repos/dlrobertson/smoltcp/branches{/branch}","tags_url":"https://api.github.com/repos/dlrobertson/smoltcp/tags","blobs_url":"https://api.github.com/repos/dlrobertson/smoltcp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlrobertson/smoltcp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlrobertson/smoltcp/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlrobertson/smoltcp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlrobertson/smoltcp/statuses/{sha}","languages_url":"https://api.github.com/repos/dlrobertson/smoltcp/languages","stargazers_url":"https://api.github.com/repos/dlrobertson/smoltcp/stargazers","contributors_url":"https://api.github.com/repos/dlrobertson/smoltcp/contributors","subscribers_url":"https://api.github.com/repos/dlrobertson/smoltcp/subscribers","subscription_url":"https://api.github.com/repos/dlrobertson/smoltcp/subscription","commits_url":"https://api.github.com/repos/dlrobertson/smoltcp/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlrobertson/smoltcp/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlrobertson/smoltcp/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlrobertson/smoltcp/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlrobertson/smoltcp/contents/{+path}","compare_url":"https://api.github.com/repos/dlrobertson/smoltcp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlrobertson/smoltcp/merges","archive_url":"https://api.github.com/repos/dlrobertson/smoltcp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlrobertson/smoltcp/downloads","issues_url":"https://api.github.com/repos/dlrobertson/smoltcp/issues{/number}","pulls_url":"https://api.github.com/repos/dlrobertson/smoltcp/pulls{/number}","milestones_url":"https://api.github.com/repos/dlrobertson/smoltcp/milestones{/number}","notifications_url":"https://api.github.com/repos/dlrobertson/smoltcp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlrobertson/smoltcp/labels{/name}","releases_url":"https://api.github.com/repos/dlrobertson/smoltcp/releases{/id}","deployments_url":"https://api.github.com/repos/dlrobertson/smoltcp/deployments","created_at":"2017-10-14T18:53:31Z","updated_at":"2017-10-14T18:53:33Z","pushed_at":"2018-02-05T14:42:12Z","git_url":"git://github.com/dlrobertson/smoltcp.git","ssh_url":"git@github.com:dlrobertson/smoltcp.git","clone_url":"https://github.com/dlrobertson/smoltcp.git","svn_url":"https://github.com/dlrobertson/smoltcp","homepage":null,"size":1035,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"m-labs:master","ref":"master","sha":"d2b8f526f3fd5e9bd439c7baf16aca1ffe41d617","user":{"login":"m-labs","id":116047,"avatar_url":"https://avatars3.githubusercontent.com/u/116047?v=4","gravatar_id":"","url":"https://api.github.com/users/m-labs","html_url":"https://github.com/m-labs","followers_url":"https://api.github.com/users/m-labs/followers","following_url":"https://api.github.com/users/m-labs/following{/other_user}","gists_url":"https://api.github.com/users/m-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/m-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-labs/subscriptions","organizations_url":"https://api.github.com/users/m-labs/orgs","repos_url":"https://api.github.com/users/m-labs/repos","events_url":"https://api.github.com/users/m-labs/events{/privacy}","received_events_url":"https://api.github.com/users/m-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":75406961,"name":"smoltcp","full_name":"m-labs/smoltcp","owner":{"login":"m-labs","id":116047,"avatar_url":"https://avatars3.githubusercontent.com/u/116047?v=4","gravatar_id":"","url":"https://api.github.com/users/m-labs","html_url":"https://github.com/m-labs","followers_url":"https://api.github.com/users/m-labs/followers","following_url":"https://api.github.com/users/m-labs/following{/other_user}","gists_url":"https://api.github.com/users/m-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/m-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-labs/subscriptions","organizations_url":"https://api.github.com/users/m-labs/orgs","repos_url":"https://api.github.com/users/m-labs/repos","events_url":"https://api.github.com/users/m-labs/events{/privacy}","received_events_url":"https://api.github.com/users/m-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/m-labs/smoltcp","description":"a smol tcp/ip stack","fork":false,"url":"https://api.github.com/repos/m-labs/smoltcp","forks_url":"https://api.github.com/repos/m-labs/smoltcp/forks","keys_url":"https://api.github.com/repos/m-labs/smoltcp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m-labs/smoltcp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m-labs/smoltcp/teams","hooks_url":"https://api.github.com/repos/m-labs/smoltcp/hooks","issue_events_url":"https://api.github.com/repos/m-labs/smoltcp/issues/events{/number}","events_url":"https://api.github.com/repos/m-labs/smoltcp/events","assignees_url":"https://api.github.com/repos/m-labs/smoltcp/assignees{/user}","branches_url":"https://api.github.com/repos/m-labs/smoltcp/branches{/branch}","tags_url":"https://api.github.com/repos/m-labs/smoltcp/tags","blobs_url":"https://api.github.com/repos/m-labs/smoltcp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m-labs/smoltcp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m-labs/smoltcp/git/refs{/sha}","trees_url":"https://api.github.com/repos/m-labs/smoltcp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m-labs/smoltcp/statuses/{sha}","languages_url":"https://api.github.com/repos/m-labs/smoltcp/languages","stargazers_url":"https://api.github.com/repos/m-labs/smoltcp/stargazers","contributors_url":"https://api.github.com/repos/m-labs/smoltcp/contributors","subscribers_url":"https://api.github.com/repos/m-labs/smoltcp/subscribers","subscription_url":"https://api.github.com/repos/m-labs/smoltcp/subscription","commits_url":"https://api.github.com/repos/m-labs/smoltcp/commits{/sha}","git_commits_url":"https://api.github.com/repos/m-labs/smoltcp/git/commits{/sha}","comments_url":"https://api.github.com/repos/m-labs/smoltcp/comments{/number}","issue_comment_url":"https://api.github.com/repos/m-labs/smoltcp/issues/comments{/number}","contents_url":"https://api.github.com/repos/m-labs/smoltcp/contents/{+path}","compare_url":"https://api.github.com/repos/m-labs/smoltcp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m-labs/smoltcp/merges","archive_url":"https://api.github.com/repos/m-labs/smoltcp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m-labs/smoltcp/downloads","issues_url":"https://api.github.com/repos/m-labs/smoltcp/issues{/number}","pulls_url":"https://api.github.com/repos/m-labs/smoltcp/pulls{/number}","milestones_url":"https://api.github.com/repos/m-labs/smoltcp/milestones{/number}","notifications_url":"https://api.github.com/repos/m-labs/smoltcp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m-labs/smoltcp/labels{/name}","releases_url":"https://api.github.com/repos/m-labs/smoltcp/releases{/id}","deployments_url":"https://api.github.com/repos/m-labs/smoltcp/deployments","created_at":"2016-12-02T15:21:02Z","updated_at":"2018-02-02T00:47:29Z","pushed_at":"2018-02-05T14:52:36Z","git_url":"git://github.com/m-labs/smoltcp.git","ssh_url":"git@github.com:m-labs/smoltcp.git","clone_url":"https://github.com/m-labs/smoltcp.git","svn_url":"https://github.com/m-labs/smoltcp","homepage":null,"size":992,"stargazers_count":394,"watchers_count":394,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":33,"open_issues":36,"watchers":394,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/m-labs/smoltcp/pulls/141"},"html":{"href":"https://github.com/m-labs/smoltcp/pull/141"},"issue":{"href":"https://api.github.com/repos/m-labs/smoltcp/issues/141"},"comments":{"href":"https://api.github.com/repos/m-labs/smoltcp/issues/141/comments"},"review_comments":{"href":"https://api.github.com/repos/m-labs/smoltcp/pulls/141/comments"},"review_comment":{"href":"https://api.github.com/repos/m-labs/smoltcp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/m-labs/smoltcp/pulls/141/commits"},"statuses":{"href":"https://api.github.com/repos/m-labs/smoltcp/statuses/f2fc25d8a16a61fc62977e8c4e55aec644ddde66"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dlrobertson"}}