{"action":"closed","issue":{"url":"https://api.github.com/repos/handsontable/handsontable/issues/5069","repository_url":"https://api.github.com/repos/handsontable/handsontable","labels_url":"https://api.github.com/repos/handsontable/handsontable/issues/5069/labels{/name}","comments_url":"https://api.github.com/repos/handsontable/handsontable/issues/5069/comments","events_url":"https://api.github.com/repos/handsontable/handsontable/issues/5069/events","html_url":"https://github.com/handsontable/handsontable/issues/5069","id":318670563,"number":5069,"title":"default values in dataSchema break minSpareRows behavior","user":{"login":"mringler","id":9800945,"avatar_url":"https://avatars3.githubusercontent.com/u/9800945?v=4","gravatar_id":"","url":"https://api.github.com/users/mringler","html_url":"https://github.com/mringler","followers_url":"https://api.github.com/users/mringler/followers","following_url":"https://api.github.com/users/mringler/following{/other_user}","gists_url":"https://api.github.com/users/mringler/gists{/gist_id}","starred_url":"https://api.github.com/users/mringler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mringler/subscriptions","organizations_url":"https://api.github.com/users/mringler/orgs","repos_url":"https://api.github.com/users/mringler/repos","events_url":"https://api.github.com/users/mringler/events{/privacy}","received_events_url":"https://api.github.com/users/mringler/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-04-28T21:38:48Z","updated_at":"2018-04-30T06:46:35Z","closed_at":"2018-04-30T06:46:34Z","author_association":"NONE","body":"### Description\r\n<!--- Tell us what happens and what should happen -->\r\nWhen setting default values via the dataSchema property, those values are set in new rows, which is great. However, when using the minSpareRow options, those rows are not recognized as empty. \r\nThis leads to new rows being added after every single operation.\r\n\r\nTo check if a cell is empty should be evaluated against it's value in the schema, not just null.\r\n\r\nThis is probably the generalized case of #2409\r\n\r\n### Steps to reproduce\r\n<!--- Provide steps to reproduce this issue -->\r\n1. set a dataSchema with default values\r\n2. set minSpareRows > 1\r\n3. change any cell => new rows are added\r\n\r\n### Demo\r\n<!--- Provide a link to a live example on JSFiddle or Codepen or fill the following demo with your settings -->\r\nhttps://jsfiddle.net/yhy5cmzo/67/\r\n\r\n### Your environment\r\n* Handsontable version: 0.36.0\r\n* Browser Name and version: Chromium 64.0.3282.167 & Firefox 58.0.2\r\n* Operating System: Ubuntu 17.10 (64-bit)\r\n\r\n\r\n"}}
{"actor":{"display_login":"AMBudnik"}}