{"action":"created","issue":{"url":"https://api.github.com/repos/alefragnani/vscode-bookmarks/issues/124","repository_url":"https://api.github.com/repos/alefragnani/vscode-bookmarks","labels_url":"https://api.github.com/repos/alefragnani/vscode-bookmarks/issues/124/labels{/name}","comments_url":"https://api.github.com/repos/alefragnani/vscode-bookmarks/issues/124/comments","events_url":"https://api.github.com/repos/alefragnani/vscode-bookmarks/issues/124/events","html_url":"https://github.com/alefragnani/vscode-bookmarks/issues/124","id":341056302,"node_id":"MDU6SXNzdWUzNDEwNTYzMDI=","number":124,"title":"Thank you for new version! But the label UX is confusing.","user":{"login":"pakLebah","id":11470932,"node_id":"MDQ6VXNlcjExNDcwOTMy","avatar_url":"https://avatars1.githubusercontent.com/u/11470932?v=4","gravatar_id":"","url":"https://api.github.com/users/pakLebah","html_url":"https://github.com/pakLebah","followers_url":"https://api.github.com/users/pakLebah/followers","following_url":"https://api.github.com/users/pakLebah/following{/other_user}","gists_url":"https://api.github.com/users/pakLebah/gists{/gist_id}","starred_url":"https://api.github.com/users/pakLebah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pakLebah/subscriptions","organizations_url":"https://api.github.com/users/pakLebah/orgs","repos_url":"https://api.github.com/users/pakLebah/repos","events_url":"https://api.github.com/users/pakLebah/events{/privacy}","received_events_url":"https://api.github.com/users/pakLebah/received_events","type":"User","site_admin":false},"labels":[{"id":286641208,"node_id":"MDU6TGFiZWwyODY2NDEyMDg=","url":"https://api.github.com/repos/alefragnani/vscode-bookmarks/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-07-13T15:10:20Z","updated_at":"2018-08-01T02:30:26Z","closed_at":null,"author_association":"NONE","body":"Hi,\r\n\r\nI just fired-up my VS Code when I saw a notification of an extension update. It's Bookmarks! It's been a long waited update. Congratulations! 😊\r\n\r\nOverall, it's a great update. Love the new features. However, IMO, you need to fix the user experience of label feature. I'd say it's a bit confusing, to say the least. Why do I need to toggle a label? Label is not a state, it's an information. When I run the feature for the first time on a bookmark, the bookmark gone missing from the panel. So, I saw 3 bookmarks on the editor's gutter but only saw 2 bookmarks on the bookmarks panel. It's weird.\r\n\r\n![jepretan layar 2018-07-13 pada 21 58 09](https://user-images.githubusercontent.com/11470932/42698382-efc739f2-86e7-11e8-922f-b4e685e57e8d.png)\r\n\r\nAs far as I could understand, it seems that you provide 2 kind of bookmarks. Regular bookmark without label and labeled bookmark which each has its own toggle command, at least sometimes they act like that. What if I want to label an existing bookmark? Toggle it and toggle it again using `Toggle labeled` command. CMIIW.\r\n\r\nMy suggestion is to remove the `Toggle labeled` command altogether. Just use the familiar `Toggle` command. If we want to put a label into a bookmark, simply go to the Bookmark panel, double-click the bookmark we want to label, type the label, press Return, done. Or provide `Edit label` command through the panel submenu. If we want to remove label of a bookmark, simply edit it and enter empty string, or provide `Remove label` command through the panel submenu.\r\n\r\nI also think the pencil icon inside the label text is unnecessary. It takes valuable space in the panel. You could simply use different style to label text, such as brighter color or bolder font weight. The line and column info could also be simplified as `(line:col)` e.g. `(234:10)` instead of `(Ln 234, Col 10)`.\r\n\r\nWhat do you think? 😊 "},"comment":{"url":"https://api.github.com/repos/alefragnani/vscode-bookmarks/issues/comments/409428983","html_url":"https://github.com/alefragnani/vscode-bookmarks/issues/124#issuecomment-409428983","issue_url":"https://api.github.com/repos/alefragnani/vscode-bookmarks/issues/124","id":409428983,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTQyODk4Mw==","user":{"login":"alefragnani","id":3781424,"node_id":"MDQ6VXNlcjM3ODE0MjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3781424?v=4","gravatar_id":"","url":"https://api.github.com/users/alefragnani","html_url":"https://github.com/alefragnani","followers_url":"https://api.github.com/users/alefragnani/followers","following_url":"https://api.github.com/users/alefragnani/following{/other_user}","gists_url":"https://api.github.com/users/alefragnani/gists{/gist_id}","starred_url":"https://api.github.com/users/alefragnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alefragnani/subscriptions","organizations_url":"https://api.github.com/users/alefragnani/orgs","repos_url":"https://api.github.com/users/alefragnani/repos","events_url":"https://api.github.com/users/alefragnani/events{/privacy}","received_events_url":"https://api.github.com/users/alefragnani/received_events","type":"User","site_admin":false},"created_at":"2018-08-01T02:30:26Z","updated_at":"2018-08-01T02:30:26Z","author_association":"OWNER","body":"Hi @mbcrawfo ,\r\n\r\nThank you for your suggestion, but it wouldn't be possible to use the _bookmark line_ as default value, because the bookmark is based in _line number_ and not _its contents_. Do you remember when you delete/add lines, the bookmark _moves up/down_? 😃 \r\n\r\nAs I commented in #137, _\"I'm still not convinced about using a single command. For me, the labeled bookmark is a secondary option, so it should be an alternative command.\"_ \r\n\r\nSo for now, it remains as two different commands, unless some new idea or proposal appears.\r\n\r\nHope this helps"}}
{"actor":{"display_login":"alefragnani"}}