{"action":"created","comment":{"url":"https://api.github.com/repos/google/nxt-standalone/pulls/comments/184839041","pull_request_review_id":116120670,"id":184839041,"diff_hunk":"@@ -76,8 +76,8 @@ MTLIndexType MTLIndexFormat(nxt::IndexFormat format) {\n             const auto& module = ToBackend(builder->GetStageInfo(stage).module);\n \n             const auto& entryPoint = builder->GetStageInfo(stage).entryPoint;\n-            id<MTLFunction> function =\n-                module->GetFunction(entryPoint.c_str(), ToBackend(GetLayout())).function;\n+            ShaderModule::MetalFunctionData data = module->GetFunction(entryPoint.c_str(), ToBackend(GetLayout()));","path":"src/backend/metal/RenderPipelineMTL.mm","position":null,"original_position":6,"commit_id":"26c4fb2f361c68d97e51dd83a59a14d29ba8acf0","original_commit_id":"53ddc68349a58bd8992fe1f58ffc0ed4f33700d9","user":{"login":"Kangz","id":472810,"avatar_url":"https://avatars3.githubusercontent.com/u/472810?v=4","gravatar_id":"","url":"https://api.github.com/users/Kangz","html_url":"https://github.com/Kangz","followers_url":"https://api.github.com/users/Kangz/followers","following_url":"https://api.github.com/users/Kangz/following{/other_user}","gists_url":"https://api.github.com/users/Kangz/gists{/gist_id}","starred_url":"https://api.github.com/users/Kangz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kangz/subscriptions","organizations_url":"https://api.github.com/users/Kangz/orgs","repos_url":"https://api.github.com/users/Kangz/repos","events_url":"https://api.github.com/users/Kangz/events{/privacy}","received_events_url":"https://api.github.com/users/Kangz/received_events","type":"User","site_admin":false},"body":"You look like an expert to me :) Thanks for the explanation, I think it makes sense as much as ObjC refcounting can be.","created_at":"2018-04-28T04:05:25Z","updated_at":"2018-04-28T04:05:26Z","html_url":"https://github.com/google/nxt-standalone/pull/189#discussion_r184839041","pull_request_url":"https://api.github.com/repos/google/nxt-standalone/pulls/189","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/google/nxt-standalone/pulls/comments/184839041"},"html":{"href":"https://github.com/google/nxt-standalone/pull/189#discussion_r184839041"},"pull_request":{"href":"https://api.github.com/repos/google/nxt-standalone/pulls/189"}},"in_reply_to_id":184728462},"pull_request":{"url":"https://api.github.com/repos/google/nxt-standalone/pulls/189","id":184438304,"html_url":"https://github.com/google/nxt-standalone/pull/189","diff_url":"https://github.com/google/nxt-standalone/pull/189.diff","patch_url":"https://github.com/google/nxt-standalone/pull/189.patch","issue_url":"https://api.github.com/repos/google/nxt-standalone/issues/189","number":189,"state":"open","locked":false,"title":"Fix a memory leak in metal ShaderModule.","user":{"login":"SenorBlanco","id":3986954,"avatar_url":"https://avatars3.githubusercontent.com/u/3986954?v=4","gravatar_id":"","url":"https://api.github.com/users/SenorBlanco","html_url":"https://github.com/SenorBlanco","followers_url":"https://api.github.com/users/SenorBlanco/followers","following_url":"https://api.github.com/users/SenorBlanco/following{/other_user}","gists_url":"https://api.github.com/users/SenorBlanco/gists{/gist_id}","starred_url":"https://api.github.com/users/SenorBlanco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SenorBlanco/subscriptions","organizations_url":"https://api.github.com/users/SenorBlanco/orgs","repos_url":"https://api.github.com/users/SenorBlanco/repos","events_url":"https://api.github.com/users/SenorBlanco/events{/privacy}","received_events_url":"https://api.github.com/users/SenorBlanco/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-26T19:18:12Z","updated_at":"2018-04-28T04:05:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61af37caf8667e315b0d3e5f27421ea1cba88af5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/nxt-standalone/pulls/189/commits","review_comments_url":"https://api.github.com/repos/google/nxt-standalone/pulls/189/comments","review_comment_url":"https://api.github.com/repos/google/nxt-standalone/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/nxt-standalone/issues/189/comments","statuses_url":"https://api.github.com/repos/google/nxt-standalone/statuses/26c4fb2f361c68d97e51dd83a59a14d29ba8acf0","head":{"label":"SenorBlanco:fix-metal-function-leak","ref":"fix-metal-function-leak","sha":"26c4fb2f361c68d97e51dd83a59a14d29ba8acf0","user":{"login":"SenorBlanco","id":3986954,"avatar_url":"https://avatars3.githubusercontent.com/u/3986954?v=4","gravatar_id":"","url":"https://api.github.com/users/SenorBlanco","html_url":"https://github.com/SenorBlanco","followers_url":"https://api.github.com/users/SenorBlanco/followers","following_url":"https://api.github.com/users/SenorBlanco/following{/other_user}","gists_url":"https://api.github.com/users/SenorBlanco/gists{/gist_id}","starred_url":"https://api.github.com/users/SenorBlanco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SenorBlanco/subscriptions","organizations_url":"https://api.github.com/users/SenorBlanco/orgs","repos_url":"https://api.github.com/users/SenorBlanco/repos","events_url":"https://api.github.com/users/SenorBlanco/events{/privacy}","received_events_url":"https://api.github.com/users/SenorBlanco/received_events","type":"User","site_admin":false},"repo":{"id":127958094,"name":"nxt-standalone","full_name":"SenorBlanco/nxt-standalone","owner":{"login":"SenorBlanco","id":3986954,"avatar_url":"https://avatars3.githubusercontent.com/u/3986954?v=4","gravatar_id":"","url":"https://api.github.com/users/SenorBlanco","html_url":"https://github.com/SenorBlanco","followers_url":"https://api.github.com/users/SenorBlanco/followers","following_url":"https://api.github.com/users/SenorBlanco/following{/other_user}","gists_url":"https://api.github.com/users/SenorBlanco/gists{/gist_id}","starred_url":"https://api.github.com/users/SenorBlanco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SenorBlanco/subscriptions","organizations_url":"https://api.github.com/users/SenorBlanco/orgs","repos_url":"https://api.github.com/users/SenorBlanco/repos","events_url":"https://api.github.com/users/SenorBlanco/events{/privacy}","received_events_url":"https://api.github.com/users/SenorBlanco/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SenorBlanco/nxt-standalone","description":"ANGLE-like library for Chromium's next-generation Web graphics API prototype.","fork":true,"url":"https://api.github.com/repos/SenorBlanco/nxt-standalone","forks_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/forks","keys_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/teams","hooks_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/hooks","issue_events_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/issues/events{/number}","events_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/events","assignees_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/assignees{/user}","branches_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/branches{/branch}","tags_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/tags","blobs_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/git/refs{/sha}","trees_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/statuses/{sha}","languages_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/languages","stargazers_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/stargazers","contributors_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/contributors","subscribers_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/subscribers","subscription_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/subscription","commits_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/commits{/sha}","git_commits_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/git/commits{/sha}","comments_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/comments{/number}","issue_comment_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/issues/comments{/number}","contents_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/contents/{+path}","compare_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/merges","archive_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/downloads","issues_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/issues{/number}","pulls_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/pulls{/number}","milestones_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/milestones{/number}","notifications_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/labels{/name}","releases_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/releases{/id}","deployments_url":"https://api.github.com/repos/SenorBlanco/nxt-standalone/deployments","created_at":"2018-04-03T19:25:25Z","updated_at":"2018-04-27T17:11:58Z","pushed_at":"2018-04-28T01:57:36Z","git_url":"git://github.com/SenorBlanco/nxt-standalone.git","ssh_url":"git@github.com:SenorBlanco/nxt-standalone.git","clone_url":"https://github.com/SenorBlanco/nxt-standalone.git","svn_url":"https://github.com/SenorBlanco/nxt-standalone","homepage":"","size":1735,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"cce393e0d48de48c5ac4bba559a6151ad38725ad","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":88893060,"name":"nxt-standalone","full_name":"google/nxt-standalone","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/nxt-standalone","description":"ANGLE-like library for Chromium's next-generation Web graphics API prototype.","fork":false,"url":"https://api.github.com/repos/google/nxt-standalone","forks_url":"https://api.github.com/repos/google/nxt-standalone/forks","keys_url":"https://api.github.com/repos/google/nxt-standalone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/nxt-standalone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/nxt-standalone/teams","hooks_url":"https://api.github.com/repos/google/nxt-standalone/hooks","issue_events_url":"https://api.github.com/repos/google/nxt-standalone/issues/events{/number}","events_url":"https://api.github.com/repos/google/nxt-standalone/events","assignees_url":"https://api.github.com/repos/google/nxt-standalone/assignees{/user}","branches_url":"https://api.github.com/repos/google/nxt-standalone/branches{/branch}","tags_url":"https://api.github.com/repos/google/nxt-standalone/tags","blobs_url":"https://api.github.com/repos/google/nxt-standalone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/nxt-standalone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/nxt-standalone/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/nxt-standalone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/nxt-standalone/statuses/{sha}","languages_url":"https://api.github.com/repos/google/nxt-standalone/languages","stargazers_url":"https://api.github.com/repos/google/nxt-standalone/stargazers","contributors_url":"https://api.github.com/repos/google/nxt-standalone/contributors","subscribers_url":"https://api.github.com/repos/google/nxt-standalone/subscribers","subscription_url":"https://api.github.com/repos/google/nxt-standalone/subscription","commits_url":"https://api.github.com/repos/google/nxt-standalone/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/nxt-standalone/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/nxt-standalone/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/nxt-standalone/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/nxt-standalone/contents/{+path}","compare_url":"https://api.github.com/repos/google/nxt-standalone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/nxt-standalone/merges","archive_url":"https://api.github.com/repos/google/nxt-standalone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/nxt-standalone/downloads","issues_url":"https://api.github.com/repos/google/nxt-standalone/issues{/number}","pulls_url":"https://api.github.com/repos/google/nxt-standalone/pulls{/number}","milestones_url":"https://api.github.com/repos/google/nxt-standalone/milestones{/number}","notifications_url":"https://api.github.com/repos/google/nxt-standalone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/nxt-standalone/labels{/name}","releases_url":"https://api.github.com/repos/google/nxt-standalone/releases{/id}","deployments_url":"https://api.github.com/repos/google/nxt-standalone/deployments","created_at":"2017-04-20T17:33:32Z","updated_at":"2018-04-28T04:03:56Z","pushed_at":"2018-04-28T04:03:55Z","git_url":"git://github.com/google/nxt-standalone.git","ssh_url":"git@github.com:google/nxt-standalone.git","clone_url":"https://github.com/google/nxt-standalone.git","svn_url":"https://github.com/google/nxt-standalone","homepage":"","size":1723,"stargazers_count":81,"watchers_count":81,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":22,"open_issues":18,"watchers":81,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/nxt-standalone/pulls/189"},"html":{"href":"https://github.com/google/nxt-standalone/pull/189"},"issue":{"href":"https://api.github.com/repos/google/nxt-standalone/issues/189"},"comments":{"href":"https://api.github.com/repos/google/nxt-standalone/issues/189/comments"},"review_comments":{"href":"https://api.github.com/repos/google/nxt-standalone/pulls/189/comments"},"review_comment":{"href":"https://api.github.com/repos/google/nxt-standalone/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/nxt-standalone/pulls/189/commits"},"statuses":{"href":"https://api.github.com/repos/google/nxt-standalone/statuses/26c4fb2f361c68d97e51dd83a59a14d29ba8acf0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Kangz"}}