{"action":"created","issue":{"url":"https://api.github.com/repos/erlang/otp/issues/1932","repository_url":"https://api.github.com/repos/erlang/otp","labels_url":"https://api.github.com/repos/erlang/otp/issues/1932/labels{/name}","comments_url":"https://api.github.com/repos/erlang/otp/issues/1932/comments","events_url":"https://api.github.com/repos/erlang/otp/issues/1932/events","html_url":"https://github.com/erlang/otp/pull/1932","id":351316227,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4OTQzODc5","number":1932,"title":"Do not allocate good and bad shifts for single byte lookups","user":{"login":"josevalim","id":9582,"node_id":"MDQ6VXNlcjk1ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/9582?v=4","gravatar_id":"","url":"https://api.github.com/users/josevalim","html_url":"https://github.com/josevalim","followers_url":"https://api.github.com/users/josevalim/followers","following_url":"https://api.github.com/users/josevalim/following{/other_user}","gists_url":"https://api.github.com/users/josevalim/gists{/gist_id}","starred_url":"https://api.github.com/users/josevalim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josevalim/subscriptions","organizations_url":"https://api.github.com/users/josevalim/orgs","repos_url":"https://api.github.com/users/josevalim/repos","events_url":"https://api.github.com/users/josevalim/events{/privacy}","received_events_url":"https://api.github.com/users/josevalim/received_events","type":"User","site_admin":false},"labels":[{"id":356267348,"node_id":"MDU6TGFiZWwzNTYyNjczNDg=","url":"https://api.github.com/repos/erlang/otp/labels/feature","name":"feature","color":"7159f7","default":false},{"id":356263938,"node_id":"MDU6TGFiZWwzNTYyNjM5Mzg=","url":"https://api.github.com/repos/erlang/otp/labels/team:VM","name":"team:VM","color":"006b75","default":false},{"id":386423799,"node_id":"MDU6TGFiZWwzODY0MjM3OTk=","url":"https://api.github.com/repos/erlang/otp/labels/testing","name":"testing","color":"e99695","default":false}],"state":"closed","locked":false,"assignee":{"login":"garazdawi","id":111762,"node_id":"MDQ6VXNlcjExMTc2Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/111762?v=4","gravatar_id":"","url":"https://api.github.com/users/garazdawi","html_url":"https://github.com/garazdawi","followers_url":"https://api.github.com/users/garazdawi/followers","following_url":"https://api.github.com/users/garazdawi/following{/other_user}","gists_url":"https://api.github.com/users/garazdawi/gists{/gist_id}","starred_url":"https://api.github.com/users/garazdawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garazdawi/subscriptions","organizations_url":"https://api.github.com/users/garazdawi/orgs","repos_url":"https://api.github.com/users/garazdawi/repos","events_url":"https://api.github.com/users/garazdawi/events{/privacy}","received_events_url":"https://api.github.com/users/garazdawi/received_events","type":"User","site_admin":false},"assignees":[{"login":"garazdawi","id":111762,"node_id":"MDQ6VXNlcjExMTc2Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/111762?v=4","gravatar_id":"","url":"https://api.github.com/users/garazdawi","html_url":"https://github.com/garazdawi","followers_url":"https://api.github.com/users/garazdawi/followers","following_url":"https://api.github.com/users/garazdawi/following{/other_user}","gists_url":"https://api.github.com/users/garazdawi/gists{/gist_id}","starred_url":"https://api.github.com/users/garazdawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garazdawi/subscriptions","organizations_url":"https://api.github.com/users/garazdawi/orgs","repos_url":"https://api.github.com/users/garazdawi/repos","events_url":"https://api.github.com/users/garazdawi/events{/privacy}","received_events_url":"https://api.github.com/users/garazdawi/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-08-16T18:22:23Z","updated_at":"2018-08-23T12:31:19Z","closed_at":"2018-08-23T12:28:39Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/erlang/otp/pulls/1932","html_url":"https://github.com/erlang/otp/pull/1932","diff_url":"https://github.com/erlang/otp/pull/1932.diff","patch_url":"https://github.com/erlang/otp/pull/1932.patch"},"body":"The single byte lookups always rely on `memchr` and\r\nnever really use the good and bad shifts arrays.\r\n\r\nMy benchmarks show this makes compile_pattern roughly twice\r\nfaster for single bytes. It also uses 256 bytes less memory.\r\n\r\nAnother alternative approach would be to introduce a complete separate\r\nstructure that does the single byte implementation but I personally find the\r\ncurrent approach simpler.\r\n\r\nFollow up to #1803, fully closes https://bugs.erlang.org/browse/ERL-374."},"comment":{"url":"https://api.github.com/repos/erlang/otp/issues/comments/415397510","html_url":"https://github.com/erlang/otp/pull/1932#issuecomment-415397510","issue_url":"https://api.github.com/repos/erlang/otp/issues/1932","id":415397510,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTM5NzUxMA==","user":{"login":"josevalim","id":9582,"node_id":"MDQ6VXNlcjk1ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/9582?v=4","gravatar_id":"","url":"https://api.github.com/users/josevalim","html_url":"https://github.com/josevalim","followers_url":"https://api.github.com/users/josevalim/followers","following_url":"https://api.github.com/users/josevalim/following{/other_user}","gists_url":"https://api.github.com/users/josevalim/gists{/gist_id}","starred_url":"https://api.github.com/users/josevalim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josevalim/subscriptions","organizations_url":"https://api.github.com/users/josevalim/orgs","repos_url":"https://api.github.com/users/josevalim/repos","events_url":"https://api.github.com/users/josevalim/events{/privacy}","received_events_url":"https://api.github.com/users/josevalim/received_events","type":"User","site_admin":false},"created_at":"2018-08-23T12:31:19Z","updated_at":"2018-08-23T12:31:19Z","author_association":"CONTRIBUTOR","body":"Thanks @garazdawi, I believe https://bugs.erlang.org/browse/ERL-374 can be closed too."}}
{"actor":{"display_login":"josevalim"}}