{"action":"created","issue":{"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/2399","repository_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api","labels_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/2399/labels{/name}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/2399/comments","events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/2399/events","html_url":"https://github.com/department-of-veterans-affairs/vets-api/pull/2399","id":374521202,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MjA0OTkx","number":2399,"title":"14575 update search endpoint for pagination","user":{"login":"hpjaj","id":7482329,"node_id":"MDQ6VXNlcjc0ODIzMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/7482329?v=4","gravatar_id":"","url":"https://api.github.com/users/hpjaj","html_url":"https://github.com/hpjaj","followers_url":"https://api.github.com/users/hpjaj/followers","following_url":"https://api.github.com/users/hpjaj/following{/other_user}","gists_url":"https://api.github.com/users/hpjaj/gists{/gist_id}","starred_url":"https://api.github.com/users/hpjaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpjaj/subscriptions","organizations_url":"https://api.github.com/users/hpjaj/orgs","repos_url":"https://api.github.com/users/hpjaj/repos","events_url":"https://api.github.com/users/hpjaj/events{/privacy}","received_events_url":"https://api.github.com/users/hpjaj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-26T19:39:21Z","updated_at":"2018-10-26T19:51:49Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/2399","html_url":"https://github.com/department-of-veterans-affairs/vets-api/pull/2399","diff_url":"https://github.com/department-of-veterans-affairs/vets-api/pull/2399.diff","patch_url":"https://github.com/department-of-veterans-affairs/vets-api/pull/2399.patch"},"body":"## Description of change\r\nStemming from [this conversation](https://github.com/department-of-veterans-affairs/vets.gov-team/issues/13440#issuecomment-432793942), for the second iteration of the search pagination, we will implement a Google-like UI for the pagination end user experience.\r\n\r\n\r\n## Testing done\r\n<!-- Please describe testing done to verify the changes. -->\r\n\r\nAutomated specs \r\n## Acceptance Criteria (Definition of Done)\r\n\r\n#### Unique to this PR\r\n- [x] Remove any `offset` logic (and specs)\r\n- [x] Update the response to include a new `pagination` object nested in a `meta` key\r\n- [x] Add a `page` param for the FE to request a specific page\r\n- [x] Update swagger docs\r\n- [x] Specs\r\n- [ ] Collaborate with FE before merging\r\n\r\n#### Applies to all PRs\r\n\r\n- [x] Appropriate logging\r\n- [x] Swagger docs have been updated, if applicable\r\n- [x] Provide link to originating GitHub issue, or connected to it via ZenHub\r\n- [x] Does not contain any sensitive information (i.e. PII/credentials/internal URLs/etc., in logging, hardcoded, or in specs)\r\n- [x] Provide which alerts would indicate a problem with this functionality (if applicable)\r\n\r\n## Screenshots\r\n\r\n#### New Meta key with Pagination object\r\n\r\n![image](https://user-images.githubusercontent.com/7482329/47588987-22765d80-d925-11e8-928c-fe1090550e8f.png)\r\n\r\n\r\n<hr/> \r\n\r\n![image](https://user-images.githubusercontent.com/7482329/47588966-0e326080-d925-11e8-9177-06c4b5e816fb.png)\r\n"},"comment":{"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/comments/433524242","html_url":"https://github.com/department-of-veterans-affairs/vets-api/pull/2399#issuecomment-433524242","issue_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/2399","id":433524242,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzUyNDI0Mg==","user":{"login":"saneshark","id":591737,"node_id":"MDQ6VXNlcjU5MTczNw==","avatar_url":"https://avatars2.githubusercontent.com/u/591737?v=4","gravatar_id":"","url":"https://api.github.com/users/saneshark","html_url":"https://github.com/saneshark","followers_url":"https://api.github.com/users/saneshark/followers","following_url":"https://api.github.com/users/saneshark/following{/other_user}","gists_url":"https://api.github.com/users/saneshark/gists{/gist_id}","starred_url":"https://api.github.com/users/saneshark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saneshark/subscriptions","organizations_url":"https://api.github.com/users/saneshark/orgs","repos_url":"https://api.github.com/users/saneshark/repos","events_url":"https://api.github.com/users/saneshark/events{/privacy}","received_events_url":"https://api.github.com/users/saneshark/received_events","type":"User","site_admin":false},"created_at":"2018-10-26T19:51:49Z","updated_at":"2018-10-26T19:51:49Z","author_association":"CONTRIBUTOR","body":"Thanks! looks like it matches pagination schema we have elsewhere in the JSON responses. If in the future you find yourself needing sorting and searching / filtering capabilities, you do get a lot of really nice features out of the box with Common::Collection though. ;)"}}
{"actor":{"display_login":"saneshark"}}