{"action":"created","issue":{"url":"https://api.github.com/repos/hasktorch/hasktorch/issues/120","repository_url":"https://api.github.com/repos/hasktorch/hasktorch","labels_url":"https://api.github.com/repos/hasktorch/hasktorch/issues/120/labels{/name}","comments_url":"https://api.github.com/repos/hasktorch/hasktorch/issues/120/comments","events_url":"https://api.github.com/repos/hasktorch/hasktorch/issues/120/events","html_url":"https://github.com/hasktorch/hasktorch/pull/120","id":384005390,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMzI5NzQz","number":120,"title":"dimension-safe `diag`, simple autoencoder example, fix overwriting values sampler bug","user":{"login":"austinvhuang","id":20875313,"node_id":"MDQ6VXNlcjIwODc1MzEz","avatar_url":"https://avatars2.githubusercontent.com/u/20875313?v=4","gravatar_id":"","url":"https://api.github.com/users/austinvhuang","html_url":"https://github.com/austinvhuang","followers_url":"https://api.github.com/users/austinvhuang/followers","following_url":"https://api.github.com/users/austinvhuang/following{/other_user}","gists_url":"https://api.github.com/users/austinvhuang/gists{/gist_id}","starred_url":"https://api.github.com/users/austinvhuang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austinvhuang/subscriptions","organizations_url":"https://api.github.com/users/austinvhuang/orgs","repos_url":"https://api.github.com/users/austinvhuang/repos","events_url":"https://api.github.com/users/austinvhuang/events{/privacy}","received_events_url":"https://api.github.com/users/austinvhuang/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-24T17:07:18Z","updated_at":"2018-11-25T17:36:32Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/hasktorch/hasktorch/pulls/120","html_url":"https://github.com/hasktorch/hasktorch/pull/120","diff_url":"https://github.com/hasktorch/hasktorch/pull/120.diff","patch_url":"https://github.com/hasktorch/hasktorch/pull/120.patch"},"body":"- Dimension-safe `diag` - previously it was possible to pass value-level `k` parameters that would lead to underlying tensor dimensions that were different from the advertised type. Replaced default `diag` with a dimension-safe version. Kept the older version as well as `diagUnsafe` as well as the `diag1d` special case.\r\n\r\n- Simple autoencoder - linear/relu layers with a bottleneck. Tested on a high-dimensional gaussian mixture (for now, will replace with something more interesting like mnist once the data loaders are ready).\r\n\r\n- Started defining a data representation for Relu activations (analogous to the Linear data representation), with the idea of a more automated declarative API that automatically defines forward/backward prop without the current verbosity/redundancy. This isn't used yet though and the design could change down the line.\r\n\r\n- Add `NOINLINE` to `withInplace`, resolves bug where values produced by samplers like `normal` were getting overwritten by subsequent calls to `normal`."},"comment":{"url":"https://api.github.com/repos/hasktorch/hasktorch/issues/comments/441457701","html_url":"https://github.com/hasktorch/hasktorch/pull/120#issuecomment-441457701","issue_url":"https://api.github.com/repos/hasktorch/hasktorch/issues/120","id":441457701,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTQ1NzcwMQ==","user":{"login":"stites","id":1694705,"node_id":"MDQ6VXNlcjE2OTQ3MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/1694705?v=4","gravatar_id":"","url":"https://api.github.com/users/stites","html_url":"https://github.com/stites","followers_url":"https://api.github.com/users/stites/followers","following_url":"https://api.github.com/users/stites/following{/other_user}","gists_url":"https://api.github.com/users/stites/gists{/gist_id}","starred_url":"https://api.github.com/users/stites/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stites/subscriptions","organizations_url":"https://api.github.com/users/stites/orgs","repos_url":"https://api.github.com/users/stites/repos","events_url":"https://api.github.com/users/stites/events{/privacy}","received_events_url":"https://api.github.com/users/stites/received_events","type":"User","site_admin":false},"created_at":"2018-11-25T17:36:32Z","updated_at":"2018-11-25T17:36:32Z","author_association":"COLLABORATOR","body":":tada: :boom: :tada:\r\nLGTM! I like the quick simple example and I apologize for not catching the O0 v. O1 bug sooner.\r\n\r\nIf you could migrate `rng-bug/RNGMinimal.hs` to `hasktorch/tests/Torch/Core/RandomSpec.hs` that would be excellent! \r\n\r\nNotes which are optional at this stage:\r\n- Style-wise, I think we should start using the brittany formatter but there's no need to do that just yet (it's the default haskell-ide-engine and a personal preference).\r\n- DRY-related things (for future reference) we should probably start pulling some of the common functions into `hasktorch-zoo`"}}
{"actor":{"display_login":"stites"}}