{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/jetty.project/pulls/comments/211721652","pull_request_review_id":148203152,"id":211721652,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTcyMTY1Mg==","diff_hunk":"@@ -492,6 +477,16 @@ protected void fileRemoved(String filename) throws Exception\n         //is the file that was removed an .xml file?\n         if (lowname.endsWith(\".xml\"))\n             super.fileRemoved(filename);\n+\n+        //is there a .xml file of the same name?\n+        if (exists(file.getName()+\".xml\")||exists(file.getName()+\".XML\"))","path":"jetty-deploy/src/main/java/org/eclipse/jetty/deploy/providers/WebAppProvider.java","position":28,"original_position":28,"commit_id":"0509dfccea02a270d2b5e63dc90fb3fb6fc786a0","original_commit_id":"0509dfccea02a270d2b5e63dc90fb3fb6fc786a0","user":{"login":"joakime","id":191721,"node_id":"MDQ6VXNlcjE5MTcyMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/191721?v=4","gravatar_id":"","url":"https://api.github.com/users/joakime","html_url":"https://github.com/joakime","followers_url":"https://api.github.com/users/joakime/followers","following_url":"https://api.github.com/users/joakime/following{/other_user}","gists_url":"https://api.github.com/users/joakime/gists{/gist_id}","starred_url":"https://api.github.com/users/joakime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joakime/subscriptions","organizations_url":"https://api.github.com/users/joakime/orgs","repos_url":"https://api.github.com/users/joakime/repos","events_url":"https://api.github.com/users/joakime/events{/privacy}","received_events_url":"https://api.github.com/users/joakime/received_events","type":"User","site_admin":false},"body":"You could use the test from line 478 here, no?","created_at":"2018-08-21T18:59:02Z","updated_at":"2018-08-21T18:59:32Z","html_url":"https://github.com/eclipse/jetty.project/pull/2839#discussion_r211721652","pull_request_url":"https://api.github.com/repos/eclipse/jetty.project/pulls/2839","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/eclipse/jetty.project/pulls/comments/211721652"},"html":{"href":"https://github.com/eclipse/jetty.project/pull/2839#discussion_r211721652"},"pull_request":{"href":"https://api.github.com/repos/eclipse/jetty.project/pulls/2839"}},"in_reply_to_id":211721343},"pull_request":{"url":"https://api.github.com/repos/eclipse/jetty.project/pulls/2839","id":209729246,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NzI5MjQ2","html_url":"https://github.com/eclipse/jetty.project/pull/2839","diff_url":"https://github.com/eclipse/jetty.project/pull/2839.diff","patch_url":"https://github.com/eclipse/jetty.project/pull/2839.patch","issue_url":"https://api.github.com/repos/eclipse/jetty.project/issues/2839","number":2839,"state":"open","locked":false,"title":"Issue #2681 Hot undeploy dir deployments.","user":{"login":"janbartel","id":342406,"node_id":"MDQ6VXNlcjM0MjQwNg==","avatar_url":"https://avatars2.githubusercontent.com/u/342406?v=4","gravatar_id":"","url":"https://api.github.com/users/janbartel","html_url":"https://github.com/janbartel","followers_url":"https://api.github.com/users/janbartel/followers","following_url":"https://api.github.com/users/janbartel/following{/other_user}","gists_url":"https://api.github.com/users/janbartel/gists{/gist_id}","starred_url":"https://api.github.com/users/janbartel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janbartel/subscriptions","organizations_url":"https://api.github.com/users/janbartel/orgs","repos_url":"https://api.github.com/users/janbartel/repos","events_url":"https://api.github.com/users/janbartel/events{/privacy}","received_events_url":"https://api.github.com/users/janbartel/received_events","type":"User","site_admin":false},"body":"WebAppProvider tries to use a File object constructed just from the name of a file that has been deleted: as the file is deleted, File.isDirectory() check cannot succeed. ","created_at":"2018-08-21T07:15:19Z","updated_at":"2018-08-21T18:59:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b622c02c17894d72871331f8dfabd4816666d56","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/jetty.project/pulls/2839/commits","review_comments_url":"https://api.github.com/repos/eclipse/jetty.project/pulls/2839/comments","review_comment_url":"https://api.github.com/repos/eclipse/jetty.project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/jetty.project/issues/2839/comments","statuses_url":"https://api.github.com/repos/eclipse/jetty.project/statuses/0509dfccea02a270d2b5e63dc90fb3fb6fc786a0","head":{"label":"eclipse:jetty-9.4.x-2681-hot-undeploy-dir","ref":"jetty-9.4.x-2681-hot-undeploy-dir","sha":"0509dfccea02a270d2b5e63dc90fb3fb6fc786a0","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":2045207,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQ1MjA3","name":"jetty.project","full_name":"eclipse/jetty.project","owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/jetty.project","description":"Eclipse Jetty® - Web Container & Clients - supports HTTP/2, HTTP/1.1, HTTP/1.0, websocket, servlets, and more","fork":false,"url":"https://api.github.com/repos/eclipse/jetty.project","forks_url":"https://api.github.com/repos/eclipse/jetty.project/forks","keys_url":"https://api.github.com/repos/eclipse/jetty.project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/jetty.project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/jetty.project/teams","hooks_url":"https://api.github.com/repos/eclipse/jetty.project/hooks","issue_events_url":"https://api.github.com/repos/eclipse/jetty.project/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/jetty.project/events","assignees_url":"https://api.github.com/repos/eclipse/jetty.project/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/jetty.project/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/jetty.project/tags","blobs_url":"https://api.github.com/repos/eclipse/jetty.project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/jetty.project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/jetty.project/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/jetty.project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/jetty.project/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/jetty.project/languages","stargazers_url":"https://api.github.com/repos/eclipse/jetty.project/stargazers","contributors_url":"https://api.github.com/repos/eclipse/jetty.project/contributors","subscribers_url":"https://api.github.com/repos/eclipse/jetty.project/subscribers","subscription_url":"https://api.github.com/repos/eclipse/jetty.project/subscription","commits_url":"https://api.github.com/repos/eclipse/jetty.project/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/jetty.project/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/jetty.project/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/jetty.project/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/jetty.project/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/jetty.project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/jetty.project/merges","archive_url":"https://api.github.com/repos/eclipse/jetty.project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/jetty.project/downloads","issues_url":"https://api.github.com/repos/eclipse/jetty.project/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/jetty.project/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/jetty.project/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/jetty.project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/jetty.project/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/jetty.project/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/jetty.project/deployments","created_at":"2011-07-14T01:11:57Z","updated_at":"2018-08-21T16:10:08Z","pushed_at":"2018-08-21T16:12:25Z","git_url":"git://github.com/eclipse/jetty.project.git","ssh_url":"git@github.com:eclipse/jetty.project.git","clone_url":"https://github.com/eclipse/jetty.project.git","svn_url":"https://github.com/eclipse/jetty.project","homepage":"https://www.eclipse.org/jetty","size":117792,"stargazers_count":2139,"watchers_count":2139,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1223,"mirror_url":null,"archived":false,"open_issues_count":391,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1223,"open_issues":391,"watchers":2139,"default_branch":"jetty-9.4.x"}},"base":{"label":"eclipse:jetty-9.4.x","ref":"jetty-9.4.x","sha":"45d5bd2cae448d83cd174f6002095548675cd108","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":2045207,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQ1MjA3","name":"jetty.project","full_name":"eclipse/jetty.project","owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/jetty.project","description":"Eclipse Jetty® - Web Container & Clients - supports HTTP/2, HTTP/1.1, HTTP/1.0, websocket, servlets, and more","fork":false,"url":"https://api.github.com/repos/eclipse/jetty.project","forks_url":"https://api.github.com/repos/eclipse/jetty.project/forks","keys_url":"https://api.github.com/repos/eclipse/jetty.project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/jetty.project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/jetty.project/teams","hooks_url":"https://api.github.com/repos/eclipse/jetty.project/hooks","issue_events_url":"https://api.github.com/repos/eclipse/jetty.project/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/jetty.project/events","assignees_url":"https://api.github.com/repos/eclipse/jetty.project/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/jetty.project/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/jetty.project/tags","blobs_url":"https://api.github.com/repos/eclipse/jetty.project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/jetty.project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/jetty.project/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/jetty.project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/jetty.project/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/jetty.project/languages","stargazers_url":"https://api.github.com/repos/eclipse/jetty.project/stargazers","contributors_url":"https://api.github.com/repos/eclipse/jetty.project/contributors","subscribers_url":"https://api.github.com/repos/eclipse/jetty.project/subscribers","subscription_url":"https://api.github.com/repos/eclipse/jetty.project/subscription","commits_url":"https://api.github.com/repos/eclipse/jetty.project/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/jetty.project/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/jetty.project/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/jetty.project/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/jetty.project/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/jetty.project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/jetty.project/merges","archive_url":"https://api.github.com/repos/eclipse/jetty.project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/jetty.project/downloads","issues_url":"https://api.github.com/repos/eclipse/jetty.project/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/jetty.project/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/jetty.project/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/jetty.project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/jetty.project/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/jetty.project/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/jetty.project/deployments","created_at":"2011-07-14T01:11:57Z","updated_at":"2018-08-21T16:10:08Z","pushed_at":"2018-08-21T16:12:25Z","git_url":"git://github.com/eclipse/jetty.project.git","ssh_url":"git@github.com:eclipse/jetty.project.git","clone_url":"https://github.com/eclipse/jetty.project.git","svn_url":"https://github.com/eclipse/jetty.project","homepage":"https://www.eclipse.org/jetty","size":117792,"stargazers_count":2139,"watchers_count":2139,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1223,"mirror_url":null,"archived":false,"open_issues_count":391,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1223,"open_issues":391,"watchers":2139,"default_branch":"jetty-9.4.x"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/jetty.project/pulls/2839"},"html":{"href":"https://github.com/eclipse/jetty.project/pull/2839"},"issue":{"href":"https://api.github.com/repos/eclipse/jetty.project/issues/2839"},"comments":{"href":"https://api.github.com/repos/eclipse/jetty.project/issues/2839/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/jetty.project/pulls/2839/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/jetty.project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/jetty.project/pulls/2839/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/jetty.project/statuses/0509dfccea02a270d2b5e63dc90fb3fb6fc786a0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"joakime"}}