{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-image/scikit-image/pulls/comments/217913060","pull_request_review_id":155743643,"id":217913060,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzkxMzA2MA==","diff_hunk":"@@ -132,6 +159,9 @@ def register_translation(src_image, target_image, upsample_factor=1,\n         Defines how the algorithm interprets input data.  \"real\" means data\n         will be FFT'd to compute the correlation, while \"fourier\" data will\n         bypass FFT of input data.  Case insensitive.\n+    return_error : bool, optional","path":"skimage/feature/register_translation.py","position":92,"original_position":92,"commit_id":"85666392a0557e0b6f02f82c6c762676c4313b53","original_commit_id":"85666392a0557e0b6f02f82c6c762676c4313b53","user":{"login":"emmanuelle","id":263366,"node_id":"MDQ6VXNlcjI2MzM2Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/263366?v=4","gravatar_id":"","url":"https://api.github.com/users/emmanuelle","html_url":"https://github.com/emmanuelle","followers_url":"https://api.github.com/users/emmanuelle/followers","following_url":"https://api.github.com/users/emmanuelle/following{/other_user}","gists_url":"https://api.github.com/users/emmanuelle/gists{/gist_id}","starred_url":"https://api.github.com/users/emmanuelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmanuelle/subscriptions","organizations_url":"https://api.github.com/users/emmanuelle/orgs","repos_url":"https://api.github.com/users/emmanuelle/repos","events_url":"https://api.github.com/users/emmanuelle/events{/privacy}","received_events_url":"https://api.github.com/users/emmanuelle/received_events","type":"User","site_admin":false},"body":"I'm not sure whether we have other functions returning residual errors, if yes we should be consistent with names.","created_at":"2018-09-16T12:43:36Z","updated_at":"2018-09-16T12:43:36Z","html_url":"https://github.com/scikit-image/scikit-image/pull/2880#discussion_r217913060","pull_request_url":"https://api.github.com/repos/scikit-image/scikit-image/pulls/2880","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/scikit-image/scikit-image/pulls/comments/217913060"},"html":{"href":"https://github.com/scikit-image/scikit-image/pull/2880#discussion_r217913060"},"pull_request":{"href":"https://api.github.com/repos/scikit-image/scikit-image/pulls/2880"}},"in_reply_to_id":217912011},"pull_request":{"url":"https://api.github.com/repos/scikit-image/scikit-image/pulls/2880","id":152542697,"node_id":"MDExOlB1bGxSZXF1ZXN0MTUyNTQyNjk3","html_url":"https://github.com/scikit-image/scikit-image/pull/2880","diff_url":"https://github.com/scikit-image/scikit-image/pull/2880.diff","patch_url":"https://github.com/scikit-image/scikit-image/pull/2880.patch","issue_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/2880","number":2880,"state":"open","locked":false,"title":"Extension of register_translation to enable subpixel precision in 3D and optionally disable error calculation","user":{"login":"vilim","id":3041236,"node_id":"MDQ6VXNlcjMwNDEyMzY=","avatar_url":"https://avatars3.githubusercontent.com/u/3041236?v=4","gravatar_id":"","url":"https://api.github.com/users/vilim","html_url":"https://github.com/vilim","followers_url":"https://api.github.com/users/vilim/followers","following_url":"https://api.github.com/users/vilim/following{/other_user}","gists_url":"https://api.github.com/users/vilim/gists{/gist_id}","starred_url":"https://api.github.com/users/vilim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vilim/subscriptions","organizations_url":"https://api.github.com/users/vilim/orgs","repos_url":"https://api.github.com/users/vilim/repos","events_url":"https://api.github.com/users/vilim/events{/privacy}","received_events_url":"https://api.github.com/users/vilim/received_events","type":"User","site_admin":false},"body":"## Description\r\nI extended the register_translation function to:\r\n- enable 3D subpixel-precision registration, by generalising the _upsampled_dft function\r\n- optionally not calculate the error and phase shift\r\n\r\n## Checklist\r\n\r\n- [x] Clean style in [the spirit of PEP8](https://www.python.org/dev/peps/pep-0008/)\r\n- [x] [Docstrings for all functions](https://github.com/numpy/numpy/blob/master/doc/example.py)\r\n- [ ] Gallery example in `./doc/examples` (new features only)\r\n- [x] Unit tests\r\n\r\n[For detailed information on these and other aspects see [scikit-image contribution guidelines](http://scikit-image.org/docs/dev/contribute.html)]\r\n\r\n\r\n## For reviewers\r\n\r\n(Don't remove the checklist below.)\r\n\r\n- [ ] Check that the PR title is short, concise, and will make sense 1 year\r\n  later.\r\n- [ ] Check that new functions are imported in corresponding `__init__.py`.\r\n- [ ] Check that new features, API changes, and deprecations are mentioned in\r\n      `doc/release/release_dev.rst`.\r\n","created_at":"2017-11-14T15:53:49Z","updated_at":"2018-09-16T12:43:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8784f22c178e0ffc97648441bd8fcef865dc3889","assignee":{"login":"jni","id":492549,"node_id":"MDQ6VXNlcjQ5MjU0OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/492549?v=4","gravatar_id":"","url":"https://api.github.com/users/jni","html_url":"https://github.com/jni","followers_url":"https://api.github.com/users/jni/followers","following_url":"https://api.github.com/users/jni/following{/other_user}","gists_url":"https://api.github.com/users/jni/gists{/gist_id}","starred_url":"https://api.github.com/users/jni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jni/subscriptions","organizations_url":"https://api.github.com/users/jni/orgs","repos_url":"https://api.github.com/users/jni/repos","events_url":"https://api.github.com/users/jni/events{/privacy}","received_events_url":"https://api.github.com/users/jni/received_events","type":"User","site_admin":false},"assignees":[{"login":"jni","id":492549,"node_id":"MDQ6VXNlcjQ5MjU0OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/492549?v=4","gravatar_id":"","url":"https://api.github.com/users/jni","html_url":"https://github.com/jni","followers_url":"https://api.github.com/users/jni/followers","following_url":"https://api.github.com/users/jni/following{/other_user}","gists_url":"https://api.github.com/users/jni/gists{/gist_id}","starred_url":"https://api.github.com/users/jni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jni/subscriptions","organizations_url":"https://api.github.com/users/jni/orgs","repos_url":"https://api.github.com/users/jni/repos","events_url":"https://api.github.com/users/jni/events{/privacy}","received_events_url":"https://api.github.com/users/jni/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":360222353,"node_id":"MDU6TGFiZWwzNjAyMjIzNTM=","url":"https://api.github.com/repos/scikit-image/scikit-image/labels/status:%20needs%20review","name":"status: needs review","color":"fef2c0","default":false},{"id":298491707,"node_id":"MDU6TGFiZWwyOTg0OTE3MDc=","url":"https://api.github.com/repos/scikit-image/scikit-image/labels/type:%20enhancement","name":"type: enhancement","color":"51af3c","default":false}],"milestone":{"url":"https://api.github.com/repos/scikit-image/scikit-image/milestones/8","html_url":"https://github.com/scikit-image/scikit-image/milestone/8","labels_url":"https://api.github.com/repos/scikit-image/scikit-image/milestones/8/labels","id":1968011,"node_id":"MDk6TWlsZXN0b25lMTk2ODAxMQ==","number":8,"title":"0.15","description":"","creator":{"login":"sciunto","id":335370,"node_id":"MDQ6VXNlcjMzNTM3MA==","avatar_url":"https://avatars0.githubusercontent.com/u/335370?v=4","gravatar_id":"","url":"https://api.github.com/users/sciunto","html_url":"https://github.com/sciunto","followers_url":"https://api.github.com/users/sciunto/followers","following_url":"https://api.github.com/users/sciunto/following{/other_user}","gists_url":"https://api.github.com/users/sciunto/gists{/gist_id}","starred_url":"https://api.github.com/users/sciunto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sciunto/subscriptions","organizations_url":"https://api.github.com/users/sciunto/orgs","repos_url":"https://api.github.com/users/sciunto/repos","events_url":"https://api.github.com/users/sciunto/events{/privacy}","received_events_url":"https://api.github.com/users/sciunto/received_events","type":"User","site_admin":false},"open_issues":141,"closed_issues":71,"state":"open","created_at":"2016-08-28T11:46:48Z","updated_at":"2018-09-15T17:13:20Z","due_on":"2019-05-01T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/scikit-image/scikit-image/pulls/2880/commits","review_comments_url":"https://api.github.com/repos/scikit-image/scikit-image/pulls/2880/comments","review_comment_url":"https://api.github.com/repos/scikit-image/scikit-image/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/2880/comments","statuses_url":"https://api.github.com/repos/scikit-image/scikit-image/statuses/85666392a0557e0b6f02f82c6c762676c4313b53","head":{"label":"portugueslab:register-subpixel-3D","ref":"register-subpixel-3D","sha":"85666392a0557e0b6f02f82c6c762676c4313b53","user":{"login":"portugueslab","id":25010485,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDEwNDg1","avatar_url":"https://avatars0.githubusercontent.com/u/25010485?v=4","gravatar_id":"","url":"https://api.github.com/users/portugueslab","html_url":"https://github.com/portugueslab","followers_url":"https://api.github.com/users/portugueslab/followers","following_url":"https://api.github.com/users/portugueslab/following{/other_user}","gists_url":"https://api.github.com/users/portugueslab/gists{/gist_id}","starred_url":"https://api.github.com/users/portugueslab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/portugueslab/subscriptions","organizations_url":"https://api.github.com/users/portugueslab/orgs","repos_url":"https://api.github.com/users/portugueslab/repos","events_url":"https://api.github.com/users/portugueslab/events{/privacy}","received_events_url":"https://api.github.com/users/portugueslab/received_events","type":"Organization","site_admin":false},"repo":{"id":110691884,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA2OTE4ODQ=","name":"scikit-image","full_name":"portugueslab/scikit-image","private":false,"owner":{"login":"portugueslab","id":25010485,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDEwNDg1","avatar_url":"https://avatars0.githubusercontent.com/u/25010485?v=4","gravatar_id":"","url":"https://api.github.com/users/portugueslab","html_url":"https://github.com/portugueslab","followers_url":"https://api.github.com/users/portugueslab/followers","following_url":"https://api.github.com/users/portugueslab/following{/other_user}","gists_url":"https://api.github.com/users/portugueslab/gists{/gist_id}","starred_url":"https://api.github.com/users/portugueslab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/portugueslab/subscriptions","organizations_url":"https://api.github.com/users/portugueslab/orgs","repos_url":"https://api.github.com/users/portugueslab/repos","events_url":"https://api.github.com/users/portugueslab/events{/privacy}","received_events_url":"https://api.github.com/users/portugueslab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/portugueslab/scikit-image","description":"Image Processing SciKit (Toolbox for SciPy)","fork":true,"url":"https://api.github.com/repos/portugueslab/scikit-image","forks_url":"https://api.github.com/repos/portugueslab/scikit-image/forks","keys_url":"https://api.github.com/repos/portugueslab/scikit-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/portugueslab/scikit-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/portugueslab/scikit-image/teams","hooks_url":"https://api.github.com/repos/portugueslab/scikit-image/hooks","issue_events_url":"https://api.github.com/repos/portugueslab/scikit-image/issues/events{/number}","events_url":"https://api.github.com/repos/portugueslab/scikit-image/events","assignees_url":"https://api.github.com/repos/portugueslab/scikit-image/assignees{/user}","branches_url":"https://api.github.com/repos/portugueslab/scikit-image/branches{/branch}","tags_url":"https://api.github.com/repos/portugueslab/scikit-image/tags","blobs_url":"https://api.github.com/repos/portugueslab/scikit-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/portugueslab/scikit-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/portugueslab/scikit-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/portugueslab/scikit-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/portugueslab/scikit-image/statuses/{sha}","languages_url":"https://api.github.com/repos/portugueslab/scikit-image/languages","stargazers_url":"https://api.github.com/repos/portugueslab/scikit-image/stargazers","contributors_url":"https://api.github.com/repos/portugueslab/scikit-image/contributors","subscribers_url":"https://api.github.com/repos/portugueslab/scikit-image/subscribers","subscription_url":"https://api.github.com/repos/portugueslab/scikit-image/subscription","commits_url":"https://api.github.com/repos/portugueslab/scikit-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/portugueslab/scikit-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/portugueslab/scikit-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/portugueslab/scikit-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/portugueslab/scikit-image/contents/{+path}","compare_url":"https://api.github.com/repos/portugueslab/scikit-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/portugueslab/scikit-image/merges","archive_url":"https://api.github.com/repos/portugueslab/scikit-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/portugueslab/scikit-image/downloads","issues_url":"https://api.github.com/repos/portugueslab/scikit-image/issues{/number}","pulls_url":"https://api.github.com/repos/portugueslab/scikit-image/pulls{/number}","milestones_url":"https://api.github.com/repos/portugueslab/scikit-image/milestones{/number}","notifications_url":"https://api.github.com/repos/portugueslab/scikit-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/portugueslab/scikit-image/labels{/name}","releases_url":"https://api.github.com/repos/portugueslab/scikit-image/releases{/id}","deployments_url":"https://api.github.com/repos/portugueslab/scikit-image/deployments","created_at":"2017-11-14T13:11:25Z","updated_at":"2017-11-14T13:11:31Z","pushed_at":"2018-07-03T09:56:27Z","git_url":"git://github.com/portugueslab/scikit-image.git","ssh_url":"git@github.com:portugueslab/scikit-image.git","clone_url":"https://github.com/portugueslab/scikit-image.git","svn_url":"https://github.com/portugueslab/scikit-image","homepage":"http://scikit-image.org","size":53684,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-image:master","ref":"master","sha":"0fa3bcb118bb208a0cc7d3e8b96cd96c1ce7a75b","user":{"login":"scikit-image","id":897180,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5NzE4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/897180?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-image","html_url":"https://github.com/scikit-image","followers_url":"https://api.github.com/users/scikit-image/followers","following_url":"https://api.github.com/users/scikit-image/following{/other_user}","gists_url":"https://api.github.com/users/scikit-image/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-image/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-image/subscriptions","organizations_url":"https://api.github.com/users/scikit-image/orgs","repos_url":"https://api.github.com/users/scikit-image/repos","events_url":"https://api.github.com/users/scikit-image/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-image/received_events","type":"Organization","site_admin":false},"repo":{"id":2014929,"node_id":"MDEwOlJlcG9zaXRvcnkyMDE0OTI5","name":"scikit-image","full_name":"scikit-image/scikit-image","private":false,"owner":{"login":"scikit-image","id":897180,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5NzE4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/897180?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-image","html_url":"https://github.com/scikit-image","followers_url":"https://api.github.com/users/scikit-image/followers","following_url":"https://api.github.com/users/scikit-image/following{/other_user}","gists_url":"https://api.github.com/users/scikit-image/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-image/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-image/subscriptions","organizations_url":"https://api.github.com/users/scikit-image/orgs","repos_url":"https://api.github.com/users/scikit-image/repos","events_url":"https://api.github.com/users/scikit-image/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-image/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/scikit-image/scikit-image","description":"Image processing in Python","fork":false,"url":"https://api.github.com/repos/scikit-image/scikit-image","forks_url":"https://api.github.com/repos/scikit-image/scikit-image/forks","keys_url":"https://api.github.com/repos/scikit-image/scikit-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-image/scikit-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-image/scikit-image/teams","hooks_url":"https://api.github.com/repos/scikit-image/scikit-image/hooks","issue_events_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-image/scikit-image/events","assignees_url":"https://api.github.com/repos/scikit-image/scikit-image/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-image/scikit-image/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-image/scikit-image/tags","blobs_url":"https://api.github.com/repos/scikit-image/scikit-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-image/scikit-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-image/scikit-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-image/scikit-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-image/scikit-image/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-image/scikit-image/languages","stargazers_url":"https://api.github.com/repos/scikit-image/scikit-image/stargazers","contributors_url":"https://api.github.com/repos/scikit-image/scikit-image/contributors","subscribers_url":"https://api.github.com/repos/scikit-image/scikit-image/subscribers","subscription_url":"https://api.github.com/repos/scikit-image/scikit-image/subscription","commits_url":"https://api.github.com/repos/scikit-image/scikit-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-image/scikit-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-image/scikit-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-image/scikit-image/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-image/scikit-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-image/scikit-image/merges","archive_url":"https://api.github.com/repos/scikit-image/scikit-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-image/scikit-image/downloads","issues_url":"https://api.github.com/repos/scikit-image/scikit-image/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-image/scikit-image/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-image/scikit-image/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-image/scikit-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-image/scikit-image/labels{/name}","releases_url":"https://api.github.com/repos/scikit-image/scikit-image/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-image/scikit-image/deployments","created_at":"2011-07-07T22:07:20Z","updated_at":"2018-09-15T05:08:31Z","pushed_at":"2018-09-16T11:41:23Z","git_url":"git://github.com/scikit-image/scikit-image.git","ssh_url":"git@github.com:scikit-image/scikit-image.git","clone_url":"https://github.com/scikit-image/scikit-image.git","svn_url":"https://github.com/scikit-image/scikit-image","homepage":"http://scikit-image.org","size":55665,"stargazers_count":2501,"watchers_count":2501,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1095,"mirror_url":null,"archived":false,"open_issues_count":485,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1095,"open_issues":485,"watchers":2501,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-image/scikit-image/pulls/2880"},"html":{"href":"https://github.com/scikit-image/scikit-image/pull/2880"},"issue":{"href":"https://api.github.com/repos/scikit-image/scikit-image/issues/2880"},"comments":{"href":"https://api.github.com/repos/scikit-image/scikit-image/issues/2880/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-image/scikit-image/pulls/2880/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-image/scikit-image/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-image/scikit-image/pulls/2880/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-image/scikit-image/statuses/85666392a0557e0b6f02f82c6c762676c4313b53"}},"author_association":"NONE"}}
{"actor":{"display_login":"emmanuelle"}}