{"action":"created","comment":{"url":"https://api.github.com/repos/scalaz/scalaz-zio/pulls/comments/197747418","pull_request_review_id":131546411,"id":197747418,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Nzc0NzQxOA==","diff_hunk":"@@ -682,19 +643,8 @@ private object RTS {\n \n                   case IO.Tags.Ensuring =>\n                     val io = curIo.asInstanceOf[IO.Ensuring[E, Any]]\n-\n-                    val ref = new AtomicReference[Boolean](false)\n-\n-                    val finalizer = Finalizer[E](\n-                      _ => IO.suspend[Void, Unit](if (!ref.get) io.finalizer else IO.unit)\n-                    )\n-\n-                    stack.push(finalizer)\n-\n-                    curIo = for {\n-                      a <- io.io\n-                      _ <- (io.finalizer[E] *> IO.sync[E, Unit](ref.set(true))).uninterruptibly\n-                    } yield a\n+                    stack.push(Finalizer[E](io.finalizer))","path":"core/jvm/src/main/scala/scalaz/zio/RTS.scala","position":154,"original_position":154,"commit_id":"ce0e6c3fc261f5eea881a4fe9eb8c928c6ba5e87","original_commit_id":"ce0e6c3fc261f5eea881a4fe9eb8c928c6ba5e87","user":{"login":"jdegoes","id":156745,"node_id":"MDQ6VXNlcjE1Njc0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/156745?v=4","gravatar_id":"","url":"https://api.github.com/users/jdegoes","html_url":"https://github.com/jdegoes","followers_url":"https://api.github.com/users/jdegoes/followers","following_url":"https://api.github.com/users/jdegoes/following{/other_user}","gists_url":"https://api.github.com/users/jdegoes/gists{/gist_id}","starred_url":"https://api.github.com/users/jdegoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdegoes/subscriptions","organizations_url":"https://api.github.com/users/jdegoes/orgs","repos_url":"https://api.github.com/users/jdegoes/repos","events_url":"https://api.github.com/users/jdegoes/events{/privacy}","received_events_url":"https://api.github.com/users/jdegoes/received_events","type":"User","site_admin":false},"body":"This is correct and what we want.","created_at":"2018-06-25T10:21:13Z","updated_at":"2018-06-25T10:33:49Z","html_url":"https://github.com/scalaz/scalaz-zio/pull/69#discussion_r197747418","pull_request_url":"https://api.github.com/repos/scalaz/scalaz-zio/pulls/69","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/scalaz/scalaz-zio/pulls/comments/197747418"},"html":{"href":"https://github.com/scalaz/scalaz-zio/pull/69#discussion_r197747418"},"pull_request":{"href":"https://api.github.com/repos/scalaz/scalaz-zio/pulls/69"}}},"pull_request":{"url":"https://api.github.com/repos/scalaz/scalaz-zio/pulls/69","id":197016046,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MDE2MDQ2","html_url":"https://github.com/scalaz/scalaz-zio/pull/69","diff_url":"https://github.com/scalaz/scalaz-zio/pull/69.diff","patch_url":"https://github.com/scalaz/scalaz-zio/pull/69.patch","issue_url":"https://api.github.com/repos/scalaz/scalaz-zio/issues/69","number":69,"state":"open","locked":false,"title":"Rewrite `io.bracket*` with the new `IO.bracket` primitive","user":{"login":"regiskuckaertz","id":629976,"node_id":"MDQ6VXNlcjYyOTk3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/629976?v=4","gravatar_id":"","url":"https://api.github.com/users/regiskuckaertz","html_url":"https://github.com/regiskuckaertz","followers_url":"https://api.github.com/users/regiskuckaertz/followers","following_url":"https://api.github.com/users/regiskuckaertz/following{/other_user}","gists_url":"https://api.github.com/users/regiskuckaertz/gists{/gist_id}","starred_url":"https://api.github.com/users/regiskuckaertz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regiskuckaertz/subscriptions","organizations_url":"https://api.github.com/users/regiskuckaertz/orgs","repos_url":"https://api.github.com/users/regiskuckaertz/repos","events_url":"https://api.github.com/users/regiskuckaertz/events{/privacy}","received_events_url":"https://api.github.com/users/regiskuckaertz/received_events","type":"User","site_admin":false},"body":"One test is failing ~~I assume because of #68~~ . I removed `io.bracketOnError` because it ended up being the same as `io.bracket`.\r\n\r\n@jdegoes I now realise the release action in `bracket0` had an additional parameter, that assumed the acquiring computation went through. ","created_at":"2018-06-25T06:48:22Z","updated_at":"2018-06-25T10:33:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6fa8bb721f80c10f554ecdbccac58f0dcf6ca70","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/scalaz/scalaz-zio/pulls/69/commits","review_comments_url":"https://api.github.com/repos/scalaz/scalaz-zio/pulls/69/comments","review_comment_url":"https://api.github.com/repos/scalaz/scalaz-zio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scalaz/scalaz-zio/issues/69/comments","statuses_url":"https://api.github.com/repos/scalaz/scalaz-zio/statuses/ce0e6c3fc261f5eea881a4fe9eb8c928c6ba5e87","head":{"label":"regiskuckaertz:remove-bracket","ref":"remove-bracket","sha":"ce0e6c3fc261f5eea881a4fe9eb8c928c6ba5e87","user":{"login":"regiskuckaertz","id":629976,"node_id":"MDQ6VXNlcjYyOTk3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/629976?v=4","gravatar_id":"","url":"https://api.github.com/users/regiskuckaertz","html_url":"https://github.com/regiskuckaertz","followers_url":"https://api.github.com/users/regiskuckaertz/followers","following_url":"https://api.github.com/users/regiskuckaertz/following{/other_user}","gists_url":"https://api.github.com/users/regiskuckaertz/gists{/gist_id}","starred_url":"https://api.github.com/users/regiskuckaertz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regiskuckaertz/subscriptions","organizations_url":"https://api.github.com/users/regiskuckaertz/orgs","repos_url":"https://api.github.com/users/regiskuckaertz/repos","events_url":"https://api.github.com/users/regiskuckaertz/events{/privacy}","received_events_url":"https://api.github.com/users/regiskuckaertz/received_events","type":"User","site_admin":false},"repo":{"id":136933794,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY5MzM3OTQ=","name":"scalaz-zio","full_name":"regiskuckaertz/scalaz-zio","owner":{"login":"regiskuckaertz","id":629976,"node_id":"MDQ6VXNlcjYyOTk3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/629976?v=4","gravatar_id":"","url":"https://api.github.com/users/regiskuckaertz","html_url":"https://github.com/regiskuckaertz","followers_url":"https://api.github.com/users/regiskuckaertz/followers","following_url":"https://api.github.com/users/regiskuckaertz/following{/other_user}","gists_url":"https://api.github.com/users/regiskuckaertz/gists{/gist_id}","starred_url":"https://api.github.com/users/regiskuckaertz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regiskuckaertz/subscriptions","organizations_url":"https://api.github.com/users/regiskuckaertz/orgs","repos_url":"https://api.github.com/users/regiskuckaertz/repos","events_url":"https://api.github.com/users/regiskuckaertz/events{/privacy}","received_events_url":"https://api.github.com/users/regiskuckaertz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/regiskuckaertz/scalaz-zio","description":"ZIO — A principled, powerful, standalone effect data type for any Scala project.","fork":true,"url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio","forks_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/forks","keys_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/teams","hooks_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/hooks","issue_events_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/issues/events{/number}","events_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/events","assignees_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/assignees{/user}","branches_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/branches{/branch}","tags_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/tags","blobs_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/git/refs{/sha}","trees_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/statuses/{sha}","languages_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/languages","stargazers_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/stargazers","contributors_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/contributors","subscribers_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/subscribers","subscription_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/subscription","commits_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/commits{/sha}","git_commits_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/git/commits{/sha}","comments_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/comments{/number}","issue_comment_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/issues/comments{/number}","contents_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/contents/{+path}","compare_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/merges","archive_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/downloads","issues_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/issues{/number}","pulls_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/pulls{/number}","milestones_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/milestones{/number}","notifications_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/labels{/name}","releases_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/releases{/id}","deployments_url":"https://api.github.com/repos/regiskuckaertz/scalaz-zio/deployments","created_at":"2018-06-11T13:57:11Z","updated_at":"2018-06-24T16:04:23Z","pushed_at":"2018-06-25T09:37:37Z","git_url":"git://github.com/regiskuckaertz/scalaz-zio.git","ssh_url":"git@github.com:regiskuckaertz/scalaz-zio.git","clone_url":"https://github.com/regiskuckaertz/scalaz-zio.git","svn_url":"https://github.com/regiskuckaertz/scalaz-zio","homepage":"","size":367,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scalaz:master","ref":"master","sha":"05101cfcc5477d086687d34e1154b44bf97e5a58","user":{"login":"scalaz","id":183416,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MzQxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/183416?v=4","gravatar_id":"","url":"https://api.github.com/users/scalaz","html_url":"https://github.com/scalaz","followers_url":"https://api.github.com/users/scalaz/followers","following_url":"https://api.github.com/users/scalaz/following{/other_user}","gists_url":"https://api.github.com/users/scalaz/gists{/gist_id}","starred_url":"https://api.github.com/users/scalaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalaz/subscriptions","organizations_url":"https://api.github.com/users/scalaz/orgs","repos_url":"https://api.github.com/users/scalaz/repos","events_url":"https://api.github.com/users/scalaz/events{/privacy}","received_events_url":"https://api.github.com/users/scalaz/received_events","type":"Organization","site_admin":false},"repo":{"id":134079884,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQwNzk4ODQ=","name":"scalaz-zio","full_name":"scalaz/scalaz-zio","owner":{"login":"scalaz","id":183416,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MzQxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/183416?v=4","gravatar_id":"","url":"https://api.github.com/users/scalaz","html_url":"https://github.com/scalaz","followers_url":"https://api.github.com/users/scalaz/followers","following_url":"https://api.github.com/users/scalaz/following{/other_user}","gists_url":"https://api.github.com/users/scalaz/gists{/gist_id}","starred_url":"https://api.github.com/users/scalaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalaz/subscriptions","organizations_url":"https://api.github.com/users/scalaz/orgs","repos_url":"https://api.github.com/users/scalaz/repos","events_url":"https://api.github.com/users/scalaz/events{/privacy}","received_events_url":"https://api.github.com/users/scalaz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalaz/scalaz-zio","description":"ZIO — A principled, powerful, standalone effect data type for any Scala project.","fork":false,"url":"https://api.github.com/repos/scalaz/scalaz-zio","forks_url":"https://api.github.com/repos/scalaz/scalaz-zio/forks","keys_url":"https://api.github.com/repos/scalaz/scalaz-zio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalaz/scalaz-zio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalaz/scalaz-zio/teams","hooks_url":"https://api.github.com/repos/scalaz/scalaz-zio/hooks","issue_events_url":"https://api.github.com/repos/scalaz/scalaz-zio/issues/events{/number}","events_url":"https://api.github.com/repos/scalaz/scalaz-zio/events","assignees_url":"https://api.github.com/repos/scalaz/scalaz-zio/assignees{/user}","branches_url":"https://api.github.com/repos/scalaz/scalaz-zio/branches{/branch}","tags_url":"https://api.github.com/repos/scalaz/scalaz-zio/tags","blobs_url":"https://api.github.com/repos/scalaz/scalaz-zio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalaz/scalaz-zio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalaz/scalaz-zio/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalaz/scalaz-zio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalaz/scalaz-zio/statuses/{sha}","languages_url":"https://api.github.com/repos/scalaz/scalaz-zio/languages","stargazers_url":"https://api.github.com/repos/scalaz/scalaz-zio/stargazers","contributors_url":"https://api.github.com/repos/scalaz/scalaz-zio/contributors","subscribers_url":"https://api.github.com/repos/scalaz/scalaz-zio/subscribers","subscription_url":"https://api.github.com/repos/scalaz/scalaz-zio/subscription","commits_url":"https://api.github.com/repos/scalaz/scalaz-zio/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalaz/scalaz-zio/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalaz/scalaz-zio/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalaz/scalaz-zio/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalaz/scalaz-zio/contents/{+path}","compare_url":"https://api.github.com/repos/scalaz/scalaz-zio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalaz/scalaz-zio/merges","archive_url":"https://api.github.com/repos/scalaz/scalaz-zio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalaz/scalaz-zio/downloads","issues_url":"https://api.github.com/repos/scalaz/scalaz-zio/issues{/number}","pulls_url":"https://api.github.com/repos/scalaz/scalaz-zio/pulls{/number}","milestones_url":"https://api.github.com/repos/scalaz/scalaz-zio/milestones{/number}","notifications_url":"https://api.github.com/repos/scalaz/scalaz-zio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalaz/scalaz-zio/labels{/name}","releases_url":"https://api.github.com/repos/scalaz/scalaz-zio/releases{/id}","deployments_url":"https://api.github.com/repos/scalaz/scalaz-zio/deployments","created_at":"2018-05-19T16:40:37Z","updated_at":"2018-06-25T09:12:58Z","pushed_at":"2018-06-25T09:37:38Z","git_url":"git://github.com/scalaz/scalaz-zio.git","ssh_url":"git@github.com:scalaz/scalaz-zio.git","clone_url":"https://github.com/scalaz/scalaz-zio.git","svn_url":"https://github.com/scalaz/scalaz-zio","homepage":"","size":380,"stargazers_count":166,"watchers_count":166,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":29,"open_issues":15,"watchers":166,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scalaz/scalaz-zio/pulls/69"},"html":{"href":"https://github.com/scalaz/scalaz-zio/pull/69"},"issue":{"href":"https://api.github.com/repos/scalaz/scalaz-zio/issues/69"},"comments":{"href":"https://api.github.com/repos/scalaz/scalaz-zio/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/scalaz/scalaz-zio/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/scalaz/scalaz-zio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scalaz/scalaz-zio/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/scalaz/scalaz-zio/statuses/ce0e6c3fc261f5eea881a4fe9eb8c928c6ba5e87"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jdegoes"}}