{"action":"created","comment":{"url":"https://api.github.com/repos/graphhopper/geocoder-converter/pulls/comments/169221786","pull_request_review_id":97712056,"id":169221786,"diff_hunk":"@@ -0,0 +1,296 @@\n+/*******************************************************************************\n+ *   Gisgraphy Project \n+ * \n+ *   This library is free software; you can redistribute it and/or\n+ *   modify it under the terms of the GNU Lesser General Public\n+ *   License as published by the Free Software Foundation; either\n+ *   version 2.1 of the License, or (at your option) any later version.\n+ * \n+ *   This library is distributed in the hope that it will be useful,\n+ *   but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU\n+ *   Lesser General Public License for more details.\n+ * \n+ *   You should have received a copy of the GNU Lesser General Public\n+ *   License along with this library; if not, write to the Free Software\n+ *   Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA\n+ * \n+ *  Copyright 2008  Gisgraphy project \n+ *  David Masclet <davidmasclet@gisgraphy.com>\n+ *  \n+ *  \n+ *******************************************************************************/\n+package com.graphhopper.converter.data;\n+\n+import java.io.File;\n+import java.util.HashMap;\n+\n+/**\n+ * \n+ * some information on country\n+ * \n+ * @author <a href=\"mailto:david.masclet@gisgraphy.com\">David Masclet</a>\n+ * \n+ */\n+public class CountryInfo {","path":"src/main/java/com/graphhopper/converter/data/CountryInfo.java","position":35,"original_position":35,"commit_id":"ebf52e3b1858d95c00eac32ac4eff2eb9a434370","original_commit_id":"ebf52e3b1858d95c00eac32ac4eff2eb9a434370","user":{"login":"boldtrn","id":1553525,"avatar_url":"https://avatars3.githubusercontent.com/u/1553525?v=4","gravatar_id":"","url":"https://api.github.com/users/boldtrn","html_url":"https://github.com/boldtrn","followers_url":"https://api.github.com/users/boldtrn/followers","following_url":"https://api.github.com/users/boldtrn/following{/other_user}","gists_url":"https://api.github.com/users/boldtrn/gists{/gist_id}","starred_url":"https://api.github.com/users/boldtrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boldtrn/subscriptions","organizations_url":"https://api.github.com/users/boldtrn/orgs","repos_url":"https://api.github.com/users/boldtrn/repos","events_url":"https://api.github.com/users/boldtrn/events{/privacy}","received_events_url":"https://api.github.com/users/boldtrn/received_events","type":"User","site_admin":false},"body":"Regarding this class, AFAIK you want to add the country to Gisgraphy. Should we then even add this class, wait until the country is available in Gisgraphy, or use the country code for now and switch to the country name, once it's available in the Gisgraphy API?","created_at":"2018-02-20T05:45:31Z","updated_at":"2018-02-20T05:45:31Z","html_url":"https://github.com/graphhopper/geocoder-converter/pull/34#discussion_r169221786","pull_request_url":"https://api.github.com/repos/graphhopper/geocoder-converter/pulls/34","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/graphhopper/geocoder-converter/pulls/comments/169221786"},"html":{"href":"https://github.com/graphhopper/geocoder-converter/pull/34#discussion_r169221786"},"pull_request":{"href":"https://api.github.com/repos/graphhopper/geocoder-converter/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/graphhopper/geocoder-converter/pulls/34","id":169071878,"html_url":"https://github.com/graphhopper/geocoder-converter/pull/34","diff_url":"https://github.com/graphhopper/geocoder-converter/pull/34.diff","patch_url":"https://github.com/graphhopper/geocoder-converter/pull/34.patch","issue_url":"https://api.github.com/repos/graphhopper/geocoder-converter/issues/34","number":34,"state":"open","locked":false,"title":"Add Gisgraphy Geocoder","user":{"login":"gisgraphy","id":7648584,"avatar_url":"https://avatars0.githubusercontent.com/u/7648584?v=4","gravatar_id":"","url":"https://api.github.com/users/gisgraphy","html_url":"https://github.com/gisgraphy","followers_url":"https://api.github.com/users/gisgraphy/followers","following_url":"https://api.github.com/users/gisgraphy/following{/other_user}","gists_url":"https://api.github.com/users/gisgraphy/gists{/gist_id}","starred_url":"https://api.github.com/users/gisgraphy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gisgraphy/subscriptions","organizations_url":"https://api.github.com/users/gisgraphy/orgs","repos_url":"https://api.github.com/users/gisgraphy/repos","events_url":"https://api.github.com/users/gisgraphy/events{/privacy}","received_events_url":"https://api.github.com/users/gisgraphy/received_events","type":"User","site_admin":false},"body":"Add Gisgraphy Geocoder as a new provider (for geocoding forward and reverse and autocomplete)\r\nDocumentation need to be updated.\r\nSome technical choice can be discussed as \r\n- the CountryInfo class\r\n- what to do if the queryType is not correct (we then consider that it is geocoding), maybe throw an exception can be better\r\n- put the DTO in a specific package can improve lisibility.\r\n\r\nA try in real environement can also be necessary\r\n\r\nEvery comments are welcomed\r\n\r\n","created_at":"2018-02-14T10:28:58Z","updated_at":"2018-02-20T05:45:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0fca726e0e8830e5637425ec226ee20cac2986a0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/graphhopper/geocoder-converter/pulls/34/commits","review_comments_url":"https://api.github.com/repos/graphhopper/geocoder-converter/pulls/34/comments","review_comment_url":"https://api.github.com/repos/graphhopper/geocoder-converter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/graphhopper/geocoder-converter/issues/34/comments","statuses_url":"https://api.github.com/repos/graphhopper/geocoder-converter/statuses/ebf52e3b1858d95c00eac32ac4eff2eb9a434370","head":{"label":"gisgraphy:master","ref":"master","sha":"ebf52e3b1858d95c00eac32ac4eff2eb9a434370","user":{"login":"gisgraphy","id":7648584,"avatar_url":"https://avatars0.githubusercontent.com/u/7648584?v=4","gravatar_id":"","url":"https://api.github.com/users/gisgraphy","html_url":"https://github.com/gisgraphy","followers_url":"https://api.github.com/users/gisgraphy/followers","following_url":"https://api.github.com/users/gisgraphy/following{/other_user}","gists_url":"https://api.github.com/users/gisgraphy/gists{/gist_id}","starred_url":"https://api.github.com/users/gisgraphy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gisgraphy/subscriptions","organizations_url":"https://api.github.com/users/gisgraphy/orgs","repos_url":"https://api.github.com/users/gisgraphy/repos","events_url":"https://api.github.com/users/gisgraphy/events{/privacy}","received_events_url":"https://api.github.com/users/gisgraphy/received_events","type":"User","site_admin":false},"repo":{"id":116700725,"name":"geocoder-converter","full_name":"gisgraphy/geocoder-converter","owner":{"login":"gisgraphy","id":7648584,"avatar_url":"https://avatars0.githubusercontent.com/u/7648584?v=4","gravatar_id":"","url":"https://api.github.com/users/gisgraphy","html_url":"https://github.com/gisgraphy","followers_url":"https://api.github.com/users/gisgraphy/followers","following_url":"https://api.github.com/users/gisgraphy/following{/other_user}","gists_url":"https://api.github.com/users/gisgraphy/gists{/gist_id}","starred_url":"https://api.github.com/users/gisgraphy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gisgraphy/subscriptions","organizations_url":"https://api.github.com/users/gisgraphy/orgs","repos_url":"https://api.github.com/users/gisgraphy/repos","events_url":"https://api.github.com/users/gisgraphy/events{/privacy}","received_events_url":"https://api.github.com/users/gisgraphy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gisgraphy/geocoder-converter","description":"Converts a Nominatim response to a GraphHopper response","fork":true,"url":"https://api.github.com/repos/gisgraphy/geocoder-converter","forks_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/forks","keys_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/teams","hooks_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/hooks","issue_events_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/issues/events{/number}","events_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/events","assignees_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/assignees{/user}","branches_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/branches{/branch}","tags_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/tags","blobs_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/git/refs{/sha}","trees_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/statuses/{sha}","languages_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/languages","stargazers_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/stargazers","contributors_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/contributors","subscribers_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/subscribers","subscription_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/subscription","commits_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/commits{/sha}","git_commits_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/git/commits{/sha}","comments_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/comments{/number}","issue_comment_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/issues/comments{/number}","contents_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/contents/{+path}","compare_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/merges","archive_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/downloads","issues_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/issues{/number}","pulls_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/pulls{/number}","milestones_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/milestones{/number}","notifications_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/labels{/name}","releases_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/releases{/id}","deployments_url":"https://api.github.com/repos/gisgraphy/geocoder-converter/deployments","created_at":"2018-01-08T16:28:58Z","updated_at":"2018-01-08T16:29:00Z","pushed_at":"2018-02-16T13:07:22Z","git_url":"git://github.com/gisgraphy/geocoder-converter.git","ssh_url":"git@github.com:gisgraphy/geocoder-converter.git","clone_url":"https://github.com/gisgraphy/geocoder-converter.git","svn_url":"https://github.com/gisgraphy/geocoder-converter","homepage":null,"size":110,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"graphhopper:master","ref":"master","sha":"34cb018018bde3944ba621dc2df821e416717927","user":{"login":"graphhopper","id":2264498,"avatar_url":"https://avatars1.githubusercontent.com/u/2264498?v=4","gravatar_id":"","url":"https://api.github.com/users/graphhopper","html_url":"https://github.com/graphhopper","followers_url":"https://api.github.com/users/graphhopper/followers","following_url":"https://api.github.com/users/graphhopper/following{/other_user}","gists_url":"https://api.github.com/users/graphhopper/gists{/gist_id}","starred_url":"https://api.github.com/users/graphhopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphhopper/subscriptions","organizations_url":"https://api.github.com/users/graphhopper/orgs","repos_url":"https://api.github.com/users/graphhopper/repos","events_url":"https://api.github.com/users/graphhopper/events{/privacy}","received_events_url":"https://api.github.com/users/graphhopper/received_events","type":"Organization","site_admin":false},"repo":{"id":53936001,"name":"geocoder-converter","full_name":"graphhopper/geocoder-converter","owner":{"login":"graphhopper","id":2264498,"avatar_url":"https://avatars1.githubusercontent.com/u/2264498?v=4","gravatar_id":"","url":"https://api.github.com/users/graphhopper","html_url":"https://github.com/graphhopper","followers_url":"https://api.github.com/users/graphhopper/followers","following_url":"https://api.github.com/users/graphhopper/following{/other_user}","gists_url":"https://api.github.com/users/graphhopper/gists{/gist_id}","starred_url":"https://api.github.com/users/graphhopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphhopper/subscriptions","organizations_url":"https://api.github.com/users/graphhopper/orgs","repos_url":"https://api.github.com/users/graphhopper/repos","events_url":"https://api.github.com/users/graphhopper/events{/privacy}","received_events_url":"https://api.github.com/users/graphhopper/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/graphhopper/geocoder-converter","description":"Converts arbitrary geocoding responses to a GraphHopper response","fork":false,"url":"https://api.github.com/repos/graphhopper/geocoder-converter","forks_url":"https://api.github.com/repos/graphhopper/geocoder-converter/forks","keys_url":"https://api.github.com/repos/graphhopper/geocoder-converter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graphhopper/geocoder-converter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graphhopper/geocoder-converter/teams","hooks_url":"https://api.github.com/repos/graphhopper/geocoder-converter/hooks","issue_events_url":"https://api.github.com/repos/graphhopper/geocoder-converter/issues/events{/number}","events_url":"https://api.github.com/repos/graphhopper/geocoder-converter/events","assignees_url":"https://api.github.com/repos/graphhopper/geocoder-converter/assignees{/user}","branches_url":"https://api.github.com/repos/graphhopper/geocoder-converter/branches{/branch}","tags_url":"https://api.github.com/repos/graphhopper/geocoder-converter/tags","blobs_url":"https://api.github.com/repos/graphhopper/geocoder-converter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graphhopper/geocoder-converter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graphhopper/geocoder-converter/git/refs{/sha}","trees_url":"https://api.github.com/repos/graphhopper/geocoder-converter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graphhopper/geocoder-converter/statuses/{sha}","languages_url":"https://api.github.com/repos/graphhopper/geocoder-converter/languages","stargazers_url":"https://api.github.com/repos/graphhopper/geocoder-converter/stargazers","contributors_url":"https://api.github.com/repos/graphhopper/geocoder-converter/contributors","subscribers_url":"https://api.github.com/repos/graphhopper/geocoder-converter/subscribers","subscription_url":"https://api.github.com/repos/graphhopper/geocoder-converter/subscription","commits_url":"https://api.github.com/repos/graphhopper/geocoder-converter/commits{/sha}","git_commits_url":"https://api.github.com/repos/graphhopper/geocoder-converter/git/commits{/sha}","comments_url":"https://api.github.com/repos/graphhopper/geocoder-converter/comments{/number}","issue_comment_url":"https://api.github.com/repos/graphhopper/geocoder-converter/issues/comments{/number}","contents_url":"https://api.github.com/repos/graphhopper/geocoder-converter/contents/{+path}","compare_url":"https://api.github.com/repos/graphhopper/geocoder-converter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graphhopper/geocoder-converter/merges","archive_url":"https://api.github.com/repos/graphhopper/geocoder-converter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graphhopper/geocoder-converter/downloads","issues_url":"https://api.github.com/repos/graphhopper/geocoder-converter/issues{/number}","pulls_url":"https://api.github.com/repos/graphhopper/geocoder-converter/pulls{/number}","milestones_url":"https://api.github.com/repos/graphhopper/geocoder-converter/milestones{/number}","notifications_url":"https://api.github.com/repos/graphhopper/geocoder-converter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graphhopper/geocoder-converter/labels{/name}","releases_url":"https://api.github.com/repos/graphhopper/geocoder-converter/releases{/id}","deployments_url":"https://api.github.com/repos/graphhopper/geocoder-converter/deployments","created_at":"2016-03-15T10:37:03Z","updated_at":"2018-01-24T14:33:41Z","pushed_at":"2018-02-16T13:07:23Z","git_url":"git://github.com/graphhopper/geocoder-converter.git","ssh_url":"git@github.com:graphhopper/geocoder-converter.git","clone_url":"https://github.com/graphhopper/geocoder-converter.git","svn_url":"https://github.com/graphhopper/geocoder-converter","homepage":"","size":75,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3,"open_issues":6,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/graphhopper/geocoder-converter/pulls/34"},"html":{"href":"https://github.com/graphhopper/geocoder-converter/pull/34"},"issue":{"href":"https://api.github.com/repos/graphhopper/geocoder-converter/issues/34"},"comments":{"href":"https://api.github.com/repos/graphhopper/geocoder-converter/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/graphhopper/geocoder-converter/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/graphhopper/geocoder-converter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/graphhopper/geocoder-converter/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/graphhopper/geocoder-converter/statuses/ebf52e3b1858d95c00eac32ac4eff2eb9a434370"}},"author_association":"NONE"}}
{"actor":{"display_login":"boldtrn"}}