{"action":"created","comment":{"url":"https://api.github.com/repos/pluginsGLPI/tag/pulls/comments/186100872","pull_request_review_id":117627701,"id":186100872,"diff_hunk":"@@ -342,11 +343,9 @@ static function updateItem(CommonDBTM $item, $options = array()) {\n       $tag      = new PluginTagTag();\n       $tag_item = new self();\n \n-      // untokenize values and create new ones\n-      $tag_values = [];\n-      if (!empty($item->input[\"_plugin_tag_tag_values\"])) {","path":"inc/tagitem.class.php","position":14,"original_position":14,"commit_id":"04cbc8153494b681a9e4fbb5f5cc00e38656f660","original_commit_id":"3590926d47645a242e64dc8bc49ec186f8bf6c0b","user":{"login":"cedric-anne","id":33253653,"avatar_url":"https://avatars1.githubusercontent.com/u/33253653?v=4","gravatar_id":"","url":"https://api.github.com/users/cedric-anne","html_url":"https://github.com/cedric-anne","followers_url":"https://api.github.com/users/cedric-anne/followers","following_url":"https://api.github.com/users/cedric-anne/following{/other_user}","gists_url":"https://api.github.com/users/cedric-anne/gists{/gist_id}","starred_url":"https://api.github.com/users/cedric-anne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedric-anne/subscriptions","organizations_url":"https://api.github.com/users/cedric-anne/orgs","repos_url":"https://api.github.com/users/cedric-anne/repos","events_url":"https://api.github.com/users/cedric-anne/events{/privacy}","received_events_url":"https://api.github.com/users/cedric-anne/received_events","type":"User","site_admin":false},"body":"I changed the input from a text input to a select multiple, so values are now passed as array instead of a chain with coma separated values. Exploding is not need anymore.","created_at":"2018-05-04T14:30:36Z","updated_at":"2018-05-04T14:30:36Z","html_url":"https://github.com/pluginsGLPI/tag/pull/41#discussion_r186100872","pull_request_url":"https://api.github.com/repos/pluginsGLPI/tag/pulls/41","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/pluginsGLPI/tag/pulls/comments/186100872"},"html":{"href":"https://github.com/pluginsGLPI/tag/pull/41#discussion_r186100872"},"pull_request":{"href":"https://api.github.com/repos/pluginsGLPI/tag/pulls/41"}},"in_reply_to_id":186099268},"pull_request":{"url":"https://api.github.com/repos/pluginsGLPI/tag/pulls/41","id":185975496,"html_url":"https://github.com/pluginsGLPI/tag/pull/41","diff_url":"https://github.com/pluginsGLPI/tag/pull/41.diff","patch_url":"https://github.com/pluginsGLPI/tag/pull/41.patch","issue_url":"https://api.github.com/repos/pluginsGLPI/tag/issues/41","number":41,"state":"open","locked":false,"title":"Add compatibility with GLPI 9.3 and fix deprecated calls","user":{"login":"cedric-anne","id":33253653,"avatar_url":"https://avatars1.githubusercontent.com/u/33253653?v=4","gravatar_id":"","url":"https://api.github.com/users/cedric-anne","html_url":"https://github.com/cedric-anne","followers_url":"https://api.github.com/users/cedric-anne/followers","following_url":"https://api.github.com/users/cedric-anne/following{/other_user}","gists_url":"https://api.github.com/users/cedric-anne/gists{/gist_id}","starred_url":"https://api.github.com/users/cedric-anne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedric-anne/subscriptions","organizations_url":"https://api.github.com/users/cedric-anne/orgs","repos_url":"https://api.github.com/users/cedric-anne/repos","events_url":"https://api.github.com/users/cedric-anne/events{/privacy}","received_events_url":"https://api.github.com/users/cedric-anne/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-04T12:54:40Z","updated_at":"2018-05-04T14:30:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a36c699ec5a3f0da23b616a7df90e052b9dfe3b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"orthagh","id":418844,"avatar_url":"https://avatars2.githubusercontent.com/u/418844?v=4","gravatar_id":"","url":"https://api.github.com/users/orthagh","html_url":"https://github.com/orthagh","followers_url":"https://api.github.com/users/orthagh/followers","following_url":"https://api.github.com/users/orthagh/following{/other_user}","gists_url":"https://api.github.com/users/orthagh/gists{/gist_id}","starred_url":"https://api.github.com/users/orthagh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orthagh/subscriptions","organizations_url":"https://api.github.com/users/orthagh/orgs","repos_url":"https://api.github.com/users/orthagh/repos","events_url":"https://api.github.com/users/orthagh/events{/privacy}","received_events_url":"https://api.github.com/users/orthagh/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pluginsGLPI/tag/pulls/41/commits","review_comments_url":"https://api.github.com/repos/pluginsGLPI/tag/pulls/41/comments","review_comment_url":"https://api.github.com/repos/pluginsGLPI/tag/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pluginsGLPI/tag/issues/41/comments","statuses_url":"https://api.github.com/repos/pluginsGLPI/tag/statuses/04cbc8153494b681a9e4fbb5f5cc00e38656f660","head":{"label":"cedric-anne:9.3/fix-compatibility","ref":"9.3/fix-compatibility","sha":"04cbc8153494b681a9e4fbb5f5cc00e38656f660","user":{"login":"cedric-anne","id":33253653,"avatar_url":"https://avatars1.githubusercontent.com/u/33253653?v=4","gravatar_id":"","url":"https://api.github.com/users/cedric-anne","html_url":"https://github.com/cedric-anne","followers_url":"https://api.github.com/users/cedric-anne/followers","following_url":"https://api.github.com/users/cedric-anne/following{/other_user}","gists_url":"https://api.github.com/users/cedric-anne/gists{/gist_id}","starred_url":"https://api.github.com/users/cedric-anne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedric-anne/subscriptions","organizations_url":"https://api.github.com/users/cedric-anne/orgs","repos_url":"https://api.github.com/users/cedric-anne/repos","events_url":"https://api.github.com/users/cedric-anne/events{/privacy}","received_events_url":"https://api.github.com/users/cedric-anne/received_events","type":"User","site_admin":false},"repo":{"id":131971584,"name":"glpi-plugin-tag","full_name":"cedric-anne/glpi-plugin-tag","owner":{"login":"cedric-anne","id":33253653,"avatar_url":"https://avatars1.githubusercontent.com/u/33253653?v=4","gravatar_id":"","url":"https://api.github.com/users/cedric-anne","html_url":"https://github.com/cedric-anne","followers_url":"https://api.github.com/users/cedric-anne/followers","following_url":"https://api.github.com/users/cedric-anne/following{/other_user}","gists_url":"https://api.github.com/users/cedric-anne/gists{/gist_id}","starred_url":"https://api.github.com/users/cedric-anne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedric-anne/subscriptions","organizations_url":"https://api.github.com/users/cedric-anne/orgs","repos_url":"https://api.github.com/users/cedric-anne/repos","events_url":"https://api.github.com/users/cedric-anne/events{/privacy}","received_events_url":"https://api.github.com/users/cedric-anne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cedric-anne/glpi-plugin-tag","description":"GLPI plugin TAG","fork":true,"url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag","forks_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/forks","keys_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/teams","hooks_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/hooks","issue_events_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/issues/events{/number}","events_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/events","assignees_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/assignees{/user}","branches_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/branches{/branch}","tags_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/tags","blobs_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/git/refs{/sha}","trees_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/statuses/{sha}","languages_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/languages","stargazers_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/stargazers","contributors_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/contributors","subscribers_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/subscribers","subscription_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/subscription","commits_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/commits{/sha}","git_commits_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/git/commits{/sha}","comments_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/comments{/number}","issue_comment_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/issues/comments{/number}","contents_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/contents/{+path}","compare_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/merges","archive_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/downloads","issues_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/issues{/number}","pulls_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/pulls{/number}","milestones_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/milestones{/number}","notifications_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/labels{/name}","releases_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/releases{/id}","deployments_url":"https://api.github.com/repos/cedric-anne/glpi-plugin-tag/deployments","created_at":"2018-05-03T09:21:14Z","updated_at":"2018-05-03T09:41:40Z","pushed_at":"2018-05-04T14:22:10Z","git_url":"git://github.com/cedric-anne/glpi-plugin-tag.git","ssh_url":"git@github.com:cedric-anne/glpi-plugin-tag.git","clone_url":"https://github.com/cedric-anne/glpi-plugin-tag.git","svn_url":"https://github.com/cedric-anne/glpi-plugin-tag","homepage":"http://www.teclib.com","size":753,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pluginsGLPI:9.3/draft","ref":"9.3/draft","sha":"9f1cba584b0ed522dd8f933aaadb6643484b2927","user":{"login":"pluginsGLPI","id":10156352,"avatar_url":"https://avatars3.githubusercontent.com/u/10156352?v=4","gravatar_id":"","url":"https://api.github.com/users/pluginsGLPI","html_url":"https://github.com/pluginsGLPI","followers_url":"https://api.github.com/users/pluginsGLPI/followers","following_url":"https://api.github.com/users/pluginsGLPI/following{/other_user}","gists_url":"https://api.github.com/users/pluginsGLPI/gists{/gist_id}","starred_url":"https://api.github.com/users/pluginsGLPI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pluginsGLPI/subscriptions","organizations_url":"https://api.github.com/users/pluginsGLPI/orgs","repos_url":"https://api.github.com/users/pluginsGLPI/repos","events_url":"https://api.github.com/users/pluginsGLPI/events{/privacy}","received_events_url":"https://api.github.com/users/pluginsGLPI/received_events","type":"Organization","site_admin":false},"repo":{"id":30525284,"name":"tag","full_name":"pluginsGLPI/tag","owner":{"login":"pluginsGLPI","id":10156352,"avatar_url":"https://avatars3.githubusercontent.com/u/10156352?v=4","gravatar_id":"","url":"https://api.github.com/users/pluginsGLPI","html_url":"https://github.com/pluginsGLPI","followers_url":"https://api.github.com/users/pluginsGLPI/followers","following_url":"https://api.github.com/users/pluginsGLPI/following{/other_user}","gists_url":"https://api.github.com/users/pluginsGLPI/gists{/gist_id}","starred_url":"https://api.github.com/users/pluginsGLPI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pluginsGLPI/subscriptions","organizations_url":"https://api.github.com/users/pluginsGLPI/orgs","repos_url":"https://api.github.com/users/pluginsGLPI/repos","events_url":"https://api.github.com/users/pluginsGLPI/events{/privacy}","received_events_url":"https://api.github.com/users/pluginsGLPI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pluginsGLPI/tag","description":"GLPI plugin TAG","fork":false,"url":"https://api.github.com/repos/pluginsGLPI/tag","forks_url":"https://api.github.com/repos/pluginsGLPI/tag/forks","keys_url":"https://api.github.com/repos/pluginsGLPI/tag/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pluginsGLPI/tag/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pluginsGLPI/tag/teams","hooks_url":"https://api.github.com/repos/pluginsGLPI/tag/hooks","issue_events_url":"https://api.github.com/repos/pluginsGLPI/tag/issues/events{/number}","events_url":"https://api.github.com/repos/pluginsGLPI/tag/events","assignees_url":"https://api.github.com/repos/pluginsGLPI/tag/assignees{/user}","branches_url":"https://api.github.com/repos/pluginsGLPI/tag/branches{/branch}","tags_url":"https://api.github.com/repos/pluginsGLPI/tag/tags","blobs_url":"https://api.github.com/repos/pluginsGLPI/tag/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pluginsGLPI/tag/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pluginsGLPI/tag/git/refs{/sha}","trees_url":"https://api.github.com/repos/pluginsGLPI/tag/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pluginsGLPI/tag/statuses/{sha}","languages_url":"https://api.github.com/repos/pluginsGLPI/tag/languages","stargazers_url":"https://api.github.com/repos/pluginsGLPI/tag/stargazers","contributors_url":"https://api.github.com/repos/pluginsGLPI/tag/contributors","subscribers_url":"https://api.github.com/repos/pluginsGLPI/tag/subscribers","subscription_url":"https://api.github.com/repos/pluginsGLPI/tag/subscription","commits_url":"https://api.github.com/repos/pluginsGLPI/tag/commits{/sha}","git_commits_url":"https://api.github.com/repos/pluginsGLPI/tag/git/commits{/sha}","comments_url":"https://api.github.com/repos/pluginsGLPI/tag/comments{/number}","issue_comment_url":"https://api.github.com/repos/pluginsGLPI/tag/issues/comments{/number}","contents_url":"https://api.github.com/repos/pluginsGLPI/tag/contents/{+path}","compare_url":"https://api.github.com/repos/pluginsGLPI/tag/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pluginsGLPI/tag/merges","archive_url":"https://api.github.com/repos/pluginsGLPI/tag/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pluginsGLPI/tag/downloads","issues_url":"https://api.github.com/repos/pluginsGLPI/tag/issues{/number}","pulls_url":"https://api.github.com/repos/pluginsGLPI/tag/pulls{/number}","milestones_url":"https://api.github.com/repos/pluginsGLPI/tag/milestones{/number}","notifications_url":"https://api.github.com/repos/pluginsGLPI/tag/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pluginsGLPI/tag/labels{/name}","releases_url":"https://api.github.com/repos/pluginsGLPI/tag/releases{/id}","deployments_url":"https://api.github.com/repos/pluginsGLPI/tag/deployments","created_at":"2015-02-09T08:12:14Z","updated_at":"2018-04-06T21:32:04Z","pushed_at":"2018-05-04T14:22:11Z","git_url":"git://github.com/pluginsGLPI/tag.git","ssh_url":"git@github.com:pluginsGLPI/tag.git","clone_url":"https://github.com/pluginsGLPI/tag.git","svn_url":"https://github.com/pluginsGLPI/tag","homepage":"http://www.teclib.com","size":752,"stargazers_count":8,"watchers_count":8,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":8,"open_issues":8,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pluginsGLPI/tag/pulls/41"},"html":{"href":"https://github.com/pluginsGLPI/tag/pull/41"},"issue":{"href":"https://api.github.com/repos/pluginsGLPI/tag/issues/41"},"comments":{"href":"https://api.github.com/repos/pluginsGLPI/tag/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/pluginsGLPI/tag/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/pluginsGLPI/tag/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pluginsGLPI/tag/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/pluginsGLPI/tag/statuses/04cbc8153494b681a9e4fbb5f5cc00e38656f660"}},"author_association":"NONE"}}
{"actor":{"display_login":"cedric-anne"}}