{"action":"created","issue":{"url":"https://api.github.com/repos/spacejam/sled/issues/222","repository_url":"https://api.github.com/repos/spacejam/sled","labels_url":"https://api.github.com/repos/spacejam/sled/issues/222/labels{/name}","comments_url":"https://api.github.com/repos/spacejam/sled/issues/222/comments","events_url":"https://api.github.com/repos/spacejam/sled/issues/222/events","html_url":"https://github.com/spacejam/sled/pull/222","id":294194054,"number":222,"title":"pagecache: Change Segment::lsn's type from Option<Lsn> to Lsn","user":{"login":"jeehoonkang","id":1201316,"avatar_url":"https://avatars0.githubusercontent.com/u/1201316?v=4","gravatar_id":"","url":"https://api.github.com/users/jeehoonkang","html_url":"https://github.com/jeehoonkang","followers_url":"https://api.github.com/users/jeehoonkang/followers","following_url":"https://api.github.com/users/jeehoonkang/following{/other_user}","gists_url":"https://api.github.com/users/jeehoonkang/gists{/gist_id}","starred_url":"https://api.github.com/users/jeehoonkang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeehoonkang/subscriptions","organizations_url":"https://api.github.com/users/jeehoonkang/orgs","repos_url":"https://api.github.com/users/jeehoonkang/repos","events_url":"https://api.github.com/users/jeehoonkang/events{/privacy}","received_events_url":"https://api.github.com/users/jeehoonkang/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-04T12:38:33Z","updated_at":"2018-02-04T13:09:04Z","closed_at":"2018-02-04T13:09:04Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/spacejam/sled/pulls/222","html_url":"https://github.com/spacejam/sled/pull/222","diff_url":"https://github.com/spacejam/sled/pull/222.diff","patch_url":"https://github.com/spacejam/sled/pull/222.patch"},"body":"Currently `Segment::lsn`'s type of `Option<Lsn>`, but it seems it can never be `None`.  So I changed its type to `Lsn`.\r\n\r\nI'm not sure it's the right thing to do: maybe `pagecache` has a plan to use `None` for `Segment::lsn` in a significant way.  Please let me know if it's the case!"},"comment":{"url":"https://api.github.com/repos/spacejam/sled/issues/comments/362905574","html_url":"https://github.com/spacejam/sled/pull/222#issuecomment-362905574","issue_url":"https://api.github.com/repos/spacejam/sled/issues/222","id":362905574,"user":{"login":"jeehoonkang","id":1201316,"avatar_url":"https://avatars0.githubusercontent.com/u/1201316?v=4","gravatar_id":"","url":"https://api.github.com/users/jeehoonkang","html_url":"https://github.com/jeehoonkang","followers_url":"https://api.github.com/users/jeehoonkang/followers","following_url":"https://api.github.com/users/jeehoonkang/following{/other_user}","gists_url":"https://api.github.com/users/jeehoonkang/gists{/gist_id}","starred_url":"https://api.github.com/users/jeehoonkang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeehoonkang/subscriptions","organizations_url":"https://api.github.com/users/jeehoonkang/orgs","repos_url":"https://api.github.com/users/jeehoonkang/repos","events_url":"https://api.github.com/users/jeehoonkang/events{/privacy}","received_events_url":"https://api.github.com/users/jeehoonkang/received_events","type":"User","site_admin":false},"created_at":"2018-02-04T13:09:04Z","updated_at":"2018-02-04T13:09:04Z","author_association":"CONTRIBUTOR","body":"I'm sorry, `Segment::default()` initializes `lsn = None`, which means the segment is not used at all.  Closing it."}}
{"actor":{"display_login":"jeehoonkang"}}