{"action":"opened","number":61,"pull_request":{"url":"https://api.github.com/repos/SkygearIO/forgot_password/pulls/61","id":221729533,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNzI5NTMz","html_url":"https://github.com/SkygearIO/forgot_password/pull/61","diff_url":"https://github.com/SkygearIO/forgot_password/pull/61.diff","patch_url":"https://github.com/SkygearIO/forgot_password/pull/61.patch","issue_url":"https://api.github.com/repos/SkygearIO/forgot_password/issues/61","number":61,"state":"open","locked":false,"title":"Should fallback to verify user error redirect if key setting is empty","user":{"login":"carmenlau","id":388892,"node_id":"MDQ6VXNlcjM4ODg5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/388892?v=4","gravatar_id":"","url":"https://api.github.com/users/carmenlau","html_url":"https://github.com/carmenlau","followers_url":"https://api.github.com/users/carmenlau/followers","following_url":"https://api.github.com/users/carmenlau/following{/other_user}","gists_url":"https://api.github.com/users/carmenlau/gists{/gist_id}","starred_url":"https://api.github.com/users/carmenlau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carmenlau/subscriptions","organizations_url":"https://api.github.com/users/carmenlau/orgs","repos_url":"https://api.github.com/users/carmenlau/repos","events_url":"https://api.github.com/users/carmenlau/events{/privacy}","received_events_url":"https://api.github.com/users/carmenlau/received_events","type":"User","site_admin":false},"body":"connect #60 \r\n\r\nCurrently when user fails to verify the code, there are 2 cases.\r\n\r\n1. The code is incorrect, so the plugin will not know which field are being verified\r\n1. The code is correct but become invalid, maybe consumed or expired. So the plugin will know which field are being verified.\r\n\r\nFor case 1, plugin used `VERIFY_ERROR_HTML_URL` and `VERIFY_ERROR_REDIRECT` for the setting.\r\n\r\nFor case 2, plugin used `VERIFY_KEYS_<FIELD_NAME>_ERROR_HTML_URL` and `VERIFY_KEYS_<FIELD_NAME>_ERROR_REDIRECT`.\r\n\r\nThere is confusion for the setting that setting `VERIFY_ERROR_REDIRECT` doesn't work when verifying email fail. The PR updates when key settings are missing. It will fallback to case 1.\r\n\r\n","created_at":"2018-10-10T10:04:56Z","updated_at":"2018-10-10T10:04:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SkygearIO/forgot_password/pulls/61/commits","review_comments_url":"https://api.github.com/repos/SkygearIO/forgot_password/pulls/61/comments","review_comment_url":"https://api.github.com/repos/SkygearIO/forgot_password/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SkygearIO/forgot_password/issues/61/comments","statuses_url":"https://api.github.com/repos/SkygearIO/forgot_password/statuses/418c3b77304b05be253e65e26bc3feed817f2e47","head":{"label":"carmenlau:fallback-verify-error-redirect","ref":"fallback-verify-error-redirect","sha":"418c3b77304b05be253e65e26bc3feed817f2e47","user":{"login":"carmenlau","id":388892,"node_id":"MDQ6VXNlcjM4ODg5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/388892?v=4","gravatar_id":"","url":"https://api.github.com/users/carmenlau","html_url":"https://github.com/carmenlau","followers_url":"https://api.github.com/users/carmenlau/followers","following_url":"https://api.github.com/users/carmenlau/following{/other_user}","gists_url":"https://api.github.com/users/carmenlau/gists{/gist_id}","starred_url":"https://api.github.com/users/carmenlau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carmenlau/subscriptions","organizations_url":"https://api.github.com/users/carmenlau/orgs","repos_url":"https://api.github.com/users/carmenlau/repos","events_url":"https://api.github.com/users/carmenlau/events{/privacy}","received_events_url":"https://api.github.com/users/carmenlau/received_events","type":"User","site_admin":false},"repo":{"id":131585779,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE1ODU3Nzk=","name":"forgot_password","full_name":"carmenlau/forgot_password","private":false,"owner":{"login":"carmenlau","id":388892,"node_id":"MDQ6VXNlcjM4ODg5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/388892?v=4","gravatar_id":"","url":"https://api.github.com/users/carmenlau","html_url":"https://github.com/carmenlau","followers_url":"https://api.github.com/users/carmenlau/followers","following_url":"https://api.github.com/users/carmenlau/following{/other_user}","gists_url":"https://api.github.com/users/carmenlau/gists{/gist_id}","starred_url":"https://api.github.com/users/carmenlau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carmenlau/subscriptions","organizations_url":"https://api.github.com/users/carmenlau/orgs","repos_url":"https://api.github.com/users/carmenlau/repos","events_url":"https://api.github.com/users/carmenlau/events{/privacy}","received_events_url":"https://api.github.com/users/carmenlau/received_events","type":"User","site_admin":false},"html_url":"https://github.com/carmenlau/forgot_password","description":null,"fork":true,"url":"https://api.github.com/repos/carmenlau/forgot_password","forks_url":"https://api.github.com/repos/carmenlau/forgot_password/forks","keys_url":"https://api.github.com/repos/carmenlau/forgot_password/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carmenlau/forgot_password/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carmenlau/forgot_password/teams","hooks_url":"https://api.github.com/repos/carmenlau/forgot_password/hooks","issue_events_url":"https://api.github.com/repos/carmenlau/forgot_password/issues/events{/number}","events_url":"https://api.github.com/repos/carmenlau/forgot_password/events","assignees_url":"https://api.github.com/repos/carmenlau/forgot_password/assignees{/user}","branches_url":"https://api.github.com/repos/carmenlau/forgot_password/branches{/branch}","tags_url":"https://api.github.com/repos/carmenlau/forgot_password/tags","blobs_url":"https://api.github.com/repos/carmenlau/forgot_password/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carmenlau/forgot_password/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carmenlau/forgot_password/git/refs{/sha}","trees_url":"https://api.github.com/repos/carmenlau/forgot_password/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carmenlau/forgot_password/statuses/{sha}","languages_url":"https://api.github.com/repos/carmenlau/forgot_password/languages","stargazers_url":"https://api.github.com/repos/carmenlau/forgot_password/stargazers","contributors_url":"https://api.github.com/repos/carmenlau/forgot_password/contributors","subscribers_url":"https://api.github.com/repos/carmenlau/forgot_password/subscribers","subscription_url":"https://api.github.com/repos/carmenlau/forgot_password/subscription","commits_url":"https://api.github.com/repos/carmenlau/forgot_password/commits{/sha}","git_commits_url":"https://api.github.com/repos/carmenlau/forgot_password/git/commits{/sha}","comments_url":"https://api.github.com/repos/carmenlau/forgot_password/comments{/number}","issue_comment_url":"https://api.github.com/repos/carmenlau/forgot_password/issues/comments{/number}","contents_url":"https://api.github.com/repos/carmenlau/forgot_password/contents/{+path}","compare_url":"https://api.github.com/repos/carmenlau/forgot_password/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carmenlau/forgot_password/merges","archive_url":"https://api.github.com/repos/carmenlau/forgot_password/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carmenlau/forgot_password/downloads","issues_url":"https://api.github.com/repos/carmenlau/forgot_password/issues{/number}","pulls_url":"https://api.github.com/repos/carmenlau/forgot_password/pulls{/number}","milestones_url":"https://api.github.com/repos/carmenlau/forgot_password/milestones{/number}","notifications_url":"https://api.github.com/repos/carmenlau/forgot_password/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carmenlau/forgot_password/labels{/name}","releases_url":"https://api.github.com/repos/carmenlau/forgot_password/releases{/id}","deployments_url":"https://api.github.com/repos/carmenlau/forgot_password/deployments","created_at":"2018-04-30T11:06:07Z","updated_at":"2018-04-30T11:06:09Z","pushed_at":"2018-10-10T09:57:02Z","git_url":"git://github.com/carmenlau/forgot_password.git","ssh_url":"git@github.com:carmenlau/forgot_password.git","clone_url":"https://github.com/carmenlau/forgot_password.git","svn_url":"https://github.com/carmenlau/forgot_password","homepage":null,"size":115,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SkygearIO:master","ref":"master","sha":"ee2ccbaddc1c649e29cd35e09fd666f170669aa9","user":{"login":"SkygearIO","id":15025887,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDI1ODg3","avatar_url":"https://avatars1.githubusercontent.com/u/15025887?v=4","gravatar_id":"","url":"https://api.github.com/users/SkygearIO","html_url":"https://github.com/SkygearIO","followers_url":"https://api.github.com/users/SkygearIO/followers","following_url":"https://api.github.com/users/SkygearIO/following{/other_user}","gists_url":"https://api.github.com/users/SkygearIO/gists{/gist_id}","starred_url":"https://api.github.com/users/SkygearIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkygearIO/subscriptions","organizations_url":"https://api.github.com/users/SkygearIO/orgs","repos_url":"https://api.github.com/users/SkygearIO/repos","events_url":"https://api.github.com/users/SkygearIO/events{/privacy}","received_events_url":"https://api.github.com/users/SkygearIO/received_events","type":"Organization","site_admin":false},"repo":{"id":67598912,"node_id":"MDEwOlJlcG9zaXRvcnk2NzU5ODkxMg==","name":"forgot_password","full_name":"SkygearIO/forgot_password","private":false,"owner":{"login":"SkygearIO","id":15025887,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDI1ODg3","avatar_url":"https://avatars1.githubusercontent.com/u/15025887?v=4","gravatar_id":"","url":"https://api.github.com/users/SkygearIO","html_url":"https://github.com/SkygearIO","followers_url":"https://api.github.com/users/SkygearIO/followers","following_url":"https://api.github.com/users/SkygearIO/following{/other_user}","gists_url":"https://api.github.com/users/SkygearIO/gists{/gist_id}","starred_url":"https://api.github.com/users/SkygearIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkygearIO/subscriptions","organizations_url":"https://api.github.com/users/SkygearIO/orgs","repos_url":"https://api.github.com/users/SkygearIO/repos","events_url":"https://api.github.com/users/SkygearIO/events{/privacy}","received_events_url":"https://api.github.com/users/SkygearIO/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SkygearIO/forgot_password","description":null,"fork":false,"url":"https://api.github.com/repos/SkygearIO/forgot_password","forks_url":"https://api.github.com/repos/SkygearIO/forgot_password/forks","keys_url":"https://api.github.com/repos/SkygearIO/forgot_password/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SkygearIO/forgot_password/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SkygearIO/forgot_password/teams","hooks_url":"https://api.github.com/repos/SkygearIO/forgot_password/hooks","issue_events_url":"https://api.github.com/repos/SkygearIO/forgot_password/issues/events{/number}","events_url":"https://api.github.com/repos/SkygearIO/forgot_password/events","assignees_url":"https://api.github.com/repos/SkygearIO/forgot_password/assignees{/user}","branches_url":"https://api.github.com/repos/SkygearIO/forgot_password/branches{/branch}","tags_url":"https://api.github.com/repos/SkygearIO/forgot_password/tags","blobs_url":"https://api.github.com/repos/SkygearIO/forgot_password/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SkygearIO/forgot_password/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SkygearIO/forgot_password/git/refs{/sha}","trees_url":"https://api.github.com/repos/SkygearIO/forgot_password/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SkygearIO/forgot_password/statuses/{sha}","languages_url":"https://api.github.com/repos/SkygearIO/forgot_password/languages","stargazers_url":"https://api.github.com/repos/SkygearIO/forgot_password/stargazers","contributors_url":"https://api.github.com/repos/SkygearIO/forgot_password/contributors","subscribers_url":"https://api.github.com/repos/SkygearIO/forgot_password/subscribers","subscription_url":"https://api.github.com/repos/SkygearIO/forgot_password/subscription","commits_url":"https://api.github.com/repos/SkygearIO/forgot_password/commits{/sha}","git_commits_url":"https://api.github.com/repos/SkygearIO/forgot_password/git/commits{/sha}","comments_url":"https://api.github.com/repos/SkygearIO/forgot_password/comments{/number}","issue_comment_url":"https://api.github.com/repos/SkygearIO/forgot_password/issues/comments{/number}","contents_url":"https://api.github.com/repos/SkygearIO/forgot_password/contents/{+path}","compare_url":"https://api.github.com/repos/SkygearIO/forgot_password/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SkygearIO/forgot_password/merges","archive_url":"https://api.github.com/repos/SkygearIO/forgot_password/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SkygearIO/forgot_password/downloads","issues_url":"https://api.github.com/repos/SkygearIO/forgot_password/issues{/number}","pulls_url":"https://api.github.com/repos/SkygearIO/forgot_password/pulls{/number}","milestones_url":"https://api.github.com/repos/SkygearIO/forgot_password/milestones{/number}","notifications_url":"https://api.github.com/repos/SkygearIO/forgot_password/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SkygearIO/forgot_password/labels{/name}","releases_url":"https://api.github.com/repos/SkygearIO/forgot_password/releases{/id}","deployments_url":"https://api.github.com/repos/SkygearIO/forgot_password/deployments","created_at":"2016-09-07T11:01:19Z","updated_at":"2018-09-04T07:02:53Z","pushed_at":"2018-09-04T07:03:36Z","git_url":"git://github.com/SkygearIO/forgot_password.git","ssh_url":"git@github.com:SkygearIO/forgot_password.git","clone_url":"https://github.com/SkygearIO/forgot_password.git","svn_url":"https://github.com/SkygearIO/forgot_password","homepage":null,"size":116,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":13,"open_issues":11,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SkygearIO/forgot_password/pulls/61"},"html":{"href":"https://github.com/SkygearIO/forgot_password/pull/61"},"issue":{"href":"https://api.github.com/repos/SkygearIO/forgot_password/issues/61"},"comments":{"href":"https://api.github.com/repos/SkygearIO/forgot_password/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/SkygearIO/forgot_password/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/SkygearIO/forgot_password/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SkygearIO/forgot_password/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/SkygearIO/forgot_password/statuses/418c3b77304b05be253e65e26bc3feed817f2e47"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":13,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"carmenlau"}}