{"action":"created","comment":{"url":"https://api.github.com/repos/calliope-project/calliope/pulls/comments/192695910","pull_request_review_id":125517822,"id":192695910,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjY5NTkxMA==","diff_hunk":"@@ -528,11 +528,31 @@ def check_model_data(model_data):\n         ]\n         if not np.all(daily_timesteps == daily_timesteps[0]):\n             model_data.attrs['allow_operate_mode'] = 0\n-            warnings.append(\n+            model_warnings.append(\n                 'Operational mode requires the same timestep resolution profile '\n                 'to be emulated on each date'\n             )\n         else:\n             model_data.attrs['allow_operate_mode'] = 1\n \n-    return model_data, comments, warnings, errors\n+    return model_data, comments, model_warnings, errors\n+\n+\n+def check_future_deprecation_warnings(model_run, model_data):\n+    \"\"\"\n+    Function for all FutureWarnings and DeprecationWarnings. Comment above each\n+    warning should specify Calliope version in which it was added, and the\n+    version in which it should be updated/removed.\n+    \"\"\"\n+\n+    # Warning that cyclic storage will default to True in 0.6.3 #\n+    # Added in 0.6.2-dev, to be removed in v0.6.3-dev\n+    if ('loc_techs_store' in model_data and\n+            not model_data.attrs.get('run.cyclic_storage', False)):\n+        warnings.warn(\n+            'Cyclic storage, a new addition in v0.6.2, currently defaults to '\n+            'False (i.e. emulating functionality prior to v0.6.2). '\n+            'From v0.6.3, cyclic storage will default to True.',\n+            FutureWarning\n+        )\n+","path":"calliope/core/preprocess/checks.py","position":252,"original_position":252,"commit_id":"79f2a8e30f231f17fb459c8796a4538e38170d7b","original_commit_id":"79f2a8e30f231f17fb459c8796a4538e38170d7b","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"blank line at end of file","created_at":"2018-06-04T10:32:40Z","updated_at":"2018-06-04T10:32:40Z","html_url":"https://github.com/calliope-project/calliope/pull/117#discussion_r192695910","pull_request_url":"https://api.github.com/repos/calliope-project/calliope/pulls/117","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/calliope-project/calliope/pulls/comments/192695910"},"html":{"href":"https://github.com/calliope-project/calliope/pull/117#discussion_r192695910"},"pull_request":{"href":"https://api.github.com/repos/calliope-project/calliope/pulls/117"}}},"pull_request":{"url":"https://api.github.com/repos/calliope-project/calliope/pulls/117","id":192061571,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMDYxNTcx","html_url":"https://github.com/calliope-project/calliope/pull/117","diff_url":"https://github.com/calliope-project/calliope/pull/117.diff","patch_url":"https://github.com/calliope-project/calliope/pull/117.patch","issue_url":"https://api.github.com/repos/calliope-project/calliope/issues/117","number":117,"state":"open","locked":false,"title":"Update where we store & check for FutureWarnings and DeprecationWarnings","user":{"login":"brynpickering","id":17178478,"node_id":"MDQ6VXNlcjE3MTc4NDc4","avatar_url":"https://avatars0.githubusercontent.com/u/17178478?v=4","gravatar_id":"","url":"https://api.github.com/users/brynpickering","html_url":"https://github.com/brynpickering","followers_url":"https://api.github.com/users/brynpickering/followers","following_url":"https://api.github.com/users/brynpickering/following{/other_user}","gists_url":"https://api.github.com/users/brynpickering/gists{/gist_id}","starred_url":"https://api.github.com/users/brynpickering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brynpickering/subscriptions","organizations_url":"https://api.github.com/users/brynpickering/orgs","repos_url":"https://api.github.com/users/brynpickering/repos","events_url":"https://api.github.com/users/brynpickering/events{/privacy}","received_events_url":"https://api.github.com/users/brynpickering/received_events","type":"User","site_admin":false},"body":"Update to un-reviewed commit d7e92f6429f15588415922b9765847ba6d9b5e0e\r\n\r\nThis PR moves the FutureWarning to a specific function, where all similar warnings should then be placed in future.\r\n\r\nReviewer checklist:\r\n\r\n~~- [ ] Test(s) added to cover contribution~~ see d7e92f6429f15588415922b9765847ba6d9b5e0e\r\n~~- [ ] Documentation updated~~\r\n~~- [ ] Changelog updated~~  see d7e92f6429f15588415922b9765847ba6d9b5e0e\r\n- [x] Coverage maintained or improved","created_at":"2018-06-01T15:04:23Z","updated_at":"2018-06-04T10:32:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b112dd0c0558aec2edb14e54959d42dbed9c9a8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/calliope-project/calliope/pulls/117/commits","review_comments_url":"https://api.github.com/repos/calliope-project/calliope/pulls/117/comments","review_comment_url":"https://api.github.com/repos/calliope-project/calliope/pulls/comments{/number}","comments_url":"https://api.github.com/repos/calliope-project/calliope/issues/117/comments","statuses_url":"https://api.github.com/repos/calliope-project/calliope/statuses/79f2a8e30f231f17fb459c8796a4538e38170d7b","head":{"label":"calliope-project:implement_futurewarnings","ref":"implement_futurewarnings","sha":"79f2a8e30f231f17fb459c8796a4538e38170d7b","user":{"login":"calliope-project","id":10073020,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDczMDIw","avatar_url":"https://avatars2.githubusercontent.com/u/10073020?v=4","gravatar_id":"","url":"https://api.github.com/users/calliope-project","html_url":"https://github.com/calliope-project","followers_url":"https://api.github.com/users/calliope-project/followers","following_url":"https://api.github.com/users/calliope-project/following{/other_user}","gists_url":"https://api.github.com/users/calliope-project/gists{/gist_id}","starred_url":"https://api.github.com/users/calliope-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calliope-project/subscriptions","organizations_url":"https://api.github.com/users/calliope-project/orgs","repos_url":"https://api.github.com/users/calliope-project/repos","events_url":"https://api.github.com/users/calliope-project/events{/privacy}","received_events_url":"https://api.github.com/users/calliope-project/received_events","type":"Organization","site_admin":false},"repo":{"id":12930335,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkzMDMzNQ==","name":"calliope","full_name":"calliope-project/calliope","owner":{"login":"calliope-project","id":10073020,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDczMDIw","avatar_url":"https://avatars2.githubusercontent.com/u/10073020?v=4","gravatar_id":"","url":"https://api.github.com/users/calliope-project","html_url":"https://github.com/calliope-project","followers_url":"https://api.github.com/users/calliope-project/followers","following_url":"https://api.github.com/users/calliope-project/following{/other_user}","gists_url":"https://api.github.com/users/calliope-project/gists{/gist_id}","starred_url":"https://api.github.com/users/calliope-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calliope-project/subscriptions","organizations_url":"https://api.github.com/users/calliope-project/orgs","repos_url":"https://api.github.com/users/calliope-project/repos","events_url":"https://api.github.com/users/calliope-project/events{/privacy}","received_events_url":"https://api.github.com/users/calliope-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/calliope-project/calliope","description":"A multi-scale energy systems modelling framework","fork":false,"url":"https://api.github.com/repos/calliope-project/calliope","forks_url":"https://api.github.com/repos/calliope-project/calliope/forks","keys_url":"https://api.github.com/repos/calliope-project/calliope/keys{/key_id}","collaborators_url":"https://api.github.com/repos/calliope-project/calliope/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/calliope-project/calliope/teams","hooks_url":"https://api.github.com/repos/calliope-project/calliope/hooks","issue_events_url":"https://api.github.com/repos/calliope-project/calliope/issues/events{/number}","events_url":"https://api.github.com/repos/calliope-project/calliope/events","assignees_url":"https://api.github.com/repos/calliope-project/calliope/assignees{/user}","branches_url":"https://api.github.com/repos/calliope-project/calliope/branches{/branch}","tags_url":"https://api.github.com/repos/calliope-project/calliope/tags","blobs_url":"https://api.github.com/repos/calliope-project/calliope/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/calliope-project/calliope/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/calliope-project/calliope/git/refs{/sha}","trees_url":"https://api.github.com/repos/calliope-project/calliope/git/trees{/sha}","statuses_url":"https://api.github.com/repos/calliope-project/calliope/statuses/{sha}","languages_url":"https://api.github.com/repos/calliope-project/calliope/languages","stargazers_url":"https://api.github.com/repos/calliope-project/calliope/stargazers","contributors_url":"https://api.github.com/repos/calliope-project/calliope/contributors","subscribers_url":"https://api.github.com/repos/calliope-project/calliope/subscribers","subscription_url":"https://api.github.com/repos/calliope-project/calliope/subscription","commits_url":"https://api.github.com/repos/calliope-project/calliope/commits{/sha}","git_commits_url":"https://api.github.com/repos/calliope-project/calliope/git/commits{/sha}","comments_url":"https://api.github.com/repos/calliope-project/calliope/comments{/number}","issue_comment_url":"https://api.github.com/repos/calliope-project/calliope/issues/comments{/number}","contents_url":"https://api.github.com/repos/calliope-project/calliope/contents/{+path}","compare_url":"https://api.github.com/repos/calliope-project/calliope/compare/{base}...{head}","merges_url":"https://api.github.com/repos/calliope-project/calliope/merges","archive_url":"https://api.github.com/repos/calliope-project/calliope/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/calliope-project/calliope/downloads","issues_url":"https://api.github.com/repos/calliope-project/calliope/issues{/number}","pulls_url":"https://api.github.com/repos/calliope-project/calliope/pulls{/number}","milestones_url":"https://api.github.com/repos/calliope-project/calliope/milestones{/number}","notifications_url":"https://api.github.com/repos/calliope-project/calliope/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/calliope-project/calliope/labels{/name}","releases_url":"https://api.github.com/repos/calliope-project/calliope/releases{/id}","deployments_url":"https://api.github.com/repos/calliope-project/calliope/deployments","created_at":"2013-09-18T17:58:41Z","updated_at":"2018-06-04T09:30:37Z","pushed_at":"2018-06-04T10:32:34Z","git_url":"git://github.com/calliope-project/calliope.git","ssh_url":"git@github.com:calliope-project/calliope.git","clone_url":"https://github.com/calliope-project/calliope.git","svn_url":"https://github.com/calliope-project/calliope","homepage":"https://www.callio.pe/","size":31553,"stargazers_count":43,"watchers_count":43,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":16,"open_issues":23,"watchers":43,"default_branch":"master"}},"base":{"label":"calliope-project:master","ref":"master","sha":"3cb29ee6d42918c449f81da6fbbcbd72453c4487","user":{"login":"calliope-project","id":10073020,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDczMDIw","avatar_url":"https://avatars2.githubusercontent.com/u/10073020?v=4","gravatar_id":"","url":"https://api.github.com/users/calliope-project","html_url":"https://github.com/calliope-project","followers_url":"https://api.github.com/users/calliope-project/followers","following_url":"https://api.github.com/users/calliope-project/following{/other_user}","gists_url":"https://api.github.com/users/calliope-project/gists{/gist_id}","starred_url":"https://api.github.com/users/calliope-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calliope-project/subscriptions","organizations_url":"https://api.github.com/users/calliope-project/orgs","repos_url":"https://api.github.com/users/calliope-project/repos","events_url":"https://api.github.com/users/calliope-project/events{/privacy}","received_events_url":"https://api.github.com/users/calliope-project/received_events","type":"Organization","site_admin":false},"repo":{"id":12930335,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkzMDMzNQ==","name":"calliope","full_name":"calliope-project/calliope","owner":{"login":"calliope-project","id":10073020,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDczMDIw","avatar_url":"https://avatars2.githubusercontent.com/u/10073020?v=4","gravatar_id":"","url":"https://api.github.com/users/calliope-project","html_url":"https://github.com/calliope-project","followers_url":"https://api.github.com/users/calliope-project/followers","following_url":"https://api.github.com/users/calliope-project/following{/other_user}","gists_url":"https://api.github.com/users/calliope-project/gists{/gist_id}","starred_url":"https://api.github.com/users/calliope-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calliope-project/subscriptions","organizations_url":"https://api.github.com/users/calliope-project/orgs","repos_url":"https://api.github.com/users/calliope-project/repos","events_url":"https://api.github.com/users/calliope-project/events{/privacy}","received_events_url":"https://api.github.com/users/calliope-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/calliope-project/calliope","description":"A multi-scale energy systems modelling framework","fork":false,"url":"https://api.github.com/repos/calliope-project/calliope","forks_url":"https://api.github.com/repos/calliope-project/calliope/forks","keys_url":"https://api.github.com/repos/calliope-project/calliope/keys{/key_id}","collaborators_url":"https://api.github.com/repos/calliope-project/calliope/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/calliope-project/calliope/teams","hooks_url":"https://api.github.com/repos/calliope-project/calliope/hooks","issue_events_url":"https://api.github.com/repos/calliope-project/calliope/issues/events{/number}","events_url":"https://api.github.com/repos/calliope-project/calliope/events","assignees_url":"https://api.github.com/repos/calliope-project/calliope/assignees{/user}","branches_url":"https://api.github.com/repos/calliope-project/calliope/branches{/branch}","tags_url":"https://api.github.com/repos/calliope-project/calliope/tags","blobs_url":"https://api.github.com/repos/calliope-project/calliope/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/calliope-project/calliope/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/calliope-project/calliope/git/refs{/sha}","trees_url":"https://api.github.com/repos/calliope-project/calliope/git/trees{/sha}","statuses_url":"https://api.github.com/repos/calliope-project/calliope/statuses/{sha}","languages_url":"https://api.github.com/repos/calliope-project/calliope/languages","stargazers_url":"https://api.github.com/repos/calliope-project/calliope/stargazers","contributors_url":"https://api.github.com/repos/calliope-project/calliope/contributors","subscribers_url":"https://api.github.com/repos/calliope-project/calliope/subscribers","subscription_url":"https://api.github.com/repos/calliope-project/calliope/subscription","commits_url":"https://api.github.com/repos/calliope-project/calliope/commits{/sha}","git_commits_url":"https://api.github.com/repos/calliope-project/calliope/git/commits{/sha}","comments_url":"https://api.github.com/repos/calliope-project/calliope/comments{/number}","issue_comment_url":"https://api.github.com/repos/calliope-project/calliope/issues/comments{/number}","contents_url":"https://api.github.com/repos/calliope-project/calliope/contents/{+path}","compare_url":"https://api.github.com/repos/calliope-project/calliope/compare/{base}...{head}","merges_url":"https://api.github.com/repos/calliope-project/calliope/merges","archive_url":"https://api.github.com/repos/calliope-project/calliope/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/calliope-project/calliope/downloads","issues_url":"https://api.github.com/repos/calliope-project/calliope/issues{/number}","pulls_url":"https://api.github.com/repos/calliope-project/calliope/pulls{/number}","milestones_url":"https://api.github.com/repos/calliope-project/calliope/milestones{/number}","notifications_url":"https://api.github.com/repos/calliope-project/calliope/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/calliope-project/calliope/labels{/name}","releases_url":"https://api.github.com/repos/calliope-project/calliope/releases{/id}","deployments_url":"https://api.github.com/repos/calliope-project/calliope/deployments","created_at":"2013-09-18T17:58:41Z","updated_at":"2018-06-04T09:30:37Z","pushed_at":"2018-06-04T10:32:34Z","git_url":"git://github.com/calliope-project/calliope.git","ssh_url":"git@github.com:calliope-project/calliope.git","clone_url":"https://github.com/calliope-project/calliope.git","svn_url":"https://github.com/calliope-project/calliope","homepage":"https://www.callio.pe/","size":31553,"stargazers_count":43,"watchers_count":43,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":16,"open_issues":23,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/calliope-project/calliope/pulls/117"},"html":{"href":"https://github.com/calliope-project/calliope/pull/117"},"issue":{"href":"https://api.github.com/repos/calliope-project/calliope/issues/117"},"comments":{"href":"https://api.github.com/repos/calliope-project/calliope/issues/117/comments"},"review_comments":{"href":"https://api.github.com/repos/calliope-project/calliope/pulls/117/comments"},"review_comment":{"href":"https://api.github.com/repos/calliope-project/calliope/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/calliope-project/calliope/pulls/117/commits"},"statuses":{"href":"https://api.github.com/repos/calliope-project/calliope/statuses/79f2a8e30f231f17fb459c8796a4538e38170d7b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"houndci-bot"}}