{"action":"created","issue":{"url":"https://api.github.com/repos/openfoodfacts/openfoodfacts-androidapp/issues/1299","repository_url":"https://api.github.com/repos/openfoodfacts/openfoodfacts-androidapp","labels_url":"https://api.github.com/repos/openfoodfacts/openfoodfacts-androidapp/issues/1299/labels{/name}","comments_url":"https://api.github.com/repos/openfoodfacts/openfoodfacts-androidapp/issues/1299/comments","events_url":"https://api.github.com/repos/openfoodfacts/openfoodfacts-androidapp/issues/1299/events","html_url":"https://github.com/openfoodfacts/openfoodfacts-androidapp/pull/1299","id":307090370,"number":1299,"title":"Fixed #517: Splash screen fix for Open Food Facts","user":{"login":"amanjeetsingh150","id":12881364,"avatar_url":"https://avatars0.githubusercontent.com/u/12881364?v=4","gravatar_id":"","url":"https://api.github.com/users/amanjeetsingh150","html_url":"https://github.com/amanjeetsingh150","followers_url":"https://api.github.com/users/amanjeetsingh150/followers","following_url":"https://api.github.com/users/amanjeetsingh150/following{/other_user}","gists_url":"https://api.github.com/users/amanjeetsingh150/gists{/gist_id}","starred_url":"https://api.github.com/users/amanjeetsingh150/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amanjeetsingh150/subscriptions","organizations_url":"https://api.github.com/users/amanjeetsingh150/orgs","repos_url":"https://api.github.com/users/amanjeetsingh150/repos","events_url":"https://api.github.com/users/amanjeetsingh150/events{/privacy}","received_events_url":"https://api.github.com/users/amanjeetsingh150/received_events","type":"User","site_admin":false},"labels":[{"id":842893174,"url":"https://api.github.com/repos/openfoodfacts/openfoodfacts-androidapp/labels/splash%20screen","name":"splash screen","color":"1e7507","default":false},{"id":510463605,"url":"https://api.github.com/repos/openfoodfacts/openfoodfacts-androidapp/labels/ux","name":"ux","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2018-03-21T01:00:09Z","updated_at":"2018-03-26T17:12:09Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openfoodfacts/openfoodfacts-androidapp/pulls/1299","html_url":"https://github.com/openfoodfacts/openfoodfacts-androidapp/pull/1299","diff_url":"https://github.com/openfoodfacts/openfoodfacts-androidapp/pull/1299.diff","patch_url":"https://github.com/openfoodfacts/openfoodfacts-androidapp/pull/1299.patch"},"body":"## Description\r\n\r\nThe splash screen logo was broken at some phones as already mentioned in the issue. So I spent some time searching and reading articles about making splash screen properly for android apps. Then I discovered about something called 9 Patch PNGs from here which stretch good for all resolutions:<br>\r\nhttps://medium.com/@101/splash-screen-in-android-769d3b0bafd0\r\nI went for the tool provided by Google to produce 9 patch images of the logo instead the one we were previously using and included them. And used them accordingly.\r\n\r\n## Related issues and discussion\r\n#517 \r\n \r\n ## Screen-shots, if any\r\nOutputs for 2 phones\r\n1. MOTO E Android Version 5.1\r\n<b>This was before:</b>\r\n<img src=\"https://user-images.githubusercontent.com/12881364/37690254-c4b10422-2ccf-11e8-8585-5064d7456d26.png\" height=\"600\"/>\r\n<br>\r\n<b>This was after:</b>\r\n<img src=\"https://user-images.githubusercontent.com/12881364/37690290-ef6bba86-2ccf-11e8-82eb-ca3b661d1f96.png\" height=\"600\"/>\r\n2. XIOMI MI Redmi Note 2 Android 5.0.2\r\n<b>Before:</b>\r\n<img src=\"https://user-images.githubusercontent.com/12881364/37690368-76029f06-2cd0-11e8-991b-67636e1cc940.png\" height=\"600\">\r\n<br>\r\n<b>After:</b>\r\n<img src=\"https://user-images.githubusercontent.com/12881364/37690403-ac7d3492-2cd0-11e8-947f-4c43cff88f0b.png\" height=\"600\">\r\n<br>\r\nI have tested this for all devices available at my home. Do tell me if any more optimization needs to be done.\r\n\r\n<b>I have done this for Open Food Facts flavor till now. If it convinces all the mentors I will send quick PR for other flavors too</b>\r\nThanks.\r\n \r\n "},"comment":{"url":"https://api.github.com/repos/openfoodfacts/openfoodfacts-androidapp/issues/comments/376241355","html_url":"https://github.com/openfoodfacts/openfoodfacts-androidapp/pull/1299#issuecomment-376241355","issue_url":"https://api.github.com/repos/openfoodfacts/openfoodfacts-androidapp/issues/1299","id":376241355,"user":{"login":"amanjeetsingh150","id":12881364,"avatar_url":"https://avatars0.githubusercontent.com/u/12881364?v=4","gravatar_id":"","url":"https://api.github.com/users/amanjeetsingh150","html_url":"https://github.com/amanjeetsingh150","followers_url":"https://api.github.com/users/amanjeetsingh150/followers","following_url":"https://api.github.com/users/amanjeetsingh150/following{/other_user}","gists_url":"https://api.github.com/users/amanjeetsingh150/gists{/gist_id}","starred_url":"https://api.github.com/users/amanjeetsingh150/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amanjeetsingh150/subscriptions","organizations_url":"https://api.github.com/users/amanjeetsingh150/orgs","repos_url":"https://api.github.com/users/amanjeetsingh150/repos","events_url":"https://api.github.com/users/amanjeetsingh150/events{/privacy}","received_events_url":"https://api.github.com/users/amanjeetsingh150/received_events","type":"User","site_admin":false},"created_at":"2018-03-26T17:12:09Z","updated_at":"2018-03-26T17:12:09Z","author_association":"CONTRIBUTOR","body":"@Karljoones should I close this and send new PR for this?"}}
{"actor":{"display_login":"amanjeetsingh150"}}