{"action":"created","issue":{"url":"https://api.github.com/repos/ConsenSys/mythril-classic/issues/737","repository_url":"https://api.github.com/repos/ConsenSys/mythril-classic","labels_url":"https://api.github.com/repos/ConsenSys/mythril-classic/issues/737/labels{/name}","comments_url":"https://api.github.com/repos/ConsenSys/mythril-classic/issues/737/comments","events_url":"https://api.github.com/repos/ConsenSys/mythril-classic/issues/737/events","html_url":"https://github.com/ConsenSys/mythril-classic/issues/737","id":382961624,"node_id":"MDU6SXNzdWUzODI5NjE2MjQ=","number":737,"title":"Increase max_depth during constructor execution","user":{"login":"b-mueller","id":5194767,"node_id":"MDQ6VXNlcjUxOTQ3Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/5194767?v=4","gravatar_id":"","url":"https://api.github.com/users/b-mueller","html_url":"https://github.com/b-mueller","followers_url":"https://api.github.com/users/b-mueller/followers","following_url":"https://api.github.com/users/b-mueller/following{/other_user}","gists_url":"https://api.github.com/users/b-mueller/gists{/gist_id}","starred_url":"https://api.github.com/users/b-mueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b-mueller/subscriptions","organizations_url":"https://api.github.com/users/b-mueller/orgs","repos_url":"https://api.github.com/users/b-mueller/repos","events_url":"https://api.github.com/users/b-mueller/events{/privacy}","received_events_url":"https://api.github.com/users/b-mueller/received_events","type":"User","site_admin":false},"labels":[{"id":1124610938,"node_id":"MDU6TGFiZWwxMTI0NjEwOTM4","url":"https://api.github.com/repos/ConsenSys/mythril-classic/labels/Priority:%20Medium","name":"Priority: Medium","color":"fbca04","default":false},{"id":695308629,"node_id":"MDU6TGFiZWw2OTUzMDg2Mjk=","url":"https://api.github.com/repos/ConsenSys/mythril-classic/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-21T05:30:41Z","updated_at":"2018-11-22T11:40:30Z","closed_at":null,"author_association":"MEMBER","body":"## Description\r\n\r\nA low max-depth setting can result in no contract being created.\r\n\r\n## Background\r\n\r\nFor some contracts such as BECToken the default max-depth is insufficient:\r\n\r\n```\r\n$ myth -x BECToken.sol:BecToken -v1\r\nroot[22918] INFO Using INFURA for RPC queries\r\nroot[22918] INFO LASER EVM initialized with dynamic loader: <mythril.support.loader.DynLoader object at 0x109de3048>\r\nroot[22918] INFO Found 0 detection modules\r\nroot[22918] INFO Starting contract creation transaction\r\nroot[22918] INFO Finished contract creation, found 0 open states\r\nroot[22918] WARNING No contract was created during the execution of contract creation Increase the resources for creation execution (--max-depth or --create-timeout)\r\nroot[22918] INFO Starting message call transaction, iteration: 0\r\nroot[22918] INFO Number of new instructions covered in tx 0: 0\r\nroot[22918] INFO Starting message call transaction, iteration: 1\r\nroot[22918] INFO Number of new instructions covered in tx 1: 0\r\nroot[22918] INFO Finished symbolic execution\r\nroot[22918] INFO 23 nodes, 22 edges, 357 total states\r\nroot[22918] INFO Starting analysis\r\nroot[22918] INFO Found 11 detection modules\r\nroot[22918] INFO Executing DELEGATECALL Usage in Fallback Function\r\nroot[22918] INFO Executing Dependence of Predictable Variables\r\nroot[22918] INFO Executing Deprecated Operations\r\nroot[22918] INFO Executing Ether Thief\r\nroot[22918] INFO Executing Reachable Exceptions\r\nroot[22918] INFO Executing External Calls\r\nroot[22918] INFO Executing Integer Overflow and Underflow\r\nroot[22918] INFO Executing Multiple Sends\r\nroot[22918] INFO Executing Unprotected Suicide\r\nroot[22918] INFO Executing Transaction Order Dependence\r\nroot[22918] INFO Executing Unchecked Return Value\r\nThe analysis was completed successfully. No issues were detected.\r\n```\r\n\r\nIt works if `--max-depth` is set to 32, but this makes the main analysis run take very long.\r\n\r\nI propose setting `max_depth` to a high fixed value (e.g. 64) for the contract creation transaction instead of using the user-provided value."},"comment":{"url":"https://api.github.com/repos/ConsenSys/mythril-classic/issues/comments/441004169","html_url":"https://github.com/ConsenSys/mythril-classic/issues/737#issuecomment-441004169","issue_url":"https://api.github.com/repos/ConsenSys/mythril-classic/issues/737","id":441004169,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTAwNDE2OQ==","user":{"login":"JoranHonig","id":8710366,"node_id":"MDQ6VXNlcjg3MTAzNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/8710366?v=4","gravatar_id":"","url":"https://api.github.com/users/JoranHonig","html_url":"https://github.com/JoranHonig","followers_url":"https://api.github.com/users/JoranHonig/followers","following_url":"https://api.github.com/users/JoranHonig/following{/other_user}","gists_url":"https://api.github.com/users/JoranHonig/gists{/gist_id}","starred_url":"https://api.github.com/users/JoranHonig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoranHonig/subscriptions","organizations_url":"https://api.github.com/users/JoranHonig/orgs","repos_url":"https://api.github.com/users/JoranHonig/repos","events_url":"https://api.github.com/users/JoranHonig/events{/privacy}","received_events_url":"https://api.github.com/users/JoranHonig/received_events","type":"User","site_admin":false},"created_at":"2018-11-22T11:40:30Z","updated_at":"2018-11-22T11:40:30Z","author_association":"COLLABORATOR","body":"How about using `max(max_depth, 64)`. So the user can still add more if necessary"}}
{"actor":{"display_login":"JoranHonig"}}