{"action":"created","comment":{"url":"https://api.github.com/repos/uber/react-vis/pulls/comments/201543957","pull_request_review_id":136066419,"id":201543957,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTU0Mzk1Nw==","diff_hunk":"@@ -8,6 +8,9 @@ Object.keys(document.defaultView).forEach(function mapProperties(property) {\n     global[property] = document.defaultView[property];\n   }\n });\n+console.error = (message) => {","path":"tests/setup.js","position":4,"original_position":4,"commit_id":"bbfe2e6448ecc81ca67e4ed6f84075f2c41fbc87","original_commit_id":"bbfe2e6448ecc81ca67e4ed6f84075f2c41fbc87","user":{"login":"benshope","id":3506088,"node_id":"MDQ6VXNlcjM1MDYwODg=","avatar_url":"https://avatars1.githubusercontent.com/u/3506088?v=4","gravatar_id":"","url":"https://api.github.com/users/benshope","html_url":"https://github.com/benshope","followers_url":"https://api.github.com/users/benshope/followers","following_url":"https://api.github.com/users/benshope/following{/other_user}","gists_url":"https://api.github.com/users/benshope/gists{/gist_id}","starred_url":"https://api.github.com/users/benshope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benshope/subscriptions","organizations_url":"https://api.github.com/users/benshope/orgs","repos_url":"https://api.github.com/users/benshope/repos","events_url":"https://api.github.com/users/benshope/events{/privacy}","received_events_url":"https://api.github.com/users/benshope/received_events","type":"User","site_admin":false},"body":"this only works on React 16 for this specific bug, but it catches others","created_at":"2018-07-11T01:41:35Z","updated_at":"2018-07-11T01:41:35Z","html_url":"https://github.com/uber/react-vis/pull/867#discussion_r201543957","pull_request_url":"https://api.github.com/repos/uber/react-vis/pulls/867","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/uber/react-vis/pulls/comments/201543957"},"html":{"href":"https://github.com/uber/react-vis/pull/867#discussion_r201543957"},"pull_request":{"href":"https://api.github.com/repos/uber/react-vis/pulls/867"}}},"pull_request":{"url":"https://api.github.com/repos/uber/react-vis/pulls/867","id":200533593,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNTMzNTkz","html_url":"https://github.com/uber/react-vis/pull/867","diff_url":"https://github.com/uber/react-vis/pull/867.diff","patch_url":"https://github.com/uber/react-vis/pull/867.patch","issue_url":"https://api.github.com/repos/uber/react-vis/issues/867","number":867,"state":"open","locked":false,"title":"Fix(ReactVis): Stop Setting Refs On Stateless Components","user":{"login":"benshope","id":3506088,"node_id":"MDQ6VXNlcjM1MDYwODg=","avatar_url":"https://avatars1.githubusercontent.com/u/3506088?v=4","gravatar_id":"","url":"https://api.github.com/users/benshope","html_url":"https://github.com/benshope","followers_url":"https://api.github.com/users/benshope/followers","following_url":"https://api.github.com/users/benshope/following{/other_user}","gists_url":"https://api.github.com/users/benshope/gists{/gist_id}","starred_url":"https://api.github.com/users/benshope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benshope/subscriptions","organizations_url":"https://api.github.com/users/benshope/orgs","repos_url":"https://api.github.com/users/benshope/repos","events_url":"https://api.github.com/users/benshope/events{/privacy}","received_events_url":"https://api.github.com/users/benshope/received_events","type":"User","site_admin":false},"body":"00ffe61 tries to set the `ref` attribute on stateless components - which causes loads of console errors.  This fix only sets the `ref` attribute on components which were previously receiving it.\r\n\r\n#861","created_at":"2018-07-10T21:50:25Z","updated_at":"2018-07-11T01:41:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c496fa259caab3f791ef78ba9c689cc8a2805cc9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/uber/react-vis/pulls/867/commits","review_comments_url":"https://api.github.com/repos/uber/react-vis/pulls/867/comments","review_comment_url":"https://api.github.com/repos/uber/react-vis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/react-vis/issues/867/comments","statuses_url":"https://api.github.com/repos/uber/react-vis/statuses/bbfe2e6448ecc81ca67e4ed6f84075f2c41fbc87","head":{"label":"uber:fix_stateless_ref_error","ref":"fix_stateless_ref_error","sha":"bbfe2e6448ecc81ca67e4ed6f84075f2c41fbc87","user":{"login":"uber","id":538264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":52304362,"node_id":"MDEwOlJlcG9zaXRvcnk1MjMwNDM2Mg==","name":"react-vis","full_name":"uber/react-vis","owner":{"login":"uber","id":538264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/react-vis","description":"Data-Visualization oriented components","fork":false,"url":"https://api.github.com/repos/uber/react-vis","forks_url":"https://api.github.com/repos/uber/react-vis/forks","keys_url":"https://api.github.com/repos/uber/react-vis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/react-vis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/react-vis/teams","hooks_url":"https://api.github.com/repos/uber/react-vis/hooks","issue_events_url":"https://api.github.com/repos/uber/react-vis/issues/events{/number}","events_url":"https://api.github.com/repos/uber/react-vis/events","assignees_url":"https://api.github.com/repos/uber/react-vis/assignees{/user}","branches_url":"https://api.github.com/repos/uber/react-vis/branches{/branch}","tags_url":"https://api.github.com/repos/uber/react-vis/tags","blobs_url":"https://api.github.com/repos/uber/react-vis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/react-vis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/react-vis/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/react-vis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/react-vis/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/react-vis/languages","stargazers_url":"https://api.github.com/repos/uber/react-vis/stargazers","contributors_url":"https://api.github.com/repos/uber/react-vis/contributors","subscribers_url":"https://api.github.com/repos/uber/react-vis/subscribers","subscription_url":"https://api.github.com/repos/uber/react-vis/subscription","commits_url":"https://api.github.com/repos/uber/react-vis/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/react-vis/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/react-vis/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/react-vis/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/react-vis/contents/{+path}","compare_url":"https://api.github.com/repos/uber/react-vis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/react-vis/merges","archive_url":"https://api.github.com/repos/uber/react-vis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/react-vis/downloads","issues_url":"https://api.github.com/repos/uber/react-vis/issues{/number}","pulls_url":"https://api.github.com/repos/uber/react-vis/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/react-vis/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/react-vis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/react-vis/labels{/name}","releases_url":"https://api.github.com/repos/uber/react-vis/releases{/id}","deployments_url":"https://api.github.com/repos/uber/react-vis/deployments","created_at":"2016-02-22T20:45:50Z","updated_at":"2018-07-11T01:36:03Z","pushed_at":"2018-07-11T01:38:59Z","git_url":"git://github.com/uber/react-vis.git","ssh_url":"git@github.com:uber/react-vis.git","clone_url":"https://github.com/uber/react-vis.git","svn_url":"https://github.com/uber/react-vis","homepage":"https://uber.github.io/react-vis","size":13154,"stargazers_count":3871,"watchers_count":3871,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":341,"mirror_url":null,"archived":false,"open_issues_count":92,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":341,"open_issues":92,"watchers":3871,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"3bb38c992c28c5947dc8148aa4eb000607881f6d","user":{"login":"uber","id":538264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":52304362,"node_id":"MDEwOlJlcG9zaXRvcnk1MjMwNDM2Mg==","name":"react-vis","full_name":"uber/react-vis","owner":{"login":"uber","id":538264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/react-vis","description":"Data-Visualization oriented components","fork":false,"url":"https://api.github.com/repos/uber/react-vis","forks_url":"https://api.github.com/repos/uber/react-vis/forks","keys_url":"https://api.github.com/repos/uber/react-vis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/react-vis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/react-vis/teams","hooks_url":"https://api.github.com/repos/uber/react-vis/hooks","issue_events_url":"https://api.github.com/repos/uber/react-vis/issues/events{/number}","events_url":"https://api.github.com/repos/uber/react-vis/events","assignees_url":"https://api.github.com/repos/uber/react-vis/assignees{/user}","branches_url":"https://api.github.com/repos/uber/react-vis/branches{/branch}","tags_url":"https://api.github.com/repos/uber/react-vis/tags","blobs_url":"https://api.github.com/repos/uber/react-vis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/react-vis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/react-vis/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/react-vis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/react-vis/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/react-vis/languages","stargazers_url":"https://api.github.com/repos/uber/react-vis/stargazers","contributors_url":"https://api.github.com/repos/uber/react-vis/contributors","subscribers_url":"https://api.github.com/repos/uber/react-vis/subscribers","subscription_url":"https://api.github.com/repos/uber/react-vis/subscription","commits_url":"https://api.github.com/repos/uber/react-vis/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/react-vis/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/react-vis/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/react-vis/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/react-vis/contents/{+path}","compare_url":"https://api.github.com/repos/uber/react-vis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/react-vis/merges","archive_url":"https://api.github.com/repos/uber/react-vis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/react-vis/downloads","issues_url":"https://api.github.com/repos/uber/react-vis/issues{/number}","pulls_url":"https://api.github.com/repos/uber/react-vis/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/react-vis/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/react-vis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/react-vis/labels{/name}","releases_url":"https://api.github.com/repos/uber/react-vis/releases{/id}","deployments_url":"https://api.github.com/repos/uber/react-vis/deployments","created_at":"2016-02-22T20:45:50Z","updated_at":"2018-07-11T01:36:03Z","pushed_at":"2018-07-11T01:38:59Z","git_url":"git://github.com/uber/react-vis.git","ssh_url":"git@github.com:uber/react-vis.git","clone_url":"https://github.com/uber/react-vis.git","svn_url":"https://github.com/uber/react-vis","homepage":"https://uber.github.io/react-vis","size":13154,"stargazers_count":3871,"watchers_count":3871,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":341,"mirror_url":null,"archived":false,"open_issues_count":92,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":341,"open_issues":92,"watchers":3871,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/react-vis/pulls/867"},"html":{"href":"https://github.com/uber/react-vis/pull/867"},"issue":{"href":"https://api.github.com/repos/uber/react-vis/issues/867"},"comments":{"href":"https://api.github.com/repos/uber/react-vis/issues/867/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/react-vis/pulls/867/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/react-vis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/react-vis/pulls/867/commits"},"statuses":{"href":"https://api.github.com/repos/uber/react-vis/statuses/bbfe2e6448ecc81ca67e4ed6f84075f2c41fbc87"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"benshope"}}