{"action":"closed","number":143,"pull_request":{"url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/pulls/143","id":201247771,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMjQ3Nzcx","html_url":"https://github.com/poanetwork/poa-network-consensus-contracts/pull/143","diff_url":"https://github.com/poanetwork/poa-network-consensus-contracts/pull/143.diff","patch_url":"https://github.com/poanetwork/poa-network-consensus-contracts/pull/143.patch","issue_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/issues/143","number":143,"state":"closed","locked":false,"title":"(Fix) Add keeping of RewardByBlock and VotingToManageEmissionFunds addresses to ProxyStorage","user":{"login":"varasev","id":33550681,"node_id":"MDQ6VXNlcjMzNTUwNjgx","avatar_url":"https://avatars1.githubusercontent.com/u/33550681?v=4","gravatar_id":"","url":"https://api.github.com/users/varasev","html_url":"https://github.com/varasev","followers_url":"https://api.github.com/users/varasev/followers","following_url":"https://api.github.com/users/varasev/following{/other_user}","gists_url":"https://api.github.com/users/varasev/gists{/gist_id}","starred_url":"https://api.github.com/users/varasev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varasev/subscriptions","organizations_url":"https://api.github.com/users/varasev/orgs","repos_url":"https://api.github.com/users/varasev/repos","events_url":"https://api.github.com/users/varasev/events{/privacy}","received_events_url":"https://api.github.com/users/varasev/received_events","type":"User","site_admin":false},"body":"- (Mandatory) Description\r\n`ProxyStorage` contract has been supplemented to be able to store the addresses of `RewardByBlock` and `VotingToManageEmissionFunds` contracts (addresses of their eternal storages) which contain logic described for `Increased Emission Supply` in https://github.com/poanetwork/RFC/issues/14. However, `ProxyStorage.setContractAddress` function still doesn't allow to change implementations of these contracts because it is supposed to add this feature later, when necessary, by upgrading ProxyStorage's implementation (validators will be able to do that with `VotingToChangeProxyAddress`).\r\n\r\n- (Mandatory) What is it: (Fix), (Feature) or (Refactor)\r\n(Fix)","created_at":"2018-07-13T10:16:38Z","updated_at":"2018-07-13T10:16:53Z","closed_at":"2018-07-13T10:16:53Z","merged_at":"2018-07-13T10:16:53Z","merge_commit_sha":"daa6feed5c7b456d62d486ae0e78c5f333212536","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/pulls/143/commits","review_comments_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/pulls/143/comments","review_comment_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/issues/143/comments","statuses_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/statuses/55216153ba7c8f67dfde2cba0e7b3ce63e3fcbb8","head":{"label":"varasev:security-audit","ref":"security-audit","sha":"55216153ba7c8f67dfde2cba0e7b3ce63e3fcbb8","user":{"login":"varasev","id":33550681,"node_id":"MDQ6VXNlcjMzNTUwNjgx","avatar_url":"https://avatars1.githubusercontent.com/u/33550681?v=4","gravatar_id":"","url":"https://api.github.com/users/varasev","html_url":"https://github.com/varasev","followers_url":"https://api.github.com/users/varasev/followers","following_url":"https://api.github.com/users/varasev/following{/other_user}","gists_url":"https://api.github.com/users/varasev/gists{/gist_id}","starred_url":"https://api.github.com/users/varasev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varasev/subscriptions","organizations_url":"https://api.github.com/users/varasev/orgs","repos_url":"https://api.github.com/users/varasev/repos","events_url":"https://api.github.com/users/varasev/events{/privacy}","received_events_url":"https://api.github.com/users/varasev/received_events","type":"User","site_admin":false},"repo":{"id":125965470,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU5NjU0NzA=","name":"poa-network-consensus-contracts","full_name":"varasev/poa-network-consensus-contracts","owner":{"login":"varasev","id":33550681,"node_id":"MDQ6VXNlcjMzNTUwNjgx","avatar_url":"https://avatars1.githubusercontent.com/u/33550681?v=4","gravatar_id":"","url":"https://api.github.com/users/varasev","html_url":"https://github.com/varasev","followers_url":"https://api.github.com/users/varasev/followers","following_url":"https://api.github.com/users/varasev/following{/other_user}","gists_url":"https://api.github.com/users/varasev/gists{/gist_id}","starred_url":"https://api.github.com/users/varasev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varasev/subscriptions","organizations_url":"https://api.github.com/users/varasev/orgs","repos_url":"https://api.github.com/users/varasev/repos","events_url":"https://api.github.com/users/varasev/events{/privacy}","received_events_url":"https://api.github.com/users/varasev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/varasev/poa-network-consensus-contracts","description":"Main repository for \"Identity at stake\" meta consensus. Includes contracts for Initial Ceremony, Governance, Management of Validators","fork":true,"url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts","forks_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/forks","keys_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/teams","hooks_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/hooks","issue_events_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/issues/events{/number}","events_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/events","assignees_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/assignees{/user}","branches_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/branches{/branch}","tags_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/tags","blobs_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/statuses/{sha}","languages_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/languages","stargazers_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/stargazers","contributors_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/contributors","subscribers_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/subscribers","subscription_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/subscription","commits_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/contents/{+path}","compare_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/merges","archive_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/downloads","issues_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/issues{/number}","pulls_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/pulls{/number}","milestones_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/milestones{/number}","notifications_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/labels{/name}","releases_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/releases{/id}","deployments_url":"https://api.github.com/repos/varasev/poa-network-consensus-contracts/deployments","created_at":"2018-03-20T05:30:18Z","updated_at":"2018-07-13T09:22:15Z","pushed_at":"2018-07-13T10:02:10Z","git_url":"git://github.com/varasev/poa-network-consensus-contracts.git","ssh_url":"git@github.com:varasev/poa-network-consensus-contracts.git","clone_url":"https://github.com/varasev/poa-network-consensus-contracts.git","svn_url":"https://github.com/varasev/poa-network-consensus-contracts","homepage":"","size":1933,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"poanetwork:security-audit","ref":"security-audit","sha":"252af6f75cd38fe9693309562d44f5fbab70ad41","user":{"login":"poanetwork","id":28943015,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4OTQzMDE1","avatar_url":"https://avatars2.githubusercontent.com/u/28943015?v=4","gravatar_id":"","url":"https://api.github.com/users/poanetwork","html_url":"https://github.com/poanetwork","followers_url":"https://api.github.com/users/poanetwork/followers","following_url":"https://api.github.com/users/poanetwork/following{/other_user}","gists_url":"https://api.github.com/users/poanetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/poanetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poanetwork/subscriptions","organizations_url":"https://api.github.com/users/poanetwork/orgs","repos_url":"https://api.github.com/users/poanetwork/repos","events_url":"https://api.github.com/users/poanetwork/events{/privacy}","received_events_url":"https://api.github.com/users/poanetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":112296895,"node_id":"MDEwOlJlcG9zaXRvcnkxMTIyOTY4OTU=","name":"poa-network-consensus-contracts","full_name":"poanetwork/poa-network-consensus-contracts","owner":{"login":"poanetwork","id":28943015,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4OTQzMDE1","avatar_url":"https://avatars2.githubusercontent.com/u/28943015?v=4","gravatar_id":"","url":"https://api.github.com/users/poanetwork","html_url":"https://github.com/poanetwork","followers_url":"https://api.github.com/users/poanetwork/followers","following_url":"https://api.github.com/users/poanetwork/following{/other_user}","gists_url":"https://api.github.com/users/poanetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/poanetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poanetwork/subscriptions","organizations_url":"https://api.github.com/users/poanetwork/orgs","repos_url":"https://api.github.com/users/poanetwork/repos","events_url":"https://api.github.com/users/poanetwork/events{/privacy}","received_events_url":"https://api.github.com/users/poanetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/poanetwork/poa-network-consensus-contracts","description":"Main repository for \"Identity at stake\" meta consensus. Includes contracts for Initial Ceremony, Governance, Management of Validators","fork":false,"url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts","forks_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/forks","keys_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/teams","hooks_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/hooks","issue_events_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/issues/events{/number}","events_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/events","assignees_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/assignees{/user}","branches_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/branches{/branch}","tags_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/tags","blobs_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/statuses/{sha}","languages_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/languages","stargazers_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/stargazers","contributors_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/contributors","subscribers_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/subscribers","subscription_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/subscription","commits_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/contents/{+path}","compare_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/merges","archive_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/downloads","issues_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/issues{/number}","pulls_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/pulls{/number}","milestones_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/milestones{/number}","notifications_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/labels{/name}","releases_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/releases{/id}","deployments_url":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/deployments","created_at":"2017-11-28T06:42:33Z","updated_at":"2018-07-12T15:31:55Z","pushed_at":"2018-07-13T10:16:53Z","git_url":"git://github.com/poanetwork/poa-network-consensus-contracts.git","ssh_url":"git@github.com:poanetwork/poa-network-consensus-contracts.git","clone_url":"https://github.com/poanetwork/poa-network-consensus-contracts.git","svn_url":"https://github.com/poanetwork/poa-network-consensus-contracts","homepage":"","size":1547,"stargazers_count":37,"watchers_count":37,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":24,"open_issues":2,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/pulls/143"},"html":{"href":"https://github.com/poanetwork/poa-network-consensus-contracts/pull/143"},"issue":{"href":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/issues/143"},"comments":{"href":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/issues/143/comments"},"review_comments":{"href":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/pulls/143/comments"},"review_comment":{"href":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/pulls/143/commits"},"statuses":{"href":"https://api.github.com/repos/poanetwork/poa-network-consensus-contracts/statuses/55216153ba7c8f67dfde2cba0e7b3ce63e3fcbb8"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"varasev","id":33550681,"node_id":"MDQ6VXNlcjMzNTUwNjgx","avatar_url":"https://avatars1.githubusercontent.com/u/33550681?v=4","gravatar_id":"","url":"https://api.github.com/users/varasev","html_url":"https://github.com/varasev","followers_url":"https://api.github.com/users/varasev/followers","following_url":"https://api.github.com/users/varasev/following{/other_user}","gists_url":"https://api.github.com/users/varasev/gists{/gist_id}","starred_url":"https://api.github.com/users/varasev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varasev/subscriptions","organizations_url":"https://api.github.com/users/varasev/orgs","repos_url":"https://api.github.com/users/varasev/repos","events_url":"https://api.github.com/users/varasev/events{/privacy}","received_events_url":"https://api.github.com/users/varasev/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":310,"deletions":87,"changed_files":26}}
{"actor":{"display_login":"varasev"}}