{"action":"created","comment":{"url":"https://api.github.com/repos/uclouvain/openjpeg/pulls/comments/229505810","pull_request_review_id":170023292,"id":229505810,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTUwNTgxMA==","diff_hunk":"@@ -537,10 +537,10 @@ void tcd_init_encode(opj_tcd_t *tcd, opj_volume_t * volume, opj_cp_t * cp,\n         if (tcp->rates[j] <= 1) {\n             tcp->rates[j] = 0;\n         } else {\n-            float num = (float)(tile->numcomps * (tile->x1 - tile->x0) *\n-                                (tile->y1 - tile->y0) * (tile->z1 - tile->z0) * volume->comps[0].prec);\n-            float den = (float)(8 * volume->comps[0].dx * volume->comps[0].dy *\n-                                volume->comps[0].dz);\n+            float num = (float)tile->numcomps * (tile->x1 - tile->x0) *\n+                                (tile->y1 - tile->y0) * (tile->z1 - tile->z0) * volume->comps[0].prec;\n+            float den = (float)8 * volume->comps[0].dx * volume->comps[0].dy *\n+                                volume->comps[0].dz;","path":"src/lib/openjp3d/tcd.c","position":26,"original_position":26,"commit_id":"7d9463a58b4eeac46c00ee0c9dc5117e661972e8","original_commit_id":"7d9463a58b4eeac46c00ee0c9dc5117e661972e8","user":{"login":"stweil","id":6734573,"node_id":"MDQ6VXNlcjY3MzQ1NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/6734573?v=4","gravatar_id":"","url":"https://api.github.com/users/stweil","html_url":"https://github.com/stweil","followers_url":"https://api.github.com/users/stweil/followers","following_url":"https://api.github.com/users/stweil/following{/other_user}","gists_url":"https://api.github.com/users/stweil/gists{/gist_id}","starred_url":"https://api.github.com/users/stweil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stweil/subscriptions","organizations_url":"https://api.github.com/users/stweil/orgs","repos_url":"https://api.github.com/users/stweil/repos","events_url":"https://api.github.com/users/stweil/events{/privacy}","received_events_url":"https://api.github.com/users/stweil/received_events","type":"User","site_admin":false},"body":"See my previous comments.","created_at":"2018-10-30T22:14:34Z","updated_at":"2018-10-30T22:15:01Z","html_url":"https://github.com/uclouvain/openjpeg/pull/1159#discussion_r229505810","pull_request_url":"https://api.github.com/repos/uclouvain/openjpeg/pulls/1159","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/uclouvain/openjpeg/pulls/comments/229505810"},"html":{"href":"https://github.com/uclouvain/openjpeg/pull/1159#discussion_r229505810"},"pull_request":{"href":"https://api.github.com/repos/uclouvain/openjpeg/pulls/1159"}}},"pull_request":{"url":"https://api.github.com/repos/uclouvain/openjpeg/pulls/1159","id":224522197,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NTIyMTk3","html_url":"https://github.com/uclouvain/openjpeg/pull/1159","diff_url":"https://github.com/uclouvain/openjpeg/pull/1159.diff","patch_url":"https://github.com/uclouvain/openjpeg/pull/1159.patch","issue_url":"https://api.github.com/repos/uclouvain/openjpeg/issues/1159","number":1159,"state":"open","locked":false,"title":"Int overflow fixed","user":{"login":"ichlubna","id":43234438,"node_id":"MDQ6VXNlcjQzMjM0NDM4","avatar_url":"https://avatars0.githubusercontent.com/u/43234438?v=4","gravatar_id":"","url":"https://api.github.com/users/ichlubna","html_url":"https://github.com/ichlubna","followers_url":"https://api.github.com/users/ichlubna/followers","following_url":"https://api.github.com/users/ichlubna/following{/other_user}","gists_url":"https://api.github.com/users/ichlubna/gists{/gist_id}","starred_url":"https://api.github.com/users/ichlubna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ichlubna/subscriptions","organizations_url":"https://api.github.com/users/ichlubna/orgs","repos_url":"https://api.github.com/users/ichlubna/repos","events_url":"https://api.github.com/users/ichlubna/events{/privacy}","received_events_url":"https://api.github.com/users/ichlubna/received_events","type":"User","site_admin":false},"body":"When compressing a lot of slices (starting from 44 FullHD slices with 3 8bit components in our experiments) the rate values are high enough to cause an int overflow that leads to negative lengths and wrong results. The cast happens too late.\r\nFixes #1162 ","created_at":"2018-10-21T06:52:59Z","updated_at":"2018-10-30T22:15:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6baf07d46012fc64eb1918847bb69ab983c69e46","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/uclouvain/openjpeg/pulls/1159/commits","review_comments_url":"https://api.github.com/repos/uclouvain/openjpeg/pulls/1159/comments","review_comment_url":"https://api.github.com/repos/uclouvain/openjpeg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uclouvain/openjpeg/issues/1159/comments","statuses_url":"https://api.github.com/repos/uclouvain/openjpeg/statuses/7d9463a58b4eeac46c00ee0c9dc5117e661972e8","head":{"label":"ichlubna:master","ref":"master","sha":"7d9463a58b4eeac46c00ee0c9dc5117e661972e8","user":{"login":"ichlubna","id":43234438,"node_id":"MDQ6VXNlcjQzMjM0NDM4","avatar_url":"https://avatars0.githubusercontent.com/u/43234438?v=4","gravatar_id":"","url":"https://api.github.com/users/ichlubna","html_url":"https://github.com/ichlubna","followers_url":"https://api.github.com/users/ichlubna/followers","following_url":"https://api.github.com/users/ichlubna/following{/other_user}","gists_url":"https://api.github.com/users/ichlubna/gists{/gist_id}","starred_url":"https://api.github.com/users/ichlubna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ichlubna/subscriptions","organizations_url":"https://api.github.com/users/ichlubna/orgs","repos_url":"https://api.github.com/users/ichlubna/repos","events_url":"https://api.github.com/users/ichlubna/events{/privacy}","received_events_url":"https://api.github.com/users/ichlubna/received_events","type":"User","site_admin":false},"repo":{"id":153980545,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM5ODA1NDU=","name":"openjpeg","full_name":"ichlubna/openjpeg","private":false,"owner":{"login":"ichlubna","id":43234438,"node_id":"MDQ6VXNlcjQzMjM0NDM4","avatar_url":"https://avatars0.githubusercontent.com/u/43234438?v=4","gravatar_id":"","url":"https://api.github.com/users/ichlubna","html_url":"https://github.com/ichlubna","followers_url":"https://api.github.com/users/ichlubna/followers","following_url":"https://api.github.com/users/ichlubna/following{/other_user}","gists_url":"https://api.github.com/users/ichlubna/gists{/gist_id}","starred_url":"https://api.github.com/users/ichlubna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ichlubna/subscriptions","organizations_url":"https://api.github.com/users/ichlubna/orgs","repos_url":"https://api.github.com/users/ichlubna/repos","events_url":"https://api.github.com/users/ichlubna/events{/privacy}","received_events_url":"https://api.github.com/users/ichlubna/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ichlubna/openjpeg","description":"Official repository of the OpenJPEG project","fork":true,"url":"https://api.github.com/repos/ichlubna/openjpeg","forks_url":"https://api.github.com/repos/ichlubna/openjpeg/forks","keys_url":"https://api.github.com/repos/ichlubna/openjpeg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ichlubna/openjpeg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ichlubna/openjpeg/teams","hooks_url":"https://api.github.com/repos/ichlubna/openjpeg/hooks","issue_events_url":"https://api.github.com/repos/ichlubna/openjpeg/issues/events{/number}","events_url":"https://api.github.com/repos/ichlubna/openjpeg/events","assignees_url":"https://api.github.com/repos/ichlubna/openjpeg/assignees{/user}","branches_url":"https://api.github.com/repos/ichlubna/openjpeg/branches{/branch}","tags_url":"https://api.github.com/repos/ichlubna/openjpeg/tags","blobs_url":"https://api.github.com/repos/ichlubna/openjpeg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ichlubna/openjpeg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ichlubna/openjpeg/git/refs{/sha}","trees_url":"https://api.github.com/repos/ichlubna/openjpeg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ichlubna/openjpeg/statuses/{sha}","languages_url":"https://api.github.com/repos/ichlubna/openjpeg/languages","stargazers_url":"https://api.github.com/repos/ichlubna/openjpeg/stargazers","contributors_url":"https://api.github.com/repos/ichlubna/openjpeg/contributors","subscribers_url":"https://api.github.com/repos/ichlubna/openjpeg/subscribers","subscription_url":"https://api.github.com/repos/ichlubna/openjpeg/subscription","commits_url":"https://api.github.com/repos/ichlubna/openjpeg/commits{/sha}","git_commits_url":"https://api.github.com/repos/ichlubna/openjpeg/git/commits{/sha}","comments_url":"https://api.github.com/repos/ichlubna/openjpeg/comments{/number}","issue_comment_url":"https://api.github.com/repos/ichlubna/openjpeg/issues/comments{/number}","contents_url":"https://api.github.com/repos/ichlubna/openjpeg/contents/{+path}","compare_url":"https://api.github.com/repos/ichlubna/openjpeg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ichlubna/openjpeg/merges","archive_url":"https://api.github.com/repos/ichlubna/openjpeg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ichlubna/openjpeg/downloads","issues_url":"https://api.github.com/repos/ichlubna/openjpeg/issues{/number}","pulls_url":"https://api.github.com/repos/ichlubna/openjpeg/pulls{/number}","milestones_url":"https://api.github.com/repos/ichlubna/openjpeg/milestones{/number}","notifications_url":"https://api.github.com/repos/ichlubna/openjpeg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ichlubna/openjpeg/labels{/name}","releases_url":"https://api.github.com/repos/ichlubna/openjpeg/releases{/id}","deployments_url":"https://api.github.com/repos/ichlubna/openjpeg/deployments","created_at":"2018-10-21T06:38:15Z","updated_at":"2018-10-21T06:51:24Z","pushed_at":"2018-10-21T06:51:22Z","git_url":"git://github.com/ichlubna/openjpeg.git","ssh_url":"git@github.com:ichlubna/openjpeg.git","clone_url":"https://github.com/ichlubna/openjpeg.git","svn_url":"https://github.com/ichlubna/openjpeg","homepage":"","size":83935,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"uclouvain:master","ref":"master","sha":"cd900d96618ab77e79812db654731dd6b5fc7bd8","user":{"login":"uclouvain","id":9862060,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4NjIwNjA=","avatar_url":"https://avatars0.githubusercontent.com/u/9862060?v=4","gravatar_id":"","url":"https://api.github.com/users/uclouvain","html_url":"https://github.com/uclouvain","followers_url":"https://api.github.com/users/uclouvain/followers","following_url":"https://api.github.com/users/uclouvain/following{/other_user}","gists_url":"https://api.github.com/users/uclouvain/gists{/gist_id}","starred_url":"https://api.github.com/users/uclouvain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uclouvain/subscriptions","organizations_url":"https://api.github.com/users/uclouvain/orgs","repos_url":"https://api.github.com/users/uclouvain/repos","events_url":"https://api.github.com/users/uclouvain/events{/privacy}","received_events_url":"https://api.github.com/users/uclouvain/received_events","type":"Organization","site_admin":false},"repo":{"id":30830585,"node_id":"MDEwOlJlcG9zaXRvcnkzMDgzMDU4NQ==","name":"openjpeg","full_name":"uclouvain/openjpeg","private":false,"owner":{"login":"uclouvain","id":9862060,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4NjIwNjA=","avatar_url":"https://avatars0.githubusercontent.com/u/9862060?v=4","gravatar_id":"","url":"https://api.github.com/users/uclouvain","html_url":"https://github.com/uclouvain","followers_url":"https://api.github.com/users/uclouvain/followers","following_url":"https://api.github.com/users/uclouvain/following{/other_user}","gists_url":"https://api.github.com/users/uclouvain/gists{/gist_id}","starred_url":"https://api.github.com/users/uclouvain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uclouvain/subscriptions","organizations_url":"https://api.github.com/users/uclouvain/orgs","repos_url":"https://api.github.com/users/uclouvain/repos","events_url":"https://api.github.com/users/uclouvain/events{/privacy}","received_events_url":"https://api.github.com/users/uclouvain/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/uclouvain/openjpeg","description":"Official repository of the OpenJPEG project","fork":false,"url":"https://api.github.com/repos/uclouvain/openjpeg","forks_url":"https://api.github.com/repos/uclouvain/openjpeg/forks","keys_url":"https://api.github.com/repos/uclouvain/openjpeg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uclouvain/openjpeg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uclouvain/openjpeg/teams","hooks_url":"https://api.github.com/repos/uclouvain/openjpeg/hooks","issue_events_url":"https://api.github.com/repos/uclouvain/openjpeg/issues/events{/number}","events_url":"https://api.github.com/repos/uclouvain/openjpeg/events","assignees_url":"https://api.github.com/repos/uclouvain/openjpeg/assignees{/user}","branches_url":"https://api.github.com/repos/uclouvain/openjpeg/branches{/branch}","tags_url":"https://api.github.com/repos/uclouvain/openjpeg/tags","blobs_url":"https://api.github.com/repos/uclouvain/openjpeg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uclouvain/openjpeg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uclouvain/openjpeg/git/refs{/sha}","trees_url":"https://api.github.com/repos/uclouvain/openjpeg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uclouvain/openjpeg/statuses/{sha}","languages_url":"https://api.github.com/repos/uclouvain/openjpeg/languages","stargazers_url":"https://api.github.com/repos/uclouvain/openjpeg/stargazers","contributors_url":"https://api.github.com/repos/uclouvain/openjpeg/contributors","subscribers_url":"https://api.github.com/repos/uclouvain/openjpeg/subscribers","subscription_url":"https://api.github.com/repos/uclouvain/openjpeg/subscription","commits_url":"https://api.github.com/repos/uclouvain/openjpeg/commits{/sha}","git_commits_url":"https://api.github.com/repos/uclouvain/openjpeg/git/commits{/sha}","comments_url":"https://api.github.com/repos/uclouvain/openjpeg/comments{/number}","issue_comment_url":"https://api.github.com/repos/uclouvain/openjpeg/issues/comments{/number}","contents_url":"https://api.github.com/repos/uclouvain/openjpeg/contents/{+path}","compare_url":"https://api.github.com/repos/uclouvain/openjpeg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uclouvain/openjpeg/merges","archive_url":"https://api.github.com/repos/uclouvain/openjpeg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uclouvain/openjpeg/downloads","issues_url":"https://api.github.com/repos/uclouvain/openjpeg/issues{/number}","pulls_url":"https://api.github.com/repos/uclouvain/openjpeg/pulls{/number}","milestones_url":"https://api.github.com/repos/uclouvain/openjpeg/milestones{/number}","notifications_url":"https://api.github.com/repos/uclouvain/openjpeg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uclouvain/openjpeg/labels{/name}","releases_url":"https://api.github.com/repos/uclouvain/openjpeg/releases{/id}","deployments_url":"https://api.github.com/repos/uclouvain/openjpeg/deployments","created_at":"2015-02-15T15:04:29Z","updated_at":"2018-10-29T15:13:51Z","pushed_at":"2018-10-29T08:16:38Z","git_url":"git://github.com/uclouvain/openjpeg.git","ssh_url":"git@github.com:uclouvain/openjpeg.git","clone_url":"https://github.com/uclouvain/openjpeg.git","svn_url":"https://github.com/uclouvain/openjpeg","homepage":"","size":83900,"stargazers_count":396,"watchers_count":396,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":223,"mirror_url":null,"archived":false,"open_issues_count":275,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":223,"open_issues":275,"watchers":396,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uclouvain/openjpeg/pulls/1159"},"html":{"href":"https://github.com/uclouvain/openjpeg/pull/1159"},"issue":{"href":"https://api.github.com/repos/uclouvain/openjpeg/issues/1159"},"comments":{"href":"https://api.github.com/repos/uclouvain/openjpeg/issues/1159/comments"},"review_comments":{"href":"https://api.github.com/repos/uclouvain/openjpeg/pulls/1159/comments"},"review_comment":{"href":"https://api.github.com/repos/uclouvain/openjpeg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uclouvain/openjpeg/pulls/1159/commits"},"statuses":{"href":"https://api.github.com/repos/uclouvain/openjpeg/statuses/7d9463a58b4eeac46c00ee0c9dc5117e661972e8"}},"author_association":"NONE"}}
{"actor":{"display_login":"stweil"}}