{"action":"created","issue":{"url":"https://api.github.com/repos/palantir/tslint/issues/4122","repository_url":"https://api.github.com/repos/palantir/tslint","labels_url":"https://api.github.com/repos/palantir/tslint/issues/4122/labels{/name}","comments_url":"https://api.github.com/repos/palantir/tslint/issues/4122/comments","events_url":"https://api.github.com/repos/palantir/tslint/issues/4122/events","html_url":"https://github.com/palantir/tslint/issues/4122","id":351602805,"node_id":"MDU6SXNzdWUzNTE2MDI4MDU=","number":4122,"title":"Extend whitespace linting functionality","user":{"login":"arhontmw","id":5570898,"node_id":"MDQ6VXNlcjU1NzA4OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/5570898?v=4","gravatar_id":"","url":"https://api.github.com/users/arhontmw","html_url":"https://github.com/arhontmw","followers_url":"https://api.github.com/users/arhontmw/followers","following_url":"https://api.github.com/users/arhontmw/following{/other_user}","gists_url":"https://api.github.com/users/arhontmw/gists{/gist_id}","starred_url":"https://api.github.com/users/arhontmw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arhontmw/subscriptions","organizations_url":"https://api.github.com/users/arhontmw/orgs","repos_url":"https://api.github.com/users/arhontmw/repos","events_url":"https://api.github.com/users/arhontmw/events{/privacy}","received_events_url":"https://api.github.com/users/arhontmw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-17T13:50:50Z","updated_at":"2018-08-27T19:04:14Z","closed_at":null,"author_association":"NONE","body":"### Rule Suggestion\r\nExtends the functionality proposed in #1588.\r\nThe amendments listed below make whitespace rules more customizable \r\n\r\n**Is your rule for a general problem or is it specific to your development style?**\r\nThe proposal introduces changes to `whitespace` rule and adds several new rules in order to solve the general problem of whitespace linting.\r\n\r\n**What does your suggested rule do?**\r\nMy suggestion:\r\n- Get rid of **check-type** option of `whitespace` rule - instead use more consistent `typedef-whitespace` rule (see PR #4110)\r\n- Add rule `ternary-operator-spacing` that checks a presence or absence of whitespace-like symbols before and/or after question and colon tokens in ternary conditional expression (see PR #4109 )\r\n- Add rule `key-spacing` that determines whether a space is required before and/or after a colon in a property/destructuring assignment (see PR #4111)\r\n- Get rid of **check-branch** option of `whitespace` rule and instead use the new rule `space-after-branch` (see PR #4112) that requires or restricts whitespace after branching keywords\r\n\r\n**List several examples where your rule could be used**\r\nThe rules suggested are appropriate for the situations when someone's coding style is not supported by the current version of **tslint**. E.g. the current version does not check the following:\r\n- Space before colon in property/desctructuring assignment\r\n- No space before question token in ternary operator\r\n- No space after branching keywords (for, if, which, ...)\r\n"},"comment":{"url":"https://api.github.com/repos/palantir/tslint/issues/comments/416333248","html_url":"https://github.com/palantir/tslint/issues/4122#issuecomment-416333248","issue_url":"https://api.github.com/repos/palantir/tslint/issues/4122","id":416333248,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjMzMzI0OA==","user":{"login":"giladgray","id":464822,"node_id":"MDQ6VXNlcjQ2NDgyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/464822?v=4","gravatar_id":"","url":"https://api.github.com/users/giladgray","html_url":"https://github.com/giladgray","followers_url":"https://api.github.com/users/giladgray/followers","following_url":"https://api.github.com/users/giladgray/following{/other_user}","gists_url":"https://api.github.com/users/giladgray/gists{/gist_id}","starred_url":"https://api.github.com/users/giladgray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giladgray/subscriptions","organizations_url":"https://api.github.com/users/giladgray/orgs","repos_url":"https://api.github.com/users/giladgray/repos","events_url":"https://api.github.com/users/giladgray/events{/privacy}","received_events_url":"https://api.github.com/users/giladgray/received_events","type":"User","site_admin":false},"created_at":"2018-08-27T19:04:14Z","updated_at":"2018-08-27T19:04:14Z","author_association":"MEMBER","body":"i would prefer to minimize the number of rules by making individual ones smarter. if the `whitespace` rule can handle everything (without being too unwieldy) then we should do that."}}
{"actor":{"display_login":"giladgray"}}