{"action":"created","issue":{"url":"https://api.github.com/repos/theforeman/foreman/issues/5683","repository_url":"https://api.github.com/repos/theforeman/foreman","labels_url":"https://api.github.com/repos/theforeman/foreman/issues/5683/labels{/name}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/5683/comments","events_url":"https://api.github.com/repos/theforeman/foreman/issues/5683/events","html_url":"https://github.com/theforeman/foreman/pull/5683","id":331548989,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MjQ5OTYz","number":5683,"title":"Fixes #22529 - Refactor Template rendering to use a proper rendering service","user":{"login":"kamils-iRonin","id":37402924,"node_id":"MDQ6VXNlcjM3NDAyOTI0","avatar_url":"https://avatars0.githubusercontent.com/u/37402924?v=4","gravatar_id":"","url":"https://api.github.com/users/kamils-iRonin","html_url":"https://github.com/kamils-iRonin","followers_url":"https://api.github.com/users/kamils-iRonin/followers","following_url":"https://api.github.com/users/kamils-iRonin/following{/other_user}","gists_url":"https://api.github.com/users/kamils-iRonin/gists{/gist_id}","starred_url":"https://api.github.com/users/kamils-iRonin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamils-iRonin/subscriptions","organizations_url":"https://api.github.com/users/kamils-iRonin/orgs","repos_url":"https://api.github.com/users/kamils-iRonin/repos","events_url":"https://api.github.com/users/kamils-iRonin/events{/privacy}","received_events_url":"https://api.github.com/users/kamils-iRonin/received_events","type":"User","site_admin":false},"labels":[{"id":79040160,"node_id":"MDU6TGFiZWw3OTA0MDE2MA==","url":"https://api.github.com/repos/theforeman/foreman/labels/Needs%20re-review","name":"Needs re-review","color":"0052cc","default":false},{"id":79040689,"node_id":"MDU6TGFiZWw3OTA0MDY4OQ==","url":"https://api.github.com/repos/theforeman/foreman/labels/Needs%20testing","name":"Needs testing","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":28,"created_at":"2018-06-12T11:33:31Z","updated_at":"2018-07-13T11:20:49Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/5683","html_url":"https://github.com/theforeman/foreman/pull/5683","diff_url":"https://github.com/theforeman/foreman/pull/5683.diff","patch_url":"https://github.com/theforeman/foreman/pull/5683.patch"},"body":"This is about rewriting templating engine. This PR includes:\r\n\r\n- base renderer class that contains code common to all renderers\r\n- database renderer to render templates from a database\r\n- support for extending renderers by Foreman plugins\r\n- helper method to render templates in multiple places\r\n\r\nIn progress: Refactor `RenderersHelper` module to use new rendering system"},"comment":{"url":"https://api.github.com/repos/theforeman/foreman/issues/comments/404804903","html_url":"https://github.com/theforeman/foreman/pull/5683#issuecomment-404804903","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/5683","id":404804903,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDgwNDkwMw==","user":{"login":"timogoebel","id":4107560,"node_id":"MDQ6VXNlcjQxMDc1NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/4107560?v=4","gravatar_id":"","url":"https://api.github.com/users/timogoebel","html_url":"https://github.com/timogoebel","followers_url":"https://api.github.com/users/timogoebel/followers","following_url":"https://api.github.com/users/timogoebel/following{/other_user}","gists_url":"https://api.github.com/users/timogoebel/gists{/gist_id}","starred_url":"https://api.github.com/users/timogoebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timogoebel/subscriptions","organizations_url":"https://api.github.com/users/timogoebel/orgs","repos_url":"https://api.github.com/users/timogoebel/repos","events_url":"https://api.github.com/users/timogoebel/events{/privacy}","received_events_url":"https://api.github.com/users/timogoebel/received_events","type":"User","site_admin":false},"created_at":"2018-07-13T11:20:49Z","updated_at":"2018-07-13T11:20:49Z","author_association":"MEMBER","body":"> Just to clarify: this is now an internal refactor without user visible changes, correct?\r\n\r\nYes. It prepares the rendering engine for new awesome features. Ideally, a user would not notice any changes."}}
{"actor":{"display_login":"timogoebel"}}