{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/pulls/comments/193571343","pull_request_review_id":126569868,"id":193571343,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzU3MTM0Mw==","diff_hunk":"@@ -0,0 +1,79 @@\n+/*","path":"cloud/vsphere/deployer.go","position":1,"original_position":1,"commit_id":"5ee3cd632fc2019229ca2ee5cf07e37aed7f9047","original_commit_id":"7e3f5b0033393a382befee8419e8fd0d992efbdc","user":{"login":"jessicaochen","id":25439230,"node_id":"MDQ6VXNlcjI1NDM5MjMw","avatar_url":"https://avatars2.githubusercontent.com/u/25439230?v=4","gravatar_id":"","url":"https://api.github.com/users/jessicaochen","html_url":"https://github.com/jessicaochen","followers_url":"https://api.github.com/users/jessicaochen/followers","following_url":"https://api.github.com/users/jessicaochen/following{/other_user}","gists_url":"https://api.github.com/users/jessicaochen/gists{/gist_id}","starred_url":"https://api.github.com/users/jessicaochen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessicaochen/subscriptions","organizations_url":"https://api.github.com/users/jessicaochen/orgs","repos_url":"https://api.github.com/users/jessicaochen/repos","events_url":"https://api.github.com/users/jessicaochen/events{/privacy}","received_events_url":"https://api.github.com/users/jessicaochen/received_events","type":"User","site_admin":false},"body":"Updated the name to reflect is a client for vsphere deployement. Hopefully that is better?","created_at":"2018-06-06T21:54:04Z","updated_at":"2018-06-06T21:54:04Z","html_url":"https://github.com/kubernetes-sigs/cluster-api/pull/293#discussion_r193571343","pull_request_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/pulls/293","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/cluster-api/pulls/comments/193571343"},"html":{"href":"https://github.com/kubernetes-sigs/cluster-api/pull/293#discussion_r193571343"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-sigs/cluster-api/pulls/293"}},"in_reply_to_id":193566103},"pull_request":{"url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/pulls/293","id":193118787,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMTE4Nzg3","html_url":"https://github.com/kubernetes-sigs/cluster-api/pull/293","diff_url":"https://github.com/kubernetes-sigs/cluster-api/pull/293.diff","patch_url":"https://github.com/kubernetes-sigs/cluster-api/pull/293.patch","issue_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/issues/293","number":293,"state":"open","locked":false,"title":"break out provider deployer logic","user":{"login":"jessicaochen","id":25439230,"node_id":"MDQ6VXNlcjI1NDM5MjMw","avatar_url":"https://avatars2.githubusercontent.com/u/25439230?v=4","gravatar_id":"","url":"https://api.github.com/users/jessicaochen","html_url":"https://github.com/jessicaochen","followers_url":"https://api.github.com/users/jessicaochen/followers","following_url":"https://api.github.com/users/jessicaochen/following{/other_user}","gists_url":"https://api.github.com/users/jessicaochen/gists{/gist_id}","starred_url":"https://api.github.com/users/jessicaochen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessicaochen/subscriptions","organizations_url":"https://api.github.com/users/jessicaochen/orgs","repos_url":"https://api.github.com/users/jessicaochen/repos","events_url":"https://api.github.com/users/jessicaochen/events{/privacy}","received_events_url":"https://api.github.com/users/jessicaochen/received_events","type":"User","site_admin":false},"body":"Breaking out clusterctl requirements for provider-specific logic.\r\n\r\nContext:\r\nWhat machineactuator needs to implement for machine controller, vsphere-deployer and clusterctl are different. Having one class implement it all leads to each use case having extra checks, overhead etc. that is not needed. \r\n\r\nFor example, when using the macineactuator for clusterctl, there are logs stating \r\n`error creating named machine config watch: stat : no such file or directory`. There is not actually an issue because clusterctl does not directly provision machines. However, this has been confusing to users of clusterctl.\r\n\r\n/hold\r\nso I can build official image right before merge.\r\n\r\n```release-note\r\n\r\n```\r\n\r\n<!-- All reviews default to cc'ing the kube-deploy-reviewers github group. -->\r\n@kubernetes/kube-deploy-reviewers\r\n","created_at":"2018-06-06T19:38:33Z","updated_at":"2018-06-06T21:54:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da4cc7f1b504cd22b604672d8cb9b60b63793ee1","assignee":{"login":"karan","id":3261985,"node_id":"MDQ6VXNlcjMyNjE5ODU=","avatar_url":"https://avatars1.githubusercontent.com/u/3261985?v=4","gravatar_id":"","url":"https://api.github.com/users/karan","html_url":"https://github.com/karan","followers_url":"https://api.github.com/users/karan/followers","following_url":"https://api.github.com/users/karan/following{/other_user}","gists_url":"https://api.github.com/users/karan/gists{/gist_id}","starred_url":"https://api.github.com/users/karan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karan/subscriptions","organizations_url":"https://api.github.com/users/karan/orgs","repos_url":"https://api.github.com/users/karan/repos","events_url":"https://api.github.com/users/karan/events{/privacy}","received_events_url":"https://api.github.com/users/karan/received_events","type":"User","site_admin":false},"assignees":[{"login":"karan","id":3261985,"node_id":"MDQ6VXNlcjMyNjE5ODU=","avatar_url":"https://avatars1.githubusercontent.com/u/3261985?v=4","gravatar_id":"","url":"https://api.github.com/users/karan","html_url":"https://github.com/karan","followers_url":"https://api.github.com/users/karan/followers","following_url":"https://api.github.com/users/karan/following{/other_user}","gists_url":"https://api.github.com/users/karan/gists{/gist_id}","starred_url":"https://api.github.com/users/karan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karan/subscriptions","organizations_url":"https://api.github.com/users/karan/orgs","repos_url":"https://api.github.com/users/karan/repos","events_url":"https://api.github.com/users/karan/events{/privacy}","received_events_url":"https://api.github.com/users/karan/received_events","type":"User","site_admin":false},{"login":"kcoronado","id":10516796,"node_id":"MDQ6VXNlcjEwNTE2Nzk2","avatar_url":"https://avatars1.githubusercontent.com/u/10516796?v=4","gravatar_id":"","url":"https://api.github.com/users/kcoronado","html_url":"https://github.com/kcoronado","followers_url":"https://api.github.com/users/kcoronado/followers","following_url":"https://api.github.com/users/kcoronado/following{/other_user}","gists_url":"https://api.github.com/users/kcoronado/gists{/gist_id}","starred_url":"https://api.github.com/users/kcoronado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kcoronado/subscriptions","organizations_url":"https://api.github.com/users/kcoronado/orgs","repos_url":"https://api.github.com/users/kcoronado/repos","events_url":"https://api.github.com/users/kcoronado/events{/privacy}","received_events_url":"https://api.github.com/users/kcoronado/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":905052788,"node_id":"MDU6TGFiZWw5MDUwNTI3ODg=","url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":875323571,"node_id":"MDU6TGFiZWw4NzUzMjM1NzE=","url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":914072495,"node_id":"MDU6TGFiZWw5MTQwNzI0OTU=","url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"e11d21","default":false},{"id":904030780,"node_id":"MDU6TGFiZWw5MDQwMzA3ODA=","url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/pulls/293/commits","review_comments_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/pulls/293/comments","review_comment_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/issues/293/comments","statuses_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/statuses/5ee3cd632fc2019229ca2ee5cf07e37aed7f9047","head":{"label":"jessicaochen:vsphere_deployer","ref":"vsphere_deployer","sha":"5ee3cd632fc2019229ca2ee5cf07e37aed7f9047","user":{"login":"jessicaochen","id":25439230,"node_id":"MDQ6VXNlcjI1NDM5MjMw","avatar_url":"https://avatars2.githubusercontent.com/u/25439230?v=4","gravatar_id":"","url":"https://api.github.com/users/jessicaochen","html_url":"https://github.com/jessicaochen","followers_url":"https://api.github.com/users/jessicaochen/followers","following_url":"https://api.github.com/users/jessicaochen/following{/other_user}","gists_url":"https://api.github.com/users/jessicaochen/gists{/gist_id}","starred_url":"https://api.github.com/users/jessicaochen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessicaochen/subscriptions","organizations_url":"https://api.github.com/users/jessicaochen/orgs","repos_url":"https://api.github.com/users/jessicaochen/repos","events_url":"https://api.github.com/users/jessicaochen/events{/privacy}","received_events_url":"https://api.github.com/users/jessicaochen/received_events","type":"User","site_admin":false},"repo":{"id":131360002,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEzNjAwMDI=","name":"cluster-api","full_name":"jessicaochen/cluster-api","owner":{"login":"jessicaochen","id":25439230,"node_id":"MDQ6VXNlcjI1NDM5MjMw","avatar_url":"https://avatars2.githubusercontent.com/u/25439230?v=4","gravatar_id":"","url":"https://api.github.com/users/jessicaochen","html_url":"https://github.com/jessicaochen","followers_url":"https://api.github.com/users/jessicaochen/followers","following_url":"https://api.github.com/users/jessicaochen/following{/other_user}","gists_url":"https://api.github.com/users/jessicaochen/gists{/gist_id}","starred_url":"https://api.github.com/users/jessicaochen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessicaochen/subscriptions","organizations_url":"https://api.github.com/users/jessicaochen/orgs","repos_url":"https://api.github.com/users/jessicaochen/repos","events_url":"https://api.github.com/users/jessicaochen/events{/privacy}","received_events_url":"https://api.github.com/users/jessicaochen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jessicaochen/cluster-api","description":"Home for the cluster api work, a subproject of sig-cluster-lifecycle","fork":true,"url":"https://api.github.com/repos/jessicaochen/cluster-api","forks_url":"https://api.github.com/repos/jessicaochen/cluster-api/forks","keys_url":"https://api.github.com/repos/jessicaochen/cluster-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jessicaochen/cluster-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jessicaochen/cluster-api/teams","hooks_url":"https://api.github.com/repos/jessicaochen/cluster-api/hooks","issue_events_url":"https://api.github.com/repos/jessicaochen/cluster-api/issues/events{/number}","events_url":"https://api.github.com/repos/jessicaochen/cluster-api/events","assignees_url":"https://api.github.com/repos/jessicaochen/cluster-api/assignees{/user}","branches_url":"https://api.github.com/repos/jessicaochen/cluster-api/branches{/branch}","tags_url":"https://api.github.com/repos/jessicaochen/cluster-api/tags","blobs_url":"https://api.github.com/repos/jessicaochen/cluster-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jessicaochen/cluster-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jessicaochen/cluster-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/jessicaochen/cluster-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jessicaochen/cluster-api/statuses/{sha}","languages_url":"https://api.github.com/repos/jessicaochen/cluster-api/languages","stargazers_url":"https://api.github.com/repos/jessicaochen/cluster-api/stargazers","contributors_url":"https://api.github.com/repos/jessicaochen/cluster-api/contributors","subscribers_url":"https://api.github.com/repos/jessicaochen/cluster-api/subscribers","subscription_url":"https://api.github.com/repos/jessicaochen/cluster-api/subscription","commits_url":"https://api.github.com/repos/jessicaochen/cluster-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/jessicaochen/cluster-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/jessicaochen/cluster-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/jessicaochen/cluster-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/jessicaochen/cluster-api/contents/{+path}","compare_url":"https://api.github.com/repos/jessicaochen/cluster-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jessicaochen/cluster-api/merges","archive_url":"https://api.github.com/repos/jessicaochen/cluster-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jessicaochen/cluster-api/downloads","issues_url":"https://api.github.com/repos/jessicaochen/cluster-api/issues{/number}","pulls_url":"https://api.github.com/repos/jessicaochen/cluster-api/pulls{/number}","milestones_url":"https://api.github.com/repos/jessicaochen/cluster-api/milestones{/number}","notifications_url":"https://api.github.com/repos/jessicaochen/cluster-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jessicaochen/cluster-api/labels{/name}","releases_url":"https://api.github.com/repos/jessicaochen/cluster-api/releases{/id}","deployments_url":"https://api.github.com/repos/jessicaochen/cluster-api/deployments","created_at":"2018-04-28T01:31:47Z","updated_at":"2018-06-06T18:45:32Z","pushed_at":"2018-06-06T21:53:19Z","git_url":"git://github.com/jessicaochen/cluster-api.git","ssh_url":"git@github.com:jessicaochen/cluster-api.git","clone_url":"https://github.com/jessicaochen/cluster-api.git","svn_url":"https://github.com/jessicaochen/cluster-api","homepage":null,"size":150401,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-sigs:master","ref":"master","sha":"57efe550e628a67d782bd2de34eb2b02db1f90e9","user":{"login":"kubernetes-sigs","id":36015203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDE1MjAz","avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"repo":{"id":124157517,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQxNTc1MTc=","name":"cluster-api","full_name":"kubernetes-sigs/cluster-api","owner":{"login":"kubernetes-sigs","id":36015203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDE1MjAz","avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-sigs/cluster-api","description":"Home for the cluster api work, a subproject of sig-cluster-lifecycle","fork":false,"url":"https://api.github.com/repos/kubernetes-sigs/cluster-api","forks_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/forks","keys_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/teams","hooks_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/events","assignees_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/tags","blobs_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/languages","stargazers_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/subscription","commits_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/merges","archive_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/downloads","issues_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/deployments","created_at":"2018-03-07T00:49:50Z","updated_at":"2018-06-06T18:19:30Z","pushed_at":"2018-06-06T21:53:20Z","git_url":"git://github.com/kubernetes-sigs/cluster-api.git","ssh_url":"git@github.com:kubernetes-sigs/cluster-api.git","clone_url":"https://github.com/kubernetes-sigs/cluster-api.git","svn_url":"https://github.com/kubernetes-sigs/cluster-api","homepage":null,"size":145015,"stargazers_count":60,"watchers_count":60,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":136,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":35,"open_issues":136,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/cluster-api/pulls/293"},"html":{"href":"https://github.com/kubernetes-sigs/cluster-api/pull/293"},"issue":{"href":"https://api.github.com/repos/kubernetes-sigs/cluster-api/issues/293"},"comments":{"href":"https://api.github.com/repos/kubernetes-sigs/cluster-api/issues/293/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-sigs/cluster-api/pulls/293/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-sigs/cluster-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-sigs/cluster-api/pulls/293/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-sigs/cluster-api/statuses/5ee3cd632fc2019229ca2ee5cf07e37aed7f9047"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jessicaochen"}}