{"action":"created","comment":{"url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/pulls/comments/228752322","pull_request_review_id":169096126,"id":228752322,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODc1MjMyMg==","diff_hunk":"@@ -93,8 +95,14 @@ def configure_step(self):\n         # WRF dependency check\n         wrf = get_software_root('WRF')\n         if wrf:\n-            majver = get_software_version('WRF').split('.')[0]\n-            self.wrfdir = os.path.join(wrf, \"WRFV%s\" % majver)\n+            wrfver = get_software_version('WRF')\n+            majver = wrfver.split('.')[0]\n+            if majver == '3':\n+                self.wrfdir = os.path.join(wrf, \"WRFV%s\" % majver)\n+            elif majver == '4':\n+                self.wrfdir = os.path.join(wrf, \"WRF-%s\" % wrfver)\n+            else:\n+                raise EasyBuildError(\"Unknown WRF version: %s\" % wrfver)","path":"easybuild/easyblocks/w/wps.py","position":25,"original_position":25,"commit_id":"1c6123d6e77c994198de6f186efb55a6c3797109","original_commit_id":"1c6123d6e77c994198de6f186efb55a6c3797109","user":{"login":"boegel","id":620876,"node_id":"MDQ6VXNlcjYyMDg3Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/620876?v=4","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"body":"I would make this less strict, and assume that ‘WRF-‘ is used from version 4.x onwards.\r\n\r\nEven better would be to employ a slightly more dynamic approach to finding the subdir, e.g. go with the subdirectory that starts with ‘WRF’ if there’s only one, and error out otherwise.","created_at":"2018-10-28T15:07:32Z","updated_at":"2018-10-28T15:16:12Z","html_url":"https://github.com/easybuilders/easybuild-easyblocks/pull/1563#discussion_r228752322","pull_request_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/pulls/1563","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/pulls/comments/228752322"},"html":{"href":"https://github.com/easybuilders/easybuild-easyblocks/pull/1563#discussion_r228752322"},"pull_request":{"href":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/pulls/1563"}}},"pull_request":{"url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/pulls/1563","id":226367531,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MzY3NTMx","html_url":"https://github.com/easybuilders/easybuild-easyblocks/pull/1563","diff_url":"https://github.com/easybuilders/easybuild-easyblocks/pull/1563.diff","patch_url":"https://github.com/easybuilders/easybuild-easyblocks/pull/1563.patch","issue_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/issues/1563","number":1563,"state":"open","locked":false,"title":"ENH: update WRF and WPS to support version 4","user":{"login":"andreas-h","id":358378,"node_id":"MDQ6VXNlcjM1ODM3OA==","avatar_url":"https://avatars2.githubusercontent.com/u/358378?v=4","gravatar_id":"","url":"https://api.github.com/users/andreas-h","html_url":"https://github.com/andreas-h","followers_url":"https://api.github.com/users/andreas-h/followers","following_url":"https://api.github.com/users/andreas-h/following{/other_user}","gists_url":"https://api.github.com/users/andreas-h/gists{/gist_id}","starred_url":"https://api.github.com/users/andreas-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreas-h/subscriptions","organizations_url":"https://api.github.com/users/andreas-h/orgs","repos_url":"https://api.github.com/users/andreas-h/repos","events_url":"https://api.github.com/users/andreas-h/events{/privacy}","received_events_url":"https://api.github.com/users/andreas-h/received_events","type":"User","site_admin":false},"body":"Both WRF and WPS saw quite some changes in version 4.0.  This commit\r\nadapts the existing WPS and WRF easyblocks to accomodate them.","created_at":"2018-10-28T13:35:40Z","updated_at":"2018-10-28T15:16:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10f86ac8f2df3d5f680dd06f7762c9f7ffc6927b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/pulls/1563/commits","review_comments_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/pulls/1563/comments","review_comment_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/issues/1563/comments","statuses_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/statuses/1c6123d6e77c994198de6f186efb55a6c3797109","head":{"label":"andreas-h:wrf4","ref":"wrf4","sha":"1c6123d6e77c994198de6f186efb55a6c3797109","user":{"login":"andreas-h","id":358378,"node_id":"MDQ6VXNlcjM1ODM3OA==","avatar_url":"https://avatars2.githubusercontent.com/u/358378?v=4","gravatar_id":"","url":"https://api.github.com/users/andreas-h","html_url":"https://github.com/andreas-h","followers_url":"https://api.github.com/users/andreas-h/followers","following_url":"https://api.github.com/users/andreas-h/following{/other_user}","gists_url":"https://api.github.com/users/andreas-h/gists{/gist_id}","starred_url":"https://api.github.com/users/andreas-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreas-h/subscriptions","organizations_url":"https://api.github.com/users/andreas-h/orgs","repos_url":"https://api.github.com/users/andreas-h/repos","events_url":"https://api.github.com/users/andreas-h/events{/privacy}","received_events_url":"https://api.github.com/users/andreas-h/received_events","type":"User","site_admin":false},"repo":{"id":57055041,"node_id":"MDEwOlJlcG9zaXRvcnk1NzA1NTA0MQ==","name":"easybuild-easyblocks","full_name":"andreas-h/easybuild-easyblocks","private":false,"owner":{"login":"andreas-h","id":358378,"node_id":"MDQ6VXNlcjM1ODM3OA==","avatar_url":"https://avatars2.githubusercontent.com/u/358378?v=4","gravatar_id":"","url":"https://api.github.com/users/andreas-h","html_url":"https://github.com/andreas-h","followers_url":"https://api.github.com/users/andreas-h/followers","following_url":"https://api.github.com/users/andreas-h/following{/other_user}","gists_url":"https://api.github.com/users/andreas-h/gists{/gist_id}","starred_url":"https://api.github.com/users/andreas-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreas-h/subscriptions","organizations_url":"https://api.github.com/users/andreas-h/orgs","repos_url":"https://api.github.com/users/andreas-h/repos","events_url":"https://api.github.com/users/andreas-h/events{/privacy}","received_events_url":"https://api.github.com/users/andreas-h/received_events","type":"User","site_admin":false},"html_url":"https://github.com/andreas-h/easybuild-easyblocks","description":"Collection of easyblocks that implement support for building and installing software with EasyBuild.","fork":true,"url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks","forks_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/forks","keys_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/teams","hooks_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/hooks","issue_events_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/issues/events{/number}","events_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/events","assignees_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/assignees{/user}","branches_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/branches{/branch}","tags_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/tags","blobs_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/statuses/{sha}","languages_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/languages","stargazers_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/stargazers","contributors_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/contributors","subscribers_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/subscribers","subscription_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/subscription","commits_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/issues/comments{/number}","contents_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/contents/{+path}","compare_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/merges","archive_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/downloads","issues_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/issues{/number}","pulls_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/pulls{/number}","milestones_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/milestones{/number}","notifications_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/labels{/name}","releases_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/releases{/id}","deployments_url":"https://api.github.com/repos/andreas-h/easybuild-easyblocks/deployments","created_at":"2016-04-25T15:50:05Z","updated_at":"2016-04-25T15:50:09Z","pushed_at":"2018-10-28T13:33:05Z","git_url":"git://github.com/andreas-h/easybuild-easyblocks.git","ssh_url":"git@github.com:andreas-h/easybuild-easyblocks.git","clone_url":"https://github.com/andreas-h/easybuild-easyblocks.git","svn_url":"https://github.com/andreas-h/easybuild-easyblocks","homepage":"http://hpcugent.github.com/easybuild/","size":9547,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"easybuilders:develop","ref":"develop","sha":"7b69193027679b20d1035bd6578ec11ad5ded7d8","user":{"login":"easybuilders","id":29568382,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NTY4Mzgy","avatar_url":"https://avatars1.githubusercontent.com/u/29568382?v=4","gravatar_id":"","url":"https://api.github.com/users/easybuilders","html_url":"https://github.com/easybuilders","followers_url":"https://api.github.com/users/easybuilders/followers","following_url":"https://api.github.com/users/easybuilders/following{/other_user}","gists_url":"https://api.github.com/users/easybuilders/gists{/gist_id}","starred_url":"https://api.github.com/users/easybuilders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/easybuilders/subscriptions","organizations_url":"https://api.github.com/users/easybuilders/orgs","repos_url":"https://api.github.com/users/easybuilders/repos","events_url":"https://api.github.com/users/easybuilders/events{/privacy}","received_events_url":"https://api.github.com/users/easybuilders/received_events","type":"Organization","site_admin":false},"repo":{"id":6228378,"node_id":"MDEwOlJlcG9zaXRvcnk2MjI4Mzc4","name":"easybuild-easyblocks","full_name":"easybuilders/easybuild-easyblocks","private":false,"owner":{"login":"easybuilders","id":29568382,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NTY4Mzgy","avatar_url":"https://avatars1.githubusercontent.com/u/29568382?v=4","gravatar_id":"","url":"https://api.github.com/users/easybuilders","html_url":"https://github.com/easybuilders","followers_url":"https://api.github.com/users/easybuilders/followers","following_url":"https://api.github.com/users/easybuilders/following{/other_user}","gists_url":"https://api.github.com/users/easybuilders/gists{/gist_id}","starred_url":"https://api.github.com/users/easybuilders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/easybuilders/subscriptions","organizations_url":"https://api.github.com/users/easybuilders/orgs","repos_url":"https://api.github.com/users/easybuilders/repos","events_url":"https://api.github.com/users/easybuilders/events{/privacy}","received_events_url":"https://api.github.com/users/easybuilders/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/easybuilders/easybuild-easyblocks","description":"Collection of easyblocks that implement support for building and installing software with EasyBuild.","fork":false,"url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks","forks_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/forks","keys_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/teams","hooks_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/hooks","issue_events_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/issues/events{/number}","events_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/events","assignees_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/assignees{/user}","branches_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/branches{/branch}","tags_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/tags","blobs_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/statuses/{sha}","languages_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/languages","stargazers_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/stargazers","contributors_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/contributors","subscribers_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/subscribers","subscription_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/subscription","commits_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/issues/comments{/number}","contents_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/contents/{+path}","compare_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/merges","archive_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/downloads","issues_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/issues{/number}","pulls_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/pulls{/number}","milestones_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/milestones{/number}","notifications_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/labels{/name}","releases_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/releases{/id}","deployments_url":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/deployments","created_at":"2012-10-15T14:31:19Z","updated_at":"2018-10-18T08:47:19Z","pushed_at":"2018-10-28T13:35:40Z","git_url":"git://github.com/easybuilders/easybuild-easyblocks.git","ssh_url":"git@github.com:easybuilders/easybuild-easyblocks.git","clone_url":"https://github.com/easybuilders/easybuild-easyblocks.git","svn_url":"https://github.com/easybuilders/easybuild-easyblocks","homepage":"http://easybuilders.github.io/easybuild/","size":9534,"stargazers_count":52,"watchers_count":52,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":161,"mirror_url":null,"archived":false,"open_issues_count":202,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":161,"open_issues":202,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/pulls/1563"},"html":{"href":"https://github.com/easybuilders/easybuild-easyblocks/pull/1563"},"issue":{"href":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/issues/1563"},"comments":{"href":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/issues/1563/comments"},"review_comments":{"href":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/pulls/1563/comments"},"review_comment":{"href":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/pulls/1563/commits"},"statuses":{"href":"https://api.github.com/repos/easybuilders/easybuild-easyblocks/statuses/1c6123d6e77c994198de6f186efb55a6c3797109"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"boegel"}}