{"action":"created","issue":{"url":"https://api.github.com/repos/wio/Cosa/issues/1","repository_url":"https://api.github.com/repos/wio/Cosa","labels_url":"https://api.github.com/repos/wio/Cosa/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/wio/Cosa/issues/1/comments","events_url":"https://api.github.com/repos/wio/Cosa/issues/1/events","html_url":"https://github.com/wio/Cosa/pull/1","id":337194740,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NDY0NjI0","number":1,"title":"[BUGFIX] - Broken Slave TWI Fixed","user":{"login":"shahzadlone","id":30120428,"node_id":"MDQ6VXNlcjMwMTIwNDI4","avatar_url":"https://avatars1.githubusercontent.com/u/30120428?v=4","gravatar_id":"","url":"https://api.github.com/users/shahzadlone","html_url":"https://github.com/shahzadlone","followers_url":"https://api.github.com/users/shahzadlone/followers","following_url":"https://api.github.com/users/shahzadlone/following{/other_user}","gists_url":"https://api.github.com/users/shahzadlone/gists{/gist_id}","starred_url":"https://api.github.com/users/shahzadlone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shahzadlone/subscriptions","organizations_url":"https://api.github.com/users/shahzadlone/orgs","repos_url":"https://api.github.com/users/shahzadlone/repos","events_url":"https://api.github.com/users/shahzadlone/events{/privacy}","received_events_url":"https://api.github.com/users/shahzadlone/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-30T07:30:32Z","updated_at":"2018-06-30T07:32:35Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/wio/Cosa/pulls/1","html_url":"https://github.com/wio/Cosa/pull/1","diff_url":"https://github.com/wio/Cosa/pull/1.diff","patch_url":"https://github.com/wio/Cosa/pull/1.patch"},"body":"COMMIT LEGEND:\r\nBroken_C=173c3ebaa483d09acefb62df920bc6b064bf4420\r\nLatest_C=90b815b6bf1a75af1e34b0f8f50ea6364e4d4acd\r\nReBroke_C=a0d6795c04086423fb25fbd232c56a3e7ce9caa2\r\n\r\nProgress so far:\r\nWhat i did:\r\n1) Reverted back to the commit where things first broke at (<Broken_C>).\r\n2) Fixed the bug (There was Nulling a variable and setting another to 0).\r\n3) But even with my fix the latest commit (<Latest_C>) was still broken, so i traced where it broke again after the fix. \r\n4) I found it rebroke after about 47 commits overall (and 2 commit changes after on the file TWI.cpp) at <ReBroke_C>. I did manually merge all commits upto this commit to confirm everything works fine until this commit.\r\n5) After that with a hint from @mikaelpatel, I was able to fix the second bug (needed to poweron TWI::slave:begin(). \r\n6) After that fixed i merge it up-to the Latest_C commit and everything seemed to work fine.\r\n\r\nWill appreciate if this can be tested further to ensure i didn't break something else.\r\nTODO: I commented the null and setting to 0, should i just delete them or leave them commented."},"comment":{"url":"https://api.github.com/repos/wio/Cosa/issues/comments/401524039","html_url":"https://github.com/wio/Cosa/pull/1#issuecomment-401524039","issue_url":"https://api.github.com/repos/wio/Cosa/issues/1","id":401524039,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTUyNDAzOQ==","user":{"login":"shahzadlone","id":30120428,"node_id":"MDQ6VXNlcjMwMTIwNDI4","avatar_url":"https://avatars1.githubusercontent.com/u/30120428?v=4","gravatar_id":"","url":"https://api.github.com/users/shahzadlone","html_url":"https://github.com/shahzadlone","followers_url":"https://api.github.com/users/shahzadlone/followers","following_url":"https://api.github.com/users/shahzadlone/following{/other_user}","gists_url":"https://api.github.com/users/shahzadlone/gists{/gist_id}","starred_url":"https://api.github.com/users/shahzadlone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shahzadlone/subscriptions","organizations_url":"https://api.github.com/users/shahzadlone/orgs","repos_url":"https://api.github.com/users/shahzadlone/repos","events_url":"https://api.github.com/users/shahzadlone/events{/privacy}","received_events_url":"https://api.github.com/users/shahzadlone/received_events","type":"User","site_admin":false},"created_at":"2018-06-30T07:32:35Z","updated_at":"2018-06-30T07:32:35Z","author_association":"NONE","body":"@dhillondeep "}}
{"actor":{"display_login":"shahzadlone"}}