{"action":"created","comment":{"url":"https://api.github.com/repos/JetBrains/intellij-community/pulls/comments/239773159","pull_request_review_id":182648384,"id":239773159,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTc3MzE1OQ==","diff_hunk":"@@ -24,10 +24,17 @@\n  */\n public class JavaResourceRootType extends JpsElementTypeBase<JavaResourceRootProperties> implements\n                                                                                          JpsModuleSourceRootType<JavaResourceRootProperties> {\n-  public static final JavaResourceRootType RESOURCE = new JavaResourceRootType();\n-  public static final JavaResourceRootType TEST_RESOURCE = new JavaResourceRootType();\n+  public static final JavaResourceRootType RESOURCE = new JavaResourceRootType(false);\n+  public static final JavaResourceRootType TEST_RESOURCE = new JavaResourceRootType(true);\n \n-  private JavaResourceRootType() {\n+  private final boolean isForTests;\n+  private JavaResourceRootType(boolean isForTests) {\n+    this.isForTests = isForTests;","path":"jps/model-api/src/org/jetbrains/jps/model/java/JavaResourceRootType.java","position":12,"original_position":12,"commit_id":"31417affbda09db4785a6c24345774adb422d079","original_commit_id":"31417affbda09db4785a6c24345774adb422d079","user":{"login":"chashnikov","id":978014,"node_id":"MDQ6VXNlcjk3ODAxNA==","avatar_url":"https://avatars0.githubusercontent.com/u/978014?v=4","gravatar_id":"","url":"https://api.github.com/users/chashnikov","html_url":"https://github.com/chashnikov","followers_url":"https://api.github.com/users/chashnikov/followers","following_url":"https://api.github.com/users/chashnikov/following{/other_user}","gists_url":"https://api.github.com/users/chashnikov/gists{/gist_id}","starred_url":"https://api.github.com/users/chashnikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chashnikov/subscriptions","organizations_url":"https://api.github.com/users/chashnikov/orgs","repos_url":"https://api.github.com/users/chashnikov/repos","events_url":"https://api.github.com/users/chashnikov/events{/privacy}","received_events_url":"https://api.github.com/users/chashnikov/received_events","type":"User","site_admin":false},"body":"We use `my` prefix for instance fields in Java classes to avoid such `this.` qualifiers.","created_at":"2018-12-07T11:13:26Z","updated_at":"2018-12-07T11:16:26Z","html_url":"https://github.com/JetBrains/intellij-community/pull/1003#discussion_r239773159","pull_request_url":"https://api.github.com/repos/JetBrains/intellij-community/pulls/1003","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/JetBrains/intellij-community/pulls/comments/239773159"},"html":{"href":"https://github.com/JetBrains/intellij-community/pull/1003#discussion_r239773159"},"pull_request":{"href":"https://api.github.com/repos/JetBrains/intellij-community/pulls/1003"}}},"pull_request":{"url":"https://api.github.com/repos/JetBrains/intellij-community/pulls/1003","id":236195683,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MTk1Njgz","html_url":"https://github.com/JetBrains/intellij-community/pull/1003","diff_url":"https://github.com/JetBrains/intellij-community/pull/1003.diff","patch_url":"https://github.com/JetBrains/intellij-community/pull/1003.patch","issue_url":"https://api.github.com/repos/JetBrains/intellij-community/issues/1003","number":1003,"state":"open","locked":false,"title":"IDEA-203651: Improve check that source root type is for tests","user":{"login":"ausatiy","id":12068549,"node_id":"MDQ6VXNlcjEyMDY4NTQ5","avatar_url":"https://avatars1.githubusercontent.com/u/12068549?v=4","gravatar_id":"","url":"https://api.github.com/users/ausatiy","html_url":"https://github.com/ausatiy","followers_url":"https://api.github.com/users/ausatiy/followers","following_url":"https://api.github.com/users/ausatiy/following{/other_user}","gists_url":"https://api.github.com/users/ausatiy/gists{/gist_id}","starred_url":"https://api.github.com/users/ausatiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ausatiy/subscriptions","organizations_url":"https://api.github.com/users/ausatiy/orgs","repos_url":"https://api.github.com/users/ausatiy/repos","events_url":"https://api.github.com/users/ausatiy/events{/privacy}","received_events_url":"https://api.github.com/users/ausatiy/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-05T14:33:32Z","updated_at":"2018-12-07T11:16:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f9066a57de436073bfea61225b14ad4e36c716f2","assignee":{"login":"chashnikov","id":978014,"node_id":"MDQ6VXNlcjk3ODAxNA==","avatar_url":"https://avatars0.githubusercontent.com/u/978014?v=4","gravatar_id":"","url":"https://api.github.com/users/chashnikov","html_url":"https://github.com/chashnikov","followers_url":"https://api.github.com/users/chashnikov/followers","following_url":"https://api.github.com/users/chashnikov/following{/other_user}","gists_url":"https://api.github.com/users/chashnikov/gists{/gist_id}","starred_url":"https://api.github.com/users/chashnikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chashnikov/subscriptions","organizations_url":"https://api.github.com/users/chashnikov/orgs","repos_url":"https://api.github.com/users/chashnikov/repos","events_url":"https://api.github.com/users/chashnikov/events{/privacy}","received_events_url":"https://api.github.com/users/chashnikov/received_events","type":"User","site_admin":false},"assignees":[{"login":"chashnikov","id":978014,"node_id":"MDQ6VXNlcjk3ODAxNA==","avatar_url":"https://avatars0.githubusercontent.com/u/978014?v=4","gravatar_id":"","url":"https://api.github.com/users/chashnikov","html_url":"https://github.com/chashnikov","followers_url":"https://api.github.com/users/chashnikov/followers","following_url":"https://api.github.com/users/chashnikov/following{/other_user}","gists_url":"https://api.github.com/users/chashnikov/gists{/gist_id}","starred_url":"https://api.github.com/users/chashnikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chashnikov/subscriptions","organizations_url":"https://api.github.com/users/chashnikov/orgs","repos_url":"https://api.github.com/users/chashnikov/repos","events_url":"https://api.github.com/users/chashnikov/events{/privacy}","received_events_url":"https://api.github.com/users/chashnikov/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JetBrains/intellij-community/pulls/1003/commits","review_comments_url":"https://api.github.com/repos/JetBrains/intellij-community/pulls/1003/comments","review_comment_url":"https://api.github.com/repos/JetBrains/intellij-community/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JetBrains/intellij-community/issues/1003/comments","statuses_url":"https://api.github.com/repos/JetBrains/intellij-community/statuses/31417affbda09db4785a6c24345774adb422d079","head":{"label":"ausatiy:IDEA-203651","ref":"IDEA-203651","sha":"31417affbda09db4785a6c24345774adb422d079","user":{"login":"ausatiy","id":12068549,"node_id":"MDQ6VXNlcjEyMDY4NTQ5","avatar_url":"https://avatars1.githubusercontent.com/u/12068549?v=4","gravatar_id":"","url":"https://api.github.com/users/ausatiy","html_url":"https://github.com/ausatiy","followers_url":"https://api.github.com/users/ausatiy/followers","following_url":"https://api.github.com/users/ausatiy/following{/other_user}","gists_url":"https://api.github.com/users/ausatiy/gists{/gist_id}","starred_url":"https://api.github.com/users/ausatiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ausatiy/subscriptions","organizations_url":"https://api.github.com/users/ausatiy/orgs","repos_url":"https://api.github.com/users/ausatiy/repos","events_url":"https://api.github.com/users/ausatiy/events{/privacy}","received_events_url":"https://api.github.com/users/ausatiy/received_events","type":"User","site_admin":false},"repo":{"id":154660543,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ2NjA1NDM=","name":"intellij-community","full_name":"ausatiy/intellij-community","private":false,"owner":{"login":"ausatiy","id":12068549,"node_id":"MDQ6VXNlcjEyMDY4NTQ5","avatar_url":"https://avatars1.githubusercontent.com/u/12068549?v=4","gravatar_id":"","url":"https://api.github.com/users/ausatiy","html_url":"https://github.com/ausatiy","followers_url":"https://api.github.com/users/ausatiy/followers","following_url":"https://api.github.com/users/ausatiy/following{/other_user}","gists_url":"https://api.github.com/users/ausatiy/gists{/gist_id}","starred_url":"https://api.github.com/users/ausatiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ausatiy/subscriptions","organizations_url":"https://api.github.com/users/ausatiy/orgs","repos_url":"https://api.github.com/users/ausatiy/repos","events_url":"https://api.github.com/users/ausatiy/events{/privacy}","received_events_url":"https://api.github.com/users/ausatiy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ausatiy/intellij-community","description":"IntelliJ IDEA Community Edition","fork":true,"url":"https://api.github.com/repos/ausatiy/intellij-community","forks_url":"https://api.github.com/repos/ausatiy/intellij-community/forks","keys_url":"https://api.github.com/repos/ausatiy/intellij-community/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ausatiy/intellij-community/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ausatiy/intellij-community/teams","hooks_url":"https://api.github.com/repos/ausatiy/intellij-community/hooks","issue_events_url":"https://api.github.com/repos/ausatiy/intellij-community/issues/events{/number}","events_url":"https://api.github.com/repos/ausatiy/intellij-community/events","assignees_url":"https://api.github.com/repos/ausatiy/intellij-community/assignees{/user}","branches_url":"https://api.github.com/repos/ausatiy/intellij-community/branches{/branch}","tags_url":"https://api.github.com/repos/ausatiy/intellij-community/tags","blobs_url":"https://api.github.com/repos/ausatiy/intellij-community/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ausatiy/intellij-community/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ausatiy/intellij-community/git/refs{/sha}","trees_url":"https://api.github.com/repos/ausatiy/intellij-community/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ausatiy/intellij-community/statuses/{sha}","languages_url":"https://api.github.com/repos/ausatiy/intellij-community/languages","stargazers_url":"https://api.github.com/repos/ausatiy/intellij-community/stargazers","contributors_url":"https://api.github.com/repos/ausatiy/intellij-community/contributors","subscribers_url":"https://api.github.com/repos/ausatiy/intellij-community/subscribers","subscription_url":"https://api.github.com/repos/ausatiy/intellij-community/subscription","commits_url":"https://api.github.com/repos/ausatiy/intellij-community/commits{/sha}","git_commits_url":"https://api.github.com/repos/ausatiy/intellij-community/git/commits{/sha}","comments_url":"https://api.github.com/repos/ausatiy/intellij-community/comments{/number}","issue_comment_url":"https://api.github.com/repos/ausatiy/intellij-community/issues/comments{/number}","contents_url":"https://api.github.com/repos/ausatiy/intellij-community/contents/{+path}","compare_url":"https://api.github.com/repos/ausatiy/intellij-community/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ausatiy/intellij-community/merges","archive_url":"https://api.github.com/repos/ausatiy/intellij-community/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ausatiy/intellij-community/downloads","issues_url":"https://api.github.com/repos/ausatiy/intellij-community/issues{/number}","pulls_url":"https://api.github.com/repos/ausatiy/intellij-community/pulls{/number}","milestones_url":"https://api.github.com/repos/ausatiy/intellij-community/milestones{/number}","notifications_url":"https://api.github.com/repos/ausatiy/intellij-community/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ausatiy/intellij-community/labels{/name}","releases_url":"https://api.github.com/repos/ausatiy/intellij-community/releases{/id}","deployments_url":"https://api.github.com/repos/ausatiy/intellij-community/deployments","created_at":"2018-10-25T11:36:36Z","updated_at":"2018-10-25T11:41:06Z","pushed_at":"2018-12-05T14:31:08Z","git_url":"git://github.com/ausatiy/intellij-community.git","ssh_url":"git@github.com:ausatiy/intellij-community.git","clone_url":"https://github.com/ausatiy/intellij-community.git","svn_url":"https://github.com/ausatiy/intellij-community","homepage":"http://www.jetbrains.com/idea/","size":3039123,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JetBrains:master","ref":"master","sha":"3e6ce37c72f07a9b299fd0d0d228391d4b909419","user":{"login":"JetBrains","id":878437,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3ODQzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/878437?v=4","gravatar_id":"","url":"https://api.github.com/users/JetBrains","html_url":"https://github.com/JetBrains","followers_url":"https://api.github.com/users/JetBrains/followers","following_url":"https://api.github.com/users/JetBrains/following{/other_user}","gists_url":"https://api.github.com/users/JetBrains/gists{/gist_id}","starred_url":"https://api.github.com/users/JetBrains/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JetBrains/subscriptions","organizations_url":"https://api.github.com/users/JetBrains/orgs","repos_url":"https://api.github.com/users/JetBrains/repos","events_url":"https://api.github.com/users/JetBrains/events{/privacy}","received_events_url":"https://api.github.com/users/JetBrains/received_events","type":"Organization","site_admin":false},"repo":{"id":2489216,"node_id":"MDEwOlJlcG9zaXRvcnkyNDg5MjE2","name":"intellij-community","full_name":"JetBrains/intellij-community","private":false,"owner":{"login":"JetBrains","id":878437,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3ODQzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/878437?v=4","gravatar_id":"","url":"https://api.github.com/users/JetBrains","html_url":"https://github.com/JetBrains","followers_url":"https://api.github.com/users/JetBrains/followers","following_url":"https://api.github.com/users/JetBrains/following{/other_user}","gists_url":"https://api.github.com/users/JetBrains/gists{/gist_id}","starred_url":"https://api.github.com/users/JetBrains/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JetBrains/subscriptions","organizations_url":"https://api.github.com/users/JetBrains/orgs","repos_url":"https://api.github.com/users/JetBrains/repos","events_url":"https://api.github.com/users/JetBrains/events{/privacy}","received_events_url":"https://api.github.com/users/JetBrains/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JetBrains/intellij-community","description":"IntelliJ IDEA Community Edition","fork":false,"url":"https://api.github.com/repos/JetBrains/intellij-community","forks_url":"https://api.github.com/repos/JetBrains/intellij-community/forks","keys_url":"https://api.github.com/repos/JetBrains/intellij-community/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JetBrains/intellij-community/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JetBrains/intellij-community/teams","hooks_url":"https://api.github.com/repos/JetBrains/intellij-community/hooks","issue_events_url":"https://api.github.com/repos/JetBrains/intellij-community/issues/events{/number}","events_url":"https://api.github.com/repos/JetBrains/intellij-community/events","assignees_url":"https://api.github.com/repos/JetBrains/intellij-community/assignees{/user}","branches_url":"https://api.github.com/repos/JetBrains/intellij-community/branches{/branch}","tags_url":"https://api.github.com/repos/JetBrains/intellij-community/tags","blobs_url":"https://api.github.com/repos/JetBrains/intellij-community/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JetBrains/intellij-community/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JetBrains/intellij-community/git/refs{/sha}","trees_url":"https://api.github.com/repos/JetBrains/intellij-community/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JetBrains/intellij-community/statuses/{sha}","languages_url":"https://api.github.com/repos/JetBrains/intellij-community/languages","stargazers_url":"https://api.github.com/repos/JetBrains/intellij-community/stargazers","contributors_url":"https://api.github.com/repos/JetBrains/intellij-community/contributors","subscribers_url":"https://api.github.com/repos/JetBrains/intellij-community/subscribers","subscription_url":"https://api.github.com/repos/JetBrains/intellij-community/subscription","commits_url":"https://api.github.com/repos/JetBrains/intellij-community/commits{/sha}","git_commits_url":"https://api.github.com/repos/JetBrains/intellij-community/git/commits{/sha}","comments_url":"https://api.github.com/repos/JetBrains/intellij-community/comments{/number}","issue_comment_url":"https://api.github.com/repos/JetBrains/intellij-community/issues/comments{/number}","contents_url":"https://api.github.com/repos/JetBrains/intellij-community/contents/{+path}","compare_url":"https://api.github.com/repos/JetBrains/intellij-community/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JetBrains/intellij-community/merges","archive_url":"https://api.github.com/repos/JetBrains/intellij-community/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JetBrains/intellij-community/downloads","issues_url":"https://api.github.com/repos/JetBrains/intellij-community/issues{/number}","pulls_url":"https://api.github.com/repos/JetBrains/intellij-community/pulls{/number}","milestones_url":"https://api.github.com/repos/JetBrains/intellij-community/milestones{/number}","notifications_url":"https://api.github.com/repos/JetBrains/intellij-community/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JetBrains/intellij-community/labels{/name}","releases_url":"https://api.github.com/repos/JetBrains/intellij-community/releases{/id}","deployments_url":"https://api.github.com/repos/JetBrains/intellij-community/deployments","created_at":"2011-09-30T13:33:05Z","updated_at":"2018-12-07T11:05:31Z","pushed_at":"2018-12-07T11:03:46Z","git_url":"git://github.com/JetBrains/intellij-community.git","ssh_url":"git@github.com:JetBrains/intellij-community.git","clone_url":"https://github.com/JetBrains/intellij-community.git","svn_url":"https://github.com/JetBrains/intellij-community","homepage":"http://www.jetbrains.com/idea/","size":3043927,"stargazers_count":6985,"watchers_count":6985,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2573,"mirror_url":null,"archived":false,"open_issues_count":88,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2573,"open_issues":88,"watchers":6985,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JetBrains/intellij-community/pulls/1003"},"html":{"href":"https://github.com/JetBrains/intellij-community/pull/1003"},"issue":{"href":"https://api.github.com/repos/JetBrains/intellij-community/issues/1003"},"comments":{"href":"https://api.github.com/repos/JetBrains/intellij-community/issues/1003/comments"},"review_comments":{"href":"https://api.github.com/repos/JetBrains/intellij-community/pulls/1003/comments"},"review_comment":{"href":"https://api.github.com/repos/JetBrains/intellij-community/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JetBrains/intellij-community/pulls/1003/commits"},"statuses":{"href":"https://api.github.com/repos/JetBrains/intellij-community/statuses/31417affbda09db4785a6c24345774adb422d079"}},"author_association":"NONE"}}
{"actor":{"display_login":"chashnikov"}}