{"action":"created","comment":{"url":"https://api.github.com/repos/Linaro/odp/pulls/comments/168911371","pull_request_review_id":97362363,"id":168911371,"diff_hunk":"@@ -485,6 +486,11 @@ int odp_pktio_start(odp_pktio_t hdl)\n \t\tsched_fn->pktio_start(_odp_pktio_index(hdl), num, index, odpq);\n \t}\n \n+\tif (ODP_PCAPNG) {","path":"platform/linux-generic/odp_packet_io.c","position":12,"original_position":12,"commit_id":"72f4a9a5222f8e4572e83e5c2428d133668699d1","original_commit_id":"72f4a9a5222f8e4572e83e5c2428d133668699d1","user":{"login":"Bill-Fischofer-Linaro","id":13422322,"avatar_url":"https://avatars1.githubusercontent.com/u/13422322?v=4","gravatar_id":"","url":"https://api.github.com/users/Bill-Fischofer-Linaro","html_url":"https://github.com/Bill-Fischofer-Linaro","followers_url":"https://api.github.com/users/Bill-Fischofer-Linaro/followers","following_url":"https://api.github.com/users/Bill-Fischofer-Linaro/following{/other_user}","gists_url":"https://api.github.com/users/Bill-Fischofer-Linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/Bill-Fischofer-Linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bill-Fischofer-Linaro/subscriptions","organizations_url":"https://api.github.com/users/Bill-Fischofer-Linaro/orgs","repos_url":"https://api.github.com/users/Bill-Fischofer-Linaro/repos","events_url":"https://api.github.com/users/Bill-Fischofer-Linaro/events{/privacy}","received_events_url":"https://api.github.com/users/Bill-Fischofer-Linaro/received_events","type":"User","site_admin":false},"body":"@lumag This style ensures that the code is always syntax-checked since it is compiled, but then optimized away if it is not active. I've found this to be a useful idiom.","created_at":"2018-02-17T03:49:20Z","updated_at":"2018-02-17T04:02:27Z","html_url":"https://github.com/Linaro/odp/pull/488#discussion_r168911371","pull_request_url":"https://api.github.com/repos/Linaro/odp/pulls/488","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Linaro/odp/pulls/comments/168911371"},"html":{"href":"https://github.com/Linaro/odp/pull/488#discussion_r168911371"},"pull_request":{"href":"https://api.github.com/repos/Linaro/odp/pulls/488"}},"in_reply_to_id":168844040},"pull_request":{"url":"https://api.github.com/repos/Linaro/odp/pulls/488","id":169620991,"html_url":"https://github.com/Linaro/odp/pull/488","diff_url":"https://github.com/Linaro/odp/pull/488.diff","patch_url":"https://github.com/Linaro/odp/pull/488.patch","issue_url":"https://api.github.com/repos/Linaro/odp/issues/488","number":488,"state":"open","locked":false,"title":"[PATCH v1] odp: pktio: add pcapng capture capabilities","user":{"login":"apalos","id":7594369,"avatar_url":"https://avatars0.githubusercontent.com/u/7594369?v=4","gravatar_id":"","url":"https://api.github.com/users/apalos","html_url":"https://github.com/apalos","followers_url":"https://api.github.com/users/apalos/followers","following_url":"https://api.github.com/users/apalos/following{/other_user}","gists_url":"https://api.github.com/users/apalos/gists{/gist_id}","starred_url":"https://api.github.com/users/apalos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apalos/subscriptions","organizations_url":"https://api.github.com/users/apalos/orgs","repos_url":"https://api.github.com/users/apalos/repos","events_url":"https://api.github.com/users/apalos/events{/privacy}","received_events_url":"https://api.github.com/users/apalos/received_events","type":"User","site_admin":false},"body":"Changes since RFC:\r\n\t- addressed issues reported in RFC\r\n\t- rewrote some functions for easier understanding\r\n\t- added capability on all input queues\r\n\r\nHow to test:\r\nsudo mkdir /var/run/odp/\r\nstart the ODP application\r\nsudo dd if=/var/run/odp/\"odp pid\"-\"inteface\"-flow-\"queue number\" of=~/test.pcap\r\n\r\nSigned-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>","created_at":"2018-02-16T13:13:10Z","updated_at":"2018-02-17T04:02:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05c872d9718c0e866381663993e70b761761d444","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":577854052,"url":"https://api.github.com/repos/Linaro/odp/labels/Email_sent","name":"Email_sent","color":"ededed","default":false},{"id":666131932,"url":"https://api.github.com/repos/Linaro/odp/labels/checkpatch","name":"checkpatch","color":"0000ff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Linaro/odp/pulls/488/commits","review_comments_url":"https://api.github.com/repos/Linaro/odp/pulls/488/comments","review_comment_url":"https://api.github.com/repos/Linaro/odp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Linaro/odp/issues/488/comments","statuses_url":"https://api.github.com/repos/Linaro/odp/statuses/72f4a9a5222f8e4572e83e5c2428d133668699d1","head":{"label":"apalos:tcpdump_like","ref":"tcpdump_like","sha":"72f4a9a5222f8e4572e83e5c2428d133668699d1","user":{"login":"apalos","id":7594369,"avatar_url":"https://avatars0.githubusercontent.com/u/7594369?v=4","gravatar_id":"","url":"https://api.github.com/users/apalos","html_url":"https://github.com/apalos","followers_url":"https://api.github.com/users/apalos/followers","following_url":"https://api.github.com/users/apalos/following{/other_user}","gists_url":"https://api.github.com/users/apalos/gists{/gist_id}","starred_url":"https://api.github.com/users/apalos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apalos/subscriptions","organizations_url":"https://api.github.com/users/apalos/orgs","repos_url":"https://api.github.com/users/apalos/repos","events_url":"https://api.github.com/users/apalos/events{/privacy}","received_events_url":"https://api.github.com/users/apalos/received_events","type":"User","site_admin":false},"repo":{"id":99039695,"name":"odp","full_name":"apalos/odp","owner":{"login":"apalos","id":7594369,"avatar_url":"https://avatars0.githubusercontent.com/u/7594369?v=4","gravatar_id":"","url":"https://api.github.com/users/apalos","html_url":"https://github.com/apalos","followers_url":"https://api.github.com/users/apalos/followers","following_url":"https://api.github.com/users/apalos/following{/other_user}","gists_url":"https://api.github.com/users/apalos/gists{/gist_id}","starred_url":"https://api.github.com/users/apalos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apalos/subscriptions","organizations_url":"https://api.github.com/users/apalos/orgs","repos_url":"https://api.github.com/users/apalos/repos","events_url":"https://api.github.com/users/apalos/events{/privacy}","received_events_url":"https://api.github.com/users/apalos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/apalos/odp","description":"The ODP project is an open-source, cross-platform set of application programming interfaces (APIs) for the networking data plane","fork":true,"url":"https://api.github.com/repos/apalos/odp","forks_url":"https://api.github.com/repos/apalos/odp/forks","keys_url":"https://api.github.com/repos/apalos/odp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apalos/odp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apalos/odp/teams","hooks_url":"https://api.github.com/repos/apalos/odp/hooks","issue_events_url":"https://api.github.com/repos/apalos/odp/issues/events{/number}","events_url":"https://api.github.com/repos/apalos/odp/events","assignees_url":"https://api.github.com/repos/apalos/odp/assignees{/user}","branches_url":"https://api.github.com/repos/apalos/odp/branches{/branch}","tags_url":"https://api.github.com/repos/apalos/odp/tags","blobs_url":"https://api.github.com/repos/apalos/odp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apalos/odp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apalos/odp/git/refs{/sha}","trees_url":"https://api.github.com/repos/apalos/odp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apalos/odp/statuses/{sha}","languages_url":"https://api.github.com/repos/apalos/odp/languages","stargazers_url":"https://api.github.com/repos/apalos/odp/stargazers","contributors_url":"https://api.github.com/repos/apalos/odp/contributors","subscribers_url":"https://api.github.com/repos/apalos/odp/subscribers","subscription_url":"https://api.github.com/repos/apalos/odp/subscription","commits_url":"https://api.github.com/repos/apalos/odp/commits{/sha}","git_commits_url":"https://api.github.com/repos/apalos/odp/git/commits{/sha}","comments_url":"https://api.github.com/repos/apalos/odp/comments{/number}","issue_comment_url":"https://api.github.com/repos/apalos/odp/issues/comments{/number}","contents_url":"https://api.github.com/repos/apalos/odp/contents/{+path}","compare_url":"https://api.github.com/repos/apalos/odp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apalos/odp/merges","archive_url":"https://api.github.com/repos/apalos/odp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apalos/odp/downloads","issues_url":"https://api.github.com/repos/apalos/odp/issues{/number}","pulls_url":"https://api.github.com/repos/apalos/odp/pulls{/number}","milestones_url":"https://api.github.com/repos/apalos/odp/milestones{/number}","notifications_url":"https://api.github.com/repos/apalos/odp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apalos/odp/labels{/name}","releases_url":"https://api.github.com/repos/apalos/odp/releases{/id}","deployments_url":"https://api.github.com/repos/apalos/odp/deployments","created_at":"2017-08-01T20:17:14Z","updated_at":"2017-08-01T20:17:17Z","pushed_at":"2018-02-16T12:04:36Z","git_url":"git://github.com/apalos/odp.git","ssh_url":"git@github.com:apalos/odp.git","clone_url":"https://github.com/apalos/odp.git","svn_url":"https://github.com/apalos/odp","homepage":"http://www.opendataplane.org/","size":9921,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Linaro:master","ref":"master","sha":"ea529e1c3312459b6722c8a175d7f03ad0251a0a","user":{"login":"Linaro","id":1180626,"avatar_url":"https://avatars0.githubusercontent.com/u/1180626?v=4","gravatar_id":"","url":"https://api.github.com/users/Linaro","html_url":"https://github.com/Linaro","followers_url":"https://api.github.com/users/Linaro/followers","following_url":"https://api.github.com/users/Linaro/following{/other_user}","gists_url":"https://api.github.com/users/Linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/Linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Linaro/subscriptions","organizations_url":"https://api.github.com/users/Linaro/orgs","repos_url":"https://api.github.com/users/Linaro/repos","events_url":"https://api.github.com/users/Linaro/events{/privacy}","received_events_url":"https://api.github.com/users/Linaro/received_events","type":"Organization","site_admin":false},"repo":{"id":79130215,"name":"odp","full_name":"Linaro/odp","owner":{"login":"Linaro","id":1180626,"avatar_url":"https://avatars0.githubusercontent.com/u/1180626?v=4","gravatar_id":"","url":"https://api.github.com/users/Linaro","html_url":"https://github.com/Linaro","followers_url":"https://api.github.com/users/Linaro/followers","following_url":"https://api.github.com/users/Linaro/following{/other_user}","gists_url":"https://api.github.com/users/Linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/Linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Linaro/subscriptions","organizations_url":"https://api.github.com/users/Linaro/orgs","repos_url":"https://api.github.com/users/Linaro/repos","events_url":"https://api.github.com/users/Linaro/events{/privacy}","received_events_url":"https://api.github.com/users/Linaro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Linaro/odp","description":"The ODP project is an open-source, cross-platform set of application programming interfaces (APIs) for the networking data plane","fork":false,"url":"https://api.github.com/repos/Linaro/odp","forks_url":"https://api.github.com/repos/Linaro/odp/forks","keys_url":"https://api.github.com/repos/Linaro/odp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Linaro/odp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Linaro/odp/teams","hooks_url":"https://api.github.com/repos/Linaro/odp/hooks","issue_events_url":"https://api.github.com/repos/Linaro/odp/issues/events{/number}","events_url":"https://api.github.com/repos/Linaro/odp/events","assignees_url":"https://api.github.com/repos/Linaro/odp/assignees{/user}","branches_url":"https://api.github.com/repos/Linaro/odp/branches{/branch}","tags_url":"https://api.github.com/repos/Linaro/odp/tags","blobs_url":"https://api.github.com/repos/Linaro/odp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Linaro/odp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Linaro/odp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Linaro/odp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Linaro/odp/statuses/{sha}","languages_url":"https://api.github.com/repos/Linaro/odp/languages","stargazers_url":"https://api.github.com/repos/Linaro/odp/stargazers","contributors_url":"https://api.github.com/repos/Linaro/odp/contributors","subscribers_url":"https://api.github.com/repos/Linaro/odp/subscribers","subscription_url":"https://api.github.com/repos/Linaro/odp/subscription","commits_url":"https://api.github.com/repos/Linaro/odp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Linaro/odp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Linaro/odp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Linaro/odp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Linaro/odp/contents/{+path}","compare_url":"https://api.github.com/repos/Linaro/odp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Linaro/odp/merges","archive_url":"https://api.github.com/repos/Linaro/odp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Linaro/odp/downloads","issues_url":"https://api.github.com/repos/Linaro/odp/issues{/number}","pulls_url":"https://api.github.com/repos/Linaro/odp/pulls{/number}","milestones_url":"https://api.github.com/repos/Linaro/odp/milestones{/number}","notifications_url":"https://api.github.com/repos/Linaro/odp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Linaro/odp/labels{/name}","releases_url":"https://api.github.com/repos/Linaro/odp/releases{/id}","deployments_url":"https://api.github.com/repos/Linaro/odp/deployments","created_at":"2017-01-16T15:11:12Z","updated_at":"2018-02-01T11:11:45Z","pushed_at":"2018-02-17T01:48:15Z","git_url":"git://github.com/Linaro/odp.git","ssh_url":"git@github.com:Linaro/odp.git","clone_url":"https://github.com/Linaro/odp.git","svn_url":"https://github.com/Linaro/odp","homepage":"http://www.opendataplane.org/","size":10807,"stargazers_count":37,"watchers_count":37,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":47,"open_issues":27,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Linaro/odp/pulls/488"},"html":{"href":"https://github.com/Linaro/odp/pull/488"},"issue":{"href":"https://api.github.com/repos/Linaro/odp/issues/488"},"comments":{"href":"https://api.github.com/repos/Linaro/odp/issues/488/comments"},"review_comments":{"href":"https://api.github.com/repos/Linaro/odp/pulls/488/comments"},"review_comment":{"href":"https://api.github.com/repos/Linaro/odp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Linaro/odp/pulls/488/commits"},"statuses":{"href":"https://api.github.com/repos/Linaro/odp/statuses/72f4a9a5222f8e4572e83e5c2428d133668699d1"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Bill-Fischofer-Linaro"}}