{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/22957","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/22957/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/22957/comments","events_url":"https://api.github.com/repos/apache/spark/issues/22957/events","html_url":"https://github.com/apache/spark/pull/22957","id":377917724,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NzQ1Nzkx","number":22957,"title":"[SPARK-25951][SQL] Ignore aliases for distributions and orderings","user":{"login":"mgaido91","id":8821783,"node_id":"MDQ6VXNlcjg4MjE3ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/8821783?v=4","gravatar_id":"","url":"https://api.github.com/users/mgaido91","html_url":"https://github.com/mgaido91","followers_url":"https://api.github.com/users/mgaido91/followers","following_url":"https://api.github.com/users/mgaido91/following{/other_user}","gists_url":"https://api.github.com/users/mgaido91/gists{/gist_id}","starred_url":"https://api.github.com/users/mgaido91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgaido91/subscriptions","organizations_url":"https://api.github.com/users/mgaido91/orgs","repos_url":"https://api.github.com/users/mgaido91/repos","events_url":"https://api.github.com/users/mgaido91/events{/privacy}","received_events_url":"https://api.github.com/users/mgaido91/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":22,"created_at":"2018-11-06T16:07:10Z","updated_at":"2018-11-30T18:16:52Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/22957","html_url":"https://github.com/apache/spark/pull/22957","diff_url":"https://github.com/apache/spark/pull/22957.diff","patch_url":"https://github.com/apache/spark/pull/22957.patch"},"body":"## What changes were proposed in this pull request?\r\n\r\nWhen we canonicalize an `Expression`, we do not remove `Alias`. So two expressions which are the same but are renamed are considered to be semantically different. As we rely on semantic equality in order to check if the result is the same for 2 expressions, some optimizations - as showed in the JIRA - may fail to apply, eg. removing redundant shuffles, when a column is renamed.\r\n\r\nThe PR proposes to ignore `Alias`es when checking whether distributions and orderings are satisfied by introducing a new method `sameResults` which ignore `Alias`es.\r\n\r\n## How was this patch tested?\r\n\r\nadded UT"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/443291952","html_url":"https://github.com/apache/spark/pull/22957#issuecomment-443291952","issue_url":"https://api.github.com/repos/apache/spark/issues/22957","id":443291952,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzI5MTk1Mg==","user":{"login":"SparkQA","id":8108735,"node_id":"MDQ6VXNlcjgxMDg3MzU=","avatar_url":"https://avatars1.githubusercontent.com/u/8108735?v=4","gravatar_id":"","url":"https://api.github.com/users/SparkQA","html_url":"https://github.com/SparkQA","followers_url":"https://api.github.com/users/SparkQA/followers","following_url":"https://api.github.com/users/SparkQA/following{/other_user}","gists_url":"https://api.github.com/users/SparkQA/gists{/gist_id}","starred_url":"https://api.github.com/users/SparkQA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SparkQA/subscriptions","organizations_url":"https://api.github.com/users/SparkQA/orgs","repos_url":"https://api.github.com/users/SparkQA/repos","events_url":"https://api.github.com/users/SparkQA/events{/privacy}","received_events_url":"https://api.github.com/users/SparkQA/received_events","type":"User","site_admin":false},"created_at":"2018-11-30T18:16:52Z","updated_at":"2018-11-30T18:16:52Z","author_association":"NONE","body":"**[Test build #99522 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99522/testReport)** for PR 22957 at commit [`5bca5e3`](https://github.com/apache/spark/commit/5bca5e348f9ee6d1f00a5f68666e991160498ed7)."}}
{"actor":{"display_login":"SparkQA"}}