{"action":"created","issue":{"url":"https://api.github.com/repos/StrikeNP/trac_test/issues/693","repository_url":"https://api.github.com/repos/StrikeNP/trac_test","labels_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/693/labels{/name}","comments_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/693/comments","events_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/693/events","html_url":"https://github.com/StrikeNP/trac_test/issues/693","id":334662917,"node_id":"MDU6SXNzdWUzMzQ2NjI5MTc=","number":693,"title":"Delete the old SILHS correlation code (Trac #693)","user":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"labels":[{"id":971577014,"node_id":"MDU6TGFiZWw5NzE1NzcwMTQ=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/Migrated%20from%20Trac","name":"Migrated from Trac","color":"FFFFFF","default":false},{"id":971577274,"node_id":"MDU6TGFiZWw5NzE1NzcyNzQ=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/clubb_src","name":"clubb_src","color":"FFFFFF","default":false},{"id":971577020,"node_id":"MDU6TGFiZWw5NzE1NzcwMjA=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/defect","name":"defect","color":"FFFFFF","default":false},{"id":971588502,"node_id":"MDU6TGFiZWw5NzE1ODg1MDI=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/schemena@uwm.edu","name":"schemena@uwm.edu","color":"FFFFFF","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/StrikeNP/trac_test/milestones/4","html_url":"https://github.com/StrikeNP/trac_test/milestone/4","labels_url":"https://api.github.com/repos/StrikeNP/trac_test/milestones/4/labels","id":3442833,"node_id":"MDk6TWlsZXN0b25lMzQ0MjgzMw==","number":4,"title":"3. Refactor CLUBB","description":null,"creator":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"open_issues":30,"closed_issues":114,"state":"open","created_at":"2018-06-21T18:01:51Z","updated_at":"2018-06-23T20:15:08Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2018-06-21T21:22:48Z","updated_at":"2018-06-23T20:16:12Z","closed_at":null,"author_association":"OWNER","body":"**Introduction**\n\nThere are two versions of SILHS: one that computes its own variances and correlations for the hydrometeors and one that uses the code in `setup_pdf_parameters`. We want to get rid of the former, older code.\n\n**Technical spec**\n\nLet's run the RICO case using both versions of SILHS and compare it with the analytic solution. If the new code doesn't look too much worse, we can delete the old code.\n\nWe can remove the `l_use_modified_corr` flag.\n\n**Test**\n\nOutput should not change in the default configuration, which sets `l_use_modified_corr = .true.`.\n\nAttachments:\n\n[plot_explicit_ta_configs.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_explicit_ta_configs.maff)\n[plot_new_pdf_config_1_plot_2.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_new_pdf_config_1_plot_2.maff)\n[plot_combo_pdf_run_3.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_combo_pdf_run_3.maff)\n[plot_input_fields_rtp3_thlp3_1.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_input_fields_rtp3_thlp3_1.maff)\n[plot_new_pdf_20180522_test_1.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_new_pdf_20180522_test_1.maff)\n[plot_attempts_8_10.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_attempts_8_10.maff)\n[plot_attempt_8_only.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_attempt_8_only.maff)\n[plot_beta_1p3.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_beta_1p3.maff)\n[plot_beta_1p3_all.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_beta_1p3_all.maff)\n\nMigrated from http://carson.math.uwm.edu/trac/clubb/ticket/693\n```json\n{\n    \"status\": \"closed\", \n    \"changetime\": \"2014-07-17T14:02:07\", \n    \"description\": \"'''Introduction'''\\n\\nThere are two versions of SILHS: one that computes its own variances and correlations for the hydrometeors and one that uses the code in `setup_pdf_parameters`. We want to get rid of the former, older code.\\n\\n'''Technical spec'''\\n\\nLet's run the RICO case using both versions of SILHS and compare it with the analytic solution. If the new code doesn't look too much worse, we can delete the old code.\\n\\nWe can remove the `l_use_modified_corr` flag.\\n\\n'''Test'''\\n\\nOutput should not change in the default configuration, which sets `l_use_modified_corr = .true.`.\", \n    \"reporter\": \"raut@uwm.edu\", \n    \"cc\": \"vlarson@uwm.edu, janhft@uwm.edu\", \n    \"resolution\": \"fixed\", \n    \"_ts\": \"1405605727146907\", \n    \"component\": \"clubb_src\", \n    \"summary\": \"Delete the old SILHS correlation code\", \n    \"priority\": \"minor\", \n    \"keywords\": \"remove duplicate code\", \n    \"time\": \"2014-06-04T21:43:16\", \n    \"milestone\": \"3. Refactor CLUBB\", \n    \"owner\": \"schemena@uwm.edu\", \n    \"type\": \"defect\"\n}\n```\n"},"comment":{"url":"https://api.github.com/repos/StrikeNP/trac_test/issues/comments/399706198","html_url":"https://github.com/StrikeNP/trac_test/issues/693#issuecomment-399706198","issue_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/693","id":399706198,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTcwNjE5OA==","user":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"created_at":"2018-06-23T20:16:11Z","updated_at":"2018-06-23T20:16:11Z","author_association":"OWNER","body":"**Trac update on 2014/07/15 at 15:33**\n**schemena@uwm.edu commented:**\n\nCommit comment from sam_clubb:r1435:\n\nFor https://github.com/larson-group/clubb/issues/693. Updated SAM to reflect the changes in clubb:r7067.\n\n"}}
{"actor":{"display_login":"StrikeNP"}}