{"action":"created","comment":{"url":"https://api.github.com/repos/patternfly/patternfly-next/pulls/comments/214341258","pull_request_review_id":151378903,"id":214341258,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDM0MTI1OA==","diff_hunk":"@@ -0,0 +1,100 @@\n+@import \"../../patternfly-utilities\";\n+\n+.pf-l-login {\n+  --pf-l-login--PaddingTop: var(--pf-global--spacer--lg);\n+  --pf-l-login--PaddingBottom: var(--pf-global--spacer--lg);\n+  --pf-l-login__container--GridColumnGap: var(--pf-global--spacer--3xl);\n+\n+  // This is a magic number to prevent the login layout grow more than what's defined in the specs.\n+  --pf-l-login__container--MaxWidth: pf-size-prem(500px);\n+\n+  // These next 2 variables are full of magic numbers, they are unique to the login layout\n+  --pf-l-login__container--GridTemplateColumns: minmax(0, calc(98px - var(--pf-l-login__container--GridColumnGap))) 544px minmax(auto, 544px) minmax(0, calc(98px - var(--pf-l-login__container--GridColumnGap)));","path":"src/patternfly/layouts/Login/styles.scss","position":12,"original_position":12,"commit_id":"c11dea6b53839b875893d141b8aae30863398663","original_commit_id":"c11dea6b53839b875893d141b8aae30863398663","user":{"login":"andresgalante","id":1832037,"node_id":"MDQ6VXNlcjE4MzIwMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/1832037?v=4","gravatar_id":"","url":"https://api.github.com/users/andresgalante","html_url":"https://github.com/andresgalante","followers_url":"https://api.github.com/users/andresgalante/followers","following_url":"https://api.github.com/users/andresgalante/following{/other_user}","gists_url":"https://api.github.com/users/andresgalante/gists{/gist_id}","starred_url":"https://api.github.com/users/andresgalante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresgalante/subscriptions","organizations_url":"https://api.github.com/users/andresgalante/orgs","repos_url":"https://api.github.com/users/andresgalante/repos","events_url":"https://api.github.com/users/andresgalante/events{/privacy}","received_events_url":"https://api.github.com/users/andresgalante/received_events","type":"User","site_admin":false},"body":"If we do a fixed padding, then they'll stay fix. What we wanted to do is for the padding to grow till they are a max of 98. That's why the minmax function.\r\n\r\nThe other math is to remove grid gaps to the 98px size.\r\n\r\n@mattnolting does it make sense, or is there a better way to do it?","created_at":"2018-08-31T12:45:44Z","updated_at":"2018-08-31T12:45:44Z","html_url":"https://github.com/patternfly/patternfly-next/pull/665#discussion_r214341258","pull_request_url":"https://api.github.com/repos/patternfly/patternfly-next/pulls/665","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/patternfly/patternfly-next/pulls/comments/214341258"},"html":{"href":"https://github.com/patternfly/patternfly-next/pull/665#discussion_r214341258"},"pull_request":{"href":"https://api.github.com/repos/patternfly/patternfly-next/pulls/665"}},"in_reply_to_id":214123312},"pull_request":{"url":"https://api.github.com/repos/patternfly/patternfly-next/pulls/665","id":211853856,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExODUzODU2","html_url":"https://github.com/patternfly/patternfly-next/pull/665","diff_url":"https://github.com/patternfly/patternfly-next/pull/665.diff","patch_url":"https://github.com/patternfly/patternfly-next/pull/665.patch","issue_url":"https://api.github.com/repos/patternfly/patternfly-next/issues/665","number":665,"state":"open","locked":false,"title":"Login screen base","user":{"login":"andresgalante","id":1832037,"node_id":"MDQ6VXNlcjE4MzIwMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/1832037?v=4","gravatar_id":"","url":"https://api.github.com/users/andresgalante","html_url":"https://github.com/andresgalante","followers_url":"https://api.github.com/users/andresgalante/followers","following_url":"https://api.github.com/users/andresgalante/following{/other_user}","gists_url":"https://api.github.com/users/andresgalante/gists{/gist_id}","starred_url":"https://api.github.com/users/andresgalante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresgalante/subscriptions","organizations_url":"https://api.github.com/users/andresgalante/orgs","repos_url":"https://api.github.com/users/andresgalante/repos","events_url":"https://api.github.com/users/andresgalante/events{/privacy}","received_events_url":"https://api.github.com/users/andresgalante/received_events","type":"User","site_admin":false},"body":"This PR closes #408 and closes #407 by creating the login box, layout, and basic and empty demo. \r\n\r\nThis demo should be the shell to place different components and accommodate different use cases.\r\n\r\nThe spaces are a bit different from the original mockup, but it has been reviewed and approved by @mceledonia (although Michael you can always change your mind if you want to change anything else)\r\n\r\n@jgiardino I didn't add any accecibility notes since I don't think it's needed here, am I wrong?\r\n\r\nStill to do is to create the demo that shows the mockup, we need a footer with inline white links, a grid of social badges and a form. We'll track in a new issue.\r\n\r\nrelated to #43 ","created_at":"2018-08-29T18:57:58Z","updated_at":"2018-08-31T12:45:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69c5259ba40b14b10e7539dc5685cfb5ce2558de","assignee":null,"assignees":[],"requested_reviewers":[{"login":"matthewcarleton","id":287880,"node_id":"MDQ6VXNlcjI4Nzg4MA==","avatar_url":"https://avatars1.githubusercontent.com/u/287880?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewcarleton","html_url":"https://github.com/matthewcarleton","followers_url":"https://api.github.com/users/matthewcarleton/followers","following_url":"https://api.github.com/users/matthewcarleton/following{/other_user}","gists_url":"https://api.github.com/users/matthewcarleton/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewcarleton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewcarleton/subscriptions","organizations_url":"https://api.github.com/users/matthewcarleton/orgs","repos_url":"https://api.github.com/users/matthewcarleton/repos","events_url":"https://api.github.com/users/matthewcarleton/events{/privacy}","received_events_url":"https://api.github.com/users/matthewcarleton/received_events","type":"User","site_admin":false},{"login":"andybraren","id":9122899,"node_id":"MDQ6VXNlcjkxMjI4OTk=","avatar_url":"https://avatars1.githubusercontent.com/u/9122899?v=4","gravatar_id":"","url":"https://api.github.com/users/andybraren","html_url":"https://github.com/andybraren","followers_url":"https://api.github.com/users/andybraren/followers","following_url":"https://api.github.com/users/andybraren/following{/other_user}","gists_url":"https://api.github.com/users/andybraren/gists{/gist_id}","starred_url":"https://api.github.com/users/andybraren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andybraren/subscriptions","organizations_url":"https://api.github.com/users/andybraren/orgs","repos_url":"https://api.github.com/users/andybraren/repos","events_url":"https://api.github.com/users/andybraren/events{/privacy}","received_events_url":"https://api.github.com/users/andybraren/received_events","type":"User","site_admin":false},{"login":"jgiardino","id":21063328,"node_id":"MDQ6VXNlcjIxMDYzMzI4","avatar_url":"https://avatars1.githubusercontent.com/u/21063328?v=4","gravatar_id":"","url":"https://api.github.com/users/jgiardino","html_url":"https://github.com/jgiardino","followers_url":"https://api.github.com/users/jgiardino/followers","following_url":"https://api.github.com/users/jgiardino/following{/other_user}","gists_url":"https://api.github.com/users/jgiardino/gists{/gist_id}","starred_url":"https://api.github.com/users/jgiardino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgiardino/subscriptions","organizations_url":"https://api.github.com/users/jgiardino/orgs","repos_url":"https://api.github.com/users/jgiardino/repos","events_url":"https://api.github.com/users/jgiardino/events{/privacy}","received_events_url":"https://api.github.com/users/jgiardino/received_events","type":"User","site_admin":false},{"login":"michael-coker","id":35148959,"node_id":"MDQ6VXNlcjM1MTQ4OTU5","avatar_url":"https://avatars0.githubusercontent.com/u/35148959?v=4","gravatar_id":"","url":"https://api.github.com/users/michael-coker","html_url":"https://github.com/michael-coker","followers_url":"https://api.github.com/users/michael-coker/followers","following_url":"https://api.github.com/users/michael-coker/following{/other_user}","gists_url":"https://api.github.com/users/michael-coker/gists{/gist_id}","starred_url":"https://api.github.com/users/michael-coker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michael-coker/subscriptions","organizations_url":"https://api.github.com/users/michael-coker/orgs","repos_url":"https://api.github.com/users/michael-coker/repos","events_url":"https://api.github.com/users/michael-coker/events{/privacy}","received_events_url":"https://api.github.com/users/michael-coker/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/patternfly/patternfly-next/pulls/665/commits","review_comments_url":"https://api.github.com/repos/patternfly/patternfly-next/pulls/665/comments","review_comment_url":"https://api.github.com/repos/patternfly/patternfly-next/pulls/comments{/number}","comments_url":"https://api.github.com/repos/patternfly/patternfly-next/issues/665/comments","statuses_url":"https://api.github.com/repos/patternfly/patternfly-next/statuses/c11dea6b53839b875893d141b8aae30863398663","head":{"label":"andresgalante:test","ref":"test","sha":"c11dea6b53839b875893d141b8aae30863398663","user":{"login":"andresgalante","id":1832037,"node_id":"MDQ6VXNlcjE4MzIwMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/1832037?v=4","gravatar_id":"","url":"https://api.github.com/users/andresgalante","html_url":"https://github.com/andresgalante","followers_url":"https://api.github.com/users/andresgalante/followers","following_url":"https://api.github.com/users/andresgalante/following{/other_user}","gists_url":"https://api.github.com/users/andresgalante/gists{/gist_id}","starred_url":"https://api.github.com/users/andresgalante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresgalante/subscriptions","organizations_url":"https://api.github.com/users/andresgalante/orgs","repos_url":"https://api.github.com/users/andresgalante/repos","events_url":"https://api.github.com/users/andresgalante/events{/privacy}","received_events_url":"https://api.github.com/users/andresgalante/received_events","type":"User","site_admin":false},"repo":{"id":124261076,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQyNjEwNzY=","name":"patternfly-next","full_name":"andresgalante/patternfly-next","owner":{"login":"andresgalante","id":1832037,"node_id":"MDQ6VXNlcjE4MzIwMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/1832037?v=4","gravatar_id":"","url":"https://api.github.com/users/andresgalante","html_url":"https://github.com/andresgalante","followers_url":"https://api.github.com/users/andresgalante/followers","following_url":"https://api.github.com/users/andresgalante/following{/other_user}","gists_url":"https://api.github.com/users/andresgalante/gists{/gist_id}","starred_url":"https://api.github.com/users/andresgalante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresgalante/subscriptions","organizations_url":"https://api.github.com/users/andresgalante/orgs","repos_url":"https://api.github.com/users/andresgalante/repos","events_url":"https://api.github.com/users/andresgalante/events{/privacy}","received_events_url":"https://api.github.com/users/andresgalante/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andresgalante/patternfly-next","description":"Working repo for patternfly next","fork":true,"url":"https://api.github.com/repos/andresgalante/patternfly-next","forks_url":"https://api.github.com/repos/andresgalante/patternfly-next/forks","keys_url":"https://api.github.com/repos/andresgalante/patternfly-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andresgalante/patternfly-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andresgalante/patternfly-next/teams","hooks_url":"https://api.github.com/repos/andresgalante/patternfly-next/hooks","issue_events_url":"https://api.github.com/repos/andresgalante/patternfly-next/issues/events{/number}","events_url":"https://api.github.com/repos/andresgalante/patternfly-next/events","assignees_url":"https://api.github.com/repos/andresgalante/patternfly-next/assignees{/user}","branches_url":"https://api.github.com/repos/andresgalante/patternfly-next/branches{/branch}","tags_url":"https://api.github.com/repos/andresgalante/patternfly-next/tags","blobs_url":"https://api.github.com/repos/andresgalante/patternfly-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andresgalante/patternfly-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andresgalante/patternfly-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/andresgalante/patternfly-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andresgalante/patternfly-next/statuses/{sha}","languages_url":"https://api.github.com/repos/andresgalante/patternfly-next/languages","stargazers_url":"https://api.github.com/repos/andresgalante/patternfly-next/stargazers","contributors_url":"https://api.github.com/repos/andresgalante/patternfly-next/contributors","subscribers_url":"https://api.github.com/repos/andresgalante/patternfly-next/subscribers","subscription_url":"https://api.github.com/repos/andresgalante/patternfly-next/subscription","commits_url":"https://api.github.com/repos/andresgalante/patternfly-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/andresgalante/patternfly-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/andresgalante/patternfly-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/andresgalante/patternfly-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/andresgalante/patternfly-next/contents/{+path}","compare_url":"https://api.github.com/repos/andresgalante/patternfly-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andresgalante/patternfly-next/merges","archive_url":"https://api.github.com/repos/andresgalante/patternfly-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andresgalante/patternfly-next/downloads","issues_url":"https://api.github.com/repos/andresgalante/patternfly-next/issues{/number}","pulls_url":"https://api.github.com/repos/andresgalante/patternfly-next/pulls{/number}","milestones_url":"https://api.github.com/repos/andresgalante/patternfly-next/milestones{/number}","notifications_url":"https://api.github.com/repos/andresgalante/patternfly-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andresgalante/patternfly-next/labels{/name}","releases_url":"https://api.github.com/repos/andresgalante/patternfly-next/releases{/id}","deployments_url":"https://api.github.com/repos/andresgalante/patternfly-next/deployments","created_at":"2018-03-07T16:09:27Z","updated_at":"2018-04-25T02:43:39Z","pushed_at":"2018-08-30T14:53:33Z","git_url":"git://github.com/andresgalante/patternfly-next.git","ssh_url":"git@github.com:andresgalante/patternfly-next.git","clone_url":"https://github.com/andresgalante/patternfly-next.git","svn_url":"https://github.com/andresgalante/patternfly-next","homepage":null,"size":18067,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"patternfly:master","ref":"master","sha":"6a0bd66be8febf602fd4b96e3124d49a4d805291","user":{"login":"patternfly","id":6391110,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTExMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6391110?v=4","gravatar_id":"","url":"https://api.github.com/users/patternfly","html_url":"https://github.com/patternfly","followers_url":"https://api.github.com/users/patternfly/followers","following_url":"https://api.github.com/users/patternfly/following{/other_user}","gists_url":"https://api.github.com/users/patternfly/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly/subscriptions","organizations_url":"https://api.github.com/users/patternfly/orgs","repos_url":"https://api.github.com/users/patternfly/repos","events_url":"https://api.github.com/users/patternfly/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly/received_events","type":"Organization","site_admin":false},"repo":{"id":122507459,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI1MDc0NTk=","name":"patternfly-next","full_name":"patternfly/patternfly-next","owner":{"login":"patternfly","id":6391110,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTExMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6391110?v=4","gravatar_id":"","url":"https://api.github.com/users/patternfly","html_url":"https://github.com/patternfly","followers_url":"https://api.github.com/users/patternfly/followers","following_url":"https://api.github.com/users/patternfly/following{/other_user}","gists_url":"https://api.github.com/users/patternfly/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly/subscriptions","organizations_url":"https://api.github.com/users/patternfly/orgs","repos_url":"https://api.github.com/users/patternfly/repos","events_url":"https://api.github.com/users/patternfly/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/patternfly/patternfly-next","description":"Working repo for PatternFly 4","fork":false,"url":"https://api.github.com/repos/patternfly/patternfly-next","forks_url":"https://api.github.com/repos/patternfly/patternfly-next/forks","keys_url":"https://api.github.com/repos/patternfly/patternfly-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patternfly/patternfly-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patternfly/patternfly-next/teams","hooks_url":"https://api.github.com/repos/patternfly/patternfly-next/hooks","issue_events_url":"https://api.github.com/repos/patternfly/patternfly-next/issues/events{/number}","events_url":"https://api.github.com/repos/patternfly/patternfly-next/events","assignees_url":"https://api.github.com/repos/patternfly/patternfly-next/assignees{/user}","branches_url":"https://api.github.com/repos/patternfly/patternfly-next/branches{/branch}","tags_url":"https://api.github.com/repos/patternfly/patternfly-next/tags","blobs_url":"https://api.github.com/repos/patternfly/patternfly-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patternfly/patternfly-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patternfly/patternfly-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/patternfly/patternfly-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patternfly/patternfly-next/statuses/{sha}","languages_url":"https://api.github.com/repos/patternfly/patternfly-next/languages","stargazers_url":"https://api.github.com/repos/patternfly/patternfly-next/stargazers","contributors_url":"https://api.github.com/repos/patternfly/patternfly-next/contributors","subscribers_url":"https://api.github.com/repos/patternfly/patternfly-next/subscribers","subscription_url":"https://api.github.com/repos/patternfly/patternfly-next/subscription","commits_url":"https://api.github.com/repos/patternfly/patternfly-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/patternfly/patternfly-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/patternfly/patternfly-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/patternfly/patternfly-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/patternfly/patternfly-next/contents/{+path}","compare_url":"https://api.github.com/repos/patternfly/patternfly-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patternfly/patternfly-next/merges","archive_url":"https://api.github.com/repos/patternfly/patternfly-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patternfly/patternfly-next/downloads","issues_url":"https://api.github.com/repos/patternfly/patternfly-next/issues{/number}","pulls_url":"https://api.github.com/repos/patternfly/patternfly-next/pulls{/number}","milestones_url":"https://api.github.com/repos/patternfly/patternfly-next/milestones{/number}","notifications_url":"https://api.github.com/repos/patternfly/patternfly-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patternfly/patternfly-next/labels{/name}","releases_url":"https://api.github.com/repos/patternfly/patternfly-next/releases{/id}","deployments_url":"https://api.github.com/repos/patternfly/patternfly-next/deployments","created_at":"2018-02-22T16:52:59Z","updated_at":"2018-08-31T12:16:19Z","pushed_at":"2018-08-31T12:21:39Z","git_url":"git://github.com/patternfly/patternfly-next.git","ssh_url":"git@github.com:patternfly/patternfly-next.git","clone_url":"https://github.com/patternfly/patternfly-next.git","svn_url":"https://github.com/patternfly/patternfly-next","homepage":"","size":39897,"stargazers_count":35,"watchers_count":35,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":180,"license":null,"forks":35,"open_issues":180,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/patternfly/patternfly-next/pulls/665"},"html":{"href":"https://github.com/patternfly/patternfly-next/pull/665"},"issue":{"href":"https://api.github.com/repos/patternfly/patternfly-next/issues/665"},"comments":{"href":"https://api.github.com/repos/patternfly/patternfly-next/issues/665/comments"},"review_comments":{"href":"https://api.github.com/repos/patternfly/patternfly-next/pulls/665/comments"},"review_comment":{"href":"https://api.github.com/repos/patternfly/patternfly-next/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/patternfly/patternfly-next/pulls/665/commits"},"statuses":{"href":"https://api.github.com/repos/patternfly/patternfly-next/statuses/c11dea6b53839b875893d141b8aae30863398663"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"andresgalante"}}