{"action":"created","issue":{"url":"https://api.github.com/repos/aiidateam/aiida_core/issues/2049","repository_url":"https://api.github.com/repos/aiidateam/aiida_core","labels_url":"https://api.github.com/repos/aiidateam/aiida_core/issues/2049/labels{/name}","comments_url":"https://api.github.com/repos/aiidateam/aiida_core/issues/2049/comments","events_url":"https://api.github.com/repos/aiidateam/aiida_core/issues/2049/events","html_url":"https://github.com/aiidateam/aiida_core/pull/2049","id":369145151,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMTU3MDQy","number":2049,"title":"[WIP] Fix several issues with the hashing method","user":{"login":"greschd","id":5692808,"node_id":"MDQ6VXNlcjU2OTI4MDg=","avatar_url":"https://avatars2.githubusercontent.com/u/5692808?v=4","gravatar_id":"","url":"https://api.github.com/users/greschd","html_url":"https://github.com/greschd","followers_url":"https://api.github.com/users/greschd/followers","following_url":"https://api.github.com/users/greschd/following{/other_user}","gists_url":"https://api.github.com/users/greschd/gists{/gist_id}","starred_url":"https://api.github.com/users/greschd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greschd/subscriptions","organizations_url":"https://api.github.com/users/greschd/orgs","repos_url":"https://api.github.com/users/greschd/repos","events_url":"https://api.github.com/users/greschd/events{/privacy}","received_events_url":"https://api.github.com/users/greschd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-10-11T14:20:18Z","updated_at":"2018-10-11T15:49:35Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/aiidateam/aiida_core/pulls/2049","html_url":"https://github.com/aiidateam/aiida_core/pull/2049","diff_url":"https://github.com/aiidateam/aiida_core/pull/2049.diff","patch_url":"https://github.com/aiidateam/aiida_core/pull/2049.patch"},"body":"Fixes #2008, #2009.\r\n\r\n* dict items are sorted _after_ hashing, fixing the behavior for\r\n  keys which can not be sorted\r\n* unicode/str and str/bytes are explicitly handled, with a different\r\n  type salt\r\n* in general, the combination between two hashes is done via the\r\n  method of boost::hash_combine, not by concatenating the hexdigest\r\n\r\nTODO: Add migration that deletes all stale hashes."},"comment":{"url":"https://api.github.com/repos/aiidateam/aiida_core/issues/comments/429008316","html_url":"https://github.com/aiidateam/aiida_core/pull/2049#issuecomment-429008316","issue_url":"https://api.github.com/repos/aiidateam/aiida_core/issues/2049","id":429008316,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTAwODMxNg==","user":{"login":"dev-zero","id":11307,"node_id":"MDQ6VXNlcjExMzA3","avatar_url":"https://avatars2.githubusercontent.com/u/11307?v=4","gravatar_id":"","url":"https://api.github.com/users/dev-zero","html_url":"https://github.com/dev-zero","followers_url":"https://api.github.com/users/dev-zero/followers","following_url":"https://api.github.com/users/dev-zero/following{/other_user}","gists_url":"https://api.github.com/users/dev-zero/gists{/gist_id}","starred_url":"https://api.github.com/users/dev-zero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dev-zero/subscriptions","organizations_url":"https://api.github.com/users/dev-zero/orgs","repos_url":"https://api.github.com/users/dev-zero/repos","events_url":"https://api.github.com/users/dev-zero/events{/privacy}","received_events_url":"https://api.github.com/users/dev-zero/received_events","type":"User","site_admin":false},"created_at":"2018-10-11T15:49:35Z","updated_at":"2018-10-11T15:49:35Z","author_association":"COLLABORATOR","body":"ok, I've tracked the boost hash mixing down to here: https://github.com/aappleby/smhasher/wiki/MurmurHash3\r\nThere the author proposes to use (for MurmurHash3) *[...] 128-bit versions for generating unique identifiers for large blocks of data [...]* ... which is exactly the case we have. Since there is no SHA smaller than 224bit SHA, we could either go with [mm3](https://pypi.org/project/mmh3) or [BLAKE2b](https://docs.python.org/3/library/hashlib.html#hashlib.blake2b)"}}
{"actor":{"display_login":"dev-zero"}}