{"action":"created","issue":{"url":"https://api.github.com/repos/capnproto/capnproto-rust/issues/112","repository_url":"https://api.github.com/repos/capnproto/capnproto-rust","labels_url":"https://api.github.com/repos/capnproto/capnproto-rust/issues/112/labels{/name}","comments_url":"https://api.github.com/repos/capnproto/capnproto-rust/issues/112/comments","events_url":"https://api.github.com/repos/capnproto/capnproto-rust/issues/112/events","html_url":"https://github.com/capnproto/capnproto-rust/pull/112","id":378528883,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MjE0MzIz","number":112,"title":"Address clippy warnings in autogenerated code","user":{"login":"ysimonson","id":127386,"node_id":"MDQ6VXNlcjEyNzM4Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/127386?v=4","gravatar_id":"","url":"https://api.github.com/users/ysimonson","html_url":"https://github.com/ysimonson","followers_url":"https://api.github.com/users/ysimonson/followers","following_url":"https://api.github.com/users/ysimonson/following{/other_user}","gists_url":"https://api.github.com/users/ysimonson/gists{/gist_id}","starred_url":"https://api.github.com/users/ysimonson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ysimonson/subscriptions","organizations_url":"https://api.github.com/users/ysimonson/orgs","repos_url":"https://api.github.com/users/ysimonson/repos","events_url":"https://api.github.com/users/ysimonson/events{/privacy}","received_events_url":"https://api.github.com/users/ysimonson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-08T00:34:24Z","updated_at":"2018-11-08T01:01:17Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/capnproto/capnproto-rust/pulls/112","html_url":"https://github.com/capnproto/capnproto-rust/pull/112","diff_url":"https://github.com/capnproto/capnproto-rust/pull/112.diff","patch_url":"https://github.com/capnproto/capnproto-rust/pull/112.patch"},"body":"This fixes most clippy warnings in capnpc autogenerated code, including:\r\n\r\n* https://rust-lang-nursery.github.io/rust-clippy/v0.0.212/index.html#needless_return\r\n* https://rust-lang-nursery.github.io/rust-clippy/v0.0.212/index.html#needless_lifetimes\r\n* https://rust-lang-nursery.github.io/rust-clippy/v0.0.212/index.html#cast_lossless\r\n* https://rust-lang-nursery.github.io/rust-clippy/v0.0.212/index.html#unit_arg\r\n\r\nThis does not semantically change the code that is generated, though the needless lifetimes fix might not be compatible with older versions of rustc (I seem to vaguely recall lifetime elison getting smarter at some point, so the explicit lifetimes may have been necessary to compile on older versions of rustc.)\r\n\r\nFor my schema, it reduces the warnings from several hundred to several dozen. The fix for the remaining warnings would require backwards-incompatible changes, so I will open a separate PR for that."},"comment":{"url":"https://api.github.com/repos/capnproto/capnproto-rust/issues/comments/436834921","html_url":"https://github.com/capnproto/capnproto-rust/pull/112#issuecomment-436834921","issue_url":"https://api.github.com/repos/capnproto/capnproto-rust/issues/112","id":436834921,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjgzNDkyMQ==","user":{"login":"dwrensha","id":495768,"node_id":"MDQ6VXNlcjQ5NTc2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/495768?v=4","gravatar_id":"","url":"https://api.github.com/users/dwrensha","html_url":"https://github.com/dwrensha","followers_url":"https://api.github.com/users/dwrensha/followers","following_url":"https://api.github.com/users/dwrensha/following{/other_user}","gists_url":"https://api.github.com/users/dwrensha/gists{/gist_id}","starred_url":"https://api.github.com/users/dwrensha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwrensha/subscriptions","organizations_url":"https://api.github.com/users/dwrensha/orgs","repos_url":"https://api.github.com/users/dwrensha/repos","events_url":"https://api.github.com/users/dwrensha/events{/privacy}","received_events_url":"https://api.github.com/users/dwrensha/received_events","type":"User","site_admin":false},"created_at":"2018-11-08T01:01:17Z","updated_at":"2018-11-08T01:01:17Z","author_association":"MEMBER","body":"Maybe try `cargo test --all`?\r\n"}}
{"actor":{"display_login":"dwrensha"}}