{"action":"created","issue":{"url":"https://api.github.com/repos/AlexFalappa/nb-springboot/issues/136","repository_url":"https://api.github.com/repos/AlexFalappa/nb-springboot","labels_url":"https://api.github.com/repos/AlexFalappa/nb-springboot/issues/136/labels{/name}","comments_url":"https://api.github.com/repos/AlexFalappa/nb-springboot/issues/136/comments","events_url":"https://api.github.com/repos/AlexFalappa/nb-springboot/issues/136/events","html_url":"https://github.com/AlexFalappa/nb-springboot/issues/136","id":307235488,"number":136,"title":"JVM arguments not working with spring boot 2.0.0","user":{"login":"anaq1","id":13847409,"avatar_url":"https://avatars1.githubusercontent.com/u/13847409?v=4","gravatar_id":"","url":"https://api.github.com/users/anaq1","html_url":"https://github.com/anaq1","followers_url":"https://api.github.com/users/anaq1/followers","following_url":"https://api.github.com/users/anaq1/following{/other_user}","gists_url":"https://api.github.com/users/anaq1/gists{/gist_id}","starred_url":"https://api.github.com/users/anaq1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anaq1/subscriptions","organizations_url":"https://api.github.com/users/anaq1/orgs","repos_url":"https://api.github.com/users/anaq1/repos","events_url":"https://api.github.com/users/anaq1/events{/privacy}","received_events_url":"https://api.github.com/users/anaq1/received_events","type":"User","site_admin":false},"labels":[{"id":546165039,"url":"https://api.github.com/repos/AlexFalappa/nb-springboot/labels/need%20info","name":"need info","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-03-21T13:03:03Z","updated_at":"2018-03-23T10:17:48Z","closed_at":null,"author_association":"NONE","body":"At this moment adding a property in jvm arguments generates this line:\r\nrun.jvmArguments=-Xdebug\r\nThis is valid for spring boot version < 2.0.0, for 2.0.0 it must be\r\nspring-boot.run.jvmArguments=-Xdebug\r\n\r\nI think there are more properties which needs this \"spring-boot\" prefix in 2.0.0."},"comment":{"url":"https://api.github.com/repos/AlexFalappa/nb-springboot/issues/comments/375606952","html_url":"https://github.com/AlexFalappa/nb-springboot/issues/136#issuecomment-375606952","issue_url":"https://api.github.com/repos/AlexFalappa/nb-springboot/issues/136","id":375606952,"user":{"login":"anaq1","id":13847409,"avatar_url":"https://avatars1.githubusercontent.com/u/13847409?v=4","gravatar_id":"","url":"https://api.github.com/users/anaq1","html_url":"https://github.com/anaq1","followers_url":"https://api.github.com/users/anaq1/followers","following_url":"https://api.github.com/users/anaq1/following{/other_user}","gists_url":"https://api.github.com/users/anaq1/gists{/gist_id}","starred_url":"https://api.github.com/users/anaq1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anaq1/subscriptions","organizations_url":"https://api.github.com/users/anaq1/orgs","repos_url":"https://api.github.com/users/anaq1/repos","events_url":"https://api.github.com/users/anaq1/events{/privacy}","received_events_url":"https://api.github.com/users/anaq1/received_events","type":"User","site_admin":false},"created_at":"2018-03-23T10:17:48Z","updated_at":"2018-03-23T10:17:48Z","author_association":"NONE","body":"I checked the version of the plugin in NB, it says:\r\nVersion: 2.0 \r\nSource: 1520272898_nb-springboot-plugin-2.0.nbm\r\n\r\nWhen I create new project from template\"Spring boot basic project\", the project has following \"Run project\" action properties:\r\n```\r\nrun.jvmArguments=-noverify -XX:TieredStopAtLevel=1\r\nrun.mainClass=com.example.BasicApplication\r\nEnv.SPRING_OUTPUT_ANSI_ENABLED=always\r\n```\r\n\r\nI added spring.flyway.enabled propety in Spring Boot tab in project properties and these lines were changed to:\r\n```\r\nspring-boot.run.mainClass=com.example.BasicApplication\r\nspring-boot.run.jvmArguments=-noverify -XX:TieredStopAtLevel=1\r\nEnv.SPRING_OUTPUT_ANSI_ENABLED=always\r\nspring-boot.run.arguments=--spring.flyway.enabled=false\r\n```\r\n\r\nUsing the plugin on existing Spring Boot 2 project (created manually, I installed the plugin afterwards)\r\nI set manually the \"Debug\" action in NB this way (working configuration):\r\n```\r\nspring-boot.run.jvmArguments=-Xdebug -Xrunjdwp:transport=dt_socket,server=n,address=${jpda.address} -Dspring.flyway.enabled=false\r\nEnv.SPRING_OUTPUT_ANSI_ENABLED=always\r\njpda.listen=true\r\n\r\n```\r\nAfter I installed the plugin, the Spring Boot tab was empty, so I added spring.flyway.enabled in \"Override configuration properties\" list. This changed the debug action:\r\n```\r\nspring-boot.run.jvmArguments=-Xdebug -Xrunjdwp:transport=dt_socket,server=n,address=${jpda.address} -Dspring.flyway.enabled=false\r\nEnv.SPRING_OUTPUT_ANSI_ENABLED=always\r\njpda.listen=true\r\nrun.jvmArguments=-Xdebug -Xrunjdwp:transport=dt_socket,server=n,address=${jpda.address}\r\nrun.arguments=--spring.flyway.enabled=false\r\n```\r\n\r\nSo I tried to delete everything from the action - Spring Boot tab stayed the same (the flyway property still present). So I removed and added the spring.flyway.enabled property once again, which leads the debug action changed to:\r\n```\r\nrun.jvmArguments=-Xdebug -Xrunjdwp:transport=dt_socket,server=n,address=${jpda.address}\r\njpda.listen=true\r\nrun.arguments=--spring.flyway.enabled=false\r\n```\r\nThe run action changed to:\r\n`run.arguments=--spring.flyway.enabled=false`\r\nThis is wrong.\r\n\r\nIt looks like the plugin is generating wrong properties in 2 situations:\r\n1. Creating new project from basic project template. But this is solved immediately after changing something in Spring Boot project properties.\r\n2. Using plugin on manually created project\r\n\r\nHope this description helps."}}
{"actor":{"display_login":"anaq1"}}