{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/comments/206717719","pull_request_review_id":142185545,"id":206717719,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjcxNzcxOQ==","diff_hunk":"@@ -209,14 +209,17 @@ The Fallback Layer natively works with PIX. However, PIX does not have support f\n When using the debug version of the Fallback Layer library, the Fallback layer has limited validation that will catch unsupported cases and output the cause of failure to the debugger. \n \n ### Acceleration structure visualization\n-It can be helpful to visualize the acceleration structure, particularly when you make changes to the structure logic in the library. To do this, enable ENABLE_ACCELERATION_STRUCTURE_VISUALIZATION in [FallbackDebug.h](src/FallbackDebug.h) and set FallbackLayer::m_levelToVisualize in [FallbackLayer.h](src/FallbackLayer.h) to a tree level you want to visualize.\n+It can be helpful to visualize the acceleration structure, particularly when you make changes to the structure logic in the library. To do this, enable ENABLE_ACCELERATION_STRUCTURE_VISUALIZATION in [FallbackDebug.h](src/FallbackDebug.h) and in [ModelViewerRayTracing.h](../../Samples/Desktop/D3D12Raytracing/src/D3D12RaytracingMiniEngineSample/ModelViewerRayTracing.h).","path":"Libraries/D3D12RaytracingFallback/developerguide.md","position":5,"original_position":5,"commit_id":"e2f06f5c5680aa88f84241435069b20c442c9a83","original_commit_id":"e2f06f5c5680aa88f84241435069b20c442c9a83","user":{"login":"clandrew","id":8118775,"node_id":"MDQ6VXNlcjgxMTg3NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/8118775?v=4","gravatar_id":"","url":"https://api.github.com/users/clandrew","html_url":"https://github.com/clandrew","followers_url":"https://api.github.com/users/clandrew/followers","following_url":"https://api.github.com/users/clandrew/following{/other_user}","gists_url":"https://api.github.com/users/clandrew/gists{/gist_id}","starred_url":"https://api.github.com/users/clandrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clandrew/subscriptions","organizations_url":"https://api.github.com/users/clandrew/orgs","repos_url":"https://api.github.com/users/clandrew/repos","events_url":"https://api.github.com/users/clandrew/events{/privacy}","received_events_url":"https://api.github.com/users/clandrew/received_events","type":"User","site_admin":false},"body":"Does it really need to be defined in two places?","created_at":"2018-07-31T23:45:27Z","updated_at":"2018-07-31T23:48:35Z","html_url":"https://github.com/Microsoft/DirectX-Graphics-Samples/pull/435#discussion_r206717719","pull_request_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/435","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/comments/206717719"},"html":{"href":"https://github.com/Microsoft/DirectX-Graphics-Samples/pull/435#discussion_r206717719"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/435"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/435","id":205264204,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MjY0MjA0","html_url":"https://github.com/Microsoft/DirectX-Graphics-Samples/pull/435","diff_url":"https://github.com/Microsoft/DirectX-Graphics-Samples/pull/435.diff","patch_url":"https://github.com/Microsoft/DirectX-Graphics-Samples/pull/435.patch","issue_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/issues/435","number":435,"state":"open","locked":false,"title":"Small changes & fixes","user":{"login":"rgerd","id":4724014,"node_id":"MDQ6VXNlcjQ3MjQwMTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4724014?v=4","gravatar_id":"","url":"https://api.github.com/users/rgerd","html_url":"https://github.com/rgerd","followers_url":"https://api.github.com/users/rgerd/followers","following_url":"https://api.github.com/users/rgerd/following{/other_user}","gists_url":"https://api.github.com/users/rgerd/gists{/gist_id}","starred_url":"https://api.github.com/users/rgerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgerd/subscriptions","organizations_url":"https://api.github.com/users/rgerd/orgs","repos_url":"https://api.github.com/users/rgerd/repos","events_url":"https://api.github.com/users/rgerd/events{/privacy}","received_events_url":"https://api.github.com/users/rgerd/received_events","type":"User","site_admin":false},"body":"- Moved the morton code calculation logic out into its own shader.\r\n- Improved acceleration structure visualization so you can now see how deeply the ray traversed in the BVH tree to hit each rendered triangle. Try it out!\r\n- Minor semantic fixes on comments/a function/a size calculation.\r\n\r\n\r\n![as visualization](https://user-images.githubusercontent.com/4724014/43491633-29651f8a-94da-11e8-8371-c742af5bc83d.PNG)\r\n","created_at":"2018-07-31T22:50:24Z","updated_at":"2018-07-31T23:48:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76bdda08436b52177e3929cf758cf6ae7b69e6b9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/435/commits","review_comments_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/435/comments","review_comment_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/issues/435/comments","statuses_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/statuses/e2f06f5c5680aa88f84241435069b20c442c9a83","head":{"label":"Microsoft:develop-dxr-rs5-smallChanges","ref":"develop-dxr-rs5-smallChanges","sha":"e2f06f5c5680aa88f84241435069b20c442c9a83","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":36831874,"node_id":"MDEwOlJlcG9zaXRvcnkzNjgzMTg3NA==","name":"DirectX-Graphics-Samples","full_name":"Microsoft/DirectX-Graphics-Samples","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/DirectX-Graphics-Samples","description":"This repo contains the DirectX Graphics samples that demonstrate how to build graphics intensive applications on Windows.","fork":false,"url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples","forks_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/forks","keys_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/teams","hooks_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/events","assignees_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/tags","blobs_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/languages","stargazers_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/subscription","commits_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/merges","archive_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/downloads","issues_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/deployments","created_at":"2015-06-03T21:34:47Z","updated_at":"2018-07-31T11:48:32Z","pushed_at":"2018-07-31T23:34:19Z","git_url":"git://github.com/Microsoft/DirectX-Graphics-Samples.git","ssh_url":"git@github.com:Microsoft/DirectX-Graphics-Samples.git","clone_url":"https://github.com/Microsoft/DirectX-Graphics-Samples.git","svn_url":"https://github.com/Microsoft/DirectX-Graphics-Samples","homepage":null,"size":106878,"stargazers_count":1682,"watchers_count":1682,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":645,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":645,"open_issues":46,"watchers":1682,"default_branch":"master"}},"base":{"label":"Microsoft:develop-dxr-rs5","ref":"develop-dxr-rs5","sha":"fc02af66f471d977e043b7046bb27b994293b9f2","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":36831874,"node_id":"MDEwOlJlcG9zaXRvcnkzNjgzMTg3NA==","name":"DirectX-Graphics-Samples","full_name":"Microsoft/DirectX-Graphics-Samples","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/DirectX-Graphics-Samples","description":"This repo contains the DirectX Graphics samples that demonstrate how to build graphics intensive applications on Windows.","fork":false,"url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples","forks_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/forks","keys_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/teams","hooks_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/events","assignees_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/tags","blobs_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/languages","stargazers_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/subscription","commits_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/merges","archive_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/downloads","issues_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/deployments","created_at":"2015-06-03T21:34:47Z","updated_at":"2018-07-31T11:48:32Z","pushed_at":"2018-07-31T23:34:19Z","git_url":"git://github.com/Microsoft/DirectX-Graphics-Samples.git","ssh_url":"git@github.com:Microsoft/DirectX-Graphics-Samples.git","clone_url":"https://github.com/Microsoft/DirectX-Graphics-Samples.git","svn_url":"https://github.com/Microsoft/DirectX-Graphics-Samples","homepage":null,"size":106878,"stargazers_count":1682,"watchers_count":1682,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":645,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":645,"open_issues":46,"watchers":1682,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/435"},"html":{"href":"https://github.com/Microsoft/DirectX-Graphics-Samples/pull/435"},"issue":{"href":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/issues/435"},"comments":{"href":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/issues/435/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/435/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/435/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/statuses/e2f06f5c5680aa88f84241435069b20c442c9a83"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"clandrew"}}