{"action":"created","issue":{"url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues/1106","repository_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python","labels_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues/1106/labels{/name}","comments_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues/1106/comments","events_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues/1106/events","html_url":"https://github.com/HypothesisWorks/hypothesis-python/pull/1106","id":296258914,"number":1106,"title":"rename target arg so we can use targets requiring an argument 'target'","user":{"login":"dchudz","id":1222726,"avatar_url":"https://avatars0.githubusercontent.com/u/1222726?v=4","gravatar_id":"","url":"https://api.github.com/users/dchudz","html_url":"https://github.com/dchudz","followers_url":"https://api.github.com/users/dchudz/followers","following_url":"https://api.github.com/users/dchudz/following{/other_user}","gists_url":"https://api.github.com/users/dchudz/gists{/gist_id}","starred_url":"https://api.github.com/users/dchudz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchudz/subscriptions","organizations_url":"https://api.github.com/users/dchudz/orgs","repos_url":"https://api.github.com/users/dchudz/repos","events_url":"https://api.github.com/users/dchudz/events{/privacy}","received_events_url":"https://api.github.com/users/dchudz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2018-02-12T03:37:20Z","updated_at":"2018-02-13T02:53:55Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/1106","html_url":"https://github.com/HypothesisWorks/hypothesis-python/pull/1106","diff_url":"https://github.com/HypothesisWorks/hypothesis-python/pull/1106.diff","patch_url":"https://github.com/HypothesisWorks/hypothesis-python/pull/1106.patch"},"body":"This is my attempt to address https://github.com/HypothesisWorks/hypothesis-python/issues/1104, following the suggestion in the comment from @DRMacIver on that issue.\r\n\r\nBut I don't think it's good:\r\n\r\n- calling `builds()` with no argument for the target no longer raises `TypeError` (`builds().example()` does), since the new code here isn't actually run when you call `builds()`\r\n- for the same reason, the deprecation warning doesn't show when you first call `builds()`\r\n\r\nI'm not thinking of any ways to fix this without adding a bunch of complication (I'd have to mess with `proxies()` and/or `base_defines_strategy()`?).\r\n\r\nI'm completely new here, but it seems to me that merging this would make life worse for users and developers.\r\n\r\nI figured I'd post it anyway, since (a) maybe I'm wrong about that or (b) I'd love to be pointed in a better direction if anyone has time to set me right.\r\n\r\nOr if not, we can just close this and add to the issue: \"Don't fix it THAT way!\"\r\n"},"comment":{"url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues/comments/365135185","html_url":"https://github.com/HypothesisWorks/hypothesis-python/pull/1106#issuecomment-365135185","issue_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues/1106","id":365135185,"user":{"login":"dchudz","id":1222726,"avatar_url":"https://avatars0.githubusercontent.com/u/1222726?v=4","gravatar_id":"","url":"https://api.github.com/users/dchudz","html_url":"https://github.com/dchudz","followers_url":"https://api.github.com/users/dchudz/followers","following_url":"https://api.github.com/users/dchudz/following{/other_user}","gists_url":"https://api.github.com/users/dchudz/gists{/gist_id}","starred_url":"https://api.github.com/users/dchudz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchudz/subscriptions","organizations_url":"https://api.github.com/users/dchudz/orgs","repos_url":"https://api.github.com/users/dchudz/repos","events_url":"https://api.github.com/users/dchudz/events{/privacy}","received_events_url":"https://api.github.com/users/dchudz/received_events","type":"User","site_admin":false},"created_at":"2018-02-13T02:53:55Z","updated_at":"2018-02-13T02:53:55Z","author_association":"NONE","body":"> FYI InvalidArgument inherits from TypeError, so except TypeError or with pytest.raises(TypeError) will still catch it.\r\n\r\noh right, thanks!"}}
{"actor":{"display_login":"dchudz"}}