{"action":"created","issue":{"url":"https://api.github.com/repos/qgis/QGIS/issues/8035","repository_url":"https://api.github.com/repos/qgis/QGIS","labels_url":"https://api.github.com/repos/qgis/QGIS/issues/8035/labels{/name}","comments_url":"https://api.github.com/repos/qgis/QGIS/issues/8035/comments","events_url":"https://api.github.com/repos/qgis/QGIS/issues/8035/events","html_url":"https://github.com/qgis/QGIS/pull/8035","id":364075509,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MzUwMjQx","number":8035,"title":"[BUG FIX][Split Tool] Bug fix for split features tool","user":{"login":"phborba","id":6131641,"node_id":"MDQ6VXNlcjYxMzE2NDE=","avatar_url":"https://avatars1.githubusercontent.com/u/6131641?v=4","gravatar_id":"","url":"https://api.github.com/users/phborba","html_url":"https://github.com/phborba","followers_url":"https://api.github.com/users/phborba/followers","following_url":"https://api.github.com/users/phborba/following{/other_user}","gists_url":"https://api.github.com/users/phborba/gists{/gist_id}","starred_url":"https://api.github.com/users/phborba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phborba/subscriptions","organizations_url":"https://api.github.com/users/phborba/orgs","repos_url":"https://api.github.com/users/phborba/repos","events_url":"https://api.github.com/users/phborba/events{/privacy}","received_events_url":"https://api.github.com/users/phborba/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-09-26T14:59:53Z","updated_at":"2018-09-27T12:30:34Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/8035","html_url":"https://github.com/qgis/QGIS/pull/8035","diff_url":"https://github.com/qgis/QGIS/pull/8035.diff","patch_url":"https://github.com/qgis/QGIS/pull/8035.patch"},"body":"## Description\r\nSplit feature was resetting attributes of new features with PostGIS providers that have default values. \r\n\r\nFor example, if a layer has a field called field1 and it has a default value of 1, if a user used the split tool in a feature that has field1=2, the new part instead of getting the old value of 2 gets the provider value of 1.\r\n\r\nA small change on createFeature from QgsVectorLayerUtils was made.\r\n\r\nThis bugfix is a suggestion for Bug report #19936 from redmine.\r\n\r\n## Checklist\r\n\r\n> Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.\r\n\r\n- [x] Commit messages are descriptive and explain the rationale for changes\r\n- [x] Commits which fix bugs include `fixes #11111` in the commit message next to the description\r\n- [x] Commits which add new features are tagged with `[FEATURE]` in the commit message\r\n- [x] Commits which change the UI or existing user workflows are tagged with `[needs-docs]` in the commit message and contain sufficient information in the commit message to be documented\r\n- [x] I have read the [QGIS Coding Standards](https://docs.qgis.org/testing/en/docs/developers_guide/codingstandards.html) and this PR complies with them\r\n- [ ] This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)\r\n- [ ] New unit tests have been added for core changes\r\n- [x] I have run [the `scripts/prepare-commit.sh` script](https://github.com/qgis/QGIS/blob/master/.github/CONTRIBUTE.md#contributing-to-qgis) before each commit\r\n"},"comment":{"url":"https://api.github.com/repos/qgis/QGIS/issues/comments/425072501","html_url":"https://github.com/qgis/QGIS/pull/8035#issuecomment-425072501","issue_url":"https://api.github.com/repos/qgis/QGIS/issues/8035","id":425072501,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTA3MjUwMQ==","user":{"login":"phborba","id":6131641,"node_id":"MDQ6VXNlcjYxMzE2NDE=","avatar_url":"https://avatars1.githubusercontent.com/u/6131641?v=4","gravatar_id":"","url":"https://api.github.com/users/phborba","html_url":"https://github.com/phborba","followers_url":"https://api.github.com/users/phborba/followers","following_url":"https://api.github.com/users/phborba/following{/other_user}","gists_url":"https://api.github.com/users/phborba/gists{/gist_id}","starred_url":"https://api.github.com/users/phborba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phborba/subscriptions","organizations_url":"https://api.github.com/users/phborba/orgs","repos_url":"https://api.github.com/users/phborba/repos","events_url":"https://api.github.com/users/phborba/events{/privacy}","received_events_url":"https://api.github.com/users/phborba/received_events","type":"User","site_admin":false},"created_at":"2018-09-27T12:30:34Z","updated_at":"2018-09-27T12:30:34Z","author_association":"NONE","body":"Guys maybe this method of test_provider_postgres should change:\r\n\r\nhttps://github.com/qgis/QGIS/blob/2275853ce64baa9ae3df99e4e62ccbe885cdf7f8/tests/src/python/test_provider_postgres.py#L806\r\n\r\nSince the behaviour is altered. What do you think @elpaso , @m-kuhn  and @nyalldawson ?"}}
{"actor":{"display_login":"phborba"}}