{"action":"created","comment":{"url":"https://api.github.com/repos/Linaro/hpc_lab_setup/pulls/comments/228985192","pull_request_review_id":169373544,"id":228985192,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODk4NTE5Mg==","diff_hunk":"@@ -66,34 +66,41 @@\n                                 kernel_opts=\"ip=dhcp text inst.stage2=http://releases.linaro.org/reference-platform/enterprise/18.06/centos-installer/ inst.repo=http://mirror.centos.org/altarch/7/os/aarch64/ inst.ks=file:/ks.cfg\"\n                         fi\n \n-                        # Chose known good kernel/initrd/cmdline\n-\n-                        # Build trigger machine_provision job\n-                        cat << EOF > machine_provision\n-                        machine_list=${machine_list}\n-                        os_type=${os_type}\n-                        machine_type=${machine_type}\n+                        # Defaults\n+                        machine_list=\"$( echo \"$machine_list\"| tr -d '[:space:]')\"\n+                        machine_name=${machine_list}\n+                        machine_arch=AArch64\n+                        machine_subarch=Grub\n                         job_type=ohpc\n+\n+                        kernel_opts=\"${kernel_opts} earlycon console=ttyAMA0,115200\"","path":"files/cluster_provision.yml","position":18,"original_position":18,"commit_id":"1392e61aae73ddbdc762a231b8e4737b43cf9883","original_commit_id":"1392e61aae73ddbdc762a231b8e4737b43cf9883","user":{"login":"rengolin","id":1040968,"node_id":"MDQ6VXNlcjEwNDA5Njg=","avatar_url":"https://avatars0.githubusercontent.com/u/1040968?v=4","gravatar_id":"","url":"https://api.github.com/users/rengolin","html_url":"https://github.com/rengolin","followers_url":"https://api.github.com/users/rengolin/followers","following_url":"https://api.github.com/users/rengolin/following{/other_user}","gists_url":"https://api.github.com/users/rengolin/gists{/gist_id}","starred_url":"https://api.github.com/users/rengolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rengolin/subscriptions","organizations_url":"https://api.github.com/users/rengolin/orgs","repos_url":"https://api.github.com/users/rengolin/repos","events_url":"https://api.github.com/users/rengolin/events{/privacy}","received_events_url":"https://api.github.com/users/rengolin/received_events","type":"User","site_admin":false},"body":"There are more common parts than just these two. You can create variables for stage2 and repo and set them in the if/else above, then set kernel opts once after.","created_at":"2018-10-29T15:49:59Z","updated_at":"2018-10-29T15:57:03Z","html_url":"https://github.com/Linaro/hpc_lab_setup/pull/70#discussion_r228985192","pull_request_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/pulls/70","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Linaro/hpc_lab_setup/pulls/comments/228985192"},"html":{"href":"https://github.com/Linaro/hpc_lab_setup/pull/70#discussion_r228985192"},"pull_request":{"href":"https://api.github.com/repos/Linaro/hpc_lab_setup/pulls/70"}}},"pull_request":{"url":"https://api.github.com/repos/Linaro/hpc_lab_setup/pulls/70","id":226509646,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NTA5NjQ2","html_url":"https://github.com/Linaro/hpc_lab_setup/pull/70","diff_url":"https://github.com/Linaro/hpc_lab_setup/pull/70.diff","patch_url":"https://github.com/Linaro/hpc_lab_setup/pull/70.patch","issue_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/issues/70","number":70,"state":"open","locked":false,"title":"Refactor provisioning to only have three jobs","user":{"login":"BaptisteGerondeau","id":15145523,"node_id":"MDQ6VXNlcjE1MTQ1NTIz","avatar_url":"https://avatars3.githubusercontent.com/u/15145523?v=4","gravatar_id":"","url":"https://api.github.com/users/BaptisteGerondeau","html_url":"https://github.com/BaptisteGerondeau","followers_url":"https://api.github.com/users/BaptisteGerondeau/followers","following_url":"https://api.github.com/users/BaptisteGerondeau/following{/other_user}","gists_url":"https://api.github.com/users/BaptisteGerondeau/gists{/gist_id}","starred_url":"https://api.github.com/users/BaptisteGerondeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BaptisteGerondeau/subscriptions","organizations_url":"https://api.github.com/users/BaptisteGerondeau/orgs","repos_url":"https://api.github.com/users/BaptisteGerondeau/repos","events_url":"https://api.github.com/users/BaptisteGerondeau/events{/privacy}","received_events_url":"https://api.github.com/users/BaptisteGerondeau/received_events","type":"User","site_admin":false},"body":"This puts the content of machine_provision in os_provision and cluster_provision, then renames os_provision to machine_provision.\r\n\r\nThis effectively deletes one job of the provisioning pipeline.\r\n\r\nNote that this simple change does not touch any of the logic, and thus does not correct the fact that the \"d05\" cluster's d03s will be provisioned with the d05 kernel opts line.\r\nThis bug (lest I'm missing something) requires too much work, especially seeing as templates will soon be added to the provisioning pipeline.","created_at":"2018-10-29T10:37:23Z","updated_at":"2018-10-29T15:57:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d6689a07a5cee814a3e37aa7f5ce510710ccb7a3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/pulls/70/commits","review_comments_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/pulls/70/comments","review_comment_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/issues/70/comments","statuses_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/statuses/1392e61aae73ddbdc762a231b8e4737b43cf9883","head":{"label":"BaptisteGerondeau:elimosprov","ref":"elimosprov","sha":"1392e61aae73ddbdc762a231b8e4737b43cf9883","user":{"login":"BaptisteGerondeau","id":15145523,"node_id":"MDQ6VXNlcjE1MTQ1NTIz","avatar_url":"https://avatars3.githubusercontent.com/u/15145523?v=4","gravatar_id":"","url":"https://api.github.com/users/BaptisteGerondeau","html_url":"https://github.com/BaptisteGerondeau","followers_url":"https://api.github.com/users/BaptisteGerondeau/followers","following_url":"https://api.github.com/users/BaptisteGerondeau/following{/other_user}","gists_url":"https://api.github.com/users/BaptisteGerondeau/gists{/gist_id}","starred_url":"https://api.github.com/users/BaptisteGerondeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BaptisteGerondeau/subscriptions","organizations_url":"https://api.github.com/users/BaptisteGerondeau/orgs","repos_url":"https://api.github.com/users/BaptisteGerondeau/repos","events_url":"https://api.github.com/users/BaptisteGerondeau/events{/privacy}","received_events_url":"https://api.github.com/users/BaptisteGerondeau/received_events","type":"User","site_admin":false},"repo":{"id":133824871,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM4MjQ4NzE=","name":"hpc_lab_jenkins","full_name":"BaptisteGerondeau/hpc_lab_jenkins","private":false,"owner":{"login":"BaptisteGerondeau","id":15145523,"node_id":"MDQ6VXNlcjE1MTQ1NTIz","avatar_url":"https://avatars3.githubusercontent.com/u/15145523?v=4","gravatar_id":"","url":"https://api.github.com/users/BaptisteGerondeau","html_url":"https://github.com/BaptisteGerondeau","followers_url":"https://api.github.com/users/BaptisteGerondeau/followers","following_url":"https://api.github.com/users/BaptisteGerondeau/following{/other_user}","gists_url":"https://api.github.com/users/BaptisteGerondeau/gists{/gist_id}","starred_url":"https://api.github.com/users/BaptisteGerondeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BaptisteGerondeau/subscriptions","organizations_url":"https://api.github.com/users/BaptisteGerondeau/orgs","repos_url":"https://api.github.com/users/BaptisteGerondeau/repos","events_url":"https://api.github.com/users/BaptisteGerondeau/events{/privacy}","received_events_url":"https://api.github.com/users/BaptisteGerondeau/received_events","type":"User","site_admin":false},"html_url":"https://github.com/BaptisteGerondeau/hpc_lab_jenkins","description":"Jenkins Jobs for HPC Lab","fork":true,"url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins","forks_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/forks","keys_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/teams","hooks_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/hooks","issue_events_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/events","assignees_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/tags","blobs_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/languages","stargazers_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/stargazers","contributors_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/contributors","subscribers_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/subscribers","subscription_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/subscription","commits_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/merges","archive_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/downloads","issues_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/labels{/name}","releases_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/BaptisteGerondeau/hpc_lab_jenkins/deployments","created_at":"2018-05-17T14:25:10Z","updated_at":"2018-10-26T13:39:51Z","pushed_at":"2018-10-29T15:49:10Z","git_url":"git://github.com/BaptisteGerondeau/hpc_lab_jenkins.git","ssh_url":"git@github.com:BaptisteGerondeau/hpc_lab_jenkins.git","clone_url":"https://github.com/BaptisteGerondeau/hpc_lab_jenkins.git","svn_url":"https://github.com/BaptisteGerondeau/hpc_lab_jenkins","homepage":null,"size":247,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Linaro:master","ref":"master","sha":"23594369fec62bb6b3e30536685c05bde1d57a45","user":{"login":"Linaro","id":1180626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODA2MjY=","avatar_url":"https://avatars0.githubusercontent.com/u/1180626?v=4","gravatar_id":"","url":"https://api.github.com/users/Linaro","html_url":"https://github.com/Linaro","followers_url":"https://api.github.com/users/Linaro/followers","following_url":"https://api.github.com/users/Linaro/following{/other_user}","gists_url":"https://api.github.com/users/Linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/Linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Linaro/subscriptions","organizations_url":"https://api.github.com/users/Linaro/orgs","repos_url":"https://api.github.com/users/Linaro/repos","events_url":"https://api.github.com/users/Linaro/events{/privacy}","received_events_url":"https://api.github.com/users/Linaro/received_events","type":"Organization","site_admin":false},"repo":{"id":131727610,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE3Mjc2MTA=","name":"hpc_lab_setup","full_name":"Linaro/hpc_lab_setup","private":false,"owner":{"login":"Linaro","id":1180626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODA2MjY=","avatar_url":"https://avatars0.githubusercontent.com/u/1180626?v=4","gravatar_id":"","url":"https://api.github.com/users/Linaro","html_url":"https://github.com/Linaro","followers_url":"https://api.github.com/users/Linaro/followers","following_url":"https://api.github.com/users/Linaro/following{/other_user}","gists_url":"https://api.github.com/users/Linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/Linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Linaro/subscriptions","organizations_url":"https://api.github.com/users/Linaro/orgs","repos_url":"https://api.github.com/users/Linaro/repos","events_url":"https://api.github.com/users/Linaro/events{/privacy}","received_events_url":"https://api.github.com/users/Linaro/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Linaro/hpc_lab_setup","description":"Jenkins Jobs for HPC Lab","fork":false,"url":"https://api.github.com/repos/Linaro/hpc_lab_setup","forks_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/forks","keys_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/teams","hooks_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/hooks","issue_events_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/issues/events{/number}","events_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/events","assignees_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/assignees{/user}","branches_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/branches{/branch}","tags_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/tags","blobs_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/git/refs{/sha}","trees_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/statuses/{sha}","languages_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/languages","stargazers_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/stargazers","contributors_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/contributors","subscribers_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/subscribers","subscription_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/subscription","commits_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/commits{/sha}","git_commits_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/git/commits{/sha}","comments_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/comments{/number}","issue_comment_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/issues/comments{/number}","contents_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/contents/{+path}","compare_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/merges","archive_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/downloads","issues_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/issues{/number}","pulls_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/pulls{/number}","milestones_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/milestones{/number}","notifications_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/labels{/name}","releases_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/releases{/id}","deployments_url":"https://api.github.com/repos/Linaro/hpc_lab_setup/deployments","created_at":"2018-05-01T15:11:06Z","updated_at":"2018-10-26T10:39:57Z","pushed_at":"2018-10-29T15:35:02Z","git_url":"git://github.com/Linaro/hpc_lab_setup.git","ssh_url":"git@github.com:Linaro/hpc_lab_setup.git","clone_url":"https://github.com/Linaro/hpc_lab_setup.git","svn_url":"https://github.com/Linaro/hpc_lab_setup","homepage":null,"size":157,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":2,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Linaro/hpc_lab_setup/pulls/70"},"html":{"href":"https://github.com/Linaro/hpc_lab_setup/pull/70"},"issue":{"href":"https://api.github.com/repos/Linaro/hpc_lab_setup/issues/70"},"comments":{"href":"https://api.github.com/repos/Linaro/hpc_lab_setup/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/Linaro/hpc_lab_setup/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/Linaro/hpc_lab_setup/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Linaro/hpc_lab_setup/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/Linaro/hpc_lab_setup/statuses/1392e61aae73ddbdc762a231b8e4737b43cf9883"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"rengolin"}}