{"action":"created","issue":{"url":"https://api.github.com/repos/sorintlab/stolon/issues/88","repository_url":"https://api.github.com/repos/sorintlab/stolon","labels_url":"https://api.github.com/repos/sorintlab/stolon/issues/88/labels{/name}","comments_url":"https://api.github.com/repos/sorintlab/stolon/issues/88/comments","events_url":"https://api.github.com/repos/sorintlab/stolon/issues/88/events","html_url":"https://github.com/sorintlab/stolon/issues/88","id":114254823,"node_id":"MDU6SXNzdWUxMTQyNTQ4MjM=","number":88,"title":"stolonctl: implement postgres reload/restart","user":{"login":"sgotti","id":1690273,"node_id":"MDQ6VXNlcjE2OTAyNzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1690273?v=4","gravatar_id":"","url":"https://api.github.com/users/sgotti","html_url":"https://github.com/sgotti","followers_url":"https://api.github.com/users/sgotti/followers","following_url":"https://api.github.com/users/sgotti/following{/other_user}","gists_url":"https://api.github.com/users/sgotti/gists{/gist_id}","starred_url":"https://api.github.com/users/sgotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgotti/subscriptions","organizations_url":"https://api.github.com/users/sgotti/orgs","repos_url":"https://api.github.com/users/sgotti/repos","events_url":"https://api.github.com/users/sgotti/events{/privacy}","received_events_url":"https://api.github.com/users/sgotti/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2015-10-30T11:46:22Z","updated_at":"2018-09-07T12:29:18Z","closed_at":null,"author_association":"MEMBER","body":""},"comment":{"url":"https://api.github.com/repos/sorintlab/stolon/issues/comments/419424288","html_url":"https://github.com/sorintlab/stolon/issues/88#issuecomment-419424288","issue_url":"https://api.github.com/repos/sorintlab/stolon/issues/88","id":419424288,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTQyNDI4OA==","user":{"login":"sgotti","id":1690273,"node_id":"MDQ6VXNlcjE2OTAyNzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1690273?v=4","gravatar_id":"","url":"https://api.github.com/users/sgotti","html_url":"https://github.com/sgotti","followers_url":"https://api.github.com/users/sgotti/followers","following_url":"https://api.github.com/users/sgotti/following{/other_user}","gists_url":"https://api.github.com/users/sgotti/gists{/gist_id}","starred_url":"https://api.github.com/users/sgotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgotti/subscriptions","organizations_url":"https://api.github.com/users/sgotti/orgs","repos_url":"https://api.github.com/users/sgotti/repos","events_url":"https://api.github.com/users/sgotti/events{/privacy}","received_events_url":"https://api.github.com/users/sgotti/received_events","type":"User","site_admin":false},"created_at":"2018-09-07T12:29:18Z","updated_at":"2018-09-07T12:29:18Z","author_association":"MEMBER","body":"@prabhu43 I reopened the issue (it was closed and I was losing your comment).\r\n\r\nYour proposal is basically an **operator** that handles a long running transaction. It requires a lot of logic to handle all the possible failures (it implements one of the possible workflows but there can be others). And as you said there're different gotchas that are difficult to know ahead of time since you should reimplement all the postgresql parameter checking logic.\r\n\r\nFor this reason I won't add a command like `stolonctl pgrestart` that will be a blocking command carrying all of this logic.\r\nPerhaps this could be implemented (in go or as shell script or whatever) as a contrib script/tool outside stolonctl.\r\n\r\n## Some notes\r\n\r\n* ideally a keeper can automatically discover (and report) if an instance needs a restart querying the pg_parameters table. It's simply not yet implemented.\r\n\r\n> On restarting the postgres of master, sentinal will elect another healthy keeper as master\r\n\r\nTo be precise, restarting the master keeper doesn't imply that a new primary will be elected, if the restart is fast enough (usually) and doesn't fail due to wrong parameters the sentinel won't detect the master as failed and won't elect a new master."}}
{"actor":{"display_login":"sgotti"}}