{"action":"created","issue":{"url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/1796","repository_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift","labels_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/1796/labels{/name}","comments_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/1796/comments","events_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/1796/events","html_url":"https://github.com/jbosstools/jbosstools-openshift/pull/1796","id":355986280,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMzg3Nzk1","number":1796,"title":"[JBIDE-26327] dont NPE on adapter shutdown if project was deleted","user":{"login":"adietish","id":25126,"node_id":"MDQ6VXNlcjI1MTI2","avatar_url":"https://avatars3.githubusercontent.com/u/25126?v=4","gravatar_id":"","url":"https://api.github.com/users/adietish","html_url":"https://github.com/adietish","followers_url":"https://api.github.com/users/adietish/followers","following_url":"https://api.github.com/users/adietish/following{/other_user}","gists_url":"https://api.github.com/users/adietish/gists{/gist_id}","starred_url":"https://api.github.com/users/adietish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adietish/subscriptions","organizations_url":"https://api.github.com/users/adietish/orgs","repos_url":"https://api.github.com/users/adietish/repos","events_url":"https://api.github.com/users/adietish/events{/privacy}","received_events_url":"https://api.github.com/users/adietish/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-31T13:43:24Z","updated_at":"2018-08-31T15:57:12Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/pulls/1796","html_url":"https://github.com/jbosstools/jbosstools-openshift/pull/1796","diff_url":"https://github.com/jbosstools/jbosstools-openshift/pull/1796.diff","patch_url":"https://github.com/jbosstools/jbosstools-openshift/pull/1796.patch"},"body":"# Pull Request Checklist\r\n## General\r\n* Is this a blocking issue or new feature? If yes, QE needs to +1 this PR\r\n\r\n## Code\r\n* Are method-/class-/variable-names meaningful?\r\n* Are methods concise, not too long?\r\n* Are catch blocks catching precise Exceptions only (no catch all)?\r\n\r\n## Testing\r\n* Are there unit-tests?\r\n* Are there integration tests (or at least a jira to tackle these)?\r\n* Is the non-happy path working, too?\r\n* Are other parts that use the same component still working fine?\r\n\r\n## Function\r\n* Does it work?\r\n"},"comment":{"url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/comments/417709373","html_url":"https://github.com/jbosstools/jbosstools-openshift/pull/1796#issuecomment-417709373","issue_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/1796","id":417709373,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzcwOTM3Mw==","user":{"login":"rhdevelopers-ci","id":18214726,"node_id":"MDQ6VXNlcjE4MjE0NzI2","avatar_url":"https://avatars3.githubusercontent.com/u/18214726?v=4","gravatar_id":"","url":"https://api.github.com/users/rhdevelopers-ci","html_url":"https://github.com/rhdevelopers-ci","followers_url":"https://api.github.com/users/rhdevelopers-ci/followers","following_url":"https://api.github.com/users/rhdevelopers-ci/following{/other_user}","gists_url":"https://api.github.com/users/rhdevelopers-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/rhdevelopers-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhdevelopers-ci/subscriptions","organizations_url":"https://api.github.com/users/rhdevelopers-ci/orgs","repos_url":"https://api.github.com/users/rhdevelopers-ci/repos","events_url":"https://api.github.com/users/rhdevelopers-ci/events{/privacy}","received_events_url":"https://api.github.com/users/rhdevelopers-ci/received_events","type":"User","site_admin":false},"created_at":"2018-08-31T15:57:12Z","updated_at":"2018-08-31T15:57:12Z","author_association":"NONE","body":"SonarQube analysis reported 3 issues\n* ![MAJOR][MAJOR] 1 major\n* ![MINOR][MINOR] 2 minor\n\nWatch the comments in this conversation to review them.\n\n#### 2 extra issues\n\nNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:\n\n1. ![MINOR][MINOR] [OpenShiftLaunchController.java#L20](https://github.com/jbosstools/jbosstools-openshift/blob/1765247a98ccd786fe291da62a6e4021ae91a8ee/plugins/org.jboss.tools.openshift.core/src/org/jboss/tools/openshift/core/server/behavior/OpenShiftLaunchController.java#L20): Remove this unused import 'org.eclipse.core.resources.IFile'. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AUselessImportCheck)\n1. ![MINOR][MINOR] [OpenShiftLaunchController.java#L38](https://github.com/jbosstools/jbosstools-openshift/blob/1765247a98ccd786fe291da62a6e4021ae91a8ee/plugins/org.jboss.tools.openshift.core/src/org/jboss/tools/openshift/core/server/behavior/OpenShiftLaunchController.java#L38): Remove this unused import 'org.eclipse.m2e.core.internal.IMavenConstants'. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AUselessImportCheck)\n\n[MAJOR]: https://sonarsource.github.io/sonar-github/severity-major.png 'Severity: MAJOR'\n[MINOR]: https://sonarsource.github.io/sonar-github/severity-minor.png 'Severity: MINOR'"}}
{"actor":{"display_login":"rhdevelopers-ci"}}