{"action":"created","issue":{"url":"https://api.github.com/repos/dymanoid/RealTime/issues/73","repository_url":"https://api.github.com/repos/dymanoid/RealTime","labels_url":"https://api.github.com/repos/dymanoid/RealTime/issues/73/labels{/name}","comments_url":"https://api.github.com/repos/dymanoid/RealTime/issues/73/comments","events_url":"https://api.github.com/repos/dymanoid/RealTime/issues/73/events","html_url":"https://github.com/dymanoid/RealTime/issues/73","id":342068756,"node_id":"MDU6SXNzdWUzNDIwNjg3NTY=","number":73,"title":"Lights out when sleeping","user":{"login":"aubergine10","id":1386719,"node_id":"MDQ6VXNlcjEzODY3MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1386719?v=4","gravatar_id":"","url":"https://api.github.com/users/aubergine10","html_url":"https://github.com/aubergine10","followers_url":"https://api.github.com/users/aubergine10/followers","following_url":"https://api.github.com/users/aubergine10/following{/other_user}","gists_url":"https://api.github.com/users/aubergine10/gists{/gist_id}","starred_url":"https://api.github.com/users/aubergine10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aubergine10/subscriptions","organizations_url":"https://api.github.com/users/aubergine10/orgs","repos_url":"https://api.github.com/users/aubergine10/repos","events_url":"https://api.github.com/users/aubergine10/events{/privacy}","received_events_url":"https://api.github.com/users/aubergine10/received_events","type":"User","site_admin":false},"labels":[{"id":950223667,"node_id":"MDU6TGFiZWw5NTAyMjM2Njc=","url":"https://api.github.com/repos/dymanoid/RealTime/labels/feature","name":"feature","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/dymanoid/RealTime/milestones/8","html_url":"https://github.com/dymanoid/RealTime/milestone/8","labels_url":"https://api.github.com/repos/dymanoid/RealTime/milestones/8/labels","id":3512657,"node_id":"MDk6TWlsZXN0b25lMzUxMjY1Nw==","number":8,"title":"1.9","description":"","creator":{"login":"dymanoid","id":9433345,"node_id":"MDQ6VXNlcjk0MzMzNDU=","avatar_url":"https://avatars1.githubusercontent.com/u/9433345?v=4","gravatar_id":"","url":"https://api.github.com/users/dymanoid","html_url":"https://github.com/dymanoid","followers_url":"https://api.github.com/users/dymanoid/followers","following_url":"https://api.github.com/users/dymanoid/following{/other_user}","gists_url":"https://api.github.com/users/dymanoid/gists{/gist_id}","starred_url":"https://api.github.com/users/dymanoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dymanoid/subscriptions","organizations_url":"https://api.github.com/users/dymanoid/orgs","repos_url":"https://api.github.com/users/dymanoid/repos","events_url":"https://api.github.com/users/dymanoid/events{/privacy}","received_events_url":"https://api.github.com/users/dymanoid/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2018-07-20T18:41:25Z","updated_at":"2018-07-22T12:12:11Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2018-07-17T20:17:16Z","updated_at":"2018-07-22T18:53:31Z","closed_at":null,"author_association":"NONE","body":"Following on from discussion in #65, I've separated this out in case there's an asset creator or modder that can assist with the following:\r\n\r\n> dymanoid: This is a tough one. I'm not an asset editor and have no idea how to control all that 3D stuff. So of course we can list this feature here, but I doubt I can implement it any time soon. A help from some asset editor / Unity3D geek would be highly appreciated.\r\n\r\nI suspect @ronyx69 might know how that stuff works as he's done a bunch of mods relating to visual stuff.\r\n\r\nInfo is required for the code is that toggles building window lights for the day/night cycle.\r\n\r\nSimplified summary (eg. ignoring fact that in summer the sunset could occur after sleep time, etc):\r\n\r\n* Sunset: Base game turns lights on\r\n* Sleep time: RealTime makes some buildings go dark, because cims are sleeping \r\n* Wake time: RealTime relights some of those buildings as cims are getting up for work\r\n* Sunrise: Base game turns lights off\r\n\r\nProp lights would be largely unaffected, eg. the red flashing lights at top of skyscrapers, etc. That being said, if code is available to toggle those, I have some ideas for a separate mod that could make use of it :)"},"comment":{"url":"https://api.github.com/repos/dymanoid/RealTime/issues/comments/406888405","html_url":"https://github.com/dymanoid/RealTime/issues/73#issuecomment-406888405","issue_url":"https://api.github.com/repos/dymanoid/RealTime/issues/73","id":406888405,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjg4ODQwNQ==","user":{"login":"aubergine10","id":1386719,"node_id":"MDQ6VXNlcjEzODY3MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1386719?v=4","gravatar_id":"","url":"https://api.github.com/users/aubergine10","html_url":"https://github.com/aubergine10","followers_url":"https://api.github.com/users/aubergine10/followers","following_url":"https://api.github.com/users/aubergine10/following{/other_user}","gists_url":"https://api.github.com/users/aubergine10/gists{/gist_id}","starred_url":"https://api.github.com/users/aubergine10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aubergine10/subscriptions","organizations_url":"https://api.github.com/users/aubergine10/orgs","repos_url":"https://api.github.com/users/aubergine10/repos","events_url":"https://api.github.com/users/aubergine10/events{/privacy}","received_events_url":"https://api.github.com/users/aubergine10/received_events","type":"User","site_admin":false},"created_at":"2018-07-22T18:53:31Z","updated_at":"2018-07-22T18:53:31Z","author_association":"NONE","body":"Performance has been an issue with Rush Hour 2 since inception, and affects many aspects of that mod (eg. see: https://github.com/PropaneDragon/Rush-Hour-2/issues/22 ).\r\n\r\nThe update with \"lights out\" was bundled with loads of other stuff, all of which was implemented in ways that caused performance issues, including the lights out bit.\r\n\r\nPart of the problem is that RH2 is doing \"lights out\" for all types of buildings, but also doing a shed load of logic to determine if a building has it's lights out or not - isn't that going to fubar branch predication?\r\n\r\nThe \"lights out but building still on\" should only be applied to residential buildings (as turning building off would be non viable due to causing all cims to be evicted).\r\n\r\nAll other types of buildings should really use the \"building turned off\" approach (maybe with some override of warning indicators) as that would also prevent deliveries, workers, etc. -- discussed in #78 .\r\n\r\nFor the residential buildings it should be just a percentage of them (from memory RH2 is actually checking whether the cims in a residence are at home and crazy stuff like that). So once a percentage has the lights turned out (ideally of a time span of one in-game hour for some variance) they just stay off until morning (specifically ~1 hour before day shift starts?).\r\n\r\nI assume the game is already retaining lighting state somehow - otherwise all the lights would be flashing on and off all night in vanilla. As long as the function(s) which affect lighting on residences can be found, it should be viable to prevent the lights coming back on at unwanted times.\r\n\r\nNote: I'd expect things like power coming back on after a power outage to cause lights to go back on, and I'd be happy for them to stay on until morning in that scenario because I'd be checking all areas of my city for power outages (a power outage will often cause other problems so when checking I've fixed things I tend to look at the lights rather than confusing multi-state warning bubbles)."}}
{"actor":{"display_login":"aubergine10"}}