{"action":"created","issue":{"url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/1666","repository_url":"https://api.github.com/repos/mattermost/mattermost-webapp","labels_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/1666/labels{/name}","comments_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/1666/comments","events_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/1666/events","html_url":"https://github.com/mattermost/mattermost-webapp/pull/1666","id":357427663,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNDQ2Mjgy","number":1666,"title":"Refactor Modals, ChannelHeader and Navbar component","user":{"login":"cometkim","id":9696352,"node_id":"MDQ6VXNlcjk2OTYzNTI=","avatar_url":"https://avatars3.githubusercontent.com/u/9696352?v=4","gravatar_id":"","url":"https://api.github.com/users/cometkim","html_url":"https://github.com/cometkim","followers_url":"https://api.github.com/users/cometkim/followers","following_url":"https://api.github.com/users/cometkim/following{/other_user}","gists_url":"https://api.github.com/users/cometkim/gists{/gist_id}","starred_url":"https://api.github.com/users/cometkim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cometkim/subscriptions","organizations_url":"https://api.github.com/users/cometkim/orgs","repos_url":"https://api.github.com/users/cometkim/repos","events_url":"https://api.github.com/users/cometkim/events{/privacy}","received_events_url":"https://api.github.com/users/cometkim/received_events","type":"User","site_admin":false},"labels":[{"id":685999255,"node_id":"MDU6TGFiZWw2ODU5OTkyNTU=","url":"https://api.github.com/repos/mattermost/mattermost-webapp/labels/2:%20Dev%20Review","name":"2: Dev Review","color":"eb6420","default":false},{"id":708533639,"node_id":"MDU6TGFiZWw3MDg1MzM2Mzk=","url":"https://api.github.com/repos/mattermost/mattermost-webapp/labels/Hacktoberfest","name":"Hacktoberfest","color":"eb6420","default":false},{"id":997129920,"node_id":"MDU6TGFiZWw5OTcxMjk5MjA=","url":"https://api.github.com/repos/mattermost/mattermost-webapp/labels/QA%20Review","name":"QA Review","color":"7cdfe2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":44,"created_at":"2018-09-05T22:30:51Z","updated_at":"2018-11-05T17:10:49Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/1666","html_url":"https://github.com/mattermost/mattermost-webapp/pull/1666","diff_url":"https://github.com/mattermost/mattermost-webapp/pull/1666.diff","patch_url":"https://github.com/mattermost/mattermost-webapp/pull/1666.patch"},"body":"#### Summary\r\n- [x] Refactor ChannelHeader and MobileChannelHeader, includes:\r\n  - [x] Move to Redux store\r\n  - [x] Move to Pure or SFC\r\n  - [x] Extract duplicates to components and share it\r\n  - [x] Rename `NavBar` to ~~`MobileChannelHeader`~~ `ChannelHeaderMobile` for consistency\r\n  - [x] Uses `ModalController` instead of manage modal internally\r\n    - explainer:\r\n    ![image](https://user-images.githubusercontent.com/9696352/46029667-09646c00-c12f-11e8-8d26-368715699a2a.png)\r\n   Many modals would rendered twice, in NavBar and ChannelHeader\r\n  - [x] Re-organize cases where dropdown menus can appear\r\n  - [x] Remove unused codes and uncovered cases\r\n  - [x] Remove jQuery\r\n\r\n#### Ticket Link\r\n\r\nInviteMemberModal\r\n- https://github.com/mattermost/mattermost-server/issues/7683\r\n\r\nNavbar\r\n- MM-11283\r\n- https://github.com/mattermost/mattermost-server/issues/9093\r\n\r\n#### Checklist\r\n- [x] Ran `make check-style` to check for style errors (required for all pull requests)\r\n- [x] Ran `make test` to ensure unit and component tests passed\r\n- [x] Added or updated unit tests (required for all new features)\r\n- [x] Has UI changes\r\n"},"comment":{"url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/comments/435955214","html_url":"https://github.com/mattermost/mattermost-webapp/pull/1666#issuecomment-435955214","issue_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/1666","id":435955214,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTk1NTIxNA==","user":{"login":"cometkim","id":9696352,"node_id":"MDQ6VXNlcjk2OTYzNTI=","avatar_url":"https://avatars3.githubusercontent.com/u/9696352?v=4","gravatar_id":"","url":"https://api.github.com/users/cometkim","html_url":"https://github.com/cometkim","followers_url":"https://api.github.com/users/cometkim/followers","following_url":"https://api.github.com/users/cometkim/following{/other_user}","gists_url":"https://api.github.com/users/cometkim/gists{/gist_id}","starred_url":"https://api.github.com/users/cometkim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cometkim/subscriptions","organizations_url":"https://api.github.com/users/cometkim/orgs","repos_url":"https://api.github.com/users/cometkim/repos","events_url":"https://api.github.com/users/cometkim/events{/privacy}","received_events_url":"https://api.github.com/users/cometkim/received_events","type":"User","site_admin":false},"created_at":"2018-11-05T17:10:49Z","updated_at":"2018-11-05T17:10:49Z","author_association":"CONTRIBUTOR","body":"@jwilander Now PR is ready for QA test. I just rebased and fixed a bug I mentioned above."}}
{"actor":{"display_login":"cometkim"}}