{"action":"created","issue":{"url":"https://api.github.com/repos/jMonkeyEngine/jmonkeyengine/issues/875","repository_url":"https://api.github.com/repos/jMonkeyEngine/jmonkeyengine","labels_url":"https://api.github.com/repos/jMonkeyEngine/jmonkeyengine/issues/875/labels{/name}","comments_url":"https://api.github.com/repos/jMonkeyEngine/jmonkeyengine/issues/875/comments","events_url":"https://api.github.com/repos/jMonkeyEngine/jmonkeyengine/issues/875/events","html_url":"https://github.com/jMonkeyEngine/jmonkeyengine/pull/875","id":343402804,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMDU1MTM3","number":875,"title":"Fix AudioNode issues when using velocityFromTranslation and small refactoring","user":{"login":"riccardobl","id":4943530,"node_id":"MDQ6VXNlcjQ5NDM1MzA=","avatar_url":"https://avatars1.githubusercontent.com/u/4943530?v=4","gravatar_id":"","url":"https://api.github.com/users/riccardobl","html_url":"https://github.com/riccardobl","followers_url":"https://api.github.com/users/riccardobl/followers","following_url":"https://api.github.com/users/riccardobl/following{/other_user}","gists_url":"https://api.github.com/users/riccardobl/gists{/gist_id}","starred_url":"https://api.github.com/users/riccardobl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riccardobl/subscriptions","organizations_url":"https://api.github.com/users/riccardobl/orgs","repos_url":"https://api.github.com/users/riccardobl/repos","events_url":"https://api.github.com/users/riccardobl/events{/privacy}","received_events_url":"https://api.github.com/users/riccardobl/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-07-22T12:37:51Z","updated_at":"2018-12-21T09:50:38Z","closed_at":"2018-09-06T19:42:49Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/jMonkeyEngine/jmonkeyengine/pulls/875","html_url":"https://github.com/jMonkeyEngine/jmonkeyengine/pull/875","diff_url":"https://github.com/jMonkeyEngine/jmonkeyengine/pull/875.diff","patch_url":"https://github.com/jMonkeyEngine/jmonkeyengine/pull/875.patch"},"body":"This PR fixes some issues in the AudioNode that caused wrong velocity calculation when using velocityFromTranslation.\r\n\r\nIn short, when cloning the node, previousWorldTranslation wasn't reset to its initial value but cloned as reference, and the first velocity update was a subtraction with a NaN.\r\n\r\nI've also modified the cloneFields method to reset the velocity to 0 if velocityFromTranslation is set, to prevent cloned nodes from preserving the velocity of the original in case they are never moved."},"comment":{"url":"https://api.github.com/repos/jMonkeyEngine/jmonkeyengine/issues/comments/449337213","html_url":"https://github.com/jMonkeyEngine/jmonkeyengine/pull/875#issuecomment-449337213","issue_url":"https://api.github.com/repos/jMonkeyEngine/jmonkeyengine/issues/875","id":449337213,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTMzNzIxMw==","user":{"login":"pspeed42","id":7004062,"node_id":"MDQ6VXNlcjcwMDQwNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/7004062?v=4","gravatar_id":"","url":"https://api.github.com/users/pspeed42","html_url":"https://github.com/pspeed42","followers_url":"https://api.github.com/users/pspeed42/followers","following_url":"https://api.github.com/users/pspeed42/following{/other_user}","gists_url":"https://api.github.com/users/pspeed42/gists{/gist_id}","starred_url":"https://api.github.com/users/pspeed42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pspeed42/subscriptions","organizations_url":"https://api.github.com/users/pspeed42/orgs","repos_url":"https://api.github.com/users/pspeed42/repos","events_url":"https://api.github.com/users/pspeed42/events{/privacy}","received_events_url":"https://api.github.com/users/pspeed42/received_events","type":"User","site_admin":false},"created_at":"2018-12-21T09:50:38Z","updated_at":"2018-12-21T09:50:38Z","author_association":"CONTRIBUTOR","body":"Position worked before and now it doesn't, right.  Velocity may have been broken before but position definitely wasn't... at least not when I've used it in the past."}}
{"actor":{"display_login":"pspeed42"}}