{"action":"created","comment":{"url":"https://api.github.com/repos/influxdata/platform/pulls/comments/204079102","pull_request_review_id":139099124,"id":204079102,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDA3OTEwMg==","diff_hunk":"@@ -0,0 +1,52 @@\n+package platform\n+\n+import (\n+\t\"bytes\"\n+\t\"testing\"\n+)\n+\n+func TestDecodeFromString(t *testing.T) {","path":"id_test.go","position":8,"original_position":8,"commit_id":"e009da37c4ad9d676a2474c6500bdeb4747f3a84","original_commit_id":"e009da37c4ad9d676a2474c6500bdeb4747f3a84","user":{"login":"mark-rushakoff","id":290647,"node_id":"MDQ6VXNlcjI5MDY0Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/290647?v=4","gravatar_id":"","url":"https://api.github.com/users/mark-rushakoff","html_url":"https://github.com/mark-rushakoff","followers_url":"https://api.github.com/users/mark-rushakoff/followers","following_url":"https://api.github.com/users/mark-rushakoff/following{/other_user}","gists_url":"https://api.github.com/users/mark-rushakoff/gists{/gist_id}","starred_url":"https://api.github.com/users/mark-rushakoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mark-rushakoff/subscriptions","organizations_url":"https://api.github.com/users/mark-rushakoff/orgs","repos_url":"https://api.github.com/users/mark-rushakoff/repos","events_url":"https://api.github.com/users/mark-rushakoff/events{/privacy}","received_events_url":"https://api.github.com/users/mark-rushakoff/received_events","type":"User","site_admin":false},"body":"The numbers are going to have to get stringified one way or another for presentation in URLs, links, etc.\r\n\r\nOne thing I've really disliked about the hex encoding is the \"sometimes\" leading 0, i.e. 0-15 decimal turn into `00`-`0f` rather than `0`-`f`.\r\n\r\nIf we're switching the ID from a byte slice to a uint64 I think the encoding should be up for grabs too. It's probably a team discussion to decide what the encoding format should be.","created_at":"2018-07-20T15:18:29Z","updated_at":"2018-07-20T15:19:18Z","html_url":"https://github.com/influxdata/platform/pull/442#discussion_r204079102","pull_request_url":"https://api.github.com/repos/influxdata/platform/pulls/442","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/influxdata/platform/pulls/comments/204079102"},"html":{"href":"https://github.com/influxdata/platform/pull/442#discussion_r204079102"},"pull_request":{"href":"https://api.github.com/repos/influxdata/platform/pulls/442"}},"in_reply_to_id":204073887},"pull_request":{"url":"https://api.github.com/repos/influxdata/platform/pulls/442","id":202809172,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyODA5MTcy","html_url":"https://github.com/influxdata/platform/pull/442","diff_url":"https://github.com/influxdata/platform/pull/442.diff","patch_url":"https://github.com/influxdata/platform/pull/442.patch","issue_url":"https://api.github.com/repos/influxdata/platform/issues/442","number":442,"state":"open","locked":false,"title":"[WIP] Platform ID using uint64","user":{"login":"leodido","id":120051,"node_id":"MDQ6VXNlcjEyMDA1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/120051?v=4","gravatar_id":"","url":"https://api.github.com/users/leodido","html_url":"https://github.com/leodido","followers_url":"https://api.github.com/users/leodido/followers","following_url":"https://api.github.com/users/leodido/following{/other_user}","gists_url":"https://api.github.com/users/leodido/gists{/gist_id}","starred_url":"https://api.github.com/users/leodido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leodido/subscriptions","organizations_url":"https://api.github.com/users/leodido/orgs","repos_url":"https://api.github.com/users/leodido/repos","events_url":"https://api.github.com/users/leodido/events{/privacy}","received_events_url":"https://api.github.com/users/leodido/received_events","type":"User","site_admin":false},"body":"Platform ID now uses `uint64`.\r\n\r\nTodo:\r\n- [ ] helper function to generate an ID pointer starting from a string\r\n- [ ] test empty string input\r\n- [ ] test non hex string input\r\n- [ ] refactor places where ID is used","created_at":"2018-07-20T10:28:38Z","updated_at":"2018-07-20T15:19:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf5e5363f682bf0a47ad9e4ae6bf8a71f4b2c44a","assignee":{"login":"leodido","id":120051,"node_id":"MDQ6VXNlcjEyMDA1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/120051?v=4","gravatar_id":"","url":"https://api.github.com/users/leodido","html_url":"https://github.com/leodido","followers_url":"https://api.github.com/users/leodido/followers","following_url":"https://api.github.com/users/leodido/following{/other_user}","gists_url":"https://api.github.com/users/leodido/gists{/gist_id}","starred_url":"https://api.github.com/users/leodido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leodido/subscriptions","organizations_url":"https://api.github.com/users/leodido/orgs","repos_url":"https://api.github.com/users/leodido/repos","events_url":"https://api.github.com/users/leodido/events{/privacy}","received_events_url":"https://api.github.com/users/leodido/received_events","type":"User","site_admin":false},"assignees":[{"login":"leodido","id":120051,"node_id":"MDQ6VXNlcjEyMDA1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/120051?v=4","gravatar_id":"","url":"https://api.github.com/users/leodido","html_url":"https://github.com/leodido","followers_url":"https://api.github.com/users/leodido/followers","following_url":"https://api.github.com/users/leodido/following{/other_user}","gists_url":"https://api.github.com/users/leodido/gists{/gist_id}","starred_url":"https://api.github.com/users/leodido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leodido/subscriptions","organizations_url":"https://api.github.com/users/leodido/orgs","repos_url":"https://api.github.com/users/leodido/repos","events_url":"https://api.github.com/users/leodido/events{/privacy}","received_events_url":"https://api.github.com/users/leodido/received_events","type":"User","site_admin":false},{"login":"fntlnz","id":3083633,"node_id":"MDQ6VXNlcjMwODM2MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/3083633?v=4","gravatar_id":"","url":"https://api.github.com/users/fntlnz","html_url":"https://github.com/fntlnz","followers_url":"https://api.github.com/users/fntlnz/followers","following_url":"https://api.github.com/users/fntlnz/following{/other_user}","gists_url":"https://api.github.com/users/fntlnz/gists{/gist_id}","starred_url":"https://api.github.com/users/fntlnz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fntlnz/subscriptions","organizations_url":"https://api.github.com/users/fntlnz/orgs","repos_url":"https://api.github.com/users/fntlnz/repos","events_url":"https://api.github.com/users/fntlnz/events{/privacy}","received_events_url":"https://api.github.com/users/fntlnz/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/influxdata/platform/pulls/442/commits","review_comments_url":"https://api.github.com/repos/influxdata/platform/pulls/442/comments","review_comment_url":"https://api.github.com/repos/influxdata/platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/influxdata/platform/issues/442/comments","statuses_url":"https://api.github.com/repos/influxdata/platform/statuses/e009da37c4ad9d676a2474c6500bdeb4747f3a84","head":{"label":"influxdata:feature/uint64-id","ref":"feature/uint64-id","sha":"e009da37c4ad9d676a2474c6500bdeb4747f3a84","user":{"login":"influxdata","id":5713248,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MTMyNDg=","avatar_url":"https://avatars2.githubusercontent.com/u/5713248?v=4","gravatar_id":"","url":"https://api.github.com/users/influxdata","html_url":"https://github.com/influxdata","followers_url":"https://api.github.com/users/influxdata/followers","following_url":"https://api.github.com/users/influxdata/following{/other_user}","gists_url":"https://api.github.com/users/influxdata/gists{/gist_id}","starred_url":"https://api.github.com/users/influxdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/influxdata/subscriptions","organizations_url":"https://api.github.com/users/influxdata/orgs","repos_url":"https://api.github.com/users/influxdata/repos","events_url":"https://api.github.com/users/influxdata/events{/privacy}","received_events_url":"https://api.github.com/users/influxdata/received_events","type":"Organization","site_admin":false},"repo":{"id":132783164,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI3ODMxNjQ=","name":"platform","full_name":"influxdata/platform","owner":{"login":"influxdata","id":5713248,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MTMyNDg=","avatar_url":"https://avatars2.githubusercontent.com/u/5713248?v=4","gravatar_id":"","url":"https://api.github.com/users/influxdata","html_url":"https://github.com/influxdata","followers_url":"https://api.github.com/users/influxdata/followers","following_url":"https://api.github.com/users/influxdata/following{/other_user}","gists_url":"https://api.github.com/users/influxdata/gists{/gist_id}","starred_url":"https://api.github.com/users/influxdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/influxdata/subscriptions","organizations_url":"https://api.github.com/users/influxdata/orgs","repos_url":"https://api.github.com/users/influxdata/repos","events_url":"https://api.github.com/users/influxdata/events{/privacy}","received_events_url":"https://api.github.com/users/influxdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/influxdata/platform","description":"InfluxDB 2.0: The community version of the InfluxData Platform for Time Series","fork":false,"url":"https://api.github.com/repos/influxdata/platform","forks_url":"https://api.github.com/repos/influxdata/platform/forks","keys_url":"https://api.github.com/repos/influxdata/platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/influxdata/platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/influxdata/platform/teams","hooks_url":"https://api.github.com/repos/influxdata/platform/hooks","issue_events_url":"https://api.github.com/repos/influxdata/platform/issues/events{/number}","events_url":"https://api.github.com/repos/influxdata/platform/events","assignees_url":"https://api.github.com/repos/influxdata/platform/assignees{/user}","branches_url":"https://api.github.com/repos/influxdata/platform/branches{/branch}","tags_url":"https://api.github.com/repos/influxdata/platform/tags","blobs_url":"https://api.github.com/repos/influxdata/platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/influxdata/platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/influxdata/platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/influxdata/platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/influxdata/platform/statuses/{sha}","languages_url":"https://api.github.com/repos/influxdata/platform/languages","stargazers_url":"https://api.github.com/repos/influxdata/platform/stargazers","contributors_url":"https://api.github.com/repos/influxdata/platform/contributors","subscribers_url":"https://api.github.com/repos/influxdata/platform/subscribers","subscription_url":"https://api.github.com/repos/influxdata/platform/subscription","commits_url":"https://api.github.com/repos/influxdata/platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/influxdata/platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/influxdata/platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/influxdata/platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/influxdata/platform/contents/{+path}","compare_url":"https://api.github.com/repos/influxdata/platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/influxdata/platform/merges","archive_url":"https://api.github.com/repos/influxdata/platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/influxdata/platform/downloads","issues_url":"https://api.github.com/repos/influxdata/platform/issues{/number}","pulls_url":"https://api.github.com/repos/influxdata/platform/pulls{/number}","milestones_url":"https://api.github.com/repos/influxdata/platform/milestones{/number}","notifications_url":"https://api.github.com/repos/influxdata/platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/influxdata/platform/labels{/name}","releases_url":"https://api.github.com/repos/influxdata/platform/releases{/id}","deployments_url":"https://api.github.com/repos/influxdata/platform/deployments","created_at":"2018-05-09T16:17:29Z","updated_at":"2018-07-20T15:12:23Z","pushed_at":"2018-07-20T15:02:45Z","git_url":"git://github.com/influxdata/platform.git","ssh_url":"git@github.com:influxdata/platform.git","clone_url":"https://github.com/influxdata/platform.git","svn_url":"https://github.com/influxdata/platform","homepage":"","size":50104,"stargazers_count":125,"watchers_count":125,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":222,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":222,"watchers":125,"default_branch":"master"}},"base":{"label":"influxdata:master","ref":"master","sha":"f2a8ae22b2e7e99afdad4699cbd4c9c2f31b188a","user":{"login":"influxdata","id":5713248,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MTMyNDg=","avatar_url":"https://avatars2.githubusercontent.com/u/5713248?v=4","gravatar_id":"","url":"https://api.github.com/users/influxdata","html_url":"https://github.com/influxdata","followers_url":"https://api.github.com/users/influxdata/followers","following_url":"https://api.github.com/users/influxdata/following{/other_user}","gists_url":"https://api.github.com/users/influxdata/gists{/gist_id}","starred_url":"https://api.github.com/users/influxdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/influxdata/subscriptions","organizations_url":"https://api.github.com/users/influxdata/orgs","repos_url":"https://api.github.com/users/influxdata/repos","events_url":"https://api.github.com/users/influxdata/events{/privacy}","received_events_url":"https://api.github.com/users/influxdata/received_events","type":"Organization","site_admin":false},"repo":{"id":132783164,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI3ODMxNjQ=","name":"platform","full_name":"influxdata/platform","owner":{"login":"influxdata","id":5713248,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MTMyNDg=","avatar_url":"https://avatars2.githubusercontent.com/u/5713248?v=4","gravatar_id":"","url":"https://api.github.com/users/influxdata","html_url":"https://github.com/influxdata","followers_url":"https://api.github.com/users/influxdata/followers","following_url":"https://api.github.com/users/influxdata/following{/other_user}","gists_url":"https://api.github.com/users/influxdata/gists{/gist_id}","starred_url":"https://api.github.com/users/influxdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/influxdata/subscriptions","organizations_url":"https://api.github.com/users/influxdata/orgs","repos_url":"https://api.github.com/users/influxdata/repos","events_url":"https://api.github.com/users/influxdata/events{/privacy}","received_events_url":"https://api.github.com/users/influxdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/influxdata/platform","description":"InfluxDB 2.0: The community version of the InfluxData Platform for Time Series","fork":false,"url":"https://api.github.com/repos/influxdata/platform","forks_url":"https://api.github.com/repos/influxdata/platform/forks","keys_url":"https://api.github.com/repos/influxdata/platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/influxdata/platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/influxdata/platform/teams","hooks_url":"https://api.github.com/repos/influxdata/platform/hooks","issue_events_url":"https://api.github.com/repos/influxdata/platform/issues/events{/number}","events_url":"https://api.github.com/repos/influxdata/platform/events","assignees_url":"https://api.github.com/repos/influxdata/platform/assignees{/user}","branches_url":"https://api.github.com/repos/influxdata/platform/branches{/branch}","tags_url":"https://api.github.com/repos/influxdata/platform/tags","blobs_url":"https://api.github.com/repos/influxdata/platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/influxdata/platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/influxdata/platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/influxdata/platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/influxdata/platform/statuses/{sha}","languages_url":"https://api.github.com/repos/influxdata/platform/languages","stargazers_url":"https://api.github.com/repos/influxdata/platform/stargazers","contributors_url":"https://api.github.com/repos/influxdata/platform/contributors","subscribers_url":"https://api.github.com/repos/influxdata/platform/subscribers","subscription_url":"https://api.github.com/repos/influxdata/platform/subscription","commits_url":"https://api.github.com/repos/influxdata/platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/influxdata/platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/influxdata/platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/influxdata/platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/influxdata/platform/contents/{+path}","compare_url":"https://api.github.com/repos/influxdata/platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/influxdata/platform/merges","archive_url":"https://api.github.com/repos/influxdata/platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/influxdata/platform/downloads","issues_url":"https://api.github.com/repos/influxdata/platform/issues{/number}","pulls_url":"https://api.github.com/repos/influxdata/platform/pulls{/number}","milestones_url":"https://api.github.com/repos/influxdata/platform/milestones{/number}","notifications_url":"https://api.github.com/repos/influxdata/platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/influxdata/platform/labels{/name}","releases_url":"https://api.github.com/repos/influxdata/platform/releases{/id}","deployments_url":"https://api.github.com/repos/influxdata/platform/deployments","created_at":"2018-05-09T16:17:29Z","updated_at":"2018-07-20T15:12:23Z","pushed_at":"2018-07-20T15:02:45Z","git_url":"git://github.com/influxdata/platform.git","ssh_url":"git@github.com:influxdata/platform.git","clone_url":"https://github.com/influxdata/platform.git","svn_url":"https://github.com/influxdata/platform","homepage":"","size":50104,"stargazers_count":125,"watchers_count":125,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":222,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":222,"watchers":125,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/influxdata/platform/pulls/442"},"html":{"href":"https://github.com/influxdata/platform/pull/442"},"issue":{"href":"https://api.github.com/repos/influxdata/platform/issues/442"},"comments":{"href":"https://api.github.com/repos/influxdata/platform/issues/442/comments"},"review_comments":{"href":"https://api.github.com/repos/influxdata/platform/pulls/442/comments"},"review_comment":{"href":"https://api.github.com/repos/influxdata/platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/influxdata/platform/pulls/442/commits"},"statuses":{"href":"https://api.github.com/repos/influxdata/platform/statuses/e009da37c4ad9d676a2474c6500bdeb4747f3a84"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mark-rushakoff"}}