{"action":"closed","number":676,"pull_request":{"url":"https://api.github.com/repos/electron/libchromiumcontent/pulls/676","id":213794847,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNzk0ODQ3","html_url":"https://github.com/electron/libchromiumcontent/pull/676","diff_url":"https://github.com/electron/libchromiumcontent/pull/676.diff","patch_url":"https://github.com/electron/libchromiumcontent/pull/676.patch","issue_url":"https://api.github.com/repos/electron/libchromiumcontent/issues/676","number":676,"state":"closed","locked":false,"title":"fix: do not let Chromium manage webview's frame's lifetime","user":{"login":"zcbenz","id":639601,"node_id":"MDQ6VXNlcjYzOTYwMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/639601?v=4","gravatar_id":"","url":"https://api.github.com/users/zcbenz","html_url":"https://github.com/zcbenz","followers_url":"https://api.github.com/users/zcbenz/followers","following_url":"https://api.github.com/users/zcbenz/following{/other_user}","gists_url":"https://api.github.com/users/zcbenz/gists{/gist_id}","starred_url":"https://api.github.com/users/zcbenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcbenz/subscriptions","organizations_url":"https://api.github.com/users/zcbenz/orgs","repos_url":"https://api.github.com/users/zcbenz/repos","events_url":"https://api.github.com/users/zcbenz/events{/privacy}","received_events_url":"https://api.github.com/users/zcbenz/received_events","type":"User","site_admin":true},"body":"##### Description of Change\r\n\r\nThis is part of fixes for https://github.com/electron/electron/issues/14211.\r\n\r\nAs explained in https://github.com/electron/electron/issues/14211#issuecomment-418616406, Chromium has some race conditions when managing WebFrame of webview that, it will sometimes accidentally detach the WebFrame of webview, resulting in the WebContents of webview being wrongly destroyed.\r\n\r\nThis patch disables Chromium's ability to detach the WebFrame of webview. There will be another patch in Electron to manually manage the WebContents of webview on Electron's side.\r\n\r\n##### Checklist\r\n\r\n- [x] PR description included and stakeholders cc'd\r\n- [x] Patch information is added to appropriate `.patches.yaml`\r\n- [x] `script/update` runs without error\r\n- [x] PR title follows semantic [commit guidelines](https://github.com/electron/electron/blob/master/docs/development/pull-requests.md#commit-message-guidelines)","created_at":"2018-09-07T01:47:59Z","updated_at":"2018-09-07T15:47:23Z","closed_at":"2018-09-07T15:47:23Z","merged_at":"2018-09-07T15:47:23Z","merge_commit_sha":"f3a3f588281aba034a0f1f85ca3c65eb5a3f7b66","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/electron/libchromiumcontent/pulls/676/commits","review_comments_url":"https://api.github.com/repos/electron/libchromiumcontent/pulls/676/comments","review_comment_url":"https://api.github.com/repos/electron/libchromiumcontent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/libchromiumcontent/issues/676/comments","statuses_url":"https://api.github.com/repos/electron/libchromiumcontent/statuses/6fdee949b2b153cb6e64217ee984e010b5e9028c","head":{"label":"electron:manage-webview-webcontents","ref":"manage-webview-webcontents","sha":"6fdee949b2b153cb6e64217ee984e010b5e9028c","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":8479951,"node_id":"MDEwOlJlcG9zaXRvcnk4NDc5OTUx","name":"libchromiumcontent","full_name":"electron/libchromiumcontent","owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/electron/libchromiumcontent","description":"Shared library build of Chromium’s Content module","fork":false,"url":"https://api.github.com/repos/electron/libchromiumcontent","forks_url":"https://api.github.com/repos/electron/libchromiumcontent/forks","keys_url":"https://api.github.com/repos/electron/libchromiumcontent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/libchromiumcontent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/libchromiumcontent/teams","hooks_url":"https://api.github.com/repos/electron/libchromiumcontent/hooks","issue_events_url":"https://api.github.com/repos/electron/libchromiumcontent/issues/events{/number}","events_url":"https://api.github.com/repos/electron/libchromiumcontent/events","assignees_url":"https://api.github.com/repos/electron/libchromiumcontent/assignees{/user}","branches_url":"https://api.github.com/repos/electron/libchromiumcontent/branches{/branch}","tags_url":"https://api.github.com/repos/electron/libchromiumcontent/tags","blobs_url":"https://api.github.com/repos/electron/libchromiumcontent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/libchromiumcontent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/libchromiumcontent/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/libchromiumcontent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/libchromiumcontent/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/libchromiumcontent/languages","stargazers_url":"https://api.github.com/repos/electron/libchromiumcontent/stargazers","contributors_url":"https://api.github.com/repos/electron/libchromiumcontent/contributors","subscribers_url":"https://api.github.com/repos/electron/libchromiumcontent/subscribers","subscription_url":"https://api.github.com/repos/electron/libchromiumcontent/subscription","commits_url":"https://api.github.com/repos/electron/libchromiumcontent/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/libchromiumcontent/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/libchromiumcontent/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/libchromiumcontent/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/libchromiumcontent/contents/{+path}","compare_url":"https://api.github.com/repos/electron/libchromiumcontent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/libchromiumcontent/merges","archive_url":"https://api.github.com/repos/electron/libchromiumcontent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/libchromiumcontent/downloads","issues_url":"https://api.github.com/repos/electron/libchromiumcontent/issues{/number}","pulls_url":"https://api.github.com/repos/electron/libchromiumcontent/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/libchromiumcontent/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/libchromiumcontent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/libchromiumcontent/labels{/name}","releases_url":"https://api.github.com/repos/electron/libchromiumcontent/releases{/id}","deployments_url":"https://api.github.com/repos/electron/libchromiumcontent/deployments","created_at":"2013-02-28T13:48:40Z","updated_at":"2018-09-06T06:51:18Z","pushed_at":"2018-09-07T15:47:23Z","git_url":"git://github.com/electron/libchromiumcontent.git","ssh_url":"git@github.com:electron/libchromiumcontent.git","clone_url":"https://github.com/electron/libchromiumcontent.git","svn_url":"https://github.com/electron/libchromiumcontent","homepage":"","size":39458,"stargazers_count":455,"watchers_count":455,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":168,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":168,"open_issues":37,"watchers":455,"default_branch":"master"}},"base":{"label":"electron:master","ref":"master","sha":"d2ffd8ab4b238cb9fa16026ea95bd24b5c79915f","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":8479951,"node_id":"MDEwOlJlcG9zaXRvcnk4NDc5OTUx","name":"libchromiumcontent","full_name":"electron/libchromiumcontent","owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/electron/libchromiumcontent","description":"Shared library build of Chromium’s Content module","fork":false,"url":"https://api.github.com/repos/electron/libchromiumcontent","forks_url":"https://api.github.com/repos/electron/libchromiumcontent/forks","keys_url":"https://api.github.com/repos/electron/libchromiumcontent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/libchromiumcontent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/libchromiumcontent/teams","hooks_url":"https://api.github.com/repos/electron/libchromiumcontent/hooks","issue_events_url":"https://api.github.com/repos/electron/libchromiumcontent/issues/events{/number}","events_url":"https://api.github.com/repos/electron/libchromiumcontent/events","assignees_url":"https://api.github.com/repos/electron/libchromiumcontent/assignees{/user}","branches_url":"https://api.github.com/repos/electron/libchromiumcontent/branches{/branch}","tags_url":"https://api.github.com/repos/electron/libchromiumcontent/tags","blobs_url":"https://api.github.com/repos/electron/libchromiumcontent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/libchromiumcontent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/libchromiumcontent/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/libchromiumcontent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/libchromiumcontent/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/libchromiumcontent/languages","stargazers_url":"https://api.github.com/repos/electron/libchromiumcontent/stargazers","contributors_url":"https://api.github.com/repos/electron/libchromiumcontent/contributors","subscribers_url":"https://api.github.com/repos/electron/libchromiumcontent/subscribers","subscription_url":"https://api.github.com/repos/electron/libchromiumcontent/subscription","commits_url":"https://api.github.com/repos/electron/libchromiumcontent/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/libchromiumcontent/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/libchromiumcontent/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/libchromiumcontent/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/libchromiumcontent/contents/{+path}","compare_url":"https://api.github.com/repos/electron/libchromiumcontent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/libchromiumcontent/merges","archive_url":"https://api.github.com/repos/electron/libchromiumcontent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/libchromiumcontent/downloads","issues_url":"https://api.github.com/repos/electron/libchromiumcontent/issues{/number}","pulls_url":"https://api.github.com/repos/electron/libchromiumcontent/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/libchromiumcontent/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/libchromiumcontent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/libchromiumcontent/labels{/name}","releases_url":"https://api.github.com/repos/electron/libchromiumcontent/releases{/id}","deployments_url":"https://api.github.com/repos/electron/libchromiumcontent/deployments","created_at":"2013-02-28T13:48:40Z","updated_at":"2018-09-06T06:51:18Z","pushed_at":"2018-09-07T15:47:23Z","git_url":"git://github.com/electron/libchromiumcontent.git","ssh_url":"git@github.com:electron/libchromiumcontent.git","clone_url":"https://github.com/electron/libchromiumcontent.git","svn_url":"https://github.com/electron/libchromiumcontent","homepage":"","size":39458,"stargazers_count":455,"watchers_count":455,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":168,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":168,"open_issues":37,"watchers":455,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/libchromiumcontent/pulls/676"},"html":{"href":"https://github.com/electron/libchromiumcontent/pull/676"},"issue":{"href":"https://api.github.com/repos/electron/libchromiumcontent/issues/676"},"comments":{"href":"https://api.github.com/repos/electron/libchromiumcontent/issues/676/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/libchromiumcontent/pulls/676/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/libchromiumcontent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/libchromiumcontent/pulls/676/commits"},"statuses":{"href":"https://api.github.com/repos/electron/libchromiumcontent/statuses/6fdee949b2b153cb6e64217ee984e010b5e9028c"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"codebytere","id":2036040,"node_id":"MDQ6VXNlcjIwMzYwNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/2036040?v=4","gravatar_id":"","url":"https://api.github.com/users/codebytere","html_url":"https://github.com/codebytere","followers_url":"https://api.github.com/users/codebytere/followers","following_url":"https://api.github.com/users/codebytere/following{/other_user}","gists_url":"https://api.github.com/users/codebytere/gists{/gist_id}","starred_url":"https://api.github.com/users/codebytere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codebytere/subscriptions","organizations_url":"https://api.github.com/users/codebytere/orgs","repos_url":"https://api.github.com/users/codebytere/repos","events_url":"https://api.github.com/users/codebytere/events{/privacy}","received_events_url":"https://api.github.com/users/codebytere/received_events","type":"User","site_admin":true},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":27,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"codebytere"}}