{"action":"created","issue":{"url":"https://api.github.com/repos/thirtybees/thirtybees/issues/807","repository_url":"https://api.github.com/repos/thirtybees/thirtybees","labels_url":"https://api.github.com/repos/thirtybees/thirtybees/issues/807/labels{/name}","comments_url":"https://api.github.com/repos/thirtybees/thirtybees/issues/807/comments","events_url":"https://api.github.com/repos/thirtybees/thirtybees/issues/807/events","html_url":"https://github.com/thirtybees/thirtybees/issues/807","id":394260979,"node_id":"MDU6SXNzdWUzOTQyNjA5Nzk=","number":807,"title":"Configuration - incorrect escaping ","user":{"login":"getdatakick","id":34651851,"node_id":"MDQ6VXNlcjM0NjUxODUx","avatar_url":"https://avatars0.githubusercontent.com/u/34651851?v=4","gravatar_id":"","url":"https://api.github.com/users/getdatakick","html_url":"https://github.com/getdatakick","followers_url":"https://api.github.com/users/getdatakick/followers","following_url":"https://api.github.com/users/getdatakick/following{/other_user}","gists_url":"https://api.github.com/users/getdatakick/gists{/gist_id}","starred_url":"https://api.github.com/users/getdatakick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getdatakick/subscriptions","organizations_url":"https://api.github.com/users/getdatakick/orgs","repos_url":"https://api.github.com/users/getdatakick/repos","events_url":"https://api.github.com/users/getdatakick/events{/privacy}","received_events_url":"https://api.github.com/users/getdatakick/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-12-26T23:59:18Z","updated_at":"2018-12-29T16:39:46Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"This is injection by commit 12d2d6c5f9f8c6d821603fba011e9de03eb1f70d\r\n\r\nBasically, this commit broke following assumption:\r\n\r\n```\r\nConfiguration::updateValue($key, $value);\r\n$value == Configuration::get($key);\r\n```\r\n\r\nas demonstrated in this [test](https://github.com/thirtybees/thirtybees/blob/e03617e6fce78298dfd08865d199bce436271e95/tests/integration/ConfigurationCoreTest.php). I've deliberately submitted the test even though it's failing, as this issue should be addressed promptly. \r\n\r\n@Traumflug, I'll keep the fix on you, since I don't know much about the reasons behind this change."},"comment":{"url":"https://api.github.com/repos/thirtybees/thirtybees/issues/comments/450504782","html_url":"https://github.com/thirtybees/thirtybees/issues/807#issuecomment-450504782","issue_url":"https://api.github.com/repos/thirtybees/thirtybees/issues/807","id":450504782,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDUwNDc4Mg==","user":{"login":"Traumflug","id":318581,"node_id":"MDQ6VXNlcjMxODU4MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/318581?v=4","gravatar_id":"","url":"https://api.github.com/users/Traumflug","html_url":"https://github.com/Traumflug","followers_url":"https://api.github.com/users/Traumflug/followers","following_url":"https://api.github.com/users/Traumflug/following{/other_user}","gists_url":"https://api.github.com/users/Traumflug/gists{/gist_id}","starred_url":"https://api.github.com/users/Traumflug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Traumflug/subscriptions","organizations_url":"https://api.github.com/users/Traumflug/orgs","repos_url":"https://api.github.com/users/Traumflug/repos","events_url":"https://api.github.com/users/Traumflug/events{/privacy}","received_events_url":"https://api.github.com/users/Traumflug/received_events","type":"User","site_admin":false},"created_at":"2018-12-29T16:39:46Z","updated_at":"2018-12-29T16:39:46Z","author_association":"COLLABORATOR","body":"Without having time to investigate this, I think the commit found guilty just uncovered other behavior. This assumption:\r\n```php\r\nConfiguration::updateValue($key, $value);\r\n$value == Configuration::get($key);\r\n```\r\nwas only true on the same request before the commit, but not on the next request. Which means, just reloading a page using a setting subject to `pSQL()` changed the displayed data. With the commit, this change happens immediately.\r\n"}}
{"actor":{"display_login":"Traumflug"}}