{"action":"created","comment":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments/211644240","pull_request_review_id":148109363,"id":211644240,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTY0NDI0MA==","diff_hunk":"@@ -49,14 +49,15 @@ set_property(CACHE CPACK_PACKAGE_SUFFIX PROPERTY STRINGS nightly unstable \"\") #e\n set ( CPACK_PACKAGE_NAME \"mantid${CPACK_PACKAGE_SUFFIX}\" )","path":"CMakeLists.txt","position":1,"original_position":1,"commit_id":"bd2fa016e5214a1243a364528fff1ebf6c5e0162","original_commit_id":"bd2fa016e5214a1243a364528fff1ebf6c5e0162","user":{"login":"brandonhewer","id":15521164,"node_id":"MDQ6VXNlcjE1NTIxMTY0","avatar_url":"https://avatars0.githubusercontent.com/u/15521164?v=4","gravatar_id":"","url":"https://api.github.com/users/brandonhewer","html_url":"https://github.com/brandonhewer","followers_url":"https://api.github.com/users/brandonhewer/followers","following_url":"https://api.github.com/users/brandonhewer/following{/other_user}","gists_url":"https://api.github.com/users/brandonhewer/gists{/gist_id}","starred_url":"https://api.github.com/users/brandonhewer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandonhewer/subscriptions","organizations_url":"https://api.github.com/users/brandonhewer/orgs","repos_url":"https://api.github.com/users/brandonhewer/repos","events_url":"https://api.github.com/users/brandonhewer/events{/privacy}","received_events_url":"https://api.github.com/users/brandonhewer/received_events","type":"User","site_admin":false},"body":"The CMakeLists.txt file shouldn't be included amongst the changes in this PR","created_at":"2018-08-21T15:11:16Z","updated_at":"2018-08-21T15:17:01Z","html_url":"https://github.com/mantidproject/mantid/pull/23186#discussion_r211644240","pull_request_url":"https://api.github.com/repos/mantidproject/mantid/pulls/23186","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments/211644240"},"html":{"href":"https://github.com/mantidproject/mantid/pull/23186#discussion_r211644240"},"pull_request":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/23186"}}},"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/23186","id":206072935,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MDcyOTM1","html_url":"https://github.com/mantidproject/mantid/pull/23186","diff_url":"https://github.com/mantidproject/mantid/pull/23186.diff","patch_url":"https://github.com/mantidproject/mantid/pull/23186.patch","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/23186","number":23186,"state":"open","locked":false,"title":"Solved fit constraints boundary problem Re #23089","user":{"login":"aybamidele","id":31194136,"node_id":"MDQ6VXNlcjMxMTk0MTM2","avatar_url":"https://avatars1.githubusercontent.com/u/31194136?v=4","gravatar_id":"","url":"https://api.github.com/users/aybamidele","html_url":"https://github.com/aybamidele","followers_url":"https://api.github.com/users/aybamidele/followers","following_url":"https://api.github.com/users/aybamidele/following{/other_user}","gists_url":"https://api.github.com/users/aybamidele/gists{/gist_id}","starred_url":"https://api.github.com/users/aybamidele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aybamidele/subscriptions","organizations_url":"https://api.github.com/users/aybamidele/orgs","repos_url":"https://api.github.com/users/aybamidele/repos","events_url":"https://api.github.com/users/aybamidele/events{/privacy}","received_events_url":"https://api.github.com/users/aybamidele/received_events","type":"User","site_admin":false},"body":"**Description of work.**\r\nchanged the way the current value about which the bounds are obtained from\r\n`double x = m_doubleManager->value(parProp);`\r\nto\r\n`double x = parProp->valueText().toDouble();`.\r\n\r\n**Report to:** [@NickDraper] <!--If the original issue was raised by a user they should be named here. Do not leak email addresses-->\r\n\r\n**To test:**\r\nOpen MantidPlot\r\nLoad some data\r\nTry to do a fit with constraints\r\nThe upper and lower bounds are not set to zero now\r\nClick on the fit button\r\nThe fit should be successful \r\n<!-- Instructions for testing. -->\r\n\r\nFixes #23089 . <!-- and fix #xxxx or close #xxxx xor resolves #xxxx -->\r\n<!-- alternative\r\n*There is no associated issue.\r\n-->\r\n\r\n<!-- delete this if you added release notes\r\n*This does not require release notes* because **fill in an explanation of why**\r\n-->\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- Is the code of an acceptable quality?\r\n- Does the code conform to the [coding standards](http://developer.mantidproject.org/Standards/)?\r\n- Are the unit tests small and test the class in isolation?\r\n- If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- Do changes function as described? Add comments below that describe the tests performed?\r\n- Do the changes handle unexpected situations, e.g. bad input?\r\n- Has the relevant (user and developer) documentation been added/updated?\r\n\r\nDoes everything look good? Mark the review as **Approve**. A member of `@mantidproject/gatekeepers` will take care of it.\r\n","created_at":"2018-08-03T15:59:24Z","updated_at":"2018-08-21T15:17:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d69c270956e492282db4f2e59885c9720d03f413","assignee":null,"assignees":[],"requested_reviewers":[{"login":"NickDraper","id":1017173,"node_id":"MDQ6VXNlcjEwMTcxNzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1017173?v=4","gravatar_id":"","url":"https://api.github.com/users/NickDraper","html_url":"https://github.com/NickDraper","followers_url":"https://api.github.com/users/NickDraper/followers","following_url":"https://api.github.com/users/NickDraper/following{/other_user}","gists_url":"https://api.github.com/users/NickDraper/gists{/gist_id}","starred_url":"https://api.github.com/users/NickDraper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickDraper/subscriptions","organizations_url":"https://api.github.com/users/NickDraper/orgs","repos_url":"https://api.github.com/users/NickDraper/repos","events_url":"https://api.github.com/users/NickDraper/events{/privacy}","received_events_url":"https://api.github.com/users/NickDraper/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":231191054,"node_id":"MDU6TGFiZWwyMzExOTEwNTQ=","url":"https://api.github.com/repos/mantidproject/mantid/labels/State:%20Review%20Required","name":"State: Review Required","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mantidproject/mantid/pulls/23186/commits","review_comments_url":"https://api.github.com/repos/mantidproject/mantid/pulls/23186/comments","review_comment_url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/23186/comments","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/bd2fa016e5214a1243a364528fff1ebf6c5e0162","head":{"label":"mantidproject:23089_fitting_constraint_values_do_not_work","ref":"23089_fitting_constraint_values_do_not_work","sha":"bd2fa016e5214a1243a364528fff1ebf6c5e0162","user":{"login":"mantidproject","id":671496,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3MTQ5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"node_id":"MDEwOlJlcG9zaXRvcnkyNTk0MTE2","name":"mantid","full_name":"mantidproject/mantid","owner":{"login":"mantidproject","id":671496,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3MTQ5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mantid/deployments","created_at":"2011-10-17T19:07:38Z","updated_at":"2018-08-21T14:27:37Z","pushed_at":"2018-08-21T14:59:33Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"git@github.com:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":499192,"stargazers_count":76,"watchers_count":76,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"archived":false,"open_issues_count":1841,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":56,"open_issues":1841,"watchers":76,"default_branch":"master"}},"base":{"label":"mantidproject:master","ref":"master","sha":"28355eb3d4dd88151fa87f32daafd96c9fcaab99","user":{"login":"mantidproject","id":671496,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3MTQ5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"node_id":"MDEwOlJlcG9zaXRvcnkyNTk0MTE2","name":"mantid","full_name":"mantidproject/mantid","owner":{"login":"mantidproject","id":671496,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3MTQ5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mantid/deployments","created_at":"2011-10-17T19:07:38Z","updated_at":"2018-08-21T14:27:37Z","pushed_at":"2018-08-21T14:59:33Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"git@github.com:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":499192,"stargazers_count":76,"watchers_count":76,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"archived":false,"open_issues_count":1841,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":56,"open_issues":1841,"watchers":76,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/23186"},"html":{"href":"https://github.com/mantidproject/mantid/pull/23186"},"issue":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/23186"},"comments":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/23186/comments"},"review_comments":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/23186/comments"},"review_comment":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/23186/commits"},"statuses":{"href":"https://api.github.com/repos/mantidproject/mantid/statuses/bd2fa016e5214a1243a364528fff1ebf6c5e0162"}},"author_association":"NONE"}}
{"actor":{"display_login":"brandonhewer"}}