{"action":"created","comment":{"url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/pulls/comments/226206315","pull_request_review_id":165970307,"id":226206315,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjIwNjMxNQ==","diff_hunk":"@@ -98,8 +125,21 @@ sub _hmt_csv {\n     while (my $row = $csv->getline($fh) or not $csv->eof()) {\n         ($row->[23] and $row->[23] eq \"Individual\") or next;\n         my $name = _process_name @{$row}[0 .. 5];\n+        \n         next if $name =~ /^\\s*$/;\n-        push @names, $name;\n+        \n+        my $date_of_birth = $row->[7];\n+        $date_of_birth =~ tr/\\//-/;\n+        \n+        # Some DOBs are invalid (Ex. 0-0-1968)\n+        try {\n+            my $dob_epoch = Date::Utility->new($date_of_birth)->epoch;\n+            push @{$hmt_ref->{$name}->{dob_epoch}}, $dob_epoch;\n+            \n+        } catch {\n+            # Even if a client has an invalid date of birth, they should still have an empty array\n+            $hmt_ref->{$name}->{dob_epoch} = [];","path":"lib/Data/Validate/Sanctions/Fetcher.pm","position":76,"original_position":76,"commit_id":"86d7e4a0f9f7504d0ec9a8f3106dd3d4d6edcad2","original_commit_id":"86d7e4a0f9f7504d0ec9a8f3106dd3d4d6edcad2","user":{"login":"chylli","id":22702,"node_id":"MDQ6VXNlcjIyNzAy","avatar_url":"https://avatars3.githubusercontent.com/u/22702?v=4","gravatar_id":"","url":"https://api.github.com/users/chylli","html_url":"https://github.com/chylli","followers_url":"https://api.github.com/users/chylli/followers","following_url":"https://api.github.com/users/chylli/following{/other_user}","gists_url":"https://api.github.com/users/chylli/gists{/gist_id}","starred_url":"https://api.github.com/users/chylli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chylli/subscriptions","organizations_url":"https://api.github.com/users/chylli/orgs","repos_url":"https://api.github.com/users/chylli/repos","events_url":"https://api.github.com/users/chylli/events{/privacy}","received_events_url":"https://api.github.com/users/chylli/received_events","type":"User","site_admin":false},"body":"why not move this line before `try` ?","created_at":"2018-10-18T08:10:11Z","updated_at":"2018-10-18T08:10:11Z","html_url":"https://github.com/binary-com/perl-Data-Validate-Sanctions/pull/23#discussion_r226206315","pull_request_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/pulls/23","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/pulls/comments/226206315"},"html":{"href":"https://github.com/binary-com/perl-Data-Validate-Sanctions/pull/23#discussion_r226206315"},"pull_request":{"href":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/pulls/23","id":222769717,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNzY5NzE3","html_url":"https://github.com/binary-com/perl-Data-Validate-Sanctions/pull/23","diff_url":"https://github.com/binary-com/perl-Data-Validate-Sanctions/pull/23.diff","patch_url":"https://github.com/binary-com/perl-Data-Validate-Sanctions/pull/23.patch","issue_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/issues/23","number":23,"state":"open","locked":false,"title":"tazeek/include_dob_sanction_list","user":{"login":"tazeek","id":8674460,"node_id":"MDQ6VXNlcjg2NzQ0NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/8674460?v=4","gravatar_id":"","url":"https://api.github.com/users/tazeek","html_url":"https://github.com/tazeek","followers_url":"https://api.github.com/users/tazeek/followers","following_url":"https://api.github.com/users/tazeek/following{/other_user}","gists_url":"https://api.github.com/users/tazeek/gists{/gist_id}","starred_url":"https://api.github.com/users/tazeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tazeek/subscriptions","organizations_url":"https://api.github.com/users/tazeek/orgs","repos_url":"https://api.github.com/users/tazeek/repos","events_url":"https://api.github.com/users/tazeek/events{/privacy}","received_events_url":"https://api.github.com/users/tazeek/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-15T03:13:43Z","updated_at":"2018-10-18T08:10:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e612c4748ca3d1a615950cb5dbaf9ea9c7c93c21","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/pulls/23/commits","review_comments_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/pulls/23/comments","review_comment_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/issues/23/comments","statuses_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/statuses/86d7e4a0f9f7504d0ec9a8f3106dd3d4d6edcad2","head":{"label":"tazeek:tazeek/include_dob_sanction_list","ref":"tazeek/include_dob_sanction_list","sha":"86d7e4a0f9f7504d0ec9a8f3106dd3d4d6edcad2","user":{"login":"tazeek","id":8674460,"node_id":"MDQ6VXNlcjg2NzQ0NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/8674460?v=4","gravatar_id":"","url":"https://api.github.com/users/tazeek","html_url":"https://github.com/tazeek","followers_url":"https://api.github.com/users/tazeek/followers","following_url":"https://api.github.com/users/tazeek/following{/other_user}","gists_url":"https://api.github.com/users/tazeek/gists{/gist_id}","starred_url":"https://api.github.com/users/tazeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tazeek/subscriptions","organizations_url":"https://api.github.com/users/tazeek/orgs","repos_url":"https://api.github.com/users/tazeek/repos","events_url":"https://api.github.com/users/tazeek/events{/privacy}","received_events_url":"https://api.github.com/users/tazeek/received_events","type":"User","site_admin":false},"repo":{"id":113007684,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMwMDc2ODQ=","name":"perl-Data-Validate-Sanctions","full_name":"tazeek/perl-Data-Validate-Sanctions","private":false,"owner":{"login":"tazeek","id":8674460,"node_id":"MDQ6VXNlcjg2NzQ0NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/8674460?v=4","gravatar_id":"","url":"https://api.github.com/users/tazeek","html_url":"https://github.com/tazeek","followers_url":"https://api.github.com/users/tazeek/followers","following_url":"https://api.github.com/users/tazeek/following{/other_user}","gists_url":"https://api.github.com/users/tazeek/gists{/gist_id}","starred_url":"https://api.github.com/users/tazeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tazeek/subscriptions","organizations_url":"https://api.github.com/users/tazeek/orgs","repos_url":"https://api.github.com/users/tazeek/repos","events_url":"https://api.github.com/users/tazeek/events{/privacy}","received_events_url":"https://api.github.com/users/tazeek/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tazeek/perl-Data-Validate-Sanctions","description":"Validate a name against sanctions lists","fork":true,"url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions","forks_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/forks","keys_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/teams","hooks_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/hooks","issue_events_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/issues/events{/number}","events_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/events","assignees_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/assignees{/user}","branches_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/branches{/branch}","tags_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/tags","blobs_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/git/refs{/sha}","trees_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/statuses/{sha}","languages_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/languages","stargazers_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/stargazers","contributors_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/contributors","subscribers_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/subscribers","subscription_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/subscription","commits_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/commits{/sha}","git_commits_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/git/commits{/sha}","comments_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/comments{/number}","issue_comment_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/issues/comments{/number}","contents_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/contents/{+path}","compare_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/merges","archive_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/downloads","issues_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/issues{/number}","pulls_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/pulls{/number}","milestones_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/milestones{/number}","notifications_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/labels{/name}","releases_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/releases{/id}","deployments_url":"https://api.github.com/repos/tazeek/perl-Data-Validate-Sanctions/deployments","created_at":"2017-12-04T07:06:44Z","updated_at":"2017-12-04T07:06:45Z","pushed_at":"2018-10-18T07:53:58Z","git_url":"git://github.com/tazeek/perl-Data-Validate-Sanctions.git","ssh_url":"git@github.com:tazeek/perl-Data-Validate-Sanctions.git","clone_url":"https://github.com/tazeek/perl-Data-Validate-Sanctions.git","svn_url":"https://github.com/tazeek/perl-Data-Validate-Sanctions","homepage":"","size":702,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"binary-com:master","ref":"master","sha":"10158535287f7e3361d829811552a9de564f4c49","user":{"login":"binary-com","id":7437559,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0Mzc1NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/7437559?v=4","gravatar_id":"","url":"https://api.github.com/users/binary-com","html_url":"https://github.com/binary-com","followers_url":"https://api.github.com/users/binary-com/followers","following_url":"https://api.github.com/users/binary-com/following{/other_user}","gists_url":"https://api.github.com/users/binary-com/gists{/gist_id}","starred_url":"https://api.github.com/users/binary-com/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binary-com/subscriptions","organizations_url":"https://api.github.com/users/binary-com/orgs","repos_url":"https://api.github.com/users/binary-com/repos","events_url":"https://api.github.com/users/binary-com/events{/privacy}","received_events_url":"https://api.github.com/users/binary-com/received_events","type":"Organization","site_admin":false},"repo":{"id":24488200,"node_id":"MDEwOlJlcG9zaXRvcnkyNDQ4ODIwMA==","name":"perl-Data-Validate-Sanctions","full_name":"binary-com/perl-Data-Validate-Sanctions","private":false,"owner":{"login":"binary-com","id":7437559,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0Mzc1NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/7437559?v=4","gravatar_id":"","url":"https://api.github.com/users/binary-com","html_url":"https://github.com/binary-com","followers_url":"https://api.github.com/users/binary-com/followers","following_url":"https://api.github.com/users/binary-com/following{/other_user}","gists_url":"https://api.github.com/users/binary-com/gists{/gist_id}","starred_url":"https://api.github.com/users/binary-com/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binary-com/subscriptions","organizations_url":"https://api.github.com/users/binary-com/orgs","repos_url":"https://api.github.com/users/binary-com/repos","events_url":"https://api.github.com/users/binary-com/events{/privacy}","received_events_url":"https://api.github.com/users/binary-com/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/binary-com/perl-Data-Validate-Sanctions","description":"Validate a name against sanctions lists","fork":false,"url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions","forks_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/forks","keys_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/teams","hooks_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/hooks","issue_events_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/issues/events{/number}","events_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/events","assignees_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/assignees{/user}","branches_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/branches{/branch}","tags_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/tags","blobs_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/git/refs{/sha}","trees_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/statuses/{sha}","languages_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/languages","stargazers_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/stargazers","contributors_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/contributors","subscribers_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/subscribers","subscription_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/subscription","commits_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/commits{/sha}","git_commits_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/git/commits{/sha}","comments_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/comments{/number}","issue_comment_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/issues/comments{/number}","contents_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/contents/{+path}","compare_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/merges","archive_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/downloads","issues_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/issues{/number}","pulls_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/pulls{/number}","milestones_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/milestones{/number}","notifications_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/labels{/name}","releases_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/releases{/id}","deployments_url":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/deployments","created_at":"2014-09-26T06:02:38Z","updated_at":"2018-07-12T02:54:56Z","pushed_at":"2018-10-18T07:53:59Z","git_url":"git://github.com/binary-com/perl-Data-Validate-Sanctions.git","ssh_url":"git@github.com:binary-com/perl-Data-Validate-Sanctions.git","clone_url":"https://github.com/binary-com/perl-Data-Validate-Sanctions.git","svn_url":"https://github.com/binary-com/perl-Data-Validate-Sanctions","homepage":"","size":562,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":9,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/pulls/23"},"html":{"href":"https://github.com/binary-com/perl-Data-Validate-Sanctions/pull/23"},"issue":{"href":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/issues/23"},"comments":{"href":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/binary-com/perl-Data-Validate-Sanctions/statuses/86d7e4a0f9f7504d0ec9a8f3106dd3d4d6edcad2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"chylli"}}