{"action":"created","comment":{"url":"https://api.github.com/repos/projectatomic/libpod/pulls/comments/188737240","pull_request_review_id":120776455,"id":188737240,"diff_hunk":"@@ -115,6 +120,38 @@ func (s *BoltState) Refresh() error {\n \t\terr = idBucket.ForEach(func(id, name []byte) error {\n \t\t\tctrBkt := ctrsBucket.Bucket(id)\n \t\t\tif ctrBkt == nil {\n+\t\t\t\t// It's a pod\n+\t\t\t\tpodBkt := podsBucket.Bucket(id)\n+\t\t\t\tif podBkt == nil {\n+\t\t\t\t\t// This is neither a pod nor a container\n+\t\t\t\t\t// Error out on the dangling ID\n+\t\t\t\t\treturn errors.Wrapf(ErrInternal, \"id %s is not a pod or a container\", string(id))\n+\t\t\t\t}\n+\n+\t\t\t\t// Get the state\n+\t\t\t\tstateBytes := podBkt.Get(stateKey)\n+\t\t\t\tif stateBytes == nil {\n+\t\t\t\t\treturn errors.Wrapf(ErrInternal, \"pod %s missing state key\", string(id))\n+\t\t\t\t}\n+\n+\t\t\t\tstate := new(podState)\n+\n+\t\t\t\tif err := json.Unmarshal(stateBytes, state); err != nil {\n+\t\t\t\t\treturn errors.Wrapf(err, \"error unmarshalling state for pod %s\", string(id))\n+\t\t\t\t}\n+\n+\t\t\t\t// Clear the CGroup path\n+\t\t\t\tstate.CgroupPath = \"\"","path":"libpod/boltdb_state.go","position":37,"original_position":37,"commit_id":"d1c5646f530369eb13945ba59a9bcaedf8446083","original_commit_id":"3ffc8f75a3549828f63ae3af6dfbd628d2f659f6","user":{"login":"mheon","id":7735048,"avatar_url":"https://avatars3.githubusercontent.com/u/7735048?v=4","gravatar_id":"","url":"https://api.github.com/users/mheon","html_url":"https://github.com/mheon","followers_url":"https://api.github.com/users/mheon/followers","following_url":"https://api.github.com/users/mheon/following{/other_user}","gists_url":"https://api.github.com/users/mheon/gists{/gist_id}","starred_url":"https://api.github.com/users/mheon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mheon/subscriptions","organizations_url":"https://api.github.com/users/mheon/orgs","repos_url":"https://api.github.com/users/mheon/repos","events_url":"https://api.github.com/users/mheon/events{/privacy}","received_events_url":"https://api.github.com/users/mheon/received_events","type":"User","site_admin":false},"body":"With cgroupfs, this ends up being mostly a no-op, as we don't need to create the pod cgroup ourself, the first container to launch will make it for it. It will matter more with systemd cgroups, though.","created_at":"2018-05-16T18:59:44Z","updated_at":"2018-05-16T18:59:44Z","html_url":"https://github.com/projectatomic/libpod/pull/784#discussion_r188737240","pull_request_url":"https://api.github.com/repos/projectatomic/libpod/pulls/784","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/projectatomic/libpod/pulls/comments/188737240"},"html":{"href":"https://github.com/projectatomic/libpod/pull/784#discussion_r188737240"},"pull_request":{"href":"https://api.github.com/repos/projectatomic/libpod/pulls/784"}},"in_reply_to_id":188731859},"pull_request":{"url":"https://api.github.com/repos/projectatomic/libpod/pulls/784","id":188495405,"html_url":"https://github.com/projectatomic/libpod/pull/784","diff_url":"https://github.com/projectatomic/libpod/pull/784.diff","patch_url":"https://github.com/projectatomic/libpod/pull/784.patch","issue_url":"https://api.github.com/repos/projectatomic/libpod/issues/784","number":784,"state":"open","locked":false,"title":"Add pod CGroups","user":{"login":"mheon","id":7735048,"avatar_url":"https://avatars3.githubusercontent.com/u/7735048?v=4","gravatar_id":"","url":"https://api.github.com/users/mheon","html_url":"https://github.com/mheon","followers_url":"https://api.github.com/users/mheon/followers","following_url":"https://api.github.com/users/mheon/following{/other_user}","gists_url":"https://api.github.com/users/mheon/gists{/gist_id}","starred_url":"https://api.github.com/users/mheon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mheon/subscriptions","organizations_url":"https://api.github.com/users/mheon/orgs","repos_url":"https://api.github.com/users/mheon/repos","events_url":"https://api.github.com/users/mheon/events{/privacy}","received_events_url":"https://api.github.com/users/mheon/received_events","type":"User","site_admin":false},"body":"Add the ability for pods to have their own CGroups that containers can use as their CGroup parent.\r\n\r\nPresently only works with cgroupfs, systemd cgroups are coming in a later patch.","created_at":"2018-05-16T16:46:42Z","updated_at":"2018-05-16T18:59:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50d9f09f929afddd8656f53f89159cf3fc72c8dd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/projectatomic/libpod/pulls/784/commits","review_comments_url":"https://api.github.com/repos/projectatomic/libpod/pulls/784/comments","review_comment_url":"https://api.github.com/repos/projectatomic/libpod/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectatomic/libpod/issues/784/comments","statuses_url":"https://api.github.com/repos/projectatomic/libpod/statuses/d1c5646f530369eb13945ba59a9bcaedf8446083","head":{"label":"mheon:pod_cgroups","ref":"pod_cgroups","sha":"d1c5646f530369eb13945ba59a9bcaedf8446083","user":{"login":"mheon","id":7735048,"avatar_url":"https://avatars3.githubusercontent.com/u/7735048?v=4","gravatar_id":"","url":"https://api.github.com/users/mheon","html_url":"https://github.com/mheon","followers_url":"https://api.github.com/users/mheon/followers","following_url":"https://api.github.com/users/mheon/following{/other_user}","gists_url":"https://api.github.com/users/mheon/gists{/gist_id}","starred_url":"https://api.github.com/users/mheon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mheon/subscriptions","organizations_url":"https://api.github.com/users/mheon/orgs","repos_url":"https://api.github.com/users/mheon/repos","events_url":"https://api.github.com/users/mheon/events{/privacy}","received_events_url":"https://api.github.com/users/mheon/received_events","type":"User","site_admin":false},"repo":{"id":109146470,"name":"libpod","full_name":"mheon/libpod","owner":{"login":"mheon","id":7735048,"avatar_url":"https://avatars3.githubusercontent.com/u/7735048?v=4","gravatar_id":"","url":"https://api.github.com/users/mheon","html_url":"https://github.com/mheon","followers_url":"https://api.github.com/users/mheon/followers","following_url":"https://api.github.com/users/mheon/following{/other_user}","gists_url":"https://api.github.com/users/mheon/gists{/gist_id}","starred_url":"https://api.github.com/users/mheon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mheon/subscriptions","organizations_url":"https://api.github.com/users/mheon/orgs","repos_url":"https://api.github.com/users/mheon/repos","events_url":"https://api.github.com/users/mheon/events{/privacy}","received_events_url":"https://api.github.com/users/mheon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mheon/libpod","description":"libpod is a library used to create container pods.","fork":true,"url":"https://api.github.com/repos/mheon/libpod","forks_url":"https://api.github.com/repos/mheon/libpod/forks","keys_url":"https://api.github.com/repos/mheon/libpod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mheon/libpod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mheon/libpod/teams","hooks_url":"https://api.github.com/repos/mheon/libpod/hooks","issue_events_url":"https://api.github.com/repos/mheon/libpod/issues/events{/number}","events_url":"https://api.github.com/repos/mheon/libpod/events","assignees_url":"https://api.github.com/repos/mheon/libpod/assignees{/user}","branches_url":"https://api.github.com/repos/mheon/libpod/branches{/branch}","tags_url":"https://api.github.com/repos/mheon/libpod/tags","blobs_url":"https://api.github.com/repos/mheon/libpod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mheon/libpod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mheon/libpod/git/refs{/sha}","trees_url":"https://api.github.com/repos/mheon/libpod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mheon/libpod/statuses/{sha}","languages_url":"https://api.github.com/repos/mheon/libpod/languages","stargazers_url":"https://api.github.com/repos/mheon/libpod/stargazers","contributors_url":"https://api.github.com/repos/mheon/libpod/contributors","subscribers_url":"https://api.github.com/repos/mheon/libpod/subscribers","subscription_url":"https://api.github.com/repos/mheon/libpod/subscription","commits_url":"https://api.github.com/repos/mheon/libpod/commits{/sha}","git_commits_url":"https://api.github.com/repos/mheon/libpod/git/commits{/sha}","comments_url":"https://api.github.com/repos/mheon/libpod/comments{/number}","issue_comment_url":"https://api.github.com/repos/mheon/libpod/issues/comments{/number}","contents_url":"https://api.github.com/repos/mheon/libpod/contents/{+path}","compare_url":"https://api.github.com/repos/mheon/libpod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mheon/libpod/merges","archive_url":"https://api.github.com/repos/mheon/libpod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mheon/libpod/downloads","issues_url":"https://api.github.com/repos/mheon/libpod/issues{/number}","pulls_url":"https://api.github.com/repos/mheon/libpod/pulls{/number}","milestones_url":"https://api.github.com/repos/mheon/libpod/milestones{/number}","notifications_url":"https://api.github.com/repos/mheon/libpod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mheon/libpod/labels{/name}","releases_url":"https://api.github.com/repos/mheon/libpod/releases{/id}","deployments_url":"https://api.github.com/repos/mheon/libpod/deployments","created_at":"2017-11-01T15:08:55Z","updated_at":"2018-05-04T15:37:40Z","pushed_at":"2018-05-16T18:58:20Z","git_url":"git://github.com/mheon/libpod.git","ssh_url":"git@github.com:mheon/libpod.git","clone_url":"https://github.com/mheon/libpod.git","svn_url":"https://github.com/mheon/libpod","homepage":null,"size":12549,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectatomic:master","ref":"master","sha":"5b2627dd7738cd92a356ca30c5a47be7a6abaf29","user":{"login":"projectatomic","id":6852258,"avatar_url":"https://avatars1.githubusercontent.com/u/6852258?v=4","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"repo":{"id":109145553,"name":"libpod","full_name":"projectatomic/libpod","owner":{"login":"projectatomic","id":6852258,"avatar_url":"https://avatars1.githubusercontent.com/u/6852258?v=4","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectatomic/libpod","description":"libpod is a library used to create container pods.","fork":false,"url":"https://api.github.com/repos/projectatomic/libpod","forks_url":"https://api.github.com/repos/projectatomic/libpod/forks","keys_url":"https://api.github.com/repos/projectatomic/libpod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectatomic/libpod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectatomic/libpod/teams","hooks_url":"https://api.github.com/repos/projectatomic/libpod/hooks","issue_events_url":"https://api.github.com/repos/projectatomic/libpod/issues/events{/number}","events_url":"https://api.github.com/repos/projectatomic/libpod/events","assignees_url":"https://api.github.com/repos/projectatomic/libpod/assignees{/user}","branches_url":"https://api.github.com/repos/projectatomic/libpod/branches{/branch}","tags_url":"https://api.github.com/repos/projectatomic/libpod/tags","blobs_url":"https://api.github.com/repos/projectatomic/libpod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectatomic/libpod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectatomic/libpod/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectatomic/libpod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectatomic/libpod/statuses/{sha}","languages_url":"https://api.github.com/repos/projectatomic/libpod/languages","stargazers_url":"https://api.github.com/repos/projectatomic/libpod/stargazers","contributors_url":"https://api.github.com/repos/projectatomic/libpod/contributors","subscribers_url":"https://api.github.com/repos/projectatomic/libpod/subscribers","subscription_url":"https://api.github.com/repos/projectatomic/libpod/subscription","commits_url":"https://api.github.com/repos/projectatomic/libpod/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectatomic/libpod/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectatomic/libpod/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectatomic/libpod/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectatomic/libpod/contents/{+path}","compare_url":"https://api.github.com/repos/projectatomic/libpod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectatomic/libpod/merges","archive_url":"https://api.github.com/repos/projectatomic/libpod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectatomic/libpod/downloads","issues_url":"https://api.github.com/repos/projectatomic/libpod/issues{/number}","pulls_url":"https://api.github.com/repos/projectatomic/libpod/pulls{/number}","milestones_url":"https://api.github.com/repos/projectatomic/libpod/milestones{/number}","notifications_url":"https://api.github.com/repos/projectatomic/libpod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectatomic/libpod/labels{/name}","releases_url":"https://api.github.com/repos/projectatomic/libpod/releases{/id}","deployments_url":"https://api.github.com/repos/projectatomic/libpod/deployments","created_at":"2017-11-01T15:01:27Z","updated_at":"2018-05-16T18:41:31Z","pushed_at":"2018-05-16T18:58:22Z","git_url":"git://github.com/projectatomic/libpod.git","ssh_url":"git@github.com:projectatomic/libpod.git","clone_url":"https://github.com/projectatomic/libpod.git","svn_url":"https://github.com/projectatomic/libpod","homepage":null,"size":12535,"stargazers_count":126,"watchers_count":126,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":47,"open_issues":56,"watchers":126,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectatomic/libpod/pulls/784"},"html":{"href":"https://github.com/projectatomic/libpod/pull/784"},"issue":{"href":"https://api.github.com/repos/projectatomic/libpod/issues/784"},"comments":{"href":"https://api.github.com/repos/projectatomic/libpod/issues/784/comments"},"review_comments":{"href":"https://api.github.com/repos/projectatomic/libpod/pulls/784/comments"},"review_comment":{"href":"https://api.github.com/repos/projectatomic/libpod/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectatomic/libpod/pulls/784/commits"},"statuses":{"href":"https://api.github.com/repos/projectatomic/libpod/statuses/d1c5646f530369eb13945ba59a9bcaedf8446083"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mheon"}}