{"action":"created","comment":{"url":"https://api.github.com/repos/graknlabs/grakn/pulls/comments/165328442","pull_request_review_id":93247404,"id":165328442,"diff_hunk":"@@ -360,17 +360,6 @@ public GetQuery getQuery() {\n         return varTypeMap;\n     }\n \n-    @Override\n-    public ImmutableMap<Var, Type> getVarTypeMap(Answer sub) {\n-        return ImmutableMap.copyOf(getVarTypeMap(\n-                Stream.concat(\n-                        getAtoms(IsaAtom.class),\n-                        inferEntityTypes()\n-                )\n-                )\n-        );\n-    }\n-","path":"grakn-graql/src/main/java/ai/grakn/graql/internal/reasoner/query/ReasonerQueryImpl.java","position":14,"original_position":14,"commit_id":"91ee08700c760fd9afb1c5e4fcb7e0b256b2c5b0","original_commit_id":"91ee08700c760fd9afb1c5e4fcb7e0b256b2c5b0","user":{"login":"kasper-piskorski","id":10519067,"avatar_url":"https://avatars2.githubusercontent.com/u/10519067?v=4","gravatar_id":"","url":"https://api.github.com/users/kasper-piskorski","html_url":"https://github.com/kasper-piskorski","followers_url":"https://api.github.com/users/kasper-piskorski/followers","following_url":"https://api.github.com/users/kasper-piskorski/following{/other_user}","gists_url":"https://api.github.com/users/kasper-piskorski/gists{/gist_id}","starred_url":"https://api.github.com/users/kasper-piskorski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kasper-piskorski/subscriptions","organizations_url":"https://api.github.com/users/kasper-piskorski/orgs","repos_url":"https://api.github.com/users/kasper-piskorski/repos","events_url":"https://api.github.com/users/kasper-piskorski/events{/privacy}","received_events_url":"https://api.github.com/users/kasper-piskorski/received_events","type":"User","site_admin":false},"body":"ok it probably should be `inferEntityTypes(sub)` here so that the sub is actually used in all the infer* methods","created_at":"2018-02-01T11:22:51Z","updated_at":"2018-02-01T11:32:52Z","html_url":"https://github.com/graknlabs/grakn/pull/2610#discussion_r165328442","pull_request_url":"https://api.github.com/repos/graknlabs/grakn/pulls/2610","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/graknlabs/grakn/pulls/comments/165328442"},"html":{"href":"https://github.com/graknlabs/grakn/pull/2610#discussion_r165328442"},"pull_request":{"href":"https://api.github.com/repos/graknlabs/grakn/pulls/2610"}}},"pull_request":{"url":"https://api.github.com/repos/graknlabs/grakn/pulls/2610","id":166314076,"html_url":"https://github.com/graknlabs/grakn/pull/2610","diff_url":"https://github.com/graknlabs/grakn/pull/2610.diff","patch_url":"https://github.com/graknlabs/grakn/pull/2610.patch","issue_url":"https://api.github.com/repos/graknlabs/grakn/issues/2610","number":2610,"state":"open","locked":false,"title":"Remove dead and unused code","user":{"login":"fppt","id":4279814,"avatar_url":"https://avatars0.githubusercontent.com/u/4279814?v=4","gravatar_id":"","url":"https://api.github.com/users/fppt","html_url":"https://github.com/fppt","followers_url":"https://api.github.com/users/fppt/followers","following_url":"https://api.github.com/users/fppt/following{/other_user}","gists_url":"https://api.github.com/users/fppt/gists{/gist_id}","starred_url":"https://api.github.com/users/fppt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fppt/subscriptions","organizations_url":"https://api.github.com/users/fppt/orgs","repos_url":"https://api.github.com/users/fppt/repos","events_url":"https://api.github.com/users/fppt/events{/privacy}","received_events_url":"https://api.github.com/users/fppt/received_events","type":"User","site_admin":false},"body":"# Why is this PR needed?\r\n\r\nIt is needed as routine maintenance so we can keep our code base clean and easier to work with.\r\n\r\n# What does the PR do?\r\n\r\nRemoves Methods which are unused.\r\nAnnotates some methods which are part of the public API.\r\nAnnotates some methods which are used indirectly, for example the OLAP constructors\r\n\r\n# Does it break backwards compatibility?\r\n\r\nNope. Everything being removed should not be in use.\r\n\r\n# List of future improvements not on this PR\r\n\r\nAutomatically pickup dead code and break the build because of it but I have not figured out how to achieve this.\r\n\r\n# Note:\r\n\r\nBecause I had to go through a lot of unfamiliar code I ended up tagging comments for different people to address. I would appreciate it if you guys could help me address these unknowns. \r\n","created_at":"2018-01-31T16:44:08Z","updated_at":"2018-02-01T11:32:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"241a7bcade704f456b3276211fc6bd38247bbe9c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/graknlabs/grakn/pulls/2610/commits","review_comments_url":"https://api.github.com/repos/graknlabs/grakn/pulls/2610/comments","review_comment_url":"https://api.github.com/repos/graknlabs/grakn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/graknlabs/grakn/issues/2610/comments","statuses_url":"https://api.github.com/repos/graknlabs/grakn/statuses/91ee08700c760fd9afb1c5e4fcb7e0b256b2c5b0","head":{"label":"fppt:kill-more-dead-code","ref":"kill-more-dead-code","sha":"91ee08700c760fd9afb1c5e4fcb7e0b256b2c5b0","user":{"login":"fppt","id":4279814,"avatar_url":"https://avatars0.githubusercontent.com/u/4279814?v=4","gravatar_id":"","url":"https://api.github.com/users/fppt","html_url":"https://github.com/fppt","followers_url":"https://api.github.com/users/fppt/followers","following_url":"https://api.github.com/users/fppt/following{/other_user}","gists_url":"https://api.github.com/users/fppt/gists{/gist_id}","starred_url":"https://api.github.com/users/fppt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fppt/subscriptions","organizations_url":"https://api.github.com/users/fppt/orgs","repos_url":"https://api.github.com/users/fppt/repos","events_url":"https://api.github.com/users/fppt/events{/privacy}","received_events_url":"https://api.github.com/users/fppt/received_events","type":"User","site_admin":false},"repo":{"id":65722027,"name":"grakn","full_name":"fppt/grakn","owner":{"login":"fppt","id":4279814,"avatar_url":"https://avatars0.githubusercontent.com/u/4279814?v=4","gravatar_id":"","url":"https://api.github.com/users/fppt","html_url":"https://github.com/fppt","followers_url":"https://api.github.com/users/fppt/followers","following_url":"https://api.github.com/users/fppt/following{/other_user}","gists_url":"https://api.github.com/users/fppt/gists{/gist_id}","starred_url":"https://api.github.com/users/fppt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fppt/subscriptions","organizations_url":"https://api.github.com/users/fppt/orgs","repos_url":"https://api.github.com/users/fppt/repos","events_url":"https://api.github.com/users/fppt/events{/privacy}","received_events_url":"https://api.github.com/users/fppt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fppt/grakn","description":"A Knowledge Graph Platform","fork":true,"url":"https://api.github.com/repos/fppt/grakn","forks_url":"https://api.github.com/repos/fppt/grakn/forks","keys_url":"https://api.github.com/repos/fppt/grakn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fppt/grakn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fppt/grakn/teams","hooks_url":"https://api.github.com/repos/fppt/grakn/hooks","issue_events_url":"https://api.github.com/repos/fppt/grakn/issues/events{/number}","events_url":"https://api.github.com/repos/fppt/grakn/events","assignees_url":"https://api.github.com/repos/fppt/grakn/assignees{/user}","branches_url":"https://api.github.com/repos/fppt/grakn/branches{/branch}","tags_url":"https://api.github.com/repos/fppt/grakn/tags","blobs_url":"https://api.github.com/repos/fppt/grakn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fppt/grakn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fppt/grakn/git/refs{/sha}","trees_url":"https://api.github.com/repos/fppt/grakn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fppt/grakn/statuses/{sha}","languages_url":"https://api.github.com/repos/fppt/grakn/languages","stargazers_url":"https://api.github.com/repos/fppt/grakn/stargazers","contributors_url":"https://api.github.com/repos/fppt/grakn/contributors","subscribers_url":"https://api.github.com/repos/fppt/grakn/subscribers","subscription_url":"https://api.github.com/repos/fppt/grakn/subscription","commits_url":"https://api.github.com/repos/fppt/grakn/commits{/sha}","git_commits_url":"https://api.github.com/repos/fppt/grakn/git/commits{/sha}","comments_url":"https://api.github.com/repos/fppt/grakn/comments{/number}","issue_comment_url":"https://api.github.com/repos/fppt/grakn/issues/comments{/number}","contents_url":"https://api.github.com/repos/fppt/grakn/contents/{+path}","compare_url":"https://api.github.com/repos/fppt/grakn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fppt/grakn/merges","archive_url":"https://api.github.com/repos/fppt/grakn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fppt/grakn/downloads","issues_url":"https://api.github.com/repos/fppt/grakn/issues{/number}","pulls_url":"https://api.github.com/repos/fppt/grakn/pulls{/number}","milestones_url":"https://api.github.com/repos/fppt/grakn/milestones{/number}","notifications_url":"https://api.github.com/repos/fppt/grakn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fppt/grakn/labels{/name}","releases_url":"https://api.github.com/repos/fppt/grakn/releases{/id}","deployments_url":"https://api.github.com/repos/fppt/grakn/deployments","created_at":"2016-08-15T09:47:35Z","updated_at":"2016-11-30T07:02:41Z","pushed_at":"2018-02-01T09:48:15Z","git_url":"git://github.com/fppt/grakn.git","ssh_url":"git@github.com:fppt/grakn.git","clone_url":"https://github.com/fppt/grakn.git","svn_url":"https://github.com/fppt/grakn","homepage":"https://grakn.ai","size":48864,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"graknlabs:master","ref":"master","sha":"a5f93d695cdcdfebf7db3744933bce1ad47f4ec5","user":{"login":"graknlabs","id":10490615,"avatar_url":"https://avatars1.githubusercontent.com/u/10490615?v=4","gravatar_id":"","url":"https://api.github.com/users/graknlabs","html_url":"https://github.com/graknlabs","followers_url":"https://api.github.com/users/graknlabs/followers","following_url":"https://api.github.com/users/graknlabs/following{/other_user}","gists_url":"https://api.github.com/users/graknlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/graknlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graknlabs/subscriptions","organizations_url":"https://api.github.com/users/graknlabs/orgs","repos_url":"https://api.github.com/users/graknlabs/repos","events_url":"https://api.github.com/users/graknlabs/events{/privacy}","received_events_url":"https://api.github.com/users/graknlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":63110867,"name":"grakn","full_name":"graknlabs/grakn","owner":{"login":"graknlabs","id":10490615,"avatar_url":"https://avatars1.githubusercontent.com/u/10490615?v=4","gravatar_id":"","url":"https://api.github.com/users/graknlabs","html_url":"https://github.com/graknlabs","followers_url":"https://api.github.com/users/graknlabs/followers","following_url":"https://api.github.com/users/graknlabs/following{/other_user}","gists_url":"https://api.github.com/users/graknlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/graknlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graknlabs/subscriptions","organizations_url":"https://api.github.com/users/graknlabs/orgs","repos_url":"https://api.github.com/users/graknlabs/repos","events_url":"https://api.github.com/users/graknlabs/events{/privacy}","received_events_url":"https://api.github.com/users/graknlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/graknlabs/grakn","description":"The Hyper-Relational Database for Knowledge Engineering","fork":false,"url":"https://api.github.com/repos/graknlabs/grakn","forks_url":"https://api.github.com/repos/graknlabs/grakn/forks","keys_url":"https://api.github.com/repos/graknlabs/grakn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graknlabs/grakn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graknlabs/grakn/teams","hooks_url":"https://api.github.com/repos/graknlabs/grakn/hooks","issue_events_url":"https://api.github.com/repos/graknlabs/grakn/issues/events{/number}","events_url":"https://api.github.com/repos/graknlabs/grakn/events","assignees_url":"https://api.github.com/repos/graknlabs/grakn/assignees{/user}","branches_url":"https://api.github.com/repos/graknlabs/grakn/branches{/branch}","tags_url":"https://api.github.com/repos/graknlabs/grakn/tags","blobs_url":"https://api.github.com/repos/graknlabs/grakn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graknlabs/grakn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graknlabs/grakn/git/refs{/sha}","trees_url":"https://api.github.com/repos/graknlabs/grakn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graknlabs/grakn/statuses/{sha}","languages_url":"https://api.github.com/repos/graknlabs/grakn/languages","stargazers_url":"https://api.github.com/repos/graknlabs/grakn/stargazers","contributors_url":"https://api.github.com/repos/graknlabs/grakn/contributors","subscribers_url":"https://api.github.com/repos/graknlabs/grakn/subscribers","subscription_url":"https://api.github.com/repos/graknlabs/grakn/subscription","commits_url":"https://api.github.com/repos/graknlabs/grakn/commits{/sha}","git_commits_url":"https://api.github.com/repos/graknlabs/grakn/git/commits{/sha}","comments_url":"https://api.github.com/repos/graknlabs/grakn/comments{/number}","issue_comment_url":"https://api.github.com/repos/graknlabs/grakn/issues/comments{/number}","contents_url":"https://api.github.com/repos/graknlabs/grakn/contents/{+path}","compare_url":"https://api.github.com/repos/graknlabs/grakn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graknlabs/grakn/merges","archive_url":"https://api.github.com/repos/graknlabs/grakn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graknlabs/grakn/downloads","issues_url":"https://api.github.com/repos/graknlabs/grakn/issues{/number}","pulls_url":"https://api.github.com/repos/graknlabs/grakn/pulls{/number}","milestones_url":"https://api.github.com/repos/graknlabs/grakn/milestones{/number}","notifications_url":"https://api.github.com/repos/graknlabs/grakn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graknlabs/grakn/labels{/name}","releases_url":"https://api.github.com/repos/graknlabs/grakn/releases{/id}","deployments_url":"https://api.github.com/repos/graknlabs/grakn/deployments","created_at":"2016-07-11T23:59:57Z","updated_at":"2018-02-01T09:30:47Z","pushed_at":"2018-02-01T11:24:26Z","git_url":"git://github.com/graknlabs/grakn.git","ssh_url":"git@github.com:graknlabs/grakn.git","clone_url":"https://github.com/graknlabs/grakn.git","svn_url":"https://github.com/graknlabs/grakn","homepage":"https://grakn.ai","size":48306,"stargazers_count":758,"watchers_count":758,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":109,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":109,"open_issues":36,"watchers":758,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/graknlabs/grakn/pulls/2610"},"html":{"href":"https://github.com/graknlabs/grakn/pull/2610"},"issue":{"href":"https://api.github.com/repos/graknlabs/grakn/issues/2610"},"comments":{"href":"https://api.github.com/repos/graknlabs/grakn/issues/2610/comments"},"review_comments":{"href":"https://api.github.com/repos/graknlabs/grakn/pulls/2610/comments"},"review_comment":{"href":"https://api.github.com/repos/graknlabs/grakn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/graknlabs/grakn/pulls/2610/commits"},"statuses":{"href":"https://api.github.com/repos/graknlabs/grakn/statuses/91ee08700c760fd9afb1c5e4fcb7e0b256b2c5b0"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"kasper-piskorski"}}