{"action":"created","comment":{"url":"https://api.github.com/repos/LSchueler/GSTools/pulls/comments/200411418","pull_request_review_id":134721752,"id":200411418,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDQxMTQxOA==","diff_hunk":"@@ -154,22 +171,22 @@ def gau(self, len_scale, mode_no=1000, **kwargs):\n \n         Parameters\n         ----------\n-            len_scale : float\n+            len_scale : :class:`float`\n                 the length scale of the distribution\n-            mode_no : int, optional\n+            mode_no : :class:`int`, optional\n                 number of the Fourier modes\n             **kwargs\n                 not used\n \n         Returns\n         -------\n-            ndarray\n+            :class:`numpy.ndarray`\n                 the modes\n         \"\"\"\n         k = self.create_empty_k(mode_no)\n-        for d in range(self.dim):\n+        for dim_i in range(self.dim):\n             rng = self._get_random_stream()\n-            k[d] = rng.normal(0., 1./len_scale, mode_no)\n+            k[dim_i] = rng.normal(0., 1./len_scale, mode_no)\n         return k","path":"gstools/field/rng.py","position":201,"original_position":201,"commit_id":"7d554de7b9d32d06cd33ed47dd5d0112c6594163","original_commit_id":"7d554de7b9d32d06cd33ed47dd5d0112c6594163","user":{"login":"LSchueler","id":26794562,"node_id":"MDQ6VXNlcjI2Nzk0NTYy","avatar_url":"https://avatars2.githubusercontent.com/u/26794562?v=4","gravatar_id":"","url":"https://api.github.com/users/LSchueler","html_url":"https://github.com/LSchueler","followers_url":"https://api.github.com/users/LSchueler/followers","following_url":"https://api.github.com/users/LSchueler/following{/other_user}","gists_url":"https://api.github.com/users/LSchueler/gists{/gist_id}","starred_url":"https://api.github.com/users/LSchueler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LSchueler/subscriptions","organizations_url":"https://api.github.com/users/LSchueler/orgs","repos_url":"https://api.github.com/users/LSchueler/repos","events_url":"https://api.github.com/users/LSchueler/events{/privacy}","received_events_url":"https://api.github.com/users/LSchueler/received_events","type":"User","site_admin":false},"body":"I think a `d` as a index variable in a short loop is perfectly fine","created_at":"2018-07-05T16:17:19Z","updated_at":"2018-07-05T16:28:28Z","html_url":"https://github.com/LSchueler/GSTools/pull/5#discussion_r200411418","pull_request_url":"https://api.github.com/repos/LSchueler/GSTools/pulls/5","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/LSchueler/GSTools/pulls/comments/200411418"},"html":{"href":"https://github.com/LSchueler/GSTools/pull/5#discussion_r200411418"},"pull_request":{"href":"https://api.github.com/repos/LSchueler/GSTools/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/LSchueler/GSTools/pulls/5","id":198664701,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NjY0NzAx","html_url":"https://github.com/LSchueler/GSTools/pull/5","diff_url":"https://github.com/LSchueler/GSTools/pull/5.diff","patch_url":"https://github.com/LSchueler/GSTools/pull/5.patch","issue_url":"https://api.github.com/repos/LSchueler/GSTools/issues/5","number":5,"state":"open","locked":false,"title":"New documentation and minor changes","user":{"login":"MuellerSeb","id":19690642,"node_id":"MDQ6VXNlcjE5NjkwNjQy","avatar_url":"https://avatars2.githubusercontent.com/u/19690642?v=4","gravatar_id":"","url":"https://api.github.com/users/MuellerSeb","html_url":"https://github.com/MuellerSeb","followers_url":"https://api.github.com/users/MuellerSeb/followers","following_url":"https://api.github.com/users/MuellerSeb/following{/other_user}","gists_url":"https://api.github.com/users/MuellerSeb/gists{/gist_id}","starred_url":"https://api.github.com/users/MuellerSeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MuellerSeb/subscriptions","organizations_url":"https://api.github.com/users/MuellerSeb/orgs","repos_url":"https://api.github.com/users/MuellerSeb/repos","events_url":"https://api.github.com/users/MuellerSeb/events{/privacy}","received_events_url":"https://api.github.com/users/MuellerSeb/received_events","type":"User","site_admin":false},"body":"I have created a new documentation for the whole package and fixed some PEP8 discrepancies.","created_at":"2018-07-02T12:31:34Z","updated_at":"2018-07-05T16:28:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6cfda3140d52e8ed8742ef0bd3cca50ffa8723c9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/LSchueler/GSTools/pulls/5/commits","review_comments_url":"https://api.github.com/repos/LSchueler/GSTools/pulls/5/comments","review_comment_url":"https://api.github.com/repos/LSchueler/GSTools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LSchueler/GSTools/issues/5/comments","statuses_url":"https://api.github.com/repos/LSchueler/GSTools/statuses/7d554de7b9d32d06cd33ed47dd5d0112c6594163","head":{"label":"MuellerSeb:master","ref":"master","sha":"7d554de7b9d32d06cd33ed47dd5d0112c6594163","user":{"login":"MuellerSeb","id":19690642,"node_id":"MDQ6VXNlcjE5NjkwNjQy","avatar_url":"https://avatars2.githubusercontent.com/u/19690642?v=4","gravatar_id":"","url":"https://api.github.com/users/MuellerSeb","html_url":"https://github.com/MuellerSeb","followers_url":"https://api.github.com/users/MuellerSeb/followers","following_url":"https://api.github.com/users/MuellerSeb/following{/other_user}","gists_url":"https://api.github.com/users/MuellerSeb/gists{/gist_id}","starred_url":"https://api.github.com/users/MuellerSeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MuellerSeb/subscriptions","organizations_url":"https://api.github.com/users/MuellerSeb/orgs","repos_url":"https://api.github.com/users/MuellerSeb/repos","events_url":"https://api.github.com/users/MuellerSeb/events{/privacy}","received_events_url":"https://api.github.com/users/MuellerSeb/received_events","type":"User","site_admin":false},"repo":{"id":138025568,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgwMjU1Njg=","name":"GSTools","full_name":"MuellerSeb/GSTools","owner":{"login":"MuellerSeb","id":19690642,"node_id":"MDQ6VXNlcjE5NjkwNjQy","avatar_url":"https://avatars2.githubusercontent.com/u/19690642?v=4","gravatar_id":"","url":"https://api.github.com/users/MuellerSeb","html_url":"https://github.com/MuellerSeb","followers_url":"https://api.github.com/users/MuellerSeb/followers","following_url":"https://api.github.com/users/MuellerSeb/following{/other_user}","gists_url":"https://api.github.com/users/MuellerSeb/gists{/gist_id}","starred_url":"https://api.github.com/users/MuellerSeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MuellerSeb/subscriptions","organizations_url":"https://api.github.com/users/MuellerSeb/orgs","repos_url":"https://api.github.com/users/MuellerSeb/repos","events_url":"https://api.github.com/users/MuellerSeb/events{/privacy}","received_events_url":"https://api.github.com/users/MuellerSeb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MuellerSeb/GSTools","description":"GeoStatTools","fork":true,"url":"https://api.github.com/repos/MuellerSeb/GSTools","forks_url":"https://api.github.com/repos/MuellerSeb/GSTools/forks","keys_url":"https://api.github.com/repos/MuellerSeb/GSTools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MuellerSeb/GSTools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MuellerSeb/GSTools/teams","hooks_url":"https://api.github.com/repos/MuellerSeb/GSTools/hooks","issue_events_url":"https://api.github.com/repos/MuellerSeb/GSTools/issues/events{/number}","events_url":"https://api.github.com/repos/MuellerSeb/GSTools/events","assignees_url":"https://api.github.com/repos/MuellerSeb/GSTools/assignees{/user}","branches_url":"https://api.github.com/repos/MuellerSeb/GSTools/branches{/branch}","tags_url":"https://api.github.com/repos/MuellerSeb/GSTools/tags","blobs_url":"https://api.github.com/repos/MuellerSeb/GSTools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MuellerSeb/GSTools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MuellerSeb/GSTools/git/refs{/sha}","trees_url":"https://api.github.com/repos/MuellerSeb/GSTools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MuellerSeb/GSTools/statuses/{sha}","languages_url":"https://api.github.com/repos/MuellerSeb/GSTools/languages","stargazers_url":"https://api.github.com/repos/MuellerSeb/GSTools/stargazers","contributors_url":"https://api.github.com/repos/MuellerSeb/GSTools/contributors","subscribers_url":"https://api.github.com/repos/MuellerSeb/GSTools/subscribers","subscription_url":"https://api.github.com/repos/MuellerSeb/GSTools/subscription","commits_url":"https://api.github.com/repos/MuellerSeb/GSTools/commits{/sha}","git_commits_url":"https://api.github.com/repos/MuellerSeb/GSTools/git/commits{/sha}","comments_url":"https://api.github.com/repos/MuellerSeb/GSTools/comments{/number}","issue_comment_url":"https://api.github.com/repos/MuellerSeb/GSTools/issues/comments{/number}","contents_url":"https://api.github.com/repos/MuellerSeb/GSTools/contents/{+path}","compare_url":"https://api.github.com/repos/MuellerSeb/GSTools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MuellerSeb/GSTools/merges","archive_url":"https://api.github.com/repos/MuellerSeb/GSTools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MuellerSeb/GSTools/downloads","issues_url":"https://api.github.com/repos/MuellerSeb/GSTools/issues{/number}","pulls_url":"https://api.github.com/repos/MuellerSeb/GSTools/pulls{/number}","milestones_url":"https://api.github.com/repos/MuellerSeb/GSTools/milestones{/number}","notifications_url":"https://api.github.com/repos/MuellerSeb/GSTools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MuellerSeb/GSTools/labels{/name}","releases_url":"https://api.github.com/repos/MuellerSeb/GSTools/releases{/id}","deployments_url":"https://api.github.com/repos/MuellerSeb/GSTools/deployments","created_at":"2018-06-20T11:47:36Z","updated_at":"2018-07-02T12:29:12Z","pushed_at":"2018-07-02T12:29:11Z","git_url":"git://github.com/MuellerSeb/GSTools.git","ssh_url":"git@github.com:MuellerSeb/GSTools.git","clone_url":"https://github.com/MuellerSeb/GSTools.git","svn_url":"https://github.com/MuellerSeb/GSTools","homepage":null,"size":1360,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"LSchueler:master","ref":"master","sha":"c2c559d77b717b2e9c39225d210258c535da709a","user":{"login":"LSchueler","id":26794562,"node_id":"MDQ6VXNlcjI2Nzk0NTYy","avatar_url":"https://avatars2.githubusercontent.com/u/26794562?v=4","gravatar_id":"","url":"https://api.github.com/users/LSchueler","html_url":"https://github.com/LSchueler","followers_url":"https://api.github.com/users/LSchueler/followers","following_url":"https://api.github.com/users/LSchueler/following{/other_user}","gists_url":"https://api.github.com/users/LSchueler/gists{/gist_id}","starred_url":"https://api.github.com/users/LSchueler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LSchueler/subscriptions","organizations_url":"https://api.github.com/users/LSchueler/orgs","repos_url":"https://api.github.com/users/LSchueler/repos","events_url":"https://api.github.com/users/LSchueler/events{/privacy}","received_events_url":"https://api.github.com/users/LSchueler/received_events","type":"User","site_admin":false},"repo":{"id":117534635,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc1MzQ2MzU=","name":"GSTools","full_name":"LSchueler/GSTools","owner":{"login":"LSchueler","id":26794562,"node_id":"MDQ6VXNlcjI2Nzk0NTYy","avatar_url":"https://avatars2.githubusercontent.com/u/26794562?v=4","gravatar_id":"","url":"https://api.github.com/users/LSchueler","html_url":"https://github.com/LSchueler","followers_url":"https://api.github.com/users/LSchueler/followers","following_url":"https://api.github.com/users/LSchueler/following{/other_user}","gists_url":"https://api.github.com/users/LSchueler/gists{/gist_id}","starred_url":"https://api.github.com/users/LSchueler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LSchueler/subscriptions","organizations_url":"https://api.github.com/users/LSchueler/orgs","repos_url":"https://api.github.com/users/LSchueler/repos","events_url":"https://api.github.com/users/LSchueler/events{/privacy}","received_events_url":"https://api.github.com/users/LSchueler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LSchueler/GSTools","description":"GeoStatTools","fork":false,"url":"https://api.github.com/repos/LSchueler/GSTools","forks_url":"https://api.github.com/repos/LSchueler/GSTools/forks","keys_url":"https://api.github.com/repos/LSchueler/GSTools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LSchueler/GSTools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LSchueler/GSTools/teams","hooks_url":"https://api.github.com/repos/LSchueler/GSTools/hooks","issue_events_url":"https://api.github.com/repos/LSchueler/GSTools/issues/events{/number}","events_url":"https://api.github.com/repos/LSchueler/GSTools/events","assignees_url":"https://api.github.com/repos/LSchueler/GSTools/assignees{/user}","branches_url":"https://api.github.com/repos/LSchueler/GSTools/branches{/branch}","tags_url":"https://api.github.com/repos/LSchueler/GSTools/tags","blobs_url":"https://api.github.com/repos/LSchueler/GSTools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LSchueler/GSTools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LSchueler/GSTools/git/refs{/sha}","trees_url":"https://api.github.com/repos/LSchueler/GSTools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LSchueler/GSTools/statuses/{sha}","languages_url":"https://api.github.com/repos/LSchueler/GSTools/languages","stargazers_url":"https://api.github.com/repos/LSchueler/GSTools/stargazers","contributors_url":"https://api.github.com/repos/LSchueler/GSTools/contributors","subscribers_url":"https://api.github.com/repos/LSchueler/GSTools/subscribers","subscription_url":"https://api.github.com/repos/LSchueler/GSTools/subscription","commits_url":"https://api.github.com/repos/LSchueler/GSTools/commits{/sha}","git_commits_url":"https://api.github.com/repos/LSchueler/GSTools/git/commits{/sha}","comments_url":"https://api.github.com/repos/LSchueler/GSTools/comments{/number}","issue_comment_url":"https://api.github.com/repos/LSchueler/GSTools/issues/comments{/number}","contents_url":"https://api.github.com/repos/LSchueler/GSTools/contents/{+path}","compare_url":"https://api.github.com/repos/LSchueler/GSTools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LSchueler/GSTools/merges","archive_url":"https://api.github.com/repos/LSchueler/GSTools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LSchueler/GSTools/downloads","issues_url":"https://api.github.com/repos/LSchueler/GSTools/issues{/number}","pulls_url":"https://api.github.com/repos/LSchueler/GSTools/pulls{/number}","milestones_url":"https://api.github.com/repos/LSchueler/GSTools/milestones{/number}","notifications_url":"https://api.github.com/repos/LSchueler/GSTools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LSchueler/GSTools/labels{/name}","releases_url":"https://api.github.com/repos/LSchueler/GSTools/releases{/id}","deployments_url":"https://api.github.com/repos/LSchueler/GSTools/deployments","created_at":"2018-01-15T11:02:55Z","updated_at":"2018-06-20T13:34:49Z","pushed_at":"2018-07-02T12:31:35Z","git_url":"git://github.com/LSchueler/GSTools.git","ssh_url":"git@github.com:LSchueler/GSTools.git","clone_url":"https://github.com/LSchueler/GSTools.git","svn_url":"https://github.com/LSchueler/GSTools","homepage":null,"size":1346,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1,"open_issues":4,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LSchueler/GSTools/pulls/5"},"html":{"href":"https://github.com/LSchueler/GSTools/pull/5"},"issue":{"href":"https://api.github.com/repos/LSchueler/GSTools/issues/5"},"comments":{"href":"https://api.github.com/repos/LSchueler/GSTools/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/LSchueler/GSTools/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/LSchueler/GSTools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LSchueler/GSTools/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/LSchueler/GSTools/statuses/7d554de7b9d32d06cd33ed47dd5d0112c6594163"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"LSchueler"}}