{"action":"created","comment":{"url":"https://api.github.com/repos/shopsys/shopsys/pulls/comments/209185401","pull_request_review_id":145148146,"id":209185401,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTE4NTQwMQ==","diff_hunk":"@@ -0,0 +1,51 @@\n+# Adding a New Advert Position\n+\n+By default, you can place advert banner on predefined positions:\n+- under the page header\n+- in the left panel (under the category tree)\n+- above the page footer\n+- in a category detail (above the category name)\n+\n+All the positions are defined in `AdvertPositionRegistry` class \n+that provides them for displaying on adverts list in admin\n+as well as for options for selectbox on advert detail administration page.\n+\n+![Advert detail in administration](img/new-advert-screen.png)\n+\n+If you want to add a new custom position, let us say on product detail page, you need to follow these steps:","path":"docs/cookbook/adding-a-new-advert-position.md","position":15,"original_position":15,"commit_id":"fd5209d6a3b4f49bbb314e627f6e68ca3145b6fc","original_commit_id":"fd5209d6a3b4f49bbb314e627f6e68ca3145b6fc","user":{"login":"PetrHeinz","id":10008612,"node_id":"MDQ6VXNlcjEwMDA4NjEy","avatar_url":"https://avatars1.githubusercontent.com/u/10008612?v=4","gravatar_id":"","url":"https://api.github.com/users/PetrHeinz","html_url":"https://github.com/PetrHeinz","followers_url":"https://api.github.com/users/PetrHeinz/followers","following_url":"https://api.github.com/users/PetrHeinz/following{/other_user}","gists_url":"https://api.github.com/users/PetrHeinz/gists{/gist_id}","starred_url":"https://api.github.com/users/PetrHeinz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PetrHeinz/subscriptions","organizations_url":"https://api.github.com/users/PetrHeinz/orgs","repos_url":"https://api.github.com/users/PetrHeinz/repos","events_url":"https://api.github.com/users/PetrHeinz/events{/privacy}","received_events_url":"https://api.github.com/users/PetrHeinz/received_events","type":"User","site_admin":false},"body":"**the** product detail page","created_at":"2018-08-10T08:32:31Z","updated_at":"2018-08-10T08:42:30Z","html_url":"https://github.com/shopsys/shopsys/pull/395#discussion_r209185401","pull_request_url":"https://api.github.com/repos/shopsys/shopsys/pulls/395","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/shopsys/shopsys/pulls/comments/209185401"},"html":{"href":"https://github.com/shopsys/shopsys/pull/395#discussion_r209185401"},"pull_request":{"href":"https://api.github.com/repos/shopsys/shopsys/pulls/395"}}},"pull_request":{"url":"https://api.github.com/repos/shopsys/shopsys/pulls/395","id":207279573,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3Mjc5NTcz","html_url":"https://github.com/shopsys/shopsys/pull/395","diff_url":"https://github.com/shopsys/shopsys/pull/395.diff","patch_url":"https://github.com/shopsys/shopsys/pull/395.patch","issue_url":"https://api.github.com/repos/shopsys/shopsys/issues/395","number":395,"state":"open","locked":false,"title":"ability of adding new advert position from project-base","user":{"login":"vitek-rostislav","id":10401898,"node_id":"MDQ6VXNlcjEwNDAxODk4","avatar_url":"https://avatars1.githubusercontent.com/u/10401898?v=4","gravatar_id":"","url":"https://api.github.com/users/vitek-rostislav","html_url":"https://github.com/vitek-rostislav","followers_url":"https://api.github.com/users/vitek-rostislav/followers","following_url":"https://api.github.com/users/vitek-rostislav/following{/other_user}","gists_url":"https://api.github.com/users/vitek-rostislav/gists{/gist_id}","starred_url":"https://api.github.com/users/vitek-rostislav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitek-rostislav/subscriptions","organizations_url":"https://api.github.com/users/vitek-rostislav/orgs","repos_url":"https://api.github.com/users/vitek-rostislav/repos","events_url":"https://api.github.com/users/vitek-rostislav/events{/privacy}","received_events_url":"https://api.github.com/users/vitek-rostislav/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n|Description, reason for the PR| Project developer must be able to add new advert position easily\r\n|New feature| Yes\r\n|BC breaks| Yes\r\n|Fixes issues| https://github.com/shopsys/shopsys/issues/392\r\n|Standards and tests pass| Yes\r\n|Have you read and signed our [License Agreement for contributions](https://www.shopsys.com/license-agreement)?| Yes\r\n","created_at":"2018-08-09T11:06:38Z","updated_at":"2018-08-10T08:42:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3afb9e239fa81b6b8ef389fdd767f051e37e4fe","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/shopsys/shopsys/pulls/395/commits","review_comments_url":"https://api.github.com/repos/shopsys/shopsys/pulls/395/comments","review_comment_url":"https://api.github.com/repos/shopsys/shopsys/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shopsys/shopsys/issues/395/comments","statuses_url":"https://api.github.com/repos/shopsys/shopsys/statuses/fd5209d6a3b4f49bbb314e627f6e68ca3145b6fc","head":{"label":"shopsys:rv-advert-positions-extensibility","ref":"rv-advert-positions-extensibility","sha":"fd5209d6a3b4f49bbb314e627f6e68ca3145b6fc","user":{"login":"shopsys","id":17828168,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODI4MTY4","avatar_url":"https://avatars3.githubusercontent.com/u/17828168?v=4","gravatar_id":"","url":"https://api.github.com/users/shopsys","html_url":"https://github.com/shopsys","followers_url":"https://api.github.com/users/shopsys/followers","following_url":"https://api.github.com/users/shopsys/following{/other_user}","gists_url":"https://api.github.com/users/shopsys/gists{/gist_id}","starred_url":"https://api.github.com/users/shopsys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopsys/subscriptions","organizations_url":"https://api.github.com/users/shopsys/orgs","repos_url":"https://api.github.com/users/shopsys/repos","events_url":"https://api.github.com/users/shopsys/events{/privacy}","received_events_url":"https://api.github.com/users/shopsys/received_events","type":"Organization","site_admin":false},"repo":{"id":119832166,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk4MzIxNjY=","name":"shopsys","full_name":"shopsys/shopsys","owner":{"login":"shopsys","id":17828168,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODI4MTY4","avatar_url":"https://avatars3.githubusercontent.com/u/17828168?v=4","gravatar_id":"","url":"https://api.github.com/users/shopsys","html_url":"https://github.com/shopsys","followers_url":"https://api.github.com/users/shopsys/followers","following_url":"https://api.github.com/users/shopsys/following{/other_user}","gists_url":"https://api.github.com/users/shopsys/gists{/gist_id}","starred_url":"https://api.github.com/users/shopsys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopsys/subscriptions","organizations_url":"https://api.github.com/users/shopsys/orgs","repos_url":"https://api.github.com/users/shopsys/repos","events_url":"https://api.github.com/users/shopsys/events{/privacy}","received_events_url":"https://api.github.com/users/shopsys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shopsys/shopsys","description":"Main repository for maintaining Shopsys Framework packages. Open for ISSUES and PULL REQUESTS. ","fork":false,"url":"https://api.github.com/repos/shopsys/shopsys","forks_url":"https://api.github.com/repos/shopsys/shopsys/forks","keys_url":"https://api.github.com/repos/shopsys/shopsys/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shopsys/shopsys/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shopsys/shopsys/teams","hooks_url":"https://api.github.com/repos/shopsys/shopsys/hooks","issue_events_url":"https://api.github.com/repos/shopsys/shopsys/issues/events{/number}","events_url":"https://api.github.com/repos/shopsys/shopsys/events","assignees_url":"https://api.github.com/repos/shopsys/shopsys/assignees{/user}","branches_url":"https://api.github.com/repos/shopsys/shopsys/branches{/branch}","tags_url":"https://api.github.com/repos/shopsys/shopsys/tags","blobs_url":"https://api.github.com/repos/shopsys/shopsys/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shopsys/shopsys/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shopsys/shopsys/git/refs{/sha}","trees_url":"https://api.github.com/repos/shopsys/shopsys/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shopsys/shopsys/statuses/{sha}","languages_url":"https://api.github.com/repos/shopsys/shopsys/languages","stargazers_url":"https://api.github.com/repos/shopsys/shopsys/stargazers","contributors_url":"https://api.github.com/repos/shopsys/shopsys/contributors","subscribers_url":"https://api.github.com/repos/shopsys/shopsys/subscribers","subscription_url":"https://api.github.com/repos/shopsys/shopsys/subscription","commits_url":"https://api.github.com/repos/shopsys/shopsys/commits{/sha}","git_commits_url":"https://api.github.com/repos/shopsys/shopsys/git/commits{/sha}","comments_url":"https://api.github.com/repos/shopsys/shopsys/comments{/number}","issue_comment_url":"https://api.github.com/repos/shopsys/shopsys/issues/comments{/number}","contents_url":"https://api.github.com/repos/shopsys/shopsys/contents/{+path}","compare_url":"https://api.github.com/repos/shopsys/shopsys/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shopsys/shopsys/merges","archive_url":"https://api.github.com/repos/shopsys/shopsys/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shopsys/shopsys/downloads","issues_url":"https://api.github.com/repos/shopsys/shopsys/issues{/number}","pulls_url":"https://api.github.com/repos/shopsys/shopsys/pulls{/number}","milestones_url":"https://api.github.com/repos/shopsys/shopsys/milestones{/number}","notifications_url":"https://api.github.com/repos/shopsys/shopsys/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shopsys/shopsys/labels{/name}","releases_url":"https://api.github.com/repos/shopsys/shopsys/releases{/id}","deployments_url":"https://api.github.com/repos/shopsys/shopsys/deployments","created_at":"2018-02-01T12:21:09Z","updated_at":"2018-08-10T06:58:09Z","pushed_at":"2018-08-10T08:30:18Z","git_url":"git://github.com/shopsys/shopsys.git","ssh_url":"git@github.com:shopsys/shopsys.git","clone_url":"https://github.com/shopsys/shopsys.git","svn_url":"https://github.com/shopsys/shopsys","homepage":"https://www.shopsys.com","size":21038,"stargazers_count":84,"watchers_count":84,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":100,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":16,"open_issues":100,"watchers":84,"default_branch":"master"}},"base":{"label":"shopsys:master","ref":"master","sha":"9f293df60c5ceb15d4c40dd058d8cb869d98cb16","user":{"login":"shopsys","id":17828168,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODI4MTY4","avatar_url":"https://avatars3.githubusercontent.com/u/17828168?v=4","gravatar_id":"","url":"https://api.github.com/users/shopsys","html_url":"https://github.com/shopsys","followers_url":"https://api.github.com/users/shopsys/followers","following_url":"https://api.github.com/users/shopsys/following{/other_user}","gists_url":"https://api.github.com/users/shopsys/gists{/gist_id}","starred_url":"https://api.github.com/users/shopsys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopsys/subscriptions","organizations_url":"https://api.github.com/users/shopsys/orgs","repos_url":"https://api.github.com/users/shopsys/repos","events_url":"https://api.github.com/users/shopsys/events{/privacy}","received_events_url":"https://api.github.com/users/shopsys/received_events","type":"Organization","site_admin":false},"repo":{"id":119832166,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk4MzIxNjY=","name":"shopsys","full_name":"shopsys/shopsys","owner":{"login":"shopsys","id":17828168,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODI4MTY4","avatar_url":"https://avatars3.githubusercontent.com/u/17828168?v=4","gravatar_id":"","url":"https://api.github.com/users/shopsys","html_url":"https://github.com/shopsys","followers_url":"https://api.github.com/users/shopsys/followers","following_url":"https://api.github.com/users/shopsys/following{/other_user}","gists_url":"https://api.github.com/users/shopsys/gists{/gist_id}","starred_url":"https://api.github.com/users/shopsys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopsys/subscriptions","organizations_url":"https://api.github.com/users/shopsys/orgs","repos_url":"https://api.github.com/users/shopsys/repos","events_url":"https://api.github.com/users/shopsys/events{/privacy}","received_events_url":"https://api.github.com/users/shopsys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shopsys/shopsys","description":"Main repository for maintaining Shopsys Framework packages. Open for ISSUES and PULL REQUESTS. ","fork":false,"url":"https://api.github.com/repos/shopsys/shopsys","forks_url":"https://api.github.com/repos/shopsys/shopsys/forks","keys_url":"https://api.github.com/repos/shopsys/shopsys/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shopsys/shopsys/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shopsys/shopsys/teams","hooks_url":"https://api.github.com/repos/shopsys/shopsys/hooks","issue_events_url":"https://api.github.com/repos/shopsys/shopsys/issues/events{/number}","events_url":"https://api.github.com/repos/shopsys/shopsys/events","assignees_url":"https://api.github.com/repos/shopsys/shopsys/assignees{/user}","branches_url":"https://api.github.com/repos/shopsys/shopsys/branches{/branch}","tags_url":"https://api.github.com/repos/shopsys/shopsys/tags","blobs_url":"https://api.github.com/repos/shopsys/shopsys/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shopsys/shopsys/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shopsys/shopsys/git/refs{/sha}","trees_url":"https://api.github.com/repos/shopsys/shopsys/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shopsys/shopsys/statuses/{sha}","languages_url":"https://api.github.com/repos/shopsys/shopsys/languages","stargazers_url":"https://api.github.com/repos/shopsys/shopsys/stargazers","contributors_url":"https://api.github.com/repos/shopsys/shopsys/contributors","subscribers_url":"https://api.github.com/repos/shopsys/shopsys/subscribers","subscription_url":"https://api.github.com/repos/shopsys/shopsys/subscription","commits_url":"https://api.github.com/repos/shopsys/shopsys/commits{/sha}","git_commits_url":"https://api.github.com/repos/shopsys/shopsys/git/commits{/sha}","comments_url":"https://api.github.com/repos/shopsys/shopsys/comments{/number}","issue_comment_url":"https://api.github.com/repos/shopsys/shopsys/issues/comments{/number}","contents_url":"https://api.github.com/repos/shopsys/shopsys/contents/{+path}","compare_url":"https://api.github.com/repos/shopsys/shopsys/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shopsys/shopsys/merges","archive_url":"https://api.github.com/repos/shopsys/shopsys/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shopsys/shopsys/downloads","issues_url":"https://api.github.com/repos/shopsys/shopsys/issues{/number}","pulls_url":"https://api.github.com/repos/shopsys/shopsys/pulls{/number}","milestones_url":"https://api.github.com/repos/shopsys/shopsys/milestones{/number}","notifications_url":"https://api.github.com/repos/shopsys/shopsys/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shopsys/shopsys/labels{/name}","releases_url":"https://api.github.com/repos/shopsys/shopsys/releases{/id}","deployments_url":"https://api.github.com/repos/shopsys/shopsys/deployments","created_at":"2018-02-01T12:21:09Z","updated_at":"2018-08-10T06:58:09Z","pushed_at":"2018-08-10T08:30:18Z","git_url":"git://github.com/shopsys/shopsys.git","ssh_url":"git@github.com:shopsys/shopsys.git","clone_url":"https://github.com/shopsys/shopsys.git","svn_url":"https://github.com/shopsys/shopsys","homepage":"https://www.shopsys.com","size":21038,"stargazers_count":84,"watchers_count":84,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":100,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":16,"open_issues":100,"watchers":84,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shopsys/shopsys/pulls/395"},"html":{"href":"https://github.com/shopsys/shopsys/pull/395"},"issue":{"href":"https://api.github.com/repos/shopsys/shopsys/issues/395"},"comments":{"href":"https://api.github.com/repos/shopsys/shopsys/issues/395/comments"},"review_comments":{"href":"https://api.github.com/repos/shopsys/shopsys/pulls/395/comments"},"review_comment":{"href":"https://api.github.com/repos/shopsys/shopsys/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shopsys/shopsys/pulls/395/commits"},"statuses":{"href":"https://api.github.com/repos/shopsys/shopsys/statuses/fd5209d6a3b4f49bbb314e627f6e68ca3145b6fc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"PetrHeinz"}}