{"action":"opened","number":633,"pull_request":{"url":"https://api.github.com/repos/ACEmulator/ACE/pulls/633","id":168406503,"html_url":"https://github.com/ACEmulator/ACE/pull/633","diff_url":"https://github.com/ACEmulator/ACE/pull/633.diff","patch_url":"https://github.com/ACEmulator/ACE/pull/633.patch","issue_url":"https://api.github.com/repos/ACEmulator/ACE/issues/633","number":633,"state":"open","locked":false,"title":"Proof of Concept work to use Entity Framework Core, DB First ***POC, DO NOT MERGE***","user":{"login":"Mag-nus","id":10608427,"avatar_url":"https://avatars1.githubusercontent.com/u/10608427?v=4","gravatar_id":"","url":"https://api.github.com/users/Mag-nus","html_url":"https://github.com/Mag-nus","followers_url":"https://api.github.com/users/Mag-nus/followers","following_url":"https://api.github.com/users/Mag-nus/following{/other_user}","gists_url":"https://api.github.com/users/Mag-nus/gists{/gist_id}","starred_url":"https://api.github.com/users/Mag-nus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mag-nus/subscriptions","organizations_url":"https://api.github.com/users/Mag-nus/orgs","repos_url":"https://api.github.com/users/Mag-nus/repos","events_url":"https://api.github.com/users/Mag-nus/events{/privacy}","received_events_url":"https://api.github.com/users/Mag-nus/received_events","type":"User","site_admin":false},"body":"This would simplify our DB model.\r\nIt should make it easier for new developers to get involved.\r\nIt would allow us to use async/await database queries.\r\n\r\nUsing the database first method, which this shows, we would simply design our tables in MySQL, then scaffold those changes into ACE. The scaffolding will completely rebuild/update the classes you see in ACE.Database.Models.\r\n\r\nScaffold-DbContext \"server=localhost;port=3306;user=root;password=password;database=ace_auth\" -Project ACE.Database -OutputDir \".\\Models\\ace_auth\" -f Pomelo.EntityFrameworkCore.MySql\r\n\r\nScaffold-DbContext \"server=localhost;port=3306;user=root;password=password;database=ace_world\" -Project ACE.Database -OutputDir \".\\Models\\ace_world\" -f Pomelo.EntityFrameworkCore.MySql\r\n\r\nScaffold-DbContext \"server=localhost;port=3306;user=root;password=password;database=ace_shard\" -Project ACE.Database -OutputDir \".\\Models\\ace_shard\" -f Pomelo.EntityFrameworkCore.MySql\r\n\r\nThe scaffolding process will automatically create all of the POCOs. In the existing system, they need to be manually created in ACE.Entity with appropriate class and field attributes for mapping. Using Entity Framework needs none of that.\r\n\r\nIf you're wondering why I chose to use Pomelo instead of a MySql EF package from Oracle, the Oracle packages do not scaffold properly. Pomelo seems to be the go to framework for EF in .net core. I've used it before with success.\r\n\r\nLastly, I believe using Entity Framework will expose contributors to the project to patterns and practices that they're more likely to see out in the field.","created_at":"2018-02-10T15:31:02Z","updated_at":"2018-02-10T15:31:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":541311526,"url":"https://api.github.com/repos/ACEmulator/ACE/labels/blocked:Needs%20more%20Information","name":"blocked:Needs more Information","color":"e99695","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ACEmulator/ACE/pulls/633/commits","review_comments_url":"https://api.github.com/repos/ACEmulator/ACE/pulls/633/comments","review_comment_url":"https://api.github.com/repos/ACEmulator/ACE/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ACEmulator/ACE/issues/633/comments","statuses_url":"https://api.github.com/repos/ACEmulator/ACE/statuses/d51dc818d06e3122ea01901e01e9bd2107417e8b","head":{"label":"Mag-nus:master","ref":"master","sha":"d51dc818d06e3122ea01901e01e9bd2107417e8b","user":{"login":"Mag-nus","id":10608427,"avatar_url":"https://avatars1.githubusercontent.com/u/10608427?v=4","gravatar_id":"","url":"https://api.github.com/users/Mag-nus","html_url":"https://github.com/Mag-nus","followers_url":"https://api.github.com/users/Mag-nus/followers","following_url":"https://api.github.com/users/Mag-nus/following{/other_user}","gists_url":"https://api.github.com/users/Mag-nus/gists{/gist_id}","starred_url":"https://api.github.com/users/Mag-nus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mag-nus/subscriptions","organizations_url":"https://api.github.com/users/Mag-nus/orgs","repos_url":"https://api.github.com/users/Mag-nus/repos","events_url":"https://api.github.com/users/Mag-nus/events{/privacy}","received_events_url":"https://api.github.com/users/Mag-nus/received_events","type":"User","site_admin":false},"repo":{"id":121012010,"name":"ACE","full_name":"Mag-nus/ACE","owner":{"login":"Mag-nus","id":10608427,"avatar_url":"https://avatars1.githubusercontent.com/u/10608427?v=4","gravatar_id":"","url":"https://api.github.com/users/Mag-nus","html_url":"https://github.com/Mag-nus","followers_url":"https://api.github.com/users/Mag-nus/followers","following_url":"https://api.github.com/users/Mag-nus/following{/other_user}","gists_url":"https://api.github.com/users/Mag-nus/gists{/gist_id}","starred_url":"https://api.github.com/users/Mag-nus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mag-nus/subscriptions","organizations_url":"https://api.github.com/users/Mag-nus/orgs","repos_url":"https://api.github.com/users/Mag-nus/repos","events_url":"https://api.github.com/users/Mag-nus/events{/privacy}","received_events_url":"https://api.github.com/users/Mag-nus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mag-nus/ACE","description":"Asheron's Call server emulator.","fork":true,"url":"https://api.github.com/repos/Mag-nus/ACE","forks_url":"https://api.github.com/repos/Mag-nus/ACE/forks","keys_url":"https://api.github.com/repos/Mag-nus/ACE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mag-nus/ACE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mag-nus/ACE/teams","hooks_url":"https://api.github.com/repos/Mag-nus/ACE/hooks","issue_events_url":"https://api.github.com/repos/Mag-nus/ACE/issues/events{/number}","events_url":"https://api.github.com/repos/Mag-nus/ACE/events","assignees_url":"https://api.github.com/repos/Mag-nus/ACE/assignees{/user}","branches_url":"https://api.github.com/repos/Mag-nus/ACE/branches{/branch}","tags_url":"https://api.github.com/repos/Mag-nus/ACE/tags","blobs_url":"https://api.github.com/repos/Mag-nus/ACE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mag-nus/ACE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mag-nus/ACE/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mag-nus/ACE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mag-nus/ACE/statuses/{sha}","languages_url":"https://api.github.com/repos/Mag-nus/ACE/languages","stargazers_url":"https://api.github.com/repos/Mag-nus/ACE/stargazers","contributors_url":"https://api.github.com/repos/Mag-nus/ACE/contributors","subscribers_url":"https://api.github.com/repos/Mag-nus/ACE/subscribers","subscription_url":"https://api.github.com/repos/Mag-nus/ACE/subscription","commits_url":"https://api.github.com/repos/Mag-nus/ACE/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mag-nus/ACE/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mag-nus/ACE/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mag-nus/ACE/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mag-nus/ACE/contents/{+path}","compare_url":"https://api.github.com/repos/Mag-nus/ACE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mag-nus/ACE/merges","archive_url":"https://api.github.com/repos/Mag-nus/ACE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mag-nus/ACE/downloads","issues_url":"https://api.github.com/repos/Mag-nus/ACE/issues{/number}","pulls_url":"https://api.github.com/repos/Mag-nus/ACE/pulls{/number}","milestones_url":"https://api.github.com/repos/Mag-nus/ACE/milestones{/number}","notifications_url":"https://api.github.com/repos/Mag-nus/ACE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mag-nus/ACE/labels{/name}","releases_url":"https://api.github.com/repos/Mag-nus/ACE/releases{/id}","deployments_url":"https://api.github.com/repos/Mag-nus/ACE/deployments","created_at":"2018-02-10T12:05:44Z","updated_at":"2018-02-10T12:05:47Z","pushed_at":"2018-02-10T15:19:29Z","git_url":"git://github.com/Mag-nus/ACE.git","ssh_url":"git@github.com:Mag-nus/ACE.git","clone_url":"https://github.com/Mag-nus/ACE.git","svn_url":"https://github.com/Mag-nus/ACE","homepage":"http://acemulator.org","size":5951,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ACEmulator:master","ref":"master","sha":"ef34494e7bdf84d800cfd8faba3bec9456dd1d6f","user":{"login":"ACEmulator","id":24881359,"avatar_url":"https://avatars0.githubusercontent.com/u/24881359?v=4","gravatar_id":"","url":"https://api.github.com/users/ACEmulator","html_url":"https://github.com/ACEmulator","followers_url":"https://api.github.com/users/ACEmulator/followers","following_url":"https://api.github.com/users/ACEmulator/following{/other_user}","gists_url":"https://api.github.com/users/ACEmulator/gists{/gist_id}","starred_url":"https://api.github.com/users/ACEmulator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ACEmulator/subscriptions","organizations_url":"https://api.github.com/users/ACEmulator/orgs","repos_url":"https://api.github.com/users/ACEmulator/repos","events_url":"https://api.github.com/users/ACEmulator/events{/privacy}","received_events_url":"https://api.github.com/users/ACEmulator/received_events","type":"Organization","site_admin":false},"repo":{"id":79078680,"name":"ACE","full_name":"ACEmulator/ACE","owner":{"login":"ACEmulator","id":24881359,"avatar_url":"https://avatars0.githubusercontent.com/u/24881359?v=4","gravatar_id":"","url":"https://api.github.com/users/ACEmulator","html_url":"https://github.com/ACEmulator","followers_url":"https://api.github.com/users/ACEmulator/followers","following_url":"https://api.github.com/users/ACEmulator/following{/other_user}","gists_url":"https://api.github.com/users/ACEmulator/gists{/gist_id}","starred_url":"https://api.github.com/users/ACEmulator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ACEmulator/subscriptions","organizations_url":"https://api.github.com/users/ACEmulator/orgs","repos_url":"https://api.github.com/users/ACEmulator/repos","events_url":"https://api.github.com/users/ACEmulator/events{/privacy}","received_events_url":"https://api.github.com/users/ACEmulator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ACEmulator/ACE","description":"Asheron's Call server emulator.","fork":false,"url":"https://api.github.com/repos/ACEmulator/ACE","forks_url":"https://api.github.com/repos/ACEmulator/ACE/forks","keys_url":"https://api.github.com/repos/ACEmulator/ACE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ACEmulator/ACE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ACEmulator/ACE/teams","hooks_url":"https://api.github.com/repos/ACEmulator/ACE/hooks","issue_events_url":"https://api.github.com/repos/ACEmulator/ACE/issues/events{/number}","events_url":"https://api.github.com/repos/ACEmulator/ACE/events","assignees_url":"https://api.github.com/repos/ACEmulator/ACE/assignees{/user}","branches_url":"https://api.github.com/repos/ACEmulator/ACE/branches{/branch}","tags_url":"https://api.github.com/repos/ACEmulator/ACE/tags","blobs_url":"https://api.github.com/repos/ACEmulator/ACE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ACEmulator/ACE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ACEmulator/ACE/git/refs{/sha}","trees_url":"https://api.github.com/repos/ACEmulator/ACE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ACEmulator/ACE/statuses/{sha}","languages_url":"https://api.github.com/repos/ACEmulator/ACE/languages","stargazers_url":"https://api.github.com/repos/ACEmulator/ACE/stargazers","contributors_url":"https://api.github.com/repos/ACEmulator/ACE/contributors","subscribers_url":"https://api.github.com/repos/ACEmulator/ACE/subscribers","subscription_url":"https://api.github.com/repos/ACEmulator/ACE/subscription","commits_url":"https://api.github.com/repos/ACEmulator/ACE/commits{/sha}","git_commits_url":"https://api.github.com/repos/ACEmulator/ACE/git/commits{/sha}","comments_url":"https://api.github.com/repos/ACEmulator/ACE/comments{/number}","issue_comment_url":"https://api.github.com/repos/ACEmulator/ACE/issues/comments{/number}","contents_url":"https://api.github.com/repos/ACEmulator/ACE/contents/{+path}","compare_url":"https://api.github.com/repos/ACEmulator/ACE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ACEmulator/ACE/merges","archive_url":"https://api.github.com/repos/ACEmulator/ACE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ACEmulator/ACE/downloads","issues_url":"https://api.github.com/repos/ACEmulator/ACE/issues{/number}","pulls_url":"https://api.github.com/repos/ACEmulator/ACE/pulls{/number}","milestones_url":"https://api.github.com/repos/ACEmulator/ACE/milestones{/number}","notifications_url":"https://api.github.com/repos/ACEmulator/ACE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ACEmulator/ACE/labels{/name}","releases_url":"https://api.github.com/repos/ACEmulator/ACE/releases{/id}","deployments_url":"https://api.github.com/repos/ACEmulator/ACE/deployments","created_at":"2017-01-16T03:18:11Z","updated_at":"2018-02-05T05:22:55Z","pushed_at":"2018-02-10T12:05:14Z","git_url":"git://github.com/ACEmulator/ACE.git","ssh_url":"git@github.com:ACEmulator/ACE.git","clone_url":"https://github.com/ACEmulator/ACE.git","svn_url":"https://github.com/ACEmulator/ACE","homepage":"http://acemulator.org","size":5960,"stargazers_count":72,"watchers_count":72,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":72,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":72,"open_issues":12,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ACEmulator/ACE/pulls/633"},"html":{"href":"https://github.com/ACEmulator/ACE/pull/633"},"issue":{"href":"https://api.github.com/repos/ACEmulator/ACE/issues/633"},"comments":{"href":"https://api.github.com/repos/ACEmulator/ACE/issues/633/comments"},"review_comments":{"href":"https://api.github.com/repos/ACEmulator/ACE/pulls/633/comments"},"review_comment":{"href":"https://api.github.com/repos/ACEmulator/ACE/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ACEmulator/ACE/pulls/633/commits"},"statuses":{"href":"https://api.github.com/repos/ACEmulator/ACE/statuses/d51dc818d06e3122ea01901e01e9bd2107417e8b"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":282,"deletions":86,"changed_files":13}}
{"actor":{"display_login":"Mag-nus"}}