{"action":"created","comment":{"url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/pulls/comments/171231028","pull_request_review_id":100045781,"id":171231028,"diff_hunk":"@@ -71,36 +110,30 @@ PgConnection.prototype.setDBAuth = function(username, params, callback) {\n // @param callback function(err)\n //\n PgConnection.prototype.setDBConn = function(dbowner, params, callback) {\n-    var self = this;\n-    // Add default database connection parameters\n-    // if none given\n     _.defaults(params, {\n-        dbuser: global.environment.postgres.user,\n-        dbpassword: global.environment.postgres.password,\n+        // dbuser: global.environment.postgres.user,","path":"lib/cartodb/backends/pg_connection.js","position":139,"original_position":139,"commit_id":"102b11b1b5e16726312c9eb82c55b4f8d6bb165b","original_commit_id":"26df09b13fa828f542dab91d0ed1a0cedf147d26","user":{"login":"enekid","id":623492,"avatar_url":"https://avatars2.githubusercontent.com/u/623492?v=4","gravatar_id":"","url":"https://api.github.com/users/enekid","html_url":"https://github.com/enekid","followers_url":"https://api.github.com/users/enekid/followers","following_url":"https://api.github.com/users/enekid/following{/other_user}","gists_url":"https://api.github.com/users/enekid/gists{/gist_id}","starred_url":"https://api.github.com/users/enekid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enekid/subscriptions","organizations_url":"https://api.github.com/users/enekid/orgs","repos_url":"https://api.github.com/users/enekid/repos","events_url":"https://api.github.com/users/enekid/events{/privacy}","received_events_url":"https://api.github.com/users/enekid/received_events","type":"User","site_admin":false},"body":"Yep. I missed that.","created_at":"2018-02-28T12:37:27Z","updated_at":"2018-02-28T12:37:40Z","html_url":"https://github.com/CartoDB/Windshaft-cartodb/pull/877#discussion_r171231028","pull_request_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/pulls/877","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/pulls/comments/171231028"},"html":{"href":"https://github.com/CartoDB/Windshaft-cartodb/pull/877#discussion_r171231028"},"pull_request":{"href":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/pulls/877"}},"in_reply_to_id":171222533},"pull_request":{"url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/pulls/877","id":170023391,"html_url":"https://github.com/CartoDB/Windshaft-cartodb/pull/877","diff_url":"https://github.com/CartoDB/Windshaft-cartodb/pull/877.diff","patch_url":"https://github.com/CartoDB/Windshaft-cartodb/pull/877.patch","issue_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/issues/877","number":877,"state":"open","locked":false,"title":"Auth API","user":{"login":"dgaubert","id":1936888,"avatar_url":"https://avatars0.githubusercontent.com/u/1936888?v=4","gravatar_id":"","url":"https://api.github.com/users/dgaubert","html_url":"https://github.com/dgaubert","followers_url":"https://api.github.com/users/dgaubert/followers","following_url":"https://api.github.com/users/dgaubert/following{/other_user}","gists_url":"https://api.github.com/users/dgaubert/gists{/gist_id}","starred_url":"https://api.github.com/users/dgaubert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgaubert/subscriptions","organizations_url":"https://api.github.com/users/dgaubert/orgs","repos_url":"https://api.github.com/users/dgaubert/repos","events_url":"https://api.github.com/users/dgaubert/events{/privacy}","received_events_url":"https://api.github.com/users/dgaubert/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-19T17:58:41Z","updated_at":"2018-02-28T12:37:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac010a371cb90dfb091304a9b8e07472d6838a89","assignee":null,"assignees":[],"requested_reviewers":[{"login":"enekid","id":623492,"avatar_url":"https://avatars2.githubusercontent.com/u/623492?v=4","gravatar_id":"","url":"https://api.github.com/users/enekid","html_url":"https://github.com/enekid","followers_url":"https://api.github.com/users/enekid/followers","following_url":"https://api.github.com/users/enekid/following{/other_user}","gists_url":"https://api.github.com/users/enekid/gists{/gist_id}","starred_url":"https://api.github.com/users/enekid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enekid/subscriptions","organizations_url":"https://api.github.com/users/enekid/orgs","repos_url":"https://api.github.com/users/enekid/repos","events_url":"https://api.github.com/users/enekid/events{/privacy}","received_events_url":"https://api.github.com/users/enekid/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/pulls/877/commits","review_comments_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/pulls/877/comments","review_comment_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/issues/877/comments","statuses_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/statuses/102b11b1b5e16726312c9eb82c55b4f8d6bb165b","head":{"label":"CartoDB:project-auth-api","ref":"project-auth-api","sha":"102b11b1b5e16726312c9eb82c55b4f8d6bb165b","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":2325416,"name":"Windshaft-cartodb","full_name":"CartoDB/Windshaft-cartodb","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/Windshaft-cartodb","description":"Windshaft tailored for CARTO","fork":false,"url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb","forks_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/forks","keys_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/teams","hooks_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/events","assignees_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/tags","blobs_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/languages","stargazers_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/subscription","commits_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/merges","archive_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/downloads","issues_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/deployments","created_at":"2011-09-04T23:35:06Z","updated_at":"2017-11-15T09:57:38Z","pushed_at":"2018-02-28T12:37:17Z","git_url":"git://github.com/CartoDB/Windshaft-cartodb.git","ssh_url":"git@github.com:CartoDB/Windshaft-cartodb.git","clone_url":"https://github.com/CartoDB/Windshaft-cartodb.git","svn_url":"https://github.com/CartoDB/Windshaft-cartodb","homepage":"","size":33010,"stargazers_count":50,"watchers_count":50,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":82,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":46,"open_issues":82,"watchers":50,"default_branch":"master"}},"base":{"label":"CartoDB:master","ref":"master","sha":"6b0ab45e6372bcc366406bd569b6c202473de579","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":2325416,"name":"Windshaft-cartodb","full_name":"CartoDB/Windshaft-cartodb","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/Windshaft-cartodb","description":"Windshaft tailored for CARTO","fork":false,"url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb","forks_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/forks","keys_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/teams","hooks_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/events","assignees_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/tags","blobs_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/languages","stargazers_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/subscription","commits_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/merges","archive_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/downloads","issues_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/deployments","created_at":"2011-09-04T23:35:06Z","updated_at":"2017-11-15T09:57:38Z","pushed_at":"2018-02-28T12:37:17Z","git_url":"git://github.com/CartoDB/Windshaft-cartodb.git","ssh_url":"git@github.com:CartoDB/Windshaft-cartodb.git","clone_url":"https://github.com/CartoDB/Windshaft-cartodb.git","svn_url":"https://github.com/CartoDB/Windshaft-cartodb","homepage":"","size":33010,"stargazers_count":50,"watchers_count":50,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":82,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":46,"open_issues":82,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/pulls/877"},"html":{"href":"https://github.com/CartoDB/Windshaft-cartodb/pull/877"},"issue":{"href":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/issues/877"},"comments":{"href":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/issues/877/comments"},"review_comments":{"href":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/pulls/877/comments"},"review_comment":{"href":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/pulls/877/commits"},"statuses":{"href":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/statuses/102b11b1b5e16726312c9eb82c55b4f8d6bb165b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"enekid"}}