{"action":"created","issue":{"url":"https://api.github.com/repos/trilinos/Trilinos/issues/2452","repository_url":"https://api.github.com/repos/trilinos/Trilinos","labels_url":"https://api.github.com/repos/trilinos/Trilinos/issues/2452/labels{/name}","comments_url":"https://api.github.com/repos/trilinos/Trilinos/issues/2452/comments","events_url":"https://api.github.com/repos/trilinos/Trilinos/issues/2452/events","html_url":"https://github.com/trilinos/Trilinos/pull/2452","id":308360666,"number":2452,"title":"KokkosKernels & Tetra fixes for KOKKOS_ENABLE_DEBUG","user":{"login":"ibaned","id":971921,"avatar_url":"https://avatars2.githubusercontent.com/u/971921?v=4","gravatar_id":"","url":"https://api.github.com/users/ibaned","html_url":"https://github.com/ibaned","followers_url":"https://api.github.com/users/ibaned/followers","following_url":"https://api.github.com/users/ibaned/following{/other_user}","gists_url":"https://api.github.com/users/ibaned/gists{/gist_id}","starred_url":"https://api.github.com/users/ibaned/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibaned/subscriptions","organizations_url":"https://api.github.com/users/ibaned/orgs","repos_url":"https://api.github.com/users/ibaned/repos","events_url":"https://api.github.com/users/ibaned/events{/privacy}","received_events_url":"https://api.github.com/users/ibaned/received_events","type":"User","site_admin":false},"labels":[{"id":338192363,"url":"https://api.github.com/repos/trilinos/Trilinos/labels/KokkosKernels","name":"KokkosKernels","color":"eb6420","default":false},{"id":289606028,"url":"https://api.github.com/repos/trilinos/Trilinos/labels/Tpetra","name":"Tpetra","color":"5319e7","default":false},{"id":287520103,"url":"https://api.github.com/repos/trilinos/Trilinos/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":{"login":"ibaned","id":971921,"avatar_url":"https://avatars2.githubusercontent.com/u/971921?v=4","gravatar_id":"","url":"https://api.github.com/users/ibaned","html_url":"https://github.com/ibaned","followers_url":"https://api.github.com/users/ibaned/followers","following_url":"https://api.github.com/users/ibaned/following{/other_user}","gists_url":"https://api.github.com/users/ibaned/gists{/gist_id}","starred_url":"https://api.github.com/users/ibaned/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibaned/subscriptions","organizations_url":"https://api.github.com/users/ibaned/orgs","repos_url":"https://api.github.com/users/ibaned/repos","events_url":"https://api.github.com/users/ibaned/events{/privacy}","received_events_url":"https://api.github.com/users/ibaned/received_events","type":"User","site_admin":false},"assignees":[{"login":"ibaned","id":971921,"avatar_url":"https://avatars2.githubusercontent.com/u/971921?v=4","gravatar_id":"","url":"https://api.github.com/users/ibaned","html_url":"https://github.com/ibaned","followers_url":"https://api.github.com/users/ibaned/followers","following_url":"https://api.github.com/users/ibaned/following{/other_user}","gists_url":"https://api.github.com/users/ibaned/gists{/gist_id}","starred_url":"https://api.github.com/users/ibaned/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibaned/subscriptions","organizations_url":"https://api.github.com/users/ibaned/orgs","repos_url":"https://api.github.com/users/ibaned/repos","events_url":"https://api.github.com/users/ibaned/events{/privacy}","received_events_url":"https://api.github.com/users/ibaned/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-03-25T15:52:02Z","updated_at":"2018-03-25T17:44:43Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/trilinos/Trilinos/pulls/2452","html_url":"https://github.com/trilinos/Trilinos/pull/2452","diff_url":"https://github.com/trilinos/Trilinos/pull/2452.diff","patch_url":"https://github.com/trilinos/Trilinos/pull/2452.patch"},"body":"<!---\r\nBe sure to select `develop` as the `base` branch against which to create this\r\npull request.  Only pull requests against `develop` will undergo Trilinos'\r\nautomated testing.  Pull requests against `master` will be ignored.\r\n-->\r\n\r\n<!---\r\nProvide a general summary of your changes in the Title above.  If this pull\r\nrequest pertains to a particular package in Trilinos, it's worthwhile to start\r\nthe title with \"PackageName:  \".\r\n-->\r\n\r\n<!---\r\nNote that anything between these delimiters is a comment that will not appear\r\nin the pull request description once created.\r\n-->\r\n\r\n<!---\r\nReplace <teamName> below with the appropriate Trilinos package/team name.\r\n-->\r\n@trilinos/tpetra \r\n@trilinos/kokkos \r\n@trilinos/kokkos-kernels\r\n\r\n<!---\r\nReviewers:  If you know someone who is knowledgeable about what you are\r\nchanging, or perhaps someone who should be, and you would like them to review\r\nyour changes before they are accepted, select them from the Reviewers drop-down\r\non the right.\r\n-->\r\n\r\n<!---\r\nAssignees:  If you know anyone who should likely handle bringing this pull\r\nrequest to completion, select them from the Assignees drop-down on the right.\r\nIf you have write-access to Trilinos, this should likely be you.\r\n-->\r\n\r\n<!---\r\nLables:  Choose any applicable package names from the Labels drop-down on the\r\nright.  Additionally, choose a label to indicate the type of issue, for\r\ninstance, bug, build, documentation, enhancement, etc.\r\n-->\r\n\r\n## Description\r\n<!--- Describe your changes in detail. -->\r\nThis fixes the remaining issues with a Trilinos build of the Tpetra stack that has Kokkos bounds checking enabled. There was an off-by-one error when constructing subviews to supply as begin/end arrays. Also, the `dgemm_double` test is very slow with bounds checking on, so until it is modified such that it runs faster, I've added code to disable it when bounds checking is on.\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required?  What problem does it solve? -->\r\nThis helps Trilinos pass all tests with Kokkos bounds checking enabled, with is an ATDM goal.\r\n\r\n## Related Issues\r\n<!---\r\nIf applicable, let us know how this merge request is related to any other open\r\nissues or pull requests:\r\n-->\r\n* Part of #2439 \r\n\r\n## How Has This Been Tested?\r\n<!---\r\nPlease describe in detail how you tested your changes.  Include details of your\r\ntesting environment and the tests you ran to see how your change affects other\r\nareas of the code.  Consider including configure, build, and test log files.\r\n-->\r\nA custom build of Trilinos passes the tests which formerly failed as identified by #2439 "},"comment":{"url":"https://api.github.com/repos/trilinos/Trilinos/issues/comments/375989027","html_url":"https://github.com/trilinos/Trilinos/pull/2452#issuecomment-375989027","issue_url":"https://api.github.com/repos/trilinos/Trilinos/issues/2452","id":375989027,"user":{"login":"bartlettroscoe","id":1959736,"avatar_url":"https://avatars1.githubusercontent.com/u/1959736?v=4","gravatar_id":"","url":"https://api.github.com/users/bartlettroscoe","html_url":"https://github.com/bartlettroscoe","followers_url":"https://api.github.com/users/bartlettroscoe/followers","following_url":"https://api.github.com/users/bartlettroscoe/following{/other_user}","gists_url":"https://api.github.com/users/bartlettroscoe/gists{/gist_id}","starred_url":"https://api.github.com/users/bartlettroscoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartlettroscoe/subscriptions","organizations_url":"https://api.github.com/users/bartlettroscoe/orgs","repos_url":"https://api.github.com/users/bartlettroscoe/repos","events_url":"https://api.github.com/users/bartlettroscoe/events{/privacy}","received_events_url":"https://api.github.com/users/bartlettroscoe/received_events","type":"User","site_admin":false},"created_at":"2018-03-25T17:44:43Z","updated_at":"2018-03-25T17:44:43Z","author_association":"MEMBER","body":"I am testing the full CI debug build of Trilinos with this now."}}
{"actor":{"display_login":"bartlettroscoe"}}