{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/frontend/pulls/comments/172523086","pull_request_review_id":101551993,"id":172523086,"diff_hunk":"@@ -20,10 +21,15 @@ type AdSize = {\n /* bodyAds is a counter that keeps track of the number of inline MPUs\n  * inserted dynamically. */\n let bodyAds: number;\n-const replaceTopSlot: boolean = isBreakpoint({\n+const isMobileBreakpoint: boolean = isBreakpoint({\n     max: 'phablet',\n });\n \n+const shouldUseVariantRules =\n+    config.get('switches.abSpacefinderSimplify', false) &&","path":"static/src/javascripts/projects/commercial/modules/article-body-adverts.js","position":18,"original_position":18,"commit_id":"8a26c1fd7f1c44d1b2b6f9e4fd61b90768e807e1","original_commit_id":"8a26c1fd7f1c44d1b2b6f9e4fd61b90768e807e1","user":{"login":"JonNorman","id":1821099,"avatar_url":"https://avatars2.githubusercontent.com/u/1821099?v=4","gravatar_id":"","url":"https://api.github.com/users/JonNorman","html_url":"https://github.com/JonNorman","followers_url":"https://api.github.com/users/JonNorman/followers","following_url":"https://api.github.com/users/JonNorman/following{/other_user}","gists_url":"https://api.github.com/users/JonNorman/gists{/gist_id}","starred_url":"https://api.github.com/users/JonNorman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonNorman/subscriptions","organizations_url":"https://api.github.com/users/JonNorman/orgs","repos_url":"https://api.github.com/users/JonNorman/repos","events_url":"https://api.github.com/users/JonNorman/events{/privacy}","received_events_url":"https://api.github.com/users/JonNorman/received_events","type":"User","site_admin":false},"body":"Yep, much better.","created_at":"2018-03-06T13:59:12Z","updated_at":"2018-03-06T13:59:12Z","html_url":"https://github.com/guardian/frontend/pull/19278#discussion_r172523086","pull_request_url":"https://api.github.com/repos/guardian/frontend/pulls/19278","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/172523086"},"html":{"href":"https://github.com/guardian/frontend/pull/19278#discussion_r172523086"},"pull_request":{"href":"https://api.github.com/repos/guardian/frontend/pulls/19278"}},"in_reply_to_id":172518255},"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/19278","id":172932853,"html_url":"https://github.com/guardian/frontend/pull/19278","diff_url":"https://github.com/guardian/frontend/pull/19278.diff","patch_url":"https://github.com/guardian/frontend/pull/19278.patch","issue_url":"https://api.github.com/repos/guardian/frontend/issues/19278","number":19278,"state":"open","locked":false,"title":"Spacefinder test","user":{"login":"JonNorman","id":1821099,"avatar_url":"https://avatars2.githubusercontent.com/u/1821099?v=4","gravatar_id":"","url":"https://api.github.com/users/JonNorman","html_url":"https://github.com/JonNorman","followers_url":"https://api.github.com/users/JonNorman/followers","following_url":"https://api.github.com/users/JonNorman/following{/other_user}","gists_url":"https://api.github.com/users/JonNorman/gists{/gist_id}","starred_url":"https://api.github.com/users/JonNorman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonNorman/subscriptions","organizations_url":"https://api.github.com/users/JonNorman/orgs","repos_url":"https://api.github.com/users/JonNorman/repos","events_url":"https://api.github.com/users/JonNorman/events{/privacy}","received_events_url":"https://api.github.com/users/JonNorman/received_events","type":"User","site_admin":false},"body":"## What does this change?\r\nThis is an AB test that seeks to measure the result of removing constraints on inline adverts on desktop. Since these always appear in the righthand column, we don't really care about other elements in the body e.g. headings.\r\n\r\n## What is the value of this and can you measure success?\r\nWe will see whether this does indeed result in a material increase in advert impressions and whether there are any issues with more adverts in the righthand column.","created_at":"2018-03-05T17:22:49Z","updated_at":"2018-03-06T13:59:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"954e81d9a6b93b17f6f9f9ceff1e37290f9c0c9f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/guardian/frontend/pulls/19278/commits","review_comments_url":"https://api.github.com/repos/guardian/frontend/pulls/19278/comments","review_comment_url":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/19278/comments","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/8a26c1fd7f1c44d1b2b6f9e4fd61b90768e807e1","head":{"label":"guardian:jn-spacefinder-test","ref":"jn-spacefinder-test","sha":"8a26c1fd7f1c44d1b2b6f9e4fd61b90768e807e1","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2018-03-06T04:33:49Z","pushed_at":"2018-03-06T13:58:22Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"https://www.theguardian.com","size":579913,"stargazers_count":3821,"watchers_count":3821,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":405,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":405,"open_issues":48,"watchers":3821,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"e51bc454bc693a03d733e039903393276ceef4da","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2018-03-06T04:33:49Z","pushed_at":"2018-03-06T13:58:22Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"https://www.theguardian.com","size":579913,"stargazers_count":3821,"watchers_count":3821,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":405,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":405,"open_issues":48,"watchers":3821,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/19278"},"html":{"href":"https://github.com/guardian/frontend/pull/19278"},"issue":{"href":"https://api.github.com/repos/guardian/frontend/issues/19278"},"comments":{"href":"https://api.github.com/repos/guardian/frontend/issues/19278/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/frontend/pulls/19278/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/frontend/pulls/19278/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/frontend/statuses/8a26c1fd7f1c44d1b2b6f9e4fd61b90768e807e1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"JonNorman"}}