{"action":"created","comment":{"url":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/comments/220928740","pull_request_review_id":159452745,"id":220928740,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDkyODc0MA==","diff_hunk":"@@ -18,6 +18,59 @@ describe(`JavaScript page creator`, () => {\n     expect(files.filter(file => validatePath(file.path)).length).toEqual(1)\n   })\n \n+  it(`filters out files that start with dot`, () => {\n+    const files = [\n+      {\n+        path: `.eslintrc`,\n+      },\n+      {\n+        path: `something/.eslintrc`,\n+      },\n+      {\n+        path: `something/.eslintrc.js`,\n+      },\n+      {\n+        path: `something/blah.js`,\n+      },\n+      {\n+        path: `.markdownlint.json`,\n+      },\n+      {\n+        path: `something/.markdownlint.json`,\n+      },\n+    ]\n+\n+    expect(files.filter(file => validatePath(file.path)).length).toEqual(1)","path":"packages/gatsby-plugin-page-creator/src/__tests__/gatsby-node.js","position":26,"original_position":26,"commit_id":"cc6991a823ba1b347da2f7b165f3061f41830e24","original_commit_id":"cc6991a823ba1b347da2f7b165f3061f41830e24","user":{"login":"DSchau","id":3924690,"node_id":"MDQ6VXNlcjM5MjQ2OTA=","avatar_url":"https://avatars2.githubusercontent.com/u/3924690?v=4","gravatar_id":"","url":"https://api.github.com/users/DSchau","html_url":"https://github.com/DSchau","followers_url":"https://api.github.com/users/DSchau/followers","following_url":"https://api.github.com/users/DSchau/following{/other_user}","gists_url":"https://api.github.com/users/DSchau/gists{/gist_id}","starred_url":"https://api.github.com/users/DSchau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DSchau/subscriptions","organizations_url":"https://api.github.com/users/DSchau/orgs","repos_url":"https://api.github.com/users/DSchau/repos","events_url":"https://api.github.com/users/DSchau/events{/privacy}","received_events_url":"https://api.github.com/users/DSchau/received_events","type":"User","site_admin":false},"body":"nit: but I'd probably just remove the `something/blah.js` and validate that the array length is `0`. _Then_ test the explicit .js inclusion in a separate test?","created_at":"2018-09-27T13:45:34Z","updated_at":"2018-09-27T13:45:35Z","html_url":"https://github.com/gatsbyjs/gatsby/pull/8573#discussion_r220928740","pull_request_url":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/8573","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/comments/220928740"},"html":{"href":"https://github.com/gatsbyjs/gatsby/pull/8573#discussion_r220928740"},"pull_request":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/8573"}}},"pull_request":{"url":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/8573","id":218498404,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NDk4NDA0","html_url":"https://github.com/gatsbyjs/gatsby/pull/8573","diff_url":"https://github.com/gatsbyjs/gatsby/pull/8573.diff","patch_url":"https://github.com/gatsbyjs/gatsby/pull/8573.patch","issue_url":"https://api.github.com/repos/gatsbyjs/gatsby/issues/8573","number":8573,"state":"open","locked":false,"title":"fix: ignore dot files in page creator plugin.","user":{"login":"mikelax","id":2080701,"node_id":"MDQ6VXNlcjIwODA3MDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2080701?v=4","gravatar_id":"","url":"https://api.github.com/users/mikelax","html_url":"https://github.com/mikelax","followers_url":"https://api.github.com/users/mikelax/followers","following_url":"https://api.github.com/users/mikelax/following{/other_user}","gists_url":"https://api.github.com/users/mikelax/gists{/gist_id}","starred_url":"https://api.github.com/users/mikelax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikelax/subscriptions","organizations_url":"https://api.github.com/users/mikelax/orgs","repos_url":"https://api.github.com/users/mikelax/repos","events_url":"https://api.github.com/users/mikelax/events{/privacy}","received_events_url":"https://api.github.com/users/mikelax/received_events","type":"User","site_admin":false},"body":"Closes #8474 \r\n\r\nRefactor the page creator plugin to ignore \"dot\" files. ","created_at":"2018-09-27T01:24:08Z","updated_at":"2018-09-27T13:45:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8ca4bbdaac38636bb79d7bcfa32146d0cb0b213","assignee":{"login":"mikelax","id":2080701,"node_id":"MDQ6VXNlcjIwODA3MDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2080701?v=4","gravatar_id":"","url":"https://api.github.com/users/mikelax","html_url":"https://github.com/mikelax","followers_url":"https://api.github.com/users/mikelax/followers","following_url":"https://api.github.com/users/mikelax/following{/other_user}","gists_url":"https://api.github.com/users/mikelax/gists{/gist_id}","starred_url":"https://api.github.com/users/mikelax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikelax/subscriptions","organizations_url":"https://api.github.com/users/mikelax/orgs","repos_url":"https://api.github.com/users/mikelax/repos","events_url":"https://api.github.com/users/mikelax/events{/privacy}","received_events_url":"https://api.github.com/users/mikelax/received_events","type":"User","site_admin":false},"assignees":[{"login":"mikelax","id":2080701,"node_id":"MDQ6VXNlcjIwODA3MDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2080701?v=4","gravatar_id":"","url":"https://api.github.com/users/mikelax","html_url":"https://github.com/mikelax","followers_url":"https://api.github.com/users/mikelax/followers","following_url":"https://api.github.com/users/mikelax/following{/other_user}","gists_url":"https://api.github.com/users/mikelax/gists{/gist_id}","starred_url":"https://api.github.com/users/mikelax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikelax/subscriptions","organizations_url":"https://api.github.com/users/mikelax/orgs","repos_url":"https://api.github.com/users/mikelax/repos","events_url":"https://api.github.com/users/mikelax/events{/privacy}","received_events_url":"https://api.github.com/users/mikelax/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/8573/commits","review_comments_url":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/8573/comments","review_comment_url":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gatsbyjs/gatsby/issues/8573/comments","statuses_url":"https://api.github.com/repos/gatsbyjs/gatsby/statuses/cc6991a823ba1b347da2f7b165f3061f41830e24","head":{"label":"mikelax:topics/8474-ignoredotfiles","ref":"topics/8474-ignoredotfiles","sha":"cc6991a823ba1b347da2f7b165f3061f41830e24","user":{"login":"mikelax","id":2080701,"node_id":"MDQ6VXNlcjIwODA3MDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2080701?v=4","gravatar_id":"","url":"https://api.github.com/users/mikelax","html_url":"https://github.com/mikelax","followers_url":"https://api.github.com/users/mikelax/followers","following_url":"https://api.github.com/users/mikelax/following{/other_user}","gists_url":"https://api.github.com/users/mikelax/gists{/gist_id}","starred_url":"https://api.github.com/users/mikelax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikelax/subscriptions","organizations_url":"https://api.github.com/users/mikelax/orgs","repos_url":"https://api.github.com/users/mikelax/repos","events_url":"https://api.github.com/users/mikelax/events{/privacy}","received_events_url":"https://api.github.com/users/mikelax/received_events","type":"User","site_admin":false},"repo":{"id":146884424,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY4ODQ0MjQ=","name":"gatsby","full_name":"mikelax/gatsby","private":false,"owner":{"login":"mikelax","id":2080701,"node_id":"MDQ6VXNlcjIwODA3MDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2080701?v=4","gravatar_id":"","url":"https://api.github.com/users/mikelax","html_url":"https://github.com/mikelax","followers_url":"https://api.github.com/users/mikelax/followers","following_url":"https://api.github.com/users/mikelax/following{/other_user}","gists_url":"https://api.github.com/users/mikelax/gists{/gist_id}","starred_url":"https://api.github.com/users/mikelax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikelax/subscriptions","organizations_url":"https://api.github.com/users/mikelax/orgs","repos_url":"https://api.github.com/users/mikelax/repos","events_url":"https://api.github.com/users/mikelax/events{/privacy}","received_events_url":"https://api.github.com/users/mikelax/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mikelax/gatsby","description":"⚛️📄🚀 Blazing fast site generator for React","fork":true,"url":"https://api.github.com/repos/mikelax/gatsby","forks_url":"https://api.github.com/repos/mikelax/gatsby/forks","keys_url":"https://api.github.com/repos/mikelax/gatsby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikelax/gatsby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikelax/gatsby/teams","hooks_url":"https://api.github.com/repos/mikelax/gatsby/hooks","issue_events_url":"https://api.github.com/repos/mikelax/gatsby/issues/events{/number}","events_url":"https://api.github.com/repos/mikelax/gatsby/events","assignees_url":"https://api.github.com/repos/mikelax/gatsby/assignees{/user}","branches_url":"https://api.github.com/repos/mikelax/gatsby/branches{/branch}","tags_url":"https://api.github.com/repos/mikelax/gatsby/tags","blobs_url":"https://api.github.com/repos/mikelax/gatsby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikelax/gatsby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikelax/gatsby/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikelax/gatsby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikelax/gatsby/statuses/{sha}","languages_url":"https://api.github.com/repos/mikelax/gatsby/languages","stargazers_url":"https://api.github.com/repos/mikelax/gatsby/stargazers","contributors_url":"https://api.github.com/repos/mikelax/gatsby/contributors","subscribers_url":"https://api.github.com/repos/mikelax/gatsby/subscribers","subscription_url":"https://api.github.com/repos/mikelax/gatsby/subscription","commits_url":"https://api.github.com/repos/mikelax/gatsby/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikelax/gatsby/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikelax/gatsby/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikelax/gatsby/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikelax/gatsby/contents/{+path}","compare_url":"https://api.github.com/repos/mikelax/gatsby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikelax/gatsby/merges","archive_url":"https://api.github.com/repos/mikelax/gatsby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikelax/gatsby/downloads","issues_url":"https://api.github.com/repos/mikelax/gatsby/issues{/number}","pulls_url":"https://api.github.com/repos/mikelax/gatsby/pulls{/number}","milestones_url":"https://api.github.com/repos/mikelax/gatsby/milestones{/number}","notifications_url":"https://api.github.com/repos/mikelax/gatsby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikelax/gatsby/labels{/name}","releases_url":"https://api.github.com/repos/mikelax/gatsby/releases{/id}","deployments_url":"https://api.github.com/repos/mikelax/gatsby/deployments","created_at":"2018-08-31T11:40:31Z","updated_at":"2018-09-26T13:42:40Z","pushed_at":"2018-09-27T12:19:19Z","git_url":"git://github.com/mikelax/gatsby.git","ssh_url":"git@github.com:mikelax/gatsby.git","clone_url":"https://github.com/mikelax/gatsby.git","svn_url":"https://github.com/mikelax/gatsby","homepage":"https://www.gatsbyjs.org","size":428992,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gatsbyjs:master","ref":"master","sha":"c392d26e87c6eaa44f3a729dabd29ad4d4d96468","user":{"login":"gatsbyjs","id":12551863,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTUxODYz","avatar_url":"https://avatars1.githubusercontent.com/u/12551863?v=4","gravatar_id":"","url":"https://api.github.com/users/gatsbyjs","html_url":"https://github.com/gatsbyjs","followers_url":"https://api.github.com/users/gatsbyjs/followers","following_url":"https://api.github.com/users/gatsbyjs/following{/other_user}","gists_url":"https://api.github.com/users/gatsbyjs/gists{/gist_id}","starred_url":"https://api.github.com/users/gatsbyjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gatsbyjs/subscriptions","organizations_url":"https://api.github.com/users/gatsbyjs/orgs","repos_url":"https://api.github.com/users/gatsbyjs/repos","events_url":"https://api.github.com/users/gatsbyjs/events{/privacy}","received_events_url":"https://api.github.com/users/gatsbyjs/received_events","type":"Organization","site_admin":false},"repo":{"id":36040894,"node_id":"MDEwOlJlcG9zaXRvcnkzNjA0MDg5NA==","name":"gatsby","full_name":"gatsbyjs/gatsby","private":false,"owner":{"login":"gatsbyjs","id":12551863,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTUxODYz","avatar_url":"https://avatars1.githubusercontent.com/u/12551863?v=4","gravatar_id":"","url":"https://api.github.com/users/gatsbyjs","html_url":"https://github.com/gatsbyjs","followers_url":"https://api.github.com/users/gatsbyjs/followers","following_url":"https://api.github.com/users/gatsbyjs/following{/other_user}","gists_url":"https://api.github.com/users/gatsbyjs/gists{/gist_id}","starred_url":"https://api.github.com/users/gatsbyjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gatsbyjs/subscriptions","organizations_url":"https://api.github.com/users/gatsbyjs/orgs","repos_url":"https://api.github.com/users/gatsbyjs/repos","events_url":"https://api.github.com/users/gatsbyjs/events{/privacy}","received_events_url":"https://api.github.com/users/gatsbyjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gatsbyjs/gatsby","description":"Build blazing fast, modern apps and websites with React","fork":false,"url":"https://api.github.com/repos/gatsbyjs/gatsby","forks_url":"https://api.github.com/repos/gatsbyjs/gatsby/forks","keys_url":"https://api.github.com/repos/gatsbyjs/gatsby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gatsbyjs/gatsby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gatsbyjs/gatsby/teams","hooks_url":"https://api.github.com/repos/gatsbyjs/gatsby/hooks","issue_events_url":"https://api.github.com/repos/gatsbyjs/gatsby/issues/events{/number}","events_url":"https://api.github.com/repos/gatsbyjs/gatsby/events","assignees_url":"https://api.github.com/repos/gatsbyjs/gatsby/assignees{/user}","branches_url":"https://api.github.com/repos/gatsbyjs/gatsby/branches{/branch}","tags_url":"https://api.github.com/repos/gatsbyjs/gatsby/tags","blobs_url":"https://api.github.com/repos/gatsbyjs/gatsby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gatsbyjs/gatsby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gatsbyjs/gatsby/git/refs{/sha}","trees_url":"https://api.github.com/repos/gatsbyjs/gatsby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gatsbyjs/gatsby/statuses/{sha}","languages_url":"https://api.github.com/repos/gatsbyjs/gatsby/languages","stargazers_url":"https://api.github.com/repos/gatsbyjs/gatsby/stargazers","contributors_url":"https://api.github.com/repos/gatsbyjs/gatsby/contributors","subscribers_url":"https://api.github.com/repos/gatsbyjs/gatsby/subscribers","subscription_url":"https://api.github.com/repos/gatsbyjs/gatsby/subscription","commits_url":"https://api.github.com/repos/gatsbyjs/gatsby/commits{/sha}","git_commits_url":"https://api.github.com/repos/gatsbyjs/gatsby/git/commits{/sha}","comments_url":"https://api.github.com/repos/gatsbyjs/gatsby/comments{/number}","issue_comment_url":"https://api.github.com/repos/gatsbyjs/gatsby/issues/comments{/number}","contents_url":"https://api.github.com/repos/gatsbyjs/gatsby/contents/{+path}","compare_url":"https://api.github.com/repos/gatsbyjs/gatsby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gatsbyjs/gatsby/merges","archive_url":"https://api.github.com/repos/gatsbyjs/gatsby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gatsbyjs/gatsby/downloads","issues_url":"https://api.github.com/repos/gatsbyjs/gatsby/issues{/number}","pulls_url":"https://api.github.com/repos/gatsbyjs/gatsby/pulls{/number}","milestones_url":"https://api.github.com/repos/gatsbyjs/gatsby/milestones{/number}","notifications_url":"https://api.github.com/repos/gatsbyjs/gatsby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gatsbyjs/gatsby/labels{/name}","releases_url":"https://api.github.com/repos/gatsbyjs/gatsby/releases{/id}","deployments_url":"https://api.github.com/repos/gatsbyjs/gatsby/deployments","created_at":"2015-05-21T22:43:05Z","updated_at":"2018-09-27T13:22:54Z","pushed_at":"2018-09-27T12:33:43Z","git_url":"git://github.com/gatsbyjs/gatsby.git","ssh_url":"git@github.com:gatsbyjs/gatsby.git","clone_url":"https://github.com/gatsbyjs/gatsby.git","svn_url":"https://github.com/gatsbyjs/gatsby","homepage":"https://www.gatsbyjs.org","size":428434,"stargazers_count":26017,"watchers_count":26017,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2964,"mirror_url":null,"archived":false,"open_issues_count":699,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2964,"open_issues":699,"watchers":26017,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/8573"},"html":{"href":"https://github.com/gatsbyjs/gatsby/pull/8573"},"issue":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/issues/8573"},"comments":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/issues/8573/comments"},"review_comments":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/8573/comments"},"review_comment":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/8573/commits"},"statuses":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/statuses/cc6991a823ba1b347da2f7b165f3061f41830e24"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"DSchau"}}