{"action":"closed","number":94,"pull_request":{"url":"https://api.github.com/repos/Devex/spaceflight/pulls/94","id":180549893,"html_url":"https://github.com/Devex/spaceflight/pull/94","diff_url":"https://github.com/Devex/spaceflight/pull/94.diff","patch_url":"https://github.com/Devex/spaceflight/pull/94.patch","issue_url":"https://api.github.com/repos/Devex/spaceflight/issues/94","number":94,"state":"closed","locked":false,"title":"DVX-6600 Create Prometheus exporter for DNSBL","user":{"login":"miguelbernadi","id":731219,"avatar_url":"https://avatars0.githubusercontent.com/u/731219?v=4","gravatar_id":"","url":"https://api.github.com/users/miguelbernadi","html_url":"https://github.com/miguelbernadi","followers_url":"https://api.github.com/users/miguelbernadi/followers","following_url":"https://api.github.com/users/miguelbernadi/following{/other_user}","gists_url":"https://api.github.com/users/miguelbernadi/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelbernadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelbernadi/subscriptions","organizations_url":"https://api.github.com/users/miguelbernadi/orgs","repos_url":"https://api.github.com/users/miguelbernadi/repos","events_url":"https://api.github.com/users/miguelbernadi/events{/privacy}","received_events_url":"https://api.github.com/users/miguelbernadi/received_events","type":"User","site_admin":false},"body":"This creates a devex_exporter that provides DNS blacklist metrics used to verify if a certain IP is considered a source of spam. The exporter should be extensible to include other providers as well in the future.\r\n\r\nThere are some minor changes to the interface of `dnsbl` to make it more similar to the design of the Collector. This should allow to create a common resource for both `Checker` and `Collector` to reuse logic and tests were possible.\r\n\r\n~It's still work In Progress as there's a potential race condition on startup I'm still researching~.\r\n\r\n**DVX-6600 Move common functions to its own file**\r\nAnd also move its tests.\r\n\r\n**DVX-6600 Split provider generation from query**\r\nExtract the generation of provider addresses from the Query function\r\nso it can be reused.\r\n\r\n**DVX-6600 Add devex_exporter using dnsbl.Collector**\r\n`dnsbl.Collector` is a Prometheus Collector compliant struct based off\r\nthe `dnsbl.Checker` to collect all dnsbl metrics.\r\n\r\n`devex_exporter` is a Prometheus exporter that exposes\r\n`dnsbl.Collector` metrics for scraping. It's intended to be extended\r\nto provide other package metrics as well in the future.\r\n\r\n**DVX-6600 Improve signature for internal helpers**\r\nMake `reverse` return a copy of the slice instead of modifying it in\r\nplace. This allows for method chaining in `reverseAddress`.\r\n\r\nThere is no need for a named return value in\r\n`reverseAddress`. Removing it shortens the function a bit and makes it clearer.","created_at":"2018-04-10T10:01:37Z","updated_at":"2018-04-10T11:18:12Z","closed_at":"2018-04-10T11:18:12Z","merged_at":"2018-04-10T11:18:12Z","merge_commit_sha":"a79716691c4c2a6c846ea4d75b16783bba05653e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Devex/spaceflight/pulls/94/commits","review_comments_url":"https://api.github.com/repos/Devex/spaceflight/pulls/94/comments","review_comment_url":"https://api.github.com/repos/Devex/spaceflight/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Devex/spaceflight/issues/94/comments","statuses_url":"https://api.github.com/repos/Devex/spaceflight/statuses/d952d844f292439f2f96fc7b36ce052d6eef268e","head":{"label":"miguelbernadi:DVX-6600","ref":"DVX-6600","sha":"d952d844f292439f2f96fc7b36ce052d6eef268e","user":{"login":"miguelbernadi","id":731219,"avatar_url":"https://avatars0.githubusercontent.com/u/731219?v=4","gravatar_id":"","url":"https://api.github.com/users/miguelbernadi","html_url":"https://github.com/miguelbernadi","followers_url":"https://api.github.com/users/miguelbernadi/followers","following_url":"https://api.github.com/users/miguelbernadi/following{/other_user}","gists_url":"https://api.github.com/users/miguelbernadi/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelbernadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelbernadi/subscriptions","organizations_url":"https://api.github.com/users/miguelbernadi/orgs","repos_url":"https://api.github.com/users/miguelbernadi/repos","events_url":"https://api.github.com/users/miguelbernadi/events{/privacy}","received_events_url":"https://api.github.com/users/miguelbernadi/received_events","type":"User","site_admin":false},"repo":{"id":91497828,"name":"spaceflight","full_name":"miguelbernadi/spaceflight","owner":{"login":"miguelbernadi","id":731219,"avatar_url":"https://avatars0.githubusercontent.com/u/731219?v=4","gravatar_id":"","url":"https://api.github.com/users/miguelbernadi","html_url":"https://github.com/miguelbernadi","followers_url":"https://api.github.com/users/miguelbernadi/followers","following_url":"https://api.github.com/users/miguelbernadi/following{/other_user}","gists_url":"https://api.github.com/users/miguelbernadi/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelbernadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelbernadi/subscriptions","organizations_url":"https://api.github.com/users/miguelbernadi/orgs","repos_url":"https://api.github.com/users/miguelbernadi/repos","events_url":"https://api.github.com/users/miguelbernadi/events{/privacy}","received_events_url":"https://api.github.com/users/miguelbernadi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miguelbernadi/spaceflight","description":null,"fork":true,"url":"https://api.github.com/repos/miguelbernadi/spaceflight","forks_url":"https://api.github.com/repos/miguelbernadi/spaceflight/forks","keys_url":"https://api.github.com/repos/miguelbernadi/spaceflight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miguelbernadi/spaceflight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miguelbernadi/spaceflight/teams","hooks_url":"https://api.github.com/repos/miguelbernadi/spaceflight/hooks","issue_events_url":"https://api.github.com/repos/miguelbernadi/spaceflight/issues/events{/number}","events_url":"https://api.github.com/repos/miguelbernadi/spaceflight/events","assignees_url":"https://api.github.com/repos/miguelbernadi/spaceflight/assignees{/user}","branches_url":"https://api.github.com/repos/miguelbernadi/spaceflight/branches{/branch}","tags_url":"https://api.github.com/repos/miguelbernadi/spaceflight/tags","blobs_url":"https://api.github.com/repos/miguelbernadi/spaceflight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miguelbernadi/spaceflight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miguelbernadi/spaceflight/git/refs{/sha}","trees_url":"https://api.github.com/repos/miguelbernadi/spaceflight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miguelbernadi/spaceflight/statuses/{sha}","languages_url":"https://api.github.com/repos/miguelbernadi/spaceflight/languages","stargazers_url":"https://api.github.com/repos/miguelbernadi/spaceflight/stargazers","contributors_url":"https://api.github.com/repos/miguelbernadi/spaceflight/contributors","subscribers_url":"https://api.github.com/repos/miguelbernadi/spaceflight/subscribers","subscription_url":"https://api.github.com/repos/miguelbernadi/spaceflight/subscription","commits_url":"https://api.github.com/repos/miguelbernadi/spaceflight/commits{/sha}","git_commits_url":"https://api.github.com/repos/miguelbernadi/spaceflight/git/commits{/sha}","comments_url":"https://api.github.com/repos/miguelbernadi/spaceflight/comments{/number}","issue_comment_url":"https://api.github.com/repos/miguelbernadi/spaceflight/issues/comments{/number}","contents_url":"https://api.github.com/repos/miguelbernadi/spaceflight/contents/{+path}","compare_url":"https://api.github.com/repos/miguelbernadi/spaceflight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miguelbernadi/spaceflight/merges","archive_url":"https://api.github.com/repos/miguelbernadi/spaceflight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miguelbernadi/spaceflight/downloads","issues_url":"https://api.github.com/repos/miguelbernadi/spaceflight/issues{/number}","pulls_url":"https://api.github.com/repos/miguelbernadi/spaceflight/pulls{/number}","milestones_url":"https://api.github.com/repos/miguelbernadi/spaceflight/milestones{/number}","notifications_url":"https://api.github.com/repos/miguelbernadi/spaceflight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miguelbernadi/spaceflight/labels{/name}","releases_url":"https://api.github.com/repos/miguelbernadi/spaceflight/releases{/id}","deployments_url":"https://api.github.com/repos/miguelbernadi/spaceflight/deployments","created_at":"2017-05-16T19:44:38Z","updated_at":"2017-05-16T19:44:39Z","pushed_at":"2018-04-10T10:13:04Z","git_url":"git://github.com/miguelbernadi/spaceflight.git","ssh_url":"git@github.com:miguelbernadi/spaceflight.git","clone_url":"https://github.com/miguelbernadi/spaceflight.git","svn_url":"https://github.com/miguelbernadi/spaceflight","homepage":null,"size":430,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"Devex:develop","ref":"develop","sha":"35d60247be9eccff4d810136a6fa3249d8065375","user":{"login":"Devex","id":3806616,"avatar_url":"https://avatars2.githubusercontent.com/u/3806616?v=4","gravatar_id":"","url":"https://api.github.com/users/Devex","html_url":"https://github.com/Devex","followers_url":"https://api.github.com/users/Devex/followers","following_url":"https://api.github.com/users/Devex/following{/other_user}","gists_url":"https://api.github.com/users/Devex/gists{/gist_id}","starred_url":"https://api.github.com/users/Devex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Devex/subscriptions","organizations_url":"https://api.github.com/users/Devex/orgs","repos_url":"https://api.github.com/users/Devex/repos","events_url":"https://api.github.com/users/Devex/events{/privacy}","received_events_url":"https://api.github.com/users/Devex/received_events","type":"Organization","site_admin":false},"repo":{"id":76343664,"name":"spaceflight","full_name":"Devex/spaceflight","owner":{"login":"Devex","id":3806616,"avatar_url":"https://avatars2.githubusercontent.com/u/3806616?v=4","gravatar_id":"","url":"https://api.github.com/users/Devex","html_url":"https://github.com/Devex","followers_url":"https://api.github.com/users/Devex/followers","following_url":"https://api.github.com/users/Devex/following{/other_user}","gists_url":"https://api.github.com/users/Devex/gists{/gist_id}","starred_url":"https://api.github.com/users/Devex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Devex/subscriptions","organizations_url":"https://api.github.com/users/Devex/orgs","repos_url":"https://api.github.com/users/Devex/repos","events_url":"https://api.github.com/users/Devex/events{/privacy}","received_events_url":"https://api.github.com/users/Devex/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Devex/spaceflight","description":"Toolbox for orchestrating infrastructure in 3rd party cloud providers.","fork":true,"url":"https://api.github.com/repos/Devex/spaceflight","forks_url":"https://api.github.com/repos/Devex/spaceflight/forks","keys_url":"https://api.github.com/repos/Devex/spaceflight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Devex/spaceflight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Devex/spaceflight/teams","hooks_url":"https://api.github.com/repos/Devex/spaceflight/hooks","issue_events_url":"https://api.github.com/repos/Devex/spaceflight/issues/events{/number}","events_url":"https://api.github.com/repos/Devex/spaceflight/events","assignees_url":"https://api.github.com/repos/Devex/spaceflight/assignees{/user}","branches_url":"https://api.github.com/repos/Devex/spaceflight/branches{/branch}","tags_url":"https://api.github.com/repos/Devex/spaceflight/tags","blobs_url":"https://api.github.com/repos/Devex/spaceflight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Devex/spaceflight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Devex/spaceflight/git/refs{/sha}","trees_url":"https://api.github.com/repos/Devex/spaceflight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Devex/spaceflight/statuses/{sha}","languages_url":"https://api.github.com/repos/Devex/spaceflight/languages","stargazers_url":"https://api.github.com/repos/Devex/spaceflight/stargazers","contributors_url":"https://api.github.com/repos/Devex/spaceflight/contributors","subscribers_url":"https://api.github.com/repos/Devex/spaceflight/subscribers","subscription_url":"https://api.github.com/repos/Devex/spaceflight/subscription","commits_url":"https://api.github.com/repos/Devex/spaceflight/commits{/sha}","git_commits_url":"https://api.github.com/repos/Devex/spaceflight/git/commits{/sha}","comments_url":"https://api.github.com/repos/Devex/spaceflight/comments{/number}","issue_comment_url":"https://api.github.com/repos/Devex/spaceflight/issues/comments{/number}","contents_url":"https://api.github.com/repos/Devex/spaceflight/contents/{+path}","compare_url":"https://api.github.com/repos/Devex/spaceflight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Devex/spaceflight/merges","archive_url":"https://api.github.com/repos/Devex/spaceflight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Devex/spaceflight/downloads","issues_url":"https://api.github.com/repos/Devex/spaceflight/issues{/number}","pulls_url":"https://api.github.com/repos/Devex/spaceflight/pulls{/number}","milestones_url":"https://api.github.com/repos/Devex/spaceflight/milestones{/number}","notifications_url":"https://api.github.com/repos/Devex/spaceflight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Devex/spaceflight/labels{/name}","releases_url":"https://api.github.com/repos/Devex/spaceflight/releases{/id}","deployments_url":"https://api.github.com/repos/Devex/spaceflight/deployments","created_at":"2016-12-13T09:29:14Z","updated_at":"2017-08-22T08:06:28Z","pushed_at":"2018-04-10T11:18:11Z","git_url":"git://github.com/Devex/spaceflight.git","ssh_url":"git@github.com:Devex/spaceflight.git","clone_url":"https://github.com/Devex/spaceflight.git","svn_url":"https://github.com/Devex/spaceflight","homepage":"","size":411,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Devex/spaceflight/pulls/94"},"html":{"href":"https://github.com/Devex/spaceflight/pull/94"},"issue":{"href":"https://api.github.com/repos/Devex/spaceflight/issues/94"},"comments":{"href":"https://api.github.com/repos/Devex/spaceflight/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/Devex/spaceflight/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/Devex/spaceflight/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Devex/spaceflight/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/Devex/spaceflight/statuses/d952d844f292439f2f96fc7b36ce052d6eef268e"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"devexbot","id":5381017,"avatar_url":"https://avatars1.githubusercontent.com/u/5381017?v=4","gravatar_id":"","url":"https://api.github.com/users/devexbot","html_url":"https://github.com/devexbot","followers_url":"https://api.github.com/users/devexbot/followers","following_url":"https://api.github.com/users/devexbot/following{/other_user}","gists_url":"https://api.github.com/users/devexbot/gists{/gist_id}","starred_url":"https://api.github.com/users/devexbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devexbot/subscriptions","organizations_url":"https://api.github.com/users/devexbot/orgs","repos_url":"https://api.github.com/users/devexbot/repos","events_url":"https://api.github.com/users/devexbot/events{/privacy}","received_events_url":"https://api.github.com/users/devexbot/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":219,"deletions":71,"changed_files":7}}
{"actor":{"display_login":"devexbot"}}