{"action":"created","issue":{"url":"https://api.github.com/repos/neos/neos-development-collection/issues/2200","repository_url":"https://api.github.com/repos/neos/neos-development-collection","labels_url":"https://api.github.com/repos/neos/neos-development-collection/issues/2200/labels{/name}","comments_url":"https://api.github.com/repos/neos/neos-development-collection/issues/2200/comments","events_url":"https://api.github.com/repos/neos/neos-development-collection/issues/2200/events","html_url":"https://github.com/neos/neos-development-collection/pull/2200","id":367292572,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNzY1MzMy","number":2200,"title":"FEATURE: Asset Sources support for Asset Editor","user":{"login":"robertlemke","id":95582,"node_id":"MDQ6VXNlcjk1NTgy","avatar_url":"https://avatars3.githubusercontent.com/u/95582?v=4","gravatar_id":"","url":"https://api.github.com/users/robertlemke","html_url":"https://github.com/robertlemke","followers_url":"https://api.github.com/users/robertlemke/followers","following_url":"https://api.github.com/users/robertlemke/following{/other_user}","gists_url":"https://api.github.com/users/robertlemke/gists{/gist_id}","starred_url":"https://api.github.com/users/robertlemke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertlemke/subscriptions","organizations_url":"https://api.github.com/users/robertlemke/orgs","repos_url":"https://api.github.com/users/robertlemke/repos","events_url":"https://api.github.com/users/robertlemke/events{/privacy}","received_events_url":"https://api.github.com/users/robertlemke/received_events","type":"User","site_admin":false},"labels":[{"id":588869222,"node_id":"MDU6TGFiZWw1ODg4NjkyMjI=","url":"https://api.github.com/repos/neos/neos-development-collection/labels/Feature","name":"Feature","color":"5319e7","default":false},{"id":274939453,"node_id":"MDU6TGFiZWwyNzQ5Mzk0NTM=","url":"https://api.github.com/repos/neos/neos-development-collection/labels/P:%20Media","name":"P: Media","color":"0052cc","default":false},{"id":274939417,"node_id":"MDU6TGFiZWwyNzQ5Mzk0MTc=","url":"https://api.github.com/repos/neos/neos-development-collection/labels/P:%20Neos","name":"P: Neos","color":"0052cc","default":false},{"id":274941070,"node_id":"MDU6TGFiZWwyNzQ5NDEwNzA=","url":"https://api.github.com/repos/neos/neos-development-collection/labels/T:%20PHP","name":"T: PHP","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2018-10-05T16:59:23Z","updated_at":"2018-10-15T06:58:35Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/neos/neos-development-collection/pulls/2200","html_url":"https://github.com/neos/neos-development-collection/pull/2200","diff_url":"https://github.com/neos/neos-development-collection/pull/2200.diff","patch_url":"https://github.com/neos/neos-development-collection/pull/2200.patch"},"body":"This change introduces the necessary backend code for enabling the Asset Editor (in the user interface's inspector panel) to use asset sources. A user can now search for assets which are stored in asset sources and import them on the fly.\r\n\r\nResolves #2198 "},"comment":{"url":"https://api.github.com/repos/neos/neos-development-collection/issues/comments/429729724","html_url":"https://github.com/neos/neos-development-collection/pull/2200#issuecomment-429729724","issue_url":"https://api.github.com/repos/neos/neos-development-collection/issues/2200","id":429729724,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTcyOTcyNA==","user":{"login":"bwaidelich","id":307571,"node_id":"MDQ6VXNlcjMwNzU3MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/307571?v=4","gravatar_id":"","url":"https://api.github.com/users/bwaidelich","html_url":"https://github.com/bwaidelich","followers_url":"https://api.github.com/users/bwaidelich/followers","following_url":"https://api.github.com/users/bwaidelich/following{/other_user}","gists_url":"https://api.github.com/users/bwaidelich/gists{/gist_id}","starred_url":"https://api.github.com/users/bwaidelich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwaidelich/subscriptions","organizations_url":"https://api.github.com/users/bwaidelich/orgs","repos_url":"https://api.github.com/users/bwaidelich/repos","events_url":"https://api.github.com/users/bwaidelich/events{/privacy}","received_events_url":"https://api.github.com/users/bwaidelich/received_events","type":"User","site_admin":false},"created_at":"2018-10-15T06:58:35Z","updated_at":"2018-10-15T06:58:35Z","author_association":"MEMBER","body":"In my opinion the two questions interact a little:\r\nI think it's totally fine to adjust this in subsequent PRs but if we want to have this in released branches (which I definitely do) we should maybe at least add that \"assetSources\" backend option so that the 3rd party lookup can be \"disabled\" if needed. The endpoint already supports this (partly: it only allows one `$assetSourceIdentifier`  and this should support arrays IMO) so it's \"only\" a matter of forwarding that option in the component request.\r\n\r\n@daniellienert what is your opinion?"}}
{"actor":{"display_login":"bwaidelich"}}