{"action":"created","issue":{"url":"https://api.github.com/repos/SublimeLinter/SublimeLinter/issues/934","repository_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter","labels_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter/issues/934/labels{/name}","comments_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter/issues/934/comments","events_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter/issues/934/events","html_url":"https://github.com/SublimeLinter/SublimeLinter/pull/934","id":293946102,"number":934,"title":"remove bid from errors when closing its last view","user":{"login":"braver","id":2543659,"avatar_url":"https://avatars1.githubusercontent.com/u/2543659?v=4","gravatar_id":"","url":"https://api.github.com/users/braver","html_url":"https://github.com/braver","followers_url":"https://api.github.com/users/braver/followers","following_url":"https://api.github.com/users/braver/following{/other_user}","gists_url":"https://api.github.com/users/braver/gists{/gist_id}","starred_url":"https://api.github.com/users/braver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/braver/subscriptions","organizations_url":"https://api.github.com/users/braver/orgs","repos_url":"https://api.github.com/users/braver/repos","events_url":"https://api.github.com/users/braver/events{/privacy}","received_events_url":"https://api.github.com/users/braver/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-02-02T16:29:55Z","updated_at":"2018-02-02T21:06:12Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/SublimeLinter/SublimeLinter/pulls/934","html_url":"https://github.com/SublimeLinter/SublimeLinter/pull/934","diff_url":"https://github.com/SublimeLinter/SublimeLinter/pull/934.diff","patch_url":"https://github.com/SublimeLinter/SublimeLinter/pull/934.patch"},"body":"`sublime.windows()` and `window.views()` always return lists, we can iterate over them to find all buffer_ids. If the view to be closed is attached to exactly 1 buffer, we also remove that buffer from `persist.errors`.\r\n\r\nThis seems to work correctly, but I see some bids in `persist.errors` that I don't have views for. They seem to be created when I open e.g. the find panel. Can it be that we create entries in `persist.errors` for such buffers? I couldn't find out if we did. \r\n\r\nWe also have the a nuclear option of wiping out `persist.errors` completely if no views remain...\r\n\r\n----\r\n\r\nfixes #900"},"comment":{"url":"https://api.github.com/repos/SublimeLinter/SublimeLinter/issues/comments/362707396","html_url":"https://github.com/SublimeLinter/SublimeLinter/pull/934#issuecomment-362707396","issue_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter/issues/934","id":362707396,"user":{"login":"braver","id":2543659,"avatar_url":"https://avatars1.githubusercontent.com/u/2543659?v=4","gravatar_id":"","url":"https://api.github.com/users/braver","html_url":"https://github.com/braver","followers_url":"https://api.github.com/users/braver/followers","following_url":"https://api.github.com/users/braver/following{/other_user}","gists_url":"https://api.github.com/users/braver/gists{/gist_id}","starred_url":"https://api.github.com/users/braver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/braver/subscriptions","organizations_url":"https://api.github.com/users/braver/orgs","repos_url":"https://api.github.com/users/braver/repos","events_url":"https://api.github.com/users/braver/events{/privacy}","received_events_url":"https://api.github.com/users/braver/received_events","type":"User","site_admin":false},"created_at":"2018-02-02T21:06:12Z","updated_at":"2018-02-02T21:06:12Z","author_association":"OWNER","body":"🤔\r\n\r\n```py\r\non_pre_close(): \r\n        print(bid)\r\n        print(buffers)\r\n        print(buffers.count(bid))\r\n```\r\n\r\nprints:\r\n```\r\n53\r\n[56]\r\n0\r\n```\r\n\r\n... and amazingly, it prints that when I *open* a view. I need some more time with this to check its behaviour it seems."}}
{"actor":{"display_login":"braver"}}