{"action":"created","issue":{"url":"https://api.github.com/repos/ioam/parambokeh/issues/51","repository_url":"https://api.github.com/repos/ioam/parambokeh","labels_url":"https://api.github.com/repos/ioam/parambokeh/issues/51/labels{/name}","comments_url":"https://api.github.com/repos/ioam/parambokeh/issues/51/comments","events_url":"https://api.github.com/repos/ioam/parambokeh/issues/51/events","html_url":"https://github.com/ioam/parambokeh/pull/51","id":324913285,"number":51,"title":"Refactored comms to add JupyterLab support","user":{"login":"jlstevens","id":890576,"avatar_url":"https://avatars3.githubusercontent.com/u/890576?v=4","gravatar_id":"","url":"https://api.github.com/users/jlstevens","html_url":"https://github.com/jlstevens","followers_url":"https://api.github.com/users/jlstevens/followers","following_url":"https://api.github.com/users/jlstevens/following{/other_user}","gists_url":"https://api.github.com/users/jlstevens/gists{/gist_id}","starred_url":"https://api.github.com/users/jlstevens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlstevens/subscriptions","organizations_url":"https://api.github.com/users/jlstevens/orgs","repos_url":"https://api.github.com/users/jlstevens/repos","events_url":"https://api.github.com/users/jlstevens/events{/privacy}","received_events_url":"https://api.github.com/users/jlstevens/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-05-21T13:19:26Z","updated_at":"2018-05-21T22:16:01Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ioam/parambokeh/pulls/51","html_url":"https://github.com/ioam/parambokeh/pull/51","diff_url":"https://github.com/ioam/parambokeh/pull/51.diff","patch_url":"https://github.com/ioam/parambokeh/pull/51.patch"},"body":"This PR is still WIP and there are a lot of issues to address:\r\n\r\n- [x] Made comms code consistent with holoviews.\r\n- [x] Works in classic notebook\r\n- [x] Displays widgets in jupyterlab\r\n- [x] Updates parameter values in jupyterlab\r\n- [x] All functionality relating to the bokeh comms and plots option.\r\n- [x] Currently removing duplication of comms code by importing from holoviews. HoloViews should not be a parambokeh dependency but we do need a comms package for pyviz.\r\n- [x] Currently needs a ``HoloViews`` object to be introduced in JS which isn't appropriate for other pyviz projects.\r\n\r\nRight now the problem I am trying to address is to get comms working in jupyterlab as the parameter values are not updating.\r\n\r\nNote that this requires the pyviz jupyterlab extension. I have the bokeh jupyterlab extension but I'm not yet sure whether or not it is actually required."},"comment":{"url":"https://api.github.com/repos/ioam/parambokeh/issues/comments/390799590","html_url":"https://github.com/ioam/parambokeh/pull/51#issuecomment-390799590","issue_url":"https://api.github.com/repos/ioam/parambokeh/issues/51","id":390799590,"user":{"login":"jlstevens","id":890576,"avatar_url":"https://avatars3.githubusercontent.com/u/890576?v=4","gravatar_id":"","url":"https://api.github.com/users/jlstevens","html_url":"https://github.com/jlstevens","followers_url":"https://api.github.com/users/jlstevens/followers","following_url":"https://api.github.com/users/jlstevens/following{/other_user}","gists_url":"https://api.github.com/users/jlstevens/gists{/gist_id}","starred_url":"https://api.github.com/users/jlstevens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlstevens/subscriptions","organizations_url":"https://api.github.com/users/jlstevens/orgs","repos_url":"https://api.github.com/users/jlstevens/repos","events_url":"https://api.github.com/users/jlstevens/events{/privacy}","received_events_url":"https://api.github.com/users/jlstevens/received_events","type":"User","site_admin":false},"created_at":"2018-05-21T22:16:01Z","updated_at":"2018-05-21T22:16:01Z","author_association":"MEMBER","body":"Tests are now green and I have ticked off the TODO items above. It isn't perfect but I think it is ready to review and merge before improving upon in subsequent PRs. The ``pyviz_comms` package is now required and available on the pyviz conda channel."}}
{"actor":{"display_login":"jlstevens"}}