{"action":"created","comment":{"url":"https://api.github.com/repos/mlflow/mlflow/pulls/comments/206907229","pull_request_review_id":142411148,"id":206907229,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjkwNzIyOQ==","diff_hunk":"@@ -227,10 +227,13 @@ def run_databricks(uri, entry_point, version, parameters, experiment_id, cluster\n     if cluster_spec is None:\n         raise ExecutionException(\"Cluster spec must be provided when launching MLflow project runs \"\n                                  \"on Databricks.\")\n-\n-    # Fetch the project into work_dir & validate parameters\n-    work_dir = _fetch_project(uri=uri, use_temp_cwd=True, version=version,\n-                              git_username=git_username, git_password=git_password)\n+    # Fetch the project into temporary work_dir & validate parameters","path":"mlflow/projects/databricks.py","position":8,"original_position":8,"commit_id":"b90620985e1378c2477aed65c8ab0ca229a49406","original_commit_id":"b90620985e1378c2477aed65c8ab0ca229a49406","user":{"login":"aarondav","id":1400247,"node_id":"MDQ6VXNlcjE0MDAyNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1400247?v=4","gravatar_id":"","url":"https://api.github.com/users/aarondav","html_url":"https://github.com/aarondav","followers_url":"https://api.github.com/users/aarondav/followers","following_url":"https://api.github.com/users/aarondav/following{/other_user}","gists_url":"https://api.github.com/users/aarondav/gists{/gist_id}","starred_url":"https://api.github.com/users/aarondav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aarondav/subscriptions","organizations_url":"https://api.github.com/users/aarondav/orgs","repos_url":"https://api.github.com/users/aarondav/repos","events_url":"https://api.github.com/users/aarondav/events{/privacy}","received_events_url":"https://api.github.com/users/aarondav/received_events","type":"User","site_admin":false},"body":"This comment is not helpful","created_at":"2018-08-01T14:41:50Z","updated_at":"2018-08-01T14:41:50Z","html_url":"https://github.com/mlflow/mlflow/pull/215#discussion_r206907229","pull_request_url":"https://api.github.com/repos/mlflow/mlflow/pulls/215","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mlflow/mlflow/pulls/comments/206907229"},"html":{"href":"https://github.com/mlflow/mlflow/pull/215#discussion_r206907229"},"pull_request":{"href":"https://api.github.com/repos/mlflow/mlflow/pulls/215"}}},"pull_request":{"url":"https://api.github.com/repos/mlflow/mlflow/pulls/215","id":204952029,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0OTUyMDI5","html_url":"https://github.com/mlflow/mlflow/pull/215","diff_url":"https://github.com/mlflow/mlflow/pull/215.diff","patch_url":"https://github.com/mlflow/mlflow/pull/215.patch","issue_url":"https://api.github.com/repos/mlflow/mlflow/issues/215","number":215,"state":"open","locked":false,"title":"Always fetch projects into temp directories","user":{"login":"smurching","id":2358483,"node_id":"MDQ6VXNlcjIzNTg0ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/2358483?v=4","gravatar_id":"","url":"https://api.github.com/users/smurching","html_url":"https://github.com/smurching","followers_url":"https://api.github.com/users/smurching/followers","following_url":"https://api.github.com/users/smurching/following{/other_user}","gists_url":"https://api.github.com/users/smurching/gists{/gist_id}","starred_url":"https://api.github.com/users/smurching/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smurching/subscriptions","organizations_url":"https://api.github.com/users/smurching/orgs","repos_url":"https://api.github.com/users/smurching/repos","events_url":"https://api.github.com/users/smurching/events{/privacy}","received_events_url":"https://api.github.com/users/smurching/received_events","type":"User","site_admin":false},"body":"This PR updates project-fetching logic to:\r\n* Not include the mlruns directory when fetching a project. This is beneficial e.g. when running a local project on Databricks - currently the sequence below will re-upload project A to DBFS the second run as the mlruns directory will have changed.\r\n  * CD into project A\r\n  * Run project A on Databricks\r\n  * Run project A locally, log results to mlruns\r\n  * Run project A on Databricks\r\n\r\n* Always fetch a project into a new temp directory to prevent concurrent attempts to copy a project into the same directory, and remove the `use_temp_cwd` flag (this is a breaking API change). The current implementation fails to detect that e.g. \"/Users/sid/code/mlflow/tests/resources/example_project/\" and \"/Users/sid/code/mlflow/tests/resources/example_project\" are the same path, and attempts to copy the former into the latter via `dir_utils.copy_tree`. When multiple runs of the same local project are launched concurrently,  the seemingly non-atomic nature of `copy_tree` results in errors like:\r\n```\r\nTraceback (most recent call last):\r\n  File \"/Users/sid/miniconda3/envs/mlflow_python3/bin/mlflow\", line 11, in <module>\r\n    load_entry_point('mlflow', 'console_scripts', 'mlflow')()\r\n  File \"/Users/sid/miniconda3/envs/mlflow_python3/lib/python3.6/site-packages/click/core.py\", line 722, in __call__\r\n    return self.main(*args, **kwargs)\r\n  File \"/Users/sid/miniconda3/envs/mlflow_python3/lib/python3.6/site-packages/click/core.py\", line 697, in main\r\n    rv = self.invoke(ctx)\r\n  File \"/Users/sid/miniconda3/envs/mlflow_python3/lib/python3.6/site-packages/click/core.py\", line 1066, in invoke\r\n    return _process_result(sub_ctx.command.invoke(sub_ctx))\r\n  File \"/Users/sid/miniconda3/envs/mlflow_python3/lib/python3.6/site-packages/click/core.py\", line 895, in invoke\r\n    return ctx.invoke(self.callback, **ctx.params)\r\n  File \"/Users/sid/miniconda3/envs/mlflow_python3/lib/python3.6/site-packages/click/core.py\", line 535, in invoke\r\n    return callback(*args, **kwargs)\r\n  File \"/Users/sid/code/mlflow/mlflow/cli.py\", line 119, in run\r\n    run_id=run_id,\r\n  File \"/Users/sid/code/mlflow/mlflow/projects/__init__.py\", line 132, in run\r\n    use_temp_cwd=use_temp_cwd, storage_dir=storage_dir, block=block, run_id=run_id)\r\n  File \"/Users/sid/code/mlflow/mlflow/projects/__init__.py\", line 70, in _run\r\n    work_dir, entry_point, use_conda, parameters, storage_dir)\r\n  File \"/Users/sid/code/mlflow/mlflow/projects/__init__.py\", line 308, in _get_entry_point_command\r\n    project = _load_project(project_dir=project_dir)\r\n  File \"/Users/sid/code/mlflow/mlflow/projects/__init__.py\", line 160, in _load_project\r\n    return Project(file_utils.read_yaml(project_dir, \"MLproject\"))\r\n  File \"/Users/sid/code/mlflow/mlflow/utils/file_utils.py\", line 159, in read_yaml\r\n    raise e\r\n  File \"/Users/sid/code/mlflow/mlflow/utils/file_utils.py\", line 156, in read_yaml\r\n    with open(file_path, 'r') as yaml_file:\r\nFileNotFoundError: [Errno 2] No such file or directory: '/Users/sid/code/mlflow/tests/resources/example_project/MLproject'\r\n```\r\n","created_at":"2018-07-30T22:52:10Z","updated_at":"2018-08-01T14:41:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e02173afb36df91f0f36a6c4e7edeee6ed98811","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mlflow/mlflow/pulls/215/commits","review_comments_url":"https://api.github.com/repos/mlflow/mlflow/pulls/215/comments","review_comment_url":"https://api.github.com/repos/mlflow/mlflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mlflow/mlflow/issues/215/comments","statuses_url":"https://api.github.com/repos/mlflow/mlflow/statuses/b90620985e1378c2477aed65c8ab0ca229a49406","head":{"label":"smurching:fix-dir-copy","ref":"fix-dir-copy","sha":"b90620985e1378c2477aed65c8ab0ca229a49406","user":{"login":"smurching","id":2358483,"node_id":"MDQ6VXNlcjIzNTg0ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/2358483?v=4","gravatar_id":"","url":"https://api.github.com/users/smurching","html_url":"https://github.com/smurching","followers_url":"https://api.github.com/users/smurching/followers","following_url":"https://api.github.com/users/smurching/following{/other_user}","gists_url":"https://api.github.com/users/smurching/gists{/gist_id}","starred_url":"https://api.github.com/users/smurching/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smurching/subscriptions","organizations_url":"https://api.github.com/users/smurching/orgs","repos_url":"https://api.github.com/users/smurching/repos","events_url":"https://api.github.com/users/smurching/events{/privacy}","received_events_url":"https://api.github.com/users/smurching/received_events","type":"User","site_admin":false},"repo":{"id":136405291,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY0MDUyOTE=","name":"mlflow","full_name":"smurching/mlflow","owner":{"login":"smurching","id":2358483,"node_id":"MDQ6VXNlcjIzNTg0ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/2358483?v=4","gravatar_id":"","url":"https://api.github.com/users/smurching","html_url":"https://github.com/smurching","followers_url":"https://api.github.com/users/smurching/followers","following_url":"https://api.github.com/users/smurching/following{/other_user}","gists_url":"https://api.github.com/users/smurching/gists{/gist_id}","starred_url":"https://api.github.com/users/smurching/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smurching/subscriptions","organizations_url":"https://api.github.com/users/smurching/orgs","repos_url":"https://api.github.com/users/smurching/repos","events_url":"https://api.github.com/users/smurching/events{/privacy}","received_events_url":"https://api.github.com/users/smurching/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smurching/mlflow","description":"Open source platform for the complete machine learning lifecycle","fork":true,"url":"https://api.github.com/repos/smurching/mlflow","forks_url":"https://api.github.com/repos/smurching/mlflow/forks","keys_url":"https://api.github.com/repos/smurching/mlflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smurching/mlflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smurching/mlflow/teams","hooks_url":"https://api.github.com/repos/smurching/mlflow/hooks","issue_events_url":"https://api.github.com/repos/smurching/mlflow/issues/events{/number}","events_url":"https://api.github.com/repos/smurching/mlflow/events","assignees_url":"https://api.github.com/repos/smurching/mlflow/assignees{/user}","branches_url":"https://api.github.com/repos/smurching/mlflow/branches{/branch}","tags_url":"https://api.github.com/repos/smurching/mlflow/tags","blobs_url":"https://api.github.com/repos/smurching/mlflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smurching/mlflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smurching/mlflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/smurching/mlflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smurching/mlflow/statuses/{sha}","languages_url":"https://api.github.com/repos/smurching/mlflow/languages","stargazers_url":"https://api.github.com/repos/smurching/mlflow/stargazers","contributors_url":"https://api.github.com/repos/smurching/mlflow/contributors","subscribers_url":"https://api.github.com/repos/smurching/mlflow/subscribers","subscription_url":"https://api.github.com/repos/smurching/mlflow/subscription","commits_url":"https://api.github.com/repos/smurching/mlflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/smurching/mlflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/smurching/mlflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/smurching/mlflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/smurching/mlflow/contents/{+path}","compare_url":"https://api.github.com/repos/smurching/mlflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smurching/mlflow/merges","archive_url":"https://api.github.com/repos/smurching/mlflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smurching/mlflow/downloads","issues_url":"https://api.github.com/repos/smurching/mlflow/issues{/number}","pulls_url":"https://api.github.com/repos/smurching/mlflow/pulls{/number}","milestones_url":"https://api.github.com/repos/smurching/mlflow/milestones{/number}","notifications_url":"https://api.github.com/repos/smurching/mlflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smurching/mlflow/labels{/name}","releases_url":"https://api.github.com/repos/smurching/mlflow/releases{/id}","deployments_url":"https://api.github.com/repos/smurching/mlflow/deployments","created_at":"2018-06-07T01:31:16Z","updated_at":"2018-07-30T20:18:52Z","pushed_at":"2018-08-01T08:22:51Z","git_url":"git://github.com/smurching/mlflow.git","ssh_url":"git@github.com:smurching/mlflow.git","clone_url":"https://github.com/smurching/mlflow.git","svn_url":"https://github.com/smurching/mlflow","homepage":"https://mlflow.org","size":3630,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mlflow:master","ref":"master","sha":"36b00deb480bfcb1e4e4fe2591419f0ee2700ee4","user":{"login":"mlflow","id":39938107,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5OTM4MTA3","avatar_url":"https://avatars3.githubusercontent.com/u/39938107?v=4","gravatar_id":"","url":"https://api.github.com/users/mlflow","html_url":"https://github.com/mlflow","followers_url":"https://api.github.com/users/mlflow/followers","following_url":"https://api.github.com/users/mlflow/following{/other_user}","gists_url":"https://api.github.com/users/mlflow/gists{/gist_id}","starred_url":"https://api.github.com/users/mlflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlflow/subscriptions","organizations_url":"https://api.github.com/users/mlflow/orgs","repos_url":"https://api.github.com/users/mlflow/repos","events_url":"https://api.github.com/users/mlflow/events{/privacy}","received_events_url":"https://api.github.com/users/mlflow/received_events","type":"Organization","site_admin":false},"repo":{"id":136202695,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYyMDI2OTU=","name":"mlflow","full_name":"mlflow/mlflow","owner":{"login":"mlflow","id":39938107,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5OTM4MTA3","avatar_url":"https://avatars3.githubusercontent.com/u/39938107?v=4","gravatar_id":"","url":"https://api.github.com/users/mlflow","html_url":"https://github.com/mlflow","followers_url":"https://api.github.com/users/mlflow/followers","following_url":"https://api.github.com/users/mlflow/following{/other_user}","gists_url":"https://api.github.com/users/mlflow/gists{/gist_id}","starred_url":"https://api.github.com/users/mlflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlflow/subscriptions","organizations_url":"https://api.github.com/users/mlflow/orgs","repos_url":"https://api.github.com/users/mlflow/repos","events_url":"https://api.github.com/users/mlflow/events{/privacy}","received_events_url":"https://api.github.com/users/mlflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mlflow/mlflow","description":"Open source platform for the complete machine learning lifecycle","fork":false,"url":"https://api.github.com/repos/mlflow/mlflow","forks_url":"https://api.github.com/repos/mlflow/mlflow/forks","keys_url":"https://api.github.com/repos/mlflow/mlflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlflow/mlflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlflow/mlflow/teams","hooks_url":"https://api.github.com/repos/mlflow/mlflow/hooks","issue_events_url":"https://api.github.com/repos/mlflow/mlflow/issues/events{/number}","events_url":"https://api.github.com/repos/mlflow/mlflow/events","assignees_url":"https://api.github.com/repos/mlflow/mlflow/assignees{/user}","branches_url":"https://api.github.com/repos/mlflow/mlflow/branches{/branch}","tags_url":"https://api.github.com/repos/mlflow/mlflow/tags","blobs_url":"https://api.github.com/repos/mlflow/mlflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlflow/mlflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlflow/mlflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlflow/mlflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlflow/mlflow/statuses/{sha}","languages_url":"https://api.github.com/repos/mlflow/mlflow/languages","stargazers_url":"https://api.github.com/repos/mlflow/mlflow/stargazers","contributors_url":"https://api.github.com/repos/mlflow/mlflow/contributors","subscribers_url":"https://api.github.com/repos/mlflow/mlflow/subscribers","subscription_url":"https://api.github.com/repos/mlflow/mlflow/subscription","commits_url":"https://api.github.com/repos/mlflow/mlflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlflow/mlflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlflow/mlflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlflow/mlflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlflow/mlflow/contents/{+path}","compare_url":"https://api.github.com/repos/mlflow/mlflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlflow/mlflow/merges","archive_url":"https://api.github.com/repos/mlflow/mlflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlflow/mlflow/downloads","issues_url":"https://api.github.com/repos/mlflow/mlflow/issues{/number}","pulls_url":"https://api.github.com/repos/mlflow/mlflow/pulls{/number}","milestones_url":"https://api.github.com/repos/mlflow/mlflow/milestones{/number}","notifications_url":"https://api.github.com/repos/mlflow/mlflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlflow/mlflow/labels{/name}","releases_url":"https://api.github.com/repos/mlflow/mlflow/releases{/id}","deployments_url":"https://api.github.com/repos/mlflow/mlflow/deployments","created_at":"2018-06-05T16:05:58Z","updated_at":"2018-08-01T12:02:44Z","pushed_at":"2018-08-01T13:58:52Z","git_url":"git://github.com/mlflow/mlflow.git","ssh_url":"git@github.com:mlflow/mlflow.git","clone_url":"https://github.com/mlflow/mlflow.git","svn_url":"https://github.com/mlflow/mlflow","homepage":"https://mlflow.org","size":3299,"stargazers_count":1866,"watchers_count":1866,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":263,"mirror_url":null,"archived":false,"open_issues_count":60,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":263,"open_issues":60,"watchers":1866,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mlflow/mlflow/pulls/215"},"html":{"href":"https://github.com/mlflow/mlflow/pull/215"},"issue":{"href":"https://api.github.com/repos/mlflow/mlflow/issues/215"},"comments":{"href":"https://api.github.com/repos/mlflow/mlflow/issues/215/comments"},"review_comments":{"href":"https://api.github.com/repos/mlflow/mlflow/pulls/215/comments"},"review_comment":{"href":"https://api.github.com/repos/mlflow/mlflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mlflow/mlflow/pulls/215/commits"},"statuses":{"href":"https://api.github.com/repos/mlflow/mlflow/statuses/b90620985e1378c2477aed65c8ab0ca229a49406"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aarondav"}}