{"action":"created","comment":{"url":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/comments/208904041","pull_request_review_id":144808738,"id":208904041,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODkwNDA0MQ==","diff_hunk":"@@ -1109,9 +1112,11 @@\n \t\treturn\n \tlights = !lights\n \tif(lights)\n-\t\tset_light(luminosity + lights_power)\n+\t\tlight_power = light_brightness_on","path":"code/game/mecha/mecha.dm","position":26,"original_position":26,"commit_id":"def4974a520298098d0c81f1c8ce22f2e41d83bc","original_commit_id":"def4974a520298098d0c81f1c8ce22f2e41d83bc","user":{"login":"jknpj","id":17928298,"node_id":"MDQ6VXNlcjE3OTI4Mjk4","avatar_url":"https://avatars1.githubusercontent.com/u/17928298?v=4","gravatar_id":"","url":"https://api.github.com/users/jknpj","html_url":"https://github.com/jknpj","followers_url":"https://api.github.com/users/jknpj/followers","following_url":"https://api.github.com/users/jknpj/following{/other_user}","gists_url":"https://api.github.com/users/jknpj/gists{/gist_id}","starred_url":"https://api.github.com/users/jknpj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jknpj/subscriptions","organizations_url":"https://api.github.com/users/jknpj/orgs","repos_url":"https://api.github.com/users/jknpj/repos","events_url":"https://api.github.com/users/jknpj/events{/privacy}","received_events_url":"https://api.github.com/users/jknpj/received_events","type":"User","site_admin":false},"body":"Try using this instead\r\n\r\n```\r\nlight_power = lights ? light_brightness_on : light_brightness_off\r\nset_light(light_power)\r\n```","created_at":"2018-08-09T12:06:52Z","updated_at":"2018-08-09T12:07:52Z","html_url":"https://github.com/vgstation-coders/vgstation13/pull/19049#discussion_r208904041","pull_request_url":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/19049","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/comments/208904041"},"html":{"href":"https://github.com/vgstation-coders/vgstation13/pull/19049#discussion_r208904041"},"pull_request":{"href":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/19049"}}},"pull_request":{"url":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/19049","id":205178737,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MTc4NzM3","html_url":"https://github.com/vgstation-coders/vgstation13/pull/19049","diff_url":"https://github.com/vgstation-coders/vgstation13/pull/19049.diff","patch_url":"https://github.com/vgstation-coders/vgstation13/pull/19049.patch","issue_url":"https://api.github.com/repos/vgstation-coders/vgstation13/issues/19049","number":19049,"state":"open","locked":false,"title":"Mecha light tweaks","user":{"login":"brndd","id":5822375,"node_id":"MDQ6VXNlcjU4MjIzNzU=","avatar_url":"https://avatars3.githubusercontent.com/u/5822375?v=4","gravatar_id":"","url":"https://api.github.com/users/brndd","html_url":"https://github.com/brndd","followers_url":"https://api.github.com/users/brndd/followers","following_url":"https://api.github.com/users/brndd/following{/other_user}","gists_url":"https://api.github.com/users/brndd/gists{/gist_id}","starred_url":"https://api.github.com/users/brndd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brndd/subscriptions","organizations_url":"https://api.github.com/users/brndd/orgs","repos_url":"https://api.github.com/users/brndd/repos","events_url":"https://api.github.com/users/brndd/events{/privacy}","received_events_url":"https://api.github.com/users/brndd/received_events","type":"User","site_admin":false},"body":"I always thought the mecha lights were too dim (they're dimmer than a lantern), so I made them brighter. Now they're brighter than a lantern, and even brighter still on the Firefighter Ripley. The Deathsquad Ripley's brightness has been reduced from 60 radius to 12, because the old value made it look like the lighting system was broken.\r\n\r\nI also made active mechs (that is, ones with a pilot in them) emit a low amount of light even when the main lights are off. It's supposed to represent cabin lights leaking out, or something. The combat mechs do not have this to allow for stealth operations.\r\n\r\n~~Oh yeah, and I removed the special cursor combat mechs have, because I've always found it supremely annoying and it's kinda glitchy with some interface elements. I hope there isn't some deeper purpose to it that eludes me.~~ ~~I put the cursor on a toggle option, defaulting to off. As a side effect of this, it's no longer exclusive to combat mechs (because working in separate interface shit for them would've been a pain).~~ I removed that from this PR and will make a new one for it.\r\n\r\nComparisons: [old Ripley lights]\r\n![image](https://user-images.githubusercontent.com/17928298/43481207-b47991fe-94db-11e8-9b0a-258ecc079e29.png)\r\n(https://i.imgur.com/oNXHtfN.png) \r\n\r\n[new Ripley lights]\r\n![image](https://user-images.githubusercontent.com/17928298/43481232-c4c7242c-94db-11e8-9912-2d9fa2e7224b.png)\r\n(https://i.imgur.com/4AAX78g.png)\r\n\r\n[Ripley ambient lights]\r\n![image](https://user-images.githubusercontent.com/17928298/43481279-e1880f40-94db-11e8-881e-259600bf90dc.png)\r\n(https://i.imgur.com/UdIN2wx.png)\r\n\r\n[a lantern]\r\n![image](https://user-images.githubusercontent.com/17928298/43481294-ef54d96e-94db-11e8-9c48-46ff976adb94.png)\r\n(https://i.imgur.com/LLkcSlP.png)\r\n\r\n:cl:\r\n* tweak: Mech lights are now brighter and have more range.\r\n* tweak: Deathsquad Ripley's lights now only illuminate 150% of the screen radius (was 750%)\r\n* tweak: Non-combat mechs now produce a small amount of light when active even when the lights are off.\r\n\r\n","created_at":"2018-07-31T16:57:16Z","updated_at":"2018-08-09T12:07:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c713d0edcda0847c9f1efd842899a4a343674b8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":712160647,"node_id":"MDU6TGFiZWw3MTIxNjA2NDc=","url":"https://api.github.com/repos/vgstation-coders/vgstation13/labels/Tweak","name":"Tweak","color":"E79871","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/19049/commits","review_comments_url":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/19049/comments","review_comment_url":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vgstation-coders/vgstation13/issues/19049/comments","statuses_url":"https://api.github.com/repos/vgstation-coders/vgstation13/statuses/def4974a520298098d0c81f1c8ce22f2e41d83bc","head":{"label":"brndd:mechlights","ref":"mechlights","sha":"def4974a520298098d0c81f1c8ce22f2e41d83bc","user":{"login":"brndd","id":5822375,"node_id":"MDQ6VXNlcjU4MjIzNzU=","avatar_url":"https://avatars3.githubusercontent.com/u/5822375?v=4","gravatar_id":"","url":"https://api.github.com/users/brndd","html_url":"https://github.com/brndd","followers_url":"https://api.github.com/users/brndd/followers","following_url":"https://api.github.com/users/brndd/following{/other_user}","gists_url":"https://api.github.com/users/brndd/gists{/gist_id}","starred_url":"https://api.github.com/users/brndd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brndd/subscriptions","organizations_url":"https://api.github.com/users/brndd/orgs","repos_url":"https://api.github.com/users/brndd/repos","events_url":"https://api.github.com/users/brndd/events{/privacy}","received_events_url":"https://api.github.com/users/brndd/received_events","type":"User","site_admin":false},"repo":{"id":141933332,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE5MzMzMzI=","name":"vgstation13","full_name":"brndd/vgstation13","owner":{"login":"brndd","id":5822375,"node_id":"MDQ6VXNlcjU4MjIzNzU=","avatar_url":"https://avatars3.githubusercontent.com/u/5822375?v=4","gravatar_id":"","url":"https://api.github.com/users/brndd","html_url":"https://github.com/brndd","followers_url":"https://api.github.com/users/brndd/followers","following_url":"https://api.github.com/users/brndd/following{/other_user}","gists_url":"https://api.github.com/users/brndd/gists{/gist_id}","starred_url":"https://api.github.com/users/brndd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brndd/subscriptions","organizations_url":"https://api.github.com/users/brndd/orgs","repos_url":"https://api.github.com/users/brndd/repos","events_url":"https://api.github.com/users/brndd/events{/privacy}","received_events_url":"https://api.github.com/users/brndd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brndd/vgstation13","description":"Butts","fork":true,"url":"https://api.github.com/repos/brndd/vgstation13","forks_url":"https://api.github.com/repos/brndd/vgstation13/forks","keys_url":"https://api.github.com/repos/brndd/vgstation13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brndd/vgstation13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brndd/vgstation13/teams","hooks_url":"https://api.github.com/repos/brndd/vgstation13/hooks","issue_events_url":"https://api.github.com/repos/brndd/vgstation13/issues/events{/number}","events_url":"https://api.github.com/repos/brndd/vgstation13/events","assignees_url":"https://api.github.com/repos/brndd/vgstation13/assignees{/user}","branches_url":"https://api.github.com/repos/brndd/vgstation13/branches{/branch}","tags_url":"https://api.github.com/repos/brndd/vgstation13/tags","blobs_url":"https://api.github.com/repos/brndd/vgstation13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brndd/vgstation13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brndd/vgstation13/git/refs{/sha}","trees_url":"https://api.github.com/repos/brndd/vgstation13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brndd/vgstation13/statuses/{sha}","languages_url":"https://api.github.com/repos/brndd/vgstation13/languages","stargazers_url":"https://api.github.com/repos/brndd/vgstation13/stargazers","contributors_url":"https://api.github.com/repos/brndd/vgstation13/contributors","subscribers_url":"https://api.github.com/repos/brndd/vgstation13/subscribers","subscription_url":"https://api.github.com/repos/brndd/vgstation13/subscription","commits_url":"https://api.github.com/repos/brndd/vgstation13/commits{/sha}","git_commits_url":"https://api.github.com/repos/brndd/vgstation13/git/commits{/sha}","comments_url":"https://api.github.com/repos/brndd/vgstation13/comments{/number}","issue_comment_url":"https://api.github.com/repos/brndd/vgstation13/issues/comments{/number}","contents_url":"https://api.github.com/repos/brndd/vgstation13/contents/{+path}","compare_url":"https://api.github.com/repos/brndd/vgstation13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brndd/vgstation13/merges","archive_url":"https://api.github.com/repos/brndd/vgstation13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brndd/vgstation13/downloads","issues_url":"https://api.github.com/repos/brndd/vgstation13/issues{/number}","pulls_url":"https://api.github.com/repos/brndd/vgstation13/pulls{/number}","milestones_url":"https://api.github.com/repos/brndd/vgstation13/milestones{/number}","notifications_url":"https://api.github.com/repos/brndd/vgstation13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brndd/vgstation13/labels{/name}","releases_url":"https://api.github.com/repos/brndd/vgstation13/releases{/id}","deployments_url":"https://api.github.com/repos/brndd/vgstation13/deployments","created_at":"2018-07-22T21:53:21Z","updated_at":"2018-08-08T23:59:36Z","pushed_at":"2018-08-09T03:45:42Z","git_url":"git://github.com/brndd/vgstation13.git","ssh_url":"git@github.com:brndd/vgstation13.git","clone_url":"https://github.com/brndd/vgstation13.git","svn_url":"https://github.com/brndd/vgstation13","homepage":"","size":1244391,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"Bleeding-Edge"}},"base":{"label":"vgstation-coders:Bleeding-Edge","ref":"Bleeding-Edge","sha":"c94e2f320a946e66980d06403f2fa0f4c43786aa","user":{"login":"vgstation-coders","id":26489760,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NDg5NzYw","avatar_url":"https://avatars2.githubusercontent.com/u/26489760?v=4","gravatar_id":"","url":"https://api.github.com/users/vgstation-coders","html_url":"https://github.com/vgstation-coders","followers_url":"https://api.github.com/users/vgstation-coders/followers","following_url":"https://api.github.com/users/vgstation-coders/following{/other_user}","gists_url":"https://api.github.com/users/vgstation-coders/gists{/gist_id}","starred_url":"https://api.github.com/users/vgstation-coders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vgstation-coders/subscriptions","organizations_url":"https://api.github.com/users/vgstation-coders/orgs","repos_url":"https://api.github.com/users/vgstation-coders/repos","events_url":"https://api.github.com/users/vgstation-coders/events{/privacy}","received_events_url":"https://api.github.com/users/vgstation-coders/received_events","type":"Organization","site_admin":false},"repo":{"id":10441188,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ0MTE4OA==","name":"vgstation13","full_name":"vgstation-coders/vgstation13","owner":{"login":"vgstation-coders","id":26489760,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NDg5NzYw","avatar_url":"https://avatars2.githubusercontent.com/u/26489760?v=4","gravatar_id":"","url":"https://api.github.com/users/vgstation-coders","html_url":"https://github.com/vgstation-coders","followers_url":"https://api.github.com/users/vgstation-coders/followers","following_url":"https://api.github.com/users/vgstation-coders/following{/other_user}","gists_url":"https://api.github.com/users/vgstation-coders/gists{/gist_id}","starred_url":"https://api.github.com/users/vgstation-coders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vgstation-coders/subscriptions","organizations_url":"https://api.github.com/users/vgstation-coders/orgs","repos_url":"https://api.github.com/users/vgstation-coders/repos","events_url":"https://api.github.com/users/vgstation-coders/events{/privacy}","received_events_url":"https://api.github.com/users/vgstation-coders/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vgstation-coders/vgstation13","description":"Butts","fork":false,"url":"https://api.github.com/repos/vgstation-coders/vgstation13","forks_url":"https://api.github.com/repos/vgstation-coders/vgstation13/forks","keys_url":"https://api.github.com/repos/vgstation-coders/vgstation13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vgstation-coders/vgstation13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vgstation-coders/vgstation13/teams","hooks_url":"https://api.github.com/repos/vgstation-coders/vgstation13/hooks","issue_events_url":"https://api.github.com/repos/vgstation-coders/vgstation13/issues/events{/number}","events_url":"https://api.github.com/repos/vgstation-coders/vgstation13/events","assignees_url":"https://api.github.com/repos/vgstation-coders/vgstation13/assignees{/user}","branches_url":"https://api.github.com/repos/vgstation-coders/vgstation13/branches{/branch}","tags_url":"https://api.github.com/repos/vgstation-coders/vgstation13/tags","blobs_url":"https://api.github.com/repos/vgstation-coders/vgstation13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vgstation-coders/vgstation13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vgstation-coders/vgstation13/git/refs{/sha}","trees_url":"https://api.github.com/repos/vgstation-coders/vgstation13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vgstation-coders/vgstation13/statuses/{sha}","languages_url":"https://api.github.com/repos/vgstation-coders/vgstation13/languages","stargazers_url":"https://api.github.com/repos/vgstation-coders/vgstation13/stargazers","contributors_url":"https://api.github.com/repos/vgstation-coders/vgstation13/contributors","subscribers_url":"https://api.github.com/repos/vgstation-coders/vgstation13/subscribers","subscription_url":"https://api.github.com/repos/vgstation-coders/vgstation13/subscription","commits_url":"https://api.github.com/repos/vgstation-coders/vgstation13/commits{/sha}","git_commits_url":"https://api.github.com/repos/vgstation-coders/vgstation13/git/commits{/sha}","comments_url":"https://api.github.com/repos/vgstation-coders/vgstation13/comments{/number}","issue_comment_url":"https://api.github.com/repos/vgstation-coders/vgstation13/issues/comments{/number}","contents_url":"https://api.github.com/repos/vgstation-coders/vgstation13/contents/{+path}","compare_url":"https://api.github.com/repos/vgstation-coders/vgstation13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vgstation-coders/vgstation13/merges","archive_url":"https://api.github.com/repos/vgstation-coders/vgstation13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vgstation-coders/vgstation13/downloads","issues_url":"https://api.github.com/repos/vgstation-coders/vgstation13/issues{/number}","pulls_url":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls{/number}","milestones_url":"https://api.github.com/repos/vgstation-coders/vgstation13/milestones{/number}","notifications_url":"https://api.github.com/repos/vgstation-coders/vgstation13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vgstation-coders/vgstation13/labels{/name}","releases_url":"https://api.github.com/repos/vgstation-coders/vgstation13/releases{/id}","deployments_url":"https://api.github.com/repos/vgstation-coders/vgstation13/deployments","created_at":"2013-06-02T19:39:54Z","updated_at":"2018-08-09T12:03:42Z","pushed_at":"2018-08-09T12:03:33Z","git_url":"git://github.com/vgstation-coders/vgstation13.git","ssh_url":"git@github.com:vgstation-coders/vgstation13.git","clone_url":"https://github.com/vgstation-coders/vgstation13.git","svn_url":"https://github.com/vgstation-coders/vgstation13","homepage":"","size":1238776,"stargazers_count":149,"watchers_count":149,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":291,"mirror_url":null,"archived":false,"open_issues_count":2142,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":291,"open_issues":2142,"watchers":149,"default_branch":"Bleeding-Edge"}},"_links":{"self":{"href":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/19049"},"html":{"href":"https://github.com/vgstation-coders/vgstation13/pull/19049"},"issue":{"href":"https://api.github.com/repos/vgstation-coders/vgstation13/issues/19049"},"comments":{"href":"https://api.github.com/repos/vgstation-coders/vgstation13/issues/19049/comments"},"review_comments":{"href":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/19049/comments"},"review_comment":{"href":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/19049/commits"},"statuses":{"href":"https://api.github.com/repos/vgstation-coders/vgstation13/statuses/def4974a520298098d0c81f1c8ce22f2e41d83bc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jknpj"}}