{"action":"created","comment":{"url":"https://api.github.com/repos/darktable-org/darktable/pulls/comments/195562214","pull_request_review_id":128958240,"id":195562214,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTU2MjIxNA==","diff_hunk":"@@ -1113,13 +1114,13 @@ static void _blend_screen(const _blend_buffer_desc_t *bd, const float *a, float\n       float lmin = 0.0, lmax, la, lb;","path":"src/develop/blend.c","position":null,"original_position":343,"commit_id":"e9594e42c26264dcc9e2beef36e55a69ae75cf11","original_commit_id":"c06ca5c09b89d8b7f2ba57277e544fb34a4acdbc","user":{"login":"rabauke","id":1159508,"node_id":"MDQ6VXNlcjExNTk1MDg=","avatar_url":"https://avatars3.githubusercontent.com/u/1159508?v=4","gravatar_id":"","url":"https://api.github.com/users/rabauke","html_url":"https://github.com/rabauke","followers_url":"https://api.github.com/users/rabauke/followers","following_url":"https://api.github.com/users/rabauke/following{/other_user}","gists_url":"https://api.github.com/users/rabauke/gists{/gist_id}","starred_url":"https://api.github.com/users/rabauke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabauke/subscriptions","organizations_url":"https://api.github.com/users/rabauke/orgs","repos_url":"https://api.github.com/users/rabauke/repos","events_url":"https://api.github.com/users/rabauke/events{/privacy}","received_events_url":"https://api.github.com/users/rabauke/received_events","type":"User","site_admin":false},"body":"This has been fixed too, now.","created_at":"2018-06-14T20:34:20Z","updated_at":"2018-06-14T20:34:20Z","html_url":"https://github.com/darktable-org/darktable/pull/1693#discussion_r195562214","pull_request_url":"https://api.github.com/repos/darktable-org/darktable/pulls/1693","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/darktable-org/darktable/pulls/comments/195562214"},"html":{"href":"https://github.com/darktable-org/darktable/pull/1693#discussion_r195562214"},"pull_request":{"href":"https://api.github.com/repos/darktable-org/darktable/pulls/1693"}},"in_reply_to_id":195304605},"pull_request":{"url":"https://api.github.com/repos/darktable-org/darktable/pulls/1693","id":192534705,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNTM0NzA1","html_url":"https://github.com/darktable-org/darktable/pull/1693","diff_url":"https://github.com/darktable-org/darktable/pull/1693.diff","patch_url":"https://github.com/darktable-org/darktable/pull/1693.patch","issue_url":"https://api.github.com/repos/darktable-org/darktable/issues/1693","number":1693,"state":"open","locked":false,"title":"blend: perform all arithmetic floating pint operations in single precision","user":{"login":"rabauke","id":1159508,"node_id":"MDQ6VXNlcjExNTk1MDg=","avatar_url":"https://avatars3.githubusercontent.com/u/1159508?v=4","gravatar_id":"","url":"https://api.github.com/users/rabauke","html_url":"https://github.com/rabauke","followers_url":"https://api.github.com/users/rabauke/followers","following_url":"https://api.github.com/users/rabauke/following{/other_user}","gists_url":"https://api.github.com/users/rabauke/gists{/gist_id}","starred_url":"https://api.github.com/users/rabauke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabauke/subscriptions","organizations_url":"https://api.github.com/users/rabauke/orgs","repos_url":"https://api.github.com/users/rabauke/repos","events_url":"https://api.github.com/users/rabauke/events{/privacy}","received_events_url":"https://api.github.com/users/rabauke/received_events","type":"User","site_admin":false},"body":"This PR is to keep all arithmetic operations, which are performed in a blend operation, in the single precision domain. This givea a (fairly small but easy to get) performance gain. Essentially the double precision functions fabs, fmin and fmax are replaced by the single precision functions fabsf, fminf and fmaxf. Note that M_PI is a double precision constant. Thus, calculations involving M_PI are promoted to double.","created_at":"2018-06-04T21:34:10Z","updated_at":"2018-06-14T20:34:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc5b853905afc0d25b48384c7a2c5bfdff0b121b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/darktable-org/darktable/pulls/1693/commits","review_comments_url":"https://api.github.com/repos/darktable-org/darktable/pulls/1693/comments","review_comment_url":"https://api.github.com/repos/darktable-org/darktable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/darktable-org/darktable/issues/1693/comments","statuses_url":"https://api.github.com/repos/darktable-org/darktable/statuses/e9594e42c26264dcc9e2beef36e55a69ae75cf11","head":{"label":"rabauke:my_blend","ref":"my_blend","sha":"e9594e42c26264dcc9e2beef36e55a69ae75cf11","user":{"login":"rabauke","id":1159508,"node_id":"MDQ6VXNlcjExNTk1MDg=","avatar_url":"https://avatars3.githubusercontent.com/u/1159508?v=4","gravatar_id":"","url":"https://api.github.com/users/rabauke","html_url":"https://github.com/rabauke","followers_url":"https://api.github.com/users/rabauke/followers","following_url":"https://api.github.com/users/rabauke/following{/other_user}","gists_url":"https://api.github.com/users/rabauke/gists{/gist_id}","starred_url":"https://api.github.com/users/rabauke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabauke/subscriptions","organizations_url":"https://api.github.com/users/rabauke/orgs","repos_url":"https://api.github.com/users/rabauke/repos","events_url":"https://api.github.com/users/rabauke/events{/privacy}","received_events_url":"https://api.github.com/users/rabauke/received_events","type":"User","site_admin":false},"repo":{"id":79269222,"node_id":"MDEwOlJlcG9zaXRvcnk3OTI2OTIyMg==","name":"darktable","full_name":"rabauke/darktable","owner":{"login":"rabauke","id":1159508,"node_id":"MDQ6VXNlcjExNTk1MDg=","avatar_url":"https://avatars3.githubusercontent.com/u/1159508?v=4","gravatar_id":"","url":"https://api.github.com/users/rabauke","html_url":"https://github.com/rabauke","followers_url":"https://api.github.com/users/rabauke/followers","following_url":"https://api.github.com/users/rabauke/following{/other_user}","gists_url":"https://api.github.com/users/rabauke/gists{/gist_id}","starred_url":"https://api.github.com/users/rabauke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabauke/subscriptions","organizations_url":"https://api.github.com/users/rabauke/orgs","repos_url":"https://api.github.com/users/rabauke/repos","events_url":"https://api.github.com/users/rabauke/events{/privacy}","received_events_url":"https://api.github.com/users/rabauke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rabauke/darktable","description":"darktable is an open source photography workflow application and raw developer","fork":true,"url":"https://api.github.com/repos/rabauke/darktable","forks_url":"https://api.github.com/repos/rabauke/darktable/forks","keys_url":"https://api.github.com/repos/rabauke/darktable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rabauke/darktable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rabauke/darktable/teams","hooks_url":"https://api.github.com/repos/rabauke/darktable/hooks","issue_events_url":"https://api.github.com/repos/rabauke/darktable/issues/events{/number}","events_url":"https://api.github.com/repos/rabauke/darktable/events","assignees_url":"https://api.github.com/repos/rabauke/darktable/assignees{/user}","branches_url":"https://api.github.com/repos/rabauke/darktable/branches{/branch}","tags_url":"https://api.github.com/repos/rabauke/darktable/tags","blobs_url":"https://api.github.com/repos/rabauke/darktable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rabauke/darktable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rabauke/darktable/git/refs{/sha}","trees_url":"https://api.github.com/repos/rabauke/darktable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rabauke/darktable/statuses/{sha}","languages_url":"https://api.github.com/repos/rabauke/darktable/languages","stargazers_url":"https://api.github.com/repos/rabauke/darktable/stargazers","contributors_url":"https://api.github.com/repos/rabauke/darktable/contributors","subscribers_url":"https://api.github.com/repos/rabauke/darktable/subscribers","subscription_url":"https://api.github.com/repos/rabauke/darktable/subscription","commits_url":"https://api.github.com/repos/rabauke/darktable/commits{/sha}","git_commits_url":"https://api.github.com/repos/rabauke/darktable/git/commits{/sha}","comments_url":"https://api.github.com/repos/rabauke/darktable/comments{/number}","issue_comment_url":"https://api.github.com/repos/rabauke/darktable/issues/comments{/number}","contents_url":"https://api.github.com/repos/rabauke/darktable/contents/{+path}","compare_url":"https://api.github.com/repos/rabauke/darktable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rabauke/darktable/merges","archive_url":"https://api.github.com/repos/rabauke/darktable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rabauke/darktable/downloads","issues_url":"https://api.github.com/repos/rabauke/darktable/issues{/number}","pulls_url":"https://api.github.com/repos/rabauke/darktable/pulls{/number}","milestones_url":"https://api.github.com/repos/rabauke/darktable/milestones{/number}","notifications_url":"https://api.github.com/repos/rabauke/darktable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rabauke/darktable/labels{/name}","releases_url":"https://api.github.com/repos/rabauke/darktable/releases{/id}","deployments_url":"https://api.github.com/repos/rabauke/darktable/deployments","created_at":"2017-01-17T20:34:16Z","updated_at":"2018-06-10T18:02:37Z","pushed_at":"2018-06-14T20:33:17Z","git_url":"git://github.com/rabauke/darktable.git","ssh_url":"git@github.com:rabauke/darktable.git","clone_url":"https://github.com/rabauke/darktable.git","svn_url":"https://github.com/rabauke/darktable","homepage":"https://www.darktable.org","size":252376,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"darktable-org:master","ref":"master","sha":"14d722fe928499938c20f1645eae2a3575d27c0b","user":{"login":"darktable-org","id":1561544,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjE1NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1561544?v=4","gravatar_id":"","url":"https://api.github.com/users/darktable-org","html_url":"https://github.com/darktable-org","followers_url":"https://api.github.com/users/darktable-org/followers","following_url":"https://api.github.com/users/darktable-org/following{/other_user}","gists_url":"https://api.github.com/users/darktable-org/gists{/gist_id}","starred_url":"https://api.github.com/users/darktable-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darktable-org/subscriptions","organizations_url":"https://api.github.com/users/darktable-org/orgs","repos_url":"https://api.github.com/users/darktable-org/repos","events_url":"https://api.github.com/users/darktable-org/events{/privacy}","received_events_url":"https://api.github.com/users/darktable-org/received_events","type":"Organization","site_admin":false},"repo":{"id":3791835,"node_id":"MDEwOlJlcG9zaXRvcnkzNzkxODM1","name":"darktable","full_name":"darktable-org/darktable","owner":{"login":"darktable-org","id":1561544,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjE1NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1561544?v=4","gravatar_id":"","url":"https://api.github.com/users/darktable-org","html_url":"https://github.com/darktable-org","followers_url":"https://api.github.com/users/darktable-org/followers","following_url":"https://api.github.com/users/darktable-org/following{/other_user}","gists_url":"https://api.github.com/users/darktable-org/gists{/gist_id}","starred_url":"https://api.github.com/users/darktable-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darktable-org/subscriptions","organizations_url":"https://api.github.com/users/darktable-org/orgs","repos_url":"https://api.github.com/users/darktable-org/repos","events_url":"https://api.github.com/users/darktable-org/events{/privacy}","received_events_url":"https://api.github.com/users/darktable-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/darktable-org/darktable","description":"darktable is an open source photography workflow application and raw developer","fork":false,"url":"https://api.github.com/repos/darktable-org/darktable","forks_url":"https://api.github.com/repos/darktable-org/darktable/forks","keys_url":"https://api.github.com/repos/darktable-org/darktable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darktable-org/darktable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darktable-org/darktable/teams","hooks_url":"https://api.github.com/repos/darktable-org/darktable/hooks","issue_events_url":"https://api.github.com/repos/darktable-org/darktable/issues/events{/number}","events_url":"https://api.github.com/repos/darktable-org/darktable/events","assignees_url":"https://api.github.com/repos/darktable-org/darktable/assignees{/user}","branches_url":"https://api.github.com/repos/darktable-org/darktable/branches{/branch}","tags_url":"https://api.github.com/repos/darktable-org/darktable/tags","blobs_url":"https://api.github.com/repos/darktable-org/darktable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darktable-org/darktable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darktable-org/darktable/git/refs{/sha}","trees_url":"https://api.github.com/repos/darktable-org/darktable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darktable-org/darktable/statuses/{sha}","languages_url":"https://api.github.com/repos/darktable-org/darktable/languages","stargazers_url":"https://api.github.com/repos/darktable-org/darktable/stargazers","contributors_url":"https://api.github.com/repos/darktable-org/darktable/contributors","subscribers_url":"https://api.github.com/repos/darktable-org/darktable/subscribers","subscription_url":"https://api.github.com/repos/darktable-org/darktable/subscription","commits_url":"https://api.github.com/repos/darktable-org/darktable/commits{/sha}","git_commits_url":"https://api.github.com/repos/darktable-org/darktable/git/commits{/sha}","comments_url":"https://api.github.com/repos/darktable-org/darktable/comments{/number}","issue_comment_url":"https://api.github.com/repos/darktable-org/darktable/issues/comments{/number}","contents_url":"https://api.github.com/repos/darktable-org/darktable/contents/{+path}","compare_url":"https://api.github.com/repos/darktable-org/darktable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darktable-org/darktable/merges","archive_url":"https://api.github.com/repos/darktable-org/darktable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darktable-org/darktable/downloads","issues_url":"https://api.github.com/repos/darktable-org/darktable/issues{/number}","pulls_url":"https://api.github.com/repos/darktable-org/darktable/pulls{/number}","milestones_url":"https://api.github.com/repos/darktable-org/darktable/milestones{/number}","notifications_url":"https://api.github.com/repos/darktable-org/darktable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darktable-org/darktable/labels{/name}","releases_url":"https://api.github.com/repos/darktable-org/darktable/releases{/id}","deployments_url":"https://api.github.com/repos/darktable-org/darktable/deployments","created_at":"2012-03-21T21:53:04Z","updated_at":"2018-06-14T09:33:05Z","pushed_at":"2018-06-14T20:33:19Z","git_url":"git://github.com/darktable-org/darktable.git","ssh_url":"git@github.com:darktable-org/darktable.git","clone_url":"https://github.com/darktable-org/darktable.git","svn_url":"https://github.com/darktable-org/darktable","homepage":"https://www.darktable.org","size":253137,"stargazers_count":2002,"watchers_count":2002,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":478,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":478,"open_issues":49,"watchers":2002,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/darktable-org/darktable/pulls/1693"},"html":{"href":"https://github.com/darktable-org/darktable/pull/1693"},"issue":{"href":"https://api.github.com/repos/darktable-org/darktable/issues/1693"},"comments":{"href":"https://api.github.com/repos/darktable-org/darktable/issues/1693/comments"},"review_comments":{"href":"https://api.github.com/repos/darktable-org/darktable/pulls/1693/comments"},"review_comment":{"href":"https://api.github.com/repos/darktable-org/darktable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/darktable-org/darktable/pulls/1693/commits"},"statuses":{"href":"https://api.github.com/repos/darktable-org/darktable/statuses/e9594e42c26264dcc9e2beef36e55a69ae75cf11"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rabauke"}}