{"action":"created","comment":{"url":"https://api.github.com/repos/all3dp/printing-engine-client/pulls/comments/166399162","pull_request_review_id":94455014,"id":166399162,"diff_hunk":"@@ -142,91 +147,80 @@ describe('model action', () => {\n       sandbox.spy(Cmd, 'dispatch')\n       onProgress(30)\n \n-      expect(Cmd.dispatch, 'to have a call satisfying', [modelAction.uploadProgress(fileId, 30)])\n+      expect(Cmd.dispatch, 'to have a call satisfying', [modelAction.uploadProgress(configId, 30)])\n     })\n \n-    it('triggers the modelAction.uploadComplete() action with the file id and the result from uploadModel()', () => {\n+    it('triggers the modelAction.uploadComplete() action with the configId and the result from uploadModel()', () => {\n       const cmd = findCmd(state, uploadModel, [\n         getFileMock,\n         {unit: 'mm'},\n         expect.it('to be a', 'function')\n       ])\n-      const action = cmd.simulate({success: true, result: getUploadModelMock()})\n+      const action = cmd.simulate({success: true, result: getBackendModelMock({})})\n \n-      expect(action, 'to equal', modelAction.uploadComplete(fileId, getUploadModelMock()))\n+      expect(action, 'to equal', modelAction.uploadComplete(configId, getBackendModelMock({})))\n     })\n \n     it('triggers the modelAction.uploadFail() action with the file id and the error from uploadModel()', () => {\n       const cmd = findCmd(state, uploadModel)\n-      const action = cmd.simulate({success: false, result: getUploadModelMock()})\n+      const action = cmd.simulate({success: false, result: getBackendModelMock({})})\n \n-      expect(action, 'to equal', modelAction.uploadFail(fileId, getUploadModelMock()))\n+      expect(action, 'to equal', modelAction.uploadFail(configId, getBackendModelMock({})))\n     })\n   })\n \n   describe('uploadComplete()', () => {\n-    let fileId\n     let state\n \n     beforeEach(() => {\n       state = withOneUploadedModel()\n     })\n \n-    describe('using selectUploadingFiles() selector', () => {\n-      it('does not return the file anymore', () => {\n-        const model = selectUploadingFiles(getModel(state)).find(m => m.fileId === fileId)\n-\n-        expect(model, 'to be', undefined)\n-      })\n-    })\n-\n-    describe('using selectModels() selector', () => {\n+    describe('using selectModelsOfModelConfigs() selector', () => {\n       it('returns the given backend model with a quantity property', () => {\n-        const model = selectModels(getModel(state)).find(\n-          m => m.modelId === getUploadModelMock().modelId\n+        const model = selectModelsOfModelConfigs(getModel(state)).find(\n+          m => m.modelId === 'model-id-1'\n         )\n \n-        expect(model, 'to satisfy', getUploadModelMock())\n+        expect(model, 'to satisfy', getBackendModelMock({modelId: 'model-id-1'}))\n       })\n     })\n \n-    describe('using selectBasketItems() selector', () => {\n-      it('returns the basket items containing the model', () => {\n-        const basketItems = selectBasketItems(getModel(state))\n-        const model = selectModels(getModel(state))[0]\n-        expect(basketItems, 'to equal', [\n-          {\n-            id: 0, // The id is the index of the array\n-            modelId: 'some-model-id',\n-            quantity: 1,\n-            material: null,\n-            model\n-          }\n-        ])\n+    describe('using selectModelConfigs() selector', () => {","path":"test/integration/app/action-next/model.spec.js","position":212,"original_position":229,"commit_id":"00d8b00fcf11fb6633a8e57170aed027ed442710","original_commit_id":"17f5dd999c3ed18f0fdc484f7d95e7cc499f8727","user":{"login":"dreampulse","id":307704,"avatar_url":"https://avatars3.githubusercontent.com/u/307704?v=4","gravatar_id":"","url":"https://api.github.com/users/dreampulse","html_url":"https://github.com/dreampulse","followers_url":"https://api.github.com/users/dreampulse/followers","following_url":"https://api.github.com/users/dreampulse/following{/other_user}","gists_url":"https://api.github.com/users/dreampulse/gists{/gist_id}","starred_url":"https://api.github.com/users/dreampulse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dreampulse/subscriptions","organizations_url":"https://api.github.com/users/dreampulse/orgs","repos_url":"https://api.github.com/users/dreampulse/repos","events_url":"https://api.github.com/users/dreampulse/events{/privacy}","received_events_url":"https://api.github.com/users/dreampulse/received_events","type":"User","site_admin":false},"body":"Das ist noch offen..","created_at":"2018-02-06T18:31:46Z","updated_at":"2018-02-06T18:31:46Z","html_url":"https://github.com/all3dp/printing-engine-client/pull/557#discussion_r166399162","pull_request_url":"https://api.github.com/repos/all3dp/printing-engine-client/pulls/557","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/all3dp/printing-engine-client/pulls/comments/166399162"},"html":{"href":"https://github.com/all3dp/printing-engine-client/pull/557#discussion_r166399162"},"pull_request":{"href":"https://api.github.com/repos/all3dp/printing-engine-client/pulls/557"}},"in_reply_to_id":166368020},"pull_request":{"url":"https://api.github.com/repos/all3dp/printing-engine-client/pulls/557","id":167393192,"html_url":"https://github.com/all3dp/printing-engine-client/pull/557","diff_url":"https://github.com/all3dp/printing-engine-client/pull/557.diff","patch_url":"https://github.com/all3dp/printing-engine-client/pull/557.patch","issue_url":"https://api.github.com/repos/all3dp/printing-engine-client/issues/557","number":557,"state":"open","locked":false,"title":"Update new types","user":{"login":"dreampulse","id":307704,"avatar_url":"https://avatars3.githubusercontent.com/u/307704?v=4","gravatar_id":"","url":"https://api.github.com/users/dreampulse","html_url":"https://github.com/dreampulse","followers_url":"https://api.github.com/users/dreampulse/followers","following_url":"https://api.github.com/users/dreampulse/following{/other_user}","gists_url":"https://api.github.com/users/dreampulse/gists{/gist_id}","starred_url":"https://api.github.com/users/dreampulse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dreampulse/subscriptions","organizations_url":"https://api.github.com/users/dreampulse/orgs","repos_url":"https://api.github.com/users/dreampulse/repos","events_url":"https://api.github.com/users/dreampulse/events{/privacy}","received_events_url":"https://api.github.com/users/dreampulse/received_events","type":"User","site_admin":false},"body":"# Definition of Done\r\n\r\n- [ ] The code does at least what is defined in the ticket and does not affect any other functionality\r\n- [ ] The PR has a meaningful title\r\n- [ ] There is a link to the issue-id\r\n- [ ] There are no 'hacks' or shortcuts refactoring is preferred\r\n- [ ] The happy case of the app was tested at least once manually\r\n","created_at":"2018-02-06T11:53:36Z","updated_at":"2018-02-06T18:31:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8543f253d8900ba79e512dee10589ae4ef5b03a8","assignee":{"login":"webholics","id":101841,"avatar_url":"https://avatars2.githubusercontent.com/u/101841?v=4","gravatar_id":"","url":"https://api.github.com/users/webholics","html_url":"https://github.com/webholics","followers_url":"https://api.github.com/users/webholics/followers","following_url":"https://api.github.com/users/webholics/following{/other_user}","gists_url":"https://api.github.com/users/webholics/gists{/gist_id}","starred_url":"https://api.github.com/users/webholics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webholics/subscriptions","organizations_url":"https://api.github.com/users/webholics/orgs","repos_url":"https://api.github.com/users/webholics/repos","events_url":"https://api.github.com/users/webholics/events{/privacy}","received_events_url":"https://api.github.com/users/webholics/received_events","type":"User","site_admin":false},"assignees":[{"login":"webholics","id":101841,"avatar_url":"https://avatars2.githubusercontent.com/u/101841?v=4","gravatar_id":"","url":"https://api.github.com/users/webholics","html_url":"https://github.com/webholics","followers_url":"https://api.github.com/users/webholics/followers","following_url":"https://api.github.com/users/webholics/following{/other_user}","gists_url":"https://api.github.com/users/webholics/gists{/gist_id}","starred_url":"https://api.github.com/users/webholics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webholics/subscriptions","organizations_url":"https://api.github.com/users/webholics/orgs","repos_url":"https://api.github.com/users/webholics/repos","events_url":"https://api.github.com/users/webholics/events{/privacy}","received_events_url":"https://api.github.com/users/webholics/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/all3dp/printing-engine-client/pulls/557/commits","review_comments_url":"https://api.github.com/repos/all3dp/printing-engine-client/pulls/557/comments","review_comment_url":"https://api.github.com/repos/all3dp/printing-engine-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/all3dp/printing-engine-client/issues/557/comments","statuses_url":"https://api.github.com/repos/all3dp/printing-engine-client/statuses/00d8b00fcf11fb6633a8e57170aed027ed442710","head":{"label":"all3dp:dev/type-next-update","ref":"dev/type-next-update","sha":"00d8b00fcf11fb6633a8e57170aed027ed442710","user":{"login":"all3dp","id":11058590,"avatar_url":"https://avatars2.githubusercontent.com/u/11058590?v=4","gravatar_id":"","url":"https://api.github.com/users/all3dp","html_url":"https://github.com/all3dp","followers_url":"https://api.github.com/users/all3dp/followers","following_url":"https://api.github.com/users/all3dp/following{/other_user}","gists_url":"https://api.github.com/users/all3dp/gists{/gist_id}","starred_url":"https://api.github.com/users/all3dp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all3dp/subscriptions","organizations_url":"https://api.github.com/users/all3dp/orgs","repos_url":"https://api.github.com/users/all3dp/repos","events_url":"https://api.github.com/users/all3dp/events{/privacy}","received_events_url":"https://api.github.com/users/all3dp/received_events","type":"Organization","site_admin":false},"repo":{"id":74679671,"name":"printing-engine-client","full_name":"all3dp/printing-engine-client","owner":{"login":"all3dp","id":11058590,"avatar_url":"https://avatars2.githubusercontent.com/u/11058590?v=4","gravatar_id":"","url":"https://api.github.com/users/all3dp","html_url":"https://github.com/all3dp","followers_url":"https://api.github.com/users/all3dp/followers","following_url":"https://api.github.com/users/all3dp/following{/other_user}","gists_url":"https://api.github.com/users/all3dp/gists{/gist_id}","starred_url":"https://api.github.com/users/all3dp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all3dp/subscriptions","organizations_url":"https://api.github.com/users/all3dp/orgs","repos_url":"https://api.github.com/users/all3dp/repos","events_url":"https://api.github.com/users/all3dp/events{/privacy}","received_events_url":"https://api.github.com/users/all3dp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/all3dp/printing-engine-client","description":"The price comparison client","fork":false,"url":"https://api.github.com/repos/all3dp/printing-engine-client","forks_url":"https://api.github.com/repos/all3dp/printing-engine-client/forks","keys_url":"https://api.github.com/repos/all3dp/printing-engine-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/all3dp/printing-engine-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/all3dp/printing-engine-client/teams","hooks_url":"https://api.github.com/repos/all3dp/printing-engine-client/hooks","issue_events_url":"https://api.github.com/repos/all3dp/printing-engine-client/issues/events{/number}","events_url":"https://api.github.com/repos/all3dp/printing-engine-client/events","assignees_url":"https://api.github.com/repos/all3dp/printing-engine-client/assignees{/user}","branches_url":"https://api.github.com/repos/all3dp/printing-engine-client/branches{/branch}","tags_url":"https://api.github.com/repos/all3dp/printing-engine-client/tags","blobs_url":"https://api.github.com/repos/all3dp/printing-engine-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/all3dp/printing-engine-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/all3dp/printing-engine-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/all3dp/printing-engine-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/all3dp/printing-engine-client/statuses/{sha}","languages_url":"https://api.github.com/repos/all3dp/printing-engine-client/languages","stargazers_url":"https://api.github.com/repos/all3dp/printing-engine-client/stargazers","contributors_url":"https://api.github.com/repos/all3dp/printing-engine-client/contributors","subscribers_url":"https://api.github.com/repos/all3dp/printing-engine-client/subscribers","subscription_url":"https://api.github.com/repos/all3dp/printing-engine-client/subscription","commits_url":"https://api.github.com/repos/all3dp/printing-engine-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/all3dp/printing-engine-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/all3dp/printing-engine-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/all3dp/printing-engine-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/all3dp/printing-engine-client/contents/{+path}","compare_url":"https://api.github.com/repos/all3dp/printing-engine-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/all3dp/printing-engine-client/merges","archive_url":"https://api.github.com/repos/all3dp/printing-engine-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/all3dp/printing-engine-client/downloads","issues_url":"https://api.github.com/repos/all3dp/printing-engine-client/issues{/number}","pulls_url":"https://api.github.com/repos/all3dp/printing-engine-client/pulls{/number}","milestones_url":"https://api.github.com/repos/all3dp/printing-engine-client/milestones{/number}","notifications_url":"https://api.github.com/repos/all3dp/printing-engine-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/all3dp/printing-engine-client/labels{/name}","releases_url":"https://api.github.com/repos/all3dp/printing-engine-client/releases{/id}","deployments_url":"https://api.github.com/repos/all3dp/printing-engine-client/deployments","created_at":"2016-11-24T14:19:39Z","updated_at":"2017-10-12T11:55:24Z","pushed_at":"2018-02-06T18:12:39Z","git_url":"git://github.com/all3dp/printing-engine-client.git","ssh_url":"git@github.com:all3dp/printing-engine-client.git","clone_url":"https://github.com/all3dp/printing-engine-client.git","svn_url":"https://github.com/all3dp/printing-engine-client","homepage":"http://print.all3dp.com","size":2560,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":108,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":108,"watchers":1,"default_branch":"multi-model-upload"}},"base":{"label":"all3dp:multi-model-upload","ref":"multi-model-upload","sha":"968afbf96714cffe763111264f0889eca22f2bcb","user":{"login":"all3dp","id":11058590,"avatar_url":"https://avatars2.githubusercontent.com/u/11058590?v=4","gravatar_id":"","url":"https://api.github.com/users/all3dp","html_url":"https://github.com/all3dp","followers_url":"https://api.github.com/users/all3dp/followers","following_url":"https://api.github.com/users/all3dp/following{/other_user}","gists_url":"https://api.github.com/users/all3dp/gists{/gist_id}","starred_url":"https://api.github.com/users/all3dp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all3dp/subscriptions","organizations_url":"https://api.github.com/users/all3dp/orgs","repos_url":"https://api.github.com/users/all3dp/repos","events_url":"https://api.github.com/users/all3dp/events{/privacy}","received_events_url":"https://api.github.com/users/all3dp/received_events","type":"Organization","site_admin":false},"repo":{"id":74679671,"name":"printing-engine-client","full_name":"all3dp/printing-engine-client","owner":{"login":"all3dp","id":11058590,"avatar_url":"https://avatars2.githubusercontent.com/u/11058590?v=4","gravatar_id":"","url":"https://api.github.com/users/all3dp","html_url":"https://github.com/all3dp","followers_url":"https://api.github.com/users/all3dp/followers","following_url":"https://api.github.com/users/all3dp/following{/other_user}","gists_url":"https://api.github.com/users/all3dp/gists{/gist_id}","starred_url":"https://api.github.com/users/all3dp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all3dp/subscriptions","organizations_url":"https://api.github.com/users/all3dp/orgs","repos_url":"https://api.github.com/users/all3dp/repos","events_url":"https://api.github.com/users/all3dp/events{/privacy}","received_events_url":"https://api.github.com/users/all3dp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/all3dp/printing-engine-client","description":"The price comparison client","fork":false,"url":"https://api.github.com/repos/all3dp/printing-engine-client","forks_url":"https://api.github.com/repos/all3dp/printing-engine-client/forks","keys_url":"https://api.github.com/repos/all3dp/printing-engine-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/all3dp/printing-engine-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/all3dp/printing-engine-client/teams","hooks_url":"https://api.github.com/repos/all3dp/printing-engine-client/hooks","issue_events_url":"https://api.github.com/repos/all3dp/printing-engine-client/issues/events{/number}","events_url":"https://api.github.com/repos/all3dp/printing-engine-client/events","assignees_url":"https://api.github.com/repos/all3dp/printing-engine-client/assignees{/user}","branches_url":"https://api.github.com/repos/all3dp/printing-engine-client/branches{/branch}","tags_url":"https://api.github.com/repos/all3dp/printing-engine-client/tags","blobs_url":"https://api.github.com/repos/all3dp/printing-engine-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/all3dp/printing-engine-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/all3dp/printing-engine-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/all3dp/printing-engine-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/all3dp/printing-engine-client/statuses/{sha}","languages_url":"https://api.github.com/repos/all3dp/printing-engine-client/languages","stargazers_url":"https://api.github.com/repos/all3dp/printing-engine-client/stargazers","contributors_url":"https://api.github.com/repos/all3dp/printing-engine-client/contributors","subscribers_url":"https://api.github.com/repos/all3dp/printing-engine-client/subscribers","subscription_url":"https://api.github.com/repos/all3dp/printing-engine-client/subscription","commits_url":"https://api.github.com/repos/all3dp/printing-engine-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/all3dp/printing-engine-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/all3dp/printing-engine-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/all3dp/printing-engine-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/all3dp/printing-engine-client/contents/{+path}","compare_url":"https://api.github.com/repos/all3dp/printing-engine-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/all3dp/printing-engine-client/merges","archive_url":"https://api.github.com/repos/all3dp/printing-engine-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/all3dp/printing-engine-client/downloads","issues_url":"https://api.github.com/repos/all3dp/printing-engine-client/issues{/number}","pulls_url":"https://api.github.com/repos/all3dp/printing-engine-client/pulls{/number}","milestones_url":"https://api.github.com/repos/all3dp/printing-engine-client/milestones{/number}","notifications_url":"https://api.github.com/repos/all3dp/printing-engine-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/all3dp/printing-engine-client/labels{/name}","releases_url":"https://api.github.com/repos/all3dp/printing-engine-client/releases{/id}","deployments_url":"https://api.github.com/repos/all3dp/printing-engine-client/deployments","created_at":"2016-11-24T14:19:39Z","updated_at":"2017-10-12T11:55:24Z","pushed_at":"2018-02-06T18:12:39Z","git_url":"git://github.com/all3dp/printing-engine-client.git","ssh_url":"git@github.com:all3dp/printing-engine-client.git","clone_url":"https://github.com/all3dp/printing-engine-client.git","svn_url":"https://github.com/all3dp/printing-engine-client","homepage":"http://print.all3dp.com","size":2560,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":108,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":108,"watchers":1,"default_branch":"multi-model-upload"}},"_links":{"self":{"href":"https://api.github.com/repos/all3dp/printing-engine-client/pulls/557"},"html":{"href":"https://github.com/all3dp/printing-engine-client/pull/557"},"issue":{"href":"https://api.github.com/repos/all3dp/printing-engine-client/issues/557"},"comments":{"href":"https://api.github.com/repos/all3dp/printing-engine-client/issues/557/comments"},"review_comments":{"href":"https://api.github.com/repos/all3dp/printing-engine-client/pulls/557/comments"},"review_comment":{"href":"https://api.github.com/repos/all3dp/printing-engine-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/all3dp/printing-engine-client/pulls/557/commits"},"statuses":{"href":"https://api.github.com/repos/all3dp/printing-engine-client/statuses/00d8b00fcf11fb6633a8e57170aed027ed442710"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dreampulse"}}