{"action":"created","issue":{"url":"https://api.github.com/repos/chris-marsh/pureline/issues/11","repository_url":"https://api.github.com/repos/chris-marsh/pureline","labels_url":"https://api.github.com/repos/chris-marsh/pureline/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/chris-marsh/pureline/issues/11/comments","events_url":"https://api.github.com/repos/chris-marsh/pureline/issues/11/events","html_url":"https://github.com/chris-marsh/pureline/pull/11","id":326697251,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwNzE4MDM2","number":11,"title":"Dont erase the line at the end of PS1","user":{"login":"rockandska","id":24546770,"node_id":"MDQ6VXNlcjI0NTQ2Nzcw","avatar_url":"https://avatars0.githubusercontent.com/u/24546770?v=4","gravatar_id":"","url":"https://api.github.com/users/rockandska","html_url":"https://github.com/rockandska","followers_url":"https://api.github.com/users/rockandska/followers","following_url":"https://api.github.com/users/rockandska/following{/other_user}","gists_url":"https://api.github.com/users/rockandska/gists{/gist_id}","starred_url":"https://api.github.com/users/rockandska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rockandska/subscriptions","organizations_url":"https://api.github.com/users/rockandska/orgs","repos_url":"https://api.github.com/users/rockandska/repos","events_url":"https://api.github.com/users/rockandska/events{/privacy}","received_events_url":"https://api.github.com/users/rockandska/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-05-26T00:53:43Z","updated_at":"2018-07-25T20:12:58Z","closed_at":"2018-06-24T08:57:23Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/chris-marsh/pureline/pulls/11","html_url":"https://github.com/chris-marsh/pureline/pull/11","diff_url":"https://github.com/chris-marsh/pureline/pull/11.diff","patch_url":"https://github.com/chris-marsh/pureline/pull/11.patch"},"body":"Erasing the line with escape sequence K seems to prevent the reverse history to works correctly.\r\nWhen we do a reverse history search with ctrl+r inside a shell and press  \"escape\" to undo, the line is erase instead of the normal behavior who let the user edit the command found.\r\n\r\nThis PR correct this and I don't see weird side effect until now.\r\n\r\nNormal:\r\n```\r\n(reverse-i-search)`sour': source /tmp/pureline/pureline /tmp/pureline/config.conf    ----> press escape\r\n $  /tmp/pureline  source /tmp/pureline/pureline /tmp/pureline/config.conf \r\n```\r\n\r\nActual behavior:\r\n```\r\n(reverse-i-search)`sour': source /tmp/pureline/pureline /tmp/pureline/config.conf    ----> press escape\r\n $  /tmp/pureline \r\n```"},"comment":{"url":"https://api.github.com/repos/chris-marsh/pureline/issues/comments/407880221","html_url":"https://github.com/chris-marsh/pureline/pull/11#issuecomment-407880221","issue_url":"https://api.github.com/repos/chris-marsh/pureline/issues/11","id":407880221,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzg4MDIyMQ==","user":{"login":"rockandska","id":24546770,"node_id":"MDQ6VXNlcjI0NTQ2Nzcw","avatar_url":"https://avatars0.githubusercontent.com/u/24546770?v=4","gravatar_id":"","url":"https://api.github.com/users/rockandska","html_url":"https://github.com/rockandska","followers_url":"https://api.github.com/users/rockandska/followers","following_url":"https://api.github.com/users/rockandska/following{/other_user}","gists_url":"https://api.github.com/users/rockandska/gists{/gist_id}","starred_url":"https://api.github.com/users/rockandska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rockandska/subscriptions","organizations_url":"https://api.github.com/users/rockandska/orgs","repos_url":"https://api.github.com/users/rockandska/repos","events_url":"https://api.github.com/users/rockandska/events{/privacy}","received_events_url":"https://api.github.com/users/rockandska/received_events","type":"User","site_admin":false},"created_at":"2018-07-25T20:12:58Z","updated_at":"2018-07-25T20:12:58Z","author_association":"CONTRIBUTOR","body":"Reproducible when you at least add the newline module (in some use case, the history command line are mixed with itself)\r\n[![asciicast](https://asciinema.org/a/zxRKb5x5jMLozsYlMK81YqZAS.png)](https://asciinema.org/a/zxRKb5x5jMLozsYlMK81YqZAS)\r\n\r\nDon't have this behavior with the commit of this PR:\r\n[![asciicast](https://asciinema.org/a/nS15f1FRq02Lkzynlmz5J4Qzl.png)](https://asciinema.org/a/nS15f1FRq02Lkzynlmz5J4Qzl)\r\n\r\nCommands done before \"asciinema rec\" were :  \r\n```\r\n$ exec env -i bash --noprofile --norc\r\nbash-4.3$ export SHELL=\"/bin/bash --norc --noprofile --login\"                \r\nbash-4.3$ export TERM=xterm                                                  \r\nbash-4.3$ export LANG=en_GB.utf8\r\nbash-4.3$ export HOME=/home/yoann\r\n```"}}
{"actor":{"display_login":"rockandska"}}