{"action":"created","issue":{"url":"https://api.github.com/repos/concrete5/concrete5/issues/7383","repository_url":"https://api.github.com/repos/concrete5/concrete5","labels_url":"https://api.github.com/repos/concrete5/concrete5/issues/7383/labels{/name}","comments_url":"https://api.github.com/repos/concrete5/concrete5/issues/7383/comments","events_url":"https://api.github.com/repos/concrete5/concrete5/issues/7383/events","html_url":"https://github.com/concrete5/concrete5/pull/7383","id":387908003,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MjkzNDg2","number":7383,"title":" Always use an ErrorList instance when validating a block on edit","user":{"login":"marvinde","id":29543909,"node_id":"MDQ6VXNlcjI5NTQzOTA5","avatar_url":"https://avatars3.githubusercontent.com/u/29543909?v=4","gravatar_id":"","url":"https://api.github.com/users/marvinde","html_url":"https://github.com/marvinde","followers_url":"https://api.github.com/users/marvinde/followers","following_url":"https://api.github.com/users/marvinde/following{/other_user}","gists_url":"https://api.github.com/users/marvinde/gists{/gist_id}","starred_url":"https://api.github.com/users/marvinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marvinde/subscriptions","organizations_url":"https://api.github.com/users/marvinde/orgs","repos_url":"https://api.github.com/users/marvinde/repos","events_url":"https://api.github.com/users/marvinde/events{/privacy}","received_events_url":"https://api.github.com/users/marvinde/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-12-05T19:24:36Z","updated_at":"2018-12-12T07:14:28Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/concrete5/concrete5/pulls/7383","html_url":"https://github.com/concrete5/concrete5/pull/7383","diff_url":"https://github.com/concrete5/concrete5/pull/7383.diff","patch_url":"https://github.com/concrete5/concrete5/pull/7383.patch"},"body":"Fixes #7379 \r\n\r\nAn other fix for this issue would have been to return an ErrorList instance in the `validate()` method in concrete/src/Block/BlockController.php but if other functions use it and expect true they might break too.\r\n\r\n@aembler What do you think ?"},"comment":{"url":"https://api.github.com/repos/concrete5/concrete5/issues/comments/446486305","html_url":"https://github.com/concrete5/concrete5/pull/7383#issuecomment-446486305","issue_url":"https://api.github.com/repos/concrete5/concrete5/issues/7383","id":446486305,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjQ4NjMwNQ==","user":{"login":"marvinde","id":29543909,"node_id":"MDQ6VXNlcjI5NTQzOTA5","avatar_url":"https://avatars3.githubusercontent.com/u/29543909?v=4","gravatar_id":"","url":"https://api.github.com/users/marvinde","html_url":"https://github.com/marvinde","followers_url":"https://api.github.com/users/marvinde/followers","following_url":"https://api.github.com/users/marvinde/following{/other_user}","gists_url":"https://api.github.com/users/marvinde/gists{/gist_id}","starred_url":"https://api.github.com/users/marvinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marvinde/subscriptions","organizations_url":"https://api.github.com/users/marvinde/orgs","repos_url":"https://api.github.com/users/marvinde/repos","events_url":"https://api.github.com/users/marvinde/events{/privacy}","received_events_url":"https://api.github.com/users/marvinde/received_events","type":"User","site_admin":false},"created_at":"2018-12-12T07:14:28Z","updated_at":"2018-12-12T07:14:28Z","author_association":"CONTRIBUTOR","body":"@aembler The **BlockController** class returns `true` in the `validate()` method ([here](https://github.com/concrete5/concrete5/blob/24c24624f05d04865b1f7e5b75373cd1df620b59/concrete/src/Block/BlockController.php#L140)), which is used when the block doesn't have a custom `validate()` method."}}
{"actor":{"display_login":"marvinde"}}