{"action":"created","comment":{"url":"https://api.github.com/repos/deepmipt/DeepPavlov/pulls/comments/176334471","pull_request_review_id":106016491,"id":176334471,"diff_hunk":"@@ -55,9 +55,8 @@ def from_params(params: Dict, **kwargs) -> Component:\n             log.exception(e)\n             raise e\n \n-    try:\n-        cls_name = config_params.pop('name')\n-    except KeyError:\n+    cls_name = config_params.pop('name', None)\n+    if not cls_name:","path":"deeppavlov/core/common/params.py","position":8,"original_position":8,"commit_id":"fb0ffe9b7eae8372374ca9e5bdbcfbcc16237601","original_commit_id":"fb0ffe9b7eae8372374ca9e5bdbcfbcc16237601","user":{"login":"my-master","id":9787475,"avatar_url":"https://avatars1.githubusercontent.com/u/9787475?v=4","gravatar_id":"","url":"https://api.github.com/users/my-master","html_url":"https://github.com/my-master","followers_url":"https://api.github.com/users/my-master/followers","following_url":"https://api.github.com/users/my-master/following{/other_user}","gists_url":"https://api.github.com/users/my-master/gists{/gist_id}","starred_url":"https://api.github.com/users/my-master/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/my-master/subscriptions","organizations_url":"https://api.github.com/users/my-master/orgs","repos_url":"https://api.github.com/users/my-master/repos","events_url":"https://api.github.com/users/my-master/events{/privacy}","received_events_url":"https://api.github.com/users/my-master/received_events","type":"User","site_admin":false},"body":"Shouldn't throw an exception, if there is a valid checking key method like \"pop\".","created_at":"2018-03-22T08:10:14Z","updated_at":"2018-03-22T08:10:15Z","html_url":"https://github.com/deepmipt/DeepPavlov/pull/130#discussion_r176334471","pull_request_url":"https://api.github.com/repos/deepmipt/DeepPavlov/pulls/130","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/deepmipt/DeepPavlov/pulls/comments/176334471"},"html":{"href":"https://github.com/deepmipt/DeepPavlov/pull/130#discussion_r176334471"},"pull_request":{"href":"https://api.github.com/repos/deepmipt/DeepPavlov/pulls/130"}},"in_reply_to_id":176111808},"pull_request":{"url":"https://api.github.com/repos/deepmipt/DeepPavlov/pulls/130","id":176458879,"html_url":"https://github.com/deepmipt/DeepPavlov/pull/130","diff_url":"https://github.com/deepmipt/DeepPavlov/pull/130.diff","patch_url":"https://github.com/deepmipt/DeepPavlov/pull/130.patch","issue_url":"https://api.github.com/repos/deepmipt/DeepPavlov/issues/130","number":130,"state":"open","locked":false,"title":"Odqa","user":{"login":"my-master","id":9787475,"avatar_url":"https://avatars1.githubusercontent.com/u/9787475?v=4","gravatar_id":"","url":"https://api.github.com/users/my-master","html_url":"https://github.com/my-master","followers_url":"https://api.github.com/users/my-master/followers","following_url":"https://api.github.com/users/my-master/following{/other_user}","gists_url":"https://api.github.com/users/my-master/gists{/gist_id}","starred_url":"https://api.github.com/users/my-master/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/my-master/subscriptions","organizations_url":"https://api.github.com/users/my-master/orgs","repos_url":"https://api.github.com/users/my-master/repos","events_url":"https://api.github.com/users/my-master/events{/privacy}","received_events_url":"https://api.github.com/users/my-master/received_events","type":"User","site_admin":false},"body":"Major changes in *core*:\r\n\r\n* Rename DatasetBasicIterator -> DatasetLearningIterator\r\n* Add class DatasetFittingIterator\r\n* Add fit_batches() method to Estimator\r\n* Add fit_batches() to train.py\r\n* Make DataReader optional in JSON config in train_model_from_config()\r\n* Rename method batch_generator() -> gen_batch() in DatasetLearningIterator (former DatasetBasicIterator)\r\n* Rename method iter_all() -> get_instances() in DatasetLearningIterator (former DatasetBasicIterator)\r\n\r\nChanges in the core are made due to lack of functionality for fitting on batches, for parallel fitting on batches (should be solved later) and for non-availability of the iterator during the fitting process. Vocabs and iterators, as they are, are not useful for large datasets.\r\nThere are a few errors in the project architecture that should be addressed in the nearest future.\r\n\r\nOther changes:\r\n* Edit all project code to work with new core changes. Basically, these are minor changes.\r\n* Add ODQA model classes (models.vectorizers.HashingTfidfVectorizer, models.odqa.TfidfRanker)\r\n\r\nTests passed except for the last test for Ranking model (not enough memory on my GPU).\r\n","created_at":"2018-03-21T12:22:14Z","updated_at":"2018-03-22T08:10:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/deepmipt/DeepPavlov/pulls/130/commits","review_comments_url":"https://api.github.com/repos/deepmipt/DeepPavlov/pulls/130/comments","review_comment_url":"https://api.github.com/repos/deepmipt/DeepPavlov/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deepmipt/DeepPavlov/issues/130/comments","statuses_url":"https://api.github.com/repos/deepmipt/DeepPavlov/statuses/fb0ffe9b7eae8372374ca9e5bdbcfbcc16237601","head":{"label":"deepmipt:odqa","ref":"odqa","sha":"fb0ffe9b7eae8372374ca9e5bdbcfbcc16237601","user":{"login":"deepmipt","id":29918795,"avatar_url":"https://avatars0.githubusercontent.com/u/29918795?v=4","gravatar_id":"","url":"https://api.github.com/users/deepmipt","html_url":"https://github.com/deepmipt","followers_url":"https://api.github.com/users/deepmipt/followers","following_url":"https://api.github.com/users/deepmipt/following{/other_user}","gists_url":"https://api.github.com/users/deepmipt/gists{/gist_id}","starred_url":"https://api.github.com/users/deepmipt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepmipt/subscriptions","organizations_url":"https://api.github.com/users/deepmipt/orgs","repos_url":"https://api.github.com/users/deepmipt/repos","events_url":"https://api.github.com/users/deepmipt/events{/privacy}","received_events_url":"https://api.github.com/users/deepmipt/received_events","type":"Organization","site_admin":false},"repo":{"id":111113343,"name":"DeepPavlov","full_name":"deepmipt/DeepPavlov","owner":{"login":"deepmipt","id":29918795,"avatar_url":"https://avatars0.githubusercontent.com/u/29918795?v=4","gravatar_id":"","url":"https://api.github.com/users/deepmipt","html_url":"https://github.com/deepmipt","followers_url":"https://api.github.com/users/deepmipt/followers","following_url":"https://api.github.com/users/deepmipt/following{/other_user}","gists_url":"https://api.github.com/users/deepmipt/gists{/gist_id}","starred_url":"https://api.github.com/users/deepmipt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepmipt/subscriptions","organizations_url":"https://api.github.com/users/deepmipt/orgs","repos_url":"https://api.github.com/users/deepmipt/repos","events_url":"https://api.github.com/users/deepmipt/events{/privacy}","received_events_url":"https://api.github.com/users/deepmipt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deepmipt/DeepPavlov","description":"An open source library for building end-to-end dialog systems and training chatbots.","fork":false,"url":"https://api.github.com/repos/deepmipt/DeepPavlov","forks_url":"https://api.github.com/repos/deepmipt/DeepPavlov/forks","keys_url":"https://api.github.com/repos/deepmipt/DeepPavlov/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deepmipt/DeepPavlov/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deepmipt/DeepPavlov/teams","hooks_url":"https://api.github.com/repos/deepmipt/DeepPavlov/hooks","issue_events_url":"https://api.github.com/repos/deepmipt/DeepPavlov/issues/events{/number}","events_url":"https://api.github.com/repos/deepmipt/DeepPavlov/events","assignees_url":"https://api.github.com/repos/deepmipt/DeepPavlov/assignees{/user}","branches_url":"https://api.github.com/repos/deepmipt/DeepPavlov/branches{/branch}","tags_url":"https://api.github.com/repos/deepmipt/DeepPavlov/tags","blobs_url":"https://api.github.com/repos/deepmipt/DeepPavlov/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deepmipt/DeepPavlov/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deepmipt/DeepPavlov/git/refs{/sha}","trees_url":"https://api.github.com/repos/deepmipt/DeepPavlov/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deepmipt/DeepPavlov/statuses/{sha}","languages_url":"https://api.github.com/repos/deepmipt/DeepPavlov/languages","stargazers_url":"https://api.github.com/repos/deepmipt/DeepPavlov/stargazers","contributors_url":"https://api.github.com/repos/deepmipt/DeepPavlov/contributors","subscribers_url":"https://api.github.com/repos/deepmipt/DeepPavlov/subscribers","subscription_url":"https://api.github.com/repos/deepmipt/DeepPavlov/subscription","commits_url":"https://api.github.com/repos/deepmipt/DeepPavlov/commits{/sha}","git_commits_url":"https://api.github.com/repos/deepmipt/DeepPavlov/git/commits{/sha}","comments_url":"https://api.github.com/repos/deepmipt/DeepPavlov/comments{/number}","issue_comment_url":"https://api.github.com/repos/deepmipt/DeepPavlov/issues/comments{/number}","contents_url":"https://api.github.com/repos/deepmipt/DeepPavlov/contents/{+path}","compare_url":"https://api.github.com/repos/deepmipt/DeepPavlov/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deepmipt/DeepPavlov/merges","archive_url":"https://api.github.com/repos/deepmipt/DeepPavlov/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deepmipt/DeepPavlov/downloads","issues_url":"https://api.github.com/repos/deepmipt/DeepPavlov/issues{/number}","pulls_url":"https://api.github.com/repos/deepmipt/DeepPavlov/pulls{/number}","milestones_url":"https://api.github.com/repos/deepmipt/DeepPavlov/milestones{/number}","notifications_url":"https://api.github.com/repos/deepmipt/DeepPavlov/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deepmipt/DeepPavlov/labels{/name}","releases_url":"https://api.github.com/repos/deepmipt/DeepPavlov/releases{/id}","deployments_url":"https://api.github.com/repos/deepmipt/DeepPavlov/deployments","created_at":"2017-11-17T14:35:29Z","updated_at":"2018-03-22T05:45:07Z","pushed_at":"2018-03-22T07:44:54Z","git_url":"git://github.com/deepmipt/DeepPavlov.git","ssh_url":"git@github.com:deepmipt/DeepPavlov.git","clone_url":"https://github.com/deepmipt/DeepPavlov.git","svn_url":"https://github.com/deepmipt/DeepPavlov","homepage":null,"size":14550,"stargazers_count":1505,"watchers_count":1505,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":165,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":165,"open_issues":12,"watchers":1505,"default_branch":"master"}},"base":{"label":"deepmipt:dev","ref":"dev","sha":"32c9f369309f97b9a35d9d47260c5e4bd75b2b6e","user":{"login":"deepmipt","id":29918795,"avatar_url":"https://avatars0.githubusercontent.com/u/29918795?v=4","gravatar_id":"","url":"https://api.github.com/users/deepmipt","html_url":"https://github.com/deepmipt","followers_url":"https://api.github.com/users/deepmipt/followers","following_url":"https://api.github.com/users/deepmipt/following{/other_user}","gists_url":"https://api.github.com/users/deepmipt/gists{/gist_id}","starred_url":"https://api.github.com/users/deepmipt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepmipt/subscriptions","organizations_url":"https://api.github.com/users/deepmipt/orgs","repos_url":"https://api.github.com/users/deepmipt/repos","events_url":"https://api.github.com/users/deepmipt/events{/privacy}","received_events_url":"https://api.github.com/users/deepmipt/received_events","type":"Organization","site_admin":false},"repo":{"id":111113343,"name":"DeepPavlov","full_name":"deepmipt/DeepPavlov","owner":{"login":"deepmipt","id":29918795,"avatar_url":"https://avatars0.githubusercontent.com/u/29918795?v=4","gravatar_id":"","url":"https://api.github.com/users/deepmipt","html_url":"https://github.com/deepmipt","followers_url":"https://api.github.com/users/deepmipt/followers","following_url":"https://api.github.com/users/deepmipt/following{/other_user}","gists_url":"https://api.github.com/users/deepmipt/gists{/gist_id}","starred_url":"https://api.github.com/users/deepmipt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepmipt/subscriptions","organizations_url":"https://api.github.com/users/deepmipt/orgs","repos_url":"https://api.github.com/users/deepmipt/repos","events_url":"https://api.github.com/users/deepmipt/events{/privacy}","received_events_url":"https://api.github.com/users/deepmipt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deepmipt/DeepPavlov","description":"An open source library for building end-to-end dialog systems and training chatbots.","fork":false,"url":"https://api.github.com/repos/deepmipt/DeepPavlov","forks_url":"https://api.github.com/repos/deepmipt/DeepPavlov/forks","keys_url":"https://api.github.com/repos/deepmipt/DeepPavlov/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deepmipt/DeepPavlov/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deepmipt/DeepPavlov/teams","hooks_url":"https://api.github.com/repos/deepmipt/DeepPavlov/hooks","issue_events_url":"https://api.github.com/repos/deepmipt/DeepPavlov/issues/events{/number}","events_url":"https://api.github.com/repos/deepmipt/DeepPavlov/events","assignees_url":"https://api.github.com/repos/deepmipt/DeepPavlov/assignees{/user}","branches_url":"https://api.github.com/repos/deepmipt/DeepPavlov/branches{/branch}","tags_url":"https://api.github.com/repos/deepmipt/DeepPavlov/tags","blobs_url":"https://api.github.com/repos/deepmipt/DeepPavlov/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deepmipt/DeepPavlov/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deepmipt/DeepPavlov/git/refs{/sha}","trees_url":"https://api.github.com/repos/deepmipt/DeepPavlov/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deepmipt/DeepPavlov/statuses/{sha}","languages_url":"https://api.github.com/repos/deepmipt/DeepPavlov/languages","stargazers_url":"https://api.github.com/repos/deepmipt/DeepPavlov/stargazers","contributors_url":"https://api.github.com/repos/deepmipt/DeepPavlov/contributors","subscribers_url":"https://api.github.com/repos/deepmipt/DeepPavlov/subscribers","subscription_url":"https://api.github.com/repos/deepmipt/DeepPavlov/subscription","commits_url":"https://api.github.com/repos/deepmipt/DeepPavlov/commits{/sha}","git_commits_url":"https://api.github.com/repos/deepmipt/DeepPavlov/git/commits{/sha}","comments_url":"https://api.github.com/repos/deepmipt/DeepPavlov/comments{/number}","issue_comment_url":"https://api.github.com/repos/deepmipt/DeepPavlov/issues/comments{/number}","contents_url":"https://api.github.com/repos/deepmipt/DeepPavlov/contents/{+path}","compare_url":"https://api.github.com/repos/deepmipt/DeepPavlov/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deepmipt/DeepPavlov/merges","archive_url":"https://api.github.com/repos/deepmipt/DeepPavlov/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deepmipt/DeepPavlov/downloads","issues_url":"https://api.github.com/repos/deepmipt/DeepPavlov/issues{/number}","pulls_url":"https://api.github.com/repos/deepmipt/DeepPavlov/pulls{/number}","milestones_url":"https://api.github.com/repos/deepmipt/DeepPavlov/milestones{/number}","notifications_url":"https://api.github.com/repos/deepmipt/DeepPavlov/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deepmipt/DeepPavlov/labels{/name}","releases_url":"https://api.github.com/repos/deepmipt/DeepPavlov/releases{/id}","deployments_url":"https://api.github.com/repos/deepmipt/DeepPavlov/deployments","created_at":"2017-11-17T14:35:29Z","updated_at":"2018-03-22T05:45:07Z","pushed_at":"2018-03-22T07:44:54Z","git_url":"git://github.com/deepmipt/DeepPavlov.git","ssh_url":"git@github.com:deepmipt/DeepPavlov.git","clone_url":"https://github.com/deepmipt/DeepPavlov.git","svn_url":"https://github.com/deepmipt/DeepPavlov","homepage":null,"size":14550,"stargazers_count":1505,"watchers_count":1505,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":165,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":165,"open_issues":12,"watchers":1505,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deepmipt/DeepPavlov/pulls/130"},"html":{"href":"https://github.com/deepmipt/DeepPavlov/pull/130"},"issue":{"href":"https://api.github.com/repos/deepmipt/DeepPavlov/issues/130"},"comments":{"href":"https://api.github.com/repos/deepmipt/DeepPavlov/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/deepmipt/DeepPavlov/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/deepmipt/DeepPavlov/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deepmipt/DeepPavlov/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/deepmipt/DeepPavlov/statuses/fb0ffe9b7eae8372374ca9e5bdbcfbcc16237601"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"my-master"}}