{"action":"created","comment":{"url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/pulls/comments/187602209","pull_request_review_id":119418900,"id":187602209,"diff_hunk":"@@ -36,13 +37,21 @@ describe('AppointmentsCalendarViewController', function () {\n         createController();\n     });\n \n+    it('should not fetch appointments when doFetchAppointmentsData is set to false', function () {\n+        state.params = {doFetchAppointmentsData: false}; \n+        expect(appointmentsService.getAllAppointments).not.toHaveBeenCalled();\n+        expect(spinner.forPromise).not.toHaveBeenCalled();\n+        ","path":"ui/test/unit/appointments/controllers/manage/calendar/appointmentsCalendarViewController.spec.js","position":26,"original_position":26,"commit_id":"fd09027accf60f43d4696065c711a915d8f0e0af","original_commit_id":"fd09027accf60f43d4696065c711a915d8f0e0af","user":{"login":"sumanmaity112","id":15261043,"avatar_url":"https://avatars2.githubusercontent.com/u/15261043?v=4","gravatar_id":"","url":"https://api.github.com/users/sumanmaity112","html_url":"https://github.com/sumanmaity112","followers_url":"https://api.github.com/users/sumanmaity112/followers","following_url":"https://api.github.com/users/sumanmaity112/following{/other_user}","gists_url":"https://api.github.com/users/sumanmaity112/gists{/gist_id}","starred_url":"https://api.github.com/users/sumanmaity112/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumanmaity112/subscriptions","organizations_url":"https://api.github.com/users/sumanmaity112/orgs","repos_url":"https://api.github.com/users/sumanmaity112/repos","events_url":"https://api.github.com/users/sumanmaity112/events{/privacy}","received_events_url":"https://api.github.com/users/sumanmaity112/received_events","type":"User","site_admin":false},"body":"Hi @krishnanspace, Remove the empty line","created_at":"2018-05-11T12:42:11Z","updated_at":"2018-05-11T12:42:11Z","html_url":"https://github.com/Bahmni/openmrs-module-bahmniapps/pull/157#discussion_r187602209","pull_request_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/pulls/157","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/pulls/comments/187602209"},"html":{"href":"https://github.com/Bahmni/openmrs-module-bahmniapps/pull/157#discussion_r187602209"},"pull_request":{"href":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/pulls/157"}}},"pull_request":{"url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/pulls/157","id":186262783,"html_url":"https://github.com/Bahmni/openmrs-module-bahmniapps/pull/157","diff_url":"https://github.com/Bahmni/openmrs-module-bahmniapps/pull/157.diff","patch_url":"https://github.com/Bahmni/openmrs-module-bahmniapps/pull/157.patch","issue_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/issues/157","number":157,"state":"open","locked":false,"title":"BAH-462: Need not call API to fetch appointments when switching views…","user":{"login":"krishnanspace","id":34261449,"avatar_url":"https://avatars3.githubusercontent.com/u/34261449?v=4","gravatar_id":"","url":"https://api.github.com/users/krishnanspace","html_url":"https://github.com/krishnanspace","followers_url":"https://api.github.com/users/krishnanspace/followers","following_url":"https://api.github.com/users/krishnanspace/following{/other_user}","gists_url":"https://api.github.com/users/krishnanspace/gists{/gist_id}","starred_url":"https://api.github.com/users/krishnanspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krishnanspace/subscriptions","organizations_url":"https://api.github.com/users/krishnanspace/orgs","repos_url":"https://api.github.com/users/krishnanspace/repos","events_url":"https://api.github.com/users/krishnanspace/events{/privacy}","received_events_url":"https://api.github.com/users/krishnanspace/received_events","type":"User","site_admin":false},"body":"… (list to calendar or vice versa)\r\n\r\nLink to Jira Card: https://bahmni.atlassian.net/browse/BAH-462\r\n\r\n### Changes:\r\n\r\n- A new boolean flag is introduced stating whether appointment data should be re-fetched or not.\r\nNew Appointment data is only fetched when the date is changed and not when the view is changed.\r\n\r\n- Once the appointment data is retrieved the same data is used by both \"List\" and \"Calender\" view.\r\n\r\n- For achieving this,I have stored the appointment data in the `$rootScope` which is then passed as a state param between \"Calender\" and \"List\" View and based on the value of the boolean variable, it is decided whether to use the stored data or call the API again\r\n\r\n-  Time taken while switching between List and Calendar views is significantly lower after achieving the above functionality.\r\n\r\n","created_at":"2018-05-07T06:06:22Z","updated_at":"2018-05-11T12:42:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"164e25dfab7cf285b3d4fc2275981064e24b95c1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/pulls/157/commits","review_comments_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/pulls/157/comments","review_comment_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/issues/157/comments","statuses_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/statuses/fd09027accf60f43d4696065c711a915d8f0e0af","head":{"label":"krishnanspace:BAH-462","ref":"BAH-462","sha":"fd09027accf60f43d4696065c711a915d8f0e0af","user":{"login":"krishnanspace","id":34261449,"avatar_url":"https://avatars3.githubusercontent.com/u/34261449?v=4","gravatar_id":"","url":"https://api.github.com/users/krishnanspace","html_url":"https://github.com/krishnanspace","followers_url":"https://api.github.com/users/krishnanspace/followers","following_url":"https://api.github.com/users/krishnanspace/following{/other_user}","gists_url":"https://api.github.com/users/krishnanspace/gists{/gist_id}","starred_url":"https://api.github.com/users/krishnanspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krishnanspace/subscriptions","organizations_url":"https://api.github.com/users/krishnanspace/orgs","repos_url":"https://api.github.com/users/krishnanspace/repos","events_url":"https://api.github.com/users/krishnanspace/events{/privacy}","received_events_url":"https://api.github.com/users/krishnanspace/received_events","type":"User","site_admin":false},"repo":{"id":128768741,"name":"openmrs-module-bahmniapps","full_name":"krishnanspace/openmrs-module-bahmniapps","owner":{"login":"krishnanspace","id":34261449,"avatar_url":"https://avatars3.githubusercontent.com/u/34261449?v=4","gravatar_id":"","url":"https://api.github.com/users/krishnanspace","html_url":"https://github.com/krishnanspace","followers_url":"https://api.github.com/users/krishnanspace/followers","following_url":"https://api.github.com/users/krishnanspace/following{/other_user}","gists_url":"https://api.github.com/users/krishnanspace/gists{/gist_id}","starred_url":"https://api.github.com/users/krishnanspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krishnanspace/subscriptions","organizations_url":"https://api.github.com/users/krishnanspace/orgs","repos_url":"https://api.github.com/users/krishnanspace/repos","events_url":"https://api.github.com/users/krishnanspace/events{/privacy}","received_events_url":"https://api.github.com/users/krishnanspace/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krishnanspace/openmrs-module-bahmniapps","description":"Angular.JS based UI application that is used by Clinicians and Patient care providers.","fork":true,"url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps","forks_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/forks","keys_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/teams","hooks_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/hooks","issue_events_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/issues/events{/number}","events_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/events","assignees_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/assignees{/user}","branches_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/branches{/branch}","tags_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/tags","blobs_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/git/refs{/sha}","trees_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/statuses/{sha}","languages_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/languages","stargazers_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/stargazers","contributors_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/contributors","subscribers_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/subscribers","subscription_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/subscription","commits_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/commits{/sha}","git_commits_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/git/commits{/sha}","comments_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/comments{/number}","issue_comment_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/issues/comments{/number}","contents_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/contents/{+path}","compare_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/merges","archive_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/downloads","issues_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/issues{/number}","pulls_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/pulls{/number}","milestones_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/milestones{/number}","notifications_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/labels{/name}","releases_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/releases{/id}","deployments_url":"https://api.github.com/repos/krishnanspace/openmrs-module-bahmniapps/deployments","created_at":"2018-04-09T12:32:42Z","updated_at":"2018-04-09T12:32:47Z","pushed_at":"2018-05-09T06:05:04Z","git_url":"git://github.com/krishnanspace/openmrs-module-bahmniapps.git","ssh_url":"git@github.com:krishnanspace/openmrs-module-bahmniapps.git","clone_url":"https://github.com/krishnanspace/openmrs-module-bahmniapps.git","svn_url":"https://github.com/krishnanspace/openmrs-module-bahmniapps","homepage":"http://www.bahmni.org","size":23869,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Bahmni:master","ref":"master","sha":"7b9c4df17c94320158ef2a76a7b1eb3b6ff6281a","user":{"login":"Bahmni","id":3725098,"avatar_url":"https://avatars0.githubusercontent.com/u/3725098?v=4","gravatar_id":"","url":"https://api.github.com/users/Bahmni","html_url":"https://github.com/Bahmni","followers_url":"https://api.github.com/users/Bahmni/followers","following_url":"https://api.github.com/users/Bahmni/following{/other_user}","gists_url":"https://api.github.com/users/Bahmni/gists{/gist_id}","starred_url":"https://api.github.com/users/Bahmni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bahmni/subscriptions","organizations_url":"https://api.github.com/users/Bahmni/orgs","repos_url":"https://api.github.com/users/Bahmni/repos","events_url":"https://api.github.com/users/Bahmni/events{/privacy}","received_events_url":"https://api.github.com/users/Bahmni/received_events","type":"Organization","site_admin":false},"repo":{"id":10353788,"name":"openmrs-module-bahmniapps","full_name":"Bahmni/openmrs-module-bahmniapps","owner":{"login":"Bahmni","id":3725098,"avatar_url":"https://avatars0.githubusercontent.com/u/3725098?v=4","gravatar_id":"","url":"https://api.github.com/users/Bahmni","html_url":"https://github.com/Bahmni","followers_url":"https://api.github.com/users/Bahmni/followers","following_url":"https://api.github.com/users/Bahmni/following{/other_user}","gists_url":"https://api.github.com/users/Bahmni/gists{/gist_id}","starred_url":"https://api.github.com/users/Bahmni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bahmni/subscriptions","organizations_url":"https://api.github.com/users/Bahmni/orgs","repos_url":"https://api.github.com/users/Bahmni/repos","events_url":"https://api.github.com/users/Bahmni/events{/privacy}","received_events_url":"https://api.github.com/users/Bahmni/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Bahmni/openmrs-module-bahmniapps","description":"Angular.JS based UI application that is used by Clinicians and Patient care providers.","fork":false,"url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps","forks_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/forks","keys_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/teams","hooks_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/hooks","issue_events_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/issues/events{/number}","events_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/events","assignees_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/assignees{/user}","branches_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/branches{/branch}","tags_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/tags","blobs_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/statuses/{sha}","languages_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/languages","stargazers_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/stargazers","contributors_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/contributors","subscribers_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/subscribers","subscription_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/subscription","commits_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/issues/comments{/number}","contents_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/contents/{+path}","compare_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/merges","archive_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/downloads","issues_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/issues{/number}","pulls_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/pulls{/number}","milestones_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/milestones{/number}","notifications_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/labels{/name}","releases_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/releases{/id}","deployments_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/deployments","created_at":"2013-05-29T06:57:42Z","updated_at":"2018-05-10T03:43:42Z","pushed_at":"2018-05-10T12:00:14Z","git_url":"git://github.com/Bahmni/openmrs-module-bahmniapps.git","ssh_url":"git@github.com:Bahmni/openmrs-module-bahmniapps.git","clone_url":"https://github.com/Bahmni/openmrs-module-bahmniapps.git","svn_url":"https://github.com/Bahmni/openmrs-module-bahmniapps","homepage":"http://www.bahmni.org","size":23236,"stargazers_count":67,"watchers_count":67,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":111,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":111,"open_issues":25,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/pulls/157"},"html":{"href":"https://github.com/Bahmni/openmrs-module-bahmniapps/pull/157"},"issue":{"href":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/issues/157"},"comments":{"href":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/issues/157/comments"},"review_comments":{"href":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/pulls/157/comments"},"review_comment":{"href":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/pulls/157/commits"},"statuses":{"href":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/statuses/fd09027accf60f43d4696065c711a915d8f0e0af"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sumanmaity112"}}