{"action":"created","comment":{"url":"https://api.github.com/repos/wix/wix-style-react/pulls/comments/194529126","pull_request_review_id":127718688,"id":194529126,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDUyOTEyNg==","diff_hunk":"@@ -63,3 +63,13 @@ open localhost:6006\n     * `wix-style-react/testkit/index.js`\n     * `wix-style-react/testkit/enzyme.js`\n     * `wix-style-react/testkit/protractor.js`\n+\n+## Adding new icon\n+\n+* receive the approval for the new icon from one of the library's UXs [wuwa](https://github.com/wuwa) or [milkyfruit](https://github.com/milkyfruit)\n+* go to [wix-ui](https://github.com/wix/wix-ui) repo to [wix-ui-icons-common](https://github.com/wix/wix-ui/tree/master/packages/wix-ui-icons-common) package\n+* add it to the system icons folder if it's an icon used internally inside a wix-style-react component, or to the general in case it is an icon to be used inside an app\n+* add your icon to correct package folder inside [wix-ui-icons-common](https://github.com/wix/wix-ui/tree/master/packages/wix-ui-icons-common)\n+* create pull request for [wix-ui](https://github.com/wix/wix-ui) with your new icon\n+* after merging your pull request inside [wix-ui](https://github.com/wix/wix-ui), your new icon will automatically appear inside [wix-style-react](https://github.com/wix/wix-style-react) with next wix-style-react release(wix-style-react has automation script, which take all icons from [wix-ui-icons-common](https://github.com/wix/wix-ui/tree/master/packages/wix-ui-icons-common) and proxy them inside [wix-style-react](https://github.com/wix/wix-style-react))\n+* your icon will be available in wix-style-react with such syntax `import MyAwesomeIcon from 'wix-style-react/icons/MyAwesomeIcon'` or `import MyAwesomeIcon from 'wix-style-react/icons/system/MyAwesomeIcon'`","path":"docs/CONTRIBUTING.md","position":13,"original_position":13,"commit_id":"165b62b6320954bc44e7ceddfaa5be5ab0a31aaf","original_commit_id":"165b62b6320954bc44e7ceddfaa5be5ab0a31aaf","user":{"login":"shlomitc","id":6093192,"node_id":"MDQ6VXNlcjYwOTMxOTI=","avatar_url":"https://avatars0.githubusercontent.com/u/6093192?v=4","gravatar_id":"","url":"https://api.github.com/users/shlomitc","html_url":"https://github.com/shlomitc","followers_url":"https://api.github.com/users/shlomitc/followers","following_url":"https://api.github.com/users/shlomitc/following{/other_user}","gists_url":"https://api.github.com/users/shlomitc/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomitc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomitc/subscriptions","organizations_url":"https://api.github.com/users/shlomitc/orgs","repos_url":"https://api.github.com/users/shlomitc/repos","events_url":"https://api.github.com/users/shlomitc/events{/privacy}","received_events_url":"https://api.github.com/users/shlomitc/received_events","type":"User","site_admin":false},"body":"currently should be `new-icons`","created_at":"2018-06-11T20:00:55Z","updated_at":"2018-06-11T20:09:28Z","html_url":"https://github.com/wix/wix-style-react/pull/1774#discussion_r194529126","pull_request_url":"https://api.github.com/repos/wix/wix-style-react/pulls/1774","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/comments/194529126"},"html":{"href":"https://github.com/wix/wix-style-react/pull/1774#discussion_r194529126"},"pull_request":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/1774"}}},"pull_request":{"url":"https://api.github.com/repos/wix/wix-style-react/pulls/1774","id":191492675,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNDkyNjc1","html_url":"https://github.com/wix/wix-style-react/pull/1774","diff_url":"https://github.com/wix/wix-style-react/pull/1774.diff","patch_url":"https://github.com/wix/wix-style-react/pull/1774.patch","issue_url":"https://api.github.com/repos/wix/wix-style-react/issues/1774","number":1774,"state":"open","locked":false,"title":"WIP: <Icons/> - use new set of icons:","user":{"login":"Faradey27","id":6922463,"node_id":"MDQ6VXNlcjY5MjI0NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/6922463?v=4","gravatar_id":"","url":"https://api.github.com/users/Faradey27","html_url":"https://github.com/Faradey27","followers_url":"https://api.github.com/users/Faradey27/followers","following_url":"https://api.github.com/users/Faradey27/following{/other_user}","gists_url":"https://api.github.com/users/Faradey27/gists{/gist_id}","starred_url":"https://api.github.com/users/Faradey27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Faradey27/subscriptions","organizations_url":"https://api.github.com/users/Faradey27/orgs","repos_url":"https://api.github.com/users/Faradey27/repos","events_url":"https://api.github.com/users/Faradey27/events{/privacy}","received_events_url":"https://api.github.com/users/Faradey27/received_events","type":"User","site_admin":false},"body":" Plan of commits:\r\n - [x] created script to proxy wix-ui-icons-common/general icons to wix-style-react/icons folder\r\n - [x] update package.json with new build script and remove old icons\r\n - [x] verify that the recently added icons in WSR are also in wix-ui-icons-common/general\r\n - [x] update icons storybook example\r\n - [x] update and fix all storybooks examples that depend on Icons\r\n - [x] add a icons section in the contribution doc (explain the automated script)\r\n - [x] provide a migration doc. both for consumers and WSR devs\r\n - [x] * create a migration codemod\r\n### What changed\r\n\r\n- Migrated to new icons and new working flow with icons\r\n\r\n\r\n### Why it changed\r\n\r\n- because of wsr-issue\r\n- to improve users and dev experience \r\n\r\n---\r\n\r\n- [ ] Change is tested\r\n- [ ] Change is documented\r\n- [ ] Build is green\r\n- [ ] Change of UX is approved by [wuwa](https://github.com/wuwa) or [milkyfruit](https://github.com/milkyfruit)\r\n\r\n### Thanks for contributing :)\r\n","created_at":"2018-05-30T15:26:04Z","updated_at":"2018-06-11T20:09:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ed6a7110486cad88ec566b971e80bc0166a917c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wix/wix-style-react/pulls/1774/commits","review_comments_url":"https://api.github.com/repos/wix/wix-style-react/pulls/1774/comments","review_comment_url":"https://api.github.com/repos/wix/wix-style-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wix/wix-style-react/issues/1774/comments","statuses_url":"https://api.github.com/repos/wix/wix-style-react/statuses/165b62b6320954bc44e7ceddfaa5be5ab0a31aaf","head":{"label":"Faradey27:next_wsrc-icons-migration","ref":"next_wsrc-icons-migration","sha":"165b62b6320954bc44e7ceddfaa5be5ab0a31aaf","user":{"login":"Faradey27","id":6922463,"node_id":"MDQ6VXNlcjY5MjI0NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/6922463?v=4","gravatar_id":"","url":"https://api.github.com/users/Faradey27","html_url":"https://github.com/Faradey27","followers_url":"https://api.github.com/users/Faradey27/followers","following_url":"https://api.github.com/users/Faradey27/following{/other_user}","gists_url":"https://api.github.com/users/Faradey27/gists{/gist_id}","starred_url":"https://api.github.com/users/Faradey27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Faradey27/subscriptions","organizations_url":"https://api.github.com/users/Faradey27/orgs","repos_url":"https://api.github.com/users/Faradey27/repos","events_url":"https://api.github.com/users/Faradey27/events{/privacy}","received_events_url":"https://api.github.com/users/Faradey27/received_events","type":"User","site_admin":false},"repo":{"id":128111069,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgxMTEwNjk=","name":"wix-style-react","full_name":"Faradey27/wix-style-react","owner":{"login":"Faradey27","id":6922463,"node_id":"MDQ6VXNlcjY5MjI0NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/6922463?v=4","gravatar_id":"","url":"https://api.github.com/users/Faradey27","html_url":"https://github.com/Faradey27","followers_url":"https://api.github.com/users/Faradey27/followers","following_url":"https://api.github.com/users/Faradey27/following{/other_user}","gists_url":"https://api.github.com/users/Faradey27/gists{/gist_id}","starred_url":"https://api.github.com/users/Faradey27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Faradey27/subscriptions","organizations_url":"https://api.github.com/users/Faradey27/orgs","repos_url":"https://api.github.com/users/Faradey27/repos","events_url":"https://api.github.com/users/Faradey27/events{/privacy}","received_events_url":"https://api.github.com/users/Faradey27/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Faradey27/wix-style-react","description":"Common React UI components for all Wix verticals developing in React","fork":true,"url":"https://api.github.com/repos/Faradey27/wix-style-react","forks_url":"https://api.github.com/repos/Faradey27/wix-style-react/forks","keys_url":"https://api.github.com/repos/Faradey27/wix-style-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Faradey27/wix-style-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Faradey27/wix-style-react/teams","hooks_url":"https://api.github.com/repos/Faradey27/wix-style-react/hooks","issue_events_url":"https://api.github.com/repos/Faradey27/wix-style-react/issues/events{/number}","events_url":"https://api.github.com/repos/Faradey27/wix-style-react/events","assignees_url":"https://api.github.com/repos/Faradey27/wix-style-react/assignees{/user}","branches_url":"https://api.github.com/repos/Faradey27/wix-style-react/branches{/branch}","tags_url":"https://api.github.com/repos/Faradey27/wix-style-react/tags","blobs_url":"https://api.github.com/repos/Faradey27/wix-style-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Faradey27/wix-style-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Faradey27/wix-style-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/Faradey27/wix-style-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Faradey27/wix-style-react/statuses/{sha}","languages_url":"https://api.github.com/repos/Faradey27/wix-style-react/languages","stargazers_url":"https://api.github.com/repos/Faradey27/wix-style-react/stargazers","contributors_url":"https://api.github.com/repos/Faradey27/wix-style-react/contributors","subscribers_url":"https://api.github.com/repos/Faradey27/wix-style-react/subscribers","subscription_url":"https://api.github.com/repos/Faradey27/wix-style-react/subscription","commits_url":"https://api.github.com/repos/Faradey27/wix-style-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/Faradey27/wix-style-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/Faradey27/wix-style-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/Faradey27/wix-style-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/Faradey27/wix-style-react/contents/{+path}","compare_url":"https://api.github.com/repos/Faradey27/wix-style-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Faradey27/wix-style-react/merges","archive_url":"https://api.github.com/repos/Faradey27/wix-style-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Faradey27/wix-style-react/downloads","issues_url":"https://api.github.com/repos/Faradey27/wix-style-react/issues{/number}","pulls_url":"https://api.github.com/repos/Faradey27/wix-style-react/pulls{/number}","milestones_url":"https://api.github.com/repos/Faradey27/wix-style-react/milestones{/number}","notifications_url":"https://api.github.com/repos/Faradey27/wix-style-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Faradey27/wix-style-react/labels{/name}","releases_url":"https://api.github.com/repos/Faradey27/wix-style-react/releases{/id}","deployments_url":"https://api.github.com/repos/Faradey27/wix-style-react/deployments","created_at":"2018-04-04T19:28:28Z","updated_at":"2018-06-07T08:19:14Z","pushed_at":"2018-06-11T13:48:39Z","git_url":"git://github.com/Faradey27/wix-style-react.git","ssh_url":"git@github.com:Faradey27/wix-style-react.git","clone_url":"https://github.com/Faradey27/wix-style-react.git","svn_url":"https://github.com/Faradey27/wix-style-react","homepage":"https://wix.github.io/wix-style-react/","size":9010,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wix:master","ref":"master","sha":"46c5cbdb52aa2b35bd3e2a50ea341e7b2eed1bd4","user":{"login":"wix","id":686511,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"repo":{"id":73713311,"node_id":"MDEwOlJlcG9zaXRvcnk3MzcxMzMxMQ==","name":"wix-style-react","full_name":"wix/wix-style-react","owner":{"login":"wix","id":686511,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wix/wix-style-react","description":"Common React UI components for all Wix verticals developing in React","fork":false,"url":"https://api.github.com/repos/wix/wix-style-react","forks_url":"https://api.github.com/repos/wix/wix-style-react/forks","keys_url":"https://api.github.com/repos/wix/wix-style-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wix/wix-style-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wix/wix-style-react/teams","hooks_url":"https://api.github.com/repos/wix/wix-style-react/hooks","issue_events_url":"https://api.github.com/repos/wix/wix-style-react/issues/events{/number}","events_url":"https://api.github.com/repos/wix/wix-style-react/events","assignees_url":"https://api.github.com/repos/wix/wix-style-react/assignees{/user}","branches_url":"https://api.github.com/repos/wix/wix-style-react/branches{/branch}","tags_url":"https://api.github.com/repos/wix/wix-style-react/tags","blobs_url":"https://api.github.com/repos/wix/wix-style-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wix/wix-style-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wix/wix-style-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/wix/wix-style-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wix/wix-style-react/statuses/{sha}","languages_url":"https://api.github.com/repos/wix/wix-style-react/languages","stargazers_url":"https://api.github.com/repos/wix/wix-style-react/stargazers","contributors_url":"https://api.github.com/repos/wix/wix-style-react/contributors","subscribers_url":"https://api.github.com/repos/wix/wix-style-react/subscribers","subscription_url":"https://api.github.com/repos/wix/wix-style-react/subscription","commits_url":"https://api.github.com/repos/wix/wix-style-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/wix/wix-style-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/wix/wix-style-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/wix/wix-style-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/wix/wix-style-react/contents/{+path}","compare_url":"https://api.github.com/repos/wix/wix-style-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wix/wix-style-react/merges","archive_url":"https://api.github.com/repos/wix/wix-style-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wix/wix-style-react/downloads","issues_url":"https://api.github.com/repos/wix/wix-style-react/issues{/number}","pulls_url":"https://api.github.com/repos/wix/wix-style-react/pulls{/number}","milestones_url":"https://api.github.com/repos/wix/wix-style-react/milestones{/number}","notifications_url":"https://api.github.com/repos/wix/wix-style-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wix/wix-style-react/labels{/name}","releases_url":"https://api.github.com/repos/wix/wix-style-react/releases{/id}","deployments_url":"https://api.github.com/repos/wix/wix-style-react/deployments","created_at":"2016-11-14T14:37:00Z","updated_at":"2018-06-11T16:15:24Z","pushed_at":"2018-06-11T18:01:51Z","git_url":"git://github.com/wix/wix-style-react.git","ssh_url":"git@github.com:wix/wix-style-react.git","clone_url":"https://github.com/wix/wix-style-react.git","svn_url":"https://github.com/wix/wix-style-react","homepage":"https://wix-wix-style-react.surge.sh","size":7565,"stargazers_count":287,"watchers_count":287,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":66,"mirror_url":null,"archived":false,"open_issues_count":112,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":66,"open_issues":112,"watchers":287,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/1774"},"html":{"href":"https://github.com/wix/wix-style-react/pull/1774"},"issue":{"href":"https://api.github.com/repos/wix/wix-style-react/issues/1774"},"comments":{"href":"https://api.github.com/repos/wix/wix-style-react/issues/1774/comments"},"review_comments":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/1774/comments"},"review_comment":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/1774/commits"},"statuses":{"href":"https://api.github.com/repos/wix/wix-style-react/statuses/165b62b6320954bc44e7ceddfaa5be5ab0a31aaf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"shlomitc"}}