{"action":"created","comment":{"url":"https://api.github.com/repos/xiph/rav1e/pulls/comments/174396314","pull_request_review_id":103738794,"id":174396314,"diff_hunk":"@@ -275,14 +283,29 @@ fn diff_4x4(dst: &mut [i16; 16], src1: &PlaneSlice, src2: &PlaneSlice) {\n     }\n }\n \n-pub fn write_b(cw: &mut ContextWriter, fi: &FrameInvariants, fs: &mut FrameState, p: usize, bo: &BlockOffset, mode: PredictionMode, tx_type: TxType) {\n+fn has_chroma(bo: &BlockOffset, bsize: BlockSize,\n+                       subsampling_x: usize, subsampling_y: usize) -> bool {\n+    let bw = mi_size_wide[bsize as usize] as u8;\n+    let bh = mi_size_high[bsize as usize] as u8;\n+    let ref_pos = ((bo.x & 0x01) == 1 || (bw & 0x01) == 0 || subsampling_x == 0) &&\n+                  ((bo.y & 0x01) == 1 || (bh & 0x01) == 0 || subsampling_y == 0);\n+\n+    ref_pos\n+}\n+\n+// For a trasnform block,","path":"src/lib.rs","position":72,"original_position":72,"commit_id":"8b27a2c042e3feac5c784f7a88a916c652bce9f1","original_commit_id":"8b27a2c042e3feac5c784f7a88a916c652bce9f1","user":{"login":"lu-zero","id":239012,"avatar_url":"https://avatars1.githubusercontent.com/u/239012?v=4","gravatar_id":"","url":"https://api.github.com/users/lu-zero","html_url":"https://github.com/lu-zero","followers_url":"https://api.github.com/users/lu-zero/followers","following_url":"https://api.github.com/users/lu-zero/following{/other_user}","gists_url":"https://api.github.com/users/lu-zero/gists{/gist_id}","starred_url":"https://api.github.com/users/lu-zero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lu-zero/subscriptions","organizations_url":"https://api.github.com/users/lu-zero/orgs","repos_url":"https://api.github.com/users/lu-zero/repos","events_url":"https://api.github.com/users/lu-zero/events{/privacy}","received_events_url":"https://api.github.com/users/lu-zero/received_events","type":"User","site_admin":false},"body":"Typo ","created_at":"2018-03-14T09:28:25Z","updated_at":"2018-03-14T09:29:19Z","html_url":"https://github.com/xiph/rav1e/pull/123#discussion_r174396314","pull_request_url":"https://api.github.com/repos/xiph/rav1e/pulls/123","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/xiph/rav1e/pulls/comments/174396314"},"html":{"href":"https://github.com/xiph/rav1e/pull/123#discussion_r174396314"},"pull_request":{"href":"https://api.github.com/repos/xiph/rav1e/pulls/123"}}},"pull_request":{"url":"https://api.github.com/repos/xiph/rav1e/pulls/123","id":174861798,"html_url":"https://github.com/xiph/rav1e/pull/123","diff_url":"https://github.com/xiph/rav1e/pull/123.diff","patch_url":"https://github.com/xiph/rav1e/pull/123.patch","issue_url":"https://api.github.com/repos/xiph/rav1e/issues/123","number":123,"state":"open","locked":false,"title":"Enable partition : part 1, split down to 8x8 blocks","user":{"login":"ycho","id":10123259,"avatar_url":"https://avatars3.githubusercontent.com/u/10123259?v=4","gravatar_id":"","url":"https://api.github.com/users/ycho","html_url":"https://github.com/ycho","followers_url":"https://api.github.com/users/ycho/followers","following_url":"https://api.github.com/users/ycho/following{/other_user}","gists_url":"https://api.github.com/users/ycho/gists{/gist_id}","starred_url":"https://api.github.com/users/ycho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ycho/subscriptions","organizations_url":"https://api.github.com/users/ycho/orgs","repos_url":"https://api.github.com/users/ycho/repos","events_url":"https://api.github.com/users/ycho/events{/privacy}","received_events_url":"https://api.github.com/users/ycho/received_events","type":"User","site_admin":false},"body":"This is part 1 of ongoing work of enabling partition encoding.\r\nEvery SuperBlock is partitioned down to 8x8 partitions,\r\nwhere pre-existing RDO mode decision decides intra modes\r\n(among three, DC_PRED, HORZ_PRED. VERT_PRED) for the 8x8 partition.\r\n\r\nIf input image size is not multiple of 8 pixels,\r\nthe coded image is padded to be multiple of 8 pixels in both width and height.\r\n\r\nTEST: subset1 images.\r\n\r\ncargo build --bin rav1e --release\r\nrm test.ivf test_rec.y4m test_dec.y4m\r\n./target/release/rav1e /home/yushin/sequences/subset1-y4m/125_-_Québec_-_Pont_de_Québec_de_nuit_-_Septembre_2009.y4m -o test.ivf  -r test_rec.y4m --quantizer 50\r\n./aom_test/aomdec test.ivf -o test_dec.y4m -v\r\nmpv --keep-open test_dec.y4m &\r\nmpv --keep-open test_rec.y4m &\r\n\r\nKNOWN ISSUES:\r\n1. If SBs on right and bottom frame borders are encoded by 8x8 partiions\r\n   and other SBs are encoded by 64x64 partition sizes, SBs start to corrupt from\r\n   the last SB row.\r\n\r\nTODO:\r\n1. Fix partition down to 4x4 blocks.\r\n2. Fix has_chroma() function.\r\n3  Fix KNOWN ISSUE 1.\r\n4. RDO-based block size decision","created_at":"2018-03-14T06:05:28Z","updated_at":"2018-03-14T09:29:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"310f80240e881cb2fcc010e70bdc06b9623d2c53","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xiph/rav1e/pulls/123/commits","review_comments_url":"https://api.github.com/repos/xiph/rav1e/pulls/123/comments","review_comment_url":"https://api.github.com/repos/xiph/rav1e/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xiph/rav1e/issues/123/comments","statuses_url":"https://api.github.com/repos/xiph/rav1e/statuses/8b27a2c042e3feac5c784f7a88a916c652bce9f1","head":{"label":"ycho:enable_partition_part1","ref":"enable_partition_part1","sha":"8b27a2c042e3feac5c784f7a88a916c652bce9f1","user":{"login":"ycho","id":10123259,"avatar_url":"https://avatars3.githubusercontent.com/u/10123259?v=4","gravatar_id":"","url":"https://api.github.com/users/ycho","html_url":"https://github.com/ycho","followers_url":"https://api.github.com/users/ycho/followers","following_url":"https://api.github.com/users/ycho/following{/other_user}","gists_url":"https://api.github.com/users/ycho/gists{/gist_id}","starred_url":"https://api.github.com/users/ycho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ycho/subscriptions","organizations_url":"https://api.github.com/users/ycho/orgs","repos_url":"https://api.github.com/users/ycho/repos","events_url":"https://api.github.com/users/ycho/events{/privacy}","received_events_url":"https://api.github.com/users/ycho/received_events","type":"User","site_admin":false},"repo":{"id":121545598,"name":"rav1e","full_name":"ycho/rav1e","owner":{"login":"ycho","id":10123259,"avatar_url":"https://avatars3.githubusercontent.com/u/10123259?v=4","gravatar_id":"","url":"https://api.github.com/users/ycho","html_url":"https://github.com/ycho","followers_url":"https://api.github.com/users/ycho/followers","following_url":"https://api.github.com/users/ycho/following{/other_user}","gists_url":"https://api.github.com/users/ycho/gists{/gist_id}","starred_url":"https://api.github.com/users/ycho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ycho/subscriptions","organizations_url":"https://api.github.com/users/ycho/orgs","repos_url":"https://api.github.com/users/ycho/repos","events_url":"https://api.github.com/users/ycho/events{/privacy}","received_events_url":"https://api.github.com/users/ycho/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ycho/rav1e","description":"The fastest and safest AV1 encoder.","fork":true,"url":"https://api.github.com/repos/ycho/rav1e","forks_url":"https://api.github.com/repos/ycho/rav1e/forks","keys_url":"https://api.github.com/repos/ycho/rav1e/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ycho/rav1e/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ycho/rav1e/teams","hooks_url":"https://api.github.com/repos/ycho/rav1e/hooks","issue_events_url":"https://api.github.com/repos/ycho/rav1e/issues/events{/number}","events_url":"https://api.github.com/repos/ycho/rav1e/events","assignees_url":"https://api.github.com/repos/ycho/rav1e/assignees{/user}","branches_url":"https://api.github.com/repos/ycho/rav1e/branches{/branch}","tags_url":"https://api.github.com/repos/ycho/rav1e/tags","blobs_url":"https://api.github.com/repos/ycho/rav1e/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ycho/rav1e/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ycho/rav1e/git/refs{/sha}","trees_url":"https://api.github.com/repos/ycho/rav1e/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ycho/rav1e/statuses/{sha}","languages_url":"https://api.github.com/repos/ycho/rav1e/languages","stargazers_url":"https://api.github.com/repos/ycho/rav1e/stargazers","contributors_url":"https://api.github.com/repos/ycho/rav1e/contributors","subscribers_url":"https://api.github.com/repos/ycho/rav1e/subscribers","subscription_url":"https://api.github.com/repos/ycho/rav1e/subscription","commits_url":"https://api.github.com/repos/ycho/rav1e/commits{/sha}","git_commits_url":"https://api.github.com/repos/ycho/rav1e/git/commits{/sha}","comments_url":"https://api.github.com/repos/ycho/rav1e/comments{/number}","issue_comment_url":"https://api.github.com/repos/ycho/rav1e/issues/comments{/number}","contents_url":"https://api.github.com/repos/ycho/rav1e/contents/{+path}","compare_url":"https://api.github.com/repos/ycho/rav1e/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ycho/rav1e/merges","archive_url":"https://api.github.com/repos/ycho/rav1e/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ycho/rav1e/downloads","issues_url":"https://api.github.com/repos/ycho/rav1e/issues{/number}","pulls_url":"https://api.github.com/repos/ycho/rav1e/pulls{/number}","milestones_url":"https://api.github.com/repos/ycho/rav1e/milestones{/number}","notifications_url":"https://api.github.com/repos/ycho/rav1e/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ycho/rav1e/labels{/name}","releases_url":"https://api.github.com/repos/ycho/rav1e/releases{/id}","deployments_url":"https://api.github.com/repos/ycho/rav1e/deployments","created_at":"2018-02-14T18:26:19Z","updated_at":"2018-03-13T17:56:22Z","pushed_at":"2018-03-14T06:48:41Z","git_url":"git://github.com/ycho/rav1e.git","ssh_url":"git@github.com:ycho/rav1e.git","clone_url":"https://github.com/ycho/rav1e.git","svn_url":"https://github.com/ycho/rav1e","homepage":"","size":788,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xiph:master","ref":"master","sha":"5ce8ef5ca47ff4a24bc0e3e784b2c7ce94359c39","user":{"login":"xiph","id":8365509,"avatar_url":"https://avatars1.githubusercontent.com/u/8365509?v=4","gravatar_id":"","url":"https://api.github.com/users/xiph","html_url":"https://github.com/xiph","followers_url":"https://api.github.com/users/xiph/followers","following_url":"https://api.github.com/users/xiph/following{/other_user}","gists_url":"https://api.github.com/users/xiph/gists{/gist_id}","starred_url":"https://api.github.com/users/xiph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiph/subscriptions","organizations_url":"https://api.github.com/users/xiph/orgs","repos_url":"https://api.github.com/users/xiph/repos","events_url":"https://api.github.com/users/xiph/events{/privacy}","received_events_url":"https://api.github.com/users/xiph/received_events","type":"Organization","site_admin":false},"repo":{"id":104629023,"name":"rav1e","full_name":"xiph/rav1e","owner":{"login":"xiph","id":8365509,"avatar_url":"https://avatars1.githubusercontent.com/u/8365509?v=4","gravatar_id":"","url":"https://api.github.com/users/xiph","html_url":"https://github.com/xiph","followers_url":"https://api.github.com/users/xiph/followers","following_url":"https://api.github.com/users/xiph/following{/other_user}","gists_url":"https://api.github.com/users/xiph/gists{/gist_id}","starred_url":"https://api.github.com/users/xiph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiph/subscriptions","organizations_url":"https://api.github.com/users/xiph/orgs","repos_url":"https://api.github.com/users/xiph/repos","events_url":"https://api.github.com/users/xiph/events{/privacy}","received_events_url":"https://api.github.com/users/xiph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xiph/rav1e","description":"The fastest and safest AV1 encoder.","fork":false,"url":"https://api.github.com/repos/xiph/rav1e","forks_url":"https://api.github.com/repos/xiph/rav1e/forks","keys_url":"https://api.github.com/repos/xiph/rav1e/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xiph/rav1e/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xiph/rav1e/teams","hooks_url":"https://api.github.com/repos/xiph/rav1e/hooks","issue_events_url":"https://api.github.com/repos/xiph/rav1e/issues/events{/number}","events_url":"https://api.github.com/repos/xiph/rav1e/events","assignees_url":"https://api.github.com/repos/xiph/rav1e/assignees{/user}","branches_url":"https://api.github.com/repos/xiph/rav1e/branches{/branch}","tags_url":"https://api.github.com/repos/xiph/rav1e/tags","blobs_url":"https://api.github.com/repos/xiph/rav1e/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xiph/rav1e/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xiph/rav1e/git/refs{/sha}","trees_url":"https://api.github.com/repos/xiph/rav1e/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xiph/rav1e/statuses/{sha}","languages_url":"https://api.github.com/repos/xiph/rav1e/languages","stargazers_url":"https://api.github.com/repos/xiph/rav1e/stargazers","contributors_url":"https://api.github.com/repos/xiph/rav1e/contributors","subscribers_url":"https://api.github.com/repos/xiph/rav1e/subscribers","subscription_url":"https://api.github.com/repos/xiph/rav1e/subscription","commits_url":"https://api.github.com/repos/xiph/rav1e/commits{/sha}","git_commits_url":"https://api.github.com/repos/xiph/rav1e/git/commits{/sha}","comments_url":"https://api.github.com/repos/xiph/rav1e/comments{/number}","issue_comment_url":"https://api.github.com/repos/xiph/rav1e/issues/comments{/number}","contents_url":"https://api.github.com/repos/xiph/rav1e/contents/{+path}","compare_url":"https://api.github.com/repos/xiph/rav1e/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xiph/rav1e/merges","archive_url":"https://api.github.com/repos/xiph/rav1e/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xiph/rav1e/downloads","issues_url":"https://api.github.com/repos/xiph/rav1e/issues{/number}","pulls_url":"https://api.github.com/repos/xiph/rav1e/pulls{/number}","milestones_url":"https://api.github.com/repos/xiph/rav1e/milestones{/number}","notifications_url":"https://api.github.com/repos/xiph/rav1e/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xiph/rav1e/labels{/name}","releases_url":"https://api.github.com/repos/xiph/rav1e/releases{/id}","deployments_url":"https://api.github.com/repos/xiph/rav1e/deployments","created_at":"2017-09-24T08:12:55Z","updated_at":"2018-03-13T18:43:12Z","pushed_at":"2018-03-14T06:48:42Z","git_url":"git://github.com/xiph/rav1e.git","ssh_url":"git@github.com:xiph/rav1e.git","clone_url":"https://github.com/xiph/rav1e.git","svn_url":"https://github.com/xiph/rav1e","homepage":"","size":696,"stargazers_count":44,"watchers_count":44,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":26,"license":null,"forks":11,"open_issues":26,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xiph/rav1e/pulls/123"},"html":{"href":"https://github.com/xiph/rav1e/pull/123"},"issue":{"href":"https://api.github.com/repos/xiph/rav1e/issues/123"},"comments":{"href":"https://api.github.com/repos/xiph/rav1e/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/xiph/rav1e/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/xiph/rav1e/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xiph/rav1e/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/xiph/rav1e/statuses/8b27a2c042e3feac5c784f7a88a916c652bce9f1"}},"author_association":"NONE"}}
{"actor":{"display_login":"lu-zero"}}