{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/51290","repository_url":"https://api.github.com/repos/Microsoft/vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/51290/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/51290/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/51290/events","html_url":"https://github.com/Microsoft/vscode/issues/51290","id":330124696,"node_id":"MDU6SXNzdWUzMzAxMjQ2OTY=","number":51290,"title":"1.24 broke/removed markdown support for base64 data URIs in CompletionItem & Hover ","user":{"login":"Janne252","id":4705573,"node_id":"MDQ6VXNlcjQ3MDU1NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/4705573?v=4","gravatar_id":"","url":"https://api.github.com/users/Janne252","html_url":"https://github.com/Janne252","followers_url":"https://api.github.com/users/Janne252/followers","following_url":"https://api.github.com/users/Janne252/following{/other_user}","gists_url":"https://api.github.com/users/Janne252/gists{/gist_id}","starred_url":"https://api.github.com/users/Janne252/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Janne252/subscriptions","organizations_url":"https://api.github.com/users/Janne252/orgs","repos_url":"https://api.github.com/users/Janne252/repos","events_url":"https://api.github.com/users/Janne252/events{/privacy}","received_events_url":"https://api.github.com/users/Janne252/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"mjbvz","id":12821956,"node_id":"MDQ6VXNlcjEyODIxOTU2","avatar_url":"https://avatars2.githubusercontent.com/u/12821956?v=4","gravatar_id":"","url":"https://api.github.com/users/mjbvz","html_url":"https://github.com/mjbvz","followers_url":"https://api.github.com/users/mjbvz/followers","following_url":"https://api.github.com/users/mjbvz/following{/other_user}","gists_url":"https://api.github.com/users/mjbvz/gists{/gist_id}","starred_url":"https://api.github.com/users/mjbvz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjbvz/subscriptions","organizations_url":"https://api.github.com/users/mjbvz/orgs","repos_url":"https://api.github.com/users/mjbvz/repos","events_url":"https://api.github.com/users/mjbvz/events{/privacy}","received_events_url":"https://api.github.com/users/mjbvz/received_events","type":"User","site_admin":false},"assignees":[{"login":"mjbvz","id":12821956,"node_id":"MDQ6VXNlcjEyODIxOTU2","avatar_url":"https://avatars2.githubusercontent.com/u/12821956?v=4","gravatar_id":"","url":"https://api.github.com/users/mjbvz","html_url":"https://github.com/mjbvz","followers_url":"https://api.github.com/users/mjbvz/followers","following_url":"https://api.github.com/users/mjbvz/following{/other_user}","gists_url":"https://api.github.com/users/mjbvz/gists{/gist_id}","starred_url":"https://api.github.com/users/mjbvz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjbvz/subscriptions","organizations_url":"https://api.github.com/users/mjbvz/orgs","repos_url":"https://api.github.com/users/mjbvz/repos","events_url":"https://api.github.com/users/mjbvz/events{/privacy}","received_events_url":"https://api.github.com/users/mjbvz/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-06-07T05:43:31Z","updated_at":"2018-06-07T07:33:55Z","closed_at":"2018-06-07T06:50:36Z","author_association":"NONE","body":"- VSCode Version: 1.24\r\n- OS Version: Windows 10 Pro 64-bit\r\n\r\nIt would seem that the most recent update broke a feature that I was (ab)using to render images in CompletionItemProvider and HoverProvider: The base64 encoded image is no longer displayed:\r\n![image](https://user-images.githubusercontent.com/4705573/41080227-208fd282-6a2e-11e8-96ae-cefdf4deb1bf.png)\r\n\r\n\r\nIn previous version, it worked like this:\r\n\r\n![gif](/Janne252/vscode-fontawesome-auto-complete/raw/master/video/demo-autocomplete.gif)\r\n\r\nThis functionality can be tested with [vscode-fontawesome-autocomplete](https://github.com/Janne252/vscode-fontawesome-auto-complete)\r\n\r\n1. Install the extension\r\n2. Create a new `.html` file\r\n3. Start typing `fa` and browse the auto-completion items. Expand the documentation by clicking the blue `i` button if necessary. \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/comments/395322461","html_url":"https://github.com/Microsoft/vscode/issues/51290#issuecomment-395322461","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/51290","id":395322461,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTMyMjQ2MQ==","user":{"login":"Janne252","id":4705573,"node_id":"MDQ6VXNlcjQ3MDU1NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/4705573?v=4","gravatar_id":"","url":"https://api.github.com/users/Janne252","html_url":"https://github.com/Janne252","followers_url":"https://api.github.com/users/Janne252/followers","following_url":"https://api.github.com/users/Janne252/following{/other_user}","gists_url":"https://api.github.com/users/Janne252/gists{/gist_id}","starred_url":"https://api.github.com/users/Janne252/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Janne252/subscriptions","organizations_url":"https://api.github.com/users/Janne252/orgs","repos_url":"https://api.github.com/users/Janne252/repos","events_url":"https://api.github.com/users/Janne252/events{/privacy}","received_events_url":"https://api.github.com/users/Janne252/received_events","type":"User","site_admin":false},"created_at":"2018-06-07T07:33:55Z","updated_at":"2018-06-07T07:33:55Z","author_association":"NONE","body":"@mjbvz Thanks for the quick response, base64 encoding the image data indeed fixed the issue.\r\n\r\nOff-topic note:\r\nI guess the markdown rendering engine was updated? Not really an issue but it seems that tables no longer render properly if the heading row cells only consist of spaces. Apparently adding a `&nbsp;` to the first header cell fixes that. \r\n\r\n"}}
{"actor":{"display_login":"Janne252"}}