{"action":"created","comment":{"url":"https://api.github.com/repos/dlang/tools/pulls/comments/166169644","pull_request_review_id":94206744,"id":166169644,"diff_hunk":"@@ -916,3 +898,78 @@ void yap(size_t line = __LINE__, T...)(auto ref T stuff)\n     debug stderr.writeln(line, \": \", stuff);\n     else stderr.writeln(stuff);\n }\n+\n+struct FileAttributes\n+{\n+    uint attributes;\n+    bool exists() const { return attributes != 0xFFFFFFFF; }\n+    bool isFile() const\n+        in { assert(exists); } do\n+    {\n+        import std.file : attrIsFile;\n+        return attrIsFile(attributes);\n+    }\n+}\n+\n+struct Yap\n+{","path":"rdmd.d","position":223,"original_position":223,"commit_id":"93a79b89e356dead6a3e7f9f9e62e7d6b1cc1781","original_commit_id":"93a79b89e356dead6a3e7f9f9e62e7d6b1cc1781","user":{"login":"CyberShadow","id":160894,"avatar_url":"https://avatars0.githubusercontent.com/u/160894?v=4","gravatar_id":"","url":"https://api.github.com/users/CyberShadow","html_url":"https://github.com/CyberShadow","followers_url":"https://api.github.com/users/CyberShadow/followers","following_url":"https://api.github.com/users/CyberShadow/following{/other_user}","gists_url":"https://api.github.com/users/CyberShadow/gists{/gist_id}","starred_url":"https://api.github.com/users/CyberShadow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyberShadow/subscriptions","organizations_url":"https://api.github.com/users/CyberShadow/orgs","repos_url":"https://api.github.com/users/CyberShadow/repos","events_url":"https://api.github.com/users/CyberShadow/events{/privacy}","received_events_url":"https://api.github.com/users/CyberShadow/received_events","type":"User","site_admin":false},"body":"Move `std.file` imports here. That way, it will not be possible to accidentally use `std.file` functions bypassing logging.","created_at":"2018-02-06T02:06:47Z","updated_at":"2018-02-06T02:11:39Z","html_url":"https://github.com/dlang/tools/pull/295#discussion_r166169644","pull_request_url":"https://api.github.com/repos/dlang/tools/pulls/295","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/dlang/tools/pulls/comments/166169644"},"html":{"href":"https://github.com/dlang/tools/pull/295#discussion_r166169644"},"pull_request":{"href":"https://api.github.com/repos/dlang/tools/pulls/295"}}},"pull_request":{"url":"https://api.github.com/repos/dlang/tools/pulls/295","id":164374944,"html_url":"https://github.com/dlang/tools/pull/295","diff_url":"https://github.com/dlang/tools/pull/295.diff","patch_url":"https://github.com/dlang/tools/pull/295.patch","issue_url":"https://api.github.com/repos/dlang/tools/issues/295","number":295,"state":"open","locked":false,"title":"(Option 1) Improve logging accuracy and reduce exists && isFile to 1 file query","user":{"login":"marler8997","id":304904,"avatar_url":"https://avatars1.githubusercontent.com/u/304904?v=4","gravatar_id":"","url":"https://api.github.com/users/marler8997","html_url":"https://github.com/marler8997","followers_url":"https://api.github.com/users/marler8997/followers","following_url":"https://api.github.com/users/marler8997/following{/other_user}","gists_url":"https://api.github.com/users/marler8997/gists{/gist_id}","starred_url":"https://api.github.com/users/marler8997/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marler8997/subscriptions","organizations_url":"https://api.github.com/users/marler8997/orgs","repos_url":"https://api.github.com/users/marler8997/repos","events_url":"https://api.github.com/users/marler8997/events{/privacy}","received_events_url":"https://api.github.com/users/marler8997/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-01-22T17:56:32Z","updated_at":"2018-02-06T02:11:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8bf67a6275efcc50793636366dd55c34635fc3d6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/dlang/tools/pulls/295/commits","review_comments_url":"https://api.github.com/repos/dlang/tools/pulls/295/comments","review_comment_url":"https://api.github.com/repos/dlang/tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dlang/tools/issues/295/comments","statuses_url":"https://api.github.com/repos/dlang/tools/statuses/93a79b89e356dead6a3e7f9f9e62e7d6b1cc1781","head":{"label":"marler8997:rdmdOneFileCheck","ref":"rdmdOneFileCheck","sha":"93a79b89e356dead6a3e7f9f9e62e7d6b1cc1781","user":{"login":"marler8997","id":304904,"avatar_url":"https://avatars1.githubusercontent.com/u/304904?v=4","gravatar_id":"","url":"https://api.github.com/users/marler8997","html_url":"https://github.com/marler8997","followers_url":"https://api.github.com/users/marler8997/followers","following_url":"https://api.github.com/users/marler8997/following{/other_user}","gists_url":"https://api.github.com/users/marler8997/gists{/gist_id}","starred_url":"https://api.github.com/users/marler8997/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marler8997/subscriptions","organizations_url":"https://api.github.com/users/marler8997/orgs","repos_url":"https://api.github.com/users/marler8997/repos","events_url":"https://api.github.com/users/marler8997/events{/privacy}","received_events_url":"https://api.github.com/users/marler8997/received_events","type":"User","site_admin":false},"repo":{"id":113237027,"name":"tools","full_name":"marler8997/tools","owner":{"login":"marler8997","id":304904,"avatar_url":"https://avatars1.githubusercontent.com/u/304904?v=4","gravatar_id":"","url":"https://api.github.com/users/marler8997","html_url":"https://github.com/marler8997","followers_url":"https://api.github.com/users/marler8997/followers","following_url":"https://api.github.com/users/marler8997/following{/other_user}","gists_url":"https://api.github.com/users/marler8997/gists{/gist_id}","starred_url":"https://api.github.com/users/marler8997/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marler8997/subscriptions","organizations_url":"https://api.github.com/users/marler8997/orgs","repos_url":"https://api.github.com/users/marler8997/repos","events_url":"https://api.github.com/users/marler8997/events{/privacy}","received_events_url":"https://api.github.com/users/marler8997/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marler8997/tools","description":"Ancillary tools for the D programming language compiler","fork":true,"url":"https://api.github.com/repos/marler8997/tools","forks_url":"https://api.github.com/repos/marler8997/tools/forks","keys_url":"https://api.github.com/repos/marler8997/tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marler8997/tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marler8997/tools/teams","hooks_url":"https://api.github.com/repos/marler8997/tools/hooks","issue_events_url":"https://api.github.com/repos/marler8997/tools/issues/events{/number}","events_url":"https://api.github.com/repos/marler8997/tools/events","assignees_url":"https://api.github.com/repos/marler8997/tools/assignees{/user}","branches_url":"https://api.github.com/repos/marler8997/tools/branches{/branch}","tags_url":"https://api.github.com/repos/marler8997/tools/tags","blobs_url":"https://api.github.com/repos/marler8997/tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marler8997/tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marler8997/tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/marler8997/tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marler8997/tools/statuses/{sha}","languages_url":"https://api.github.com/repos/marler8997/tools/languages","stargazers_url":"https://api.github.com/repos/marler8997/tools/stargazers","contributors_url":"https://api.github.com/repos/marler8997/tools/contributors","subscribers_url":"https://api.github.com/repos/marler8997/tools/subscribers","subscription_url":"https://api.github.com/repos/marler8997/tools/subscription","commits_url":"https://api.github.com/repos/marler8997/tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/marler8997/tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/marler8997/tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/marler8997/tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/marler8997/tools/contents/{+path}","compare_url":"https://api.github.com/repos/marler8997/tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marler8997/tools/merges","archive_url":"https://api.github.com/repos/marler8997/tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marler8997/tools/downloads","issues_url":"https://api.github.com/repos/marler8997/tools/issues{/number}","pulls_url":"https://api.github.com/repos/marler8997/tools/pulls{/number}","milestones_url":"https://api.github.com/repos/marler8997/tools/milestones{/number}","notifications_url":"https://api.github.com/repos/marler8997/tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marler8997/tools/labels{/name}","releases_url":"https://api.github.com/repos/marler8997/tools/releases{/id}","deployments_url":"https://api.github.com/repos/marler8997/tools/deployments","created_at":"2017-12-05T21:53:02Z","updated_at":"2017-12-05T21:53:04Z","pushed_at":"2018-02-03T15:55:20Z","git_url":"git://github.com/marler8997/tools.git","ssh_url":"git@github.com:marler8997/tools.git","clone_url":"https://github.com/marler8997/tools.git","svn_url":"https://github.com/marler8997/tools","homepage":"http://dlang.org","size":696,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dlang:master","ref":"master","sha":"6840d414487a12b2909c59428bb4cdf1324f83e3","user":{"login":"dlang","id":565913,"avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"repo":{"id":1262864,"name":"tools","full_name":"dlang/tools","owner":{"login":"dlang","id":565913,"avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dlang/tools","description":"Ancillary tools for the D programming language compiler","fork":false,"url":"https://api.github.com/repos/dlang/tools","forks_url":"https://api.github.com/repos/dlang/tools/forks","keys_url":"https://api.github.com/repos/dlang/tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlang/tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlang/tools/teams","hooks_url":"https://api.github.com/repos/dlang/tools/hooks","issue_events_url":"https://api.github.com/repos/dlang/tools/issues/events{/number}","events_url":"https://api.github.com/repos/dlang/tools/events","assignees_url":"https://api.github.com/repos/dlang/tools/assignees{/user}","branches_url":"https://api.github.com/repos/dlang/tools/branches{/branch}","tags_url":"https://api.github.com/repos/dlang/tools/tags","blobs_url":"https://api.github.com/repos/dlang/tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlang/tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlang/tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlang/tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlang/tools/statuses/{sha}","languages_url":"https://api.github.com/repos/dlang/tools/languages","stargazers_url":"https://api.github.com/repos/dlang/tools/stargazers","contributors_url":"https://api.github.com/repos/dlang/tools/contributors","subscribers_url":"https://api.github.com/repos/dlang/tools/subscribers","subscription_url":"https://api.github.com/repos/dlang/tools/subscription","commits_url":"https://api.github.com/repos/dlang/tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlang/tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlang/tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlang/tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlang/tools/contents/{+path}","compare_url":"https://api.github.com/repos/dlang/tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlang/tools/merges","archive_url":"https://api.github.com/repos/dlang/tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlang/tools/downloads","issues_url":"https://api.github.com/repos/dlang/tools/issues{/number}","pulls_url":"https://api.github.com/repos/dlang/tools/pulls{/number}","milestones_url":"https://api.github.com/repos/dlang/tools/milestones{/number}","notifications_url":"https://api.github.com/repos/dlang/tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlang/tools/labels{/name}","releases_url":"https://api.github.com/repos/dlang/tools/releases{/id}","deployments_url":"https://api.github.com/repos/dlang/tools/deployments","created_at":"2011-01-17T09:07:05Z","updated_at":"2018-01-31T22:14:03Z","pushed_at":"2018-02-06T02:03:38Z","git_url":"git://github.com/dlang/tools.git","ssh_url":"git@github.com:dlang/tools.git","clone_url":"https://github.com/dlang/tools.git","svn_url":"https://github.com/dlang/tools","homepage":"http://dlang.org","size":688,"stargazers_count":124,"watchers_count":124,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":110,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0"},"forks":110,"open_issues":6,"watchers":124,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dlang/tools/pulls/295"},"html":{"href":"https://github.com/dlang/tools/pull/295"},"issue":{"href":"https://api.github.com/repos/dlang/tools/issues/295"},"comments":{"href":"https://api.github.com/repos/dlang/tools/issues/295/comments"},"review_comments":{"href":"https://api.github.com/repos/dlang/tools/pulls/295/comments"},"review_comment":{"href":"https://api.github.com/repos/dlang/tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dlang/tools/pulls/295/commits"},"statuses":{"href":"https://api.github.com/repos/dlang/tools/statuses/93a79b89e356dead6a3e7f9f9e62e7d6b1cc1781"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"CyberShadow"}}