{"action":"created","comment":{"url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/pulls/comments/196917945","pull_request_review_id":130559044,"id":196917945,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjkxNzk0NQ==","diff_hunk":"@@ -0,0 +1,32 @@\n+using System.Net;\n+using System.Net.Http.Headers;\n+using System.Threading.Tasks;\n+\n+namespace Faithlife.WebRequests.Json\n+{\n+\t/// <summary>\n+\t/// AutoWebServiceRequest responses with an explicitly set status code. \n+\t/// </summary>\n+\tpublic abstract class ExplicitStatusResponse : AutoWebServiceResponse","path":"src/Faithlife.WebRequests/Json/ExplicitStatusResponse.cs","position":10,"original_position":10,"commit_id":"7b3f72e08fa63d22ba66f8f429b0b04d73c8499b","original_commit_id":"7b3f72e08fa63d22ba66f8f429b0b04d73c8499b","user":{"login":"michael-sterling","id":28580758,"node_id":"MDQ6VXNlcjI4NTgwNzU4","avatar_url":"https://avatars2.githubusercontent.com/u/28580758?v=4","gravatar_id":"","url":"https://api.github.com/users/michael-sterling","html_url":"https://github.com/michael-sterling","followers_url":"https://api.github.com/users/michael-sterling/followers","following_url":"https://api.github.com/users/michael-sterling/following{/other_user}","gists_url":"https://api.github.com/users/michael-sterling/gists{/gist_id}","starred_url":"https://api.github.com/users/michael-sterling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michael-sterling/subscriptions","organizations_url":"https://api.github.com/users/michael-sterling/orgs","repos_url":"https://api.github.com/users/michael-sterling/repos","events_url":"https://api.github.com/users/michael-sterling/events{/privacy}","received_events_url":"https://api.github.com/users/michael-sterling/received_events","type":"User","site_admin":false},"body":"This base class is useful for writing a library of client aspects that can operate on any response type. The aspect necessary for the current use-case is for an AuthenticationLostHandler that mirrors [this WebCommon code](https://git/Logos/WebCommon/blob/nuget/src/Logos.Common.Authentication/AuthenticationLostUtility.cs#L7-L12).\r\n\r\nWe could put this base-class inside whatever library wants to contain the stable of extensions, but then what if I've got two libraries I want to use? C# doesn't do multiple-inheritance well, so now I've probably got an interface for each library, and I need to know at client-package-publish time which libraries my consumer will want to use.\r\n\r\nAt the point where this class adds very little burden on `Faithlife.WebRequests`, and enhances it in some ways by making clear a use-case for the `StatusCode` magic, I see enough benefit to keep it around.\r\n\r\nDo you have any objections other than the mentioned YAGNI?","created_at":"2018-06-20T19:41:24Z","updated_at":"2018-06-20T19:41:25Z","html_url":"https://github.com/Faithlife/FaithlifeWebRequests/pull/11#discussion_r196917945","pull_request_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/pulls/11","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/pulls/comments/196917945"},"html":{"href":"https://github.com/Faithlife/FaithlifeWebRequests/pull/11#discussion_r196917945"},"pull_request":{"href":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/pulls/11"}},"in_reply_to_id":196909434},"pull_request":{"url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/pulls/11","id":196235410,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MjM1NDEw","html_url":"https://github.com/Faithlife/FaithlifeWebRequests/pull/11","diff_url":"https://github.com/Faithlife/FaithlifeWebRequests/pull/11.diff","patch_url":"https://github.com/Faithlife/FaithlifeWebRequests/pull/11.patch","issue_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/issues/11","number":11,"state":"open","locked":false,"title":"Return status codes explicitly if the response type expects it.","user":{"login":"tobs1701","id":2482021,"node_id":"MDQ6VXNlcjI0ODIwMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/2482021?v=4","gravatar_id":"","url":"https://api.github.com/users/tobs1701","html_url":"https://github.com/tobs1701","followers_url":"https://api.github.com/users/tobs1701/followers","following_url":"https://api.github.com/users/tobs1701/following{/other_user}","gists_url":"https://api.github.com/users/tobs1701/gists{/gist_id}","starred_url":"https://api.github.com/users/tobs1701/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobs1701/subscriptions","organizations_url":"https://api.github.com/users/tobs1701/orgs","repos_url":"https://api.github.com/users/tobs1701/repos","events_url":"https://api.github.com/users/tobs1701/events{/privacy}","received_events_url":"https://api.github.com/users/tobs1701/received_events","type":"User","site_admin":false},"body":"Handle any status code without mandating a property be specifically named for the status code on a response object. This change will give us greater flexibility when guaranteeing successful authentication or the existence of certain headers on the response. \r\n\r\ncc @ejball --I don't appear to have permissions to assign this to you.","created_at":"2018-06-20T18:35:43Z","updated_at":"2018-06-20T19:41:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"632b555c79cba1316ad23cdde4b9bfa64f2fd9b7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/pulls/11/commits","review_comments_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/pulls/11/comments","review_comment_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/issues/11/comments","statuses_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/statuses/7b3f72e08fa63d22ba66f8f429b0b04d73c8499b","head":{"label":"tobs1701:return_status_codes_explicitly","ref":"return_status_codes_explicitly","sha":"7b3f72e08fa63d22ba66f8f429b0b04d73c8499b","user":{"login":"tobs1701","id":2482021,"node_id":"MDQ6VXNlcjI0ODIwMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/2482021?v=4","gravatar_id":"","url":"https://api.github.com/users/tobs1701","html_url":"https://github.com/tobs1701","followers_url":"https://api.github.com/users/tobs1701/followers","following_url":"https://api.github.com/users/tobs1701/following{/other_user}","gists_url":"https://api.github.com/users/tobs1701/gists{/gist_id}","starred_url":"https://api.github.com/users/tobs1701/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobs1701/subscriptions","organizations_url":"https://api.github.com/users/tobs1701/orgs","repos_url":"https://api.github.com/users/tobs1701/repos","events_url":"https://api.github.com/users/tobs1701/events{/privacy}","received_events_url":"https://api.github.com/users/tobs1701/received_events","type":"User","site_admin":false},"repo":{"id":136654258,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY2NTQyNTg=","name":"FaithlifeWebRequests","full_name":"tobs1701/FaithlifeWebRequests","owner":{"login":"tobs1701","id":2482021,"node_id":"MDQ6VXNlcjI0ODIwMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/2482021?v=4","gravatar_id":"","url":"https://api.github.com/users/tobs1701","html_url":"https://github.com/tobs1701","followers_url":"https://api.github.com/users/tobs1701/followers","following_url":"https://api.github.com/users/tobs1701/following{/other_user}","gists_url":"https://api.github.com/users/tobs1701/gists{/gist_id}","starred_url":"https://api.github.com/users/tobs1701/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobs1701/subscriptions","organizations_url":"https://api.github.com/users/tobs1701/orgs","repos_url":"https://api.github.com/users/tobs1701/repos","events_url":"https://api.github.com/users/tobs1701/events{/privacy}","received_events_url":"https://api.github.com/users/tobs1701/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tobs1701/FaithlifeWebRequests","description":"Client code for making strongly-typed web service requests","fork":true,"url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests","forks_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/forks","keys_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/teams","hooks_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/hooks","issue_events_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/issues/events{/number}","events_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/events","assignees_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/assignees{/user}","branches_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/branches{/branch}","tags_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/tags","blobs_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/git/refs{/sha}","trees_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/statuses/{sha}","languages_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/languages","stargazers_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/stargazers","contributors_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/contributors","subscribers_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/subscribers","subscription_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/subscription","commits_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/commits{/sha}","git_commits_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/git/commits{/sha}","comments_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/comments{/number}","issue_comment_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/issues/comments{/number}","contents_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/contents/{+path}","compare_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/merges","archive_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/downloads","issues_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/issues{/number}","pulls_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/pulls{/number}","milestones_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/milestones{/number}","notifications_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/labels{/name}","releases_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/releases{/id}","deployments_url":"https://api.github.com/repos/tobs1701/FaithlifeWebRequests/deployments","created_at":"2018-06-08T18:40:10Z","updated_at":"2018-06-08T18:40:11Z","pushed_at":"2018-06-20T18:11:04Z","git_url":"git://github.com/tobs1701/FaithlifeWebRequests.git","ssh_url":"git@github.com:tobs1701/FaithlifeWebRequests.git","clone_url":"https://github.com/tobs1701/FaithlifeWebRequests.git","svn_url":"https://github.com/tobs1701/FaithlifeWebRequests","homepage":null,"size":143,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Faithlife:master","ref":"master","sha":"07e42ccfa68eea79ed6d860c4da037004bf60187","user":{"login":"Faithlife","id":7575190,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NzUxOTA=","avatar_url":"https://avatars1.githubusercontent.com/u/7575190?v=4","gravatar_id":"","url":"https://api.github.com/users/Faithlife","html_url":"https://github.com/Faithlife","followers_url":"https://api.github.com/users/Faithlife/followers","following_url":"https://api.github.com/users/Faithlife/following{/other_user}","gists_url":"https://api.github.com/users/Faithlife/gists{/gist_id}","starred_url":"https://api.github.com/users/Faithlife/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Faithlife/subscriptions","organizations_url":"https://api.github.com/users/Faithlife/orgs","repos_url":"https://api.github.com/users/Faithlife/repos","events_url":"https://api.github.com/users/Faithlife/events{/privacy}","received_events_url":"https://api.github.com/users/Faithlife/received_events","type":"Organization","site_admin":false},"repo":{"id":102504986,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI1MDQ5ODY=","name":"FaithlifeWebRequests","full_name":"Faithlife/FaithlifeWebRequests","owner":{"login":"Faithlife","id":7575190,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NzUxOTA=","avatar_url":"https://avatars1.githubusercontent.com/u/7575190?v=4","gravatar_id":"","url":"https://api.github.com/users/Faithlife","html_url":"https://github.com/Faithlife","followers_url":"https://api.github.com/users/Faithlife/followers","following_url":"https://api.github.com/users/Faithlife/following{/other_user}","gists_url":"https://api.github.com/users/Faithlife/gists{/gist_id}","starred_url":"https://api.github.com/users/Faithlife/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Faithlife/subscriptions","organizations_url":"https://api.github.com/users/Faithlife/orgs","repos_url":"https://api.github.com/users/Faithlife/repos","events_url":"https://api.github.com/users/Faithlife/events{/privacy}","received_events_url":"https://api.github.com/users/Faithlife/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Faithlife/FaithlifeWebRequests","description":"Client code for making strongly-typed web service requests","fork":false,"url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests","forks_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/forks","keys_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/teams","hooks_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/hooks","issue_events_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/issues/events{/number}","events_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/events","assignees_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/assignees{/user}","branches_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/branches{/branch}","tags_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/tags","blobs_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/git/refs{/sha}","trees_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/statuses/{sha}","languages_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/languages","stargazers_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/stargazers","contributors_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/contributors","subscribers_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/subscribers","subscription_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/subscription","commits_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/commits{/sha}","git_commits_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/git/commits{/sha}","comments_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/comments{/number}","issue_comment_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/issues/comments{/number}","contents_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/contents/{+path}","compare_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/merges","archive_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/downloads","issues_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/issues{/number}","pulls_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/pulls{/number}","milestones_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/milestones{/number}","notifications_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/labels{/name}","releases_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/releases{/id}","deployments_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/deployments","created_at":"2017-09-05T16:28:43Z","updated_at":"2018-04-28T21:53:06Z","pushed_at":"2018-06-20T18:35:44Z","git_url":"git://github.com/Faithlife/FaithlifeWebRequests.git","ssh_url":"git@github.com:Faithlife/FaithlifeWebRequests.git","clone_url":"https://github.com/Faithlife/FaithlifeWebRequests.git","svn_url":"https://github.com/Faithlife/FaithlifeWebRequests","homepage":null,"size":143,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/pulls/11"},"html":{"href":"https://github.com/Faithlife/FaithlifeWebRequests/pull/11"},"issue":{"href":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/issues/11"},"comments":{"href":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/statuses/7b3f72e08fa63d22ba66f8f429b0b04d73c8499b"}},"author_association":"NONE"}}
{"actor":{"display_login":"michael-sterling"}}