{"action":"created","comment":{"url":"https://api.github.com/repos/metabrainz/picard/pulls/comments/215779141","pull_request_review_id":153122650,"id":215779141,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTc3OTE0MQ==","diff_hunk":"@@ -419,8 +419,9 @@ def _move_additional_files(self, old_filename, new_filename):\n         \"\"\"Move extra files, like playlists...\"\"\"\n         old_path = os.path.dirname(old_filename)\n         new_path = os.path.dirname(new_filename)\n-        patterns = config.setting[\"move_additional_files_pattern\"]\n-        patterns = [string_(p.strip()) for p in patterns.split() if p.strip()]\n+        patterns = [p for p in [p.strip() for p in\n+                                config.setting[\"move_additional_files_pattern\"].split()]\n+                    if p]","path":"picard/file.py","position":35,"original_position":17,"commit_id":"f15d4e1ef4fe667f32a5fd3b28940ebbd0012127","original_commit_id":"98ce56ae054435983ab8244517bfb07fd7f854a4","user":{"login":"samj1912","id":16130816,"node_id":"MDQ6VXNlcjE2MTMwODE2","avatar_url":"https://avatars1.githubusercontent.com/u/16130816?v=4","gravatar_id":"","url":"https://api.github.com/users/samj1912","html_url":"https://github.com/samj1912","followers_url":"https://api.github.com/users/samj1912/followers","following_url":"https://api.github.com/users/samj1912/following{/other_user}","gists_url":"https://api.github.com/users/samj1912/gists{/gist_id}","starred_url":"https://api.github.com/users/samj1912/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samj1912/subscriptions","organizations_url":"https://api.github.com/users/samj1912/orgs","repos_url":"https://api.github.com/users/samj1912/repos","events_url":"https://api.github.com/users/samj1912/events{/privacy}","received_events_url":"https://api.github.com/users/samj1912/received_events","type":"User","site_admin":false},"body":"A very useful case for assignment operator from py3.7 :) ","created_at":"2018-09-06T21:08:40Z","updated_at":"2018-09-06T21:08:41Z","html_url":"https://github.com/metabrainz/picard/pull/958#discussion_r215779141","pull_request_url":"https://api.github.com/repos/metabrainz/picard/pulls/958","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/metabrainz/picard/pulls/comments/215779141"},"html":{"href":"https://github.com/metabrainz/picard/pull/958#discussion_r215779141"},"pull_request":{"href":"https://api.github.com/repos/metabrainz/picard/pulls/958"}},"in_reply_to_id":215757150},"pull_request":{"url":"https://api.github.com/repos/metabrainz/picard/pulls/958","id":213595007,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNTk1MDA3","html_url":"https://github.com/metabrainz/picard/pull/958","diff_url":"https://github.com/metabrainz/picard/pull/958.diff","patch_url":"https://github.com/metabrainz/picard/pull/958.patch","issue_url":"https://api.github.com/repos/metabrainz/picard/issues/958","number":958,"state":"open","locked":false,"title":"Deprecate string_() and related cleanup","user":{"login":"zas","id":151042,"node_id":"MDQ6VXNlcjE1MTA0Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/151042?v=4","gravatar_id":"","url":"https://api.github.com/users/zas","html_url":"https://github.com/zas","followers_url":"https://api.github.com/users/zas/followers","following_url":"https://api.github.com/users/zas/following{/other_user}","gists_url":"https://api.github.com/users/zas/gists{/gist_id}","starred_url":"https://api.github.com/users/zas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zas/subscriptions","organizations_url":"https://api.github.com/users/zas/orgs","repos_url":"https://api.github.com/users/zas/repos","events_url":"https://api.github.com/users/zas/events{/privacy}","received_events_url":"https://api.github.com/users/zas/received_events","type":"User","site_admin":false},"body":"<!--\r\n    Hello! Thanks for submitting a pull request to MusicBrainz Picard. We\r\n    appreciate your time and interest in helping our project!\r\n\r\n    Use this template to help us review your change. Not everything is required,\r\n    depending on your change. Keep or delete what is relevant for your change.\r\n    Remember that it helps us review if you give more helpful info for us to\r\n    understand your change.\r\n\r\n    Ensure that you've read through and followed the Contributing Guidelines, in\r\n    [CONTRIBUTING.md](https://github.com/metabrainz/picard/blob/master/CONTRIBUTING.md).\r\n-->\r\n\r\n# Summary\r\n\r\n<!--\r\n    Update the checkbox with an [x] for the type of contribution you are making.\r\n-->\r\n\r\n* This is a…\r\n    * [ ] Bug fix\r\n    * [ ] Feature addition\r\n    * [x] Refactoring\r\n    * [ ] Minor / simple change (like a typo)\r\n    * [ ] Other\r\n* **Describe this change in 1-2 sentences**:\r\n\r\n# Problem\r\n\r\nAbout string_():\r\n- that's a builtin aliasing `picard.util.convert_to_string()`\r\n- it does 2 tests before eventually returning `str(arg)` plus the call to the method, that's pretty expensive if not strictly needed\r\n- in many cases, it is unneeded or equivalent to `str()`\r\n- explicit calls to conversion functions are better as they don't hide what is going on\r\n- it was introduced in https://github.com/metabrainz/picard/pull/664 to help the move to Python3\r\n\r\n\r\nReferences:\r\nhttps://github.com/metabrainz/picard/pull/945#discussion_r214912848\r\nhttps://github.com/metabrainz/picard/pull/945#issuecomment-418523558\r\n\r\n\r\n# Solution\r\n\r\nUse `str()` or `bytes(arg).decode()` or drop it, depending on the case.\r\n\r\n\r\n# Action\r\n\r\n<!--\r\n    Other than merging your change, do you want / need us to do anything else\r\n    with your change? This could include reviewing a specific part of your PR.\r\n-->\r\n\r\n","created_at":"2018-09-06T12:09:19Z","updated_at":"2018-09-06T21:08:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c9d3f69d9607445caa15c2665d1a5de8c19364a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/metabrainz/picard/pulls/958/commits","review_comments_url":"https://api.github.com/repos/metabrainz/picard/pulls/958/comments","review_comment_url":"https://api.github.com/repos/metabrainz/picard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/metabrainz/picard/issues/958/comments","statuses_url":"https://api.github.com/repos/metabrainz/picard/statuses/f15d4e1ef4fe667f32a5fd3b28940ebbd0012127","head":{"label":"zas:string_cleanup","ref":"string_cleanup","sha":"f15d4e1ef4fe667f32a5fd3b28940ebbd0012127","user":{"login":"zas","id":151042,"node_id":"MDQ6VXNlcjE1MTA0Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/151042?v=4","gravatar_id":"","url":"https://api.github.com/users/zas","html_url":"https://github.com/zas","followers_url":"https://api.github.com/users/zas/followers","following_url":"https://api.github.com/users/zas/following{/other_user}","gists_url":"https://api.github.com/users/zas/gists{/gist_id}","starred_url":"https://api.github.com/users/zas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zas/subscriptions","organizations_url":"https://api.github.com/users/zas/orgs","repos_url":"https://api.github.com/users/zas/repos","events_url":"https://api.github.com/users/zas/events{/privacy}","received_events_url":"https://api.github.com/users/zas/received_events","type":"User","site_admin":false},"repo":{"id":7479305,"node_id":"MDEwOlJlcG9zaXRvcnk3NDc5MzA1","name":"picard","full_name":"zas/picard","owner":{"login":"zas","id":151042,"node_id":"MDQ6VXNlcjE1MTA0Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/151042?v=4","gravatar_id":"","url":"https://api.github.com/users/zas","html_url":"https://github.com/zas","followers_url":"https://api.github.com/users/zas/followers","following_url":"https://api.github.com/users/zas/following{/other_user}","gists_url":"https://api.github.com/users/zas/gists{/gist_id}","starred_url":"https://api.github.com/users/zas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zas/subscriptions","organizations_url":"https://api.github.com/users/zas/orgs","repos_url":"https://api.github.com/users/zas/repos","events_url":"https://api.github.com/users/zas/events{/privacy}","received_events_url":"https://api.github.com/users/zas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zas/picard","description":"MusicBrainz Picard","fork":true,"url":"https://api.github.com/repos/zas/picard","forks_url":"https://api.github.com/repos/zas/picard/forks","keys_url":"https://api.github.com/repos/zas/picard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zas/picard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zas/picard/teams","hooks_url":"https://api.github.com/repos/zas/picard/hooks","issue_events_url":"https://api.github.com/repos/zas/picard/issues/events{/number}","events_url":"https://api.github.com/repos/zas/picard/events","assignees_url":"https://api.github.com/repos/zas/picard/assignees{/user}","branches_url":"https://api.github.com/repos/zas/picard/branches{/branch}","tags_url":"https://api.github.com/repos/zas/picard/tags","blobs_url":"https://api.github.com/repos/zas/picard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zas/picard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zas/picard/git/refs{/sha}","trees_url":"https://api.github.com/repos/zas/picard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zas/picard/statuses/{sha}","languages_url":"https://api.github.com/repos/zas/picard/languages","stargazers_url":"https://api.github.com/repos/zas/picard/stargazers","contributors_url":"https://api.github.com/repos/zas/picard/contributors","subscribers_url":"https://api.github.com/repos/zas/picard/subscribers","subscription_url":"https://api.github.com/repos/zas/picard/subscription","commits_url":"https://api.github.com/repos/zas/picard/commits{/sha}","git_commits_url":"https://api.github.com/repos/zas/picard/git/commits{/sha}","comments_url":"https://api.github.com/repos/zas/picard/comments{/number}","issue_comment_url":"https://api.github.com/repos/zas/picard/issues/comments{/number}","contents_url":"https://api.github.com/repos/zas/picard/contents/{+path}","compare_url":"https://api.github.com/repos/zas/picard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zas/picard/merges","archive_url":"https://api.github.com/repos/zas/picard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zas/picard/downloads","issues_url":"https://api.github.com/repos/zas/picard/issues{/number}","pulls_url":"https://api.github.com/repos/zas/picard/pulls{/number}","milestones_url":"https://api.github.com/repos/zas/picard/milestones{/number}","notifications_url":"https://api.github.com/repos/zas/picard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zas/picard/labels{/name}","releases_url":"https://api.github.com/repos/zas/picard/releases{/id}","deployments_url":"https://api.github.com/repos/zas/picard/deployments","created_at":"2013-01-07T08:45:26Z","updated_at":"2018-05-29T07:44:58Z","pushed_at":"2018-09-06T20:12:01Z","git_url":"git://github.com/zas/picard.git","ssh_url":"git@github.com:zas/picard.git","clone_url":"https://github.com/zas/picard.git","svn_url":"https://github.com/zas/picard","homepage":"http://musicbrainz.org/doc/MusicBrainz_Picard","size":28246,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"metabrainz:master","ref":"master","sha":"0791312e5c12af7f3fa74db03629243976e7af27","user":{"login":"metabrainz","id":293421,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MzQyMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/293421?v=4","gravatar_id":"","url":"https://api.github.com/users/metabrainz","html_url":"https://github.com/metabrainz","followers_url":"https://api.github.com/users/metabrainz/followers","following_url":"https://api.github.com/users/metabrainz/following{/other_user}","gists_url":"https://api.github.com/users/metabrainz/gists{/gist_id}","starred_url":"https://api.github.com/users/metabrainz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metabrainz/subscriptions","organizations_url":"https://api.github.com/users/metabrainz/orgs","repos_url":"https://api.github.com/users/metabrainz/repos","events_url":"https://api.github.com/users/metabrainz/events{/privacy}","received_events_url":"https://api.github.com/users/metabrainz/received_events","type":"Organization","site_admin":false},"repo":{"id":2218679,"node_id":"MDEwOlJlcG9zaXRvcnkyMjE4Njc5","name":"picard","full_name":"metabrainz/picard","owner":{"login":"metabrainz","id":293421,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MzQyMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/293421?v=4","gravatar_id":"","url":"https://api.github.com/users/metabrainz","html_url":"https://github.com/metabrainz","followers_url":"https://api.github.com/users/metabrainz/followers","following_url":"https://api.github.com/users/metabrainz/following{/other_user}","gists_url":"https://api.github.com/users/metabrainz/gists{/gist_id}","starred_url":"https://api.github.com/users/metabrainz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metabrainz/subscriptions","organizations_url":"https://api.github.com/users/metabrainz/orgs","repos_url":"https://api.github.com/users/metabrainz/repos","events_url":"https://api.github.com/users/metabrainz/events{/privacy}","received_events_url":"https://api.github.com/users/metabrainz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metabrainz/picard","description":"MusicBrainz Picard","fork":false,"url":"https://api.github.com/repos/metabrainz/picard","forks_url":"https://api.github.com/repos/metabrainz/picard/forks","keys_url":"https://api.github.com/repos/metabrainz/picard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metabrainz/picard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metabrainz/picard/teams","hooks_url":"https://api.github.com/repos/metabrainz/picard/hooks","issue_events_url":"https://api.github.com/repos/metabrainz/picard/issues/events{/number}","events_url":"https://api.github.com/repos/metabrainz/picard/events","assignees_url":"https://api.github.com/repos/metabrainz/picard/assignees{/user}","branches_url":"https://api.github.com/repos/metabrainz/picard/branches{/branch}","tags_url":"https://api.github.com/repos/metabrainz/picard/tags","blobs_url":"https://api.github.com/repos/metabrainz/picard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metabrainz/picard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metabrainz/picard/git/refs{/sha}","trees_url":"https://api.github.com/repos/metabrainz/picard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metabrainz/picard/statuses/{sha}","languages_url":"https://api.github.com/repos/metabrainz/picard/languages","stargazers_url":"https://api.github.com/repos/metabrainz/picard/stargazers","contributors_url":"https://api.github.com/repos/metabrainz/picard/contributors","subscribers_url":"https://api.github.com/repos/metabrainz/picard/subscribers","subscription_url":"https://api.github.com/repos/metabrainz/picard/subscription","commits_url":"https://api.github.com/repos/metabrainz/picard/commits{/sha}","git_commits_url":"https://api.github.com/repos/metabrainz/picard/git/commits{/sha}","comments_url":"https://api.github.com/repos/metabrainz/picard/comments{/number}","issue_comment_url":"https://api.github.com/repos/metabrainz/picard/issues/comments{/number}","contents_url":"https://api.github.com/repos/metabrainz/picard/contents/{+path}","compare_url":"https://api.github.com/repos/metabrainz/picard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metabrainz/picard/merges","archive_url":"https://api.github.com/repos/metabrainz/picard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metabrainz/picard/downloads","issues_url":"https://api.github.com/repos/metabrainz/picard/issues{/number}","pulls_url":"https://api.github.com/repos/metabrainz/picard/pulls{/number}","milestones_url":"https://api.github.com/repos/metabrainz/picard/milestones{/number}","notifications_url":"https://api.github.com/repos/metabrainz/picard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metabrainz/picard/labels{/name}","releases_url":"https://api.github.com/repos/metabrainz/picard/releases{/id}","deployments_url":"https://api.github.com/repos/metabrainz/picard/deployments","created_at":"2011-08-16T22:30:23Z","updated_at":"2018-09-06T14:51:26Z","pushed_at":"2018-09-06T20:12:03Z","git_url":"git://github.com/metabrainz/picard.git","ssh_url":"git@github.com:metabrainz/picard.git","clone_url":"https://github.com/metabrainz/picard.git","svn_url":"https://github.com/metabrainz/picard","homepage":"https://picard.musicbrainz.org","size":27990,"stargazers_count":1523,"watchers_count":1523,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":238,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":238,"open_issues":4,"watchers":1523,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/metabrainz/picard/pulls/958"},"html":{"href":"https://github.com/metabrainz/picard/pull/958"},"issue":{"href":"https://api.github.com/repos/metabrainz/picard/issues/958"},"comments":{"href":"https://api.github.com/repos/metabrainz/picard/issues/958/comments"},"review_comments":{"href":"https://api.github.com/repos/metabrainz/picard/pulls/958/comments"},"review_comment":{"href":"https://api.github.com/repos/metabrainz/picard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/metabrainz/picard/pulls/958/commits"},"statuses":{"href":"https://api.github.com/repos/metabrainz/picard/statuses/f15d4e1ef4fe667f32a5fd3b28940ebbd0012127"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"samj1912"}}